[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040373#comment-16040373 ] Gary Gregory commented on VFS-438: -- Yes, I suppose that is OK. Thank you for the link. > Please promote vfs-smb currently in the sandbox > --- > > Key: VFS-438 > URL: https://issues.apache.org/jira/browse/VFS-438 > Project: Commons VFS > Issue Type: New Feature >Affects Versions: 2.0 > Environment: windows/unix >Reporter: Dan Tran > > Current smb provider in the sandbox is mature enough to proceed with > promotion out of sandbox for general use. > Detail discussion is here > http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html > The sandbox also tests hookup to current test suite, all we need is to > provide a external URI using VFS test suite instructions. > There are currently 2 classloader specific failures > Tests in error: > testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.ClassToLoad > testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.sealed.AnotherClass > Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 > require cifs 1.3.17 with one line change at > SmbFileObject.java line number 227 to > if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040346#comment-16040346 ] Christoph Obexer commented on VFS-438: -- According to http://www.apache.org/licenses/LICENSE-2.0#apply that is how you are supposed to use the Apache license?! > Please promote vfs-smb currently in the sandbox > --- > > Key: VFS-438 > URL: https://issues.apache.org/jira/browse/VFS-438 > Project: Commons VFS > Issue Type: New Feature >Affects Versions: 2.0 > Environment: windows/unix >Reporter: Dan Tran > > Current smb provider in the sandbox is mature enough to proceed with > promotion out of sandbox for general use. > Detail discussion is here > http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html > The sandbox also tests hookup to current test suite, all we need is to > provide a external URI using VFS test suite instructions. > There are currently 2 classloader specific failures > Tests in error: > testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.ClassToLoad > testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.sealed.AnotherClass > Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 > require cifs 1.3.17 with one line change at > SmbFileObject.java line number 227 to > if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036014#comment-16036014 ] Gary Gregory commented on VFS-438: -- Hi All, We welcome patches ;-) WRT https://github.com/hierynomus/smbj/blob/master/LICENSE_HEADER IANAL but I am not sure it is OK or not for us to link to a project that has a Copyright statement on top of the Apache license. That would be the first thing I would ask on legal@ Gary > Please promote vfs-smb currently in the sandbox > --- > > Key: VFS-438 > URL: https://issues.apache.org/jira/browse/VFS-438 > Project: Commons VFS > Issue Type: New Feature >Affects Versions: 2.0 > Environment: windows/unix >Reporter: Dan Tran > > Current smb provider in the sandbox is mature enough to proceed with > promotion out of sandbox for general use. > Detail discussion is here > http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html > The sandbox also tests hookup to current test suite, all we need is to > provide a external URI using VFS test suite instructions. > There are currently 2 classloader specific failures > Tests in error: > testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.ClassToLoad > testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.sealed.AnotherClass > Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 > require cifs 1.3.17 with one line change at > SmbFileObject.java line number 227 to > if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035980#comment-16035980 ] Christoph Obexer commented on VFS-438: -- There appears to be an Apache licensed implementation: https://github.com/hierynomus/smbj as noted on VFS-635 Please also note that SMBv1 as supported by jCIFS is considered bad by Microsoft: https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/ Maybe it's best to drop the current jCIFS based implementation from the sandbox and instead provide a smbj based implementation as a separate maven artifact. > Please promote vfs-smb currently in the sandbox > --- > > Key: VFS-438 > URL: https://issues.apache.org/jira/browse/VFS-438 > Project: Commons VFS > Issue Type: New Feature >Affects Versions: 2.0 > Environment: windows/unix >Reporter: Dan Tran > > Current smb provider in the sandbox is mature enough to proceed with > promotion out of sandbox for general use. > Detail discussion is here > http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html > The sandbox also tests hookup to current test suite, all we need is to > provide a external URI using VFS test suite instructions. > There are currently 2 classloader specific failures > Tests in error: > testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.ClassToLoad > testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): > code.sealed.AnotherClass > Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 > require cifs 1.3.17 with one line change at > SmbFileObject.java line number 227 to > if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231326#comment-14231326 ] Sebb commented on VFS-438: -- Yes, optional may solve the issue for run-time users of the binary artifacts. But that is not the only issue here. The ASF publishes source. It must be possible for users to download and build the VFS source without pulling in code that is not AL licensed. This needs to be the default behaviour. It is vital that the build does not incorporate non-AL code unless the builder specifically agrees to it. Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230205#comment-14230205 ] Sebb commented on VFS-438: -- Please note: the JCIFS library is LGPL, so cannot be included in any releases of VFS. It is permissible to depend on a LGPL library, but that dependency must be completely optional, and the product must be usable without it. [1] A user must be sure that if they download and use VFS, all the code is available under AL 2.0. That means that Maven must not automatically download the dependency. Also, it must be possible for the end user to download the source and build it without needing to download the LGPL dependency. [1] http://www.apache.org/legal/resolved.html#optional Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230216#comment-14230216 ] Bernd Eckenfels commented on VFS-438: - Must not automatically download - does this mean optional is ok, or should it be not in the dependency graph at all? Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230251#comment-14230251 ] Dan Tran commented on VFS-438: -- so this request is valid if vfs-smb's pom.xml has jcifs as optional? Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230284#comment-14230284 ] Bernd Eckenfels commented on VFS-438: - I think if it is behind a non-automatically enabled profile and build with that, it might be fine: it wont depend on jcifs, but support using the provider if it is present in the classpath. Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230303#comment-14230303 ] Sebb commented on VFS-438: -- I think optional dependencies are still downloaded automatically. Try it and see - I think optional just means Maven won't include the jar in transitive dependencies [2] The point is that there should be no suprises for the user. UNLESS they explicitly agree otherwise, users should ONLY get AL-licensed software when they download/use ASF releases. There are probably many ways this can be achieved. For example, we may be able to use a 'provided' or 'system' dependency. This will require a deliberate action by the user to pre-install the jar somewhere. I'm sure there are other possible solutions. [2] http://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230312#comment-14230312 ] Sebb commented on VFS-438: -- Yes, a profile that has to be specifically enabled sounds OK. Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230550#comment-14230550 ] Joerg Schaible commented on VFS-438: Dependencies in profiles are absolutely evil. Optional is the perfect way to go. Nothing is downloaded automatically. Try yourself with a recent xstream versions, it has a lot of optional deps. Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230853#comment-14230853 ] Sebb commented on VFS-438: -- Why are dependencies in profiles evil? I just tried updating IO to depend on junit 4.12-beta-3 as an optional dependency. As expected, running mvn test downloaded the jar. So optional does _not_ meet the requirements for the component itself. Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (VFS-438) Please promote vfs-smb currently in the sandbox
[ https://issues.apache.org/jira/browse/VFS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230929#comment-14230929 ] Dan Tran commented on VFS-438: -- The behavior you see is correction since you have comons-io as direct dependency of 4.12 junit. However, the user of commons-io will not see junit 4.12 download. The vfs-smb case, we can have jcift as optional dep, and the user of vfs-smb will never see jcif download to his/her local repo Please promote vfs-smb currently in the sandbox --- Key: VFS-438 URL: https://issues.apache.org/jira/browse/VFS-438 Project: Commons VFS Issue Type: New Feature Affects Versions: 2.0 Environment: windows/unix Reporter: Dan Tran Fix For: 2.1 Current smb provider in the sandbox is mature enough to proceed with promotion out of sandbox for general use. Detail discussion is here http://apache-commons.680414.n4.nabble.com/Promote-vfs-cift-out-of-sandbox-td4636519.html The sandbox also tests hookup to current test suite, all we need is to provide a external URI using VFS test suite instructions. There are currently 2 classloader specific failures Tests in error: testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.ClassToLoad testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests): code.sealed.AnotherClass Tests run: 1745, Failures: 0, Errors: 2, Skipped: 0 require cifs 1.3.17 with one line change at SmbFileObject.java line number 227 to if (e.getNtStatus() == SmbException.NT_STATUS_NO_SUCH_FILE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
