[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954459#comment-16954459 ] Woonsan Ko commented on VFS-686: It seems working fine after building/running from master branch. I've followed [1] to test run webdav3 and webdav4 providers after running Jackrabbit Standalone server [2], which provides WebDAV server as well, locally. Thank you very much! Woonsan [1] https://github.com/apache/commons-vfs/blob/master/commons-vfs2-examples/README.md#example-test-scenario-with-webdav3 [2] http://jackrabbit.apache.org/jcr/standalone-server.html > Upgrade Jackrabbit dependency to the latest 2.x > --- > > Key: VFS-686 > URL: https://issues.apache.org/jira/browse/VFS-686 > Project: Commons VFS > Issue Type: Improvement >Affects Versions: 2.2 >Reporter: Woonsan Ko >Priority: Major > Labels: pull-request-available > Fix For: 2.5.0 > > Attachments: feature-VFS-686-2.patch, feature-VFS-686-3.patch, > feature-VFS-686-4.patch, feature-VFS-686-5.patch, feature-VFS-686-6.patch, > feature-VFS-686.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x, > while Jackrabbit 2.x depends on HttpClient 4.x. > So, WebDAV file system provider should use the latest stable version of > Jackrabbit 2.x. > As of VFS-360, it is possible to let the WebDAV file system use > HttpComponents 4.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953853#comment-16953853 ] Woonsan Ko commented on VFS-686: Hi [~ggregory], I've just pushed since tag fixes to PR. Thanks! Woonsan P.S. There seemed to have a temporary build error in travis. I assume it's travis env issue at the moment. After re-kicking the build, it seems to build fine in most envs. > Upgrade Jackrabbit dependency to the latest 2.x > --- > > Key: VFS-686 > URL: https://issues.apache.org/jira/browse/VFS-686 > Project: Commons VFS > Issue Type: Improvement >Affects Versions: 2.2 >Reporter: Woonsan Ko >Priority: Major > Labels: pull-request-available > Attachments: feature-VFS-686-2.patch, feature-VFS-686-3.patch, > feature-VFS-686-4.patch, feature-VFS-686-5.patch, feature-VFS-686-6.patch, > feature-VFS-686.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x, > while Jackrabbit 2.x depends on HttpClient 4.x. > So, WebDAV file system provider should use the latest stable version of > Jackrabbit 2.x. > As of VFS-360, it is possible to let the WebDAV file system use > HttpComponents 4.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[
https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953790#comment-16953790
]
Gary D. Gregory commented on VFS-686:
-
I'd like to use GitHub to squash and merge, can you make sure the PR is
up-to-date WRT {{@since}} tags?
> Upgrade Jackrabbit dependency to the latest 2.x
> ---
>
> Key: VFS-686
> URL: https://issues.apache.org/jira/browse/VFS-686
> Project: Commons VFS
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Woonsan Ko
>Priority: Major
> Labels: pull-request-available
> Attachments: feature-VFS-686-2.patch, feature-VFS-686-3.patch,
> feature-VFS-686-4.patch, feature-VFS-686-5.patch, feature-VFS-686-6.patch,
> feature-VFS-686.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x,
> while Jackrabbit 2.x depends on HttpClient 4.x.
> So, WebDAV file system provider should use the latest stable version of
> Jackrabbit 2.x.
> As of VFS-360, it is possible to let the WebDAV file system use
> HttpComponents 4.x.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[
https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953539#comment-16953539
]
Woonsan Ko commented on VFS-686:
Latest patch generated from PR: [^feature-VFS-686-6.patch]
{noformat:title=example command}
$ git apply --whitespace=fix feature-VFS-686-6.patch
{noformat}
> Upgrade Jackrabbit dependency to the latest 2.x
> ---
>
> Key: VFS-686
> URL: https://issues.apache.org/jira/browse/VFS-686
> Project: Commons VFS
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Woonsan Ko
>Priority: Major
> Labels: pull-request-available
> Attachments: feature-VFS-686-2.patch, feature-VFS-686-3.patch,
> feature-VFS-686-4.patch, feature-VFS-686-5.patch, feature-VFS-686-6.patch,
> feature-VFS-686.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x,
> while Jackrabbit 2.x depends on HttpClient 4.x.
> So, WebDAV file system provider should use the latest stable version of
> Jackrabbit 2.x.
> As of VFS-360, it is possible to let the WebDAV file system use
> HttpComponents 4.x.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951931#comment-16951931 ] Woonsan Ko commented on VFS-686: I've just upgraded the JR2 dependency to 2.19.5 in the PR and attached [^feature-VFS-686-5.patch] accordingly. > Upgrade Jackrabbit dependency to the latest 2.x > --- > > Key: VFS-686 > URL: https://issues.apache.org/jira/browse/VFS-686 > Project: Commons VFS > Issue Type: Improvement >Affects Versions: 2.2 >Reporter: Woonsan Ko >Priority: Major > Labels: pull-request-available > Attachments: feature-VFS-686-2.patch, feature-VFS-686-3.patch, > feature-VFS-686-4.patch, feature-VFS-686-5.patch, feature-VFS-686.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x, > while Jackrabbit 2.x depends on HttpClient 4.x. > So, WebDAV file system provider should use the latest stable version of > Jackrabbit 2.x. > As of VFS-360, it is possible to let the WebDAV file system use > HttpComponents 4.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[
https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946313#comment-16946313
]
Woonsan Ko commented on VFS-686:
Hi [~ggregory],
Would you mind reviewing the pull request (
https://github.com/apache/commons-vfs/pull/52 ) ? I've just merged master and
fixed conflicts. Also, I've attached a new patch file:
[^feature-VFS-686-4.patch] , with which you can apply by {{git apply
--whitespace=fix feature-VFS-686-4.patch}}. There are some trailing whitespace
warnings, but they are automatically fixed by the command.
To test both webdav3 and webdav4 providers with Jackrabbit standalone server
[1], please see the last two sections in commons-vfs2-examples/README.md.
Thanks in advance,
Woonsan
[1] http://jackrabbit.apache.org/jcr/standalone-server.html
(You can download the latest one from
https://www.apache.org/dyn/closer.lua/jackrabbit/2.18.3/jackrabbit-standalone-2.18.3.jar
and run it simply by {{java -jar jackrabbit-standalone-2.18.3.jar}}, for
example.)
> Upgrade Jackrabbit dependency to the latest 2.x
> ---
>
> Key: VFS-686
> URL: https://issues.apache.org/jira/browse/VFS-686
> Project: Commons VFS
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Woonsan Ko
>Priority: Major
> Labels: pull-request-available
> Attachments: feature-VFS-686-2.patch, feature-VFS-686-3.patch,
> feature-VFS-686-4.patch, feature-VFS-686.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x,
> while Jackrabbit 2.x depends on HttpClient 4.x.
> So, WebDAV file system provider should use the latest stable version of
> Jackrabbit 2.x.
> As of VFS-360, it is possible to let the WebDAV file system use
> HttpComponents 4.x.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[
https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853790#comment-16853790
]
Woonsan Ko commented on VFS-686:
Uploaded a new patch up-to-date: [^feature-VFS-686-3.patch]
You can apply it to master branch like this:
{noformat}
$ git apply --whitespace=fix feature-VFS-686-3.patch
...feature-VFS-686-3.patch:1250: trailing whitespace.
warning: squelched 3319 whitespace errors
warning: 7 lines applied after fixing whitespace errors.
{noformat}
There are some warnings due to white spaces, but they are just warnings and
automatically fixed.
Regards,
Woonsan
> Upgrade Jackrabbit dependency to the latest 2.x
> ---
>
> Key: VFS-686
> URL: https://issues.apache.org/jira/browse/VFS-686
> Project: Commons VFS
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Woonsan Ko
>Priority: Major
> Labels: pull-request-available
> Attachments: feature-VFS-686-2.patch, feature-VFS-686-3.patch,
> feature-VFS-686.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x,
> while Jackrabbit 2.x depends on HttpClient 4.x.
> So, WebDAV file system provider should use the latest stable version of
> Jackrabbit 2.x.
> As of VFS-360, it is possible to let the WebDAV file system use
> HttpComponents 4.x.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847945#comment-16847945 ] Woonsan Ko commented on VFS-686: Updated new patch file after merging master branch: [^feature-VFS-686-2.patch] > Upgrade Jackrabbit dependency to the latest 2.x > --- > > Key: VFS-686 > URL: https://issues.apache.org/jira/browse/VFS-686 > Project: Commons VFS > Issue Type: Improvement >Affects Versions: 2.2 >Reporter: Woonsan Ko >Priority: Major > Labels: pull-request-available > Attachments: feature-VFS-686-2.patch, feature-VFS-686.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x, > while Jackrabbit 2.x depends on HttpClient 4.x. > So, WebDAV file system provider should use the latest stable version of > Jackrabbit 2.x. > As of VFS-360, it is possible to let the WebDAV file system use > HttpComponents 4.x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[
https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830723#comment-16830723
]
Woonsan Ko commented on VFS-686:
Hi [~garydgregory],
For some reason, the patch file downloaded from GitHub makes problems when
applying it to master branch.
So, I created the patch file ( [^feature-VFS-686.patch] ) locally:
{code:title}
$ git diff master feature/VFS-686 --binary > feature-VFS-686.patch
{code}
And this seems working with this command:
{code}
$ git apply --whitespace=fix /tmp/feature-VFS-686.patch
{code}
Could you try with this instead?
Thanks,
Woonsan
> Upgrade Jackrabbit dependency to the latest 2.x
> ---
>
> Key: VFS-686
> URL: https://issues.apache.org/jira/browse/VFS-686
> Project: Commons VFS
> Issue Type: Improvement
>Affects Versions: 2.2
>Reporter: Woonsan Ko
>Priority: Major
> Labels: pull-request-available
> Attachments: feature-VFS-686.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x,
> while Jackrabbit 2.x depends on HttpClient 4.x.
> So, WebDAV file system provider should use the latest stable version of
> Jackrabbit 2.x.
> As of VFS-360, it is possible to let the WebDAV file system use
> HttpComponents 4.x.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815886#comment-16815886 ] Gary Gregory commented on VFS-686: -- The link from GihHub to GitBox seems broken; see my email on the dev ML. I want to wait to merge this until it is fixed... > Upgrade Jackrabbit dependency to the latest 2.x > --- > > Key: VFS-686 > URL: https://issues.apache.org/jira/browse/VFS-686 > Project: Commons VFS > Issue Type: Improvement >Affects Versions: 2.2 >Reporter: Woonsan Ko >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x, > while Jackrabbit 2.x depends on HttpClient 4.x. > So, WebDAV file system provider should use the latest stable version of > Jackrabbit 2.x. > As of VFS-360, it is possible to let the WebDAV file system use > HttpComponents 4.x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815876#comment-16815876 ] Woonsan Ko commented on VFS-686: The pull request ( https://github.com/apache/commons-vfs/pull/52 ) is now ready to review. No more JR snapshot dependency; now using the latest release, 2.19.2. Thanks! > Upgrade Jackrabbit dependency to the latest 2.x > --- > > Key: VFS-686 > URL: https://issues.apache.org/jira/browse/VFS-686 > Project: Commons VFS > Issue Type: Improvement >Affects Versions: 2.2 >Reporter: Woonsan Ko >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The current dependency, Jackrabbit 1.6.5, still depends on HttpClient 3.x, > while Jackrabbit 2.x depends on HttpClient 4.x. > So, WebDAV file system provider should use the latest stable version of > Jackrabbit 2.x. > As of VFS-360, it is possible to let the WebDAV file system use > HttpComponents 4.x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
