Bruno P. Kinoshita created DBCP-509: ---------------------------------------
Summary: Not all methods are consistent in PerUserPooldataSource and InstanceKeyDataSource Key: DBCP-509 URL: https://issues.apache.org/jira/browse/DBCP-509 Project: Commons DBCP Issue Type: Improvement Affects Versions: 2.4.0 Reporter: Bruno P. Kinoshita Fix For: 2.5.0 While working on DBCP-504 tests, I wrote a few files to help me automating some of the tests (e.g. https://gist.github.com/kinow/053b6d1f293fdc208a2a14571f246786). In PerUserPooldataSource, I realized I had to change some tests that were failing to handle null values. But not all methods. So I had a look at the methods, and the majority was following a pattern * using primitives * default'ing to the class/parent method getDefaultPropertyZ() whenever Z property was null But three values were using objects instead of primitives, and allowing null's: * defaultAutoCommit * defaultReadOnly * perUserDefaultAutoCommit I prepared a pull request that falls back to the default method's values. It's more of a discussion issue, just to document what I found during DBCP-504. -- This message was sent by Atlassian JIRA (v7.6.3#76005)