[jira] [Issue Comment Deleted] (VFS-558) java.lang.UnsupportedOperationException in FtpFileObject

2015-01-18 Thread L (JIRA)

 [ 
https://issues.apache.org/jira/browse/VFS-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

L updated VFS-558:
--
Comment: was deleted

(was: Re: BTW2: do you use OnCallRefresher on purpose, I can imagine that makes 
FTP quite slow.

Well, I do use CacheStrategy.ON_CALL, so yes, it is OnCallRefreshFileObject.
My code has some checks before performing moveTo to verify the destination file 
is not there so I am not overwriting it.
My tests gave me quite a lot of spurious warnings saying the file IS there 
before the rename while I quite sure it was not there.
Adding the CacheStrategy.ON_CALL helped a lot but sometimes I still get 
resulted in most of the false positive )

 java.lang.UnsupportedOperationException in FtpFileObject
 

 Key: VFS-558
 URL: https://issues.apache.org/jira/browse/VFS-558
 Project: Commons VFS
  Issue Type: Bug
Affects Versions: 2.0
Reporter: L

 I am getting the following exception in my code:
 java.lang.UnsupportedOperationException
   at java.util.Collections$UnmodifiableMap.remove(Collections.java:1345)
   at 
 org.apache.commons.vfs2.provider.ftp.FtpFileObject.onChildrenChanged(FtpFileObject.java:271)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.childrenChanged(AbstractFileObject.java:240)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.notifyParent(AbstractFileObject.java:1931)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.handleCreate(AbstractFileObject.java:1577)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.moveTo(AbstractFileObject.java:1866)
   at 
 org.apache.commons.vfs2.impl.DecoratedFileObject.moveTo(DecoratedFileObject.java:241)
   at 
 org.apache.commons.vfs2.cache.OnCallRefreshFileObject.moveTo(OnCallRefreshFileObject.java:184)
 ...
 I guess it is caused by the fact that children field is set to 
 EMPTY_FTP_FILE_MAP at the moment onChildrenChanged() is invoked.
 I also do not like line 1866 in AbstractFileObject.java. To me it looks like 
 it might be the real cause of the problem:
 FileObjectUtils.getAbstractFileObject(destFile).handleCreate(getType());
 Must it not be destFile.getType()?
 But even if I am right about AbstractFileObject.java:1866, 
 FtpFileObject.onChildrenChanged() must be corrected as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (VFS-558) java.lang.UnsupportedOperationException in FtpFileObject

2015-01-18 Thread L (JIRA)

 [ 
https://issues.apache.org/jira/browse/VFS-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

L updated VFS-558:
--
Comment: was deleted

(was: Re: BTW2: do you use OnCallRefresher on purpose, I can imagine that makes 
FTP quite slow.

Well, I do use CacheStrategy.ON_CALL, so yes, it is OnCallRefreshFileObject.
My code has some checks before performing moveTo to verify the destination file 
is not there so I am not overwriting it.
My tests gave me quite a lot of spurious warnings saying the file IS there 
before the rename while I quite sure it was not there.
Adding the CacheStrategy.ON_CALL helped a lot but sometimes I still get 
resulted in most of the false positive )

 java.lang.UnsupportedOperationException in FtpFileObject
 

 Key: VFS-558
 URL: https://issues.apache.org/jira/browse/VFS-558
 Project: Commons VFS
  Issue Type: Bug
Affects Versions: 2.0
Reporter: L

 I am getting the following exception in my code:
 java.lang.UnsupportedOperationException
   at java.util.Collections$UnmodifiableMap.remove(Collections.java:1345)
   at 
 org.apache.commons.vfs2.provider.ftp.FtpFileObject.onChildrenChanged(FtpFileObject.java:271)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.childrenChanged(AbstractFileObject.java:240)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.notifyParent(AbstractFileObject.java:1931)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.handleCreate(AbstractFileObject.java:1577)
   at 
 org.apache.commons.vfs2.provider.AbstractFileObject.moveTo(AbstractFileObject.java:1866)
   at 
 org.apache.commons.vfs2.impl.DecoratedFileObject.moveTo(DecoratedFileObject.java:241)
   at 
 org.apache.commons.vfs2.cache.OnCallRefreshFileObject.moveTo(OnCallRefreshFileObject.java:184)
 ...
 I guess it is caused by the fact that children field is set to 
 EMPTY_FTP_FILE_MAP at the moment onChildrenChanged() is invoked.
 I also do not like line 1866 in AbstractFileObject.java. To me it looks like 
 it might be the real cause of the problem:
 FileObjectUtils.getAbstractFileObject(destFile).handleCreate(getType());
 Must it not be destFile.getType()?
 But even if I am right about AbstractFileObject.java:1866, 
 FtpFileObject.onChildrenChanged() must be corrected as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)