[jira] [Resolved] (COLLECTIONS-519) private constructors in utility classes break existing code

2014-05-02 Thread Thomas Neidhart (JIRA)

 [ 
https://issues.apache.org/jira/browse/COLLECTIONS-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Neidhart resolved COLLECTIONS-519.
-

   Resolution: Won't Fix
Fix Version/s: (was: 4.1)

Reverted commit after veto in r1591832.

> private constructors in utility classes break existing code
> ---
>
> Key: COLLECTIONS-519
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-519
> Project: Commons Collections
>  Issue Type: Bug
>Affects Versions: 4.x
>Reporter: Radoslav Paskalev
>
> Hello,
> In collections version 4.x all utility classes (example ListUtils, MapUtils, 
> PredicateUtils) have private constructors. I consider this to be a 
> serious bug, as it breaks any possibility the classes to be extended by the 
> users.  The javadoc says that constructors are private in order to prevent 
> class instantiation but this object instantiation is not really problem and i 
> think it is more important to allow classes to be extended. The possibility 
> to extend utility classes was one of the major selling points of commons.lang 
> and commons.collections projects. In the latest commons.lang project the 
> utility classes still have public constructors.
> Best Regards



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (COLLECTIONS-519) private constructors in utility classes break existing code

2014-05-01 Thread Thomas Neidhart (JIRA)

 [ 
https://issues.apache.org/jira/browse/COLLECTIONS-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Neidhart resolved COLLECTIONS-519.
-

   Resolution: Fixed
Fix Version/s: 4.1

In r1591602, I have changed all constructors of *Utils classes from private to 
protected to allow sub-classing.

Commons is a community project, thus we need feedback from our users to further 
improve the components.

Thanks for the use-cases that you presented here, probably not something that 
lots of people do, but certainly valid and useful.

> private constructors in utility classes break existing code
> ---
>
> Key: COLLECTIONS-519
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-519
> Project: Commons Collections
>  Issue Type: Bug
>Affects Versions: 4.x
>Reporter: Radoslav Paskalev
> Fix For: 4.1
>
>
> Hello,
> In collections version 4.x all utility classes (example ListUtils, MapUtils, 
> PredicateUtils) have private constructors. I consider this to be a 
> serious bug, as it breaks any possibility the classes to be extended by the 
> users.  The javadoc says that constructors are private in order to prevent 
> class instantiation but this object instantiation is not really problem and i 
> think it is more important to allow classes to be extended. The possibility 
> to extend utility classes was one of the major selling points of commons.lang 
> and commons.collections projects. In the latest commons.lang project the 
> utility classes still have public constructors.
> Best Regards



--
This message was sent by Atlassian JIRA
(v6.2#6252)