[
https://issues.apache.org/jira/browse/IMAGING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita resolved IMAGING-252.
----------------------------------------
Resolution: Fixed
Hi [~gwlucas] o/
Triaging the issues for alpha-3. This one appears to have been fixed some time
ago. We now test Windows with GitHub Actions -
https://github.com/apache/commons-imaging/blob/c33ef79cd2026b5b622102c8c7ebc9eebdd5b899/.github/workflows/maven.yml#L29
> Unit Tests Fail when running under Windows
> ------------------------------------------
>
> Key: IMAGING-252
> URL: https://issues.apache.org/jira/browse/IMAGING-252
> Project: Commons Imaging
> Issue Type: Bug
> Components: Build, imaging.*
> Affects Versions: 1.0-alpha1
> Reporter: Gary Lucas
> Priority: Major
>
> When performing a maven verify under a Windows OS, the unit test for
> TestImageInfo.java fails. The problem is due to the fact that the toString()
> method used for the test data format (BMP, I think) returns a multi-line
> product. Under windows, the PrintWriter class that is used internally to
> format the string introduces carriage returns. But the "expected" string
> that the TestImageInfo class uses has line feeds but no carriage returns.
> So the assertEquals() test fails.
> By tradition, Windows text includes a carriage-return/line-feed at the end of
> each line of text while Linux text has just a line-feed. So if these unit
> tests are performed on Linux, they pass. Only Windows is an issue.
> Recommend including a line of code to remove the carriage-returns from the
> return String from the ImageInfo.toString() method call. Instead of:
> {quote}assertEquals(expected, imageInfo.toString());
> {quote}
> use:
>
> {quote}String test = imageInfo.toString().replaceAll("\\r", "");
> assertEquals(expected, test);
> {quote}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
