[jira] [Resolved] (MATH-658) Dead code in FastMath.pow(double, double) and some improvement in test coverage
[ https://issues.apache.org/jira/browse/MATH-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved MATH-658. --- Resolution: Fixed Patches applied. > Dead code in FastMath.pow(double, double) and some improvement in test > coverage > --- > > Key: MATH-658 > URL: https://issues.apache.org/jira/browse/MATH-658 > Project: Commons Math > Issue Type: Improvement >Reporter: Yannick TANGUY >Priority: Minor > Fix For: 3.0 > > Attachments: FastMath.java.diff, FastMathTest.java, > FastMathTest.java.diff > > > This issue concerns the FastMath class and its test class. > (1) In the double pow(double, double) function, there are 2 identical "if" > blocks. The second one can be suppressed. > if (y < 0 && y == yi && (yi & 1) == 1) { > return Double.NEGATIVE_INFINITY; > } > // this block is never used -> to be suppressed > if (y < 0 && y == yi && (yi & 1) == 1) { > return -0.0; > } > if (y > 0 && y == yi && (yi & 1) == 1) { > return -0.0; > } > (2) To obtain better code coverage, we added some tests case in > FastMathTest.java (see attached file) > - Added test for log1p > - Added tests in testPowSpecialCases() > - Added tests for a 100% coverage of acos(). > - Added tests for a 100% coverage of asin(). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-658) Dead code in FastMath.pow(double, double) and some improvement in test coverage
[ https://issues.apache.org/jira/browse/MATH-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved MATH-658. --- Resolution: Fixed Hope this is now better resolved ... > Dead code in FastMath.pow(double, double) and some improvement in test > coverage > --- > > Key: MATH-658 > URL: https://issues.apache.org/jira/browse/MATH-658 > Project: Commons Math > Issue Type: Improvement >Reporter: Yannick TANGUY >Priority: Minor > Fix For: 3.0 > > Attachments: FastMath.java.diff, FastMathTest.java.diff > > > This issue concerns the FastMath class and its test class. > (1) In the double pow(double, double) function, there are 2 identical "if" > blocks. The second one can be suppressed. > if (y < 0 && y == yi && (yi & 1) == 1) { > return Double.NEGATIVE_INFINITY; > } > // this block is never used -> to be suppressed > if (y < 0 && y == yi && (yi & 1) == 1) { > return -0.0; > } > if (y > 0 && y == yi && (yi & 1) == 1) { > return -0.0; > } > (2) To obtain better code coverage, we added some tests case in > FastMathTest.java (see attached file) > - Added test for log1p > - Added tests in testPowSpecialCases() > - Added tests for a 100% coverage of acos(). > - Added tests for a 100% coverage of asin(). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira