[jira] [Resolved] (NET-425) _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.

2011-11-11 Thread Sebb (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb resolved NET-425.
--

Resolution: Fixed

Thanks.

I modified the patch slightly; got rid of the private methods (only used once) 
and rearranged the methods to simplify the difference between versions.

 _openDataConnection_, __storeFile, and __storeFileStream should be protected 
 and take String for FTP command.
 -

 Key: NET-425
 URL: https://issues.apache.org/jira/browse/NET-425
 Project: Commons Net
  Issue Type: Improvement
  Components: FTP
Affects Versions: 3.0.1
 Environment: All
Reporter: Steven Jardine
 Fix For: 3.1

 Attachments: patch.txt, retrievefile.patch


 Currently __storeFile, __storeStream, and _openConnection_ are declared as 
 private and only receive int commands.  I am trying to extend the FTPClient 
 class to implement specialized commands that utilize these methods.  In order 
 for this to work I need to have these methods declared as protected as well 
 as adjust the parameters to allow for String commands.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (NET-425) _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.

2011-11-01 Thread Sebb (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb resolved NET-425.
--

Resolution: Fixed

 _openDataConnection_, __storeFile, and __storeFileStream should be protected 
 and take String for FTP command.
 -

 Key: NET-425
 URL: https://issues.apache.org/jira/browse/NET-425
 Project: Commons Net
  Issue Type: Improvement
  Components: FTP
 Environment: All
Reporter: Steven Jardine
 Attachments: patch.txt


 Currently __storeFile, __storeStream, and _openConnection_ are declared as 
 private and only receive int commands.  I am trying to extend the FTPClient 
 class to implement specialized commands that utilize these methods.  In order 
 for this to work I need to have these methods declared as protected as well 
 as adjust the parameters to allow for String commands.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira