[jira] [Updated] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1081: -- Summary: DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check (was: DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.) > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check > > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Assignee: Benedikt Ritter >Priority: Trivial > Labels: github > Fix For: Review Patch > > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1081: -- Labels: github (was: ) > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check. > - > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Priority: Trivial > Labels: github > Fix For: Review Patch > > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1081: -- Fix Version/s: Review Patch > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check. > - > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Priority: Trivial > Fix For: Review Patch > > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.
[ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Baker updated LANG-1081: - Attachment: DiffBuilder-equals_test_in_append_Objects.patch DiffBuilderAppendsNonEqualObjectsFixed.java DiffBuilderAppendsNonEqualObjects.java Attached are examples of how to detect and correct the issue. > DiffBuilder.append(String, Object left, Object right) does not do a > left.equals(right) check. > - > > Key: LANG-1081 > URL: https://issues.apache.org/jira/browse/LANG-1081 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* >Affects Versions: 3.3.2 >Reporter: Jonathan Baker >Priority: Trivial > Attachments: DiffBuilder-equals_test_in_append_Objects.patch, > DiffBuilderAppendsNonEqualObjects.java, > DiffBuilderAppendsNonEqualObjectsFixed.java > > Original Estimate: 1m > Remaining Estimate: 1m > > Only testing == without testing equals() seems wrong. > Should an equals() test be added after determining that the parameters are > not arrays? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
