[jira] [Updated] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty

2011-11-03 Thread Adrian Cumiskey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Cumiskey updated OGNL-35:


Attachment: patch-OGNL35-v2.txt

> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> 
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
>  Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String 
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method 
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from 
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from 
> getSourceAccessor() and getSourceSetter().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty

2011-11-03 Thread Adrian Cumiskey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Cumiskey updated OGNL-35:


Description: 
* Flipped equals() everywhere where a variable is tested against a String 
constant.
* ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() 
from getSourceSetter() and getSourceAccessor().
* ASTProperty: CPD fix, extracted shared method getSourceString() from 
toGetSourceString() and toSetSourceString().
* ArrayPropertyAccessor: CPD fix, extracted getIndexString() from 
getSourceAccessor() and getSourceSetter().

  was:
* Flipped equals() where variable is tested against String constant.
* CPD: Extracted getSourceBeanMethod() shared method from getSourceSetter() and 
getSourceAccessor() in ListPropertyAccessor

Summary: [PATCH] Improvements to {List,Map,Array}PropertyAccessor and 
ASTProperty  (was: [PATCH] Improvements to {List,Map}PropertyAccessor)

> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> 
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
>  Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String 
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method 
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from 
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from 
> getSourceAccessor() and getSourceSetter().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira