[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=382133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382133
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 05/Feb/20 08:12
Start Date: 05/Feb/20 08:12
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #92: COMPRESS-477 :
"open when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92#issuecomment-582290001
Sure. I will add a new JIRA issue and modify the name of this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 382133)
Time Spent: 14.5h (was: 14h 20m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=382131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382131
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 05/Feb/20 08:11
Start Date: 05/Feb/20 08:11
Worklog Time Spent: 10m
Work Description: bodewig commented on issue #92: COMPRESS-477 : "open
when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92#issuecomment-582289566
@PeterAlfreadLee I think it would be good to track this as a separate JIRA
issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 382131)
Time Spent: 14h 20m (was: 14h 10m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=382121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382121
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 05/Feb/20 07:59
Start Date: 05/Feb/20 07:59
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on pull request #92:
COMPRESS-477 : "open when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92
Please refer (#90)[https://github.com/apache/commons-compress/pull/90]
When I was adding zip64 support for split zip, I encountered a problem :
When adding testcases in `Zip64SupportIT`, I created a split zip with
10,000+ split segments. Then I found that I was unable to unzip it because
there would be too many open files when extracting it. We can oepn the files
when actually needed and therefore we can successfully extract such split zips
with great amount of segments.
I have set a threshold of 20 in `MultiReadOnlySeekableByteChannel`. The
"open when actually needed" procedure will only work when the number of split
segments is greater than the threshold.
Actually this is a pretty rare case cause most split zips would not have too
many segments. So you can decide whether to merge this PR or not. :-)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 382121)
Time Spent: 14h 10m (was: 14h)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=374368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-374368
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 20/Jan/20 02:18
Start Date: 20/Jan/20 02:18
Worklog Time Spent: 10m
Work Description: jchaudhari01 commented on issue #84: COMPRESS-477 Add
support for extracting splitted zip files
URL: https://github.com/apache/commons-compress/pull/84#issuecomment-576079774
Does anyone know when is `1.20` going to be released?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 374368)
Time Spent: 14h (was: 13h 50m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 14h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=367144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367144
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 07/Jan/20 01:21
Start Date: 07/Jan/20 01:21
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-571389505
Everything looks great. I will try to finish the part of Zip64 for split zip
ASAP. Thank you for your reviews.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 367144)
Time Spent: 13h 50m (was: 13h 40m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=367143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367143
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 07/Jan/20 01:21
Start Date: 07/Jan/20 01:21
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-571389505
Everything looks great. I will try to finish the part of Zip64 for split zip
ASAP.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 367143)
Time Spent: 13h 40m (was: 13.5h)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=364531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364531
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 30/Dec/19 05:58
Start Date: 30/Dec/19 05:58
Worklog Time Spent: 10m
Work Description: bodewig commented on issue #86: COMPRESS-477 building a
split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-569591435
@PeterAlfreadLee please have a look at 57664d91 and check I haven't made any
mistakes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 364531)
Time Spent: 13.5h (was: 13h 20m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=360059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360059
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 16/Dec/19 03:42
Start Date: 16/Dec/19 03:42
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-565892958
@bodewig
Thank you for your reviews and rebased code.
> I think all that needs to be done now is document split support inside of
the "manual" properly and then I can close COMPRESS-477. I'll take care of that.
Please feel free to let me know if I can offer some help.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 360059)
Time Spent: 13h 20m (was: 13h 10m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=359951&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359951
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 15/Dec/19 11:12
Start Date: 15/Dec/19 11:12
Worklog Time Spent: 10m
Work Description: bodewig commented on issue #86: COMPRESS-477 building a
split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-565799612
@PeterAlfreadLee please take a look at my changes in 26c7aff
I think all that needs to be done now is document split support inside of
the "manual" properly and then I can close COMPRESS-477. I'll take care of that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359951)
Time Spent: 13h 10m (was: 13h)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=359950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359950
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 15/Dec/19 11:10
Start Date: 15/Dec/19 11:10
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359950)
Time Spent: 13h (was: 12h 50m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 13h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=359945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359945
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 15/Dec/19 10:45
Start Date: 15/Dec/19 10:45
Worklog Time Spent: 10m
Work Description: bodewig commented on issue #86: COMPRESS-477 building a
split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-565797653
@PeterAlfreadLee the openjdk-ea build is failing in master as well. It
probably either is a problem that exists in master anyway or a problem with our
Travis setup (which happens more often than our code breaking anything).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359945)
Time Spent: 12h 50m (was: 12h 40m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=359804&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359804
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 14/Dec/19 12:46
Start Date: 14/Dec/19 12:46
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-565713702
Code pushed with some test cases added.
But I'm a little confused why the build/test failed on `JDK: openjdk-ea`
while the others are finished successfully. Is there something wrong?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359804)
Time Spent: 12h 40m (was: 12.5h)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=359803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359803
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 14/Dec/19 12:43
Start Date: 14/Dec/19 12:43
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #86: COMPRESS-477 building
a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-552765671
[](https://coveralls.io/builds/27614132)
Coverage decreased (-0.1%) to 86.781% when pulling
**21025c71938d91bcaa1d55529087c0a082d22324 on
PeterAlfreadLee:COMPRESS-477-constructing** into
**dfa9ed3712097c10765301b15d720f867c4a061d on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359803)
Time Spent: 12.5h (was: 12h 20m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=359801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359801
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 14/Dec/19 12:41
Start Date: 14/Dec/19 12:41
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-565713702
Code pushed with some test cases added.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359801)
Time Spent: 12h 20m (was: 12h 10m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=356183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356183
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 09/Dec/19 13:51
Start Date: 09/Dec/19 13:51
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #86: COMPRESS-477 building
a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-552765671
[](https://coveralls.io/builds/27501786)
Coverage decreased (-0.01%) to 86.909% when pulling
**10ea1c82035e17b6f0b6c3035d51045c2991d2c7 on
PeterAlfreadLee:COMPRESS-477-constructing** into
**dfa9ed3712097c10765301b15d720f867c4a061d on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 356183)
Time Spent: 12h 10m (was: 12h)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=356180&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356180
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 09/Dec/19 13:47
Start Date: 09/Dec/19 13:47
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-563245782
Code pushed. Just the same as
https://github.com/bodewig/commons-compress/tree/COMPRESS-477-constructing with
only a little change : the imports of ZipSplitOutputStream has been extracted.
Besides I'll add some more test cases. Unfortunely I got some other work
this week so I don't have that much time for OSS like last few weeks. I hope I
can finish it in these two days. Thank you for your reviews @bodewig
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 356180)
Time Spent: 12h (was: 11h 50m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 12h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=356152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356152
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 09/Dec/19 13:18
Start Date: 09/Dec/19 13:18
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-563233979
> Actually both master and this branch neglect the possibility of the number
of disks requiring Zip64 extra handling. TBH I find the idea of a split ZIP
archive that spans more than 64k files a bit disturbing and would address it
with a separate change independent of this PR.
You are right. I forgot to take the Zip64 into consideration. I'll also look
into this later. And I agree that a separate PR maybe a good idea.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 356152)
Time Spent: 11h 50m (was: 11h 40m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=355937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355937
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 09/Dec/19 05:00
Start Date: 09/Dec/19 05:00
Worklog Time Spent: 10m
Work Description: bodewig commented on issue #86: COMPRESS-477 building a
split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-563063669
@trejkaz I won't make any promises but I intend to propose a new release
once this PR and #87 are in - and I've looked through the latest JIRA issues.
Most likely I won't be able to start with this before christmas, but hope to
cut 1.20 early next year.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 355937)
Time Spent: 11h 40m (was: 11.5h)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=355887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355887
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 09/Dec/19 01:27
Start Date: 09/Dec/19 01:27
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-563025104
@bodewig
Thank you so much for your reviews. I'll check this rebased version out ASAP.
I'll at least add your name to the comments to thank you for your hard work.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 355887)
Time Spent: 11.5h (was: 11h 20m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=355886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355886
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 09/Dec/19 01:14
Start Date: 09/Dec/19 01:14
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #84: COMPRESS-477
Add support for extracting splitted zip files
URL: https://github.com/apache/commons-compress/pull/84#issuecomment-563023329
These changes are great. Thank you for your reviews @bodewig
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 355886)
Time Spent: 11h 20m (was: 11h 10m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=355881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355881
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 08/Dec/19 22:31
Start Date: 08/Dec/19 22:31
Worklog Time Spent: 10m
Work Description: trejkaz commented on issue #86: COMPRESS-477 building a
split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-563003309
I'll be keeping watch on this one as we're very interested in the
functionality. How soon can we get this in an official release?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 355881)
Time Spent: 11h 10m (was: 11h)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-477) Support for split zip files
[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=355866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355866
]
ASF GitHub Bot logged work on COMPRESS-477:
---
Author: ASF GitHub Bot
Created on: 08/Dec/19 20:40
Start Date: 08/Dec/19 20:40
Worklog Time Spent: 10m
Work Description: bodewig commented on issue #86: COMPRESS-477 building a
split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-562991230
https://github.com/bodewig/commons-compress/tree/COMPRESS-477-constructing
holds a rebased version of this PR, I'd be happy if you just applied similar
changes and pushed it here, no need to have me as contributor inside of your
work.
While rebasing I realized that master says the disk number start is a long
while this branch uses an int. Actually both master and this branch neglect the
possibility of the number of disks requiring Zip64 extra handling. TBH I find
the idea of a split ZIP archive that spans more than 64k files a bit disturbing
and would address it with a separate change independent of this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 355866)
Time Spent: 11h (was: 10h 50m)
> Support for split zip files
> ---
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.18
>Reporter: Luís Filipe Nassif
>Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 11h
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
