[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=601028&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601028 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 24/May/21 06:27 Start Date: 24/May/21 06:27 Worklog Time Spent: 10m Work Description: bodewig merged pull request #168: URL: https://github.com/apache/commons-compress/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 601028) Time Spent: 1h 50m (was: 1h 40m) > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=600993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600993 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 24/May/21 01:37 Start Date: 24/May/21 01:37 Worklog Time Spent: 10m Work Description: PeterAlfredLee commented on pull request #168: URL: https://github.com/apache/commons-compress/pull/168#issuecomment-846674351 This looks good to me. :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 600993) Time Spent: 1h 40m (was: 1.5h) > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=600842&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600842 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 22/May/21 13:29 Start Date: 22/May/21 13:29 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #168: URL: https://github.com/apache/commons-compress/pull/168#issuecomment-846408598 @garydgregory @PeterAlfredLee is there anythin gleft that needs to be done before merging this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 600842) Time Spent: 1.5h (was: 1h 20m) > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=561827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561827 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 06/Mar/21 18:28 Start Date: 06/Mar/21 18:28 Worklog Time Spent: 10m Work Description: bokken commented on pull request #168: URL: https://github.com/apache/commons-compress/pull/168#issuecomment-792008765 Do I need to do anything else here @garydgregory ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 561827) Time Spent: 1h 20m (was: 1h 10m) > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[
https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=555239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-555239
]
ASF GitHub Bot logged work on COMPRESS-566:
---
Author: ASF GitHub Bot
Created on: 20/Feb/21 17:51
Start Date: 20/Feb/21 17:51
Worklog Time Spent: 10m
Work Description: bokken commented on a change in pull request #168:
URL: https://github.com/apache/commons-compress/pull/168#discussion_r579686912
##
File path:
src/main/java/org/apache/commons/compress/compressors/gzip/GzipParameters.java
##
@@ -118,4 +120,28 @@ public int getOperatingSystem() {
public void setOperatingSystem(final int operatingSystem) {
this.operatingSystem = operatingSystem;
}
+
+/**
+ * Gets size of the buffer used to retrieve compressed data.
+ * @return The size of the buffer used to retrieve compressed data.
+ * @since 1.21
+ * @see #setBufferSize(int)
+ */
+public int getBufferSize() {
+return this.bufferSize;
+}
+
+/**
+ * Sets size of the buffer used to retrieve compressed data from
+ * {@link Deflater} and write to underlying {@link OutputStream}.
+ *
+ * @param bufferSize the bufferSize to set. Must be a positive value.
+ * @since 1.21
+ */
+public void setBufferSize(int bufferSize) {
+if (bufferSize <= 0) {
Review comment:
I personally do not see the value, but can add if desired.
There is certainly some threshold where larger values are counter
productive, but my opinion is consumers can determine that on their own.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 555239)
Time Spent: 1h 10m (was: 1h)
> make gzip deflate buffer size configurable
> --
>
> Key: COMPRESS-566
> URL: https://issues.apache.org/jira/browse/COMPRESS-566
> Project: Commons Compress
> Issue Type: Improvement
> Components: Compressors
>Reporter: Brett Okken
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> It would be good if this could be configurable in GzipParameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[
https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=555031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-555031
]
ASF GitHub Bot logged work on COMPRESS-566:
---
Author: ASF GitHub Bot
Created on: 20/Feb/21 02:07
Start Date: 20/Feb/21 02:07
Worklog Time Spent: 10m
Work Description: PeterAlfredLee commented on a change in pull request
#168:
URL: https://github.com/apache/commons-compress/pull/168#discussion_r579572525
##
File path:
src/main/java/org/apache/commons/compress/compressors/gzip/GzipParameters.java
##
@@ -118,4 +120,28 @@ public int getOperatingSystem() {
public void setOperatingSystem(final int operatingSystem) {
this.operatingSystem = operatingSystem;
}
+
+/**
+ * Gets size of the buffer used to retrieve compressed data.
+ * @return The size of the buffer used to retrieve compressed data.
+ * @since 1.21
+ * @see #setBufferSize(int)
+ */
+public int getBufferSize() {
+return this.bufferSize;
+}
+
+/**
+ * Sets size of the buffer used to retrieve compressed data from
+ * {@link Deflater} and write to underlying {@link OutputStream}.
+ *
+ * @param bufferSize the bufferSize to set. Must be a positive value.
+ * @since 1.21
+ */
+public void setBufferSize(int bufferSize) {
+if (bufferSize <= 0) {
Review comment:
Do we need a high limit check for `bufferSize` here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 555031)
Time Spent: 1h (was: 50m)
> make gzip deflate buffer size configurable
> --
>
> Key: COMPRESS-566
> URL: https://issues.apache.org/jira/browse/COMPRESS-566
> Project: Commons Compress
> Issue Type: Improvement
> Components: Compressors
>Reporter: Brett Okken
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> It would be good if this could be configurable in GzipParameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=554977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554977 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 19/Feb/21 23:17 Start Date: 19/Feb/21 23:17 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #168: URL: https://github.com/apache/commons-compress/pull/168#issuecomment-782362631 [](https://coveralls.io/builds/37289516) Coverage increased (+0.005%) to 87.36% when pulling **309681f315008eb78bc063db623e02bbe8c8855c on bokken:COMPRESS-566_buf_size** into **1b7528fbd6295a3958daf1b1114621ee5e40e83c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 554977) Time Spent: 50m (was: 40m) > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[
https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=554974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554974
]
ASF GitHub Bot logged work on COMPRESS-566:
---
Author: ASF GitHub Bot
Created on: 19/Feb/21 23:09
Start Date: 19/Feb/21 23:09
Worklog Time Spent: 10m
Work Description: bokken commented on a change in pull request #168:
URL: https://github.com/apache/commons-compress/pull/168#discussion_r579530866
##
File path:
src/main/java/org/apache/commons/compress/compressors/gzip/GzipParameters.java
##
@@ -118,4 +120,22 @@ public int getOperatingSystem() {
public void setOperatingSystem(final int operatingSystem) {
this.operatingSystem = operatingSystem;
}
+
Review comment:
The rest of the attributes in the class only had javadoc for setter
method. I had started writing javadoc but removed it to match the rest. I can
certainly add.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 554974)
Time Spent: 40m (was: 0.5h)
> make gzip deflate buffer size configurable
> --
>
> Key: COMPRESS-566
> URL: https://issues.apache.org/jira/browse/COMPRESS-566
> Project: Commons Compress
> Issue Type: Improvement
> Components: Compressors
>Reporter: Brett Okken
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> It would be good if this could be configurable in GzipParameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[
https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=554945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554945
]
ASF GitHub Bot logged work on COMPRESS-566:
---
Author: ASF GitHub Bot
Created on: 19/Feb/21 21:32
Start Date: 19/Feb/21 21:32
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #168:
URL: https://github.com/apache/commons-compress/pull/168#discussion_r579486633
##
File path:
src/main/java/org/apache/commons/compress/compressors/gzip/GzipParameters.java
##
@@ -118,4 +120,22 @@ public int getOperatingSystem() {
public void setOperatingSystem(final int operatingSystem) {
this.operatingSystem = operatingSystem;
}
+
Review comment:
You're missing a Javadoc comment here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 554945)
Time Spent: 0.5h (was: 20m)
> make gzip deflate buffer size configurable
> --
>
> Key: COMPRESS-566
> URL: https://issues.apache.org/jira/browse/COMPRESS-566
> Project: Commons Compress
> Issue Type: Improvement
> Components: Compressors
>Reporter: Brett Okken
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> It would be good if this could be configurable in GzipParameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=554940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554940 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 19/Feb/21 21:23 Start Date: 19/Feb/21 21:23 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #168: URL: https://github.com/apache/commons-compress/pull/168#issuecomment-782362631 [](https://coveralls.io/builds/37286781) Coverage increased (+0.005%) to 87.36% when pulling **8797ec4eadc5ad4e0b278677979010ce6aa41f7b on bokken:COMPRESS-566_buf_size** into **1b7528fbd6295a3958daf1b1114621ee5e40e83c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 554940) Time Spent: 20m (was: 10m) > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=554937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554937 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 19/Feb/21 21:17 Start Date: 19/Feb/21 21:17 Worklog Time Spent: 10m Work Description: bokken opened a new pull request #168: URL: https://github.com/apache/commons-compress/pull/168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 554937) Remaining Estimate: 0h Time Spent: 10m > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
