[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=649986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649986 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 13/Sep/21 12:44 Start Date: 13/Sep/21 12:44 Worklog Time Spent: 10m Work Description: jochenw merged pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 649986) Time Spent: 1.5h (was: 1h 20m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=645099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645099 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 01/Sep/21 09:36 Start Date: 01/Sep/21 09:36 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [![Coverage Status](https://coveralls.io/builds/42501247/badge)](https://coveralls.io/builds/42501247) Coverage decreased (-0.6%) to 77.521% when pulling **1bb61b675b00866aea512b12adf2678201dca609 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 645099) Time Spent: 1h 20m (was: 1h 10m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=644355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644355 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 31/Aug/21 15:15 Start Date: 31/Aug/21 15:15 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [![Coverage Status](https://coveralls.io/builds/42501247/badge)](https://coveralls.io/builds/42501247) Coverage decreased (-0.6%) to 77.521% when pulling **1bb61b675b00866aea512b12adf2678201dca609 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 644355) Time Spent: 1h 10m (was: 1h) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=643964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643964 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 31/Aug/21 10:57 Start Date: 31/Aug/21 10:57 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [![Coverage Status](https://coveralls.io/builds/42501247/badge)](https://coveralls.io/builds/42501247) Coverage decreased (-0.6%) to 77.521% when pulling **1bb61b675b00866aea512b12adf2678201dca609 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 643964) Time Spent: 1h (was: 50m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=643330&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643330 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 30/Aug/21 08:23 Start Date: 30/Aug/21 08:23 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-908147305 OK! I've removed all deprecated classes and their tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 643330) Time Spent: 50m (was: 40m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640681&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640681 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 23/Aug/21 12:12 Start Date: 23/Aug/21 12:12 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-903709210 @jochenw What do you think about these changes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640681) Time Spent: 40m (was: 0.5h) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640217 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 20/Aug/21 12:19 Start Date: 20/Aug/21 12:19 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [![Coverage Status](https://coveralls.io/builds/42296738/badge)](https://coveralls.io/builds/42296738) Coverage decreased (-0.02%) to 78.1% when pulling **79d91fd9f5b803dca23ca269b073361de051e6e3 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640217) Time Spent: 0.5h (was: 20m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640203 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 20/Aug/21 11:16 Start Date: 20/Aug/21 11:16 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902621364 With this improvement Apache Wicket 10.x file upload functionality is fully functional with Jakarta Servlet API 5.0! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640203) Time Spent: 20m (was: 10m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640202 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 20/Aug/21 11:14 Start Date: 20/Aug/21 11:14 Worklog Time Spent: 10m Work Description: martin-g opened a new pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109 It should be neutral. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640202) Remaining Estimate: 0h Time Spent: 10m > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)