[jira] [Commented] (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438154#comment-13438154 ] Thomas Neidhart commented on CODEC-88: -- Base32 has been part of codec since release 1.5, shouldn't we close this issue and put a note in the changes/release-notes? Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Fix For: 1.x Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438161#comment-13438161 ] Gary D. Gregory commented on CODEC-88: -- Makes sense. Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Fix For: 1.x Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986941#action_12986941 ] Sebb commented on CODEC-88: --- The bulk of the implementation is now complete; also added encode/decode for the Hex version of the Base32 alphabet. To be resolved still: - whether to support decoding lower-case letters, and what API changes would be needed Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986990#action_12986990 ] Gary Gregory commented on CODEC-88: --- Thank you for the implementation! FYI: Cobertura reports low code/branch coverage: 57% / 33%. Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986993#action_12986993 ] Gary Gregory commented on CODEC-88: --- Whether to support decoding lower-case letters, and what API changes would be needed Where is that in the RFC? Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987021#action_12987021 ] Sebb commented on CODEC-88: --- Yes, needs many more tests. Lower-case letters are mentioned in section 3.4. Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986577#action_12986577 ] Gary Gregory commented on CODEC-88: --- I would make sense, but who knows until you write some code... Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986600#action_12986600 ] Julius Davies commented on CODEC-88: Two things scare me off 1. Base32 is 5 bits which is relatively prime to 8, unlike the nicer 6 to 8 situation that arises with Base64. But the main problem. so many unit tests to write. Ugh! Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986622#action_12986622 ] Sebb commented on CODEC-88: --- I've just been taking a look - only the encode and decode routines seem to know anything about the low level details. The rest of the code is likely to be common. The I/O streams likewise really only need the underlying Base64 or Base32 instance; I suspect otherwise the code will be identical. From [1] BASE64 characters are 6 bits in length. They are formed by taking a block of three octets to form a 24-bit string, which is converted into four BASE64 characters. BASE32 characters are 5 bits in length. They are formed by taking a block of five octets to form a 40-bit string, which is converted into eight BASE32 characters. This will make encode and especially decode a bit longer, as they have to deal with larger blocks of characters, but won't make things intrinsically harder. Regarding unit tests - we need those whatever imlementation is chosen. [1] http://www.garykessler.net/library/base64.html Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12986170#action_12986170 ] Julius Davies commented on CODEC-88: If we get it from here it's Public Domain (ASL 2.0 compatible) and not LGPL: http://bitcollider.cvs.sourceforge.net/viewvc/bitcollider/jbitcollider/plugins/org.bitpedia.collider.core/src/org/bitpedia/util/Base32.java?revision=1.2content-type=text/plain As a co-author, Gordon Mohr, Co-Founder of Bitzi, has the authority to declare this code as public domain: http://xavvy.com/ I think we should leave the Bitzi attribution public domain declaration @author tags in place if we take this code. Also, I could not locate any unit tests for this code. Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985484#action_12985484 ] Gary Gregory commented on CODEC-88: --- Can someone sort out the licensing with this code? Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785438#action_12785438 ] Gary Gregory commented on CODEC-88: --- The code comment talk about licenses that are not Apache 2.0, so I am not sure if we can use this as is. If you want this feature included, we need help with: - The code must be submitted under the Apache 2.0 license. - The code must fit in the Commons Codec style/framework/interfaces. - The code must have unit tests. Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Attachments: Base32.java Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CODEC-88) Base32 encoder
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781277#action_12781277 ] Gary Gregory commented on CODEC-88: --- Sure, submit a patch! :) Base32 encoder -- Key: CODEC-88 URL: https://issues.apache.org/jira/browse/CODEC-88 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Eric Olander Priority: Minor Any chance of getting Base32 encoding support along the lines of the existing Base64 encoder? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
