[jira] [Commented] (COMPRESS-18) JarArchiveEntry does not populate manifestAttributes or certificates
[ https://issues.apache.org/jira/browse/COMPRESS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560749#comment-13560749 ] Stefan Bodewig commented on COMPRESS-18: +1 to deprecations and documenting the methods return null. Throwing exceptions would be a bit too much IMHO (even though I don't believe anybody is actually calling either method). > JarArchiveEntry does not populate manifestAttributes or certificates > > > Key: COMPRESS-18 > URL: https://issues.apache.org/jira/browse/COMPRESS-18 > Project: Commons Compress > Issue Type: Bug > Components: Archivers >Reporter: Sebb >Priority: Minor > Fix For: 2.0 > > Attachments: compress-18.patch > > > JarArchiveEntry does not populate manifestAttributes or certificates - they > are both always null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COMPRESS-18) JarArchiveEntry does not populate manifestAttributes or certificates
[ https://issues.apache.org/jira/browse/COMPRESS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560664#comment-13560664 ] Sebb commented on COMPRESS-18: -- Given that getManifestAttributes() does not work - and the corresponding JVM method is called getAttributes() - perhaps we should deprecate it now? Also, any objections to adding Javadoc to the two methods to say that they currently always return null? Or, given that they are not implemented, maybe they should throw an unchecked exception? [If so, this would be documented of course] > JarArchiveEntry does not populate manifestAttributes or certificates > > > Key: COMPRESS-18 > URL: https://issues.apache.org/jira/browse/COMPRESS-18 > Project: Commons Compress > Issue Type: Bug > Components: Archivers >Reporter: Sebb >Priority: Minor > Fix For: 2.0 > > Attachments: compress-18.patch > > > JarArchiveEntry does not populate manifestAttributes or certificates - they > are both always null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COMPRESS-18) JarArchiveEntry does not populate manifestAttributes or certificates
[ https://issues.apache.org/jira/browse/COMPRESS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864193#action_12864193 ] Jukka Zitting commented on COMPRESS-18: --- Is there anything else we need to do for this? I'd be happy to help if needed. > JarArchiveEntry does not populate manifestAttributes or certificates > > > Key: COMPRESS-18 > URL: https://issues.apache.org/jira/browse/COMPRESS-18 > Project: Commons Compress > Issue Type: Bug >Reporter: Sebb >Priority: Minor > Fix For: 1.1 > > Attachments: compress-18.patch > > > JarArchiveEntry does not populate manifestAttributes or certificates - they > are both always null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-18) JarArchiveEntry does not populate manifestAttributes or certificates
[ https://issues.apache.org/jira/browse/COMPRESS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856985#action_12856985 ] Jukka Zitting commented on COMPRESS-18: --- Ah, I see. Thanks! > JarArchiveEntry does not populate manifestAttributes or certificates > > > Key: COMPRESS-18 > URL: https://issues.apache.org/jira/browse/COMPRESS-18 > Project: Commons Compress > Issue Type: Bug >Reporter: Sebb >Priority: Minor > Fix For: 1.1 > > Attachments: compress-18.patch > > > JarArchiveEntry does not populate manifestAttributes or certificates - they > are both always null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COMPRESS-18) JarArchiveEntry does not populate manifestAttributes or certificates
[ https://issues.apache.org/jira/browse/COMPRESS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856894#action_12856894 ] Stefan Bodewig commented on COMPRESS-18: It addresses the issue by making JarArchiveEntry extend JarEntry now - which provides access to the manifest attributes and certificates. > JarArchiveEntry does not populate manifestAttributes or certificates > > > Key: COMPRESS-18 > URL: https://issues.apache.org/jira/browse/COMPRESS-18 > Project: Commons Compress > Issue Type: Bug >Reporter: Sebb >Priority: Minor > Fix For: 1.1 > > Attachments: compress-18.patch > > > JarArchiveEntry does not populate manifestAttributes or certificates - they > are both always null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COMPRESS-18) JarArchiveEntry does not populate manifestAttributes or certificates
[ https://issues.apache.org/jira/browse/COMPRESS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856846#action_12856846 ] Jukka Zitting commented on COMPRESS-18: --- What's the benefit of the proposed change? It doesn't seem to address the topic of this issue. > JarArchiveEntry does not populate manifestAttributes or certificates > > > Key: COMPRESS-18 > URL: https://issues.apache.org/jira/browse/COMPRESS-18 > Project: Commons Compress > Issue Type: Bug >Reporter: Sebb >Priority: Minor > Fix For: 1.1 > > Attachments: compress-18.patch > > > JarArchiveEntry does not populate manifestAttributes or certificates - they > are both always null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira