[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931909#action_12931909
]
Gilles commented on MATH-440:
-
I'm commenting at the same time on dev; we should decide on a single
communication channel :(
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931905#action_12931905
]
Luc Maisonobe commented on MATH-440:
Looking more precisely, it is not possible to have both a one pattern and a two
patterns constructors since they are followed by variable arguments (that would
be ambiguous).
So I would rather have only a two patterns argument (either or both can be
null) to let the user tune his message at will.
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931902#action_12931902
]
Luc Maisonobe commented on MATH-440:
Yes, this is exactly what I understood and this is what bothers me: we add a
generic part to a user exception and the user as absolutely no way to prevent
us from doing so.
If the user does not want the generic part, he simply cannot have what he wants.
What about providing two constructors then ? I can write the explanations for
both.
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931899#action_12931899
]
Gilles commented on MATH-440:
-
I'm not sure I understand what the problem is but as the recent exchange on the
dev ML has shown, there was some misunderstanding, which is now cleared, I
think.
Thus, USER_EXCEPTION is the "general" message that will always appear even if
the user calls the default constructor to instantiate a {{MathUserException}}.
In the constructor that takes a pattern, it is going to format the "specific"
part of the message log.
I didn't include a constructor with 2 {{Localizable}} to avoid convoluted
explanations...
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931835#action_12931835
]
Luc Maisonobe commented on MATH-440:
As this exception is really a user exception, I would suggest not to tweak the
message ourselves.
So I would like to replace the LocalizedFormats.USER_EXCEPTION general part and
let only the user specific part.
What do you think ?
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931823#action_12931823
]
Gilles commented on MATH-440:
-
{{FunctionEvaluationException}} deprecated in revision 1034995.
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931569#action_12931569
]
Gilles commented on MATH-440:
-
As per the discussion on the dev ML, the constructor of the
{{MathUserException}} now takes a {{Localizable}} argument (revision 1034601 in
trunk).
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931476#action_12931476
]
Gilles commented on MATH-440:
-
Luc,
I'll let you take care of removing "DerivativeException" since you said that
you were going to make changes in the "ode" package.
And I think that "IntegratorException" is also a candidate for removal.
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931456#action_12931456
]
Gilles commented on MATH-440:
-
New class introduced in revision 1034487 for trunk.
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-440) Introducing a "UserException" class
[
https://issues.apache.org/jira/browse/MATH-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931439#action_12931439
]
Gilles commented on MATH-440:
-
New class introduced in revision 1034457 for branch MATH_2_X.
Superseded classes were deprecated.
> Introducing a "UserException" class
> ---
>
> Key: MATH-440
> URL: https://issues.apache.org/jira/browse/MATH-440
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Gilles
>Assignee: Gilles
>Priority: Minor
> Fix For: 2.2
>
>
> After a discussion in MATH-425, it was concluded that a new "UserException"
> could be created and advertised as a privileged channel to convey failure
> information through the CM code layer.
> The usage of this exception is the same as the one intended for the current
> {{FunctionEvaluationException}}, {{MatrixVisitorException}} and
> {{DerivativeException}}, so those classes will be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
