[ https://issues.apache.org/jira/browse/NET-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-318. ---------------------- Resolution: Fixed Fix Version/s: 3.0 Fixed as part of NET-364 > Article.references field is never updated; extremely inefficient > implementation > ------------------------------------------------------------------------------- > > Key: NET-318 > URL: https://issues.apache.org/jira/browse/NET-318 > Project: Commons Net > Issue Type: Bug > Components: NNTP > Affects Versions: 2.0 > Reporter: Sebb > Priority: Minor > Fix For: 3.0 > > > Article.references is a private StringBuffer instance. > The method addReference(String) inserts the reference into the buffer > followed by a tab. > However, as far as I can tell, this is never called. > The method getReferences() - which is used - has to parse the StringBuffer in > order to find the references. > Since the buffer is only used in the add and get methods, it does not make > sense to handle the references this way. > Even if the buffer were used (e.g. as part of a toString() method) it would > still be better to store the references as a List or Array. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira