[jira] [Updated] (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CODEC-91: - Fix Version/s: (was: 1.6) 1.x > Handling of embedded padding in base64 encoded data changed in 1.4 > -- > > Key: CODEC-91 > URL: https://issues.apache.org/jira/browse/CODEC-91 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.4 >Reporter: Chris Pimlott >Assignee: Julius Davies > Fix For: 1.x > > Attachments: codec-91-actually-works-and-tests-yay.patch > > > 1.4 changed the way that embedded padding characters (i.e. "=") were handled > when decoding base64 data. Previously, the decoder ignored them and decoded > all the data. Now it stops upon encountering the first padding byte. This > breaks compatibility with previous versions. > For example, in 1.4, > b64.decode("Y29tbW9ucwo=".getBytes()); > gives the same result as > b64.decode("Y29tbW9ucwo=Y29tbW9ucwo=".getBytes()); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Yandell updated CODEC-91: --- Fix Version/s: 1.6 At this point the new behaviour should be the default. Setting the version to 1.6 though as this issue should be resolved (somehow) for the next release. > Handling of embedded padding in base64 encoded data changed in 1.4 > -- > > Key: CODEC-91 > URL: https://issues.apache.org/jira/browse/CODEC-91 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.4 >Reporter: Chris Pimlott >Assignee: Julius Davies > Fix For: 1.6 > > Attachments: codec-91-actually-works-and-tests-yay.patch > > > 1.4 changed the way that embedded padding characters (i.e. "=") were handled > when decoding base64 data. Previously, the decoder ignored them and decoded > all the data. Now it stops upon encountering the first padding byte. This > breaks compatibility with previous versions. > For example, in 1.4, > b64.decode("Y29tbW9ucwo=".getBytes()); > gives the same result as > b64.decode("Y29tbW9ucwo=Y29tbW9ucwo=".getBytes()); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julius Davies updated CODEC-91: --- Attachment: codec-91-actually-works-and-tests-yay.patch This is a much better patch - it actually works. And to respond to Sebb, I think we should bring back the original 1.3 behaviour as the default behaviour. We can later consider allowing alternative behaviour via flags or config or some other mechanism. > Handling of embedded padding in base64 encoded data changed in 1.4 > -- > > Key: CODEC-91 > URL: https://issues.apache.org/jira/browse/CODEC-91 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.4 >Reporter: Chris Pimlott > Attachments: codec-91-actually-works-and-tests-yay.patch > > > 1.4 changed the way that embedded padding characters (i.e. "=") were handled > when decoding base64 data. Previously, the decoder ignored them and decoded > all the data. Now it stops upon encountering the first padding byte. This > breaks compatibility with previous versions. > For example, in 1.4, > b64.decode("Y29tbW9ucwo=".getBytes()); > gives the same result as > b64.decode("Y29tbW9ucwo=Y29tbW9ucwo=".getBytes()); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julius Davies updated CODEC-91: --- Attachment: (was: codec-91.patch) > Handling of embedded padding in base64 encoded data changed in 1.4 > -- > > Key: CODEC-91 > URL: https://issues.apache.org/jira/browse/CODEC-91 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.4 >Reporter: Chris Pimlott > > 1.4 changed the way that embedded padding characters (i.e. "=") were handled > when decoding base64 data. Previously, the decoder ignored them and decoded > all the data. Now it stops upon encountering the first padding byte. This > breaks compatibility with previous versions. > For example, in 1.4, > b64.decode("Y29tbW9ucwo=".getBytes()); > gives the same result as > b64.decode("Y29tbW9ucwo=Y29tbW9ucwo=".getBytes()); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julius Davies updated CODEC-91: --- Attachment: codec-91.patch The attached patch brings back the original commons-codec-1.3.jar behaviour as requested by Chris Pimlott. NOTE: This is another way to unearth the bug in CODEC-98, so we'll need the CODEC-98 fix if we accept this patch. > Handling of embedded padding in base64 encoded data changed in 1.4 > -- > > Key: CODEC-91 > URL: https://issues.apache.org/jira/browse/CODEC-91 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.4 >Reporter: Chris Pimlott > Attachments: codec-91.patch > > > 1.4 changed the way that embedded padding characters (i.e. "=") were handled > when decoding base64 data. Previously, the decoder ignored them and decoded > all the data. Now it stops upon encountering the first padding byte. This > breaks compatibility with previous versions. > For example, in 1.4, > b64.decode("Y29tbW9ucwo=".getBytes()); > gives the same result as > b64.decode("Y29tbW9ucwo=Y29tbW9ucwo=".getBytes()); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.