[jira] [Created] (CB-5023) www folder empty when using CLI create
Sebastian Zillessen created CB-5023:
---
Summary: www folder empty when using CLI create
Key: CB-5023
URL: https://issues.apache.org/jira/browse/CB-5023
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Affects Versions: 3.1.0
Environment: Mac OSX 10.8.5
Reporter: Sebastian Zillessen
When I create a new cordova project with
{code}
cordova create -d MyTest de.sebastianzillessen.mytest MapTest
Creating a new cordova project with name MapTest and id
de.sebastianzillessen.mytest at location
/Users/sebastianzillessen/Spitzeljagd_Entwicklung/2.0/prototypes/MyTest
Using stock cordova hello-world application.
cordova library for www already exists. No need to download. Continuing.
Copying stock Cordova www assets into
/Users/sebastianzillessen/Spitzeljagd_Entwicklung/2.0/prototypes/MyTest/www
{code}
the CLI creates the project but the complete `www`-folder is empty.
The folder did not exists before.
I installed cordova with
{code}
npm install -g cordova
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Created] (CB-5024) Windows8 CLI .NET Framework Error
Clément Hardouin created CB-5024: Summary: Windows8 CLI .NET Framework Error Key: CB-5024 URL: https://issues.apache.org/jira/browse/CB-5024 Project: Apache Cordova Issue Type: Bug Components: Windows 8 Affects Versions: 3.1.0 Environment: Windows 8 Pro Reporter: Clément Hardouin Assignee: Jesse MacFadyen When trying to add the windows8 platform on my existing project, the following error shows up: Please install the .NET Framwork v4.0.30319 (in the latest windows phone SDK's) Make sure the msbuild command in your path is pointing to v4.0.30319 of msbuild as well (inside C:\Windows\Microsoft.NET\Framework\v4.0.30319). To solve the problem, you need to edit the following file : .cordova/lib/windows8/cordova/3.1.0/windows8/bin/check_reqs.js On line 80, add a capital letter to Version : var msversion = output.match(/\.NET\sFramework\,\sVersion\s4\.0/); -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5025) WP7 localStorage.getItem unexpected behaviour.
Elvedin Hamzagic created CB-5025: Summary: WP7 localStorage.getItem unexpected behaviour. Key: CB-5025 URL: https://issues.apache.org/jira/browse/CB-5025 Project: Apache Cordova Issue Type: Bug Reporter: Elvedin Hamzagic Priority: Minor Javascript for WP7 localStorage.getItem returns string 'undefined' when specified key exists and value is undefined. This scenario can be triggered when adding some key/value to localStorage, then removing it. The actual line in code in getItem function, which produce this behaviour, is: retVal = window.unescape(decodeURIComponent(this._result)); The problem is that decodeURIComponent return string 'undefined' when input is undefined, and this should be fixed somehow like this: retVal = this._result ? window.unescape(decodeURIComponent(this._result)) : this._result; -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-2293) File Transfer of picture fails on every other picture
[
https://issues.apache.org/jira/browse/CB-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790281#comment-13790281
]
Andrew Grieve commented on CB-2293:
---
There were some fixes to OkHttp that sound promising:
https://github.com/square/okhttp/commit/155a516b54ed60ec796cf5b9f2d8705012c5ceae
It's possible that if you update the version of OkHttp that the problem will be
fixed.
You would do so by:
1. Check out cordova-android from
https://git-wip-us.apache.org/repos/asf?p=cordova-android.git
2. Swap in a new version of OkHttp (under framework/src/com/squareup/okhttp)
3. Go into your projects/android directory
4. Run path/to/cordova-android/bin/update
If that doesn't work, then a work-around is to just retry a failed request.
File Transfer of picture fails on every other picture
-
Key: CB-2293
URL: https://issues.apache.org/jira/browse/CB-2293
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 2.2.0, 2.3.0
Environment: Tested on a Motorola Atrix HD(Android 4.1.2) as well as
a Samsung Galaxy S3(Android 4.1.1)
Reporter: Amrit Kahlon
Assignee: Ian Clelland
Fix For: 2.8.0
Attachments: cordova-2.4.0rc1.jar
When uploading pictures using the File Transfer function on android, the
first picture will upload fine. Then the second upload will give the
following error:
01-21 13:48:02.545: W/FileTransfer(8894): Error getting HTTP status code from
connection.
01-21 13:48:02.545: W/FileTransfer(8894): java.io.EOFException
01-21 13:48:02.545: W/FileTransfer(8894): at
libcore.io.Streams.readAsciiLine(Streams.java:203)
01-21 13:48:02.545: W/FileTransfer(8894): at
libcore.net.http.HttpEngine.readResponseHeaders(HttpEngine.java:560)
01-21 13:48:02.545: W/FileTransfer(8894): at
libcore.net.http.HttpEngine.readResponse(HttpEngine.java:813)
01-21 13:48:02.545: W/FileTransfer(8894): at
libcore.net.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:274)
01-21 13:48:02.545: W/FileTransfer(8894): at
libcore.net.http.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:486)
01-21 13:48:02.545: W/FileTransfer(8894): at
org.apache.cordova.FileTransfer.createFileTransferError(FileTransfer.java:535)
01-21 13:48:02.545: W/FileTransfer(8894): at
org.apache.cordova.FileTransfer.access$500(FileTransfer.java:62)
01-21 13:48:02.545: W/FileTransfer(8894): at
org.apache.cordova.FileTransfer$1.run(FileTransfer.java:437)
01-21 13:48:02.545: W/FileTransfer(8894): at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
01-21 13:48:02.545: W/FileTransfer(8894): at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
01-21 13:48:02.545: W/FileTransfer(8894): at
java.lang.Thread.run(Thread.java:856)
01-21 13:48:02.555: E/FileTransfer(8894):
{target:http:\/\/xxx.xxx.xxx\/api\/photo_uploads\/create?version=2api_key=xsource=androidapp-2.2.1,source:file:\/\/\/storage\/sdcard0\/Android\/data\/com.hockeycommunity.hc_app\/cache\/resize.jpg?1358804880392,code:3}
01-21 13:48:02.555: E/FileTransfer(8894): java.net.SocketException: sendto
failed: EPIPE (Broken pipe)
01-21 13:48:02.555: E/FileTransfer(8894): at
libcore.io.IoBridge.maybeThrowAfterSendto(IoBridge.java:506)
01-21 13:48:02.555: E/FileTransfer(8894): at
libcore.io.IoBridge.sendto(IoBridge.java:475)
01-21 13:48:02.555: E/FileTransfer(8894): at
java.net.PlainSocketImpl.write(PlainSocketImpl.java:508)
01-21 13:48:02.555: E/FileTransfer(8894): at
java.net.PlainSocketImpl.access$100(PlainSocketImpl.java:46)
01-21 13:48:02.555: E/FileTransfer(8894): at
java.net.PlainSocketImpl$PlainSocketOutputStream.write(PlainSocketImpl.java:270)
01-21 13:48:02.555: E/FileTransfer(8894): at
libcore.net.http.FixedLengthOutputStream.write(FixedLengthOutputStream.java:41)
01-21 13:48:02.555: E/FileTransfer(8894): at
java.io.DataOutputStream.write(DataOutputStream.java:98)
01-21 13:48:02.555: E/FileTransfer(8894): at
org.apache.cordova.FileTransfer$1.run(FileTransfer.java:372)
01-21 13:48:02.555: E/FileTransfer(8894): at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
01-21 13:48:02.555: E/FileTransfer(8894): at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
01-21 13:48:02.555: E/FileTransfer(8894): at
java.lang.Thread.run(Thread.java:856)
01-21 13:48:02.555: E/FileTransfer(8894): Caused by:
libcore.io.ErrnoException: sendto failed: EPIPE (Broken pipe)
01-21 13:48:02.555: E/FileTransfer(8894): at
libcore.io.Posix.sendtoBytes(Native Method)
01-21 13:48:02.555: E/FileTransfer(8894): at
[jira] [Updated] (CB-5024) Windows8 CLI .NET Framework Error
[ https://issues.apache.org/jira/browse/CB-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clément Hardouin updated CB-5024: - Priority: Minor (was: Major) Windows8 CLI .NET Framework Error - Key: CB-5024 URL: https://issues.apache.org/jira/browse/CB-5024 Project: Apache Cordova Issue Type: Bug Components: Windows 8 Affects Versions: 3.1.0 Environment: Windows 8 Pro Reporter: Clément Hardouin Assignee: Jesse MacFadyen Priority: Minor When trying to add the windows8 platform on my existing project, the following error shows up: Please install the .NET Framwork v4.0.30319 (in the latest windows phone SDK's) Make sure the msbuild command in your path is pointing to v4.0.30319 of msbuild as well (inside C:\Windows\Microsoft.NET\Framework\v4.0.30319). To solve the problem, you need to edit the following file : .cordova/lib/windows8/cordova/3.1.0/windows8/bin/check_reqs.js On line 80, add a capital letter to Version : var msversion = output.match(/\.NET\sFramework\,\sVersion\s4\.0/); -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4954) BBB10 Plugin, use of static callbacks required for camera_take_burst cause entire plugin to fail
[ https://issues.apache.org/jira/browse/CB-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790288#comment-13790288 ] Ryan Sweny commented on CB-4954: Hi Jeffrey, You now have access to the plugin and sample project here: https://github.com/Motek/DiscreteCameraPlugin If you build it, install the plugin to the sample, then run the sample you should see that deviceReady is fired and a bunch of debug messages print to the screen and through WebInspector. If you then uncomment the code below to actually save a photo, you should find the sample then fails to run at all: https://github.com/Motek/DiscreteCameraPlugin/blob/master/plugin/src/blackberry10/native/src/discretecamera_ndk.cpp#L73 BBB10 Plugin, use of static callbacks required for camera_take_burst cause entire plugin to fail Key: CB-4954 URL: https://issues.apache.org/jira/browse/CB-4954 Project: Apache Cordova Issue Type: Bug Components: BlackBerry, Plugin Camera Affects Versions: 3.0.0 Environment: Windows 7 64-bit, BB OS 10.1, Z10 Reporter: Ryan Sweny Adding new methods to my BlackBerry plugin has gone well until I needed to include camera functionality. Adding a function like this: static void still_callback(camera_handle_t handle, camera_buffer_t* buf, void* arg) resulted the entire plugin failing on startup. The error given on the BlackBerry is: [JavaScript Alert] Require Error Can'[t find /usr/lib/webplatform/plugins/jnext/libDiscreteCamera.so Library cannot be found Are static methods allowed in BlackBerry plugins? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4971) Installation of plugins does not work for iOS
[ https://issues.apache.org/jira/browse/CB-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790302#comment-13790302 ] Oleg commented on CB-4971: -- [~ritterb82]: the workaround is to complete the installation manually. Check the location of the red files in the Xcode. Copy the files there. Add the frameworks if required (you will know it if running the app from Xcode fails). Update the config.xml file (the one which is outside of the www directory). e.g. add feature name=Device param name=ios-package value=CDVDevice / /feature Installation of plugins does not work for iOS - Key: CB-4971 URL: https://issues.apache.org/jira/browse/CB-4971 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts, Plugin Device, Plugin Dialogs Affects Versions: 3.0.0, 3.1.0 Environment: iOS Reporter: Oleg Priority: Critical Labels: ios, plugin Fix For: Master, 3.0.0, 3.1.0 Original Estimate: 72h Remaining Estimate: 72h Installation of iOS plugins does not work for iOS. Update: does not work in 3.1 cordova either. When installing the plugin via cordova plugin add, the plugins fail to install correctly to the iOS platform: - source code (.js, .m, .h and .bundle) files are not copied over - proper frameworks are not being added to the project - config.xml file is not updated with plugin information Tried it on Device, Contacts and Dialogs and some other plugins. Update: tried on network-information plugin with cordova 3.1 the workaround is to perform the above steps manually. but it is not documented anywhere. Note: it worked for me during one test, when the project was fresh. However after making a few minor changes and running cordova prepare or cordova build a few times, it stops working for iOS - i.e. you cannot add plugins without issues above. Android works fine. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4952) resolveLocalFileSystemURI returns SECURITY_ERROR wrongly in iOS
[
https://issues.apache.org/jira/browse/CB-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790331#comment-13790331
]
David Jung commented on CB-4952:
Same problem in Cordova 3.1.0.
Capture Video from Cam on iOS and resolve file name (/private/var/...) returns
SecurityError
resolveLocalFileSystemURI returns SECURITY_ERROR wrongly in iOS
---
Key: CB-4952
URL: https://issues.apache.org/jira/browse/CB-4952
Project: Apache Cordova
Issue Type: Bug
Components: Plugin File
Affects Versions: 3.0.0
Environment: iOS
Reporter: Kuan Yi Ming
Assignee: Ian Clelland
The simplified version of resolveLocalFileSystemURI in the 3.0.0 file plugin
doesn't properly check the URI if it's in the tmp or Documents folder and
returns FileError.SECURITY_ERROR instead. This doesn't occur in 2.9.0.
For example, trying to resolve a URI of a video file from using getPicture().
Calling the following lines in CDVFile.m using the above example:
{code:java}
NSLog(@url path: %@, path);
NSLog(@docs path: %@, self.appDocsPath);
NSLog(@temp path: %@, self.appTempPath);
{code}
returns these:
url path: /private/var/mobile/Applications/[app id]/tmp//trim.TpPlJN.MOV
docs path: /var/mobile/Applications/[app id]/Documents
temp path: /var/mobile/Applications/[app id]/tmp
Since the security error check uses hasPrefix against self.appDocsPath and
self.appTempPath here, it fails the check.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (CB-4482) iOS Globalization calls fail with ERROR: Method 'xxx' not defined in Globalization
[
https://issues.apache.org/jira/browse/CB-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790344#comment-13790344
]
peter miller commented on CB-4482:
--
Yup, that seems to be fixed on cordova 3.1. (I created a new project and added
the plugins with cordova 3.1. I then pulled across the html, prepared it from
the CLI, and compiled it with Xcode. All fine.) Thanks.
iOS Globalization calls fail with ERROR: Method 'xxx' not defined in
Globalization
--
Key: CB-4482
URL: https://issues.apache.org/jira/browse/CB-4482
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Globalization
Affects Versions: 3.0.0
Environment: iOS is the only platform currently added. And its being
run on a Mac.
Reporter: peter miller
Assignee: Steve Gill
Calling navigator.globalization.getDateNames failed with the following:
2013-08-01 13:21:26.768 Luna Solaria[2590:907] ERROR: Method 'getDateNames:'
not defined in Plugin 'Globalization' 2013-08-01 13:21:26.770 Luna
Solaria[2590:907] -[CDVCommandQueue executePending] [Line 116] FAILED
pluginJSON = [ Globalization1635930361, Globalization, getDateNames, [
{ options : { item : months, type : narrow } } ] ]
Every other method of globalization I've tried has had the same result.
Other plugins seem to work okay. And the plugin is definitely installed.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Created] (CB-5026) Move setting of UIWebView properties into its own plugin from the core
Shazron Abdullah created CB-5026: Summary: Move setting of UIWebView properties into its own plugin from the core Key: CB-5026 URL: https://issues.apache.org/jira/browse/CB-5026 Project: Apache Cordova Issue Type: Task Components: iOS Affects Versions: Master Reporter: Shazron Abdullah Priority: Minor Fix For: 3.2.0 See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400 (except for the CDVLocalStorage stuff) This 150 line behemoth should be in its own plugin (with onload=true). Not sure about removing it from core, but putting it in its own plugin in core is a start. This way, if there are any iOS changes, people can just update a a plugin, and they won't have to update any core code just to get the latest bits. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5027) Application Error: There was a network error.
Paulo Pacheco created CB-5027: - Summary: Application Error: There was a network error. Key: CB-5027 URL: https://issues.apache.org/jira/browse/CB-5027 Project: Apache Cordova Issue Type: Bug Components: Android, App Hello World Affects Versions: 3.1.0 Environment: Windows7 Reporter: Paulo Pacheco Priority: Blocker 1 - Install Cordova CLI 3.1.0 2 - cordova create model org,sample ModelApp 3- cordova platform add android 4- cordova build -d android 5- cordova emulate android Error in LogCat: E/CordovaWebView(3677): CordovaWebView: TIMEOUT ERROR! Error in Emulator: There was a network error. (file:///android_asset/www/index.html) Tree of project: ├───.cordova │ └───hooks │ ├───after_build │ ├───after_compile │ ├───after_docs │ ├───after_emulate │ ├───after_platform_add │ ├───after_platform_ls │ ├───after_platform_rm │ ├───after_plugin_add │ ├───after_plugin_ls │ ├───after_plugin_rm │ ├───after_prepare │ ├───after_run │ ├───before_build │ ├───before_compile │ ├───before_docs │ ├───before_emulate │ ├───before_platform_add │ ├───before_platform_ls │ ├───before_platform_rm │ ├───before_plugin_add │ ├───before_plugin_ls │ ├───before_plugin_rm │ ├───before_prepare │ └───before_run ├───merges │ └───android ├───platforms │ └───android │ ├───assets │ │ └───www │ │ └───cordova-app-hello-world-3.1.0-5683220 │ │ └───www │ │ ├───css │ │ ├───img │ │ ├───js │ │ └───res │ │ ├───icon │ │ │ ├───android │ │ │ ├───bada │ │ │ ├───bada-wac │ │ │ ├───blackberry │ │ │ ├───blackberry10 │ │ │ ├───ios │ │ │ ├───tizen │ │ │ ├───webos │ │ │ └───windows-phone │ │ └───screen │ │ ├───android │ │ ├───bada │ │ ├───bada-wac │ │ ├───blackberry │ │ ├───blackberry10 │ │ └───ios │ ├───bin │ │ ├───classes │ │ │ └───br │ │ │ └───com │ │ │ └───softplan │ │ │ └───mobilelab │ │ ├───dexedLibs │ │ └───res │ │ ├───drawable │ │ ├───drawable-hdpi │ │ ├───drawable-ldpi │ │ ├───drawable-mdpi │ │ └───drawable-xhdpi │ ├───cordova │ │ ├───lib │ │ └───node_modules │ │ ├───.bin │ │ └───shelljs │ │ ├───bin │ │ └───scripts │ ├───gen │ │ └───br │ │ └───com │ │ └───softplan │ │ └───mobilelab │ ├───libs │ ├───res │ │ ├───drawable │ │ ├───drawable-hdpi │ │ ├───drawable-ldpi │ │ ├───drawable-mdpi │ │ ├───drawable-xhdpi │ │ ├───values │ │ └───xml │ └───src │ └───br │ └───com │ └───softplan │ └───mobilelab ├───plugins └───www └───cordova-app-hello-world-3.1.0-5683220 └───www ├───css ├───img ├───js └───res ├───icon │ ├───android │ ├───bada │ ├───bada-wac │ ├───blackberry │ ├───blackberry10 │ ├───ios │ ├───tizen │ ├───webos │ └───windows-phone └───screen ├───android ├───bada ├───bada-wac ├───blackberry ├───blackberry10 └───ios -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (CB-5026) Move setting of UIWebView properties into its own plugin from the core
[ https://issues.apache.org/jira/browse/CB-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-5026: - Description: See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400 (except for the CDVLocalStorage stuff) This 150 line behemoth should be in its own plugin (with onload=true). Not sure about removing it from core, but putting it in its own plugin in core is a start. Pros: - if iOS = 8 adds more properties, and people want to stick to Cordova 3.A and we only support it in 3.B or 4.x, they only have to update a plugin and not the whole core. Cons: - if they rely on these settings, they will lose them when they upgrade if they don't install a plugin, this won't be any different when they moved from 2.x to 3.x - Yet Another Repo? was: See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400 (except for the CDVLocalStorage stuff) This 150 line behemoth should be in its own plugin (with onload=true). Not sure about removing it from core, but putting it in its own plugin in core is a start. This way, if there are any iOS changes, people can just update a a plugin, and they won't have to update any core code just to get the latest bits. Move setting of UIWebView properties into its own plugin from the core -- Key: CB-5026 URL: https://issues.apache.org/jira/browse/CB-5026 Project: Apache Cordova Issue Type: Task Components: iOS Affects Versions: Master Reporter: Shazron Abdullah Priority: Minor Fix For: 3.2.0 See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400 (except for the CDVLocalStorage stuff) This 150 line behemoth should be in its own plugin (with onload=true). Not sure about removing it from core, but putting it in its own plugin in core is a start. Pros: - if iOS = 8 adds more properties, and people want to stick to Cordova 3.A and we only support it in 3.B or 4.x, they only have to update a plugin and not the whole core. Cons: - if they rely on these settings, they will lose them when they upgrade if they don't install a plugin, this won't be any different when they moved from 2.x to 3.x - Yet Another Repo? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5028) Make whitelist rejection pop a visible dialog
Tony Hursh created CB-5028: -- Summary: Make whitelist rejection pop a visible dialog Key: CB-5028 URL: https://issues.apache.org/jira/browse/CB-5028 Project: Apache Cordova Issue Type: Improvement Reporter: Tony Hursh Priority: Minor Judging from the number of times it comes up in different forums, whitelist problems seem to be a recurrent pain point for new users. In XCode you get a log message when an URL is rejected (if it's not running in Xcode the app just fails silently, to all appearances). Maybe in addition to the log message, a visible dialog could be popped up. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5028) Make whitelist rejection pop a visible dialog
[ https://issues.apache.org/jira/browse/CB-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790585#comment-13790585 ] Shazron Abdullah commented on CB-5028: -- I think a better option is for the core to dispatch an event, that app devs can listen to, and choose to display if they want. Make whitelist rejection pop a visible dialog - Key: CB-5028 URL: https://issues.apache.org/jira/browse/CB-5028 Project: Apache Cordova Issue Type: Improvement Reporter: Tony Hursh Priority: Minor Judging from the number of times it comes up in different forums, whitelist problems seem to be a recurrent pain point for new users. In XCode you get a log message when an URL is rejected (if it's not running in Xcode the app just fails silently, to all appearances). Maybe in addition to the log message, a visible dialog could be popped up. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5029) CLI should show plugin dependencies
Marcel Kinard created CB-5029:
-
Summary: CLI should show plugin dependencies
Key: CB-5029
URL: https://issues.apache.org/jira/browse/CB-5029
Project: Apache Cordova
Issue Type: New Feature
Components: Plugman
Reporter: Marcel Kinard
Priority: Minor
It would be nice if the list of plugins could identify dependencies.
For example, instead of:
$ cordova plugin
[ 'org.apache.cordova.file',
'org.apache.cordova.file-transfer' ]
Perhaps it could say something like:
[ 'org.apache.cordova.file',
'org.apache.cordova.file-transfer',
{ dependencies:
{ 'org.apache.cordova-file-transfer': [ 'org.apache.cordova.file' ] }
} ]
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Created] (CB-5030) create git repo cordova-amazon-fireos
Brian LeRoux created CB-5030: Summary: create git repo cordova-amazon-fireos Key: CB-5030 URL: https://issues.apache.org/jira/browse/CB-5030 Project: Apache Cordova Issue Type: Bug Reporter: Brian LeRoux -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Closed] (CB-5030) create git repo cordova-amazon-fireos
[ https://issues.apache.org/jira/browse/CB-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian LeRoux closed CB-5030. Resolution: Fixed create git repo cordova-amazon-fireos - Key: CB-5030 URL: https://issues.apache.org/jira/browse/CB-5030 Project: Apache Cordova Issue Type: Bug Reporter: Brian LeRoux -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5031) Help text for platform update and plugin search is missing
Marcel Kinard created CB-5031: - Summary: Help text for platform update and plugin search is missing Key: CB-5031 URL: https://issues.apache.org/jira/browse/CB-5031 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Marcel Kinard Assignee: Mike Billau Priority: Minor Should be in cordova-cli/doc/help.txt and cordova-docs/guide/cli -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5032) platform ls and plugin ls commands are not clear in help text
Marcel Kinard created CB-5032: - Summary: platform ls and plugin ls commands are not clear in help text Key: CB-5032 URL: https://issues.apache.org/jira/browse/CB-5032 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Minor It's not clear in the CLI's help output how to invoke the ls subcommand for platforms and plugins. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5032) platform ls and plugin ls commands are not clear in help text
[ https://issues.apache.org/jira/browse/CB-5032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790646#comment-13790646 ] ASF subversion and git services commented on CB-5032: - Commit 9823bdddb0e042286a383e04aecec35d709d3d90 in branch refs/heads/master from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=9823bdd ] CB-5032: clarify the help text platform ls and plugin ls commands are not clear in help text - Key: CB-5032 URL: https://issues.apache.org/jira/browse/CB-5032 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Minor It's not clear in the CLI's help output how to invoke the ls subcommand for platforms and plugins. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (CB-5032) platform ls and plugin ls commands are not clear in help text
[ https://issues.apache.org/jira/browse/CB-5032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Kinard resolved CB-5032. --- Resolution: Fixed Fix Version/s: 3.2.0 updated doc/help.txt platform ls and plugin ls commands are not clear in help text - Key: CB-5032 URL: https://issues.apache.org/jira/browse/CB-5032 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Minor Fix For: 3.2.0 It's not clear in the CLI's help output how to invoke the ls subcommand for platforms and plugins. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5033) Write tests for firefoxos in cordova-cli
James Long created CB-5033: -- Summary: Write tests for firefoxos in cordova-cli Key: CB-5033 URL: https://issues.apache.org/jira/browse/CB-5033 Project: Apache Cordova Issue Type: Task Components: FirefoxOS Reporter: James Long I'm going to add firefox os to the spec/metadata folder in cordova-cli so that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Assigned] (CB-5005) Feature and Permissions docs wrong for Android plugins
[ https://issues.apache.org/jira/browse/CB-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Billau reassigned CB-5005: --- Assignee: Michael Brooks (was: Mike Billau) Added the rest of the commits to the pull request. I removed a few Android permissions because they were not listed in the plugin.xml - those removed permissions would never be added to the app in the first place. If they need to be there, then we would have bug reports for those plugins. Feature and Permissions docs wrong for Android plugins -- Key: CB-5005 URL: https://issues.apache.org/jira/browse/CB-5005 Project: Apache Cordova Issue Type: Bug Components: Plugin Battery Status, Plugin Camera, Plugin Console, Plugin Contacts, Plugin Device, Plugin Device Motion, Plugin Device Orientation, Plugin Dialogs, Plugin File, Plugin File Transfer, Plugin Geolocation, Plugin Globalization, Plugin InAppBrowser, Plugin Media, Plugin Media Capture, Plugin Network Information, Plugin SplashScreen, Plugin Vibration Affects Versions: Master Reporter: Mike Billau Assignee: Michael Brooks Priority: Trivial Most (all?) of the plugin documentation pages have the wrong value for the plugin id attribute in the Accessing the Feature section for Android. A lot of the plugins also seem to have the wrong list of Permissions that get added to the AndroidManifest.xml. This can be confusing for new users who follow along with the docs and expect to see something different in these files. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5033) Write tests for firefoxos in cordova-cli
[ https://issues.apache.org/jira/browse/CB-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790662#comment-13790662 ] James Long commented on CB-5033: I sent an email about this, but maybe this is a better place to discuss... A bunch of tests seem to be failing. It looks like iOS and android are find, but wp8 and blackberry fail. Are you guys doing continuous integration and running these tests anywhere automatically? `npm test` shouldn't have any errors, so if those platforms are deprecated or known not to be ready, they should be removed. Write tests for firefoxos in cordova-cli Key: CB-5033 URL: https://issues.apache.org/jira/browse/CB-5033 Project: Apache Cordova Issue Type: Task Components: FirefoxOS Reporter: James Long I'm going to add firefox os to the spec/metadata folder in cordova-cli so that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5028) Make whitelist rejection pop a visible dialog
[ https://issues.apache.org/jira/browse/CB-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790663#comment-13790663 ] Tony Hursh commented on CB-5028: The problem is that they don't even know the whitelist exists, so they wouldn't know to listen for the event, either. Make whitelist rejection pop a visible dialog - Key: CB-5028 URL: https://issues.apache.org/jira/browse/CB-5028 Project: Apache Cordova Issue Type: Improvement Reporter: Tony Hursh Priority: Minor Judging from the number of times it comes up in different forums, whitelist problems seem to be a recurrent pain point for new users. In XCode you get a log message when an URL is rejected (if it's not running in Xcode the app just fails silently, to all appearances). Maybe in addition to the log message, a visible dialog could be popped up. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5028) Make whitelist rejection pop a visible dialog
[ https://issues.apache.org/jira/browse/CB-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790675#comment-13790675 ] Shazron Abdullah commented on CB-5028: -- No question, devs will have to opt in, this is more of a dev documentation/awareness issue. Make whitelist rejection pop a visible dialog - Key: CB-5028 URL: https://issues.apache.org/jira/browse/CB-5028 Project: Apache Cordova Issue Type: Improvement Reporter: Tony Hursh Priority: Minor Judging from the number of times it comes up in different forums, whitelist problems seem to be a recurrent pain point for new users. In XCode you get a log message when an URL is rejected (if it's not running in Xcode the app just fails silently, to all appearances). Maybe in addition to the log message, a visible dialog could be popped up. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5028) Make whitelist rejection pop a visible dialog
[ https://issues.apache.org/jira/browse/CB-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790687#comment-13790687 ] Tony Hursh commented on CB-5028: Maybe it could be solved with documentation. It would probably have to be somewhere other than in a totally separate document that they may not even know enough to read. It's a real problem. I see at least four recent posts on the issue in the phonegap Google group right now, and that would just be the people who found their way there to ask for help. No telling how many others just give up, or waste hours of their time trying to figure out what's wrong. Make whitelist rejection pop a visible dialog - Key: CB-5028 URL: https://issues.apache.org/jira/browse/CB-5028 Project: Apache Cordova Issue Type: Improvement Reporter: Tony Hursh Priority: Minor Judging from the number of times it comes up in different forums, whitelist problems seem to be a recurrent pain point for new users. In XCode you get a log message when an URL is rejected (if it's not running in Xcode the app just fails silently, to all appearances). Maybe in addition to the log message, a visible dialog could be popped up. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5028) Make whitelist rejection pop a visible dialog
[ https://issues.apache.org/jira/browse/CB-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790688#comment-13790688 ] Shazron Abdullah commented on CB-5028: -- I know its a problem - but popping up visible dialogs as a solution will never get into the core, that's why I proposed the alternative. Make whitelist rejection pop a visible dialog - Key: CB-5028 URL: https://issues.apache.org/jira/browse/CB-5028 Project: Apache Cordova Issue Type: Improvement Reporter: Tony Hursh Priority: Minor Judging from the number of times it comes up in different forums, whitelist problems seem to be a recurrent pain point for new users. In XCode you get a log message when an URL is rejected (if it's not running in Xcode the app just fails silently, to all appearances). Maybe in addition to the log message, a visible dialog could be popped up. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4971) Installation of plugins does not work for iOS
[ https://issues.apache.org/jira/browse/CB-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790716#comment-13790716 ] Anis Kadri commented on CB-4971: For those people having issues xcodebuild -version The xcode project file (pbxproject) might have changed in Xcode 5.0 Installation of plugins does not work for iOS - Key: CB-4971 URL: https://issues.apache.org/jira/browse/CB-4971 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts, Plugin Device, Plugin Dialogs Affects Versions: 3.0.0, 3.1.0 Environment: iOS Reporter: Oleg Priority: Critical Labels: ios, plugin Fix For: Master, 3.0.0, 3.1.0 Original Estimate: 72h Remaining Estimate: 72h Installation of iOS plugins does not work for iOS. Update: does not work in 3.1 cordova either. When installing the plugin via cordova plugin add, the plugins fail to install correctly to the iOS platform: - source code (.js, .m, .h and .bundle) files are not copied over - proper frameworks are not being added to the project - config.xml file is not updated with plugin information Tried it on Device, Contacts and Dialogs and some other plugins. Update: tried on network-information plugin with cordova 3.1 the workaround is to perform the above steps manually. but it is not documented anywhere. Note: it worked for me during one test, when the project was fresh. However after making a few minor changes and running cordova prepare or cordova build a few times, it stops working for iOS - i.e. you cannot add plugins without issues above. Android works fine. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5034) Document plugin registry
Mike Billau created CB-5034: --- Summary: Document plugin registry Key: CB-5034 URL: https://issues.apache.org/jira/browse/CB-5034 Project: Apache Cordova Issue Type: Bug Components: Docs, Registry Affects Versions: Master Reporter: Mike Billau I can't find any reference to the plugin registry anywhere in our documentation. Am I looking in the wrong place or are we waiting for the web component to be more polished before announcing the registry? I think some places the registry should be mentioned: Plugman: readme.md CLI: cordova help command (CB-5031) readme.md docs: http://cordova.apache.org/docs/en/edge/guide_cli_index.md.html#The%20Command-line%20Interface (I think it's best to split the Add Platforms section into Add Platforms and Add Plugins, and in this new section talk about adding plugins, automatic plugin installation (plugin dependencies), and the registry) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5010) CLONE - Plugins Release - Oct 9 2013
[ https://issues.apache.org/jira/browse/CB-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790764#comment-13790764 ] Steve Gill commented on CB-5010: Oooo also found an issue with our release process steps for plugins. Since the last release we updated every plugin, all of the dev branches are showing new commits existing (version increment on dev branches). A version increment in not a valid reason to release a plugin but according to our automated steps at http://wiki.apache.org/cordova/StepsForPluginRelease, it will be treated as one. CLONE - Plugins Release - Oct 9 2013 Key: CB-5010 URL: https://issues.apache.org/jira/browse/CB-5010 Project: Apache Cordova Issue Type: Task Reporter: Steve Gill Assignee: Steve Gill -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4825) Fix XCode 5 accelerometer plugin warnings
[ https://issues.apache.org/jira/browse/CB-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790778#comment-13790778 ] ASF subversion and git services commented on CB-4825: - Commit b2e17a784a6d69a89410e661f3f9d76f0fcb4bc5 in branch refs/heads/dev from [~wjamesjong] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-motion.git;h=b2e17a7 ] [CB-4825] avoid retain cycle in update block Fix XCode 5 accelerometer plugin warnings - Key: CB-4825 URL: https://issues.apache.org/jira/browse/CB-4825 Project: Apache Cordova Issue Type: Bug Components: Plugin Device Motion Affects Versions: 3.0.0 Reporter: James Jong Assignee: James Jong Attachments: warnings-plugin-accelerometer.png Fox xcode 5 warnings. See attached picture. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5031) Help text for platform update and plugin search is missing
[ https://issues.apache.org/jira/browse/CB-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790786#comment-13790786 ] Mike Billau commented on CB-5031: - Pull request for cordova-docs/guide/cli: https://github.com/apache/cordova-docs/pull/129 Pull request for cordova-cli help.txt: https://github.com/apache/cordova-cli/pull/48 Created this issue to track documenting the registry since I think this is the first time it has been officially mentioned in the docs: https://issues.apache.org/jira/browse/CB-5034 Help text for platform update and plugin search is missing -- Key: CB-5031 URL: https://issues.apache.org/jira/browse/CB-5031 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Marcel Kinard Assignee: Mike Billau Priority: Minor Should be in cordova-cli/doc/help.txt and cordova-docs/guide/cli -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-2630) Add API browser to documentation
[ https://issues.apache.org/jira/browse/CB-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790806#comment-13790806 ] Mike Billau commented on CB-2630: - Would this be done automatically if we used a tool like JSDoc? Add API browser to documentation Key: CB-2630 URL: https://issues.apache.org/jira/browse/CB-2630 Project: Apache Cordova Issue Type: Improvement Components: Docs Reporter: Benjamin Assignee: Michael Brooks Priority: Critical Labels: documentation Fix For: Master As a new user, browsing documentation by feature is fantastic, but it's difficult to find things when I want to look at the API by object hierarchy. For example, you should be able to see a list of all methods on navigator by platform. Something like http://docs.phonegap.com/en/2.5.0/_index.html is somewhat useful, but you cannot drill down into the API and many things aren't listed (navigator.app.loadUrl, for example). -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4825) Fix XCode 5 accelerometer plugin warnings
[ https://issues.apache.org/jira/browse/CB-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790831#comment-13790831 ] ASF subversion and git services commented on CB-4825: - Commit 90932591e862f04aa4b4f57885db31592562c081 in branch refs/heads/dev from [~wjamesjong] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-motion.git;h=9093259 ] [CB-4825] Add CoreMotion.framework to plugin.xml Fix XCode 5 accelerometer plugin warnings - Key: CB-4825 URL: https://issues.apache.org/jira/browse/CB-4825 Project: Apache Cordova Issue Type: Bug Components: Plugin Device Motion Affects Versions: 3.0.0 Reporter: James Jong Assignee: James Jong Attachments: warnings-plugin-accelerometer.png Fox xcode 5 warnings. See attached picture. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5010) CLONE - Plugins Release - Oct 9 2013
[ https://issues.apache.org/jira/browse/CB-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790932#comment-13790932 ] Steve Gill commented on CB-5010: Plugins included in release: cordova-plugin-contacts cordova-plugin-file cordova-plugin-file-transfer cordova-plugin-inappbrowser cordova-plugin-media cordova-plugin-media-capture cordova-plugin-splashscreen cordova-plugin-vibration Skipping cordova-plugin-device-motion due to needing more testing CLONE - Plugins Release - Oct 9 2013 Key: CB-5010 URL: https://issues.apache.org/jira/browse/CB-5010 Project: Apache Cordova Issue Type: Task Reporter: Steve Gill Assignee: Steve Gill -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4971) Installation of plugins does not work for iOS
[
https://issues.apache.org/jira/browse/CB-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790994#comment-13790994
]
Anis Kadri commented on CB-4971:
I could not reproduce.
I am using _XCode 5.0_, _plugman 0.13.0_ _cordova 3.1.0-0.1.0_
{code}
cordova create myapp
cordova plugin add org.apache.cordova.network-information
cordova prepare # multiple times
{code}
Project opens in XCode 5.0 and builds and runs just fine for me. cordova build
also works.
Can you guys try blowing up your $HOME/.cordova and try again with a fresh
project ?
Installation of plugins does not work for iOS
-
Key: CB-4971
URL: https://issues.apache.org/jira/browse/CB-4971
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Contacts, Plugin Device, Plugin Dialogs
Affects Versions: 3.0.0, 3.1.0
Environment: iOS
Reporter: Oleg
Priority: Critical
Labels: ios, plugin
Fix For: Master, 3.0.0, 3.1.0
Original Estimate: 72h
Remaining Estimate: 72h
Installation of iOS plugins does not work for iOS.
Update: does not work in 3.1 cordova either.
When installing the plugin via cordova plugin add, the plugins fail to
install correctly to the iOS platform:
- source code (.js, .m, .h and .bundle) files are not copied over
- proper frameworks are not being added to the project
- config.xml file is not updated with plugin information
Tried it on Device, Contacts and Dialogs and some other plugins.
Update: tried on network-information plugin with cordova 3.1
the workaround is to perform the above steps manually. but it is not
documented anywhere.
Note: it worked for me during one test, when the project was fresh. However
after making a few minor changes and running cordova prepare or cordova
build a few times, it stops working for iOS - i.e. you cannot add plugins
without issues above. Android works fine.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (CB-4994) Cordova prepare SyntaxError
[
https://issues.apache.org/jira/browse/CB-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grieve updated CB-4994:
--
Attachment: Screen Shot 2013-10-09 at 8.31.20 PM.png
Cordova prepare SyntaxError
---
Key: CB-4994
URL: https://issues.apache.org/jira/browse/CB-4994
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Affects Versions: 3.1.0
Environment: Xcode 5, mac 10.8.5, cordova 3.1.0-0.1.0
Reporter: Dmitry D
Priority: Blocker
Labels: build
Attachments: Screen Shot 2013-10-09 at 8.31.20 PM.png
After modify project in Xcode (change icons, capabilities and localisation
language) can not prepare project with command cordova prepare and catch
error in console
$ cordova prepare
{ name: 'SyntaxError',
message: 'Expected /*, = or [A-Za-z0-9_] but . found.',
line: 382,
column: 11 }
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Reopened] (CB-5021) Make InAppBrowser close more robust - avoid NPE if no matching open
[
https://issues.apache.org/jira/browse/CB-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter reopened CB-5021:
---
see previous comment
Make InAppBrowser close more robust - avoid NPE if no matching open
---
Key: CB-5021
URL: https://issues.apache.org/jira/browse/CB-5021
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin InAppBrowser
Affects Versions: 2.9.0
Reporter: Peter
Assignee: Andrew Grieve
Priority: Minor
We have an Android application which implements an embedded WebView
container in which it executes customer Cordova apps.
Under certain conditions our container needs to terminate the customer app,
and during this termination it attempts to do some resource cleanup. For
example, to cleanup any possible lurking InAppBrowser resources it does
(equivalent of a IAB.close) the following:
{code}
cwv.pluginManager.exec(InAppBrowser, close, null, []);
{code}
Unfortunately, we don't really know if user app was actually using
InAppBrowser or not.
* If it _was_ using IAB, then the above exec works.
* If it _wasn’t_ using IAB, the above exec results in NPE (inAppWebView is
null) since current *InAppBrowser.java* code assumes close won't be called
without matching open.
Proposed improvement below is to make the InAppBrowser’s close more robust,
so if it gets called in an unusual scenario (e.g. without a prior open)
then it is just a harmless NOP.
For example,
Before:
{code}
else if (action.equals(close)) {
closeDialog();
this.callbackContext.sendPluginResult(new
PluginResult(PluginResult.Status.OK));
}
{code}
After:
{code}
else if (action.equals(close)) {
if (inAppWebView != null) {
closeDialog();
this.callbackContext.success();
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (CB-5022) Installing Core Plugins section unclear
[ https://issues.apache.org/jira/browse/CB-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Fowler updated CB-5022: -- Looking at the project on github the example command should have a method in it such as install. Should it be something like : plugman -d install --platform android --project c:\projects\helloplug\platforms\android --plugin C:\cordova-3.0.0\cordova-plugin-device Installing Core Plugins section unclear --- Key: CB-5022 URL: https://issues.apache.org/jira/browse/CB-5022 Project: Apache Cordova Issue Type: Improvement Components: Docs Affects Versions: 3.1.0 Environment: n/a Reporter: Angela Fowler Priority: Minor Labels: documentation http://cordova.apache.org/docs/en/edge/plugin_ref_plugman.md.html The Installing Core Plugins section appears as a bullet list of commands. cordova-plugin-battery-status plugman --platform --project --plugin org.apache.cordova.battery-status 1. Each command starts with the plugin name when it should start with plugman. Perhaps this was intended to be the first column of a table? 2. Each command is an example (according to the opening paragraph) but is missing the platform e.g. android and the project 3. It is still unclear to us how to upgrade from 2.9 which has the plugins included. If we don't use CLI as the introduction mentions, how is the project created? Can plugins be built into the jar or is the plugin source separate (as when added by CLI). -- This message was sent by Atlassian JIRA (v6.1#6144)
