[jira] [Commented] (CB-5848) Support for Android expansion files
[ https://issues.apache.org/jira/browse/CB-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882269#comment-13882269 ] Valerio Santinelli commented on CB-5848: I understand the reasons behind trying to avoid having large assets. But right now I can't find any alternative solution for being able to access big assets in another way. And if you are in such situation, there really is no solution except writing some custom code to do like Joe says and download the big assets during application startup or something like that. Support for Android expansion files --- Key: CB-5848 URL: https://issues.apache.org/jira/browse/CB-5848 Project: Apache Cordova Issue Type: New Feature Components: Android Affects Versions: 3.3.0 Reporter: Valerio Santinelli Priority: Minor As you might already know, Android .APK files cannot exceed 50Mb if you want to make them available on Google Play Store. For bigger apps, you can add one or more expansion files (.obb) The request would be to have Cordova automatically put the content of the www folder into an obb file so that all the assets won't be bundled with the app itself. That way, even if the assets are huge, you can still publish on Google Play Store. Right now there is no way to publish any app that exceeds 50Mb. I have seen some OS projects trying to deal with this, but right now there's no working solution. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows
[ https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882313#comment-13882313 ] Bas Bosman commented on CB-5438: Both /src/test/androidexec.js and /src/test/iosexec.js are symlinks to /src/android/exec.js and /src/ios/exec.js Symlinks don't work on the Windows platform and are represented there as a text file with the contents being a text description of where it should be pointing at. The problem is that the jshint task of the build tries to parse those 'text' files as js files, which fails for obvious reasons. My solution is to explicitly exclude those 2 symlink files from the jshint task. The files they point at are included in the src/**/*.js jshint src setting, so they will get checked anyway. Now we can successfully run grunt build on Windows. Pull request for this at: https://github.com/apache/cordova-js/pull/64 Can't build/test cordova-js on Windows -- Key: CB-5438 URL: https://issues.apache.org/jira/browse/CB-5438 Project: Apache Cordova Issue Type: Bug Components: CordovaJS Affects Versions: Master Environment: Windows 8 x64 Node v0.10.13 Reporter: qi Priority: Critical Simply run 'grunt build', got, Running jshint:src (jshint) task Linting lib/test/androidexec.js ...ERROR [L1:C1] E030: Expected an identifier and instead saw '.'. ../android/exec.js [L1:C2] E033: Expected an operator and instead saw '.'. ../android/exec.js [L1:C3] E033: Expected an operator and instead saw '/'. ../android/exec.js [L1:C4] W033: Missing semicolon. ../android/exec.js [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4. ../android/exec.js [L1:C19] W033: Missing semicolon. ../android/exec.js [L1:C4] W117: 'android' is not defined. ../android/exec.js [L1:C12] W117: 'exec' is not defined. ../android/exec.js Linting lib/test/iosexec.js ...ERROR [L1:C1] E030: Expected an identifier and instead saw '.'. ../ios/exec.js [L1:C2] E033: Expected an operator and instead saw '.'. ../ios/exec.js [L1:C3] E033: Expected an operator and instead saw '/'. ../ios/exec.js [L1:C4] W033: Missing semicolon. ../ios/exec.js [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4. ../ios/exec.js [L1:C15] W033: Missing semicolon. ../ios/exec.js [L1:C4] W117: 'ios' is not defined. ../ios/exec.js [L1:C8] W117: 'exec' is not defined. ../ios/exec.js Warning: Task jshint:src failed. Use --force to continue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5848) Support for Android expansion files
[ https://issues.apache.org/jira/browse/CB-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882322#comment-13882322 ] Joe Bowser commented on CB-5848: This is a no-brainer as far as Mobile UX goes. Large APKs are super bad because you still have to access the video from the package every time, which is either computational (having to extract from the APK every time, which on slower devices is non-zero) or storage overhead (storing the same file twice, taking up twice the space your app said it would on the app store), or you can fetch the files from your server once on the initial startup and save them in your app's data directory. Most games use the custom download approach for a reason. Support for Android expansion files --- Key: CB-5848 URL: https://issues.apache.org/jira/browse/CB-5848 Project: Apache Cordova Issue Type: New Feature Components: Android Affects Versions: 3.3.0 Reporter: Valerio Santinelli Priority: Minor As you might already know, Android .APK files cannot exceed 50Mb if you want to make them available on Google Play Store. For bigger apps, you can add one or more expansion files (.obb) The request would be to have Cordova automatically put the content of the www folder into an obb file so that all the assets won't be bundled with the app itself. That way, even if the assets are huge, you can still publish on Google Play Store. Right now there is no way to publish any app that exceeds 50Mb. I have seen some OS projects trying to deal with this, but right now there's no working solution. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5496) source zip download link leads to a 404 page
[ https://issues.apache.org/jira/browse/CB-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882321#comment-13882321 ] Bas Bosman commented on CB-5496: I think this issue can be marked as resolved, as the link got fixed during the 3.3.0 release. source zip download link leads to a 404 page -- Key: CB-5496 URL: https://issues.apache.org/jira/browse/CB-5496 Project: Apache Cordova Issue Type: Bug Components: Website Reporter: webchick If you click the source zip link at http://cordova.apache.org/#download it leads to https://www.apache.org/dist/cordova/cordova-3.1.0-src.zip which is a 404 page. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5387) NPM update not working as documented
[
https://issues.apache.org/jira/browse/CB-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882323#comment-13882323
]
Bas Bosman commented on CB-5387:
Pull request: https://github.com/apache/cordova-docs/pull/170
This changes the example to a working example.
NPM update not working as documented
Key: CB-5387
URL: https://issues.apache.org/jira/browse/CB-5387
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Affects Versions: 3.0.0
Environment: Windows 7
Reporter: John M. Wargo
I’m currently at CLI 3.0.9 and tried to update to 3.1.0 (per the instructions
in the docs here:
http://cordova.apache.org/docs/en/3.1.0/guide_cli_index.md.html#The%20Command-line%20Interface)
using:
npm update -g cordova@3.1.0
and nothing happened. Cordova stayed at 3.0.9.
When I do:
npm update -g cordova
It successfully updates me to 3.1.0-0.2.0
Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.
C:\Users\I833153\dev\testcordova -v
3.0.9
C:\Users\I833153\dev\testnpm update -g cordova@3.1.0
C:\Users\I833153\dev\testcordova -v
3.0.9
C:\Users\I833153\dev\testnpm update -g cordova
npm http GET https://registry.npmjs.org/cordova
npm http GET https://registry.npmjs.org/cordova
npm http GET https://registry.npmjs.org/cordova
npm http GET https://registry.npmjs.org/cordova/3.1.0-0.2.0
npm http GET https://registry.npmjs.org/cordova/3.1.0-0.2.0
npm http GET https://registry.npmjs.org/cordova/3.1.0-0.2.0
npm http GET https://registry.npmjs.org/ncallbacks/1.0.0
npm http GET https://registry.npmjs.org/colors
npm http GET https://registry.npmjs.org/ripple-emulator/0.9.18
npm http GET https://registry.npmjs.org/tar
npm http GET https://registry.npmjs.org/prompt/0.2.7
npm http GET https://registry.npmjs.org/plist
npm http GET https://registry.npmjs.org/request/2.22.0
npm http GET https://registry.npmjs.org/xcode/0.5.1
npm http GET https://registry.npmjs.org/shelljs/0.1.2
npm http GET https://registry.npmjs.org/mime
npm http GET https://registry.npmjs.org/optimist/0.6.0
npm http GET https://registry.npmjs.org/express/3.0.0
npm http GET https://registry.npmjs.org/follow-redirects
npm http GET https://registry.npmjs.org/npm
npm http GET https://registry.npmjs.org/open/0.0.3
npm http GET https://registry.npmjs.org/elementtree/0.1.5
npm http GET https://registry.npmjs.org/semver/1.1.0
npm http GET https://registry.npmjs.org/q
npm http GET https://registry.npmjs.org/glob
npm http GET https://registry.npmjs.org/plugman
npm http GET https://registry.npmjs.org/ncallbacks/1.0.0
npm http GET https://registry.npmjs.org/colors
npm http GET https://registry.npmjs.org/ripple-emulator/0.9.18
npm http GET https://registry.npmjs.org/tar
npm http GET https://registry.npmjs.org/prompt/0.2.7
npm http GET https://registry.npmjs.org/plist
npm http GET https://registry.npmjs.org/request/2.22.0
npm http GET https://registry.npmjs.org/xcode/0.5.1
npm http GET https://registry.npmjs.org/shelljs/0.1.2
npm http GET https://registry.npmjs.org/mime
npm http GET https://registry.npmjs.org/optimist/0.6.0
npm http GET https://registry.npmjs.org/express/3.0.0
npm http GET https://registry.npmjs.org/follow-redirects
npm http GET https://registry.npmjs.org/npm
npm http GET https://registry.npmjs.org/open/0.0.3
npm http GET https://registry.npmjs.org/elementtree/0.1.5
npm http GET https://registry.npmjs.org/semver/1.1.0
npm http GET https://registry.npmjs.org/q
npm http GET https://registry.npmjs.org/glob
npm http GET https://registry.npmjs.org/plugman
npm http GET https://registry.npmjs.org/ncallbacks/1.0.0
npm http GET https://registry.npmjs.org/colors
npm http GET https://registry.npmjs.org/ripple-emulator/0.9.18
npm http GET https://registry.npmjs.org/tar
npm http GET https://registry.npmjs.org/prompt/0.2.7
npm http GET https://registry.npmjs.org/plist
npm http GET https://registry.npmjs.org/request/2.22.0
npm http GET https://registry.npmjs.org/xcode/0.5.1
npm http GET https://registry.npmjs.org/shelljs/0.1.2
npm http GET https://registry.npmjs.org/mime
npm http GET https://registry.npmjs.org/optimist/0.6.0
npm http GET https://registry.npmjs.org/express/3.0.0
npm http GET https://registry.npmjs.org/follow-redirects
npm http GET https://registry.npmjs.org/npm
npm http GET https://registry.npmjs.org/open/0.0.3
npm http GET https://registry.npmjs.org/elementtree/0.1.5
npm http GET https://registry.npmjs.org/semver/1.1.0
npm http GET https://registry.npmjs.org/q
npm http GET https://registry.npmjs.org/glob
npm http GET https://registry.npmjs.org/plugman
npm WARN engine ncallbacks@1.0.0: wanted: {node:~0.6.7} (current:
{node:v
0.10.21,npm:1.3.11})
npm http GET https://registry.npmjs.org/underscore
npm http GET
[jira] [Created] (CB-5900) Spelling mistakes in the english docs
Bas Bosman created CB-5900: -- Summary: Spelling mistakes in the english docs Key: CB-5900 URL: https://issues.apache.org/jira/browse/CB-5900 Project: Apache Cordova Issue Type: Improvement Components: Docs Affects Versions: 3.3.0 Reporter: Bas Bosman Priority: Trivial The docs contain a number of spelling mistakes. For example: tareting - targeting (docs/en/edge/config_ref/images.md) explicity - explicitly (docs/en/edge/guide/appdev/whitelist/index.md) whilelisting - whitelisting (docs/en/edge/guide/appdev/whitelist/index.md) direcotry - directory (docs/en/edge/guide/cli/index.md) executible - executable (docs/en/edge/guide/overview/index.md) accessable - accessible (docs/en/edge/guide/platforms/android/index.md) correspoinding - corresponding (docs/en/edge/guide/platforms/android/plugin.md) instructinos - instructions (docs/en/edge/guide/platforms/android/upgrading.md) lastest - latest (docs/en/edge/guide/platforms/ios/index.md) relevent - relevant (docs/en/edge/guide/platforms/ios/upgrading.md) e.g - e.g. (numerous locations) instuctions - instructions (docs/en/edge/guide/platforms/win8/index.md) Windwos - Windows (docs/en/edge/guide/platforms/wp7/index.md) instally - install (docs/en/edge/plugin_reg/plugman.md) acccessed - accessed (docs/en/edge/plugin_reg/spec.md) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5900) Spelling mistakes in the english docs
[ https://issues.apache.org/jira/browse/CB-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882340#comment-13882340 ] Bas Bosman commented on CB-5900: Pull request: https://github.com/apache/cordova-docs/pull/171 Spelling mistakes in the english docs - Key: CB-5900 URL: https://issues.apache.org/jira/browse/CB-5900 Project: Apache Cordova Issue Type: Improvement Components: Docs Affects Versions: 3.3.0 Reporter: Bas Bosman Priority: Trivial Labels: spelling Original Estimate: 0.25h Remaining Estimate: 0.25h The docs contain a number of spelling mistakes. For example: tareting - targeting (docs/en/edge/config_ref/images.md) explicity - explicitly (docs/en/edge/guide/appdev/whitelist/index.md) whilelisting - whitelisting (docs/en/edge/guide/appdev/whitelist/index.md) direcotry - directory (docs/en/edge/guide/cli/index.md) executible - executable (docs/en/edge/guide/overview/index.md) accessable - accessible (docs/en/edge/guide/platforms/android/index.md) correspoinding - corresponding (docs/en/edge/guide/platforms/android/plugin.md) instructinos - instructions (docs/en/edge/guide/platforms/android/upgrading.md) lastest - latest (docs/en/edge/guide/platforms/ios/index.md) relevent - relevant (docs/en/edge/guide/platforms/ios/upgrading.md) e.g - e.g. (numerous locations) instuctions - instructions (docs/en/edge/guide/platforms/win8/index.md) Windwos - Windows (docs/en/edge/guide/platforms/wp7/index.md) instally - install (docs/en/edge/plugin_reg/plugman.md) acccessed - accessed (docs/en/edge/plugin_reg/spec.md) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5890) Media won't play local file on iOS
[
https://issues.apache.org/jira/browse/CB-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882345#comment-13882345
]
John M. Wargo commented on CB-5890:
---
I did a search on the OSStatus error message and found out that the issue is
with the file format. Somehow my file, although it will play on Android, won't
play on iOS.
I rerecorded my sample media file on the iOS voice recorder and the file will
play on both devices.
There's still a bug here that the error message is blank, but there seems to
also be a problem with the interface to the media player as I know the file
was...good.
Media won't play local file on iOS
--
Key: CB-5890
URL: https://issues.apache.org/jira/browse/CB-5890
Project: Apache Cordova
Issue Type: Bug
Components: iOS, Plugin Media
Affects Versions: 3.3.0
Environment: Mac OSX
Reporter: John M. Wargo
I have an application that will play a media file on Android, but not on iOS.
When I try to play the file, the console indicates that it can find the file,
but fails on opening it:
Failed to initialize AVAudioPlayer
Here's some console entries:
2014-01-24 08:49:51.374 Ex141[386:60b] Entering doPlay
2014-01-24 08:49:51.376 Ex141[386:60b] Found resource
'/var/mobile/Applications/C557863E-BB8C-4384-8188-9C36B5B603C4/Ex141.app/www/sample.mp3'
in the web folder.
2014-01-24 08:49:51.391 Ex141[386:60b] Failed to initialize AVAudioPlayer:
The operation couldn’t be completed. (OSStatus error 1685348671.)
2014-01-24 08:49:51.394 Ex141[386:60b] THREAD WARNING: ['Media'] took
'18.647949' ms. Plugin should use a background thread.
2014-01-24 08:49:51.396 Ex141[386:60b] Leaving doPlay
2014-01-24 08:49:51.397 Ex141[386:60b] ERROR: Entering mediaError
2014-01-24 08:49:51.398 Ex141[386:60b] ERROR: {message:,code:4}
Notice that the message string is blank.
This is my code:
theFile = 'sample.mp3';
theMedia = new Media(theFile, mediaSuccess, mediaError, mediaStatus);
theMedia.play();
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-5899) FileError code 5 returned with dirEntry.readEntries()
[
https://issues.apache.org/jira/browse/CB-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882352#comment-13882352
]
Boston Dell-Vandenberg commented on CB-5899:
After more testing I've found it only occurs on the dev branch of the file
plugin: https://github.com/apache/cordova-plugin-file/tree/dev
I'm using the dev branch because it contains file / file transfer fixes for
BlackBerry 10.
This js code can reproduce the problem (note I'm arbitrarily picking a sub
directory to demonstrate):
{code:javascript}
var fp, el, count = 0;
var showLocalFiles = function () {
fp = {};
fp.currPath = '';
fp.currEntry = null;
fp.fileEntries = [];
fp.getRoot = function (callback) {
window.requestFileSystem(LocalFileSystem.PERSISTENT, 0,
function (fileSystem) {
fp.rootPath = fileSystem.root.fullPath;
fp.getEntries(fileSystem.root);
}, function () {
console.log('Error accessing local file system');
});
};
fp.getEntries = function (dirEntry) {
if (dirEntry === null)
return;
var directoryReader = dirEntry.createReader();
fp.currPath = dirEntry.fullPath;
fp.currEntry = dirEntry;
directoryReader.readEntries(
function (entries) {
console.log('got entries: ', entries);
entries.sort(function (a, b) {
if (a.name.toLowerCase() b.name.toLowerCase())
return -1;
if (a.name.toLowerCase() b.name.toLowerCase())
return 1;
return 0;
});
fp.fileEntries = entries;
if (count === 0) {
fp.getEntries(fp.fileEntries[4]);
count++;
}
},
function (error) {
console.log('Failed to list directory contents. Code =
' + error.code);
}
);
};
fp.getRoot();
};
window.addEventListener('load', function onload() {
document.addEventListener('deviceready', showLocalFiles, false);
}, false);
{code}
FileError code 5 returned with dirEntry.readEntries()
-
Key: CB-5899
URL: https://issues.apache.org/jira/browse/CB-5899
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin File
Affects Versions: 3.3.0
Environment: Android 4.1, Android 4.4
Reporter: Boston Dell-Vandenberg
When attempting to read entries of a DirectoryEntry from the local file
system the plugin returns an FileError code 5.
I am able to successfully read the root directory of the local file system
using window.requestFileSystem() but creating a directoryReader and calling
readEntries() of any sub directories of the root file system results in the
error.
I am using Cordova 3.3 and have tried both 0.2.5 of the file plugin as well
as the current Dev branch.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-5464) Documentation issues
[ https://issues.apache.org/jira/browse/CB-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882414#comment-13882414 ] Bas Bosman commented on CB-5464: 1) appears to be solved in the current edge documentation. Documentation issues Key: CB-5464 URL: https://issues.apache.org/jira/browse/CB-5464 Project: Apache Cordova Issue Type: Bug Components: Docs Affects Versions: 3.1.0 Reporter: Jacob Weber Priority: Minor 1) [This page|http://cordova.apache.org/docs/en/3.1.0/guide_platforms_ios_upgrading.md.html#Upgrading%20iOS] has a broken link: [Using Plugman to Manage Plugins|http://cordova.apache.org/docs/en/3.1.0/guide_platforms_ios_upgrading.md.html#Using%20Plugman%20to%20Manage%0APlugins]. Also, the formatting under Upgrading 3.0.0 projects to 3.1.0 is messed up. 2) [This page|http://cordova.apache.org/docs/en/3.1.0/guide_platforms_ios_config.md.html#The%20config.xml%0AFile] has a link that points back to itself: [The config.xml File|http://cordova.apache.org/docs/en/3.1.0/guide_platforms_ios_config.md.html#The%20config.xml%0AFile]. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5175) Fix core plugins that incorrectly run on main thread
[ https://issues.apache.org/jira/browse/CB-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882420#comment-13882420 ] Bas Bosman commented on CB-5175: Another relates issue: https://issues.apache.org/jira/browse/CB-5369 (StatusBar plugin - not fixed) Fix core plugins that incorrectly run on main thread Key: CB-5175 URL: https://issues.apache.org/jira/browse/CB-5175 Project: Apache Cordova Issue Type: Bug Components: Docs, Plugin Device Orientation, Plugin File, Plugin Media Reporter: Mike Billau Priority: Minor After CB-4133 we are able to detect and log when a plugin incorrectly does work on the UI thread instead of a worker thread. We should go back and verify that all of our plugins follow this practice - eat your own dogfood type of thing. We know there are problems with: Android: file, compass iOS: media Docs: Need to verify plugin author guide is still valid -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5851) cordova.apache.org insecurely references css/js files
[ https://issues.apache.org/jira/browse/CB-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882428#comment-13882428 ] Bas Bosman commented on CB-5851: This is a duplicate of CB-4561 cordova.apache.org insecurely references css/js files - Key: CB-5851 URL: https://issues.apache.org/jira/browse/CB-5851 Project: Apache Cordova Issue Type: Bug Components: Website Environment: Chrome 32. Reporter: Ryan Aslett If you browse to https://cordova.apache.org , none of the css or javascript loads due to protocol mismatches when loading the css files. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4908) FB - Globalization.java - use valueOf instead of new Long/new Integer
[
https://issues.apache.org/jira/browse/CB-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882434#comment-13882434
]
Bas Bosman commented on CB-4908:
Pull request: https://github.com/apache/cordova-plugin-globalization/pull/6
Extra info: http://stackoverflow.com/a/13145360/1412800
FB - Globalization.java - use valueOf instead of new Long/new Integer
-
Key: CB-4908
URL: https://issues.apache.org/jira/browse/CB-4908
Project: Apache Cordova
Issue Type: Sub-task
Components: Android
Affects Versions: 2.9.0
Reporter: Peter
Priority: Minor
Resolve FindBugs reported issues in *Globalization.java*:
Before
{code}
obj.put(millisecond, new Long(0));
{code}
After
{code}
obj.put(millisecond, Long.valueOf(0));
{code}
Before (2 places)
{code}
obj.put(rounding, new Integer(0));
{code}
After
{code}
obj.put(rounding, Integer.valueOf(0));
{code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-4907) FB - FileTransfer.java - method does not close stream
[
https://issues.apache.org/jira/browse/CB-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882437#comment-13882437
]
Bas Bosman commented on CB-4907:
Pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/17
FB - FileTransfer.java - method does not close stream
-
Key: CB-4907
URL: https://issues.apache.org/jira/browse/CB-4907
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 2.9.0
Reporter: Peter
Priority: Minor
Resolve FindBugs reported issue in *FileTransfer.java*:
Before
{code}
String line = reader.readLine();
while(line != null)
{
bodyBuilder.append(line);
line = reader.readLine();
if(line != null)
bodyBuilder.append('\n');
}
body = bodyBuilder.toString();
{code}
After
{code}
try {
String line = reader.readLine();
while(line != null) {
bodyBuilder.append(line);
line = reader.readLine();
if(line != null) {
bodyBuilder.append('\n');
}
}
body = bodyBuilder.toString();
} finally {
reader.close();
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Resolved] (CB-5851) cordova.apache.org insecurely references css/js files
[ https://issues.apache.org/jira/browse/CB-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-5851. -- Resolution: Duplicate cordova.apache.org insecurely references css/js files - Key: CB-5851 URL: https://issues.apache.org/jira/browse/CB-5851 Project: Apache Cordova Issue Type: Bug Components: Website Environment: Chrome 32. Reporter: Ryan Aslett If you browse to https://cordova.apache.org , none of the css or javascript loads due to protocol mismatches when loading the css files. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4917) FB - FileUtils.java - may fail to clean up streams
[
https://issues.apache.org/jira/browse/CB-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882452#comment-13882452
]
Bas Bosman commented on CB-4917:
Pull request: https://github.com/apache/cordova-plugin-file/pull/24
FB - FileUtils.java - may fail to clean up streams
--
Key: CB-4917
URL: https://issues.apache.org/jira/browse/CB-4917
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 2.9.0
Reporter: Peter
Priority: Minor
Resolve FindBugs issues in *FileUtils.java*
*In copyAction method*
Before
{code}
FileInputStream istream = new FileInputStream(srcFile);
FileOutputStream ostream = new FileOutputStream(destFile);
FileChannel input = istream.getChannel();
FileChannel output = ostream.getChannel();
try {
input.transferTo(0, input.size(), output);
} finally {
istream.close();
ostream.close();
input.close();
output.close();
}
{code}
After
{code}
FileInputStream istream = new FileInputStream(srcFile);
try {
FileOutputStream ostream = new FileOutputStream(destFile);
FileChannel input = istream.getChannel();
FileChannel output = ostream.getChannel();
try {
input.transferTo(0, input.size(), output);
} finally {
ostream.close();
input.close();
output.close();
}
} finally {
istream.close();
}
{code}
*In write method*
Before
{code}
ByteArrayInputStream in = new ByteArrayInputStream(rawData);
FileOutputStream out = new FileOutputStream(filename, append);
byte buff[] = new byte[rawData.length];
in.read(buff, 0, buff.length);
out.write(buff, 0, rawData.length);
out.flush();
out.close();
{code}
After
{code}
ByteArrayInputStream in = new ByteArrayInputStream(rawData);
FileOutputStream out = new FileOutputStream(filename, append);
try {
byte buff[] = new byte[rawData.length];
in.read(buff, 0, buff.length);
out.write(buff, 0, rawData.length);
out.flush();
} finally {
out.close();
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-4906) FB - Capture.java - method does not clean up stream
[
https://issues.apache.org/jira/browse/CB-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882461#comment-13882461
]
Bas Bosman commented on CB-4906:
Pull request: https://github.com/apache/cordova-plugin-media-capture/pull/12
FB - Capture.java - method does not clean up stream
---
Key: CB-4906
URL: https://issues.apache.org/jira/browse/CB-4906
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 2.9.0
Reporter: Peter
Priority: Minor
Resolve FindBugs reported issue in *Capture.java*:
Before
{code}
FileInputStream fis = new
FileInputStream(DirectoryManager.getTempDirectoryPath(this.cordova.getActivity())
+ /Capture.jpg);
OutputStream os =
this.cordova.getActivity().getContentResolver().openOutputStream(uri);
byte[] buffer = new byte[4096];
int len;
while ((len = fis.read(buffer)) != -1) {
os.write(buffer, 0, len);
}
os.flush();
os.close();
fis.close();
{code}
After
{code}
FileInputStream fis = new
FileInputStream(DirectoryManager.getTempDirectoryPath(this.cordova.getActivity())
+ /Capture.jpg);
try {
OutputStream os =
this.cordova.getActivity().getContentResolver().openOutputStream(uri);
try {
byte[] buffer = new byte[4096];
int len;
while ((len = fis.read(buffer)) != -1) {
os.write(buffer, 0, len);
}
os.flush();
} finally {
os.close();
}
} finally {
fis.close();
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-4984) Can't name my class CordovaActivity
[
https://issues.apache.org/jira/browse/CB-4984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882472#comment-13882472
]
Bas Bosman commented on CB-4984:
Pull request: https://github.com/apache/cordova-android/pull/93
Can't name my class CordovaActivity
---
Key: CB-4984
URL: https://issues.apache.org/jira/browse/CB-4984
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 3.1.0
Environment: android sdk tools 22.2.1
android sdk platform-tools 18.0.1
Android 4.3 (API 18)
Reporter: Anis Kadri
Priority: Minor
Fix For: 3.4.0
Yes it's super silly but the node create script should fail if user enters
in: CordovaActivity as an activity name since we inherit from a class that
has that name. Might also apply to package names.
steps to reproduce
{code}
./bin/create /path/to/project mypackage.name CordovaActivity
{code}
Results:
{code}
-compile:
[javac] Compiling 6 source files to /private/tmp/android/bin/classes
[javac] /private/tmp/android/src/io/cordova/CordovaActivity.java:25:
cyclic inheritance involving io.cordova.CordovaActivity
[javac] public class CordovaActivity extends CordovaActivity
[javac]^
[javac] 1 error
{code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-5536) Use Unicode arrows instead of greater than / less than symbols to indicate back and forward buttons
[ https://issues.apache.org/jira/browse/CB-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882473#comment-13882473 ] Bas Bosman commented on CB-5536: Pull request based on the triangles: https://github.com/apache/cordova-plugin-inappbrowser/pull/18 Use Unicode arrows instead of greater than / less than symbols to indicate back and forward buttons --- Key: CB-5536 URL: https://issues.apache.org/jira/browse/CB-5536 Project: Apache Cordova Issue Type: Improvement Components: Plugin InAppBrowser Affects Versions: 3.1.0 Environment: Android (possibly others) Reporter: Oliver Moran Priority: Trivial The plugin currently represents navigate back and navigate forward buttons with less than or equal to signs ( and ). These actions could be represented more attractively (and more appropriately) using Unicode arrows symbols: https://en.wikipedia.org/wiki/Arrow_(symbol)#Arrows_in_Unicode Code sample in Android: back.setText(\u21e6); // ⇦ forward.setText(\u21e8); // ⇨ .. or ... back.setText(\u2190); // ← forward.setText(\u2192); // → -- This message was sent by Atlassian JIRA (v6.1.5#6160)
