[jira] [Resolved] (CB-6372) port createmobilespec.sh to Node.js
[ https://issues.apache.org/jira/browse/CB-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Kinard resolved CB-6372. --- Resolution: Fixed Fix Version/s: 3.5.0 > port createmobilespec.sh to Node.js > --- > > Key: CB-6372 > URL: https://issues.apache.org/jira/browse/CB-6372 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > Fix For: 3.5.0 > > > Do a simple port of the createmobilespec script from bash to Node.js. This is > a start to it working on other dev workstations (i.e., Windows), and to make > it easier to add improvements (i.e., support for platforms other than iOS and > Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6372) port createmobilespec.sh to Node.js
[ https://issues.apache.org/jira/browse/CB-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951710#comment-13951710 ] ASF subversion and git services commented on CB-6372: - Commit d434ff29b60e7f055df19f9414cbe59a0a535313 in cordova-mobile-spec's branch refs/heads/master from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=d434ff2 ] CB-6372 Enable variable platforms Added command-line parms so you can choose which platforms to use. This is groundwork for adding additional platforms. > port createmobilespec.sh to Node.js > --- > > Key: CB-6372 > URL: https://issues.apache.org/jira/browse/CB-6372 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Do a simple port of the createmobilespec script from bash to Node.js. This is > a start to it working on other dev workstations (i.e., Windows), and to make > it easier to add improvements (i.e., support for platforms other than iOS and > Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6327) Facebook Connect plugin blocked by callbackId restricted characters
[
https://issues.apache.org/jira/browse/CB-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951588#comment-13951588
]
ASF subversion and git services commented on CB-6327:
-
Commit 56eb0a70b93db082d394435759cfbf0ee05dfdb2 in cordova-ios's branch
refs/heads/3.4.x from [~iclelland]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=56eb0a7 ]
CB-6327: Allow '.' in plugin feature names (and therefore callback ids)
> Facebook Connect plugin blocked by callbackId restricted characters
> ---
>
> Key: CB-6327
> URL: https://issues.apache.org/jira/browse/CB-6327
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.5.0
>Reporter: Ian Clelland
>Assignee: Ian Clelland
>Priority: Blocker
>
> The FB Connect plugin uses a period character ('.', U+002E) in it's feature
> name. (Specifically, it uses the reverse-DNS name
> "org.apache.cordova.facebook.Connect")
> This produces a callbackId in the bridge which is blocked, as of commit
> 7da5f2d.
> reverse-dns-style naming seems like a legitimate use of the feature name, so
> I'm inclined to add the period to the list of allowed characters.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951472#comment-13951472
]
ASF GitHub Bot commented on CB-6329:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11087542
--- Diff: src/info.js ---
@@ -30,105 +29,80 @@ var cordova_util = require('./util'),
Outputs to a file
*/
module.exports = function info() {
-
-//Get the template
-var projectRoot = cordova_util.cdProjectRoot();
-
-var raw = fs.readFileSync(path.join(__dirname, '..', 'doc',
'info.txt'), 'utf-8').split("\n"),
-output;
-
-output = raw.map(function(line) {
-if(line.match('%') ) {
-var type = (line.substr(5)).replace("\r",""),
-out = "";
-
-switch(type) {
-case "Node":
-out = shell.exec('node --version',{silent:true}).output;
-break;
-case "Cordova":
-out = require('../package').version;
-break;
-case "Config":
-out = fs.readFileSync(
cordova_util.projectConfig(projectRoot) );
-break;
-case "Platforms":
-out = doPlatforms( projectRoot );
-break;
-case "Plugins":
-out = doPlugins( projectRoot );
-break;
-default:
-break;
-}
-return line.replace( "%"+type, out );
-} else {
-return line;
+//Get projectRoot
+var projectRoot = cordova_util.cdProjectRoot(),
+output;
+delLog(projectRoot);
+//Get Node info
+info_utils.getNodeInfo(function (result){
+if( result ){
+print_SaveMsg(projectRoot, "Node version: "+ result);
+//Get Cordova version
+info_utils.getCordovaInfo(function (result){
+if( result ){print_SaveMsg(projectRoot,"Cordova version:
"+ result );
+// Get config.xml file
+fs.readFile(cordova_util.projectConfig(projectRoot) ,
'utf-8' , function ( err , result ){
+if(err) {print_SaveMsg(projectRoot,"Error reading
config.xml file"+ err);}
+print_SaveMsg(projectRoot,'Config.xml File: \r'+
result +'\r\r\r');
+print_SaveMsg(projectRoot,'Plugins: \r' +
doPlugins( projectRoot ) +'\r\r\r');
+//Get platforms info
+doPlatforms(projectRoot, function (result){
+if( result ){
+print_SaveMsg(projectRoot,result);
+}
+});
+});
+}
+});
}
-}).join("\n");
-
-// /*
-// Write to File;
-// */
-events.emit('results', output);
-fs.writeFileSync('info.txt', output );
+});
return Q();
--- End diff --
Another way
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951468#comment-13951468
]
ASF GitHub Bot commented on CB-6329:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11087487
--- Diff: src/info.js ---
@@ -30,105 +29,80 @@ var cordova_util = require('./util'),
Outputs to a file
*/
module.exports = function info() {
-
-//Get the template
-var projectRoot = cordova_util.cdProjectRoot();
-
-var raw = fs.readFileSync(path.join(__dirname, '..', 'doc',
'info.txt'), 'utf-8').split("\n"),
-output;
-
-output = raw.map(function(line) {
-if(line.match('%') ) {
-var type = (line.substr(5)).replace("\r",""),
-out = "";
-
-switch(type) {
-case "Node":
-out = shell.exec('node --version',{silent:true}).output;
-break;
-case "Cordova":
-out = require('../package').version;
-break;
-case "Config":
-out = fs.readFileSync(
cordova_util.projectConfig(projectRoot) );
-break;
-case "Platforms":
-out = doPlatforms( projectRoot );
-break;
-case "Plugins":
-out = doPlugins( projectRoot );
-break;
-default:
-break;
-}
-return line.replace( "%"+type, out );
-} else {
-return line;
+//Get projectRoot
+var projectRoot = cordova_util.cdProjectRoot(),
+output;
+delLog(projectRoot);
+//Get Node info
+info_utils.getNodeInfo(function (result){
+if( result ){
+print_SaveMsg(projectRoot, "Node version: "+ result);
+//Get Cordova version
+info_utils.getCordovaInfo(function (result){
+if( result ){print_SaveMsg(projectRoot,"Cordova version:
"+ result );
+// Get config.xml file
+fs.readFile(cordova_util.projectConfig(projectRoot) ,
'utf-8' , function ( err , result ){
+if(err) {print_SaveMsg(projectRoot,"Error reading
config.xml file"+ err);}
+print_SaveMsg(projectRoot,'Config.xml File: \r'+
result +'\r\r\r');
+print_SaveMsg(projectRoot,'Plugins: \r' +
doPlugins( projectRoot ) +'\r\r\r');
+//Get platforms info
+doPlatforms(projectRoot, function (result){
+if( result ){
+print_SaveMsg(projectRoot,result);
+}
+});
+});
+}
+});
}
-}).join("\n");
-
-// /*
-// Write to File;
-// */
-events.emit('results', output);
-fs.writeFileSync('info.txt', output );
+});
return Q();
--- End diff --
Noted, I'm going to look for another to do so.
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951464#comment-13951464
]
ASF GitHub Bot commented on CB-6329:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11087348
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+
+getNodeInfo: function( callback ){
+ callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+ },
+
+getCordovaInfo: function( callback ){
+ callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
+ },
+
+getPlatformInfo: function(platform, projectRoot, callback ){
+ var command="", args="";
+ switch( platform ){
+ case "ios":
+ _self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\r\r' +call);});
+ break;
+ case "android":
+ _self.execFunc('android', 'list target',
function(call){callback('Android Platform:\r\r' +call);});
--- End diff --
If you say so, I can change them all
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951460#comment-13951460
]
ASF GitHub Bot commented on CB-6329:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11087286
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
--- End diff --
my mistake, sorry.
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951463#comment-13951463
]
ASF GitHub Bot commented on CB-6329:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11087336
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+
+getNodeInfo: function( callback ){
+ callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+ },
+
+getCordovaInfo: function( callback ){
+ callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
--- End diff --
yes, you're right, I can change that.
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951462#comment-13951462
]
ASF GitHub Bot commented on CB-6329:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11087295
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+
+getNodeInfo: function( callback ){
+ callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
--- End diff --
got it
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[
https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951455#comment-13951455
]
ASF GitHub Bot commented on CB-5082:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11087137
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+getNodeInfo: function( callback ){
+callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+},
+
+getCordovaInfo: function( callback ){
+callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
+},
+
+getPlatformInfo: function(platform, projectRoot, callback ){
+var command="", args="";
+switch( platform ){
+case "ios":
+_self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\r\r' +call);});
+break;
+case "android":
+_self.execFunc('android', 'list target',
function(call){callback('Android Platform:\r\r' +call);});
+break;
+case "blackberry10":
+var bbUtilsPath = path.join(projectRoot, 'platforms',
platform, 'cordova'),
+bbBuildPath= path.join(projectRoot, 'platforms', platform,
'build'),
+bbresults="",
+varState;
+//get CORDOVA_BBTOOLS environment variable.
+_self.get_pathEnv( ['blackberry-nativepackager',
'blackberry-deploy'], function (path){
+if(path){
+//s et CORDOVA_BBTOOLS environment variable.
+varState = _self.setEnv_Var('CORDOVA_BBTOOLS', path,
false);
+// Get BB10 SDK Version
+_self.getSDKinfo(bbUtilsPath, function(result){
+if(result){bbresults+="Blackberry 10 Native SDK
version: "+result+"\r";
+// Get BB10 deployed and stored devices
+_self.deployedDevices(bbUtilsPath, 'device',
false, function(result){
+if(result){bbresults+="\rBlackberry 10
deployed devices:\r"+result+"\r";
+// Get BB10 deployed and stored
emulators
+_self.deployedDevices(bbUtilsPath,
'emulator', false, function (result){
+
if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r";
+
if(!varState){_self.delEnv_Var('CORDOVA_BBTOOLS');}
+callback('Blackberry 10
Platform:\r\r' +bbresults);
+}});
+}});
+}});
+}
+else{callback("Blackberry 10 Native SDK path not found");}
+});
+break;
+}
+},
+// Execute using a child_process exec, for any async command
+execFunc: function(command, args, callback){
+child_process.exec(command + ' ' +args,
+function (error, stdout, stderr) {
+callback(stdout);
+if (error !== null) {
+callback('Error performing command: ' + error + "\n"
+stderr);
+}
+});
+},
+//Uses Library to get Native SDK version
+getSDKinfo: function ( utilsPath, callback) {
+_self.execFunc("\"" +path.join(utilsPath,'bb10-ndk-version')+"\""
, '' ,function(output){callback(output);});
+},
+// It explores
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[
https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951445#comment-13951445
]
ASF GitHub Bot commented on CB-5082:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11086944
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+getNodeInfo: function( callback ){
+callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+},
+
+getCordovaInfo: function( callback ){
+callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
+},
+
+getPlatformInfo: function(platform, projectRoot, callback ){
+var command="", args="";
+switch( platform ){
+case "ios":
+_self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\r\r' +call);});
+break;
+case "android":
+_self.execFunc('android', 'list target',
function(call){callback('Android Platform:\r\r' +call);});
+break;
+case "blackberry10":
+var bbUtilsPath = path.join(projectRoot, 'platforms',
platform, 'cordova'),
+bbBuildPath= path.join(projectRoot, 'platforms', platform,
'build'),
+bbresults="",
+varState;
+//get CORDOVA_BBTOOLS environment variable.
+_self.get_pathEnv( ['blackberry-nativepackager',
'blackberry-deploy'], function (path){
+if(path){
+//s et CORDOVA_BBTOOLS environment variable.
+varState = _self.setEnv_Var('CORDOVA_BBTOOLS', path,
false);
+// Get BB10 SDK Version
+_self.getSDKinfo(bbUtilsPath, function(result){
+if(result){bbresults+="Blackberry 10 Native SDK
version: "+result+"\r";
+// Get BB10 deployed and stored devices
+_self.deployedDevices(bbUtilsPath, 'device',
false, function(result){
+if(result){bbresults+="\rBlackberry 10
deployed devices:\r"+result+"\r";
+// Get BB10 deployed and stored
emulators
+_self.deployedDevices(bbUtilsPath,
'emulator', false, function (result){
+
if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r";
+
if(!varState){_self.delEnv_Var('CORDOVA_BBTOOLS');}
+callback('Blackberry 10
Platform:\r\r' +bbresults);
+}});
+}});
+}});
+}
+else{callback("Blackberry 10 Native SDK path not found");}
+});
+break;
+}
+},
+// Execute using a child_process exec, for any async command
+execFunc: function(command, args, callback){
+child_process.exec(command + ' ' +args,
+function (error, stdout, stderr) {
+callback(stdout);
+if (error !== null) {
+callback('Error performing command: ' + error + "\n"
+stderr);
+}
+});
+},
+//Uses Library to get Native SDK version
+getSDKinfo: function ( utilsPath, callback) {
+_self.execFunc("\"" +path.join(utilsPath,'bb10-ndk-version')+"\""
, '' ,function(output){callback(output);});
+},
+// It explores
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[
https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951442#comment-13951442
]
ASF GitHub Bot commented on CB-5082:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11086870
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+getNodeInfo: function( callback ){
+callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+},
+
+getCordovaInfo: function( callback ){
+callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
+},
+
+getPlatformInfo: function(platform, projectRoot, callback ){
+var command="", args="";
+switch( platform ){
+case "ios":
+_self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\r\r' +call);});
+break;
+case "android":
+_self.execFunc('android', 'list target',
function(call){callback('Android Platform:\r\r' +call);});
+break;
+case "blackberry10":
+var bbUtilsPath = path.join(projectRoot, 'platforms',
platform, 'cordova'),
+bbBuildPath= path.join(projectRoot, 'platforms', platform,
'build'),
+bbresults="",
+varState;
+//get CORDOVA_BBTOOLS environment variable.
+_self.get_pathEnv( ['blackberry-nativepackager',
'blackberry-deploy'], function (path){
+if(path){
+//s et CORDOVA_BBTOOLS environment variable.
+varState = _self.setEnv_Var('CORDOVA_BBTOOLS', path,
false);
+// Get BB10 SDK Version
+_self.getSDKinfo(bbUtilsPath, function(result){
+if(result){bbresults+="Blackberry 10 Native SDK
version: "+result+"\r";
+// Get BB10 deployed and stored devices
+_self.deployedDevices(bbUtilsPath, 'device',
false, function(result){
+if(result){bbresults+="\rBlackberry 10
deployed devices:\r"+result+"\r";
+// Get BB10 deployed and stored
emulators
+_self.deployedDevices(bbUtilsPath,
'emulator', false, function (result){
+
if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r";
+
if(!varState){_self.delEnv_Var('CORDOVA_BBTOOLS');}
+callback('Blackberry 10
Platform:\r\r' +bbresults);
+}});
+}});
+}});
+}
+else{callback("Blackberry 10 Native SDK path not found");}
+});
+break;
+}
+},
+// Execute using a child_process exec, for any async command
+execFunc: function(command, args, callback){
+child_process.exec(command + ' ' +args,
+function (error, stdout, stderr) {
+callback(stdout);
+if (error !== null) {
+callback('Error performing command: ' + error + "\n"
+stderr);
+}
+});
+},
+//Uses Library to get Native SDK version
+getSDKinfo: function ( utilsPath, callback) {
+_self.execFunc("\"" +path.join(utilsPath,'bb10-ndk-version')+"\""
, '' ,function(output){callback(output);});
+},
+// It explores
[jira] [Created] (CB-6377) CLI is unable to create a project when there are spaces in the path
JennyGee created CB-6377: Summary: CLI is unable to create a project when there are spaces in the path Key: CB-6377 URL: https://issues.apache.org/jira/browse/CB-6377 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: JennyGee Priority: Critical Unable to create a project where there are spaces in the path. C:\Program Files\BlackBerry\BB10 WebWorks SDK 2.1.0.3\webworks-cli\node_modules\ wrench\lib\wrench.js:249 if (e.code !== 'EEXIST') throw e; ^ Error: ENOENT, no such file or directory 'C:\Documents and Settings\IEUser\.cord ova\lib\blackberry10\cordova\v2.1.0.3' at Object.fs.mkdirSync (fs.js:642:18) at Object.exports.copyDirSyncRecursive (C:\Program Files\BlackBerry\BB10 Web Works SDK 2.1.0.3\webworks-cli\node_modules\wrench\lib\wrench.js:246:12) at Object._self.fetchBlackBerry (C:\Program Files\BlackBerry\BB10 WebWorks S DK 2.1.0.3\webworks-cli\lib\utils\utils.js:59:20) at new CLI (C:\Program Files\BlackBerry\BB10 WebWorks SDK 2.1.0.3\webworks-c li\lib\cli.js:48:19) at Object. (C:\Program Files\BlackBerry\BB10 WebWorks SDK 2.1.0.3 \webworks-cli\bin\webworks:4:16) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Function.Module.runMain (module.js:497:10) Looking at the source code, it appears that https://issues.apache.org/jira/browse/CB-6323 broke https://issues.apache.org/jira/browse/CB-6306 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5362) URI parameter should be able to handle local repo
[
https://issues.apache.org/jira/browse/CB-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951389#comment-13951389
]
ASF GitHub Bot commented on CB-5362:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/83
> URI parameter should be able to handle local repo
> -
>
> Key: CB-5362
> URL: https://issues.apache.org/jira/browse/CB-5362
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry, CLI
>Affects Versions: 3.1.0
>Reporter: JennyGee
>Assignee: Josh Soref
>Priority: Minor
>
> (In cases where you have multiple copies of the pre-released cordova library
> and quickly switch between them.) In the project directory, you can have the
> following .cordova/config.json, and set:
> {code:javascript}
> {...
>"lib": {
>"android": {
>"version": "dev",
>"uri": "/some/local/path",
>"id": "cordova-android-dev"
>}
>}
> }
> Where the URI can specify some local REPO.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-4563) [BlackBerry10] Move blackberry.app feature params to widget preferences
[ https://issues.apache.org/jira/browse/CB-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951388#comment-13951388 ] ASF GitHub Bot commented on CB-4563: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/30 > [BlackBerry10] Move blackberry.app feature params to widget preferences > --- > > Key: CB-4563 > URL: https://issues.apache.org/jira/browse/CB-4563 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.0.0 >Reporter: Bryan Higgins >Assignee: Bryan Higgins > Fix For: 3.1.0 > > > Global widget preferences (such as orientation) should be moved out of the > blackberry.app feature. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3159) BB10 Documentation
[ https://issues.apache.org/jira/browse/CB-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951384#comment-13951384 ] ASF GitHub Bot commented on CB-3159: Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/44 > BB10 Documentation > -- > > Key: CB-3159 > URL: https://issues.apache.org/jira/browse/CB-3159 > Project: Apache Cordova > Issue Type: Sub-task > Components: BlackBerry >Reporter: Lorin Beer >Priority: Blocker > > new versions of guides and documentation matching any new workflow introduced > in the new codebase. > Major tasks are: > 1. Getting Started Guide > http://docs.phonegap.com/en/edge/guide_getting-started_blackberry_index.md.html#Getting%20Started%20with%20BlackBerry > 2. Command Line Usage > http://docs.phonegap.com/en/edge/guide_command-line_index.md.html#Command-Line%20Usage_blackberry > 3. Plugin Development Guide > http://docs.phonegap.com/en/edge/guide_plugin-development_blackberry_index.md.html#Developing%20a%20Plugin%20on%20BlackBerry -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5258) build / run - stdout & stderr empty on Windows
[ https://issues.apache.org/jira/browse/CB-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951383#comment-13951383 ] ASF GitHub Bot commented on CB-5258: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/70 > build / run - stdout & stderr empty on Windows > -- > > Key: CB-5258 > URL: https://issues.apache.org/jira/browse/CB-5258 > Project: Apache Cordova > Issue Type: Bug > Components: Android, BlackBerry, CLI, Coho, iOS, Plugman >Affects Versions: 3.1.0 >Reporter: Bryan Higgins >Assignee: Josh Soref > Fix For: 3.5.0 > > > Cordova CLI build and run commands do not show any error messages (stderr) > and when running in verbose mode no script output is displayed (stdout). > I noticed this problem testing Windows 8 + BlackBerry. I'm not sure if it > also affects other platforms. > Reverting from spawn to exec does not appear to fix the issue. Nor does > removing the call to "cmd /C" and appending ".bat". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5585) cordova emulate android doesn't exit
[ https://issues.apache.org/jira/browse/CB-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951382#comment-13951382 ] ASF GitHub Bot commented on CB-5585: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/115 > cordova emulate android doesn't exit > > > Key: CB-5585 > URL: https://issues.apache.org/jira/browse/CB-5585 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI >Affects Versions: 3.2.0 >Reporter: Carlos Santana >Assignee: Carlos Santana > Fix For: 3.3.0 > > > Cordova CLI 3.2.0-0.4.0 > Android Platform 3.2.0 > condition: no android emulator running > cordova create hello > cd hello > cordova platform add android > cordova emulate > Results: > emulator starts > app gets installed > app starts fine > But command prompt never exits. > Expected results: > cordova command to exit > This affects other projects like grunt-cordovacli and generator-cordovacli > because other commands are expected to run after "cordova emulate" -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5316) Spell Cordova as a brand unless it's a command or script
[ https://issues.apache.org/jira/browse/CB-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951386#comment-13951386 ] ASF GitHub Bot commented on CB-5316: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/73 > Spell Cordova as a brand unless it's a command or script > > > Key: CB-5316 > URL: https://issues.apache.org/jira/browse/CB-5316 > Project: Apache Cordova > Issue Type: Bug > Components: Android, BlackBerry, CLI, Coho, CordovaJS, iOS, Plugin > Device, Plugman >Affects Versions: 3.1.0 >Reporter: Josh Soref >Assignee: Josh Soref >Priority: Minor > > It's helpful to spell brands as they should be spelled (Apache, Atari, > BlackBerry, Cordova, ...) except when the item actually refers to something > that isn't just the general brand (cordova.js, cordova-cli/bin/cordova). > It makes it easier when reading error messages because if you see the brand, > then you know the error isn't talking about the command. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5183) WP7/8 lib path is not correctly resolved by CLI
[
https://issues.apache.org/jira/browse/CB-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951387#comment-13951387
]
ASF GitHub Bot commented on CB-5183:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/84
> WP7/8 lib path is not correctly resolved by CLI
> ---
>
> Key: CB-5183
> URL: https://issues.apache.org/jira/browse/CB-5183
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Reporter: Sergey Grebnov
>Assignee: Josh Soref
>Priority: Minor
> Attachments: cordova_wp8_wp7_cli.patch
>
>
> Steps to reproduce
> 1. Install latest cordova-cli from git repo
> 2. Create new project App using 'cordova create App' CLI command
> 3. Update app/.cordova/config.json to point to custom cordova-wp8 repo
> For example
> { "id":"org.apache.mobilespec", "name":"mobilespec", "lib": { "wp8": {
> "uri": "c:\\..\\cordova-wp8", "version": "3.1.0", "id":
> "cordova-wp8-master"} }}
> 4. Run 'cordova platform add wp8' commands
> Expected: command succeeded.
> Actually: command failed with the message below
> Error: Error while checking requirements:
> '"c:\..\cordova-wp8\bin\check_reqs"' is not recognized as an internal or
> external command,
> operable program or batch file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6338) Improve error for missing template
[
https://issues.apache.org/jira/browse/CB-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951385#comment-13951385
]
ASF GitHub Bot commented on CB-6338:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/149
> Improve error for missing template
> --
>
> Key: CB-6338
> URL: https://issues.apache.org/jira/browse/CB-6338
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>Priority: Minor
>
> Today when you try to create a project using a template whose path doesn't
> exist (typically due to a typo), you get:
> {quote}
> cordova create /tmp/xxxq a a
> '\{"id":"id","name":"name","lib":\{"www":\{"uri":"/tmp/xxqrtc","id":"custom","version":"0"}}}'
> Creating a new cordova project with name "a" and id "a" at location
> "/tmp/xxxq"
> Using custom www assets from /tmp/xxqrtc
> cp: no such file or directory: /tmp/xxqrtc/*
> {quote}
> The * isn't really appropriate, what doesn't exist is the template directory,
> not "*".
> {quote}
> cordova create /tmp/xxxq a a
> '\{"id":"id","name":"name","lib":\{"www":\{"uri":"/tmp/xxqrtc","id":"custom","version":"0"}}}'
> Creating a new cordova project with name "a" and id "a" at location
> "/tmp/xxxq"
> Using custom www assets from /tmp/xxqrtc
> Could not find directory: /tmp/xxqrtc
> {quote}
> If people don't think this should be handled by cli, I can host the code
> outside it, but...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-1388) Add reset() to plugin API and fix callback collisions on all platforms
[ https://issues.apache.org/jira/browse/CB-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951381#comment-13951381 ] ASF GitHub Bot commented on CB-1388: Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/79 > Add reset() to plugin API and fix callback collisions on all platforms > -- > > Key: CB-1388 > URL: https://issues.apache.org/jira/browse/CB-1388 > Project: Apache Cordova > Issue Type: Bug > Components: Bada, BlackBerry, CordovaJS, Qt, Tizen, webOS >Affects Versions: 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0 >Reporter: Braden Shepherdson >Assignee: Braden Shepherdson > Fix For: 2.8.0 > > > There are three parts to this bug. > First, platform-specific: we should add a reset() function to the plugin API > which is called on top-level navigation or refresh, so that plugins can know > to cancel any long-running requests and reinitialize themselves. This won't > be relevant to some platforms > Second, platform-independent: the callback IDs generated on the Javascript > side should be randomized in some way to prevent collisions after navigation. > Otherwise a request might get the ID "Service1", and before it has a chance > to complete we navigate and a new request is made, also receiving "Service1". > Then the first response comes back and the new Service1 callback is handed > the old results. > Third, we should add a test for this to Mobile Spec, if possible. This is a > tricky thing to reproduce reliably, unfortunately. > I'll tackle the second and third parts, and Android for the first part. It > would be great if people who work on other platforms would add the reset() > logic, or close the platform bugs if the platform is all-Javascript and fully > reloaded on navigation. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5258) build / run - stdout & stderr empty on Windows
[ https://issues.apache.org/jira/browse/CB-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951380#comment-13951380 ] ASF GitHub Bot commented on CB-5258: Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/82 > build / run - stdout & stderr empty on Windows > -- > > Key: CB-5258 > URL: https://issues.apache.org/jira/browse/CB-5258 > Project: Apache Cordova > Issue Type: Bug > Components: Android, BlackBerry, CLI, Coho, iOS, Plugman >Affects Versions: 3.1.0 >Reporter: Bryan Higgins >Assignee: Josh Soref > Fix For: 3.5.0 > > > Cordova CLI build and run commands do not show any error messages (stderr) > and when running in verbose mode no script output is displayed (stdout). > I noticed this problem testing Windows 8 + BlackBerry. I'm not sure if it > also affects other platforms. > Reverting from spawn to exec does not appear to fix the issue. Nor does > removing the call to "cmd /C" and appending ".bat". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6322) Simplify platforms/platform code for platform specifics
[
https://issues.apache.org/jira/browse/CB-6322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951378#comment-13951378
]
ASF GitHub Bot commented on CB-6322:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/146#discussion_r11085455
--- Diff: platforms.js ---
@@ -39,12 +41,14 @@ module.exports = {
version: '3.4.0'
},
'wp7' : {
+hostos : ['win32'],
--- End diff --
http://stackoverflow.com/questions/8683895/variable-to-detect-operating-system-in-node-scripts?answertab=votes#tab-top
windows returns 'win32', even on 64 bit operation systems. i.e.
process.platform === 'win32' is sufficient – Raynos Dec 30 '11 at 21:44
> Simplify platforms/platform code for platform specifics
> ---
>
> Key: CB-6322
> URL: https://issues.apache.org/jira/browse/CB-6322
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> Currently people who want to add a platform have to hack both platforms.js
> and platform.js
> Ideally they shouldn't have to hack platform.js at all.
> Before this change:
> {quote}
> $ cordova platform
> Installed platforms:
> Available platforms: android, blackberry10, firefoxos, ios
> {quote}
> After this change:
> {quote}
> $ cordova platform
> Installed platforms:
> Available platforms: amazon-fireos, android, blackberry10, firefoxos, ios
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951352#comment-13951352 ] Josh Bavari commented on CB-6279: - Cancel that last comment - ill get them since im on the task. > Add filter by platform > -- > > Key: CB-6279 > URL: https://issues.apache.org/jira/browse/CB-6279 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951350#comment-13951350 ] Josh Bavari commented on CB-6279: - I hear and comply. You removing or me? > Add filter by platform > -- > > Key: CB-6279 > URL: https://issues.apache.org/jira/browse/CB-6279 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4714) Allow removing a plugin that is a dependency (using -f or -force flag)
[ https://issues.apache.org/jira/browse/CB-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951336#comment-13951336 ] ASF GitHub Bot commented on CB-4714: Github user jbondc commented on the pull request: https://github.com/apache/cordova-plugman/pull/31#issuecomment-38964731 Ya will have a fix for it soon. > Allow removing a plugin that is a dependency (using -f or -force flag) > -- > > Key: CB-4714 > URL: https://issues.apache.org/jira/browse/CB-4714 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, Plugman >Affects Versions: 3.0.0 > Environment: Windows 8 >Reporter: Jonathan Bond >Assignee: Jonathan Bond >Priority: Minor > Labels: patch > Fix For: 3.5.0 > > Attachments: 0001-Use-plugman-emitter-of-events.patch, > 0002-CB-4714-Pass-options-to-plugin-uninstall.patch > > > Some context: > I wanted to start using the mobile spec app for cordova. The problem is I > didn't know which dependencies were required for the application. > So I created a plugin which just lists some dependencies: > https://github.com/jbondc/cordova-plugin-mobile-spec > > cordova create test > > cordova platform add android > >cordova plugin list > No plugins added. Use `cordova plugin add `. > >cordova plugin add https://github.com/jbondc/cordova-plugin-mobile-spec > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.file', > 'org.apache.cordova.core.media-capture', > 'org.apache.cordova.core.mobile-spec' ] > To test a modifications/patches to a specific plugin (media-capture), I > wanted to do: > >cordova plugin rm org.apache.cordova.core.media-capture > [Error: Another top-level plugin (org.apache.cordova.core.mobile-spec) relies > on plugin org.apache.cordova.core.media-capture, therefore aborting > uninstallation > .] > A lot of dependency management systems (freebsd ports, debian packages) allow > you to forcefully remove a dependency. > That's what I'm proposing: > >cordova plugin rm org.apache.cordova.core.media-capture -f > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.mobile-spec' ] > >cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-media-capture > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.media-capture', > 'org.apache.cordova.core.mobile-spec' ] > It makes it easier to add/remove a plugin even if some dependencies are not > met. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4714) Allow removing a plugin that is a dependency (using -f or -force flag)
[ https://issues.apache.org/jira/browse/CB-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951333#comment-13951333 ] ASF GitHub Bot commented on CB-4714: Github user jbondc closed the pull request at: https://github.com/apache/cordova-plugman/pull/31 > Allow removing a plugin that is a dependency (using -f or -force flag) > -- > > Key: CB-4714 > URL: https://issues.apache.org/jira/browse/CB-4714 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, Plugman >Affects Versions: 3.0.0 > Environment: Windows 8 >Reporter: Jonathan Bond >Assignee: Jonathan Bond >Priority: Minor > Labels: patch > Fix For: 3.5.0 > > Attachments: 0001-Use-plugman-emitter-of-events.patch, > 0002-CB-4714-Pass-options-to-plugin-uninstall.patch > > > Some context: > I wanted to start using the mobile spec app for cordova. The problem is I > didn't know which dependencies were required for the application. > So I created a plugin which just lists some dependencies: > https://github.com/jbondc/cordova-plugin-mobile-spec > > cordova create test > > cordova platform add android > >cordova plugin list > No plugins added. Use `cordova plugin add `. > >cordova plugin add https://github.com/jbondc/cordova-plugin-mobile-spec > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.file', > 'org.apache.cordova.core.media-capture', > 'org.apache.cordova.core.mobile-spec' ] > To test a modifications/patches to a specific plugin (media-capture), I > wanted to do: > >cordova plugin rm org.apache.cordova.core.media-capture > [Error: Another top-level plugin (org.apache.cordova.core.mobile-spec) relies > on plugin org.apache.cordova.core.media-capture, therefore aborting > uninstallation > .] > A lot of dependency management systems (freebsd ports, debian packages) allow > you to forcefully remove a dependency. > That's what I'm proposing: > >cordova plugin rm org.apache.cordova.core.media-capture -f > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.mobile-spec' ] > >cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-media-capture > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.media-capture', > 'org.apache.cordova.core.mobile-spec' ] > It makes it easier to add/remove a plugin even if some dependencies are not > met. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4714) Allow removing a plugin that is a dependency (using -f or -force flag)
[ https://issues.apache.org/jira/browse/CB-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951316#comment-13951316 ] ASF GitHub Bot commented on CB-4714: Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugman/pull/31#issuecomment-38963141 Going to close this given the work that's gone on since. Open a new one to continue on. > Allow removing a plugin that is a dependency (using -f or -force flag) > -- > > Key: CB-4714 > URL: https://issues.apache.org/jira/browse/CB-4714 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, Plugman >Affects Versions: 3.0.0 > Environment: Windows 8 >Reporter: Jonathan Bond >Assignee: Jonathan Bond >Priority: Minor > Labels: patch > Fix For: 3.5.0 > > Attachments: 0001-Use-plugman-emitter-of-events.patch, > 0002-CB-4714-Pass-options-to-plugin-uninstall.patch > > > Some context: > I wanted to start using the mobile spec app for cordova. The problem is I > didn't know which dependencies were required for the application. > So I created a plugin which just lists some dependencies: > https://github.com/jbondc/cordova-plugin-mobile-spec > > cordova create test > > cordova platform add android > >cordova plugin list > No plugins added. Use `cordova plugin add `. > >cordova plugin add https://github.com/jbondc/cordova-plugin-mobile-spec > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.file', > 'org.apache.cordova.core.media-capture', > 'org.apache.cordova.core.mobile-spec' ] > To test a modifications/patches to a specific plugin (media-capture), I > wanted to do: > >cordova plugin rm org.apache.cordova.core.media-capture > [Error: Another top-level plugin (org.apache.cordova.core.mobile-spec) relies > on plugin org.apache.cordova.core.media-capture, therefore aborting > uninstallation > .] > A lot of dependency management systems (freebsd ports, debian packages) allow > you to forcefully remove a dependency. > That's what I'm proposing: > >cordova plugin rm org.apache.cordova.core.media-capture -f > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.mobile-spec' ] > >cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-media-capture > >cordova plugin list > [ 'org.apache.cordova.core.battery-status', > 'org.apache.cordova.core.camera', > 'org.apache.cordova.core.device', > 'org.apache.cordova.core.media-capture', > 'org.apache.cordova.core.mobile-spec' ] > It makes it easier to add/remove a plugin even if some dependencies are not > met. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6272) Fix subdir handling
[
https://issues.apache.org/jira/browse/CB-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951314#comment-13951314
]
ASF GitHub Bot commented on CB-6272:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugman/pull/66
> Fix subdir handling
> ---
>
> Key: CB-6272
> URL: https://issues.apache.org/jira/browse/CB-6272
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Jonathan Bond
>Priority: Blocker
>
> CB-6160 landed [~jbondc]'s ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
> which broke some portion of install:
> +if (dep.subdir) {
> +dep.subdir = path.join(dep.subdir.split('/'));
> ...
> -if (dep_subdir) {
> -dep_subdir = path.join.apply(null,
> dep_subdir.split('/'));
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6272) Fix subdir handling
[
https://issues.apache.org/jira/browse/CB-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951313#comment-13951313
]
ASF subversion and git services commented on CB-6272:
-
Commit 54fc8582ca10b506d8268124f55718e9f31bc9d1 in cordova-plugman's branch
refs/heads/master from [~jbondc]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=54fc858 ]
CB-6272 Fix subdir bug + tests & meta fetch with a src directory
github: close #66
> Fix subdir handling
> ---
>
> Key: CB-6272
> URL: https://issues.apache.org/jira/browse/CB-6272
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Jonathan Bond
>Priority: Blocker
>
> CB-6160 landed [~jbondc]'s ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
> which broke some portion of install:
> +if (dep.subdir) {
> +dep.subdir = path.join(dep.subdir.split('/'));
> ...
> -if (dep_subdir) {
> -dep_subdir = path.join.apply(null,
> dep_subdir.split('/'));
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
[ https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951315#comment-13951315 ] ASF GitHub Bot commented on CB-6344: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/68 > Specify after which sibling to add config-changes in plugin.xml > --- > > Key: CB-6344 > URL: https://issues.apache.org/jira/browse/CB-6344 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugman >Reporter: Martin Bektchiev >Assignee: Martin Bektchiev > Original Estimate: 0h > Remaining Estimate: 0h > > The order of XML elements is important In the Windows Phone manifest file. > (e.g. see > http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement). > That's why we need to provide a way to specify where a specific element has > to be added. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
[
https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951305#comment-13951305
]
ASF subversion and git services commented on CB-6344:
-
Commit ac1160d470db03c2d2de2bbd7ad0ece336cf0394 in cordova-plugman's branch
refs/heads/master from [~mbektchiev]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=ac1160d ]
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(munge.files[file].parents[parent][index] { xml, count, after })
* add an after parameter to graftXML which contains a list of possible
predecessor elements separated by semicolon
* fix unit tests and add new ones
github: close #68
> Specify after which sibling to add config-changes in plugin.xml
> ---
>
> Key: CB-6344
> URL: https://issues.apache.org/jira/browse/CB-6344
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugman
>Reporter: Martin Bektchiev
>Assignee: Martin Bektchiev
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The order of XML elements is important In the Windows Phone manifest file.
> (e.g. see
> http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement).
> That's why we need to provide a way to specify where a specific element has
> to be added.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6141) Windows 8 test fails
[
https://issues.apache.org/jira/browse/CB-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951289#comment-13951289
]
ASF subversion and git services commented on CB-6141:
-
Commit 7e8c641aa8195ea2fcb3e28b4154966c424948e9 in cordova-cli's branch
refs/heads/master from [~jbondc]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=7e8c641 ]
CB-6141 Fix Windows 8 tests
github: close #135
> Windows 8 test fails
>
>
> Key: CB-6141
> URL: https://issues.apache.org/jira/browse/CB-6141
> Project: Apache Cordova
> Issue Type: Test
> Components: Plugman
>Affects Versions: 3.3.0
> Environment: Windows 8
>Reporter: Jonathan Bond
>Priority: Critical
> Fix For: Master
>
>
> npm test:
> > jasmine-node --color spec e2e
> .{ name: 'CordovaError',
> message: 'Symlinks on Windows require Administrator privileges' }
> F..this is script 1 in
> C:\Users\Jonathan\AppData\Local\Temp\e2e-test\hooks_test\project\.cordova\hooks\test\
> this is script 0 in
> C:\Users\Jonathan\AppData\Local\Temp\e2e-test\hooks_test\project\.cordova\hooks\test\
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (CB-6373) Do-not-call spies won't error if an exception is thrown
[
https://issues.apache.org/jira/browse/CB-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ian Clelland resolved CB-6373.
--
Resolution: Fixed
Fixed now; mobile spec tests are mostly passing still :) I don't see any other
failures revealed by this fix.
> Do-not-call spies won't error if an exception is thrown
> ---
>
> Key: CB-6373
> URL: https://issues.apache.org/jira/browse/CB-6373
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
>Reporter: Ian Clelland
>Assignee: Ian Clelland
>
> In the mobile spec test runner, the function created by
> {{createDoNotCallSpy}} logs an error message containing the JSON
> serialization of the function arguments, and then makes a false assertion, to
> cause a test to fail.
> If the function arguments are not JSON-serializable, then an exception will
> be thrown in the spy, and failure will never be asserted. If a test is
> counting on a doNotCallSpy to not be called, it may succeed, since the spy
> will never cause a test failure.
> (This was noticed because one of the File tests, file.spec.9, was failing
> unnoticed on iOS until FileEntry objects became serializable with CB-6352)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5606) WP8. Add ArrayBuffer support to exec bridge
[ https://issues.apache.org/jira/browse/CB-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951245#comment-13951245 ] ASF GitHub Bot commented on CB-5606: Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/65 > WP8. Add ArrayBuffer support to exec bridge > --- > > Key: CB-5606 > URL: https://issues.apache.org/jira/browse/CB-5606 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, WP8 >Reporter: Sergey Grebnov >Assignee: Jesse MacFadyen > > As per discussion "Windows Phone binary bridge" in the mailing list. > Right now WP7/8 does not support binary data type (ArrayBuffer) since there > is no special logic to serialize such data. Other platforms use base64 > encoding. > We should add support of ArrayBuffer to windows phone exec bridge. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-6370) Syntax error in camera test
[ https://issues.apache.org/jira/browse/CB-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland closed CB-6370. Resolution: Duplicate This is the same issue that caused CB-6352 (and was originally reported in CB-6347). It should be fixed now, in the dev branch of File > Syntax error in camera test > --- > > Key: CB-6370 > URL: https://issues.apache.org/jira/browse/CB-6370 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera >Affects Versions: 3.4.0 > Environment: Android 4.0.4 >Reporter: puchen > > Run camera test, click ‘camera.getPicture()’ success, then click 'Copy > Image', got error message: > Uncaught TypeError: Converting circular structure to JSON > reason: JSON.stringify([].slice.call(arguments)) is called failed at function > logCallback -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6322) Simplify platforms/platform code for platform specifics
[
https://issues.apache.org/jira/browse/CB-6322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951239#comment-13951239
]
ASF GitHub Bot commented on CB-6322:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/146#discussion_r11080870
--- Diff: platforms.js ---
@@ -39,12 +41,14 @@ module.exports = {
version: '3.4.0'
},
'wp7' : {
+hostos : ['win32'],
--- End diff --
win64?
> Simplify platforms/platform code for platform specifics
> ---
>
> Key: CB-6322
> URL: https://issues.apache.org/jira/browse/CB-6322
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> Currently people who want to add a platform have to hack both platforms.js
> and platform.js
> Ideally they shouldn't have to hack platform.js at all.
> Before this change:
> {quote}
> $ cordova platform
> Installed platforms:
> Available platforms: android, blackberry10, firefoxos, ios
> {quote}
> After this change:
> {quote}
> $ cordova platform
> Installed platforms:
> Available platforms: amazon-fireos, android, blackberry10, firefoxos, ios
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5520) Should we add "DEBUG=1" to "Preprocessor Macros"->"Debug" ?
[
https://issues.apache.org/jira/browse/CB-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951230#comment-13951230
]
Shazron Abdullah commented on CB-5520:
--
Hmm, didn't know about "3. Target .xcconfig" -- at least it is not configurable
in Xcode 5.
In Xcode 5 -> Project Settings -> Info -> Configuration you can set the
xcconfig, but not so in Target.
> Should we add "DEBUG=1" to "Preprocessor Macros"->"Debug" ?
> ---
>
> Key: CB-5520
> URL: https://issues.apache.org/jira/browse/CB-5520
> Project: Apache Cordova
> Issue Type: Wish
> Components: iOS
>Affects Versions: 3.2.0
>Reporter: glmnbeyond
>Assignee: Shazron Abdullah
>Priority: Minor
> Labels: core
>
> I created a helloCordova project via Cordova CLI, and added some debug info
> to native code:
> DLog('This is a debug info');
> But the debug info is never outputted.If I use ALog, the info can be
> outputted, so I think it probably has something to do with the "DEBUG" macro.
> After I added "DEBUG=1" to "Preprocessor Macros", ran the helloCordova
> target, DLog can be outputted.
> So here is my question:
> Should we add "DEBUG=1" to iOS template project->"Build Settings"->
> "Preprocessor Macros" ->"Debug" ?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[
https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951227#comment-13951227
]
ASF GitHub Bot commented on CB-5082:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11080438
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+getNodeInfo: function( callback ){
+callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+},
+
+getCordovaInfo: function( callback ){
+callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
+},
+
+getPlatformInfo: function(platform, projectRoot, callback ){
+var command="", args="";
+switch( platform ){
+case "ios":
+_self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\r\r' +call);});
+break;
+case "android":
+_self.execFunc('android', 'list target',
function(call){callback('Android Platform:\r\r' +call);});
+break;
+case "blackberry10":
+var bbUtilsPath = path.join(projectRoot, 'platforms',
platform, 'cordova'),
+bbBuildPath= path.join(projectRoot, 'platforms', platform,
'build'),
+bbresults="",
+varState;
+//get CORDOVA_BBTOOLS environment variable.
+_self.get_pathEnv( ['blackberry-nativepackager',
'blackberry-deploy'], function (path){
+if(path){
+//s et CORDOVA_BBTOOLS environment variable.
+varState = _self.setEnv_Var('CORDOVA_BBTOOLS', path,
false);
+// Get BB10 SDK Version
+_self.getSDKinfo(bbUtilsPath, function(result){
+if(result){bbresults+="Blackberry 10 Native SDK
version: "+result+"\r";
+// Get BB10 deployed and stored devices
+_self.deployedDevices(bbUtilsPath, 'device',
false, function(result){
+if(result){bbresults+="\rBlackberry 10
deployed devices:\r"+result+"\r";
+// Get BB10 deployed and stored
emulators
+_self.deployedDevices(bbUtilsPath,
'emulator', false, function (result){
+
if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r";
+
if(!varState){_self.delEnv_Var('CORDOVA_BBTOOLS');}
+callback('Blackberry 10
Platform:\r\r' +bbresults);
+}});
+}});
+}});
+}
+else{callback("Blackberry 10 Native SDK path not found");}
+});
+break;
+}
+},
+// Execute using a child_process exec, for any async command
+execFunc: function(command, args, callback){
+child_process.exec(command + ' ' +args,
+function (error, stdout, stderr) {
+callback(stdout);
+if (error !== null) {
+callback('Error performing command: ' + error + "\n"
+stderr);
+}
+});
+},
+//Uses Library to get Native SDK version
+getSDKinfo: function ( utilsPath, callback) {
+_self.execFunc("\"" +path.join(utilsPath,'bb10-ndk-version')+"\""
, '' ,function(output){callback(output);});
+},
+// It explores t
[jira] [Commented] (CB-6372) port createmobilespec.sh to Node.js
[ https://issues.apache.org/jira/browse/CB-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951228#comment-13951228 ] ASF GitHub Bot commented on CB-6372: Github user cmarcelk closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/54 > port createmobilespec.sh to Node.js > --- > > Key: CB-6372 > URL: https://issues.apache.org/jira/browse/CB-6372 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Do a simple port of the createmobilespec script from bash to Node.js. This is > a start to it working on other dev workstations (i.e., Windows), and to make > it easier to add improvements (i.e., support for platforms other than iOS and > Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[
https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951225#comment-13951225
]
ASF GitHub Bot commented on CB-5082:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11080370
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+getNodeInfo: function( callback ){
+callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+},
+
+getCordovaInfo: function( callback ){
+callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
+},
+
+getPlatformInfo: function(platform, projectRoot, callback ){
+var command="", args="";
+switch( platform ){
+case "ios":
+_self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\r\r' +call);});
+break;
+case "android":
+_self.execFunc('android', 'list target',
function(call){callback('Android Platform:\r\r' +call);});
+break;
+case "blackberry10":
+var bbUtilsPath = path.join(projectRoot, 'platforms',
platform, 'cordova'),
+bbBuildPath= path.join(projectRoot, 'platforms', platform,
'build'),
+bbresults="",
+varState;
+//get CORDOVA_BBTOOLS environment variable.
+_self.get_pathEnv( ['blackberry-nativepackager',
'blackberry-deploy'], function (path){
+if(path){
+//s et CORDOVA_BBTOOLS environment variable.
+varState = _self.setEnv_Var('CORDOVA_BBTOOLS', path,
false);
+// Get BB10 SDK Version
+_self.getSDKinfo(bbUtilsPath, function(result){
+if(result){bbresults+="Blackberry 10 Native SDK
version: "+result+"\r";
+// Get BB10 deployed and stored devices
+_self.deployedDevices(bbUtilsPath, 'device',
false, function(result){
+if(result){bbresults+="\rBlackberry 10
deployed devices:\r"+result+"\r";
+// Get BB10 deployed and stored
emulators
+_self.deployedDevices(bbUtilsPath,
'emulator', false, function (result){
+
if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r";
+
if(!varState){_self.delEnv_Var('CORDOVA_BBTOOLS');}
+callback('Blackberry 10
Platform:\r\r' +bbresults);
+}});
+}});
+}});
+}
+else{callback("Blackberry 10 Native SDK path not found");}
+});
+break;
+}
+},
+// Execute using a child_process exec, for any async command
+execFunc: function(command, args, callback){
+child_process.exec(command + ' ' +args,
+function (error, stdout, stderr) {
+callback(stdout);
+if (error !== null) {
+callback('Error performing command: ' + error + "\n"
+stderr);
+}
+});
+},
+//Uses Library to get Native SDK version
+getSDKinfo: function ( utilsPath, callback) {
+_self.execFunc("\"" +path.join(utilsPath,'bb10-ndk-version')+"\""
, '' ,function(output){callback(output);});
+},
+// It explores t
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951220#comment-13951220
]
ASF GitHub Bot commented on CB-6329:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080227
--- Diff: src/info.js ---
@@ -30,105 +29,80 @@ var cordova_util = require('./util'),
Outputs to a file
*/
module.exports = function info() {
-
-//Get the template
-var projectRoot = cordova_util.cdProjectRoot();
-
-var raw = fs.readFileSync(path.join(__dirname, '..', 'doc',
'info.txt'), 'utf-8').split("\n"),
-output;
-
-output = raw.map(function(line) {
-if(line.match('%') ) {
-var type = (line.substr(5)).replace("\r",""),
-out = "";
-
-switch(type) {
-case "Node":
-out = shell.exec('node --version',{silent:true}).output;
-break;
-case "Cordova":
-out = require('../package').version;
-break;
-case "Config":
-out = fs.readFileSync(
cordova_util.projectConfig(projectRoot) );
-break;
-case "Platforms":
-out = doPlatforms( projectRoot );
-break;
-case "Plugins":
-out = doPlugins( projectRoot );
-break;
-default:
-break;
-}
-return line.replace( "%"+type, out );
-} else {
-return line;
+//Get projectRoot
+var projectRoot = cordova_util.cdProjectRoot(),
+output;
+delLog(projectRoot);
+//Get Node info
+info_utils.getNodeInfo(function (result){
+if( result ){
+print_SaveMsg(projectRoot, "Node version: "+ result);
+//Get Cordova version
+info_utils.getCordovaInfo(function (result){
+if( result ){print_SaveMsg(projectRoot,"Cordova version:
"+ result );
+// Get config.xml file
+fs.readFile(cordova_util.projectConfig(projectRoot) ,
'utf-8' , function ( err , result ){
+if(err) {print_SaveMsg(projectRoot,"Error reading
config.xml file"+ err);}
+print_SaveMsg(projectRoot,'Config.xml File: \r'+
result +'\r\r\r');
+print_SaveMsg(projectRoot,'Plugins: \r' +
doPlugins( projectRoot ) +'\r\r\r');
+//Get platforms info
+doPlatforms(projectRoot, function (result){
+if( result ){
+print_SaveMsg(projectRoot,result);
+}
+});
+});
+}
+});
}
-}).join("\n");
-
-// /*
-// Write to File;
-// */
-events.emit('results', output);
-fs.writeFileSync('info.txt', output );
+});
return Q();
--- End diff --
Not this this is not synchronous, you need to have the returned promise not
resolve until the command is completed. Have a look at other examples where
promises are used.
It may also clean up your code above to use promises instead of such heavy
nesting.
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6372) port createmobilespec.sh to Node.js
[ https://issues.apache.org/jira/browse/CB-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951221#comment-13951221 ] ASF subversion and git services commented on CB-6372: - Commit b580fd9d079d824973d11f02e80234fd645d89df in cordova-mobile-spec's branch refs/heads/master from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=b580fd9 ] CB-6372 Port createmobilespec from bash to node. This is a straight-up port with no change in function. This is the initial work. Improvements and expansion can come later. > port createmobilespec.sh to Node.js > --- > > Key: CB-6372 > URL: https://issues.apache.org/jira/browse/CB-6372 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Do a simple port of the createmobilespec script from bash to Node.js. This is > a start to it working on other dev workstations (i.e., Windows), and to make > it easier to add improvements (i.e., support for platforms other than iOS and > Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6245) Tools Release March 31, 2014
[ https://issues.apache.org/jira/browse/CB-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951217#comment-13951217 ] Steve Gill commented on CB-6245: Waiting on iOS 3.4.1 (maybe 3.5.0) which is aiming to be ready on Monday. > Tools Release March 31, 2014 > > > Key: CB-6245 > URL: https://issues.apache.org/jira/browse/CB-6245 > Project: Apache Cordova > Issue Type: Task > Components: CLI, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6245) Tools Release March 31, 2014
[ https://issues.apache.org/jira/browse/CB-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-6245: --- Summary: Tools Release March 31, 2014 (was: Tools Release March 28, 2014) > Tools Release March 31, 2014 > > > Key: CB-6245 > URL: https://issues.apache.org/jira/browse/CB-6245 > Project: Apache Cordova > Issue Type: Task > Components: CLI, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951207#comment-13951207
]
ASF GitHub Bot commented on CB-6329:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080089
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+
+getNodeInfo: function( callback ){
+ callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+ },
+
+getCordovaInfo: function( callback ){
+ callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
+ },
+
+getPlatformInfo: function(platform, projectRoot, callback ){
+ var command="", args="";
+ switch( platform ){
+ case "ios":
+ _self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\r\r' +call);});
+ break;
+ case "android":
+ _self.execFunc('android', 'list target',
function(call){callback('Android Platform:\r\r' +call);});
--- End diff --
Why use \r? I think \n is much more common for newlines. Not sure if \r
even works correctly?
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951203#comment-13951203
]
ASF GitHub Bot commented on CB-6329:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080008
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+
+getNodeInfo: function( callback ){
+ callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
--- End diff --
Please use 4 space indent and remove trailing whitespace
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951206#comment-13951206
]
ASF GitHub Bot commented on CB-6329:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080035
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
+path = require('path'),
+fs= require('fs'),
+_self;
+
+_self = {
+
+getNodeInfo: function( callback ){
+ callback(_self.execFunc('node', '--version',
function(call){callback(call);}));
+ },
+
+getCordovaInfo: function( callback ){
+ callback(_self.execFunc('cordova', '--version',
function(call){callback(call);}));
--- End diff --
you're calling callback twice here and above.
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951202#comment-13951202
]
ASF GitHub Bot commented on CB-6329:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r1107
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+var cordova_util = require('./util'),
+child_process = require('child_process'),
--- End diff --
nit: indent these
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5836) Link to author profile from detail page
[ https://issues.apache.org/jira/browse/CB-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951198#comment-13951198 ] Steve Gill commented on CB-5836: This is not going into launch. Will be something we look into adding after. > Link to author profile from detail page > --- > > Key: CB-5836 > URL: https://issues.apache.org/jira/browse/CB-5836 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Joni Rustulka >Priority: Trivial > > Once users can login and create a profile on our site, link to their profile > from the details page. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951196#comment-13951196 ] Steve Gill commented on CB-6279: Talked to Joni. We aren't allowed to use the icons for the filters. They are copyrighted or something. Just checkboxes for now. > Add filter by platform > -- > > Key: CB-6279 > URL: https://issues.apache.org/jira/browse/CB-6279 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5606) WP8. Add ArrayBuffer support to exec bridge
[ https://issues.apache.org/jira/browse/CB-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951185#comment-13951185 ] ASF subversion and git services commented on CB-5606: - Commit 81f9a00ae27351350008bb84236635065cf124e8 in cordova-js's branch refs/heads/master from [~edwinvanderham] [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=81f9a00 ] CB-5606 WP8. ArrayBuffer does not exist in WP7 github: close #65 > WP8. Add ArrayBuffer support to exec bridge > --- > > Key: CB-5606 > URL: https://issues.apache.org/jira/browse/CB-5606 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, WP8 >Reporter: Sergey Grebnov >Assignee: Jesse MacFadyen > > As per discussion "Windows Phone binary bridge" in the mailing list. > Right now WP7/8 does not support binary data type (ArrayBuffer) since there > is no special logic to serialize such data. Other platforms use base64 > encoding. > We should add support of ArrayBuffer to windows phone exec bridge. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6127) Create Translations for Plugins for 3.4
[ https://issues.apache.org/jira/browse/CB-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951149#comment-13951149 ] ASF GitHub Bot commented on CB-6127: Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/192 > Create Translations for Plugins for 3.4 > --- > > Key: CB-6127 > URL: https://issues.apache.org/jira/browse/CB-6127 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Affects Versions: 3.4.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Fix For: 3.5.0 > > > Plugin documentation is no longer located in the cordova-docs repository for > 3.4. Instead we need to translate each of the 17 individual plugin > repository files. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6369) InAppBrowser->CSS/JS Injection->openWithScript test failed!
[
https://issues.apache.org/jira/browse/CB-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950774#comment-13950774
]
ASF GitHub Bot commented on CB-6369:
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/53#issuecomment-38924229
It would be helpful if you put your real name in your github profile, so we
could easily verify that you completed an ICLA. I had to search the mailing
list to find your name. http://markmail.org/message/dhf6snlztceytxph
> InAppBrowser->CSS/JS Injection->openWithScript test failed!
> ---
>
> Key: CB-6369
> URL: https://issues.apache.org/jira/browse/CB-6369
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, mobile-spec, Plugin InAppBrowser
>Affects Versions: 3.4.0
> Environment: Cordova-ios 3.5.0-dev
> org.apache.cordova.inappbrowser 0.3.3-dev
>Reporter: glmnbeyond
>
> Steps to reproduce it:
> 1) Using createmobilespec.sh to create mobilespec project
> 2) Load mobile-spec tests
> 3) Navigate to "In App Browser" and "CSS / JS Injection" section
> 4) Test "Script File Injection(callback)" "Script Literal Injection" and
> "Script Literal Injection(callback)"
> Results:
> The actual test results don't match with the descriptions of expected test
> results.
> Expected:
> The actual test results match with the descriptions of expected test results.
> For example, the expected test result of "Script Literal Injection
> (callback)" should be
> "open successfully in InAppBrowser with the text {color:green}"Script literal
> successfully injected"{color} and alert dialog with the text "Results
> verified". " instead of "open successfully in InAppBrowser with text
> {color:red}"InAppBrowser - Script / Style Injection Test"{color} and alert
> dialog with the text "Results verified"."
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
[ https://issues.apache.org/jira/browse/CB-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Yong updated CB-6375: -- Description: See screenshot here: http://imgur.com/NtQ4QSl Notice the large white gap at the top of the page When a page is tall enough to cause the page to slide upwards when the virtual keyboard is displayed, and while the page scroll position is scrolled down so that the header and / or other controls are hidden above the top edge of the screen, dismissing the keyboard will intermittently cause a page rendering error such that there is a large white gap above the header of the page, essentially pushing down all page contents. This also causes the hitboxes of buttons and other form controls to differ from the on screen view i.e. the hitboxes are where the controls should have appeared had there not been a large gap at the top of the screen. This gap is present on all pages within the app and will remain until another text input field is focused and the keyboard shows again. See screenshot here: http://imgur.com/NtQ4QSl In the above screenshot I clicked on the "submit registration" button before filling out the form correctly and triggering a validation error "confirm password". This caused the keyboard to hide and resulted in the page gap error as shown. The error also occurs when the keyboard is dismissed without hitting the "submit registration" button i.e. by using the dismiss keyboard button within the android nav bar. was: See screenshot here: http://imgur.com/NtQ4QSl Notice the large white gap at the top of the page When a page is tall enough to cause the page to slide upwards when the virtual keyboard is displayed, and while the page scroll position is scrolled down so that the header and / or other controls are hidden above the top edge of the screen, dismissing the keyboard will intermittently cause a page rendering error such that there is a large white gap above the header of the page, essentially pushing down all page contents. This also causes the hitboxes of buttons and other form controls to differ fro he on screen view i.e. the hitboxes are where the controls should have appeared had there not been a large gap at the top of the screen. This gap is present on all pages within the app and will remain until another text input field is focused and the keyboard shows again. See screenshot here: http://imgur.com/NtQ4QSl In the above screenshot I clicked on the "submit registration" button before filling out the form correctly and triggering a validation error "confirm password". This caused the keyboard to hide and resulted in the page gap error as shown. The error also occurs when the keyboard is dismissed without hitting the "submit registration" button i.e. by using the dismiss keyboard button within the android nav bar. > When keyboard is dismissed. Page has a large gap at top of screen > - > > Key: CB-6375 > URL: https://issues.apache.org/jira/browse/CB-6375 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 >Reporter: Jonathan Yong > > See screenshot here: http://imgur.com/NtQ4QSl > Notice the large white gap at the top of the page > When a page is tall enough to cause the page to slide upwards when the > virtual keyboard is displayed, and while the page scroll position is scrolled > down so that the header and / or other controls are hidden above the top edge > of the screen, dismissing the keyboard will intermittently cause a page > rendering error such that there is a large white gap above the header of the > page, essentially pushing down all page contents. > This also causes the hitboxes of buttons and other form controls to differ > from the on screen view i.e. the hitboxes are where the controls should have > appeared had there not been a large gap at the top of the screen. > This gap is present on all pages within the app and will remain until another > text input field is focused and the keyboard shows again. > See screenshot here: http://imgur.com/NtQ4QSl > In the above screenshot I clicked on the "submit registration" button before > filling out the form correctly and triggering a validation error "confirm > password". This caused the keyboard to hide and resulted in the page gap > error as shown. > The error also occurs when the keyboard is dismissed without hitting the > "submit registration" button i.e. by using the dismiss keyboard button within > the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6374) deprecation warnings from iOS 6
[ https://issues.apache.org/jira/browse/CB-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Jong updated CB-6374: --- Attachment: deprecation_warnings2.png deprecation_warnings1.png > deprecation warnings from iOS 6 > --- > > Key: CB-6374 > URL: https://issues.apache.org/jira/browse/CB-6374 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera, Plugin Contacts, Plugin InAppBrowser, > Plugin Media Capture >Reporter: James Jong >Priority: Minor > Attachments: deprecation_warnings1.png, deprecation_warnings2.png > > > See attachments for details on deprecation warnings from iOS 6. Mostly > related to warnings of using ModalViewController. The deprecations should be > fixed when support for < iOS 6 is removed from Cordova. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
Jonathan Yong created CB-6375: - Summary: When keyboard is dismissed. Page has a large gap at top of screen Key: CB-6375 URL: https://issues.apache.org/jira/browse/CB-6375 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.4.0 Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 Reporter: Jonathan Yong See screenshot here: http://imgur.com/NtQ4QSl Notice the large white gap at the top of the page When a page is tall enough to cause the page to slide upwards when the virtual keyboard is displayed, and while the page scroll position is scrolled down so that the header and / or other controls are hidden above the top edge of the screen, dismissing the keyboard will intermittantly cause a page rendering error when there is a large white gap above the header of the page, essentially pushing down all page contents. This also causes the hitboxes of buttons and other form controls to differ fro he on screen view i.e. the hitboxes are where the controls should have appeared had there not been a large gap at the top of the screen. This gap is present on all pages within the app and will remain until another text input field is focused and the keyboard shows again. See screenshot here: http://imgur.com/NtQ4QSl In the above screenshot I clicked on the "submit registration" button before filling out the form correctly and triggering a validation error "confirm password". This caused the keyboard to hide and resulted in the page gap error as shown. The error also occurs when the keyboard is dismissed without hitting the "submit registration" button i.e. by using the dismiss keyboard button within the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6212) fix plugin warnings compiled under arm64 64-bit
[ https://issues.apache.org/jira/browse/CB-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950772#comment-13950772 ] ASF subversion and git services commented on CB-6212: - Commit db9fa24cf8ba165aabae0460a9cbeb1dd1d67e62 in cordova-plugin-media-capture's branch refs/heads/dev from [~wjamesjong] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=db9fa24 ] CB-6212 iOS: fix warnings compiled under arm64 64-bit -fix one more warning > fix plugin warnings compiled under arm64 64-bit > --- > > Key: CB-6212 > URL: https://issues.apache.org/jira/browse/CB-6212 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera, Plugin Contacts, Plugin Dialogs, Plugin > File, Plugin File Transfer, Plugin Geolocation, Plugin Globalization, Plugin > InAppBrowser, Plugin Media, Plugin Media Capture >Reporter: James Jong >Assignee: James Jong >Priority: Minor > Fix For: 3.5.0 > > > Fix plugin warnings compiled under arm64 64-bit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6374) deprecation warnings from iOS 6
James Jong created CB-6374: -- Summary: deprecation warnings from iOS 6 Key: CB-6374 URL: https://issues.apache.org/jira/browse/CB-6374 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera, Plugin Contacts, Plugin InAppBrowser, Plugin Media Capture Reporter: James Jong Priority: Minor See attachments for details on deprecation warnings from iOS 6. Mostly related to warnings of using ModalViewController. The deprecations should be fixed when support for < iOS 6 is removed from Cordova. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
[ https://issues.apache.org/jira/browse/CB-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Yong updated CB-6375: -- Description: See screenshot here: http://imgur.com/NtQ4QSl Notice the large white gap at the top of the page When a page is tall enough to cause the page to slide upwards when the virtual keyboard is displayed, and while the page scroll position is scrolled down so that the header and / or other controls are hidden above the top edge of the screen, dismissing the keyboard will intermittently cause a page rendering error such that there is a large white gap above the header of the page, essentially pushing down all page contents. This also causes the hitboxes of buttons and other form controls to differ fro he on screen view i.e. the hitboxes are where the controls should have appeared had there not been a large gap at the top of the screen. This gap is present on all pages within the app and will remain until another text input field is focused and the keyboard shows again. See screenshot here: http://imgur.com/NtQ4QSl In the above screenshot I clicked on the "submit registration" button before filling out the form correctly and triggering a validation error "confirm password". This caused the keyboard to hide and resulted in the page gap error as shown. The error also occurs when the keyboard is dismissed without hitting the "submit registration" button i.e. by using the dismiss keyboard button within the android nav bar. was: See screenshot here: http://imgur.com/NtQ4QSl Notice the large white gap at the top of the page When a page is tall enough to cause the page to slide upwards when the virtual keyboard is displayed, and while the page scroll position is scrolled down so that the header and / or other controls are hidden above the top edge of the screen, dismissing the keyboard will intermittantly cause a page rendering error when there is a large white gap above the header of the page, essentially pushing down all page contents. This also causes the hitboxes of buttons and other form controls to differ fro he on screen view i.e. the hitboxes are where the controls should have appeared had there not been a large gap at the top of the screen. This gap is present on all pages within the app and will remain until another text input field is focused and the keyboard shows again. See screenshot here: http://imgur.com/NtQ4QSl In the above screenshot I clicked on the "submit registration" button before filling out the form correctly and triggering a validation error "confirm password". This caused the keyboard to hide and resulted in the page gap error as shown. The error also occurs when the keyboard is dismissed without hitting the "submit registration" button i.e. by using the dismiss keyboard button within the android nav bar. > When keyboard is dismissed. Page has a large gap at top of screen > - > > Key: CB-6375 > URL: https://issues.apache.org/jira/browse/CB-6375 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 >Reporter: Jonathan Yong > > See screenshot here: http://imgur.com/NtQ4QSl > Notice the large white gap at the top of the page > When a page is tall enough to cause the page to slide upwards when the > virtual keyboard is displayed, and while the page scroll position is scrolled > down so that the header and / or other controls are hidden above the top edge > of the screen, dismissing the keyboard will intermittently cause a page > rendering error such that there is a large white gap above the header of the > page, essentially pushing down all page contents. > This also causes the hitboxes of buttons and other form controls to differ > fro he on screen view i.e. the hitboxes are where the controls should have > appeared had there not been a large gap at the top of the screen. > This gap is present on all pages within the app and will remain until another > text input field is focused and the keyboard shows again. > See screenshot here: http://imgur.com/NtQ4QSl > In the above screenshot I clicked on the "submit registration" button before > filling out the form correctly and triggering a validation error "confirm > password". This caused the keyboard to hide and resulted in the page gap > error as shown. > The error also occurs when the keyboard is dismissed without hitting the > "submit registration" button i.e. by using the dismiss keyboard button within > the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5516) StatusBar Plugin breaks with Keyboard Plugin ShrinksView enabled and text box selected
[ https://issues.apache.org/jira/browse/CB-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951017#comment-13951017 ] ASF GitHub Bot commented on CB-5516: GitHub user gconnolly opened a pull request: https://github.com/apache/cordova-plugins/pull/8 Resize webView to handle orientation change when keyboard will hide The webView does not get properly resized if the orientation changes before the keyboard is dismissed. This issue was introduced by CB-5516. Rather restoring the entire savedWebViewFrame, just use the origin of the savedWebViewFrame to transform the the viewController.view.bounds. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gconnolly/cordova-plugins master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugins/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit 6f60ce76e924bb82d4cabdac908aa988bebf9149 Author: Gene Connolly Date: 2014-03-28T16:51:14Z Resize webView to handle orientation change when keyboard will hide The webView does not get properly resized if the orientation changes before the keyboard is dismissed. This issue was introduced by CB-5516. Rather restoring the entire savedWebViewFrame, just use the origin of the savedWebViewFrame to transform the the viewController.view.bounds. > StatusBar Plugin breaks with Keyboard Plugin ShrinksView enabled and text box > selected > -- > > Key: CB-5516 > URL: https://issues.apache.org/jira/browse/CB-5516 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugins >Affects Versions: 3.2.0 > Environment: Xcode 5, iOS 7 simulator >Reporter: Jon Tancer >Assignee: Shazron Abdullah > Labels: keyboard-plugin, statusbar-plugin > > When the keyboard plugin and the status bar plugin are both installed and > configured with the following options: > Keyboard.shrinkView(true); > StatusBar.overlaysWebView(false); > After tapping a select drop down or focusing on a text input, then hiding > native iOS keyboard/select list, it seems the webview gets pushed up behind > the statusbar. The status bar is still shown (like in iOS 6), but now some > of the webview is hidden below it. > Calling StatusBar.hide() then StatusBar.show() resolves the issue but is not > ideal. > When the app first opens this issue is not present. It only starts to happen > after a form element gains focus and the keyboard or select list native iOS > controls are opened then dismissed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6369) InAppBrowser->CSS/JS Injection->openWithScript test failed!
[
https://issues.apache.org/jira/browse/CB-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950842#comment-13950842
]
ASF GitHub Bot commented on CB-6369:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/53
> InAppBrowser->CSS/JS Injection->openWithScript test failed!
> ---
>
> Key: CB-6369
> URL: https://issues.apache.org/jira/browse/CB-6369
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, mobile-spec, Plugin InAppBrowser
>Affects Versions: 3.4.0
> Environment: Cordova-ios 3.5.0-dev
> org.apache.cordova.inappbrowser 0.3.3-dev
>Reporter: glmnbeyond
>
> Steps to reproduce it:
> 1) Using createmobilespec.sh to create mobilespec project
> 2) Load mobile-spec tests
> 3) Navigate to "In App Browser" and "CSS / JS Injection" section
> 4) Test "Script File Injection(callback)" "Script Literal Injection" and
> "Script Literal Injection(callback)"
> Results:
> The actual test results don't match with the descriptions of expected test
> results.
> Expected:
> The actual test results match with the descriptions of expected test results.
> For example, the expected test result of "Script Literal Injection
> (callback)" should be
> "open successfully in InAppBrowser with the text {color:green}"Script literal
> successfully injected"{color} and alert dialog with the text "Results
> verified". " instead of "open successfully in InAppBrowser with text
> {color:red}"InAppBrowser - Script / Style Injection Test"{color} and alert
> dialog with the text "Results verified"."
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6085) Note Windows 8.1 apps not backward-compatible to 8.0
[ https://issues.apache.org/jira/browse/CB-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951128#comment-13951128 ] ASF subversion and git services commented on CB-6085: - Commit a02f09b017008cd675be9aead4743f6e658368d5 in cordova-docs's branch refs/heads/master from [~sierra] [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=a02f09b ] CB-6085 Note Windows 8.0/8.1 compatibility issue github: close #191 > Note Windows 8.1 apps not backward-compatible to 8.0 > > > Key: CB-6085 > URL: https://issues.apache.org/jira/browse/CB-6085 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Mike Sierra >Assignee: Mike Sierra >Priority: Minor > > Windows 8.1 apps don't run on Windows 8.0. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6373) Do-not-call spies won't error if an exception is thrown
[
https://issues.apache.org/jira/browse/CB-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950758#comment-13950758
]
ASF subversion and git services commented on CB-6373:
-
Commit 1fd31480eef4b3ecf28d1ef7bea9acaa1ee45ec0 in cordova-mobile-spec's branch
refs/heads/master from [~iclelland]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=1fd3148 ]
CB-6373: Make doNotCallSpies more resilient to errors
This ensures that they cause test failures, even when a JSON exception is thrown
while logging the error.
> Do-not-call spies won't error if an exception is thrown
> ---
>
> Key: CB-6373
> URL: https://issues.apache.org/jira/browse/CB-6373
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
>Reporter: Ian Clelland
>Assignee: Ian Clelland
>
> In the mobile spec test runner, the function created by
> {{createDoNotCallSpy}} logs an error message containing the JSON
> serialization of the function arguments, and then makes a false assertion, to
> cause a test to fail.
> If the function arguments are not JSON-serializable, then an exception will
> be thrown in the spy, and failure will never be asserted. If a test is
> counting on a doNotCallSpy to not be called, it may succeed, since the spy
> will never cause a test failure.
> (This was noticed because one of the File tests, file.spec.9, was failing
> unnoticed on iOS until FileEntry objects became serializable with CB-6352)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6372) port createmobilespec.sh to Node.js
[ https://issues.apache.org/jira/browse/CB-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950681#comment-13950681 ] Marcel Kinard commented on CB-6372: --- Any comments on this before I commit it to master? > port createmobilespec.sh to Node.js > --- > > Key: CB-6372 > URL: https://issues.apache.org/jira/browse/CB-6372 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Do a simple port of the createmobilespec script from bash to Node.js. This is > a start to it working on other dev workstations (i.e., Windows), and to make > it easier to add improvements (i.e., support for platforms other than iOS and > Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6376) [BlackBerry10] backgroundColor in user.js is missing quotes
[ https://issues.apache.org/jira/browse/CB-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951122#comment-13951122 ] ASF subversion and git services commented on CB-6376: - Commit e3fd5de55e57475b74b87848264569bc5c09540b in cordova-blackberry's branch refs/heads/master from [~bhigg...@blackberry.com] [ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=e3fd5de ] CB-6376 backgroundColor in user.js is missing quotes > [BlackBerry10] backgroundColor in user.js is missing quotes > --- > > Key: CB-6376 > URL: https://issues.apache.org/jira/browse/CB-6376 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Reporter: Bryan Higgins >Assignee: Bryan Higgins > Fix For: 3.5.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-6376) [BlackBerry10] backgroundColor in user.js is missing quotes
[ https://issues.apache.org/jira/browse/CB-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Higgins closed CB-6376. - Resolution: Fixed > [BlackBerry10] backgroundColor in user.js is missing quotes > --- > > Key: CB-6376 > URL: https://issues.apache.org/jira/browse/CB-6376 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Reporter: Bryan Higgins >Assignee: Bryan Higgins > Fix For: 3.5.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6376) [BlackBerry10] backgroundColor in user.js is missing quotes
Bryan Higgins created CB-6376: - Summary: [BlackBerry10] backgroundColor in user.js is missing quotes Key: CB-6376 URL: https://issues.apache.org/jira/browse/CB-6376 Project: Apache Cordova Issue Type: Bug Components: BlackBerry Reporter: Bryan Higgins Assignee: Bryan Higgins Fix For: 3.5.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6369) InAppBrowser->CSS/JS Injection->openWithScript test failed!
[
https://issues.apache.org/jira/browse/CB-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950783#comment-13950783
]
ASF subversion and git services commented on CB-6369:
-
Commit e5aac984091c6e83d1029244793cbbb2a7aaf848 in cordova-mobile-spec's branch
refs/heads/master from [~glmnbeyond]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=e5aac98 ]
CB-6369: Update the descriptions of expected results for InAppBrowser
openWithScript tests.
github: close #53
> InAppBrowser->CSS/JS Injection->openWithScript test failed!
> ---
>
> Key: CB-6369
> URL: https://issues.apache.org/jira/browse/CB-6369
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, mobile-spec, Plugin InAppBrowser
>Affects Versions: 3.4.0
> Environment: Cordova-ios 3.5.0-dev
> org.apache.cordova.inappbrowser 0.3.3-dev
>Reporter: glmnbeyond
>
> Steps to reproduce it:
> 1) Using createmobilespec.sh to create mobilespec project
> 2) Load mobile-spec tests
> 3) Navigate to "In App Browser" and "CSS / JS Injection" section
> 4) Test "Script File Injection(callback)" "Script Literal Injection" and
> "Script Literal Injection(callback)"
> Results:
> The actual test results don't match with the descriptions of expected test
> results.
> Expected:
> The actual test results match with the descriptions of expected test results.
> For example, the expected test result of "Script Literal Injection
> (callback)" should be
> "open successfully in InAppBrowser with the text {color:green}"Script literal
> successfully injected"{color} and alert dialog with the text "Results
> verified". " instead of "open successfully in InAppBrowser with text
> {color:red}"InAppBrowser - Script / Style Injection Test"{color} and alert
> dialog with the text "Results verified"."
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-6335) Blackberry file plugin accessing file system returns no results
[
https://issues.apache.org/jira/browse/CB-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boston Dell-Vandenberg updated CB-6335:
---
Description:
Trying to access the Blackberry shared folder and list it's contents but the
file plugin is returning no entries (FileError Code 1).
blackberry.io.sandbox is set to false and the blackberry.io plugin is installed
to access the shared folder path.
I have tested on both emulator and device (10.2) with the following code:
{code}
window.requestFileSystem(
LocalFileSystem.PERSISTENT,
1024 * 1024,
function (fs) {
fs.root.getDirectory(
blackberry.io.sharedFolder,
{},
function(result) {
var reader = result.createReader();
reader.readEntries(
function(entries) {
console.log(entries);
},
function (error) {
console.log('Failed to list directory contents: ', error);
}
);
},
function(error) {
console.log('Error accessing shared folder');
}
);
},
function () {
console.log('Error accessing local file system');
}
);
{code}
was:
Trying to access the Blackberry shared folder and list it's contents but the
file plugin is returning no entries (FileError Code 1).
blackberry.io.sandbox is set to false and the blackberry.io plugin is installed
to access the shared folder path.
I have tested on both emulator and device (10.2) with the following code:
[code]
window.requestFileSystem(
LocalFileSystem.PERSISTENT,
1024 * 1024,
function (fs) {
fs.root.getDirectory(
blackberry.io.sharedFolder,
{},
function(result) {
var reader = result.createReader();
reader.readEntries(
function(entries) {
console.log(entries);
},
function (error) {
console.log('Failed to list directory contents: ', error);
}
);
},
function(error) {
console.log('Error accessing shared folder');
}
);
},
function () {
console.log('Error accessing local file system');
}
);
[code]
> Blackberry file plugin accessing file system returns no results
> ---
>
> Key: CB-6335
> URL: https://issues.apache.org/jira/browse/CB-6335
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry, Plugin File
>Affects Versions: 3.4.0
> Environment: File plugin 1.0.1, Blackberry 10.2.x emulator & device
> (Z10)
>Reporter: Boston Dell-Vandenberg
>
> Trying to access the Blackberry shared folder and list it's contents but the
> file plugin is returning no entries (FileError Code 1).
> blackberry.io.sandbox is set to false and the blackberry.io plugin is
> installed to access the shared folder path.
> I have tested on both emulator and device (10.2) with the following code:
> {code}
> window.requestFileSystem(
> LocalFileSystem.PERSISTENT,
> 1024 * 1024,
> function (fs) {
> fs.root.getDirectory(
> blackberry.io.sharedFolder,
> {},
> function(result) {
> var reader = result.createReader();
> reader.readEntries(
> function(entries) {
> console.log(entries);
> },
> function (error) {
> console.log('Failed to list directory contents: ', error);
> }
> );
> },
> function(error) {
> console.log('Error accessing shared folder');
> }
> );
> },
> function () {
> console.log('Error accessing local file system');
> }
> );
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
[ https://issues.apache.org/jira/browse/CB-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951014#comment-13951014 ] Jonathan Yong commented on CB-6375: --- It can be reproduced with the helloworld phonegap 3.4 project template. I have uploaded an example here: https://drive.google.com/file/d/0Bzb7gVjeXDYwWFhPMWFadkNqSWc/edit?usp=sharing To reproduce, deploy to an android device (I am using Nexus 5, 4.4.2) then click on the textfield at the bottom of the page to bring up the keyboard. Then dismiss the keyboard. The problem happens intermittently so you may need to show and dismiss the keyboard multiple times. > When keyboard is dismissed. Page has a large gap at top of screen > - > > Key: CB-6375 > URL: https://issues.apache.org/jira/browse/CB-6375 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 >Reporter: Jonathan Yong > > See screenshot here: http://imgur.com/NtQ4QSl > Notice the large white gap at the top of the page > When a page is tall enough to cause the page to slide upwards when the > virtual keyboard is displayed, and while the page scroll position is scrolled > down so that the header and / or other controls are hidden above the top edge > of the screen, dismissing the keyboard will intermittently cause a page > rendering error such that there is a large white gap above the header of the > page, essentially pushing down all page contents. > This also causes the hitboxes of buttons and other form controls to differ > from the on screen view i.e. the hitboxes are where the controls should have > appeared had there not been a large gap at the top of the screen. > This gap is present on all pages within the app and will remain until another > text input field is focused and the keyboard shows again. > See screenshot here: http://imgur.com/NtQ4QSl > In the above screenshot I clicked on the "submit registration" button before > filling out the form correctly and triggering a validation error "confirm > password". This caused the keyboard to hide and resulted in the page gap > error as shown. > The error also occurs when the keyboard is dismissed without hitting the > "submit registration" button i.e. by using the dismiss keyboard button within > the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
[ https://issues.apache.org/jira/browse/CB-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950961#comment-13950961 ] Jonathan Yong commented on CB-6375: --- Give me a sec to throw together a quick test without jQuery Mobile and I'll report back. > When keyboard is dismissed. Page has a large gap at top of screen > - > > Key: CB-6375 > URL: https://issues.apache.org/jira/browse/CB-6375 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 >Reporter: Jonathan Yong > > See screenshot here: http://imgur.com/NtQ4QSl > Notice the large white gap at the top of the page > When a page is tall enough to cause the page to slide upwards when the > virtual keyboard is displayed, and while the page scroll position is scrolled > down so that the header and / or other controls are hidden above the top edge > of the screen, dismissing the keyboard will intermittently cause a page > rendering error such that there is a large white gap above the header of the > page, essentially pushing down all page contents. > This also causes the hitboxes of buttons and other form controls to differ > from the on screen view i.e. the hitboxes are where the controls should have > appeared had there not been a large gap at the top of the screen. > This gap is present on all pages within the app and will remain until another > text input field is focused and the keyboard shows again. > See screenshot here: http://imgur.com/NtQ4QSl > In the above screenshot I clicked on the "submit registration" button before > filling out the form correctly and triggering a validation error "confirm > password". This caused the keyboard to hide and resulted in the page gap > error as shown. > The error also occurs when the keyboard is dismissed without hitting the > "submit registration" button i.e. by using the dismiss keyboard button within > the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6369) InAppBrowser->CSS/JS Injection->openWithScript test failed!
[
https://issues.apache.org/jira/browse/CB-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950784#comment-13950784
]
Marcel Kinard commented on CB-6369:
---
Pull request merged. Thanks for the contribution!
Please Close the pull request, and Resolve this Jira issue.
> InAppBrowser->CSS/JS Injection->openWithScript test failed!
> ---
>
> Key: CB-6369
> URL: https://issues.apache.org/jira/browse/CB-6369
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, mobile-spec, Plugin InAppBrowser
>Affects Versions: 3.4.0
> Environment: Cordova-ios 3.5.0-dev
> org.apache.cordova.inappbrowser 0.3.3-dev
>Reporter: glmnbeyond
>
> Steps to reproduce it:
> 1) Using createmobilespec.sh to create mobilespec project
> 2) Load mobile-spec tests
> 3) Navigate to "In App Browser" and "CSS / JS Injection" section
> 4) Test "Script File Injection(callback)" "Script Literal Injection" and
> "Script Literal Injection(callback)"
> Results:
> The actual test results don't match with the descriptions of expected test
> results.
> Expected:
> The actual test results match with the descriptions of expected test results.
> For example, the expected test result of "Script Literal Injection
> (callback)" should be
> "open successfully in InAppBrowser with the text {color:green}"Script literal
> successfully injected"{color} and alert dialog with the text "Results
> verified". " instead of "open successfully in InAppBrowser with text
> {color:red}"InAppBrowser - Script / Style Injection Test"{color} and alert
> dialog with the text "Results verified"."
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
[ https://issues.apache.org/jira/browse/CB-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951053#comment-13951053 ] Jonathan Yong commented on CB-6375: --- Also note that fullscreen = false is required to push the view upwards when the keyboard is shown. Otherwise the view does not change and the keyboard obscures the text input field. > When keyboard is dismissed. Page has a large gap at top of screen > - > > Key: CB-6375 > URL: https://issues.apache.org/jira/browse/CB-6375 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 >Reporter: Jonathan Yong > > See screenshot here: http://imgur.com/NtQ4QSl > Notice the large white gap at the top of the page > When a page is tall enough to cause the page to slide upwards when the > virtual keyboard is displayed, and while the page scroll position is scrolled > down so that the header and / or other controls are hidden above the top edge > of the screen, dismissing the keyboard will intermittently cause a page > rendering error such that there is a large white gap above the header of the > page, essentially pushing down all page contents. > This also causes the hitboxes of buttons and other form controls to differ > from the on screen view i.e. the hitboxes are where the controls should have > appeared had there not been a large gap at the top of the screen. > This gap is present on all pages within the app and will remain until another > text input field is focused and the keyboard shows again. > See screenshot here: http://imgur.com/NtQ4QSl > In the above screenshot I clicked on the "submit registration" button before > filling out the form correctly and triggering a validation error "confirm > password". This caused the keyboard to hide and resulted in the page gap > error as shown. > The error also occurs when the keyboard is dismissed without hitting the > "submit registration" button i.e. by using the dismiss keyboard button within > the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6372) port createmobilespec.sh to Node.js
[ https://issues.apache.org/jira/browse/CB-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951021#comment-13951021 ] Andrew Grieve commented on CB-6372: --- Just one: thanks :) > port createmobilespec.sh to Node.js > --- > > Key: CB-6372 > URL: https://issues.apache.org/jira/browse/CB-6372 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Do a simple port of the createmobilespec script from bash to Node.js. This is > a start to it working on other dev workstations (i.e., Windows), and to make > it easier to add improvements (i.e., support for platforms other than iOS and > Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
[ https://issues.apache.org/jira/browse/CB-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951037#comment-13951037 ] Jonathan Yong commented on CB-6375: --- Here is a screenshot of what you should see with the above example when the problem occurs: http://imgur.com/41gstOG > When keyboard is dismissed. Page has a large gap at top of screen > - > > Key: CB-6375 > URL: https://issues.apache.org/jira/browse/CB-6375 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 >Reporter: Jonathan Yong > > See screenshot here: http://imgur.com/NtQ4QSl > Notice the large white gap at the top of the page > When a page is tall enough to cause the page to slide upwards when the > virtual keyboard is displayed, and while the page scroll position is scrolled > down so that the header and / or other controls are hidden above the top edge > of the screen, dismissing the keyboard will intermittently cause a page > rendering error such that there is a large white gap above the header of the > page, essentially pushing down all page contents. > This also causes the hitboxes of buttons and other form controls to differ > from the on screen view i.e. the hitboxes are where the controls should have > appeared had there not been a large gap at the top of the screen. > This gap is present on all pages within the app and will remain until another > text input field is focused and the keyboard shows again. > See screenshot here: http://imgur.com/NtQ4QSl > In the above screenshot I clicked on the "submit registration" button before > filling out the form correctly and triggering a validation error "confirm > password". This caused the keyboard to hide and resulted in the page gap > error as shown. > The error also occurs when the keyboard is dismissed without hitting the > "submit registration" button i.e. by using the dismiss keyboard button within > the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5520) Should we add "DEBUG=1" to "Preprocessor Macros"->"Debug" ?
[
https://issues.apache.org/jira/browse/CB-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950910#comment-13950910
]
Andrew Grieve commented on CB-5520:
---
I've done quite a bit of work with .xcconfig files in the past.
There's 4 layers of inheritance:
1. Xcode Defaults
2. Project .xcconfig
3. Target .xcconfig
4. Target settings (what we're using now)
Each layer can inherit from the above via $(inherted), but you can't append or
inherit from settings on the same level.
For this reason, I think it makes sense for us to provide a Target .xcconfig,
so that users can set their own settings on either side of it (2 & 4).
For an upgrade path, I think it'd be great to have the update script do some
pbxproj munging to:
1. Add the .xcconfig
2. Delete *all* settings that we set (or maybe everything except PRODUCT_NAME?)
Failing this, we could just have the update script fail with a message saying
"Recreate your project"
> Should we add "DEBUG=1" to "Preprocessor Macros"->"Debug" ?
> ---
>
> Key: CB-5520
> URL: https://issues.apache.org/jira/browse/CB-5520
> Project: Apache Cordova
> Issue Type: Wish
> Components: iOS
>Affects Versions: 3.2.0
>Reporter: glmnbeyond
>Assignee: Shazron Abdullah
>Priority: Minor
> Labels: core
>
> I created a helloCordova project via Cordova CLI, and added some debug info
> to native code:
> DLog('This is a debug info');
> But the debug info is never outputted.If I use ALog, the info can be
> outputted, so I think it probably has something to do with the "DEBUG" macro.
> After I added "DEBUG=1" to "Preprocessor Macros", ran the helloCordova
> target, DLog can be outputted.
> So here is my question:
> Should we add "DEBUG=1" to iOS template project->"Build Settings"->
> "Preprocessor Macros" ->"Debug" ?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6375) When keyboard is dismissed. Page has a large gap at top of screen
[ https://issues.apache.org/jira/browse/CB-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950950#comment-13950950 ] Joe Bowser commented on CB-6375: What happens when you don't use jQuery Mobile? > When keyboard is dismissed. Page has a large gap at top of screen > - > > Key: CB-6375 > URL: https://issues.apache.org/jira/browse/CB-6375 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Android 4.4.2 Nexus 5, jQuery Mobile 1.4.2, PhoneGap 3.4 >Reporter: Jonathan Yong > > See screenshot here: http://imgur.com/NtQ4QSl > Notice the large white gap at the top of the page > When a page is tall enough to cause the page to slide upwards when the > virtual keyboard is displayed, and while the page scroll position is scrolled > down so that the header and / or other controls are hidden above the top edge > of the screen, dismissing the keyboard will intermittently cause a page > rendering error such that there is a large white gap above the header of the > page, essentially pushing down all page contents. > This also causes the hitboxes of buttons and other form controls to differ > from the on screen view i.e. the hitboxes are where the controls should have > appeared had there not been a large gap at the top of the screen. > This gap is present on all pages within the app and will remain until another > text input field is focused and the keyboard shows again. > See screenshot here: http://imgur.com/NtQ4QSl > In the above screenshot I clicked on the "submit registration" button before > filling out the form correctly and triggering a validation error "confirm > password". This caused the keyboard to hide and resulted in the page gap > error as shown. > The error also occurs when the keyboard is dismissed without hitting the > "submit registration" button i.e. by using the dismiss keyboard button within > the android nav bar. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6373) Do-not-call spies won't error if an exception is thrown
Ian Clelland created CB-6373:
Summary: Do-not-call spies won't error if an exception is thrown
Key: CB-6373
URL: https://issues.apache.org/jira/browse/CB-6373
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Ian Clelland
Assignee: Ian Clelland
In the mobile spec test runner, the function created by {{createDoNotCallSpy}}
logs an error message containing the JSON serialization of the function
arguments, and then makes a false assertion, to cause a test to fail.
If the function arguments are not JSON-serializable, then an exception will be
thrown in the spy, and failure will never be asserted. If a test is counting on
a doNotCallSpy to not be called, it may succeed, since the spy will never cause
a test failure.
(This was noticed because one of the File tests, file.spec.9, was failing
unnoticed on iOS until FileEntry objects became serializable with CB-6352)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6359) resolveLocalFileSystemURL continues to be inconsistent, now fails specifically on Galaxy Note 3 when capturing video only
[
https://issues.apache.org/jira/browse/CB-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950686#comment-13950686
]
Ian Clelland commented on CB-6359:
--
That's good to hear -- thanks for testing that again.
I'm going to keep this issue open; I'm still considering it a bug until CB-6152
is fixed. Developers shouldn't have to go that far out of their way to get
media-capture and file to work together.
> resolveLocalFileSystemURL continues to be inconsistent, now fails
> specifically on Galaxy Note 3 when capturing video only
> -
>
> Key: CB-6359
> URL: https://issues.apache.org/jira/browse/CB-6359
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin File, Plugin Media Capture
>Affects Versions: 3.4.0
> Environment: On Mac
> Cordova info
> Current Node Version
> v0.10.25
> Current Cordova CLI Version
> 3.4.0-0.1.0
> Testing with: Samsung Galaxy Note 3 (Android)...the device is NOT rooted.
>Reporter: Ralph S Theart
>Assignee: Ian Clelland
> Labels: android, capture
>
> Ok this is a very strange bug. Some background first though. I have 10 test
> devices at my house so I can test the apps I make. Of the 10 devices 8 are
> android. My app works across the board on all of them flawlessly. So I
> already know its not something related to my set up or my code. Out of the
> *10* devices one specific feature seems to fail on one specific device
> (Galaxy Note 3). When you capture video and try to resolve the URI you will
> always get error core 5 every single time no matter what changes you make or
> conditions. Here is the code.
> {code}
> navigator.device.capture.captureVideo(function(mediaFiles){
> var mediaFilePath = mediaFiles[0].fullPath;
>
> window.resolveLocalFileSystemURL(mediaFilePath, function(){
>///never gets this far
> }, function(error){
>console.log(error.code);
>*Always fails with error code 5*
> });
> }, function(error){
> var msg = 'Messages > captureVideo():: An error
> occurred during video capture: ' + error.code;
> console.log(msg, null, 'Uh oh!');
>});
> {code}
> For this device and this specific scenario the path returned by capture is
> always something like this:
> *file:/storage/extSdCard/DCIM/Camera/20140327_104747.mp4* yes I noticed
> the "file:/" and have even tried replacing it with "file:///" and it still
> continues to fail.
> btw ...I have a lot of devices I test with with...do you guys have these kind
> of facilities? I have built up a rigorous excel sheet full of tests among
> which are all of the media type api's. I did this because
> resolveLocalFileSystemURL has become a problem child for me since 3.4 I have
> already submitted 3 bugs 1 of which was solved and actually made it to the
> 1.0.1 File-System update. The 2nd one is solved now too. I wouldn't care if
> the device this was happening to was old and was on an older firmware like
> 4.0.3 but this is a popular device especially in our database any help would
> be appreciated.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6359) resolveLocalFileSystemURL continues to be inconsistent, now fails specifically on Galaxy Note 3 when capturing video only
[
https://issues.apache.org/jira/browse/CB-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950692#comment-13950692
]
Ralph S Theart commented on CB-6359:
Agreed and thanks again.
> resolveLocalFileSystemURL continues to be inconsistent, now fails
> specifically on Galaxy Note 3 when capturing video only
> -
>
> Key: CB-6359
> URL: https://issues.apache.org/jira/browse/CB-6359
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin File, Plugin Media Capture
>Affects Versions: 3.4.0
> Environment: On Mac
> Cordova info
> Current Node Version
> v0.10.25
> Current Cordova CLI Version
> 3.4.0-0.1.0
> Testing with: Samsung Galaxy Note 3 (Android)...the device is NOT rooted.
>Reporter: Ralph S Theart
>Assignee: Ian Clelland
> Labels: android, capture
>
> Ok this is a very strange bug. Some background first though. I have 10 test
> devices at my house so I can test the apps I make. Of the 10 devices 8 are
> android. My app works across the board on all of them flawlessly. So I
> already know its not something related to my set up or my code. Out of the
> *10* devices one specific feature seems to fail on one specific device
> (Galaxy Note 3). When you capture video and try to resolve the URI you will
> always get error core 5 every single time no matter what changes you make or
> conditions. Here is the code.
> {code}
> navigator.device.capture.captureVideo(function(mediaFiles){
> var mediaFilePath = mediaFiles[0].fullPath;
>
> window.resolveLocalFileSystemURL(mediaFilePath, function(){
>///never gets this far
> }, function(error){
>console.log(error.code);
>*Always fails with error code 5*
> });
> }, function(error){
> var msg = 'Messages > captureVideo():: An error
> occurred during video capture: ' + error.code;
> console.log(msg, null, 'Uh oh!');
>});
> {code}
> For this device and this specific scenario the path returned by capture is
> always something like this:
> *file:/storage/extSdCard/DCIM/Camera/20140327_104747.mp4* yes I noticed
> the "file:/" and have even tried replacing it with "file:///" and it still
> continues to fail.
> btw ...I have a lot of devices I test with with...do you guys have these kind
> of facilities? I have built up a rigorous excel sheet full of tests among
> which are all of the media type api's. I did this because
> resolveLocalFileSystemURL has become a problem child for me since 3.4 I have
> already submitted 3 bugs 1 of which was solved and actually made it to the
> 1.0.1 File-System update. The 2nd one is solved now too. I wouldn't care if
> the device this was happening to was old and was on an older firmware like
> 4.0.3 but this is a popular device especially in our database any help would
> be appreciated.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6372) port createmobilespec.sh to Node.js
[ https://issues.apache.org/jira/browse/CB-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950680#comment-13950680 ] ASF GitHub Bot commented on CB-6372: GitHub user cmarcelk opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/54 CB-6372 Port createmobilespec from bash to node. This is a straight-up port with no change in function. This is the initial work. Improvements and expansion can come later. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmarcelk/cordova-mobile-spec create-port Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 3d930d63c909b052731d2ce347ac32c6faaf8ecf Author: Marcel Kinard Date: 2014-03-28T13:20:02Z CB-6372 Port createmobilespec from bash to node. This is a straight-up port with no change in function. This is the initial work. Improvements and expansion can come later. > port createmobilespec.sh to Node.js > --- > > Key: CB-6372 > URL: https://issues.apache.org/jira/browse/CB-6372 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Do a simple port of the createmobilespec script from bash to Node.js. This is > a start to it working on other dev workstations (i.e., Windows), and to make > it easier to add improvements (i.e., support for platforms other than iOS and > Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6359) resolveLocalFileSystemURL continues to be inconsistent, now fails specifically on Galaxy Note 3 when capturing video only
[
https://issues.apache.org/jira/browse/CB-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950666#comment-13950666
]
Ralph S Theart commented on CB-6359:
It worked I was missing "root" in that list for "AndroidExtraFilesystems".
Thanks! 10 for 10 now :}
> resolveLocalFileSystemURL continues to be inconsistent, now fails
> specifically on Galaxy Note 3 when capturing video only
> -
>
> Key: CB-6359
> URL: https://issues.apache.org/jira/browse/CB-6359
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin File, Plugin Media Capture
>Affects Versions: 3.4.0
> Environment: On Mac
> Cordova info
> Current Node Version
> v0.10.25
> Current Cordova CLI Version
> 3.4.0-0.1.0
> Testing with: Samsung Galaxy Note 3 (Android)...the device is NOT rooted.
>Reporter: Ralph S Theart
>Assignee: Ian Clelland
> Labels: android, capture
>
> Ok this is a very strange bug. Some background first though. I have 10 test
> devices at my house so I can test the apps I make. Of the 10 devices 8 are
> android. My app works across the board on all of them flawlessly. So I
> already know its not something related to my set up or my code. Out of the
> *10* devices one specific feature seems to fail on one specific device
> (Galaxy Note 3). When you capture video and try to resolve the URI you will
> always get error core 5 every single time no matter what changes you make or
> conditions. Here is the code.
> {code}
> navigator.device.capture.captureVideo(function(mediaFiles){
> var mediaFilePath = mediaFiles[0].fullPath;
>
> window.resolveLocalFileSystemURL(mediaFilePath, function(){
>///never gets this far
> }, function(error){
>console.log(error.code);
>*Always fails with error code 5*
> });
> }, function(error){
> var msg = 'Messages > captureVideo():: An error
> occurred during video capture: ' + error.code;
> console.log(msg, null, 'Uh oh!');
>});
> {code}
> For this device and this specific scenario the path returned by capture is
> always something like this:
> *file:/storage/extSdCard/DCIM/Camera/20140327_104747.mp4* yes I noticed
> the "file:/" and have even tried replacing it with "file:///" and it still
> continues to fail.
> btw ...I have a lot of devices I test with with...do you guys have these kind
> of facilities? I have built up a rigorous excel sheet full of tests among
> which are all of the media type api's. I did this because
> resolveLocalFileSystemURL has become a problem child for me since 3.4 I have
> already submitted 3 bugs 1 of which was solved and actually made it to the
> 1.0.1 File-System update. The 2nd one is solved now too. I wouldn't care if
> the device this was happening to was old and was on an older firmware like
> 4.0.3 but this is a popular device especially in our database any help would
> be appreciated.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-6372) port createmobilespec.sh to Node.js
Marcel Kinard created CB-6372: - Summary: port createmobilespec.sh to Node.js Key: CB-6372 URL: https://issues.apache.org/jira/browse/CB-6372 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Minor Do a simple port of the createmobilespec script from bash to Node.js. This is a start to it working on other dev workstations (i.e., Windows), and to make it easier to add improvements (i.e., support for platforms other than iOS and Android). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6371) Spashscreen doesn't shown on Windows8.
Vladimir Kotikov created CB-6371: Summary: Spashscreen doesn't shown on Windows8. Key: CB-6371 URL: https://issues.apache.org/jira/browse/CB-6371 Project: Apache Cordova Issue Type: Bug Components: Plugin SplashScreen, Windows 8 Affects Versions: 3.4.0 Reporter: Vladimir Kotikov Assignee: Jesse MacFadyen Priority: Trivial After installing splashscreen plugin for Windows8 platform, navigator.splashscreen.show() shows no image. This is because path to splashscreen image is differs from path to platform template default splashscreen image. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6360) The InAppBrowser crash on IOS 5.1 >NSInvalidArgumentException', reason: '-[UILabel setMinimumScaleFactor:
[ https://issues.apache.org/jira/browse/CB-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Benzerrouk updated CB-6360: -- Labels: InAppBrowser crash ios5 (was: InAppBrowser crash ios5 ios6) Summary: The InAppBrowser crash on IOS 5.1 >NSInvalidArgumentException', reason: '-[UILabel setMinimumScaleFactor: (was: The InAppBrowser crash on IOS 6.1 and IOS 5.1 >NSInvalidArgumentException', reason: '-[UILabel setMinimumScaleFactor:) only on IOS 5.1 > The InAppBrowser crash on IOS 5.1 >NSInvalidArgumentException', reason: > '-[UILabel setMinimumScaleFactor: > - > > Key: CB-6360 > URL: https://issues.apache.org/jira/browse/CB-6360 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin InAppBrowser >Affects Versions: 3.3.0, 3.4.0 > Environment: Cordova 3.3 or 3.4 Xcode 5.0.1. Test on Ipad 2, Iphone > 3GS >Reporter: Gilles Benzerrouk > Labels: InAppBrowser, crash, ios5 > Original Estimate: 3h > Remaining Estimate: 3h > > When i try to launch the InAppBrowser with : > var ref =window.open(urlCt, > '_blank','location=yes,closebuttoncaption=Fermer,EnableViewPortScale=yes'); > InAppBrowser crash. > Here the log on Xcode 5.0.1 > 2014-03-26 08:48:38.480 ParisFood[405:707] -[UILabel setMinimumScaleFactor:]: > unrecognized selector sent to instance 0xecb7b10 > 2014-03-26 08:48:38.485 ParisFood[405:707] *** Terminating app due to > uncaught exception 'NSInvalidArgumentException', reason: '-[UILabel > setMinimumScaleFactor:]: unrecognized selector sent to instance 0xecb7b10' > *** First throw call stack: > (0x30fc588f 0x37303259 0x30fc8a9b 0x30fc7915 0x30f22650 0x49409 0x47bfd > 0x43f8f 0x43bc5 0x223c9 0x21cef 0x21899 0x21a7f 0x21991 0x30f241fb 0x318e1747 > 0x30f99ad3 0x30f9929f 0x30f98045 0x30f1b4a5 0x30f1b36d 0x32f95439 0x3067ecd5 > 0x2808f 0x28050) > terminate called throwing an exception > Before on cordova 2.9 everything was working well !!! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[
https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950578#comment-13950578
]
Robin Zeggelaar commented on CB-5634:
-
I can confirm this issue. I tried to find the source of the problem, which
brought me to configParser.js, line 88.
{code}if (preferences[i].attrib.name.toLowerCase() === name) {
ret = a.attrib.value;
}{code}
Here, the variable a is not defined, generating the error. I'd say changing
this line to {code}ret = preferences[i].attrib.value{code} would fix it.
Then again, i'm no cordova expert. But that's what it looks like to me.
> Orientation Preference is ignored in Android, should be parsed by CLI
> -
>
> Key: CB-5634
> URL: https://issues.apache.org/jira/browse/CB-5634
> Project: Apache Cordova
> Issue Type: Bug
> Components: Amazon FireOS, Android, CLI, Docs, iOS
>Reporter: Joe Bowser
>Assignee: Andrew Grieve
>
> The docs say that an Orientation preference is supposed to work across all
> platforms. However, Android's activities can only be locked to an
> orientation by modifying the AndroidManifest.xml.
> To get past this, we either change the docs, or we support this in the CLI.
> I feel that adding an XML parser to the scripts is complete overkill, since
> we don't have any tests for our platform scripts, and I personally think
> they're a giant pile of technical debt.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-4862) ios 7 keyboard resizes the page even with KeyboardShrinksView set to false
[ https://issues.apache.org/jira/browse/CB-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950539#comment-13950539 ] Chris Emerson commented on CB-4862: --- For whatever it's worth - viewports are still a sensitive/tedious topic. I have to maintain separate viewport tags for ANDROID and iOS otherwise crazy things happen. I realize this comment lacks tactical/actionable detail - mainly I'm just posting to find out if anyone is looking at removing this issue so we (Cordova/PhoneGap devs) can soon just pick ONE viewport tag and it magically works on all devices. > ios 7 keyboard resizes the page even with KeyboardShrinksView set to false > -- > > Key: CB-4862 > URL: https://issues.apache.org/jira/browse/CB-4862 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 2.8.0 > Environment: ipod 5th gen ios 7 and simulator for ios 7 >Reporter: Jake Williams >Assignee: Shazron Abdullah > Labels: ios7, keyboard-plugin > > We have a page with a fixed footer and some inputs. In previous ios versions > the page would be pushed up when an input was focused and the keyboard came > up. In ios 7, the page height is reduced to the available space after the > keyboard appears and the footer covers the input (depends on the position of > the footer, but it does happen sometimes). There is also a problem where the > input could be beneath the keyboard if you have multiple inputs and you use > next/previous to move between them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[
https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950524#comment-13950524
]
David Lee commented on CB-5634:
---
I'm also getting a {{[ReferenceError: a is not defined]}} error when I run
{{cordova run android}} with {{}}. This error doesn't stop the command from succeeding, though.
If I remove {{}}, then the
error message goes away.
> Orientation Preference is ignored in Android, should be parsed by CLI
> -
>
> Key: CB-5634
> URL: https://issues.apache.org/jira/browse/CB-5634
> Project: Apache Cordova
> Issue Type: Bug
> Components: Amazon FireOS, Android, CLI, Docs, iOS
>Reporter: Joe Bowser
>Assignee: Andrew Grieve
>
> The docs say that an Orientation preference is supposed to work across all
> platforms. However, Android's activities can only be locked to an
> orientation by modifying the AndroidManifest.xml.
> To get past this, we either change the docs, or we support this in the CLI.
> I feel that adding an XML parser to the scripts is complete overkill, since
> we don't have any tests for our platform scripts, and I personally think
> they're a giant pile of technical debt.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[
https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950517#comment-13950517
]
David Lee edited comment on CB-5634 at 3/28/14 9:16 AM:
I'm still able to reproduce this on Android 4.2 with cordova 3.4.0-0.1.3.
Maybe it's a bug in the docs, but I have {{}} in my config.xml and it's still reorienting to landscape
when I move the phone around.
was (Author: davidomundo):
I'm still able to reproduce this on Android for 3.4.0-0.1.3.
Maybe it's a bug in the docs, but I have {{}} in my config.xml and it's still reorienting to landscape.
> Orientation Preference is ignored in Android, should be parsed by CLI
> -
>
> Key: CB-5634
> URL: https://issues.apache.org/jira/browse/CB-5634
> Project: Apache Cordova
> Issue Type: Bug
> Components: Amazon FireOS, Android, CLI, Docs, iOS
>Reporter: Joe Bowser
>Assignee: Andrew Grieve
>
> The docs say that an Orientation preference is supposed to work across all
> platforms. However, Android's activities can only be locked to an
> orientation by modifying the AndroidManifest.xml.
> To get past this, we either change the docs, or we support this in the CLI.
> I feel that adding an XML parser to the scripts is complete overkill, since
> we don't have any tests for our platform scripts, and I personally think
> they're a giant pile of technical debt.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[
https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950517#comment-13950517
]
David Lee commented on CB-5634:
---
I'm still able to reproduce this on Android for 3.4.0-0.1.3.
Maybe it's a bug in the docs, but I have {{}} in my config.xml and it's still reorienting to landscape.
> Orientation Preference is ignored in Android, should be parsed by CLI
> -
>
> Key: CB-5634
> URL: https://issues.apache.org/jira/browse/CB-5634
> Project: Apache Cordova
> Issue Type: Bug
> Components: Amazon FireOS, Android, CLI, Docs, iOS
>Reporter: Joe Bowser
>Assignee: Andrew Grieve
>
> The docs say that an Orientation preference is supposed to work across all
> platforms. However, Android's activities can only be locked to an
> orientation by modifying the AndroidManifest.xml.
> To get past this, we either change the docs, or we support this in the CLI.
> I feel that adding an XML parser to the scripts is complete overkill, since
> we don't have any tests for our platform scripts, and I personally think
> they're a giant pile of technical debt.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-6370) Syntax error in camera test
puchen created CB-6370: -- Summary: Syntax error in camera test Key: CB-6370 URL: https://issues.apache.org/jira/browse/CB-6370 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Affects Versions: 3.4.0 Environment: Android 4.0.4 Reporter: puchen Run camera test, click ‘camera.getPicture()’ success, then click 'Copy Image', got error message: Uncaught TypeError: Converting circular structure to JSON reason: JSON.stringify([].slice.call(arguments)) is called failed at function logCallback -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
[ https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Bektchiev updated CB-6344: - Remaining Estimate: 0h (was: 48h) Original Estimate: 0h (was: 48h) > Specify after which sibling to add config-changes in plugin.xml > --- > > Key: CB-6344 > URL: https://issues.apache.org/jira/browse/CB-6344 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugman >Reporter: Martin Bektchiev >Assignee: Martin Bektchiev > Original Estimate: 0h > Remaining Estimate: 0h > > The order of XML elements is important In the Windows Phone manifest file. > (e.g. see > http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement). > That's why we need to provide a way to specify where a specific element has > to be added. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
[ https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Bektchiev updated CB-6344: - Remaining Estimate: 48h (was: 0h) Original Estimate: 48h (was: 0h) > Specify after which sibling to add config-changes in plugin.xml > --- > > Key: CB-6344 > URL: https://issues.apache.org/jira/browse/CB-6344 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugman >Reporter: Martin Bektchiev >Assignee: Martin Bektchiev > Original Estimate: 48h > Remaining Estimate: 48h > > The order of XML elements is important In the Windows Phone manifest file. > (e.g. see > http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement). > That's why we need to provide a way to specify where a specific element has > to be added. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
[ https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Bektchiev updated CB-6344: - Remaining Estimate: 0h (was: 48h) Original Estimate: 0h (was: 48h) > Specify after which sibling to add config-changes in plugin.xml > --- > > Key: CB-6344 > URL: https://issues.apache.org/jira/browse/CB-6344 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugman >Reporter: Martin Bektchiev >Assignee: Martin Bektchiev > Original Estimate: 0h > Remaining Estimate: 0h > > The order of XML elements is important In the Windows Phone manifest file. > (e.g. see > http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement). > That's why we need to provide a way to specify where a specific element has > to be added. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6344) Specify after which sibling to add config-changes in plugin.xml
[
https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950468#comment-13950468
]
ASF GitHub Bot commented on CB-6344:
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugman/pull/68
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(`munge.files[file].parents[parent][index] { xml, count, after }`)
* add an after parameter to graftXML which contains a list of possible
predecessor elements separated by semicolon
* fix unit tests and add new ones
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-plugman
config-file-after-option
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugman/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
commit 0616f1fefd24cad93715f16b6cabb94d3356e0cb
Author: Martin Bektchiev
Date: 2014-03-26T08:15:39Z
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(munge.files[file].parents[parent][index] { xml, count, after })
* add an after parameter to graftXML which contains a list of possible
predecessor elements separated by semicolon
* fix unit tests and add new ones
> Specify after which sibling to add config-changes in plugin.xml
> ---
>
> Key: CB-6344
> URL: https://issues.apache.org/jira/browse/CB-6344
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugman
>Reporter: Martin Bektchiev
>Assignee: Martin Bektchiev
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The order of XML elements is important In the Windows Phone manifest file.
> (e.g. see
> http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement).
> That's why we need to provide a way to specify where a specific element has
> to be added.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
