[jira] [Commented] (CB-6444) iOS issue with fixed positioned elements and keyboard
[
https://issues.apache.org/jira/browse/CB-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969274#comment-13969274
]
Andrey Kurdyumov commented on CB-6444:
--
Even this is looks like not Cordova issue, but issue with underlying WebView I
think this is enough important for Cordova users to be fixed by Cordova.
I have following solution for that issue particularly.
1. Add Keyboard plugin
2. setup handler for onhinding event
Keyboard.onhiding = function() {
document.body.scrollLeft = 0;
}
And what I want is add that to the actual Keyboard plugin and not keep it as
well-known problem with given solution. To have backward compatibility with
already existing code where scrolling to top is not intended behaviour we could
add switch which is off by default and all users which have this issue could
enable. This switch should be also documented, so people would be more aware
about issue when looking on the plugin.
If this is sounds good, then I could do all necessary lifting with the code and
create pull request.
> iOS issue with fixed positioned elements and keyboard
> -
>
> Key: CB-6444
> URL: https://issues.apache.org/jira/browse/CB-6444
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Keyboard
> Environment: iOS 7.0, iOS 7.1, iOS 6.1
>Reporter: Andrey Kurdyumov
>
> 1. Create blank Cordova application.
> 2. Made following changes:
> index.hmml
> Replace content of div with id="deviceready" with following content
>
>
> js/index.js
> comment line
> app.receivedEvent('deviceready');
> css/index.css
> in the class .app
> change position:absolute to position: fixed
> 3. Build app and launch it
> 4. Touch text box. Keyboard should popup
> 5. Touch checkbox. Keyboard is shown, but all page moved a bit bottom.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-6444) iOS issue with fixed positioned elements and keyboard
Andrey Kurdyumov created CB-6444:
Summary: iOS issue with fixed positioned elements and keyboard
Key: CB-6444
URL: https://issues.apache.org/jira/browse/CB-6444
Project: Apache Cordova
Issue Type: Bug
Components: iOS, Plugin Keyboard
Environment: iOS 7.0, iOS 7.1, iOS 6.1
Reporter: Andrey Kurdyumov
1. Create blank Cordova application.
2. Made following changes:
index.hmml
Replace content of div with id="deviceready" with following content
js/index.js
comment line
app.receivedEvent('deviceready');
css/index.css
in the class .app
change position:absolute to position: fixed
3. Build app and launch it
4. Touch text box. Keyboard should popup
5. Touch checkbox. Keyboard is shown, but all page moved a bit bottom.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (CB-6413) spec.105 and spec.108 of file autotest are failed on Android 2.3.7
[ https://issues.apache.org/jira/browse/CB-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland reassigned CB-6413: Assignee: Ian Clelland > spec.105 and spec.108 of file autotest are failed on Android 2.3.7 > -- > > Key: CB-6413 > URL: https://issues.apache.org/jira/browse/CB-6413 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 > Environment: Android 2.3.7 >Reporter: puchen >Assignee: Ian Clelland > > Run spec.105 and spec.108 of file autotest got messages: > spec.105: Expected 4 to be 32. > spec.108: Expected spy verifier to have been called. > Android 2.3.7 can't support window.WebKitBlobBuilder, and js code "if > (window.WebKitBlobBuilder)" the window.WebKitBlobBuilder is 'undefined' in > the spec.105 and spec.108. But codes still run in the if line. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6413) spec.105 and spec.108 of file autotest are failed on Android 2.3.7
[
https://issues.apache.org/jira/browse/CB-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969143#comment-13969143
]
Ian Clelland commented on CB-6413:
--
[~puchen], can you try Mobile Spec again, with this latest patch? On your
device, it should try to use the {{Blob()}} constructor, and when that throws
an exception, it should leave the {{blob}} variable undefined. Then it should
fall through, and the test should pass.
> spec.105 and spec.108 of file autotest are failed on Android 2.3.7
> --
>
> Key: CB-6413
> URL: https://issues.apache.org/jira/browse/CB-6413
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 3.4.0
> Environment: Android 2.3.7
>Reporter: puchen
>
> Run spec.105 and spec.108 of file autotest got messages:
> spec.105: Expected 4 to be 32.
> spec.108: Expected spy verifier to have been called.
> Android 2.3.7 can't support window.WebKitBlobBuilder, and js code "if
> (window.WebKitBlobBuilder)" the window.WebKitBlobBuilder is 'undefined' in
> the spec.105 and spec.108. But codes still run in the if line.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (CB-6235) Make windows.console and exceptions out working on wp8
[
https://issues.apache.org/jira/browse/CB-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse MacFadyen resolved CB-6235.
-
Resolution: Invalid
All console.log output is sent to Visual Studio's 'output' window
> Make windows.console and exceptions out working on wp8
> --
>
> Key: CB-6235
> URL: https://issues.apache.org/jira/browse/CB-6235
> Project: Apache Cordova
> Issue Type: Improvement
> Components: WP8
>Affects Versions: 3.4.0
> Environment: Windows 8
> Visual Studio Express for Windows Phone 2012
> Cordova 3.4.0
>Reporter: Malte Legenhausen
>Assignee: Jesse MacFadyen
>
> When running my cordova application in the windows phone simulator via visual
> studio you get no console.log and exception output cause console.log gets
> replaced by an noop function and no window.onerror handler is defined.
> Better would it be to replace it by
> window.console = {
> log: function (str) { window.external.Notify(str); }
> };
> window.onerror = function (e) {
> console.log("window.onerror ::" + JSON.stringify(e));
> };
> You get not line numbers out of this but this helps very much.
> I got this improvements from
> http://sgrebnov.blogspot.de/2012/12/debugging-cordova-apps-on-wp8.html
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (CB-1401) Add reset() (and other APIs) to Windows Phone Plugin documentation
[
https://issues.apache.org/jira/browse/CB-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse MacFadyen resolved CB-1401.
-
Resolution: Fixed
> Add reset() (and other APIs) to Windows Phone Plugin documentation
> ---
>
> Key: CB-1401
> URL: https://issues.apache.org/jira/browse/CB-1401
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Docs, WP8
>Reporter: Filip Maj
>Assignee: Jesse MacFadyen
>
> Make sure to update the documentation related to Plugin development to
> mention the {{reset}} API.
> Also, once-over the {{Command}} class and make sure we document other API
> methods available.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-1401) Add reset() (and other APIs) to Windows Phone Plugin documentation
[
https://issues.apache.org/jira/browse/CB-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969132#comment-13969132
]
ASF subversion and git services commented on CB-1401:
-
Commit f5e312554ba35a922707a323272f1f424d6c8f65 in cordova-docs's branch
refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=f5e3125 ]
CB-1401 Document existence of onReset for plugin devs
> Add reset() (and other APIs) to Windows Phone Plugin documentation
> ---
>
> Key: CB-1401
> URL: https://issues.apache.org/jira/browse/CB-1401
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Docs, WP8
>Reporter: Filip Maj
>Assignee: Jesse MacFadyen
>
> Make sure to update the documentation related to Plugin development to
> mention the {{reset}} API.
> Also, once-over the {{Command}} class and make sure we document other API
> methods available.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6443) cordova-plugin-network-information breaks the build
[
https://issues.apache.org/jira/browse/CB-6443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969091#comment-13969091
]
Shazron Abdullah commented on CB-6443:
--
{code}
$ cordova -v
3.4.1-0.1.0
{code}
> cordova-plugin-network-information breaks the build
> ---
>
> Key: CB-6443
> URL: https://issues.apache.org/jira/browse/CB-6443
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Network Information
>Affects Versions: 3.4.0
> Environment: ios
>Reporter: DotNetWise
>Priority: Blocker
>
> Adding the cordova-plugin-network-information plugin will break the linker
> and when you do cordova build ios --release --device will FAIL the build.
> This is after I have upgraded to cordova cli 3.4.1
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (CB-6443) cordova-plugin-network-information breaks the build
[ https://issues.apache.org/jira/browse/CB-6443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-6443. -- Resolution: Cannot Reproduce Created a Cordova 3.4.1 project, added the plugin, and did " cordova build ios --release --device". Build succeeded. > cordova-plugin-network-information breaks the build > --- > > Key: CB-6443 > URL: https://issues.apache.org/jira/browse/CB-6443 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Network Information >Affects Versions: 3.4.0 > Environment: ios >Reporter: DotNetWise >Priority: Blocker > > Adding the cordova-plugin-network-information plugin will break the linker > and when you do cordova build ios --release --device will FAIL the build. > This is after I have upgraded to cordova cli 3.4.1 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6405) [WP8] Make InAppBrowser work with embedded files, using system behavior
[ https://issues.apache.org/jira/browse/CB-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen resolved CB-6405. - Resolution: Fixed Fix Version/s: 3.5.0 > [WP8] Make InAppBrowser work with embedded files, using system behavior > --- > > Key: CB-6405 > URL: https://issues.apache.org/jira/browse/CB-6405 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin InAppBrowser >Affects Versions: 3.2.0 >Reporter: Nadya Atanasova >Priority: Trivial > Fix For: 3.5.0 > > > When trying to open embedded file, the browser is not working. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-3324) InAppBrowser does not handle hardware back button
[ https://issues.apache.org/jira/browse/CB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen resolved CB-3324. - Resolution: Fixed Fix Version/s: 3.5.0 > InAppBrowser does not handle hardware back button > - > > Key: CB-3324 > URL: https://issues.apache.org/jira/browse/CB-3324 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 >Affects Versions: 2.7.0, 3.1.0 >Reporter: Martin Hujer >Assignee: Jesse MacFadyen > Fix For: 3.5.0 > > > When the link is opened in InAppBrowser on WP8 and I try to use hardware back > button to get back to app, it does not work. Actually, it "backs" in the > webpage under InAppBrowser. > Steps to reproduce: > 1) Navigate throught the HTML app packaged with Cordova > 2) A wild link appears > 3) Taping opens InAppBrowser > 4) Using HW back button navigates in underlaying webpage and not in > InAppBrowser so it eventually closes the app after few clicks (it seems > nothing is happening in the InAppBrowser). > Back hardware button works consistenty in all WP8 apps, so I think it should > also work here. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6421) Delete duplicate tests and move e2e tests to spec dir
[ https://issues.apache.org/jira/browse/CB-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969067#comment-13969067 ] ASF subversion and git services commented on CB-6421: - Commit f4a9597a8a4394ca6e943c285e1ad8eab5a31fd7 in cordova-cli's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=f4a9597 ] CB-6421: Move tests from e2e to spec Part 2, move all the files and delete e2e dir. For history of old overwritten tests in spec try git log 5cf9d9064005ff7bc6205c05277169b929e52fb5 > Delete duplicate tests and move e2e tests to spec dir > - > > Key: CB-6421 > URL: https://issues.apache.org/jira/browse/CB-6421 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > The e2e tests duplicate some of the tests in spec/ dir. They were designed to > be less fragile (less false alarms) by using less mocks and hitting the real > file system. They are fairly stable for some time now and should be moved to > spec overwriting the old duplicate tests. > Some coverage will be lost, separate issues will be filed to restore it. > See discussions on the dev@ mailing list: > Proposal to remove duplicates: > https://www.mail-archive.com/dev@cordova.apache.org/msg15466.html > and initial discussion back in Nov 2013 about creating the e2e tests > https://www.mail-archive.com/dev@cordova.apache.org/msg11708.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6421) Delete duplicate tests and move e2e tests to spec dir
[ https://issues.apache.org/jira/browse/CB-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969066#comment-13969066 ] ASF subversion and git services commented on CB-6421: - Commit fde755fe86b7c93b8505645567781646dc8fb572 in cordova-cli's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=fde755f ] CB-6421: Move tests from e2e to spec Removing the duplicate tests first as a separate commit (for better history). > Delete duplicate tests and move e2e tests to spec dir > - > > Key: CB-6421 > URL: https://issues.apache.org/jira/browse/CB-6421 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > The e2e tests duplicate some of the tests in spec/ dir. They were designed to > be less fragile (less false alarms) by using less mocks and hitting the real > file system. They are fairly stable for some time now and should be moved to > spec overwriting the old duplicate tests. > Some coverage will be lost, separate issues will be filed to restore it. > See discussions on the dev@ mailing list: > Proposal to remove duplicates: > https://www.mail-archive.com/dev@cordova.apache.org/msg15466.html > and initial discussion back in Nov 2013 about creating the e2e tests > https://www.mail-archive.com/dev@cordova.apache.org/msg11708.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6421) Delete duplicate tests and move e2e tests to spec dir
[ https://issues.apache.org/jira/browse/CB-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969068#comment-13969068 ] ASF subversion and git services commented on CB-6421: - Commit 38db7a2db44fbb251df3af1567699df3b1a3ec1e in cordova-cli's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=38db7a2 ] CB-6421: Move tests from e2e to spec - cli test After e2e dir was merged into spec/ there were interferences between the e2e tests and cli.spec.js. Jasmine runs all tests in a single process, therefore process-global settings like event listener (un)registration can cause interference between the tests. github: close #159 > Delete duplicate tests and move e2e tests to spec dir > - > > Key: CB-6421 > URL: https://issues.apache.org/jira/browse/CB-6421 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > The e2e tests duplicate some of the tests in spec/ dir. They were designed to > be less fragile (less false alarms) by using less mocks and hitting the real > file system. They are fairly stable for some time now and should be moved to > spec overwriting the old duplicate tests. > Some coverage will be lost, separate issues will be filed to restore it. > See discussions on the dev@ mailing list: > Proposal to remove duplicates: > https://www.mail-archive.com/dev@cordova.apache.org/msg15466.html > and initial discussion back in Nov 2013 about creating the e2e tests > https://www.mail-archive.com/dev@cordova.apache.org/msg11708.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6443) cordova-plugin-network-information breaks the build
DotNetWise created CB-6443: -- Summary: cordova-plugin-network-information breaks the build Key: CB-6443 URL: https://issues.apache.org/jira/browse/CB-6443 Project: Apache Cordova Issue Type: Bug Components: Plugin Network Information Affects Versions: 3.4.0 Environment: ios Reporter: DotNetWise Priority: Blocker Adding the cordova-plugin-network-information plugin will break the linker and when you do cordova build ios --release --device will FAIL the build. This is after I have upgraded to cordova cli 3.4.1 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3324) InAppBrowser does not handle hardware back button
[ https://issues.apache.org/jira/browse/CB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969048#comment-13969048 ] ASF subversion and git services commented on CB-3324: - Commit 1c32236353d8fc118a8449464ba7cd8f93a5eee2 in cordova-plugin-inappbrowser's branch refs/heads/dev from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=1c32236 ] CB-3324 Add support for back-button inappbrowser [WP8] if there is no history -> InAppBrowser is closed > InAppBrowser does not handle hardware back button > - > > Key: CB-3324 > URL: https://issues.apache.org/jira/browse/CB-3324 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 >Affects Versions: 2.7.0, 3.1.0 >Reporter: Martin Hujer >Assignee: Jesse MacFadyen > > When the link is opened in InAppBrowser on WP8 and I try to use hardware back > button to get back to app, it does not work. Actually, it "backs" in the > webpage under InAppBrowser. > Steps to reproduce: > 1) Navigate throught the HTML app packaged with Cordova > 2) A wild link appears > 3) Taping opens InAppBrowser > 4) Using HW back button navigates in underlaying webpage and not in > InAppBrowser so it eventually closes the app after few clicks (it seems > nothing is happening in the InAppBrowser). > Back hardware button works consistenty in all WP8 apps, so I think it should > also work here. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6038) null reference error in InAppBrowser plugin for WP8
[
https://issues.apache.org/jira/browse/CB-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse MacFadyen resolved CB-6038.
-
Resolution: Fixed
Resolved in updates to JS code [1] to prevent null string options, as well as
in native code [2]
[1] bddf86c3cefd9d787876d15e771beb499e43eb2f
[2] 2fc9f3da1fc683442a4c41811e826476d2ca9dd6
> null reference error in InAppBrowser plugin for WP8
> ---
>
> Key: CB-6038
> URL: https://issues.apache.org/jira/browse/CB-6038
> Project: Apache Cordova
> Issue Type: Bug
> Components: WP8
>Affects Versions: 3.3.0
>Reporter: André van der Plas
>Assignee: Jesse MacFadyen
> Labels: InAppBrowser, Null, WP8
>
> Inside the InAppBrowser.cs file there is a method named 'open' that tries to
> perform a featstring.Split(',') where featstring is the options argument when
> performing a window.open call.
> This third parameter is optional though and can be null.
> Fix by checking wheter args[2] = null
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6218) [BlackBerry10] InAppBrowser docs incorrectly state support for events
[ https://issues.apache.org/jira/browse/CB-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969035#comment-13969035 ] ASF subversion and git services commented on CB-6218: - Commit e282cc9e387e405a9103b2afa2b1a7a2b6232833 in cordova-plugin-inappbrowser's branch refs/heads/dev from [~bhigg...@blackberry.com] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=e282cc9 ] CB-6218 Update docs for BB10 > [BlackBerry10] InAppBrowser docs incorrectly state support for events > - > > Key: CB-6218 > URL: https://issues.apache.org/jira/browse/CB-6218 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Reporter: Bryan Higgins >Assignee: Bryan Higgins > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6422) Use cordova/exec/proxy instead of platform dupes
[
https://issues.apache.org/jira/browse/CB-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse MacFadyen reassigned CB-6422:
---
Assignee: (was: Jesse MacFadyen)
> Use cordova/exec/proxy instead of platform dupes
>
>
> Key: CB-6422
> URL: https://issues.apache.org/jira/browse/CB-6422
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS, Plugin Camera, Plugin Device, Tizen
>Reporter: Jesse MacFadyen
>
> the proxy code is built into cordova/exec/proxy, so instead of :
> require("cordova/windows8/commandProxy")...
> it should be :
> require("cordova/exec/proxy")...
> This applies to several platforms + core plugins
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5194) Camera.getPicture with sourceType: PHOTOLIBRARY doesn't respect correctOrientation unless targetWidth/Height also specified
[ https://issues.apache.org/jira/browse/CB-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968988#comment-13968988 ] Joe Bowser commented on CB-5194: [~Clément Vollet] Do you have a commit to point at? > Camera.getPicture with sourceType: PHOTOLIBRARY doesn't respect > correctOrientation unless targetWidth/Height also specified > --- > > Key: CB-5194 > URL: https://issues.apache.org/jira/browse/CB-5194 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Camera >Affects Versions: 2.6.0 > Environment: Galaxy S4 >Reporter: Andre Asselin >Priority: Minor > > Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture > from the library. The correctOrientation option will be ignored unless you > also specify targetWidth/Height as options. The documentation doesn't state > there is a dependency. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[
https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968920#comment-13968920
]
ASF GitHub Bot commented on CB-6437:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11610878
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/
+ */
var fs = require('fs'),
path = require('path'),
-shelljs,
-optimist;
+child_process = require('child_process'),
+shelljs;
+
+// Dependencies requirements check
try {
shelljs = require('shelljs');
-optimist = require('optimist');
} catch (e) {
console.error('Missing module. Please run "npm install" from this
directory:\n\t' +
- path.dirname(__dirname));
+path.dirname(__dirname));
process.exit(2);
}
-var tokens = process.argv.slice(2);
-var argv = optimist(tokens)
- .default('android', false)
- .default('ios', false)
- .usage('Usage: $0 [--android] [--ios]\nDefault is to use
Android and iOS.')
- .argv;
-// preserve the original behavior when there are no args
-if (tokens.length === 0) {
-argv.android = true;
-argv.ios = true;
+console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
+console.log('To clone needed repositories:');
+console.log(' ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
android -r ios -r cli');
+console.log('To update all repositories:');
+console.log(' ./cordova-coho/coho repo-update');
+
+// Setting up vars, folders and libraries, to ensure full compatibility
cross platform, absolute paths are used instead of relative paths
+var mainModDir = process.cwd(),
+// Cordova Coho dir, it should contain all libraries and required
repositories
+// [cordova-cli, cordova-android, cordova-blackberry, cordova-ios,
cordova-windows, cordova-windows8, all plugins libraries, cordova-mobile-spec,
cordova-js]
+// searchDir function it was added, to look for cordova-coho folder
backwards, for cases like absolute/path/cordova-coho/cordova-coho/...All
libraries
+// This is to make sure that cordova-coho exists and it's the right one.
+coho_dir = searchDir(mainModDir, 'cordova-coho'),
+cordova_cli = path.join(coho_dir, 'cordova-cli', 'bin', 'cordova'),
+cordova_ms = (path.join(coho_dir, 'cordova-mobile-spec')),
+cordova_js = (path.join(coho_dir, 'cordova-js')),
+ms_project_dir = (path.join(mainModDir, 'mobilespec'));
+
+// Main libraries and path's requirements check
+if (!fs.existsSync(coho_dir)) {
+console.log('Please run this script from the directory that contains
cordova-coho');
+shelljs.exit(1);
}
-var platforms = [];
-if (argv.android) { platforms.push('android'); }
-if (argv.ios) { platforms.push('ios'); }
-if (!fs.existsSync('cordova-mobile-spec')) {
+if (!fs.existsSync(cordova_ms)) {
console.log('Please run this script from the directory that contains
cordova-mobile-spec');
shelljs.exit(1);
}
-if (fs.existsSync('mobilespec')) {
-console.log('Directory "mobilespec" already exists. Delete it first
then re-run.');
+if (!fs.existsSync(cordova_js)) {
+console.log('Please run this script from the directory that contains
cordova-js');
shelljs.exit(1);
}
-console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
-console.log('To clone needed repositories:');
-console.log(" ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
cli -r " + platforms.join(' -r '));
-console.log('To update all repositories:');
-console.log(' ./cordova-coho/coho repo-update');
+//Determine which platforms are available
+// Default platforms [Android, Blackberry], both platforms works under
Windows, Linux and Mac OS
+cordovaPlatforms = ['android', 'blackberry10'];
--- End diff --
Yes, agree. I didn't see the optimist module when started to work in this,
it seems a really good idea, at first it was add android and iOS, both
platforms, that's why I'd choose to add all possible platforms.
We have options to pick, we can add the arguments like the platforms,
android, iOS, blackberry, wp8 and so. But this allows to the user add platforms
that are not allowed to use in their environment, let's say:
Mac Os dev env for Android, iOS
If the user types: createmobiles
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[
https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968840#comment-13968840
]
ASF GitHub Bot commented on CB-6437:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11607945
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/
+ */
var fs = require('fs'),
path = require('path'),
-shelljs,
-optimist;
+child_process = require('child_process'),
+shelljs;
+
+// Dependencies requirements check
try {
shelljs = require('shelljs');
-optimist = require('optimist');
} catch (e) {
console.error('Missing module. Please run "npm install" from this
directory:\n\t' +
- path.dirname(__dirname));
+path.dirname(__dirname));
process.exit(2);
}
-var tokens = process.argv.slice(2);
-var argv = optimist(tokens)
- .default('android', false)
- .default('ios', false)
- .usage('Usage: $0 [--android] [--ios]\nDefault is to use
Android and iOS.')
- .argv;
-// preserve the original behavior when there are no args
-if (tokens.length === 0) {
-argv.android = true;
-argv.ios = true;
+console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
+console.log('To clone needed repositories:');
+console.log(' ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
android -r ios -r cli');
+console.log('To update all repositories:');
+console.log(' ./cordova-coho/coho repo-update');
+
+// Setting up vars, folders and libraries, to ensure full compatibility
cross platform, absolute paths are used instead of relative paths
+var mainModDir = process.cwd(),
+// Cordova Coho dir, it should contain all libraries and required
repositories
+// [cordova-cli, cordova-android, cordova-blackberry, cordova-ios,
cordova-windows, cordova-windows8, all plugins libraries, cordova-mobile-spec,
cordova-js]
+// searchDir function it was added, to look for cordova-coho folder
backwards, for cases like absolute/path/cordova-coho/cordova-coho/...All
libraries
+// This is to make sure that cordova-coho exists and it's the right one.
+coho_dir = searchDir(mainModDir, 'cordova-coho'),
+cordova_cli = path.join(coho_dir, 'cordova-cli', 'bin', 'cordova'),
+cordova_ms = (path.join(coho_dir, 'cordova-mobile-spec')),
+cordova_js = (path.join(coho_dir, 'cordova-js')),
+ms_project_dir = (path.join(mainModDir, 'mobilespec'));
+
+// Main libraries and path's requirements check
+if (!fs.existsSync(coho_dir)) {
+console.log('Please run this script from the directory that contains
cordova-coho');
+shelljs.exit(1);
}
-var platforms = [];
-if (argv.android) { platforms.push('android'); }
-if (argv.ios) { platforms.push('ios'); }
-if (!fs.existsSync('cordova-mobile-spec')) {
+if (!fs.existsSync(cordova_ms)) {
console.log('Please run this script from the directory that contains
cordova-mobile-spec');
shelljs.exit(1);
}
-if (fs.existsSync('mobilespec')) {
-console.log('Directory "mobilespec" already exists. Delete it first
then re-run.');
+if (!fs.existsSync(cordova_js)) {
+console.log('Please run this script from the directory that contains
cordova-js');
shelljs.exit(1);
}
-console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
-console.log('To clone needed repositories:');
-console.log(" ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
cli -r " + platforms.join(' -r '));
-console.log('To update all repositories:');
-console.log(' ./cordova-coho/coho repo-update');
+//Determine which platforms are available
+// Default platforms [Android, Blackberry], both platforms works under
Windows, Linux and Mac OS
+cordovaPlatforms = ['android', 'blackberry10'];
+if (/^win/.test(process.platform)) {
+//Determine windows 8 platform
+child_process.exec('wmic os get caption', function (error, stdout,
stderr) {
+if (error !== null) {
+callback = 'Error performing command: ' + error + "\n" +
stderr;
+} else {
+// If Windows 8, add Windows Phone 8 and Windows8 platform to
the array
+if ((/.*(Windows 8).*/gi).test(((stdout.replace(/\r\r\n/i, ':
')).replace(/\s\s+/g, '')).replace((/\n|\r/gi), ''))) {
+
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[
https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968822#comment-13968822
]
ASF GitHub Bot commented on CB-6437:
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11607297
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/
+ */
var fs = require('fs'),
path = require('path'),
-shelljs,
-optimist;
+child_process = require('child_process'),
+shelljs;
+
+// Dependencies requirements check
try {
shelljs = require('shelljs');
-optimist = require('optimist');
} catch (e) {
console.error('Missing module. Please run "npm install" from this
directory:\n\t' +
- path.dirname(__dirname));
+path.dirname(__dirname));
process.exit(2);
}
-var tokens = process.argv.slice(2);
-var argv = optimist(tokens)
- .default('android', false)
- .default('ios', false)
- .usage('Usage: $0 [--android] [--ios]\nDefault is to use
Android and iOS.')
- .argv;
-// preserve the original behavior when there are no args
-if (tokens.length === 0) {
-argv.android = true;
-argv.ios = true;
+console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
+console.log('To clone needed repositories:');
+console.log(' ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
android -r ios -r cli');
+console.log('To update all repositories:');
+console.log(' ./cordova-coho/coho repo-update');
+
+// Setting up vars, folders and libraries, to ensure full compatibility
cross platform, absolute paths are used instead of relative paths
+var mainModDir = process.cwd(),
+// Cordova Coho dir, it should contain all libraries and required
repositories
+// [cordova-cli, cordova-android, cordova-blackberry, cordova-ios,
cordova-windows, cordova-windows8, all plugins libraries, cordova-mobile-spec,
cordova-js]
+// searchDir function it was added, to look for cordova-coho folder
backwards, for cases like absolute/path/cordova-coho/cordova-coho/...All
libraries
+// This is to make sure that cordova-coho exists and it's the right one.
+coho_dir = searchDir(mainModDir, 'cordova-coho'),
+cordova_cli = path.join(coho_dir, 'cordova-cli', 'bin', 'cordova'),
+cordova_ms = (path.join(coho_dir, 'cordova-mobile-spec')),
+cordova_js = (path.join(coho_dir, 'cordova-js')),
+ms_project_dir = (path.join(mainModDir, 'mobilespec'));
+
+// Main libraries and path's requirements check
+if (!fs.existsSync(coho_dir)) {
+console.log('Please run this script from the directory that contains
cordova-coho');
+shelljs.exit(1);
}
-var platforms = [];
-if (argv.android) { platforms.push('android'); }
-if (argv.ios) { platforms.push('ios'); }
-if (!fs.existsSync('cordova-mobile-spec')) {
+if (!fs.existsSync(cordova_ms)) {
console.log('Please run this script from the directory that contains
cordova-mobile-spec');
shelljs.exit(1);
}
-if (fs.existsSync('mobilespec')) {
-console.log('Directory "mobilespec" already exists. Delete it first
then re-run.');
+if (!fs.existsSync(cordova_js)) {
+console.log('Please run this script from the directory that contains
cordova-js');
shelljs.exit(1);
}
-console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
-console.log('To clone needed repositories:');
-console.log(" ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
cli -r " + platforms.join(' -r '));
-console.log('To update all repositories:');
-console.log(' ./cordova-coho/coho repo-update');
+//Determine which platforms are available
+// Default platforms [Android, Blackberry], both platforms works under
Windows, Linux and Mac OS
+cordovaPlatforms = ['android', 'blackberry10'];
+if (/^win/.test(process.platform)) {
+//Determine windows 8 platform
+child_process.exec('wmic os get caption', function (error, stdout,
stderr) {
+if (error !== null) {
+callback = 'Error performing command: ' + error + "\n" +
stderr;
+} else {
+// If Windows 8, add Windows Phone 8 and Windows8 platform to
the array
+if ((/.*(Windows 8).*/gi).test(((stdout.replace(/\r\r\n/i, ':
')).replace(/\s\s+/g, '')).replace((/\n|\r/gi), ''))) {
+
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968817#comment-13968817 ] ASF GitHub Bot commented on CB-6437: Github user cmarcelk commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11607031 --- Diff: createmobilespec/createmobilespec.sh --- @@ -0,0 +1,3 @@ +#!/bin/bash --- End diff -- All files should include the Apache header. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[
https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968815#comment-13968815
]
ASF GitHub Bot commented on CB-6437:
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606853
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/
+ */
var fs = require('fs'),
path = require('path'),
-shelljs,
-optimist;
+child_process = require('child_process'),
+shelljs;
+
+// Dependencies requirements check
try {
shelljs = require('shelljs');
-optimist = require('optimist');
} catch (e) {
console.error('Missing module. Please run "npm install" from this
directory:\n\t' +
- path.dirname(__dirname));
+path.dirname(__dirname));
process.exit(2);
}
-var tokens = process.argv.slice(2);
-var argv = optimist(tokens)
- .default('android', false)
- .default('ios', false)
- .usage('Usage: $0 [--android] [--ios]\nDefault is to use
Android and iOS.')
- .argv;
-// preserve the original behavior when there are no args
-if (tokens.length === 0) {
-argv.android = true;
-argv.ios = true;
+console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
+console.log('To clone needed repositories:');
+console.log(' ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
android -r ios -r cli');
+console.log('To update all repositories:');
+console.log(' ./cordova-coho/coho repo-update');
+
+// Setting up vars, folders and libraries, to ensure full compatibility
cross platform, absolute paths are used instead of relative paths
+var mainModDir = process.cwd(),
+// Cordova Coho dir, it should contain all libraries and required
repositories
+// [cordova-cli, cordova-android, cordova-blackberry, cordova-ios,
cordova-windows, cordova-windows8, all plugins libraries, cordova-mobile-spec,
cordova-js]
+// searchDir function it was added, to look for cordova-coho folder
backwards, for cases like absolute/path/cordova-coho/cordova-coho/...All
libraries
+// This is to make sure that cordova-coho exists and it's the right one.
+coho_dir = searchDir(mainModDir, 'cordova-coho'),
+cordova_cli = path.join(coho_dir, 'cordova-cli', 'bin', 'cordova'),
+cordova_ms = (path.join(coho_dir, 'cordova-mobile-spec')),
+cordova_js = (path.join(coho_dir, 'cordova-js')),
+ms_project_dir = (path.join(mainModDir, 'mobilespec'));
+
+// Main libraries and path's requirements check
+if (!fs.existsSync(coho_dir)) {
+console.log('Please run this script from the directory that contains
cordova-coho');
+shelljs.exit(1);
}
-var platforms = [];
-if (argv.android) { platforms.push('android'); }
-if (argv.ios) { platforms.push('ios'); }
-if (!fs.existsSync('cordova-mobile-spec')) {
+if (!fs.existsSync(cordova_ms)) {
console.log('Please run this script from the directory that contains
cordova-mobile-spec');
shelljs.exit(1);
}
-if (fs.existsSync('mobilespec')) {
-console.log('Directory "mobilespec" already exists. Delete it first
then re-run.');
+if (!fs.existsSync(cordova_js)) {
+console.log('Please run this script from the directory that contains
cordova-js');
shelljs.exit(1);
}
-console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
-console.log('To clone needed repositories:');
-console.log(" ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
cli -r " + platforms.join(' -r '));
-console.log('To update all repositories:');
-console.log(' ./cordova-coho/coho repo-update');
+//Determine which platforms are available
+// Default platforms [Android, Blackberry], both platforms works under
Windows, Linux and Mac OS
+cordovaPlatforms = ['android', 'blackberry10'];
+if (/^win/.test(process.platform)) {
+//Determine windows 8 platform
+child_process.exec('wmic os get caption', function (error, stdout,
stderr) {
+if (error !== null) {
+callback = 'Error performing command: ' + error + "\n" +
stderr;
+} else {
+// If Windows 8, add Windows Phone 8 and Windows8 platform to
the array
+if ((/.*(Windows 8).*/gi).test(((stdout.replace(/\r\r\n/i, ':
')).replace(/\s\s+/g, '')).replace((/\n|\r/gi), ''))) {
+
[jira] [Updated] (CB-6441) Plugin frameworks not always included
[ https://issues.apache.org/jira/browse/CB-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-6441: - Component/s: (was: iOS) Plugman CLI > Plugin frameworks not always included > - > > Key: CB-6441 > URL: https://issues.apache.org/jira/browse/CB-6441 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Dooms >Assignee: Anis Kadri >Priority: Minor > > Several plugins specify frameworks in ios (e.g. NetworkInformation requires > SystemConfiguration.framework). However these aren't always added > automatically, and must be added manually. This seems to happen especially > during a plugin update. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6441) Plugin frameworks not always included
[ https://issues.apache.org/jira/browse/CB-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-6441: - Environment: iOS > Plugin frameworks not always included > - > > Key: CB-6441 > URL: https://issues.apache.org/jira/browse/CB-6441 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 > Environment: iOS >Reporter: Dooms >Assignee: Anis Kadri >Priority: Minor > > Several plugins specify frameworks in ios (e.g. NetworkInformation requires > SystemConfiguration.framework). However these aren't always added > automatically, and must be added manually. This seems to happen especially > during a plugin update. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[
https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968810#comment-13968810
]
ASF GitHub Bot commented on CB-6437:
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606571
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/
+ */
var fs = require('fs'),
path = require('path'),
-shelljs,
-optimist;
+child_process = require('child_process'),
+shelljs;
+
+// Dependencies requirements check
try {
shelljs = require('shelljs');
-optimist = require('optimist');
} catch (e) {
console.error('Missing module. Please run "npm install" from this
directory:\n\t' +
- path.dirname(__dirname));
+path.dirname(__dirname));
process.exit(2);
}
-var tokens = process.argv.slice(2);
-var argv = optimist(tokens)
- .default('android', false)
- .default('ios', false)
- .usage('Usage: $0 [--android] [--ios]\nDefault is to use
Android and iOS.')
- .argv;
-// preserve the original behavior when there are no args
-if (tokens.length === 0) {
-argv.android = true;
-argv.ios = true;
+console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
+console.log('To clone needed repositories:');
+console.log(' ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
android -r ios -r cli');
+console.log('To update all repositories:');
+console.log(' ./cordova-coho/coho repo-update');
+
+// Setting up vars, folders and libraries, to ensure full compatibility
cross platform, absolute paths are used instead of relative paths
+var mainModDir = process.cwd(),
+// Cordova Coho dir, it should contain all libraries and required
repositories
+// [cordova-cli, cordova-android, cordova-blackberry, cordova-ios,
cordova-windows, cordova-windows8, all plugins libraries, cordova-mobile-spec,
cordova-js]
+// searchDir function it was added, to look for cordova-coho folder
backwards, for cases like absolute/path/cordova-coho/cordova-coho/...All
libraries
+// This is to make sure that cordova-coho exists and it's the right one.
+coho_dir = searchDir(mainModDir, 'cordova-coho'),
+cordova_cli = path.join(coho_dir, 'cordova-cli', 'bin', 'cordova'),
+cordova_ms = (path.join(coho_dir, 'cordova-mobile-spec')),
+cordova_js = (path.join(coho_dir, 'cordova-js')),
+ms_project_dir = (path.join(mainModDir, 'mobilespec'));
+
+// Main libraries and path's requirements check
+if (!fs.existsSync(coho_dir)) {
+console.log('Please run this script from the directory that contains
cordova-coho');
+shelljs.exit(1);
}
-var platforms = [];
-if (argv.android) { platforms.push('android'); }
-if (argv.ios) { platforms.push('ios'); }
-if (!fs.existsSync('cordova-mobile-spec')) {
+if (!fs.existsSync(cordova_ms)) {
console.log('Please run this script from the directory that contains
cordova-mobile-spec');
shelljs.exit(1);
}
-if (fs.existsSync('mobilespec')) {
-console.log('Directory "mobilespec" already exists. Delete it first
then re-run.');
+if (!fs.existsSync(cordova_js)) {
+console.log('Please run this script from the directory that contains
cordova-js');
shelljs.exit(1);
}
-console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
-console.log('To clone needed repositories:');
-console.log(" ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
cli -r " + platforms.join(' -r '));
-console.log('To update all repositories:');
-console.log(' ./cordova-coho/coho repo-update');
+//Determine which platforms are available
+// Default platforms [Android, Blackberry], both platforms works under
Windows, Linux and Mac OS
+cordovaPlatforms = ['android', 'blackberry10'];
+if (/^win/.test(process.platform)) {
+//Determine windows 8 platform
+child_process.exec('wmic os get caption', function (error, stdout,
stderr) {
+if (error !== null) {
+callback = 'Error performing command: ' + error + "\n" +
stderr;
+} else {
+// If Windows 8, add Windows Phone 8 and Windows8 platform to
the array
+if ((/.*(Windows 8).*/gi).test(((stdout.replace(/\r\r\n/i, ':
')).replace(/\s\s+/g, '')).replace((/\n|\r/gi), ''))) {
+
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[
https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968806#comment-13968806
]
ASF GitHub Bot commented on CB-6437:
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606359
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/
+ */
var fs = require('fs'),
path = require('path'),
-shelljs,
-optimist;
+child_process = require('child_process'),
+shelljs;
+
+// Dependencies requirements check
try {
shelljs = require('shelljs');
-optimist = require('optimist');
} catch (e) {
console.error('Missing module. Please run "npm install" from this
directory:\n\t' +
- path.dirname(__dirname));
+path.dirname(__dirname));
process.exit(2);
}
-var tokens = process.argv.slice(2);
-var argv = optimist(tokens)
- .default('android', false)
- .default('ios', false)
- .usage('Usage: $0 [--android] [--ios]\nDefault is to use
Android and iOS.')
- .argv;
-// preserve the original behavior when there are no args
-if (tokens.length === 0) {
-argv.android = true;
-argv.ios = true;
+console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
+console.log('To clone needed repositories:');
+console.log(' ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
android -r ios -r cli');
+console.log('To update all repositories:');
+console.log(' ./cordova-coho/coho repo-update');
+
+// Setting up vars, folders and libraries, to ensure full compatibility
cross platform, absolute paths are used instead of relative paths
+var mainModDir = process.cwd(),
+// Cordova Coho dir, it should contain all libraries and required
repositories
+// [cordova-cli, cordova-android, cordova-blackberry, cordova-ios,
cordova-windows, cordova-windows8, all plugins libraries, cordova-mobile-spec,
cordova-js]
+// searchDir function it was added, to look for cordova-coho folder
backwards, for cases like absolute/path/cordova-coho/cordova-coho/...All
libraries
+// This is to make sure that cordova-coho exists and it's the right one.
+coho_dir = searchDir(mainModDir, 'cordova-coho'),
+cordova_cli = path.join(coho_dir, 'cordova-cli', 'bin', 'cordova'),
+cordova_ms = (path.join(coho_dir, 'cordova-mobile-spec')),
+cordova_js = (path.join(coho_dir, 'cordova-js')),
+ms_project_dir = (path.join(mainModDir, 'mobilespec'));
+
+// Main libraries and path's requirements check
+if (!fs.existsSync(coho_dir)) {
+console.log('Please run this script from the directory that contains
cordova-coho');
+shelljs.exit(1);
}
-var platforms = [];
-if (argv.android) { platforms.push('android'); }
-if (argv.ios) { platforms.push('ios'); }
-if (!fs.existsSync('cordova-mobile-spec')) {
+if (!fs.existsSync(cordova_ms)) {
console.log('Please run this script from the directory that contains
cordova-mobile-spec');
shelljs.exit(1);
}
-if (fs.existsSync('mobilespec')) {
-console.log('Directory "mobilespec" already exists. Delete it first
then re-run.');
+if (!fs.existsSync(cordova_js)) {
+console.log('Please run this script from the directory that contains
cordova-js');
shelljs.exit(1);
}
-console.log('Creating mobilespec project. If you have any errors, it may
be from missing repositories.');
-console.log('To clone needed repositories:');
-console.log(" ./cordova-coho/coho repo-clone -r plugins -r mobile-spec -r
cli -r " + platforms.join(' -r '));
-console.log('To update all repositories:');
-console.log(' ./cordova-coho/coho repo-update');
+//Determine which platforms are available
+// Default platforms [Android, Blackberry], both platforms works under
Windows, Linux and Mac OS
+cordovaPlatforms = ['android', 'blackberry10'];
--- End diff --
I don't think the goal is to build all possible mobile platforms. A
frequent developer workflow is to work on only one mobile platform at a time.
The last commit reads command-line args to let users self-select which mobile
platforms to build. I suggest that behavior be preserved.
> [Mobilespec] improve and add support for blackberry, wp8, windows8
> --
>
> Key: CB-6437
> URL: https://issues.apache.org/jira/
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968796#comment-13968796 ] ASF GitHub Bot commented on CB-6437: Github user martincgg commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-40413680 Changed tabs for spaces > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6428) Unable to read android_asset directory through File API
[
https://issues.apache.org/jira/browse/CB-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968779#comment-13968779
]
Andrew Grieve commented on CB-6428:
---
Confirmed this is not yet implemented. It's a part of the original proposal
(CB-285), but it's just not done yet.
> Unable to read android_asset directory through File API
> ---
>
> Key: CB-6428
> URL: https://issues.apache.org/jira/browse/CB-6428
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 3.3.0
> Environment: Android 4.4.2 / Samsung Galaxy S4
>Reporter: Matt Grande
>Assignee: Ian Clelland
> Labels: android, file
>
> Attempting to read the 'android_asset' folder through the File API results in
> Error Code 5 (FileError.ENCODING_ERR). I've tried accessing via
> resolveLocalFileSystemURL, and by creating a directory reader and calling
> readEntries().
>
> window.resolveLocalFileSystemURL('file:///android_asset/www/my_asset_folder',
> success, fail);
> var sourceDir = new DirectoryEntry( { fullPath:
> 'file:///android_asset/www/my_asset_folder' } );
> var reader = sourceDir.createReader();
> reader.readEntries(success, fail);
> (I have also tried with the URLs being '/android_asset/www/my_asset_folder';
> same result)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[
https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968771#comment-13968771
]
ASF GitHub Bot commented on CB-6437:
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11604897
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/
+ */
var fs = require('fs'),
path = require('path'),
-shelljs,
-optimist;
+child_process = require('child_process'),
+shelljs;
+
+// Dependencies requirements check
try {
-shelljs = require('shelljs');
-optimist = require('optimist');
+ shelljs = require('shelljs');
--- End diff --
Please replace tabs with 4 spaces. (Yes, this is a nit.) Tabs appear in
several of your additions.
> [Mobilespec] improve and add support for blackberry, wp8, windows8
> --
>
> Key: CB-6437
> URL: https://issues.apache.org/jira/browse/CB-6437
> Project: Apache Cordova
> Issue Type: Improvement
> Components: BlackBerry, mobile-spec, Windows 8, WP8
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry10, mobilespec,, module, node, support,
> windows8, wp8
> Fix For: 3.5.0
>
>
> The new node module for Mobilespecs can be improved.
> -Adding more functionality
> -Supporting platforms as blackberry10, windows phone 8 and windows 8.
> -Add functionality to automate some process as well.
> -Add functionality to add platforms according to the development environment
> --- Android, Blackberry, iOS ---> Mac.
> --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8.
> --- Android, Blackberry ---> Linux or any other Windows OS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968751#comment-13968751 ] ASF GitHub Bot commented on CB-6437: Github user martincgg commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-40410078 Tested it under Windows 7 & 8(Run as adminstrator), Mac and Linux(Ubuntu). > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968745#comment-13968745 ] ASF GitHub Bot commented on CB-6437: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/55 CB-6437[Improvements & support for more platforms] -Added full compatibility cross platform -Works with absolute paths -Added support for Blackberry10, Windows 8 and Windows Phone 8 -Added functionality to add platforms according to the development environment: --- Android, Blackberry, iOS ---> Mac. --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. --- Android, Blackberry ---> Linux or any other Windows OS. - Added more requirements checks - Added functionality to delete project folder if exists (recursive function) - Added functionality to locate libraries - Added function to copy with exclusion list - Added createmobilespec.bat & createmobilespec.sh - Added symlink for windows & Linux based OS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-mobile-spec CB-6437 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 7a5475e9a70c2e13d742ca46dbd529fd8ff1968f Author: Martin Gonzalez Date: 2014-04-14T19:46:17Z CB-6437[Improvements & support for more platforms] -Added full compatibility cross platform -Working with absolute paths -Added support for Blackberry10, Windows 8 and Windows Phone 8 -Added functionality to add platforms according to the development environment -- Android, Blackberry, iOS ---> Mac. -- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. -- Android, Blackberry ---> Linux or any other Windows OS. - Added more requirements checks - Added functionality to delete project folder if exists (recursive function) - Added functionality to locate libraries - Added function to copy with exclusion list - Added createmobilespec.bat & createmobilespec.sh - Added symlink for windows & Linux based OS. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968724#comment-13968724 ] Martin Gonzalez edited comment on CB-6437 at 4/14/14 7:33 PM: -- Requires CB-6435. When try to add plugins and Windows8 platform is installed, it during the installation it throws a error because it doesn't passed the requirements check for version. Semver it establish that the minimum version is 3.3.0 and the versions files it contains 3.3.0-dev, so dev is below release version and it doesn't pass. So this error causes a break of the module, and stops the whole execution. It requires the resolution to work correctly. was (Author: martin.c.glez.glez): Requires CB-6415. When try to add plugins and Windows8 platform is installed, it during the installation it throws a error because it doesn't passed the requirements check for version. Semver it establish that the minimum version is 3.3.0 and the versions files it contains 3.3.0-dev, so dev is below release version and it doesn't pass. So this error causes a break of the module, and stops the whole execution. It requires the resolution to work correctly. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968724#comment-13968724 ] Martin Gonzalez edited comment on CB-6437 at 4/14/14 7:33 PM: -- Requires CB-6415. When try to add plugins and Windows8 platform is installed, it during the installation it throws a error because it doesn't passed the requirements check for version. Semver it establish that the minimum version is 3.3.0 and the versions files it contains 3.3.0-dev, so dev is below release version and it doesn't pass. So this error causes a break of the module, and stops the whole execution. It requires the resolution to work correctly. was (Author: martin.c.glez.glez): When try to add plugins and Windows8 platform is installed, it during the installation it throws a error because it doesn't passed the requirements check for version. Semver it establish that the minimum version is 3.3.0 and the versions files it contains 3.3.0-dev, so dev is below release version and it doesn't pass. So this error causes a break of the module, and stops the whole execution. It requires the resolution to work correctly. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6413) spec.105 and spec.108 of file autotest are failed on Android 2.3.7
[ https://issues.apache.org/jira/browse/CB-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968727#comment-13968727 ] ASF subversion and git services commented on CB-6413: - Commit 9c6d91aa79f6f3ff552b12c1ac8fa3ebd78138f8 in cordova-mobile-spec's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=9c6d91a ] CB-6413: Fix feature detection of ArrayBuffer/Blob support on Sony Android 2.3.7 > spec.105 and spec.108 of file autotest are failed on Android 2.3.7 > -- > > Key: CB-6413 > URL: https://issues.apache.org/jira/browse/CB-6413 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 > Environment: Android 2.3.7 >Reporter: puchen > > Run spec.105 and spec.108 of file autotest got messages: > spec.105: Expected 4 to be 32. > spec.108: Expected spy verifier to have been called. > Android 2.3.7 can't support window.WebKitBlobBuilder, and js code "if > (window.WebKitBlobBuilder)" the window.WebKitBlobBuilder is 'undefined' in > the spec.105 and spec.108. But codes still run in the if line. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968715#comment-13968715 ] Martin Gonzalez edited comment on CB-6437 at 4/14/14 7:33 PM: -- Requires CB-6435. Blackberry it doesn't passes the requirement check, because it doesn't look under cordova-blackberry. According to the load and usage of lazy_load, it should look under the repository for blackberry10\bin. And the requirements check looks for cordova-blackberry\bin. This behavior it's only reproduced when local libraries are used. So this blocker issue resolves that problem to work correctly. was (Author: martin.c.glez.glez): Blackberry it doesn't passes the requirement check, because it doesn't look under cordova-blackberry. According to the load and usage of lazy_load, it should look under the repository for blackberry10\bin. And the requirements check looks for cordova-blackberry\bin. This behavior it's only reproduced when local libraries are used. So this blocker issue resolves that problem to work correctly. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968715#comment-13968715 ] Martin Gonzalez edited comment on CB-6437 at 4/14/14 7:33 PM: -- Requires CB-6415. Blackberry it doesn't passes the requirement check, because it doesn't look under cordova-blackberry. According to the load and usage of lazy_load, it should look under the repository for blackberry10\bin. And the requirements check looks for cordova-blackberry\bin. This behavior it's only reproduced when local libraries are used. So this blocker issue resolves that problem to work correctly. was (Author: martin.c.glez.glez): Requires CB-6435. Blackberry it doesn't passes the requirement check, because it doesn't look under cordova-blackberry. According to the load and usage of lazy_load, it should look under the repository for blackberry10\bin. And the requirements check looks for cordova-blackberry\bin. This behavior it's only reproduced when local libraries are used. So this blocker issue resolves that problem to work correctly. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968724#comment-13968724 ] Martin Gonzalez commented on CB-6437: - When try to add plugins and Windows8 platform is installed, it during the installation it throws a error because it doesn't passed the requirements check for version. Semver it establish that the minimum version is 3.3.0 and the versions files it contains 3.3.0-dev, so dev is below release version and it doesn't pass. So this error causes a break of the module, and stops the whole execution. It requires the resolution to work correctly. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968715#comment-13968715 ] Martin Gonzalez commented on CB-6437: - Blackberry it doesn't passes the requirement check, because it doesn't look under cordova-blackberry. According to the load and usage of lazy_load, it should look under the repository for blackberry10\bin. And the requirements check looks for cordova-blackberry\bin. This behavior it's only reproduced when local libraries are used. So this blocker issue resolves that problem to work correctly. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6437) [Mobilespec] improve and add support for blackberry, wp8, windows8
[ https://issues.apache.org/jira/browse/CB-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Gonzalez updated CB-6437: Description: The new node module for Mobilespecs can be improved. -Adding more functionality -Supporting platforms as blackberry10, windows phone 8 and windows 8. -Add functionality to automate some process as well. -Add functionality to add platforms according to the development environment --- Android, Blackberry, iOS ---> Mac. --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. --- Android, Blackberry ---> Linux or any other Windows OS. was: The new node module for Mobilespecs can be improved. -Adding more functionality -Supporting platforms as blackberry10, windows phone 8 and windows 8. -Add functionality to automate some process as well. > [Mobilespec] improve and add support for blackberry, wp8, windows8 > -- > > Key: CB-6437 > URL: https://issues.apache.org/jira/browse/CB-6437 > Project: Apache Cordova > Issue Type: Improvement > Components: BlackBerry, mobile-spec, Windows 8, WP8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry10, mobilespec,, module, node, support, > windows8, wp8 > Fix For: 3.5.0 > > > The new node module for Mobilespecs can be improved. > -Adding more functionality > -Supporting platforms as blackberry10, windows phone 8 and windows 8. > -Add functionality to automate some process as well. > -Add functionality to add platforms according to the development environment > --- Android, Blackberry, iOS ---> Mac. > --- Android, Blackberry, Windows 8, Windows Phone 8 ---> Windows 8. > --- Android, Blackberry ---> Linux or any other Windows OS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6441) Plugin frameworks not always included
[ https://issues.apache.org/jira/browse/CB-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968642#comment-13968642 ] Anis Kadri commented on CB-6441: Can you confirm that this happens when you install multiple plugins in succession ? I've got the same issue but it doesn't happen unless there is more than one plugin being installed. > Plugin frameworks not always included > - > > Key: CB-6441 > URL: https://issues.apache.org/jira/browse/CB-6441 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.4.0 >Reporter: Dooms >Assignee: Anis Kadri >Priority: Minor > > Several plugins specify frameworks in ios (e.g. NetworkInformation requires > SystemConfiguration.framework). However these aren't always added > automatically, and must be added manually. This seems to happen especially > during a plugin update. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6441) Plugin frameworks not always included
[ https://issues.apache.org/jira/browse/CB-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anis Kadri reassigned CB-6441: -- Assignee: Anis Kadri > Plugin frameworks not always included > - > > Key: CB-6441 > URL: https://issues.apache.org/jira/browse/CB-6441 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.4.0 >Reporter: Dooms >Assignee: Anis Kadri >Priority: Minor > > Several plugins specify frameworks in ios (e.g. NetworkInformation requires > SystemConfiguration.framework). However these aren't always added > automatically, and must be added manually. This seems to happen especially > during a plugin update. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6413) spec.105 and spec.108 of file autotest are failed on Android 2.3.7
[
https://issues.apache.org/jira/browse/CB-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968620#comment-13968620
]
Ian Clelland commented on CB-6413:
--
Sounds like a pretty special build of Android -- thanks for checking.
I think that what's going wrong here is that the call to {{fail()}} doesn't
actually stop execution of the test. {{blob}} is left undefined, and the test
runs without it.
I'd like to skip the test entirely, but I don't think we can, on your device.
With {{ArrayBuffer}} and {{Blob}} both being defined (and looking correct,) I
think we need to run the test and try to create the blob before we fail.
Out of curiosity -- since the Blob constructor statement is obviously throwing
an exception -- can you tell what the exception is? I'm wondering what kind of
blob implementation you have on that phone.
> spec.105 and spec.108 of file autotest are failed on Android 2.3.7
> --
>
> Key: CB-6413
> URL: https://issues.apache.org/jira/browse/CB-6413
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 3.4.0
> Environment: Android 2.3.7
>Reporter: puchen
>
> Run spec.105 and spec.108 of file autotest got messages:
> spec.105: Expected 4 to be 32.
> spec.108: Expected spy verifier to have been called.
> Android 2.3.7 can't support window.WebKitBlobBuilder, and js code "if
> (window.WebKitBlobBuilder)" the window.WebKitBlobBuilder is 'undefined' in
> the spec.105 and spec.108. But codes still run in the if line.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6435) [windows 8] version outdated, still 3.3.0-dev
[ https://issues.apache.org/jira/browse/CB-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968417#comment-13968417 ] ASF GitHub Bot commented on CB-6435: Github user martincgg commented on the pull request: https://github.com/apache/cordova-windows/pull/25#issuecomment-40375277 Yes, agree. This is completely odd, what worries me, is when trying to install plugins to a project with windows 8 platform installed, it throws an error with plugman module: https://github.com/apache/cordova-plugman/blob/master/src/install.js#L90 So it stops the whole thing and is not possible add plugins to the project. So this need to be fixed. > [windows 8] version outdated, still 3.3.0-dev > - > > Key: CB-6435 > URL: https://issues.apache.org/jira/browse/CB-6435 > Project: Apache Cordova > Issue Type: Bug > Components: Windows 8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez > Labels: plugins, version, windows8 > Fix For: 3.5.0 > > > Trying to add plugins to a project that has the windows8 platform, I've found > out that that semver causes an error, because it doesn't pass the > requirements. > Min requirement: 3.3.0 > Engine.requirement: 3.3.0-dev > So it doesn't pass. > The file version needs to be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6442) build/run fails if project path contains spaces
[ https://issues.apache.org/jira/browse/CB-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968400#comment-13968400 ] Vladimir Kotikov commented on CB-6442: -- Create a PR to fix this https://github.com/apache/cordova-windows/pull/26 > build/run fails if project path contains spaces > --- > > Key: CB-6442 > URL: https://issues.apache.org/jira/browse/CB-6442 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Windows 8 >Affects Versions: 3.4.0 > Environment: Windows 8.1 Cordova CLI 3.4.1 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > Fix For: 3.4.0 > > > 1. Create new project with spaces in path. > 2. cordova platform add windows8 > 3. cordova build windows8 > Running command: cmd "/s /c ""d:\PROJECTS\Temp\test > app\platforms\windows8\cordova\build.bat""" > ... > D:\PROJECTS\Temp\test > app\platforms\windows8\cordova\lib\ApplyPlatformConfig.ps1 : A positional > parameter cannot be found that accepts > argument 'app\platforms\windows8'. > same problem with > cordova run windows 8 > To get this working we need to add additional quotes into powershell scripts > call. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6442) build/run fails if project path contains spaces
[ https://issues.apache.org/jira/browse/CB-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968399#comment-13968399 ] ASF GitHub Bot commented on CB-6442: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/26 CB-6442 Fix build/deploy errors when path to project contains spaces You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-6442 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 8037310ad388a37adcc176dffecd2d8a3a5a4e15 Author: Vladimir Kotikov Date: 2014-04-14T08:30:59Z Fix build/deploy errors when path to project contains spaces > build/run fails if project path contains spaces > --- > > Key: CB-6442 > URL: https://issues.apache.org/jira/browse/CB-6442 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Windows 8 >Affects Versions: 3.4.0 > Environment: Windows 8.1 Cordova CLI 3.4.1 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > Fix For: 3.4.0 > > > 1. Create new project with spaces in path. > 2. cordova platform add windows8 > 3. cordova build windows8 > Running command: cmd "/s /c ""d:\PROJECTS\Temp\test > app\platforms\windows8\cordova\build.bat""" > ... > D:\PROJECTS\Temp\test > app\platforms\windows8\cordova\lib\ApplyPlatformConfig.ps1 : A positional > parameter cannot be found that accepts > argument 'app\platforms\windows8'. > same problem with > cordova run windows 8 > To get this working we need to add additional quotes into powershell scripts > call. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6442) build/run fails if project path contains spaces
[ https://issues.apache.org/jira/browse/CB-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-6442: - Description: 1. Create new project with spaces in path. 2. cordova platform add windows8 3. cordova build windows8 Running command: cmd "/s /c ""d:\PROJECTS\Temp\test app\platforms\windows8\cordova\build.bat""" ... D:\PROJECTS\Temp\test app\platforms\windows8\cordova\lib\ApplyPlatformConfig.ps1 : A positional parameter cannot be found that accepts argument 'app\platforms\windows8'. same problem with cordova run windows 8 To get this working we need to add additional quotes into powershell scripts call. was: 1. Create new project with spaces in path. 2. cordova platform add windows8 3. cordova build windows8 Running command: cmd "/s /c ""d:\PROJECTS\Temp\test app\platforms\windows8\cordova\build.bat""" ... D:\PROJECTS\Temp\test app\platforms\windows8\cordova\lib\ApplyPlatformConfig.ps1 : A positional parameter cannot be found that accepts argument 'app\platforms\windows8'. same problem with cordova run windows 8 To get this working we need to add additional quoting into powershell scripts call. > build/run fails if project path contains spaces > --- > > Key: CB-6442 > URL: https://issues.apache.org/jira/browse/CB-6442 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Windows 8 >Affects Versions: 3.4.0 > Environment: Windows 8.1 Cordova CLI 3.4.1 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > Fix For: 3.4.0 > > > 1. Create new project with spaces in path. > 2. cordova platform add windows8 > 3. cordova build windows8 > Running command: cmd "/s /c ""d:\PROJECTS\Temp\test > app\platforms\windows8\cordova\build.bat""" > ... > D:\PROJECTS\Temp\test > app\platforms\windows8\cordova\lib\ApplyPlatformConfig.ps1 : A positional > parameter cannot be found that accepts > argument 'app\platforms\windows8'. > same problem with > cordova run windows 8 > To get this working we need to add additional quotes into powershell scripts > call. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6442) build/run fails if project path contains spaces
Vladimir Kotikov created CB-6442: Summary: build/run fails if project path contains spaces Key: CB-6442 URL: https://issues.apache.org/jira/browse/CB-6442 Project: Apache Cordova Issue Type: Bug Components: CLI, Windows 8 Affects Versions: 3.4.0 Environment: Windows 8.1 Cordova CLI 3.4.1 Reporter: Vladimir Kotikov Assignee: Jesse MacFadyen Fix For: 3.4.0 1. Create new project with spaces in path. 2. cordova platform add windows8 3. cordova build windows8 Running command: cmd "/s /c ""d:\PROJECTS\Temp\test app\platforms\windows8\cordova\build.bat""" ... D:\PROJECTS\Temp\test app\platforms\windows8\cordova\lib\ApplyPlatformConfig.ps1 : A positional parameter cannot be found that accepts argument 'app\platforms\windows8'. same problem with cordova run windows 8 To get this working we need to add additional quoting into powershell scripts call. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6377) CLI is unable to create a project when there are spaces in the path
[ https://issues.apache.org/jira/browse/CB-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968345#comment-13968345 ] ASF GitHub Bot commented on CB-6377: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/161#issuecomment-40365473 @bryanhiggins thx! > CLI is unable to create a project when there are spaces in the path > --- > > Key: CB-6377 > URL: https://issues.apache.org/jira/browse/CB-6377 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: JennyGee >Assignee: Josh Soref >Priority: Critical > > Unable to create a project where there are spaces in the path. > C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-cli\node_modules\ > wrench\lib\wrench.js:249 > if (e.code !== 'EEXIST') throw e; >^ > Error: ENOENT, no such file or directory 'C:\Documents and > Settings\IEUser\.cord > ova\lib\blackberry10\cordova\v2.1.0.3' > at Object.fs.mkdirSync (fs.js:642:18) > at Object.exports.copyDirSyncRecursive (C:\Program Files\BlackBerry\BB10 > Web > Works SDK 2.1.0.3\webworks-cli\node_modules\wrench\lib\wrench.js:246:12) > at Object._self.fetchBlackBerry (C:\Program Files\BlackBerry\BB10 > WebWorks S > DK 2.1.0.3\webworks-cli\lib\utils\utils.js:59:20) > at new CLI (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-c > li\lib\cli.js:48:19) > at Object. (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3 > \webworks-cli\bin\webworks:4:16) > at Module._compile (module.js:456:26) > at Object.Module._extensions..js (module.js:474:10) > at Module.load (module.js:356:32) > at Function.Module._load (module.js:312:12) > at Function.Module.runMain (module.js:497:10) > Looking at the source code, it appears that > https://issues.apache.org/jira/browse/CB-6323 broke > https://issues.apache.org/jira/browse/CB-6306 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6377) CLI is unable to create a project when there are spaces in the path
[ https://issues.apache.org/jira/browse/CB-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968340#comment-13968340 ] ASF GitHub Bot commented on CB-6377: Github user bryanhiggins commented on the pull request: https://github.com/apache/cordova-cli/pull/161#issuecomment-40364475 @sgrebnov Thanks for testing. I've merged this in. Feel free to issue a pull request for your points which seem valid to me. Josh is on holiday until next week. I think it can wait until then. > CLI is unable to create a project when there are spaces in the path > --- > > Key: CB-6377 > URL: https://issues.apache.org/jira/browse/CB-6377 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: JennyGee >Assignee: Josh Soref >Priority: Critical > > Unable to create a project where there are spaces in the path. > C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-cli\node_modules\ > wrench\lib\wrench.js:249 > if (e.code !== 'EEXIST') throw e; >^ > Error: ENOENT, no such file or directory 'C:\Documents and > Settings\IEUser\.cord > ova\lib\blackberry10\cordova\v2.1.0.3' > at Object.fs.mkdirSync (fs.js:642:18) > at Object.exports.copyDirSyncRecursive (C:\Program Files\BlackBerry\BB10 > Web > Works SDK 2.1.0.3\webworks-cli\node_modules\wrench\lib\wrench.js:246:12) > at Object._self.fetchBlackBerry (C:\Program Files\BlackBerry\BB10 > WebWorks S > DK 2.1.0.3\webworks-cli\lib\utils\utils.js:59:20) > at new CLI (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-c > li\lib\cli.js:48:19) > at Object. (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3 > \webworks-cli\bin\webworks:4:16) > at Module._compile (module.js:456:26) > at Object.Module._extensions..js (module.js:474:10) > at Module.load (module.js:356:32) > at Function.Module._load (module.js:312:12) > at Function.Module.runMain (module.js:497:10) > Looking at the source code, it appears that > https://issues.apache.org/jira/browse/CB-6323 broke > https://issues.apache.org/jira/browse/CB-6306 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6377) CLI is unable to create a project when there are spaces in the path
[ https://issues.apache.org/jira/browse/CB-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968339#comment-13968339 ] ASF GitHub Bot commented on CB-6377: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/161 > CLI is unable to create a project when there are spaces in the path > --- > > Key: CB-6377 > URL: https://issues.apache.org/jira/browse/CB-6377 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: JennyGee >Assignee: Josh Soref >Priority: Critical > > Unable to create a project where there are spaces in the path. > C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-cli\node_modules\ > wrench\lib\wrench.js:249 > if (e.code !== 'EEXIST') throw e; >^ > Error: ENOENT, no such file or directory 'C:\Documents and > Settings\IEUser\.cord > ova\lib\blackberry10\cordova\v2.1.0.3' > at Object.fs.mkdirSync (fs.js:642:18) > at Object.exports.copyDirSyncRecursive (C:\Program Files\BlackBerry\BB10 > Web > Works SDK 2.1.0.3\webworks-cli\node_modules\wrench\lib\wrench.js:246:12) > at Object._self.fetchBlackBerry (C:\Program Files\BlackBerry\BB10 > WebWorks S > DK 2.1.0.3\webworks-cli\lib\utils\utils.js:59:20) > at new CLI (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-c > li\lib\cli.js:48:19) > at Object. (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3 > \webworks-cli\bin\webworks:4:16) > at Module._compile (module.js:456:26) > at Object.Module._extensions..js (module.js:474:10) > at Module.load (module.js:356:32) > at Function.Module._load (module.js:312:12) > at Function.Module.runMain (module.js:497:10) > Looking at the source code, it appears that > https://issues.apache.org/jira/browse/CB-6323 broke > https://issues.apache.org/jira/browse/CB-6306 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6377) CLI is unable to create a project when there are spaces in the path
[ https://issues.apache.org/jira/browse/CB-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968338#comment-13968338 ] ASF subversion and git services commented on CB-6377: - Commit de2500bf8c0264fb2f2cd8f0271405de8f393d24 in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=de2500b ] CB-6377 superspawn: always wrap non .exe with spaces to cmd with /s /c To use /s, we need: 1. to pass a single argument containing all of our arguments (with quotes around the whole thing). 2. to use spawnOpts.windowsVerbatimArguments so that nothing gets escaped. > CLI is unable to create a project when there are spaces in the path > --- > > Key: CB-6377 > URL: https://issues.apache.org/jira/browse/CB-6377 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: JennyGee >Assignee: Josh Soref >Priority: Critical > > Unable to create a project where there are spaces in the path. > C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-cli\node_modules\ > wrench\lib\wrench.js:249 > if (e.code !== 'EEXIST') throw e; >^ > Error: ENOENT, no such file or directory 'C:\Documents and > Settings\IEUser\.cord > ova\lib\blackberry10\cordova\v2.1.0.3' > at Object.fs.mkdirSync (fs.js:642:18) > at Object.exports.copyDirSyncRecursive (C:\Program Files\BlackBerry\BB10 > Web > Works SDK 2.1.0.3\webworks-cli\node_modules\wrench\lib\wrench.js:246:12) > at Object._self.fetchBlackBerry (C:\Program Files\BlackBerry\BB10 > WebWorks S > DK 2.1.0.3\webworks-cli\lib\utils\utils.js:59:20) > at new CLI (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3\webworks-c > li\lib\cli.js:48:19) > at Object. (C:\Program Files\BlackBerry\BB10 WebWorks SDK > 2.1.0.3 > \webworks-cli\bin\webworks:4:16) > at Module._compile (module.js:456:26) > at Object.Module._extensions..js (module.js:474:10) > at Module.load (module.js:356:32) > at Function.Module._load (module.js:312:12) > at Function.Module.runMain (module.js:497:10) > Looking at the source code, it appears that > https://issues.apache.org/jira/browse/CB-6323 broke > https://issues.apache.org/jira/browse/CB-6306 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6126) [BlackBerry10] Contacts documentation need to be updated
[ https://issues.apache.org/jira/browse/CB-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968336#comment-13968336 ] ASF subversion and git services commented on CB-6126: - Commit 3d79c9035b5c0e46db8fd2ac180efba538dd6cf6 in cordova-plugin-contacts's branch refs/heads/dev from [~bhigg...@blackberry.com] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=3d79c90 ] CB-6126 [BlackBerry10] Update docs quirks section for fields which are supported > [BlackBerry10] Contacts documentation need to be updated > > > Key: CB-6126 > URL: https://issues.apache.org/jira/browse/CB-6126 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry, Docs, Plugin Contacts >Reporter: Kristoffer Flores >Priority: Minor > > Many of the "BlackBerry 10 Quirks" need to be updated since many contacts > fields are now working to spec. > ex: > nickname: Not supported, returning null. > (Nickname is now supported) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6431) Method remapUri handle url 'content://...' incorrectly in FileUtils.java
[ https://issues.apache.org/jira/browse/CB-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland reassigned CB-6431: Assignee: Ian Clelland > Method remapUri handle url 'content://...' incorrectly in FileUtils.java > > > Key: CB-6431 > URL: https://issues.apache.org/jira/browse/CB-6431 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 > Environment: Android 4.1.2 >Reporter: puchen >Assignee: Ian Clelland > > Method remapUri handle url like this > "content://media/external/images/media/6794", path in uri got > "file:mnt/...", which got more '/' than normol file path. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6435) [windows 8] version outdated, still 3.3.0-dev
[ https://issues.apache.org/jira/browse/CB-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968313#comment-13968313 ] ASF GitHub Bot commented on CB-6435: Github user clelland commented on the pull request: https://github.com/apache/cordova-windows/pull/25#issuecomment-40361496 It seems odd that this wasn't taken care of automatically by coho when 3.3.0 was released (and when 3.4.0 was released); if it's still not happening when we do 3.5.0, we should look deeper to see if something else is wrong with the tools. > [windows 8] version outdated, still 3.3.0-dev > - > > Key: CB-6435 > URL: https://issues.apache.org/jira/browse/CB-6435 > Project: Apache Cordova > Issue Type: Bug > Components: Windows 8 >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez > Labels: plugins, version, windows8 > Fix For: 3.5.0 > > > Trying to add plugins to a project that has the windows8 platform, I've found > out that that semver causes an error, because it doesn't pass the > requirements. > Min requirement: 3.3.0 > Engine.requirement: 3.3.0-dev > So it doesn't pass. > The file version needs to be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6377) CLI is unable to create a project when there are spaces in the path
[
https://issues.apache.org/jira/browse/CB-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968250#comment-13968250
]
ASF GitHub Bot commented on CB-6377:
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/161#issuecomment-40355369
LGTM + Tested.
I think we should accept the changes and then look on the following
improvements:
1. The line below is very complex to read/understand. Move to separate fn +
simplify + comments?
[['/s', '/c', '"'+[cmd].concat(args).map(function(a){if (/^[^"].*
.*[^"]/.test(a)) return '"'+a+'"'; return a;}).join(" ")+'"'].join(" ")];
2. Not sure we should use two different cases - if there is white space and
not. Single case is preferred since we don't need to test both cases.
> CLI is unable to create a project when there are spaces in the path
> ---
>
> Key: CB-6377
> URL: https://issues.apache.org/jira/browse/CB-6377
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: JennyGee
>Assignee: Josh Soref
>Priority: Critical
>
> Unable to create a project where there are spaces in the path.
> C:\Program Files\BlackBerry\BB10 WebWorks SDK
> 2.1.0.3\webworks-cli\node_modules\
> wrench\lib\wrench.js:249
> if (e.code !== 'EEXIST') throw e;
>^
> Error: ENOENT, no such file or directory 'C:\Documents and
> Settings\IEUser\.cord
> ova\lib\blackberry10\cordova\v2.1.0.3'
> at Object.fs.mkdirSync (fs.js:642:18)
> at Object.exports.copyDirSyncRecursive (C:\Program Files\BlackBerry\BB10
> Web
> Works SDK 2.1.0.3\webworks-cli\node_modules\wrench\lib\wrench.js:246:12)
> at Object._self.fetchBlackBerry (C:\Program Files\BlackBerry\BB10
> WebWorks S
> DK 2.1.0.3\webworks-cli\lib\utils\utils.js:59:20)
> at new CLI (C:\Program Files\BlackBerry\BB10 WebWorks SDK
> 2.1.0.3\webworks-c
> li\lib\cli.js:48:19)
> at Object. (C:\Program Files\BlackBerry\BB10 WebWorks SDK
> 2.1.0.3
> \webworks-cli\bin\webworks:4:16)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
> at Function.Module._load (module.js:312:12)
> at Function.Module.runMain (module.js:497:10)
> Looking at the source code, it appears that
> https://issues.apache.org/jira/browse/CB-6323 broke
> https://issues.apache.org/jira/browse/CB-6306
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-3207) network
[ https://issues.apache.org/jira/browse/CB-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968217#comment-13968217 ] ASF GitHub Bot commented on CB-3207: GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/9 CB-3207 Newer implementation in FFOS implemented You can merge this pull request into a Git repository by running: $ git pull https://github.com/mozilla-cordova/cordova-plugin-network-information dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 37047348db396c3f1176d860436a03e400b7a659 Author: Piotr Zalewa Date: 2014-03-16T01:44:57Z there was an error in the object definition commit f973965a03f3e59ebb3ec93aee6f132c2f271d00 Author: Piotr Zalewa Date: 2014-03-17T21:06:31Z Merge pull request #1 from zalun/fix_firefoxos there was an error in the object definition commit 44005034004559bb798f402b4ef177f5f70167d8 Author: Rodrigo Silveira Date: 2014-04-07T18:32:28Z Initial version of firefox os network information plugin commit 1fa3ae6e47ab26c11e69721807a8ea42d8723f81 Author: Piotr Zalewa Date: 2014-04-14T10:36:32Z Merge pull request #3 from rodms10/dev Initial version of firefox os network information plugin > network > --- > > Key: CB-3207 > URL: https://issues.apache.org/jira/browse/CB-3207 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS >Affects Versions: 2.6.0 >Reporter: Herm Wong >Assignee: Herm Wong > Fix For: 3.5.0 > > > Network API spec: > https://dvcs.w3.org/hg/dap/raw-file/tip/network-api/Overview.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-5488) deviceready event not firing with jQuery Mobile
[
https://issues.apache.org/jira/browse/CB-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968160#comment-13968160
]
Dooms edited comment on CB-5488 at 4/14/14 8:50 AM:
An update: after a few hours more on this bug, I suspect it occurs whenever
*any* scripts take too long to load (e.g. having several scripts over 1mb in
size), whereafter cordova decides to quit its initialisation.
was (Author: dooms):
An update: after a few hours more on this bug, I suspect it occurs whenever
*any* scripts take too long to load (e.g. having several scripts over 1mb in
size), whereafter cordova decides to quit its initialisation.
Changing the timeout value at the bottom has fixed some of the tests I have run
this fix on.
window.setTimeout(function() {
if (channel.onDeviceReady.state != 2) {
console.log('deviceready has not fired after 5 seconds.');
logUnfiredChannels(platformInitChannelsArray);
logUnfiredChannels(channel.deviceReadyChannelsArray);
}
}, 5000);
> deviceready event not firing with jQuery Mobile
> ---
>
> Key: CB-5488
> URL: https://issues.apache.org/jira/browse/CB-5488
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, iOS
>Affects Versions: 3.1.0
>Reporter: Federico Kereki
>
> If you use PhoneGap + jQuery + jQuery Mobile, the deviceready event doesn't
> fire. Googling around, I found several similar reports, all pointing out that
> if jQuery Mobile isn't included, the event fires.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (CB-5488) deviceready event not firing with jQuery Mobile
[
https://issues.apache.org/jira/browse/CB-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968160#comment-13968160
]
Dooms edited comment on CB-5488 at 4/14/14 8:46 AM:
An update: after a few hours more on this bug, I suspect it occurs whenever
*any* scripts take too long to load (e.g. having several scripts over 1mb in
size), whereafter cordova decides to quit its initialisation.
Changing the timeout value at the bottom has fixed some of the tests I have run
this fix on.
window.setTimeout(function() {
if (channel.onDeviceReady.state != 2) {
console.log('deviceready has not fired after 5 seconds.');
logUnfiredChannels(platformInitChannelsArray);
logUnfiredChannels(channel.deviceReadyChannelsArray);
}
}, 5000);
was (Author: dooms):
An update: after a few hours more on this bug, I suspect it occurs whenever
*any* scripts take too long to load (e.g. having several scripts over 1mb in
size), whereafter cordova decides to quit its initialisation.
> deviceready event not firing with jQuery Mobile
> ---
>
> Key: CB-5488
> URL: https://issues.apache.org/jira/browse/CB-5488
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, iOS
>Affects Versions: 3.1.0
>Reporter: Federico Kereki
>
> If you use PhoneGap + jQuery + jQuery Mobile, the deviceready event doesn't
> fire. Googling around, I found several similar reports, all pointing out that
> if jQuery Mobile isn't included, the event fires.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (CB-5488) deviceready event not firing with jQuery Mobile
[ https://issues.apache.org/jira/browse/CB-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968160#comment-13968160 ] Dooms edited comment on CB-5488 at 4/14/14 8:25 AM: An update: after a few hours more on this bug, I suspect it occurs whenever *any* scripts take too long to load (e.g. having several scripts over 1mb in size), whereafter cordova decides to quit its initialisation. was (Author: dooms): An update: after a few hours more on this bug, I suspect it occurs whenever *any* scripts take too long to load (e.g. for scripts over 1mb in size), whereafter cordova decides to quit its initialisation. > deviceready event not firing with jQuery Mobile > --- > > Key: CB-5488 > URL: https://issues.apache.org/jira/browse/CB-5488 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, iOS >Affects Versions: 3.1.0 >Reporter: Federico Kereki > > If you use PhoneGap + jQuery + jQuery Mobile, the deviceready event doesn't > fire. Googling around, I found several similar reports, all pointing out that > if jQuery Mobile isn't included, the event fires. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-5488) deviceready event not firing with jQuery Mobile
[ https://issues.apache.org/jira/browse/CB-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968160#comment-13968160 ] Dooms edited comment on CB-5488 at 4/14/14 8:24 AM: An update: after a few hours more on this bug, I suspect it occurs whenever *any* scripts take too long to load (e.g. for scripts over 1mb in size), whereafter cordova decides to quit its initialisation. was (Author: dooms): An update: after a few hours more on this bug, I suspect it occurs whenever *any* scripts take too long to load, whereafter cordova decides to quit its initialisation. > deviceready event not firing with jQuery Mobile > --- > > Key: CB-5488 > URL: https://issues.apache.org/jira/browse/CB-5488 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, iOS >Affects Versions: 3.1.0 >Reporter: Federico Kereki > > If you use PhoneGap + jQuery + jQuery Mobile, the deviceready event doesn't > fire. Googling around, I found several similar reports, all pointing out that > if jQuery Mobile isn't included, the event fires. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-5488) deviceready event not firing with jQuery Mobile
[ https://issues.apache.org/jira/browse/CB-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968160#comment-13968160 ] Dooms edited comment on CB-5488 at 4/14/14 8:19 AM: An update: after a few hours more on this bug, I suspect it occurs whenever *any* scripts take too long to load, whereafter cordova decides to quit its initialisation. was (Author: dooms): An update: after a few hours more on this bug, I suspect it occurs whenever *any* scripts take too long to load, forcing cordova to quit its initialisation. > deviceready event not firing with jQuery Mobile > --- > > Key: CB-5488 > URL: https://issues.apache.org/jira/browse/CB-5488 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, iOS >Affects Versions: 3.1.0 >Reporter: Federico Kereki > > If you use PhoneGap + jQuery + jQuery Mobile, the deviceready event doesn't > fire. Googling around, I found several similar reports, all pointing out that > if jQuery Mobile isn't included, the event fires. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5488) deviceready event not firing with jQuery Mobile
[ https://issues.apache.org/jira/browse/CB-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968160#comment-13968160 ] Dooms commented on CB-5488: --- An update: after a few hours more on this bug, I suspect it occurs whenever *any* scripts take too long to load, forcing cordova to quit its initialisation. > deviceready event not firing with jQuery Mobile > --- > > Key: CB-5488 > URL: https://issues.apache.org/jira/browse/CB-5488 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, iOS >Affects Versions: 3.1.0 >Reporter: Federico Kereki > > If you use PhoneGap + jQuery + jQuery Mobile, the deviceready event doesn't > fire. Googling around, I found several similar reports, all pointing out that > if jQuery Mobile isn't included, the event fires. -- This message was sent by Atlassian JIRA (v6.2#6252)
