[jira] [Created] (CB-6531) Can inject same code when navigating

2014-04-27 Thread Samuel Huaux (JIRA)
Samuel Huaux created CB-6531:


 Summary: Can inject same code when navigating
 Key: CB-6531
 URL: https://issues.apache.org/jira/browse/CB-6531
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin InAppBrowser
Affects Versions: 3.4.0
 Environment: windows phone 8.1
Reporter: Samuel Huaux
Priority: Critical


1. create wp8 cordova project,add InappBrowser plugin;
2. add ref.executeScript({ code: "some code"}); in iabStop(event)
3. run this project
4. the code will be injected in the first page
5. Navigate to a second page
6. the code won't be injected



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6532) cdvfile file url is not working with link tag like css

2014-04-27 Thread JIRA
Patrick Dürsteler created CB-6532:
-

 Summary: cdvfile file url is not working with link tag like css 
 Key: CB-6532
 URL: https://issues.apache.org/jira/browse/CB-6532
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, Plugin File Transfer
Affects Versions: 3.4.0
 Environment: iOS 7 
Reporter: Patrick Dürsteler
Priority: Critical


A css downloaded with xhr and created a local url 
(cdvfile://localhost/persistent/test.css) with the File API can't be used as a 
stylesheet.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6532) cdvfile file url is not working with link tag like css

2014-04-27 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/CB-6532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Dürsteler updated CB-6532:
--

Description: 
A css downloaded with xhr and created a local url 
(cdvfile://localhost/test.css) with the File API can't be used as a stylesheet.

{code}
var filename = "test.css";
var imageURL = "http://apache.org/css/style.css";;

requestFileSystem(TEMPORARY, 0, function(fileSystem) {
var ft = new FileTransfer();
ft.download(imageURL, fileSystem.root.toURL() + "/" + filename, 
function(entry) {
 var fileref=document.createElement("link");
 fileref.setAttribute("rel", "stylesheet");
 fileref.setAttribute("type", "text/css");
   fileref.setAttribute("href", entry.toURL());
document.head.appendChild(imgElement);
});
});
{code}

  was:A css downloaded with xhr and created a local url 
(cdvfile://localhost/persistent/test.css) with the File API can't be used as a 
stylesheet.


> cdvfile file url is not working with link tag like css 
> ---
>
> Key: CB-6532
> URL: https://issues.apache.org/jira/browse/CB-6532
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, Plugin File Transfer
>Affects Versions: 3.4.0
> Environment: iOS 7 
>Reporter: Patrick Dürsteler
>Priority: Critical
>
> A css downloaded with xhr and created a local url 
> (cdvfile://localhost/test.css) with the File API can't be used as a 
> stylesheet.
> {code}
> var filename = "test.css";
> var imageURL = "http://apache.org/css/style.css";;
> requestFileSystem(TEMPORARY, 0, function(fileSystem) {
> var ft = new FileTransfer();
> ft.download(imageURL, fileSystem.root.toURL() + "/" + filename, 
> function(entry) {
>  var fileref=document.createElement("link");
>  fileref.setAttribute("rel", "stylesheet");
>  fileref.setAttribute("type", "text/css");
>fileref.setAttribute("href", entry.toURL());
> document.head.appendChild(imgElement);
> });
> });
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5933) Make finding of .xcodeproj more intelligent

2014-04-27 Thread Marcos Almeida Jr (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982348#comment-13982348
 ] 

Marcos Almeida Jr commented on CB-5933:
---

Just to let you know, latest cordova 3.4.1 still have this problem. This is a 
pain when working with shared disk between O.Ses.  

> Make finding of .xcodeproj more intelligent
> ---
>
> Key: CB-5933
> URL: https://issues.apache.org/jira/browse/CB-5933
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.3.0, 3.4.0
> Environment: OSX Mavericks using non-HFS such as exFat or ntfs-3g.
>Reporter: Marcos Almeida Jr
>
> The command cordova platform add ios runs without issues, but later, using 
> cordova prepare always throws exceptions. The file missing may be an 
> AppleDouble file. 
> See below:
> {quote}
> junior-mac:atrium-corporate-tablet Marcos$ cordova prepare ios
> /usr/local/lib/node_modules/cordova/src/config_parser.js:28
> throw new Error("Parsing "+path+" failed:\n"+e.message);
>   ^
> Error: Parsing 
> /Volumes/Dados/Projects/Oficina/JoaoFortes/atrium-corporate-tablet/platforms/ios/._AtriumTablet/config.xml
>  failed:
> ENOENT, no such file or directory 
> '/Volumes/Dados/Projects/Oficina/JoaoFortes/atrium-corporate-tablet/platforms/ios/._AtriumTablet/config.xml'
> at Object.config_parser 
> (/usr/local/lib/node_modules/cordova/src/config_parser.js:28:15)
> at Object.ios_parser 
> (/usr/local/lib/node_modules/cordova/src/metadata/ios_parser.js:62:19)
> at /usr/local/lib/node_modules/cordova/src/prepare.js:56:23
> at Array.map (native)
> at CLI.prepare (/usr/local/lib/node_modules/cordova/src/prepare.js:54:35)
> at new CLI (/usr/local/lib/node_modules/cordova/src/cli.js:101:30)
> at Object. 
> (/usr/local/lib/node_modules/cordova/bin/cordova:41:16)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-5933) Make finding of .xcodeproj more intelligent

2014-04-27 Thread Marcos Almeida Jr (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcos Almeida Jr updated CB-5933:
--

Affects Version/s: 3.4.0

> Make finding of .xcodeproj more intelligent
> ---
>
> Key: CB-5933
> URL: https://issues.apache.org/jira/browse/CB-5933
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.3.0, 3.4.0
> Environment: OSX Mavericks using non-HFS such as exFat or ntfs-3g.
>Reporter: Marcos Almeida Jr
>
> The command cordova platform add ios runs without issues, but later, using 
> cordova prepare always throws exceptions. The file missing may be an 
> AppleDouble file. 
> See below:
> {quote}
> junior-mac:atrium-corporate-tablet Marcos$ cordova prepare ios
> /usr/local/lib/node_modules/cordova/src/config_parser.js:28
> throw new Error("Parsing "+path+" failed:\n"+e.message);
>   ^
> Error: Parsing 
> /Volumes/Dados/Projects/Oficina/JoaoFortes/atrium-corporate-tablet/platforms/ios/._AtriumTablet/config.xml
>  failed:
> ENOENT, no such file or directory 
> '/Volumes/Dados/Projects/Oficina/JoaoFortes/atrium-corporate-tablet/platforms/ios/._AtriumTablet/config.xml'
> at Object.config_parser 
> (/usr/local/lib/node_modules/cordova/src/config_parser.js:28:15)
> at Object.ios_parser 
> (/usr/local/lib/node_modules/cordova/src/metadata/ios_parser.js:62:19)
> at /usr/local/lib/node_modules/cordova/src/prepare.js:56:23
> at Array.map (native)
> at CLI.prepare (/usr/local/lib/node_modules/cordova/src/prepare.js:54:35)
> at new CLI (/usr/local/lib/node_modules/cordova/src/cli.js:101:30)
> at Object. 
> (/usr/local/lib/node_modules/cordova/bin/cordova:41:16)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-5933) Make finding of .xcodeproj more intelligent

2014-04-27 Thread Marcos Almeida Jr (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcos Almeida Jr updated CB-5933:
--

Labels: easyfix  (was: )

> Make finding of .xcodeproj more intelligent
> ---
>
> Key: CB-5933
> URL: https://issues.apache.org/jira/browse/CB-5933
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.3.0, 3.4.0
> Environment: OSX Mavericks using non-HFS such as exFat or ntfs-3g.
>Reporter: Marcos Almeida Jr
>  Labels: easyfix
>
> The command cordova platform add ios runs without issues, but later, using 
> cordova prepare always throws exceptions. The file missing may be an 
> AppleDouble file. 
> See below:
> {quote}
> junior-mac:atrium-corporate-tablet Marcos$ cordova prepare ios
> /usr/local/lib/node_modules/cordova/src/config_parser.js:28
> throw new Error("Parsing "+path+" failed:\n"+e.message);
>   ^
> Error: Parsing 
> /Volumes/Dados/Projects/Oficina/JoaoFortes/atrium-corporate-tablet/platforms/ios/._AtriumTablet/config.xml
>  failed:
> ENOENT, no such file or directory 
> '/Volumes/Dados/Projects/Oficina/JoaoFortes/atrium-corporate-tablet/platforms/ios/._AtriumTablet/config.xml'
> at Object.config_parser 
> (/usr/local/lib/node_modules/cordova/src/config_parser.js:28:15)
> at Object.ios_parser 
> (/usr/local/lib/node_modules/cordova/src/metadata/ios_parser.js:62:19)
> at /usr/local/lib/node_modules/cordova/src/prepare.js:56:23
> at Array.map (native)
> at CLI.prepare (/usr/local/lib/node_modules/cordova/src/prepare.js:54:35)
> at new CLI (/usr/local/lib/node_modules/cordova/src/cli.js:101:30)
> at Object. 
> (/usr/local/lib/node_modules/cordova/bin/cordova:41:16)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6517) Windows 8 navigator.camera.getPicture image file issue

2014-04-27 Thread brian johnston (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982364#comment-13982364
 ] 

brian johnston commented on CB-6517:


Windows 8 wants a URI with a single slash.  Here's the work-around for now:

 if (app.runningOnDevice('win32nt'))
callback(fileEntry.fullPath.replace('//','/'), fileName);
else
callback(fileEntry.toNativeURL(), fileName);

Also, for those of us using AngularJS, this issue was compounded by this 
AngularJS issue: 
http://stackoverflow.com/questions/23061164/windowsphone-8-and-angularjs-ng-src-not-working

> Windows 8 navigator.camera.getPicture image file issue
> --
>
> Key: CB-6517
> URL: https://issues.apache.org/jira/browse/CB-6517
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows 8
>Affects Versions: 1.9.0
>Reporter: brian johnston
>Assignee: Jesse MacFadyen
>
> I see a possible related issue was resolved (CB-2736).  Now I am not getting 
> an error from window.resolveLocalFileSystemURI, but I can find no way to 
> display the photo to the user in an HTML IMG tag.  I've tried 
> fileEntry.toNativeURL(), fileEntry.fullPath and fileEntry.toURL().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Issue Comment Deleted] (CB-6518) Unable to create directory on Windows 8

2014-04-27 Thread brian johnston (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

brian johnston updated CB-6518:
---

Comment: was deleted

(was: In other words, I need to create the directory in the documents folder 
that is visible from Windows File Explorer and move files into it and read 
files from it.  At this point I've tried to use the FileEntry object returned 
from fileSys.root.getDirectory(toFolderName,
{ create: true, exclusive: false }, but no-go with that yet.  As a work around 
I built the directory crawler app to try to crawl into the directory from the 
root of the persistent file system, but I'm stuck in the shared folder of the 
isolated storage at this point.  How can I get to the "Documents" folder so the 
user can see and use the files?)

> Unable to create directory on Windows 8
> ---
>
> Key: CB-6518
> URL: https://issues.apache.org/jira/browse/CB-6518
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows 8
>Affects Versions: 1.9.0
>Reporter: brian johnston
>Assignee: Jesse MacFadyen
>
> No error is returned from "fileSys.root.getDirectory("Foo",{ create: true, 
> exclusive: false },..".  However, the folder is not visible on the phone file 
> system.  To test I plugged the phone into my Windows 8 computer with a USB 
> cable and browsed all the visible phone folders.  The folder is not there.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6518) Unable to create directory on Windows 8

2014-04-27 Thread brian johnston (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981568#comment-13981568
 ] 

brian johnston edited comment on CB-6518 at 4/27/14 3:55 PM:
-

My bad.  You can't just browse all the Phone's directories using File Explorer. 
WP Power Tools (http://wptools.codeplex.com/) provides a nice Isolated Storage 
Browser.  Now I can see the directory and some files that were moved into to 
it.  So this bug may be resolved. 


was (Author: briankj):
My bad.  You can't just browse all the Phone's directories using File Explorer. 
WP Power Tools (http://wptools.codeplex.com/) provides a nice Isolated Storage 
Browser.  Now I can see the directory and some files that were moved into to 
it.  So this bug may be resolved.  However, I built a little test app to list 
all the directories I could from the Persistent and the Temporary file systems 
and I still could not get to the directory created.  Rather, that code lists 
out four directories, but not the one I created:

PERSISTENT folders:
shared
sharedmedia
sharedshellcontent
sharedtransfers

TEMPORARY folders:
TMP



> Unable to create directory on Windows 8
> ---
>
> Key: CB-6518
> URL: https://issues.apache.org/jira/browse/CB-6518
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows 8
>Affects Versions: 1.9.0
>Reporter: brian johnston
>Assignee: Jesse MacFadyen
>
> No error is returned from "fileSys.root.getDirectory("Foo",{ create: true, 
> exclusive: false },..".  However, the folder is not visible on the phone file 
> system.  To test I plugged the phone into my Windows 8 computer with a USB 
> cable and browsed all the visible phone folders.  The folder is not there.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Issue Comment Deleted] (CB-6518) Unable to create directory on Windows 8

2014-04-27 Thread brian johnston (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

brian johnston updated CB-6518:
---

Comment: was deleted

(was: this.moveFileByUri = function (fromFileUri, toFolderName, toFileName, 
callback) {

var me = app.log('||atsFile.moveFileByUri||');
var dbg = "::fromFileUri:{0} ::toFolderName: {1} ::toFileName:{2}";
app.log(me + dbg.format(fromFileUri, toFolderName, toFileName));

window.resolveLocalFileSystemURI(fromFileUri, resolveOnSuccess, 
resOnError);

//Callback function when the file system uri has been resolved
function resolveOnSuccess(entry) {

app.log(me + '::entry::' + entry.toURL());

window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, function 
(fileSys) {

app.log(me + '::fileSys::' + fileSys.root.toURL());

//The folder is created if doesn't exist
fileSys.root.getDirectory(toFolderName,
{ create: true, exclusive: false },
function (directory) {
app.log(me + '::directory::' + 
directory.toURL());
entry.moveTo(directory, toFileName, 
callback, resOnError);
},
resOnError);

},
resOnError);
}

function resOnError(error) {
app.logError(me + getFileErrorMessage(error));
}
})

> Unable to create directory on Windows 8
> ---
>
> Key: CB-6518
> URL: https://issues.apache.org/jira/browse/CB-6518
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows 8
>Affects Versions: 1.9.0
>Reporter: brian johnston
>Assignee: Jesse MacFadyen
>
> No error is returned from "fileSys.root.getDirectory("Foo",{ create: true, 
> exclusive: false },..".  However, the folder is not visible on the phone file 
> system.  To test I plugged the phone into my Windows 8 computer with a USB 
> cable and browsed all the visible phone folders.  The folder is not there.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Issue Comment Deleted] (CB-6518) Unable to create directory on Windows 8

2014-04-27 Thread brian johnston (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

brian johnston updated CB-6518:
---

Comment: was deleted

(was: My bad.  You can't just browse all the Phone's directories using File 
Explorer. WP Power Tools (http://wptools.codeplex.com/) provides a nice 
Isolated Storage Browser.  Now I can see the directory and some files that were 
moved into to it.  So this bug may be resolved. )

> Unable to create directory on Windows 8
> ---
>
> Key: CB-6518
> URL: https://issues.apache.org/jira/browse/CB-6518
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows 8
>Affects Versions: 1.9.0
>Reporter: brian johnston
>Assignee: Jesse MacFadyen
>
> No error is returned from "fileSys.root.getDirectory("Foo",{ create: true, 
> exclusive: false },..".  However, the folder is not visible on the phone file 
> system.  To test I plugged the phone into my Windows 8 computer with a USB 
> cable and browsed all the visible phone folders.  The folder is not there.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6518) Unable to create directory on Windows 8

2014-04-27 Thread brian johnston (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

brian johnston resolved CB-6518.


   Resolution: Fixed
Fix Version/s: 3.3.0
   3.4.0

My bad.  You can't just browse all the Phone's directories using File Explorer. 
WP Power Tools (http://wptools.codeplex.com/) provides a nice Isolated Storage 
Browser.  Now I can see the directory and some files that were moved into to 
it.  So this bug may be resolved. 

> Unable to create directory on Windows 8
> ---
>
> Key: CB-6518
> URL: https://issues.apache.org/jira/browse/CB-6518
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows 8
>Affects Versions: 1.9.0
>Reporter: brian johnston
>Assignee: Jesse MacFadyen
> Fix For: 3.4.0, 3.3.0
>
>
> No error is returned from "fileSys.root.getDirectory("Foo",{ create: true, 
> exclusive: false },..".  However, the folder is not visible on the phone file 
> system.  To test I plugged the phone into my Windows 8 computer with a USB 
> cable and browsed all the visible phone folders.  The folder is not there.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5816) FirefoxOS - add build script

2014-04-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982368#comment-13982368
 ] 

ASF GitHub Bot commented on CB-5816:


Github user Steckelfisch commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12029718
  
--- Diff: bin/lib/create.js ---
@@ -26,6 +26,7 @@ var fs = require('fs'),
 ROOT= path.join(__dirname, '..', '..'),
 check_reqs = require('./check_reqs');
 
+
--- End diff --

why check_reqs i assume.
Steven Gill has put that file there and I approached the inclusion
and test as a pattern from other platforms.


> FirefoxOS - add build script
> 
>
> Key: CB-5816
> URL: https://issues.apache.org/jira/browse/CB-5816
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: FirefoxOS
>Reporter: Axel Nennker
>
> run:  cordova build firefoxos
> output:
> Generating config.xml from defaults for platform "firefoxos"
> Preparing firefoxos project
> Compiling app on platform "firefoxos" via command 
> "/project/platforms/firefoxos/cordova/build" 
> events.js:72
> throw er; // Unhandled 'error' event
>   ^
> Error: spawn ENOENT
> at errnoException (child_process.js:980:11)
> at Process.ChildProcess._handle.onexit (child_process.js:771:34)
> project$ 
> expected output: 
> nothing
> -
> platforms/firefoxos/cordova/build does not exist so the "cordova build 
> firefoxos" command fails.
> Please add a "build" script (although it does nothing)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5816) FirefoxOS - add build script

2014-04-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982376#comment-13982376
 ] 

ASF GitHub Bot commented on CB-5816:


Github user Steckelfisch commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12029772
  
--- Diff: bin/lib/create.js ---
@@ -53,14 +54,24 @@ exports.createProject = 
function(project_path,package_name,project_name){
 
 //copy template folder
 shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'www'), 
project_path);
+
+//copy check_reqs file ,creat bin/lib if it does not exist yet
--- End diff --

It seems i was somewhat sloppy with documentation here. corrected


> FirefoxOS - add build script
> 
>
> Key: CB-5816
> URL: https://issues.apache.org/jira/browse/CB-5816
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: FirefoxOS
>Reporter: Axel Nennker
>
> run:  cordova build firefoxos
> output:
> Generating config.xml from defaults for platform "firefoxos"
> Preparing firefoxos project
> Compiling app on platform "firefoxos" via command 
> "/project/platforms/firefoxos/cordova/build" 
> events.js:72
> throw er; // Unhandled 'error' event
>   ^
> Error: spawn ENOENT
> at errnoException (child_process.js:980:11)
> at Process.ChildProcess._handle.onexit (child_process.js:771:34)
> project$ 
> expected output: 
> nothing
> -
> platforms/firefoxos/cordova/build does not exist so the "cordova build 
> firefoxos" command fails.
> Please add a "build" script (although it does nothing)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5816) FirefoxOS - add build script

2014-04-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982377#comment-13982377
 ] 

ASF GitHub Bot commented on CB-5816:


Github user Steckelfisch commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12029795
  
--- Diff: bin/lib/create.js ---
@@ -53,14 +54,24 @@ exports.createProject = 
function(project_path,package_name,project_name){
 
 //copy template folder
 shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'www'), 
project_path);
+
+//copy check_reqs file ,creat bin/lib if it does not exist yet
+if(!fs.existsSync(path.join(project_path,'cordova', 'lib'))) {
--- End diff --

check


> FirefoxOS - add build script
> 
>
> Key: CB-5816
> URL: https://issues.apache.org/jira/browse/CB-5816
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: FirefoxOS
>Reporter: Axel Nennker
>
> run:  cordova build firefoxos
> output:
> Generating config.xml from defaults for platform "firefoxos"
> Preparing firefoxos project
> Compiling app on platform "firefoxos" via command 
> "/project/platforms/firefoxos/cordova/build" 
> events.js:72
> throw er; // Unhandled 'error' event
>   ^
> Error: spawn ENOENT
> at errnoException (child_process.js:980:11)
> at Process.ChildProcess._handle.onexit (child_process.js:771:34)
> project$ 
> expected output: 
> nothing
> -
> platforms/firefoxos/cordova/build does not exist so the "cordova build 
> firefoxos" command fails.
> Please add a "build" script (although it does nothing)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6446) plugin:add grunt task only accepts a single --variable parameter

2014-04-27 Thread Sebastien (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982397#comment-13982397
 ] 

Sebastien commented on CB-6446:
---

Actually, I think this issue should be reopened, or maybe one should create a 
new one because even without using the mentioned Grunt task, passing multiple 
variables to `$ cordova plugin add` does not seem to work (latest cordova-cli).

How can one reproduce this issue:
1. Enter `$ cordova plugin add pro.fing.cordova.gapreload --variable 
SERVER_HOST="yay, host value!" --variable SERVER_PORT="yet another passed 
value"`.
2. Open *plugins/pro.fing.cordova.gapreload/gapreload.xml* and see that the 
passed SERVER_HOST config is here unlike SERVER_PORT.

> plugin:add grunt task only accepts a single --variable parameter
> 
>
> Key: CB-6446
> URL: https://issues.apache.org/jira/browse/CB-6446
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.4.0
> Environment: OSX
>Reporter: Ron James
>
> To install the facebook connect plugin, we need to pass 2 variables - 
> APP_NAME and APP_ID, e.g:
> grunt plugin:add:https://github.com/phonegap/phonegap-facebook-plugin.git 
> --variable APP_NAME=MyApp --variable APP_ID=1234123412341234
> The `variable` parameters aren't being passed through to plugman correctly so 
> the installation fails.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5816) FirefoxOS - add build script

2014-04-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982454#comment-13982454
 ] 

ASF GitHub Bot commented on CB-5816:


Github user Steckelfisch commented on a diff in the pull request:

https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12031141
  
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+ 
+var path = require('path'),
+fs = require('fs'),
+clean = require('./clean'),
+shjs = require('shelljs'),
+zip = require('adm-zip'),
+check_reqs = require('./check_reqs'),
+buildDirInMerge ='build--release';
+
+function hasMergesCustomReleaseArtifactsDir() {
+return fs.existsSync('merges/firefoxos/'+buildDirInMerge);
+}
+
+
+function hasCustomReleaseArtifactsDir() {
+return fs.existsSync('platforms/firefoxos/www/'+buildDirInMerge);
+}
+
+/**
+ * hasAllMergesRequiredCustomReleaseArtifacts()
+ * checks that merges/firefoxos/build--release is avialable and properly 
filled.
+ *
+ */
+function hasAllMergesRequiredCustomReleaseArtifacts() {
+
if(!fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/manifest.webapp')) { 
+console.error('\nPlease provide 
/merges/firefoxos/'+buildDirInMerge+'/package.manifest');
+}
+
+if(!fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/index.html')) {
+console.error('\nPlease provide 
/merges/firefoxos/'+buildDirInMerge+'/index.html');
+}
+
+return (   
fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/package.manifest')
+&& 
fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/index.html') );
+}
+
+/**
+ * hasAllRequiredCustomReleaseArtifacts()
+ * checks that 'cordova prepare' has copied merges/firefoxos to 
platforms/firefoxos/www
+ *
+ */
+function hasAllRequiredCustomReleaseArtifacts() {
+
if(!fs.existsSync('platforms/firefoxos/www/'+buildDirInMerge+'/manifest.webapp'))
 { 
+console.error('\nPlease provide 
/merges/firefoxos/'+buildDirInMerge+'/package.manifest');
--- End diff --

plus some other stuff :-(
review is nice :-)


> FirefoxOS - add build script
> 
>
> Key: CB-5816
> URL: https://issues.apache.org/jira/browse/CB-5816
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: FirefoxOS
>Reporter: Axel Nennker
>
> run:  cordova build firefoxos
> output:
> Generating config.xml from defaults for platform "firefoxos"
> Preparing firefoxos project
> Compiling app on platform "firefoxos" via command 
> "/project/platforms/firefoxos/cordova/build" 
> events.js:72
> throw er; // Unhandled 'error' event
>   ^
> Error: spawn ENOENT
> at errnoException (child_process.js:980:11)
> at Process.ChildProcess._handle.onexit (child_process.js:771:34)
> project$ 
> expected output: 
> nothing
> -
> platforms/firefoxos/cordova/build does not exist so the "cordova build 
> firefoxos" command fails.
> Please add a "build" script (although it does nothing)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6441) Plugin frameworks not always included

2014-04-27 Thread Adam George (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982774#comment-13982774
 ] 

Adam George commented on CB-6441:
-

This issue also happens if you remove the iOS platform and then re-add it in.

I.e.

cordova platform add ios
cordova plugin add com.phonegap.plugins.barcodescanner
cordova platform remove ios
cordova platform add ios

The frameworks required for barcode scanner will be missing after re-adding the 
ios platform.

Unfortunately, removing then adding the platform is something that needs to be 
done quite often with cordova.  The `cordova platform update ios` command 
doesn't do a great job, and you're often better off removing the platform and 
adding it back again.

> Plugin frameworks not always included
> -
>
> Key: CB-6441
> URL: https://issues.apache.org/jira/browse/CB-6441
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 3.4.0
> Environment: iOS
>Reporter: Dooms
>Assignee: Anis Kadri
>Priority: Minor
>
> Several plugins specify frameworks in ios (e.g. NetworkInformation requires 
> SystemConfiguration.framework). However these aren't always added 
> automatically, and must be added manually. This seems to happen especially 
> during a plugin update.



--
This message was sent by Atlassian JIRA
(v6.2#6252)