[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[
https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036846#comment-14036846
]
Jesse MacFadyen commented on CB-6571:
-
So what about doing this in `DirectoryEntry.getDirectory` ? .. or
DirectoryEntry constructor?
{code}
var win = successCallback && function (result) {
var fullPath = result.fullPath;
// add trailing slash if it is missing
if (!/\/$/.test(fullPath)) {
fullPath += "/";
}
var nativeURL = result.nativeURL;
// add trailing slash if it is missing
if (!/\/$/.test(nativeURL)) {
nativeURL += "/";
}
var entry = new DirectoryEntry(result.name, fullPath, fs, nativeURL);
successCallback(entry);
};
{code}
Then it would be fixed everywhere ...
> DirectoryEntry.toURL() has a trailing slash on iOS but not Android
> --
>
> Key: CB-6571
> URL: https://issues.apache.org/jira/browse/CB-6571
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> We should be consistent with this and always have directories end with at /.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools
[ https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036847#comment-14036847 ] ASF subversion and git services commented on CB-6973: - Commit 5e4f8655cb265e4119b9ec9386988bfbadd0399c in cordova-lib's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=5e4f865 ] CB-6973: Fix more JSHint errors > Use JSHint in Cordova CLI tools > --- > > Key: CB-6973 > URL: https://issues.apache.org/jira/browse/CB-6973 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036821#comment-14036821 ] Andrew Grieve commented on CB-6571: --- Not sure if there's a spec or not. Interestingly, the root of the issue is that NSURL appends / on iOS, and Uri on Android doesn't. Having the trailing slash adds more information about the file:// URL, so I went with that. I added a mobilespec test so that if other platforms differed from this it would be pointed out by the autotests. > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036823#comment-14036823 ] Andrew Grieve commented on CB-6571: --- Also - tested that Chrome's html5 FS uses trailing slashes, so it's consistent there as well. > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036789#comment-14036789 ] ASF GitHub Bot commented on CB-6542: Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46514286 Ok, all merged :) > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Reopened] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen reopened CB-6571: - > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036788#comment-14036788 ] Jesse MacFadyen commented on CB-6571: - is this part of a spec somewhere? Seemingly small changes like this have an effect on platforms other than iOS and Android, and it is very difficult to keep up with the multitude of minor incremental changes sometimes. I am surprised that this is considered resolved. > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6928) Wrong behaviour transferring cacheable content
[ https://issues.apache.org/jira/browse/CB-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036771#comment-14036771 ] ASF GitHub Bot commented on CB-6928: GitHub user jpuerto opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/71 CB-6928: Add 304 response test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpuerto/cordova-mobile-spec master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit 4f78beb5c55e5d02a0abc589db116e24220d52b2 Author: Javier Puerto Date: 2014-06-19T00:59:22Z CB-6928: Add 304 response test > Wrong behaviour transferring cacheable content > -- > > Key: CB-6928 > URL: https://issues.apache.org/jira/browse/CB-6928 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 3.5.0 >Reporter: Javier Puerto >Priority: Minor > Attachments: CB-6928.diff > > > Use case: > Transfer resources from server to the device. To avoid unnecessary use of the > device bandwidth, the resources that exists already are checked with the > "If-Modified-Since" header so server can return 304 status code and update > just in case that is needed. > Result for Android test: > The plugin doesn't care about the status code, if the request is success, > open the InputStream and copy the content to the file. The problem is that a > HTTP status of 304 has no response and that leads to a corrupted file > transfer. > Fix: > If status code is 304, doesn't makes sense to process the InputStream. Read > the status code after connection and if it's 304, skip the copy process and > return the file entity like a success transfer. > I've tested for Android only. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6928) Wrong behaviour transferring cacheable content
[ https://issues.apache.org/jira/browse/CB-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036743#comment-14036743 ] ASF GitHub Bot commented on CB-6928: GitHub user jpuerto opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/32 CB-6928: Implements NOT_MODIFIED check downloading resources. Introduce FileTransferError.NOT_MODIFIED_ERR, execute error callback for 304 status code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpuerto/cordova-plugin-file-transfer pull-request Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 369e6170605b5db99a6a568174078f185d31ca0c Author: Javier Puerto Date: 2014-06-12T08:34:42Z CB-6928: Open output stream only if it's necessary. commit 5a834df72ff690e8d6a6d58b7c7df1aa448edbb4 Author: Javier Puerto Date: 2014-06-19T00:20:51Z CB-6928: Handle 304 status code > Wrong behaviour transferring cacheable content > -- > > Key: CB-6928 > URL: https://issues.apache.org/jira/browse/CB-6928 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 3.5.0 >Reporter: Javier Puerto >Priority: Minor > Attachments: CB-6928.diff > > > Use case: > Transfer resources from server to the device. To avoid unnecessary use of the > device bandwidth, the resources that exists already are checked with the > "If-Modified-Since" header so server can return 304 status code and update > just in case that is needed. > Result for Android test: > The plugin doesn't care about the status code, if the request is success, > open the InputStream and copy the content to the file. The problem is that a > HTTP status of 304 has no response and that leads to a corrupted file > transfer. > Fix: > If status code is 304, doesn't makes sense to process the InputStream. Read > the status code after connection and if it's 304, skip the copy process and > return the file entity like a success transfer. > I've tested for Android only. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6884) Support new Cordova bridge under iOS 8 WKWebView
[
https://issues.apache.org/jira/browse/CB-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah updated CB-6884:
-
Description:
https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
WKUserContentController - add a script message handler with name "cordova":
https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
The WKUserContentController is associated with a WKWebViewConfiguration which
is initialized with a WKWebView.
{code}
WKUserContentController* userContentController = [[WKUserContentController
alloc] init];
// scriptMessageHandler is the object that conforms to the
WKScriptMessageHandler protocol
// see
https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
[userContentController addScriptMessageHandler:scriptMessageHandler
name:@"cordova"];
{code}
In JavaScript, you would call into Objective-C thus:
{code}
var command = { callbackId: "blabla23", service:"Camera", action:
"takePicture", actionArgs: [ 1, 2, 3 ] };
window.webkit.messageHandlers.cordova.postMessage(command);
{code}
In the object that conforms to the WKScriptMessageHandler protocol:
{code}
- (void)userContentController:(WKUserContentController *)userContentController
didReceiveScriptMessage:(WKScriptMessage *)message
{
if (![message.name isEqualToString:@"cordova"]) {
return;
}
NSDictionary* command = message.body;
// TODO: get the callbackId, service, action, actionArgs keys and create a
CDVInvokedUrlCommand, and dispatch it
}
{code}
was:
https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
WKUserContentController - add a script message handler with name "cordova":
https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
The WKUserContentController is associated with a WKWebViewConfiguration which
is initialized with a WKWebView.
{code}
WKUserContentController userContentController = [[WKUserContentController
alloc] init];
// scriptMessageHandler is the object that conforms to the
WKScriptMessageHandler protocol
// see
https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
[userContentController addScriptMessageHandler:scriptMessageHandler
name:@"cordova"];
{code}
In JavaScript, you would call into Objective-C thus:
{code}
var command = { callbackId: "blabla23", service:"Camera", action:
"takePicture", actionArgs: [ 1, 2, 3 ] };
window.webkit.messageHandlers.cordova.postMessage(command);
{code}
In the object that conforms to the WKScriptMessageHandler protocol:
{code}
- (void)userContentController:(WKUserContentController *)userContentController
didReceiveScriptMessage:(WKScriptMessage *)message
{
if (![message.name isEqualToString:@"cordova"]) {
return;
}
NSDictionary* command = message.body;
// TODO: get the callbackId, service, action, actionArgs keys and create a
CDVInvokedUrlCommand, and dispatch it
}
{code}
> Support new Cordova bridge under iOS 8 WKWebView
>
>
> Key: CB-6884
> URL: https://issues.apache.org/jira/browse/CB-6884
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, iOS
> Environment: iOS 8 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.6.0
>
>
> https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
> WKUserContentController - add a script message handler with name "cordova":
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
> The WKUserContentController is associated with a WKWebViewConfiguration which
> is initialized with a WKWebView.
> {code}
> WKUserContentController* userContentController = [[WKUserContentController
> alloc] init];
> // scriptMessageHandler is the object that conforms to the
> WKScriptMessageHandler protocol
> // see
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
> [userContentController addScriptMessageHandler:scriptMessageHandler
> name:@"cordova"];
> {code}
> In JavaScript, you would call into Objective-C thus:
> {code}
> var command = { callbackId: "blabla23", service:"Camera", action:
> "takePicture", actionArgs: [ 1, 2, 3
[jira] [Commented] (CB-6884) Support new Cordova bridge under iOS 8 WKWebView
[
https://issues.apache.org/jira/browse/CB-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036724#comment-14036724
]
Shazron Abdullah commented on CB-6884:
--
http://trac.webkit.org/changeset/169696
[WKWebView loadHTMLString:baseURL]
> Support new Cordova bridge under iOS 8 WKWebView
>
>
> Key: CB-6884
> URL: https://issues.apache.org/jira/browse/CB-6884
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, iOS
> Environment: iOS 8 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.6.0
>
>
> https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
> WKUserContentController - add a script message handler with name "cordova":
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
> The WKUserContentController is associated with a WKWebViewConfiguration which
> is initialized with a WKWebView.
> {code}
> WKUserContentController userContentController = [[WKUserContentController
> alloc] init];
> // scriptMessageHandler is the object that conforms to the
> WKScriptMessageHandler protocol
> // see
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
> [userContentController addScriptMessageHandler:scriptMessageHandler
> name:@"cordova"];
> {code}
> In JavaScript, you would call into Objective-C thus:
> {code}
> var command = { callbackId: "blabla23", service:"Camera", action:
> "takePicture", actionArgs: [ 1, 2, 3 ] };
> window.webkit.messageHandlers.cordova.postMessage(command);
> {code}
> In the object that conforms to the WKScriptMessageHandler protocol:
> {code}
> - (void)userContentController:(WKUserContentController
> *)userContentController didReceiveScriptMessage:(WKScriptMessage *)message
> {
> if (![message.name isEqualToString:@"cordova"]) {
> return;
> }
> NSDictionary* command = message.body;
> // TODO: get the callbackId, service, action, actionArgs keys and create
> a CDVInvokedUrlCommand, and dispatch it
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-3571) Add support for elements in config.xml
[
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036631#comment-14036631
]
ASF GitHub Bot commented on CB-3571:
Github user surajpindoria commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46506676
Can you add some tests for this.
> Add support for elements in config.xml
> ---
>
> Key: CB-3571
> URL: https://issues.apache.org/jira/browse/CB-3571
> Project: Apache Cordova
> Issue Type: Wish
> Components: CLI
>Affects Versions: Master
>Reporter: Michael Brooks
>Assignee: Mark Koudritsky
>
> Similar to adding support for the {{}} element, we should add support
> for the splash screen.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6540) Error for creating a project inside its template is confusing
[
https://issues.apache.org/jira/browse/CB-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036571#comment-14036571
]
ASF subversion and git services commented on CB-6540:
-
Commit f7f92e83154d5ae06fb692f2821893a84bc7f595 in cordova-lib's branch
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f7f92e8 ]
CB-6540 Rephrase Error msg for creating a project inside its template
github: close #35
> Error for creating a project inside its template is confusing
> -
>
> Key: CB-6540
> URL: https://issues.apache.org/jira/browse/CB-6540
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> If you pass the right magic template to cli.create:
> {quote}
> options = \{ id: id, name: name, lib: \{} };
> options.lib.www = \{id: 'custom', version: '0', uri: path.resolve(template)}}
> cordova.create(dir, null, null, options, function (err) {});
> {quote}
> You end up reaching this code path:
> {quote}
> if ( www_dir.indexOf(path.resolve(config_json.lib.www.uri)) === 0 ) \{
> throw new CordovaError(
> 'Project must not be created inside the www assets dir.' +
> '\nproject dir:\t' + dir +
> '\nwww assets dir:\t' + config_json.lib.www.uri
> );
> }
> {quote}
> The output is:
> {quote}
> \{ name: 'CordovaError',
> message: 'Project must not be created inside the www assets dir.\n
> project dir:\t/private/tmp/null/y\nwww assets dir:\t/private/tmp/null' }
> {quote}
> Amongst the many problems:
> 1. The \n's and \t's aren't actually being converted into newlines and tabs
> 2. The message is absolutely incomprehensible (even if it wasn't garbled up
> by the encoded whitespace).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6540) Error for creating a project inside its template is confusing
[
https://issues.apache.org/jira/browse/CB-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036572#comment-14036572
]
ASF GitHub Bot commented on CB-6540:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/35
> Error for creating a project inside its template is confusing
> -
>
> Key: CB-6540
> URL: https://issues.apache.org/jira/browse/CB-6540
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> If you pass the right magic template to cli.create:
> {quote}
> options = \{ id: id, name: name, lib: \{} };
> options.lib.www = \{id: 'custom', version: '0', uri: path.resolve(template)}}
> cordova.create(dir, null, null, options, function (err) {});
> {quote}
> You end up reaching this code path:
> {quote}
> if ( www_dir.indexOf(path.resolve(config_json.lib.www.uri)) === 0 ) \{
> throw new CordovaError(
> 'Project must not be created inside the www assets dir.' +
> '\nproject dir:\t' + dir +
> '\nwww assets dir:\t' + config_json.lib.www.uri
> );
> }
> {quote}
> The output is:
> {quote}
> \{ name: 'CordovaError',
> message: 'Project must not be created inside the www assets dir.\n
> project dir:\t/private/tmp/null/y\nwww assets dir:\t/private/tmp/null' }
> {quote}
> Amongst the many problems:
> 1. The \n's and \t's aren't actually being converted into newlines and tabs
> 2. The message is absolutely incomprehensible (even if it wasn't garbled up
> by the encoded whitespace).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036549#comment-14036549 ] ASF GitHub Bot commented on CB-6542: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46502577 @kamrik : can you please merge these things in cordova-lib so that they don't sit around lost? :) > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6537) Consistently indicate `cordova ...` in errors
[ https://issues.apache.org/jira/browse/CB-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036544#comment-14036544 ] ASF GitHub Bot commented on CB-6537: Github user jsoref closed the pull request at: https://github.com/apache/cordova-cli/pull/172 > Consistently indicate `cordova ...` in errors > - > > Key: CB-6537 > URL: https://issues.apache.org/jira/browse/CB-6537 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref >Priority: Minor > > Good: > $ cordova build > No platforms added to this project. Please use `cordova platform add > `. > Bad: > $ cordova platform add fio > Platform "fio" not recognized as a core cordova platform. See "platform list". > $ cordova jlhjk > Cordova does not know jlhjk; try help for a list of all the available > commands. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6537) Consistently indicate `cordova ...` in errors
[ https://issues.apache.org/jira/browse/CB-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036543#comment-14036543 ] ASF GitHub Bot commented on CB-6537: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/172#issuecomment-46502217 Integrated as https://github.com/apache/cordova-lib/pull/20 > Consistently indicate `cordova ...` in errors > - > > Key: CB-6537 > URL: https://issues.apache.org/jira/browse/CB-6537 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref >Priority: Minor > > Good: > $ cordova build > No platforms added to this project. Please use `cordova platform add > `. > Bad: > $ cordova platform add fio > Platform "fio" not recognized as a core cordova platform. See "platform list". > $ cordova jlhjk > Cordova does not know jlhjk; try help for a list of all the available > commands. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036538#comment-14036538 ] ASF GitHub Bot commented on CB-6542: Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46502024 Thanks! > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6540) Error for creating a project inside its template is confusing
[
https://issues.apache.org/jira/browse/CB-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036532#comment-14036532
]
ASF GitHub Bot commented on CB-6540:
Github user jsoref closed the pull request at:
https://github.com/apache/cordova-cli/pull/173
> Error for creating a project inside its template is confusing
> -
>
> Key: CB-6540
> URL: https://issues.apache.org/jira/browse/CB-6540
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> If you pass the right magic template to cli.create:
> {quote}
> options = \{ id: id, name: name, lib: \{} };
> options.lib.www = \{id: 'custom', version: '0', uri: path.resolve(template)}}
> cordova.create(dir, null, null, options, function (err) {});
> {quote}
> You end up reaching this code path:
> {quote}
> if ( www_dir.indexOf(path.resolve(config_json.lib.www.uri)) === 0 ) \{
> throw new CordovaError(
> 'Project must not be created inside the www assets dir.' +
> '\nproject dir:\t' + dir +
> '\nwww assets dir:\t' + config_json.lib.www.uri
> );
> }
> {quote}
> The output is:
> {quote}
> \{ name: 'CordovaError',
> message: 'Project must not be created inside the www assets dir.\n
> project dir:\t/private/tmp/null/y\nwww assets dir:\t/private/tmp/null' }
> {quote}
> Amongst the many problems:
> 1. The \n's and \t's aren't actually being converted into newlines and tabs
> 2. The message is absolutely incomprehensible (even if it wasn't garbled up
> by the encoded whitespace).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6415) BlackBerry10 was not looking for itself in the right place if you used a .cordova/config.json file
[
https://issues.apache.org/jira/browse/CB-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036533#comment-14036533
]
ASF GitHub Bot commented on CB-6415:
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-cli/pull/162#issuecomment-46501910
Migrated to https://github.com/apache/cordova-lib/pull/9
> BlackBerry10 was not looking for itself in the right place if you used a
> .cordova/config.json file
> --
>
> Key: CB-6415
> URL: https://issues.apache.org/jira/browse/CB-6415
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
> Environment: Windows 7, Native development environment for
> blackberry10 properly configured.
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry10, cli
> Fix For: 3.5.0
>
>
> Working on some tests, for a new node module for cordova, I've found a
> problem when I try to work with custom libraries, this problem only applies
> to Blackberry, it doesn't resolve correctly a uri path in a config.json file,
> My configuration in the project:
> .cordova/config.json >
> {
> "id": "org.apache.cordova",
> "name": "mobilespec",
> "lib": {
> "blackberry10": {
> "uri": "C:\\Users\\Administrator\\cordova-blackberry"
> },
> "wp8": {
> "uri": "C:\\Users\\Administrator\\cordova-coho\\cordova-wp8"
> },
> "windows8": {
> "uri": "C:\\Users\\Administrator\\cordova-coho\\cordova-windows"
> }
> }
> }
> The problem is that it never resolves the path, with the folder that contains
> blackberry10 library, which is inside of cordova-blackberry.
> When I try to add the full path to the project:
> "blackberry10":{"uri":"C:\\Users\\Administrator\\cordova-coho\\cordova-blackberry\\blackberry10"}
> It pass the requirements check, but when it produce an error at running the
> command to add the project at superspawn.js.
> What's happening here is, that it pass the requirements check, but when it
> try to use the library use is trying to use this path:
> C:\\Users\\Administrator\\cord
> ova-blackberry\\blackberry10\\blackberry10\\bin\\create
> So the usage path is obtained trying to look for 'blackberry10', under
> 'cordova-blackberry', and the requirements check requires the whole path:
> "blackberry10":{"uri":"C:\\Users\\Administrator\\cordova-coho\\cordova-blackberry\\blackberry10"}
> According to my trace, the requirements check it should resolve the path
> correctly, looking under 'cordova-blackberry'.
> I'll assign this to me, I have a simple solution for it when custom paths are
> used.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036537#comment-14036537 ] ASF GitHub Bot commented on CB-6542: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/34 > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6540) Error for creating a project inside its template is confusing
[
https://issues.apache.org/jira/browse/CB-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036530#comment-14036530
]
ASF GitHub Bot commented on CB-6540:
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-lib/pull/35
CB-6540 Error for creating a project inside its template is confusing
From https://github.com/apache/cordova-cli/pull/173
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-lib cb_6540
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
commit 7a41b67807a7f9ae404a8e8a219affe0a9705422
Author: Josh Soref
Date: 2014-06-18T22:17:19Z
CB-6540 Error for creating a project inside its template is confusing
> Error for creating a project inside its template is confusing
> -
>
> Key: CB-6540
> URL: https://issues.apache.org/jira/browse/CB-6540
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> If you pass the right magic template to cli.create:
> {quote}
> options = \{ id: id, name: name, lib: \{} };
> options.lib.www = \{id: 'custom', version: '0', uri: path.resolve(template)}}
> cordova.create(dir, null, null, options, function (err) {});
> {quote}
> You end up reaching this code path:
> {quote}
> if ( www_dir.indexOf(path.resolve(config_json.lib.www.uri)) === 0 ) \{
> throw new CordovaError(
> 'Project must not be created inside the www assets dir.' +
> '\nproject dir:\t' + dir +
> '\nwww assets dir:\t' + config_json.lib.www.uri
> );
> }
> {quote}
> The output is:
> {quote}
> \{ name: 'CordovaError',
> message: 'Project must not be created inside the www assets dir.\n
> project dir:\t/private/tmp/null/y\nwww assets dir:\t/private/tmp/null' }
> {quote}
> Amongst the many problems:
> 1. The \n's and \t's aren't actually being converted into newlines and tabs
> 2. The message is absolutely incomprehensible (even if it wasn't garbled up
> by the encoded whitespace).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036535#comment-14036535 ] ASF subversion and git services commented on CB-6542: - Commit ba59ae9c9fb20c72b9bd76c4b277cf2a8c64258f in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=ba59ae9 ] CB-6542: Delay creating project until there's some chance that it will succeed github: close #34 > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6415) BlackBerry10 was not looking for itself in the right place if you used a .cordova/config.json file
[
https://issues.apache.org/jira/browse/CB-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036534#comment-14036534
]
ASF GitHub Bot commented on CB-6415:
Github user jsoref closed the pull request at:
https://github.com/apache/cordova-cli/pull/162
> BlackBerry10 was not looking for itself in the right place if you used a
> .cordova/config.json file
> --
>
> Key: CB-6415
> URL: https://issues.apache.org/jira/browse/CB-6415
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 3.4.0
> Environment: Windows 7, Native development environment for
> blackberry10 properly configured.
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: blackberry10, cli
> Fix For: 3.5.0
>
>
> Working on some tests, for a new node module for cordova, I've found a
> problem when I try to work with custom libraries, this problem only applies
> to Blackberry, it doesn't resolve correctly a uri path in a config.json file,
> My configuration in the project:
> .cordova/config.json >
> {
> "id": "org.apache.cordova",
> "name": "mobilespec",
> "lib": {
> "blackberry10": {
> "uri": "C:\\Users\\Administrator\\cordova-blackberry"
> },
> "wp8": {
> "uri": "C:\\Users\\Administrator\\cordova-coho\\cordova-wp8"
> },
> "windows8": {
> "uri": "C:\\Users\\Administrator\\cordova-coho\\cordova-windows"
> }
> }
> }
> The problem is that it never resolves the path, with the folder that contains
> blackberry10 library, which is inside of cordova-blackberry.
> When I try to add the full path to the project:
> "blackberry10":{"uri":"C:\\Users\\Administrator\\cordova-coho\\cordova-blackberry\\blackberry10"}
> It pass the requirements check, but when it produce an error at running the
> command to add the project at superspawn.js.
> What's happening here is, that it pass the requirements check, but when it
> try to use the library use is trying to use this path:
> C:\\Users\\Administrator\\cord
> ova-blackberry\\blackberry10\\blackberry10\\bin\\create
> So the usage path is obtained trying to look for 'blackberry10', under
> 'cordova-blackberry', and the requirements check requires the whole path:
> "blackberry10":{"uri":"C:\\Users\\Administrator\\cordova-coho\\cordova-blackberry\\blackberry10"}
> According to my trace, the requirements check it should resolve the path
> correctly, looking under 'cordova-blackberry'.
> I'll assign this to me, I have a simple solution for it when custom paths are
> used.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036520#comment-14036520 ] ASF GitHub Bot commented on CB-6542: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46501511 https://github.com/apache/cordova-lib/pull/34 > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036523#comment-14036523 ] ASF GitHub Bot commented on CB-6542: Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/34#issuecomment-46501549 Migrated from https://github.com/apache/cordova-cli/pull/174 > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036521#comment-14036521 ] ASF GitHub Bot commented on CB-6542: Github user jsoref closed the pull request at: https://github.com/apache/cordova-cli/pull/174 > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036516#comment-14036516 ] ASF GitHub Bot commented on CB-6542: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/34 CB-6542 Delay creating project until there's some chance that it will su... ...cceed You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_6542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit bf8e4158ec2a2810fd51c101ec5b50fcdf2dce05 Author: Josh Soref Date: 2014-06-18T22:13:23Z CB-6542 Delay creating project until there's some chance that it will succeed > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036506#comment-14036506 ] ASF GitHub Bot commented on CB-6542: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46501065 Probably... > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6968) fix bashism (source) in update script and bb10-ndk-version
[ https://issues.apache.org/jira/browse/CB-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036502#comment-14036502 ] ASF GitHub Bot commented on CB-6968: Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/163 > fix bashism (source) in update script and bb10-ndk-version > -- > > Key: CB-6968 > URL: https://issues.apache.org/jira/browse/CB-6968 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Reporter: Josh Soref >Assignee: Josh Soref > > Ubuntu/Debian use dash as sh, not bash, which causes bashisms to be a problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6934) cordova run blackberry --target withno_ip_nor_password should complain about ip not password
[
https://issues.apache.org/jira/browse/CB-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036501#comment-14036501
]
ASF GitHub Bot commented on CB-6934:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/162
> cordova run blackberry --target withno_ip_nor_password should complain about
> ip not password
>
>
> Key: CB-6934
> URL: https://issues.apache.org/jira/browse/CB-6934
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> $ cordova run --target aa --no-query
> Running command: /tmp/xb/platforms/blackberry10/cordova/run --target aa
> --no-query
> No device password provided. You can omit --no-query, use --devicepass, or
> enter a value for 'password' to the target aa defined at
> ~/.cordova/blackberry10.json
> Here's that section:
> "aa": {
> "type": "device"
> },
> The error code wanted to complain about the IP field (it's first, and it's
> set, but it's stomped on).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6934) cordova run blackberry --target withno_ip_nor_password should complain about ip not password
[
https://issues.apache.org/jira/browse/CB-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036499#comment-14036499
]
ASF subversion and git services commented on CB-6934:
-
Commit cf04d7c045bb0565d9321339ecf67cdcf7552d1f in cordova-blackberry's branch
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=cf04d7c ]
CB-6934 run should complain about target w/o ip before password
> cordova run blackberry --target withno_ip_nor_password should complain about
> ip not password
>
>
> Key: CB-6934
> URL: https://issues.apache.org/jira/browse/CB-6934
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> $ cordova run --target aa --no-query
> Running command: /tmp/xb/platforms/blackberry10/cordova/run --target aa
> --no-query
> No device password provided. You can omit --no-query, use --devicepass, or
> enter a value for 'password' to the target aa defined at
> ~/.cordova/blackberry10.json
> Here's that section:
> "aa": {
> "type": "device"
> },
> The error code wanted to complain about the IP field (it's first, and it's
> set, but it's stomped on).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6968) fix bashism (source) in update script and bb10-ndk-version
[ https://issues.apache.org/jira/browse/CB-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036500#comment-14036500 ] ASF subversion and git services commented on CB-6968: - Commit 002c04561d7e7e12a23d81f3b94bb72b1f9c016b in cordova-blackberry's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=002c045 ] CB-6968 fix bashism (source) in update script and bb10-ndk-version > fix bashism (source) in update script and bb10-ndk-version > -- > > Key: CB-6968 > URL: https://issues.apache.org/jira/browse/CB-6968 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Reporter: Josh Soref >Assignee: Josh Soref > > Ubuntu/Debian use dash as sh, not bash, which causes bashisms to be a problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6542) Delay creating project until there's some chance that it will succeed
[ https://issues.apache.org/jira/browse/CB-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036484#comment-14036484 ] ASF GitHub Bot commented on CB-6542: Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46500400 @jsoref, is this still relevant? If yes, could you please rebase it onto cordova-lib. Thanks. > Delay creating project until there's some chance that it will succeed > - > > Key: CB-6542 > URL: https://issues.apache.org/jira/browse/CB-6542 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Right now, it's very easy to try to create a project, receive an error, and > as a result have a seemingly empty project directory which will refuse to be > used if you want to fix the arguments to create. > This is more or less because we eagerly create the .cordova/config.json file > instead of lazily creating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6756) Restore Platforms from config.xml
[ https://issues.apache.org/jira/browse/CB-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036478#comment-14036478 ] ASF GitHub Bot commented on CB-6756: Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/18#issuecomment-46500220 My bad. this is restore platforms.. Restore plugins is already merged. > Restore Platforms from config.xml > - > > Key: CB-6756 > URL: https://issues.apache.org/jira/browse/CB-6756 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI >Affects Versions: 3.4.0 >Reporter: Gorkem ERCAN >Assignee: Gorkem ERCAN > > save platforms command should record the currently installed platforms on a > project to config.xml > restore platforms should restore them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6756) Restore Platforms from config.xml
[ https://issues.apache.org/jira/browse/CB-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036475#comment-14036475 ] ASF GitHub Bot commented on CB-6756: GitHub user gorkem reopened a pull request: https://github.com/apache/cordova-lib/pull/18 CB-6756 Initial implementation for the save and restore platforms command Adds implementation of the save and restore command for platforms. It also enhances the ConfigParser to support engine elements and cordova namespace. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gorkem/cordova-lib restore-platforms Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit a829dafb56c0543b0ffdfab8e2e1914d57a2917c Author: Gorkem Ercan Date: 2014-05-25T23:11:57Z Initial implementation for the restore platforms command Adds implementation of the save and restore command for platforms. It also enhances the ConfigParser to support engine elements and cordova namespace. > Restore Platforms from config.xml > - > > Key: CB-6756 > URL: https://issues.apache.org/jira/browse/CB-6756 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI >Affects Versions: 3.4.0 >Reporter: Gorkem ERCAN >Assignee: Gorkem ERCAN > > save platforms command should record the currently installed platforms on a > project to config.xml > restore platforms should restore them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6756) Restore Platforms from config.xml
[ https://issues.apache.org/jira/browse/CB-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036463#comment-14036463 ] ASF GitHub Bot commented on CB-6756: Github user gorkem closed the pull request at: https://github.com/apache/cordova-lib/pull/18 > Restore Platforms from config.xml > - > > Key: CB-6756 > URL: https://issues.apache.org/jira/browse/CB-6756 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI >Affects Versions: 3.4.0 >Reporter: Gorkem ERCAN >Assignee: Gorkem ERCAN > > save platforms command should record the currently installed platforms on a > project to config.xml > restore platforms should restore them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6756) Restore Platforms from config.xml
[ https://issues.apache.org/jira/browse/CB-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036462#comment-14036462 ] ASF GitHub Bot commented on CB-6756: Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/18#issuecomment-46499679 closing as merged > Restore Platforms from config.xml > - > > Key: CB-6756 > URL: https://issues.apache.org/jira/browse/CB-6756 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI >Affects Versions: 3.4.0 >Reporter: Gorkem ERCAN >Assignee: Gorkem ERCAN > > save platforms command should record the currently installed platforms on a > project to config.xml > restore platforms should restore them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6756) Restore Platforms from config.xml
[ https://issues.apache.org/jira/browse/CB-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036457#comment-14036457 ] ASF GitHub Bot commented on CB-6756: Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/178#issuecomment-46499213 Hi @gorkem, looks like this functionality was already merged. Is this correct? If yes, could you please close the pull request. Same question for https://github.com/apache/cordova-lib/pull/18 Thanks. > Restore Platforms from config.xml > - > > Key: CB-6756 > URL: https://issues.apache.org/jira/browse/CB-6756 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI >Affects Versions: 3.4.0 >Reporter: Gorkem ERCAN >Assignee: Gorkem ERCAN > > save platforms command should record the currently installed platforms on a > project to config.xml > restore platforms should restore them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6960) Port compass tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036418#comment-14036418 ] Samir Silva commented on CB-6960: - I'll be working on this > Port compass tests to plugin-test-framework > --- > > Key: CB-6960 > URL: https://issues.apache.org/jira/browse/CB-6960 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Orientation >Reporter: Staci Cooper >Assignee: Staci Cooper >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6957) Battery tests need to be ported to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036415#comment-14036415 ] Samir Silva commented on CB-6957: - I'll be working on this > Battery tests need to be ported to plugin-test-framework > > > Key: CB-6957 > URL: https://issues.apache.org/jira/browse/CB-6957 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Battery Status >Reporter: Staci Cooper >Assignee: Staci Cooper > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6970) Share win project files manipulation code between cordova and plugman
[ https://issues.apache.org/jira/browse/CB-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036416#comment-14036416 ] ASF GitHub Bot commented on CB-6970: Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/32#issuecomment-46496437 Thanks! This looks much cleaner. > Share win project files manipulation code between cordova and plugman > - > > Key: CB-6970 > URL: https://issues.apache.org/jira/browse/CB-6970 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib, Windows 8, WP8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > Labels: cordova-lib, windows8, wp8 > > Both cordova and plugman use own logic to parse and modify jsproj and csproj > files, for example (cordova) windows8_parser/update_jsproj and (plugman) > w8jsproj.js/removeSourceFile use exactly the same code blocks to parse and > update jsproj files. > It is better to remove duplicate code and have special shared classes to work > with project files. Cordova and plugman should rely on those classes instead > of using own implementation. > We should also remove manual project files manipulation logic from general > cordova/plugman classes, like below. > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/prepare.js#L83 > Implementation layer should be hidden from them, they just need to rely on > special well named methods provided by newly introduced classes (see above). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6970) Share win project files manipulation code between cordova and plugman
[ https://issues.apache.org/jira/browse/CB-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036411#comment-14036411 ] ASF subversion and git services commented on CB-6970: - Commit f802efd1ea46644a5035f1f7f8891a088635af73 in cordova-lib's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f802efd ] CB-6970 Share win project files manipulation code between cordova and plugman github: close #32 > Share win project files manipulation code between cordova and plugman > - > > Key: CB-6970 > URL: https://issues.apache.org/jira/browse/CB-6970 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib, Windows 8, WP8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > Labels: cordova-lib, windows8, wp8 > > Both cordova and plugman use own logic to parse and modify jsproj and csproj > files, for example (cordova) windows8_parser/update_jsproj and (plugman) > w8jsproj.js/removeSourceFile use exactly the same code blocks to parse and > update jsproj files. > It is better to remove duplicate code and have special shared classes to work > with project files. Cordova and plugman should rely on those classes instead > of using own implementation. > We should also remove manual project files manipulation logic from general > cordova/plugman classes, like below. > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/prepare.js#L83 > Implementation layer should be hidden from them, they just need to rely on > special well named methods provided by newly introduced classes (see above). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6970) Share win project files manipulation code between cordova and plugman
[ https://issues.apache.org/jira/browse/CB-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036412#comment-14036412 ] ASF GitHub Bot commented on CB-6970: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/32 > Share win project files manipulation code between cordova and plugman > - > > Key: CB-6970 > URL: https://issues.apache.org/jira/browse/CB-6970 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib, Windows 8, WP8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > Labels: cordova-lib, windows8, wp8 > > Both cordova and plugman use own logic to parse and modify jsproj and csproj > files, for example (cordova) windows8_parser/update_jsproj and (plugman) > w8jsproj.js/removeSourceFile use exactly the same code blocks to parse and > update jsproj files. > It is better to remove duplicate code and have special shared classes to work > with project files. Cordova and plugman should rely on those classes instead > of using own implementation. > We should also remove manual project files manipulation logic from general > cordova/plugman classes, like below. > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/prepare.js#L83 > Implementation layer should be hidden from them, they just need to rely on > special well named methods provided by newly introduced classes (see above). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6089) Can not add device plugin when platform firefoxos present
[ https://issues.apache.org/jira/browse/CB-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zalewa resolved CB-6089. -- Resolution: Fixed It is working, I assume it was fixed > Can not add device plugin when platform firefoxos present > - > > Key: CB-6089 > URL: https://issues.apache.org/jira/browse/CB-6089 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, FirefoxOS, Plugin Device >Affects Versions: 3.4.0 > Environment: osx > cordova cli >Reporter: Carlos Santana > > $ cordova create hello > $ cd hello > $ cordova platform add ios > $ cordova platform firefoxos > $ cordova plugin add org.apache.cordova.device > Fetching plugin "org.apache.cordova.device" via plugin registry > Starting installation of "org.apache.cordova.device" for android > Preparing android project > org.apache.cordova.device installed on android. > Starting installation of "org.apache.cordova.device" for firefoxos > Preparing firefoxos project > Error: ENOENT, no such file or directory > '/Users/csantana23/git/csantanapr/triangle-open-data-day/hybridApp/todd/platforms/firefoxos/www/config.xml' > at Object.fs.openSync (fs.js:427:18) > at Object.fs.readFileSync (fs.js:284:15) > at Object.module.exports.parseElementtreeSync > (/Users/csantana23/.nvm/v0.10.24/lib/node_modules/cordova/node_modules/plugman/src/util/xml-helpers.js:119:27) > at Object.module.exports.package_name > (/Users/csantana23/.nvm/v0.10.24/lib/node_modules/cordova/node_modules/plugman/src/platforms/firefoxos.js:10:38) > at Object.module.exports.generate_plugin_config_munge > (/Users/csantana23/.nvm/v0.10.24/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:100:53) > at Object.module.exports.add_plugin_changes > (/Users/csantana23/.nvm/v0.10.24/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:300:43) > at > /Users/csantana23/.nvm/v0.10.24/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:440:28 > at Array.forEach (native) > at Object.module.exports.process > (/Users/csantana23/.nvm/v0.10.24/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:439:49) > at Object.handlePrepare > (/Users/csantana23/.nvm/v0.10.24/lib/node_modules/cordova/node_modules/plugman/src/prepare.js:69:20) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-5608) file-transfer
[ https://issues.apache.org/jira/browse/CB-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rodrigo Silveira reassigned CB-5608: Assignee: Rodrigo Silveira > file-transfer > - > > Key: CB-5608 > URL: https://issues.apache.org/jira/browse/CB-5608 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS >Reporter: Steve Gill >Assignee: Rodrigo Silveira > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-5033) Write tests for firefoxos in cordova-cli
[ https://issues.apache.org/jira/browse/CB-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zalewa closed CB-5033. Resolution: Fixed Not gonna happen > Write tests for firefoxos in cordova-cli > > > Key: CB-5033 > URL: https://issues.apache.org/jira/browse/CB-5033 > Project: Apache Cordova > Issue Type: Task > Components: FirefoxOS >Reporter: James Long > > I'm going to add firefox os to the spec/metadata folder in cordova-cli so > that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6974) Keyboard causes input focus issue
[
https://issues.apache.org/jira/browse/CB-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036384#comment-14036384
]
Darryl Pogue commented on CB-6974:
--
This only happens if {{KeyboardShrinksView}} is true in config.xml.
> Keyboard causes input focus issue
> -
>
> Key: CB-6974
> URL: https://issues.apache.org/jira/browse/CB-6974
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Keyboard
>Affects Versions: 3.5.0
> Environment: iOS 6.1
>Reporter: Darryl Pogue
> Labels: iOS
>
> I've confirmed that this issue is caused by the keyboard plugin, because it
> does not happen when the keyboard plugin is disabled.
> If there is an input on the lower half of the page, when it is tapped, the
> keyboard will slide up, covering the input and not putting it in focus.
> In my config file I have the following:
> {code:xml|title=config.xml}
>
>
> />
> {code}
> This appears to only happen when the input is on a page that is absolutely
> positioned.
> The best reference I can find about the issue is
> http://www.telerik.com/forums/click-on-input-levels-up-the-footer-on-the-keyboard-whitout-change-the-view-!-
> but the suggested change of setting the body height on deviceReady didn't
> work for me.
> It does not appear to be related to the status bar (as potentially stated in
> that thread). Removing the status bar plugin did not fix the problem.
> My guess is that it's related to hiding the accessory bar and intercepting
> the keyboard opening in Objective C, but I don't know enough about ObjC to
> know what would cause the focus to be lost :(
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (CB-6893) Update readme documentation in cordova-firefoxos
[ https://issues.apache.org/jira/browse/CB-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rodrigo Silveira reassigned CB-6893: Assignee: Rodrigo Silveira > Update readme documentation in cordova-firefoxos > > > Key: CB-6893 > URL: https://issues.apache.org/jira/browse/CB-6893 > Project: Apache Cordova > Issue Type: Task > Components: FirefoxOS >Reporter: Rodrigo Silveira >Assignee: Rodrigo Silveira >Priority: Minor > Labels: documentation > > The readme instructions are way more complex that what they need to be. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6570) mobile-spec has inline JavaScript which is forbidden for Firefox OS privileged apps
[ https://issues.apache.org/jira/browse/CB-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zalewa resolved CB-6570. -- Resolution: Fixed > mobile-spec has inline JavaScript which is forbidden for Firefox OS > privileged apps > --- > > Key: CB-6570 > URL: https://issues.apache.org/jira/browse/CB-6570 > Project: Apache Cordova > Issue Type: Bug > Components: FirefoxOS, mobile-spec >Reporter: Piotr Zalewa >Assignee: Piotr Zalewa > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-5692) Add icon to firefoxos
[
https://issues.apache.org/jira/browse/CB-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Zalewa resolved CB-5692.
--
Resolution: Fixed
> Add icon to firefoxos
> -
>
> Key: CB-5692
> URL: https://issues.apache.org/jira/browse/CB-5692
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
>Reporter: Axel Nennker
>
> Add icons to firefoxos and add "icons" field to manifest.webapp
> https://developer.mozilla.org/en-US/Apps/Developing/Manifest
> "icons": {
> "30": "icon-30.png",
> "60": "icon-60.png",
> "128": "icon-128.png"
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (CB-6895) Generated manifest skips some properties
[ https://issues.apache.org/jira/browse/CB-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zalewa resolved CB-6895. -- Resolution: Fixed > Generated manifest skips some properties > > > Key: CB-6895 > URL: https://issues.apache.org/jira/browse/CB-6895 > Project: Apache Cordova > Issue Type: Bug > Components: FirefoxOS >Affects Versions: 3.5.0 >Reporter: Rodrigo Silveira >Assignee: Rodrigo Silveira > > The properties *launch_path* and *installs_allowed_from* are hard coded and > should instead come from *content* and *access* elements in *config.xml*. > Manifest doesn't support fullscreen and portrait. > See [config.xml > docs|http://cordova.apache.org/docs/en/3.5.0/config_ref_index.md.html#The%20config.xml%20File] > for cordova props we can use and [app manifest > doc|https://developer.mozilla.org/en-US/Apps/Build/Manifest] for what > firefoxos supports. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6949) CSP in FirefoxOS breaks app.initialize() causing deviceReady not to fire
[ https://issues.apache.org/jira/browse/CB-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036352#comment-14036352 ] Piotr Zalewa commented on CB-6949: -- To enter into the CSP mode an app need to be privileged. That happens when you'd add a plugin which requires it - in example contacts plugin. We need to change ``cordova-app-hello-world`` so all JS will be placed in a separate JS > CSP in FirefoxOS breaks app.initialize() causing deviceReady not to fire > > > Key: CB-6949 > URL: https://issues.apache.org/jira/browse/CB-6949 > Project: Apache Cordova > Issue Type: Bug > Components: FirefoxOS >Reporter: John McLear >Priority: Critical > > To replicate: > cordova create test > cordova platform add firefoxos > Run your application on firefoxos and you will notice deviceReady does not > fire. You will also get a CSP warning. > The cause is the inline "app.initialize()" > The fix is to move the app.initialize() to another file and set the script at > "defer"ed however I expect this will break a lot of other things. > FirefoxOS expects CSP for all applications by default and is completely > strict about certified applications. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6975) Large files and high file count take a long time and will crash the zip process
[ https://issues.apache.org/jira/browse/CB-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036342#comment-14036342 ] ASF subversion and git services commented on CB-6975: - Commit c8fdd7ca19699a0c7852f989d65a334fd0082ab2 in cordova-app-harness's branch refs/heads/master from [~drkemp] [ https://git-wip-us.apache.org/repos/asf?p=cordova-app-harness.git;h=c8fdd7c ] CB-6975 Improve the speed of the zip function > Large files and high file count take a long time and will crash the zip > process > --- > > Key: CB-6975 > URL: https://issues.apache.org/jira/browse/CB-6975 > Project: Apache Cordova > Issue Type: Bug > Components: AppHarness > Environment: Harness push on OSX at least - likely all platforms >Reporter: David Kemp >Assignee: David Kemp > > Directories with a number of large files cause the zip process to experience > exponential tie and memory use. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6975) Large files and high file count take a long time and will crash the zip process
David Kemp created CB-6975: -- Summary: Large files and high file count take a long time and will crash the zip process Key: CB-6975 URL: https://issues.apache.org/jira/browse/CB-6975 Project: Apache Cordova Issue Type: Bug Components: AppHarness Environment: Harness push on OSX at least - likely all platforms Reporter: David Kemp Assignee: David Kemp Directories with a number of large files cause the zip process to experience exponential tie and memory use. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools
[ https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036211#comment-14036211 ] ASF subversion and git services commented on CB-6973: - Commit f9a81e4f38a70be50c1133d335553f4841ba98f4 in cordova-lib's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f9a81e4 ] CB-6973: Fix JSHint errors in src/plugman/*.js Add JSHint config comment in all the files (sometimes with tweaks) /* jshint node:true, bitwise:true, undef:true, trailing:true, quotmark:true, indent:4, unused:vars, latedef:nofunc */ JSHint is now happy for both src/cordova/*.js and src/plugman/*.js not including subdirs. Use npm run jshint to run jshint on all the files that have been fixed so far. > Use JSHint in Cordova CLI tools > --- > > Key: CB-6973 > URL: https://issues.apache.org/jira/browse/CB-6973 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6964) Port network tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035989#comment-14035989 ] Javier Alberto Becerra Bermudez commented on CB-6964: - I've been working on this item > Port network tests to plugin-test-framework > --- > > Key: CB-6964 > URL: https://issues.apache.org/jira/browse/CB-6964 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Network Information >Reporter: Staci Cooper >Assignee: Staci Cooper >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6974) Keyboard causes input focus issue
Darryl Pogue created CB-6974:
Summary: Keyboard causes input focus issue
Key: CB-6974
URL: https://issues.apache.org/jira/browse/CB-6974
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Keyboard
Affects Versions: 3.5.0
Environment: iOS 6.1
Reporter: Darryl Pogue
I've confirmed that this issue is caused by the keyboard plugin, because it
does not happen when the keyboard plugin is disabled.
If there is an input on the lower half of the page, when it is tapped, the
keyboard will slide up, covering the input and not putting it in focus.
In my config file I have the following:
{code:xml|title=config.xml}
{code}
This appears to only happen when the input is on a page that is absolutely
positioned.
The best reference I can find about the issue is
http://www.telerik.com/forums/click-on-input-levels-up-the-footer-on-the-keyboard-whitout-change-the-view-!-
but the suggested change of setting the body height on deviceReady didn't work
for me.
It does not appear to be related to the status bar (as potentially stated in
that thread). Removing the status bar plugin did not fix the problem.
My guess is that it's related to hiding the accessory bar and intercepting the
keyboard opening in Objective C, but I don't know enough about ObjC to know
what would cause the focus to be lost :(
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6965) Port notification tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035995#comment-14035995 ] Javier Alberto Becerra Bermudez commented on CB-6965: - I've been working on this item. > Port notification tests to plugin-test-framework > > > Key: CB-6965 > URL: https://issues.apache.org/jira/browse/CB-6965 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Dialogs >Reporter: Staci Cooper >Assignee: Staci Cooper >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-6958) Port camera tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035991#comment-14035991 ] Javier Alberto Becerra Bermudez edited comment on CB-6958 at 6/18/14 5:27 PM: -- I've been working on this item. was (Author: javierbb): I've been working on this on > Port camera tests to plugin-test-framework > -- > > Key: CB-6958 > URL: https://issues.apache.org/jira/browse/CB-6958 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Camera >Reporter: Staci Cooper >Assignee: Staci Cooper > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6958) Port camera tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035991#comment-14035991 ] Javier Alberto Becerra Bermudez commented on CB-6958: - I've been working on this on > Port camera tests to plugin-test-framework > -- > > Key: CB-6958 > URL: https://issues.apache.org/jira/browse/CB-6958 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Camera >Reporter: Staci Cooper >Assignee: Staci Cooper > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6971) Infinite recursion onerror in Android 4.0.x branch
[ https://issues.apache.org/jira/browse/CB-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-6971. --- Resolution: Fixed Assignee: Andrew Grieve > Infinite recursion onerror in Android 4.0.x branch > -- > > Key: CB-6971 > URL: https://issues.apache.org/jira/browse/CB-6971 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > E/AndroidRuntime( 2106): java.lang.StackOverflowError > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6971) Infinite recursion onerror in Android 4.0.x branch
[ https://issues.apache.org/jira/browse/CB-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035985#comment-14035985 ] ASF subversion and git services commented on CB-6971: - Commit 3a9898a6a6a5fa88cf29448d525c3ef4518ee2fc in cordova-android's branch refs/heads/4.0.x from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=3a9898a ] CB-6971 Fix infinite recursion for onReceiveError > Infinite recursion onerror in Android 4.0.x branch > -- > > Key: CB-6971 > URL: https://issues.apache.org/jira/browse/CB-6971 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Priority: Minor > > E/AndroidRuntime( 2106): java.lang.StackOverflowError > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) > E/AndroidRuntime( 2106): at > org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) > E/AndroidRuntime( 2106): at > org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6959) Port capture tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035983#comment-14035983 ] Samir Silva commented on CB-6959: - I will be working on this plugin > Port capture tests to plugin-test-framework > --- > > Key: CB-6959 > URL: https://issues.apache.org/jira/browse/CB-6959 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Media Capture >Reporter: Staci Cooper >Assignee: Staci Cooper >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools
[ https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035959#comment-14035959 ] ASF subversion and git services commented on CB-6973: - Commit 6748b0a65ada025debcd881cc2cc30dc74d1383f in cordova-lib's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=6748b0a ] CB-6973: Fix JSHint errors in src/cordova/*.js Add JSHint config comment in all the files (sometimes with tweaks) /* jshint node:true, bitwise:true, undef:true, trailing:true, quotmark:true, indent:4, unused:vars, latedef:nofunc */ JSHint is now happy for all of src/cordova/*.js (not including metadata/*.js). > Use JSHint in Cordova CLI tools > --- > > Key: CB-6973 > URL: https://issues.apache.org/jira/browse/CB-6973 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools
[ https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035960#comment-14035960 ] ASF subversion and git services commented on CB-6973: - Commit bf2745e7d7cb747755cc5805420f1a1fe238ab68 in cordova-lib's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=bf2745e ] CB-6973: Add JSHint to npm-test in package.json - It runs after jasmine and only if jasmine test was successful. - Can be run separately as "npm run jshint". - For now only covers src/cordova/*.js not including metadata/*.js > Use JSHint in Cordova CLI tools > --- > > Key: CB-6973 > URL: https://issues.apache.org/jira/browse/CB-6973 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6973) Use JSHint in Cordova CLI tools
Mark Koudritsky created CB-6973: --- Summary: Use JSHint in Cordova CLI tools Key: CB-6973 URL: https://issues.apache.org/jira/browse/CB-6973 Project: Apache Cordova Issue Type: Improvement Components: CLI Reporter: Mark Koudritsky Assignee: Mark Koudritsky -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5711) Keyboard plugin w/ shrinkView breaks when switching between different keyboards
[
https://issues.apache.org/jira/browse/CB-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035904#comment-14035904
]
Darryl Pogue commented on CB-5711:
--
Should be fixed in master by
https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;a=commit;h=34912f80900b9d23bdf09997a19dd9dee21aa86e
> Keyboard plugin w/ shrinkView breaks when switching between different
> keyboards
> ---
>
> Key: CB-5711
> URL: https://issues.apache.org/jira/browse/CB-5711
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Keyboard
>Affects Versions: 3.2.0
>Reporter: Stuart Parmenter
> Labels: keyboard-plugin
>
> If you have an followed by an or an
> they all show different keyboards and fire
> UIKeyboardWillShowNotification without firing UIKeyboardWillHideNotification.
> This causes the shrink code to happen multiple times.
> The easiest fix is to add a check in shrinkViewKeyboardWillShow:
> if (self.keyboardIsVisible) {
> return;
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6954) Share events.js between cordova and plugman
[ https://issues.apache.org/jira/browse/CB-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035855#comment-14035855 ] ASF subversion and git services commented on CB-6954: - Commit 637994cce413509479d3dfd18b568382e1a4f59f in cordova-cli's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=637994c ] CB-6954: Use the unified cordova_lib.events in cli spec > Share events.js between cordova and plugman > --- > > Key: CB-6954 > URL: https://issues.apache.org/jira/browse/CB-6954 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > Labels: cordova, cordova-lib, plugman, refactoring > > Currently there are two instances of events.js under cordova and plugman > folders which provide exactly the same functionality. > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/events.js > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/events.js > This is common functionality which must be shared among cordova and plugman > so must be moved to some common folder (src/events.js???). Similar to > CordovaError and xml-helpers.js > It is also required to be able to reference to 'events' from shared code - as > an example, common Hooks code which emits messages via 'events'. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6943) customWWW assets can be local but include : in path
[ https://issues.apache.org/jira/browse/CB-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035845#comment-14035845 ] ASF subversion and git services commented on CB-6943: - Commit fc3c606b22214c864a7ae3fc5ab549c84453548c in cordova-cli's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=fc3c606 ] CB-6943: Fixe cli tets on non-windows. The previous commit for this bug f6e73a61683ed2160eaa1da97f6cfacbc6aea0ac broke the cli jasmine tests for non Windows platforms. Custom www path gets path.resolved. Paths beginning with C:\ get resolved to something like this on Os X: /Users/joe/tst/c:\PrivateWWW I replaced the specific expectation for the path with jasmine.any(Object). Note, paths beginning with file:// don't get resolved properly either, so they still don't work as custom www uri. Looks like we need to write or find a smarter wrapper for path.resolve that can take care of file:// and c:\ > customWWW assets can be local but include : in path > --- > > Key: CB-6943 > URL: https://issues.apache.org/jira/browse/CB-6943 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen > > passing a copy-from or link-to value of file:// will output the error message: > 'Only local paths for custom www assets are supported.' > This IS a local path. The test should be testing for http not : > C: is another valid path segment. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6954) Share events.js between cordova and plugman
[ https://issues.apache.org/jira/browse/CB-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035807#comment-14035807 ] ASF subversion and git services commented on CB-6954: - Commit c7a6435193c354870487e5fed399c9c1e9754aa2 in cordova-cli's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=c7a6435 ] CB-6954: Use the unified cordova_lib.events After events got shared between cordova and plugman, some log messages were printed multiple times since handlers were registered twice in the cli: cordova.on(...) plugman.on(...) changing it to events.on(...) > Share events.js between cordova and plugman > --- > > Key: CB-6954 > URL: https://issues.apache.org/jira/browse/CB-6954 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > Labels: cordova, cordova-lib, plugman, refactoring > > Currently there are two instances of events.js under cordova and plugman > folders which provide exactly the same functionality. > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/events.js > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/events.js > This is common functionality which must be shared among cordova and plugman > so must be moved to some common folder (src/events.js???). Similar to > CordovaError and xml-helpers.js > It is also required to be able to reference to 'events' from shared code - as > an example, common Hooks code which emits messages via 'events'. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6954) Share events.js between cordova and plugman
[ https://issues.apache.org/jira/browse/CB-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035806#comment-14035806 ] ASF subversion and git services commented on CB-6954: - Commit fb41e644d7d669d55baf2f20167b222e4907f72d in cordova-lib's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fb41e64 ] CB-6954: Expose the unified events as cordova_lib.events After events got shared between cordova and plugman, some log messages were printed multiple times since handlers were registered twice in the cli: cordova.on(...) plugman.on(...) changing it to events.on(...) > Share events.js between cordova and plugman > --- > > Key: CB-6954 > URL: https://issues.apache.org/jira/browse/CB-6954 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > Labels: cordova, cordova-lib, plugman, refactoring > > Currently there are two instances of events.js under cordova and plugman > folders which provide exactly the same functionality. > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/events.js > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/events.js > This is common functionality which must be shared among cordova and plugman > so must be moved to some common folder (src/events.js???). Similar to > CordovaError and xml-helpers.js > It is also required to be able to reference to 'events' from shared code - as > an example, common Hooks code which emits messages via 'events'. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6972) IntentReceiver leak warning in logs for NetworkManager
Andrew Grieve created CB-6972: - Summary: IntentReceiver leak warning in logs for NetworkManager Key: CB-6972 URL: https://issues.apache.org/jira/browse/CB-6972 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin Network Information Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor E/ActivityThread(22112): android.app.IntentReceiverLeaked: Activity org.chromium.appdevtool.ChromeAppDeveloperTool has leaked IntentReceiver org.apache.cordova.networkinformation.NetworkManager$1@425560c0 that was originally registered here. Are you missing a call to unregisterReceiver()? E/ActivityThread(22112):at android.app.LoadedApk$ReceiverDispatcher.(LoadedApk.java:805) E/ActivityThread(22112):at android.app.LoadedApk.getReceiverDispatcher(LoadedApk.java:606) E/ActivityThread(22112):at android.app.ContextImpl.registerReceiverInternal(ContextImpl.java:1551) E/ActivityThread(22112):at android.app.ContextImpl.registerReceiver(ContextImpl.java:1531) E/ActivityThread(22112):at android.app.ContextImpl.registerReceiver(ContextImpl.java:1525) E/ActivityThread(22112):at android.content.ContextWrapper.registerReceiver(ContextWrapper.java:467) E/ActivityThread(22112):at org.apache.cordova.networkinformation.NetworkManager.initialize(NetworkManager.java:113) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6971) Infinite recursion onerror in Android 4.0.x branch
Andrew Grieve created CB-6971: - Summary: Infinite recursion onerror in Android 4.0.x branch Key: CB-6971 URL: https://issues.apache.org/jira/browse/CB-6971 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Andrew Grieve Priority: Minor E/AndroidRuntime( 2106): java.lang.StackOverflowError E/AndroidRuntime( 2106):at org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) E/AndroidRuntime( 2106):at org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) E/AndroidRuntime( 2106):at org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) E/AndroidRuntime( 2106):at org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) E/AndroidRuntime( 2106):at org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) E/AndroidRuntime( 2106):at org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) E/AndroidRuntime( 2106):at org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) E/AndroidRuntime( 2106):at org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) E/AndroidRuntime( 2106):at org.apache.cordova.AndroidWebViewClient.onReceivedError(AndroidWebViewClient.java:491) E/AndroidRuntime( 2106):at org.apache.cordova.IceCreamCordovaWebViewClient.onReceivedError(IceCreamCordovaWebViewClient.java:104) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6970) Share win project files manipulation code between cordova and plugman
[ https://issues.apache.org/jira/browse/CB-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035664#comment-14035664 ] ASF GitHub Bot commented on CB-6970: GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/32 CB-6970 Share win project files manipulation code between cordova and plugman https://issues.apache.org/jira/browse/CB-6970 1. Shared csproj and jsproj classes 2. Updated code to use those classes instead of manual manipulation 3. Updated removeSourceFile method to support regexp as parameter (ability to remove batch files or all files from specific folder). You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-6970 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 09759f285e698e16746304f1f6d074a4cc019008 Author: sgrebnov Date: 2014-06-18T12:58:20Z CB-6970 Share win project files manipulation code between cordova and plugman > Share win project files manipulation code between cordova and plugman > - > > Key: CB-6970 > URL: https://issues.apache.org/jira/browse/CB-6970 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib, Windows 8, WP8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > Labels: cordova-lib, windows8, wp8 > > Both cordova and plugman use own logic to parse and modify jsproj and csproj > files, for example (cordova) windows8_parser/update_jsproj and (plugman) > w8jsproj.js/removeSourceFile use exactly the same code blocks to parse and > update jsproj files. > It is better to remove duplicate code and have special shared classes to work > with project files. Cordova and plugman should rely on those classes instead > of using own implementation. > We should also remove manual project files manipulation logic from general > cordova/plugman classes, like below. > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/prepare.js#L83 > Implementation layer should be hidden from them, they just need to rely on > special well named methods provided by newly introduced classes (see above). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6970) Share win project files manipulation code between cordova and plugman
Sergey Grebnov created CB-6970: -- Summary: Share win project files manipulation code between cordova and plugman Key: CB-6970 URL: https://issues.apache.org/jira/browse/CB-6970 Project: Apache Cordova Issue Type: Improvement Components: CordovaLib, Windows 8, WP8 Reporter: Sergey Grebnov Assignee: Sergey Grebnov Both cordova and plugman use own logic to parse and modify jsproj and csproj files, for example (cordova) windows8_parser/update_jsproj and (plugman) w8jsproj.js/removeSourceFile use exactly the same code blocks to parse and update jsproj files. It is better to remove duplicate code and have special shared classes to work with project files. Cordova and plugman should rely on those classes instead of using own implementation. We should also remove manual project files manipulation logic from general cordova/plugman classes, like below. https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/prepare.js#L83 Implementation layer should be hidden from them, they just need to rely on special well named methods provided by newly introduced classes (see above). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Reopened] (CB-4612) ContactName is not supported on Android 4.X?
[ https://issues.apache.org/jira/browse/CB-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shingo Toda reopened CB-4612: - Doc is still not fixed in master. https://github.com/apache/cordova-plugin-contacts/blob/master/doc/index.md > ContactName is not supported on Android 4.X? > > > Key: CB-4612 > URL: https://issues.apache.org/jira/browse/CB-4612 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Docs, Plugin Contacts >Affects Versions: 2.9.0 > Environment: Android 4.X >Reporter: Shingo Toda >Assignee: Joe Bowser >Priority: Minor > Labels: documentation > > Document says ContactName is supported on Android 2.X (see > [http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#ContactName]). > But mobile-spec tests regarding to this property are passed on Android 4.2.2 > emulator. What is not supported on this object? Or is this just a wrong > documentation? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6909) shellCmd and shellRunParam in master.cfg use values for master, fails on Windows slaves if OS X master
[
https://issues.apache.org/jira/browse/CB-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035031#comment-14035031
]
ASF GitHub Bot commented on CB-6909:
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-medic/pull/11#issuecomment-46406000
+1, LGTM, tested on Windows and OS slaves
> shellCmd and shellRunParam in master.cfg use values for master, fails on
> Windows slaves if OS X master
> --
>
> Key: CB-6909
> URL: https://issues.apache.org/jira/browse/CB-6909
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic, Windows 8, WP8
> Environment: OS X master, buildbot 0.8.8, Windows Server 2012R2
> slave, buildslave 0.8.8
>Reporter: Vladimir Kotikov
>Assignee: Jesse MacFadyen
> Labels: medic, windows8, wp8
>
> shellCmd and shellRunCmd are defined in master.cfg and used for a lot of the
> build tasks. But the value depends on the OS of the master, so if you have a
> OS X master and Windows client (or vice versa) a lot of steps will fail.
> {noformat}
> shellCmd="/bin/sh"
> shellRunParam="-c"
> if is_Windows :
> shellCmd="cmd"
> shellRunParam="/c"
> {noformat}
> For some steps, like in wp8 and windows8 sections, we know they'll always run
> on Windows so we could always use 'cmd'. But in common sections or for a
> platform like android, it needs to work on both.
> -
> It seems that ShellCommand step already uses command interpreter according to
> slave platform (see
> http://docs.buildbot.net/current/manual/cfg-buildsteps.html#step-ShellCommand).
> So it's safe to remove this and specify commands for ShellCommand steps just
> with list of strings.
> Another possible issue is different path delimiter on windows and other
> platforms. But in most cases slash instead of backslash works fine on
> windows. So it is possible to replace '\\' to '/' in windows build steps.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
