[jira] [Commented] (CB-6980) [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with filesystem: null

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038538#comment-14038538
 ] 

ASF GitHub Bot commented on CB-6980:


Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/53#issuecomment-46649607
  
Good to know that it was useful @mhujer 


> [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with 
> filesystem: null
> ---
>
> Key: CB-6980
> URL: https://issues.apache.org/jira/browse/CB-6980
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: WP8, plugin-file
> Fix For: 3.6.0
>
>
> I have notice, when resolveLocalFileSystemURI or resolveLocalFileSystemURL is 
> called on the File Plugin under Windows Phone 8, it always returns a 
> fileEntry with null information on the filesystem.
> This behavior is unexpected the filesystem information it shouldn't be null 
> if a Entry Object is created.
> Found through mobile-spec File tests, affecting operations as 
> removeRecursively on DirectoryEntry, and remove on Entry.
> It might be reproduce by other means or scenarios.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6525) download success callback not called in 0.4.3

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038531#comment-14038531
 ] 

ASF subversion and git services commented on CB-6525:
-

Commit 4f455ac3efe64caede6cbaff9d7c638caf6e5392 in cordova-plugin-file's branch 
refs/heads/master from [~martin.c.glez.glez]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=4f455ac ]

CB-6980 Fixing filesystem:null property in Entry

when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success it should return a
Entry with several properties, as it is the filesystem information,
which returns as null.
on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
retrieved it should contain the filesystem information.
Since the fix, CB-6525, only adds support for Android and iOS, for other
platform it retrieves a null object, so adding a condition to retrieve
the information if the object from the callback is null.


> download success callback not called in 0.4.3
> -
>
> Key: CB-6525
> URL: https://issues.apache.org/jira/browse/CB-6525
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File Transfer
>Affects Versions: 3.4.0
> Environment: Cordova 3.4.1
> iOS
> 0.4.3 of the file transfer plugin
>Reporter: AH
>Assignee: Andrew Grieve
>
> I've noticed that the success callback doesn't get executed after a download 
> is successfully completed. Specifically, if success contains a console.log, 
> nothing is logged to the Xcode debugger even though the download has 
> completed successfully. I can tell that the download was completed because 
> the following message is logged in Xcode: "File Transfer Finished with 
> response code 200"
> transfer.download(src, localPath, success, error);
> I think this is an issue with version 0.4.3 of the file transfer plugin. 
> Version 0.4.2 of the plugin running on Cordova 3.4.1 didn't have this bug. 
> I found another possible report of this bug: 
> http://stackoverflow.com/questions/23240807/cant-setmetadata-while-downloading-files-via-filetransfer-download-in-ios-in-ph



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6980) [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with filesystem: null

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038530#comment-14038530
 ] 

ASF subversion and git services commented on CB-6980:
-

Commit 4f455ac3efe64caede6cbaff9d7c638caf6e5392 in cordova-plugin-file's branch 
refs/heads/master from [~martin.c.glez.glez]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=4f455ac ]

CB-6980 Fixing filesystem:null property in Entry

when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success it should return a
Entry with several properties, as it is the filesystem information,
which returns as null.
on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
retrieved it should contain the filesystem information.
Since the fix, CB-6525, only adds support for Android and iOS, for other
platform it retrieves a null object, so adding a condition to retrieve
the information if the object from the callback is null.


> [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with 
> filesystem: null
> ---
>
> Key: CB-6980
> URL: https://issues.apache.org/jira/browse/CB-6980
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: WP8, plugin-file
> Fix For: 3.6.0
>
>
> I have notice, when resolveLocalFileSystemURI or resolveLocalFileSystemURL is 
> called on the File Plugin under Windows Phone 8, it always returns a 
> fileEntry with null information on the filesystem.
> This behavior is unexpected the filesystem information it shouldn't be null 
> if a Entry Object is created.
> Found through mobile-spec File tests, affecting operations as 
> removeRecursively on DirectoryEntry, and remove on Entry.
> It might be reproduce by other means or scenarios.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6980) [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with filesystem: null

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038532#comment-14038532
 ] 

ASF GitHub Bot commented on CB-6980:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/53


> [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with 
> filesystem: null
> ---
>
> Key: CB-6980
> URL: https://issues.apache.org/jira/browse/CB-6980
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: WP8, plugin-file
> Fix For: 3.6.0
>
>
> I have notice, when resolveLocalFileSystemURI or resolveLocalFileSystemURL is 
> called on the File Plugin under Windows Phone 8, it always returns a 
> fileEntry with null information on the filesystem.
> This behavior is unexpected the filesystem information it shouldn't be null 
> if a Entry Object is created.
> Found through mobile-spec File tests, affecting operations as 
> removeRecursively on DirectoryEntry, and remove on Entry.
> It might be reproduce by other means or scenarios.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6991) Weinre doesn't fails to load in browsers without a development console

2014-06-19 Thread Joshua Walsh (JIRA)
Joshua Walsh created CB-6991:


 Summary: Weinre doesn't fails to load in browsers without a 
development console
 Key: CB-6991
 URL: https://issues.apache.org/jira/browse/CB-6991
 Project: Apache Cordova
  Issue Type: Bug
  Components: weinre
 Environment: Windows Phone 8.0, iOS, Android
Reporter: Joshua Walsh
Assignee: Patrick Mueller
Priority: Blocker


I couldn't work out where to submit a pull request, so I'm doing an issue 
report instead. Additionally, this issue applies to version 2.0.0-pre-HH0SN197 
of Weinre, but I don't know which version of Cordova that maps to.

This issue has been a massive pain to debug, as the issue is not present on 
desktop computers and there are no debugging tools on mobile devices, hence why 
I need Weinre in the first place! In fact, the issue is even more specific than 
that: The issue affects all browsers WITHOUT debugging tools.

The error is: "Unable to set property __original of undefined or null 
reference." The issue occurs on line 172 of Console.amd.js. In order to fix it, 
I added the following lines of code above line 168:

if(!window.console)
{
window.console = {};
}

I'm sure there's a more elegant way of solving this, but it does the trick.

Good luck!



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6728) Support chip architecture as an option when building Windows and Windows Phone projects

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038519#comment-14038519
 ] 

ASF GitHub Bot commented on CB-6728:


GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-cli/pull/180

CB-6728 Support chip architecture

https://issues.apache.org/jira/browse/CB-6728


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli CB-6728

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #180


commit f57db496f8c3e771c94b392a06d2309166225271
Author: sgrebnov 
Date:   2014-06-20T06:22:09Z

CB-6728 Support chip architecture




> Support chip architecture as an option when building Windows and Windows 
> Phone projects
> ---
>
> Key: CB-6728
> URL: https://issues.apache.org/jira/browse/CB-6728
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android, CLI, iOS, Windows 8, WP8
>Affects Versions: 3.4.0
>Reporter: Vladimir Kotikov
>Assignee: Jesse MacFadyen
>  Labels: arm, cli, windows, wp8, x64, x86
>
> Currently apps for Windows 8 and Windows Phone 8 are targeted to AnyCPU 
> architecture, which is universal, but sometimes it's critical to build 
> application for specific processor architecture.
> As an example is WebSQL plugin which contains references to C++ libs so needs 
> to be built for specific architecture (x84, x64, ARM) and which does not 
> support AnyCPU target.
> So it looks important to add support for additional build flags `-x64`, 
> `-x86`, `-arm`, '-any' to specify target chip architecture.
> {noformat}
> cordova build windows8 --release --x64
> cordova build wp8 --arm
> {noformat}
> If flag is not specified, `AnuCPU` target platform should be used by default.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-3571) Add support for elements in config.xml

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038484#comment-14038484
 ] 

ASF GitHub Bot commented on CB-3571:


Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-lib/pull/30#issuecomment-46646255
  
Could we also incorporate the following PR to this one before merge? It 
adds splash images support for iOS, WP8 and Windows8.
https://github.com/AxelNennker/cordova-lib/pull/1


> Add support for  elements in config.xml
> ---
>
> Key: CB-3571
> URL: https://issues.apache.org/jira/browse/CB-3571
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: CLI
>Affects Versions: Master
>Reporter: Michael Brooks
>Assignee: Lorin Beer
>
> Similar to adding support for the {{}} element, we should add support 
> for the splash screen.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6024) nopt refactoring

2014-06-19 Thread Sergey Grebnov (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037775#comment-14037775
 ] 

Sergey Grebnov edited comment on CB-6024 at 6/20/14 5:31 AM:
-

What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps where we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate --store <-test windows8.1
cordova windows emulate --store80 <-test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '-- ' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--'. like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?


was (Author: sgrebnov):
What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate --store <-test windows8.1
cordova windows emulate --store80 <-test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '-- ' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--'. like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6980) [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with filesystem: null

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038432#comment-14038432
 ] 

ASF GitHub Bot commented on CB-6980:


Github user mhujer commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/53#issuecomment-46644249
  
Thanks for the PR @martincgg ! I just stumbled accross this issue and this 
saved me time


> [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with 
> filesystem: null
> ---
>
> Key: CB-6980
> URL: https://issues.apache.org/jira/browse/CB-6980
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: WP8, plugin-file
> Fix For: 3.6.0
>
>
> I have notice, when resolveLocalFileSystemURI or resolveLocalFileSystemURL is 
> called on the File Plugin under Windows Phone 8, it always returns a 
> fileEntry with null information on the filesystem.
> This behavior is unexpected the filesystem information it shouldn't be null 
> if a Entry Object is created.
> Found through mobile-spec File tests, affecting operations as 
> removeRecursively on DirectoryEntry, and remove on Entry.
> It might be reproduce by other means or scenarios.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6024) nopt refactoring

2014-06-19 Thread Parashuram (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038224#comment-14038224
 ] 

Parashuram commented on CB-6024:


I think the above proposal also works well given that platforms will not just 
be node modules. They will be consumed using the node API instead of calling 
commands directly. 

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6884) Support new Cordova bridge under iOS 8 WKWebView

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038184#comment-14038184
 ] 

ASF subversion and git services commented on CB-6884:
-

Commit f27458fd1cbf3c0416430d04947e1c26cf87013e in cordova-js's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=f27458f ]

CB-6884 - Fixed js callbacks not firing using WKWebView Cordova bridge


> Support new Cordova bridge under iOS 8 WKWebView
> 
>
> Key: CB-6884
> URL: https://issues.apache.org/jira/browse/CB-6884
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS, iOS
> Environment: iOS 8 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.6.0
>
>
> https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
> WKUserContentController - add a script message handler with name "cordova":
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
> The WKUserContentController is associated with a WKWebViewConfiguration which 
> is initialized with a WKWebView.
> {code}
> WKUserContentController* userContentController = [[WKUserContentController 
> alloc] init];
> // scriptMessageHandler is the object that conforms to the 
> WKScriptMessageHandler protocol
> // see 
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
> [userContentController addScriptMessageHandler:scriptMessageHandler 
> name:@"cordova"];
> {code}
> In JavaScript, you would call into Objective-C thus:
> {code}
> var command = { callbackId: "blabla23", service:"Camera", action: 
> "takePicture", actionArgs: [ 1, 2, 3 ] };
> window.webkit.messageHandlers.cordova.postMessage(command);
> {code}
> In the object that conforms to the WKScriptMessageHandler protocol:
> {code}
> - (void)userContentController:(WKUserContentController 
> *)userContentController   didReceiveScriptMessage:(WKScriptMessage *)message
> {
> if (![message.name isEqualToString:@"cordova"]) {
> return;
> }
> NSDictionary* command = message.body;
> // TODO: get the callbackId, service, action, actionArgs keys and create 
> a CDVInvokedUrlCommand, and dispatch it
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6024) nopt refactoring

2014-06-19 Thread Andrew Grieve (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038175#comment-14038175
 ] 

Andrew Grieve commented on CB-6024:
---

It's pretty important that all flags appear in the --help text, so I don't 
think it's avoidable to have to change CLI the way things are set up.

That said, there's been some talk now that platforms are set up with a 
package.json, that they could provide a JS API.

E.g. we could have each platform optionally export a function that stuff more 
flags into nopt as well as into the help text.

E.g.
{code}
var platform = require('./path/to/cordova-wp8');
if (platform.initExtraBuildFlags) {
  platform.initExtraBuildFlags(nopt, helpText);
}
{code}

For this to work, we'd need to re-work how we do help text in CLI (right now 
it's just a plain-text file). That said, I think re-working would be a bonus as 
it'd be nice if you could do "cordova help command" or "cordova build --help" 
and get the help text for just that command instead of a dump of the whole text 
file.

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6661) Web Platform Target

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038120#comment-14038120
 ] 

ASF GitHub Bot commented on CB-6661:


Github user jsoref commented on the pull request:

https://github.com/apache/cordova-lib/pull/22#issuecomment-46631277
  
@kingnebby : those two corrections are right, but you should squash them 
into your other commits, and then you should rebase and resolve the merge 
conflicts.

(Note: I'm not reviewing the feature at this time.)


> Web Platform Target
> ---
>
> Key: CB-6661
> URL: https://issues.apache.org/jira/browse/CB-6661
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaJS, CordovaLib
>Affects Versions: 3.4.0
> Environment: All
>Reporter: Daniel
>Priority: Minor
>  Labels: cordova-js, features, platform
> Fix For: 3.4.0
>
>
> I have not been able to find built in functionality for cordova to deploy an 
> app to a server platform. This purpose of this new platform is to allow an 
> HTML5 application within a Cordova project to be deployed on a web server, 
> available for access over standard internet protocols.
> My team and I will be actively working this at 
> https://github.com/CollinearGroup/cordova-js
> We intend to build this functionality with a nodejs server but hope that we 
> can provide the server with varying backends like Grails and Rails.
> Cordova-Lib: https://github.com/apache/cordova-lib/pull/22
> Cordova-Web: https://github.com/CollinearGroup/cordova-web
> Cordova-Js: https://github.com/apache/cordova-js/pull/70



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6884) Support new Cordova bridge under iOS 8 WKWebView

2014-06-19 Thread Shazron Abdullah (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038117#comment-14038117
 ] 

Shazron Abdullah edited comment on CB-6884 at 6/19/14 11:48 PM:


Work in progress in my fork: 
https://github.com/shazron/cordova-ios/tree/wkwebview-only

Known issue currently: callbacks don't fire.

Core plugins seem to work. However, CDVPlugin's webView property even though it 
is declared as a UIWebView, is actually a WKWebView in this branch. It has to 
be explicitly coerced to a WKWebView. 

If the plugin uses any selectors from UIWebView in referencing the webView 
property, it may crash.

Config.xml processing for preferences is turned off for now.


was (Author: shazron):
Work in progress in my fork: 
https://github.com/shazron/cordova-ios/tree/wkwebview-only

Known issue currently: callbacks don't fire.

Core plugins seem to work. However, CDVPlugin's webView property even though it 
is declared as a UIWebView, is actually a WKWebView in this branch. It has to 
be explicitly coerced to a WKWebView. 

If the plugin uses any selectors from UIWebView in referencing the webView 
property, it may crash.

> Support new Cordova bridge under iOS 8 WKWebView
> 
>
> Key: CB-6884
> URL: https://issues.apache.org/jira/browse/CB-6884
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS, iOS
> Environment: iOS 8 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.6.0
>
>
> https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
> WKUserContentController - add a script message handler with name "cordova":
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
> The WKUserContentController is associated with a WKWebViewConfiguration which 
> is initialized with a WKWebView.
> {code}
> WKUserContentController* userContentController = [[WKUserContentController 
> alloc] init];
> // scriptMessageHandler is the object that conforms to the 
> WKScriptMessageHandler protocol
> // see 
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
> [userContentController addScriptMessageHandler:scriptMessageHandler 
> name:@"cordova"];
> {code}
> In JavaScript, you would call into Objective-C thus:
> {code}
> var command = { callbackId: "blabla23", service:"Camera", action: 
> "takePicture", actionArgs: [ 1, 2, 3 ] };
> window.webkit.messageHandlers.cordova.postMessage(command);
> {code}
> In the object that conforms to the WKScriptMessageHandler protocol:
> {code}
> - (void)userContentController:(WKUserContentController 
> *)userContentController   didReceiveScriptMessage:(WKScriptMessage *)message
> {
> if (![message.name isEqualToString:@"cordova"]) {
> return;
> }
> NSDictionary* command = message.body;
> // TODO: get the callbackId, service, action, actionArgs keys and create 
> a CDVInvokedUrlCommand, and dispatch it
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-3571) Add support for elements in config.xml

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038115#comment-14038115
 ] 

ASF GitHub Bot commented on CB-3571:


Github user jsoref commented on the pull request:

https://github.com/apache/cordova-lib/pull/30#issuecomment-46631067
  
Could you please do a rebase so that there isn't an ugly merge (or multiple 
ugly merges) in the history? I've done a number for #9 -- it makes things much 
nicer.

A quick check shows that while there is a conflict, it's incredibly tiny, 
and trivial to resolve ("pick your change").


> Add support for  elements in config.xml
> ---
>
> Key: CB-3571
> URL: https://issues.apache.org/jira/browse/CB-3571
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: CLI
>Affects Versions: Master
>Reporter: Michael Brooks
>Assignee: Lorin Beer
>
> Similar to adding support for the {{}} element, we should add support 
> for the splash screen.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6884) Support new Cordova bridge under iOS 8 WKWebView

2014-06-19 Thread Shazron Abdullah (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038117#comment-14038117
 ] 

Shazron Abdullah commented on CB-6884:
--

Work in progress in my fork: 
https://github.com/shazron/cordova-ios/tree/wkwebview-only

Known issue currently: callbacks don't fire.

Core plugins seem to work. However, CDVPlugin's webView property even though it 
is declared as a UIWebView, is actually a WKWebView in this branch. It has to 
be explicitly coerced to a WKWebView. 

If the plugin uses any selectors from UIWebView in referencing the webView 
property, it may crash.

> Support new Cordova bridge under iOS 8 WKWebView
> 
>
> Key: CB-6884
> URL: https://issues.apache.org/jira/browse/CB-6884
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS, iOS
> Environment: iOS 8 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.6.0
>
>
> https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
> WKUserContentController - add a script message handler with name "cordova":
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
> The WKUserContentController is associated with a WKWebViewConfiguration which 
> is initialized with a WKWebView.
> {code}
> WKUserContentController* userContentController = [[WKUserContentController 
> alloc] init];
> // scriptMessageHandler is the object that conforms to the 
> WKScriptMessageHandler protocol
> // see 
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
> [userContentController addScriptMessageHandler:scriptMessageHandler 
> name:@"cordova"];
> {code}
> In JavaScript, you would call into Objective-C thus:
> {code}
> var command = { callbackId: "blabla23", service:"Camera", action: 
> "takePicture", actionArgs: [ 1, 2, 3 ] };
> window.webkit.messageHandlers.cordova.postMessage(command);
> {code}
> In the object that conforms to the WKScriptMessageHandler protocol:
> {code}
> - (void)userContentController:(WKUserContentController 
> *)userContentController   didReceiveScriptMessage:(WKScriptMessage *)message
> {
> if (![message.name isEqualToString:@"cordova"]) {
> return;
> }
> NSDictionary* command = message.body;
> // TODO: get the callbackId, service, action, actionArgs keys and create 
> a CDVInvokedUrlCommand, and dispatch it
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6986) pin jshint

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038103#comment-14038103
 ] 

ASF subversion and git services commented on CB-6986:
-

Commit d23aee39bf92e70eca8cb5defb6c0066a071c210 in cordova-lib's branch 
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d23aee3 ]

CB-6986 make npm run jshint work without a global jshint

Add jshint to dev-deps in package.json and use it instead of relying on a
global jshint.

github: close #37


> pin jshint
> --
>
> Key: CB-6986
> URL: https://issues.apache.org/jira/browse/CB-6986
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> Currently npm test and npm run jshint fail if jshint isn't installed globally.
> Apparently jshint has changed significantly between 2.4 and 2.5, so if we're 
> expecting people to have consistent output, we should select a specific 
> version of jshint and depend on it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6986) pin jshint

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038104#comment-14038104
 ] 

ASF GitHub Bot commented on CB-6986:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/37


> pin jshint
> --
>
> Key: CB-6986
> URL: https://issues.apache.org/jira/browse/CB-6986
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> Currently npm test and npm run jshint fail if jshint isn't installed globally.
> Apparently jshint has changed significantly between 2.4 and 2.5, so if we're 
> expecting people to have consistent output, we should select a specific 
> version of jshint and depend on it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6651) prepare-release-branch should update version in package.json

2014-06-19 Thread Steve Gill (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-6651.


Resolution: Fixed

> prepare-release-branch should update version in package.json
> 
>
> Key: CB-6651
> URL: https://issues.apache.org/jira/browse/CB-6651
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Coho
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> This should be done automatically be prepare-release-branch in the release 
> steps.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6651) prepare-release-branch should update version in package.json

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038094#comment-14038094
 ] 

ASF subversion and git services commented on CB-6651:
-

Commit 25aaf5ae05edde7c9faa1ce6acdee21bac2462e6 in cordova-coho's branch 
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=25aaf5a ]

CB-6651 prepare release branch now updates version in package.json file


> prepare-release-branch should update version in package.json
> 
>
> Key: CB-6651
> URL: https://issues.apache.org/jira/browse/CB-6651
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Coho
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> This should be done automatically be prepare-release-branch in the release 
> steps.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6140) Plugman allows deletion of platform dependencies

2014-06-19 Thread Josh Soref (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Soref updated CB-6140:
---

Affects Version/s: 3.5.0

> Plugman allows deletion of platform dependencies
> 
>
> Key: CB-6140
> URL: https://issues.apache.org/jira/browse/CB-6140
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 3.4.0, 3.5.0
>Reporter: Bryan Higgins
>Assignee: Jonathan Bond
> Fix For: 3.6.0
>
>
> plugman 0.20.1 / CLI 3.4.0-0.1.2
> After a dependency was automatically added for me, I am able to remove it.
> "prepare" then complains about a missing plugin.xml file
> I used the following plugin, but I suspect this behaviour would occur for all 
> with a top-level dependency:
> https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6884) Support new Cordova bridge under iOS 8 WKWebView

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038089#comment-14038089
 ] 

ASF subversion and git services commented on CB-6884:
-

Commit 0329464c7bb538cc469dc965e28f5801ea14422f in cordova-js's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=0329464 ]

CB-6884 - Added WKWebView Cordova bridge


> Support new Cordova bridge under iOS 8 WKWebView
> 
>
> Key: CB-6884
> URL: https://issues.apache.org/jira/browse/CB-6884
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS, iOS
> Environment: iOS 8 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.6.0
>
>
> https://developer.apple.com/library/prerelease/ios/releasenotes/General/RN-iOSSDK-8.0/index.html
> WKUserContentController - add a script message handler with name "cordova":
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKUserContentController_Ref/index.html#//apple_ref/swift/cl/WKUserContentController
> The WKUserContentController is associated with a WKWebViewConfiguration which 
> is initialized with a WKWebView.
> {code}
> WKUserContentController* userContentController = [[WKUserContentController 
> alloc] init];
> // scriptMessageHandler is the object that conforms to the 
> WKScriptMessageHandler protocol
> // see 
> https://developer.apple.com/library/prerelease/ios/documentation/WebKit/Reference/WKScriptMessageHandler_Ref/index.html#//apple_ref/swift/intf/WKScriptMessageHandler
> [userContentController addScriptMessageHandler:scriptMessageHandler 
> name:@"cordova"];
> {code}
> In JavaScript, you would call into Objective-C thus:
> {code}
> var command = { callbackId: "blabla23", service:"Camera", action: 
> "takePicture", actionArgs: [ 1, 2, 3 ] };
> window.webkit.messageHandlers.cordova.postMessage(command);
> {code}
> In the object that conforms to the WKScriptMessageHandler protocol:
> {code}
> - (void)userContentController:(WKUserContentController 
> *)userContentController   didReceiveScriptMessage:(WKScriptMessage *)message
> {
> if (![message.name isEqualToString:@"cordova"]) {
> return;
> }
> NSDictionary* command = message.body;
> // TODO: get the callbackId, service, action, actionArgs keys and create 
> a CDVInvokedUrlCommand, and dispatch it
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6140) Plugman allows deletion of platform dependencies

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038071#comment-14038071
 ] 

ASF GitHub Bot commented on CB-6140:


Github user jsoref commented on the pull request:

https://github.com/apache/cordova-lib/pull/38#issuecomment-46627998
  
1. The first line of your commit message should be of the form:

CB-6140 Don't allow deletion of platform dependencies

2. Please fix any misspellings in the commit message:
platform/dependecy


> Plugman allows deletion of platform dependencies
> 
>
> Key: CB-6140
> URL: https://issues.apache.org/jira/browse/CB-6140
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 3.4.0
>Reporter: Bryan Higgins
>Assignee: Jonathan Bond
> Fix For: 3.6.0
>
>
> plugman 0.20.1 / CLI 3.4.0-0.1.2
> After a dependency was automatically added for me, I am able to remove it.
> "prepare" then complains about a missing plugin.xml file
> I used the following plugin, but I suspect this behaviour would occur for all 
> with a top-level dependency:
> https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5671) facilitate dynamic loading of cordova plugins

2014-06-19 Thread Anis Kadri (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038070#comment-14038070
 ] 

Anis Kadri commented on CB-5671:


CB-6990

> facilitate dynamic loading of cordova plugins
> -
>
> Key: CB-5671
> URL: https://issues.apache.org/jira/browse/CB-5671
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaJS
>Affects Versions: 3.2.0
> Environment: any
>Reporter: Jon Whitlock
>Assignee: Andrew Grieve
>  Labels: javascript
> Attachments: Screen Shot 2014-03-06 at 8.49.27 AM.png
>
>
> Problem: Cordova expects resources to be loaded off the device filesystem.
> 1) On iOS this is very risky due to the turnaround time pushing hotfixes 
> through the App store.
> 2) In complex JS applications one needs to use a loader like require.js to 
> manage async loading (especially on mobile) & module dependancy management 
> (as cordova does internally).
> 3) When integrating with many 3rd-party services like auth/"social login" one 
> needs to have a public-facing page to call back to.
> Use case: We have a bunch of prereqs before cordova.js loads, so we have to 
> load cordova.js using require.js.  However to show localised error messages 
> we need the preferred language from the device to know which language to show 
> messaging in, so we need cordova loaded as part of auth prerequisites.
> Problematic Assumptions:
> a) findCordovaPath() assumes a script tag in the document loaded cordova.js 
> -- not the case with require.js or similar.
> b) injectPluginScript() assumes that cordova_plugins.js is in the same dir as 
> cordova.js
> So using plugins & dynamically loading Cordova is terminal, unless I hack 
> findCordovaPath() to return (in our case) the path where cordova.js is to be 
> found -- which is defined in a JS configuration file.
> I think it would be more robust to define the location of those file(s) in a 
> config file somewhere -- which could also facilitate dynamic loading of 
> cordova.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6140) Plugman allows deletion of platform dependencies

2014-06-19 Thread Josh Soref (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Soref updated CB-6140:
---

Summary: Plugman allows deletion of platform dependencies  (was: Plugman 
allows deletion of dependencies)

> Plugman allows deletion of platform dependencies
> 
>
> Key: CB-6140
> URL: https://issues.apache.org/jira/browse/CB-6140
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 3.4.0
>Reporter: Bryan Higgins
>Assignee: Jonathan Bond
> Fix For: 3.6.0
>
>
> plugman 0.20.1 / CLI 3.4.0-0.1.2
> After a dependency was automatically added for me, I am able to remove it.
> "prepare" then complains about a missing plugin.xml file
> I used the following plugin, but I suspect this behaviour would occur for all 
> with a top-level dependency:
> https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038055#comment-14038055
 ] 

ASF GitHub Bot commented on CB-6140:


GitHub user dylin opened a pull request:

https://github.com/apache/cordova-lib/pull/38

Fixed issue: CB-6140

plugman dependency check will ignore platform/dependecy when removing an
intalled plugin, which will result in platform level dependencies is
uninstalled inproperly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dylin/cordova-lib dylin/CB-6140

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #38


commit 3241f0776efe9f9bcb3a5d09dedb3cba21c8a5dc
Author: Danyi Lin 
Date:   2014-06-19T22:45:19Z

Fixed issue: CB-6140
plugman dependency check will ignore platform/dependecy when removing an
intalled plugin, which will result in platform level dependencies is
uninstalled inproperly.




> Plugman allows deletion of dependencies
> ---
>
> Key: CB-6140
> URL: https://issues.apache.org/jira/browse/CB-6140
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 3.4.0
>Reporter: Bryan Higgins
>Assignee: Jonathan Bond
> Fix For: 3.6.0
>
>
> plugman 0.20.1 / CLI 3.4.0-0.1.2
> After a dependency was automatically added for me, I am able to remove it.
> "prepare" then complains about a missing plugin.xml file
> I used the following plugin, but I suspect this behaviour would occur for all 
> with a top-level dependency:
> https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies

2014-06-19 Thread Danyi Lin (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038037#comment-14038037
 ] 

Danyi Lin commented on CB-6140:
---

[~bhigg...@blackberry.com] I am just trying to clarify this issue

given a plugin defined as below:

  foo
  ...
  
 bar
  
 ...


* Install plugin foo, bar will be installed as dependency implicitly

Test 1
remove  plugin foo
expect result: bar should be remove either
actual result : bar was NOT removed

Test 2
remove plugin bar
expect result: the removing will be rejected, because foo depends on it
actual result : bar was removed.

> Plugman allows deletion of dependencies
> ---
>
> Key: CB-6140
> URL: https://issues.apache.org/jira/browse/CB-6140
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 3.4.0
>Reporter: Bryan Higgins
>Assignee: Jonathan Bond
> Fix For: 3.6.0
>
>
> plugman 0.20.1 / CLI 3.4.0-0.1.2
> After a dependency was automatically added for me, I am able to remove it.
> "prepare" then complains about a missing plugin.xml file
> I used the following plugin, but I suspect this behaviour would occur for all 
> with a top-level dependency:
> https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6990) concatenate all plugins with cordova.js

2014-06-19 Thread Anis Kadri (JIRA)
Anis Kadri created CB-6990:
--

 Summary: concatenate all plugins with cordova.js
 Key: CB-6990
 URL: https://issues.apache.org/jira/browse/CB-6990
 Project: Apache Cordova
  Issue Type: Improvement
  Components: CordovaJS
Affects Versions: 3.5.0
Reporter: Anis Kadri
Assignee: Anis Kadri
 Fix For: 4.0.0


Use browserify to concatenate all plugins with cordova.js (instead of using 
dynamically loading cordova_plugins.js).

To make it backward compatible with existing plugins, use browserify transforms 
to change the path of the require() calls with real paths.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6024) nopt refactoring

2014-06-19 Thread Parashuram (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037971#comment-14037971
 ] 

Parashuram edited comment on CB-6024 at 6/19/14 9:59 PM:
-

This approach will also mean that adding additional command line parameters to 
platforms would require a CLI change. Given that Cordova is moving towards 
releasing the platforms and the CLI separately, will that not be a problem ? 

How about the unknown params passed downstream so that the platforms can handle 
it? 


was (Author: axemclion):
This approach will also mean that adding additional command line parameters to 
platforms would require a CLI change. Given that Cordova is moving towards 
releasing the platforms and the CLI separately, will that not be a problem ? 

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6024) nopt refactoring

2014-06-19 Thread Parashuram (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037971#comment-14037971
 ] 

Parashuram commented on CB-6024:


This approach will also mean that adding additional command line parameters to 
platforms would require a CLI change. Given that Cordova is moving towards 
releasing the platforms and the CLI separately, will that not be a problem ? 

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6988) [WP8][cordova-plugin-file] add readAsBinaryString support native

2014-06-19 Thread Martin Gonzalez (JIRA)
Martin Gonzalez created CB-6988:
---

 Summary: [WP8][cordova-plugin-file] add readAsBinaryString support 
native
 Key: CB-6988
 URL: https://issues.apache.org/jira/browse/CB-6988
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, WP8
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Martin Gonzalez
 Fix For: 3.6.0


There's no support for this method on the native side, it would be nice to have 
them working for the next release.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6989) [WP8][cordova-plugin-file] add readAsArrayBuffer support native

2014-06-19 Thread Martin Gonzalez (JIRA)
Martin Gonzalez created CB-6989:
---

 Summary: [WP8][cordova-plugin-file] add readAsArrayBuffer support 
native
 Key: CB-6989
 URL: https://issues.apache.org/jira/browse/CB-6989
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, WP8
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Martin Gonzalez
 Fix For: 3.6.0


It would be nice to have this functionality on the native side of WP8.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-3571) Add support for elements in config.xml

2014-06-19 Thread Axel Nennker (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037933#comment-14037933
 ] 

Axel Nennker commented on CB-3571:
--

Changed the indentation from 2 to 4 spaces although I prefer Mozilla's 2 space 
guideline.
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Indentation

Where would a shared function live or would the fireos_parser do a:
require('./android_parser').handleLauncherIcons(config);

> Add support for  elements in config.xml
> ---
>
> Key: CB-3571
> URL: https://issues.apache.org/jira/browse/CB-3571
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: CLI
>Affects Versions: Master
>Reporter: Michael Brooks
>Assignee: Lorin Beer
>
> Similar to adding support for the {{}} element, we should add support 
> for the splash screen.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6987) [cordova-plugin-file] error writing file when data is an URI reference in WP8

2014-06-19 Thread Martin Gonzalez (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Gonzalez updated CB-6987:


Description: 
When using File API  to write a file and as data to write that file reference 
it's a reference instead of the data, or the data is instance of a File or 
Blob, the right workflow is read the source file, get the data, to later write 
it to the new file.
Over WP8, is not possible use that workflow using readAsDataURL.
Found through mobilespec File tests.


  was:
When using File API  to write a file and as data to write that file reference 
it's a reference instead of the data, or the data is instance of a File or 
Blob, the right workflow is read the source file, get the data, to later write 
it to the new file.
Over WP8, is not possible use that workflow.
Found through mobilespec File tests.



> [cordova-plugin-file] error writing file when data is an URI reference in WP8
> -
>
> Key: CB-6987
> URL: https://issues.apache.org/jira/browse/CB-6987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: WP8, plugin-file
> Fix For: 3.6.0
>
>
> When using File API  to write a file and as data to write that file reference 
> it's a reference instead of the data, or the data is instance of a File or 
> Blob, the right workflow is read the source file, get the data, to later 
> write it to the new file.
> Over WP8, is not possible use that workflow using readAsDataURL.
> Found through mobilespec File tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6987) [cordova-plugin-file] error writing file when data is an URI reference in WP8

2014-06-19 Thread Martin Gonzalez (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Gonzalez updated CB-6987:


Summary: [cordova-plugin-file] error writing file when data is an URI 
reference in WP8  (was: [cordova-plugin-file] error writing file when data is 
URI reference in WP8)

> [cordova-plugin-file] error writing file when data is an URI reference in WP8
> -
>
> Key: CB-6987
> URL: https://issues.apache.org/jira/browse/CB-6987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: WP8, plugin-file
> Fix For: 3.6.0
>
>
> When using File API  to write a file and as data to write that file reference 
> it's a reference instead of the data, or the data is instance of a File or 
> Blob, the right workflow is read the source file, get the data, to later 
> write it to the new file.
> Over WP8, is not possible use that workflow.
> Found through mobilespec File tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6987) [cordova-plugin-file] error writing file when data is URI reference in WP8

2014-06-19 Thread Martin Gonzalez (JIRA)
Martin Gonzalez created CB-6987:
---

 Summary: [cordova-plugin-file] error writing file when data is URI 
reference in WP8
 Key: CB-6987
 URL: https://issues.apache.org/jira/browse/CB-6987
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, WP8
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Martin Gonzalez
 Fix For: 3.6.0


When using File API  to write a file and as data to write that file reference 
it's a reference instead of the data, or the data is instance of a File or 
Blob, the right workflow is read the source file, get the data, to later write 
it to the new file.
Over WP8, is not possible use that workflow.
Found through mobilespec File tests.




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6936) app crashes if webview is destroyed while dialog box open

2014-06-19 Thread Shingo Toda (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037877#comment-14037877
 ] 

Shingo Toda commented on CB-6936:
-

When I try {{webView.getContext()}} for "destroyed" check, it returns our 
MainActivity so unfortunately app still crashes. Do you know the reason?

Also I looked into SDK source code but it's bit hard to know how context field 
is set to null.

> app crashes if webview is destroyed while dialog box open
> -
>
> Key: CB-6936
> URL: https://issues.apache.org/jira/browse/CB-6936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.4.0
> Environment: Android 4.x on physical device
> Or any Android environment
>Reporter: Shingo Toda
>Assignee: Joe Bowser
>Priority: Minor
>
> We have an Android application which implements an embedded WebView 
> "container" in which it executes customer Cordova apps.
> Under certain conditions our container needs to terminate the customer app, 
> and during this termination it calls {{CordovaWebView.destroy()}} to disable 
> CordovaWebView.
> But application may entirely crash during this termination in some scenarios. 
> For example:
> # call {{navigator.notification.alert}}, {{confirm}} or {{prompt}} and leave 
> popup dialog open
> # this termination is done for some reason while dialog box is till open
> # all views on CordovaWebView are released but dialog box still remains
> # attempt to close dialog by pressing button in the dialog
> # application crashes with Unknown exception.
> {code}
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176): 81508: Unknown exception 
> occurred.
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176): java.lang.NullPointerException
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> android.webkit.WebView.setNetworkAvailable(WebView.java:2639)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> org.apache.cordova.NativeToJsMessageQueue$OnlineEventsBridgeMode$1.run(NativeToJsMessageQueue.java:305)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> android.app.Activity.runOnUiThread(Activity.java:4175)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> org.apache.cordova.NativeToJsMessageQueue$OnlineEventsBridgeMode.onNativeToJsMessageAvailable(NativeToJsMessageQueue.java:313)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> org.apache.cordova.NativeToJsMessageQueue.enqueueMessage(NativeToJsMessageQueue.java:253)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> org.apache.cordova.NativeToJsMessageQueue.addPluginResult(NativeToJsMessageQueue.java:246)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> org.apache.cordova.CordovaWebView.sendPluginResult(CordovaWebView.java:572)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> org.apache.cordova.CallbackContext.sendPluginResult(CallbackContext.java:64)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> org.apache.cordova.dialogs.Notification$1$1.onClick(Notification.java:150)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at 
> com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
> {code}
> h2. Problem
> Obviously CordovaWebView is already not available but dialog still exists. If 
> a user press button in dialog, {{onClick()}} gets called and consequently 
> {{CordovaWebView.setNetworkAvailable()}} gets called to send message from 
> queue to JavaScript even though WebView is already destroyed. As a result, 
> entire application crashes.
> h3. Workaround
> We made a method to check if WebView is destroyed or not.
> {code}
> private boolean isWebViewDestroyed() {
>   final String url = webView.getUrl();
>   if (url == null ||
>   url.equals("about:blank")) {
>   return true;
>   } else {
>   return false;
>   }
> }
> {code}
> And check this before {{callbackContext.sendPluginResult()}} is called.
> {code}
> public synchronized void alert(final String message, final String title, 
> final String buttonLabel, final CallbackContext callbackContext) {
> final CordovaInterface cordova = this.cordova;
> Runnable runnable = new Runnable() {
> public void run() {
> AlertDialog.Builder dlg = new 
> AlertDialog.Builder(cordova.getActivity());
> dlg.setMessage(message);
> dlg.setTitle(title);
> dlg.setCancelable(true);
> dlg.setPositiveButton(buttonLabel,
> new AlertDialog.OnClickListener() {
> public void onClick(DialogInterface dialog, int 
> which) {
> dialog.dismiss();
> 

[jira] [Commented] (CB-6962) Port globalization tests to plugin-test-framework

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037846#comment-14037846
 ] 

ASF GitHub Bot commented on CB-6962:


GitHub user stacic opened a pull request:

https://github.com/apache/cordova-plugin-globalization/pull/12

CB-6962 globalization tests for test-framework



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stacic/cordova-plugin-globalization cdvtest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-globalization/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 3057362b293f664c135739d2b94a85fea282e2c4
Author: Staci Cooper 
Date:   2014-06-19T20:41:39Z

CB-6962 globalization tests for test-framework




> Port globalization tests to plugin-test-framework
> -
>
> Key: CB-6962
> URL: https://issues.apache.org/jira/browse/CB-6962
> Project: Apache Cordova
>  Issue Type: Test
>  Components: Plugin Globalization
>Reporter: Staci Cooper
>Assignee: Staci Cooper
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037832#comment-14037832
 ] 

Joe Bowser commented on CB-6982:


If you feel this strongly about this change, which is minor, you should discuss 
it on the dev list.

> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />" cordova should use basic drawable 
> folder, because doesn't matter of resolution, PPI, etc., so doesn't matter of 
> device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders in this 
> situation should be deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 icon file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6986) pin jshint

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037825#comment-14037825
 ] 

ASF GitHub Bot commented on CB-6986:


GitHub user jsoref opened a pull request:

https://github.com/apache/cordova-lib/pull/37

CB-6986 make npm run jshint work without a global jshint



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jsoref/cordova-lib cb_6986

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit a64032cc5a35a8a59cb97bd13f11013b742ed1fb
Author: Josh Soref 
Date:   2014-06-19T20:00:04Z

CB-6986 make npm run jshint work without a global jshint




> pin jshint
> --
>
> Key: CB-6986
> URL: https://issues.apache.org/jira/browse/CB-6986
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> Currently npm test and npm run jshint fail if jshint isn't installed globally.
> Apparently jshint has changed significantly between 2.4 and 2.5, so if we're 
> expecting people to have consistent output, we should select a specific 
> version of jshint and depend on it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6986) pin jshint

2014-06-19 Thread Josh Soref (JIRA)
Josh Soref created CB-6986:
--

 Summary: pin jshint
 Key: CB-6986
 URL: https://issues.apache.org/jira/browse/CB-6986
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref


Currently npm test and npm run jshint fail if jshint isn't installed globally.

Apparently jshint has changed significantly between 2.4 and 2.5, so if we're 
expecting people to have consistent output, we should select a specific version 
of jshint and depend on it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037823#comment-14037823
 ] 

Jan Velecký commented on CB-6982:
-

Copy icon only to drawable folder have the same effect, but size of application 
is smaller. What do you not understand? There are only one icon of specific 
dimension. Why that icon should be there five times? Then why not add it also 
into xxhdpi and xxxhdpi. More is better... Of course...

> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />" cordova should use basic drawable 
> folder, because doesn't matter of resolution, PPI, etc., so doesn't matter of 
> device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders in this 
> situation should be deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 icon file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6024) nopt refactoring

2014-06-19 Thread Mark Koudritsky (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037815#comment-14037815
 ] 

Mark Koudritsky commented on CB-6024:
-

One options would be

cordova emulate windows --vm=store 
cordova emulate windows --flavor=phone

This way CLI only knows about --flavor flag and we can expand the set of its 
possible values in the platform without any changes in CLI.
We can probably come up with a better name than "flavor" :)
Some possible names --type, --variant, --emulator, --vm
--vm is my favorite.


> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6024) nopt refactoring

2014-06-19 Thread Mark Koudritsky (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037815#comment-14037815
 ] 

Mark Koudritsky edited comment on CB-6024 at 6/19/14 8:21 PM:
--

One options would be

cordova emulate windows --flavor=store 
cordova emulate windows --flavor=phone

This way CLI only knows about --flavor flag and we can expand the set of its 
possible values in the platform without any changes in CLI.
We can probably come up with a better name than "flavor" :)
Some possible names --type, --variant, --emulator, --vm
--vm is my favorite.



was (Author: kamrik):
One options would be

cordova emulate windows --vm=store 
cordova emulate windows --flavor=phone

This way CLI only knows about --flavor flag and we can expand the set of its 
possible values in the platform without any changes in CLI.
We can probably come up with a better name than "flavor" :)
Some possible names --type, --variant, --emulator, --vm
--vm is my favorite.


> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6985) [android] check requirements broken

2014-06-19 Thread Lorin Beer (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lorin Beer updated CB-6985:
---

Description: 
CLI attempts to create android project even when SDK/env-vars are not present.

steps to replicate

1. remove 'android' tool from path
2. $ cordova create foo && cd foo
3. $ cordova platform add android

depending on what you removed from your path (android, android tools, ant, etc) 
the output looks something like this
'''
Creating android project...

/Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/node_modules/q/q.js:126
throw e;
  ^
Error: ERROR : executing command 'ant', make sure you have ant installed and 
added to your path.
at 
/Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/lib/check_reqs.js:47:27
at ChildProcess.exithandler (child_process.js:651:7)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Socket. (child_process.js:966:11)
at Socket.EventEmitter.emit (events.js:95:17)
at Pipe.close (net.js:465:12)
Error: /Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/create: Command 
failed with exit code 8
at ChildProcess.whenDone 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/superspawn.js:131:23)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Process.ChildProcess._handle.onexit (child_process.js:820:5)


### solution 

fix so error are not generated by attempting to create platform projects when 
the platform is invalid for the dev OS or not present.

  was:
CLI attempts to create android project even when SDK/env-vars are not present.

### steps to replicate

1. remove 'android' tool from path
2. $ cordova create foo && cd foo
3. $ cordova platform add android

depending on what you removed from your path (android, android tools, ant, etc) 
the output looks something like this
'''
Creating android project...

/Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/node_modules/q/q.js:126
throw e;
  ^
Error: ERROR : executing command 'ant', make sure you have ant installed and 
added to your path.
at 
/Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/lib/check_reqs.js:47:27
at ChildProcess.exithandler (child_process.js:651:7)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Socket. (child_process.js:966:11)
at Socket.EventEmitter.emit (events.js:95:17)
at Pipe.close (net.js:465:12)
Error: /Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/create: Command 
failed with exit code 8
at ChildProcess.whenDone 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/superspawn.js:131:23)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Process.ChildProcess._handle.onexit (child_process.js:820:5)


### solution 

fix so error are not generated by attempting to create platform projects when 
the platform is invalid for the dev OS or not present.


> [android] check requirements broken
> ---
>
> Key: CB-6985
> URL: https://issues.apache.org/jira/browse/CB-6985
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.5.0
>Reporter: Lorin Beer
>Assignee: Lorin Beer
>
> CLI attempts to create android project even when SDK/env-vars are not present.
> steps to replicate
> 1. remove 'android' tool from path
> 2. $ cordova create foo && cd foo
> 3. $ cordova platform add android
> depending on what you removed from your path (android, android tools, ant, 
> etc) the output looks something like this
> '''
> Creating android project...
> /Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/node_modules/q/q.js:126
> throw e;
>   ^
> Error: ERROR : executing command 'ant', make sure you have ant installed and 
> added to your path.
> at 
> /Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/lib/check_reqs.js:47:27
> at ChildProcess.exithandler (child_process.js:651:7)
> at ChildProcess.EventEmitter.emit (events.js:98:17)
> at maybeClose (child_process.js:753:16)
> at Socket. (child_process.js:966:11)
> at Socket.EventEmitter.emit (events.js:95:17)
> at Pipe.close (net.js:465:12)
> Error: /Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/create: Command 
> failed with exit code 8
> at ChildProcess.whenDone 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/superspawn.js:131:23)
> at ChildProcess.EventEmitter.emit (events.js:98:17)
> at maybeClose (child_process.js:753:16)
> at Process.ChildProcess._handle.onexit (child_process.js:820:5)
> ### solution 
> fix 

[jira] [Commented] (CB-3445) Move Cordova-Android Build Setup to Gradle

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037806#comment-14037806
 ] 

ASF subversion and git services commented on CB-3445:
-

Commit 0ffb5d253a09ece5b0af22b78079a67f809423ae in cordova-android's branch 
refs/heads/4.0.x from [~iclelland]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=0ffb5d2 ]

CB-3445: android: Copy Gradle wrapper from Android SDK rather than bundling a 
JAR


> Move Cordova-Android Build Setup to Gradle
> --
>
> Key: CB-3445
> URL: https://issues.apache.org/jira/browse/CB-3445
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Ian Clelland
>Priority: Minor
>
> Currently we're using ant for our setup, and our setup can break every time 
> that the Android SDK updates and change its build.xml.  However, the Android 
> Team has created Gradle to be more robust such that it doesn't have the same 
> problems as ant-based scripts.
> This also has the advantage of using Android Studio for development instead 
> of Eclipse, and the ability for us to bundle resources, which is something we 
> haven't been able to do before.
> Moving to Gradle has numerous advantages, but will break scripts, so this is 
> to be moved in the post-3.0 timeframe.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037792#comment-14037792
 ] 

Joe Bowser edited comment on CB-6982 at 6/19/14 8:08 PM:
-

Ah, that was a typo.  This is actually supposed to happen.  The creation of the 
drawable folders and the copying of the icon is not a bug.


was (Author: bowserj):
Ah, that was a typo.  This is actually supposed to happen.  The creation of the 
drawable folders is not a bug.

> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />" cordova should use basic drawable 
> folder, because doesn't matter of resolution, PPI, etc., so doesn't matter of 
> device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders in this 
> situation should be deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 icon file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6024) nopt refactoring

2014-06-19 Thread Sergey Grebnov (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037775#comment-14037775
 ] 

Sergey Grebnov edited comment on CB-6024 at 6/19/14 8:07 PM:
-

What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate --store <-test windows8.1
cordova windows emulate --store80 <-test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '-- ' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--'. like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?


was (Author: sgrebnov):
What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate -- store <- test windows8.1
cordova windows emulate -- store80 <- test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '-- ' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--'. like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6098) Android app initiates long press on home screen before opening

2014-06-19 Thread Joe Bowser (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-6098.


Resolution: Not a Problem

This is a weird bug, but this is actually supposed to happen.  The script 
initiates this event to unlock the screen.

> Android app initiates long press on home screen before opening
> --
>
> Key: CB-6098
> URL: https://issues.apache.org/jira/browse/CB-6098
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CLI
>Affects Versions: 3.4.0, 3.5.0
> Environment: Linux build from CLI, occurs on both emulator and my 
> Nexus 4
>Reporter: Joe Archer
>Assignee: Joe Bowser
>
> When opening any app (including a build straight after "cordova create") just 
> before the app splash screen is shown, the app appears to initiate a long 
> press on the homescreen, triggering the wallpaper/widgets/settings Android 
> system overlay. This occurs on API 19 and 18 on both the emulator and 2 
> tested devices.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread Joe Bowser (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-6982.


Resolution: Won't Fix

Ah, that was a typo.  This is actually supposed to happen.  The creation of the 
drawable folders is not a bug.

> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />" cordova should use basic drawable 
> folder, because doesn't matter of resolution, PPI, etc., so doesn't matter of 
> device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders in this 
> situation should be deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 icon file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Reopened] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Velecký reopened CB-6982:
-


"The icon element is handled correctly in this instance."
Not.
Isn't, because there are not problem with creation of drawable folders, but 
with copying exact same icon into 5 folders intead of 1 folder. I describe bug 
in description paragraph.

> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />" cordova should use basic drawable 
> folder, because doesn't matter of resolution, PPI, etc., so doesn't matter of 
> device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders in this 
> situation should be deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 icon file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6024) nopt refactoring

2014-06-19 Thread Sergey Grebnov (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037775#comment-14037775
 ] 

Sergey Grebnov edited comment on CB-6024 at 6/19/14 8:02 PM:
-

What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate -- store <- test windows8.1
cordova windows emulate -- store80 <- test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '-- ' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--'. like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?


was (Author: sgrebnov):
What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate --store <- test windows8.1
cordova windows emulate --store80 <- test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '--' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--'. like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-6024) nopt refactoring

2014-06-19 Thread Sergey Grebnov (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037775#comment-14037775
 ] 

Sergey Grebnov edited comment on CB-6024 at 6/19/14 8:01 PM:
-

What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate --store <- test windows8.1
cordova windows emulate --store80 <- test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '--' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--'. like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?


was (Author: sgrebnov):
What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate --store <- test windows8.1
cordova windows emulate --store80 <- test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '--' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--', like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6024) nopt refactoring

2014-06-19 Thread Sergey Grebnov (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037775#comment-14037775
 ] 

Sergey Grebnov commented on CB-6024:


What is the recommended way of adding additional platform specific parameters 
after this change? For example, for Windows 8.1 and Universal Apps whether we 
will support both Windows 8.1 and Windows Phone 8.1 we will want to add 
additional parameter to 'cordova emulate' to specify whether to run build on 
Windows or Windows Phone, for example

cordova windows emulate --phone <-test windows phone 8.1
cordova windows emulate --store <- test windows8.1
cordova windows emulate --store80 <- test windows8

Right now all new unknown parameters are ignored and not passed to downstream. 
I see that special '--' arg could be used to pass additional ars but I don't 
think this will be very nature to require users to use '--', like
cordova windows emulate -- --phone

So it looks like any change in supported platform args will require cordova-cli 
update. So we won't be able to release platform w/o releasing cordova-cli.

Any recommendations or ideas?

> nopt refactoring
> 
>
> Key: CB-6024
> URL: https://issues.apache.org/jira/browse/CB-6024
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Affects Versions: 3.3.0
> Environment: Windows, Mac OSX
>Reporter: Jonathan Bond
>Assignee: Mark Koudritsky
>  Labels: patch
> Fix For: 3.6.0
>
>
> As per mailing list:
> - Refactoring cli to use nopt. 
> - Several improvements to the install/uninstall tests to touch the file 
> system.
> - Consistency improvements in the code



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6953) Error on building android project. Semicolon expected

2014-06-19 Thread Joe Bowser (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-6953.


Resolution: Fixed

This has already been fixed on Master

https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=141bbfb05134bdd11e262d879bbd253bf4479519

> Error on building android project. Semicolon expected
> -
>
> Key: CB-6953
> URL: https://issues.apache.org/jira/browse/CB-6953
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CLI
>Affects Versions: 3.5.0
> Environment: Windows 7 64bit
>Reporter: Rick Gommers
> Fix For: 3.6.0
>
>
> I just installed Cordova 3.5.0-0.2.4.
> Created fresh android project, tried to run it and this was the result:
> -compile:
> [javac] Compiling 3 source files to 
> C:\CordovaProjects\menukaart\platforms\android\ant-build\classes
> [javac] 
> C:\CordovaProjects\menukaart\platforms\android\src\com\23ivh12b3b4\menukaart\MenuKaart.java:20:
>  error: ';' expected
> [javac] package com.23ivh12b3b4.menukaart;
> [javac]^
> [javac] 
> C:\CordovaProjects\menukaart\platforms\android\ant-gen\com\23ivh12b3b4\menukaart\BuildConfig.java:2:
>  error: ';' expected
> [javac] package com.23ivh12b3b4.menukaart;
> [javac]^
> [javac] 
> C:\CordovaProjects\menukaart\platforms\android\ant-gen\com\23ivh12b3b4\menukaart\R.java:8:
>  error: ';' expected
> [javac] package com.23ivh12b3b4.menukaart;
> [javac]^
> [javac] 3 errors
> BUILD FAILED
> C:\Eclipse\sdk\tools\ant\build.xml:720: The following error occurred while 
> executing this line:
> C:\Eclipse\sdk\tools\ant\build.xml:734: Compile failed; see the compiler 
> error output for details.
> Total time: 3 seconds
> C:\CordovaProjects\menukaart\platforms\android\cordova\node_modules\q\q.js:126
> throw e;
>   ^
> Error code 1 for command: cmd with args: 
> /s,/c,ant,debug,-f,C:\CordovaProjects\menukaart\platforms\android\build.xml,-Dout.dir=ant-build,-Dgen.absolute.dir=ant-
> gen
> Command finished with error code 8: 
> C:\CordovaProjects\menukaart\platforms\android\cordova\run.bat
> Error: C:\CordovaProjects\menukaart\platforms\android\cordova\run.bat: 
> Command failed with exit code 8
> at ChildProcess.whenDone 
> (C:\Users\RICKGO~1\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\superspawn.js:131:23)
> at ChildProcess.EventEmitter.emit (events.js:98:17)
> at maybeClose (child_process.js:735:16)
> at Process.ChildProcess._handle.onexit (child_process.js:802:5)
> C:\CordovaProjects\menukaart>cordova -v
> 3.5.0-0.2.4



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5971) cordova create temp something.default will break android badly

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037743#comment-14037743
 ] 

ASF subversion and git services commented on CB-5971:
-

Commit 141bbfb05134bdd11e262d879bbd253bf4479519 in cordova-android's branch 
refs/heads/master from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=141bbfb ]

CB-5971: This would have been a good first bug, too bad


> cordova create temp something.default will break android badly
> --
>
> Key: CB-5971
> URL: https://issues.apache.org/jira/browse/CB-5971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CLI
>Affects Versions: 3.3.0
>Reporter: Josh Soref
>
> steps:
> {quote}
> {{cordova create temp something.default}}
> {{cd temp}}
> {{cordova platform add android}}
> {{cordova build}}
> {quote}
> expected results:
> if {{something.default}} is a bad name, then cordova create or the android 
> platform should tell me that in a clear way
> actual results:
> BUILD FAILED 
> adt-bundle-mac-x86_64-20130917/sdk/tools/ant/build.xml:720: The following 
> error occurred while executing this line: 
> adt-bundle-mac-x86_64-20130917/sdk/tools/ant/build.xml:734: Compile failed; 
> see the compiler error output for details. 
> Total time: 17 seconds 
> Error code 1 for command: ant with args: 
> debug,-f,/private/tmp/temp/platforms/android/build.xml,-Dout.dir=ant-build,-Dgen.absolute.dir=ant-gen
>  
> at ChildProcess. (cordova-cli/src/compile.js:65:22) 
> at ChildProcess.EventEmitter.emit (events.js:98:17) 
> at maybeClose (child_process.js:735:16) 
> at Socket. (child_process.js:948:11) 
> at Socket.EventEmitter.emit (events.js:95:17) 
> at Pipe.close (net.js:466:12) 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-4404) android:windowSoftInputMode does not work

2014-06-19 Thread Daniel Trebbien (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037738#comment-14037738
 ] 

Daniel Trebbien commented on CB-4404:
-

Ah, okay. Yes, I can confirm that "adjustResize" is the behavior when 
fullscreen is "false" and you don't add 
{{android:windowSoftInputMode="adjustPan"}} to the {{}} element.

> android:windowSoftInputMode does not work
> -
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-4404) android:windowSoftInputMode has no effect in full screen mode, and "adjustPan" does not work in non-full screen mode

2014-06-19 Thread Daniel Trebbien (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Trebbien updated CB-4404:


Summary: android:windowSoftInputMode has no effect in full screen mode, and 
"adjustPan" does not work in non-full screen mode  (was: 
android:windowSoftInputMode does not work)

> android:windowSoftInputMode has no effect in full screen mode, and 
> "adjustPan" does not work in non-full screen mode
> 
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Closed] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread Joe Bowser (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser closed CB-6982.
--

Resolution: Invalid

The icon element is handled correctly in this instance.  These folders are 
created so that if the user wishes they can put their own icons here, which I 
would recommend so the icon doesn't look like crap.

> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />" cordova should use basic drawable 
> folder, because doesn't matter of resolution, PPI, etc., so doesn't matter of 
> device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders in this 
> situation should be deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 icon file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-4404) android:windowSoftInputMode does not work

2014-06-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037731#comment-14037731
 ] 

Joe Bowser edited comment on CB-4404 at 6/19/14 7:33 PM:
-

Yeah, that's what I meant.  If you use adjustResize on the activity element, 
you can take advantage of hideKeyboard and showKeyboard events.  I believe it 
was using adjustResize all along, since this property was completely ignored 
before.


was (Author: bowserj):
Yeah, that's what I meant.  If you use adjustResize on the activity element, 
you can take advantage of hideKeyboard and showKeyboard events.  I believe it 
was using adjustResize all along, since it was being completely ignored before.

> android:windowSoftInputMode does not work
> -
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-4404) android:windowSoftInputMode does not work

2014-06-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037731#comment-14037731
 ] 

Joe Bowser commented on CB-4404:


Yeah, that's what I meant.  If you use adjustResize on the activity element, 
you can take advantage of hideKeyboard and showKeyboard events.  I believe it 
was using adjustResize all along, since it was being completely ignored before.

> android:windowSoftInputMode does not work
> -
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (CB-4404) android:windowSoftInputMode does not work

2014-06-19 Thread Daniel Trebbien (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037725#comment-14037725
 ] 

Daniel Trebbien edited comment on CB-4404 at 6/19/14 7:29 PM:
--

Hmmm. I am not sure that I know what "adjustPan seems to work on non-fullscreen 
mode, but we have no JS events!" means.

I am trying to use "adjustPan" with a PhoneGap 3.5.0 app with fullscreen = 
"false". Prompted by [Emanuele's comment|#comment-14029162], I added 
{{android:windowSoftInputMode="adjustPan"}} to the {{}} element and 
now when I run the app on a Nexus 7 (2013) tablet running Android 4.4.3, the 
soft keyboard is placed on top of the focused {{}} element, but the app 
doesn't pan upward so that the {{}} is visible. Is that what [you 
meant|#comment-14029538] by "OK, that doesn't fix the main problem"? Is this 
issue also under the umbrella of CB-4404?


was (Author: dtrebbien):
I am not sure that I know what "adjustPan seems to work on non-fullscreen mode, 
but we have no JS events!" means.

I am trying to use "adjustPan" with a PhoneGap 3.5.0 app with fullscreen = 
"false". Prompted by [Emanuele's comment|#comment-14029162], I added 
{{android:windowSoftInputMode="adjustPan"}} to the {{}} element and 
now when I run the app on a Nexus 7 (2013) tablet running Android 4.4.3, the 
soft keyboard is placed on top of the focused {{}} element, but the app 
doesn't pan upward so that the {{}} is visible. Is that what [you 
meant|#comment-14029538] by "OK, that doesn't fix the main problem"? Is this 
issue also under the umbrella of CB-4404?

> android:windowSoftInputMode does not work
> -
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-4404) android:windowSoftInputMode does not work

2014-06-19 Thread Daniel Trebbien (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037725#comment-14037725
 ] 

Daniel Trebbien commented on CB-4404:
-

I am not sure that I know what "adjustPan seems to work on non-fullscreen mode, 
but we have no JS events!" means.

I am trying to use "adjustPan" with a PhoneGap 3.5.0 app with fullscreen = 
"false". Prompted by [Emanuele's comment|#comment-14029162], I added 
{{android:windowSoftInputMode="adjustPan"}} to the {{}} element and 
now when I run the app on a Nexus 7 (2013) tablet running Android 4.4.3, the 
soft keyboard is placed on top of the focused {{}} element, but the app 
doesn't pan upward so that the {{}} is visible. Is that what [you 
meant|#comment-14029538] by "OK, that doesn't fix the main problem"? Is this 
issue also under the umbrella of CB-4404?

> android:windowSoftInputMode does not work
> -
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037700#comment-14037700
 ] 

ASF GitHub Bot commented on CB-5059:


Github user clelland commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/8#issuecomment-46603710
  
Junmin, can you comment any more on this? I'm not sure what the root issue 
is? Does the current filetransfer plugin cause a crash with the crosswalk 
backend? If so, can we create a test case for that?

We definitely do want to keep cookie support for filetransfer, so if there 
are changes needed to the Cordova Crosswalk Webview to enable cookies, then I'd 
like to fix it there.


> The android implementation of file transfer plugin should not depend on the 
> concrete class android.webkit.CookieManager
> ---
>
> Key: CB-5059
> URL: https://issues.apache.org/jira/browse/CB-5059
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: Master
> Environment: cordova-android, git branch 3.0.x
>Reporter: Junmin
> Fix For: Master
>
>
> The android implementation of file transfer plugin leverages the class 
> android.webkit.CookieManager, which depends on the concrete web 
> infrastructure android.webkit.WebView. This dependence ruins the portability 
> of the plugin. For example, it could not run on a substantial implementation 
> of CordovaWebView which based on a android third party component(such as 
> chromium for android).
> Following is the crash log when initializing the CookieManager without 
> android.webkit.WebView:
> I/dalvikvm(5006): java.lang.IllegalStateException: Call 
> CookieSyncManager::createInstance() or create a webview before using this 
> class
> I/dalvikvm(5006):   at 
> android.webkit.JniUtil.checkInitialized(JniUtil.java:44)
> I/dalvikvm(5006):   at 
> android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.nativeGetCookie(Native Method)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96)
> I/dalvikvm(5006):   at 
> org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6985) [android] check requirements broken

2014-06-19 Thread Lorin Beer (JIRA)
Lorin Beer created CB-6985:
--

 Summary: [android] check requirements broken
 Key: CB-6985
 URL: https://issues.apache.org/jira/browse/CB-6985
 Project: Apache Cordova
  Issue Type: Bug
  Components: CLI
Affects Versions: 3.5.0
Reporter: Lorin Beer
Assignee: Lorin Beer


CLI attempts to create android project even when SDK/env-vars are not present.

### steps to replicate

1. remove 'android' tool from path
2. $ cordova create foo && cd foo
3. $ cordova platform add android

depending on what you removed from your path (android, android tools, ant, etc) 
the output looks something like this
'''
Creating android project...

/Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/node_modules/q/q.js:126
throw e;
  ^
Error: ERROR : executing command 'ant', make sure you have ant installed and 
added to your path.
at 
/Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/lib/check_reqs.js:47:27
at ChildProcess.exithandler (child_process.js:651:7)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Socket. (child_process.js:966:11)
at Socket.EventEmitter.emit (events.js:95:17)
at Pipe.close (net.js:465:12)
Error: /Users/lorin/.cordova/lib/android/cordova/3.5.0/bin/create: Command 
failed with exit code 8
at ChildProcess.whenDone 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/superspawn.js:131:23)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Process.ChildProcess._handle.onexit (child_process.js:820:5)


### solution 

fix so error are not generated by attempting to create platform projects when 
the platform is invalid for the dev OS or not present.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6698) Plugman support for referencing Android libraries

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037679#comment-14037679
 ] 

ASF subversion and git services commented on CB-6698:
-

Commit e59181b51c12ea19c4824903909fdd3bc0302b8e in cordova-lib's branch 
refs/heads/master from [~mbektchiev]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=e59181b ]

CB-6698: Fix 'android update lib-project' to work with paths containing spaces

github: close #36


> Plugman support for referencing Android libraries
> -
>
> Key: CB-6698
> URL: https://issues.apache.org/jira/browse/CB-6698
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugman
>Reporter: Martin Bektchiev
>Assignee: Martin Bektchiev
>
> Make plugman capable of referencing an Android library project from within a 
> plugin. 
> Currently there's no viable way to do it and it is becoming common to try to 
> circumvent this limitation by abusing *plugin.xml* to (try to) merge a 
> library's resources, code and configuration. (see 
> https://github.com/wildabeast/BarcodeScanner)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6698) Plugman support for referencing Android libraries

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037680#comment-14037680
 ] 

ASF GitHub Bot commented on CB-6698:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/36


> Plugman support for referencing Android libraries
> -
>
> Key: CB-6698
> URL: https://issues.apache.org/jira/browse/CB-6698
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugman
>Reporter: Martin Bektchiev
>Assignee: Martin Bektchiev
>
> Make plugman capable of referencing an Android library project from within a 
> plugin. 
> Currently there's no viable way to do it and it is becoming common to try to 
> circumvent this limitation by abusing *plugin.xml* to (try to) merge a 
> library's resources, code and configuration. (see 
> https://github.com/wildabeast/BarcodeScanner)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-4404) android:windowSoftInputMode does not work

2014-06-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037672#comment-14037672
 ] 

Joe Bowser commented on CB-4404:


1. adjustResize works in non-fullscreen mode and events fire! 
2. adjustPan seems to work on non-fullscreen mode, but we have no JS events!
3. Neither work on Full Screen mode.

I'm fine with a better title, since I know what the bug is, but others don't. :S

> android:windowSoftInputMode does not work
> -
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-4404) android:windowSoftInputMode does not work

2014-06-19 Thread Daniel Trebbien (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037660#comment-14037660
 ] 

Daniel Trebbien commented on CB-4404:
-

I know that this bug is kind of tracking two, distinct issues (fullscreen true 
versus false).  Mostly, though, this is about windowSoftInputMode having no 
effect in full screen mode, and can be summarized as:  (1) in full screen mode 
when windowSoftInputMode is set to "adjustPan", the app doesn't actually pan to 
reveal the focused  element and instead the soft keyboard is simply laid 
on top; and (2), in full screen mode when windowSoftInputMode is set to 
"adjustResize", the app is not resized down so that the app and the soft 
keyboard are side-by-side with the app on top of the soft keyboard.  I don't 
know what windowSoftInputMode setting this corresponds to (perhaps 
"stateVisible"?).

Would it be okay with others if I change the title of this issue to 
"android:windowSoftInputMode has no effect in full screen mode"?

> android:windowSoftInputMode does not work
> -
>
> Key: CB-4404
> URL: https://issues.apache.org/jira/browse/CB-4404
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 2.9.0
> Environment: * Mac OS 10.7.5
> * Android 4.1.2 and 4.2.2 emulator using Intel's x86 images
>Reporter: Daniel Trebbien
>Assignee: Andrew Grieve
>
> _I recently posted a description of this issue to the phonegap group at 
> [https://groups.google.com/d/topic/phonegap/J-h0lt68x0g/discussion]._
> I am testing out PhoneGap 2.9.0 in the Android emulator (using Intel's x86 
> images), and I am seeing the issue that the android:windowSoftInputMode 
> setting is not having an effect.  By default, the setting is set to 
> "adjustPan" in the generated project, but when I actually focus a text 
> , the soft keyboard appears on top of the app, but does not pan the 
> main window, and the  is usually hidden beneath the keyboard as a 
> result.
> Steps to reproduce:
> # Create a new PhoneGap 2.9.0 project using the {{cordova create}} utility.  
> Add the 'android' platform.
> # Open the project in Eclipse.
> # Edit {{index.html}} to add {{ placeholder="Text box">}} below the {{Apache Cordova}} heading.
> # Run the app in Android 4.1.2 or 4.2.2 emulator.
> # Tap the  and notice that the soft keyboard is placed over the app 
> and the  is hidden beneath.
> # Try changing the android:windowSoftInputMode setting in 
> {{AndroidManifest.xml}} to "adjustResize", reload the app, and notice that 
> the app is not resized when the  receives keyboard focus.
> I am seeing this problem in Android 4.1.2 and 4.2.2 emulator.  In Android 
> 4.0.3 emulator, the app pans as expected.
> The strange thing is that if I load the www/ files in the Browser and focus 
> the , then the window is resized to fit the soft keyboard like normal. 
>  This seems to imply that android:windowSoftInputMode works fine in the 
> emulator, but there is some issue in PhoneGap that is preventing it from 
> working.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6698) Plugman support for referencing Android libraries

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037567#comment-14037567
 ] 

ASF GitHub Bot commented on CB-6698:


GitHub user mbektchiev opened a pull request:

https://github.com/apache/cordova-lib/pull/36

CB-6698 Fix 'android update lib-project' command to work with paths 
containing spaces



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Icenium/cordova-lib 
bektchiev/fix-android-lib-paths-with-spaces

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit f48e9b5d633ef212969a57053b7af1abaa71a129
Author: Martin Bektchiev 
Date:   2014-06-19T17:29:15Z

CB-6698 Fix 'android update lib-project' command to work with paths 
containing spaces




> Plugman support for referencing Android libraries
> -
>
> Key: CB-6698
> URL: https://issues.apache.org/jira/browse/CB-6698
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugman
>Reporter: Martin Bektchiev
>Assignee: Martin Bektchiev
>
> Make plugman capable of referencing an Android library project from within a 
> plugin. 
> Currently there's no viable way to do it and it is becoming common to try to 
> circumvent this limitation by abusing *plugin.xml* to (try to) merge a 
> library's resources, code and configuration. (see 
> https://github.com/wildabeast/BarcodeScanner)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6280) improve integration with plugin docs

2014-06-19 Thread Steve Gill (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-6280.


Resolution: Fixed

> improve integration with plugin docs
> 
>
> Key: CB-6280
> URL: https://issues.apache.org/jira/browse/CB-6280
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Registry, Registry Web
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> Right now, we expose the readme for each plugin. Either the docs of the 
> plugins are going to get merged into the readme or we need to expose the docs 
> at publish time and then display them on the plugin details page



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6611) [Release + 3.5.0] Announce Release

2014-06-19 Thread Steve Gill (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-6611.


Resolution: Fixed

> [Release + 3.5.0] Announce Release
> --
>
> Key: CB-6611
> URL: https://issues.apache.org/jira/browse/CB-6611
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Amazon FireOS, Android, App Hello World, BlackBerry, 
> CLI, CordovaJS, Docs, FirefoxOS, iOS, mobile-spec, Ubuntu, Windows 8, WP8
>Reporter: Steve Gill
>Assignee: Steve Gill
> Fix For: 3.6.0
>
>
> Refer to Workflow here:
> http://wiki.apache.org/cordova/CuttingReleases



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6586) [Release + 3.5.0] Parent Issue

2014-06-19 Thread Steve Gill (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-6586.


Resolution: Fixed

> [Release + 3.5.0] Parent Issue
> --
>
> Key: CB-6586
> URL: https://issues.apache.org/jira/browse/CB-6586
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Amazon FireOS, Android, App Hello World, BlackBerry, 
> CLI, CordovaJS, Docs, FirefoxOS, iOS, mobile-spec, Ubuntu, Windows 8, WP8
>Reporter: Steve Gill
>Assignee: Steve Gill
> Fix For: 3.6.0
>
>
> Parent bug for the 3.5.0 Cordova Release.
> Workflow here:
> http://wiki.apache.org/cordova/CuttingReleases
> Release Master: ?
> Component Leads: Refer to assignee of "Test & Tag" sub-tasks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6610) [Release + 3.5.0] Change default docs to new version

2014-06-19 Thread Steve Gill (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-6610.


Resolution: Fixed

> [Release + 3.5.0] Change default docs to new version
> 
>
> Key: CB-6610
> URL: https://issues.apache.org/jira/browse/CB-6610
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Docs
>Reporter: Steve Gill
> Fix For: 3.6.0
>
>
> Refer to Workflow here:
> http://wiki.apache.org/cordova/CuttingReleases



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (CB-6609) [Release + 3.5.0] Upload signed release .zip to Apache Dist

2014-06-19 Thread Steve Gill (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-6609.


Resolution: Fixed

> [Release + 3.5.0] Upload signed release .zip to Apache Dist
> ---
>
> Key: CB-6609
> URL: https://issues.apache.org/jira/browse/CB-6609
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Amazon FireOS, Android, App Hello World, BlackBerry, 
> CLI, CordovaJS, Docs, FirefoxOS, iOS, mobile-spec, Ubuntu, Windows 8, WP8
>Reporter: Steve Gill
> Fix For: 3.6.0
>
>
> Refer to Workflow here:
> http://wiki.apache.org/cordova/CuttingReleases



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6984) requestFileSystem does not always return after document reload

2014-06-19 Thread Zarko Hristovski (JIRA)
Zarko Hristovski created CB-6984:


 Summary: requestFileSystem does not always return after document 
reload
 Key: CB-6984
 URL: https://issues.apache.org/jira/browse/CB-6984
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File
Affects Versions: 3.5.0
 Environment: Experienced on Android Nexus 5
File plugin 1.2.0
Reporter: Zarko Hristovski
 Attachments: fsreload.zip

Once in a while we need to reload the application ( document ) because a part 
of it is dynamic - downloaded from a server and injected into the app.

The problem is that sometimes and quite often, our app won't be able to compete 
its initialization since requestFileSystem neither succeeds nor fails, it just 
hangs there. This happens after location.reload(). It seems like some sort of 
timing issue and the number of attempts does not actually matter.

I'll include a slightly modified "hello world" app that should show the problem.

This doesn't seem to affect iOS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6984) requestFileSystem does not always return after document reload

2014-06-19 Thread Zarko Hristovski (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zarko Hristovski updated CB-6984:
-

Attachment: fsreload.zip

Test app ( based on the "Hello World" app )

> requestFileSystem does not always return after document reload
> --
>
> Key: CB-6984
> URL: https://issues.apache.org/jira/browse/CB-6984
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 3.5.0
> Environment: Experienced on Android Nexus 5
> File plugin 1.2.0
>Reporter: Zarko Hristovski
> Attachments: fsreload.zip
>
>
> Once in a while we need to reload the application ( document ) because a part 
> of it is dynamic - downloaded from a server and injected into the app.
> The problem is that sometimes and quite often, our app won't be able to 
> compete its initialization since requestFileSystem neither succeeds nor 
> fails, it just hangs there. This happens after location.reload(). It seems 
> like some sort of timing issue and the number of attempts does not actually 
> matter.
> I'll include a slightly modified "hello world" app that should show the 
> problem.
> This doesn't seem to affect iOS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6959) Port capture tests to plugin-test-framework

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037532#comment-14037532
 ] 

ASF GitHub Bot commented on CB-6959:


GitHub user SSRico opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/19

CB-6959] Port capture tests to plugin-test-framework

Ported capture tests from mobile-spec to the new test framework working
with jasmine 2.0.

Added:
-New js-module named tests to plugin.xml
-Folder with tests.js

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SSRico/cordova-plugin-media-capture CB-6959

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit b2320e39d005e93787794e7f6fe64cfaf7071d46
Author: Samir Silva 
Date:   2014-06-19T18:59:57Z

CB-6959] Port capture tests to plugin-test-framework

Ported capture tests from mobile-spec to the new test framework working
with jasmine 2.0.

Added:
-New js-module named tests to plugin.xml
-Folder with tests.js




> Port capture tests to plugin-test-framework
> ---
>
> Key: CB-6959
> URL: https://issues.apache.org/jira/browse/CB-6959
> Project: Apache Cordova
>  Issue Type: Test
>  Components: Plugin Media Capture
>Reporter: Staci Cooper
>Assignee: Staci Cooper
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037527#comment-14037527
 ] 

ASF subversion and git services commented on CB-6973:
-

Commit 5332be8f6691ba53794e42d8e0637389a213fbd9 in cordova-lib's branch 
refs/heads/master from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=5332be8 ]

CB-6973: Fix JSHint errors in ConfigParse

Also a minor bug fix in findOrCreate().


> Use JSHint in Cordova CLI tools
> ---
>
> Key: CB-6973
> URL: https://issues.apache.org/jira/browse/CB-6973
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037529#comment-14037529
 ] 

ASF subversion and git services commented on CB-6973:
-

Commit ad086b9bb678e964743e163b910aad1a97044934 in cordova-lib's branch 
refs/heads/master from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=ad086b9 ]

CB-6973: Run JSHint on all code in src/ via npm test

"npm test" will nor run "jshing src" if the jasmine stage completes
with no errors.

Specs are not covered by JSHint for now.


> Use JSHint in Cordova CLI tools
> ---
>
> Key: CB-6973
> URL: https://issues.apache.org/jira/browse/CB-6973
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037528#comment-14037528
 ] 

ASF subversion and git services commented on CB-6973:
-

Commit 682d46d8847a610ae79674180d419619b374146c in cordova-lib's branch 
refs/heads/master from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=682d46d ]

CB-6973: Fix JSHint errors in cordova/metadata/*

All files in src pass JSHint clean now.
To run JSHint on all the js files, run
jshint src
from the root dir of cordova-lib package


> Use JSHint in Cordova CLI tools
> ---
>
> Key: CB-6973
> URL: https://issues.apache.org/jira/browse/CB-6973
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6935) [Android][cordova-plugin-file] window.resolveLocalFileSystemURL can't resolve cordova.file.applicationDirectory URL

2014-06-19 Thread Andrew Grieve (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037446#comment-14037446
 ] 

Andrew Grieve commented on CB-6935:
---

Make sure when you load your saved page that you do so from a file:/// URL and 
not a cdvfile: URL. The file plugin had some churn on this, but the latest 
version of it now always returns file: URLs for toURL() of a FileEntry (because 
of issues like this).

> [Android][cordova-plugin-file] window.resolveLocalFileSystemURL can't resolve 
> cordova.file.applicationDirectory URL
> ---
>
> Key: CB-6935
> URL: https://issues.apache.org/jira/browse/CB-6935
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, Plugin File
>Affects Versions: 1.2.0
> Environment: - Samsung I-9100 Intl (Cyanogenmod 10.2, android 4.3.1)
> - Samgsung GT-P5110 (Cyanogenmod 11, android 4.4.2)
>Reporter: Mestre Muten
>  Labels: easyfix, patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> As of version 1.2.0 of this plugin, some special directory paths were added 
> under cordova.file.*Directory.
> All of them seem to work, but "applicationDirectory" on Android platform 
> doesn't.
> This special directory equals "file:///android_asset/".
> It calls fail callback with error code = 1 (NOT_FOUND_ERR).
> For a simple test just call this on deviceready:
> window.resolveLocalFileSystemURL(cordova.file.applicationDirectory, 
> function(dirEntry){console.log('SUCCESS');},function(error){console.log('ERROR:
>  '+JSON.stringify(error));});



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6980) [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with filesystem: null

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037439#comment-14037439
 ] 

ASF GitHub Bot commented on CB-6980:


GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/53

CB-6980 Fixing filesystem:null property in Entry

when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success it should return a
Entry with several properties, as it is the filesystem information,
which returns as null.
on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
retrieved it should contain the filesystem information.
Since the fix, CB-6525, only adds support for Android and iOS, for other
platform it retrieves a null object, so adding a condition to retrieve
the information if the object from the callback is null.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-6980

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #53


commit 4f455ac3efe64caede6cbaff9d7c638caf6e5392
Author: Martin Gonzalez 
Date:   2014-06-19T15:38:20Z

CB-6980 Fixing filesystem:null property in Entry

when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success it should return a
Entry with several properties, as it is the filesystem information,
which returns as null.
on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
retrieved it should contain the filesystem information.
Since the fix, CB-6525, only adds support for Android and iOS, for other
platform it retrieves a null object, so adding a condition to retrieve
the information if the object from the callback is null.




> [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with 
> filesystem: null
> ---
>
> Key: CB-6980
> URL: https://issues.apache.org/jira/browse/CB-6980
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: WP8, plugin-file
> Fix For: 3.6.0
>
>
> I have notice, when resolveLocalFileSystemURI or resolveLocalFileSystemURL is 
> called on the File Plugin under Windows Phone 8, it always returns a 
> fileEntry with null information on the filesystem.
> This behavior is unexpected the filesystem information it shouldn't be null 
> if a Entry Object is created.
> Found through mobile-spec File tests, affecting operations as 
> removeRecursively on DirectoryEntry, and remove on Entry.
> It might be reproduce by other means or scenarios.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6983) Incorrect debug statement in callbackSuccess

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037435#comment-14037435
 ] 

ASF GitHub Bot commented on CB-6983:


GitHub user stacic opened a pull request:

https://github.com/apache/cordova-js/pull/71

CB-6983 misleading debug statement



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stacic/cordova-js CB-6983

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-js/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #71


commit cf2ab5190f94de8923aafd5559be940661a32e75
Author: Staci Cooper 
Date:   2014-06-19T15:34:50Z

CB-6983 misleading debug statement




> Incorrect debug statement in callbackSuccess
> 
>
> Key: CB-6983
> URL: https://issues.apache.org/jira/browse/CB-6983
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Reporter: Staci Cooper
>Assignee: Staci Cooper
>Priority: Trivial
>
> Catch statement in callbackSuccess() incorrectly reports error in error 
> callback



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6935) [Android][cordova-plugin-file] window.resolveLocalFileSystemURL can't resolve cordova.file.applicationDirectory URL

2014-06-19 Thread Mestre Muten (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037432#comment-14037432
 ] 

Mestre Muten commented on CB-6935:
--

Hi again,

I'm sorry if it's not the correct place, but I think it's related to the main 
post.

You know I said I use a kind of "loader", ok that loader does this steps:
1- Connect to server and get last version available
2- Download all needed files to file system (dataDirectory) using file-transfer
3- Redirect to downloaded index.html
4- Load some "stock APK" resources 

When I try to access some resources from assets directory, I find two issues 
that worked before, but not now:
1- can't acces localStorage data I saved in the loader from the new index.html
2- can't load cordova.js (and plugins) from file:///android_assets/www, I get 
this error: 06-19 17:08:33.089: I/chromium(7912): [INFO:CONSOLE(0)] "Not 
allowed to load local resource: 
file:///android_asset/www/cordova.js?_=1403190512614", source: 
cdvfile://localhost/files/www/index.html (0)

That's really bad for me cause I can't load cordova, and thus, I can't access 
any cordova features. The other approach is to download cordova along with 
html/css/js, I'll try it now.

I'm on cordova 3.5, and I think this worked fine on cordova 3.3

PD: It would be really great to get read-only access to assets directory on 
android.

> [Android][cordova-plugin-file] window.resolveLocalFileSystemURL can't resolve 
> cordova.file.applicationDirectory URL
> ---
>
> Key: CB-6935
> URL: https://issues.apache.org/jira/browse/CB-6935
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, Plugin File
>Affects Versions: 1.2.0
> Environment: - Samsung I-9100 Intl (Cyanogenmod 10.2, android 4.3.1)
> - Samgsung GT-P5110 (Cyanogenmod 11, android 4.4.2)
>Reporter: Mestre Muten
>  Labels: easyfix, patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> As of version 1.2.0 of this plugin, some special directory paths were added 
> under cordova.file.*Directory.
> All of them seem to work, but "applicationDirectory" on Android platform 
> doesn't.
> This special directory equals "file:///android_asset/".
> It calls fail callback with error code = 1 (NOT_FOUND_ERR).
> For a simple test just call this on deviceready:
> window.resolveLocalFileSystemURL(cordova.file.applicationDirectory, 
> function(dirEntry){console.log('SUCCESS');},function(error){console.log('ERROR:
>  '+JSON.stringify(error));});



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6983) Incorrect debug statement in callbackSuccess

2014-06-19 Thread Staci Cooper (JIRA)
Staci Cooper created CB-6983:


 Summary: Incorrect debug statement in callbackSuccess
 Key: CB-6983
 URL: https://issues.apache.org/jira/browse/CB-6983
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaJS
Reporter: Staci Cooper
Assignee: Staci Cooper
Priority: Trivial


Catch statement in callbackSuccess() incorrectly reports error in error callback



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-3571) Add support for elements in config.xml

2014-06-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037423#comment-14037423
 ] 

ASF GitHub Bot commented on CB-3571:


Github user kamrik commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/30#discussion_r13974255
  
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -88,13 +88,54 @@ module.exports.prototype = {
 fs.writeFileSync(this.strings, strings.write({indent: 4}), 
'utf-8');
 events.emit('verbose', 'Wrote out Android application name to "' + 
name + '"');
 
+var projectRoot = util.isCordova(this.path);
+
+var splashIcons = config.getIcons('android', 'splash');
+// if there are icon elements in config.xml
+if (splashIcons) {
+   events.emit('verbose', "splash icons: " + 
JSON.stringify(splashIcons));
--- End diff --

This line seems to be indented with 3 spaces. Please use consistent 4 space 
indentation.

A suggestion: the whole splashScreen section seems to be long enough to 
live in a function of its own. Preferably in such a way so that it can be 
shared with Amazon FireOS parser, or whatever Android derivative wants to use 
it.


> Add support for  elements in config.xml
> ---
>
> Key: CB-3571
> URL: https://issues.apache.org/jira/browse/CB-3571
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: CLI
>Affects Versions: Master
>Reporter: Michael Brooks
>Assignee: Lorin Beer
>
> Similar to adding support for the {{}} element, we should add support 
> for the splash screen.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Velecký updated CB-6982:


Description: 
When using single icon as application icon in config.xml this way "" cordova should use basic drawable folder, 
because doesn't matter of resolution, PPI, etc., so doesn't matter of device 
and for this purpose there are "drawable" folder. Not use drawable-hdpi, 
drawable-ldpi and so on. Icons in these folders in this situation should be 
deleted.

It's really not neccessary to have 5 not similar, but exactly same icon files, 
when we can have only 1 icon file.

  was:
When using single icon as application icon in config.xml this way "". Phonegap should use basic drawable 
folder, because the doesn't matter of resolution, PPI, etc., so doesn't matter 
of device and for this purpose there are "drawable" folder. Not use 
drawable-hdpi, drawable-ldpi and so on. Icons in these folders should be 
deleted.

It's really not neccessary to have 5 not similar, but exactly same icon files, 
when we can have only 1 file.


> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />" cordova should use basic drawable 
> folder, because doesn't matter of resolution, PPI, etc., so doesn't matter of 
> device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders in this 
> situation should be deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 icon file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-6982) Should use only drawable folder for single application icon

2014-06-19 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/CB-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Velecký updated CB-6982:


Summary: Should use only drawable folder for single application icon  (was: 
Should use only drawable folder for singel application icon)

> Should use only drawable folder for single application icon
> ---
>
> Key: CB-6982
> URL: https://issues.apache.org/jira/browse/CB-6982
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 3.5.0
>Reporter: Jan Velecký
>Priority: Minor
>
> When using single icon as application icon in config.xml this way " src="icon.png" platform="android" />". Phonegap should use basic drawable 
> folder, because the doesn't matter of resolution, PPI, etc., so doesn't 
> matter of device and for this purpose there are "drawable" folder. Not use 
> drawable-hdpi, drawable-ldpi and so on. Icons in these folders should be 
> deleted.
> It's really not neccessary to have 5 not similar, but exactly same icon 
> files, when we can have only 1 file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6982) Should use only drawable folder for singel application icon

2014-06-19 Thread JIRA
Jan Velecký created CB-6982:
---

 Summary: Should use only drawable folder for singel application 
icon
 Key: CB-6982
 URL: https://issues.apache.org/jira/browse/CB-6982
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: 3.5.0
Reporter: Jan Velecký
Priority: Minor


When using single icon as application icon in config.xml this way "". Phonegap should use basic drawable 
folder, because the doesn't matter of resolution, PPI, etc., so doesn't matter 
of device and for this purpose there are "drawable" folder. Not use 
drawable-hdpi, drawable-ldpi and so on. Icons in these folders should be 
deleted.

It's really not neccessary to have 5 not similar, but exactly same icon files, 
when we can have only 1 file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037377#comment-14037377
 ] 

ASF subversion and git services commented on CB-6973:
-

Commit a1da72b6274927df3666d34339f844eb8a270df0 in cordova-lib's branch 
refs/heads/master from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a1da72b ]

CB-6973: Fix JSHint errors in plugman/platforms/*


> Use JSHint in Cordova CLI tools
> ---
>
> Key: CB-6973
> URL: https://issues.apache.org/jira/browse/CB-6973
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Assigned] (CB-6098) Android app initiates long press on home screen before opening

2014-06-19 Thread Joe Bowser (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser reassigned CB-6098:
--

Assignee: Joe Bowser

> Android app initiates long press on home screen before opening
> --
>
> Key: CB-6098
> URL: https://issues.apache.org/jira/browse/CB-6098
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CLI
>Affects Versions: 3.4.0, 3.5.0
> Environment: Linux build from CLI, occurs on both emulator and my 
> Nexus 4
>Reporter: Joe Archer
>Assignee: Joe Bowser
>
> When opening any app (including a build straight after "cordova create") just 
> before the app splash screen is shown, the app appears to initiate a long 
> press on the homescreen, triggering the wallpaper/widgets/settings Android 
> system overlay. This occurs on API 19 and 18 on both the emulator and 2 
> tested devices.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6963) Port media tests to plugin-test-framework

2014-06-19 Thread Javier Alberto Becerra Bermudez (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037354#comment-14037354
 ] 

Javier Alberto Becerra Bermudez commented on CB-6963:
-

I've been working on this item.

> Port media tests to plugin-test-framework
> -
>
> Key: CB-6963
> URL: https://issues.apache.org/jira/browse/CB-6963
> Project: Apache Cordova
>  Issue Type: Test
>  Components: Plugin Media
>Reporter: Staci Cooper
>Assignee: Staci Cooper
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6973) Use JSHint in Cordova CLI tools

2014-06-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037344#comment-14037344
 ] 

ASF subversion and git services commented on CB-6973:
-

Commit 8d1d70e27506cfcafff73563595a245e8bdb0c33 in cordova-lib's branch 
refs/heads/master from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=8d1d70e ]

CB-6973: Fix JSHint errors in plugman/registry/*


> Use JSHint in Cordova CLI tools
> ---
>
> Key: CB-6973
> URL: https://issues.apache.org/jira/browse/CB-6973
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6981) Removing & re-adding a plugin leaves out iOS project file modifications etc.

2014-06-19 Thread Michael Schmidt (JIRA)
Michael Schmidt created CB-6981:
---

 Summary: Removing & re-adding a plugin leaves out iOS project file 
modifications etc.
 Key: CB-6981
 URL: https://issues.apache.org/jira/browse/CB-6981
 Project: Apache Cordova
  Issue Type: Bug
  Components: iOS
Affects Versions: 3.5.0
Reporter: Michael Schmidt


Removing & re-adding a plugin leaves out iOS project file modifications etc. - 
re-adding via command line: cordova add/rm plugin

There was a similar issue fixed in 3.4.0. - 
https://issues.apache.org/jira/browse/CB-4971

We're still experiencing this issue in Cordova 3.5.0

Anyone knows a workaround? Why does this appear in 3.5.0 still though it should 
be fixed in 3.4.0?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-4971) Installation of plugins does not work for iOS - config.xml feature lines not added

2014-06-19 Thread Michael Schmidt (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037327#comment-14037327
 ] 

Michael Schmidt commented on CB-4971:
-

We're still experiencing this issue in cordova 3.5.0
- removing & re-adding a plugin leaves out the iOS project file modification 
etc.

Anyone knows a workaround? Why does this appear still in 3.5.0 though it should 
be fixed in 3.4.0?

> Installation of plugins does not work for iOS - config.xml feature lines not 
> added
> --
>
> Key: CB-4971
> URL: https://issues.apache.org/jira/browse/CB-4971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 3.0.0, 3.1.0
> Environment: iOS 
>Reporter: Oleg
>Priority: Critical
>  Labels: ios, plugin
> Fix For: 3.4.0
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Installation of iOS plugins does not work for iOS.
> Update: does not work in 3.1 cordova either.
> When installing the plugin via "cordova plugin add", the plugins fail to 
> install correctly to the iOS platform:
> - source code (.js, .m, .h and .bundle) files are not copied over
> - proper frameworks are not being added to the project
> - config.xml file is not updated with plugin information
> Tried it on Device, Contacts and Dialogs and some other plugins.
> Update: tried on network-information plugin with cordova 3.1
> the workaround is to perform the above steps manually. but it is not 
> documented anywhere.
> Note: it worked for me during one test, when the project was fresh. However 
> after making a few minor changes and running "cordova prepare" or "cordova 
> build" a few times, it stops working for iOS - i.e. you cannot add plugins 
> without issues above. Android works fine.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6980) [WP8][cordova-plugin-file] resolveLocalFileSystemURI returns an entry with filesystem: null

2014-06-19 Thread Martin Gonzalez (JIRA)
Martin Gonzalez created CB-6980:
---

 Summary: [WP8][cordova-plugin-file] resolveLocalFileSystemURI 
returns an entry with filesystem: null
 Key: CB-6980
 URL: https://issues.apache.org/jira/browse/CB-6980
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, WP8
Affects Versions: 3.5.0
Reporter: Martin Gonzalez
Assignee: Martin Gonzalez
 Fix For: 3.6.0


I have notice, when resolveLocalFileSystemURI or resolveLocalFileSystemURL is 
called on the File Plugin under Windows Phone 8, it always returns a fileEntry 
with null information on the filesystem.
This behavior is unexpected the filesystem information it shouldn't be null if 
a Entry Object is created.
Found through mobile-spec File tests, affecting operations as removeRecursively 
on DirectoryEntry, and remove on Entry.
It might be reproduce by other means or scenarios.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android

2014-06-19 Thread Andrew Grieve (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037286#comment-14037286
 ] 

Andrew Grieve commented on CB-6571:
---

Good idea. Probably constructor is better. 

Just re-tested and looks like my first browser test was too simple (only tested 
root.toURL()). Here's a better test:

{code}
webkitRequestFileSystem(TEMPORARY, 1, function(f) {fs = f})
undefined
fs.root.toURL()
"filesystem:https://issues.apache.org/temporary/";
fs.root.fullPath
"/"
fs.root.getDirectory('hi', {create:true}, function(e) { ent = e })
undefined
ent.fullPath
"/hi"
ent.toURL()
"filesystem:https://issues.apache.org/temporary/hi";
{code}


So:
* fs.root has trailing /
* subdirectories do not
* paths do not, except for root

filesystem: URLs more reflect cdvfile: urls though, not really file: urls. And 
since the root is different from subdirectories, apps would need to always 
check for trailing slashes themselves anyways when given a URL (ugh). So... 
Maybe let's not try and match this behaviour and try to be consistent ourselves 
at least.

[~iclelland] any thoughts on this?

> DirectoryEntry.toURL() has a trailing slash on iOS but not Android
> --
>
> Key: CB-6571
> URL: https://issues.apache.org/jira/browse/CB-6571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> We should be consistent with this and always have directories end with at /.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CB-3571) Add support for elements in config.xml

2014-06-19 Thread Andrew Grieve (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Grieve updated CB-3571:
--

Assignee: Lorin Beer  (was: Mark Koudritsky)

> Add support for  elements in config.xml
> ---
>
> Key: CB-3571
> URL: https://issues.apache.org/jira/browse/CB-3571
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: CLI
>Affects Versions: Master
>Reporter: Michael Brooks
>Assignee: Lorin Beer
>
> Similar to adding support for the {{}} element, we should add support 
> for the splash screen.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6974) Keyboard causes input focus issue

2014-06-19 Thread Andrey Kurdyumov (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037276#comment-14037276
 ] 

Andrey Kurdyumov commented on CB-6974:
--

I could confirm [~dpogue] observation. From my experience real cause for that 
behavior is that when user tap screen, keyboard is shown before the click and 
focus event propagated to WebView. Thus after screen resize, tap coordinates 
remains the same, but INPUT is no longer under tapped area and focus event is 
not fired.
>From my observations this fixed only in iOS 7.1

> Keyboard causes input focus issue
> -
>
> Key: CB-6974
> URL: https://issues.apache.org/jira/browse/CB-6974
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Keyboard
>Affects Versions: 3.5.0
> Environment: iOS 6.1
>Reporter: Darryl Pogue
>  Labels: iOS
>
> I've confirmed that this issue is caused by the keyboard plugin, because it 
> does not happen when the keyboard plugin is disabled.
> If there is an input on the lower half of the page, when it is tapped, the 
> keyboard will slide up, covering the input and not putting it in focus.
> In my config file I have the following:
> {code:xml|title=config.xml}
> 
> 
>  />
> {code}
> This appears to only happen when the input is on a page that is absolutely 
> positioned.
> The best reference I can find about the issue is 
> http://www.telerik.com/forums/click-on-input-levels-up-the-footer-on-the-keyboard-whitout-change-the-view-!-
>  but the suggested change of setting the body height on deviceReady didn't 
> work for me.
> It does not appear to be related to the status bar (as potentially stated in 
> that thread). Removing the status bar plugin did not fix the problem.
> My guess is that it's related to hiding the accessory bar and intercepting 
> the keyboard opening in Objective C, but I don't know enough about ObjC to 
> know what would cause the focus to be lost :(



--
This message was sent by Atlassian JIRA
(v6.2#6252)


  1   2   >