[jira] [Commented] (CB-7060) WP8. Fix large project build performance issue
[ https://issues.apache.org/jira/browse/CB-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049680#comment-14049680 ] ASF GitHub Bot commented on CB-7060: GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-wp8/pull/43 CB-7060 WP8. Fix large project build performance issue https://issues.apache.org/jira/browse/CB-7060 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-wp8 CB-7060 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit dcbd56b2bb2971363ff0de790cb8857f9d80a0b6 Author: sgrebnov Date: 2014-07-02T07:00:53Z CB-7060 WP8. Fix large project build performance issue > WP8. Fix large project build performance issue > -- > > Key: CB-7060 > URL: https://issues.apache.org/jira/browse/CB-7060 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > When a Windows Phone project with many resources is built in VS with Cordova, > the project takes much longer to build than a project for Win 8 or Android. > We have identified the function that is causing the issue; it is the > exec_verbose(command) function in > \bld\Debug\platforms\wp8\cordova\lib\build.js . > // executes a commmand in the shell > function exec_verbose(command) { > //Log("Command: " + command); > var oShell=wscript_shell.Exec(command); > while (oShell.Status == 0) { > //Wait a little bit so we're not super looping > WScript.sleep(100); > //Print any stdout output from the script > if (!oShell.StdOut.AtEndOfStream) { > var line = oShell.StdOut.ReadLine(); > Log(line); > } > } > The WScript.sleep() call gets executed every time through the loop, and when > building a Windows Phone 8 project, every single resource that is added gets > its own line in the log. Thus a project with thousands of resources sleeps > thousands of times. This function is identical in the Win8 build.js file, but > the resources aren’t added in the same way as they are for Windows Phone > projects. The Android build.js does something entirely different. > We have identified a couple potential fixes: > •Change the if statement to a while loop > •Leave the if statement but change the ReadLine() call to a ReadAll() call > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6230) InAppBrowser closes after opening, instead of before
[ https://issues.apache.org/jira/browse/CB-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049699#comment-14049699 ] Erik Jan de Wit commented on CB-6230: - Can't you remove the close call? > InAppBrowser closes after opening, instead of before > > > Key: CB-6230 > URL: https://issues.apache.org/jira/browse/CB-6230 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin InAppBrowser >Affects Versions: 3.4.0, 3.5.0 >Reporter: Jacob Weber > > In Cordova 3.4, with InAppBrowser 0.3.3, create a new project using the CLI. > In www/js/index.js, make the following change: > {noformat} > onDeviceReady: function() { > app.receivedEvent('deviceready'); > document.addEventListener('click', function() { > if (window.myWindow) window.myWindow.close(); > window.myWindow = window.open('http://www.google.com', "_blank"); > }); > }, > {noformat} > Tap the page once, and a browser will appear. Close the browser. Then tap the > app again. This time the browser will appear for a split second, then close > right away. The close() call seems to be happening after the subsequent > open() call, instead of before it. > This was working in 3.3, with InAppBrowser 0.2.5. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7060) WP8. Fix large project build performance issue
[ https://issues.apache.org/jira/browse/CB-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049775#comment-14049775 ] ASF subversion and git services commented on CB-7060: - Commit 1215a84fd80c1a17f0fe6376c3894397fefe46a7 in cordova-windows's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=1215a84 ] fixes potential perf issue inside exec_verbose method see CB-7060 WP8. Fix large project build performance issue > WP8. Fix large project build performance issue > -- > > Key: CB-7060 > URL: https://issues.apache.org/jira/browse/CB-7060 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > When a Windows Phone project with many resources is built in VS with Cordova, > the project takes much longer to build than a project for Win 8 or Android. > We have identified the function that is causing the issue; it is the > exec_verbose(command) function in > \bld\Debug\platforms\wp8\cordova\lib\build.js . > // executes a commmand in the shell > function exec_verbose(command) { > //Log("Command: " + command); > var oShell=wscript_shell.Exec(command); > while (oShell.Status == 0) { > //Wait a little bit so we're not super looping > WScript.sleep(100); > //Print any stdout output from the script > if (!oShell.StdOut.AtEndOfStream) { > var line = oShell.StdOut.ReadLine(); > Log(line); > } > } > The WScript.sleep() call gets executed every time through the loop, and when > building a Windows Phone 8 project, every single resource that is added gets > its own line in the log. Thus a project with thousands of resources sleeps > thousands of times. This function is identical in the Win8 build.js file, but > the resources aren’t added in the same way as they are for Windows Phone > projects. The Android build.js does something entirely different. > We have identified a couple potential fixes: > •Change the if statement to a while loop > •Leave the if statement but change the ReadLine() call to a ReadAll() call > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7061) the page behind the "subscribe" link on top of http://cordova.apache.org/#news crashes
Rémi Becheras created CB-7061: - Summary: the page behind the "subscribe" link on top of http://cordova.apache.org/#news crashes Key: CB-7061 URL: https://issues.apache.org/jira/browse/CB-7061 Project: Apache Cordova Issue Type: Bug Components: Website Environment: Chromium-browser (I am on Xubuntu 14.04) Reporter: Rémi Becheras I did want suscribe on http://cordova.apache.org/rss.xml But the folowing error occurs: This page contains the following errors: error on line 2949 at column 38: xmlParseEntityRef: no name Below is a rendering of the page up to the first error. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7003) navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions
[ https://issues.apache.org/jira/browse/CB-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049932#comment-14049932 ] ASF subversion and git services commented on CB-7003: - Commit aef7032ea4670b381b3bca70cec091f93667f8d5 in cordova-plugin-contacts's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=aef7032 ] CB-7003: Make pickContact pick correct contact on Android 4.3 and 4.4.3 > navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 > versions > > > Key: CB-7003 > URL: https://issues.apache.org/jira/browse/CB-7003 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Contacts >Affects Versions: 3.5.0 >Reporter: Meshkov Alex >Assignee: Ian Clelland > > This issue touches pickContact method on Android devices. Simple call > {code} > navigator.contacts.pickContact(function (contact) { > if (contact.id == -1) { > return false; > } > alert(contact.name.formatted); > }); > {code} > return wrong _contact.name.formatted_ value. For instance if I select _Mom_ > contact I would get Maria's contact object. > This bug affects Android versions 4.3 (Samsung Galaxy S3) and 4.4.3 (Nexus 4) > I haven't tested on other devices. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7003) navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions
[ https://issues.apache.org/jira/browse/CB-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049935#comment-14049935 ] ASF subversion and git services commented on CB-7003: - Commit aef7032ea4670b381b3bca70cec091f93667f8d5 in cordova-plugin-contacts's branch refs/heads/0.2.11 from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=aef7032 ] CB-7003: Make pickContact pick correct contact on Android 4.3 and 4.4.3 > navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 > versions > > > Key: CB-7003 > URL: https://issues.apache.org/jira/browse/CB-7003 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Contacts >Affects Versions: 3.5.0 >Reporter: Meshkov Alex >Assignee: Ian Clelland > > This issue touches pickContact method on Android devices. Simple call > {code} > navigator.contacts.pickContact(function (contact) { > if (contact.id == -1) { > return false; > } > alert(contact.name.formatted); > }); > {code} > return wrong _contact.name.formatted_ value. For instance if I select _Mom_ > contact I would get Maria's contact object. > This bug affects Android versions 4.3 (Samsung Galaxy S3) and 4.4.3 (Nexus 4) > I haven't tested on other devices. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049965#comment-14049965 ] ASF subversion and git services commented on CB-6571: - Commit 56f1f3d6bb4493c026e4a603947b4ea3e4ab0975 in cordova-plugin-file's branch refs/heads/master from [~mbektchiev] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=56f1f3d ] CB-6571 Fix getParentForLocalURL to work correctly with directories with trailing '/' (This closes #58) Fixes 2 failing unit tests in mobile spec. > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049966#comment-14049966 ] ASF GitHub Bot commented on CB-6571: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/58 > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland resolved CB-6571. -- Resolution: Fixed > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6571) DirectoryEntry.toURL() has a trailing slash on iOS but not Android
[ https://issues.apache.org/jira/browse/CB-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049970#comment-14049970 ] Ian Clelland commented on CB-6571: -- This should be fixed now; I've merged in the PR and I have all tests passing on Android. > DirectoryEntry.toURL() has a trailing slash on iOS but not Android > -- > > Key: CB-6571 > URL: https://issues.apache.org/jira/browse/CB-6571 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > We should be consistent with this and always have directories end with at /. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6230) InAppBrowser closes after opening, instead of before
[ https://issues.apache.org/jira/browse/CB-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049979#comment-14049979 ] Jacob Weber commented on CB-6230: - [~edewit] This is just a condensed example. In real usage, this happens whenever I want to open a browser, then later close it, and then later open another one. The close doesn't need to happen immediately before the open, like in this example. > InAppBrowser closes after opening, instead of before > > > Key: CB-6230 > URL: https://issues.apache.org/jira/browse/CB-6230 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin InAppBrowser >Affects Versions: 3.4.0, 3.5.0 >Reporter: Jacob Weber > > In Cordova 3.4, with InAppBrowser 0.3.3, create a new project using the CLI. > In www/js/index.js, make the following change: > {noformat} > onDeviceReady: function() { > app.receivedEvent('deviceready'); > document.addEventListener('click', function() { > if (window.myWindow) window.myWindow.close(); > window.myWindow = window.open('http://www.google.com', "_blank"); > }); > }, > {noformat} > Tap the page once, and a browser will appear. Close the browser. Then tap the > app again. This time the browser will appear for a split second, then close > right away. The close() call seems to be happening after the subsequent > open() call, instead of before it. > This was working in 3.3, with InAppBrowser 0.2.5. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-6230) InAppBrowser closes after opening, instead of before
[ https://issues.apache.org/jira/browse/CB-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049979#comment-14049979 ] Jacob Weber edited comment on CB-6230 at 7/2/14 2:46 PM: - [~edewit] This is just a condensed example. In real usage, this happens whenever I want to open a browser, then later close it, and then later open another one. The close doesn't need to happen immediately before the open, like in this example. And actually, even in this example, I couldn't remove the close call, because of CB-6228. was (Author: jweber): [~edewit] This is just a condensed example. In real usage, this happens whenever I want to open a browser, then later close it, and then later open another one. The close doesn't need to happen immediately before the open, like in this example. > InAppBrowser closes after opening, instead of before > > > Key: CB-6230 > URL: https://issues.apache.org/jira/browse/CB-6230 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin InAppBrowser >Affects Versions: 3.4.0, 3.5.0 >Reporter: Jacob Weber > > In Cordova 3.4, with InAppBrowser 0.3.3, create a new project using the CLI. > In www/js/index.js, make the following change: > {noformat} > onDeviceReady: function() { > app.receivedEvent('deviceready'); > document.addEventListener('click', function() { > if (window.myWindow) window.myWindow.close(); > window.myWindow = window.open('http://www.google.com', "_blank"); > }); > }, > {noformat} > Tap the page once, and a browser will appear. Close the browser. Then tap the > app again. This time the browser will appear for a split second, then close > right away. The close() call seems to be happening after the subsequent > open() call, instead of before it. > This was working in 3.3, with InAppBrowser 0.2.5. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7024) Cordova resolveLocalFileSystemURL works but then fileEntry.file() fails
[ https://issues.apache.org/jira/browse/CB-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049996#comment-14049996 ] Ian Clelland commented on CB-7024: -- bq. That is stuppid! It's a bug. The first issue may indeed be a bug; if the permission is missing, and is now required, then it should be added by the File plugin. bq. I cannot get the mime-Type for the given fileEntry, so how am I supposed to upload it via FileTransfer plugin (as it asks explicitely for it - to send it as ContentType to the server Calling {{fileEntry.file()}} is supposed to return you a file object, with a mime type, which you can query like this: {code} myFileEntry.file(function(myFile) { mimeType = myFile.type; }, errorHandler); {code} If the MIME type is not being attached correctly, or is not being detected properly, then that is a bug; possibly with our interface to the external content provider. bq. - that's another stuppid thing, it should detect it if I pass null in the firs place anways). Having Cordova actually guess the content type is probably not going to happen; there are too many ways to do it (by extension? by application? by content provider? by actually reading every file and looking at its structure?), and we have no idea about the cost of getting it wrong. If you just need *something* for an HTTP header, and you really have no idea what the data type is, then use {{application/octet-stream}} -- all it says is "this is bytes". You can always have the server do any required file type detection when the data is uploaded. Also, how is this a security issue? Is that label appropriate here? > Cordova resolveLocalFileSystemURL works but then fileEntry.file() fails > --- > > Key: CB-7024 > URL: https://issues.apache.org/jira/browse/CB-7024 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.0.0, 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 > Environment: Android >Reporter: DotNetWise >Priority: Blocker > Labels: file, mimeType, security > Original Estimate: 8m > Remaining Estimate: 8m > > First, you do a {{navigator.camera.getPicture(uploadPicture_step1, > uploadError, chooseOptions);}} > with success and then you do {{window.resolveLocalFileSystemURL(fileURI, > function (fileEntry) {}} > again with success. > Now if you call that {{fileEntry.file(function(info) {}, function(err) { }); > }}you always get an exception and the error callback is called with > {{err.code = 1000}}; > The error in {{logcat}} is missing {{android.permission.MANAGE_DOCUMENTS}} > That is stuppid! It's a bug. > I cannot get the mime-Type for the given fileEntry, so how am I supposed to > upload it via FileTransfer plugin (as it asks explicitely for it - to send it > as ContentType to the server - that's another stuppid thing, it should detect > it if I pass null in the firs place anways). > This issue is for the files that are comming from custom providers such as > "downloads". e.g. > {{content://document/primary%3ADownload/11june.pdf}} > In config.xml I do have > {{ >value="files,files-external,documents,sdcard,cache,cache-external,root" /> > > > > > > value="org.apache.cordova.filetransfer.FileTransfer" /> > > > value="org.apache.cordova.camera.CameraLauncher" /> > }} > In {{AndroidManifest.xml}} I do have > {{ > }} > Here are some logs > {{ > E/DatabaseUtils(24425): java.lang.SecurityException: Permission Denial: > reading com.android.externalstorage.ExternalStorageProvider uri conten > nts/document/primary%3ADownload/11june.pdf from pid=22853, uid=10197 requires > android.permission.MANAGE_DOCUMENTS, or grantUriPermission() > E/DatabaseUtils(24425): at > android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:467) > E/DatabaseUtils(24425): at > android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:394) > E/DatabaseUtils(24425): at > android.content.ContentProvider$Transport.query(ContentProvider.java:194) > E/DatabaseUtils(24425): at > android.content.ContentProviderNative.onTransact(ContentProviderNative.java:112) > E/DatabaseUtils(24425): at > android.os.Binder.execTransact(Binder.java:404) > E/DatabaseUtils(24425): at dalvik.system.NativeStart.run(Native > Method) > W/System.err(22853): java.lang.SecurityException: Permission Denial: reading > com.android.externalstorage.ExternalStorageProvider uri content:/ > /document/primary%3ADownload/11june.pdf from pid=22853, uid=10197 requires > android.permission.MANAGE_DOCUMENTS, or grantUriPermission() > W/System.err(22853):at android.os.Parcel.readException(Parcel.java:1465) > W/System.err(22853):at > android.da
[jira] [Updated] (CB-7024) Cordova resolveLocalFileSystemURL works but then fileEntry.file() fails
[ https://issues.apache.org/jira/browse/CB-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland updated CB-7024: - Description: First, you do a {{navigator.camera.getPicture(uploadPicture_step1, uploadError, chooseOptions);}} with success and then you do {{window.resolveLocalFileSystemURL(fileURI, function (fileEntry) {})}} again with success. Now if you call that {{fileEntry.file(function(info) {}, function(err) { });}} you always get an exception and the error callback is called with {{err.code = 1000}}; The error in {{logcat}} is missing {{android.permission.MANAGE_DOCUMENTS}} That is stuppid! It's a bug. I cannot get the mime-Type for the given fileEntry, so how am I supposed to upload it via FileTransfer plugin (as it asks explicitely for it - to send it as ContentType to the server - that's another stuppid thing, it should detect it if I pass null in the firs place anways). This issue is for the files that are comming from custom providers such as "downloads". e.g. {{content://document/primary%3ADownload/11june.pdf}} In config.xml I do have {code} {code} In {{AndroidManifest.xml}} I do have {code} {code} Here are some logs {code} E/DatabaseUtils(24425): java.lang.SecurityException: Permission Denial: reading com.android.externalstorage.ExternalStorageProvider uri conten nts/document/primary%3ADownload/11june.pdf from pid=22853, uid=10197 requires android.permission.MANAGE_DOCUMENTS, or grantUriPermission() E/DatabaseUtils(24425): at android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:467) E/DatabaseUtils(24425): at android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:394) E/DatabaseUtils(24425): at android.content.ContentProvider$Transport.query(ContentProvider.java:194) E/DatabaseUtils(24425): at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:112) E/DatabaseUtils(24425): at android.os.Binder.execTransact(Binder.java:404) E/DatabaseUtils(24425): at dalvik.system.NativeStart.run(Native Method) W/System.err(22853): java.lang.SecurityException: Permission Denial: reading com.android.externalstorage.ExternalStorageProvider uri content:/ /document/primary%3ADownload/11june.pdf from pid=22853, uid=10197 requires android.permission.MANAGE_DOCUMENTS, or grantUriPermission() W/System.err(22853):at android.os.Parcel.readException(Parcel.java:1465) W/System.err(22853):at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:185) W/System.err(22853):at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:137) W/System.err(22853):at android.content.ContentProviderProxy.query(ContentProviderNative.java:413) W/System.err(22853):at android.content.ContentResolver.query(ContentResolver.java:461) W/System.err(22853):at android.content.ContentResolver.query(ContentResolver.java:404) W/System.err(22853):at org.apache.cordova.file.ContentFilesystem.openCursorForURL(ContentFilesystem.java:258) W/System.err(22853):at org.apache.cordova.file.ContentFilesystem.getFileMetadataForLocalURL(ContentFilesystem.java:169) W/System.err(22853):at org.apache.cordova.file.FileUtils.getFileMetadata(FileUtils.java:811) W/System.err(22853):at org.apache.cordova.file.FileUtils.access$400(FileUtils.java:52) W/System.err(22853):at org.apache.cordova.file.FileUtils$14.run(FileUtils.java:383) W/System.err(22853):at org.apache.cordova.file.FileUtils$24.run(FileUtils.java:540) W/System.err(22853):at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) W/System.err(22853):at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) W/System.err(22853):at java.lang.Thread.run(Thread.java:841) {code} was: First, you do a {{navigator.camera.getPicture(uploadPicture_step1, uploadError, chooseOptions);}} with success and then you do {{window.resolveLocalFileSystemURL(fileURI, function (fileEntry) {}} again with success. Now if you call that {{fileEntry.file(function(info) {}, function(err) { }); }}you always get an exception and the error callback is called with {{err.code = 1000}}; The error in {{logcat}} is missing {{android.permission.MANAGE_DOCUMENTS}} That is stuppid! It's a bug. I cannot get the mime-Type for the given fileEntry, so how am I supposed to upload it via FileTransfer plugin (as it asks explicitely for it - to send it as ContentType to the server - that's another stuppid thing, it should detect it if I pass null in the firs place anways). This issue is for the files that are comming from custom providers such as "downloads". e.g. {{content://document/primary%3ADownload/11june.pdf}} In config.xml I do have {{ }} In {{AndroidManifest.xml}} I do have
[jira] [Commented] (CB-7056) serve: return promise of server
[ https://issues.apache.org/jira/browse/CB-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050015#comment-14050015 ] ASF GitHub Bot commented on CB-7056: Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/48#issuecomment-47789192 This breaks the specs. @jsoref could you please take a look at this. The errors are different depending on whether you run "npm test" or "jasmine-node spec-cordova/serve.spec.js". And the errors are different on OSX and Linux. Might be some problem with chdirs and temp folders. > serve: return promise of server > --- > > Key: CB-7056 > URL: https://issues.apache.org/jira/browse/CB-7056 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > In `d3b32927`, cordova serve's programmatic api stopped returning the server > object... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7003) navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions
[ https://issues.apache.org/jira/browse/CB-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050016#comment-14050016 ] ASF GitHub Bot commented on CB-7003: Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/32#issuecomment-47789413 This is merged now; you can close this (I forgot to auto-close by mentioning the PR# in the commit) > navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 > versions > > > Key: CB-7003 > URL: https://issues.apache.org/jira/browse/CB-7003 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Contacts >Affects Versions: 3.5.0 >Reporter: Meshkov Alex >Assignee: Ian Clelland > > This issue touches pickContact method on Android devices. Simple call > {code} > navigator.contacts.pickContact(function (contact) { > if (contact.id == -1) { > return false; > } > alert(contact.name.formatted); > }); > {code} > return wrong _contact.name.formatted_ value. For instance if I select _Mom_ > contact I would get Maria's contact object. > This bug affects Android versions 4.3 (Samsung Galaxy S3) and 4.4.3 (Nexus 4) > I haven't tested on other devices. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7003) navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions
[ https://issues.apache.org/jira/browse/CB-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050039#comment-14050039 ] ASF GitHub Bot commented on CB-7003: Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/32 > navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 > versions > > > Key: CB-7003 > URL: https://issues.apache.org/jira/browse/CB-7003 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Contacts >Affects Versions: 3.5.0 >Reporter: Meshkov Alex >Assignee: Ian Clelland > > This issue touches pickContact method on Android devices. Simple call > {code} > navigator.contacts.pickContact(function (contact) { > if (contact.id == -1) { > return false; > } > alert(contact.name.formatted); > }); > {code} > return wrong _contact.name.formatted_ value. For instance if I select _Mom_ > contact I would get Maria's contact object. > This bug affects Android versions 4.3 (Samsung Galaxy S3) and 4.4.3 (Nexus 4) > I haven't tested on other devices. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7003) navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions
[ https://issues.apache.org/jira/browse/CB-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050038#comment-14050038 ] ASF GitHub Bot commented on CB-7003: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/32#issuecomment-47791107 Verified merged version, works correct, closing.. > navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 > versions > > > Key: CB-7003 > URL: https://issues.apache.org/jira/browse/CB-7003 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Contacts >Affects Versions: 3.5.0 >Reporter: Meshkov Alex >Assignee: Ian Clelland > > This issue touches pickContact method on Android devices. Simple call > {code} > navigator.contacts.pickContact(function (contact) { > if (contact.id == -1) { > return false; > } > alert(contact.name.formatted); > }); > {code} > return wrong _contact.name.formatted_ value. For instance if I select _Mom_ > contact I would get Maria's contact object. > This bug affects Android versions 4.3 (Samsung Galaxy S3) and 4.4.3 (Nexus 4) > I haven't tested on other devices. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6846) [medic] platform add step fails on windows due to path issue in json
[ https://issues.apache.org/jira/browse/CB-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050067#comment-14050067 ] ASF subversion and git services commented on CB-6846: - Commit ccb29fffd7e33734b114aeb03309f87f18d779a2 in cordova-medic's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=ccb29ff ] CB-6846 Fixes `Platform Add` fail on Windows slave github: close #7 > [medic] platform add step fails on windows due to path issue in json > > > Key: CB-6846 > URL: https://issues.apache.org/jira/browse/CB-6846 > Project: Apache Cordova > Issue Type: Bug > Components: Medic > Environment: Windows8.1/Server 2012 R2 >Reporter: Vladimir Kotikov > > When build slave installed on windows machine build step #23 Platform Add > fails due to invalid {{.cordova/config.json}}, written on prev. step #22 > Write Json, because bb10 is using {{TEST_DIR}} instead of {{TEST_DIR_ESCAPED}} > Bug was introduced in this changeset in writejson.js > https://github.com/apache/cordova-medic/commit/dccca3f474835aa3e1cfd1fbfb51b80cf5403e55 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7037) platform check doesn't warn when it can't install a platform
[ https://issues.apache.org/jira/browse/CB-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050068#comment-14050068 ] ASF GitHub Bot commented on CB-7037: Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/42#issuecomment-47793655 Looks good, ship it. > platform check doesn't warn when it can't install a platform > > > Key: CB-7037 > URL: https://issues.apache.org/jira/browse/CB-7037 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref > > `cordova platform check` basically tries to create a new project with the > same platforms as in your current project. It doesn't complain about projects > for which it can't get a version - the original thinking was: > {quote} > /* If a platform doesn't install, then we can't realistically > suggest updating */ > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L250-L251 > The problem is that if you try to add android, it will often fail because one > or both of "android" or "ant" will be missing from your path. Since check > can't install android, it can't get its version and thus can't determine it > isn't current. > We should add some logic so that it can report that it can't determine > instead of making the admittedly stronger claim of "up-to-date". > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L262 > {quote} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6846) [medic] platform add step fails on windows due to path issue in json
[ https://issues.apache.org/jira/browse/CB-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050069#comment-14050069 ] ASF GitHub Bot commented on CB-6846: Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/7 > [medic] platform add step fails on windows due to path issue in json > > > Key: CB-6846 > URL: https://issues.apache.org/jira/browse/CB-6846 > Project: Apache Cordova > Issue Type: Bug > Components: Medic > Environment: Windows8.1/Server 2012 R2 >Reporter: Vladimir Kotikov > > When build slave installed on windows machine build step #23 Platform Add > fails due to invalid {{.cordova/config.json}}, written on prev. step #22 > Write Json, because bb10 is using {{TEST_DIR}} instead of {{TEST_DIR_ESCAPED}} > Bug was introduced in this changeset in writejson.js > https://github.com/apache/cordova-medic/commit/dccca3f474835aa3e1cfd1fbfb51b80cf5403e55 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6996) Memory leak in network-information
[ https://issues.apache.org/jira/browse/CB-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050224#comment-14050224 ] Staci Cooper commented on CB-6996: -- Closing because accidental duplicate/problem was found in CB-7028. > Memory leak in network-information > -- > > Key: CB-6996 > URL: https://issues.apache.org/jira/browse/CB-6996 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Network Information, WP8 >Affects Versions: Master >Reporter: Staci Cooper >Assignee: Staci Cooper >Priority: Minor > > When navigating back and forth between a hybrid and native page a memory leak > occurs if you have the network-information plugin installed. > Looks like it has to do with onCordovaReady.subscribe(// function that fires > onCordovaConnectionReady) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-6996) Memory leak in network-information
[ https://issues.apache.org/jira/browse/CB-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Staci Cooper closed CB-6996. Resolution: Fixed > Memory leak in network-information > -- > > Key: CB-6996 > URL: https://issues.apache.org/jira/browse/CB-6996 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Network Information, WP8 >Affects Versions: Master >Reporter: Staci Cooper >Assignee: Staci Cooper >Priority: Minor > > When navigating back and forth between a hybrid and native page a memory leak > occurs if you have the network-information plugin installed. > Looks like it has to do with onCordovaReady.subscribe(// function that fires > onCordovaConnectionReady) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7040) Contacts Plugin Release June 27, 2014
[ https://issues.apache.org/jira/browse/CB-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050056#comment-14050056 ] Ian Clelland commented on CB-7040: -- * CB-7003 android: Make pickContact pick correct contact on Android 4.3 and 4.4.3 > Contacts Plugin Release June 27, 2014 > - > > Key: CB-7040 > URL: https://issues.apache.org/jira/browse/CB-7040 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Reporter: Ian Clelland >Assignee: Ian Clelland > > Following (and updating) steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6909) shellCmd and shellRunParam in master.cfg use values for master, fails on Windows slaves if OS X master
[ https://issues.apache.org/jira/browse/CB-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050239#comment-14050239 ] ASF subversion and git services commented on CB-6909: - Commit 3a3d42de84b9389e1e610cc4caa715ebac9df93e in cordova-medic's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=3a3d42d ] CB-6909 Removes platform-dependent commands Namely shellCmd and shellRunParam from master.cfg > shellCmd and shellRunParam in master.cfg use values for master, fails on > Windows slaves if OS X master > -- > > Key: CB-6909 > URL: https://issues.apache.org/jira/browse/CB-6909 > Project: Apache Cordova > Issue Type: Bug > Components: Medic, Windows 8, WP8 > Environment: OS X master, buildbot 0.8.8, Windows Server 2012R2 > slave, buildslave 0.8.8 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > Labels: medic, windows8, wp8 > > shellCmd and shellRunCmd are defined in master.cfg and used for a lot of the > build tasks. But the value depends on the OS of the master, so if you have a > OS X master and Windows client (or vice versa) a lot of steps will fail. > {noformat} > shellCmd="/bin/sh" > shellRunParam="-c" > if is_Windows : > shellCmd="cmd" > shellRunParam="/c" > {noformat} > For some steps, like in wp8 and windows8 sections, we know they'll always run > on Windows so we could always use 'cmd'. But in common sections or for a > platform like android, it needs to work on both. > - > It seems that ShellCommand step already uses command interpreter according to > slave platform (see > http://docs.buildbot.net/current/manual/cfg-buildsteps.html#step-ShellCommand). > So it's safe to remove this and specify commands for ShellCommand steps just > with list of strings. > Another possible issue is different path delimiter on windows and other > platforms. But in most cases slash instead of backslash works fine on > windows. So it is possible to replace '\\' to '/' in windows build steps. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6889) "Edit json" step in master.cfg fails on Windows
[ https://issues.apache.org/jira/browse/CB-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050241#comment-14050241 ] ASF GitHub Bot commented on CB-6889: Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/12 > "Edit json" step in master.cfg fails on Windows > --- > > Key: CB-6889 > URL: https://issues.apache.org/jira/browse/CB-6889 > Project: Apache Cordova > Issue Type: Bug > Components: Medic, Windows 8, WP8 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > > When running medic on windows (either the client and server or just a > client), the Edit json step specified in master.cfg fails. > Reason: Windows medic install uses the unix utilities from git\bin, the > version of sed installed requires specification of backup suffix for {{-i}} > option without space. > {noformat} > -i[SUFFIX], --in-place[=SUFFIX] > edit files in place (makes backup if extension supplied) > {noformat} > from sed help. > {{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -ibak package.json}} > instead of {{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -i bak > package.json}} works fine on both windows and mac. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6899) [medic] "Cordova-lib link" step fails on Windows slave
[ https://issues.apache.org/jira/browse/CB-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050240#comment-14050240 ] ASF subversion and git services commented on CB-6899: - Commit 1719d7ed90011746ef0ac74edd0e4aa66d7e14b6 in cordova-medic's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=1719d7e ] CB-6899 Replaces "ln -s" command It's not working on windows slaves, so it's replaced with inline node script. github: close #12 > [medic] "Cordova-lib link" step fails on Windows slave > -- > > Key: CB-6899 > URL: https://issues.apache.org/jira/browse/CB-6899 > Project: Apache Cordova > Issue Type: Bug > Components: Medic, Windows 8, WP8 > Environment: Windows Server 2012R2 / Windows 8.1, Buildslave 0.8.8, > ln (fileutils) 4.1 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > > Medic uses "ln -s" to create symbolic links, which comes from git\bin. This > doesn't work on windows clients and always raise "pervission denied" error, > even if runned in elevated prompt (with admin access). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6889) "Edit json" step in master.cfg fails on Windows
[ https://issues.apache.org/jira/browse/CB-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050238#comment-14050238 ] ASF subversion and git services commented on CB-6889: - Commit da161f5d7317f0f570a7a283a6a14d9c21de558e in cordova-medic's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=da161f5 ] CB-6889 Change "-i" sed's argument behaviour This now works on both mac and windows. > "Edit json" step in master.cfg fails on Windows > --- > > Key: CB-6889 > URL: https://issues.apache.org/jira/browse/CB-6889 > Project: Apache Cordova > Issue Type: Bug > Components: Medic, Windows 8, WP8 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > > When running medic on windows (either the client and server or just a > client), the Edit json step specified in master.cfg fails. > Reason: Windows medic install uses the unix utilities from git\bin, the > version of sed installed requires specification of backup suffix for {{-i}} > option without space. > {noformat} > -i[SUFFIX], --in-place[=SUFFIX] > edit files in place (makes backup if extension supplied) > {noformat} > from sed help. > {{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -ibak package.json}} > instead of {{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -i bak > package.json}} works fine on both windows and mac. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7056) serve: return promise of server
[ https://issues.apache.org/jira/browse/CB-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050259#comment-14050259 ] ASF GitHub Bot commented on CB-7056: Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/48#issuecomment-47797251 I have an update, I'll post it shortly. > serve: return promise of server > --- > > Key: CB-7056 > URL: https://issues.apache.org/jira/browse/CB-7056 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > In `d3b32927`, cordova serve's programmatic api stopped returning the server > object... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050266#comment-14050266 ] ASF GitHub Bot commented on CB-6776: Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/9#issuecomment-47798569 This seems to deal quite a lot with check_requirements(). Considering the discussion last Thursday, should we first stop using check_requirements() and then add the remaining changes from this PR? A nit: The lazy_load.mixin() func seems to be the same as underscore.extend() http://underscorejs.org/#extend Other than that looks good. > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7062) Media file: renameTo method can not move between different mount point
Fabrizio created CB-7062: Summary: Media file: renameTo method can not move between different mount point Key: CB-7062 URL: https://issues.apache.org/jira/browse/CB-7062 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Affects Versions: 3.5.0 Environment: Android Reporter: Fabrizio I am using the Media plugin to record audio. I would like to store the audio tracks in the data/data/{PackageName}/files folder. Based on https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L182 the plugin is using renameTo renameTo on Android works only if both paths are on the same mount point. ( http://developer.android.com/reference/java/io/File.html#renameTo%28java.io.File%29 ) On my Android 4.2.2 I get an error: E/AudioPlayer( 8514): FAILED renaming /storage/emulated/0/tmprecording.3gp to /data/data/com.example.hello/files/audiofile.mp3 Android can not move the file from /storage to /data The silly part is that moveFile method does not return false if the files can't be moved therefore the Success callback is still called. I fixed it commenting out https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L99 and L100, L103. I am not sure which kind of implications that might cause on other devices. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7037) platform check doesn't warn when it can't install a platform
[ https://issues.apache.org/jira/browse/CB-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050333#comment-14050333 ] ASF GitHub Bot commented on CB-7037: Github user jsoref closed the pull request at: https://github.com/apache/cordova-lib/pull/42 > platform check doesn't warn when it can't install a platform > > > Key: CB-7037 > URL: https://issues.apache.org/jira/browse/CB-7037 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref > > `cordova platform check` basically tries to create a new project with the > same platforms as in your current project. It doesn't complain about projects > for which it can't get a version - the original thinking was: > {quote} > /* If a platform doesn't install, then we can't realistically > suggest updating */ > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L250-L251 > The problem is that if you try to add android, it will often fail because one > or both of "android" or "ant" will be missing from your path. Since check > can't install android, it can't get its version and thus can't determine it > isn't current. > We should add some logic so that it can report that it can't determine > instead of making the admittedly stronger claim of "up-to-date". > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L262 > {quote} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7037) platform check doesn't warn when it can't install a platform
[ https://issues.apache.org/jira/browse/CB-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050331#comment-14050331 ] ASF subversion and git services commented on CB-7037: - Commit 53f7b2272fc30919ce0b52df04dc073204c76da6 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=53f7b22 ] CB-7037 platform check doesn't warn when it can't install a platform cordova platform check will now report when: * it can't create a platform * it can't run a new platform version script * a new platform version script doesn't report a version > platform check doesn't warn when it can't install a platform > > > Key: CB-7037 > URL: https://issues.apache.org/jira/browse/CB-7037 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref > > `cordova platform check` basically tries to create a new project with the > same platforms as in your current project. It doesn't complain about projects > for which it can't get a version - the original thinking was: > {quote} > /* If a platform doesn't install, then we can't realistically > suggest updating */ > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L250-L251 > The problem is that if you try to add android, it will often fail because one > or both of "android" or "ant" will be missing from your path. Since check > can't install android, it can't get its version and thus can't determine it > isn't current. > We should add some logic so that it can report that it can't determine > instead of making the admittedly stronger claim of "up-to-date". > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L262 > {quote} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7056) serve: return promise of server
[ https://issues.apache.org/jira/browse/CB-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050341#comment-14050341 ] ASF GitHub Bot commented on CB-7056: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/50 > serve: return promise of server > --- > > Key: CB-7056 > URL: https://issues.apache.org/jira/browse/CB-7056 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > In `d3b32927`, cordova serve's programmatic api stopped returning the server > object... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7056) serve: return promise of server
[ https://issues.apache.org/jira/browse/CB-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050337#comment-14050337 ] ASF GitHub Bot commented on CB-7056: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/50 CB-7056 serve: fix Android test, make tests conditional Fix **Android** merges codepath, as it turns out that merges doesn't need the platform specific hack. Adding **BlackBerry 10** test. **Android**, **iOS** and **BlackBerry 10** require specific scripts to be available, otherwise they fail. Introduce `itifapps` and `cit` (conditional `it`) based on **Jasmine**'s: * `xit` -- ignore test * `iit` -- run these tests, but skip it tests * `it` -- run these tests, unless there are iit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_7056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit fe873fd12b87ebc52866bb1f494ffdaa31a278b7 Author: Josh Soref Date: 2014-07-02T16:54:10Z CB-7056 serve: fix Android test, make tests conditional Fix **Android** merges codepath, as it turns out that merges doesn't need the platform specific hack. Adding **BlackBerry 10** test. **Android**, **iOS** and **BlackBerry 10** require specific scripts to be available, otherwise they fail. Introduce `itifapps` and `cit` (conditional `it`) based on **Jasmine**'s: * `xit` -- ignore test * `iit` -- run these tests, but skip it tests * `it` -- run these tests, unless there are iit tests > serve: return promise of server > --- > > Key: CB-7056 > URL: https://issues.apache.org/jira/browse/CB-7056 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > In `d3b32927`, cordova serve's programmatic api stopped returning the server > object... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7056) serve: return promise of server
[ https://issues.apache.org/jira/browse/CB-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050339#comment-14050339 ] ASF subversion and git services commented on CB-7056: - Commit fe873fd12b87ebc52866bb1f494ffdaa31a278b7 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fe873fd ] CB-7056 serve: fix Android test, make tests conditional Fix **Android** merges codepath, as it turns out that merges doesn't need the platform specific hack. Adding **BlackBerry 10** test. **Android**, **iOS** and **BlackBerry 10** require specific scripts to be available, otherwise they fail. Introduce `itifapps` and `cit` (conditional `it`) based on **Jasmine**'s: * `xit` -- ignore test * `iit` -- run these tests, but skip it tests * `it` -- run these tests, unless there are iit tests > serve: return promise of server > --- > > Key: CB-7056 > URL: https://issues.apache.org/jira/browse/CB-7056 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > In `d3b32927`, cordova serve's programmatic api stopped returning the server > object... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-1684) Allow the user to select front or back camera on Camera.getPicture()
[ https://issues.apache.org/jira/browse/CB-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050344#comment-14050344 ] carlo123 commented on CB-1684: -- That can be true, but seems like an excuse (some app needs just front camera and even if you can change it...every time the app needs to restore it). Interesting. If someone counted on cordova and needs to force switching to front camera...he needs to look at Appcelerator or native(as I assume that native app can do that)? If you have any workaround to force switching camera (as our html app is 95% developed) it would be very much appreciated > Allow the user to select front or back camera on Camera.getPicture() > > > Key: CB-1684 > URL: https://issues.apache.org/jira/browse/CB-1684 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Simon MacDonald >Assignee: Max Woghiren >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7024) Cordova resolveLocalFileSystemURL works but then fileEntry.file() fails
[ https://issues.apache.org/jira/browse/CB-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050365#comment-14050365 ] Ian Clelland commented on CB-7024: -- I'm trying to find a way to reproduce this, but I think I need some more information. The message you're seeing about the MANAGE_DOCUMENTS permission suggests that you are testing this on Android KitKat -- can you tell me specifically what version you are running? Also, what versions of the Camera, File and FileTransfer plugin are you using? If they're not the most current versions, then have you tried to upgrade them? I haven't been able to reproduce the first issue you mentioned -- when I use the Camera plugin to get an image, whether from the Camera or from the photo album, I get a FileEntry object that I can call {{file()}} on successfully. How are you getting the image that is failing, and what is it's URL? (Ideally, I'd like to know what {{fileEntry.toURL()}} and {{fileEntry.toInternalURL())}} are returning) When you next mention that you are having problems with PDF files, I'm not sure what the connection is to the camera API -- if you're not using that, then how are you getting the URL of the file to pass to FileTransfer (and what exactly are you passing to {{FileTransfer.upload()}}?) > Cordova resolveLocalFileSystemURL works but then fileEntry.file() fails > --- > > Key: CB-7024 > URL: https://issues.apache.org/jira/browse/CB-7024 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.0.0, 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 > Environment: Android >Reporter: DotNetWise >Priority: Blocker > Labels: file, mimeType, security > Original Estimate: 8m > Remaining Estimate: 8m > > First, you do a {{navigator.camera.getPicture(uploadPicture_step1, > uploadError, chooseOptions);}} > with success and then you do {{window.resolveLocalFileSystemURL(fileURI, > function (fileEntry) {})}} > again with success. > Now if you call that {{fileEntry.file(function(info) {}, function(err) { > });}} you always get an exception and the error callback is called with > {{err.code = 1000}}; > The error in {{logcat}} is missing {{android.permission.MANAGE_DOCUMENTS}} > That is stuppid! It's a bug. > I cannot get the mime-Type for the given fileEntry, so how am I supposed to > upload it via FileTransfer plugin (as it asks explicitely for it - to send it > as ContentType to the server - that's another stuppid thing, it should detect > it if I pass null in the firs place anways). > This issue is for the files that are comming from custom providers such as > "downloads". e.g. > {{content://document/primary%3ADownload/11june.pdf}} > In config.xml I do have > {code} > value="files,files-external,documents,sdcard,cache,cache-external,root" /> > > > > > > value="org.apache.cordova.filetransfer.FileTransfer" /> > > > value="org.apache.cordova.camera.CameraLauncher" /> > > {code} > In {{AndroidManifest.xml}} I do have > {code} > > {code} > Here are some logs > {code} > E/DatabaseUtils(24425): java.lang.SecurityException: Permission Denial: > reading com.android.externalstorage.ExternalStorageProvider uri conten > nts/document/primary%3ADownload/11june.pdf from pid=22853, uid=10197 requires > android.permission.MANAGE_DOCUMENTS, or grantUriPermission() > E/DatabaseUtils(24425): at > android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:467) > E/DatabaseUtils(24425): at > android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:394) > E/DatabaseUtils(24425): at > android.content.ContentProvider$Transport.query(ContentProvider.java:194) > E/DatabaseUtils(24425): at > android.content.ContentProviderNative.onTransact(ContentProviderNative.java:112) > E/DatabaseUtils(24425): at > android.os.Binder.execTransact(Binder.java:404) > E/DatabaseUtils(24425): at dalvik.system.NativeStart.run(Native > Method) > W/System.err(22853): java.lang.SecurityException: Permission Denial: reading > com.android.externalstorage.ExternalStorageProvider uri content:/ > /document/primary%3ADownload/11june.pdf from pid=22853, uid=10197 requires > android.permission.MANAGE_DOCUMENTS, or grantUriPermission() > W/System.err(22853):at android.os.Parcel.readException(Parcel.java:1465) > W/System.err(22853):at > android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:185) > W/System.err(22853):at > android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:137) > W/System.err(22853):at > android.content.ContentProviderProxy.query(ContentProviderNative.java:413) > W/System.err(22853):at >
[jira] [Resolved] (CB-7019) Network Information Plugin Release June 24, 2014
[ https://issues.apache.org/jira/browse/CB-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland resolved CB-7019. -- Resolution: Fixed > Network Information Plugin Release June 24, 2014 > > > Key: CB-7019 > URL: https://issues.apache.org/jira/browse/CB-7019 > Project: Apache Cordova > Issue Type: Task > Components: Plugin Network Information >Reporter: Ian Clelland >Assignee: Ian Clelland > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > Releasing Network Information plugin only. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6532) cdvfile file url is not working with link tag like css
[ https://issues.apache.org/jira/browse/CB-6532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050392#comment-14050392 ] Ian Clelland commented on CB-6532: -- [~user165537], I have merged his PR in -- you could try it by installing the plugin from git directly, using something like {code} cordova plugin rm org.apache.cordova.file cordova plugin add https://github.com/apache/cordova-plugin-file.git {code} (If you have any other plugins installed that depend on file, though, it might be a bit tougher) > cdvfile file url is not working with link tag like css > --- > > Key: CB-6532 > URL: https://issues.apache.org/jira/browse/CB-6532 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File, Plugin File Transfer >Affects Versions: 3.4.0 > Environment: iOS 7 >Reporter: Patrick Dürsteler >Priority: Critical > > A css downloaded with xhr and created a local url > (cdvfile://localhost/test.css) with the File API can't be used as a > stylesheet. > {code} > var filename = "test.css"; > var imageURL = "http://apache.org/css/style.css";; > requestFileSystem(TEMPORARY, 0, function(fileSystem) { > var ft = new FileTransfer(); > ft.download(imageURL, fileSystem.root.toURL() + "/" + filename, > function(entry) { > var fileref=document.createElement("link"); > fileref.setAttribute("rel", "stylesheet"); > fileref.setAttribute("type", "text/css"); >fileref.setAttribute("href", entry.toURL()); > document.head.appendChild(imgElement); > }); > }); > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6532) cdvfile file url is not working with link tag like css
[ https://issues.apache.org/jira/browse/CB-6532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050478#comment-14050478 ] Ian Clelland commented on CB-6532: -- [~mikedidomizio], no it's not necessary for all platforms to use {{cdvfile}} urls; in fact, because of issues like this, those URLs are mostly used by Android and iOS for passing information about files between JavaScript and native code. It's used by FileEntry and DirectoryEntry objects, so that the system can keep track of which part of the file system it is dealing with, and to provide some sandboxing between apps, but when an app requests a URL, the File plugin returns a native URL in just about every case now. There are, I believe, other platforms which can't use these specific URLs, but have their own custom schemes for different areas of the device, and so the plugin is just designed to allow that, without forcing a specific URL scheme on any particular platform. > cdvfile file url is not working with link tag like css > --- > > Key: CB-6532 > URL: https://issues.apache.org/jira/browse/CB-6532 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File, Plugin File Transfer >Affects Versions: 3.4.0 > Environment: iOS 7 >Reporter: Patrick Dürsteler >Priority: Critical > > A css downloaded with xhr and created a local url > (cdvfile://localhost/test.css) with the File API can't be used as a > stylesheet. > {code} > var filename = "test.css"; > var imageURL = "http://apache.org/css/style.css";; > requestFileSystem(TEMPORARY, 0, function(fileSystem) { > var ft = new FileTransfer(); > ft.download(imageURL, fileSystem.root.toURL() + "/" + filename, > function(entry) { > var fileref=document.createElement("link"); > fileref.setAttribute("rel", "stylesheet"); > fileref.setAttribute("type", "text/css"); >fileref.setAttribute("href", entry.toURL()); > document.head.appendChild(imgElement); > }); > }); > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6938) iOS File plugin: copyTo for file returns error when destination file exists
[ https://issues.apache.org/jira/browse/CB-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland reassigned CB-6938: Assignee: Ian Clelland > iOS File plugin: copyTo for file returns error when destination file exists > --- > > Key: CB-6938 > URL: https://issues.apache.org/jira/browse/CB-6938 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.5.0 > Environment: ios >Reporter: Vladimir Avdonin >Assignee: Ian Clelland > > According to w3c spec: > A copy of a file on top of an existing file must attempt to delete and > replace that file. > iOS version of plugin in file CDVLocalFilesystem.m contains this code for the > case: > {code} > } else if (bNewExists) { > // the full destination should NOT already exist if a copy > errCode = PATH_EXISTS_ERR; > {code} > Suggested patch: > {code} > diff --git a/src/ios/CDVLocalFilesystem.m b/src/ios/CDVLocalFilesystem.m > index d1576ad..f5aa508 100644 > --- a/src/ios/CDVLocalFilesystem.m > +++ b/src/ios/CDVLocalFilesystem.m > @@ -535,11 +535,11 @@ > if (bSrcIsDir && ![self canCopyMoveSrc:srcFullPath > ToDestination:newFileSystemPath]) { > // can't copy dir into self > errCode = INVALID_MODIFICATION_ERR; > -} else if (bNewExists) { > -// the full destination should NOT already exist if a > copy > -errCode = PATH_EXISTS_ERR; > } else { > -bSuccess = [fileMgr copyItemAtPath:srcFullPath > toPath:newFileSystemPath error:&error]; > + bSuccess = YES; > +if (bNewExists) > +bSuccess = [fileMgr > removeItemAtPath:newFileSystemPath error:&error]; > +if (bSuccess) > +bSuccess = [fileMgr copyItemAtPath:srcFullPath > toPath:newFileSystemPath error:&error]; > } > } else { // move > // iOS requires that destination must not exist before > calling moveTo > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6984) requestFileSystem does not always return after document reload
[ https://issues.apache.org/jira/browse/CB-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050565#comment-14050565 ] Ian Clelland commented on CB-6984: -- This certainly appears to be the same bug as CB-6667. I've seen your test app run as long as 300+ cycles, or fail in as little as 5, using the ONLINE_EVENT bridge mode. Switching it to LOAD_URL mode, I've had it running now for 20 minutes without a failure, so there's definitely something getting out of sync with our default mode. > requestFileSystem does not always return after document reload > -- > > Key: CB-6984 > URL: https://issues.apache.org/jira/browse/CB-6984 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.5.0 > Environment: - Experienced on Nexus 5 smartphone ( Android 4.4.3 ) > - File plugin 1.2.0 >Reporter: Zarko Hristovski > Attachments: fsreload.zip > > > Once in a while we need to reload the application ( document ) because a part > of it is dynamic - downloaded from a server and injected into the app. > The problem is that sometimes and quite often, our app won't be able to > compete its initialization since requestFileSystem neither succeeds nor > fails, it just hangs there. This happens after location.reload(). It seems > like some sort of timing issue and the number of attempts does not actually > matter. > I'll include a slightly modified "hello world" app that should show the > problem. > This doesn't seem to affect iOS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7063) save.spec and restore.spec should use a proper spy
Josh Soref created CB-7063: -- Summary: save.spec and restore.spec should use a proper spy Key: CB-7063 URL: https://issues.apache.org/jira/browse/CB-7063 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Not using a proper spy risks derailing other specs... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7064) Added tests to Globalization covering changes from CB-4602
Eric Weiterman created CB-7064: -- Summary: Added tests to Globalization covering changes from CB-4602 Key: CB-7064 URL: https://issues.apache.org/jira/browse/CB-7064 Project: Apache Cordova Issue Type: Test Components: Plugin Globalization Affects Versions: Master Reporter: Eric Weiterman Priority: Trivial Fix For: Master Tests that accompany a changes from https://issues.apache.org/jira/browse/CB-4602. Added tests to check that W3C compliance is being met when generating language tags with the PreferredLanguage and GetLocale methods in the Globalization plugin. Tags, i.e. en-US, should use hyphens instead of underscores. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7064) Added tests to Globalization covering changes from CB-4602
[ https://issues.apache.org/jira/browse/CB-7064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Weiterman updated CB-7064: --- Issue Type: Sub-task (was: Test) Parent: CB-4602 > Added tests to Globalization covering changes from CB-4602 > -- > > Key: CB-7064 > URL: https://issues.apache.org/jira/browse/CB-7064 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Globalization >Affects Versions: Master >Reporter: Eric Weiterman >Priority: Trivial > Labels: test > Fix For: Master > > > Tests that accompany a changes from > https://issues.apache.org/jira/browse/CB-4602. Added tests to check that W3C > compliance is being met when generating language tags with the > PreferredLanguage and GetLocale methods in the Globalization plugin. Tags, > i.e. en-US, should use hyphens instead of underscores. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7045) improve plugman install (+spec)
[ https://issues.apache.org/jira/browse/CB-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050606#comment-14050606 ] ASF subversion and git services commented on CB-7045: - Commit fb3c8d63ff3714723c5525e9b3c6de1157bcb14f in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fb3c8d6 ] CB-7045 (fix up quotes to make jshint happy) > improve plugman install (+spec) > --- > > Key: CB-7045 > URL: https://issues.apache.org/jira/browse/CB-7045 > Project: Apache Cordova > Issue Type: Bug > Components: Plugman >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > Currently install.spec skips some of its tests, i'd like more of them to work. > {quote} > function checkEngines(engines) { > ... > if ( semver.satisfies(engine.currentVersion, engine.minVersion) || > engine.currentVersion === null ) { > {quote} > this expects currentVersion to be a *number* or {{null}}, but currently it's > possible for it to be {{""}} > {{cleanVersionOutput}} will take {{""}} and return {{""}} which isn't > helpful... > {{callEngineScripts}} calls {{child_process.exec(scriptPath...}} and handles > error, but not no output. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7063) save.spec and restore.spec should use a proper spy
[ https://issues.apache.org/jira/browse/CB-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050605#comment-14050605 ] ASF subversion and git services commented on CB-7063: - Commit 8c3885a452e1db5bdb03bdcfd58342d99bf8a9bf in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=8c3885a ] CB-7063 save.spec and restore.spec use a proper spy > save.spec and restore.spec should use a proper spy > -- > > Key: CB-7063 > URL: https://issues.apache.org/jira/browse/CB-7063 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Not using a proper spy risks derailing other specs... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7056) serve: return promise of server
[ https://issues.apache.org/jira/browse/CB-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050607#comment-14050607 ] ASF subversion and git services commented on CB-7056: - Commit 2cc872f89c54eb23091ba10617a85203c57c0a4e in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=2cc872f ] CB-7056 make tests conditional using it/xit instead of iit/it Apparently iit in any files makes jasmine skip all it tests in all other files... To address some flakiness in the tests, temp directory changes between each test. > serve: return promise of server > --- > > Key: CB-7056 > URL: https://issues.apache.org/jira/browse/CB-7056 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.1.0, 3.2.0, 3.3.0, 3.4.0, 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > In `d3b32927`, cordova serve's programmatic api stopped returning the server > object... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050608#comment-14050608 ] ASF subversion and git services commented on CB-6776: - Commit 3911876cdca2fc69f964c2e72fc7a01813ebf639 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3911876 ] CB-6776 Make project/.cordova/config.json integrate with platforms.js > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050615#comment-14050615 ] ASF subversion and git services commented on CB-6776: - Commit dac628755fbc9f3ec43c0fea478c9da883cbeddf in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=dac6287 ] CB-6776 (use _.extend instead of custom mixin function) > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050616#comment-14050616 ] ASF GitHub Bot commented on CB-6776: Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/9#issuecomment-47826046 Merged as 3911876 with the `_.extend` as dac6287 Given the amount of pain I've gone through to keep this working, the check_requirements folks can untangle it. > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050617#comment-14050617 ] ASF GitHub Bot commented on CB-6776: Github user jsoref closed the pull request at: https://github.com/apache/cordova-lib/pull/9 > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7063) save.spec and restore.spec should use a proper spy
[ https://issues.apache.org/jira/browse/CB-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050651#comment-14050651 ] ASF subversion and git services commented on CB-7063: - Commit 3a84379f4a5c86fbbf663e6eb6f63be840492256 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3a84379 ] CB-7063 (fix case of Q) > save.spec and restore.spec should use a proper spy > -- > > Key: CB-7063 > URL: https://issues.apache.org/jira/browse/CB-7063 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Not using a proper spy risks derailing other specs... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3562) Wrong splash screen ratio for landscape-only applications
[ https://issues.apache.org/jira/browse/CB-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050662#comment-14050662 ] ASF GitHub Bot commented on CB-3562: Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47830696 Ah, I gotcha, It's because the shouldAutorotate selector has no setter in CDVViewController. @shazron - any opinion on this? with swizzling it will work with existing cordova-ios, but it would be easy to make a setter for shouldAutorotate settable, or alternatively make supportedOrientations public. I'm leaning towards accepting this as-is since it works and only swizzles a UIViewController selector. > Wrong splash screen ratio for landscape-only applications > - > > Key: CB-3562 > URL: https://issues.apache.org/jira/browse/CB-3562 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin SplashScreen >Affects Versions: 2.6.0, 2.7.0, 2.9.0 >Reporter: Michael Hanselmann >Assignee: Shazron Abdullah > Fix For: 3.4.0 > > > CDVSplashScreen.m shows the splash image with a wrong ratio for > landscape-only applications on iPhone/iPod touch devices. I fixed it locally > by applying a 90° transformation (“CGAffineTransformMakeRotation(M_PI / 2)”) > to the image view. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7065) lazy_load: don't append tgz stuff for local file system paths
[ https://issues.apache.org/jira/browse/CB-7065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050781#comment-14050781 ] ASF subversion and git services commented on CB-7065: - Commit 7b5dee59505b036b1846b3573b0fe4ef3e9ffabf in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7b5dee5 ] CB-7065 lazy_load: do not append tgz for non urls > lazy_load: don't append tgz stuff for local file system paths > - > > Key: CB-7065 > URL: https://issues.apache.org/jira/browse/CB-7065 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > This used to work, but the tests seemed to indicate it stopped at some point > (possibly around when {{cordova}} became {{cordova_npm}}/{{cordova_git}}) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7065) lazy_load: don't append tgz stuff for local file system paths
Josh Soref created CB-7065: -- Summary: lazy_load: don't append tgz stuff for local file system paths Key: CB-7065 URL: https://issues.apache.org/jira/browse/CB-7065 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref This used to work, but the tests seemed to indicate it stopped at some point (possibly around when {{cordova}} became {{cordova_npm}}/{{cordova_git}}) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050782#comment-14050782 ] ASF subversion and git services commented on CB-6776: - Commit 8ec83be0b3120617e65ab3a817e074ab7a5ae022 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=8ec83be ] CB-6776 (avoid stomping on global platforms properties) > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-6776. -- Resolution: Fixed Fix Version/s: 3.6.0 > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6776) Make project/.cordova/config.json integrate with platforms.js
[ https://issues.apache.org/jira/browse/CB-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050783#comment-14050783 ] ASF subversion and git services commented on CB-6776: - Commit 07ad206336ac1fa93d47aeea545e2795e477d865 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=07ad206 ] CB-6776 (correct windows8 fallback path) > Make project/.cordova/config.json integrate with platforms.js > - > > Key: CB-6776 > URL: https://issues.apache.org/jira/browse/CB-6776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > Handling of .cordova/config.json , platforms and lazy_load is currently > fairly messy. > This removes hardcoded platforms.js handling from lazy_load (especially for > wp7/wp8 and blackberry10). > It also allows other future platforms to have whatever odd behavior they like > (similar to wp7/wp8/blackberry10) if they so choose. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7063) save.spec and restore.spec should use a proper spy
[ https://issues.apache.org/jira/browse/CB-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7063. -- Resolution: Fixed Fix Version/s: 3.6.0 > save.spec and restore.spec should use a proper spy > -- > > Key: CB-7063 > URL: https://issues.apache.org/jira/browse/CB-7063 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > Not using a proper spy risks derailing other specs... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7037) platform check doesn't warn when it can't install a platform
[ https://issues.apache.org/jira/browse/CB-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7037. -- Resolution: Fixed Fix Version/s: 3.6.0 Assignee: Josh Soref > platform check doesn't warn when it can't install a platform > > > Key: CB-7037 > URL: https://issues.apache.org/jira/browse/CB-7037 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > `cordova platform check` basically tries to create a new project with the > same platforms as in your current project. It doesn't complain about projects > for which it can't get a version - the original thinking was: > {quote} > /* If a platform doesn't install, then we can't realistically > suggest updating */ > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L250-L251 > The problem is that if you try to add android, it will often fail because one > or both of "android" or "ant" will be missing from your path. Since check > can't install android, it can't get its version and thus can't determine it > isn't current. > We should add some logic so that it can report that it can't determine > instead of making the admittedly stronger claim of "up-to-date". > {quote} > https://github.com/apache/cordova-lib/blob/0abfcded491fc4e15e24992ba101a5863513a1a7/cordova-lib/src/cordova/platform.js#L262 > {quote} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6492) AppData hint is wrong for wXP
[ https://issues.apache.org/jira/browse/CB-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050794#comment-14050794 ] ASF GitHub Bot commented on CB-6492: Github user dylin commented on the pull request: https://github.com/apache/cordova-blackberry/pull/166#issuecomment-47844108 r+ > AppData hint is wrong for wXP > - > > Key: CB-6492 > URL: https://issues.apache.org/jira/browse/CB-6492 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.5.0 > Environment: Windows XP >Reporter: Josh Soref >Assignee: Josh Soref > > [WARN]Cannot sign applications. Author.p12 file cannot be found at > default location: C:\Documents and Settings\User\AppData\Local\Research In > Motion\author.p12 > The problem is that "AppData" was introduced later, wXP only has "Application > Data" ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6492) AppData hint is wrong for wXP
[ https://issues.apache.org/jira/browse/CB-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050797#comment-14050797 ] ASF subversion and git services commented on CB-6492: - Commit d8c9241354b0e0d61712681ee7b8860ee26b943d in cordova-blackberry's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=d8c9241 ] CB-6492 AppData hint is wrong for wXP Check for LOCALAPPDATA environment variable (which is what Windows Vista introduced) Otherwise, use the hard coded value for XP/older > AppData hint is wrong for wXP > - > > Key: CB-6492 > URL: https://issues.apache.org/jira/browse/CB-6492 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.5.0 > Environment: Windows XP >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > [WARN]Cannot sign applications. Author.p12 file cannot be found at > default location: C:\Documents and Settings\User\AppData\Local\Research In > Motion\author.p12 > The problem is that "AppData" was introduced later, wXP only has "Application > Data" ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-6492) AppData hint is wrong for wXP
[ https://issues.apache.org/jira/browse/CB-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-6492. -- Resolution: Fixed Fix Version/s: 3.6.0 > AppData hint is wrong for wXP > - > > Key: CB-6492 > URL: https://issues.apache.org/jira/browse/CB-6492 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.5.0 > Environment: Windows XP >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > [WARN]Cannot sign applications. Author.p12 file cannot be found at > default location: C:\Documents and Settings\User\AppData\Local\Research In > Motion\author.p12 > The problem is that "AppData" was introduced later, wXP only has "Application > Data" ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6492) AppData hint is wrong for wXP
[ https://issues.apache.org/jira/browse/CB-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050799#comment-14050799 ] ASF GitHub Bot commented on CB-6492: Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/166 > AppData hint is wrong for wXP > - > > Key: CB-6492 > URL: https://issues.apache.org/jira/browse/CB-6492 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.5.0 > Environment: Windows XP >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > [WARN]Cannot sign applications. Author.p12 file cannot be found at > default location: C:\Documents and Settings\User\AppData\Local\Research In > Motion\author.p12 > The problem is that "AppData" was introduced later, wXP only has "Application > Data" ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7065) lazy_load: don't append tgz stuff for local file system paths
[ https://issues.apache.org/jira/browse/CB-7065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7065. -- Resolution: Fixed Fix Version/s: 3.6.0 fwiw, this was hit in 3a84379 when that platform.spec.js and serve.spec.js tests were run -- the lazy_load code constructed: cordova-lib/cordova-lib/spec-cordova/fixtures/platforms/android-lib;a=snapshot;h=dev;sf=tgz/VERSION > lazy_load: don't append tgz stuff for local file system paths > - > > Key: CB-7065 > URL: https://issues.apache.org/jira/browse/CB-7065 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > This used to work, but the tests seemed to indicate it stopped at some point > (possibly around when {{cordova}} became {{cordova_npm}}/{{cordova_git}}) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7066) cordova prepare firefoxos overwrites icons in manifest
Pierre Rudloff created CB-7066: -- Summary: cordova prepare firefoxos overwrites icons in manifest Key: CB-7066 URL: https://issues.apache.org/jira/browse/CB-7066 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Affects Versions: 3.5.0 Environment: Debian 7.5 Reporter: Pierre Rudloff I have got some icons manually set in a manifest file that is in my www folder: "icons": { "32": "/img/logo_32.png", "60": "/img/logo_60.png", "90": "/img/logo_90.png", "120": "/img/logo_120.png", "128": "/img/logo_128.png", "256": "/img/logo_256.png" } When I run {{cordova prepare firefoxos}}, it creates a new manifest file in {{platforms/firefoxos/www}} but does not keep my icons: "icons": { "57": "/icon-57.png", "72": "/icon-72.png", "114": "/icon-114.png", "144": "/icon-144.png" }, -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050976#comment-14050976 ] ASF subversion and git services commented on CB-6357: - Commit a18029fe893a14416be78eaf2d2a3ac8c20c3016 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a18029f ] CB-6357 (fix latent bug) > platform check should install each platform to determine if they're > functional and their version number > --- > > Key: CB-6357 > URL: https://issues.apache.org/jira/browse/CB-6357 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Currently `cordova platform check` has a few behaviors which are not > necessarily ideal: > 1. It relies on the platforms.js file to have valid versions which match what > is actually in the cached ~/.cordova/lib space. > 2. If a platform is installed for which there's a newer version which won't > install (e.g. you're on Windows and you have iOS installed), it could tell > you that there's an upgrade available, however, you won't be able to install > it. > We'd like to fix these limitations by having platform check actually run the > version script against a live project. This should mean that there will not > be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7067) run jasmine tests individually
Josh Soref created CB-7067: -- Summary: run jasmine tests individually Key: CB-7067 URL: https://issues.apache.org/jira/browse/CB-7067 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref The way we run tests right now has a couple of painful points: 1. We can't skip only some tests in a single spec file because jasmine is treating all of our tests as a single set run together, and so by saying "I want to prefer test X in file A", it's interpreting that as "I don't want to run any other tests in any other file unless they are also preferred". That's pretty annoying. 2. Spys and other manipulations we do in a spec can have adverse impact on unrelated tests. Trying to get tests to work thus involves debugging all other tests and hunting for common problems. Neither of these things pain ports are necessary afaict. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7067) run jasmine tests individually
[ https://issues.apache.org/jira/browse/CB-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051021#comment-14051021 ] ASF GitHub Bot commented on CB-7067: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/51 CB-7067 run jasmine tests individually CB-7067 run jasmine tests individually `superspawn.spawn` `opts` now take `onstdio` and `onstderr` to incrementally handle output from child processes. `npm run jasmine` now runs `jasmine-serial` instead of `jasmine-node` `jasmine-serial` runs each test that `jasmine-node` would have run in the same order `jasmine-node` would have run them using `jasmine-node` with any command-line arguments you pass it (that `jasmine-serial` supports). `serve.spec` now skips tests for platforms for which it's missing the required binaries. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_7067 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit d81e946500ed7daffe579b3904161149e5eef25e Author: Josh Soref Date: 2014-07-03T01:09:39Z CB-7067 run jasmine tests individually `superspawn.spawn` `opts` now take `onstdio` and `onstderr` to incrementally handle output from child processes. `npm run jasmine` now runs `jasmine-serial` instead of `jasmine-node` `jasmine-serial` runs each test that `jasmine-node` would have run in the same order `jasmine-node` would have run them using `jasmine-node` with any command-line arguments you pass it (that `jasmine-serial` supports). `serve.spec` now skips tests for platforms for which it's missing the required binaries. > run jasmine tests individually > -- > > Key: CB-7067 > URL: https://issues.apache.org/jira/browse/CB-7067 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > The way we run tests right now has a couple of painful points: > 1. We can't skip only some tests in a single spec file because jasmine is > treating all of our tests as a single set run together, and so by saying "I > want to prefer test X in file A", it's interpreting that as "I don't want to > run any other tests in any other file unless they are also preferred". That's > pretty annoying. > 2. Spys and other manipulations we do in a spec can have adverse impact on > unrelated tests. Trying to get tests to work thus involves debugging all > other tests and hunting for common problems. > Neither of these things pain ports are necessary afaict. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7067) run jasmine tests individually
[ https://issues.apache.org/jira/browse/CB-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051024#comment-14051024 ] ASF GitHub Bot commented on CB-7067: Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/51#issuecomment-47863431 @kamrik: how's this? > run jasmine tests individually > -- > > Key: CB-7067 > URL: https://issues.apache.org/jira/browse/CB-7067 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > The way we run tests right now has a couple of painful points: > 1. We can't skip only some tests in a single spec file because jasmine is > treating all of our tests as a single set run together, and so by saying "I > want to prefer test X in file A", it's interpreting that as "I don't want to > run any other tests in any other file unless they are also preferred". That's > pretty annoying. > 2. Spys and other manipulations we do in a spec can have adverse impact on > unrelated tests. Trying to get tests to work thus involves debugging all > other tests and hunting for common problems. > Neither of these things pain ports are necessary afaict. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7026) Deploy step for windows8 and wp8 fails with `timed out` message
[ https://issues.apache.org/jira/browse/CB-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051101#comment-14051101 ] ASF GitHub Bot commented on CB-7026: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-medic/pull/13 CB-7026 Adds info about creating necessary design documents to CouchDB You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 587b34e92116e4d3a0ab6f4fcb1c2d6554f45e34 Author: Vladimir Kotikov Date: 2014-06-25T13:44:23Z CB-7026 Adds info about creating necessary design documents to CouchDB > Deploy step for windows8 and wp8 fails with `timed out` message > --- > > Key: CB-7026 > URL: https://issues.apache.org/jira/browse/CB-7026 > Project: Apache Cordova > Issue Type: Bug > Components: Medic, Windows 8, WP8 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > > Build for both Windows8 and wp8 fails on last step 'Deploy...' with following > output: > {noformat} > [WP8] Modifying Cordova wp8 application. (sha: WP8__master__1403700905) > [WP8] Write medic.json to autotest folder (sha: WP8__master__1403700905) > [WP8] [DEPLOY] starting deploy via command: cd > d:\medic\slave\WP8_Master\build\mobilespec\platforms\wp8\..\..\ && node > ..\cordova-cli\bin\cordova run --emulator wp8 (WP8__master__1403700905) > query failed for mobilespec_results true > ... > query failed for mobilespec_results true > [WP8 ERROR]: (sha: WP8__ma) > WP8 tests execution failed. > timed out > {noformat} > Mobilespec tests are passing and test info is being written to couchDB but > build script can't retrieve this results. This is because corresponding > design document in {{mobilespec_results}} is missing. > Here is request URL: > {{http://o146:5984/mobilespec_results/_design/results/_view/sha?key="WP8__master__1403700905}} > Problem is that {{_design/results/_view/sha}} design document is missing from > {{mobilespec_results}} table.It needs to be created manually, but this is not > described in README.md for cordova-medic. > It is necessary to add info about creating corresponding design document to > {{mobilespec_results}} table to README.md -- This message was sent by Atlassian JIRA (v6.2#6252)