[jira] [Commented] (CB-6667) window.requestFileSystem - callbacks are not fired in a particular circumstance
[ https://issues.apache.org/jira/browse/CB-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107715#comment-14107715 ] Slava Kim commented on CB-6667: --- For anyone else looking at this, this patch helped us: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=445ddd8 > window.requestFileSystem - callbacks are not fired in a particular > circumstance > --- > > Key: CB-6667 > URL: https://issues.apache.org/jira/browse/CB-6667 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 > Environment: Mac OS X 10.9.2 > Android SDK (latest) - API v19 > Eclipse 4.2.2 >Reporter: Kelvin Dart >Priority: Critical > Labels: Android4.4.x, Cordova, androidmanifest.xml, window > > Excuse the essay, but I have a very odd issue that I have singled down to > Cordova which happens in a very specific circumstance on Android. > I have provided a project of the stock Cordova Android project which can be > found here: http://www.filedropper.com/windowfstest - with a minor > modification for the issue I am having. > I have uploaded a compiled APK to install to your device here: > http://www.filedropper.com/windowfstest140509-1404 > Steps to replicate are: > 1) Download and install that APK onto your device (I was using the Samsung > Galaxy S4 with Android 4.4.2 running, no root, and stock TouchWiz ROM, I > *hope* this occurs on other Android devices but have not had an opportunity > to verify). > 2) Start the application and observe an alert appears stating 'dr', then > afterwards another alert appears, 'got FS' - if you check the code, you'll > see this is normal from my app.initialize(). > 3) Once those two alerts have appeared, press the Android 'home' button, to > quit to the main Android home screen. > 4) Go into another app or two and just use your phone normally. What we are > trying to achieve here is for the Android memory management system to > 'end'/kill the WindowFSTest app in the backend. > 5) Go into Apps > WindowFSTest (i.e. the app in question) and hopefully it > will have restarted - the app has to have restarted for the bug to occur, and > observe a few things here: > a) Verify the app has restarted, this can be verified by the 'dr' popup > occuring when Cordova loads. > b) Once you are confident the app has been restarted, observe the initial > 'dr' popup, but *not* the 'got FS' popup - this is the bug, the > window.requestFileSystem does not fire the callbacks for some reason - and I > do not know why. > N.b. there are a few things to note here which is why the bug is tricky to > replicate AND I imagine will be even more difficult to debug at a lower level > ;-) > 1) The Android system has to kill the app in the backend once you've pressed > the 'home' button - there's no way of determining when this has happened, > just use the phone like ordinary for half a minute or so - normally it kills > it after a short period. > 2) The way to restart the app is via Apps > WindowFSTest (not via the task > manager). > 3) ***IMPORTANT*** the above two steps seem to occur only when you run it > from a compiled APK, not directly from source/debug APK - so it's not as easy > to debug since you cannot put line breaks in the Java file(s). > Although not perfect, one way to fix this is to use: > android:launchMode="singleTop" > In AndroidManifest.xml - since it ensures the app is 'resumed' instead of > restarted. > I can provide a video upon request illustrating the issue. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6667) window.requestFileSystem - callbacks are not fired in a particular circumstance
[ https://issues.apache.org/jira/browse/CB-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107694#comment-14107694 ] Slava Kim commented on CB-6667: --- Hey everyone. Here at Meteor we rely on the file-saving heavily for our implementation of Hot Code push updates. We are very interested in a fix of this. Any updates from the Cordova Core team? > window.requestFileSystem - callbacks are not fired in a particular > circumstance > --- > > Key: CB-6667 > URL: https://issues.apache.org/jira/browse/CB-6667 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 > Environment: Mac OS X 10.9.2 > Android SDK (latest) - API v19 > Eclipse 4.2.2 >Reporter: Kelvin Dart >Priority: Critical > Labels: Android4.4.x, Cordova, androidmanifest.xml, window > > Excuse the essay, but I have a very odd issue that I have singled down to > Cordova which happens in a very specific circumstance on Android. > I have provided a project of the stock Cordova Android project which can be > found here: http://www.filedropper.com/windowfstest - with a minor > modification for the issue I am having. > I have uploaded a compiled APK to install to your device here: > http://www.filedropper.com/windowfstest140509-1404 > Steps to replicate are: > 1) Download and install that APK onto your device (I was using the Samsung > Galaxy S4 with Android 4.4.2 running, no root, and stock TouchWiz ROM, I > *hope* this occurs on other Android devices but have not had an opportunity > to verify). > 2) Start the application and observe an alert appears stating 'dr', then > afterwards another alert appears, 'got FS' - if you check the code, you'll > see this is normal from my app.initialize(). > 3) Once those two alerts have appeared, press the Android 'home' button, to > quit to the main Android home screen. > 4) Go into another app or two and just use your phone normally. What we are > trying to achieve here is for the Android memory management system to > 'end'/kill the WindowFSTest app in the backend. > 5) Go into Apps > WindowFSTest (i.e. the app in question) and hopefully it > will have restarted - the app has to have restarted for the bug to occur, and > observe a few things here: > a) Verify the app has restarted, this can be verified by the 'dr' popup > occuring when Cordova loads. > b) Once you are confident the app has been restarted, observe the initial > 'dr' popup, but *not* the 'got FS' popup - this is the bug, the > window.requestFileSystem does not fire the callbacks for some reason - and I > do not know why. > N.b. there are a few things to note here which is why the bug is tricky to > replicate AND I imagine will be even more difficult to debug at a lower level > ;-) > 1) The Android system has to kill the app in the backend once you've pressed > the 'home' button - there's no way of determining when this has happened, > just use the phone like ordinary for half a minute or so - normally it kills > it after a short period. > 2) The way to restart the app is via Apps > WindowFSTest (not via the task > manager). > 3) ***IMPORTANT*** the above two steps seem to occur only when you run it > from a compiled APK, not directly from source/debug APK - so it's not as easy > to debug since you cannot put line breaks in the Java file(s). > Although not perfect, one way to fix this is to use: > android:launchMode="singleTop" > In AndroidManifest.xml - since it ensures the app is 'resumed' instead of > restarted. > I can provide a video upon request illustrating the issue. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[
https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107638#comment-14107638
]
ASF GitHub Bot commented on CB-6837:
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/117
[CB-6837][Android] Fix: leaked window when hitting back button while alert
being rendered
Created arrayList on ChromeClient that it will register all showed
AlertDialog, using CordovaChromeClient class, this applies to AlertDialogs
object, included messages, prompts and confirm AlertDialog objects.
When onDestroy() method is called on the CordovaActivity, it will perform a
call to ChromeClient class to destroy all AlerDialogs objects registered on the
arrayList.
This would perform a cleanup before the CordovaActivity is destroyed.
dlg.show() returns an AlertDialog object, to be added to the arrayList.
It can be:
dialogsManager.add(dlg.show());
But I think it looks cleaner as is already.
Tested on 4.2.2 & 4.4.2.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-android CB-6837
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
commit 1dcadbcbb28053b5f9ec81feb2d40660d2978974
Author: Martin Gonzalez
Date: 2014-08-22T22:43:04Z
[CB-6837 - Android] Fix leaked window when hitting back button while alert
being rendered
> Hitting Back button while alert being rendered causes leaked window
> ---
>
> Key: CB-6837
> URL: https://issues.apache.org/jira/browse/CB-6837
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: 3.5.0
>Reporter: Marcel Kinard
>Assignee: Martin Gonzalez
>Priority: Minor
> Attachments: index.html
>
>
> On master and using dialogs plugin. Using a trivial app that has a button to
> create an alert dialog after 500ms timeout. If the Back button is hit at
> approximately the same time as the timer expires and the alert is to be
> shown, the following exception appears in logcat:
> D/CordovaWebView( 8178): The current URL is:
> file:///android_asset/www/index.html
> D/CordovaWebView( 8178): The URL at item 0 is:
> file:///android_asset/www/index.html
> D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused
> 54ms, total 55ms
> D/CordovaActivity( 8178): Paused the application!
> D/CordovaWebView( 8178): Handle the pause
> W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection
> W/InputMethodManagerService( 513): Starting input on non-focused client
> com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050
> pid=8178)
> D/CordovaActivity( 8178): CordovaActivity.onDestroy()
> D/CordovaWebView( 8178): >>> loadUrlNow()
> E/WindowManager( 8178):
> E/WindowManager( 8178): android.view.WindowLeaked: Activity
> com.example.Example has leaked window
> com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E.
> R.I. 0,0-465,256} that was originally added here
> E/WindowManager( 8178): at
> android.view.ViewRootImpl.(ViewRootImpl.java:348)
> E/WindowManager( 8178): at
> android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248)
> E/WindowManager( 8178): at
> android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69)
> E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286)
> E/WindowManager( 8178): at
> android.app.AlertDialog$Builder.show(AlertDialog.java:951)
> E/WindowManager( 8178): at
> org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143)
> E/WindowManager( 8178): at
> com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606)
> E/WindowManager( 8178): at
> com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73)
> E/WindowManager( 8178): at
> com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native
> Method)
> E/WindowManager( 8178): at
> com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27)
> E/WindowManager( 8178): at
> android.os.Handler.dispatchMessage(Handler.java:102)
> E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136)
> E/WindowManager( 8178): at
> android.app.ActivityThread.main(ActivityThread.java:5017)
> E/WindowManager( 8178): at java.lang.reflect.Me
[jira] [Commented] (CB-7372) Prepare for FirefoxOS on Windows generates incorrect path
[ https://issues.apache.org/jira/browse/CB-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107605#comment-14107605 ] ASF GitHub Bot commented on CB-7372: GitHub user Menardi opened a pull request: https://github.com/apache/cordova-lib/pull/77 CB-7372 Remove use of path.join for manifest.launch_path I was having issues on Windows when creating a new FirefoxOS project. A brand new project, when added to the Firefox App Manager, gave an error: "Launch path has to be an absolute path starting with '/': '\index.html'". The issue is the use of path.join to generate manifest.launch_path. On Windows, this uses backslashes, which caused the issue. I have opted to simply use concatenation instead. I have also fixed an issue where "cordova prepare firefoxos" would fail if there was no tag in the config.xml. If it is not present, we default to index.html. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Menardi/cordova-lib patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit d79f0c16e89a77e682b750e10c195e45bf1430c2 Author: Menardi Date: 2014-08-22T21:35:13Z Remove use of path.join for manifest.launch_path I was having issues on Windows when creating a new FirefoxOS project. A brand new project, when added to the Firefox App Manager, gave an error: "Launch path has to be an absolute path starting with '/': '\index.html'". The issue is the use of path.join to generate manifest.launch_path. On Windows, this uses backslashes, which caused the issue. I have opted to simply use concatenation instead. I have also fixed an issue where "cordova prepare firefoxos" would fail if there was no tag in the config.xml. If it is not present, we default to index.html. > Prepare for FirefoxOS on Windows generates incorrect path > - > > Key: CB-7372 > URL: https://issues.apache.org/jira/browse/CB-7372 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, FirefoxOS >Affects Versions: 3.5.0 > Environment: Windows 8 64-bit >Reporter: Gearóid Moroney >Priority: Critical > > On Windows, the manifest.webapp file for Firefox OS has an invalid path. The > file must be edited manually to get the app to work. > To reproduce: > - Install Cordova 3.5.0 > - Create a new project: cordova create test > - In the test folder, add FxOS: cordova platform add firefoxos > - Package the app. For FxOS all that needs to be done is prepare: cordova > prepare firefoxos > - In Firefox (at least version 26), go to about:app-manager > - Click Apps on the left, and then "Add Packaged App" on the bottom. Select > test/platforms/firefoxos/www > - On the right-hand side, notice the error: "Launch path has to be an > absolute path starting with '/': '\index.html'" > I have a fix ready for this and will submit a pull request on GitHub. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7372) Prepare for FirefoxOS on Windows generates incorrect path
[ https://issues.apache.org/jira/browse/CB-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gearóid Moroney updated CB-7372: Component/s: CordovaLib > Prepare for FirefoxOS on Windows generates incorrect path > - > > Key: CB-7372 > URL: https://issues.apache.org/jira/browse/CB-7372 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, FirefoxOS >Affects Versions: 3.5.0 > Environment: Windows 8 64-bit >Reporter: Gearóid Moroney >Priority: Critical > > On Windows, the manifest.webapp file for Firefox OS has an invalid path. The > file must be edited manually to get the app to work. > To reproduce: > - Install Cordova 3.5.0 > - Create a new project: cordova create test > - In the test folder, add FxOS: cordova platform add firefoxos > - Package the app. For FxOS all that needs to be done is prepare: cordova > prepare firefoxos > - In Firefox (at least version 26), go to about:app-manager > - Click Apps on the left, and then "Add Packaged App" on the bottom. Select > test/platforms/firefoxos/www > - On the right-hand side, notice the error: "Launch path has to be an > absolute path starting with '/': '\index.html'" > I have a fix ready for this and will submit a pull request on GitHub. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7372) Prepare for FirefoxOS on Windows generates incorrect path
Gearóid Moroney created CB-7372: --- Summary: Prepare for FirefoxOS on Windows generates incorrect path Key: CB-7372 URL: https://issues.apache.org/jira/browse/CB-7372 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Affects Versions: 3.5.0 Environment: Windows 8 64-bit Reporter: Gearóid Moroney Priority: Critical On Windows, the manifest.webapp file for Firefox OS has an invalid path. The file must be edited manually to get the app to work. To reproduce: - Install Cordova 3.5.0 - Create a new project: cordova create test - In the test folder, add FxOS: cordova platform add firefoxos - Package the app. For FxOS all that needs to be done is prepare: cordova prepare firefoxos - In Firefox (at least version 26), go to about:app-manager - Click Apps on the left, and then "Add Packaged App" on the bottom. Select test/platforms/firefoxos/www - On the right-hand side, notice the error: "Launch path has to be an absolute path starting with '/': '\index.html'" I have a fix ready for this and will submit a pull request on GitHub. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[
https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107516#comment-14107516
]
Martin Gonzalez commented on CB-6837:
-
the Alert dialog, it throws the exception above described, because when it
tries to destroy the view, the dialog object makes an attempt to perform on the
view.
The workaround it should be avoid that exception, by destroying or dismiss all
alert objects during onDestroy().
> Hitting Back button while alert being rendered causes leaked window
> ---
>
> Key: CB-6837
> URL: https://issues.apache.org/jira/browse/CB-6837
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: 3.5.0
>Reporter: Marcel Kinard
>Assignee: Martin Gonzalez
>Priority: Minor
> Attachments: index.html
>
>
> On master and using dialogs plugin. Using a trivial app that has a button to
> create an alert dialog after 500ms timeout. If the Back button is hit at
> approximately the same time as the timer expires and the alert is to be
> shown, the following exception appears in logcat:
> D/CordovaWebView( 8178): The current URL is:
> file:///android_asset/www/index.html
> D/CordovaWebView( 8178): The URL at item 0 is:
> file:///android_asset/www/index.html
> D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused
> 54ms, total 55ms
> D/CordovaActivity( 8178): Paused the application!
> D/CordovaWebView( 8178): Handle the pause
> W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection
> W/InputMethodManagerService( 513): Starting input on non-focused client
> com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050
> pid=8178)
> D/CordovaActivity( 8178): CordovaActivity.onDestroy()
> D/CordovaWebView( 8178): >>> loadUrlNow()
> E/WindowManager( 8178):
> E/WindowManager( 8178): android.view.WindowLeaked: Activity
> com.example.Example has leaked window
> com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E.
> R.I. 0,0-465,256} that was originally added here
> E/WindowManager( 8178): at
> android.view.ViewRootImpl.(ViewRootImpl.java:348)
> E/WindowManager( 8178): at
> android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248)
> E/WindowManager( 8178): at
> android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69)
> E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286)
> E/WindowManager( 8178): at
> android.app.AlertDialog$Builder.show(AlertDialog.java:951)
> E/WindowManager( 8178): at
> org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143)
> E/WindowManager( 8178): at
> com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606)
> E/WindowManager( 8178): at
> com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73)
> E/WindowManager( 8178): at
> com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native
> Method)
> E/WindowManager( 8178): at
> com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27)
> E/WindowManager( 8178): at
> android.os.Handler.dispatchMessage(Handler.java:102)
> E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136)
> E/WindowManager( 8178): at
> android.app.ActivityThread.main(ActivityThread.java:5017)
> E/WindowManager( 8178): at java.lang.reflect.Method.invokeNative(Native
> Method)
> E/WindowManager( 8178): at
> java.lang.reflect.Method.invoke(Method.java:515)
> E/WindowManager( 8178): at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
> E/WindowManager( 8178): at
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
> E/WindowManager( 8178): at dalvik.system.NativeStart.main(Native Method)
> D/CordovaWebViewClient( 8178): onPageFinished(about:blank)
> D/CordovaActivity( 8178): onMessage(onPageFinished,about:blank)
> D/CordovaActivity( 8178): onMessage(exit,null)
> It looks like there is an attempt to show the alert dialog after the
> activity's onDestroy() method has been called.
> When resuming the app by clicking on it's icon in the home screen or using
> the Multitask button, the webview doesn't render completely, I see only a
> black screen with the usual status bar. The app must be killed, and then it
> works fine after a restart. It appears that there is a pretty small time
> window during the timeout in which this can be reproduced, something on the
> order of 200ms.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[
https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Gonzalez reassigned CB-6837:
---
Assignee: Martin Gonzalez (was: Marcel Kinard)
> Hitting Back button while alert being rendered causes leaked window
> ---
>
> Key: CB-6837
> URL: https://issues.apache.org/jira/browse/CB-6837
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: 3.5.0
>Reporter: Marcel Kinard
>Assignee: Martin Gonzalez
>Priority: Minor
> Attachments: index.html
>
>
> On master and using dialogs plugin. Using a trivial app that has a button to
> create an alert dialog after 500ms timeout. If the Back button is hit at
> approximately the same time as the timer expires and the alert is to be
> shown, the following exception appears in logcat:
> D/CordovaWebView( 8178): The current URL is:
> file:///android_asset/www/index.html
> D/CordovaWebView( 8178): The URL at item 0 is:
> file:///android_asset/www/index.html
> D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused
> 54ms, total 55ms
> D/CordovaActivity( 8178): Paused the application!
> D/CordovaWebView( 8178): Handle the pause
> W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection
> W/InputMethodManagerService( 513): Starting input on non-focused client
> com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050
> pid=8178)
> D/CordovaActivity( 8178): CordovaActivity.onDestroy()
> D/CordovaWebView( 8178): >>> loadUrlNow()
> E/WindowManager( 8178):
> E/WindowManager( 8178): android.view.WindowLeaked: Activity
> com.example.Example has leaked window
> com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E.
> R.I. 0,0-465,256} that was originally added here
> E/WindowManager( 8178): at
> android.view.ViewRootImpl.(ViewRootImpl.java:348)
> E/WindowManager( 8178): at
> android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248)
> E/WindowManager( 8178): at
> android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69)
> E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286)
> E/WindowManager( 8178): at
> android.app.AlertDialog$Builder.show(AlertDialog.java:951)
> E/WindowManager( 8178): at
> org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143)
> E/WindowManager( 8178): at
> com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606)
> E/WindowManager( 8178): at
> com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73)
> E/WindowManager( 8178): at
> com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native
> Method)
> E/WindowManager( 8178): at
> com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27)
> E/WindowManager( 8178): at
> android.os.Handler.dispatchMessage(Handler.java:102)
> E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136)
> E/WindowManager( 8178): at
> android.app.ActivityThread.main(ActivityThread.java:5017)
> E/WindowManager( 8178): at java.lang.reflect.Method.invokeNative(Native
> Method)
> E/WindowManager( 8178): at
> java.lang.reflect.Method.invoke(Method.java:515)
> E/WindowManager( 8178): at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
> E/WindowManager( 8178): at
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
> E/WindowManager( 8178): at dalvik.system.NativeStart.main(Native Method)
> D/CordovaWebViewClient( 8178): onPageFinished(about:blank)
> D/CordovaActivity( 8178): onMessage(onPageFinished,about:blank)
> D/CordovaActivity( 8178): onMessage(exit,null)
> It looks like there is an attempt to show the alert dialog after the
> activity's onDestroy() method has been called.
> When resuming the app by clicking on it's icon in the home screen or using
> the Multitask button, the webview doesn't render completely, I see only a
> black screen with the usual status bar. The app must be killed, and then it
> works fine after a restart. It appears that there is a pretty small time
> window during the timeout in which this can be reproduced, something on the
> order of 200ms.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7371) [Android] App crashes after phone language change
[
https://issues.apache.org/jira/browse/CB-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107503#comment-14107503
]
ASF GitHub Bot commented on CB-7371:
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/116
[CB-7371 -Android] Fixed: app crash after phone language change
The main reason of this behavior is the config.xml, origin="" tag,
specifies access to all kind of resources on the network and makes the
whiteList object on the WhiteList class a null object, indicating that when
origin="", there's no whiteList, all is allowed.
When it tries to resume the application it checks:
if (url.startsWith("file://") || url.startsWith("javascript:") ||
whitelist.isUrlWhiteListed(url))
This condition passes and triggers the load for 'about:blank'
The condition passes because, whitelist.isUrlWhiteListed(url) statement
returns true.
When the origin="*" is processed by the WhiteList class, it sets a null to
the whiteList object, which it should contain the access to resources allowed,
however when whitelist.isUrlWhiteListed(url) it returns a true if the whiteList
object is null, therefore the condition passes and continues to the loadurl
method on webClient, stopping the application, because of the 'about:blank' url.
Adding another condition along with that statement for when whiteList =
null, but url= about:blank, in that way it won't be able to load the url.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-android CB-7371
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
commit f3e9d46e533d7915876c09c6f95afcea7d842323
Author: Martin Gonzalez
Date: 2014-08-22T21:04:25Z
[CB-7371 -Android] Fixed: app crash after phone language change
> [Android] App crashes after phone language change
> -
>
> Key: CB-7371
> URL: https://issues.apache.org/jira/browse/CB-7371
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: 3.5.0
> Environment: 4.2.2 (Jelly-Bean)
> 4.4.2 (KitKat)
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: android, crash
> Fix For: 3.6.0
>
>
> After switching device language on android, the app will fails to reload
> scenario:
> 1. Create new app
> 2. open it and exit with the home button
> 3.Switch device language to or any other
> 4. Resume the app
> Expected result :
> the app should run
> Actual result:
> app crashes on first load
> Log:
> 07-28 16:24:10.018: D/CordovaActivity(25402): CordovaActivity.onDestroy()
> 07-28 16:24:10.028: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.038: I/CordovaLog(25402): Changing log level to DEBUG(3)
> 07-28 16:24:10.038: I/CordovaLog(25402): Found start page location:
> cdvtests/index.html
> 07-28 16:24:10.038: D/CordovaActivity(25402): CordovaActivity.onCreate()
> 07-28 16:24:10.048: D/CordovaActivity(25402): CordovaActivity.init()
> 07-28 16:24:10.058: D/CordovaWebView(25402): >>>
> loadUrl(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.068: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.068: I/CordovaLog(25402): Found start page location:
> cdvtests/index.html
> 07-28 16:24:10.068: D/CordovaActivity(25402): Resuming the App
> 07-28 16:24:10.068: D/CordovaActivity(25402): CB-3064: The errorUrl is null
> 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageStarted(about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402):
> onMessage(onPageStarted,about:blank)
> 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageFinished(about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402):
> onMessage(onPageFinished,about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402): onMessage(exit,null)
> 07-28 16:24:10.088: D/CordovaWebViewClient(25402):
> onPageStarted(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.088: D/CordovaActivity(25402):
> onMessage(onPageStarted,file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.108: D/CordovaActivity(25402): Paused the application!
> 07-28 16:24:10.108: D/CordovaWebView(25402): Handle the pause
> 07-28 16:24:10.148: D/CordovaActivity(25402): CordovaActivity.onDestroy()
> 07-28 16:24:10.148: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.158: D/CordovaWebViewClient(25402):
> onPageFinished(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.158: D/CordovaActivity(25402):
> onMessage(onPageFinished,
[jira] [Commented] (CB-7371) [Android] App crashes after phone language change
[ https://issues.apache.org/jira/browse/CB-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107473#comment-14107473 ] ASF GitHub Bot commented on CB-7371: Github user martincgg closed the pull request at: https://github.com/apache/cordova-android/pull/115 > [Android] App crashes after phone language change > - > > Key: CB-7371 > URL: https://issues.apache.org/jira/browse/CB-7371 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 > Environment: 4.2.2 (Jelly-Bean) > 4.4.2 (KitKat) >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: android, crash > Fix For: 3.6.0 > > > After switching device language on android, the app will fails to reload > scenario: > 1. Create new app > 2. open it and exit with the home button > 3.Switch device language to or any other > 4. Resume the app > Expected result : > the app should run > Actual result: > app crashes on first load > Log: > 07-28 16:24:10.018: D/CordovaActivity(25402): CordovaActivity.onDestroy() > 07-28 16:24:10.028: D/CordovaWebView(25402): >>> loadUrlNow() > 07-28 16:24:10.038: I/CordovaLog(25402): Changing log level to DEBUG(3) > 07-28 16:24:10.038: I/CordovaLog(25402): Found start page location: > cdvtests/index.html > 07-28 16:24:10.038: D/CordovaActivity(25402): CordovaActivity.onCreate() > 07-28 16:24:10.048: D/CordovaActivity(25402): CordovaActivity.init() > 07-28 16:24:10.058: D/CordovaWebView(25402): >>> > loadUrl(file:///android_asset/www/cdvtests/index.html) > 07-28 16:24:10.068: D/CordovaWebView(25402): >>> loadUrlNow() > 07-28 16:24:10.068: I/CordovaLog(25402): Found start page location: > cdvtests/index.html > 07-28 16:24:10.068: D/CordovaActivity(25402): Resuming the App > 07-28 16:24:10.068: D/CordovaActivity(25402): CB-3064: The errorUrl is null > 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageStarted(about:blank) > 07-28 16:24:10.078: D/CordovaActivity(25402): > onMessage(onPageStarted,about:blank) > 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageFinished(about:blank) > 07-28 16:24:10.078: D/CordovaActivity(25402): > onMessage(onPageFinished,about:blank) > 07-28 16:24:10.078: D/CordovaActivity(25402): onMessage(exit,null) > 07-28 16:24:10.088: D/CordovaWebViewClient(25402): > onPageStarted(file:///android_asset/www/cdvtests/index.html) > 07-28 16:24:10.088: D/CordovaActivity(25402): > onMessage(onPageStarted,file:///android_asset/www/cdvtests/index.html) > 07-28 16:24:10.108: D/CordovaActivity(25402): Paused the application! > 07-28 16:24:10.108: D/CordovaWebView(25402): Handle the pause > 07-28 16:24:10.148: D/CordovaActivity(25402): CordovaActivity.onDestroy() > 07-28 16:24:10.148: D/CordovaWebView(25402): >>> loadUrlNow() > 07-28 16:24:10.158: D/CordovaWebViewClient(25402): > onPageFinished(file:///android_asset/www/cdvtests/index.html) > 07-28 16:24:10.158: D/CordovaActivity(25402): > onMessage(onPageFinished,file:///android_asset/www/cdvtests/index.html) > 07-28 16:24:10.168: D/CordovaWebViewClient(25402): onPageStarted(about:blank) > 07-28 16:24:10.168: D/CordovaActivity(25402): > onMessage(onPageStarted,about:blank) > 07-28 16:24:10.188: D/CordovaWebViewClient(25402): onPageFinished(about:blank) > 07-28 16:24:10.188: D/CordovaActivity(25402): > onMessage(onPageFinished,about:blank) > 07-28 16:24:10.188: D/CordovaActivity(25402): onMessage(exit,null) > 07-28 16:24:12.168: D/CordovaActivity(25402): onMessage(spinner,stop) > 07-28 16:24:12.188: D/CordovaActivity(25402): onMessage(spinner,stop) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107461#comment-14107461 ] ASF GitHub Bot commented on CB-7350: Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/105 > Make createmobilespec friendlier > > > Key: CB-7350 > URL: https://issues.apache.org/jira/browse/CB-7350 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > * Don't assume that the people running mobilespec are developers -- In my > experience, they aren't > * The READMEs needed a refresh > * Asking people to install grunt-cli globally is silly, we have npm > dependencies, we can use them. > * The pushd/popd spam is really not helpful afaict > * Provide information about how to use coho to get the right things more or > less at the right time > * Fix the __dirname output to be correct > ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107458#comment-14107458 ] ASF GitHub Bot commented on CB-7350: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/105 CB-7350 Rework createmobilespec * fix platform flag documentation for --amazon - wrap very long lines - clarify that /bin/create isn't a system application... - drop repetitive: when creating the mobile-spec project - it wasn't used consistently... * support directoryName for --plugman * delay pushd cli_project_dir until after couldNotFind cordova-plugin-test-framework check * Brand: BlackBerry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-mobile-spec docwork Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #105 commit a624fd9edf7828761b6df23e73e18181cc2b73c5 Author: Josh Soref Date: 2014-08-22T20:10:28Z CB-7350 Rework createmobilespec * fix platform flag documentation for --amazon - wrap very long lines - clarify that /bin/create isn't a system application... - drop repetitive: when creating the mobile-spec project - it wasn't used consistently... * support directoryName for --plugman * delay pushd cli_project_dir until after couldNotFind cordova-plugin-test-framework check * Brand: BlackBerry > Make createmobilespec friendlier > > > Key: CB-7350 > URL: https://issues.apache.org/jira/browse/CB-7350 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > * Don't assume that the people running mobilespec are developers -- In my > experience, they aren't > * The READMEs needed a refresh > * Asking people to install grunt-cli globally is silly, we have npm > dependencies, we can use them. > * The pushd/popd spam is really not helpful afaict > * Provide information about how to use coho to get the right things more or > less at the right time > * Fix the __dirname output to be correct > ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107460#comment-14107460 ] ASF subversion and git services commented on CB-7350: - Commit a624fd9edf7828761b6df23e73e18181cc2b73c5 in cordova-mobile-spec's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=a624fd9 ] CB-7350 Rework createmobilespec * fix platform flag documentation for --amazon - wrap very long lines - clarify that /bin/create isn't a system application... - drop repetitive: when creating the mobile-spec project - it wasn't used consistently... * support directoryName for --plugman * delay pushd cli_project_dir until after couldNotFind cordova-plugin-test-framework check * Brand: BlackBerry > Make createmobilespec friendlier > > > Key: CB-7350 > URL: https://issues.apache.org/jira/browse/CB-7350 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > * Don't assume that the people running mobilespec are developers -- In my > experience, they aren't > * The READMEs needed a refresh > * Asking people to install grunt-cli globally is silly, we have npm > dependencies, we can use them. > * The pushd/popd spam is really not helpful afaict > * Provide information about how to use coho to get the right things more or > less at the right time > * Fix the __dirname output to be correct > ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5312) Support github.com/apache repositories
[ https://issues.apache.org/jira/browse/CB-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107347#comment-14107347 ] ASF GitHub Bot commented on CB-5312: Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/34 > Support github.com/apache repositories > -- > > Key: CB-5312 > URL: https://issues.apache.org/jira/browse/CB-5312 > Project: Apache Cordova > Issue Type: Bug > Components: Coho >Affects Versions: 3.1.0 >Reporter: Josh Soref >Assignee: Josh Soref >Priority: Minor > > If you clone from the github.com/apache/ mirrors instead of the canonical > apache repositories, then coho doesn't work. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5312) Support github.com/apache repositories
[ https://issues.apache.org/jira/browse/CB-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107345#comment-14107345 ] ASF subversion and git services commented on CB-5312: - Commit 3f644787dea610ab3b8608562af616398d202e56 in cordova-coho's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=3f64478 ] CB-5312 Support github.com/apache repositories > Support github.com/apache repositories > -- > > Key: CB-5312 > URL: https://issues.apache.org/jira/browse/CB-5312 > Project: Apache Cordova > Issue Type: Bug > Components: Coho >Affects Versions: 3.1.0 >Reporter: Josh Soref >Assignee: Josh Soref >Priority: Minor > > If you clone from the github.com/apache/ mirrors instead of the canonical > apache repositories, then coho doesn't work. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7210) cleanup create remove clean/copyJavascript
[
https://issues.apache.org/jira/browse/CB-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Soref closed CB-7210.
--
Resolution: Fixed
Fix Version/s: 3.6.0
> cleanup create remove clean/copyJavascript
> --
>
> Key: CB-7210
> URL: https://issues.apache.org/jira/browse/CB-7210
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
> Fix For: 3.6.0
>
>
> I suspect that at some point the cordova.js script was built by create.
> These days, it's just a file, and not particularly interesting. The current
> code does a number of odd things in order to construct cordova.js.
> Unfortunately, those things aren't safe for people who are running create
> multiple times concurrently (either because they're using
> {{jasmine-isolated.js}} or some CI which happens to like to run things
> concurrently). Creating and deleting directories at fixed locations is
> hazardous to such tasks.
> I'd like to simplify the code...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Closed] (CB-7119) cordova run --target xxx dies if blackberry10.json is empty
[
https://issues.apache.org/jira/browse/CB-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Soref closed CB-7119.
--
Resolution: Fixed
Fix Version/s: 3.6.0
> cordova run --target xxx dies if blackberry10.json is empty
> ---
>
> Key: CB-7119
> URL: https://issues.apache.org/jira/browse/CB-7119
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
> Fix For: 3.6.0
>
>
> {quote}
> $ mv ~/.cordova/blackberry10.json ~/.cordova/blackberry10.json.x ; touch
> ~/.cordova/blackberry10.json; cordova run --target foo ; mv
> ~/.cordova/blackberry10.json.x ~/.cordova/blackberry10.json
> module.js:485
> throw err;
> ^
> SyntaxError: ~/.cordova/blackberry10.json: Unexpected end of input
> at Object.parse (native)
> at Object.Module._extensions..json (module.js:482:27)
> at Module.load (module.js:356:32)
> at Function.Module._load (module.js:312:12)
> at Module.require (module.js:364:17)
> at require (module.js:380:17)
> at Object._self.getProperties
> (project/platforms/blackberry10/cordova/lib/utils.js:303:22)
> at Object.
> (project/spatial/platforms/blackberry10/cordova/lib/target-utils.js:22:39)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Closed] (CB-7250) bin/test/cordova/integration/target.js risks destroying blackberry10.json
[
https://issues.apache.org/jira/browse/CB-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Soref closed CB-7250.
--
Resolution: Fixed
Fix Version/s: 3.6.0
> bin/test/cordova/integration/target.js risks destroying blackberry10.json
> -
>
> Key: CB-7250
> URL: https://issues.apache.org/jira/browse/CB-7250
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
> Fix For: 3.6.0
>
>
> I ran the test suite recently.
> Unfortunately, for unknown reasons, I'm now left with:
> {quote}
> $ cat ~/.cordova/blackberry10.json
> \{
> "targets": \{
> "z10": \{
> "ip": "169.254.0.1",
> "type": "device",
> "password": "pass",
> "pin": "DEADBEEF"
> }
> }
> }
> {quote}
> Tests should not do this. They should instead change their HOME / USERPROFILE
> environment variables to a directory w/in their own test directory.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Closed] (CB-7211) jshint: force to see all errors
[ https://issues.apache.org/jira/browse/CB-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7211. -- Resolution: Fixed Fix Version/s: 3.6.0 > jshint: force to see all errors > --- > > Key: CB-7211 > URL: https://issues.apache.org/jira/browse/CB-7211 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref >Priority: Minor > Fix For: 3.6.0 > > > Sometimes jshint will not show all its warnings, I'd rather show them all by > default... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7350. -- Resolution: Fixed Fix Version/s: 3.6.0 > Make createmobilespec friendlier > > > Key: CB-7350 > URL: https://issues.apache.org/jira/browse/CB-7350 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > * Don't assume that the people running mobilespec are developers -- In my > experience, they aren't > * The READMEs needed a refresh > * Asking people to install grunt-cli globally is silly, we have npm > dependencies, we can use them. > * The pushd/popd spam is really not helpful afaict > * Provide information about how to use coho to get the right things more or > less at the right time > * Fix the __dirname output to be correct > ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7329) fireos documentation image links are broken
[ https://issues.apache.org/jira/browse/CB-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref resolved CB-7329. Resolution: Fixed Fix Version/s: 3.6.0 > fireos documentation image links are broken > --- > > Key: CB-7329 > URL: https://issues.apache.org/jira/browse/CB-7329 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Affects Versions: 3.2.0, 3.3.0, 3.4.0, 3.5.0, 3.6.0 >Reporter: Josh Soref >Assignee: Josh Soref >Priority: Minor > Fix For: 3.6.0 > > > - > doesn't correctly map to a picture: > + -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7349) Tell users to run npm install
[ https://issues.apache.org/jira/browse/CB-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7349. -- Resolution: Fixed Fix Version/s: 3.6.0 > Tell users to run npm install > - > > Key: CB-7349 > URL: https://issues.apache.org/jira/browse/CB-7349 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > Fix For: 3.6.0 > > > I'm trying to get cordova-mobile-spec/createmobilespec to be friendly. > One of the many things which doesn't work well is the lack of an instruction > to run npm install from cordova-js at the proper time. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107295#comment-14107295
]
Archana Naik commented on CB-7363:
--
I am in the same boat as Josh. I am testing my dev work using mobielspec and
need to be able to distinguish 2 different versions. For mobilespec i want to
use my dev cli which uses everything dev(cordova-lib).
> Do not insist on precise version of cordova-lib
> ---
>
> Key: CB-7363
> URL: https://issues.apache.org/jira/browse/CB-7363
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, Plugman
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
> Fix For: 3.6.0
>
>
> Currently plugman's {{package.json}} has:
> {quote}
> "cordova-lib" : "0.21.6",
> {quote}
> Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
> which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
> _symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
> *obliterated*. This isn't desirable and makes a totally mess out of git
> repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7371) [Android] App crashes after phone language change
[
https://issues.apache.org/jira/browse/CB-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107231#comment-14107231
]
ASF GitHub Bot commented on CB-7371:
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/115
[CB-7371] Fixed: app crash after phone language change
The main reason of this behavior is the config.xml, origin="*" tag,
specifies access to all kind of resources on the network and makes the
whiteList object on the WhiteList class a null object, indicating that when
origin="*", there's no whiteList, all is allowed.
When it tries to resume the application it checks:
if (url.startsWith("file://") || url.startsWith("javascript:") ||
whitelist.isUrlWhiteListed(url))
This condition passes and triggers the load for 'about:blank'
The condition passes because, whitelist.isUrlWhiteListed(url) statement
returns true.
When the origin="*" is processed by the WhiteList class, it sets a null to
the whiteList object, which it should contain the access to resources allowed,
however when whitelist.isUrlWhiteListed(url) it returns a true if the whiteList
object is null, therefore the condition passes and continues to the loadurl
method on webClient, stopping the application, because of the 'about:blank' url.
Adding another condition along with that statement for when whiteList =
null, but url= about:blank, in that way it won't be able to load the url.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
commit f9c23ec8711719db86843e944e7749e758b2a3f4
Author: Martin Gonzalez
Date: 2014-08-22T18:09:42Z
CB-7371 Fixed: app crash after phone language change
> [Android] App crashes after phone language change
> -
>
> Key: CB-7371
> URL: https://issues.apache.org/jira/browse/CB-7371
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: 3.5.0
> Environment: 4.2.2 (Jelly-Bean)
> 4.4.2 (KitKat)
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
> Labels: android, crash
> Fix For: 3.6.0
>
>
> After switching device language on android, the app will fails to reload
> scenario:
> 1. Create new app
> 2. open it and exit with the home button
> 3.Switch device language to or any other
> 4. Resume the app
> Expected result :
> the app should run
> Actual result:
> app crashes on first load
> Log:
> 07-28 16:24:10.018: D/CordovaActivity(25402): CordovaActivity.onDestroy()
> 07-28 16:24:10.028: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.038: I/CordovaLog(25402): Changing log level to DEBUG(3)
> 07-28 16:24:10.038: I/CordovaLog(25402): Found start page location:
> cdvtests/index.html
> 07-28 16:24:10.038: D/CordovaActivity(25402): CordovaActivity.onCreate()
> 07-28 16:24:10.048: D/CordovaActivity(25402): CordovaActivity.init()
> 07-28 16:24:10.058: D/CordovaWebView(25402): >>>
> loadUrl(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.068: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.068: I/CordovaLog(25402): Found start page location:
> cdvtests/index.html
> 07-28 16:24:10.068: D/CordovaActivity(25402): Resuming the App
> 07-28 16:24:10.068: D/CordovaActivity(25402): CB-3064: The errorUrl is null
> 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageStarted(about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402):
> onMessage(onPageStarted,about:blank)
> 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageFinished(about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402):
> onMessage(onPageFinished,about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402): onMessage(exit,null)
> 07-28 16:24:10.088: D/CordovaWebViewClient(25402):
> onPageStarted(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.088: D/CordovaActivity(25402):
> onMessage(onPageStarted,file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.108: D/CordovaActivity(25402): Paused the application!
> 07-28 16:24:10.108: D/CordovaWebView(25402): Handle the pause
> 07-28 16:24:10.148: D/CordovaActivity(25402): CordovaActivity.onDestroy()
> 07-28 16:24:10.148: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.158: D/CordovaWebViewClient(25402):
> onPageFinished(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.158: D/CordovaActivity(25402):
> onMessage(onPageFinished,file:///android_asset/ww
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107183#comment-14107183 ] ASF GitHub Bot commented on CB-7350: Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/103 > Make createmobilespec friendlier > > > Key: CB-7350 > URL: https://issues.apache.org/jira/browse/CB-7350 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > * Don't assume that the people running mobilespec are developers -- In my > experience, they aren't > * The READMEs needed a refresh > * Asking people to install grunt-cli globally is silly, we have npm > dependencies, we can use them. > * The pushd/popd spam is really not helpful afaict > * Provide information about how to use coho to get the right things more or > less at the right time > * Fix the __dirname output to be correct > ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107180#comment-14107180 ] ASF subversion and git services commented on CB-7350: - Commit bf7089f80568725b753cd107f762a0963e2852df in cordova-mobile-spec's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=bf7089f ] CB-7350 Rework createmobilespec * Don't assume that the people running mobilespec are developers * Correct __dirname path output * quit instead of return in top level code... * use joinable array for platform_layout, localPlatforms - this means the couldNotFind can report the correct repo name for bb10 * Default to not logging pushd/popd (--debug to get it back) * Explain how to get coho * Provide information about how to use coho to get the right things more or less at the right time * Add could not find routine with coho instructions * Fix instructions for getting cli+lib and plugins * Remove recommendation to clone android * a few lines earlier it already said to repo-clone -r plugins * Skip broken platforms * Refactor installPlugins, updateJS, summary * warn about missing plugman * fixes --plugman for non ios platforms * add blackberry10 config dir info for plugman * Adding fallback for createmobilespec --plugman config.xml * correctly copy www directory contents... * Depend on grunt-cli + report missing grunt * Windows: fix symlink text * Brand: JavaScript > Make createmobilespec friendlier > > > Key: CB-7350 > URL: https://issues.apache.org/jira/browse/CB-7350 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > * Don't assume that the people running mobilespec are developers -- In my > experience, they aren't > * The READMEs needed a refresh > * Asking people to install grunt-cli globally is silly, we have npm > dependencies, we can use them. > * The pushd/popd spam is really not helpful afaict > * Provide information about how to use coho to get the right things more or > less at the right time > * Fix the __dirname output to be correct > ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107179#comment-14107179 ] ASF subversion and git services commented on CB-7350: - Commit a9a9b2d5fff27a1191ad40b29937aa50fd50dbe3 in cordova-mobile-spec's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=a9a9b2d ] CB-7350 Improve README.md markdown Also annotate points where I think the content is wrong > Make createmobilespec friendlier > > > Key: CB-7350 > URL: https://issues.apache.org/jira/browse/CB-7350 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > * Don't assume that the people running mobilespec are developers -- In my > experience, they aren't > * The READMEs needed a refresh > * Asking people to install grunt-cli globally is silly, we have npm > dependencies, we can use them. > * The pushd/popd spam is really not helpful afaict > * Provide information about how to use coho to get the right things more or > less at the right time > * Fix the __dirname output to be correct > ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7371) [Android] App crashes after phone language change
Martin Gonzalez created CB-7371: --- Summary: [Android] App crashes after phone language change Key: CB-7371 URL: https://issues.apache.org/jira/browse/CB-7371 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: 4.2.2 (Jelly-Bean) 4.4.2 (KitKat) Reporter: Martin Gonzalez Assignee: Martin Gonzalez Fix For: 3.6.0 After switching device language on android, the app will fails to reload scenario: 1. Create new app 2. open it and exit with the home button 3.Switch device language to or any other 4. Resume the app Expected result : the app should run Actual result: app crashes on first load Log: 07-28 16:24:10.018: D/CordovaActivity(25402): CordovaActivity.onDestroy() 07-28 16:24:10.028: D/CordovaWebView(25402): >>> loadUrlNow() 07-28 16:24:10.038: I/CordovaLog(25402): Changing log level to DEBUG(3) 07-28 16:24:10.038: I/CordovaLog(25402): Found start page location: cdvtests/index.html 07-28 16:24:10.038: D/CordovaActivity(25402): CordovaActivity.onCreate() 07-28 16:24:10.048: D/CordovaActivity(25402): CordovaActivity.init() 07-28 16:24:10.058: D/CordovaWebView(25402): >>> loadUrl(file:///android_asset/www/cdvtests/index.html) 07-28 16:24:10.068: D/CordovaWebView(25402): >>> loadUrlNow() 07-28 16:24:10.068: I/CordovaLog(25402): Found start page location: cdvtests/index.html 07-28 16:24:10.068: D/CordovaActivity(25402): Resuming the App 07-28 16:24:10.068: D/CordovaActivity(25402): CB-3064: The errorUrl is null 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageStarted(about:blank) 07-28 16:24:10.078: D/CordovaActivity(25402): onMessage(onPageStarted,about:blank) 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageFinished(about:blank) 07-28 16:24:10.078: D/CordovaActivity(25402): onMessage(onPageFinished,about:blank) 07-28 16:24:10.078: D/CordovaActivity(25402): onMessage(exit,null) 07-28 16:24:10.088: D/CordovaWebViewClient(25402): onPageStarted(file:///android_asset/www/cdvtests/index.html) 07-28 16:24:10.088: D/CordovaActivity(25402): onMessage(onPageStarted,file:///android_asset/www/cdvtests/index.html) 07-28 16:24:10.108: D/CordovaActivity(25402): Paused the application! 07-28 16:24:10.108: D/CordovaWebView(25402): Handle the pause 07-28 16:24:10.148: D/CordovaActivity(25402): CordovaActivity.onDestroy() 07-28 16:24:10.148: D/CordovaWebView(25402): >>> loadUrlNow() 07-28 16:24:10.158: D/CordovaWebViewClient(25402): onPageFinished(file:///android_asset/www/cdvtests/index.html) 07-28 16:24:10.158: D/CordovaActivity(25402): onMessage(onPageFinished,file:///android_asset/www/cdvtests/index.html) 07-28 16:24:10.168: D/CordovaWebViewClient(25402): onPageStarted(about:blank) 07-28 16:24:10.168: D/CordovaActivity(25402): onMessage(onPageStarted,about:blank) 07-28 16:24:10.188: D/CordovaWebViewClient(25402): onPageFinished(about:blank) 07-28 16:24:10.188: D/CordovaActivity(25402): onMessage(onPageFinished,about:blank) 07-28 16:24:10.188: D/CordovaActivity(25402): onMessage(exit,null) 07-28 16:24:12.168: D/CordovaActivity(25402): onMessage(spinner,stop) 07-28 16:24:12.188: D/CordovaActivity(25402): onMessage(spinner,stop) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[
https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107130#comment-14107130
]
ASF GitHub Bot commented on CB-7350:
Github user jengee commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/103#discussion_r16609983
--- Diff: createmobilespec/createmobilespec.js ---
@@ -210,122 +267,153 @@ if (argv.plugman) {
shelljs.cp("-f", path.join(mobile_spec_git_dir, 'config.xml'),
path.join(projectDirName, 'config.xml'));
// Config.json file ---> linked to local libraries
-shelljs.pushd(cli_project_dir);
+pushd(cli_project_dir);
var localPlatforms = {
-"amazon-fireos" : top_dir + "cordova-amazon-fireos" ,
-"android" : top_dir + "cordova-android" ,
-"ios" : top_dir + "cordova-ios" ,
-"blackberry10" : top_dir + "cordova-blackberry" ,
-"wp8" : top_dir + "cordova-wp8" + path.sep + "wp8",
-"windows8" : top_dir + "cordova-windows",
-"windows" : path.join(top_dir, "cordova-windows", "windows")
+"amazon-fireos" : [top_dir, "cordova-amazon-fireos"],
+"android" : [top_dir, "cordova-android"],
+"ios" : [top_dir, "cordova-ios"],
+"blackberry10" : [top_dir, "cordova-blackberry"],
+"wp8" : [top_dir, "cordova-wp8", "wp8"],
+"windows8" : [top_dir, "cordova-windows"],
+"windows" : [top_dir, "cordova-windows", "windows"]
};
// Executing platform Add
console.log("Adding platforms...");
-platforms.forEach(function (platform) {
+[].concat(platforms).forEach(function (platform) {
console.log("Adding Platform: " + platform);
-var platformArg = argv.global ? platform :
localPlatforms[platform];
+var platformArg;
+if (argv.global) {
+platformArg = platform;
+} else {
+platformArg = path.join.apply(null, localPlatforms[platform]);
+if (!fs.existsSync(platformArg)) {
+couldNotFind(localPlatforms[platform][1], platform);
+platforms = platforms.filter(function (p) { return p !=
platform; });
+return;
+}
+}
console.log("platformArg: " + cli + " " + platformArg);
shelljs.exec(cli + ' platform add "' + platformArg + '"
--verbose');
});
-shelljs.popd();
+popd();
}
// install plugins for each platform
-
-if (argv.plugman) {
-console.log("Adding plugins using plugman...");
-platforms.forEach(function (platform) {
-var projName = getProjName(platform),
-nodeCommand = /^win/.test(process.platform) ? process.argv[0]
+" " : "";
-shelljs.pushd(projName);
-// plugin path must be relative and not absolute (sigh)
-shelljs.exec(nodeCommand + path.join(top_dir, "cordova-plugman",
"main.js") +
- " install --platform " + platform +
- " --project . --plugin " + path.join("..",
"cordova-mobile-spec", "dependencies-plugin") +
- " --searchpath " + top_dir);
-shelljs.popd();
-});
-} else {
-// don't use local git repos for plugins when using --global
-var searchpath = argv.global ? "" : " --searchpath " + top_dir;
-shelljs.pushd(cli_project_dir);
-console.log("Adding plugins using CLI...");
-console.log("Searchpath:", searchpath);
-shelljs.exec(cli + " plugin add " + path.join(mobile_spec_git_dir,
"dependencies-plugin") +
- searchpath);
-shelljs.popd();
-}
+function installPlugins() {
+if (argv.plugman) {
+console.log("Adding plugins using plugman...");
+if (!fs.existsSync(path.join(top_dir, "cordova-plugman"))) {
+couldNotFind('plugman');
+console.log(" ln -s cordova-lib/cordova-lib
cordova-plugman/node_modules");
+return;
--- End diff --
this needs some `..`'s
> Make createmobilespec friendlier
>
>
> Key: CB-7350
> URL: https://issues.apache.org/jira/browse/CB-7350
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
>Affects Versions: 3.5.0
>Reporter: Josh Soref
>Assignee: Josh Soref
>
> * Don't assume that the people running mobilespec are developers -- In my
> experience, they aren't
> * The READMEs needed a refresh
> * Asking people to install grunt-cli globally is silly, we have npm
> dependencies, we can use them.
> * The pushd/popd sp
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[
https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107053#comment-14107053
]
ASF GitHub Bot commented on CB-7350:
Github user jengee commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/103#discussion_r16607454
--- Diff: createmobilespec/createmobilespec.js ---
@@ -210,122 +267,153 @@ if (argv.plugman) {
shelljs.cp("-f", path.join(mobile_spec_git_dir, 'config.xml'),
path.join(projectDirName, 'config.xml'));
// Config.json file ---> linked to local libraries
-shelljs.pushd(cli_project_dir);
+pushd(cli_project_dir);
var localPlatforms = {
-"amazon-fireos" : top_dir + "cordova-amazon-fireos" ,
-"android" : top_dir + "cordova-android" ,
-"ios" : top_dir + "cordova-ios" ,
-"blackberry10" : top_dir + "cordova-blackberry" ,
-"wp8" : top_dir + "cordova-wp8" + path.sep + "wp8",
-"windows8" : top_dir + "cordova-windows",
-"windows" : path.join(top_dir, "cordova-windows", "windows")
+"amazon-fireos" : [top_dir, "cordova-amazon-fireos"],
+"android" : [top_dir, "cordova-android"],
+"ios" : [top_dir, "cordova-ios"],
+"blackberry10" : [top_dir, "cordova-blackberry"],
+"wp8" : [top_dir, "cordova-wp8", "wp8"],
+"windows8" : [top_dir, "cordova-windows"],
+"windows" : [top_dir, "cordova-windows", "windows"]
};
// Executing platform Add
console.log("Adding platforms...");
-platforms.forEach(function (platform) {
+[].concat(platforms).forEach(function (platform) {
console.log("Adding Platform: " + platform);
-var platformArg = argv.global ? platform :
localPlatforms[platform];
+var platformArg;
+if (argv.global) {
+platformArg = platform;
+} else {
+platformArg = path.join.apply(null, localPlatforms[platform]);
+if (!fs.existsSync(platformArg)) {
+couldNotFind(localPlatforms[platform][1], platform);
+platforms = platforms.filter(function (p) { return p !=
platform; });
+return;
+}
+}
console.log("platformArg: " + cli + " " + platformArg);
shelljs.exec(cli + ' platform add "' + platformArg + '"
--verbose');
});
-shelljs.popd();
+popd();
}
// install plugins for each platform
-
-if (argv.plugman) {
-console.log("Adding plugins using plugman...");
-platforms.forEach(function (platform) {
-var projName = getProjName(platform),
-nodeCommand = /^win/.test(process.platform) ? process.argv[0]
+" " : "";
-shelljs.pushd(projName);
-// plugin path must be relative and not absolute (sigh)
-shelljs.exec(nodeCommand + path.join(top_dir, "cordova-plugman",
"main.js") +
- " install --platform " + platform +
- " --project . --plugin " + path.join("..",
"cordova-mobile-spec", "dependencies-plugin") +
- " --searchpath " + top_dir);
-shelljs.popd();
-});
-} else {
-// don't use local git repos for plugins when using --global
-var searchpath = argv.global ? "" : " --searchpath " + top_dir;
-shelljs.pushd(cli_project_dir);
-console.log("Adding plugins using CLI...");
-console.log("Searchpath:", searchpath);
-shelljs.exec(cli + " plugin add " + path.join(mobile_spec_git_dir,
"dependencies-plugin") +
- searchpath);
-shelljs.popd();
-}
+function installPlugins() {
+if (argv.plugman) {
+console.log("Adding plugins using plugman...");
+if (!fs.existsSync(path.join(top_dir, "cordova-plugman"))) {
+couldNotFind('plugman');
+console.log(" ln -s cordova-lib/cordova-lib
cordova-plugman/node_modules");
+return;
+}
+platforms.forEach(function (platform) {
+var projName = getProjName(platform),
+nodeCommand = /^win/.test(process.platform) ?
process.argv[0] +" " : "";
+pushd(projName);
+// plugin path must be relative and not absolute (sigh)
+shelljs.exec(nodeCommand + path.join(top_dir,
"cordova-plugman", "main.js") +
+ " install --platform " + platform +
+ " --project . --plugin " + path.join("..",
"cordova-mobile-spec", "dependencies-plugin") +
+ " --searchpath " + top_dir);
+p
[jira] [Updated] (CB-7370) http://registry.cordova.io/-/all doesn't show all information of plugins
[ https://issues.apache.org/jira/browse/CB-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Adrian Sosa Herrera updated CB-7370: --- Description: Looking into the JSON rendered in http://registry.cordova.io/-/all, I noted the plugins don't have the "platforms" attribute. Also in the versions attribute, it shows only the latest, not all registered versions. As an example, take org.apache.cordova.file. If look at it in the -/all URL in the registry, you'll find that in the "latest" attribute the version is 1.3.0. Now look at the "versions" and you will see "1.3.0: latest" missing the other versions (they are correctly listed in http://registry.cordova.io/org.apache.cordova.file as well as in plugins.cordova.io). Using this same plugin, in -/all URL, you will notice that the "platforms" attribute is missing, but go into the plugin JSON (http://registry.cordova.io/org.apache.cordova.file) and you will notice the platforms supported for each version. was: Looking into the JSON rendered in http://registry.cordova.io/-/all, I noted the plugins don't have the "platforms" attribute. Also in the versions attribute, it shows only the latest, not all registered versions. As an example, take org.apache.cordova.file. If look at it in the -/all URL in the registry, you'll find that in the "latest" attribute the version is 1.3.0. Now look at the "versions" and you will see "1.3.0: latest" missing the other versions (they are correctly listed in http://registry.cordova.io/org.apache.cordova.file as well as in plugins.cordova.io). Using this same plugin, in -/all URL, you will notice that the "platforms" attribute is missing, but go into the plugin JSON (http://registry.cordova.io/org.apache.cordova.file) and you will notice the platforms supported for each version. > http://registry.cordova.io/-/all doesn't show all information of plugins > > > Key: CB-7370 > URL: https://issues.apache.org/jira/browse/CB-7370 > Project: Apache Cordova > Issue Type: Bug > Components: Registry, Registry Web >Reporter: Victor Adrian Sosa Herrera >Priority: Minor > > Looking into the JSON rendered in http://registry.cordova.io/-/all, I noted > the plugins don't have the "platforms" attribute. Also in the versions > attribute, it shows only the latest, not all registered versions. > As an example, take org.apache.cordova.file. If look at it in the -/all URL > in the registry, you'll find that in the "latest" attribute the version is > 1.3.0. Now look at the "versions" and you will see "1.3.0: latest" missing > the other versions (they are correctly listed in > http://registry.cordova.io/org.apache.cordova.file as well as in > plugins.cordova.io). > Using this same plugin, in -/all URL, you will notice that the "platforms" > attribute is missing, but go into the plugin JSON > (http://registry.cordova.io/org.apache.cordova.file) and you will notice the > platforms supported for each version. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7370) http://registry.cordova.io/-/all doesn't show all information of plugins
Victor Adrian Sosa Herrera created CB-7370: -- Summary: http://registry.cordova.io/-/all doesn't show all information of plugins Key: CB-7370 URL: https://issues.apache.org/jira/browse/CB-7370 Project: Apache Cordova Issue Type: Bug Components: Registry, Registry Web Reporter: Victor Adrian Sosa Herrera Priority: Minor Looking into the JSON rendered in http://registry.cordova.io/-/all, I noted the plugins don't have the "platforms" attribute. Also in the versions attribute, it shows only the latest, not all registered versions. As an example, take org.apache.cordova.file. If look at it in the -/all URL in the registry, you'll find that in the "latest" attribute the version is 1.3.0. Now look at the "versions" and you will see "1.3.0: latest" missing the other versions (they are correctly listed in http://registry.cordova.io/org.apache.cordova.file as well as in plugins.cordova.io). Using this same plugin, in -/all URL, you will notice that the "platforms" attribute is missing, but go into the plugin JSON (http://registry.cordova.io/org.apache.cordova.file) and you will notice the platforms supported for each version. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7369) Ridiculous link loop in documentation. Getting started is a headache
teo created CB-7369: --- Summary: Ridiculous link loop in documentation. Getting started is a headache Key: CB-7369 URL: https://issues.apache.org/jira/browse/CB-7369 Project: Apache Cordova Issue Type: Bug Components: Docs Environment: all Reporter: teo Priority: Critical I approach Cordova as a newcomer and look for a "getting started" kind of guide. So I start at http://cordova.apache.org/ and I notice a link to documentation, which allegedly "includes Getting Started guides": http://cordova.apache.org/docs/en/3.5.0/ Here I look for the words "Getting Started" and find nothing, but there's an promising "Overview" which reads: "START HERE if you are new to Cordova. Includes installation and next steps." (emphasys added) So I follow that link: http://cordova.apache.org/docs/en/3.5.0/guide_overview_index.md.html#Overview And at the bottom it says: """ Installing Cordova The installation of Cordova will differ depending on the workflow above you choose: Cross-platform workflow: see The Command-Line Interface. Platform-centered workflow: see the Platform Guides. """ I want to choose the "platform-centered workflow", so I follow the link to Platform Guides: http://cordova.apache.org/docs/en/3.5.0/guide_platforms_index.md.html#Platform%20Guides which says: """ Platform Guides BEFORE developing for any of the platforms listed below, install cordova's command-line interface (CLI). (For details, see The Command-Line Interface.) """ (emphasys added). So I follow that link: http://cordova.apache.org/docs/en/3.5.0/guide_cli_index.md.html#The%20Command-Line%20Interface And it says: """ PREREQUISITES BEFORE running any command-line tools, you need to install SDKs for each platform you wish to target. (See the Platform Guides for more details.) """ which links back to the platform guides. LOOP DETECTED! There needs to be a clearer step-by-step installation guide (one for each platform or workflow, if needed), without a loop of prerequisites where installing A is required before you install B, but installing B is required before you install A. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7367) Allow update of weinreId without page refresh
[ https://issues.apache.org/jira/browse/CB-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106844#comment-14106844 ] Patrick Mueller commented on CB-7367: - Sorry, brain fart there! Got a few things on my mind :-) Ya, don't have any tests, sorry. Will look at soon, thanks so much! > Allow update of weinreId without page refresh > - > > Key: CB-7367 > URL: https://issues.apache.org/jira/browse/CB-7367 > Project: Apache Cordova > Issue Type: Wish > Components: weinre >Reporter: Stewart >Assignee: Patrick Mueller >Priority: Minor > > As the clientId is specified in the URL's fragment, browsers will not refresh > the page when changing the clientId from Weinre. > Detect changes to the fragment within Weinre to allow updating this on the > fly (no page refresh required). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7368) WP8: cordova build/run --archs="x86" produces x64 binaries.
[
https://issues.apache.org/jira/browse/CB-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-7368:
-
Description:
{{cordova run --archs="x86"}} command for WP8 platform fails with following
error:
{noformat}
Xap packaging completed successfully
ERROR: Directory with build artefacts doesn't exists
Error: d:\Projects\cordova\test\hello\platforms\wp8\cordova\run.bat: Command
failed with exit code 2
at ChildProcess.whenDone
(d:\Projects\cordova\cordova-dev\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Process.ChildProcess._handle.onexit (child_process.js:820:5)
{noformat}
this caused by error in .sln file, which produces x64 binaries instead of x86.
was:
cordova run --archs="x86" command for WP8 platform fails with following error:
{noformat}
Xap packaging completed successfully
ERROR: Directory with build artefacts doesn't exists
Error: d:\Projects\cordova\test\hello\platforms\wp8\cordova\run.bat: Command
failed with exit code 2
at ChildProcess.whenDone
(d:\Projects\cordova\cordova-dev\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Process.ChildProcess._handle.onexit (child_process.js:820:5)
{noformat}
this caused by error in .sln file, which produces x64 binaries instead of x86.
> WP8: cordova build/run --archs="x86" produces x64 binaries.
> ---
>
> Key: CB-7368
> URL: https://issues.apache.org/jira/browse/CB-7368
> Project: Apache Cordova
> Issue Type: Bug
> Components: WP8
>Affects Versions: 3.6.0
>Reporter: Vladimir Kotikov
>Assignee: Jesse MacFadyen
> Fix For: 3.6.0
>
>
> {{cordova run --archs="x86"}} command for WP8 platform fails with following
> error:
> {noformat}
> Xap packaging completed successfully
> ERROR: Directory with build artefacts doesn't exists
> Error: d:\Projects\cordova\test\hello\platforms\wp8\cordova\run.bat: Command
> failed with exit code 2
> at ChildProcess.whenDone
> (d:\Projects\cordova\cordova-dev\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
> at ChildProcess.EventEmitter.emit (events.js:98:17)
> at maybeClose (child_process.js:753:16)
> at Process.ChildProcess._handle.onexit (child_process.js:820:5)
> {noformat}
> this caused by error in .sln file, which produces x64 binaries instead of x86.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7368) WP8: cordova build/run --archs="x86" produces x64 binaries.
[
https://issues.apache.org/jira/browse/CB-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106761#comment-14106761
]
ASF GitHub Bot commented on CB-7368:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-wp8/pull/52
CB-7368 --archs="x86" now produces correct binaries.
Fix for https://issues.apache.org/jira/browse/CB-7368
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-wp8 CB-7368
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
commit 1abe74e0890484192fe11a358382d1e29aad42ce
Author: Vladimir Kotikov
Date: 2014-08-22T12:13:41Z
CB-7368 --archs="x86" now produces correct binaries.
> WP8: cordova build/run --archs="x86" produces x64 binaries.
> ---
>
> Key: CB-7368
> URL: https://issues.apache.org/jira/browse/CB-7368
> Project: Apache Cordova
> Issue Type: Bug
> Components: WP8
>Affects Versions: 3.6.0
>Reporter: Vladimir Kotikov
>Assignee: Jesse MacFadyen
> Fix For: 3.6.0
>
>
> {{cordova run --archs="x86"}} command for WP8 platform fails with following
> error:
> {noformat}
> Xap packaging completed successfully
> ERROR: Directory with build artefacts doesn't exists
> Error: d:\Projects\cordova\test\hello\platforms\wp8\cordova\run.bat: Command
> failed with exit code 2
> at ChildProcess.whenDone
> (d:\Projects\cordova\cordova-dev\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
> at ChildProcess.EventEmitter.emit (events.js:98:17)
> at maybeClose (child_process.js:753:16)
> at Process.ChildProcess._handle.onexit (child_process.js:820:5)
> {noformat}
> this caused by error in .sln file, which produces x64 binaries instead of x86.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7367) Allow update of weinreId without page refresh
[ https://issues.apache.org/jira/browse/CB-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106740#comment-14106740 ] Stewart commented on CB-7367: - Hi Patrick, this is pertaining to a pull request on github (see above). It's just a few lines in the index.js file to support it. I performed a development build and tested the change on that output, but couldn't see any tests to run. Best regards, Stew. > Allow update of weinreId without page refresh > - > > Key: CB-7367 > URL: https://issues.apache.org/jira/browse/CB-7367 > Project: Apache Cordova > Issue Type: Wish > Components: weinre >Reporter: Stewart >Assignee: Patrick Mueller >Priority: Minor > > As the clientId is specified in the URL's fragment, browsers will not refresh > the page when changing the clientId from Weinre. > Detect changes to the fragment within Weinre to allow updating this on the > fly (no page refresh required). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7368) WP8: cordova build/run --archs="x86" produces x64 binaries.
Vladimir Kotikov created CB-7368:
Summary: WP8: cordova build/run --archs="x86" produces x64
binaries.
Key: CB-7368
URL: https://issues.apache.org/jira/browse/CB-7368
Project: Apache Cordova
Issue Type: Bug
Components: WP8
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Fix For: 3.6.0
cordova run --archs="x86" command for WP8 platform fails with following error:
{noformat}
Xap packaging completed successfully
ERROR: Directory with build artefacts doesn't exists
Error: d:\Projects\cordova\test\hello\platforms\wp8\cordova\run.bat: Command
failed with exit code 2
at ChildProcess.whenDone
(d:\Projects\cordova\cordova-dev\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:753:16)
at Process.ChildProcess._handle.onexit (child_process.js:820:5)
{noformat}
this caused by error in .sln file, which produces x64 binaries instead of x86.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7367) Allow update of weinreId without page refresh
[ https://issues.apache.org/jira/browse/CB-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106728#comment-14106728 ] Patrick Mueller commented on CB-7367: - Did you have any interest in working on a patch? Build directions should be included in the docs. No worries, if not. I'll queue it up for sometime next week (hopefully). > Allow update of weinreId without page refresh > - > > Key: CB-7367 > URL: https://issues.apache.org/jira/browse/CB-7367 > Project: Apache Cordova > Issue Type: Wish > Components: weinre >Reporter: Stewart >Assignee: Patrick Mueller >Priority: Minor > > As the clientId is specified in the URL's fragment, browsers will not refresh > the page when changing the clientId from Weinre. > Detect changes to the fragment within Weinre to allow updating this on the > fly (no page refresh required). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-7314) Must re-add platforms after adding plugin to avoid build failure
[
https://issues.apache.org/jira/browse/CB-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vivek Thakur reassigned CB-7314:
Assignee: Vivek Thakur
> Must re-add platforms after adding plugin to avoid build failure
>
>
> Key: CB-7314
> URL: https://issues.apache.org/jira/browse/CB-7314
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Shawn Freyssonnet-Inder
>Assignee: Vivek Thakur
>
> {code}
> cordova create a b c
> cd a
> cordova platform add ios
> cordova emulate ios
> # App works
> cordova plugin add org.apache.cordova.file-transfer
> cordova emulate ios
> # Build fails
> cordova platform remove ios
> cordova platform add ios
> cordova emulate ios
> # App works
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7312) Wrong Destination Type for Cordova Camera
[ https://issues.apache.org/jira/browse/CB-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106616#comment-14106616 ] Charalampos Tampakopoulos commented on CB-7312: --- I passed the uri to the following plugin: https://github.com/jaeger25/Html5Video which expects file_uri's. As I stated in the original bug report. This should be stated in the documentation. > Wrong Destination Type for Cordova Camera > - > > Key: CB-7312 > URL: https://issues.apache.org/jira/browse/CB-7312 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 >Reporter: Charalampos Tampakopoulos >Assignee: Vivek Thakur > > When I am using the following options: > quality: 95, > destinationType : FILE_URI, > sourceType : PHOTOLIBRARY, > allowEdit : false, > mediaType: ALLMEDIA, > targetWidth: 680, > targetHeight: 680, > correctOrientation: true, > saveToPhotoAlbum: false > I keep getting back the native URI from the android phone. > If I select either picture or video instead of all media the result is the > expected file_uri. > If this is the expected behavior I thing this should be stated in the > documentation. > The camera version I am using is the 0.3.0 and I am developing using a nexus > 4 using android version 4.4.4 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7312) Wrong Destination Type for Cordova Camera
[ https://issues.apache.org/jira/browse/CB-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106610#comment-14106610 ] Vivek Thakur commented on CB-7312: -- What is it that you want to achieve by using a common URI if you are able to resolve content out of it? URIs should be treated as opaque. You shouldn't be relying on the URI to be anything, beyond something which can be resolved/loaded. This probably will need to be updated in the documentation. > Wrong Destination Type for Cordova Camera > - > > Key: CB-7312 > URL: https://issues.apache.org/jira/browse/CB-7312 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 >Reporter: Charalampos Tampakopoulos >Assignee: Vivek Thakur > > When I am using the following options: > quality: 95, > destinationType : FILE_URI, > sourceType : PHOTOLIBRARY, > allowEdit : false, > mediaType: ALLMEDIA, > targetWidth: 680, > targetHeight: 680, > correctOrientation: true, > saveToPhotoAlbum: false > I keep getting back the native URI from the android phone. > If I select either picture or video instead of all media the result is the > expected file_uri. > If this is the expected behavior I thing this should be stated in the > documentation. > The camera version I am using is the 0.3.0 and I am developing using a nexus > 4 using android version 4.4.4 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7367) Allow update of weinreId without page refresh
Stewart created CB-7367: --- Summary: Allow update of weinreId without page refresh Key: CB-7367 URL: https://issues.apache.org/jira/browse/CB-7367 Project: Apache Cordova Issue Type: Wish Components: weinre Reporter: Stewart Assignee: Patrick Mueller Priority: Minor As the clientId is specified in the URL's fragment, browsers will not refresh the page when changing the clientId from Weinre. Detect changes to the fragment within Weinre to allow updating this on the fly (no page refresh required). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7367) Allow update of weinreId without page refresh
[ https://issues.apache.org/jira/browse/CB-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106603#comment-14106603 ] ASF GitHub Bot commented on CB-7367: Github user shteou commented on the pull request: https://github.com/apache/cordova-weinre/pull/7#issuecomment-53032403 Issue logged: https://issues.apache.org/jira/browse/CB-7367 Thanks. > Allow update of weinreId without page refresh > - > > Key: CB-7367 > URL: https://issues.apache.org/jira/browse/CB-7367 > Project: Apache Cordova > Issue Type: Wish > Components: weinre >Reporter: Stewart >Assignee: Patrick Mueller >Priority: Minor > > As the clientId is specified in the URL's fragment, browsers will not refresh > the page when changing the clientId from Weinre. > Detect changes to the fragment within Weinre to allow updating this on the > fly (no page refresh required). -- This message was sent by Atlassian JIRA (v6.2#6252)
