[jira] [Commented] (CB-7493) Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms.
[ https://issues.apache.org/jira/browse/CB-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128177#comment-14128177 ] ASF GitHub Bot commented on CB-7493: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/103 CB-7493 Adds test-build command to package.json Fix for https://issues.apache.org/jira/browse/CB-7493 \+ bonus - travis configuration file. Succesful build log: https://travis-ci.org/vladimir-kotikov/cordova-ios You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-7493 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit cfdc9cc56beef91527aab8a2f5e8223b46e5b29b Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-09-09T13:06:15Z CB-7493 Adds test-build command to package.json Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms. --- Key: CB-7493 URL: https://issues.apache.org/jira/browse/CB-7493 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Windows, WP8 Reporter: Vladimir Kotikov Assignee: Jesse MacFadyen Since we have several issues with unicode in paths and app names it will be great to have automated testing of these cases. Best place to keep these tests is platform repo, so these tests can be ran via come CI service (Appveyor for WP8 and Windows, Travis CI for Android and iOS) For WP8 and windows platforms we already have such tests, so we need just to improve them to test new cases. For Android and iOS it will be necessary to implement tests. Implementation will be very similar to windows/wp8 implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7493) Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms.
[ https://issues.apache.org/jira/browse/CB-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-7493: - Description: Since we have several issues with unicode in paths and app names it will be great to have automated testing of these cases. Best place to keep these tests is platform repo, so these tests can be ran via come CI service (Appveyor for WP8 and Windows, Travis CI for Android and iOS) For WP8 and windows platforms we already have such tests, so we need just to improve them to test new cases. For Android and iOS it will be necessary to implement tests. Implementation will be very similar to windows/wp8 implementation. Note that android currently doesn't have support for unicode symbols in app name (due to android tools restrictions). So test for android should contain only 'space' case test. was: Since we have several issues with unicode in paths and app names it will be great to have automated testing of these cases. Best place to keep these tests is platform repo, so these tests can be ran via come CI service (Appveyor for WP8 and Windows, Travis CI for Android and iOS) For WP8 and windows platforms we already have such tests, so we need just to improve them to test new cases. For Android and iOS it will be necessary to implement tests. Implementation will be very similar to windows/wp8 implementation. Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms. --- Key: CB-7493 URL: https://issues.apache.org/jira/browse/CB-7493 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Windows, WP8 Reporter: Vladimir Kotikov Assignee: Jesse MacFadyen Since we have several issues with unicode in paths and app names it will be great to have automated testing of these cases. Best place to keep these tests is platform repo, so these tests can be ran via come CI service (Appveyor for WP8 and Windows, Travis CI for Android and iOS) For WP8 and windows platforms we already have such tests, so we need just to improve them to test new cases. For Android and iOS it will be necessary to implement tests. Implementation will be very similar to windows/wp8 implementation. Note that android currently doesn't have support for unicode symbols in app name (due to android tools restrictions). So test for android should contain only 'space' case test. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7508) deviceready event not firing in Windows Mobile App
Gopu created CB-7508: Summary: deviceready event not firing in Windows Mobile App Key: CB-7508 URL: https://issues.apache.org/jira/browse/CB-7508 Project: Apache Cordova Issue Type: Bug Components: WP8 Affects Versions: 3.5.0 Environment: Microsoft Visual Studio 2013 Professional (Windows 8.1 OS) Reporter: Gopu Assignee: Jesse MacFadyen Priority: Blocker Fix For: 3.5.0 We are creating a new JavaScript-Store Apps-Windows Phone Apps in VS 2013 as described in the tutorial https://github.com/apache/cordova-windows. But when we run the application in the emulator, we get the following error: deviceready event is not fired after 5 seconds. It seems that cordova is not loaded. And hence, we are unable to access any cordova functions. Kindly help us in resolving the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7509) cordova fails to add wp8 platform with --usegit option
Vladimir Kotikov created CB-7509:
Summary: cordova fails to add wp8 platform with --usegit option
Key: CB-7509
URL: https://issues.apache.org/jira/browse/CB-7509
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Priority: Critical
Fix For: 3.7.0
**Repro steps**
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option
cdv platform add wp8 --usegit -d
**Expected:**
Platform successfully added
**Actual:**
command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script due
to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib already
pushed to dist/dev
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CB-7509) cordova fails to add wp8 platform with --usegit option
[
https://issues.apache.org/jira/browse/CB-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-7509:
-
Description:
*Repro steps*
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option: {{cdv platform add wp8 --usegit -d}}
*Expected:* Platform successfully added
*Actual:* command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script due
to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib already
pushed to dist/dev
was:
**Repro steps**
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option
cdv platform add wp8 --usegit -d
**Expected:**
Platform successfully added
**Actual:**
command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script due
to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib already
pushed to dist/dev
cordova fails to add wp8 platform with --usegit option
--
Key: CB-7509
URL: https://issues.apache.org/jira/browse/CB-7509
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Priority: Critical
Fix For: 3.7.0
*Repro steps*
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option: {{cdv platform add wp8 --usegit -d}}
*Expected:* Platform successfully added
*Actual:* command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running
[jira] [Updated] (CB-7509) cordova fails to add wp8 platform with --usegit option
[
https://issues.apache.org/jira/browse/CB-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-7509:
-
Labels: usegit wp8 (was: )
cordova fails to add wp8 platform with --usegit option
--
Key: CB-7509
URL: https://issues.apache.org/jira/browse/CB-7509
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Priority: Critical
Labels: usegit, wp8
Fix For: 3.7.0
*Repro steps*
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option: {{cdv platform add wp8 --usegit -d}}
*Expected:* Platform successfully added
*Actual:* command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script
due to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib
already pushed to dist/dev
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CB-7509) cordova fails to add wp8 platform with --usegit option
[
https://issues.apache.org/jira/browse/CB-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Grebnov updated CB-7509:
---
Assignee: Jesse MacFadyen
cordova fails to add wp8 platform with --usegit option
--
Key: CB-7509
URL: https://issues.apache.org/jira/browse/CB-7509
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Priority: Critical
Labels: usegit, wp8
Fix For: 3.7.0
*Repro steps*
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option: {{cdv platform add wp8 --usegit -d}}
*Expected:* Platform successfully added
*Actual:* command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script
due to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib
already pushed to dist/dev
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7509) cordova fails to add wp8 platform with --usegit option
[
https://issues.apache.org/jira/browse/CB-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128278#comment-14128278
]
ASF subversion and git services commented on CB-7509:
-
Commit 3a71397d82f6d50893edc9ab427a27995174be3d in cordova-lib's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3a71397 ]
CB-7509 Revert back subdirectory for wp8
This is necessary since 'cordova platform add wp8' with --usegit option fails
due to invalid path to create script.
cordova fails to add wp8 platform with --usegit option
--
Key: CB-7509
URL: https://issues.apache.org/jira/browse/CB-7509
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Priority: Critical
Labels: usegit, wp8
Fix For: 3.7.0
*Repro steps*
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option: {{cdv platform add wp8 --usegit -d}}
*Expected:* Platform successfully added
*Actual:* command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script
due to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib
already pushed to dist/dev
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (CB-7510) history.replaceState doesn't work with long URLs
Alexander Bykov created CB-7510: --- Summary: history.replaceState doesn't work with long URLs Key: CB-7510 URL: https://issues.apache.org/jira/browse/CB-7510 Project: Apache Cordova Issue Type: Bug Components: WP8 Affects Versions: 2.9.1 Environment: Windows Phone 8.0 (NOKIA Lumia 920) Reporter: Alexander Bykov Assignee: Jesse MacFadyen While executing the js code below an app stops working if the 'url' argument length is greater that 200: var url = Array(200).join(a); alert(start + url.length); alert(window.history.replaceState(null, null, url)); alert(end); If run the same code in phone's browser it works properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6911) iOS 8 - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128423#comment-14128423 ] ASF GitHub Bot commented on CB-6911: Github user difa1 commented on the pull request: https://github.com/apache/cordova-js/pull/80#issuecomment-55110115 Thanks for the fix :+1: Hope you get acceptance for this before iOS 8 will be released :D iOS 8 - deprecated attempt to access property errors when accessing anything off window.navigator --- Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7509) cordova fails to add wp8 platform with --usegit option
[
https://issues.apache.org/jira/browse/CB-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128447#comment-14128447
]
Marcel Kinard commented on CB-7509:
---
Does this affect only the --usegit option? Meaning, when the tarballs are
hosted on npm will it work OK? The reason I ask is to determine if this is a
blocker for the 3.6.1 release.
cordova fails to add wp8 platform with --usegit option
--
Key: CB-7509
URL: https://issues.apache.org/jira/browse/CB-7509
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Priority: Critical
Labels: usegit, wp8
Fix For: 3.7.0
*Repro steps*
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option: {{cdv platform add wp8 --usegit -d}}
*Expected:* Platform successfully added
*Actual:* command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script
due to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib
already pushed to dist/dev
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (CB-7511) Auto-detect ANDROID_HOME when Android Studio is installed
Andrew Grieve created CB-7511:
-
Summary: Auto-detect ANDROID_HOME when Android Studio is installed
Key: CB-7511
URL: https://issues.apache.org/jira/browse/CB-7511
Project: Apache Cordova
Issue Type: Bug
Components: Android
Reporter: Andrew Grieve
Assignee: Andrew Grieve
Priority: Minor
Yet another way we can cheat and not force users to learn about their PATH
environment variables.
Android studio on windows installs the sdk at (by default):
{quote}
%ProgramFiles%\Android\android-studio\sdk
{quote}
or
{quote}
%LOCALAPPDATA%\Android\android-studio\sdk
{quote}
on Mac:
{quote}
/Applications/Android Studio.app/sdk
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7459) Allow automatic tests to be run for specific plugin(s)
[ https://issues.apache.org/jira/browse/CB-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128482#comment-14128482 ] Jason Chase commented on CB-7459: - Pull request updated and rebased (hopefully correctly). Allow automatic tests to be run for specific plugin(s) -- Key: CB-7459 URL: https://issues.apache.org/jira/browse/CB-7459 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Jason Chase Assignee: Michal Mocny Priority: Minor Currently, the mobile spec test runner will discover automatic tests for all plugins, and then run all discovered tests en masse. When working on a specific issue/plugin, it would be convenient to be able to run tests for a single plugin (or small subset of plugins). The test framework already supports the concept of enabling/disabling tests for plugins, but that is not exposed in the UI for the test runner. Proposed changes: * On the Auto Tests page for plugins, provide a UI to individually select which tests should be run. This UI should allow for multi-select of plugins. * The UI for test selection should indicate the existing enabled status of each plugin * When the page is initially loaded, keep the existing behaviour, where all enabled plugin tests are automatically run * Subsequent runs (i.e. using the existing Again button) will reflect any user changes to the selected tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-5115) On iOS 7, events are dispatched to wrong elements when taping an input field pops the virtual keyboard
[ https://issues.apache.org/jira/browse/CB-5115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128506#comment-14128506 ] Dan Caseley commented on CB-5115: - Info for future people: We hit a similar problem, characterised by the tapped input field ending up under the keyboard after the tap auto-scroll. We found this resolved by iOS 7.1. On iOS 7, events are dispatched to wrong elements when taping an input field pops the virtual keyboard -- Key: CB-5115 URL: https://issues.apache.org/jira/browse/CB-5115 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.1.0 Environment: iOS 7 Reporter: Adrian Vasiliu Attachments: test_Cordova-pure-html.html On iOS 7, when a Cordova 3.1 app contains input fields (input, textarea), the events such as focus and click can be dispatched to the wrong element when taping the field causes the virtual keyboard to show up. Apparently, the event dispatching mechanism is confused by the fact the page is pushed by the keyboard showing up: the events are dispatched to the element at the coordinate after the push, instead of the element at the coordinate of the initial tap gesture. Reproduced with Cordova 3.1 using Xcode 5.0 on Mac OS X 10.8.5, running on iPhone and iPad simulators and real devices. How to reproduce: Run on iOS 7 a Cordova 3.1 app using the code from the attached test file. The test contains several input elements, and a message area which displays a message for each focus and click events received by the input elements; the message includes the id of the element. When tapping an input element while the keyboard is not visible, the message shows that the event is received by wrong element. Also, the wrong input is focused. Differently, when the keyboard is already visible, the events are dispatched to the correct element. Notes: - Reproduced only when *not* using height:device-height in the meta tag, per the recommendation in the Cordova 3.1 doc (http://cordova.apache.org/docs/en/3.1.0/guide_platforms_ios_upgrading.md.html#Upgrading%20iOS). - Setting KeyboardShrinksView to either true or false in config.xml does not matter for this issue. - The same test code works fine in a pure webapp in Safari on iOS 7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CB-7511) Auto-detect ANDROID_HOME when Android Studio is installed
[
https://issues.apache.org/jira/browse/CB-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grieve resolved CB-7511.
---
Resolution: Fixed
Fixed in 3.7.0-dev
Auto-detect ANDROID_HOME when Android Studio is installed
-
Key: CB-7511
URL: https://issues.apache.org/jira/browse/CB-7511
Project: Apache Cordova
Issue Type: Bug
Components: Android
Reporter: Andrew Grieve
Assignee: Andrew Grieve
Priority: Minor
Yet another way we can cheat and not force users to learn about their PATH
environment variables.
Android studio on windows installs the sdk at (by default):
{quote}
%ProgramFiles%\Android\android-studio\sdk
{quote}
or
{quote}
%LOCALAPPDATA%\Android\android-studio\sdk
{quote}
on Mac:
{quote}
/Applications/Android Studio.app/sdk
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7511) Auto-detect ANDROID_HOME when Android Studio is installed
[
https://issues.apache.org/jira/browse/CB-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128513#comment-14128513
]
ASF subversion and git services commented on CB-7511:
-
Commit 8237c41143abf594ff0bcc717a7847a7aa38654c in cordova-android's branch
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=8237c41 ]
CB-7511 Auto-detect Android SDK when Android Studio is installed
Auto-detect ANDROID_HOME when Android Studio is installed
-
Key: CB-7511
URL: https://issues.apache.org/jira/browse/CB-7511
Project: Apache Cordova
Issue Type: Bug
Components: Android
Reporter: Andrew Grieve
Assignee: Andrew Grieve
Priority: Minor
Yet another way we can cheat and not force users to learn about their PATH
environment variables.
Android studio on windows installs the sdk at (by default):
{quote}
%ProgramFiles%\Android\android-studio\sdk
{quote}
or
{quote}
%LOCALAPPDATA%\Android\android-studio\sdk
{quote}
on Mac:
{quote}
/Applications/Android Studio.app/sdk
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7459) Allow automatic tests to be run for specific plugin(s)
[ https://issues.apache.org/jira/browse/CB-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128525#comment-14128525 ] ASF subversion and git services commented on CB-7459: - Commit a7b7441faa491dcf187303975263ca43445d3656 in cordova-plugin-test-framework's branch refs/heads/master from [~mmocny] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=a7b7441 ] Merge branch 'CB-7459' of https://github.com/jpchase/cordova-plugin-test-framework Allow automatic tests to be run for specific plugin(s) -- Key: CB-7459 URL: https://issues.apache.org/jira/browse/CB-7459 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Jason Chase Assignee: Michal Mocny Priority: Minor Currently, the mobile spec test runner will discover automatic tests for all plugins, and then run all discovered tests en masse. When working on a specific issue/plugin, it would be convenient to be able to run tests for a single plugin (or small subset of plugins). The test framework already supports the concept of enabling/disabling tests for plugins, but that is not exposed in the UI for the test runner. Proposed changes: * On the Auto Tests page for plugins, provide a UI to individually select which tests should be run. This UI should allow for multi-select of plugins. * The UI for test selection should indicate the existing enabled status of each plugin * When the page is initially loaded, keep the existing behaviour, where all enabled plugin tests are automatically run * Subsequent runs (i.e. using the existing Again button) will reflect any user changes to the selected tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7459) Allow automatic tests to be run for specific plugin(s)
[ https://issues.apache.org/jira/browse/CB-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128523#comment-14128523 ] ASF subversion and git services commented on CB-7459: - Commit bee5f2582ccfae4928e0b268eba6c0375812ab56 in cordova-plugin-test-framework's branch refs/heads/master from [~chasej] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=bee5f25 ] CB-7459 Allow auto tests to be run for specific plugin(s) * On the Auto Tests page for plugins, generate a list of checkboxes to select each of the detected plugins. These are initially checked based on enabled status of each plugin. * Subsequent runs (i.e. using the existing Again button) will reflect any user changes to the selected tests * User selections are persisted to localStorage, to remember the settings for subsequent runs of the app. The enabling of test modules is encapsulated in the framework, so both user and console/programmatic selection are retained the same way via localStorage * When the page is initially loaded, keep the existing behaviour, where all enabled plugin tests are automatically run * UI enhancements to show/hide list of tests, add Select/Unselect All buttons, and use shorter test names Allow automatic tests to be run for specific plugin(s) -- Key: CB-7459 URL: https://issues.apache.org/jira/browse/CB-7459 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Jason Chase Assignee: Michal Mocny Priority: Minor Currently, the mobile spec test runner will discover automatic tests for all plugins, and then run all discovered tests en masse. When working on a specific issue/plugin, it would be convenient to be able to run tests for a single plugin (or small subset of plugins). The test framework already supports the concept of enabling/disabling tests for plugins, but that is not exposed in the UI for the test runner. Proposed changes: * On the Auto Tests page for plugins, provide a UI to individually select which tests should be run. This UI should allow for multi-select of plugins. * The UI for test selection should indicate the existing enabled status of each plugin * When the page is initially loaded, keep the existing behaviour, where all enabled plugin tests are automatically run * Subsequent runs (i.e. using the existing Again button) will reflect any user changes to the selected tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7459) Allow automatic tests to be run for specific plugin(s)
[ https://issues.apache.org/jira/browse/CB-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128526#comment-14128526 ] Michal Mocny commented on CB-7459: -- Awesome work. May I make one more feature request as a follow on patch? If a test is left disabled due to localStorage remembering, its very hard to notice since by default the checklist is closed. It would be nice if there was an always-showing large text that said Running N/M plugin tests, and it would change to say Running All M plugin tests to make it clear at a glance. Allow automatic tests to be run for specific plugin(s) -- Key: CB-7459 URL: https://issues.apache.org/jira/browse/CB-7459 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Jason Chase Assignee: Michal Mocny Priority: Minor Currently, the mobile spec test runner will discover automatic tests for all plugins, and then run all discovered tests en masse. When working on a specific issue/plugin, it would be convenient to be able to run tests for a single plugin (or small subset of plugins). The test framework already supports the concept of enabling/disabling tests for plugins, but that is not exposed in the UI for the test runner. Proposed changes: * On the Auto Tests page for plugins, provide a UI to individually select which tests should be run. This UI should allow for multi-select of plugins. * The UI for test selection should indicate the existing enabled status of each plugin * When the page is initially loaded, keep the existing behaviour, where all enabled plugin tests are automatically run * Subsequent runs (i.e. using the existing Again button) will reflect any user changes to the selected tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7433) Camera manual tests crashes application on windows platform
[ https://issues.apache.org/jira/browse/CB-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128545#comment-14128545 ] Edna Morales commented on CB-7433: -- I noticed that this change causes the camera manual tests not to load on iOS or Android with an MSApp is not defined error. The inappbrowser manual tests load fine with the change. The inappbrowser changes use window.MSApp while the camera changes only use MSApp. Is there a reason for that? Camera manual tests crashes application on windows platform --- Key: CB-7433 URL: https://issues.apache.org/jira/browse/CB-7433 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin Camera Environment: Windows 8.1 WP8.1 Reporter: Vladimir Kotikov Mobilespec application crashes when trying to start Camera plugin manual tests. When opened in Visual Studio, following error message is shown before failure: !https://raw.githubusercontent.com/MSOpenTech/winstore-jscompat/master/error.PNG?token=3019602__eyJzY29wZSI6IlJhd0Jsb2I6TVNPcGVuVGVjaC93aW5zdG9yZS1qc2NvbXBhdC9tYXN0ZXIvZXJyb3IuUE5HIiwiZXhwaXJlcyI6MTQwNjU3OTYyOX0%3D--101970399d1c4e94bbe251e71e78f8be6af6d7ba! Problem is that manipulating DOM using innerHtml property of elemets is considered unsafe on windows platform and may cause exceptions, when injected HTM is invalid or contains unsafe elements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7509) cordova fails to add wp8 platform with --usegit option
[
https://issues.apache.org/jira/browse/CB-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128548#comment-14128548
]
Vladimir Kotikov commented on CB-7509:
--
Yep, this is only for --usegit. NPM flow doesn't use 'subdirectory' property in
any way.
cordova fails to add wp8 platform with --usegit option
--
Key: CB-7509
URL: https://issues.apache.org/jira/browse/CB-7509
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: 3.6.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Priority: Critical
Labels: usegit, wp8
Fix For: 3.7.0
*Repro steps*
1. Get cordova-cli and cordova-lib from
[dist/dev|https://dist.apache.org/repos/dist/dev/cordova/CB-7383/]
1. Create empty cordova project
2. add WP8 platform with --usegit option: {{cdv platform add wp8 --usegit -d}}
*Expected:* Platform successfully added
*Actual:* command fails with following output:
{noformat}
Requesting
{url:https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;a=snapshot;h=3.6.1;sf=tgz,strictSSL:true}...
Downloading cordova library for wp8...
Downloaded, unzipped and extracted 313341 byte response.
Download complete
Creating wp8 project...
Running command:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create /s /c
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
d:\PROJECTS\Temp\test-usegit\platforms\wp8
io.cordova.hellocordova HelloCordova
Command finished with error code ENOENT:
C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create
/s,/c,C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create,d:\PROJECTS\Temp\test-usegit\platforms\wp8,io.cordova.hellocordova,HelloCordova
Error: C:\Users\vladimir.kotikov\.cordova\lib\wp\cordova\3.6.1\bin\create:
Command failed with exit code ENOENT
at ChildProcess.whenDone
(d:\cordova\cordova-lib\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.EventEmitter.emit (events.js:95:17)
at Process.ChildProcess._handle.onexit (child_process.js:805:12)
{noformat}
Seems to be introduced by commit
[60c42827|https://github.com/apache/cordova-lib/commit/60c42827a0e2c61729a65e904e798bf2e2830e7c].
'subdirectory' field, that specifies directory inside repo, where platform
package contents is placed was removes, so cordova can't find create script
due to invalid path.
Commit already included in 3.6.1 release and corresponding cordova-lib
already pushed to dist/dev
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7433) Camera manual tests crashes application on windows platform
[ https://issues.apache.org/jira/browse/CB-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128558#comment-14128558 ] Vladimir Kotikov commented on CB-7433: -- Oops. Sorry, my bad. Seems i've missed `window`reference here. Camera manual tests crashes application on windows platform --- Key: CB-7433 URL: https://issues.apache.org/jira/browse/CB-7433 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin Camera Environment: Windows 8.1 WP8.1 Reporter: Vladimir Kotikov Mobilespec application crashes when trying to start Camera plugin manual tests. When opened in Visual Studio, following error message is shown before failure: !https://raw.githubusercontent.com/MSOpenTech/winstore-jscompat/master/error.PNG?token=3019602__eyJzY29wZSI6IlJhd0Jsb2I6TVNPcGVuVGVjaC93aW5zdG9yZS1qc2NvbXBhdC9tYXN0ZXIvZXJyb3IuUE5HIiwiZXhwaXJlcyI6MTQwNjU3OTYyOX0%3D--101970399d1c4e94bbe251e71e78f8be6af6d7ba! Problem is that manipulating DOM using innerHtml property of elemets is considered unsafe on windows platform and may cause exceptions, when injected HTM is invalid or contains unsafe elements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7433) Camera manual tests crashes application on windows platform
[ https://issues.apache.org/jira/browse/CB-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128560#comment-14128560 ] ASF subversion and git services commented on CB-7433: - Commit d84b875c449d68937520a1b352e09f6d39044fbf in cordova-plugin-camera's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=d84b875 ] CB-7433 Adds missing window reference to prevent manual tests failure on Android and iOS Camera manual tests crashes application on windows platform --- Key: CB-7433 URL: https://issues.apache.org/jira/browse/CB-7433 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin Camera Environment: Windows 8.1 WP8.1 Reporter: Vladimir Kotikov Mobilespec application crashes when trying to start Camera plugin manual tests. When opened in Visual Studio, following error message is shown before failure: !https://raw.githubusercontent.com/MSOpenTech/winstore-jscompat/master/error.PNG?token=3019602__eyJzY29wZSI6IlJhd0Jsb2I6TVNPcGVuVGVjaC93aW5zdG9yZS1qc2NvbXBhdC9tYXN0ZXIvZXJyb3IuUE5HIiwiZXhwaXJlcyI6MTQwNjU3OTYyOX0%3D--101970399d1c4e94bbe251e71e78f8be6af6d7ba! Problem is that manipulating DOM using innerHtml property of elemets is considered unsafe on windows platform and may cause exceptions, when injected HTM is invalid or contains unsafe elements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7433) Camera manual tests crashes application on windows platform
[ https://issues.apache.org/jira/browse/CB-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128566#comment-14128566 ] Edna Morales commented on CB-7433: -- Thanks Vladimir Camera manual tests crashes application on windows platform --- Key: CB-7433 URL: https://issues.apache.org/jira/browse/CB-7433 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin Camera Environment: Windows 8.1 WP8.1 Reporter: Vladimir Kotikov Mobilespec application crashes when trying to start Camera plugin manual tests. When opened in Visual Studio, following error message is shown before failure: !https://raw.githubusercontent.com/MSOpenTech/winstore-jscompat/master/error.PNG?token=3019602__eyJzY29wZSI6IlJhd0Jsb2I6TVNPcGVuVGVjaC93aW5zdG9yZS1qc2NvbXBhdC9tYXN0ZXIvZXJyb3IuUE5HIiwiZXhwaXJlcyI6MTQwNjU3OTYyOX0%3D--101970399d1c4e94bbe251e71e78f8be6af6d7ba! Problem is that manipulating DOM using innerHtml property of elemets is considered unsafe on windows platform and may cause exceptions, when injected HTM is invalid or contains unsafe elements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7512) Android Gradle build requires API 19 and build tools 19.0.0 exactly
Ian Clelland created CB-7512: Summary: Android Gradle build requires API 19 and build tools 19.0.0 exactly Key: CB-7512 URL: https://issues.apache.org/jira/browse/CB-7512 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Ian Clelland Assignee: Ian Clelland -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7513) Failed to find PDF header: `%PDF' not found
Walter Chacon Solis created CB-7513: --- Summary: Failed to find PDF header: `%PDF' not found Key: CB-7513 URL: https://issues.apache.org/jira/browse/CB-7513 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 3.5.0 Environment: iOS8 beta 5 and Xcode 6 beta 7 Reporter: Walter Chacon Solis Can't open a url of a pdf document. InAppBrowser shows a blank page. Xcode logs: failed to find PDF header: `%PDF' not found. Probably this issue is related to this one: http://stackoverflow.com/questions/25158552/failed-to-find-pdf-header-pdf-not-found -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7513) Failed to find PDF header: `%PDF' not found
[ https://issues.apache.org/jira/browse/CB-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Chacon Solis updated CB-7513: Description: Can't open a url of a pdf document. InAppBrowser shows a blank page. Even more this is causing a memory leak after a while of waiting for the pdf document to load Xcode logs: failed to find PDF header: `%PDF' not found. Probably this issue is related to this one: http://stackoverflow.com/questions/25158552/failed-to-find-pdf-header-pdf-not-found was: Can't open a url of a pdf document. InAppBrowser shows a blank page. Xcode logs: failed to find PDF header: `%PDF' not found. Probably this issue is related to this one: http://stackoverflow.com/questions/25158552/failed-to-find-pdf-header-pdf-not-found Failed to find PDF header: `%PDF' not found --- Key: CB-7513 URL: https://issues.apache.org/jira/browse/CB-7513 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 3.5.0 Environment: iOS8 beta 5 and Xcode 6 beta 7 Reporter: Walter Chacon Solis Labels: inAppBrowser, pdf Can't open a url of a pdf document. InAppBrowser shows a blank page. Even more this is causing a memory leak after a while of waiting for the pdf document to load Xcode logs: failed to find PDF header: `%PDF' not found. Probably this issue is related to this one: http://stackoverflow.com/questions/25158552/failed-to-find-pdf-header-pdf-not-found -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7512) Android Gradle build requires API 19 and build tools 19.0.0 exactly
[ https://issues.apache.org/jira/browse/CB-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128614#comment-14128614 ] ASF subversion and git services commented on CB-7512: - Commit 0e78dc35d8aaec855aca9228bf5dca1b0795cac6 in cordova-android's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=0e78dc3 ] CB-7512: Read android target from project.properties if possible Android Gradle build requires API 19 and build tools 19.0.0 exactly --- Key: CB-7512 URL: https://issues.apache.org/jira/browse/CB-7512 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Ian Clelland Assignee: Ian Clelland -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7459) Allow automatic tests to be run for specific plugin(s)
[ https://issues.apache.org/jira/browse/CB-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128669#comment-14128669 ] ASF GitHub Bot commented on CB-7459: Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/4#issuecomment-55140469 Wow this is good, Thanks Jason. Allow automatic tests to be run for specific plugin(s) -- Key: CB-7459 URL: https://issues.apache.org/jira/browse/CB-7459 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Jason Chase Assignee: Michal Mocny Priority: Minor Currently, the mobile spec test runner will discover automatic tests for all plugins, and then run all discovered tests en masse. When working on a specific issue/plugin, it would be convenient to be able to run tests for a single plugin (or small subset of plugins). The test framework already supports the concept of enabling/disabling tests for plugins, but that is not exposed in the UI for the test runner. Proposed changes: * On the Auto Tests page for plugins, provide a UI to individually select which tests should be run. This UI should allow for multi-select of plugins. * The UI for test selection should indicate the existing enabled status of each plugin * When the page is initially loaded, keep the existing behaviour, where all enabled plugin tests are automatically run * Subsequent runs (i.e. using the existing Again button) will reflect any user changes to the selected tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7513) Failed to find PDF header: `%PDF' not found
[ https://issues.apache.org/jira/browse/CB-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Chacon Solis updated CB-7513: Labels: iOS8 inAppBrowser pdf (was: inAppBrowser pdf) Failed to find PDF header: `%PDF' not found --- Key: CB-7513 URL: https://issues.apache.org/jira/browse/CB-7513 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 3.5.0 Environment: iOS8 beta 5 and Xcode 6 beta 7 Reporter: Walter Chacon Solis Labels: iOS8, inAppBrowser, pdf Can't open a url of a pdf document. InAppBrowser shows a blank page. Even more this is causing a memory leak after a while of waiting for the pdf document to load Xcode logs: failed to find PDF header: `%PDF' not found. Probably this issue is related to this one: http://stackoverflow.com/questions/25158552/failed-to-find-pdf-header-pdf-not-found -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6490) getLocaleName does not return consistent results depending on the platform
[ https://issues.apache.org/jira/browse/CB-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128814#comment-14128814 ] Mike Billau commented on CB-6490: - Android uses a dash. getLocaleName does not return consistent results depending on the platform -- Key: CB-6490 URL: https://issues.apache.org/jira/browse/CB-6490 Project: Apache Cordova Issue Type: Bug Components: Plugin Globalization, WP8 Environment: Windows Phone 8 Reporter: Pascale Dardailler Assignee: Jesse MacFadyen getLocaleName does not return consistent results depending on the platform. The documentation should be changed to state that it should return a BCP 47 representation of Unicode locale identifier (see http://www.unicode.org/reports/tr35/#Unicode_locale_identifier - section 3.3.1 BCP 47 tag conversion) to identify the culture of the user, and disambiguate the region as a place. Implementation should be changed accordingly. WindowsPhone 8 implementation is incorrect. Returning country code is not enough. It should use CultureInfo.CurrentCulture.Name. Android and iOS should use dashes instead of underscores. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6490) getLocaleName does not return consistent results depending on the platform
[ https://issues.apache.org/jira/browse/CB-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128835#comment-14128835 ] Edna Morales commented on CB-6490: -- iOS also uses a dash getLocaleName does not return consistent results depending on the platform -- Key: CB-6490 URL: https://issues.apache.org/jira/browse/CB-6490 Project: Apache Cordova Issue Type: Bug Components: Plugin Globalization, WP8 Environment: Windows Phone 8 Reporter: Pascale Dardailler Assignee: Jesse MacFadyen getLocaleName does not return consistent results depending on the platform. The documentation should be changed to state that it should return a BCP 47 representation of Unicode locale identifier (see http://www.unicode.org/reports/tr35/#Unicode_locale_identifier - section 3.3.1 BCP 47 tag conversion) to identify the culture of the user, and disambiguate the region as a place. Implementation should be changed accordingly. WindowsPhone 8 implementation is incorrect. Returning country code is not enough. It should use CultureInfo.CurrentCulture.Name. Android and iOS should use dashes instead of underscores. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7514) res/xml/config.xml Gets clobbered on prepare with default values.
Kris Erickson created CB-7514: - Summary: res/xml/config.xml Gets clobbered on prepare with default values. Key: CB-7514 URL: https://issues.apache.org/jira/browse/CB-7514 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Environment: windows 7 64bit, android. Reporter: Kris Erickson When running cordova prepare android the res/xml/config.xml gets clobbered with default values (e.g. id becomes io.cordova.helloCordova, it looses a couple of installed plugins, the version gets reset to the default value, etc). See http://stackoverflow.com/a/20383398/3798 for a good summary of what happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CB-6490) getLocaleName does not return consistent results depending on the platform
[ https://issues.apache.org/jira/browse/CB-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Billau resolved CB-6490. - Resolution: Fixed Fix Version/s: 3.6.0 Assignee: Mike Billau (was: Jesse MacFadyen) getLocaleName does not return consistent results depending on the platform -- Key: CB-6490 URL: https://issues.apache.org/jira/browse/CB-6490 Project: Apache Cordova Issue Type: Bug Components: Plugin Globalization, WP8 Environment: Windows Phone 8 Reporter: Pascale Dardailler Assignee: Mike Billau Fix For: 3.6.0 getLocaleName does not return consistent results depending on the platform. The documentation should be changed to state that it should return a BCP 47 representation of Unicode locale identifier (see http://www.unicode.org/reports/tr35/#Unicode_locale_identifier - section 3.3.1 BCP 47 tag conversion) to identify the culture of the user, and disambiguate the region as a place. Implementation should be changed accordingly. WindowsPhone 8 implementation is incorrect. Returning country code is not enough. It should use CultureInfo.CurrentCulture.Name. Android and iOS should use dashes instead of underscores. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-4822) globalization.getLocaleName does not always return the real country setting
[ https://issues.apache.org/jira/browse/CB-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128887#comment-14128887 ] Edna Morales commented on CB-4822: -- I have verified that this issue was fixed on iOS. Having the langauge set to English and the region to US returns en-US. Changing the region to UK returns en-GB. globalization.getLocaleName does not always return the real country setting --- Key: CB-4822 URL: https://issues.apache.org/jira/browse/CB-4822 Project: Apache Cordova Issue Type: Improvement Components: Plugin Globalization Affects Versions: 2.7.0 Reporter: Ingmar Bode Due to the documentation globalization.getLocaleName returns the locale identifier of the browser. Unfortunately on some devices (e.g. iOS) the browsers seem to return some kind of fake locale. For example, when I go in my iPhone's settings and set language: en and region: uk, globalization.getLocaleName returns en_US though I would expect en_UK. Is there any way you guys can make Cordova return the real region set in the phones settings - and not what the phone's browser thinks? Btw: We are using Telerik's Icenium. They are currently working with Cordova 2.7., so maybe this issue has already been improved/fixed in later Cordova versions? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-4822) globalization.getLocaleName does not always return the real country setting
[ https://issues.apache.org/jira/browse/CB-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128886#comment-14128886 ] Mike Billau commented on CB-4822: - Android returns en-GB when I set the language to English (United Kingdom), so this looks right for Android. globalization.getLocaleName does not always return the real country setting --- Key: CB-4822 URL: https://issues.apache.org/jira/browse/CB-4822 Project: Apache Cordova Issue Type: Improvement Components: Plugin Globalization Affects Versions: 2.7.0 Reporter: Ingmar Bode Due to the documentation globalization.getLocaleName returns the locale identifier of the browser. Unfortunately on some devices (e.g. iOS) the browsers seem to return some kind of fake locale. For example, when I go in my iPhone's settings and set language: en and region: uk, globalization.getLocaleName returns en_US though I would expect en_UK. Is there any way you guys can make Cordova return the real region set in the phones settings - and not what the phone's browser thinks? Btw: We are using Telerik's Icenium. They are currently working with Cordova 2.7., so maybe this issue has already been improved/fixed in later Cordova versions? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CB-4822) globalization.getLocaleName does not always return the real country setting
[ https://issues.apache.org/jira/browse/CB-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Billau resolved CB-4822. - Resolution: Fixed globalization.getLocaleName does not always return the real country setting --- Key: CB-4822 URL: https://issues.apache.org/jira/browse/CB-4822 Project: Apache Cordova Issue Type: Improvement Components: Plugin Globalization Affects Versions: 2.7.0 Reporter: Ingmar Bode Due to the documentation globalization.getLocaleName returns the locale identifier of the browser. Unfortunately on some devices (e.g. iOS) the browsers seem to return some kind of fake locale. For example, when I go in my iPhone's settings and set language: en and region: uk, globalization.getLocaleName returns en_US though I would expect en_UK. Is there any way you guys can make Cordova return the real region set in the phones settings - and not what the phone's browser thinks? Btw: We are using Telerik's Icenium. They are currently working with Cordova 2.7., so maybe this issue has already been improved/fixed in later Cordova versions? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7515) Globalization getPreferredLanguage is not calling back
Piotr Zalewa created CB-7515: Summary: Globalization getPreferredLanguage is not calling back Key: CB-7515 URL: https://issues.apache.org/jira/browse/CB-7515 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Piotr Zalewa Assignee: Piotr Zalewa This happens because an ``l10n_read`` event has been fired before calling the function. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[ https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128947#comment-14128947 ] ASF GitHub Bot commented on CB-7515: GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/22 CB-7515 [FFOS Globalization] Fix l10n ready event You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugin-globalization fix_l10n_ready_event Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-globalization/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit 8c2acbc144417832f384b5638b5caf9a041a812c Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-02T15:16:02Z CB-6962 Ported globalization tests to framework Tests will not be pulled into project with inclusion of plugin. Pending changes to tooling to run with --test. commit 8533c975c3fb1897958e7b00178f8b1e4a24ed44 Author: Eric Weiterman ewei...@us.ibm.com Date: 2014-07-02T19:35:40Z Added test to complete CB-7064, added tests that check for W3C compliance in language tags generated from PreferredLanguage and GetLocale methods commit c663d4bad3a808ac67b0385005ef0858febd1f3d Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T18:58:41Z Clean-up: removed duplicate code commit 9d7506e514885bbb58881726cf4482c259a30836 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-08-01T20:34:40Z Renamed test dir, added nested plugin.xml commit f4fe4957fea3d95bcba8be34325d37b628a3798a Author: Bryan Higgins bhigg...@blackberry.com Date: 2014-08-14T20:12:27Z CB-7233 [BlackBerry10] Globalization is now supported commit a7a8bd332aa193ddf4c1f1d47622a6f822556e2b Author: Piotr Zalewa pi...@zalewa.info Date: 2014-09-10T19:10:24Z fix waiting for an event which was already fired Globalization getPreferredLanguage is not calling back -- Key: CB-7515 URL: https://issues.apache.org/jira/browse/CB-7515 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Piotr Zalewa Assignee: Piotr Zalewa This happens because an ``l10n_read`` event has been fired before calling the function. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[ https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128950#comment-14128950 ] ASF GitHub Bot commented on CB-7515: Github user zalun closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/22 Globalization getPreferredLanguage is not calling back -- Key: CB-7515 URL: https://issues.apache.org/jira/browse/CB-7515 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Piotr Zalewa Assignee: Piotr Zalewa This happens because an ``l10n_read`` event has been fired before calling the function. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[ https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128961#comment-14128961 ] Piotr Zalewa commented on CB-7515: -- I have closed the PR as there where about 6 commits difference between apache's repository and github one Globalization getPreferredLanguage is not calling back -- Key: CB-7515 URL: https://issues.apache.org/jira/browse/CB-7515 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Piotr Zalewa Assignee: Piotr Zalewa This happens because an ``l10n_read`` event has been fired before calling the function. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7516) Docs. Fix broken links to API on Platform Support page
Sergey Grebnov created CB-7516: -- Summary: Docs. Fix broken links to API on Platform Support page Key: CB-7516 URL: https://issues.apache.org/jira/browse/CB-7516 Project: Apache Cordova Issue Type: Bug Components: Docs Affects Versions: 3.5.0 Reporter: Sergey Grebnov Assignee: Sergey Grebnov I’m noticing that a bunch of links to docs on http://cordova.apache.org/docs/en/3.5.0/guide_support_index.md.html#Platform%20Support are broken and should get fixed. They’re all the ones on the left side of the table in the Platform API section with the exception of Events and Storage. All the rest have URIs of the form https://github.com/apache/cordova-plugin-device-motion/blob/dev/doc/index.md that produce 404 errors. They just need dev in the path replaced with master as in https://github.com/apache/cordova-plugin-device-motion/blob/master/doc/index.md. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7517) Media plugin returns an error and app becomes unresponsive when playing some mp3 fiiles on iOS
Tom Krones created CB-7517: -- Summary: Media plugin returns an error and app becomes unresponsive when playing some mp3 fiiles on iOS Key: CB-7517 URL: https://issues.apache.org/jira/browse/CB-7517 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.5.0 Reporter: Tom Krones You can read more about the issue here: https://groups.google.com/forum/?hl=en?hl%3Den#!topic/phonegap/Zb7NQsr6wCQ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[
https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129045#comment-14129045
]
ASF GitHub Bot commented on CB-7515:
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17386903
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError');
var l10n_loaded = new Event('l10n_loaded');
var l10n_ready = new Event('l10n_ready');
+var is_l10n_ready = false;
+
document.addEventListener('l10n_loaded', function() {
+ console.log('DEBUG: L10n loaded');
navigator.mozL10n.ready(function() {
+console.log('DEBUG: L10n ready');
+is_l10n_ready = true;
document.dispatchEvent(l10n_ready);
});
});
+function callIfL10nReady(callback) {
+if (is_l10n_ready) {
+return callback();
+}
+document.addEventListener('l10n_ready', callback);
--- End diff --
Please remove the event listener to avoid memory leak.
Globalization getPreferredLanguage is not calling back
--
Key: CB-7515
URL: https://issues.apache.org/jira/browse/CB-7515
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Piotr Zalewa
Assignee: Piotr Zalewa
This happens because an ``l10n_read`` event has been fired before calling the
function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[
https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129046#comment-14129046
]
ASF GitHub Bot commented on CB-7515:
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17386918
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError');
var l10n_loaded = new Event('l10n_loaded');
var l10n_ready = new Event('l10n_ready');
+var is_l10n_ready = false;
+
document.addEventListener('l10n_loaded', function() {
+ console.log('DEBUG: L10n loaded');
--- End diff --
Remove debug logging.
Globalization getPreferredLanguage is not calling back
--
Key: CB-7515
URL: https://issues.apache.org/jira/browse/CB-7515
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Piotr Zalewa
Assignee: Piotr Zalewa
This happens because an ``l10n_read`` event has been fired before calling the
function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[
https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129047#comment-14129047
]
ASF GitHub Bot commented on CB-7515:
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17386923
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError');
var l10n_loaded = new Event('l10n_loaded');
var l10n_ready = new Event('l10n_ready');
+var is_l10n_ready = false;
+
document.addEventListener('l10n_loaded', function() {
+ console.log('DEBUG: L10n loaded');
navigator.mozL10n.ready(function() {
+console.log('DEBUG: L10n ready');
--- End diff --
Remove debug logging.
Globalization getPreferredLanguage is not calling back
--
Key: CB-7515
URL: https://issues.apache.org/jira/browse/CB-7515
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Piotr Zalewa
Assignee: Piotr Zalewa
This happens because an ``l10n_read`` event has been fired before calling the
function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[
https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129183#comment-14129183
]
ASF GitHub Bot commented on CB-7515:
Github user zalun commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17391437
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError');
var l10n_loaded = new Event('l10n_loaded');
var l10n_ready = new Event('l10n_ready');
+var is_l10n_ready = false;
+
document.addEventListener('l10n_loaded', function() {
+ console.log('DEBUG: L10n loaded');
navigator.mozL10n.ready(function() {
+console.log('DEBUG: L10n ready');
--- End diff --
I was thinking it might be useful for someone who is working with
translations... Would help to detect race condition...
Globalization getPreferredLanguage is not calling back
--
Key: CB-7515
URL: https://issues.apache.org/jira/browse/CB-7515
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Piotr Zalewa
Assignee: Piotr Zalewa
This happens because an ``l10n_read`` event has been fired before calling the
function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7515) Globalization getPreferredLanguage is not calling back
[
https://issues.apache.org/jira/browse/CB-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129194#comment-14129194
]
ASF GitHub Bot commented on CB-7515:
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/22#discussion_r17391733
--- Diff: src/firefoxos/GlobalizationProxy.js ---
@@ -24,12 +24,25 @@ var GlobalizationError =
require('./GlobalizationError');
var l10n_loaded = new Event('l10n_loaded');
var l10n_ready = new Event('l10n_ready');
+var is_l10n_ready = false;
+
document.addEventListener('l10n_loaded', function() {
+ console.log('DEBUG: L10n loaded');
navigator.mozL10n.ready(function() {
+console.log('DEBUG: L10n ready');
--- End diff --
Ah OK, I though it was left over code from when you were developing. I'm
fine with keeping it.
Globalization getPreferredLanguage is not calling back
--
Key: CB-7515
URL: https://issues.apache.org/jira/browse/CB-7515
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Piotr Zalewa
Assignee: Piotr Zalewa
This happens because an ``l10n_read`` event has been fired before calling the
function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (CB-7518) Android - Don't run android command from within CLI/Plugman
Andrew Grieve created CB-7518: - Summary: Android - Don't run android command from within CLI/Plugman Key: CB-7518 URL: https://issues.apache.org/jira/browse/CB-7518 Project: Apache Cordova Issue Type: Improvement Components: Plugman Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor The Android SDK auto-detection code (e.g. location ANDROID_HOME, putting things in your PATH), is a part of cordova-android's check_reqs script, which is not called from within CLI. So, we don't want to rely on the presense of the android executable from within CLI. Currently the only time it's called is for `framework` within plugins. With the ANDROID_HOME changes in 3.6.0, running this isn't necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7518) Android - Don't run android command from within CLI/Plugman
[ https://issues.apache.org/jira/browse/CB-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129509#comment-14129509 ] ASF subversion and git services commented on CB-7518: - Commit 1fba040aca7dda41c3aa197bb083241034f036f8 in cordova-lib's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=1fba040 ] CB-7518 Don't run android update lib-project for android 3.6.0 It's no longer required. Android - Don't run android command from within CLI/Plugman - Key: CB-7518 URL: https://issues.apache.org/jira/browse/CB-7518 Project: Apache Cordova Issue Type: Improvement Components: Plugman Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor The Android SDK auto-detection code (e.g. location ANDROID_HOME, putting things in your PATH), is a part of cordova-android's check_reqs script, which is not called from within CLI. So, we don't want to rely on the presense of the android executable from within CLI. Currently the only time it's called is for `framework` within plugins. With the ANDROID_HOME changes in 3.6.0, running this isn't necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
