[jira] [Updated] (CB-5942) targetWidth and targetHeight are not being interpreted consistently across platforms
[ https://issues.apache.org/jira/browse/CB-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-5942: - Environment: iOS, WP8 targetWidth and targetHeight are not being interpreted consistently across platforms Key: CB-5942 URL: https://issues.apache.org/jira/browse/CB-5942 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Affects Versions: 3.0.0, 3.1.0, 3.2.0 Environment: iOS, WP8 Reporter: John M. Wargo A while back I posted a question regarding Camera targetWidth targetHeight properties and how they worked. After some discussion, the conclusion I reached was that the documentation couldn't be correct about how it worked since there was no way to determine the camera's resolution with the current API but the docs said I had to provide both parameters. I said I'd do some testing and I have finally gotten around to completing it. Here's what I discovered: I created an application that allowed me to pass in different values for targetWidth targetHeight when taking a picture. I tested at the following image sizes: 640x480, 800x600, 1024x768 as well as setting only the targetWidth to 1024 or only the targetHeight to 768. Here's the results: Android PortraitLandscape 480x640 640x480 600x800 800x600 768x10241024x768 768x10241024x768 768x10241024x768 iOS PortraitLandscape 360x480 640x480 450x600 800x600 576x768 1024x768 2448x3264 3264x2448 2448x3264 3264x2448 Windows Phone 8 PortraitLandscape 1836x3264 3264x1836 1836x3264 3264x1836 1836x3264 3264x1836 1836x3264 3264x1836 1836x3264 3264x1836 As you can see, Android properly implements the targetWidth targetHeight properties. On iOS, it supports setting both properties, but not instances where only one is specified. Windows Phone 8 ignores the parameters completely. On iOS, when you turn the device on its side, the Camera API applies the target width or height to the wrong axis (Android does this well however). I'm trying to test this on a BlackBerry device, but my development environment is giving me fits right now. I'll work on it in the morning and publish my results when I get them. I would suggest that the android implementation is as expected and that the other platforms need their implementations of targetWidth targetHeight adjusted so it works correctly. The documentation should be updated as well as it's incorrect today specifying that both properties must be provided. If the group doesn't want to support only providing one of the properties, then I would expect that the onError callback is called when only one is provided rather than simply ignoring them as is the case with iOS and Windows Phone. I posted my sample application and a spreadsheet with my results to https://github.com/johnwargo/camera_res_test The concensus on the dev list is the following: The API should never grow the image The API should shrink the image while maintaining aspect ratio, such that both dimensions of the resized image fit within targetWidth and targetHeight. I would propose as well that the API support only one of the parameters or both - the API should understand enough about the image file to maintain aspect ratio, the developer shouldn't have to tell it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-5942) targetWidth and targetHeight are not being interpreted consistently across platforms
[ https://issues.apache.org/jira/browse/CB-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140059#comment-14140059 ] Shazron Abdullah commented on CB-5942: -- I would suggest using the table notation here: https://issues.apache.org/jira/secure/WikiRendererHelpAction.jspa?section=tables for your table so it's easy to refer to in this bug without having to open the Excel file from your repo. Here's the plan (We should break this up into two sub-tasks, one for iOS and one for WP8): 1. We should support both properties 2. The API should never grow the image 3. The API should shrink the image while maintaining aspect ratio, such that both dimensions of the resized image fit within targetWidth and targetHeight. 4. Use the Android output as the expected output targetWidth and targetHeight are not being interpreted consistently across platforms Key: CB-5942 URL: https://issues.apache.org/jira/browse/CB-5942 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Affects Versions: 3.0.0, 3.1.0, 3.2.0 Environment: iOS, WP8 Reporter: John M. Wargo A while back I posted a question regarding Camera targetWidth targetHeight properties and how they worked. After some discussion, the conclusion I reached was that the documentation couldn't be correct about how it worked since there was no way to determine the camera's resolution with the current API but the docs said I had to provide both parameters. I said I'd do some testing and I have finally gotten around to completing it. Here's what I discovered: I created an application that allowed me to pass in different values for targetWidth targetHeight when taking a picture. I tested at the following image sizes: 640x480, 800x600, 1024x768 as well as setting only the targetWidth to 1024 or only the targetHeight to 768. Here's the results: Android PortraitLandscape 480x640 640x480 600x800 800x600 768x10241024x768 768x10241024x768 768x10241024x768 iOS PortraitLandscape 360x480 640x480 450x600 800x600 576x768 1024x768 2448x3264 3264x2448 2448x3264 3264x2448 Windows Phone 8 PortraitLandscape 1836x3264 3264x1836 1836x3264 3264x1836 1836x3264 3264x1836 1836x3264 3264x1836 1836x3264 3264x1836 As you can see, Android properly implements the targetWidth targetHeight properties. On iOS, it supports setting both properties, but not instances where only one is specified. Windows Phone 8 ignores the parameters completely. On iOS, when you turn the device on its side, the Camera API applies the target width or height to the wrong axis (Android does this well however). I'm trying to test this on a BlackBerry device, but my development environment is giving me fits right now. I'll work on it in the morning and publish my results when I get them. I would suggest that the android implementation is as expected and that the other platforms need their implementations of targetWidth targetHeight adjusted so it works correctly. The documentation should be updated as well as it's incorrect today specifying that both properties must be provided. If the group doesn't want to support only providing one of the properties, then I would expect that the onError callback is called when only one is provided rather than simply ignoring them as is the case with iOS and Windows Phone. I posted my sample application and a spreadsheet with my results to https://github.com/johnwargo/camera_res_test The concensus on the dev list is the following: The API should never grow the image The API should shrink the image while maintaining aspect ratio, such that both dimensions of the resized image fit within targetWidth and targetHeight. I would propose as well that the API support only one of the parameters or both - the API should understand enough about the image file to maintain aspect ratio, the developer shouldn't have to tell it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7453) Cordova-media-capture fails to record an mp3 file on WP8.1 device/emulator
[ https://issues.apache.org/jira/browse/CB-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140070#comment-14140070 ] ASF GitHub Bot commented on CB-7453: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56139405 Rebased. @purplecabbage, pls. review. Cordova-media-capture fails to record an mp3 file on WP8.1 device/emulator -- Key: CB-7453 URL: https://issues.apache.org/jira/browse/CB-7453 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Capture Environment: WP8.1 device/emulator Reporter: Vladimir Kotikov Labels: media-capture, mp3, wp8.1 When trying to record audio file using media-capture plugin on WP8.1 device, i gettting error with code 3, which is equal to {{CAPTURE_NO_MEDIA_FILES}}. It seems that WP8.1 by some reasons can't encode audio stream to mp3 format. Possible solution is to add a fallback to another format (m4a looks good) when mp3 recording fails. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7493) Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms.
[ https://issues.apache.org/jira/browse/CB-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140072#comment-14140072 ] ASF GitHub Bot commented on CB-7493: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/43#issuecomment-56139471 Rebased. @purplecabbage, pls. review. Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms. --- Key: CB-7493 URL: https://issues.apache.org/jira/browse/CB-7493 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Windows, WP8 Reporter: Vladimir Kotikov Assignee: Jesse MacFadyen Since we have several issues with unicode in paths and app names it will be great to have automated testing of these cases. Best place to keep these tests is platform repo, so these tests can be ran via come CI service (Appveyor for WP8 and Windows, Travis CI for Android and iOS) For WP8 and windows platforms we already have such tests, so we need just to improve them to test new cases. For Android and iOS it will be necessary to implement tests. Implementation will be very similar to windows/wp8 implementation. Note that android currently doesn't have support for unicode symbols in app name (due to android tools restrictions). So test for android should contain only 'space' case test. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7600) Camera manual test error messages are not very informative.
Vladimir Kotikov created CB-7600: Summary: Camera manual test error messages are not very informative. Key: CB-7600 URL: https://issues.apache.org/jira/browse/CB-7600 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Reporter: Vladimir Kotikov Priority: Minor When some error occurs in camera plugin, manual test always reports Error getting picture: undefined, since it tries to get an code property from error object but Camera plugin always reports errors wit hstring messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7600) Camera manual test error messages are not very informative.
[ https://issues.apache.org/jira/browse/CB-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-7600: - Description: When some error occurs in camera plugin, manual test always reports Error getting picture: undefined, since it tries to get an code property from error object but Camera plugin always reports errors with string messages, so the e.code will always undefined. was: When some error occurs in camera plugin, manual test always reports Error getting picture: undefined, since it tries to get an code property from error object but Camera plugin always reports errors wit hstring messages. Camera manual test error messages are not very informative. --- Key: CB-7600 URL: https://issues.apache.org/jira/browse/CB-7600 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Reporter: Vladimir Kotikov Priority: Minor When some error occurs in camera plugin, manual test always reports Error getting picture: undefined, since it tries to get an code property from error object but Camera plugin always reports errors with string messages, so the e.code will always undefined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7600) Camera manual test error messages are not very informative.
[ https://issues.apache.org/jira/browse/CB-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140251#comment-14140251 ] ASF subversion and git services commented on CB-7600: - Commit 7413c1bcb2916ad0ff77833679ae346563044d74 in cordova-plugin-camera's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=7413c1b ] CB-7600 Adds informative message to error callback in manual test. Camera manual test error messages are not very informative. --- Key: CB-7600 URL: https://issues.apache.org/jira/browse/CB-7600 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Reporter: Vladimir Kotikov Priority: Minor When some error occurs in camera plugin, manual test always reports Error getting picture: undefined, since it tries to get an code property from error object but Camera plugin always reports errors with string messages, so the e.code will always undefined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CB-7600) Camera manual test error messages are not very informative.
[ https://issues.apache.org/jira/browse/CB-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov resolved CB-7600. -- Resolution: Fixed Camera manual test error messages are not very informative. --- Key: CB-7600 URL: https://issues.apache.org/jira/browse/CB-7600 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Reporter: Vladimir Kotikov Priority: Minor When some error occurs in camera plugin, manual test always reports Error getting picture: undefined, since it tries to get an code property from error object but Camera plugin always reports errors with string messages, so the e.code will always undefined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7601) Build fails due to capabilities with m: prefixes are incorrectly sorted
Sergey Grebnov created CB-7601: -- Summary: Build fails due to capabilities with m: prefixes are incorrectly sorted Key: CB-7601 URL: https://issues.apache.org/jira/browse/CB-7601 Project: Apache Cordova Issue Type: Bug Components: Windows Affects Versions: 3.6.0 Reporter: Sergey Grebnov Assignee: Sergey Grebnov Repro steps: {code} cordova create app cd app cordova platform add windows cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova build windows {code} Observe the following error {code} C:\temp\win81\contactsTest\platforms\windows\build\phone\debug\anycpu\AppxM anifest.xml(41,6): error APPX1404: File content does not conform to specified schema. The element 'Capabilities' in namespace 'http://schemas.microsof t.com/appx/2010/manifest' has invalid child element 'Capability' in namespace 'http://schemas.microsoft.com/appx/2014/manifest'. List of possible elem ents expected: 'DeviceCapabilityChoice, DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2010/manifest' as well as 'DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2013/manifest'. [C:\temp\w in81\contactsTest\platforms\windows\CordovaApp.Phone.jsproj] {code} *package.phone.appxmanifest* contains the following section which is invalid since all Capabilities should go before DeviceCapabilities {code} Capabilities Capability Name=internetClientServer / Capability Name=picturesLibrary / DeviceCapability Name=webcam / m3:Capability Name=contacts / /Capabilities {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7601) Build fails due to capabilities with m: prefixes are incorrectly sorted
[ https://issues.apache.org/jira/browse/CB-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140314#comment-14140314 ] Sergey Grebnov commented on CB-7601: Elementtree library which is used to work with XML uses Qualified Name when you access tag name: elem.tag for m3:Capability Name=contacts / returns tag name with manifest prefix ('m3:Capability') so sort function works incorrectly. As per research there is no way to force 'elementtree' to ignore manifest prefixes and return local name instead. So sort function should take care of this. Build fails due to capabilities with m: prefixes are incorrectly sorted --- Key: CB-7601 URL: https://issues.apache.org/jira/browse/CB-7601 Project: Apache Cordova Issue Type: Bug Components: Windows Affects Versions: 3.6.0 Reporter: Sergey Grebnov Assignee: Sergey Grebnov Labels: windows Repro steps: {code} cordova create app cd app cordova platform add windows cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova build windows {code} Observe the following error {code} C:\temp\win81\contactsTest\platforms\windows\build\phone\debug\anycpu\AppxM anifest.xml(41,6): error APPX1404: File content does not conform to specified schema. The element 'Capabilities' in namespace 'http://schemas.microsof t.com/appx/2010/manifest' has invalid child element 'Capability' in namespace 'http://schemas.microsoft.com/appx/2014/manifest'. List of possible elem ents expected: 'DeviceCapabilityChoice, DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2010/manifest' as well as 'DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2013/manifest'. [C:\temp\w in81\contactsTest\platforms\windows\CordovaApp.Phone.jsproj] {code} *package.phone.appxmanifest* contains the following section which is invalid since all Capabilities should go before DeviceCapabilities {code} Capabilities Capability Name=internetClientServer / Capability Name=picturesLibrary / DeviceCapability Name=webcam / m3:Capability Name=contacts / /Capabilities {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7601) Build fails due to capabilities with m: prefixes are incorrectly sorted
[ https://issues.apache.org/jira/browse/CB-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov updated CB-7601: --- Assignee: Jesse MacFadyen (was: Sergey Grebnov) Build fails due to capabilities with m: prefixes are incorrectly sorted --- Key: CB-7601 URL: https://issues.apache.org/jira/browse/CB-7601 Project: Apache Cordova Issue Type: Bug Components: Windows Affects Versions: 3.6.0 Reporter: Sergey Grebnov Assignee: Jesse MacFadyen Labels: windows Repro steps: {code} cordova create app cd app cordova platform add windows cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova build windows {code} Observe the following error {code} C:\temp\win81\contactsTest\platforms\windows\build\phone\debug\anycpu\AppxM anifest.xml(41,6): error APPX1404: File content does not conform to specified schema. The element 'Capabilities' in namespace 'http://schemas.microsof t.com/appx/2010/manifest' has invalid child element 'Capability' in namespace 'http://schemas.microsoft.com/appx/2014/manifest'. List of possible elem ents expected: 'DeviceCapabilityChoice, DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2010/manifest' as well as 'DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2013/manifest'. [C:\temp\w in81\contactsTest\platforms\windows\CordovaApp.Phone.jsproj] {code} *package.phone.appxmanifest* contains the following section which is invalid since all Capabilities should go before DeviceCapabilities {code} Capabilities Capability Name=internetClientServer / Capability Name=picturesLibrary / DeviceCapability Name=webcam / m3:Capability Name=contacts / /Capabilities {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-3360) Set custom InAppBrowser user-agent
[ https://issues.apache.org/jira/browse/CB-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140413#comment-14140413 ] Philipp Brömser commented on CB-3360: - thanks a lot, still works :-) Set custom InAppBrowser user-agent -- Key: CB-3360 URL: https://issues.apache.org/jira/browse/CB-3360 Project: Apache Cordova Issue Type: Improvement Components: Android, BlackBerry, Plugin InAppBrowser, WP8 Affects Versions: 2.7.0 Environment: iOS, Android, WP8, BlackBerry Reporter: Kevin Simpson Assignee: Joe Bowser Priority: Minor Labels: Cordova, InAppBrowser, android Currently you can set a custom user-agent for the main Cordova webview by overriding the init method for the DroidGap class. However, when opening a page in the InAppBrowser, that webview will still contain the default user-agent. There are two solutions that I have thought of to this: 1. Set the user-agent of the InAppBrowser webview to whatever the user-agent in the Cordova webview is set to. (This is what I am currently doing, as it was a one line change, but it requires rebuilding Cordova manually) 2. Have some sort of configuration option to set the user-agent for the InAppBrowser. This would allow a different user-agent from the main webview, but is also a more involved change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140654#comment-14140654 ] Ian Clelland commented on CB-6837: -- The takeaway seems to be that concrete instances of CordovaWebView should keep track of dialogs that they create, and destroy any open ones if they are destroyed -- is that right? The API change would be small -- one method on CordovaWebView (although it might be better to implement it as {{CordovaWebView.onDestroy()}}, which can then do whatever it needs to in order to clean up -- in the future, it might be more than just {{destroyDialogs}}) I can make the corresponding changes on Cordova-Crosswalk-Engine. Hitting Back button while alert being rendered causes leaked window --- Key: CB-6837 URL: https://issues.apache.org/jira/browse/CB-6837 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Reporter: Marcel Kinard Assignee: Martin Gonzalez Attachments: index.html On master and using dialogs plugin. Using a trivial app that has a button to create an alert dialog after 500ms timeout. If the Back button is hit at approximately the same time as the timer expires and the alert is to be shown, the following exception appears in logcat: D/CordovaWebView( 8178): The current URL is: file:///android_asset/www/index.html D/CordovaWebView( 8178): The URL at item 0 is: file:///android_asset/www/index.html D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused 54ms, total 55ms D/CordovaActivity( 8178): Paused the application! D/CordovaWebView( 8178): Handle the pause W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection W/InputMethodManagerService( 513): Starting input on non-focused client com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050 pid=8178) D/CordovaActivity( 8178): CordovaActivity.onDestroy() D/CordovaWebView( 8178): loadUrlNow() E/WindowManager( 8178): E/WindowManager( 8178): android.view.WindowLeaked: Activity com.example.Example has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E. R.I. 0,0-465,256} that was originally added here E/WindowManager( 8178): at android.view.ViewRootImpl.init(ViewRootImpl.java:348) E/WindowManager( 8178): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248) E/WindowManager( 8178): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69) E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286) E/WindowManager( 8178): at android.app.AlertDialog$Builder.show(AlertDialog.java:951) E/WindowManager( 8178): at org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143) E/WindowManager( 8178): at com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606) E/WindowManager( 8178): at com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27) E/WindowManager( 8178): at android.os.Handler.dispatchMessage(Handler.java:102) E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136) E/WindowManager( 8178): at android.app.ActivityThread.main(ActivityThread.java:5017) E/WindowManager( 8178): at java.lang.reflect.Method.invokeNative(Native Method) E/WindowManager( 8178): at java.lang.reflect.Method.invoke(Method.java:515) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) E/WindowManager( 8178): at dalvik.system.NativeStart.main(Native Method) D/CordovaWebViewClient( 8178): onPageFinished(about:blank) D/CordovaActivity( 8178): onMessage(onPageFinished,about:blank) D/CordovaActivity( 8178): onMessage(exit,null) It looks like there is an attempt to show the alert dialog after the activity's onDestroy() method has been called. When resuming the app by clicking on it's icon in the home screen or using the Multitask button, the webview doesn't render completely, I see only a black screen with the usual status bar. The app must be killed, and then it works fine after a restart. It appears that there is a pretty small time window during the timeout in which this can be reproduced, something on the
[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140752#comment-14140752 ] ASF GitHub Bot commented on CB-6837: Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/117#discussion_r17791920 --- Diff: framework/src/org/apache/cordova/CordovaChromeClient.java --- @@ -123,7 +128,8 @@ public boolean onKey(DialogInterface dialog, int keyCode, KeyEvent event) { return true; } }); -dlg.show(); +AlertDialog alert = dlg.show(); --- End diff -- dlg.show(); can be added complete to the next line, avoiding variable creation. Hitting Back button while alert being rendered causes leaked window --- Key: CB-6837 URL: https://issues.apache.org/jira/browse/CB-6837 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Reporter: Marcel Kinard Assignee: Martin Gonzalez Attachments: index.html On master and using dialogs plugin. Using a trivial app that has a button to create an alert dialog after 500ms timeout. If the Back button is hit at approximately the same time as the timer expires and the alert is to be shown, the following exception appears in logcat: D/CordovaWebView( 8178): The current URL is: file:///android_asset/www/index.html D/CordovaWebView( 8178): The URL at item 0 is: file:///android_asset/www/index.html D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused 54ms, total 55ms D/CordovaActivity( 8178): Paused the application! D/CordovaWebView( 8178): Handle the pause W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection W/InputMethodManagerService( 513): Starting input on non-focused client com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050 pid=8178) D/CordovaActivity( 8178): CordovaActivity.onDestroy() D/CordovaWebView( 8178): loadUrlNow() E/WindowManager( 8178): E/WindowManager( 8178): android.view.WindowLeaked: Activity com.example.Example has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E. R.I. 0,0-465,256} that was originally added here E/WindowManager( 8178): at android.view.ViewRootImpl.init(ViewRootImpl.java:348) E/WindowManager( 8178): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248) E/WindowManager( 8178): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69) E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286) E/WindowManager( 8178): at android.app.AlertDialog$Builder.show(AlertDialog.java:951) E/WindowManager( 8178): at org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143) E/WindowManager( 8178): at com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606) E/WindowManager( 8178): at com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27) E/WindowManager( 8178): at android.os.Handler.dispatchMessage(Handler.java:102) E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136) E/WindowManager( 8178): at android.app.ActivityThread.main(ActivityThread.java:5017) E/WindowManager( 8178): at java.lang.reflect.Method.invokeNative(Native Method) E/WindowManager( 8178): at java.lang.reflect.Method.invoke(Method.java:515) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) E/WindowManager( 8178): at dalvik.system.NativeStart.main(Native Method) D/CordovaWebViewClient( 8178): onPageFinished(about:blank) D/CordovaActivity( 8178): onMessage(onPageFinished,about:blank) D/CordovaActivity( 8178): onMessage(exit,null) It looks like there is an attempt to show the alert dialog after the activity's onDestroy() method has been called. When resuming the app by clicking on it's icon in the home screen or using the Multitask button, the webview doesn't render completely, I see only a black screen with the usual status bar. The app must be killed, and then it works fine after a restart. It appears that there is a pretty small time window during the
[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140771#comment-14140771 ] Martin Gonzalez commented on CB-6837: - Hi [~iclelland], I've made some changes, removed: removeDialogs method on CordovaWebView, and CordovaActivity involvement: https://github.com/apache/cordova-android/pull/117/files It is possible to keep the track from the CordovaWebView, using some method at the ChromeClient to send the references back onDialogs creation, and handle the whole dialogs destruction on the WebView. Although, I haven't tried to find a way to keep track of all dialogs created, without touching the CordovaChromeClient class at all, do you have any insights that you want to share? Hitting Back button while alert being rendered causes leaked window --- Key: CB-6837 URL: https://issues.apache.org/jira/browse/CB-6837 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Reporter: Marcel Kinard Assignee: Martin Gonzalez Attachments: index.html On master and using dialogs plugin. Using a trivial app that has a button to create an alert dialog after 500ms timeout. If the Back button is hit at approximately the same time as the timer expires and the alert is to be shown, the following exception appears in logcat: D/CordovaWebView( 8178): The current URL is: file:///android_asset/www/index.html D/CordovaWebView( 8178): The URL at item 0 is: file:///android_asset/www/index.html D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused 54ms, total 55ms D/CordovaActivity( 8178): Paused the application! D/CordovaWebView( 8178): Handle the pause W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection W/InputMethodManagerService( 513): Starting input on non-focused client com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050 pid=8178) D/CordovaActivity( 8178): CordovaActivity.onDestroy() D/CordovaWebView( 8178): loadUrlNow() E/WindowManager( 8178): E/WindowManager( 8178): android.view.WindowLeaked: Activity com.example.Example has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E. R.I. 0,0-465,256} that was originally added here E/WindowManager( 8178): at android.view.ViewRootImpl.init(ViewRootImpl.java:348) E/WindowManager( 8178): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248) E/WindowManager( 8178): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69) E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286) E/WindowManager( 8178): at android.app.AlertDialog$Builder.show(AlertDialog.java:951) E/WindowManager( 8178): at org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143) E/WindowManager( 8178): at com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606) E/WindowManager( 8178): at com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27) E/WindowManager( 8178): at android.os.Handler.dispatchMessage(Handler.java:102) E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136) E/WindowManager( 8178): at android.app.ActivityThread.main(ActivityThread.java:5017) E/WindowManager( 8178): at java.lang.reflect.Method.invokeNative(Native Method) E/WindowManager( 8178): at java.lang.reflect.Method.invoke(Method.java:515) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) E/WindowManager( 8178): at dalvik.system.NativeStart.main(Native Method) D/CordovaWebViewClient( 8178): onPageFinished(about:blank) D/CordovaActivity( 8178): onMessage(onPageFinished,about:blank) D/CordovaActivity( 8178): onMessage(exit,null) It looks like there is an attempt to show the alert dialog after the activity's onDestroy() method has been called. When resuming the app by clicking on it's icon in the home screen or using the Multitask button, the webview doesn't render completely, I see only a black screen with the usual status bar. The app must be killed, and then it works fine after a restart. It appears that there is a pretty small time window during the
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140906#comment-14140906 ] Marcel Kinard commented on CB-6911: --- [~shazron], important enough for this to be a candidate for cordova-ios@3.6.4? [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140943#comment-14140943 ] Joe Bowser commented on CB-6837: Do you have to use the CordovaChromeClient for this? This class will most likely not exist in Cordova 4.0, and will only exist on certain implementations. Hitting Back button while alert being rendered causes leaked window --- Key: CB-6837 URL: https://issues.apache.org/jira/browse/CB-6837 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Reporter: Marcel Kinard Assignee: Martin Gonzalez Attachments: index.html On master and using dialogs plugin. Using a trivial app that has a button to create an alert dialog after 500ms timeout. If the Back button is hit at approximately the same time as the timer expires and the alert is to be shown, the following exception appears in logcat: D/CordovaWebView( 8178): The current URL is: file:///android_asset/www/index.html D/CordovaWebView( 8178): The URL at item 0 is: file:///android_asset/www/index.html D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused 54ms, total 55ms D/CordovaActivity( 8178): Paused the application! D/CordovaWebView( 8178): Handle the pause W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection W/InputMethodManagerService( 513): Starting input on non-focused client com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050 pid=8178) D/CordovaActivity( 8178): CordovaActivity.onDestroy() D/CordovaWebView( 8178): loadUrlNow() E/WindowManager( 8178): E/WindowManager( 8178): android.view.WindowLeaked: Activity com.example.Example has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E. R.I. 0,0-465,256} that was originally added here E/WindowManager( 8178): at android.view.ViewRootImpl.init(ViewRootImpl.java:348) E/WindowManager( 8178): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248) E/WindowManager( 8178): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69) E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286) E/WindowManager( 8178): at android.app.AlertDialog$Builder.show(AlertDialog.java:951) E/WindowManager( 8178): at org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143) E/WindowManager( 8178): at com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606) E/WindowManager( 8178): at com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27) E/WindowManager( 8178): at android.os.Handler.dispatchMessage(Handler.java:102) E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136) E/WindowManager( 8178): at android.app.ActivityThread.main(ActivityThread.java:5017) E/WindowManager( 8178): at java.lang.reflect.Method.invokeNative(Native Method) E/WindowManager( 8178): at java.lang.reflect.Method.invoke(Method.java:515) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) E/WindowManager( 8178): at dalvik.system.NativeStart.main(Native Method) D/CordovaWebViewClient( 8178): onPageFinished(about:blank) D/CordovaActivity( 8178): onMessage(onPageFinished,about:blank) D/CordovaActivity( 8178): onMessage(exit,null) It looks like there is an attempt to show the alert dialog after the activity's onDestroy() method has been called. When resuming the app by clicking on it's icon in the home screen or using the Multitask button, the webview doesn't render completely, I see only a black screen with the usual status bar. The app must be killed, and then it works fine after a restart. It appears that there is a pretty small time window during the timeout in which this can be reproduced, something on the order of 200ms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7602) isCopyOnItself check fails when moving directory
Tom Good created CB-7602: Summary: isCopyOnItself check fails when moving directory Key: CB-7602 URL: https://issues.apache.org/jira/browse/CB-7602 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin File Affects Versions: 3.5.0 Reporter: Tom Good Priority: Minor When using moveTo to move a directory the isCopyOnItself check fails if the directory name starts the same. Example: Source: /storage/emulated/0/GalileoMobile Destination: /storage/emulated/0/GalileoMobileBackup/GalileoMobile The issue is with the indexof check looking for any slash. Existing Line 305 of LocalFileSystem.java: if (dest.startsWith(src) dest.indexOf(File.separator, src.length() - 1) != -1) { Something like this should work: if (dest.equals(src) || dest.startsWith(src + File.separator) ) { This would also occur with copies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7602) isCopyOnItself check fails when moving directory
[ https://issues.apache.org/jira/browse/CB-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Good updated CB-7602: - Description: When using moveTo to move a directory the isCopyOnItself check fails if the directory name starts the same but is different. Example: Source: /storage/emulated/0/GalileoMobile Destination: /storage/emulated/0/GalileoMobileBackup/GalileoMobile The issue is with the indexof check looking for any slash following the partial match. Existing Line 305 of LocalFileSystem.java: if (dest.startsWith(src) dest.indexOf(File.separator, src.length() - 1) != -1) { Something like this should work: if (dest.equals(src) || dest.startsWith(src + File.separator) ) { This would also occur with copies. was: When using moveTo to move a directory the isCopyOnItself check fails if the directory name starts the same but is different. Example: Source: /storage/emulated/0/GalileoMobile Destination: /storage/emulated/0/GalileoMobileBackup/GalileoMobile The issue is with the indexof check looking for any slash. Existing Line 305 of LocalFileSystem.java: if (dest.startsWith(src) dest.indexOf(File.separator, src.length() - 1) != -1) { Something like this should work: if (dest.equals(src) || dest.startsWith(src + File.separator) ) { This would also occur with copies. isCopyOnItself check fails when moving directory Key: CB-7602 URL: https://issues.apache.org/jira/browse/CB-7602 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin File Affects Versions: 3.5.0 Reporter: Tom Good Priority: Minor Labels: copyTo, moveTo When using moveTo to move a directory the isCopyOnItself check fails if the directory name starts the same but is different. Example: Source: /storage/emulated/0/GalileoMobile Destination: /storage/emulated/0/GalileoMobileBackup/GalileoMobile The issue is with the indexof check looking for any slash following the partial match. Existing Line 305 of LocalFileSystem.java: if (dest.startsWith(src) dest.indexOf(File.separator, src.length() - 1) != -1) { Something like this should work: if (dest.equals(src) || dest.startsWith(src + File.separator) ) { This would also occur with copies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7602) isCopyOnItself check returns invalid result when moving directory
[ https://issues.apache.org/jira/browse/CB-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Good updated CB-7602: - Summary: isCopyOnItself check returns invalid result when moving directory (was: isCopyOnItself check fails when moving directory) isCopyOnItself check returns invalid result when moving directory - Key: CB-7602 URL: https://issues.apache.org/jira/browse/CB-7602 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin File Affects Versions: 3.5.0 Reporter: Tom Good Priority: Minor Labels: copyTo, moveTo When using moveTo to move a directory the isCopyOnItself check fails if the directory name starts the same but is different. Example: Source: /storage/emulated/0/GalileoMobile Destination: /storage/emulated/0/GalileoMobileBackup/GalileoMobile The issue is with the indexof check looking for any slash following the partial match. Existing Line 305 of LocalFileSystem.java: if (dest.startsWith(src) dest.indexOf(File.separator, src.length() - 1) != -1) { Something like this should work: if (dest.equals(src) || dest.startsWith(src + File.separator) ) { This would also occur with copies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140996#comment-14140996 ] Shazron Abdullah commented on CB-6911: -- I don't want to stop the vote process and really just want that release out the way. I am of the opinion that this error is harmless -- it doesn't affect execution, even though it shows as an error, it's actually a warning. Others here differ I think. [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7572) Serve should respond with 304 when resources are not modified
[ https://issues.apache.org/jira/browse/CB-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140999#comment-14140999 ] ASF GitHub Bot commented on CB-7572: GitHub user bryanhiggins opened a pull request: https://github.com/apache/cordova-lib/pull/88 CB-7572 Serve - respond with 304 when resource not modified This will prevent a lot of unnecessary network traffic, especially in situations such as a list control which has the same icon on each row. I've tested it on OSX with Chrome, but plan on testing Windows and with mobile devices before merging. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry-webworks/cordova-lib 304 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit 88855bc066d700ca77aaedf8ffb934d3b4b68a5b Author: Bryan Higgins bhigg...@blackberry.com Date: 2014-09-19T18:02:12Z CB-7572 Serve - respond with 304 when resource not modified Serve should respond with 304 when resources are not modified - Key: CB-7572 URL: https://issues.apache.org/jira/browse/CB-7572 Project: Apache Cordova Issue Type: Improvement Components: CLI Affects Versions: 3.6.0 Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor It would be nice if serve set the Last-Modified header and responded with 304 based on the If-Modified-Since request header. This will prevent a lot of unnecessary network traffic, especially in situations such as a list control which has the same icon on each row. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (CB-7595) network.connection.type bug on Android L
[ https://issues.apache.org/jira/browse/CB-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser reassigned CB-7595: -- Assignee: Joe Bowser network.connection.type bug on Android L Key: CB-7595 URL: https://issues.apache.org/jira/browse/CB-7595 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin Network Information Affects Versions: 3.5.0 Environment: Android, Nexus 5, Reporter: Nathaniel Foster Assignee: Joe Bowser Labels: android, network.connection I am testing out my Cordova 3.5 app on the developer version of Android L. Navigator.connection.type returns unknown when I am connected to my mobile network (TMobile). When I am connected to wifi it returns wifi. It works fine when I test on previous versions of Android. Not sure if this is a Cordova issue or Android issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141030#comment-14141030 ] Marcel Kinard commented on CB-6911: --- Sorry if I miscommunicated. My suggestion is to let 3.6.3 get out the door and go live, and the question is if a follow-on cordova-ios@3.6.4 (by itself, with no other platforms) is warranted. It would take a tools release to go with it, which I also suggest be a follow-on and not an interruption. Not sure if that changes your response. [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141031#comment-14141031 ] Shazron Abdullah commented on CB-6617: -- Try it in a new project to rule out other problems. I tested it just like I mentioned, load the file by file URL in iAB. inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window
[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141032#comment-14141032 ] Ian Clelland commented on CB-6837: -- CordovaChromeClient seems like the right place to put this, on the master/3.x branch. That's the class that creates the dialogs; it should be the one to keep track of them, and eventually destroy them. It's not appropriate for 4.0.x, but this is exactly the sort of code that needs to be modified for 4.0.x anyway. (WebChromeClient (and CordovaChromeClient) is an implementation detail that is specific to the stock Android WebView. Crosswalk uses {{org.xwalk.core.internal.XWalkUIClient}}, and even that's subject to change. I have no idea what GeckoView does, but I suspect it's radically different again. In fact, CordovaChromeClient is already gone from the 4.0.x; replaced by the hopefully-obviously-android-specific AndroidChromeClient class.) The right thing to do is to have CordovaActivity tell its CordovaWebView, whatever class that happens to be, that it's about to be destroyed, and the various CordovaWebView subclasses will just know how to clean up. That looks like what this patch is now doing. Hitting Back button while alert being rendered causes leaked window --- Key: CB-6837 URL: https://issues.apache.org/jira/browse/CB-6837 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Reporter: Marcel Kinard Assignee: Martin Gonzalez Attachments: index.html On master and using dialogs plugin. Using a trivial app that has a button to create an alert dialog after 500ms timeout. If the Back button is hit at approximately the same time as the timer expires and the alert is to be shown, the following exception appears in logcat: D/CordovaWebView( 8178): The current URL is: file:///android_asset/www/index.html D/CordovaWebView( 8178): The URL at item 0 is: file:///android_asset/www/index.html D/dalvikvm( 513): GC_FOR_ALLOC freed 306K, 13% free 14164K/16240K, paused 54ms, total 55ms D/CordovaActivity( 8178): Paused the application! D/CordovaWebView( 8178): Handle the pause W/IInputConnectionWrapper( 8178): showStatusIcon on inactive InputConnection W/InputMethodManagerService( 513): Starting input on non-focused client com.android.internal.view.IInputMethodClient$Stub$Proxy@42396598 (uid=10050 pid=8178) D/CordovaActivity( 8178): CordovaActivity.onDestroy() D/CordovaWebView( 8178): loadUrlNow() E/WindowManager( 8178): E/WindowManager( 8178): android.view.WindowLeaked: Activity com.example.Example has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{41f0d8b8 V.E. R.I. 0,0-465,256} that was originally added here E/WindowManager( 8178): at android.view.ViewRootImpl.init(ViewRootImpl.java:348) E/WindowManager( 8178): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248) E/WindowManager( 8178): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69) E/WindowManager( 8178): at android.app.Dialog.show(Dialog.java:286) E/WindowManager( 8178): at android.app.AlertDialog$Builder.show(AlertDialog.java:951) E/WindowManager( 8178): at org.apache.cordova.CordovaChromeClient.onJsAlert(CordovaChromeClient.java:143) E/WindowManager( 8178): at com.android.webview.chromium.WebViewContentsClientAdapter.handleJsAlert(WebViewContentsClientAdapter.java:606) E/WindowManager( 8178): at com.android.org.chromium.android_webview.AwContentsClientBridge.handleJsAlert(AwContentsClientBridge.java:73) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) E/WindowManager( 8178): at com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:27) E/WindowManager( 8178): at android.os.Handler.dispatchMessage(Handler.java:102) E/WindowManager( 8178): at android.os.Looper.loop(Looper.java:136) E/WindowManager( 8178): at android.app.ActivityThread.main(ActivityThread.java:5017) E/WindowManager( 8178): at java.lang.reflect.Method.invokeNative(Native Method) E/WindowManager( 8178): at java.lang.reflect.Method.invoke(Method.java:515) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) E/WindowManager( 8178): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) E/WindowManager( 8178): at dalvik.system.NativeStart.main(Native Method) D/CordovaWebViewClient( 8178): onPageFinished(about:blank) D/CordovaActivity( 8178): onMessage(onPageFinished,about:blank) D/CordovaActivity( 8178): onMessage(exit,null)
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141043#comment-14141043 ] Shazron Abdullah commented on CB-6911: -- Try patching: ~/.cordova/lib/npm_cache/cordova-ios/3.6.0/package/CordovaLib/cordova.js [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141052#comment-14141052 ] Shazron Abdullah commented on CB-6911: -- Marcel -- then thats fine (with just this one change to cordova.js). [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141060#comment-14141060 ] Ralph S Theart commented on CB-6617: ok thats fair, let me create a brand new project and I will keep you posted. Thanks Shazron. I'll be back hopefully by today. inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141081#comment-14141081 ] Marcel Kinard commented on CB-6911: --- Ah, I forgot it is a js change instead of a native change. That makes it more complicated. But not tremendously more so. [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141084#comment-14141084 ] Shazron Abdullah commented on CB-6911: -- That's part of the reason why I wanted it to be in 3.7.0, because this change affects all platforms (navigator object clobbering), and we may need some more room for testing. [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6911) [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator
[ https://issues.apache.org/jira/browse/CB-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141110#comment-14141110 ] Fabian Diehl commented on CB-6911: -- Guys, let Shazron time to test on all platforms, it's a js change not just ios... If you want to get the fix simply do the following: 1. Clone the cordova-js (Version 3.7) 2. Grunt the git, this will create all the native js files. 3. Replace the cordova.js in your platform_www folder This is it, you have the fix and shazron has time to test :D if you need more detailed instruction I would gladly help you or send you the js for the platform you need. Hope this discussion will be closed nown :D Kind regards Fabian Kind regards [CordovaJS][iOS 8] - deprecated attempt to access property errors when accessing anything off window.navigator Key: CB-6911 URL: https://issues.apache.org/jira/browse/CB-6911 Project: Apache Cordova Issue Type: Sub-task Components: CordovaJS Environment: iOS 8 beta 5 (device) Reporter: Jeff Schilling Assignee: Shazron Abdullah Fix For: 3.7.0 Attachments: Screen Shot 2014-09-01 at 9.03.30 pm.png, Screen Shot 2014-09-04 at 9.30.58 pm.png references to window.navigator.* (platform, geolocation) etc fail with Deprecated attempt to access property 'geolocation' on a non-Navigator object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CB-7539) [WKWebView][iOS 8] Use local webserver option to load local HTML file from www
[ https://issues.apache.org/jira/browse/CB-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141153#comment-14141153 ] Shazron Abdullah edited comment on CB-7539 at 9/19/14 7:41 PM: --- Thanks Liming Xie, I like the idea. Here's what I'm thinking: To use WKWebView as the default web engine, we need a local http server running (at least until Apple fixes this bug). This will *NOT* be embedded as part of Cordova, but is a plugin with onload = true in the feature tag. This accomplishes two things: 1. Maintenance of the plugin is out of Cordova committer's hands, we don't have to be experts 2. Ability to swap (if need be) another http server. Not sure if this is that important However Cordova still needs to discover the http server during startup. This can be achieved through Preferences, and a new protocol these http servers will need to implement (simple stuff). I'm thinking: {code} preference name=CordovaHttpServer value=CorHttpd / !-- the http server plugin feature name -- {code} CorHttpd will implement, say, CDVHttpServerProtocol My proposal: {code} - (void) startServer:(NSURL*)root; // we want a randomized port - (void) stopServer; - (NSURL*) serverUrl; // return the server url - (void) setSessionKey:(NSString*)sessionKey; // not sure how this will work yet at all. {code} If preference UseWKWebView is true, we look for the CordovaHttpServer preference, now we know which plugin is the loaded http server. We check that it conforms to CDVHttpServerProtocol, then call startServer, passing in the www root (we need to pass in the exact html file to load), generate a UUID for the sessionKey, set the sessionKey, grab the serverUrl, and pass it to WKWebView. If the CordovaHttpServer plugin is missing, we error out and prompt the user to install one, with a recommendation (in this case CorHttpd). was (Author: shazron): Thanks Liming Xie, I like the idea. Here's what I'm thinking: To use WKWebView as the default web engine, we need a local http server running (at least until Apple fixes this bug). This will *NOT* be embedded as part of Cordova, but is a plugin with onload = true in the feature tag. This accomplishes two things: 1. Maintenance of the plugin is out of Cordova committer's hands, we don't have to be experts 2. Ability to swap (if need be) another http server. Not sure if this is that important However Cordova still needs to discover the http server during startup. This can be achieved through Preferences, and a new protocol these http servers will need to implement (simple stuff). I'm thinking: {code} preference name=CordovaHttpServer value=CorHttpd / !-- the http server plugin feature name -- {code} CorHttpd will implement, say, CDVHttpServerProtocol My proposal: {code} - (void) startServer:(NSURL*)root; // we want a randomized port, return the serverUrl - (void) stopServer; - (NSURL*) serverUrl; // return the server url - (void) setSessionKey:(NSString*)sessionKey; // not sure how this will work yet at all. {code} If preference UseWKWebView is true, we look for the CordovaHttpServer preference, now we know which plugin is the loaded http server. We check that it conforms to CDVHttpServerProtocol, then call startServer, passing in the www root (we need to pass in the exact html file to load), generate a UUID for the sessionKey, set the sessionKey, grab the serverUrl, and pass it to WKWebView. If the CordovaHttpServer plugin is missing, we error out and prompt the user to install one, with a recommendation (in this case CorHttpd). [WKWebView][iOS 8] Use local webserver option to load local HTML file from www -- Key: CB-7539 URL: https://issues.apache.org/jira/browse/CB-7539 Project: Apache Cordova Issue Type: Sub-task Components: iOS Reporter: Shazron Abdullah Priority: Blocker This workaround is because of this bug: http://www.openradar.me/radar?id=5839348817723392 (filed with Apple of course also) I'm still hoping that Apple fixes this in iOS 8.1, but we should have this as a contingency plan. Create this as an included plugin, so it can be extracted later if need be. We need to secure access to the local webserver, probably through a session token in the header, since background apps can have access to the webserver. The session token is passed down to the initially loaded local page specified from the content tag in config.xml, and should be used in the cordova.exec call. We would also need to implement local proxy support , see CB-7348 This all sounds more complex than it needs to be than just loading a file url -- wishing Apple would just fix this in iOS 8.1 instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7539) [WKWebView][iOS 8] Use local webserver option to load local HTML file from www
[ https://issues.apache.org/jira/browse/CB-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141153#comment-14141153 ] Shazron Abdullah commented on CB-7539: -- Thanks Liming Xie, I like the idea. Here's what I'm thinking: To use WKWebView as the default web engine, we need a local http server running (at least until Apple fixes this bug). This will *NOT* be embedded as part of Cordova, but is a plugin with onload = true in the feature tag. This accomplishes two things: 1. Maintenance of the plugin is out of Cordova committer's hands, we don't have to be experts 2. Ability to swap (if need be) another http server. Not sure if this is that important However Cordova still needs to discover the http server during startup. This can be achieved through Preferences, and a new protocol these http servers will need to implement (simple stuff). I'm thinking: {code} preference name=CordovaHttpServer value=CorHttpd / !-- the http server plugin feature name -- {code} CorHttpd will implement, say, CDVHttpServerProtocol My proposal: {code} - (void) startServer:(NSURL*)root; // we want a randomized port, return the serverUrl - (void) stopServer; - (NSURL*) serverUrl; // return the server url - (void) setSessionKey:(NSString*)sessionKey; // not sure how this will work yet at all. {code} If preference UseWKWebView is true, we look for the CordovaHttpServer preference, now we know which plugin is the loaded http server. We check that it conforms to CDVHttpServerProtocol, then call startServer, passing in the www root (we need to pass in the exact html file to load), generate a UUID for the sessionKey, set the sessionKey, grab the serverUrl, and pass it to WKWebView. If the CordovaHttpServer plugin is missing, we error out and prompt the user to install one, with a recommendation (in this case CorHttpd). [WKWebView][iOS 8] Use local webserver option to load local HTML file from www -- Key: CB-7539 URL: https://issues.apache.org/jira/browse/CB-7539 Project: Apache Cordova Issue Type: Sub-task Components: iOS Reporter: Shazron Abdullah Priority: Blocker This workaround is because of this bug: http://www.openradar.me/radar?id=5839348817723392 (filed with Apple of course also) I'm still hoping that Apple fixes this in iOS 8.1, but we should have this as a contingency plan. Create this as an included plugin, so it can be extracted later if need be. We need to secure access to the local webserver, probably through a session token in the header, since background apps can have access to the webserver. The session token is passed down to the initially loaded local page specified from the content tag in config.xml, and should be used in the cordova.exec call. We would also need to implement local proxy support , see CB-7348 This all sounds more complex than it needs to be than just loading a file url -- wishing Apple would just fix this in iOS 8.1 instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7601) Build fails due to capabilities with m: prefixes are incorrectly sorted
[ https://issues.apache.org/jira/browse/CB-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141213#comment-14141213 ] ASF GitHub Bot commented on CB-7601: Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/46 Build fails due to capabilities with m: prefixes are incorrectly sorted --- Key: CB-7601 URL: https://issues.apache.org/jira/browse/CB-7601 Project: Apache Cordova Issue Type: Bug Components: Windows Affects Versions: 3.6.0 Reporter: Sergey Grebnov Assignee: Jesse MacFadyen Labels: windows Repro steps: {code} cordova create app cd app cordova platform add windows cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova build windows {code} Observe the following error {code} C:\temp\win81\contactsTest\platforms\windows\build\phone\debug\anycpu\AppxM anifest.xml(41,6): error APPX1404: File content does not conform to specified schema. The element 'Capabilities' in namespace 'http://schemas.microsof t.com/appx/2010/manifest' has invalid child element 'Capability' in namespace 'http://schemas.microsoft.com/appx/2014/manifest'. List of possible elem ents expected: 'DeviceCapabilityChoice, DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2010/manifest' as well as 'DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2013/manifest'. [C:\temp\w in81\contactsTest\platforms\windows\CordovaApp.Phone.jsproj] {code} *package.phone.appxmanifest* contains the following section which is invalid since all Capabilities should go before DeviceCapabilities {code} Capabilities Capability Name=internetClientServer / Capability Name=picturesLibrary / DeviceCapability Name=webcam / m3:Capability Name=contacts / /Capabilities {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7601) Build fails due to capabilities with m: prefixes are incorrectly sorted
[ https://issues.apache.org/jira/browse/CB-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141211#comment-14141211 ] ASF subversion and git services commented on CB-7601: - Commit 36b20a7b431aeb57e28201e04fc9cb80143b2943 in cordova-windows's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=36b20a7 ] CB-7601 Build fails due to capabilities with m: prefixes are incorrectly sorted Build fails due to capabilities with m: prefixes are incorrectly sorted --- Key: CB-7601 URL: https://issues.apache.org/jira/browse/CB-7601 Project: Apache Cordova Issue Type: Bug Components: Windows Affects Versions: 3.6.0 Reporter: Sergey Grebnov Assignee: Jesse MacFadyen Labels: windows Repro steps: {code} cordova create app cd app cordova platform add windows cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova plugin add https://github.com/apache/cordova-plugin-contacts cordova build windows {code} Observe the following error {code} C:\temp\win81\contactsTest\platforms\windows\build\phone\debug\anycpu\AppxM anifest.xml(41,6): error APPX1404: File content does not conform to specified schema. The element 'Capabilities' in namespace 'http://schemas.microsof t.com/appx/2010/manifest' has invalid child element 'Capability' in namespace 'http://schemas.microsoft.com/appx/2014/manifest'. List of possible elem ents expected: 'DeviceCapabilityChoice, DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2010/manifest' as well as 'DeviceCapability' in namespace 'http://schemas.microsoft.com/appx/2013/manifest'. [C:\temp\w in81\contactsTest\platforms\windows\CordovaApp.Phone.jsproj] {code} *package.phone.appxmanifest* contains the following section which is invalid since all Capabilities should go before DeviceCapabilities {code} Capabilities Capability Name=internetClientServer / Capability Name=picturesLibrary / DeviceCapability Name=webcam / m3:Capability Name=contacts / /Capabilities {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141241#comment-14141241 ] Ralph S Theart commented on CB-6617: ok all updated... I tried.. urapp.loadUrlInApp(cordova.file.applicationDirectory+'/www/pages/test.html'); {code} html head /head body onload=urapp.initialize() h3Cordova Test/h3 script type=text/javascript src=../../cordova.js/script script type=text/javascript var urapp = { // Application Constructor initialize: function() { this.bindEvents(); }, // Bind Event Listeners // // Bind any events that are required on startup. Common events are: // 'load', 'deviceready', 'offline', and 'online'. bindEvents: function() { document.addEventListener('deviceready', this.onDeviceReady, false); }, // deviceready Event Handler // // The scope of 'this' is the event. In order to call the 'receivedEvent' // function, we must explicity call 'app.receivedEvent(...);' onDeviceReady: function() { alert('ready'); } } /script /body /html {code} the alert never fires...is my codova.js path mess up or something... I even tried script type=text/javascript src=cordova.js/script but still nothing. thanks for your help. inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7453) Cordova-media-capture fails to record an mp3 file on WP8.1 device/emulator
[ https://issues.apache.org/jira/browse/CB-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141263#comment-14141263 ] ASF subversion and git services commented on CB-7453: - Commit 82e748c605da140ecca8c5680a4b04de0cb0354b in cordova-plugin-media-capture's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=82e748c ] CB-7453 Adds fallback to m4a audio format when mp3 recording fails. Cordova-media-capture fails to record an mp3 file on WP8.1 device/emulator -- Key: CB-7453 URL: https://issues.apache.org/jira/browse/CB-7453 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Capture Environment: WP8.1 device/emulator Reporter: Vladimir Kotikov Labels: media-capture, mp3, wp8.1 When trying to record audio file using media-capture plugin on WP8.1 device, i gettting error with code 3, which is equal to {{CAPTURE_NO_MEDIA_FILES}}. It seems that WP8.1 by some reasons can't encode audio stream to mp3 format. Possible solution is to add a fallback to another format (m4a looks good) when mp3 recording fails. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7453) Cordova-media-capture fails to record an mp3 file on WP8.1 device/emulator
[ https://issues.apache.org/jira/browse/CB-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141265#comment-14141265 ] ASF GitHub Bot commented on CB-7453: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/26 Cordova-media-capture fails to record an mp3 file on WP8.1 device/emulator -- Key: CB-7453 URL: https://issues.apache.org/jira/browse/CB-7453 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Capture Environment: WP8.1 device/emulator Reporter: Vladimir Kotikov Labels: media-capture, mp3, wp8.1 When trying to record audio file using media-capture plugin on WP8.1 device, i gettting error with code 3, which is equal to {{CAPTURE_NO_MEDIA_FILES}}. It seems that WP8.1 by some reasons can't encode audio stream to mp3 format. Possible solution is to add a fallback to another format (m4a looks good) when mp3 recording fails. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141275#comment-14141275 ] Ralph S Theart commented on CB-6617: using _blank with IAB btw inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141305#comment-14141305 ] Ralph S Theart commented on CB-6617: ok my js path was wrong...still testing inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141317#comment-14141317 ] Ralph S Theart commented on CB-6617: close but I think I'm missing something... {code} //IAB html head link href=../css/inAppBrowser.css rel=stylesheet type=text/css /head body onload=urapp.initialize() h3Cordova Test/h3 a style=font-size:100px onclick=navigator.notification.alert('boss');TEST THIS!/a script type=text/javascript src=../cordova.js/script script type=text/javascript window.onerror = function(message, url, lineNumber) { parseUrl = location.search.match(/[^/]+$/g); UrlParts = parseUrl[0].split('?'); FileName = UrlParts[0]; alert(Error: +message+ in +FileName+ at line +lineNumber); } var urapp = { // Application Constructor initialize: function() { urapp.bindEvents(); }, // Bind Event Listeners // // Bind any events that are required on startup. Common events are: // 'load', 'deviceready', 'offline', and 'online'. bindEvents: function() { //alert('binding'); document.addEventListener('deviceready', urapp.onDeviceReady, false); }, // deviceready Event Handler // // The scope of 'this' is the event. In order to call the 'receivedEvent' // function, we must explicity call 'app.receivedEvent(...);' onDeviceReady: function() { alert('ready'); } } /script /body /html {code} alert never gets called even though cordova is loading in the IAB ...you can see the pick that shows it. inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph S Theart updated CB-6617: --- Attachment: Screen Shot 2014-09-19 at 5.15.47 PM.png inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Attachments: Screen Shot 2014-09-19 at 5.15.47 PM.png Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-6617: --- Component/s: Android inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Labels: android, localstorage Attachments: Screen Shot 2014-09-19 at 5.15.47 PM.png Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-6617: --- Component/s: (was: Android) inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Assignee: Joe Bowser Labels: android, localstorage Attachments: Screen Shot 2014-09-19 at 5.15.47 PM.png Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (CB-6617) inAppBrowser does not contain the localStorage of the parent window
[ https://issues.apache.org/jira/browse/CB-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser reassigned CB-6617: -- Assignee: (was: Joe Bowser) inAppBrowser does not contain the localStorage of the parent window --- Key: CB-6617 URL: https://issues.apache.org/jira/browse/CB-6617 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Plugin InAppBrowser Affects Versions: 3.4.0 Reporter: Ralph S Theart Labels: android, localstorage Attachments: Screen Shot 2014-09-19 at 5.15.47 PM.png Why is it that I can share localStorage information between wbeviews(I refer to my app and a inappbrowser instance) in iOS but not in Android. If I do... {code} //location: index.html (in my app) localStorage.setItem('Cheese':'Brie'); {code} Then if I try to retrieve this data from locally served html file via inappbroweser in android {code} var item = localStorage.getItem('Cheese'); item = null {code} It never get set... BUT if I recompile my app and locally served html file via inAppBroweser then it's there. I feel like i'm missing something.. How in the world are people passing data back and forth between the app view and the iab view?? I need to pass deep objects back and forth ...so using url parameters is unacceptable. Neither is using inject js...as it is not consistent in android the data does not always make it to the iab instance and sometimes becomes undefined...I have tested this with LoadStart, LoadStop...it's just not consistent. iOS just works...could you help me thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-5294) File input element not opening file picker in Android 4.4
[ https://issues.apache.org/jira/browse/CB-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-5294: --- Assignee: (was: Joe Bowser) File input element not opening file picker in Android 4.4 - Key: CB-5294 URL: https://issues.apache.org/jira/browse/CB-5294 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.1.0 Environment: Android 4.4.2, partially fixed in Android 4.4.3 Reporter: Paul Kane The file input field doesn't respond when clicked/tapped in Android 4.4. Works fine in previous Android versions. This is regardless of whether the Target Level is set to 18 or 19. To reproduce, I created a fresh Cordova 3.1.0 project for Android. The only modification I made to the default (placeholder) index.html file was adding a form element with a single input type=file element inside. Clicking the Choose File button does nothing. No Logcat output or errors. Normally at this point a dialogue would open allowing me to select an image from the gallery or take a picture, which is what happens in older Android versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7471) Translations for September
[ https://issues.apache.org/jira/browse/CB-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141345#comment-14141345 ] ASF GitHub Bot commented on CB-7471: GitHub user sosahvictor opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/65 CB-7471 cordova-plugin-inappbrowser documentation translation cordova-plugin-inappbrowser automatic translation You can merge this pull request into a Git repository by running: $ git pull https://github.com/sosahvictor/cordova-plugin-inappbrowser master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit e9eb23468360eb9cd36a7b041fea8218b904b1f1 Author: Victor Sosa victo...@mx1.ibm.com Date: 2014-09-19T19:31:22Z CB-7471 cordova-plugin-inappbrowser documentation translation: cordova-plugin-inappbrowser Translations for September -- Key: CB-7471 URL: https://issues.apache.org/jira/browse/CB-7471 Project: Apache Cordova Issue Type: Improvement Components: Translation Reporter: Lisa Seacat DeLuca Assignee: Lisa Seacat DeLuca Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7471) Translations for September
[ https://issues.apache.org/jira/browse/CB-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141349#comment-14141349 ] ASF GitHub Bot commented on CB-7471: Github user sosahvictor closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/65 Translations for September -- Key: CB-7471 URL: https://issues.apache.org/jira/browse/CB-7471 Project: Apache Cordova Issue Type: Improvement Components: Translation Reporter: Lisa Seacat DeLuca Assignee: Lisa Seacat DeLuca Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7471) Translations for September
[ https://issues.apache.org/jira/browse/CB-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141350#comment-14141350 ] Victor Adrian Sosa Herrera commented on CB-7471: Hi Lisa, didn't mean to close it. Please let me know if I can do something to get this PR committed Translations for September -- Key: CB-7471 URL: https://issues.apache.org/jira/browse/CB-7471 Project: Apache Cordova Issue Type: Improvement Components: Translation Reporter: Lisa Seacat DeLuca Assignee: Lisa Seacat DeLuca Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7471) Translations for September
[ https://issues.apache.org/jira/browse/CB-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141351#comment-14141351 ] ASF GitHub Bot commented on CB-7471: GitHub user sosahvictor opened a pull request: https://github.com/apache/cordova-plugin-media/pull/30 CB-7471 cordova-plugin-media documentation translation cordova-plugin-media automatic translation You can merge this pull request into a Git repository by running: $ git pull https://github.com/sosahvictor/cordova-plugin-media master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit badb8b4edda89ac6cdeaa6dfbc7778398067aa77 Author: Victor Sosa victo...@mx1.ibm.com Date: 2014-09-19T19:31:33Z CB-7471 cordova-plugin-media documentation translation: cordova-plugin-media Translations for September -- Key: CB-7471 URL: https://issues.apache.org/jira/browse/CB-7471 Project: Apache Cordova Issue Type: Improvement Components: Translation Reporter: Lisa Seacat DeLuca Assignee: Lisa Seacat DeLuca Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-6230) InAppBrowser closes after opening, instead of before
[ https://issues.apache.org/jira/browse/CB-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141371#comment-14141371 ] Joe Bowser commented on CB-6230: I think there's something wrong with your example code w.r.t to how the execution of it will work after some recent refactors. If you're expecting the browser to close an old object before it opens, that's not guaranteed to happen. In fact, once you open an InAppBrowser window then close it, the myWindow object is still present. However, it's not guaranteed that close will work faster than open in this case. If you could explain what you're trying to do with this code, that may be better, because it's not clear here. This looks less like a problem with the way InAppBrowser works per-se, and more a problem with JS. InAppBrowser closes after opening, instead of before Key: CB-6230 URL: https://issues.apache.org/jira/browse/CB-6230 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin InAppBrowser Affects Versions: 3.4.0, 3.5.0 Environment: Android 4.3, Galaxy Nexus Reporter: Jacob Weber Assignee: Joe Bowser In Cordova 3.4, with InAppBrowser 0.3.3, create a new project using the CLI. In www/js/index.js, make the following change: {noformat} onDeviceReady: function() { app.receivedEvent('deviceready'); document.addEventListener('click', function() { if (window.myWindow) window.myWindow.close(); window.myWindow = window.open('http://www.google.com', _blank); }); }, {noformat} Tap the page once, and a browser will appear. Close the browser. Then tap the app again. This time the browser will appear for a split second, then close right away. The close() call seems to be happening after the subsequent open() call, instead of before it. This was working in 3.3, with InAppBrowser 0.2.5. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CB-7603) Update to okhttp 2.0.0
Grigory Kruglov created CB-7603: --- Summary: Update to okhttp 2.0.0 Key: CB-7603 URL: https://issues.apache.org/jira/browse/CB-7603 Project: Apache Cordova Issue Type: Improvement Components: CordovaLib Affects Versions: 3.5.0 Reporter: Grigory Kruglov Priority: Minor Square's okhttp is now at 2.0.0 (vs 1.3.0 that's currently included in cordova-android). It would be great to see bundled version of okhttp upgraded. There are significant API changes, so it's likely to be non-trivial. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7383) [Release + 3.6.0] Parent Issue
[ https://issues.apache.org/jira/browse/CB-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141407#comment-14141407 ] ASF subversion and git services commented on CB-7383: - Commit 1626351 from [~cmarcelk] [ https://svn.apache.org/r1626351 ] CB-7383 Upload the 3.6 docs, but don't make them primary yet. [Release + 3.6.0] Parent Issue -- Key: CB-7383 URL: https://issues.apache.org/jira/browse/CB-7383 Project: Apache Cordova Issue Type: Task Components: Amazon FireOS, Android, App Hello World, BlackBerry, CLI, CordovaJS, CordovaLib, FirefoxOS, iOS, mobile-spec, Ubuntu, Windows 8, WP8 Reporter: Steve Gill Assignee: Jesse MacFadyen Fix For: 3.6.0 Parent bug for the 3.6.0 Cordova Release. Workflow here: http://wiki.apache.org/cordova/CuttingReleases Release Master: ? Component Leads: Refer to assignee of Test Tag sub-tasks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CB-7539) [WKWebView][iOS 8] Use local webserver option to load local HTML file from www
[ https://issues.apache.org/jira/browse/CB-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141153#comment-14141153 ] Shazron Abdullah edited comment on CB-7539 at 9/19/14 10:34 PM: Thanks Liming Xie, I like the idea. Here's what I'm thinking: To use WKWebView as the default web engine, we need a local http server running (at least until Apple fixes this bug). This will *NOT* be embedded as part of Cordova, but is a plugin with onload = true in the feature tag. This accomplishes two things: 1. Maintenance of the plugin is out of Cordova committer's hands, we don't have to be experts 2. Ability to swap (if need be) another http server. Not sure if this is that important However Cordova still needs to discover the http server during startup. This can be achieved through Preferences, and a new protocol these http servers will need to implement (simple stuff). I'm thinking: {code} preference name=CordovaHttpServer value=CorHttpd / !-- the http server plugin feature name -- {code} CorHttpd will implement, say, CDVHttpServerProtocol My proposal: {code} - (void) startServer:(NSURL*)root; // we want a randomized port - (void) stopServer; - (NSURL*) serverUrl; // return the server url - (void) setSessionKey:(NSString*)sessionKey; // not sure how this will work yet at all. {code} If preference UseWKWebView is true: # look for the CordovaHttpServer preference, now we know which plugin is the loaded http server. # confirm http server plugin conforms to CDVHttpServerProtocol, # call CDVHttpServerProtocol::startServer, passing in the www root (we need to pass in the exact html file to load) # generate a UUID for the sessionKey, set the sessionKey through CDVHttpServerProtocol:setSessionKey, # grab the serverUrl through CDVHttpServerProtocol::serverUrl # pass the serverUrl to WKWebView If the CordovaHttpServer plugin is missing, we error out and prompt the user to install one, with a recommendation (in this case CorHttpd). was (Author: shazron): Thanks Liming Xie, I like the idea. Here's what I'm thinking: To use WKWebView as the default web engine, we need a local http server running (at least until Apple fixes this bug). This will *NOT* be embedded as part of Cordova, but is a plugin with onload = true in the feature tag. This accomplishes two things: 1. Maintenance of the plugin is out of Cordova committer's hands, we don't have to be experts 2. Ability to swap (if need be) another http server. Not sure if this is that important However Cordova still needs to discover the http server during startup. This can be achieved through Preferences, and a new protocol these http servers will need to implement (simple stuff). I'm thinking: {code} preference name=CordovaHttpServer value=CorHttpd / !-- the http server plugin feature name -- {code} CorHttpd will implement, say, CDVHttpServerProtocol My proposal: {code} - (void) startServer:(NSURL*)root; // we want a randomized port - (void) stopServer; - (NSURL*) serverUrl; // return the server url - (void) setSessionKey:(NSString*)sessionKey; // not sure how this will work yet at all. {code} If preference UseWKWebView is true, we look for the CordovaHttpServer preference, now we know which plugin is the loaded http server. We check that it conforms to CDVHttpServerProtocol, then call startServer, passing in the www root (we need to pass in the exact html file to load), generate a UUID for the sessionKey, set the sessionKey, grab the serverUrl, and pass it to WKWebView. If the CordovaHttpServer plugin is missing, we error out and prompt the user to install one, with a recommendation (in this case CorHttpd). [WKWebView][iOS 8] Use local webserver option to load local HTML file from www -- Key: CB-7539 URL: https://issues.apache.org/jira/browse/CB-7539 Project: Apache Cordova Issue Type: Sub-task Components: iOS Reporter: Shazron Abdullah Priority: Blocker This workaround is because of this bug: http://www.openradar.me/radar?id=5839348817723392 (filed with Apple of course also) I'm still hoping that Apple fixes this in iOS 8.1, but we should have this as a contingency plan. Create this as an included plugin, so it can be extracted later if need be. We need to secure access to the local webserver, probably through a session token in the header, since background apps can have access to the webserver. The session token is passed down to the initially loaded local page specified from the content tag in config.xml, and should be used in the cordova.exec call. We would also need to implement local proxy support , see CB-7348 This all sounds more complex than it needs to be than just loading a file url -- wishing Apple would just fix this
[jira] [Resolved] (CB-6910) Cordova app is killed by progress element on some Androids
[ https://issues.apache.org/jira/browse/CB-6910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-6910. Resolution: Won't Fix This isn't something we can fix easily. In 4.0.x you can use a 3rd Party WebView, but that's like using a sledgehammer to put in a nail so you can hang a painting. Cordova app is killed by progress element on some Androids Key: CB-6910 URL: https://issues.apache.org/jira/browse/CB-6910 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.4.0, 3.5.0 Reporter: Martin Hujer Assignee: Joe Bowser Priority: Minor When you create a Cordova app and put this content into index.html file: {code} !DOCTYPE html html body progress id=pr-3 style=width: 200px/progress /body /html {code} it kills Android app with with SIGSEGV on certain Androids (such as Samsung Galaxy S4 - GT-I9195). {code} 06-10 16:19:56.473: A/libc(5668): Fatal signal 11 (SIGSEGV) at 0x (code=1), thread 5682 (WebViewCoreThre) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CB-2391) colons in URIs crash WebView
[ https://issues.apache.org/jira/browse/CB-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-2391. Resolution: Won't Fix This hasn't come up recently, but it's also something that we can't fix easily with Cordova 3.x or lower. Closing, since this is a browser issue. colons in URIs crash WebView Key: CB-2391 URL: https://issues.apache.org/jira/browse/CB-2391 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 2.3.0 Environment: Seen on Nexus 4, Android 4.2.1 Reporter: Robert Hoffmann Assignee: Joe Bowser Priority: Minor Labels: WebView, crash, hash, url Fix For: 3.6.0 With useBrowserHistory (true) the application crashes when returning from WebView (using the android back button). Reproduce: 1) So from the Cordova App page (file:///android_asset/www/app.html#BackPlace:null) the user clicks on a link (e.g. www.google.com) which opens the WebView. 2) When clicking the back button to return to the app, the app crashes with the exception below. Guess: I wonder if the hash in the originating cordova app page could be the core of this problem (e.g. file:///android_asset/www/app.html#BackPlace:null). Note: The app does not crash when setting useBrowserHistory to false! 02-07 01:09:45.979: E/dalvikvm(8542): Class lookup Landroid/webkit/WebResourceResponse; attempted with exception pending 02-07 01:09:45.979: W/dalvikvm(8542): Pending exception is: 02-07 01:09:45.979: I/dalvikvm(8542): java.lang.NullPointerException: 02-07 01:09:45.979: I/dalvikvm(8542): at android.content.res.AssetManager.openAsset(Native Method) 02-07 01:09:45.979: I/dalvikvm(8542): at android.content.res.AssetManager.open(AssetManager.java:315) 02-07 01:09:45.979: I/dalvikvm(8542): at android.webkit.BrowserFrame.inputStreamForAndroidResource(BrowserFrame.java:765) 02-07 01:09:45.979: I/dalvikvm(8542): at android.webkit.BrowserFrame.shouldInterceptRequest(BrowserFrame.java:852) 02-07 01:09:45.979: I/dalvikvm(8542): at android.webkit.BrowserFrame.nativeGoBackOrForward(Native Method) 02-07 01:09:45.979: I/dalvikvm(8542): at android.webkit.BrowserFrame.goBackOrForward(BrowserFrame.java:346) 02-07 01:09:45.979: I/dalvikvm(8542): at android.webkit.WebViewCore$EventHub$1.handleMessage(WebViewCore.java:1400) 02-07 01:09:45.979: I/dalvikvm(8542): at android.os.Handler.dispatchMessage(Handler.java:99) 02-07 01:09:45.979: I/dalvikvm(8542): at android.os.Looper.loop(Looper.java:137) 02-07 01:09:45.979: I/dalvikvm(8542): at android.webkit.WebViewCore$WebCoreThread.run(WebViewCore.java:812) 02-07 01:09:45.979: I/dalvikvm(8542): at java.lang.Thread.run(Thread.java:856) 02-07 01:09:45.979: I/dalvikvm(8542): DALVIK THREADS: 02-07 01:09:45.979: I/dalvikvm(8542): (mutexes: tll=0 tsl=0 tscl=0 ghl=0) 02-07 01:09:45.979: D/DroidGap(8542): onMessage(onPageStarted,file:///android_asset/www/app.html#BackPlace:null) 02-07 01:09:45.979: I/dalvikvm(8542): main prio=5 tid=1 NATIVE 02-07 01:09:45.989: I/dalvikvm(8542): | group=main sCount=0 dsCount=0 obj=0x40cfc9a0 self=0x40701bf8 02-07 01:09:45.989: I/dalvikvm(8542): | sysTid=8542 nice=0 sched=0/0 cgrp=apps handle=1074258908 02-07 01:09:45.989: I/dalvikvm(8542): | state=S schedstat=( 0 0 0 ) utm=97 stm=76 core=0 02-07 01:09:45.999: I/dalvikvm(8542): #00 pc 00017ee4 /system/lib/libc.so (epoll_wait+12) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-3313) Both Camera.getPicture and Capture.captureImage api doesn't set MediaStore.Images.Media.Size after picture taken
[ https://issues.apache.org/jira/browse/CB-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141477#comment-14141477 ] Joe Bowser commented on CB-3313: Related to CB-7487 Both Camera.getPicture and Capture.captureImage api doesn't set MediaStore.Images.Media.Size after picture taken Key: CB-3313 URL: https://issues.apache.org/jira/browse/CB-3313 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin Camera Affects Versions: 2.6.0 Reporter: yongqian gao Assignee: Joe Bowser Priority: Minor Tried a couple android devices with both image and picture api from Cordova; and notice the picture size shows zero while getting those picture from Windows 7/Portable Devices. And on some of device, you can not copy those pictures to windows desktop. while you can get those pictures from Adb/Shell, and file size is right. I notice both APIs doesn't set MediaStore.Images.Media.Size after picture taken. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7493) Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms.
[ https://issues.apache.org/jira/browse/CB-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141600#comment-14141600 ] ASF GitHub Bot commented on CB-7493: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/43#issuecomment-56250918 These tests are failing for me. What commit is required to make this pass? or is there an environment setting I need to change? Creating Cordova Windows Project: App Name : com.test.app Namespace : 応用 Path : testcreate Add e2e test for 'space-in-path' and 'unicode in path/name' for core platforms. --- Key: CB-7493 URL: https://issues.apache.org/jira/browse/CB-7493 Project: Apache Cordova Issue Type: Bug Components: Android, iOS, Windows, WP8 Reporter: Vladimir Kotikov Assignee: Jesse MacFadyen Since we have several issues with unicode in paths and app names it will be great to have automated testing of these cases. Best place to keep these tests is platform repo, so these tests can be ran via come CI service (Appveyor for WP8 and Windows, Travis CI for Android and iOS) For WP8 and windows platforms we already have such tests, so we need just to improve them to test new cases. For Android and iOS it will be necessary to implement tests. Implementation will be very similar to windows/wp8 implementation. Note that android currently doesn't have support for unicode symbols in app name (due to android tools restrictions). So test for android should contain only 'space' case test. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CB-7604) [iOS 8] Update icon and splash screen support for iPhone 6 and 6 Plus
[ https://issues.apache.org/jira/browse/CB-7604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-7604: - Issue Type: Sub-task (was: Bug) Parent: CB-7043 [iOS 8] Update icon and splash screen support for iPhone 6 and 6 Plus - Key: CB-7604 URL: https://issues.apache.org/jira/browse/CB-7604 Project: Apache Cordova Issue Type: Sub-task Components: iOS Environment: iOS 8 Reporter: Shazron Abdullah New icon size for iPhone 6 Plus - 180x180. New splash screen sizes also. Find out prevention of auto-scaling. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7539) [WKWebView][iOS 8] Use local webserver option to load local HTML file from www
[ https://issues.apache.org/jira/browse/CB-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141645#comment-14141645 ] Liming Xie commented on CB-7539: Shazron, I like the proposal. It does make sense. [WKWebView][iOS 8] Use local webserver option to load local HTML file from www -- Key: CB-7539 URL: https://issues.apache.org/jira/browse/CB-7539 Project: Apache Cordova Issue Type: Sub-task Components: iOS Reporter: Shazron Abdullah Priority: Blocker This workaround is because of this bug: http://www.openradar.me/radar?id=5839348817723392 (filed with Apple of course also) I'm still hoping that Apple fixes this in iOS 8.1, but we should have this as a contingency plan. Create this as an included plugin, so it can be extracted later if need be. We need to secure access to the local webserver, probably through a session token in the header, since background apps can have access to the webserver. The session token is passed down to the initially loaded local page specified from the content tag in config.xml, and should be used in the cordova.exec call. We would also need to implement local proxy support , see CB-7348 This all sounds more complex than it needs to be than just loading a file url -- wishing Apple would just fix this in iOS 8.1 instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)