[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298238#comment-14298238
 ] 

ASF GitHub Bot commented on CB-5059:


Github user dpogue commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-72157462
  
Thanks for catching that. Updated and tested with both 
cordova-android@3.6.4 and cordova-android@4.0.x.


> The android implementation of file transfer plugin should not depend on the 
> concrete class android.webkit.CookieManager
> ---
>
> Key: CB-5059
> URL: https://issues.apache.org/jira/browse/CB-5059
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: Master
> Environment: cordova-android, git branch 3.0.x
>Reporter: Junmin
> Fix For: Master
>
>
> The android implementation of file transfer plugin leverages the class 
> android.webkit.CookieManager, which depends on the concrete web 
> infrastructure android.webkit.WebView. This dependence ruins the portability 
> of the plugin. For example, it could not run on a substantial implementation 
> of CordovaWebView which based on a android third party component(such as 
> chromium for android).
> Following is the crash log when initializing the CookieManager without 
> android.webkit.WebView:
> I/dalvikvm(5006): java.lang.IllegalStateException: Call 
> CookieSyncManager::createInstance() or create a webview before using this 
> class
> I/dalvikvm(5006):   at 
> android.webkit.JniUtil.checkInitialized(JniUtil.java:44)
> I/dalvikvm(5006):   at 
> android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.nativeGetCookie(Native Method)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96)
> I/dalvikvm(5006):   at 
> org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8346) App silently crashes after crop intent task at Camera@0.3.3

[Shingo Toda (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298200#comment-14298200
 ] 

Shingo Toda commented on CB-8346:
-

This issue seems fixed by this change.
https://github.com/apache/cordova-plugin-camera/commit/8b8db828f6661ebe8cf44f488140774b9ddd7eb0#diff-f2e83abdaf34884df7e74b6493cf2dd7


> App silently crashes after crop intent task at Camera@0.3.3
> ---
>
> Key: CB-8346
> URL: https://issues.apache.org/jira/browse/CB-8346
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Android 4.4.3 (Nexus 7)
>Reporter: Shingo Toda
>Priority: Minor
>
> After sequentially taking pictures with allowEdit == true, an app ends up 
> silently being killed. This issue may be reproduced using mobilespec as below.
> # Set allowEdit to true and sourceType to CAMERA
> # Touch "Get Picture"
> # Take photo
> # Really resize the taken picture
> # Do this cycle several times
> Maybe the first a few of photos are successfully retrieved but at some point, 
> an app silently ends. 
> It seems that when an app ends, the app does not get resumed after crop 
> intent task is finished.
> This does not happen when I actually don't resize a photo within crop intent 
> task.
> Also I didn't see this happen on ICS device (Android 4.0.3).
> Log below was shown when I took a picture but the app ended.
> {noformat}
> 01-22 18:39:57.686: D/CordovaLog(14287): 
> file:///android_asset/www/plugins/org.apache.cordova.test-framework/www/main.js:
>  Line 117 : Getting picture with options: 
> {"sourceType":1,"destinationType":1,"encodingType":0,"mediaType":0,"quality":50,"allowEdit":1,"correctOrientation":1,"saveToPhotoAlbum":1}
> 01-22 18:39:57.686: I/chromium(14287): [INFO:CONSOLE(117)] "Getting picture 
> with options: 
> {"sourceType":1,"destinationType":1,"encodingType":0,"mediaType":0,"quality":50,"allowEdit":1,"correctOrientation":1,"saveToPhotoAlbum":1}",
>  source: 
> file:///android_asset/www/plugins/org.apache.cordova.test-framework/www/main.js
>  (117)
> 01-22 18:39:57.706: D/CordovaActivity(14287): Paused the application!
> 01-22 18:39:57.706: D/CordovaWebView(14287): Handle the pause
> 01-22 18:39:57.976: W/IInputConnectionWrapper(14287): showStatusIcon on 
> inactive InputConnection
> 01-22 18:39:58.387: W/ManagedEGLContext(14287): doTerminate failed: EGL count 
> is 2 but managed count is 1
> 01-22 18:40:06.685: D/CordovaActivity(14287): Incoming Result
> 01-22 18:40:06.685: D/CordovaActivity(14287): Request code = 34
> 01-22 18:40:06.685: D/CordovaActivity(14287): We have a callback to send this 
> result to
> 01-22 18:40:06.725: D/dalvikvm(14287): GC_FOR_ALLOC freed 433K, 33% free 
> 9194K/13660K, paused 12ms, total 12ms
> 01-22 18:40:06.765: I/dalvikvm-heap(14287): Grow heap (frag case) to 28.233MB 
> for 20155408-byte allocation
> 01-22 18:40:06.785: D/dalvikvm(14287): GC_FOR_ALLOC freed <1K, 14% free 
> 28876K/33344K, paused 15ms, total 15ms
> 01-22 18:40:06.785: W/CursorWrapperInner(14287): Cursor finalized without 
> prior close()
> 01-22 18:40:07.556: D/dalvikvm(14287): GC_EXPLICIT freed 19711K, 33% free 
> 9179K/13660K, paused 2ms+3ms, total 31ms
> 01-22 18:40:07.566: D/CordovaActivity(14287): Resuming the App
> 01-22 18:40:07.566: W/CursorWrapperInner(14287): Cursor finalized without 
> prior close()
> 01-22 18:40:07.566: D/CordovaActivity(14287): Paused the application!
> 01-22 18:40:07.566: D/CordovaWebView(14287): Handle the pause
> 01-22 18:40:07.896: W/ManagedEGLContext(14287): doTerminate failed: EGL count 
> is 2 but managed count is 1
> {noformat}
> When it successfully crops a photo, following log was shown after the message 
> above.
> {noformat}
> 01-22 18:39:54.923: D/CordovaActivity(14287): Incoming Result
> 01-22 18:39:54.923: D/CordovaActivity(14287): Request code = 100
> 01-22 18:39:54.923: D/CordovaActivity(14287): We have a callback to send this 
> result to
> 01-22 18:39:54.943: D/CordovaActivity(14287): Resuming the App
> 01-22 18:39:54.963: D/CordovaLog(14287): 
> file:///android_asset/www/plugins/org.apache.cordova.test-framework/www/main.js:
>  Line 117 : URL: 
> file:///storage/emulated/0/Android/data/org.apache.mobilespec/cache/1421912394938.jpg
> 01-22 18:39:54.963: I/chromium(14287): [INFO:CONSOLE(117)] "URL: 
> file:///storage/emulated/0/Android/data/org.apache.mobilespec/cache/1421912394938.jpg",
>  source: 
> file:///android_asset/www/plugins/org.apache.cordova.test-framework/www/main.js
>  (117)
> 01-22 18:39:55.123: D/CordovaLog(14287): 
> file:///android_asset/www/plugins/org.apache.cordova.test-framework/www/main.js:
>  Line 117 : resolveLocalFileSystemURI is deprecated. Please call 
> resolveLocalFileSystemURL instead.
> 01-22 18:39:55.123: I/chromium(14287): [INFO:CONSOLE(117)] 
> "reso

[jira] [Commented] (CB-8382) Make CordovaActivity not implement CordovaInterface

[Andrew Grieve (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298099#comment-14298099
 ] 

Andrew Grieve commented on CB-8382:
---

Created a PR for review of this: 
https://github.com/apache/cordova-android/pull/152

> Make CordovaActivity not implement CordovaInterface
> ---
>
> Key: CB-8382
> URL: https://issues.apache.org/jira/browse/CB-8382
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> CordovaWebView.java used to enforce that they CordovaActivity could be cast 
> to a CordovaInterface, but this has been fixed with the move to a two-step 
> initialization (separate call to init()). 
> With this being fixed, it would clean up the code a bit by shrinking the API 
> surface of CordovaActivity. Further, it would ensure that the 
> activity==interface assumption does not return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8382) Make CordovaActivity not implement CordovaInterface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298097#comment-14298097
 ] 

ASF GitHub Bot commented on CB-8382:


GitHub user agrieve opened a pull request:

https://github.com/apache/cordova-android/pull/152

CB-8382 Make CordovaActivity not implement CordovaInterface

Instead, use a CordovaInterfaceImpl class. This also makes it easier
for apps to implement the interface without extending CordovaActivity.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agrieve/cordova-android cordova-interface

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit e27fd72d52b136d820e1e07c86fdcc5cdbf197ad
Author: Andrew Grieve 
Date:   2015-01-30T01:42:44Z

CB-8382 Make CordovaActivity not implement CordovaInterface

Instead, use a CordovaInterfaceImpl class. This also makes it easier
for apps to implement the interface without extending CordovaActivity.




> Make CordovaActivity not implement CordovaInterface
> ---
>
> Key: CB-8382
> URL: https://issues.apache.org/jira/browse/CB-8382
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> CordovaWebView.java used to enforce that they CordovaActivity could be cast 
> to a CordovaInterface, but this has been fixed with the move to a two-step 
> initialization (separate call to init()). 
> With this being fixed, it would clean up the code a bit by shrinking the API 
> surface of CordovaActivity. Further, it would ensure that the 
> activity==interface assumption does not return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8341) position retrieval timed out

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8341:
-
Component/s: (was: CordovaLib)
 (was: iOS)
 Plugin Geolocation
Environment: iOS

> position retrieval timed out
> 
>
> Key: CB-8341
> URL: https://issues.apache.org/jira/browse/CB-8341
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
>Affects Versions: 3.5.0
> Environment: iOS
>Reporter: Probal
>
> geolocation.getCurrentPosition giving error "position retrieval timed out" in 
> phone gap app for ios 8.1. It was giving correct location on IOS version 7.1. 
> geolocation plugin has been update to latest version and still getting the 
> same error constantly. Any help is appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8355) return errors about permissions denied before trying to capture

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8355:
-
Component/s: (was: iOS)
 Plugin Camera

> return errors about permissions denied before trying to capture
> ---
>
> Key: CB-8355
> URL: https://issues.apache.org/jira/browse/CB-8355
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Camera
>Reporter: Anton S. Konovalov
>  Labels: permissions
>
> I posted CDVCamera.m to the gist.github.com so you could check if everything 
> work ok for you and apply to the latest file version.
> Here it is: https://gist.github.com/extempl/c4ad434409f2b9c358b2
> P.S. you need to compare this with 0.3.4 since it based on latest stable 
> version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8342) SplashScreen plugin doesn't destroy it's views which seems to block user interaction

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8342:
-
Component/s: (was: iOS)
 Plugin SplashScreen

> SplashScreen plugin doesn't destroy it's views which seems to block user 
> interaction
> 
>
> Key: CB-8342
> URL: https://issues.apache.org/jira/browse/CB-8342
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Jamal Johnson
>  Labels: ios, splashscreen
>
> We recently updated the SplashScreen plugin for iPhone 6/6+ support but 
> uncovered an issue that appears to have been caused by a fix for another 
> issue.
> There was a bug report (https://issues.apache.org/jira/browse/CB-7204) 
> concerning it sounds like a race condition with the spinner and the splash 
> screen and the fix was to make sure the animation "completed" by checking a 
> boolean passed to the animation "completion" function, when hiding the 
> SplashScreen, before destroying it's views. This boolean, according to the 
> docs, will be false if another view is animated in before this one was 
> "completed".
> Here is the commit with the fix: d2e62a551c950041cb4c9683624a04d931f4bee3 
> (https://github.com/apache/cordova-plugin-splashscreen/commit/d2e62a551c950041cb4c9683624a04d931f4bee3)
> We have a case where we have another view (a PinLock plugin) that sometimes 
> gets animated in before the SplashScreen animation is fully complete. There 
> doesn't seem to be any issues with this and is transparent to the user. 
> However, with the addition of checking the "finished" boolean before 
> destroying the views, the app becomes unusable. If we comment that 
> conditional out, everything works fine again.
> Is there another way to handle fixing the race condition? Or any other 
> suggestions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8355) return errors about permissions denied before trying to capture

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8355:
-
Environment: iOS

> return errors about permissions denied before trying to capture
> ---
>
> Key: CB-8355
> URL: https://issues.apache.org/jira/browse/CB-8355
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Camera
> Environment: iOS
>Reporter: Anton S. Konovalov
>  Labels: permissions
>
> I posted CDVCamera.m to the gist.github.com so you could check if everything 
> work ok for you and apply to the latest file version.
> Here it is: https://gist.github.com/extempl/c4ad434409f2b9c358b2
> P.S. you need to compare this with 0.3.4 since it based on latest stable 
> version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8270) Objective-C methods on categories should be named with a prefix

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8270:
-
Fix Version/s: (was: Master)
   4.0.0

> Objective-C methods on categories should be named with a prefix
> ---
>
> Key: CB-8270
> URL: https://issues.apache.org/jira/browse/CB-8270
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Affects Versions: Master
> Environment: All iOS platforms
>Reporter: Ruoyu Fu
>Priority: Critical
>  Labels: categories, ios, namespace
> Fix For: 4.0.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> According to Apple's documentation, naming a Category method without a prefix 
> would possibly cause a Name Clash
> https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4
> In CordovaLib/Classes/CDVJSON.h : NSArray(CDVJSONSerializing) 
> The method name should starts with a prefix



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8222) play media in background thread

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8222:
-
Component/s: (was: iOS)
 Plugin Media

> play media in background thread
> ---
>
> Key: CB-8222
> URL: https://issues.apache.org/jira/browse/CB-8222
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media
>Affects Versions: 3.5.0
> Environment: Xcode
>Reporter: Ralf Koch
>  Labels: performance
>
> Xcode gives a warning with in example the Media plugin playing a tiny mp3 
> file for taking too long, even though it is about 50ms and recommends 
> background thread which is actually easy to implement.
> Could you guys do this or is there a reason not to?
> I would think it should be in the "CDVSound.m" --> "- 
> (void)startPlayingAudio:(CDVInvokedUrlCommand*)command" command, is this 
> correct?
> Best regards
> Ralf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7873) [iOS 8] Memory accretion issue

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298068#comment-14298068
 ] 

Shazron Abdullah commented on CB-7873:
--

Considering CB-8002 was introduced in 3.7.0 (Nov 2014) and the test project 
used 3.6.3, I don't think it's related. 

> [iOS 8] Memory accretion issue
> --
>
> Key: CB-7873
> URL: https://issues.apache.org/jira/browse/CB-7873
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: Master
> Environment: iOS 8
>Reporter: Shazron Abdullah
> Attachments: memory-accretion.png
>
>
> See https://github.com/ModusCreateOrg/phonegap-ios8-memory for description 
> and test project.
> See attached image.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8222) play media in background thread

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-8222:
-
Environment: 
Xcode
iOS

  was:Xcode


> play media in background thread
> ---
>
> Key: CB-8222
> URL: https://issues.apache.org/jira/browse/CB-8222
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media
>Affects Versions: 3.5.0
> Environment: Xcode
> iOS
>Reporter: Ralf Koch
>  Labels: performance
>
> Xcode gives a warning with in example the Media plugin playing a tiny mp3 
> file for taking too long, even though it is about 50ms and recommends 
> background thread which is actually easy to implement.
> Could you guys do this or is there a reason not to?
> I would think it should be in the "CDVSound.m" --> "- 
> (void)startPlayingAudio:(CDVInvokedUrlCommand*)command" command, is this 
> correct?
> Best regards
> Ralf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8365) Add NSInteger, NSUInteger factory methods to CDVPluginResult

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298065#comment-14298065
 ] 

Shazron Abdullah commented on CB-8365:
--

i.e. as another overload here: 
https://github.com/apache/cordova-ios/blob/fd941c3c7bbf7705087be7c2ecc23ca432036a56/CordovaLib/Classes/CDVPluginResult.h#L49

> Add NSInteger, NSUInteger factory methods to CDVPluginResult
> 
>
> Key: CB-8365
> URL: https://issues.apache.org/jira/browse/CB-8365
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Kevin Hawkins
>Priority: Minor
> Fix For: Master
>
>   Original Estimate: 2m
>  Remaining Estimate: 2m
>
> It would be nice to have the Cocoa-defined integer types as return values 
> from the plugin, especially given that they'll support much larger data for 
> 64-bit devices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-8382) Make CordovaActivity not implement CordovaInterface

[Andrew Grieve (JIRA)]

Andrew Grieve created CB-8382:
-

 Summary: Make CordovaActivity not implement CordovaInterface
 Key: CB-8382
 URL: https://issues.apache.org/jira/browse/CB-8382
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Reporter: Andrew Grieve
Assignee: Andrew Grieve
Priority: Minor


CordovaWebView.java used to enforce that they CordovaActivity could be cast to 
a CordovaInterface, but this has been fixed with the move to a two-step 
initialization (separate call to init()). 

With this being fixed, it would clean up the code a bit by shrinking the API 
surface of CordovaActivity. Further, it would ensure that the 
activity==interface assumption does not return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-8379) cordova --version should also tell you the cordova-lib version

[Andrew Grieve (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Grieve resolved CB-8379.
---
Resolution: Fixed

Since the lib version is generally the same as the CLI version,
only print the cordova-lib version if it differs from the CLI version, or if it 
ends with "-dev". The -dev part is to make it easier to know when it's npm 
link'ed properly.
Fixed in 4.2.1-dev

> cordova --version should also tell you the cordova-lib version
> --
>
> Key: CB-8379
> URL: https://issues.apache.org/jira/browse/CB-8379
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> cordova-lib version is generally more useful than cordova-cli version, so 
> --version should tell you both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8379) cordova --version should also tell you the cordova-lib version

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297986#comment-14297986
 ] 

ASF subversion and git services commented on CB-8379:
-

Commit 545cac1e0a96caa97a2ba8bcd54120495ce5af50 in cordova-cli's branch 
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=545cac1 ]

CB-8379 Have --version print out cordova-lib version if it's not the same as 
CLI's version

Useful for local testing


> cordova --version should also tell you the cordova-lib version
> --
>
> Key: CB-8379
> URL: https://issues.apache.org/jira/browse/CB-8379
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> cordova-lib version is generally more useful than cordova-cli version, so 
> --version should tell you both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-5696) Missing Plugin source file on iOS

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah resolved CB-5696.
--
Resolution: Fixed
  Assignee: Andrew Grieve

> Missing Plugin source file on iOS
> -
>
> Key: CB-5696
> URL: https://issues.apache.org/jira/browse/CB-5696
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugman
>Affects Versions: 3.3.0
> Environment: Mac OSX 10.9, plugman 0.17.0, cordova 3.3.0-0.1.1, xcode 
> 5
>Reporter: xu.li
>Assignee: Andrew Grieve
>  Labels: build, patch
>
> Bug
> 
> 1. cordova create cordova-issue com.example.cordova.issue cordova-issue
> 2. cd cordova-issue/ && cordova platform add ios && cordova build && cordova 
> plugin add org.apache.cordova.device
> 3. Open the project in xcode5, and you will find CDVDevice.h and CDVDevice.m 
> are missing.
> Reason
> 
> It is caused by [cordova-plugman.git] / src / platforms / ios.js.
> In the parseProjectFile function, it searches for "config.xml" using 
> "glob.sync", and then filter the file path list, and then use the first file 
> in the remaining list.
> When the name of the project, 3rd parameter in the "cordova create" command, 
> starts with a lowercased letter after "b", it will not be list as the first 
> item among all the candidates, and the "**/build/**"-like file paths are not 
> filtered out.
> Quick Fix
> 
> Filter all the file candidates contain "/build/".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8182) cordova run browser will serve app files over http

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297849#comment-14297849
 ] 

ASF GitHub Bot commented on CB-8182:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-browser/pull/9#issuecomment-72121570
  
It's worth a lot! 
There is some prior art on this, last summer Suraj, aka @surajpindoria 
split all of cordova-lib into separate modules, however this was too big of a 
change all at once, so it ultimately became un-mergable rather quickly.  It 
still lives as a parable for future generations here : 
https://github.com/apache/cordova-lib/pull/62


> cordova run browser will serve app files over http
> --
>
> Key: CB-8182
> URL: https://issues.apache.org/jira/browse/CB-8182
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Browser
>Reporter: Kirk Shoop
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8182) cordova run browser will serve app files over http

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297821#comment-14297821
 ] 

ASF GitHub Bot commented on CB-8182:


Github user jsoref commented on the pull request:

https://github.com/apache/cordova-browser/pull/9#issuecomment-72117452
  
fwiw, that was what i was going to suggest. :+1: 


> cordova run browser will serve app files over http
> --
>
> Key: CB-8182
> URL: https://issues.apache.org/jira/browse/CB-8182
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Browser
>Reporter: Kirk Shoop
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297820#comment-14297820
 ] 

ASF GitHub Bot commented on CB-8123:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/155#issuecomment-72117279
  
yeah, whichever approach is easier. Ultimately the test in this case is 
invalid, but we don't want it appearing to break the build.


> Enable version, device, and chip arch specific library / dll / winmd 
> references in plugins for the Windows platform
> ---
>
> Key: CB-8123
> URL: https://issues.apache.org/jira/browse/CB-8123
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugins, Windows
>Reporter: Tim Barham
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Because Cordova's windows platform can target multiple target platforms, 
> projects and frameworks referenced by the plugin may need to target only a 
> subset of those platforms. To enable this, support the following attributes 
> on the  and  elements:
> 1. device - indicates the reference is specific to a target device. Supported 
> values are "phone", "windows" or "all" (default is "all").
> 2. versions - specify platform versions the reference supports (node semantic 
> version ranges supported). Default is to support all versions.
> 3. arch - indicates the reference is specific to a particular chip 
> architecture (x86 or x64).
> The "arch" attribute should result in a Condition="'$(Platform)'=='XXX" 
> attribute on the reference. The other attributes will impact which generated 
> jsproj files the reference is actually added to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297799#comment-14297799
 ] 

ASF GitHub Bot commented on CB-8123:


Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/155#issuecomment-72114968
  
The tests use path.join(), but jsproj uses hard-coded backslashes (which is 
reasonable, because normally it would only run on Windows). This problem is 
showing up now because previously this code wasn’t exercised by tests.

I’m looking to see if it is feasible/reasonable to update jsproj to be 
platform agnostic, to the extent it needs to be for tests to pass. I’d prefer 
that to skipping the tests, so we get consistent coverage (the tests don’t 
build projects – just verify that files are modified as expected).

From: Jesse MacFadyen [mailto:notificati...@github.com]
Sent: Thursday, January 29, 2015 12:12 PM
To: apache/cordova-lib
Cc: Tim Barham
Subject: Re: [cordova-lib] CB-8123 Plugin references can target specific 
windows platforms. (#155)


You should use path.join( ) in your tests when creating paths so the tests 
will still pass on MacOS, or check the environment and skip running your tests 
altogether.

—
Reply to this email directly or view it on 
GitHub.



> Enable version, device, and chip arch specific library / dll / winmd 
> references in plugins for the Windows platform
> ---
>
> Key: CB-8123
> URL: https://issues.apache.org/jira/browse/CB-8123
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugins, Windows
>Reporter: Tim Barham
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Because Cordova's windows platform can target multiple target platforms, 
> projects and frameworks referenced by the plugin may need to target only a 
> subset of those platforms. To enable this, support the following attributes 
> on the  and  elements:
> 1. device - indicates the reference is specific to a target device. Supported 
> values are "phone", "windows" or "all" (default is "all").
> 2. versions - specify platform versions the reference supports (node semantic 
> version ranges supported). Default is to support all versions.
> 3. arch - indicates the reference is specific to a particular chip 
> architecture (x86 or x64).
> The "arch" attribute should result in a Condition="'$(Platform)'=='XXX" 
> attribute on the reference. The other attributes will impact which generated 
> jsproj files the reference is actually added to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-8381) Support platform alias "windows" during plugin installation

[Ashwin Desai (JIRA)]

Ashwin Desai created CB-8381:


 Summary: Support platform alias "windows" during plugin 
installation
 Key: CB-8381
 URL: https://issues.apache.org/jira/browse/CB-8381
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugman
Affects Versions: 0.22.11
 Environment: windows 8.1
Reporter: Ashwin Desai
Priority: Minor


Plugman version: 0.22.17

Using platform windows produces the following error. 
if platform = windows8, plugin is installed successfully. 

c:\tmp>plugman install --platform windows --project TestCordova --plugin 
c:\users\plugins\echo
Object # has no method 'help'





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8182) cordova run browser will serve app files over http

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297720#comment-14297720
 ] 

ASF GitHub Bot commented on CB-8182:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-browser/pull/9#issuecomment-72108752
  
Ideally, I think 'cordova serve' should become it's own module in npm 
(cordova-serve) which is used both by cordova-lib and by cordova-browser.



> cordova run browser will serve app files over http
> --
>
> Key: CB-8182
> URL: https://issues.apache.org/jira/browse/CB-8182
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Browser
>Reporter: Kirk Shoop
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8182) cordova run browser will serve app files over http

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297694#comment-14297694
 ] 

ASF GitHub Bot commented on CB-8182:


Github user kirkshoop commented on the pull request:

https://github.com/apache/cordova-browser/pull/9#issuecomment-72105849
  
@jsoref do you have a proposal for how `cordova run browser` should be 
structured?

initial options:
* separate implementation for separate scenario ``
* add a dependency on `cordova-lib` to reuse the `serve' implementation:
 * that would be a recursive dependency. `cordova-browser` would always 
have to depend on an earlier published `cordova-lib` which itself depended on 
an older `cordova-browser`
 * `cordova serve` serves all the platforms added to the project, not just 
`cordova-browser`.
* leave `cordova run browser` broken and use documentation to ask devs 
using the browser platform to use `cordova serve` and launch the browser 
manually instead of `cordova run browser`.
* ``


> cordova run browser will serve app files over http
> --
>
> Key: CB-8182
> URL: https://issues.apache.org/jira/browse/CB-8182
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Browser
>Reporter: Kirk Shoop
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-8380) Running 'cordova build --release --device' fails

[Jenny Gee (JIRA)]

Jenny Gee created CB-8380:
-

 Summary: Running 'cordova build --release --device' fails
 Key: CB-8380
 URL: https://issues.apache.org/jira/browse/CB-8380
 Project: Apache Cordova
  Issue Type: Bug
  Components: CLI, iOS
Affects Versions: 3.8.0
Reporter: Jenny Gee


When running 'cordova build --release --device', it fails with the following 
error:

{code}
Check dependencies

Code Sign error: No code signing identities found: No valid signing identities 
(i.e. certificate and private key pair) matching the team ID “(null)” were 
found.

warning: no rule to process file 
'/Users/gfxbbuser/TestProjects/iosTestXCode6/platforms/ios/iosTestXCode6/main.m'
 of type sourcecode.c.objc for architecture armv7 armv7s arm64

warning: no rule to process file 
'/Users/gfxbbuser/TestProjects/iosTestXCode6/platforms/ios/iosTestXCode6/Classes/AppDelegate.m'
 of type sourcecode.c.objc for architecture armv7 armv7s arm64

warning: no rule to process file 
'/Users/gfxbbuser/TestProjects/iosTestXCode6/platforms/ios/iosTestXCode6/Classes/MainViewController.m'
 of type sourcecode.c.objc for architecture armv7 armv7s arm64

CodeSign error: code signing is required for product type 'Application' in SDK 
'iOS 8.1'

** BUILD FAILED **
{code}


Environment found:


- Yosemite
- XCode6.1
- Certificates and Provisioning Profiles are all installed

First Build in Cordova 3.5.0
- No Problems. And app is signed

Then build in Cordova 4.2.0
- Error is above

Then built in Cordova 4.2.1-dev
- Same error above

In all cases, all I did was switch the version of cordova, and it's quite 
apparent to me that it can't find the proper signing identity. 

oh yes - In both the above cases, I even had an iPhone attached, just for kicks.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-8379) cordova --version should also tell you the cordova-lib version

[Andrew Grieve (JIRA)]

Andrew Grieve created CB-8379:
-

 Summary: cordova --version should also tell you the cordova-lib 
version
 Key: CB-8379
 URL: https://issues.apache.org/jira/browse/CB-8379
 Project: Apache Cordova
  Issue Type: Bug
  Components: CLI
Reporter: Andrew Grieve
Assignee: Andrew Grieve
Priority: Minor


cordova-lib version is generally more useful than cordova-cli version, so 
--version should tell you both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8227) Add --save option to 'cordova platform add'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297490#comment-14297490
 ] 

ASF GitHub Bot commented on CB-8227:


Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/144#issuecomment-72096263
  
working on fixing merge conflicts. will update this once that's done.


> Add --save option to 'cordova platform add'
> ---
>
> Key: CB-8227
> URL: https://issues.apache.org/jira/browse/CB-8227
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Reporter: Omar Mefire
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> When run with the --save flag, the 'platform add' command will not only add 
> the specified platforms, but it will also save them to config.xml.
> - When running this command, the pinned CLI version will be used if no 
> version is specified.
> - config.xml will be ovewritten if similar engine has already been specified 
> in config.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-8378) Delete LinearLayoutSoftKeyboardDetect for 4.0.x

[Andrew Grieve (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Grieve resolved CB-8378.
---
Resolution: Fixed

Deleted in cordova-android@4.0.0-dev

> Delete LinearLayoutSoftKeyboardDetect for 4.0.x
> ---
>
> Key: CB-8378
> URL: https://issues.apache.org/jira/browse/CB-8378
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> Conversation here: http://markmail.org/thread/a36bg2kux6rssmnt
> TLDR - We've never documented the events it fires, there are bugs with it, 
> and there's a 3rd party plugin that serves the same purpose 
> (https://github.com/driftyco/ionic-plugins-keyboard/blob/master/src/android/IonicKeyboard.java)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8378) Delete LinearLayoutSoftKeyboardDetect for 4.0.x

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297481#comment-14297481
 ] 

ASF subversion and git services commented on CB-8378:
-

Commit 37617c67f85179145f78e00de071b9f5171e8938 in cordova-android's branch 
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=37617c6 ]

CB-8378 Delete LinearLayoutSoftKeyboardDetect (hidekeyboard and showkeyboard 
events)


> Delete LinearLayoutSoftKeyboardDetect for 4.0.x
> ---
>
> Key: CB-8378
> URL: https://issues.apache.org/jira/browse/CB-8378
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> Conversation here: http://markmail.org/thread/a36bg2kux6rssmnt
> TLDR - We've never documented the events it fires, there are bugs with it, 
> and there's a 3rd party plugin that serves the same purpose 
> (https://github.com/driftyco/ionic-plugins-keyboard/blob/master/src/android/IonicKeyboard.java)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8378) Delete LinearLayoutSoftKeyboardDetect for 4.0.x

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297479#comment-14297479
 ] 

ASF subversion and git services commented on CB-8378:
-

Commit fc4db9145934bd0053161cbf9ffc0caf83b770c6 in cordova-js's branch 
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=fc4db91 ]

CB-8378 android: Deleted hidekeyboard & showkeyboard events


> Delete LinearLayoutSoftKeyboardDetect for 4.0.x
> ---
>
> Key: CB-8378
> URL: https://issues.apache.org/jira/browse/CB-8378
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> Conversation here: http://markmail.org/thread/a36bg2kux6rssmnt
> TLDR - We've never documented the events it fires, there are bugs with it, 
> and there's a 3rd party plugin that serves the same purpose 
> (https://github.com/driftyco/ionic-plugins-keyboard/blob/master/src/android/IonicKeyboard.java)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297478#comment-14297478
 ] 

ASF GitHub Bot commented on CB-8123:


Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/155#discussion_r23798529
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -0,0 +1,415 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+var windows = require('../../src/plugman/platforms/windows'),
+common = require('../../src/plugman/platforms/common'),
+install = require('../../src/plugman/install'),
+path = require('path'),
+fs = require('fs'),
+shell = require('shelljs'),
+et = require('elementtree'),
+os = require('osenv'),
+cordovaProjectDir = path.join(os.tmpdir(), 'plugman'),
+cordovaProjectWindowsPlatformDir = path.join(cordovaProjectDir, 
'platforms', 'windows'),
+cordovaProjectPluginsDir = path.join(cordovaProjectDir, 'plugins'),
+xml_helpers = require('../../src/util/xml-helpers'),
+dummyplugin = path.join(__dirname, '..', 'plugins', 
'org.test.plugins.dummyplugin'),
+faultyplugin = path.join(__dirname, '..', 'plugins', 
'org.test.plugins.faultyplugin');
+
+var PluginInfo = require('../../src/PluginInfo');
+
+var dummyPluginInfo = new PluginInfo(dummyplugin);
+var dummy_id = dummyPluginInfo.id;
+var valid_source = dummyPluginInfo.getSourceFiles('windows');
+var valid_libfiles = dummyPluginInfo.getLibFiles('windows');
+var valid_frameworks = dummyPluginInfo.getFrameworks('windows');
+
+var faultyPluginInfo = new PluginInfo(faultyplugin);
+var faulty_id = faultyPluginInfo.id;
+var invalid_source = faultyPluginInfo.getSourceFiles('windows');
+var invalid_libfiles = faultyPluginInfo.getLibFiles('windows');
+
+function copyArray(arr) {
+return Array.prototype.slice.call(arr, 0);
+}
+
+beforeEach(function () {
+this.addMatchers({
+toContainXmlPath: function (xpath) {
+var xml = this.actual;
+var notText = this.isNot ? 'not ' : '';
+this.message = function () {
+return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
+};
+
+return xml.find(xpath) != null;
+}});
+});
+
+['windows', 'windows8'].forEach(function (platform) {
+var windows_project = path.join(__dirname, '..', 'projects', platform);
+
+shell.mkdir('-p', cordovaProjectWindowsPlatformDir);
+shell.cp('-rf', path.join(windows_project, '*'), 
cordovaProjectWindowsPlatformDir);
+var proj_files = 
windows.parseProjectFile(cordovaProjectWindowsPlatformDir);
+shell.rm('-rf', cordovaProjectDir);
+
+var platformProjects = {
+windows: {
+all: 'CordovaApp.projitems',
+phone: 'CordovaApp.Phone.jsproj',
+windows: 'CordovaApp.Windows.jsproj',
+windows8: 'CordovaApp.Windows80.jsproj'
+}, windows8: {
+all: 'TestApp.jsproj',
+windows8: 'TestApp.jsproj'
+}
+}[platform];
+
+describe(platform + ' project handler', function () {
+beforeEach(function () {
+shell.mkdir('-p', cordovaProjectWindowsPlatformDir);
+shell.mkdir('-p', cordovaProjectPluginsDir);
+});
+afterEach(function () {
+shell.rm('-rf', cordovaProjectDir);
+});
+
+describe('www_dir method', function () {
+it('should return cordova-windows project www location using 
www_dir', function () {
+expect(windows.www_dir(path.sep)).toEqual(path.sep + 
'www');
+});
+});
+describe('package_name method', function () {
+it('shoul

[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297474#comment-14297474
 ] 

ASF GitHub Bot commented on CB-8123:


Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/155#discussion_r23798388
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -0,0 +1,415 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+var windows = require('../../src/plugman/platforms/windows'),
+common = require('../../src/plugman/platforms/common'),
+install = require('../../src/plugman/install'),
+path = require('path'),
+fs = require('fs'),
+shell = require('shelljs'),
+et = require('elementtree'),
+os = require('osenv'),
+cordovaProjectDir = path.join(os.tmpdir(), 'plugman'),
+cordovaProjectWindowsPlatformDir = path.join(cordovaProjectDir, 
'platforms', 'windows'),
+cordovaProjectPluginsDir = path.join(cordovaProjectDir, 'plugins'),
+xml_helpers = require('../../src/util/xml-helpers'),
+dummyplugin = path.join(__dirname, '..', 'plugins', 
'org.test.plugins.dummyplugin'),
+faultyplugin = path.join(__dirname, '..', 'plugins', 
'org.test.plugins.faultyplugin');
+
+var PluginInfo = require('../../src/PluginInfo');
+
+var dummyPluginInfo = new PluginInfo(dummyplugin);
+var dummy_id = dummyPluginInfo.id;
+var valid_source = dummyPluginInfo.getSourceFiles('windows');
+var valid_libfiles = dummyPluginInfo.getLibFiles('windows');
+var valid_frameworks = dummyPluginInfo.getFrameworks('windows');
+
+var faultyPluginInfo = new PluginInfo(faultyplugin);
+var faulty_id = faultyPluginInfo.id;
+var invalid_source = faultyPluginInfo.getSourceFiles('windows');
+var invalid_libfiles = faultyPluginInfo.getLibFiles('windows');
+
+function copyArray(arr) {
+return Array.prototype.slice.call(arr, 0);
+}
+
+beforeEach(function () {
+this.addMatchers({
+toContainXmlPath: function (xpath) {
+var xml = this.actual;
+var notText = this.isNot ? 'not ' : '';
+this.message = function () {
+return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
+};
+
+return xml.find(xpath) != null;
+}});
+});
+
+['windows', 'windows8'].forEach(function (platform) {
+var windows_project = path.join(__dirname, '..', 'projects', platform);
+
+shell.mkdir('-p', cordovaProjectWindowsPlatformDir);
+shell.cp('-rf', path.join(windows_project, '*'), 
cordovaProjectWindowsPlatformDir);
+var proj_files = 
windows.parseProjectFile(cordovaProjectWindowsPlatformDir);
+shell.rm('-rf', cordovaProjectDir);
+
+var platformProjects = {
+windows: {
+all: 'CordovaApp.projitems',
+phone: 'CordovaApp.Phone.jsproj',
+windows: 'CordovaApp.Windows.jsproj',
+windows8: 'CordovaApp.Windows80.jsproj'
+}, windows8: {
+all: 'TestApp.jsproj',
+windows8: 'TestApp.jsproj'
+}
+}[platform];
+
+describe(platform + ' project handler', function () {
+beforeEach(function () {
+shell.mkdir('-p', cordovaProjectWindowsPlatformDir);
+shell.mkdir('-p', cordovaProjectPluginsDir);
+});
+afterEach(function () {
+shell.rm('-rf', cordovaProjectDir);
+});
+
+describe('www_dir method', function () {
+it('should return cordova-windows project www location using 
www_dir', function () {
+expect(windows.www_dir(path.sep)).toEqual(path.sep + 
'www');
+});
+});
+describe('package_name method', function () {
+it('shoul

[jira] [Created] (CB-8378) Delete LinearLayoutSoftKeyboardDetect for 4.0.x

[Andrew Grieve (JIRA)]

Andrew Grieve created CB-8378:
-

 Summary: Delete LinearLayoutSoftKeyboardDetect for 4.0.x
 Key: CB-8378
 URL: https://issues.apache.org/jira/browse/CB-8378
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Reporter: Andrew Grieve
Assignee: Andrew Grieve
Priority: Minor


Conversation here: http://markmail.org/thread/a36bg2kux6rssmnt

TLDR - We've never documented the events it fires, there are bugs with it, and 
there's a 3rd party plugin that serves the same purpose 
(https://github.com/driftyco/ionic-plugins-keyboard/blob/master/src/android/IonicKeyboard.java)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-8377) tag in Plugin.xml aren't parsed properly

[Andrew Grieve (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Grieve resolved CB-8377.
---
Resolution: Fixed

Fix is in. Was a regression caused by 15adc1b9fcc069438.

>  tag in Plugin.xml aren't parsed properly
> ---
>
> Key: CB-8377
> URL: https://issues.apache.org/jira/browse/CB-8377
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
>Reporter: Alexander Sorokin
>Priority: Critical
>
> With the example of mobile-spec on windows:
> 1. cordova-mobile-spec/createmobilespec/createmobilespec.cmd --windows 
> mobilespec
> 2. go to \mobilespec\platforms\windows\www and open cordova_plugins.js
> Expected result
> there must be a section with "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy",
> "runs": true
> },
> {code}
> Actual result
> There is a section without "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy"
> },
> {code}
> This indicates that globalization plugin's Plugin.xml was not parsed properly:
> {code:title=Plugin.xml|borderStyle=solid}
> 
> 
>  name="GlobalizationProxy">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8377) tag in Plugin.xml aren't parsed properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297435#comment-14297435
 ] 

ASF GitHub Bot commented on CB-8377:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/156


>  tag in Plugin.xml aren't parsed properly
> ---
>
> Key: CB-8377
> URL: https://issues.apache.org/jira/browse/CB-8377
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
>Reporter: Alexander Sorokin
>Priority: Critical
>
> With the example of mobile-spec on windows:
> 1. cordova-mobile-spec/createmobilespec/createmobilespec.cmd --windows 
> mobilespec
> 2. go to \mobilespec\platforms\windows\www and open cordova_plugins.js
> Expected result
> there must be a section with "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy",
> "runs": true
> },
> {code}
> Actual result
> There is a section without "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy"
> },
> {code}
> This indicates that globalization plugin's Plugin.xml was not parsed properly:
> {code:title=Plugin.xml|borderStyle=solid}
> 
> 
>  name="GlobalizationProxy">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8377) tag in Plugin.xml aren't parsed properly

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297434#comment-14297434
 ] 

ASF subversion and git services commented on CB-8377:
-

Commit 51d422f9111849c2cc24b3f09e2214673f625acf in cordova-lib's branch 
refs/heads/master from [~alsorokin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=51d422f ]

CB-8377 Fixed  tag parsing (close #156)

Was broken by a recent commit (was never released)


>  tag in Plugin.xml aren't parsed properly
> ---
>
> Key: CB-8377
> URL: https://issues.apache.org/jira/browse/CB-8377
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
>Reporter: Alexander Sorokin
>Priority: Critical
>
> With the example of mobile-spec on windows:
> 1. cordova-mobile-spec/createmobilespec/createmobilespec.cmd --windows 
> mobilespec
> 2. go to \mobilespec\platforms\windows\www and open cordova_plugins.js
> Expected result
> there must be a section with "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy",
> "runs": true
> },
> {code}
> Actual result
> There is a section without "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy"
> },
> {code}
> This indicates that globalization plugin's Plugin.xml was not parsed properly:
> {code:title=Plugin.xml|borderStyle=solid}
> 
> 
>  name="GlobalizationProxy">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8367) [org.apache.cordova.dialogs] Add Prompt support on Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297395#comment-14297395
 ] 

ASF GitHub Bot commented on CB-8367:


GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-plugin-dialogs/pull/47

CB-8367 [org.apache.cordova.dialogs] Add Prompt support on Windows

https://issues.apache.org/jira/browse/CB-8367

Adds simple html-based prompt dialog on Windows to bridge this api gap.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-dialogs CB-8367

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-dialogs/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit 9105e851a8e132b4762a1882614b24ab074b4819
Author: sgrebnov 
Date:   2015-01-29T19:18:16Z

CB-8367 [org.apache.cordova.dialogs] Add Prompt support on Windows




> [org.apache.cordova.dialogs] Add Prompt support on Windows
> --
>
> Key: CB-8367
> URL: https://issues.apache.org/jira/browse/CB-8367
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Dialogs
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
>Priority: Minor
>  Labels: cordova-plugin-dialogs, windows
>
> Prompt method is not currently supported on Windows. There is no such native 
> api, but we could add html-based popup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8227) Add --save option to 'cordova platform add'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297389#comment-14297389
 ] 

ASF GitHub Bot commented on CB-8227:


Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/203#discussion_r23794326
  
--- Diff: src/cli.js ---
@@ -286,6 +286,7 @@ function cli(inputArgs) {
 , cli_variables : cli_vars
 , browserify: args.browserify || false
 , link: args.link || false
+   , save: args.save || false
--- End diff --

offhand, this looks unaligned


> Add --save option to 'cordova platform add'
> ---
>
> Key: CB-8227
> URL: https://issues.apache.org/jira/browse/CB-8227
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Reporter: Omar Mefire
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> When run with the --save flag, the 'platform add' command will not only add 
> the specified platforms, but it will also save them to config.xml.
> - When running this command, the pinned CLI version will be used if no 
> version is specified.
> - config.xml will be ovewritten if similar engine has already been specified 
> in config.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297337#comment-14297337
 ] 

ASF GitHub Bot commented on CB-4614:


Github user jsoref commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72081856
  
The first line of your commit message isn't in the right form.

Also, please use `git rebase -i` and you should `fold` your commits into a 
single commit.


> Contact.save and Contact.remove - method signatures not documented
> --
>
> Key: CB-4614
> URL: https://issues.apache.org/jira/browse/CB-4614
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs, Plugin Contacts
>Affects Versions: 2.9.0
>Reporter: Peter
>Assignee: Michael Brooks
>Priority: Minor
>
> The method signatures for Contact methods *save* and *remove* are not 
> documented. Only in the examples can you see that they have parameters for 
> onSuccess and onError callbacks.
> Ref 
> http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8377) tag in Plugin.xml aren't parsed properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297108#comment-14297108
 ] 

ASF GitHub Bot commented on CB-8377:


GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-lib/pull/156

CB-8377 Fixed  tag parsing

This fixes https://issues.apache.org/jira/browse/CB-8377

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-8377

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #156


commit 3690ed5f7776a80a24a385dd795d71c19599010a
Author: alsorokin 
Date:   2015-01-29T12:16:40Z

CB-8377 Fixed  tag parsing




>  tag in Plugin.xml aren't parsed properly
> ---
>
> Key: CB-8377
> URL: https://issues.apache.org/jira/browse/CB-8377
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
>Reporter: Alexander Sorokin
>Priority: Critical
>
> With the example of mobile-spec on windows:
> 1. cordova-mobile-spec/createmobilespec/createmobilespec.cmd --windows 
> mobilespec
> 2. go to \mobilespec\platforms\windows\www and open cordova_plugins.js
> Expected result
> there must be a section with "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy",
> "runs": true
> },
> {code}
> Actual result
> There is a section without "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy"
> },
> {code}
> This indicates that globalization plugin's Plugin.xml was not parsed properly:
> {code:title=Plugin.xml|borderStyle=solid}
> 
> 
>  name="GlobalizationProxy">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297058#comment-14297058
 ] 

ASF GitHub Bot commented on CB-4614:


Github user jsoref commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72050202
  
@svkirans: please use `git commit --amend` and fix your commit message to 
match the style.


> Contact.save and Contact.remove - method signatures not documented
> --
>
> Key: CB-4614
> URL: https://issues.apache.org/jira/browse/CB-4614
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs, Plugin Contacts
>Affects Versions: 2.9.0
>Reporter: Peter
>Assignee: Michael Brooks
>Priority: Minor
>
> The method signatures for Contact methods *save* and *remove* are not 
> documented. Only in the examples can you see that they have parameters for 
> onSuccess and onError callbacks.
> Ref 
> http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297048#comment-14297048
 ] 

ASF GitHub Bot commented on CB-4614:


Github user svkirans commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72048606
  
Added documentation for remove and save functions in contact.


> Contact.save and Contact.remove - method signatures not documented
> --
>
> Key: CB-4614
> URL: https://issues.apache.org/jira/browse/CB-4614
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs, Plugin Contacts
>Affects Versions: 2.9.0
>Reporter: Peter
>Assignee: Michael Brooks
>Priority: Minor
>
> The method signatures for Contact methods *save* and *remove* are not 
> documented. Only in the examples can you see that they have parameters for 
> onSuccess and onError callbacks.
> Ref 
> http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297042#comment-14297042
 ] 

ASF GitHub Bot commented on CB-4614:


Github user jsoref commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72047729
  
Please see 
http://wiki.apache.org/cordova/IssueWorkflow#About_Commit_Messages


> Contact.save and Contact.remove - method signatures not documented
> --
>
> Key: CB-4614
> URL: https://issues.apache.org/jira/browse/CB-4614
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs, Plugin Contacts
>Affects Versions: 2.9.0
>Reporter: Peter
>Assignee: Michael Brooks
>Priority: Minor
>
> The method signatures for Contact methods *save* and *remove* are not 
> documented. Only in the examples can you see that they have parameters for 
> onSuccess and onError callbacks.
> Ref 
> http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297035#comment-14297035
 ] 

ASF GitHub Bot commented on CB-4614:


GitHub user svkirans opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/54

Fix for CB-4614

Fix for CB-4614

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svkirans/cordova-plugin-contacts CB-4614

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit e47ede740e3d9f01428e1141319eb1e1154527b6
Author: Kiran 
Date:   2015-01-29T15:46:36Z

Fix for CB-4614




> Contact.save and Contact.remove - method signatures not documented
> --
>
> Key: CB-4614
> URL: https://issues.apache.org/jira/browse/CB-4614
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs, Plugin Contacts
>Affects Versions: 2.9.0
>Reporter: Peter
>Assignee: Michael Brooks
>Priority: Minor
>
> The method signatures for Contact methods *save* and *remove* are not 
> documented. Only in the examples can you see that they have parameters for 
> onSuccess and onError callbacks.
> Ref 
> http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297026#comment-14297026
 ] 

ASF GitHub Bot commented on CB-5059:


Github user agrieve commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/60#discussion_r23775743
  
--- Diff: src/android/FileTransfer.java ---
@@ -316,7 +317,23 @@ public void run() {
 conn.setRequestProperty("Content-Type", 
"multipart/form-data; boundary=" + BOUNDARY);
 
 // Set the cookies on the response
-String cookie = 
CookieManager.getInstance().getCookie(target);
+boolean gotCookie = false;
+String cookie = null;
+Class webViewClass = webView.getClass();
+try {
+Method gcm = 
webViewClass.getMethod("getCookieManager");
+ICordovaCookieManager cm = 
(ICordovaCookieManager)gcm.invoke(webView);
--- End diff --

We'll need to make the code just a little be more complicated and hard to 
read still, since pre-4.0.0 cordova-android users will get a compile error 
looking for the ICordovaCookieManager symbol :(


> The android implementation of file transfer plugin should not depend on the 
> concrete class android.webkit.CookieManager
> ---
>
> Key: CB-5059
> URL: https://issues.apache.org/jira/browse/CB-5059
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: Master
> Environment: cordova-android, git branch 3.0.x
>Reporter: Junmin
> Fix For: Master
>
>
> The android implementation of file transfer plugin leverages the class 
> android.webkit.CookieManager, which depends on the concrete web 
> infrastructure android.webkit.WebView. This dependence ruins the portability 
> of the plugin. For example, it could not run on a substantial implementation 
> of CordovaWebView which based on a android third party component(such as 
> chromium for android).
> Following is the crash log when initializing the CookieManager without 
> android.webkit.WebView:
> I/dalvikvm(5006): java.lang.IllegalStateException: Call 
> CookieSyncManager::createInstance() or create a webview before using this 
> class
> I/dalvikvm(5006):   at 
> android.webkit.JniUtil.checkInitialized(JniUtil.java:44)
> I/dalvikvm(5006):   at 
> android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.nativeGetCookie(Native Method)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109)
> I/dalvikvm(5006):   at 
> android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96)
> I/dalvikvm(5006):   at 
> org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5696) Missing Plugin source file on iOS

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296983#comment-14296983
 ] 

ASF subversion and git services commented on CB-5696:
-

Commit 6fd8e23fda5658d5c8d43ecfb6016edb6f713265 in cordova-lib's branch 
refs/heads/master from Dimitar Kerezov
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=6fd8e23 ]

CB-5696 find ios project directory using the xcode project file (close #151)

Add unit tests for future reassurance
Fix incorrect name "ChildApp" in .pbxproj files to "SampleApp"


> Missing Plugin source file on iOS
> -
>
> Key: CB-5696
> URL: https://issues.apache.org/jira/browse/CB-5696
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugman
>Affects Versions: 3.3.0
> Environment: Mac OSX 10.9, plugman 0.17.0, cordova 3.3.0-0.1.1, xcode 
> 5
>Reporter: xu.li
>  Labels: build, patch
>
> Bug
> 
> 1. cordova create cordova-issue com.example.cordova.issue cordova-issue
> 2. cd cordova-issue/ && cordova platform add ios && cordova build && cordova 
> plugin add org.apache.cordova.device
> 3. Open the project in xcode5, and you will find CDVDevice.h and CDVDevice.m 
> are missing.
> Reason
> 
> It is caused by [cordova-plugman.git] / src / platforms / ios.js.
> In the parseProjectFile function, it searches for "config.xml" using 
> "glob.sync", and then filter the file path list, and then use the first file 
> in the remaining list.
> When the name of the project, 3rd parameter in the "cordova create" command, 
> starts with a lowercased letter after "b", it will not be list as the first 
> item among all the candidates, and the "**/build/**"-like file paths are not 
> filtered out.
> Quick Fix
> 
> Filter all the file candidates contain "/build/".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5696) Missing Plugin source file on iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296984#comment-14296984
 ] 

ASF GitHub Bot commented on CB-5696:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/151


> Missing Plugin source file on iOS
> -
>
> Key: CB-5696
> URL: https://issues.apache.org/jira/browse/CB-5696
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugman
>Affects Versions: 3.3.0
> Environment: Mac OSX 10.9, plugman 0.17.0, cordova 3.3.0-0.1.1, xcode 
> 5
>Reporter: xu.li
>  Labels: build, patch
>
> Bug
> 
> 1. cordova create cordova-issue com.example.cordova.issue cordova-issue
> 2. cd cordova-issue/ && cordova platform add ios && cordova build && cordova 
> plugin add org.apache.cordova.device
> 3. Open the project in xcode5, and you will find CDVDevice.h and CDVDevice.m 
> are missing.
> Reason
> 
> It is caused by [cordova-plugman.git] / src / platforms / ios.js.
> In the parseProjectFile function, it searches for "config.xml" using 
> "glob.sync", and then filter the file path list, and then use the first file 
> in the remaining list.
> When the name of the project, 3rd parameter in the "cordova create" command, 
> starts with a lowercased letter after "b", it will not be list as the first 
> item among all the candidates, and the "**/build/**"-like file paths are not 
> filtered out.
> Quick Fix
> 
> Filter all the file candidates contain "/build/".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8377) tag in Plugin.xml aren't parsed properly

[Alexander Sorokin (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296937#comment-14296937
 ] 

Alexander Sorokin commented on CB-8377:
---

I'll send a PR for this tomorrow.

>  tag in Plugin.xml aren't parsed properly
> ---
>
> Key: CB-8377
> URL: https://issues.apache.org/jira/browse/CB-8377
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
>Reporter: Alexander Sorokin
>Priority: Critical
>
> With the example of mobile-spec on windows:
> 1. cordova-mobile-spec/createmobilespec/createmobilespec.cmd --windows 
> mobilespec
> 2. go to \mobilespec\platforms\windows\www and open cordova_plugins.js
> Expected result
> there must be a section with "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy",
> "runs": true
> },
> {code}
> Actual result
> There is a section without "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
> {
> "file": 
> "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
> "id": "org.apache.cordova.globalization.GlobalizationProxy"
> },
> {code}
> This indicates that globalization plugin's Plugin.xml was not parsed properly:
> {code:title=Plugin.xml|borderStyle=solid}
> 
> 
>  name="GlobalizationProxy">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-8377) tag in Plugin.xml aren't parsed properly

[Alexander Sorokin (JIRA)]

Alexander Sorokin created CB-8377:
-

 Summary:  tag in Plugin.xml aren't parsed properly
 Key: CB-8377
 URL: https://issues.apache.org/jira/browse/CB-8377
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Affects Versions: Master
Reporter: Alexander Sorokin
Priority: Critical


With the example of mobile-spec on windows:

1. cordova-mobile-spec/createmobilespec/createmobilespec.cmd --windows 
mobilespec
2. go to \mobilespec\platforms\windows\www and open cordova_plugins.js

Expected result
there must be a section with "runs" element
{code:title=cordova_plugins.js|borderStyle=solid}
{
"file": 
"plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
"id": "org.apache.cordova.globalization.GlobalizationProxy",
"runs": true
},
{code}
Actual result
There is a section without "runs" element
{code:title=cordova_plugins.js|borderStyle=solid}
{
"file": 
"plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
"id": "org.apache.cordova.globalization.GlobalizationProxy"
},
{code}
This indicates that globalization plugin's Plugin.xml was not parsed properly:

{code:title=Plugin.xml|borderStyle=solid}







{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org