[jira] [Created] (CB-8391) Adding device plugin to project leads to build failure on ios
Omar Mefire created CB-8391: --- Summary: Adding device plugin to project leads to build failure on ios Key: CB-8391 URL: https://issues.apache.org/jira/browse/CB-8391 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.7.0 Reporter: Omar Mefire Priority: Critical - create cordova project using Visual Studio - add new platform: ios - setup remote agent on Mac OS X - start remote debugging on Mac OS X via Visual Studio The build fails with the following error messages : "The following build commands failed: CompileC build/wkwebview_tests.build/Debug-iphonesimulator/wkwebview_tests.build/Objects-normal/i386/CDVDevice.o wkwebview_tests/Plug\ ins/org.apache.cordova.device/CDVDevice.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Command finished with error code 65: /Users/mm/remote-builds/builds/94550/cordovaApp/platforms/ios/cordova/build --debug ERROR building one of the platforms: Error: /Users/mm/remote-builds/builds/94550/cordovaApp/platforms/ios/cordova/build: Command failed with \ exit code 65 You may not have the required environment or OS to build this project Fri Jan 30 2015 13:48:44 GMT-0800 (PST) Done building 94550 Fri Jan 30 2015 13:48:44 GMT-0800 (PST) Finished building Cordova app" -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-5536) Use Unicode arrows instead of greater than / less than symbols to indicate back and forward buttons
[
https://issues.apache.org/jira/browse/CB-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Chase resolved CB-5536.
-
Resolution: Implemented
> Use Unicode arrows instead of greater than / less than symbols to indicate
> back and forward buttons
> ---
>
> Key: CB-5536
> URL: https://issues.apache.org/jira/browse/CB-5536
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin InAppBrowser
>Affects Versions: 3.1.0
> Environment: Android (possibly others)
>Reporter: Oliver Moran
>Priority: Trivial
>
> The plugin currently represents navigate back and navigate forward buttons
> with less than or equal to signs (< and >).
> These actions could be represented more attractively (and more appropriately)
> using Unicode arrows symbols:
> https://en.wikipedia.org/wiki/Arrow_(symbol)#Arrows_in_Unicode
> Code sample in Android:
> back.setText("\u21e6"); // ⇦
> forward.setText("\u21e8"); // ⇨
> .. or ...
> back.setText("\u2190"); // ←
> forward.setText("\u2192"); // →
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8388) Windows mobilespec test app crashes on unhandled javascript exception
[ https://issues.apache.org/jira/browse/CB-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299211#comment-14299211 ] ASF GitHub Bot commented on CB-8388: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/9 > Windows mobilespec test app crashes on unhandled javascript exception > - > > Key: CB-8388 > URL: https://issues.apache.org/jira/browse/CB-8388 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 3.7.0 >Reporter: Nikhil Khandelwal >Priority: Minor > > This prevents from getting results when 1 test fails with an unhandled > exception. The idea is to 'handle' the unhandled exception and prevent the > test from crashing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8388) Windows mobilespec test app crashes on unhandled javascript exception
[ https://issues.apache.org/jira/browse/CB-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299210#comment-14299210 ] ASF subversion and git services commented on CB-8388: - Commit 84382143d095ca85e0332708dbe8682f0bfbd6c1 in cordova-plugin-test-framework's branch refs/heads/master from [~nikhilkh] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=8438214 ] CB-8388 Prevent Windows app from crashing on test failure github: close #9 > Windows mobilespec test app crashes on unhandled javascript exception > - > > Key: CB-8388 > URL: https://issues.apache.org/jira/browse/CB-8388 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 3.7.0 >Reporter: Nikhil Khandelwal >Priority: Minor > > This prevents from getting results when 1 test fails with an unhandled > exception. The idea is to 'handle' the unhandled exception and prevent the > test from crashing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse MacFadyen resolved CB-8384.
-
Resolution: Fixed
Merged! Thanks [~sgrebnov]
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> 1. There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
> 2. Current implementation does not track connection status changed event.
> This could be added via NetworkInformation.NetworkStatusChanged
> (https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299133#comment-14299133
]
ASF subversion and git services commented on CB-8384:
-
Commit d8a714757fae0ac615224a7a0daabaa88c8e2581 in
cordova-plugin-network-information's branch refs/heads/master from sgrebnov
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=d8a7147
]
CB-8384 Fixes the way we detect online status on Windows
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> 1. There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
> 2. Current implementation does not track connection status changed event.
> This could be added via NetworkInformation.NetworkStatusChanged
> (https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299131#comment-14299131
]
ASF subversion and git services commented on CB-8384:
-
Commit fb608698e5c97e18da8bb1d6f73621bb3676ebfe in
cordova-plugin-network-information's branch refs/heads/master from sgrebnov
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=fb60869
]
CB-8384 Add Windows section to Network Information plugin
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> 1. There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
> 2. Current implementation does not track connection status changed event.
> This could be added via NetworkInformation.NetworkStatusChanged
> (https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299134#comment-14299134
]
ASF subversion and git services commented on CB-8384:
-
Commit 9710603feb6a458314145bfc4c4814657b16346a in
cordova-plugin-network-information's branch refs/heads/master from sgrebnov
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=9710603
]
CB-8384 Network status change support on Windows
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> 1. There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
> 2. Current implementation does not track connection status changed event.
> This could be added via NetworkInformation.NetworkStatusChanged
> (https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299135#comment-14299135
]
ASF GitHub Bot commented on CB-8384:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/24
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> 1. There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
> 2. Current implementation does not track connection status changed event.
> This could be added via NetworkInformation.NetworkStatusChanged
> (https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299132#comment-14299132
]
ASF subversion and git services commented on CB-8384:
-
Commit c8281535160a547a367b7c820360e711c59d4cc9 in
cordova-plugin-network-information's branch refs/heads/master from sgrebnov
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=c828153
]
CB-8384 Add Windows platform quirks
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> 1. There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
> 2. Current implementation does not track connection status changed event.
> This could be added via NetworkInformation.NetworkStatusChanged
> (https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8388) Windows mobilespec test app crashes on unhandled javascript exception
[ https://issues.apache.org/jira/browse/CB-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299121#comment-14299121 ] ASF GitHub Bot commented on CB-8388: GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/9 CB-8388 Prevent Windows app from crashing on test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8388 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 395d3458a45b162a5aa0278d7fd4d2b322a1ad51 Author: Nikhil Khandelwal Date: 2015-01-30T16:42:32Z CB-8388 Prevent Windows app from crashing on test failure > Windows mobilespec test app crashes on unhandled javascript exception > - > > Key: CB-8388 > URL: https://issues.apache.org/jira/browse/CB-8388 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 3.7.0 >Reporter: Nikhil Khandelwal >Priority: Minor > > This prevents from getting results when 1 test fails with an unhandled > exception. The idea is to 'handle' the unhandled exception and prevent the > test from crashing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8390) broken for gradle projects
Andrew Grieve created CB-8390:
-
Summary: broken for gradle projects
Key: CB-8390
URL: https://issues.apache.org/jira/browse/CB-8390
Project: Apache Cordova
Issue Type: Bug
Components: Android, CordovaLib
Reporter: Andrew Grieve
Assignee: Andrew Grieve
Priority: Minor
{code}
{code}
allows referencing of android support libraries and play services, which live
within the user's SDK directory.
https://developer.android.com/tools/support-library/features.html
There is currently ANT-specific logic within plugman to handle them, and they
don't work at all for gradle projects.
https://github.com/apache/cordova-lib/blob/e05c656ef3d77d6c5e9232ed4e6ddbd3e29654eb/cordova-lib/src/plugman/platforms/android.js#L118
(note the use of local.properties)
Some example tags:
{code}
{code}
Currently (for ANT), these libraries were added as sub-projects using the path
to them within the SDK directory. For gradle, we should be added them via:
{code}
dependencies {
compile 'com.android.support:support-v4:21.0.+'
compile 'com.android.support:support-v13:18.0.+'
compile 'com.google.android.gms:play-services:6.5.87'
}
{code}
Proposed change:
Look for `src` in the form of `extras/android/support/v4` and map that to
`com.android.support:support-v4`. Just use a hardcoded lookup table, as this is
just for backwards compat.
Add support for `src` in the form of `com.android.support:support-v4`, and add
these to the project.properties file, in the same way that we do for
subprojects and gradleReference frameworks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8389) pluginManager.postMessage() Should allow plugins first dibs at messages rather than CordovaInterface
[ https://issues.apache.org/jira/browse/CB-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-8389. --- Resolution: Fixed Fixed in 4.0.0-dev > pluginManager.postMessage() Should allow plugins first dibs at messages > rather than CordovaInterface > > > Key: CB-8389 > URL: https://issues.apache.org/jira/browse/CB-8389 > Project: Apache Cordova > Issue Type: Bug >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > This isn't really that obvious, but it makes more sense when you look at the > two events handled by CordovaActivity: > - exit (finish()es the app) > - onReceiveError (likewise) > These events cannot be handled by plugins, because the activity gets to them > first. I'd like to write a plugin for "developer mode", where onReceiveError > happens quite a bit, and I need the plugin to be able to catch this case > rather than finish the activity. > Giving plugins first dibs at messages actually doesn't preclude an activity > from having first dibs either. The activity just needs to register their own > plugin to do so (which is trivial). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8224) 'Cordova run browser' should support other browsers
[ https://issues.apache.org/jira/browse/CB-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298875#comment-14298875 ] ASF GitHub Bot commented on CB-8224: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-browser/pull/8#issuecomment-72233705 @stevengill I noticed you have made some changes in this area. Wondering if you can help review this? > 'Cordova run browser' should support other browsers > --- > > Key: CB-8224 > URL: https://issues.apache.org/jira/browse/CB-8224 > Project: Apache Cordova > Issue Type: Task > Components: Browser >Reporter: Nikhil Khandelwal > > Currently, cordova run browser only supports launching Chrome. To make > 'browser' a production browser deployment platform - support for multiple > browsers is expected. > Cordova run browser should launch the default browser on the machine. This > can be overridden by a user by explicitly specifying a browser to run with > --target flag. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8389) pluginManager.postMessage() Should allow plugins first dibs at messages rather than CordovaInterface
[ https://issues.apache.org/jira/browse/CB-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298869#comment-14298869 ] ASF subversion and git services commented on CB-8389: - Commit 26ee1c4547933955f2719530d7b42ffef0119f20 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=26ee1c4 ] CB-8389 Allow plugins to handle exit and onReceivedError messages before CordovaInterface Also switches to LinkedHashMap for plugins so that activity can insert a plugin and have it be the first one to receive messages > pluginManager.postMessage() Should allow plugins first dibs at messages > rather than CordovaInterface > > > Key: CB-8389 > URL: https://issues.apache.org/jira/browse/CB-8389 > Project: Apache Cordova > Issue Type: Bug >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > This isn't really that obvious, but it makes more sense when you look at the > two events handled by CordovaActivity: > - exit (finish()es the app) > - onReceiveError (likewise) > These events cannot be handled by plugins, because the activity gets to them > first. I'd like to write a plugin for "developer mode", where onReceiveError > happens quite a bit, and I need the plugin to be able to catch this case > rather than finish the activity. > Giving plugins first dibs at messages actually doesn't preclude an activity > from having first dibs either. The activity just needs to register their own > plugin to do so (which is trivial). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8389) pluginManager.postMessage() Should allow plugins first dibs at messages rather than CordovaInterface
Andrew Grieve created CB-8389: - Summary: pluginManager.postMessage() Should allow plugins first dibs at messages rather than CordovaInterface Key: CB-8389 URL: https://issues.apache.org/jira/browse/CB-8389 Project: Apache Cordova Issue Type: Bug Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor This isn't really that obvious, but it makes more sense when you look at the two events handled by CordovaActivity: - exit (finish()es the app) - onReceiveError (likewise) These events cannot be handled by plugins, because the activity gets to them first. I'd like to write a plugin for "developer mode", where onReceiveError happens quite a bit, and I need the plugin to be able to catch this case rather than finish the activity. Giving plugins first dibs at messages actually doesn't preclude an activity from having first dibs either. The activity just needs to register their own plugin to do so (which is trivial). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8387) Handling of DisallowOverscroll preference should be done by WebView, not Activity
[ https://issues.apache.org/jira/browse/CB-8387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298835#comment-14298835 ] ASF subversion and git services commented on CB-8387: - Commit e3dd6d8c883a0a9bfbde91f0abfc845d49a74e47 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=e3dd6d8 ] CB-8387 Address TODO and have DisallowOverscroll preference set by AndroidWebView instead of CordovaActivity Now the preference will work even when not using CordovaActivity > Handling of DisallowOverscroll preference should be done by WebView, not > Activity > - > > Key: CB-8387 > URL: https://issues.apache.org/jira/browse/CB-8387 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > There's a TODO in the code already for this, but the change makes it so the > preference will work even when not using CordovaActivity -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager
[ https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298837#comment-14298837 ] ASF GitHub Bot commented on CB-5059: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/60 > The android implementation of file transfer plugin should not depend on the > concrete class android.webkit.CookieManager > --- > > Key: CB-5059 > URL: https://issues.apache.org/jira/browse/CB-5059 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: Master > Environment: cordova-android, git branch 3.0.x >Reporter: Junmin > Fix For: Master > > > The android implementation of file transfer plugin leverages the class > android.webkit.CookieManager, which depends on the concrete web > infrastructure android.webkit.WebView. This dependence ruins the portability > of the plugin. For example, it could not run on a substantial implementation > of CordovaWebView which based on a android third party component(such as > chromium for android). > Following is the crash log when initializing the CookieManager without > android.webkit.WebView: > I/dalvikvm(5006): java.lang.IllegalStateException: Call > CookieSyncManager::createInstance() or create a webview before using this > class > I/dalvikvm(5006): at > android.webkit.JniUtil.checkInitialized(JniUtil.java:44) > I/dalvikvm(5006): at > android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.nativeGetCookie(Native Method) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96) > I/dalvikvm(5006): at > org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8386) App should crash if requested webview fails to instantiate
[ https://issues.apache.org/jira/browse/CB-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-8386. --- Resolution: Fixed Fixed in 4.0.0-dev > App should crash if requested webview fails to instantiate > -- > > Key: CB-8386 > URL: https://issues.apache.org/jira/browse/CB-8386 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > Right now we just fallback to system webview, but this behaviour just hides > bugs. If I have crosswalk plugin added, and it's not working, then I want to > know about it, not receive a system webview where my app works differently in. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8387) Handling of DisallowOverscroll preference should be done by WebView, not Activity
[ https://issues.apache.org/jira/browse/CB-8387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-8387. --- Resolution: Fixed Fixed in 4.0.0-dev > Handling of DisallowOverscroll preference should be done by WebView, not > Activity > - > > Key: CB-8387 > URL: https://issues.apache.org/jira/browse/CB-8387 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > There's a TODO in the code already for this, but the change makes it so the > preference will work even when not using CordovaActivity -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8388) Windows mobilespec test app crashes on unhandled javascript exception
Nikhil Khandelwal created CB-8388: - Summary: Windows mobilespec test app crashes on unhandled javascript exception Key: CB-8388 URL: https://issues.apache.org/jira/browse/CB-8388 Project: Apache Cordova Issue Type: Bug Components: Windows Affects Versions: 3.7.0 Reporter: Nikhil Khandelwal Priority: Minor This prevents from getting results when 1 test fails with an unhandled exception. The idea is to 'handle' the unhandled exception and prevent the test from crashing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8378) Delete LinearLayoutSoftKeyboardDetect for 4.0.x
[ https://issues.apache.org/jira/browse/CB-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298833#comment-14298833 ] ASF subversion and git services commented on CB-8378: - Commit a2fed200fe8f12afd2e774a325f3c803625f6079 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=a2fed20 ] CB-8378 Remove reference to LinearLayoutSoftKeyboardDetect from unit tests > Delete LinearLayoutSoftKeyboardDetect for 4.0.x > --- > > Key: CB-8378 > URL: https://issues.apache.org/jira/browse/CB-8378 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > Conversation here: http://markmail.org/thread/a36bg2kux6rssmnt > TLDR - We've never documented the events it fires, there are bugs with it, > and there's a 3rd party plugin that serves the same purpose > (https://github.com/driftyco/ionic-plugins-keyboard/blob/master/src/android/IonicKeyboard.java) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager
[ https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298836#comment-14298836 ] ASF subversion and git services commented on CB-5059: - Commit c12f1eb9befb2111717b3219be10975476efec64 in cordova-plugin-file-transfer's branch refs/heads/master from [~dpogue] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=c12f1eb ] CB-5059 Add a CookieManager abstraction for pluggable webviews (close #60) This allows FileTransfer to correctly use webview cookies regardless of which webview engine is in use. > The android implementation of file transfer plugin should not depend on the > concrete class android.webkit.CookieManager > --- > > Key: CB-5059 > URL: https://issues.apache.org/jira/browse/CB-5059 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: Master > Environment: cordova-android, git branch 3.0.x >Reporter: Junmin > Fix For: Master > > > The android implementation of file transfer plugin leverages the class > android.webkit.CookieManager, which depends on the concrete web > infrastructure android.webkit.WebView. This dependence ruins the portability > of the plugin. For example, it could not run on a substantial implementation > of CordovaWebView which based on a android third party component(such as > chromium for android). > Following is the crash log when initializing the CookieManager without > android.webkit.WebView: > I/dalvikvm(5006): java.lang.IllegalStateException: Call > CookieSyncManager::createInstance() or create a webview before using this > class > I/dalvikvm(5006): at > android.webkit.JniUtil.checkInitialized(JniUtil.java:44) > I/dalvikvm(5006): at > android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.nativeGetCookie(Native Method) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109) > I/dalvikvm(5006): at > android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96) > I/dalvikvm(5006): at > org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8386) App should crash if requested webview fails to instantiate
[ https://issues.apache.org/jira/browse/CB-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298834#comment-14298834 ] ASF subversion and git services commented on CB-8386: - Commit 137fe12c43a00a11d8b163e2b634165e108420f2 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=137fe12 ] CB-8386 Don't fallback on system webview if custom webview fails to construct > App should crash if requested webview fails to instantiate > -- > > Key: CB-8386 > URL: https://issues.apache.org/jira/browse/CB-8386 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > Right now we just fallback to system webview, but this behaviour just hides > bugs. If I have crosswalk plugin added, and it's not working, then I want to > know about it, not receive a system webview where my app works differently in. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8383) pause event don't fire when 'KeepRunning' is false
[
https://issues.apache.org/jira/browse/CB-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hugefactory updated CB-8383:
Description:
Under Android, when a project use 'KeepRunning=false' in the config.xml file,
the 'pause' event in javascript don't fire when application go to background.
Next, 'pause' event fire when 'resume' is call and when the application resume.
The problem is in 'CordovaWebView.java' in the 'handlePause' method :
public void handlePause(boolean keepRunning) {
LOG.d(TAG, "Handle the pause");
// Send pause event to JavaScript
this.loadUrl("javascript:try{cordova.fireDocumentEvent('pause');}catch(e){console.log('exception
firing pause event from native');};");
// Forward to plugins
if (this.pluginManager != null) {
this.pluginManager.onPause(keepRunning);
}
// If app doesn't want to run in background
if (!keepRunning) {
// Pause JavaScript timers (including setInterval)
this.pauseTimers();
}
paused = true;
}
As you can see, 'pauseTimers()' is call immediatly when we choose 'KeepRunning'
false.
According to the Android documentation, 'pauseTimer()' stop all javascript
activitythen the 'pause' javascript callback is not execute (it's execute
after, when the 'resumeTimers()' is call and the application resume.
I suggest to delay the 'pauseTimers()' for 1 or 2 sec. Then the javascript
'pause' can execute before the application is really stop :
//OLD
//this.pauseTimers();
//NEW
final Handler handler = new Handler();
handler.postDelayed(new Runnable() {
@Override
public void run() {
LOG.d(TAG, "Handle the pauseTimers");
pauseTimers();
}
}, 1000);
}
Thanks.
was:
When a project use 'KeepRunning=false' in the config.xml file, the 'pause'
event in javascript don't fire when application go to background. Next, 'pause'
event fire when 'resume' is call and when the application resume.
The problem is in 'CordovaWebView.java' in the 'handlePause' method :
public void handlePause(boolean keepRunning)
{
LOG.d(TAG, "Handle the pause");
// Send pause event to JavaScript
this.loadUrl("javascript:try{cordova.fireDocumentEvent('pause');}catch(e){console.log('exception
firing pause event from native');};");
// Forward to plugins
if (this.pluginManager != null) {
this.pluginManager.onPause(keepRunning);
}
// If app doesn't want to run in background
if (!keepRunning) {
// Pause JavaScript timers (including setInterval)
this.pauseTimers();
}
paused = true;
}
As you can see, 'pauseTimers()' is call immediatly when we choose 'KeepRunning'
false.
According to the Android documentation, 'pauseTimer()' stop all javascript
activitythen the 'pause' javascript callback is not execute (it's execute
after, when the 'resumeTimers()' is call and the application resume.
I suggest to delay the 'pauseTimers()' for 1 or 2 sec. Then the javascript
'pause' can execute before the application is really stop :
//OLD
//this.pauseTimers();
//NEW
final Handler handler = new Handler();
handler.postDelayed(new Runnable() {
@Override
public void run() {
LOG.d(TAG, "Handle the pauseTimers");
pauseTimers();
}
}, 1000);
}
Thanks.
> pause event don't fire when 'KeepRunning' is false
> --
>
> Key: CB-8383
> URL: https://issues.apache.org/jira/browse/CB-8383
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master, 3.5.0, 4.0.0, 4.1.3
> Environment: Mac osx 10.9
>Reporter: hugefactory
> Labels: easyfix
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Under Android, when a project use 'KeepRunning=false' in the config.xml file,
> the 'pause' event in javascript don't fire when application go to background.
> Next, 'pause' event fire when 'resume' is call and when the application
> resume.
> The problem is in 'CordovaWebView.java' in the 'handlePause' method :
> public void handlePause(boolean keepRunning) {
> LOG.d(TAG, "Handle the pause");
> // Send pause event to JavaScript
>
> this.loadUrl("javascript:try{cordova.fireDocumentEvent('pause');}catch(e){console.log('exception
> firing pause event from native');};");
> // Forward to plugins
> if (this.pluginManager != null) {
> this.pluginManager.onPause(keepRunning);
> }
> // If app doesn't want to run in background
> i
[jira] [Created] (CB-8387) Handling of DisallowOverscroll preference should be done by WebView, not Activity
Andrew Grieve created CB-8387: - Summary: Handling of DisallowOverscroll preference should be done by WebView, not Activity Key: CB-8387 URL: https://issues.apache.org/jira/browse/CB-8387 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor There's a TODO in the code already for this, but the change makes it so the preference will work even when not using CordovaActivity -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8386) App should crash if requested webview fails to instantiate
Andrew Grieve created CB-8386: - Summary: App should crash if requested webview fails to instantiate Key: CB-8386 URL: https://issues.apache.org/jira/browse/CB-8386 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor Right now we just fallback to system webview, but this behaviour just hides bugs. If I have crosswalk plugin added, and it's not working, then I want to know about it, not receive a system webview where my app works differently in. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8385) Ensure plugin-test-framework runs tests only once
[
https://issues.apache.org/jira/browse/CB-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Grebnov updated CB-8385:
---
Summary: Ensure plugin-test-framework runs tests only once (was: Ensure
plugin-test-framework trigger tests only once)
> Ensure plugin-test-framework runs tests only once
> -
>
> Key: CB-8385
> URL: https://issues.apache.org/jira/browse/CB-8385
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin TestFramework
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-test-framework
>
> I see this on Windows. This is happening when test-framework checks whether
> Medic config exists and calls callback twice when there is no config
> available (default case when you use test framework locally):
> 1. Inside onload
> 2. Inside exception catch block
> {code}
> exports.load = function (callback) {
> var xhr = new XMLHttpRequest();
> xhr.open("GET", "../medic.json", true);
> xhr.onload = function() {
> if (xhr.readyState == 4 && xhr.status == 200) {
> var cfg = JSON.parse(xhr.responseText);
> exports.logurl = cfg.logurl;
> exports.enabled = true;
> console.log('Loaded Medic Config: logurl=' + exports.logurl);
> }
> callback();
> }
> xhr.onerror = function() {
>callback();
> }
> try {
> xhr.send(null);
> }
> catch(ex) {
> // some platforms throw on a file not found
> console.log('Did not find medic config file');
> setTimeout(function(){
> callback();
> },0);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8385) Ensure plugin-test-framework trigger tests only once
[
https://issues.apache.org/jira/browse/CB-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Grebnov updated CB-8385:
---
Description:
I see this on Windows. This is happening when test-framework checks whether
Medic config exists and calls callback twice when there is no config available
(default case when you use test framework locally):
1. Inside onload
2. Inside exception catch block
{code}
exports.load = function (callback) {
var xhr = new XMLHttpRequest();
xhr.open("GET", "../medic.json", true);
xhr.onload = function() {
if (xhr.readyState == 4 && xhr.status == 200) {
var cfg = JSON.parse(xhr.responseText);
exports.logurl = cfg.logurl;
exports.enabled = true;
console.log('Loaded Medic Config: logurl=' + exports.logurl);
}
callback();
}
xhr.onerror = function() {
callback();
}
try {
xhr.send(null);
}
catch(ex) {
// some platforms throw on a file not found
console.log('Did not find medic config file');
setTimeout(function(){
callback();
},0);
}
}
{code}
was:
I see this on Windows. This is happening when test-framework checks whether
Medic config exists and calls callback twice when there is no config available
(default case when you use test framework locally):
1. Inside xhr.onerror
2. Inside exception catch block
{code}
exports.load = function (callback) {
var xhr = new XMLHttpRequest();
xhr.open("GET", "../medic.json", true);
xhr.onload = function() {
if (xhr.readyState == 4 && xhr.status == 200) {
var cfg = JSON.parse(xhr.responseText);
exports.logurl = cfg.logurl;
exports.enabled = true;
console.log('Loaded Medic Config: logurl=' + exports.logurl);
}
callback();
}
xhr.onerror = function() {
callback();
}
try {
xhr.send(null);
}
catch(ex) {
// some platforms throw on a file not found
console.log('Did not find medic config file');
setTimeout(function(){
callback();
},0);
}
}
{code}
> Ensure plugin-test-framework trigger tests only once
>
>
> Key: CB-8385
> URL: https://issues.apache.org/jira/browse/CB-8385
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin TestFramework
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-test-framework
>
> I see this on Windows. This is happening when test-framework checks whether
> Medic config exists and calls callback twice when there is no config
> available (default case when you use test framework locally):
> 1. Inside onload
> 2. Inside exception catch block
> {code}
> exports.load = function (callback) {
> var xhr = new XMLHttpRequest();
> xhr.open("GET", "../medic.json", true);
> xhr.onload = function() {
> if (xhr.readyState == 4 && xhr.status == 200) {
> var cfg = JSON.parse(xhr.responseText);
> exports.logurl = cfg.logurl;
> exports.enabled = true;
> console.log('Loaded Medic Config: logurl=' + exports.logurl);
> }
> callback();
> }
> xhr.onerror = function() {
>callback();
> }
> try {
> xhr.send(null);
> }
> catch(ex) {
> // some platforms throw on a file not found
> console.log('Did not find medic config file');
> setTimeout(function(){
> callback();
> },0);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8385) Ensure plugin-test-framework trigger tests only once
Sergey Grebnov created CB-8385:
--
Summary: Ensure plugin-test-framework trigger tests only once
Key: CB-8385
URL: https://issues.apache.org/jira/browse/CB-8385
Project: Apache Cordova
Issue Type: Bug
Components: Plugin TestFramework
Reporter: Sergey Grebnov
Assignee: Sergey Grebnov
I see this on Windows. This is happening when test-framework checks whether
Medic config exists and calls callback twice when there is no config available
(default case when you use test framework locally):
1. Inside xhr.onerror
2. Inside exception catch block
{code}
exports.load = function (callback) {
var xhr = new XMLHttpRequest();
xhr.open("GET", "../medic.json", true);
xhr.onload = function() {
if (xhr.readyState == 4 && xhr.status == 200) {
var cfg = JSON.parse(xhr.responseText);
exports.logurl = cfg.logurl;
exports.enabled = true;
console.log('Loaded Medic Config: logurl=' + exports.logurl);
}
callback();
}
xhr.onerror = function() {
callback();
}
try {
xhr.send(null);
}
catch(ex) {
// some platforms throw on a file not found
console.log('Did not find medic config file');
setTimeout(function(){
callback();
},0);
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Grebnov updated CB-8384:
---
Description:
1. There is currently only windows8 platform section in plugin.xml
{code}
{code}
To correctly add support of Windows Universal Platform we should create
separate section below:
{code}
{code}
2. Current implementation does not track connection status changed event. This
could be added via NetworkInformation.NetworkStatusChanged
(https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
was:
There is currently only windows8 platform section in plugin.xml
{code}
{code}
To correctly add support of Windows Universal Platform we should create
separate section below:
{code}
{code}
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> 1. There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
> 2. Current implementation does not track connection status changed event.
> This could be added via NetworkInformation.NetworkStatusChanged
> (https://msdn.microsoft.com/library/windows/apps/windows.networking.connectivity.networkinformation.networkstatuschanged.aspx)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8384) Add Windows platform support to Network Information plugin
[
https://issues.apache.org/jira/browse/CB-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298583#comment-14298583
]
ASF GitHub Bot commented on CB-8384:
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/24
CB-8384 Add Windows platform support to Network Information plugin
https://issues.apache.org/jira/browse/CB-8384
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sgrebnov/cordova-plugin-network-information
CB-8384
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
commit fb608698e5c97e18da8bb1d6f73621bb3676ebfe
Author: sgrebnov
Date: 2015-01-30T11:57:10Z
CB-8384 Add Windows section to Network Information plugin
commit c8281535160a547a367b7c820360e711c59d4cc9
Author: sgrebnov
Date: 2015-01-30T12:33:36Z
CB-8384 Add Windows platform quirks
commit d8a714757fae0ac615224a7a0daabaa88c8e2581
Author: sgrebnov
Date: 2015-01-30T12:37:16Z
CB-8384 Fixes the way we detect online status on Windows
> Add Windows platform support to Network Information plugin
> --
>
> Key: CB-8384
> URL: https://issues.apache.org/jira/browse/CB-8384
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Network Information, Windows
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: cordova-plugin-network-information, plugins, windows
>
> There is currently only windows8 platform section in plugin.xml
> {code}
>
> {code}
> To correctly add support of Windows Universal Platform we should create
> separate section below:
> {code}
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8384) Add Windows platform support to Network Information plugin
Sergey Grebnov created CB-8384:
--
Summary: Add Windows platform support to Network Information plugin
Key: CB-8384
URL: https://issues.apache.org/jira/browse/CB-8384
Project: Apache Cordova
Issue Type: Improvement
Components: Plugin Network Information, Windows
Reporter: Sergey Grebnov
Assignee: Sergey Grebnov
There is currently only windows8 platform section in plugin.xml
{code}
{code}
To correctly add support of Windows Universal Platform we should create
separate section below:
{code}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8383) pause event don't fire when 'KeepRunning' is false
hugefactory created CB-8383:
---
Summary: pause event don't fire when 'KeepRunning' is false
Key: CB-8383
URL: https://issues.apache.org/jira/browse/CB-8383
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 3.5.0, Master, 4.0.0, 4.1.3
Environment: Mac osx 10.9
Reporter: hugefactory
When a project use 'KeepRunning=false' in the config.xml file, the 'pause'
event in javascript don't fire when application go to background. Next, 'pause'
event fire when 'resume' is call and when the application resume.
The problem is in 'CordovaWebView.java' in the 'handlePause' method :
public void handlePause(boolean keepRunning)
{
LOG.d(TAG, "Handle the pause");
// Send pause event to JavaScript
this.loadUrl("javascript:try{cordova.fireDocumentEvent('pause');}catch(e){console.log('exception
firing pause event from native');};");
// Forward to plugins
if (this.pluginManager != null) {
this.pluginManager.onPause(keepRunning);
}
// If app doesn't want to run in background
if (!keepRunning) {
// Pause JavaScript timers (including setInterval)
this.pauseTimers();
}
paused = true;
}
As you can see, 'pauseTimers()' is call immediatly when we choose 'KeepRunning'
false.
According to the Android documentation, 'pauseTimer()' stop all javascript
activitythen the 'pause' javascript callback is not execute (it's execute
after, when the 'resumeTimers()' is call and the application resume.
I suggest to delay the 'pauseTimers()' for 1 or 2 sec. Then the javascript
'pause' can execute before the application is really stop :
//OLD
//this.pauseTimers();
//NEW
final Handler handler = new Handler();
handler.postDelayed(new Runnable() {
@Override
public void run() {
LOG.d(TAG, "Handle the pauseTimers");
pauseTimers();
}
}, 1000);
}
Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
