[jira] [Commented] (CB-8028) handleOpenURL doesn't work properly when app is being launched for the first time
[ https://issues.apache.org/jira/browse/CB-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310462#comment-14310462 ] Shazron Abdullah commented on CB-8028: -- The plugin probably needs to be loaded at startup like so: https://github.com/apache/cordova-plugins/blob/a365e2acc82cd9057a6b15aaca121666a4f5372a/local-webserver/plugin.xml#L41 > handleOpenURL doesn't work properly when app is being launched for the first > time > - > > Key: CB-8028 > URL: https://issues.apache.org/jira/browse/CB-8028 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.7.0 >Reporter: Antonio Laguna >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > Hi! > Please bear in mind that this is my first issue being reported here but I > thought it to be worth it. > So, we've been developing a Cordova application lately and we decided to add > a notification center plugin to be able to launch the application from it, > taking advantage of the url-scheme on iOS. > We discovered that it worked flawlessly when it was launched and the app was > in background but it wasn't when the app was closed and tried to launch from > there. > So I dug deeper. > Since this is an Ionic application, I thought the issue was due to Angular > not being ready at the appropriate time or something like that so I just put > something really low-level which didn't depend on any library: > {code:javascript} > window.foo = 'bar'; > {code} > And then checked with a timeout (after app was ready) to see if it was there. > But it wasn't. > So I dug deeper. > So the issue seems to come on this function which is on the > {{CDDViewController}} class > {code} > - (void)processOpenUrl:(NSURL*)url pageLoaded:(BOOL)pageLoaded > { > if (!pageLoaded) { > // query the webview for readystate > NSString* readyState = [webView > stringByEvaluatingJavaScriptFromString:@"document.readyState"]; > pageLoaded = [readyState isEqualToString:@"loaded"] || [readyState > isEqualToString:@"complete"]; > } > if (pageLoaded) { > // calls into javascript global function 'handleOpenURL' > NSString* jsString = [NSString stringWithFormat:@"if (typeof > handleOpenURL === 'function') { handleOpenURL(\"%@\");}", url]; > [self.webView stringByEvaluatingJavaScriptFromString:jsString]; > } else { > // save for when page has loaded > self.openURL = url; > } > } > {code} > The thing is that the second check for {{pageLoaded}} is positive even though > the page is clearly at a really early stage. The Splash is still being shown > and the DOM although it may be ready-ish, it doesn't work properly (clearly). > This is the flow: > * It comes first by {{(void)processOpenUrl:(NSURL*)url}} - The > {{handleOpenUrl}} function is then called cause even though {{NO}} is passed > as a parameter, Cordova gets to think it's ready. > * Then it comes to {{onPageDidLoad}} which would call > {{(void)processOpenUrl:(NSURL*)url pageLoaded:(BOOL)pageLoaded}} too but > since {{openURL}} hasn't been saved this time, it won't do anything > Just to make sure of things, I tried to {{self.openURL = url;}} even if the > page was loaded and that turned out to work. > I don't understand the implications of this but IMHO, {{onPageDidLoad}} is a > better point to understand wether the app is ready or not than querying the > document like that cause the code doesn't seem to be there yet. > Please note that I put my handler before anything else on the header to > ensure it wasn't a racing issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310466#comment-14310466 ] Shazron Abdullah commented on CB-7606: -- Took a look at Eddy's patch here: https://gist.github.com/EddyVerbruggen/3edb9f33b29d26c79ec7 Looking at one of the comments, a fixed delay is still not optimal, because modern vs older devices will behave differently. Been trying to find the best solution that works in a deterministic way. Talking to [~purplecabbage] - he thinks the best way to make this behave in a deterministic manner is to tie it to cordova's deviceready event, and I agree. {code} NSString* jsString = [NSString stringWithFormat:@"document.addEventListener('deviceready',function(){if (typeof handleOpenURL === 'function') { handleOpenURL(\"%@\");}});", url]; [webView stringByEvaluatingJavaScriptFromString:jsString]; {code} cordova duck-punches (no animals were hurt!) document.addEventListener to do what it needs to do, so because of this, if deviceready has already fired, the callback will fire right away -- so handleOpenURL will always be called. I haven't tested this yet, but I will try this approach and report back. I'm also testing Antonio's approach here: https://issues.apache.org/jira/browse/CB-8028?focusedCommentId=14231236&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14231236 .. he reports it as working, but this depends on plugins being loaded before the url is handled, so there might be timing issues there. > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8441) Delete platform specific src from cordovajs, update browserify and grunt build flow
[ https://issues.apache.org/jira/browse/CB-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-8441: --- Description: Delete platform specific src from cordovajs since it has been moved to platforms (CB-8417) Update browserify builds to look in platform cordova-js-src folder when building cordova-js Update grunt cordova-js builds to look in platform folders for platform specific js Doc at https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing was: Delete platform specific src from cordovajs since it has been moved to platforms (CB-8417) Update browserify builds to look in platform cordova-js-src folder when building cordova-js Update grunt cordova-js builds to look in platform folders for platform specific js > Delete platform specific src from cordovajs, update browserify and grunt > build flow > --- > > Key: CB-8441 > URL: https://issues.apache.org/jira/browse/CB-8441 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS >Reporter: Steve Gill >Assignee: Steve Gill > > Delete platform specific src from cordovajs since it has been moved to > platforms (CB-8417) > Update browserify builds to look in platform cordova-js-src folder when > building cordova-js > Update grunt cordova-js builds to look in platform folders for platform > specific js > Doc at > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8441) Delete platform specific src from cordovajs, update browserify and grunt build flow
Steve Gill created CB-8441: -- Summary: Delete platform specific src from cordovajs, update browserify and grunt build flow Key: CB-8441 URL: https://issues.apache.org/jira/browse/CB-8441 Project: Apache Cordova Issue Type: Bug Components: CordovaJS Reporter: Steve Gill Assignee: Steve Gill Delete platform specific src from cordovajs since it has been moved to platforms (CB-8417) Update browserify builds to look in platform cordova-js-src folder when building cordova-js Update grunt cordova-js builds to look in platform folders for platform specific js -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-8417. Resolution: Fixed > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310421#comment-14310421 ] ASF subversion and git services commented on CB-8417: - Commit cd90271b694dbd33fdc23cebdab1f3caba5e691e in cordova-wp8's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=cd90271 ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310413#comment-14310413 ] ASF subversion and git services commented on CB-8417: - Commit 4b02d5f438b52b55e6345830fad15f8d6011f147 in cordova-webos's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-webos.git;h=4b02d5f ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310414#comment-14310414 ] ASF subversion and git services commented on CB-8417: - Commit 3fd450c6d03d3cb0020558d9101298f9e315ac4b in cordova-windows's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=3fd450c ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310409#comment-14310409 ] ASF subversion and git services commented on CB-8417: - Commit a00fa7c47b765b5ef2fb47f11d4e0d4621f49805 in cordova-ubuntu's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ubuntu.git;h=a00fa7c ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310405#comment-14310405 ] ASF subversion and git services commented on CB-8417: - Commit 67e69f6c52a56a2f7254da50b60045108cead66d in cordova-osx's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-osx.git;h=67e69f6 ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310403#comment-14310403 ] ASF subversion and git services commented on CB-8417: - Commit bacbd091067f8a670f6d57e4331961c89a955cbd in cordova-firefoxos's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;h=bacbd09 ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310402#comment-14310402 ] ASF subversion and git services commented on CB-8417: - Commit 79fca25044c7c2f769c49f3456195ab02f236b66 in cordova-amazon-fireos's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-amazon-fireos.git;h=79fca25 ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310393#comment-14310393 ] ASF subversion and git services commented on CB-8417: - Commit ad7ce085f7d6ea7039f02419d3830682f26dc63e in cordova-android's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=ad7ce08 ] CB-8417 renamed platform_modules into cordova-js-src > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310392#comment-14310392 ] ASF subversion and git services commented on CB-8417: - Commit 338ee71f966ab7fdc1ccde02e5086febbc82b70c in cordova-ios's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=338ee71 ] CB-8417 renamed platform_modules into cordova-js-src > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310391#comment-14310391 ] ASF subversion and git services commented on CB-8417: - Commit ed02db41e6ff785ce4a65e6bd1ac621b828eb456 in cordova-blackberry's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=ed02db4 ] CB-8417 renamed platform_modules into cordova-js-src > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310390#comment-14310390 ] ASF subversion and git services commented on CB-8417: - Commit ae9d599e903517ee9276313fd56b5781ac94c321 in cordova-browser's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;h=ae9d599 ] CB-8417 renamed platform_modules into cordova-js-src > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310386#comment-14310386 ] Steve Gill commented on CB-8417: After talking with Jesse and Shaz, we agreed that cordova-js-src makes more sense than platforms_modules. I will move forward with that. We can rename if people disagree. > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310363#comment-14310363 ] ASF subversion and git services commented on CB-8417: - Commit e17e27cfeb2ca22fe16426c6e08a8861b3e3e1f4 in cordova-browser's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;h=e17e27c ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310356#comment-14310356 ] ASF subversion and git services commented on CB-8417: - Commit 077a69d9c7c9687a7884dbf9222ea1562a874a6f in cordova-blackberry's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=077a69d ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310348#comment-14310348 ] ASF subversion and git services commented on CB-8417: - Commit 8b3c89b646026ccfe2903230f3ea9066911fe9f8 in cordova-ios's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=8b3c89b ] CB-8417 moved platform specific js into platform > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8417) Move platform specific JS into platforms
[ https://issues.apache.org/jira/browse/CB-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310310#comment-14310310 ] ASF subversion and git services commented on CB-8417: - Commit 828edb3a439ace4ecd169ee8e87a93418fc623b9 in cordova-android's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=828edb3 ] CB-8417 moved platform specific js into platforms > Move platform specific JS into platforms > > > Key: CB-8417 > URL: https://issues.apache.org/jira/browse/CB-8417 > Project: Apache Cordova > Issue Type: Improvement > Components: Amazon FireOS, Android, BlackBerry, Browser, CordovaJS, > FirefoxOS, iOS, Ubuntu, Windows, WP8 >Reporter: Steve Gill >Assignee: Steve Gill > > Doc: > https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing > Move platform specific folders from the cordova-js/src directory to each > platforms repo. Maybe a top level directory named platform_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310288#comment-14310288 ] Steve Gill commented on CB-8416: Once reviewed, I will merge to master and close this issue > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8415) Cordova-Android 3.7.1 Platform Release February 3, 2015
[ https://issues.apache.org/jira/browse/CB-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-8415. Resolution: Done > Cordova-Android 3.7.1 Platform Release February 3, 2015 > --- > > Key: CB-8415 > URL: https://issues.apache.org/jira/browse/CB-8415 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8415) Cordova-Android 3.7.1 Platform Release February 3, 2015
[ https://issues.apache.org/jira/browse/CB-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309921#comment-14309921 ] Steve Gill commented on CB-8415: http://cordova.apache.org/announcements/2015/02/06/cordova-android-3.7.1.html > Cordova-Android 3.7.1 Platform Release February 3, 2015 > --- > > Key: CB-8415 > URL: https://issues.apache.org/jira/browse/CB-8415 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8440) iOS Geolocation ask for permissions twice
Mike Hartington created CB-8440: --- Summary: iOS Geolocation ask for permissions twice Key: CB-8440 URL: https://issues.apache.org/jira/browse/CB-8440 Project: Apache Cordova Issue Type: Bug Components: Plugin Geolocation Affects Versions: 3.7.0 Environment: IOS8 Reporter: Mike Hartington Getting what looks like a conflict between a native dialog and the webview alert when trying to use geolocation on iOS. http://youtu.be/ByghzOBRKJQ I'll get the expect native dialog saying "Allow App to use your location?" followed by another with the system path to index.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8439) Fix documentation : 'cordova platform update'
[ https://issues.apache.org/jira/browse/CB-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309914#comment-14309914 ] ASF GitHub Bot commented on CB-8439: GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/208 CB-8439 Fix 'cordova platform update' documentation to include CB-8439 Fix 'cordova platform update' documentation to include You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli CB-8439 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #208 commit 568fa5c97e415b19801dccdb8e738f8b1a203dc6 Author: Omar Mefire Date: 2015-02-06T21:02:17Z CB-8439 Fix 'cordova platform update' documentation to include > Fix documentation : 'cordova platform update' > -- > > Key: CB-8439 > URL: https://issues.apache.org/jira/browse/CB-8439 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Omar Mefire > > - Currently, if you type: 'cordova platform --help' from the CLI, the > documentation for 'cordova platform update' does not mention that it can also > take paths and git-urls in addition to platform, which is misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8439) Fix documentation : 'cordova platform update'
Omar Mefire created CB-8439: --- Summary: Fix documentation : 'cordova platform update' Key: CB-8439 URL: https://issues.apache.org/jira/browse/CB-8439 Project: Apache Cordova Issue Type: Improvement Components: CordovaLib Reporter: Omar Mefire - Currently, if you type: 'cordova platform --help' from the CLI, the documentation for 'cordova platform update' does not mention that it can also take paths and git-urls in addition to platform, which is misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8409) cordova build && echo good || echo bad does not work
[ https://issues.apache.org/jira/browse/CB-8409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309844#comment-14309844 ] ASF subversion and git services commented on CB-8409: - Commit 0ee180cd1d40b4c2da77d255000a578e12e0a449 in cordova-lib's branch refs/heads/CB-8416 from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=0ee180c ] CB-8409 compile: bubble failures > cordova build && echo good || echo bad does not work > > > Key: CB-8409 > URL: https://issues.apache.org/jira/browse/CB-8409 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Josh Soref >Assignee: Josh Soref > > {quote} > $ cordova create test > $ cd test > $ cordova platform add blackberry10 > $ cordova build --release && echo good || echo bad > {quote} > When prompted for a keystore, password: > {quote} > Please enter your keystore password: > {quote} > enter garbage ^M > the actual results are: > {quote} > good > {quote} > the expected result is: > {quote} > bad > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8239) Add support for git urls to 'cordova platform add'
[ https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309843#comment-14309843 ] ASF subversion and git services commented on CB-8239: - Commit 74b8142c281e3cad0bf4c3b8166d97b6637f5a97 in cordova-lib's branch refs/heads/CB-8416 from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=74b8142 ] CB-8239 Fix "platform update" should ignore `` (close #159) > Add support for git urls to 'cordova platform add' > -- > > Key: CB-8239 > URL: https://issues.apache.org/jira/browse/CB-8239 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI, CordovaLib >Reporter: Omar Mefire > > Allow the following scenarios: > - users can issue 'cordova platform add > https://github.com/apache/cordova-android.git' and the git repo will be > cloned and used. > - users can issue 'cordova platform add > android@https://github.com/apache/cordova-android.git' and the git repo will > be cloned and used. > - users can issue 'cordova platform add android' and if their config.xml file > contains: ' version='https://github.com/apache/cordova-android.git' />, then the git repo > pointed to by config.xml will be cloned and used. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8390) broken for gradle projects
[ https://issues.apache.org/jira/browse/CB-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309842#comment-14309842 ] ASF subversion and git services commented on CB-8390: - Commit 60f19284ce5b8e265e2348ba88907fc47af42007 in cordova-lib's branch refs/heads/CB-8416 from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=60f1928 ] CB-8390 android: Make `` work with Gradle > broken for gradle projects > -- > > Key: CB-8390 > URL: https://issues.apache.org/jira/browse/CB-8390 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > {code} > > {code} > allows referencing of android support libraries and play services, which live > within the user's SDK directory. > https://developer.android.com/tools/support-library/features.html > There is currently ANT-specific logic within plugman to handle them, and they > don't work at all for gradle projects. > https://github.com/apache/cordova-lib/blob/e05c656ef3d77d6c5e9232ed4e6ddbd3e29654eb/cordova-lib/src/plugman/platforms/android.js#L118 > (note the use of local.properties) > Some example tags: > {code} > > > src="google/google_play_services/libproject/google-play-services_lib" /> > {code} > Currently (for ANT), these libraries were added as sub-projects using the > path to them within the SDK directory. For gradle, we should be added them > via: > {code} > dependencies { > compile 'com.android.support:support-v4:21.0.+' > compile 'com.android.support:support-v13:18.0.+' > compile 'com.google.android.gms:play-services:6.5.87' > } > {code} > Proposed change: > Look for `src` in the form of `extras/android/support/v4` and map that to > `com.android.support:support-v4`. Just use a hardcoded lookup table, as this > is just for backwards compat. > Add support for `src` in the form of `com.android.support:support-v4`, and > add these to the project.properties file, in the same way that we do for > subprojects and gradleReference frameworks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309845#comment-14309845 ] ASF subversion and git services commented on CB-8416: - Commit 0d0279c84c82bb2aa79a8a116184b4f43617c0cb in cordova-lib's branch refs/heads/CB-8416 from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=0d0279c ] Merge branch 'master' into CB-8416 > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309836#comment-14309836 ] ASF subversion and git services commented on CB-8416: - Commit adab8c9accfd769019837bb1cc36a2975f9742b0 in cordova-lib's branch refs/heads/CB-8416 from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=adab8c9 ] CB-8416 updated plugman publish to temporarily rename existing package.json files > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309778#comment-14309778 ] ASF subversion and git services commented on CB-8416: - Commit cc0ec04d0209f26b10f14f6fa91296fe529f4af0 in cordova-plugman's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=cc0ec04 ] CB-8416 added createpackagejson to help doc > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309765#comment-14309765 ] ASF subversion and git services commented on CB-8416: - Commit fcf37d03d12301d26cb4bcbb0107b085325f40d6 in cordova-lib's branch refs/heads/CB-8416 from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fcf37d0 ] CB-8416: added createpackagejson command > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test
[ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309657#comment-14309657 ] ASF GitHub Bot commented on CB-8412: Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73293570 Seems like an artifact. The original design changed and that checkin was supposed to be reverted. I'll take a look > WP8 platform should use JSHint as part of npm test > -- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen >Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of > travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test
[ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309615#comment-14309615 ] ASF GitHub Bot commented on CB-8412: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73290860 The failing test is because your 'end-to-end list validation handles list parameter' test requires ios-sim which is not installed. Installation of ios-sim should be added to .travis.yml if this is an important test. > WP8 platform should use JSHint as part of npm test > -- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen >Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of > travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309575#comment-14309575 ] Andrew Grieve commented on CB-3679: --- The version of cordova-android @ master has it removed. > Breakout SplashScreen Plugin for Android > > > Key: CB-3679 > URL: https://issues.apache.org/jira/browse/CB-3679 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, Plugin SplashScreen >Reporter: Steve Gill >Assignee: Andrew Grieve > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test
[ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309558#comment-14309558 ] ASF GitHub Bot commented on CB-8412: Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73285875 `node node_modules/jshint/bin/jshint bin && node node_modules/jshint/bin/jshint tests` is passing. Failing tests are not related to this PR > WP8 platform should use JSHint as part of npm test > -- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen >Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of > travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test
[ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309551#comment-14309551 ] ASF GitHub Bot commented on CB-8412: Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73285130 Ahh, finally we're all green on AppVeyor :rocket: > WP8 platform should use JSHint as part of npm test > -- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen >Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of > travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309448#comment-14309448 ] ASF GitHub Bot commented on CB-3679: Github user cgwyllie commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-73274586 @agrieve @jbavari Hey, been looking into this for a while this afternoon and was wondering how it's possible to use the version of Cordova that doesn't have the splash code bundled on Android. Any pointer would be appreciated! > Breakout SplashScreen Plugin for Android > > > Key: CB-3679 > URL: https://issues.apache.org/jira/browse/CB-3679 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, Plugin SplashScreen >Reporter: Steve Gill >Assignee: Andrew Grieve > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8438) Translations for February
Victor Adrian Sosa Herrera created CB-8438: -- Summary: Translations for February Key: CB-8438 URL: https://issues.apache.org/jira/browse/CB-8438 Project: Apache Cordova Issue Type: Improvement Components: Translation Reporter: Victor Adrian Sosa Herrera Assignee: Victor Adrian Sosa Herrera Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8243) Translations for January
[ https://issues.apache.org/jira/browse/CB-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Adrian Sosa Herrera closed CB-8243. -- Resolution: Fixed > Translations for January > > > Key: CB-8243 > URL: https://issues.apache.org/jira/browse/CB-8243 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Victor Adrian Sosa Herrera >Assignee: Victor Adrian Sosa Herrera >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8243) Translations for January
[ https://issues.apache.org/jira/browse/CB-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309428#comment-14309428 ] ASF GitHub Bot commented on CB-8243: Github user sosahvictor closed the pull request at: https://github.com/apache/cordova-docs/pull/262 > Translations for January > > > Key: CB-8243 > URL: https://issues.apache.org/jira/browse/CB-8243 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Victor Adrian Sosa Herrera >Assignee: Victor Adrian Sosa Herrera >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7700) Translations for October
[ https://issues.apache.org/jira/browse/CB-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309424#comment-14309424 ] ASF subversion and git services commented on CB-7700: - Commit 7c220d4d622be059d76ed0562be3921e44800cf2 in cordova-docs's branch refs/heads/master from Victor Sosa [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=7c220d4 ] CB-7700 cordova-docs documentation translation: cordova-docs > Translations for October > > > Key: CB-7700 > URL: https://issues.apache.org/jira/browse/CB-7700 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Victor Adrian Sosa Herrera >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7700) Translations for October
[ https://issues.apache.org/jira/browse/CB-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309423#comment-14309423 ] ASF subversion and git services commented on CB-7700: - Commit aa0e98de333d7c2270139edc8b7534700d33ab27 in cordova-docs's branch refs/heads/master from Victor Sosa [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=aa0e98d ] CB-7700 cordova-docs documentation translation: cordova-docs > Translations for October > > > Key: CB-7700 > URL: https://issues.apache.org/jira/browse/CB-7700 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Victor Adrian Sosa Herrera >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7936) Translations for November
[ https://issues.apache.org/jira/browse/CB-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309425#comment-14309425 ] ASF subversion and git services commented on CB-7936: - Commit 6e536536e02efc4e8699823bf5fcc8dd8a03c5dc in cordova-docs's branch refs/heads/master from [~sosah.victor] [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=6e53653 ] CB-7936 cordova-docs documentation translation: cordova-docs > Translations for November > - > > Key: CB-7936 > URL: https://issues.apache.org/jira/browse/CB-7936 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Victor Adrian Sosa Herrera >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8243) Translations for January
[ https://issues.apache.org/jira/browse/CB-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309426#comment-14309426 ] ASF subversion and git services commented on CB-8243: - Commit 8474943acbbfc390b9a8b15d4dad785e4aad98eb in cordova-docs's branch refs/heads/master from [~sosah.victor] [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=8474943 ] CB-8243 cordova-docs documentation translation: cordova-docs > Translations for January > > > Key: CB-8243 > URL: https://issues.apache.org/jira/browse/CB-8243 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Victor Adrian Sosa Herrera >Assignee: Victor Adrian Sosa Herrera >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8002) Creating a new div for every Js -> Native exec() call
[ https://issues.apache.org/jira/browse/CB-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309379#comment-14309379 ] Kim Hansen edited comment on CB-8002 at 2/6/15 4:41 PM: Putting in a plug for getting this fix out sooner than later. The memory growth doesn't trigger iOS memory warnings so a dev may be unaware it's happening. It does not appear as a leak in Instruments, but that's expected since it's not really a leak. In our app, it seems like the OS or the browser puts us in bad-app jail and queues up native calls. Symptomatically, Xcode console output stops and calls through the dialogs plugin don't result in a dialog presentation--nothing at all happens. Non system events proceed normally so until there's a failed system level call a user will think the app is ok. As soon as the home button is pressed, Xcode console will barf out all of the queued console.log messages and when the app is relaunched (without force quit), the queued dialogs appear. All of them, one at a time. For the benefit of google, Instruments shows unabated growth of the memory allocated to VM: JS garbage collector. My simple test method is to use setInterval to fire off a console.log message indicating the current time, and then watch the console either in Xcode itself or via the devices window in Xcode. At some point in time with 3.7.0, the console messages will stop arriving. I have tested the fix on the following devices, watching both for the above symptoms and for the linear memory usage expansion signature (we make routine system calls in our app) in both Instruments and Xcode. I am satisfied (enough) that the fix is production worthy, we'll be shipping to Apple later today. * iPhone 4S on 7.0.6 * iPhone 5, 5S and 6 on 8.1.3 was (Author: khansen): Putting in a plug for getting this fix out sooner than later. The memory growth doesn't trigger iOS memory warnings so a dev may be unaware it's happening. It does not appear as a leak in Instruments, but that's expected since it's not really a leak. In our app, it seems like the OS puts us in bad-app jail and queues up native calls. Symptomatically, Xcode console output stops and calls through the dialogs plugin don't result in a dialog presentation--nothing at all happens. Non system events proceed normally so until there's a failed system level call a user will think the app is ok. As soon as the home button is pressed, Xcode console will barf out all of the queued console.log messages and when the app is relaunched (without force quit), the queued dialogs appear. All of them, one at a time. For the benefit of google, Instruments shows unabated growth of the memory allocated to VM: JS garbage collector. My simple test method is to use setInterval to fire off a console.log message indicating the current time, and then watch the console either in Xcode itself or via the devices window in Xcode. At some point in time with 3.7.0, the console messages will stop arriving. I have tested the fix on the following devices, watching both for the above symptoms and for the linear memory usage expansion signature (we make routine system calls in our app) in both Instruments and Xcode. I am satisfied (enough) that the fix is production worthy, we'll be shipping to Apple later today. * iPhone 4S on 7.0.6 * iPhone 5, 5S and 6 on 8.1.3 > Creating a new div for every Js -> Native exec() call > - > > Key: CB-8002 > URL: https://issues.apache.org/jira/browse/CB-8002 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.7.0 > Environment: Tested on multiple iOS 8.1 devices, simulators >Reporter: Serdar Onal >Assignee: Andrew Grieve >Priority: Critical > Fix For: 3.8.0 > > > Since the 3.7.0 update, when cordova does a Js to Native call using exec(), > somehow the underlying cordova.js is creating a "gap://ready" iframe on every > call. This means that if you made 1000 native calls you'll have 1000 divs on > the DOM. > I believe this issue is of critical priority as it incurs a huge memory leak. > Screenshot from safari inspector > https://drive.google.com/file/d/0B94TXiq5ycp1anp6aGpTbjhPdG8/view?usp=sharing -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8002) Creating a new div for every Js -> Native exec() call
[ https://issues.apache.org/jira/browse/CB-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309379#comment-14309379 ] Kim Hansen commented on CB-8002: Putting in a plug for getting this fix out sooner than later. The memory growth doesn't trigger iOS memory warnings so a dev may be unaware it's happening. It does not appear as a leak in Instruments, but that's expected since it's not really a leak. In our app, it seems like the OS puts us in bad-app jail and queues up native calls. Symptomatically, Xcode console output stops and calls through the dialogs plugin don't result in a dialog presentation--nothing at all happens. Non system events proceed normally so until there's a failed system level call a user will think the app is ok. As soon as the home button is pressed, Xcode console will barf out all of the queued console.log messages and when the app is relaunched (without force quit), the queued dialogs appear. All of them, one at a time. For the benefit of google, Instruments shows unabated growth of the memory allocated to VM: JS garbage collector. My simple test method is to use setInterval to fire off a console.log message indicating the current time, and then watch the console either in Xcode itself or via the devices window in Xcode. At some point in time with 3.7.0, the console messages will stop arriving. I have tested the fix on the following devices, watching both for the above symptoms and for the linear memory usage expansion signature (we make routine system calls in our app) in both Instruments and Xcode. I am satisfied (enough) that the fix is production worthy, we'll be shipping to Apple later today. * iPhone 4S on 7.0.6 * iPhone 5, 5S and 6 on 8.1.3 > Creating a new div for every Js -> Native exec() call > - > > Key: CB-8002 > URL: https://issues.apache.org/jira/browse/CB-8002 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.7.0 > Environment: Tested on multiple iOS 8.1 devices, simulators >Reporter: Serdar Onal >Assignee: Andrew Grieve >Priority: Critical > Fix For: 3.8.0 > > > Since the 3.7.0 update, when cordova does a Js to Native call using exec(), > somehow the underlying cordova.js is creating a "gap://ready" iframe on every > call. This means that if you made 1000 native calls you'll have 1000 divs on > the DOM. > I believe this issue is of critical priority as it incurs a huge memory leak. > Screenshot from safari inspector > https://drive.google.com/file/d/0B94TXiq5ycp1anp6aGpTbjhPdG8/view?usp=sharing -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8431) File Transfer Crash on Android with Crosswalk 10+
[ https://issues.apache.org/jira/browse/CB-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309375#comment-14309375 ] Ian Clelland commented on CB-8431: -- That would make sense, Andrew -- I don't know why I was consistently able to see it with Crosswalk, and not without, but I think you're right -- the presence of Crosswalk shouldn't make a difference, with the APIs that are in use. > File Transfer Crash on Android with Crosswalk 10+ > - > > Key: CB-8431 > URL: https://issues.apache.org/jira/browse/CB-8431 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 4.0.0 >Reporter: Ian Clelland > > Mobile Spec crashes during File Transfer tests, with a NullPointerException > thrown inside of OkHTTP. > This is very similar to CB-6378, except that all operations here appear to be > happening on the same thread. > The stack trace I've seen is: > {code} > E/AndroidRuntime(16078): FATAL EXCEPTION: pool-1-thread-3 > E/AndroidRuntime(16078): Process: org.apache.mobilespec, PID: 16078 > E/AndroidRuntime(16078): java.lang.NullPointerException: Attempt to read from > field 'int com.android.okio.Segment.limit' on a null object reference > E/AndroidRuntime(16078): at > com.android.okio.OkBuffer.write(OkBuffer.java:574) > E/AndroidRuntime(16078): at > com.android.okio.OkBuffer.read(OkBuffer.java:610) > E/AndroidRuntime(16078): at > com.android.okio.RealBufferedSource.read(RealBufferedSource.java:53) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.read(HttpConnection.java:442) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.Util.skipAll(Util.java:227) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpConnection.discard(HttpConnection.java:212) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.close(HttpConnection.java:464) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.Util.closeQuietly(Util.java:97) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpEngine.close(HttpEngine.java:433) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpURLConnectionImpl.disconnect(HttpURLConnectionImpl.java:113) > E/AndroidRuntime(16078): at > org.apache.cordova.filetransfer.FileTransfer$5.run(FileTransfer.java:950) > E/AndroidRuntime(16078): at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) > E/AndroidRuntime(16078): at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) > E/AndroidRuntime(16078): at java.lang.Thread.run(Thread.java:818) > E/FileTransfer(16078): > {"code":3,"source":"http:\/\/cordova.apache.org\/downloads\/logos_2.zip","target":"file:\/\/\/data\/data\/org.apache.mobilespec\/files\/files\/testFile.txt","http_status":200,"exception":"Attempt > to read from field 'int com.android.okio.Segment.limit' on a null object > reference"} > E/FileTransfer(16078): java.lang.NullPointerException: Attempt to read from > field 'int com.android.okio.Segment.limit' on a null object reference > E/FileTransfer(16078):at > com.android.okio.OkBuffer.write(OkBuffer.java:574) > E/FileTransfer(16078):at > com.android.okio.OkBuffer.read(OkBuffer.java:610) > E/FileTransfer(16078):at > com.android.okio.RealBufferedSource.read(RealBufferedSource.java:53) > E/FileTransfer(16078):at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.read(HttpConnection.java:442) > E/FileTransfer(16078):at > com.android.okhttp.internal.Util.skipAll(Util.java:227) > E/FileTransfer(16078):at > com.android.okhttp.internal.http.HttpConnection.discard(HttpConnection.java:212) > E/FileTransfer(16078):at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.close(HttpConnection.java:464) > E/FileTransfer(16078):at > com.android.okio.RealBufferedSource.close(RealBufferedSource.java:198) > E/FileTransfer(16078):at > com.android.okio.RealBufferedSource$1.close(RealBufferedSource.java:181) > E/FileTransfer(16078):at > java.io.FilterInputStream.close(FilterInputStream.java:64) > E/FileTransfer(16078):at > org.apache.cordova.filetransfer.FileTransfer.safeClose(FileTransfer.java:516) > E/FileTransfer(16078):at > org.apache.cordova.filetransfer.FileTransfer.access$300(FileTransfer.java:69) > E/FileTransfer(16078):at > org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:843) > E/FileTransfer(16078):at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) > E/FileTransfer(16078):at > java.util.concurr
[jira] [Commented] (CB-8431) File Transfer Crash on Android with Crosswalk 10+
[ https://issues.apache.org/jira/browse/CB-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309324#comment-14309324 ] Andrew Grieve commented on CB-8431: --- I suspect it happens only on Android L > File Transfer Crash on Android with Crosswalk 10+ > - > > Key: CB-8431 > URL: https://issues.apache.org/jira/browse/CB-8431 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 4.0.0 >Reporter: Ian Clelland > > Mobile Spec crashes during File Transfer tests, with a NullPointerException > thrown inside of OkHTTP. > This is very similar to CB-6378, except that all operations here appear to be > happening on the same thread. > The stack trace I've seen is: > {code} > E/AndroidRuntime(16078): FATAL EXCEPTION: pool-1-thread-3 > E/AndroidRuntime(16078): Process: org.apache.mobilespec, PID: 16078 > E/AndroidRuntime(16078): java.lang.NullPointerException: Attempt to read from > field 'int com.android.okio.Segment.limit' on a null object reference > E/AndroidRuntime(16078): at > com.android.okio.OkBuffer.write(OkBuffer.java:574) > E/AndroidRuntime(16078): at > com.android.okio.OkBuffer.read(OkBuffer.java:610) > E/AndroidRuntime(16078): at > com.android.okio.RealBufferedSource.read(RealBufferedSource.java:53) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.read(HttpConnection.java:442) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.Util.skipAll(Util.java:227) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpConnection.discard(HttpConnection.java:212) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.close(HttpConnection.java:464) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.Util.closeQuietly(Util.java:97) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpEngine.close(HttpEngine.java:433) > E/AndroidRuntime(16078): at > com.android.okhttp.internal.http.HttpURLConnectionImpl.disconnect(HttpURLConnectionImpl.java:113) > E/AndroidRuntime(16078): at > org.apache.cordova.filetransfer.FileTransfer$5.run(FileTransfer.java:950) > E/AndroidRuntime(16078): at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) > E/AndroidRuntime(16078): at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) > E/AndroidRuntime(16078): at java.lang.Thread.run(Thread.java:818) > E/FileTransfer(16078): > {"code":3,"source":"http:\/\/cordova.apache.org\/downloads\/logos_2.zip","target":"file:\/\/\/data\/data\/org.apache.mobilespec\/files\/files\/testFile.txt","http_status":200,"exception":"Attempt > to read from field 'int com.android.okio.Segment.limit' on a null object > reference"} > E/FileTransfer(16078): java.lang.NullPointerException: Attempt to read from > field 'int com.android.okio.Segment.limit' on a null object reference > E/FileTransfer(16078):at > com.android.okio.OkBuffer.write(OkBuffer.java:574) > E/FileTransfer(16078):at > com.android.okio.OkBuffer.read(OkBuffer.java:610) > E/FileTransfer(16078):at > com.android.okio.RealBufferedSource.read(RealBufferedSource.java:53) > E/FileTransfer(16078):at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.read(HttpConnection.java:442) > E/FileTransfer(16078):at > com.android.okhttp.internal.Util.skipAll(Util.java:227) > E/FileTransfer(16078):at > com.android.okhttp.internal.http.HttpConnection.discard(HttpConnection.java:212) > E/FileTransfer(16078):at > com.android.okhttp.internal.http.HttpConnection$FixedLengthSource.close(HttpConnection.java:464) > E/FileTransfer(16078):at > com.android.okio.RealBufferedSource.close(RealBufferedSource.java:198) > E/FileTransfer(16078):at > com.android.okio.RealBufferedSource$1.close(RealBufferedSource.java:181) > E/FileTransfer(16078):at > java.io.FilterInputStream.close(FilterInputStream.java:64) > E/FileTransfer(16078):at > org.apache.cordova.filetransfer.FileTransfer.safeClose(FileTransfer.java:516) > E/FileTransfer(16078):at > org.apache.cordova.filetransfer.FileTransfer.access$300(FileTransfer.java:69) > E/FileTransfer(16078):at > org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:843) > E/FileTransfer(16078):at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) > E/FileTransfer(16078):at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) > E/FileTransfer(16078):at java.lang.Thread.run(Thread.java:818) > W/ActivityManager( 404): Force finishing activity >
[jira] [Commented] (CB-8084) Push Notifications code included by default
[ https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309063#comment-14309063 ] ASF GitHub Bot commented on CB-8084: Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-ios/pull/128#issuecomment-73229125 Thanks, @ligaz - comments addressed. Hey @shazron or @agrieve could someone please take a look at this > Push Notifications code included by default > --- > > Key: CB-8084 > URL: https://issues.apache.org/jira/browse/CB-8084 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.5.0 >Reporter: Jacob Weber > > When creating a new Cordova app using the CLI, it adds code to AppDelegate.m > for Push Notifications. This causes Apple to issue a warning when you submit > the app, if your provisioning profile doesn't have Push Notifications enabled: > {quote} > Missing Push Notification Entitlement - Your app appears to include API used > to register with the Apple Push Notification service, but the app signature's > entitlements do not include the "aps-environment" entitlement. If your app > uses the Apple Push Notification service, make sure your App ID is enabled > for Push Notification in the Provisioning Portal, and resubmit after signing > your app with a Distribution provisioning profile that includes the > "aps-environment" entitlement. See "Provisioning and Development" in the > Local and Push Notification Programming Guide for more information. If your > app does not use the Apple Push Notification service, no action is required. > You may remove the API from future submissions to stop this warning. If you > use a third-party framework, you may need to contact the developer for > information on removing the API. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8437) Select Picker auto-closing after displaying keyboard
Tom Bell created CB-8437: Summary: Select Picker auto-closing after displaying keyboard Key: CB-8437 URL: https://issues.apache.org/jira/browse/CB-8437 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 4.0.0 Environment: iOS 8, iPhone 6 (Simulator and Device) Reporter: Tom Bell We have some select elements that when tapped, open the picker, switches to a keyboard, then auto closes. A screen recording here shows the behaviour http://cl.ly/1d212h32271j -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test
[ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308995#comment-14308995 ] ASF GitHub Bot commented on CB-8412: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73223016 This is an issue of AppVeyor itself and it should be [fixed now](http://help.appveyor.com/discussions/questions/921-support-for-silverlight-4-available). We need just another commit now to trigger the build. > WP8 platform should use JSHint as part of npm test > -- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen >Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of > travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[ https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308941#comment-14308941 ] Zarko Hristovski commented on CB-7827: -- Come on fellas, this has been open for months. > manifest/application/activity[android:name] always CordovaApp > - > > Key: CB-7827 > URL: https://issues.apache.org/jira/browse/CB-7827 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 4.0.0 > Environment: Windows 8.1 x64, NodeJs 0.10.32 >Reporter: Sergey > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[ https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308918#comment-14308918 ] ASF GitHub Bot commented on CB-8084: Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230979 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +path = require('path'), +exec = require('child_process').exec, +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE = 'PushNotificationsEnabled.h', +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT = '#define PUSH_NOTIFICATIONS_ENABLED ', +EXPANDED_PROVISIONING_PROFILE = process.env.EXPANDED_PROVISIONING_PROFILE, +PATH_TO_MOBILE_PROVISIONS = path.join(process.env.HOME, 'Library', 'MobileDevice', 'Provisioning Profiles'), +PROVISIONING_PROFILE_REQUIRED = process.env.PROVISIONING_PROFILE_REQUIRED, +PROVISIONING_PROFILE_UUID_REGEX = new RegExp('UUID<\/key>[\\s\\S]*' + EXPANDED_PROVISIONING_PROFILE + '<\/string>'); + +function logErrorIfExists(error) { +if (error !== null) { +console.error('ERROR: ' + error); +} +} + +function sanitizeMobileProvision(mobileProvision) { +if (mobileProvision.indexOf('.mobileprovision') === -1) { +mobileProvision += '.mobileprovision'; +} + +return mobileProvision; +} + +function createPushNotificationsEnabledHeaderFile(pushPluginsEnabled) { +var cordovaEnablePluginHeaderFileLocation = path.join(__dirname, '..', '..', process.env.PROJECT_NAME, 'Classes', PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE); +fs.writeFileSync(cordovaEnablePluginHeaderFileLocation, PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT + pushPluginsEnabled); +} + +function createPushNotificationsEnabledHeaderFileWithMobileProvision(mobileProvision) { +var pathToProvisioningProfile = path.join(PATH_TO_MOBILE_PROVISIONS, sanitizeMobileProvision(mobileProvision)); + +exec("security cms -D -i \"" + pathToProvisioningProfile + "\"", function (error, stdout, stderr) { +logErrorIfExists(error); +var pushPluginsEnabled = stdout.indexOf("aps-environment") > -1; +createPushNotificationsEnabledHeaderFile(pushPluginsEnabled); +}); +} + +function isprovisionUUIDSuitable(provisionContents) { +return PROVISIONING_PROFILE_UUID_REGEX.test(provisionContents); +} + +function findValidMobileProvision(provisions, successCallback, errorCallback) { --- End diff -- If you want to follow the node convention the errorCallback should be passed before the success one. > Push Notifications code included by default > --- > > Key: CB-8084 > URL: https://issues.apache.org/jira/browse/CB-8084 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.5.0 >Reporter: Jacob Weber > > When creating a new Cordova app using the CLI, it adds code to AppDelegate.m > for Push Notifications. This causes Apple to issue a warning when you submit > the app, if your provisioning profile doesn't have Push Notifications enabled: > {quote} > Missing Push Notification Entitlement - Your app appears to include API used > to register with the Apple Push Notification service, but the app signature's > entitlements do not include the "aps-environment" entitlement. If your app > uses the Apple Push Notification service, make sure your App ID is enabled > for Push Notification in the Provisioning Portal, and resubmit after signing > your app with a Distribution provisioning profile that includes the > "aps-environment" entitlement. See "Provisioning and Development" in the > Local and Push Notification Programming Guide for more information. If your > app does not use the Apple Push Notification service, no action is required. > You may remove the API from future submissions to stop this warning. If you > use a third-party framework, you may need to contact the developer for > information on removing the API. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[ https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308917#comment-14308917 ] ASF GitHub Bot commented on CB-8084: Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230911 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +path = require('path'), +exec = require('child_process').exec, +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE = 'PushNotificationsEnabled.h', +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT = '#define PUSH_NOTIFICATIONS_ENABLED ', +EXPANDED_PROVISIONING_PROFILE = process.env.EXPANDED_PROVISIONING_PROFILE, +PATH_TO_MOBILE_PROVISIONS = path.join(process.env.HOME, 'Library', 'MobileDevice', 'Provisioning Profiles'), +PROVISIONING_PROFILE_REQUIRED = process.env.PROVISIONING_PROFILE_REQUIRED, +PROVISIONING_PROFILE_UUID_REGEX = new RegExp('UUID<\/key>[\\s\\S]*' + EXPANDED_PROVISIONING_PROFILE + '<\/string>'); + +function logErrorIfExists(error) { +if (error !== null) { +console.error('ERROR: ' + error); +} +} + +function sanitizeMobileProvision(mobileProvision) { +if (mobileProvision.indexOf('.mobileprovision') === -1) { +mobileProvision += '.mobileprovision'; +} + +return mobileProvision; +} + +function createPushNotificationsEnabledHeaderFile(pushPluginsEnabled) { +var cordovaEnablePluginHeaderFileLocation = path.join(__dirname, '..', '..', process.env.PROJECT_NAME, 'Classes', PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE); +fs.writeFileSync(cordovaEnablePluginHeaderFileLocation, PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT + pushPluginsEnabled); +} + +function createPushNotificationsEnabledHeaderFileWithMobileProvision(mobileProvision) { +var pathToProvisioningProfile = path.join(PATH_TO_MOBILE_PROVISIONS, sanitizeMobileProvision(mobileProvision)); + +exec("security cms -D -i \"" + pathToProvisioningProfile + "\"", function (error, stdout, stderr) { +logErrorIfExists(error); +var pushPluginsEnabled = stdout.indexOf("aps-environment") > -1; +createPushNotificationsEnabledHeaderFile(pushPluginsEnabled); +}); +} + +function isprovisionUUIDSuitable(provisionContents) { --- End diff -- Maybe the `p` should be capitalized here. > Push Notifications code included by default > --- > > Key: CB-8084 > URL: https://issues.apache.org/jira/browse/CB-8084 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.5.0 >Reporter: Jacob Weber > > When creating a new Cordova app using the CLI, it adds code to AppDelegate.m > for Push Notifications. This causes Apple to issue a warning when you submit > the app, if your provisioning profile doesn't have Push Notifications enabled: > {quote} > Missing Push Notification Entitlement - Your app appears to include API used > to register with the Apple Push Notification service, but the app signature's > entitlements do not include the "aps-environment" entitlement. If your app > uses the Apple Push Notification service, make sure your App ID is enabled > for Push Notification in the Provisioning Portal, and resubmit after signing > your app with a Distribution provisioning profile that includes the > "aps-environment" entitlement. See "Provisioning and Development" in the > Local and Push Notification Programming Guide for more information. If your > app does not use the Apple Push Notification service, no action is required. > You may remove the API from future submissions to stop this warning. If you > use a third-party framework, you may need to contact the developer for > information on removing the API. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[ https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308916#comment-14308916 ] ASF GitHub Bot commented on CB-8084: Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230887 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +path = require('path'), +exec = require('child_process').exec, +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE = 'PushNotificationsEnabled.h', +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT = '#define PUSH_NOTIFICATIONS_ENABLED ', +EXPANDED_PROVISIONING_PROFILE = process.env.EXPANDED_PROVISIONING_PROFILE, +PATH_TO_MOBILE_PROVISIONS = path.join(process.env.HOME, 'Library', 'MobileDevice', 'Provisioning Profiles'), +PROVISIONING_PROFILE_REQUIRED = process.env.PROVISIONING_PROFILE_REQUIRED, +PROVISIONING_PROFILE_UUID_REGEX = new RegExp('UUID<\/key>[\\s\\S]*' + EXPANDED_PROVISIONING_PROFILE + '<\/string>'); + +function logErrorIfExists(error) { +if (error !== null) { +console.error('ERROR: ' + error); +} +} + +function sanitizeMobileProvision(mobileProvision) { +if (mobileProvision.indexOf('.mobileprovision') === -1) { +mobileProvision += '.mobileprovision'; +} + +return mobileProvision; +} + +function createPushNotificationsEnabledHeaderFile(pushPluginsEnabled) { +var cordovaEnablePluginHeaderFileLocation = path.join(__dirname, '..', '..', process.env.PROJECT_NAME, 'Classes', PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE); +fs.writeFileSync(cordovaEnablePluginHeaderFileLocation, PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT + pushPluginsEnabled); +} + +function createPushNotificationsEnabledHeaderFileWithMobileProvision(mobileProvision) { +var pathToProvisioningProfile = path.join(PATH_TO_MOBILE_PROVISIONS, sanitizeMobileProvision(mobileProvision)); + +exec("security cms -D -i \"" + pathToProvisioningProfile + "\"", function (error, stdout, stderr) { +logErrorIfExists(error); +var pushPluginsEnabled = stdout.indexOf("aps-environment") > -1; --- End diff -- The variable name should be something like `hasPushNotificationsEntitlement` :smile: > Push Notifications code included by default > --- > > Key: CB-8084 > URL: https://issues.apache.org/jira/browse/CB-8084 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.5.0 >Reporter: Jacob Weber > > When creating a new Cordova app using the CLI, it adds code to AppDelegate.m > for Push Notifications. This causes Apple to issue a warning when you submit > the app, if your provisioning profile doesn't have Push Notifications enabled: > {quote} > Missing Push Notification Entitlement - Your app appears to include API used > to register with the Apple Push Notification service, but the app signature's > entitlements do not include the "aps-environment" entitlement. If your app > uses the Apple Push Notification service, make sure your App ID is enabled > for Push Notification in the Provisioning Portal, and resubmit after signing > your app with a Distribution provisioning profile that includes the > "aps-environment" entitlement. See "Provisioning and Development" in the > Local and Push Notification Programming Guide for more information. If your > app does not use the Apple Push Notification service, no action is required. > You may remove the API from future submissions to stop this warning. If you > use a third-party framework, you may need to contact the developer for > information on removing the API. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[ https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308914#comment-14308914 ] ASF GitHub Bot commented on CB-8084: Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230792 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +path = require('path'), +exec = require('child_process').exec, +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE = 'PushNotificationsEnabled.h', +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT = '#define PUSH_NOTIFICATIONS_ENABLED ', +EXPANDED_PROVISIONING_PROFILE = process.env.EXPANDED_PROVISIONING_PROFILE, +PATH_TO_MOBILE_PROVISIONS = path.join(process.env.HOME, 'Library', 'MobileDevice', 'Provisioning Profiles'), +PROVISIONING_PROFILE_REQUIRED = process.env.PROVISIONING_PROFILE_REQUIRED, +PROVISIONING_PROFILE_UUID_REGEX = new RegExp('UUID<\/key>[\\s\\S]*' + EXPANDED_PROVISIONING_PROFILE + '<\/string>'); + +function logErrorIfExists(error) { +if (error !== null) { +console.error('ERROR: ' + error); +} +} + +function sanitizeMobileProvision(mobileProvision) { +if (mobileProvision.indexOf('.mobileprovision') === -1) { +mobileProvision += '.mobileprovision'; +} + +return mobileProvision; +} + +function createPushNotificationsEnabledHeaderFile(pushPluginsEnabled) { +var cordovaEnablePluginHeaderFileLocation = path.join(__dirname, '..', '..', process.env.PROJECT_NAME, 'Classes', PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE); --- End diff -- The dirname of the project file should be available as an environment variable. > Push Notifications code included by default > --- > > Key: CB-8084 > URL: https://issues.apache.org/jira/browse/CB-8084 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.5.0 >Reporter: Jacob Weber > > When creating a new Cordova app using the CLI, it adds code to AppDelegate.m > for Push Notifications. This causes Apple to issue a warning when you submit > the app, if your provisioning profile doesn't have Push Notifications enabled: > {quote} > Missing Push Notification Entitlement - Your app appears to include API used > to register with the Apple Push Notification service, but the app signature's > entitlements do not include the "aps-environment" entitlement. If your app > uses the Apple Push Notification service, make sure your App ID is enabled > for Push Notification in the Provisioning Portal, and resubmit after signing > your app with a Distribution provisioning profile that includes the > "aps-environment" entitlement. See "Provisioning and Development" in the > Local and Push Notification Programming Guide for more information. If your > app does not use the Apple Push Notification service, no action is required. > You may remove the API from future submissions to stop this warning. If you > use a third-party framework, you may need to contact the developer for > information on removing the API. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[ https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308910#comment-14308910 ] ASF GitHub Bot commented on CB-8084: Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230690 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +path = require('path'), +exec = require('child_process').exec, +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE = 'PushNotificationsEnabled.h', +PUSH_NOTIFICATIONS_ENABLED_HEADER_FILE_CONTENT = '#define PUSH_NOTIFICATIONS_ENABLED ', +EXPANDED_PROVISIONING_PROFILE = process.env.EXPANDED_PROVISIONING_PROFILE, +PATH_TO_MOBILE_PROVISIONS = path.join(process.env.HOME, 'Library', 'MobileDevice', 'Provisioning Profiles'), +PROVISIONING_PROFILE_REQUIRED = process.env.PROVISIONING_PROFILE_REQUIRED, +PROVISIONING_PROFILE_UUID_REGEX = new RegExp('UUID<\/key>[\\s\\S]*' + EXPANDED_PROVISIONING_PROFILE + '<\/string>'); + +function logErrorIfExists(error) { +if (error !== null) { --- End diff -- You can use just `if(error)` here. > Push Notifications code included by default > --- > > Key: CB-8084 > URL: https://issues.apache.org/jira/browse/CB-8084 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.5.0 >Reporter: Jacob Weber > > When creating a new Cordova app using the CLI, it adds code to AppDelegate.m > for Push Notifications. This causes Apple to issue a warning when you submit > the app, if your provisioning profile doesn't have Push Notifications enabled: > {quote} > Missing Push Notification Entitlement - Your app appears to include API used > to register with the Apple Push Notification service, but the app signature's > entitlements do not include the "aps-environment" entitlement. If your app > uses the Apple Push Notification service, make sure your App ID is enabled > for Push Notification in the Provisioning Portal, and resubmit after signing > your app with a Distribution provisioning profile that includes the > "aps-environment" entitlement. See "Provisioning and Development" in the > Local and Push Notification Programming Guide for more information. If your > app does not use the Apple Push Notification service, no action is required. > You may remove the API from future submissions to stop this warning. If you > use a third-party framework, you may need to contact the developer for > information on removing the API. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test
[ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308891#comment-14308891 ] ASF GitHub Bot commented on CB-8412: Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73209662 On build 103 you can see this error message: https://ci.appveyor.com/project/Humbedooh/cordova-wp8/build/1.0.103 In order to see the failure, you have to pipe build output to test output, which is not desirable under normal circumstances - that's why I've changed it back to silent and it's not visible on 104. > WP8 platform should use JSHint as part of npm test > -- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen >Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of > travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test
[ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308885#comment-14308885 ] ASF GitHub Bot commented on CB-8412: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73208876 Not sure where you are seeing this error ... I see nothing in any of the failed build logs about Silverlight. > WP8 platform should use JSHint as part of npm test > -- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen >Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of > travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8227) Add --save option to 'cordova platform add'
[ https://issues.apache.org/jira/browse/CB-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308861#comment-14308861 ] ASF GitHub Bot commented on CB-8227: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73205488 asdf > Add --save option to 'cordova platform add' > --- > > Key: CB-8227 > URL: https://issues.apache.org/jira/browse/CB-8227 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI, CordovaLib >Reporter: Omar Mefire > Original Estimate: 48h > Remaining Estimate: 48h > > When run with the --save flag, the 'platform add' command will not only add > the specified platforms, but it will also save them to config.xml. > - When running this command, the pinned CLI version will be used if no > version is specified. > - config.xml will be ovewritten if similar engine has already been specified > in config.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8407) file-transfer plugin fails to download a file if to ms-appdata specified file on windows
[ https://issues.apache.org/jira/browse/CB-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov closed CB-8407. Resolution: Fixed > file-transfer plugin fails to download a file if to ms-appdata specified file > on windows > > > Key: CB-8407 > URL: https://issues.apache.org/jira/browse/CB-8407 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 0.4.8 > Environment: Windows platform > File-transfer plugin@0.4.9-dev > file plugin@1.3.4-dev >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: file, file-transfer, windows > > download() in file-transfer plugin expects path instead of internal URL on > windows > This bug seems to be introduced with these changes to cordova-plugin-file: > https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f > All tests for download method of file-transfer plugin now fail on windows > with following message: > Exception calling native with command :: FileTransfer :: download > ::exception=WinRTError: The parameter is incorrect. > As per internal discussion, this line may be the cause: > https://github.com/apache/cordova-plugin-file-transfer/blob/master/src/windows/FileTransferProxy.js#L166 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8436) 'cordova build --device' for ios doesn't produce correct application
[ https://issues.apache.org/jira/browse/CB-8436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308832#comment-14308832 ] ASF GitHub Bot commented on CB-8436: GitHub user Fatme opened a pull request: https://github.com/apache/cordova-ios/pull/130 CB-8436 Remove unneeded "" when composing xcodebuild arguments Fixes https://issues.apache.org/jira/browse/CB-8436 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-ios fatme/fix-build Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit d2d09207dbbfd4a2544ec3d3145c2175243612ce Author: Fatme Havaluova Date: 2015-02-05T16:20:40Z Remove unneeded "" when composing xcodebuild arguments > 'cordova build --device' for ios doesn't produce correct application > > > Key: CB-8436 > URL: https://issues.apache.org/jira/browse/CB-8436 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.8.0 > Environment: CLI OSX >Reporter: Fatme >Priority: Blocker > > When running 'cordova build --device', it buils successfully, but the build > produces the following warnings: > {code:borderStyle=solid} > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSDictionary+Extensions.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVInvokedUrlCommand.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSData+Base64.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVPluginResult.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVPlugin.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSMutableArray+QueueAdditions.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVWhitelist.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVURLProtocol.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVViewController.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVLocalStorage.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/UIDevice+Extensions.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSArray+Comparisons.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVCommandQueue.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVJSON_private.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVCommandDelegateImpl.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVConfigParser.m' > of type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVJSON.m' of > type sourcecode.c.objc for architecture armv7 armv7s arm64 > warning: no rule to process file > '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVUserAgentUtil.m' > of type sourcecode.c.objc for architecture armv7 armv7s a
[jira] [Commented] (CB-8407) file-transfer plugin fails to download a file if to ms-appdata specified file on windows
[ https://issues.apache.org/jira/browse/CB-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308813#comment-14308813 ] ASF subversion and git services commented on CB-8407: - Commit 7a93626812522e473248c7629238da81d03fb805 in cordova-plugin-file-transfer's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=7a93626 ] CB-8407 Use File proxy to construct valid FileEntry for download success callback Due to changes in file plugin (https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f) result of download method should now have filesystemName specified for proper work. This updates download method to construct FileEntry properly, using File plugin proxy. > file-transfer plugin fails to download a file if to ms-appdata specified file > on windows > > > Key: CB-8407 > URL: https://issues.apache.org/jira/browse/CB-8407 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 0.4.8 > Environment: Windows platform > File-transfer plugin@0.4.9-dev > file plugin@1.3.4-dev >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: file, file-transfer, windows > > download() in file-transfer plugin expects path instead of internal URL on > windows > This bug seems to be introduced with these changes to cordova-plugin-file: > https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f > All tests for download method of file-transfer plugin now fail on windows > with following message: > Exception calling native with command :: FileTransfer :: download > ::exception=WinRTError: The parameter is incorrect. > As per internal discussion, this line may be the cause: > https://github.com/apache/cordova-plugin-file-transfer/blob/master/src/windows/FileTransferProxy.js#L166 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8436) 'cordova build --device' for ios doesn't produce correct application
Fatme created CB-8436: - Summary: 'cordova build --device' for ios doesn't produce correct application Key: CB-8436 URL: https://issues.apache.org/jira/browse/CB-8436 Project: Apache Cordova Issue Type: Bug Affects Versions: 3.8.0 Environment: CLI OSX Reporter: Fatme Priority: Blocker When running 'cordova build --device', it buils successfully, but the build produces the following warnings: {code:borderStyle=solid} warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSDictionary+Extensions.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVInvokedUrlCommand.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSData+Base64.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVPluginResult.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVPlugin.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSMutableArray+QueueAdditions.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVWhitelist.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVURLProtocol.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVViewController.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVLocalStorage.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/UIDevice+Extensions.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/NSArray+Comparisons.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVCommandQueue.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVJSON_private.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVCommandDelegateImpl.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVConfigParser.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVJSON.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVUserAgentUtil.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVWebViewDelegate.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 warning: no rule to process file '/Users/havaluova/Work/cordova-ios/tmp/myApp/CordovaLib/Classes/CDVTimer.m' of type sourcecode.c.objc for architecture armv7 armv7s arm64 {code} If I try to deploy the produced application on devices, it fails {code} AMDeviceInstallApplication failed: 0xE867: Unknown error. {code} Actually the produced application doesn't have unix executable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8407) file-transfer plugin fails to download a file if to ms-appdata specified file on windows
[ https://issues.apache.org/jira/browse/CB-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308815#comment-14308815 ] ASF GitHub Bot commented on CB-8407: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/63 > file-transfer plugin fails to download a file if to ms-appdata specified file > on windows > > > Key: CB-8407 > URL: https://issues.apache.org/jira/browse/CB-8407 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 0.4.8 > Environment: Windows platform > File-transfer plugin@0.4.9-dev > file plugin@1.3.4-dev >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: file, file-transfer, windows > > download() in file-transfer plugin expects path instead of internal URL on > windows > This bug seems to be introduced with these changes to cordova-plugin-file: > https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f > All tests for download method of file-transfer plugin now fail on windows > with following message: > Exception calling native with command :: FileTransfer :: download > ::exception=WinRTError: The parameter is incorrect. > As per internal discussion, this line may be the cause: > https://github.com/apache/cordova-plugin-file-transfer/blob/master/src/windows/FileTransferProxy.js#L166 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8407) file-transfer plugin fails to download a file if to ms-appdata specified file on windows
[ https://issues.apache.org/jira/browse/CB-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308812#comment-14308812 ] ASF subversion and git services commented on CB-8407: - Commit 0394c0ce1eaf60f93ef1d529bc2fe1634d5d33da in cordova-plugin-file-transfer's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=0394c0c ] CB-8407 Removes excess path to native path conversion in download method This fixes file transfer download tests failures, when target file is specified by ms-appdata:/// uri on Windows. > file-transfer plugin fails to download a file if to ms-appdata specified file > on windows > > > Key: CB-8407 > URL: https://issues.apache.org/jira/browse/CB-8407 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 0.4.8 > Environment: Windows platform > File-transfer plugin@0.4.9-dev > file plugin@1.3.4-dev >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: file, file-transfer, windows > > download() in file-transfer plugin expects path instead of internal URL on > windows > This bug seems to be introduced with these changes to cordova-plugin-file: > https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f > All tests for download method of file-transfer plugin now fail on windows > with following message: > Exception calling native with command :: FileTransfer :: download > ::exception=WinRTError: The parameter is incorrect. > As per internal discussion, this line may be the cause: > https://github.com/apache/cordova-plugin-file-transfer/blob/master/src/windows/FileTransferProxy.js#L166 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8407) file-transfer plugin fails to download a file if to ms-appdata specified file on windows
[ https://issues.apache.org/jira/browse/CB-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308810#comment-14308810 ] ASF GitHub Bot commented on CB-8407: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-73199798 Reviewed and tested - LGTM :ship: > file-transfer plugin fails to download a file if to ms-appdata specified file > on windows > > > Key: CB-8407 > URL: https://issues.apache.org/jira/browse/CB-8407 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 0.4.8 > Environment: Windows platform > File-transfer plugin@0.4.9-dev > file plugin@1.3.4-dev >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: file, file-transfer, windows > > download() in file-transfer plugin expects path instead of internal URL on > windows > This bug seems to be introduced with these changes to cordova-plugin-file: > https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f > All tests for download method of file-transfer plugin now fail on windows > with following message: > Exception calling native with command :: FileTransfer :: download > ::exception=WinRTError: The parameter is incorrect. > As per internal discussion, this line may be the cause: > https://github.com/apache/cordova-plugin-file-transfer/blob/master/src/windows/FileTransferProxy.js#L166 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org