[jira] [Commented] (CB-8084) Push Notifications code included by default
[
https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319701#comment-14319701
]
Shazron Abdullah commented on CB-8084:
--
I've created CB-8473 (see links section) with dependent links (3 issues in all)
regarding what we are doing for this in cordova-ios 4.0
> Push Notifications code included by default
> ---
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Jacob Weber
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m
> for Push Notifications. This causes Apple to issue a warning when you submit
> the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used
> to register with the Apple Push Notification service, but the app signature's
> entitlements do not include the "aps-environment" entitlement. If your app
> uses the Apple Push Notification service, make sure your App ID is enabled
> for Push Notification in the Provisioning Portal, and resubmit after signing
> your app with a Distribution provisioning profile that includes the
> "aps-environment" entitlement. See "Provisioning and Development" in the
> Local and Push Notification Programming Guide for more information. If your
> app does not use the Apple Push Notification service, no action is required.
> You may remove the API from future submissions to stop this warning. If you
> use a third-party framework, you may need to contact the developer for
> information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8045) Android test for windows failed to deploy app
[
https://issues.apache.org/jira/browse/CB-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317681#comment-14317681
]
Angela Fowler edited comment on CB-8045 at 2/13/15 7:34 AM:
Still getting the timeout in the "Run Tests" step for Android in Mac
environment.
Added some logging to src/build/makers/android/deploy.js:
[ANDROID] [DEPLOY] adb -s emulator-5554 shell am start -n
org.apache.mobilespec/.MainActivity (Android__master__1423721520)
[ANDROID] [DEPLOY] adb -s emulator-5554 logcat -c (Android__master__1423721520)
[ANDROID] [DEPLOY] spawn logcat process (Android__master__1423721520)
[ANDROID] [DEPLOY] Mobile-spec timed out on emulator-5554, continuing.
(Android__master__1423721520)
Android test prepare failed
Seems to be here:
var logcat = cp.spawn('adb', ['-s', d,
'logcat']);
was (Author: amfowler):
Still getting the timeout in the "Run Tests" step.
Added some logging to src/build/makers/android/deploy.js:
[ANDROID] [DEPLOY] adb -s emulator-5554 shell am start -n
org.apache.mobilespec/.MainActivity (Android__master__1423721520)
[ANDROID] [DEPLOY] adb -s emulator-5554 logcat -c (Android__master__1423721520)
[ANDROID] [DEPLOY] spawn logcat process (Android__master__1423721520)
[ANDROID] [DEPLOY] Mobile-spec timed out on emulator-5554, continuing.
(Android__master__1423721520)
Android test prepare failed
Seems to be here:
var logcat = cp.spawn('adb', ['-s', d,
'logcat']);
> Android test for windows failed to deploy app
> -
>
> Key: CB-8045
> URL: https://issues.apache.org/jira/browse/CB-8045
> Project: Apache Cordova
> Issue Type: Test
> Components: Android, Medic
>Reporter: Maria Bukharina
>
> Repo steps:
> 1. Set up medic configuration
> 2. Create android emutlator
> 3. Run AndroidWin build
> Deploy step failed:]
> [ANDROID] [DEPLOY] Mobile-spec timed out on emulator-5554, continuing.
> (Android__master__1416321767)
> Android test prepare failed
> program finished with exit code 1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8474) Remove local/remote push notification delegates from CordovaAppDelegate
[ https://issues.apache.org/jira/browse/CB-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-8474: - Description: They should be in a plugin, in the cordova-plugins repo, that swizzles the appropriate delegates (see CB-8475) See dependent and is depended on linked issues. was: They should be in a plugin, in the cordova-plugins repo, that swizzles the appropriate delegates (see CB-) See dependent and is depended on linked issues. > Remove local/remote push notification delegates from CordovaAppDelegate > --- > > Key: CB-8474 > URL: https://issues.apache.org/jira/browse/CB-8474 > Project: Apache Cordova > Issue Type: Task > Components: iOS >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > They should be in a plugin, in the cordova-plugins repo, that swizzles the > appropriate delegates (see CB-8475) > See dependent and is depended on linked issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8475) Create plugin to handle local/remote push notification delegates in the app delegate
Shazron Abdullah created CB-8475: Summary: Create plugin to handle local/remote push notification delegates in the app delegate Key: CB-8475 URL: https://issues.apache.org/jira/browse/CB-8475 Project: Apache Cordova Issue Type: Task Components: iOS, Plugins Reporter: Shazron Abdullah Fix For: 4.0.0 These refer to the 3 delegates that were in AppDelegate.m in the template. See dependent issue. Plugin should reside in the cordova-plugins repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8474) Remove local/remote push notification delegates from CordovaAppDelegate
Shazron Abdullah created CB-8474: Summary: Remove local/remote push notification delegates from CordovaAppDelegate Key: CB-8474 URL: https://issues.apache.org/jira/browse/CB-8474 Project: Apache Cordova Issue Type: Task Components: iOS Reporter: Shazron Abdullah Fix For: 4.0.0 They should be in a plugin, in the cordova-plugins repo, that swizzles the appropriate delegates (see CB-) See dependent and is depended on linked issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8473) Remove AppDelegate code from template
Shazron Abdullah created CB-8473: Summary: Remove AppDelegate code from template Key: CB-8473 URL: https://issues.apache.org/jira/browse/CB-8473 Project: Apache Cordova Issue Type: Task Components: iOS Reporter: Shazron Abdullah Fix For: 4.0.0 1. Move the AppDelegate code into the CordovaLib project (e.g. CordovaAppDelegate) 2. Make the template AppDelegate class inherit from CordovaAppDelegate, and just be empty -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8472) Exception (can't find config.xml) installing platform after plugins
[
https://issues.apache.org/jira/browse/CB-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Barham updated CB-8472:
---
Description:
If you add a platform after adding a plugin, you can get an exception
h4. Repro steps:
# Create a new cordova app (e.g. 'cordova create TestApp').
# Add a plugin (e.g. 'cordova plugin add org.apache.cordova.camera').
# Add a platform (e.g. 'cordova platform add browser').
h4. Result:
The following error:
{code}Failed to install 'org.apache.cordova.camera':Error: ENOENT, no such file
or
directory
'D:\tbarham\OneDrive\Documents\CordovaApps\TestApp\platforms\browser\config.xml'
at Error (native)
at Object.fs.openSync (fs.js:502:18)
at Object.fs.readFileSync (fs.js:354:15)
at Object.module.exports.parseElementtreeSync
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\util\xml-helpers.js:118:27)
at Object.module.exports.package_name
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\browser.js:51:38)
at PlatformMunger.generate_plugin_config_munge
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:264:54)
at PlatformMunger.add_plugin_changes
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:184:29)
at
D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:315:14
at Array.forEach (native)
at PlatformMunger_process [as process]
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:314:45){code}
The problem is we are trying to install plugins for the platform before we call
prepare() for the platform, so config.xml has not been created yet.
*Also note:* we are currently passing junk to prepare() - because of the
location of the call, the local variable _platform_ is not defined, and instead
we are passing a reference to a function _platform()_.
was:
If you add a platform after adding a plugin, you can get an exception
h4. Repro steps:
# Create a new cordova app (e.g. 'cordova create TestApp').
# Add a plugin (e.g. 'cordova plugin add org.apache.cordova.camera').
# Add a platform (e.g. 'cordova platform add browser').
h4. Result:
The following error:
{code}Failed to install 'org.apache.cordova.camera':Error: ENOENT, no such file
or
directory
'D:\tbarham\OneDrive\Documents\CordovaApps\TestApp\platforms\browser\config.xml'
at Error (native)
at Object.fs.openSync (fs.js:502:18)
at Object.fs.readFileSync (fs.js:354:15)
at Object.module.exports.parseElementtreeSync
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\util\xml-helpers.js:118:27)
at Object.module.exports.package_name
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\browser.js:51:38)
at PlatformMunger.generate_plugin_config_munge
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:264:54)
at PlatformMunger.add_plugin_changes
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:184:29)
at
D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:315:14
at Array.forEach (native)
at PlatformMunger_process [as process]
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:314:45){code}
The problem is we are trying to install plugins for the platform before we call
prepare() for the platform, so config.xml has not been created yet.
> Exception (can't find config.xml) installing platform after plugins
> ---
>
> Key: CB-8472
> URL: https://issues.apache.org/jira/browse/CB-8472
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: Master
>Reporter: Tim Barham
>Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> If you add a platform after adding a plugin, you can get an exception
> h4. Repro steps:
> # Create a new cordova app (e.g. 'cordova create TestApp').
> # Add a plugin (e.g. 'cordova plugin add org.apache.cordova.camera').
> # Add a platform (e.g. 'cordova platform add browser').
> h4. Result:
> The following error:
> {code}Failed to install 'org.apache.cordova.camera':Error: ENOENT, no such
> file or
> directory
> 'D:\tbarham\OneDrive\Documents\CordovaApps\TestApp\platforms\browser\config.xml'
> at Error (native)
> at Object.fs.openSync (fs.js:502:18)
> at Object.fs.readFileSync (fs.js:354:15)
> at Object.module.exports.parseElementtreeSync
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\util\xml-helpers.js:118:27)
> at Object.module.exports.package_name
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\browser.js:51:38)
> at PlatformMunger.generate_plugin_config_munge
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:264:54)
> at PlatformMunger.add_plugin_changes
> (D:\GIT\Cordova\cordova
[jira] [Commented] (CB-8472) Exception (can't find config.xml) installing platform after plugins
[
https://issues.apache.org/jira/browse/CB-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319558#comment-14319558
]
Tim Barham commented on CB-8472:
I have a fix for this and will be sending it out for CR soon.
> Exception (can't find config.xml) installing platform after plugins
> ---
>
> Key: CB-8472
> URL: https://issues.apache.org/jira/browse/CB-8472
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: Master
>Reporter: Tim Barham
>Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> If you add a platform after adding a plugin, you can get an exception
> h4. Repro steps:
> # Create a new cordova app (e.g. 'cordova create TestApp').
> # Add a plugin (e.g. 'cordova plugin add org.apache.cordova.camera').
> # Add a platform (e.g. 'cordova platform add browser').
> h4. Result:
> The following error:
> {code}Failed to install 'org.apache.cordova.camera':Error: ENOENT, no such
> file or
> directory
> 'D:\tbarham\OneDrive\Documents\CordovaApps\TestApp\platforms\browser\config.xml'
> at Error (native)
> at Object.fs.openSync (fs.js:502:18)
> at Object.fs.readFileSync (fs.js:354:15)
> at Object.module.exports.parseElementtreeSync
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\util\xml-helpers.js:118:27)
> at Object.module.exports.package_name
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\browser.js:51:38)
> at PlatformMunger.generate_plugin_config_munge
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:264:54)
> at PlatformMunger.add_plugin_changes
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:184:29)
> at
> D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:315:14
> at Array.forEach (native)
> at PlatformMunger_process [as process]
> (D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:314:45){code}
> The problem is we are trying to install plugins for the platform before we
> call prepare() for the platform, so config.xml has not been created yet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8472) Exception (can't find config.xml) installing platform after plugins
Tim Barham created CB-8472:
--
Summary: Exception (can't find config.xml) installing platform
after plugins
Key: CB-8472
URL: https://issues.apache.org/jira/browse/CB-8472
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Affects Versions: Master
Reporter: Tim Barham
Priority: Critical
If you add a platform after adding a plugin, you can get an exception
h4. Repro steps:
# Create a new cordova app (e.g. 'cordova create TestApp').
# Add a plugin (e.g. 'cordova plugin add org.apache.cordova.camera').
# Add a platform (e.g. 'cordova platform add browser').
h4. Result:
The following error:
{code}Failed to install 'org.apache.cordova.camera':Error: ENOENT, no such file
or
directory
'D:\tbarham\OneDrive\Documents\CordovaApps\TestApp\platforms\browser\config.xml'
at Error (native)
at Object.fs.openSync (fs.js:502:18)
at Object.fs.readFileSync (fs.js:354:15)
at Object.module.exports.parseElementtreeSync
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\util\xml-helpers.js:118:27)
at Object.module.exports.package_name
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\browser.js:51:38)
at PlatformMunger.generate_plugin_config_munge
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:264:54)
at PlatformMunger.add_plugin_changes
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:184:29)
at
D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:315:14
at Array.forEach (native)
at PlatformMunger_process [as process]
(D:\GIT\Cordova\cordova-lib\cordova-lib\src\plugman\util\config-changes.js:314:45){code}
The problem is we are trying to install plugins for the platform before we call
prepare() for the platform, so config.xml has not been created yet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8084) Push Notifications code included by default
[
https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319444#comment-14319444
]
Shazron Abdullah edited comment on CB-8084 at 2/13/15 2:07 AM:
---
I'm reluctant to put this code in since it will be ripped out later in 4.0. The
3.8.0 release is long overdue and since it doesn't really affect upload
(warning for now) I'd rather leave it be for now.
What I can do is wrap the remote/local notification code in the AppDelegate
with:
{code}
#ifndef DISABLE_PUSH_NOTIFICATIONS
// delegate code here
#endif
{code}
This means by default the delegate functions are enabled, like always
(backwards compatible). Through a build hook (which can be installed through a
plugin, or just copied into the project), the code that was in the pull request
can be run where it adds the DISABLE_PUSH_NOTIFICATIONS = 1 in the
build.xcconfig file.
was (Author: shazron):
I'm reluctant to put this code since it will be ripped out later in 4.0. The
3.8.0 release is long overdue and since it doesn't really affect upload
(warning for now) I'd rather leave it be for now.
What I can do is wrap the remote/local notification code in the AppDelegate
with:
{code}
#ifndef DISABLE_PUSH_NOTIFICATIONS
// delegate code here
#endif
{code}
This means by default the delegate functions are enabled, like always
(backwards compatible). Through a build hook (which can be installed through a
plugin, or just copied into the project), the code that was in the pull request
can be run where it adds the DISABLE_PUSH_NOTIFICATIONS = 1 in the
build.xcconfig file.
> Push Notifications code included by default
> ---
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Jacob Weber
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m
> for Push Notifications. This causes Apple to issue a warning when you submit
> the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used
> to register with the Apple Push Notification service, but the app signature's
> entitlements do not include the "aps-environment" entitlement. If your app
> uses the Apple Push Notification service, make sure your App ID is enabled
> for Push Notification in the Provisioning Portal, and resubmit after signing
> your app with a Distribution provisioning profile that includes the
> "aps-environment" entitlement. See "Provisioning and Development" in the
> Local and Push Notification Programming Guide for more information. If your
> app does not use the Apple Push Notification service, no action is required.
> You may remove the API from future submissions to stop this warning. If you
> use a third-party framework, you may need to contact the developer for
> information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[
https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319447#comment-14319447
]
ASF GitHub Bot commented on CB-8084:
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/128#issuecomment-74192861
See the latest comment in https://issues.apache.org/jira/browse/CB-8084 and
please continue the discussion there, thanks.
> Push Notifications code included by default
> ---
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Jacob Weber
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m
> for Push Notifications. This causes Apple to issue a warning when you submit
> the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used
> to register with the Apple Push Notification service, but the app signature's
> entitlements do not include the "aps-environment" entitlement. If your app
> uses the Apple Push Notification service, make sure your App ID is enabled
> for Push Notification in the Provisioning Portal, and resubmit after signing
> your app with a Distribution provisioning profile that includes the
> "aps-environment" entitlement. See "Provisioning and Development" in the
> Local and Push Notification Programming Guide for more information. If your
> app does not use the Apple Push Notification service, no action is required.
> You may remove the API from future submissions to stop this warning. If you
> use a third-party framework, you may need to contact the developer for
> information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[
https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319444#comment-14319444
]
Shazron Abdullah commented on CB-8084:
--
I'm reluctant to put this code since it will be ripped out later in 4.0. The
3.8.0 release is long overdue and since it doesn't really affect upload
(warning for now) I'd rather leave it be for now.
What I can do is wrap the remote/local notification code in the AppDelegate
with:
{code}
#ifndef DISABLE_PUSH_NOTIFICATIONS
// delegate code here
#endif
{code}
This means by default the delegate functions are enabled, like always
(backwards compatible). Through a build hook (which can be installed through a
plugin, or just copied into the project), the code that was in the pull request
can be run where it adds the DISABLE_PUSH_NOTIFICATIONS = 1 in the
build.xcconfig file.
> Push Notifications code included by default
> ---
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Jacob Weber
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m
> for Push Notifications. This causes Apple to issue a warning when you submit
> the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used
> to register with the Apple Push Notification service, but the app signature's
> entitlements do not include the "aps-environment" entitlement. If your app
> uses the Apple Push Notification service, make sure your App ID is enabled
> for Push Notification in the Provisioning Portal, and resubmit after signing
> your app with a Distribution provisioning profile that includes the
> "aps-environment" entitlement. See "Provisioning and Development" in the
> Local and Push Notification Programming Guide for more information. If your
> app does not use the Apple Push Notification service, no action is required.
> You may remove the API from future submissions to stop this warning. If you
> use a third-party framework, you may need to contact the developer for
> information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319429#comment-14319429 ] Shazron Abdullah commented on CB-7606: -- Alright, I've only gotten one piece of feedback (Brian de Alwis) regarding this fix. I'm going to proceed tomorrow on integrating, testing and releasing 3.8.0 based on my own tests. I can always patch the release branch if someone finds anything. > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8028) handleOpenURL doesn't work properly when app is being launched for the first time
[
https://issues.apache.org/jira/browse/CB-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319430#comment-14319430
]
Shazron Abdullah commented on CB-8028:
--
Alright, I've only gotten one piece of feedback (Brian de Alwis) regarding this
fix. I'm going to proceed tomorrow on integrating, testing and releasing 3.8.0
based on my own tests. I can always patch the release branch if someone finds
anything.
> handleOpenURL doesn't work properly when app is being launched for the first
> time
> -
>
> Key: CB-8028
> URL: https://issues.apache.org/jira/browse/CB-8028
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.7.0
>Reporter: Antonio Laguna
>Assignee: Shazron Abdullah
> Fix For: 3.8.0
>
>
> Hi!
> Please bear in mind that this is my first issue being reported here but I
> thought it to be worth it.
> So, we've been developing a Cordova application lately and we decided to add
> a notification center plugin to be able to launch the application from it,
> taking advantage of the url-scheme on iOS.
> We discovered that it worked flawlessly when it was launched and the app was
> in background but it wasn't when the app was closed and tried to launch from
> there.
> So I dug deeper.
> Since this is an Ionic application, I thought the issue was due to Angular
> not being ready at the appropriate time or something like that so I just put
> something really low-level which didn't depend on any library:
> {code:javascript}
> window.foo = 'bar';
> {code}
> And then checked with a timeout (after app was ready) to see if it was there.
> But it wasn't.
> So I dug deeper.
> So the issue seems to come on this function which is on the
> {{CDDViewController}} class
> {code}
> - (void)processOpenUrl:(NSURL*)url pageLoaded:(BOOL)pageLoaded
> {
> if (!pageLoaded) {
> // query the webview for readystate
> NSString* readyState = [webView
> stringByEvaluatingJavaScriptFromString:@"document.readyState"];
> pageLoaded = [readyState isEqualToString:@"loaded"] || [readyState
> isEqualToString:@"complete"];
> }
> if (pageLoaded) {
> // calls into javascript global function 'handleOpenURL'
> NSString* jsString = [NSString stringWithFormat:@"if (typeof
> handleOpenURL === 'function') { handleOpenURL(\"%@\");}", url];
> [self.webView stringByEvaluatingJavaScriptFromString:jsString];
> } else {
> // save for when page has loaded
> self.openURL = url;
> }
> }
> {code}
> The thing is that the second check for {{pageLoaded}} is positive even though
> the page is clearly at a really early stage. The Splash is still being shown
> and the DOM although it may be ready-ish, it doesn't work properly (clearly).
> This is the flow:
> * It comes first by {{(void)processOpenUrl:(NSURL*)url}} - The
> {{handleOpenUrl}} function is then called cause even though {{NO}} is passed
> as a parameter, Cordova gets to think it's ready.
> * Then it comes to {{onPageDidLoad}} which would call
> {{(void)processOpenUrl:(NSURL*)url pageLoaded:(BOOL)pageLoaded}} too but
> since {{openURL}} hasn't been saved this time, it won't do anything
> Just to make sure of things, I tried to {{self.openURL = url;}} even if the
> page was loaded and that turned out to work.
> I don't understand the implications of this but IMHO, {{onPageDidLoad}} is a
> better point to understand wether the app is ready or not than querying the
> document like that cause the code doesn't seem to be there yet.
> Please note that I put my handler before anything else on the header to
> ensure it wasn't a racing issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8469) Android projects are not importable by Android Studio until after first build
[ https://issues.apache.org/jira/browse/CB-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-8469. --- Resolution: Fixed Fixed in cordova-android@master (for initial project creation), and fixed in cordova-lib@4.2.1-dev (for plugin add) > Android projects are not importable by Android Studio until after first build > - > > Key: CB-8469 > URL: https://issues.apache.org/jira/browse/CB-8469 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > This will certainly trip up many people. Trick is that we need to do the > build.js logic where gradle files are added in: > 1. as part of create script > 2. as part of "plugin add", where plugins contain -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8469) Android projects are not importable by Android Studio until after first build
[ https://issues.apache.org/jira/browse/CB-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319416#comment-14319416 ] ASF subversion and git services commented on CB-8469: - Commit d77ebc40a16ab27a8ed22c0bbf2ab8a84a5ac448 in cordova-lib's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d77ebc4 ] CB-8469 android: Call into platform's build.js after `plugin add` so that Android Studio will work without needing an explicit command-line build first > Android projects are not importable by Android Studio until after first build > - > > Key: CB-8469 > URL: https://issues.apache.org/jira/browse/CB-8469 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > This will certainly trip up many people. Trick is that we need to do the > build.js logic where gradle files are added in: > 1. as part of create script > 2. as part of "plugin add", where plugins contain -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-2419) On Windows 8, Camera.getPicture does not return file URI
[
https://issues.apache.org/jira/browse/CB-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319366#comment-14319366
]
Don Becker commented on CB-2419:
What version is this issue resolved in? Looking at the above commits,
URL.createObjectURL() is still called on the file before the callback is
called. The blobs are fine for displaying the images that are selected via an
, but I am unable to copy the file from a Blob.
> On Windows 8, Camera.getPicture does not return file URI
>
>
> Key: CB-2419
> URL: https://issues.apache.org/jira/browse/CB-2419
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera, Windows 8
>Affects Versions: 2.4.0
>Reporter: Youval Bronicki
>Assignee: Jesse MacFadyen
>
> The camera.getPicture method returns a blob: URI when a File URI is requested.
> I've been able to tweak it to my needs by changing:
> {{_imageUrl = URL.createObjectURL(storageFile);}}
> to:
> {{var _imageUrl = storageFile.path;}}
> However the result is not strictly speaking a FILE URI, so that may not be
> the preferred solution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-8416. Resolution: Fixed > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319353#comment-14319353 ] ASF subversion and git services commented on CB-8416: - Commit 0d0279c84c82bb2aa79a8a116184b4f43617c0cb in cordova-lib's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=0d0279c ] Merge branch 'master' into CB-8416 > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319351#comment-14319351 ] ASF subversion and git services commented on CB-8416: - Commit fcf37d03d12301d26cb4bcbb0107b085325f40d6 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fcf37d0 ] CB-8416: added createpackagejson command > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319352#comment-14319352 ] ASF subversion and git services commented on CB-8416: - Commit adab8c9accfd769019837bb1cc36a2975f9742b0 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=adab8c9 ] CB-8416 updated plugman publish to temporarily rename existing package.json files > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319354#comment-14319354 ] ASF subversion and git services commented on CB-8416: - Commit f37d6a6f1149fdc554d9e7e2179c2a7f028ef9ca in cordova-lib's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f37d6a6 ] Merge branch 'master' into CB-8416 > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8420) 'cordova plugin add' should look into config.xml for correct feature element when no version is provided
[ https://issues.apache.org/jira/browse/CB-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319342#comment-14319342 ] ASF subversion and git services commented on CB-8420: - Commit 629b8867cd44a4d89b5dadd17e1b33f8cbf8b120 in cordova-lib's branch refs/heads/CB-8416 from [~omefire] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=629b886 ] CB-8420 Make `cordova plugin add FOO` use version from config.xml (close #162) > 'cordova plugin add' should look into config.xml for correct feature element > when no version is provided > > > Key: CB-8420 > URL: https://issues.apache.org/jira/browse/CB-8420 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib >Reporter: Omar Mefire >Assignee: Omar Mefire > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8416) Add createpackagejson command to plugman
[ https://issues.apache.org/jira/browse/CB-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319344#comment-14319344 ] ASF subversion and git services commented on CB-8416: - Commit f37d6a6f1149fdc554d9e7e2179c2a7f028ef9ca in cordova-lib's branch refs/heads/CB-8416 from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f37d6a6 ] Merge branch 'master' into CB-8416 > Add createpackagejson command to plugman > > > Key: CB-8416 > URL: https://issues.apache.org/jira/browse/CB-8416 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib, Plugman >Reporter: Steve Gill >Assignee: Steve Gill > > I am going to create a createpackagejson command in plugman that will build a > package.json file similar to > https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json > from plugin.xml. Other plugin devs will be able to use this command to > quickly add package.json files to their plugins. > I will then modify plugman publish to use the createpackagejson command if > needed. Plugman publish will still have to add the contents of the readme (or > doc/index.md) to the package.json as well as the platforms tag if we decide > to remove it. It will also have to change the package-name field to > package-id when publishing to CPR. Once published, we can remove these > changes package.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform
[ https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319343#comment-14319343 ] ASF subversion and git services commented on CB-8123: - Commit 37567dab758874b56731e211d32b855e28116d99 in cordova-lib's branch refs/heads/CB-8416 from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=37567da ] Merge branch 'CB-8123-final' of https://github.com/MSOpenTech/cordova-lib > Enable version, device, and chip arch specific library / dll / winmd > references in plugins for the Windows platform > --- > > Key: CB-8123 > URL: https://issues.apache.org/jira/browse/CB-8123 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugins, Windows >Reporter: Tim Barham > Original Estimate: 72h > Remaining Estimate: 72h > > Because Cordova's windows platform can target multiple target platforms, > projects and frameworks referenced by the plugin may need to target only a > subset of those platforms. To enable this, support the following attributes > on the and elements: > 1. device - indicates the reference is specific to a target device. Supported > values are "phone", "windows" or "all" (default is "all"). > 2. versions - specify platform versions the reference supports (node semantic > version ranges supported). Default is to support all versions. > 3. arch - indicates the reference is specific to a particular chip > architecture (x86 or x64). > The "arch" attribute should result in a Condition="'$(Platform)'=='XXX" > attribute on the reference. The other attributes will impact which generated > jsproj files the reference is actually added to. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform
[ https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319341#comment-14319341 ] ASF subversion and git services commented on CB-8123: - Commit 98d17dd7976af2cdd3b7bfa9ce0612728dd5e6d7 in cordova-lib's branch refs/heads/CB-8416 from [~TimBarham] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=98d17dd ] CB-8123 Fix JSHINT issue. > Enable version, device, and chip arch specific library / dll / winmd > references in plugins for the Windows platform > --- > > Key: CB-8123 > URL: https://issues.apache.org/jira/browse/CB-8123 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugins, Windows >Reporter: Tim Barham > Original Estimate: 72h > Remaining Estimate: 72h > > Because Cordova's windows platform can target multiple target platforms, > projects and frameworks referenced by the plugin may need to target only a > subset of those platforms. To enable this, support the following attributes > on the and elements: > 1. device - indicates the reference is specific to a target device. Supported > values are "phone", "windows" or "all" (default is "all"). > 2. versions - specify platform versions the reference supports (node semantic > version ranges supported). Default is to support all versions. > 3. arch - indicates the reference is specific to a particular chip > architecture (x86 or x64). > The "arch" attribute should result in a Condition="'$(Platform)'=='XXX" > attribute on the reference. The other attributes will impact which generated > jsproj files the reference is actually added to. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform
[ https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319340#comment-14319340 ] ASF subversion and git services commented on CB-8123: - Commit d98343e34bb70d2262ef212726947e9c511a1808 in cordova-lib's branch refs/heads/CB-8416 from [~TimBarham] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d98343e ] Merge branch 'master' into CB-8123-temp Conflicts: cordova-lib/spec-plugman/platforms/windows8.spec.js > Enable version, device, and chip arch specific library / dll / winmd > references in plugins for the Windows platform > --- > > Key: CB-8123 > URL: https://issues.apache.org/jira/browse/CB-8123 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugins, Windows >Reporter: Tim Barham > Original Estimate: 72h > Remaining Estimate: 72h > > Because Cordova's windows platform can target multiple target platforms, > projects and frameworks referenced by the plugin may need to target only a > subset of those platforms. To enable this, support the following attributes > on the and elements: > 1. device - indicates the reference is specific to a target device. Supported > values are "phone", "windows" or "all" (default is "all"). > 2. versions - specify platform versions the reference supports (node semantic > version ranges supported). Default is to support all versions. > 3. arch - indicates the reference is specific to a particular chip > architecture (x86 or x64). > The "arch" attribute should result in a Condition="'$(Platform)'=='XXX" > attribute on the reference. The other attributes will impact which generated > jsproj files the reference is actually added to. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8471) Impossible to resume FileTransfer download
Mike Dawson created CB-8471:
---
Summary: Impossible to resume FileTransfer download
Key: CB-8471
URL: https://issues.apache.org/jira/browse/CB-8471
Project: Apache Cordova
Issue Type: Improvement
Components: Plugin File Transfer
Reporter: Mike Dawson
Problem is when using the FileTransfer plugin to download a file, if the file
is interrupted it will get automatically deleted. It is therefor impossible to
implement any kind of resume logic to resume the download and one can only
restart from scratch. If you are downloading on unreliable networks then your
chances of ever succeeding will be very poor with larger files.
This is what happens on Android (FileTransfer.java line 948):
// Remove incomplete download.
if (!cached && result.getStatus() != PluginResult.Status.OK.ordinal() && file
!= null) {
file.delete();
}
I suggest there should be an option keepIncompleteDownload that would allow the
partial download to be kept. Developers could then implement their own logic
in Javascript to get the next part of the file using range headers and
concatenate the parts together to reform the whole file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8470) Image quality always set to 50 for android in org.apache.cordova.camera
Kate Hudson created CB-8470: --- Summary: Image quality always set to 50 for android in org.apache.cordova.camera Key: CB-8470 URL: https://issues.apache.org/jira/browse/CB-8470 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Reporter: Kate Hudson No matter what I set the quality to in the js api, the quality returned on Android is always 50. Code is here: https://github.com/mozilla/webmaker-app/blob/master/components/imagePicker/index.js#L28 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319098#comment-14319098 ] Brian de Alwis commented on CB-7606: I applied this fix against 3.7.0 and it seems to have fixed the cold-start issues that I have been encountering. Thanks! > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8444) Don't clobber `window.open`
[ https://issues.apache.org/jira/browse/CB-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319060#comment-14319060 ] ASF GitHub Bot commented on CB-8444: GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/80 CB-8444 Don't clobber `window.open` There are scenarios where an app needs the built-in `window.open` functionality (i.e. to open an url in the system browser). As the InAppBrowser clobbers window.open, it requires the app to either change all affected `window.open` calls (to add "target=_system"), or undo the clobber. This clobber is particularly problematic when InAppBrowser is added to an app as a dependency of another plugin. For example, a plugin that provides an external web-based authentication flow. Instead, each app should be able to control whether `window.open` is clobbered, regardless of the inclusion of the InAppBrowser plugin. This PR is a first step to add a new API to access the InAppBrowser, separately from `window.open`. The intention is to then remove the clobber of `window.open` in a future release. Changes: - Add new symbol/clobber to access open function (`cordova.InAppBrowser.open`) - Change existing tests to use new symbol (i.e. don't rely on plugin clobber of `window.open`) - Add tests to use `window.open` via manual replace with new symbol - Update docs to deprecate plugin clobber of `window.open` You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpchase/cordova-plugin-inappbrowser CB-8444 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit ad263a1b539660b00e4cd4d4c5ac7be38acf9351 Author: Jason Chase Date: 2015-02-12T21:34:32Z CB-8444 Don't clobber `window.open` - Add new symbol/clobber to access open function (`cordova.InAppBrowser.open`) - Change existing tests to use new symbol (i.e. don't rely on plugin clobber of `window.open`) - Add tests to use `window.open` via manual replace with new symbol - Update docs to deprecate plugin clobber of `window.open` > Don't clobber `window.open` > --- > > Key: CB-8444 > URL: https://issues.apache.org/jira/browse/CB-8444 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin InAppBrowser >Reporter: sandstrom >Assignee: Jason Chase > > Where Cordova plugins map 1:1 to W3C API's it's great that they clobber the > corresponding namespace. Geolocation is a good example. > However, it doesn't really feel like this plugin is a 1:1, so perhaps it > should be available at another name, e.g. `window.iabOpen` (the old API > should be preserved until the next major though, since to keep backward > compatibility). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8469) Android projects are not importable by Android Studio until after first build
[ https://issues.apache.org/jira/browse/CB-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318991#comment-14318991 ] ASF subversion and git services commented on CB-8469: - Commit db18e1480ee26f47c6cbb6763627d60b735c0167 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=db18e14 ] CB-8469 Create gradle build files as part of create script Makes project imporatable by Android Studio before first build > Android projects are not importable by Android Studio until after first build > - > > Key: CB-8469 > URL: https://issues.apache.org/jira/browse/CB-8469 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > This will certainly trip up many people. Trick is that we need to do the > build.js logic where gradle files are added in: > 1. as part of create script > 2. as part of "plugin add", where plugins contain -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8468) Application freezes if breakpoint hits JavaScript callback invoked from native
[
https://issues.apache.org/jira/browse/CB-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Pridham updated CB-8468:
---
Summary: Application freezes if breakpoint hits JavaScript callback invoked
from native (was: Applications freezes if breakpoint hits JavaScript callback
invoked from native)
> Application freezes if breakpoint hits JavaScript callback invoked from native
> --
>
> Key: CB-8468
> URL: https://issues.apache.org/jira/browse/CB-8468
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Reporter: Marcus Pridham
>Priority: Minor
>
> It you attach Safari to your application and hit a breakpoint in a Cordova
> callback the application freezes and you can't step through or continue.
> This only happens in breakpoints in the native to JavaScript callbacks.
> JavaScript breakpoints in other areas work fine.
> A simple way to reproduce is to use the globalization plugin. Attach safari
> and put a breakpoint in the success callback.
> navigator.globalization.getPreferredLanguage(function() {
> console.log("test"); // Will freeze if breakpoint set here
> }, function() {});
> The problem seems to have to do with the webview
> stringByEvaluatingJavaScriptFromString. It is a synchronous call that can
> return the result of the JavaScript back to the native. The native code will
> crash if a breakpoint is hit while trying to execute the JavaScript. The
> workaround is to have your callback code in a setTimeout so it is not in the
> same context as the native stringByEvaluatingJavaScriptFromString call.
>
> A workaround:
>
> Open cordova.js and around line 281 replace:
>
> callbackFromNative: function(callbackId, isSuccess, status, args,
> keepCallback) {
>
> With:
>
> callbackFromNative: function(callbackId, isSuccess, status, args,
> keepCallback) {
>setTimeout(function() {
> cordova.callbackFromNative2(callbackId, isSuccess, status, args,
> keepCallback);
> }, 0);
> },
>
> callbackFromNative2: function(callbackId, isSuccess, status, args,
> keepCallback) {
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8469) Android projects are not importable by Android Studio until after first build
Andrew Grieve created CB-8469: - Summary: Android projects are not importable by Android Studio until after first build Key: CB-8469 URL: https://issues.apache.org/jira/browse/CB-8469 Project: Apache Cordova Issue Type: Bug Components: Android, CordovaLib Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor This will certainly trip up many people. Trick is that we need to do the build.js logic where gradle files are added in: 1. as part of create script 2. as part of "plugin add", where plugins contain -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8468) Applications freezes if breakpoint hits JavaScript callback invoked from native
Marcus Pridham created CB-8468:
--
Summary: Applications freezes if breakpoint hits JavaScript
callback invoked from native
Key: CB-8468
URL: https://issues.apache.org/jira/browse/CB-8468
Project: Apache Cordova
Issue Type: Bug
Components: iOS
Reporter: Marcus Pridham
Priority: Minor
It you attach Safari to your application and hit a breakpoint in a Cordova
callback the application freezes and you can't step through or continue. This
only happens in breakpoints in the native to JavaScript callbacks. JavaScript
breakpoints in other areas work fine.
A simple way to reproduce is to use the globalization plugin. Attach safari
and put a breakpoint in the success callback.
navigator.globalization.getPreferredLanguage(function() {
console.log("test"); // Will freeze if breakpoint set here
}, function() {});
The problem seems to have to do with the webview
stringByEvaluatingJavaScriptFromString. It is a synchronous call that can
return the result of the JavaScript back to the native. The native code will
crash if a breakpoint is hit while trying to execute the JavaScript. The
workaround is to have your callback code in a setTimeout so it is not in the
same context as the native stringByEvaluatingJavaScriptFromString call.
A workaround:
Open cordova.js and around line 281 replace:
callbackFromNative: function(callbackId, isSuccess, status, args, keepCallback)
{
With:
callbackFromNative: function(callbackId, isSuccess, status, args,
keepCallback) {
setTimeout(function() {
cordova.callbackFromNative2(callbackId, isSuccess, status, args,
keepCallback);
}, 0);
},
callbackFromNative2: function(callbackId, isSuccess, status, args,
keepCallback) {
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[ https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318894#comment-14318894 ] Connor Pearson commented on CB-7827: According to google (http://android-developers.blogspot.com/2011/06/things-that-cannot-change.html), android:name should never change. While releasing an app with android:name of CordovaApp may work for new apps, this breaks apps that have already been released with a different name. > manifest/application/activity[android:name] always CordovaApp > - > > Key: CB-7827 > URL: https://issues.apache.org/jira/browse/CB-7827 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 4.0.0 > Environment: Windows 8.1 x64, NodeJs 0.10.32 >Reporter: Sergey > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8447) 'cordova platform update android@3.7.1' fails
[ https://issues.apache.org/jira/browse/CB-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318843#comment-14318843 ] Andrew Grieve commented on CB-8447: --- I believe the issue here is that this works on master, but not on the latest released version of the tools. > 'cordova platform update android@3.7.1' fails > - > > Key: CB-8447 > URL: https://issues.apache.org/jira/browse/CB-8447 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > [This issue is resolved in the current master branch] > In cordova-lib@4.2.0, The following sequence of operations fails : > - cordova platform add android@3.5.0 > - cordova platform update android@3.7.1 > The error message is : "Platform "android@3.7.1" is not installed. See > `cordova platform list`." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8447) 'cordova platform update android@3.7.1' fails
[ https://issues.apache.org/jira/browse/CB-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318614#comment-14318614 ] Hirbod commented on CB-8447: I can confirm. I get the same warning. Really... this is the second time an update fails. Before it was iOS, now it is Android.. > 'cordova platform update android@3.7.1' fails > - > > Key: CB-8447 > URL: https://issues.apache.org/jira/browse/CB-8447 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > [This issue is resolved in the current master branch] > In cordova-lib@4.2.0, The following sequence of operations fails : > - cordova platform add android@3.5.0 > - cordova platform update android@3.7.1 > The error message is : "Platform "android@3.7.1" is not installed. See > `cordova platform list`." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform
[ https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318613#comment-14318613 ] ASF GitHub Bot commented on CB-8123: Github user stefangordon commented on the pull request: https://github.com/apache/cordova-lib/pull/164#issuecomment-74116684 Great stuff! Any pointers on how users can easily install this via NPM now? I've only had success manually cloning the lib and cli repos and copying correct binaries. > Enable version, device, and chip arch specific library / dll / winmd > references in plugins for the Windows platform > --- > > Key: CB-8123 > URL: https://issues.apache.org/jira/browse/CB-8123 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugins, Windows >Reporter: Tim Barham > Original Estimate: 72h > Remaining Estimate: 72h > > Because Cordova's windows platform can target multiple target platforms, > projects and frameworks referenced by the plugin may need to target only a > subset of those platforms. To enable this, support the following attributes > on the and elements: > 1. device - indicates the reference is specific to a target device. Supported > values are "phone", "windows" or "all" (default is "all"). > 2. versions - specify platform versions the reference supports (node semantic > version ranges supported). Default is to support all versions. > 3. arch - indicates the reference is specific to a particular chip > architecture (x86 or x64). > The "arch" attribute should result in a Condition="'$(Platform)'=='XXX" > attribute on the reference. The other attributes will impact which generated > jsproj files the reference is actually added to. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8467) inappbrowser -- provide ability to hide browser window without closing session
Eric Kidder created CB-8467: --- Summary: inappbrowser -- provide ability to hide browser window without closing session Key: CB-8467 URL: https://issues.apache.org/jira/browse/CB-8467 Project: Apache Cordova Issue Type: Improvement Components: Android, CordovaJS, iOS Affects Versions: Master Reporter: Eric Kidder I have a need to hide the InAppBrowser UI without closing the session. This is to handle a situation I have, where a RESTful interface uses authentication and will redirect users to a separate login page. The InAppBrowser is created with hidden=yes, so that it is created without a UI. When the user is authenticated, the JSON will be downloaded normally and the browser window will not be shown. When the user is not authorized, they will be redirected to an HTML page in order to authenticate. After authentication, the user is redirected back to the API URL, where the JSON will be displayed in the InAppBrowser. Having the ability to hide the browser window will keep the user from seeing the JSON and improve the user experience. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8466) WP 8.1 backbutton event not fired
Tom Van Boghout created CB-8466:
---
Summary: WP 8.1 backbutton event not fired
Key: CB-8466
URL: https://issues.apache.org/jira/browse/CB-8466
Project: Apache Cordova
Issue Type: Bug
Components: WP8
Affects Versions: 3.6.3
Reporter: Tom Van Boghout
Assignee: Jesse MacFadyen
document.addEventListener("backbutton", function (e) {console.log("backbutton
clicked"}, false};
Instead executing the console.log it exits the app without firing the event.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8465) getCurrentHeading has options parameter in the code, but is not documented.
Venkata Kiran created CB-8465: - Summary: getCurrentHeading has options parameter in the code, but is not documented. Key: CB-8465 URL: https://issues.apache.org/jira/browse/CB-8465 Project: Apache Cordova Issue Type: Bug Components: Plugin Device Orientation Reporter: Venkata Kiran Priority: Trivial getCurrentHeading has options parameter in the code, but is not indicated in the documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
