[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[ https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329925#comment-14329925 ] ASF GitHub Bot commented on CB-8499: Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75350562 Is platforms.json an existing file? Is it used anywhere else? I suspect that it is a new file and I am not sure if it is really needed > 'cordova platform save' : should save all installed platforms to config.xml > --- > > Key: CB-8499 > URL: https://issues.apache.org/jira/browse/CB-8499 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova platform add android --save' to both add and > save a platform to config.xml, It would be useful to have a way to 'mass > save' already installed platforms to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5429) cordova-plugin-network-information fails on iOS when updateReachability is executed
[ https://issues.apache.org/jira/browse/CB-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329896#comment-14329896 ] Joel Rubio commented on CB-5429: Getting this bug as well. Cordova 3.7.0, iOS, no ARC. I notice there is no one assigned to this bug? Anyone looking at it? I posted this on google groups as well. For more information about the issue: https://groups.google.com/forum/#!topic/phonegap/wk1_mlHi3Go > cordova-plugin-network-information fails on iOS when updateReachability is > executed > --- > > Key: CB-5429 > URL: https://issues.apache.org/jira/browse/CB-5429 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Network Information >Affects Versions: 3.1.0 > Environment: iOS >Reporter: Pepe Cano > Fix For: 3.6.0 > > > The use case is: > - app has not any active network connection > - put the "app" in background and access to WIFI settings to active any WIFI > connection > - "updateReachability" is executed and the [self sendPluginResult] call > originates and EXC_BAD_ACCESS exception on the _callbackId variable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329868#comment-14329868 ] ASF GitHub Bot commented on CB-8482: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75346177 There will need to be another pass to update dependent modules to handle the possibility that some new code depending on old syntax might have been inserted in the interim. this is just a reminder to myself and the person who will merge this. > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[
https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329765#comment-14329765
]
ASF GitHub Bot commented on CB-8084:
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/128#issuecomment-75339637
Note that the fix enables it to be disabled using a build.xcconfig
preprocessor macro definition (which can be done through a project/plugin
hook). In 3.8.0 it still behaves like 3.7.0 by default for backwards
compatibility reasons (in 4.0.0, it will be disabled)
> Push Notifications code included by default
> ---
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.5.0
>Reporter: Jacob Weber
>Assignee: Shazron Abdullah
> Fix For: 3.8.0
>
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m
> for Push Notifications. This causes Apple to issue a warning when you submit
> the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used
> to register with the Apple Push Notification service, but the app signature's
> entitlements do not include the "aps-environment" entitlement. If your app
> uses the Apple Push Notification service, make sure your App ID is enabled
> for Push Notification in the Provisioning Portal, and resubmit after signing
> your app with a Distribution provisioning profile that includes the
> "aps-environment" entitlement. See "Provisioning and Development" in the
> Local and Push Notification Programming Guide for more information. If your
> app does not use the Apple Push Notification service, no action is required.
> You may remove the API from future submissions to stop this warning. If you
> use a third-party framework, you may need to contact the developer for
> information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8512) Incorrect verify archive instruction
[ https://issues.apache.org/jira/browse/CB-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-8512. -- Resolution: Fixed > Incorrect verify archive instruction > > > Key: CB-8512 > URL: https://issues.apache.org/jira/browse/CB-8512 > Project: Apache Cordova > Issue Type: Bug > Components: Coho >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > https://github.com/apache/cordova-coho/blob/8b772020b0686ff4a587d4edd1c1eb3ec1c2fffd/src/create-verify-archive.js#L110 > No .zip is ever created, if you followed this instruction it will error. > Remove the .zip instruction, keep the .tgz -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[ https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329730#comment-14329730 ] ASF GitHub Bot commented on CB-8499: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75336770 LGTM > 'cordova platform save' : should save all installed platforms to config.xml > --- > > Key: CB-8499 > URL: https://issues.apache.org/jira/browse/CB-8499 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova platform add android --save' to both add and > save a platform to config.xml, It would be useful to have a way to 'mass > save' already installed platforms to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[ https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329504#comment-14329504 ] ASF GitHub Bot commented on CB-8499: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75314035 @vladimir-kotikov Thanks for reviewing, All your reviews have been addressed, please take another look. > 'cordova platform save' : should save all installed platforms to config.xml > --- > > Key: CB-8499 > URL: https://issues.apache.org/jira/browse/CB-8499 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova platform add android --save' to both add and > save a platform to config.xml, It would be useful to have a way to 'mass > save' already installed platforms to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329499#comment-14329499
]
ASF GitHub Bot commented on CB-8499:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25100140
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
}
+function save(hooksRunner, projectRoot, opts) {
+var xml = cordova_util.projectConfig(projectRoot);
+var cfg = new ConfigParser(xml);
+
+// First, remove all platforms that are already in config.xml
+cfg.getEngines().map(function(engine){
+cfg.removeEngine();
+});
+
+// Save installed platforms into config.xml
+return
platformMetadata.getPlatformVersions(projectRoot).then(function(platformVersions){
+platformVersions.map(function(platVer){
--- End diff --
Changed all the map into forEach. it's definitely better to use forEach
with side-effecting operations.
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329498#comment-14329498
]
ASF GitHub Bot commented on CB-8499:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25100062
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
}
+function save(hooksRunner, projectRoot, opts) {
+var xml = cordova_util.projectConfig(projectRoot);
+var cfg = new ConfigParser(xml);
+
+// First, remove all platforms that are already in config.xml
+cfg.getEngines().map(function(engine){
+cfg.removeEngine();
--- End diff --
Thanks @vladimir-kotikov , nice catch. :)
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329469#comment-14329469
]
ASF GitHub Bot commented on CB-8499:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098780
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs'),
+events = require('../events');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions
installed
+// In this case, we won't be able to know what source the platform
came from
+return Q.nfcall(fs.exists, platformsJsonFile).then(function(exists){
--- End diff --
@vladimir-kotikov , getting a 404 on the link. anyway, thanks for the
suggestion, modifying accordingly.
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329473#comment-14329473
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098877
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs'),
+events = require('../events');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions
installed
+// In this case, we won't be able to know what source the platform
came from
+return Q.nfcall(fs.exists, platformsJsonFile).then(function(exists){
--- End diff --
Sorry, my bad. Here is a proper link
http://nodejs.org/api/fs.html#fs_fs_exists_path_callback
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329466#comment-14329466
]
ASF GitHub Bot commented on CB-8499:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25098622
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs'),
+events = require('../events');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions
installed
+// In this case, we won't be able to know what source the platform
came from
+return Q.nfcall(fs.exists, platformsJsonFile).then(function(exists){
--- End diff --
@vladimir-kotikov , getting a 404 on the link
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8516) Support DefaultLanguage selection for WP8
[
https://issues.apache.org/jira/browse/CB-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329453#comment-14329453
]
ASF GitHub Bot commented on CB-8516:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-wp8/pull/76#discussion_r25098154
--- Diff: template/cordova/lib/build.js ---
@@ -68,6 +70,40 @@ module.exports.run = function (argv) {
}
return parseAndValidateArgs(argv)
+.then(function(buildopts) {
+var csProjFilePath = shell.ls(path.join(ROOT, '*.csproj'))[0];
+var WMAppManifestFilePath = path.join(ROOT, 'Properties',
'WMAppManifest.xml');
+var AssemblyInfoFilePath = path.join(ROOT, 'Properties',
'AssemblyInfo.cs');
+var configFilePath = path.join(ROOT, '..', '..', 'config.xml');
+
+var configContents = removeBOM(fs.readFileSync(configFilePath,
'utf-8'));
+var configXML = new et.ElementTree(et.XML(configContents));
+var defaultLocale = configXML.getroot().attrib['defaultlocale'] ||
'en-US';
+
+// Change locale on csproj file
+var csProjContents = removeBOM(fs.readFileSync(csProjFilePath,
'utf-8'));
+var csProjXML = new et.ElementTree(et.XML(csProjContents));
+var csProjDefaultLocale =
csProjXML.find('./PropertyGroup/SupportedCultures');
+csProjDefaultLocale.text = defaultLocale;
+fs.writeFileSync(csProjFilePath, csProjXML.write({indent: 2}),
'utf-8');
+
+// Change locale on WMAppManifest file
+var WMAppManifestContents =
removeBOM(fs.readFileSync(WMAppManifestFilePath, 'utf-8'));
+var WMAppManifestXML = new
et.ElementTree(et.XML(WMAppManifestContents));
+var WMAppManifestLanguages =
WMAppManifestXML.find('./Languages/Language');
+WMAppManifestLanguages.set('code', defaultLocale);
+var WMAppManifestDefaultLanguage =
WMAppManifestXML.find('./DefaultLanguage');
+WMAppManifestDefaultLanguage.set('code', defaultLocale);
+fs.writeFileSync(WMAppManifestFilePath,
WMAppManifestXML.write({indent: 2}), 'utf-8');
+
+// Change locale on AssemblyInfo file
+var AssemblyInfoContents =
removeBOM(fs.readFileSync(AssemblyInfoFilePath, 'utf-8'));
+AssemblyInfoContents = AssemblyInfoContents.replace(/[\w\[:
]+NeutralResourcesLanguageAttribute\("[\w\-]+"\)]/,
--- End diff --
Changing the NeutralResourceLanguageAttribute does not look like the
correct thing to do here.
> Support DefaultLanguage selection for WP8
> -
>
> Key: CB-8516
> URL: https://issues.apache.org/jira/browse/CB-8516
> Project: Apache Cordova
> Issue Type: Improvement
> Components: WP8
>Reporter: Murat Sutunc
>Assignee: Jesse MacFadyen
>
> The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute)
> supports "defaultlocale" attribute.
> Cordova should set the appropriate project file attributes for WP 8.0 using
> the W3C widget spec "defaultlocale" attribute.
> In the case widget is missing "defaultlocale" attribute, it should default to
> "en-us".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8516) Support DefaultLanguage selection for WP8
[ https://issues.apache.org/jira/browse/CB-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329429#comment-14329429 ] ASF GitHub Bot commented on CB-8516: Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/76#issuecomment-75305949 We actually don't want to merge this right now. Let's hold on until I review how winpho8 locale works. > Support DefaultLanguage selection for WP8 > - > > Key: CB-8516 > URL: https://issues.apache.org/jira/browse/CB-8516 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for WP 8.0 using > the W3C widget spec "defaultlocale" attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329428#comment-14329428 ] ASF GitHub Bot commented on CB-8515: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75305927 This looks good! @sgrebnov Can you please help merge this one? It will be good to have this in the next cordova-windows release. > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7567) firefox os build compression corrupted certain JPEG files
[
https://issues.apache.org/jira/browse/CB-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329419#comment-14329419
]
ASF subversion and git services commented on CB-7567:
-
Commit bd21ce3b06db8ee6315c6ad591eef2f18265c037 in cordova-firefoxos's branch
refs/heads/master from [~jbuck]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;h=bd21ce3 ]
CB-7567 Don't use adm-zip because it creates invalid zip files
> firefox os build compression corrupted certain JPEG files
> -
>
> Key: CB-7567
> URL: https://issues.apache.org/jira/browse/CB-7567
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
>Affects Versions: 3.5.0
> Environment: Cordova 3.5.0-0.2.7, Ionic 1.2.5, Ubuntu 14.04 64-bit
>Reporter: Hendy Irawan
> Attachments: Vegetable-Pasta.jpg
>
>
> Some image files cannot be compressed properly by {{build firefoxos}}.
> However, during build there is no error.
> During extraction, these affected files will have 0 byte size.
> For example, unzipping the package.zip will emit following error message:
> {code}
> inflating: recipe_photos/Vegetable-Pasta.jpg
> error: invalid compressed data to inflate
>creating: templates/
> {code}
> Example file that cannot be compressed is attached.
> Note that the file is correct in
> {{platforms/firefoxos/www/recipe_photos/Vegetable-Pasta.jpg}}. It's only
> corrupted inside the ZIP file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329420#comment-14329420
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25096560
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs'),
+events = require('../events');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions
installed
+// In this case, we won't be able to know what source the platform
came from
+return Q.nfcall(fs.exists, platformsJsonFile).then(function(exists){
+if(exists){
+return getPlatVersionsFromFile(platformsJsonFile);
+}
+return getPlatVersionsFromFileSystem(projectRoot);
+});
+}
+
+// Returns a promise
+function getPlatVersionsFromFile(platformsJsonFile){
+var platformData = getJson(platformsJsonFile);
+var platformVersions = [];
+
+platformVersions = Object.keys(platformData).map(function(p){
+return {platform: p, version: platformData[p]};
+});
+
+return Q(platformVersions);
+}
+
+// Returns a promise
+function getPlatVersionsFromFileSystem(projectRoot){
+var platformVersions = [];
+var platforms_on_fs = cordova_util.listPlatforms(projectRoot);
+platforms_on_fs.map(function(platform){
--- End diff --
`map` vs `forEach` again
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7567) firefox os build compression corrupted certain JPEG files
[
https://issues.apache.org/jira/browse/CB-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329422#comment-14329422
]
ASF GitHub Bot commented on CB-7567:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-firefoxos/pull/22
> firefox os build compression corrupted certain JPEG files
> -
>
> Key: CB-7567
> URL: https://issues.apache.org/jira/browse/CB-7567
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
>Affects Versions: 3.5.0
> Environment: Cordova 3.5.0-0.2.7, Ionic 1.2.5, Ubuntu 14.04 64-bit
>Reporter: Hendy Irawan
> Attachments: Vegetable-Pasta.jpg
>
>
> Some image files cannot be compressed properly by {{build firefoxos}}.
> However, during build there is no error.
> During extraction, these affected files will have 0 byte size.
> For example, unzipping the package.zip will emit following error message:
> {code}
> inflating: recipe_photos/Vegetable-Pasta.jpg
> error: invalid compressed data to inflate
>creating: templates/
> {code}
> Example file that cannot be compressed is attached.
> Note that the file is correct in
> {{platforms/firefoxos/www/recipe_photos/Vegetable-Pasta.jpg}}. It's only
> corrupted inside the ZIP file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329414#comment-14329414
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25096417
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs'),
+events = require('../events');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions
installed
+// In this case, we won't be able to know what source the platform
came from
+return Q.nfcall(fs.exists, platformsJsonFile).then(function(exists){
--- End diff --
Due to
[nodejs.org/api/fs.html](nodejs.org/api/fs.html#fs_fs_exists_path_callback)
> fs.exists() is an anachronism and exists only for historical reasons.
There should almost never be a reason to use it in your own code.
Probably it is better to replace this with something like this:
```
return getPlatVersionsFromFile(platformsJsonFile)
.fail(function () {
return getPlatVersionsFromFileSystem(projectRoot);
});
```
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329409#comment-14329409 ] Chris Emerson commented on CB-7606: --- Just an update ... I manually updated my Cordova files w/the updates here and that appears to fix the cold-start problem. When are these files going to be rolled into the current/latest Cordova version? Side/related question - When I run cordova --version I get 4.2 not 3.8 (?)... what am I missing/confusing here? > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7567) firefox os build compression corrupted certain JPEG files
[
https://issues.apache.org/jira/browse/CB-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329394#comment-14329394
]
Simon Wex commented on CB-7567:
---
This looks good to me. Tested, it produces a valid zip file where previously it
did not when it contained images. R+
> firefox os build compression corrupted certain JPEG files
> -
>
> Key: CB-7567
> URL: https://issues.apache.org/jira/browse/CB-7567
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
>Affects Versions: 3.5.0
> Environment: Cordova 3.5.0-0.2.7, Ionic 1.2.5, Ubuntu 14.04 64-bit
>Reporter: Hendy Irawan
> Attachments: Vegetable-Pasta.jpg
>
>
> Some image files cannot be compressed properly by {{build firefoxos}}.
> However, during build there is no error.
> During extraction, these affected files will have 0 byte size.
> For example, unzipping the package.zip will emit following error message:
> {code}
> inflating: recipe_photos/Vegetable-Pasta.jpg
> error: invalid compressed data to inflate
>creating: templates/
> {code}
> Example file that cannot be compressed is attached.
> Note that the file is correct in
> {{platforms/firefoxos/www/recipe_photos/Vegetable-Pasta.jpg}}. It's only
> corrupted inside the ZIP file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329392#comment-14329392
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095419
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,113 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs'),
+events = require('../events');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions
installed
+// In this case, we won't be able to know what source the platform
came from
+return Q.nfcall(fs.exists, platformsJsonFile).then(function(exists){
+if(exists){
+return getPlatVersionsFromFile(platformsJsonFile);
+}
+return getPlatVersionsFromFileSystem(projectRoot);
+});
+}
+
+// Returns a promise
+function getPlatVersionsFromFile(platformsJsonFile){
+var platformData = getJson(platformsJsonFile);
--- End diff --
You may want to require JSON file directly: `var platformData =
require(platformsJsonFile);`
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329389#comment-14329389
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095044
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
}
+function save(hooksRunner, projectRoot, opts) {
+var xml = cordova_util.projectConfig(projectRoot);
+var cfg = new ConfigParser(xml);
+
+// First, remove all platforms that are already in config.xml
+cfg.getEngines().map(function(engine){
+cfg.removeEngine();
+});
+
+// Save installed platforms into config.xml
+return
platformMetadata.getPlatformVersions(projectRoot).then(function(platformVersions){
+platformVersions.map(function(platVer){
--- End diff --
`map` vs `forEach` again
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329387#comment-14329387
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095035
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -158,6 +160,11 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
return installPluginsForNewPlatform(platform,
projectRoot, cfg, opts);
}
}).then(function() {
+// Save platform@version into platforms.json. i.e:
'android@https://github.com/apache/cordova-android.git'
+// If no version was specified, save the edge version
+var versionToSave = version ? version :
platforms[platform].version;
--- End diff --
just a nitpick - there is no need for ternary operator, `version ||
platforms[platform].version` will work the same way
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329388#comment-14329388
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095040
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -174,6 +181,24 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
});
}
+function save(hooksRunner, projectRoot, opts) {
+var xml = cordova_util.projectConfig(projectRoot);
+var cfg = new ConfigParser(xml);
+
+// First, remove all platforms that are already in config.xml
+cfg.getEngines().map(function(engine){
+cfg.removeEngine();
--- End diff --
Something strange here. `removeEngine` requires an engine Id param
(https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/configparser/ConfigParser.js#L404).
Probably should be `cfg.removeEngine(engine.id);` instead.
Also `forEach` IMHO is more appropriate here than `map` here
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329340#comment-14329340 ] Chris Emerson edited comment on CB-7606 at 2/20/15 7:09 PM: Anyone else seeing the "cold start" issue return after/as-of the most recent version of Cordova? Hopefully I'm just screwing up the fix but it sure seems like it might be back. Because for me that timeout that Shazron posted in his fix is not firing on cold starts ... only after the app is opened. was (Author: chrisemersonnc): Anyone else seeing the "cold start" issue return after/as-of Cordova 4.2? Hopefully I'm just screwing up the fix but it sure seems like it might be back. Because for me that timeout that Shazron posted in his fix is not firing on cold starts ... only after the app is opened. > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329340#comment-14329340 ] Chris Emerson edited comment on CB-7606 at 2/20/15 7:02 PM: Anyone else seeing the "cold start" issue return after/as-of Cordova 4.2? Hopefully I'm just screwing up the fix but it sure seems like it might be back. Because for me that timeout that Shazron posted in his fix is not firing on cold starts ... only after the app is opened. was (Author: chrisemersonnc): Anyone else seeing the "cold start" issue return after/as-of Cordova 4.2? Hopefully I'm just screwing up the fix but it sure seems like it might be back. > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329371#comment-14329371 ] ASF GitHub Bot commented on CB-8515: Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75298546 I'll fix the default locale to en-US. When a defaultlocale is not present we should set it to en-US. Good catch! > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[ https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329367#comment-14329367 ] ASF GitHub Bot commented on CB-8499: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75298325 @agrieve , @vladimir-kotikov and @gorkem, please review. > 'cordova platform save' : should save all installed platforms to config.xml > --- > > Key: CB-8499 > URL: https://issues.apache.org/jira/browse/CB-8499 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova platform add android --save' to both add and > save a platform to config.xml, It would be useful to have a way to 'mass > save' already installed platforms to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8521) 'cordova plugin save' should save all installed plugins and their version/git-url/folder-location into config.xml
[ https://issues.apache.org/jira/browse/CB-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omar Mefire updated CB-8521: Description: In addition to using 'cordova plugin add org.apache.cordova.device --save' to both add and save a plugin to config.xml, It would be useful to have a way to 'mass save' already installed plugins to config.xml. > 'cordova plugin save' should save all installed plugins and their > version/git-url/folder-location into config.xml > - > > Key: CB-8521 > URL: https://issues.apache.org/jira/browse/CB-8521 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova plugin add org.apache.cordova.device --save' to > both add and save a plugin to config.xml, It would be useful to have a way to > 'mass save' already installed plugins to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8444) Don't clobber `window.open`
[ https://issues.apache.org/jira/browse/CB-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Chase reassigned CB-8444: --- Assignee: Jason Chase > Don't clobber `window.open` > --- > > Key: CB-8444 > URL: https://issues.apache.org/jira/browse/CB-8444 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin InAppBrowser >Reporter: sandstrom >Assignee: Jason Chase > Fix For: Master > > > Where Cordova plugins map 1:1 to W3C API's it's great that they clobber the > corresponding namespace. Geolocation is a good example. > However, it doesn't really feel like this plugin is a 1:1, so perhaps it > should be available at another name, e.g. `window.iabOpen` (the old API > should be preserved until the next major though, since to keep backward > compatibility). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329340#comment-14329340 ] Chris Emerson commented on CB-7606: --- Anyone else seeing the "cold start" issue return after/as-of Cordova 4.2? Hopefully I'm just screwing up the fix but it sure seems like it might be back. > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Reopened] (CB-8444) Don't clobber `window.open`
[ https://issues.apache.org/jira/browse/CB-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Chase reopened CB-8444: - After an appropriate deprecation period, the plugin needs to be changed to fully remove the clobber of `window.open`. As an API change, this would require a major release. > Don't clobber `window.open` > --- > > Key: CB-8444 > URL: https://issues.apache.org/jira/browse/CB-8444 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin InAppBrowser >Reporter: sandstrom > Fix For: Master > > > Where Cordova plugins map 1:1 to W3C API's it's great that they clobber the > corresponding namespace. Geolocation is a good example. > However, it doesn't really feel like this plugin is a 1:1, so perhaps it > should be available at another name, e.g. `window.iabOpen` (the old API > should be preserved until the next major though, since to keep backward > compatibility). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8444) Don't clobber `window.open`
[ https://issues.apache.org/jira/browse/CB-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329337#comment-14329337 ] Jason Chase commented on CB-8444: - A new symbol has been added to expose the InAppBrowser functionality, named `cordova.InAppBrowser.open`. The clobber of `window.open` has been deprecated (in the docs), but not removed. The plan is to wait to the next major release, to give apps a chance to update usage as appropriate. > Don't clobber `window.open` > --- > > Key: CB-8444 > URL: https://issues.apache.org/jira/browse/CB-8444 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin InAppBrowser >Reporter: sandstrom > Fix For: Master > > > Where Cordova plugins map 1:1 to W3C API's it's great that they clobber the > corresponding namespace. Geolocation is a good example. > However, it doesn't really feel like this plugin is a 1:1, so perhaps it > should be available at another name, e.g. `window.iabOpen` (the old API > should be preserved until the next major though, since to keep backward > compatibility). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8521) 'cordova plugin save' should save all installed plugins and their version/git-url/folder-location into config.xml
Omar Mefire created CB-8521: --- Summary: 'cordova plugin save' should save all installed plugins and their version/git-url/folder-location into config.xml Key: CB-8521 URL: https://issues.apache.org/jira/browse/CB-8521 Project: Apache Cordova Issue Type: New Feature Reporter: Omar Mefire Assignee: Omar Mefire -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[ https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329295#comment-14329295 ] ASF GitHub Bot commented on CB-8499: GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/170 CB-8499 `cordova platform save` should save all currently installed platforms and their versions/git-url/folder-location into config.xml. CB-8499 `cordova platform save` should save all currently installed platforms and their versions/git-url/folder-location into config.xml. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8499 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/170.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #170 commit 6dac55f9995a0abd847051ba1ae1eeac2384362f Author: Omar Mefire Date: 2015-02-18T19:15:53Z CB-8499 When adding a platform, capture version/folder/url being added to allow us to be able to save all installed platforms and their versions later on by doing 'cordova platform save' commit 0063dfeeceef675bba072bc95e0add07d30a4326 Author: Omar Mefire Date: 2015-02-18T20:21:12Z CB-8499 When deleting a platform, remove it from platforms.json commit c440aac71cb3eee5226cbe7f57ecb09e8a1315cb Author: Omar Mefire Date: 2015-02-18T21:59:18Z CB-8499 `cordova platform save`: save installed platforms and their sources (versions/git_urls/folders) into config.xml > 'cordova platform save' : should save all installed platforms to config.xml > --- > > Key: CB-8499 > URL: https://issues.apache.org/jira/browse/CB-8499 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova platform add android --save' to both add and > save a platform to config.xml, It would be useful to have a way to 'mass > save' already installed platforms to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8520) Android build adds gradle args multiple times
[ https://issues.apache.org/jira/browse/CB-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal reassigned CB-8520: - Assignee: Nikhil Khandelwal > Android build adds gradle args multiple times > - > > Key: CB-8520 > URL: https://issues.apache.org/jira/browse/CB-8520 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal >Priority: Minor > > As seen below, 'PcdvDebugSigningPropertiesFile' is added twice when gradle is > invoked. This bug is minor issue and I have a fix for it. > λ cordova build android -- > --gradleArg=-PcdvDebugSigningPropertiesFile=key.properties > Running command: d:\apps\test\platforms\android\cordova\build.bat > --gradleArg=-PcdvDebugSigningPropertiesFile=key.properties > ANDROID_HOME=C:\Program Files (x86)\Android\android-sdk > JAVA_HOME=C:\Program Files\java\jdk1.8.0_25 > Running: d:\apps\test\platforms\android\gradlew cdvBuildDebug -b > d:\apps\test\platforms\android\build.gradle -Dorg.gradle.daemon=true > -PcdvDebugSigningPropertiesFile=key.properties > -PcdvDebugSigningPropertiesFile=key.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8520) Android build adds gradle args multiple times
Nikhil Khandelwal created CB-8520: - Summary: Android build adds gradle args multiple times Key: CB-8520 URL: https://issues.apache.org/jira/browse/CB-8520 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Nikhil Khandelwal Priority: Minor As seen below, 'PcdvDebugSigningPropertiesFile' is added twice when gradle is invoked. This bug is minor issue and I have a fix for it. λ cordova build android -- --gradleArg=-PcdvDebugSigningPropertiesFile=key.properties Running command: d:\apps\test\platforms\android\cordova\build.bat --gradleArg=-PcdvDebugSigningPropertiesFile=key.properties ANDROID_HOME=C:\Program Files (x86)\Android\android-sdk JAVA_HOME=C:\Program Files\java\jdk1.8.0_25 Running: d:\apps\test\platforms\android\gradlew cdvBuildDebug -b d:\apps\test\platforms\android\build.gradle -Dorg.gradle.daemon=true -PcdvDebugSigningPropertiesFile=key.properties -PcdvDebugSigningPropertiesFile=key.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8519) exception and crash when instantiatePlugin() fails
xx created CB-8519: -- Summary: exception and crash when instantiatePlugin() fails Key: CB-8519 URL: https://issues.apache.org/jira/browse/CB-8519 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: xx Priority: Critical public CordovaPlugin getPlugin(String service) in PluginManager.java does not check for return value of instantiatePlugin call. Proposed fix: if (ret == null) return null; -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8444) Don't clobber `window.open`
[ https://issues.apache.org/jira/browse/CB-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Chase resolved CB-8444. - Resolution: Fixed Fix Version/s: Master > Don't clobber `window.open` > --- > > Key: CB-8444 > URL: https://issues.apache.org/jira/browse/CB-8444 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin InAppBrowser >Reporter: sandstrom >Assignee: Jason Chase > Fix For: Master > > > Where Cordova plugins map 1:1 to W3C API's it's great that they clobber the > corresponding namespace. Geolocation is a good example. > However, it doesn't really feel like this plugin is a 1:1, so perhaps it > should be available at another name, e.g. `window.iabOpen` (the old API > should be preserved until the next major though, since to keep backward > compatibility). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8444) Don't clobber `window.open`
[ https://issues.apache.org/jira/browse/CB-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Chase updated CB-8444: Assignee: (was: Jason Chase) > Don't clobber `window.open` > --- > > Key: CB-8444 > URL: https://issues.apache.org/jira/browse/CB-8444 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin InAppBrowser >Reporter: sandstrom > Fix For: Master > > > Where Cordova plugins map 1:1 to W3C API's it's great that they clobber the > corresponding namespace. Geolocation is a good example. > However, it doesn't really feel like this plugin is a 1:1, so perhaps it > should be available at another name, e.g. `window.iabOpen` (the old API > should be preserved until the next major though, since to keep backward > compatibility). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7773) "compass" bugs with WP8.1
[ https://issues.apache.org/jira/browse/CB-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328952#comment-14328952 ] Sergey Grebnov commented on CB-7773: I'm not sure Lumia 520 has compass at all (Magnetometer sensor) > "compass" bugs with WP8.1 > - > > Key: CB-7773 > URL: https://issues.apache.org/jira/browse/CB-7773 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Device Orientation >Affects Versions: 3.6.3 > Environment: I am using WP8.1 with phonegap 3.6.3 and all latest core > plugin... > my device => nokia lumia 520 >Reporter: Colin Bau > Labels: compass > Original Estimate: 12h > Remaining Estimate: 12h > > wen I use > navigator.compass.getCurrentHeading(startCompass, startCompass); > it will trigger the "startCompass" successful > but the... > heading.trueHeading > heading.magneticHeading > heading.headingAccuracy > heading.timestamp > all got "undefined" > PS > android and iOS are all work -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328920#comment-14328920 ] ASF GitHub Bot commented on CB-8515: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75239086 But this is minor, so I'm +1 merging this. > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328918#comment-14328918 ] ASF GitHub Bot commented on CB-8515: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75238948 May be just use something like this var defaultLocale = config.defaultLocale() || 'en-us'; > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328917#comment-14328917 ] ASF GitHub Bot commented on CB-8515: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75238727 I meant if you changed locale in config.xml and then removed this settings it will continue pointing to the wrong previously used locale, not the default one. > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8234) IOS phonegap camera gives empty snapshot result in IOS 8.1 on iPhone 6 /iPhone 6 plus.
[
https://issues.apache.org/jira/browse/CB-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328905#comment-14328905
]
josh pine commented on CB-8234:
---
Please look into issue.
> IOS phonegap camera gives empty snapshot result in IOS 8.1 on iPhone 6
> /iPhone 6 plus.
> ---
>
> Key: CB-8234
> URL: https://issues.apache.org/jira/browse/CB-8234
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Reporter: pvagare
>
> I get following error while I am taking the photo from iPhone camera.
> "Snapshotting a view that has not been rendered results in an empty snapshot.
> Ensure your view has been rendered at least once before snapshotting or
> snapshot after screen updates."
> My platform details. IOS 8.1.2, cordova 3.5,iPhone 6 Plus
> Please update the camera plugin as early as possible.
> Please refer the following JavaScript code.
> navigator.camera.getPicture(onSuccess, onFail, {
> quality:100,
> destinationType:
> Camera.DestinationType.FILE_URI,
> sourceType:
> Camera.PictureSourceType.PHOTOLIBRARY,
> encodingType:
> Camera.EncodingType.JPEG,
> targetWidth:960,
> targetHeight:640
> });
> function onSuccess(imageURI){
> console.log(imageURI);
> }
> function onFail(){
>alert("Fail");
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328893#comment-14328893 ] ASF GitHub Bot commented on CB-8515: Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75235633 if no locale is not found it uses the current default language which is en-us. Since that is already hardcoded in proj files I'm not re-setting it. removing might have some side effects. > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8497) FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
[
https://issues.apache.org/jira/browse/CB-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dani Palou updated CB-8497:
---
Description:
If I try to delete a file that has the character '#' in its name, the 'remove'
function always fails, returning FileError.NOT_FOUND_ERR. If the file doesn't
have the '#' character, the code works fine. This error is happening both in
Android 5 and iOS 8.1.3.
The same happens for the 'file' function.
This is one of the FileEntries that I'm testing with:
{quote}
fullPath: "/tmp/test#.txt",
isDirectory: false,
isFIle: true,
name: "test#.txt",
nativeURL: "file:///storage/emulated/0/tmp/test%23.txt"
{quote}
I obtained this FileEntry using a DirectoryReader to read the contents of the
parent folder.
I'm testing with PhoneGap CLI 4.2.0, FilePlugin 1.3.3, PhoneGap Android 3.6.4
and PhoneGap iOS 3.7.0.
was:
If I try to delete a file that has the character '#' in its name, the 'remove'
function always fails, returning FileError.NOT_FOUND_ERR. If the file doesn't
have the '#' character, the code works fine. This error is happening both in
Android 5 and iOS 8.1.3.
The same happens for the 'file' function.
This is one of the FileEntries that I'm testing with:
{quote}
fullPath: "/tmp/test#.txt",
isDirectory: false,
isFIle: true,
name: "test#.txt",
nativeURL: "file:///storage/emulated/0/tmp/test%23.txt"
{quote}
I obtained this FileEntry using a DirectoryReader to read the contents of the
parent folder.
I'm testing with PhoneGap 4.2.0 and FilePlugin 1.3.3.
> FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
>
>
> Key: CB-8497
> URL: https://issues.apache.org/jira/browse/CB-8497
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, iOS, Plugin File
> Environment: iOS 8.1.3 and Android 5.0
>Reporter: Dani Palou
>
> If I try to delete a file that has the character '#' in its name, the
> 'remove' function always fails, returning FileError.NOT_FOUND_ERR. If the
> file doesn't have the '#' character, the code works fine. This error is
> happening both in Android 5 and iOS 8.1.3.
> The same happens for the 'file' function.
> This is one of the FileEntries that I'm testing with:
> {quote}
> fullPath: "/tmp/test#.txt",
> isDirectory: false,
> isFIle: true,
> name: "test#.txt",
> nativeURL: "file:///storage/emulated/0/tmp/test%23.txt"
> {quote}
> I obtained this FileEntry using a DirectoryReader to read the contents of the
> parent folder.
> I'm testing with PhoneGap CLI 4.2.0, FilePlugin 1.3.3, PhoneGap Android 3.6.4
> and PhoneGap iOS 3.7.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[
https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328855#comment-14328855
]
ASF GitHub Bot commented on CB-8084:
Github user Mitko-Kerezov closed the pull request at:
https://github.com/apache/cordova-ios/pull/128
> Push Notifications code included by default
> ---
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.5.0
>Reporter: Jacob Weber
>Assignee: Shazron Abdullah
> Fix For: 3.8.0
>
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m
> for Push Notifications. This causes Apple to issue a warning when you submit
> the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used
> to register with the Apple Push Notification service, but the app signature's
> entitlements do not include the "aps-environment" entitlement. If your app
> uses the Apple Push Notification service, make sure your App ID is enabled
> for Push Notification in the Provisioning Portal, and resubmit after signing
> your app with a Distribution provisioning profile that includes the
> "aps-environment" entitlement. See "Provisioning and Development" in the
> Local and Push Notification Programming Guide for more information. If your
> app does not use the Apple Push Notification service, no action is required.
> You may remove the API from future submissions to stop this warning. If you
> use a third-party framework, you may need to contact the developer for
> information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8084) Push Notifications code included by default
[
https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328854#comment-14328854
]
ASF GitHub Bot commented on CB-8084:
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-ios/pull/128#issuecomment-75227834
Issue was fixed with
https://github.com/apache/cordova-ios/commit/8dcc9dd626c523e6e217dd7e8ce43d0af849fa3a
So I'm closing this now
> Push Notifications code included by default
> ---
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.5.0
>Reporter: Jacob Weber
>Assignee: Shazron Abdullah
> Fix For: 3.8.0
>
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m
> for Push Notifications. This causes Apple to issue a warning when you submit
> the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used
> to register with the Apple Push Notification service, but the app signature's
> entitlements do not include the "aps-environment" entitlement. If your app
> uses the Apple Push Notification service, make sure your App ID is enabled
> for Push Notification in the Provisioning Portal, and resubmit after signing
> your app with a Distribution provisioning profile that includes the
> "aps-environment" entitlement. See "Provisioning and Development" in the
> Local and Push Notification Programming Guide for more information. If your
> app does not use the Apple Push Notification service, no action is required.
> You may remove the API from future submissions to stop this warning. If you
> use a third-party framework, you may need to contact the developer for
> information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8508) Rework medic scripts for android platform
[ https://issues.apache.org/jira/browse/CB-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328762#comment-14328762 ] ASF GitHub Bot commented on CB-8508: Github user alsorokin closed the pull request at: https://github.com/apache/cordova-medic/pull/33 > Rework medic scripts for android platform > - > > Key: CB-8508 > URL: https://issues.apache.org/jira/browse/CB-8508 > Project: Apache Cordova > Issue Type: Bug > Components: Medic >Reporter: Alexander Sorokin > > Currently android script has numerous issues, including: > - Test results not being posted to couchDB > - Mobilespec integration with medic is broken (wrong placement of medic.json) > What needs to be done: > - Force use Ant as Visual Studio doesn't support Gradle > - Keep in mind to use Gradle and Ant both in the future > - Use `cordova run` command to execute mobile spec application instead of > directly using avd/adb > - Fix medic integration > - Fix couchDB logging (inject couchDB server address to Content Security > Policy) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8518) InAppBrowser fails to open external urls in system browser (naive fix included)
Achim Staebler created CB-8518:
--
Summary: InAppBrowser fails to open external urls in system
browser (naive fix included)
Key: CB-8518
URL: https://issues.apache.org/jira/browse/CB-8518
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 0.6.1
Environment: ios 8.1, tested in ipad air emulator
Reporter: Achim Staebler
Attempts to open an external url with
window.open("http://www.apache.org";, "_system");
fail silently. The root cause is line 91, where an absolute URL is constructed
from the app's base URL and the url passed to window.open:
NSURL* absoluteUrl = [[NSURL URLWithString:url relativeToURL:baseUrl]
absoluteURL];
However, cordova resources are served via file:// scheme, so absoluteURL will
be nil in this case. My suggested fix compares the URL's schemes and skips
creating a relative url when this clearly does not work:
NSURL* absoluteUrl;
NSURL* urlTarget = [NSURL URLWithString:url];
if ([urlTarget.scheme isEqualToString:baseUrl.scheme]) {
// same protocol, can use relative URL Relative to base
absoluteUrl = [[NSURL URLWithString:url relativeToURL:baseUrl]
absoluteURL];
} else {
absoluteUrl = urlTarget;
}
I'm not submitting this as a pull request because I'm not certain about the
portential security implications this native fix might have.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8508) Rework medic scripts for android platform
[ https://issues.apache.org/jira/browse/CB-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328753#comment-14328753 ] ASF GitHub Bot commented on CB-8508: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-medic/pull/33#issuecomment-75212956 merged, @alsorokin please close PR (I've misspelled github directive in commit message to close it automatically) > Rework medic scripts for android platform > - > > Key: CB-8508 > URL: https://issues.apache.org/jira/browse/CB-8508 > Project: Apache Cordova > Issue Type: Bug > Components: Medic >Reporter: Alexander Sorokin > > Currently android script has numerous issues, including: > - Test results not being posted to couchDB > - Mobilespec integration with medic is broken (wrong placement of medic.json) > What needs to be done: > - Force use Ant as Visual Studio doesn't support Gradle > - Keep in mind to use Gradle and Ant both in the future > - Use `cordova run` command to execute mobile spec application instead of > directly using avd/adb > - Fix medic integration > - Fix couchDB logging (inject couchDB server address to Content Security > Policy) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8508) Rework medic scripts for android platform
[ https://issues.apache.org/jira/browse/CB-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328750#comment-14328750 ] ASF subversion and git services commented on CB-8508: - Commit aa2f08ba496448e7d44c40e68fe8cd2ee34664fe in cordova-medic's branch refs/heads/master from [~alsorokin] [ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=aa2f08b ] CB-8508 Android scripts rework, config patching changes github close 33 > Rework medic scripts for android platform > - > > Key: CB-8508 > URL: https://issues.apache.org/jira/browse/CB-8508 > Project: Apache Cordova > Issue Type: Bug > Components: Medic >Reporter: Alexander Sorokin > > Currently android script has numerous issues, including: > - Test results not being posted to couchDB > - Mobilespec integration with medic is broken (wrong placement of medic.json) > What needs to be done: > - Force use Ant as Visual Studio doesn't support Gradle > - Keep in mind to use Gradle and Ant both in the future > - Use `cordova run` command to execute mobile spec application instead of > directly using avd/adb > - Fix medic integration > - Fix couchDB logging (inject couchDB server address to Content Security > Policy) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[
https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328745#comment-14328745
]
ASF GitHub Bot commented on CB-8515:
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/59#discussion_r25058822
--- Diff: template/cordova/lib/prepare.js ---
@@ -40,14 +40,37 @@ module.exports.applyPlatformConfig = function () {
return false;
});
+// Apply appxmanifest changes
['package.windows.appxmanifest', 'package.windows80.appxmanifest',
'package.phone.appxmanifest'].forEach(
function(manifestFile) {
updateManifestFile(config, path.join(ROOT, manifestFile));
});
+// Apply jsproj changes
+['CordovaApp.Phone.jsproj', 'CordovaApp.Windows.jsproj',
'CordovaApp.Windows80.jsproj'].forEach(
+function(jsprojFile) {
+updatejsprojFile(config, path.join(ROOT, jsprojFile));
+});
+
copyImages(config);
};
+function updatejsprojFile(config, jsProjFilePath) {
+var defaultLocale = config.defaultLocale();
+
+if (defaultLocale) {
--- End diff --
I think we should remove or set to default DefaultLanguage in case there is
no config.defaultLocale().
> Support DefaultLanguage selection for Windows
> -
>
> Key: CB-8515
> URL: https://issues.apache.org/jira/browse/CB-8515
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
>Reporter: Murat Sutunc
>
> The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute)
> supports "defaultlocale" attribute.
> Cordova should set the appropriate project file attributes for Windows 8.0,
> 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale"
> attribute.
> In the case widget is missing "defaultlocale" attribute, it should default to
> "en-us".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8516) Support DefaultLanguage selection for WP8
[ https://issues.apache.org/jira/browse/CB-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328742#comment-14328742 ] ASF GitHub Bot commented on CB-8516: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/76#issuecomment-75211406 LGTM, propose to move config parsing logic to separate file/class similar to how this is done on windows https://github.com/apache/cordova-windows/blob/master/template/cordova/lib/ConfigParser.js > Support DefaultLanguage selection for WP8 > - > > Key: CB-8516 > URL: https://issues.apache.org/jira/browse/CB-8516 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Jesse MacFadyen > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for WP 8.0 using > the W3C widget spec "defaultlocale" attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8517) App crash because of ContentResolver query returned null on lollipop device
Manoj Katari P created CB-8517: -- Summary: App crash because of ContentResolver query returned null on lollipop device Key: CB-8517 URL: https://issues.apache.org/jira/browse/CB-8517 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts Environment: Lollipop, MotoG Reporter: Manoj Katari P ContentResolver.query() can return null in devices running with lollipop. Its not handled in contacts plugin at ContactAccessorSdk5.java:186 for idCursor --- FATAL EXCEPTION: pool-1-thread-38 E/AndroidRuntime(17921): Process: com.toshiba.uclient, PID: 17921 E/AndroidRuntime(17921): java.lang.NullPointerException: Attempt to invoke interface method 'boolean android.database.Cursor.moveToNext()' on a null object reference E/AndroidRuntime(17921):at org.apache.cordova.contacts.ContactAccessorSdk5.search(ContactAccessorSdk5.java:186) E/AndroidRuntime(17921):at org.apache.cordova.contacts.ContactManager$1.run(ContactManager.java:93) E/AndroidRuntime(17921):at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) E/AndroidRuntime(17921):at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) E/AndroidRuntime(17921):at java.lang.Thread.run(Thread.java:818) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
