[jira] [Created] (CB-8580) PluginResult.Status.NO_RESULT is broken (error CB is invoked instead)
Eddy Verbruggen created CB-8580: --- Summary: PluginResult.Status.NO_RESULT is broken (error CB is invoked instead) Key: CB-8580 URL: https://issues.apache.org/jira/browse/CB-8580 Project: Apache Cordova Issue Type: Bug Components: WP8 Affects Versions: 3.7.0 Reporter: Eddy Verbruggen Assignee: Jesse MacFadyen Before 3.7.0 a plugin could respond with: PluginResult pluginResult = new PluginResult(PluginResult.Status.NO_RESULT); pluginResult.KeepCallback = true; this.DispatchCommandResult(pluginResult); This meant the successCB nor the errorCB was invoked awaiting a further response from native code. Since 3.7.0 however in this case the errorCB is invoked due to this difference: Before 3.7.0: https://github.com/apache/cordova-wp8/blob/3.5.x/common/www/cordova.js#L293 Since 3.7.0: https://github.com/apache/cordova-wp8/blob/3.7.1/template/www/cordova.js#L287 I'd love to see the old behavior in a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8580) PluginResult.Status.NO_RESULT is broken (error CB is invoked instead)
[ https://issues.apache.org/jira/browse/CB-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342214#comment-14342214 ] Eddy Verbruggen commented on CB-8580: - Created a PR: https://github.com/apache/cordova-wp8/pull/77 > PluginResult.Status.NO_RESULT is broken (error CB is invoked instead) > - > > Key: CB-8580 > URL: https://issues.apache.org/jira/browse/CB-8580 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 >Affects Versions: 3.7.0 >Reporter: Eddy Verbruggen >Assignee: Jesse MacFadyen > > Before 3.7.0 a plugin could respond with: > PluginResult pluginResult = new PluginResult(PluginResult.Status.NO_RESULT); > pluginResult.KeepCallback = true; > this.DispatchCommandResult(pluginResult); > This meant the successCB nor the errorCB was invoked awaiting a further > response from native code. > Since 3.7.0 however in this case the errorCB is invoked due to this > difference: > Before 3.7.0: > https://github.com/apache/cordova-wp8/blob/3.5.x/common/www/cordova.js#L293 > Since 3.7.0: > https://github.com/apache/cordova-wp8/blob/3.7.1/template/www/cordova.js#L287 > I'd love to see the old behavior in a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8054) Camera getPicture photo library not supported on Windows?
[ https://issues.apache.org/jira/browse/CB-8054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342371#comment-14342371 ] Don Becker commented on CB-8054: Same issue with Lumia 530 with Camera plugin 0.3.4 > Camera getPicture photo library not supported on Windows? > - > > Key: CB-8054 > URL: https://issues.apache.org/jira/browse/CB-8054 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera, Windows >Affects Versions: 3.7.1 > Environment: Windows Phone 8.1 > Lumia 635 > Windows universal app platform > Camera plugin v0.3.3 >Reporter: Boston Dell-Vandenberg > > On the Windows platform when calling getPicture() with "sourceType" of > "PHOTOLIBRARY" or "SAVEDPHOTOALBUM" it returns "Not supported" error. > The plugin documentation says Windows is supported but is that not the case? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7577) Cordova Crashes on IOS8 when Using input type="file"
[
https://issues.apache.org/jira/browse/CB-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342373#comment-14342373
]
Marco commented on CB-7577:
---
I'm still having this issue with phonegap 3.6.3 and iOS 8.1. I build using
build.phonegap.com.
When clicking on select file (html input file) whether I select "choose
existing" or "take photo" the app crashes.
> Cordova Crashes on IOS8 when Using input type="file"
>
>
> Key: CB-7577
> URL: https://issues.apache.org/jira/browse/CB-7577
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: iOS
>Affects Versions: 3.5.0, 3.6.0
> Environment: ios8
>Reporter: Sven Brunner
>Assignee: Shazron Abdullah
>Priority: Critical
>
> The app crashes when using an '' after asking if you
> want to record an Photo/Video or get the file from media.
> Console says the following:
> {code}
> : *** Terminating app due to uncaught exception
> 'NSInternalInconsistencyException', reason: 'Trying to dismiss
> UIAlertController with unknown presenter.'
> *** First throw call stack:
> (0x18553a084 0x195e2c0e4 0x185539fc4 0x18a085fac 0x189cb0724
> 0x189cea7b8 0x189ce9e58 0x189cbd660 0x189f5bd6c 0x189cbbbc8 0x1854f2324
> 0x1854f15c8 0x1854ef678 0x18541d664 0x18e51b5a4 0x189d22984 0x1000c64f4
> 0x19649aa08)
> Sep 18 10:39:13 iPad ReportCrash[577] : task_set_exception_ports(B07,
> 400, D03, 0, 0) failed with error (4: (os/kern) invalid argument)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342548#comment-14342548 ] ASF GitHub Bot commented on CB-8577: Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76639381 Ahhh. I see what you mean now. I think we should fix this on the Config.getFeature(id) so that the existing information on config.xml files are not discarded. > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342564#comment-14342564 ] ASF GitHub Bot commented on CB-8577: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76641117 Fixing it in Config.getFeature(id) would mean that we would have to differentiate between `` types : variables and non-variables. I think that could be unecessarily complex, require special logic and create more subtle bugs. So, I'm in favor on fixing the syntax itself. > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342568#comment-14342568 ] ASF GitHub Bot commented on CB-8577: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76641530 Fixing it in Config.getFeature(id) would mean that we would have to differentiate between `` types : variables and non-variables. I think that would be unecessarily complex, require special logic and create more subtle bugs. So, I'm in favor on fixing the syntax itself. It also has the benefit of conveying its goal clearer. > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342572#comment-14342572 ] ASF GitHub Bot commented on CB-8577: Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76643012 I agree, but this is temporary. Special params are going away with the plugin tag. And ConfigParser's current implementation already does a special treatment of FEATURE_SPECIAL_PARAMS. I have a commit that I am testing that fixes the getFeature(id) which fixes the tests that depend on the variable too. In case interested, this is how it all started https://github.com/apache/cordova-lib/pull/63 > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8054) Camera getPicture photo library not supported on Windows?
[
https://issues.apache.org/jira/browse/CB-8054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342582#comment-14342582
]
Don Becker commented on CB-8054:
// TODO: Add WP8.1 support
// WP8.1 doesn't allow to use of pickSingleFileAsync method
// see http://msdn.microsoft.com/en-us/library/windows/apps/br207852.aspx for
details
// replacement of pickSingleFileAsync - pickSingleFileAndContinue method
// will take application to suspended state and this require additional logic
to wake application up
if (navigator.appVersion.indexOf('Windows Phone 8.1') >= 0 ) {
errorCallback('Not supported');
return;
}
> Camera getPicture photo library not supported on Windows?
> -
>
> Key: CB-8054
> URL: https://issues.apache.org/jira/browse/CB-8054
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera, Windows
>Affects Versions: 3.7.1
> Environment: Windows Phone 8.1
> Lumia 635
> Windows universal app platform
> Camera plugin v0.3.3
>Reporter: Boston Dell-Vandenberg
>
> On the Windows platform when calling getPicture() with "sourceType" of
> "PHOTOLIBRARY" or "SAVEDPHOTOALBUM" it returns "Not supported" error.
> The plugin documentation says Windows is supported but is that not the case?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8054) Camera getPicture photo library not supported on Windows?
[
https://issues.apache.org/jira/browse/CB-8054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342582#comment-14342582
]
Don Becker edited comment on CB-8054 at 3/2/15 1:20 AM:
{quote}
// TODO: Add WP8.1 support
// WP8.1 doesn't allow to use of pickSingleFileAsync method
// see http://msdn.microsoft.com/en-us/library/windows/apps/br207852.aspx for
details
// replacement of pickSingleFileAsync - pickSingleFileAndContinue method
// will take application to suspended state and this require additional logic
to wake application up
if (navigator.appVersion.indexOf('Windows Phone 8.1') >= 0 ) {
errorCallback('Not supported');
return;
}
{quote}
was (Author: psyon):
// TODO: Add WP8.1 support
// WP8.1 doesn't allow to use of pickSingleFileAsync method
// see http://msdn.microsoft.com/en-us/library/windows/apps/br207852.aspx for
details
// replacement of pickSingleFileAsync - pickSingleFileAndContinue method
// will take application to suspended state and this require additional logic
to wake application up
if (navigator.appVersion.indexOf('Windows Phone 8.1') >= 0 ) {
errorCallback('Not supported');
return;
}
> Camera getPicture photo library not supported on Windows?
> -
>
> Key: CB-8054
> URL: https://issues.apache.org/jira/browse/CB-8054
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera, Windows
>Affects Versions: 3.7.1
> Environment: Windows Phone 8.1
> Lumia 635
> Windows universal app platform
> Camera plugin v0.3.3
>Reporter: Boston Dell-Vandenberg
>
> On the Windows platform when calling getPicture() with "sourceType" of
> "PHOTOLIBRARY" or "SAVEDPHOTOALBUM" it returns "Not supported" error.
> The plugin documentation says Windows is supported but is that not the case?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8054) Camera getPicture photo library not supported on Windows?
[
https://issues.apache.org/jira/browse/CB-8054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342582#comment-14342582
]
Don Becker edited comment on CB-8054 at 3/2/15 1:21 AM:
{code}
// TODO: Add WP8.1 support
// WP8.1 doesn't allow to use of pickSingleFileAsync method
// see http://msdn.microsoft.com/en-us/library/windows/apps/br207852.aspx for
details
// replacement of pickSingleFileAsync - pickSingleFileAndContinue method
// will take application to suspended state and this require additional logic
to wake application up
if (navigator.appVersion.indexOf('Windows Phone 8.1') >= 0 ) {
errorCallback('Not supported');
return;
}
{code}
was (Author: psyon):
{quote}
// TODO: Add WP8.1 support
// WP8.1 doesn't allow to use of pickSingleFileAsync method
// see http://msdn.microsoft.com/en-us/library/windows/apps/br207852.aspx for
details
// replacement of pickSingleFileAsync - pickSingleFileAndContinue method
// will take application to suspended state and this require additional logic
to wake application up
if (navigator.appVersion.indexOf('Windows Phone 8.1') >= 0 ) {
errorCallback('Not supported');
return;
}
{quote}
> Camera getPicture photo library not supported on Windows?
> -
>
> Key: CB-8054
> URL: https://issues.apache.org/jira/browse/CB-8054
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera, Windows
>Affects Versions: 3.7.1
> Environment: Windows Phone 8.1
> Lumia 635
> Windows universal app platform
> Camera plugin v0.3.3
>Reporter: Boston Dell-Vandenberg
>
> On the Windows platform when calling getPicture() with "sourceType" of
> "PHOTOLIBRARY" or "SAVEDPHOTOALBUM" it returns "Not supported" error.
> The plugin documentation says Windows is supported but is that not the case?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342624#comment-14342624 ] ASF GitHub Bot commented on CB-8577: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/174 > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342623#comment-14342623 ] ASF subversion and git services commented on CB-8577: - Commit 4c0fec7d30df238cfc4c834a4235b2c8fcf330ad in cordova-lib's branch refs/heads/master from [~gercan] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4c0fec7 ] CB-8577 - Read plugin variables from correct tag Reads the plugin variables from param, instead of the erroneous variable tag github: close #174 > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN reassigned CB-8577: Assignee: Gorkem ERCAN > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire >Assignee: Gorkem ERCAN > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN resolved CB-8577. -- Resolution: Fixed fixed by reading from > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire >Assignee: Gorkem ERCAN > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8577) 'cordova plugin add --save' should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342808#comment-14342808 ] ASF GitHub Bot commented on CB-8577: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76663106 @gorkem, the change you've committed to fix this issue ( https://github.com/apache/cordova-lib/commit/4c0fec7d30df238cfc4c834a4235b2c8fcf330ad ) introduces another bug : the variables list now contains all the `` such as 'id', 'url', 'installPath', which is not correct ! This is exactly the kind of subtle bugs I was afraid would sneak in if we used the approach you're currently using to fix this issue. Related PR, with alternative fix : https://github.com/apache/cordova-lib/pull/174 > 'cordova plugin add --save' should save variables into config.xml > -- > > Key: CB-8577 > URL: https://issues.apache.org/jira/browse/CB-8577 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire >Assignee: Gorkem ERCAN > > When adding a plugin with the --save/autosave option on, the variables (if > any is passed) should be saved into config.xml so that the plugin can be > auto-restored successfully later during 'prepare' or 'build' operation. > For example: > - cordova create hello com.omefire.hello Hello > - cd hello > - cordova plugin add com.phonegap.plugins.facebookconnect --variable > APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in > facebook plugin added to config.xml > - cordova prepare android => results in an error message : > " Installing "com.phonegap.plugins.facebookconnect" for android > Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) > missing: APP_ID, APP_NAME " > This issue is due to the fact that 'cordova plugin add --save' save > variables in config.xml using the tag instead of the tag. > N.B: on 'cordova prepare ', the plugins are restored from > config.xml if they are not yet installed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
