[jira] [Commented] (CB-5806) [Windows8] Add keepCallback support to proxy
[
https://issues.apache.org/jira/browse/CB-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358160#comment-14358160
]
ASF GitHub Bot commented on CB-5806:
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26281092
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
// CB-5806 [Windows8] Add keepCallback support to proxy
onSuccess = function (result, callbackOptions) {
callbackOptions = callbackOptions || {};
+var callbackStatus;
+if (callbackOptions.status !== null) {
--- End diff --
If the user passed undefined explicitly, it would have evaluated to falsy
and in line 65 (pre-change) would have been replaced with
cordova.callbackStatus.OK. With your change, line 64's (post-change) test is
true (undefined !== null), so local callbackStatus becomes undefined (line 65),
and the status property is undefined (line 72 or 88).
> [Windows8] Add keepCallback support to proxy
>
>
> Key: CB-5806
> URL: https://issues.apache.org/jira/browse/CB-5806
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, Windows 8
>Affects Versions: 3.3.0
>Reporter: Sergey Grebnov
>Assignee: Jesse MacFadyen
> Fix For: 3.4.0
>
>
> Below is current proxy implementation. There is no way pass keepCallbck param
> via onSuccess method.
> onSuccess = function (result) {
> cordova.callbackSuccess(callbackId,
> {
> status: cordova.callbackStatus.OK,
> message: result
> });
> };
> onError = function (err) {
> cordova.callbackError(callbackId,
> {
> status: cordova.callbackStatus.ERROR,
> message: err
> });
> };
> proxy(onSuccess, onError, args);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5806) [Windows8] Add keepCallback support to proxy
[
https://issues.apache.org/jira/browse/CB-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358152#comment-14358152
]
ASF GitHub Bot commented on CB-5806:
Github user CJRChang commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26280804
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
// CB-5806 [Windows8] Add keepCallback support to proxy
onSuccess = function (result, callbackOptions) {
callbackOptions = callbackOptions || {};
+var callbackStatus;
+if (callbackOptions.status !== null) {
--- End diff --
Yes it is - in the event that the user passes a callbackOptions but does
not specify status, it will return null.
> [Windows8] Add keepCallback support to proxy
>
>
> Key: CB-5806
> URL: https://issues.apache.org/jira/browse/CB-5806
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, Windows 8
>Affects Versions: 3.3.0
>Reporter: Sergey Grebnov
>Assignee: Jesse MacFadyen
> Fix For: 3.4.0
>
>
> Below is current proxy implementation. There is no way pass keepCallbck param
> via onSuccess method.
> onSuccess = function (result) {
> cordova.callbackSuccess(callbackId,
> {
> status: cordova.callbackStatus.OK,
> message: result
> });
> };
> onError = function (err) {
> cordova.callbackError(callbackId,
> {
> status: cordova.callbackStatus.ERROR,
> message: err
> });
> };
> proxy(onSuccess, onError, args);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5806) [Windows8] Add keepCallback support to proxy
[
https://issues.apache.org/jira/browse/CB-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358147#comment-14358147
]
ASF GitHub Bot commented on CB-5806:
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26280733
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
// CB-5806 [Windows8] Add keepCallback support to proxy
onSuccess = function (result, callbackOptions) {
callbackOptions = callbackOptions || {};
+var callbackStatus;
+if (callbackOptions.status !== null) {
--- End diff --
Is undefined a possible value here?
> [Windows8] Add keepCallback support to proxy
>
>
> Key: CB-5806
> URL: https://issues.apache.org/jira/browse/CB-5806
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, Windows 8
>Affects Versions: 3.3.0
>Reporter: Sergey Grebnov
>Assignee: Jesse MacFadyen
> Fix For: 3.4.0
>
>
> Below is current proxy implementation. There is no way pass keepCallbck param
> via onSuccess method.
> onSuccess = function (result) {
> cordova.callbackSuccess(callbackId,
> {
> status: cordova.callbackStatus.OK,
> message: result
> });
> };
> onError = function (err) {
> cordova.callbackError(callbackId,
> {
> status: cordova.callbackStatus.ERROR,
> message: err
> });
> };
> proxy(onSuccess, onError, args);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8189) iOS platform update still fail
[
https://issues.apache.org/jira/browse/CB-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357954#comment-14357954
]
Shazron Abdullah commented on CB-8189:
--
It is solved as I showed in my test above (updating 4.0 to 4.1.2) -- no repro.
The template does not have the execute function at all, it was removed Jun 20th
2014 (deprecated since Cordova 2.2) because it was deprecated:
https://github.com/apache/cordova-ios/commits/master/bin/templates/project/__PROJECT_NAME__/Classes/MainViewController.m
The fix is to remove it in your MainViewController, not adding that code.
> iOS platform update still fail
> --
>
> Key: CB-8189
> URL: https://issues.apache.org/jira/browse/CB-8189
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, iOS
>Affects Versions: 4.0.0, 4.1.3
> Environment: Mac
>Reporter: jan
>Assignee: Shazron Abdullah
>Priority: Critical
>
> Cordova 4.0.0 to 4.1.2
> $ cordova platform update ios
> $ cordova run ios
> {code:title= error|borderStyle=solid}
> [INF] [shellscript]
> /Volumes/x/workspace/x_Mobile_App/cordova/platforms/ios/x/Classes/MainViewController.m:154:19:
> error: no visible @interface for '''CDVCommandDelegateImpl''' declares the
> selector '''execute:'''
> [INF] [shellscript] return [super execute:command];
> [INF] [shellscript] ~ ^~~
> [INF] [shellscript] 1 error generated.
> [INF] [shellscript]
> [INF] [shellscript] ** BUILD FAILED **
> [INF] [shellscript]
> [INF] [shellscript]
> [INF] [shellscript] The following build commands failed:
> [INF] [shellscript] CompileC
> build/x.build/Release-iphonesimulator/x.build/Objects-normal/i386/MainViewController.o
> x/Classes/MainViewController.m normal i386 objective-c
> com.apple.compilers.llvm.clang.1_0.compiler
> [INF] [shellscript] (1 failure)
> [INF] [shellscript] Error:
> /Volumes/x/workspace/x_Mobile_App/cordova/platforms/ios/cordova/build:
> Command failed with exit code 65
> [INF] [shellscript] at ChildProcess.whenDone
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/superspawn.js:135:23)
> [INF] [shellscript] at ChildProcess.emit (events.js:98:17)
> [INF] [shellscript] at maybeClose (child_process.js:756:16)
> [INF] [shellscript] at Process.ChildProcess._handle.onexit
> (child_process.js:823:5)
> {code}
> My temporary workaround:
> {code:title=cordova/platforms/ios/CordovaLib/Classes/CDVCommandDelegateImpl.m|borderStyle=solid}
> - (BOOL)execute:(CDVInvokedUrlCommand*)command
> {
> return [_commandQueue execute:command];
> }
> {code}
> + including the method in the header file
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8652) Whitelist plugin cannot be found by createmobilespec.js
[
https://issues.apache.org/jira/browse/CB-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grieve resolved CB-8652.
---
Resolution: Fixed
Thanks Dmitry!
> Whitelist plugin cannot be found by createmobilespec.js
> ---
>
> Key: CB-8652
> URL: https://issues.apache.org/jira/browse/CB-8652
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
>Affects Versions: Master
>Reporter: Dmitry Blotsky
> Labels: cordova, mobilespec, plugin, plugins, whitelist
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Running {{createmobilespec.js}} breaks because it can no longer find the
> whitelist plugin in `cordova-plugins`, since it's been moved to its own repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8652) Whitelist plugin cannot be found by createmobilespec.js
[
https://issues.apache.org/jira/browse/CB-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357951#comment-14357951
]
ASF GitHub Bot commented on CB-8652:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/122
> Whitelist plugin cannot be found by createmobilespec.js
> ---
>
> Key: CB-8652
> URL: https://issues.apache.org/jira/browse/CB-8652
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
>Affects Versions: Master
>Reporter: Dmitry Blotsky
> Labels: cordova, mobilespec, plugin, plugins, whitelist
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Running {{createmobilespec.js}} breaks because it can no longer find the
> whitelist plugin in `cordova-plugins`, since it's been moved to its own repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357756#comment-14357756 ] ASF GitHub Bot commented on CB-8634: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/180#issuecomment-78390923 This change was merged in. > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8652) Whitelist plugin cannot be found by createmobilespec.js
[
https://issues.apache.org/jira/browse/CB-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357738#comment-14357738
]
ASF GitHub Bot commented on CB-8652:
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/122#issuecomment-78388071
@agrieve could you please take a look if you have a convenient time? Thank
you!
> Whitelist plugin cannot be found by createmobilespec.js
> ---
>
> Key: CB-8652
> URL: https://issues.apache.org/jira/browse/CB-8652
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
>Affects Versions: Master
>Reporter: Dmitry Blotsky
> Labels: cordova, mobilespec, plugin, plugins, whitelist
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Running {{createmobilespec.js}} breaks because it can no longer find the
> whitelist plugin in `cordova-plugins`, since it's been moved to its own repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8636) ConfigParser.getFeature() returns invalid variables
[ https://issues.apache.org/jira/browse/CB-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357728#comment-14357728 ] ASF GitHub Bot commented on CB-8636: Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/181 > ConfigParser.getFeature() returns invalid variables > --- > > Key: CB-8636 > URL: https://issues.apache.org/jira/browse/CB-8636 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Calling ConfigParser.getFeature() returns not only the variables defined in > config.xml, but also the id, version, installPath and url elements. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8636) ConfigParser.getFeature() returns invalid variables
[ https://issues.apache.org/jira/browse/CB-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357727#comment-14357727 ] ASF GitHub Bot commented on CB-8636: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-78387046 closing this PR because #182 went in. > ConfigParser.getFeature() returns invalid variables > --- > > Key: CB-8636 > URL: https://issues.apache.org/jira/browse/CB-8636 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Calling ConfigParser.getFeature() returns not only the variables defined in > config.xml, but also the id, version, installPath and url elements. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8653) Move plugins documentation into README
Steve Gill created CB-8653: -- Summary: Move plugins documentation into README Key: CB-8653 URL: https://issues.apache.org/jira/browse/CB-8653 Project: Apache Cordova Issue Type: Task Components: Plugins Reporter: Steve Gill Assignee: Steve Gill -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3360) Set custom InAppBrowser user-agent
[ https://issues.apache.org/jira/browse/CB-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357576#comment-14357576 ] ASF GitHub Bot commented on CB-3360: Github user sinofool commented on the pull request: https://github.com/apache/cordova-ios/pull/131#issuecomment-78368407 Thanks @shazron > Set custom InAppBrowser user-agent > -- > > Key: CB-3360 > URL: https://issues.apache.org/jira/browse/CB-3360 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, BlackBerry, Plugin InAppBrowser, WP8 >Affects Versions: 2.7.0 > Environment: iOS, Android, WP8, BlackBerry >Reporter: Kevin Simpson >Assignee: Joe Bowser >Priority: Minor > Labels: Cordova, InAppBrowser, android > > Currently you can set a custom user-agent for the main Cordova webview by > overriding the init method for the DroidGap class. However, when opening a > page in the InAppBrowser, that webview will still contain the default > user-agent. > There are two solutions that I have thought of to this: > 1. Set the user-agent of the InAppBrowser webview to whatever the user-agent > in the Cordova webview is set to. (This is what I am currently doing, as it > was a one line change, but it requires rebuilding Cordova manually) > 2. Have some sort of configuration option to set the user-agent for the > InAppBrowser. This would allow a different user-agent from the main webview, > but is also a more involved change. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6667) window.requestFileSystem - callbacks are not fired in a particular circumstance
[ https://issues.apache.org/jira/browse/CB-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357562#comment-14357562 ] Kenneth Li commented on CB-6667: Hi everybody, I'm using Cordova 3.7.1 and the cordova file plugin version 1.3.3 and Android SDK API 19, the requestfilesystem callbacks sometimes fired, sometimes not fired when I open my apps in my Samsung Note 2. However, the same app works perfectly in other mobile phones such as Nubia & JinLi (these 2 brands are made in China), this problem makes me crazy and my current work around is using a "global timing variable" and check whether the callbacks are fired within 5 seconds, if not, I use the window.location.reload() function to refresh my page, and this work around works fine. > window.requestFileSystem - callbacks are not fired in a particular > circumstance > --- > > Key: CB-6667 > URL: https://issues.apache.org/jira/browse/CB-6667 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 > Environment: Mac OS X 10.9.2 > Android SDK (latest) - API v19 > Eclipse 4.2.2 >Reporter: Kelvin Dart >Priority: Critical > Labels: Android4.4.x, Cordova, androidmanifest.xml, window > > Excuse the essay, but I have a very odd issue that I have singled down to > Cordova which happens in a very specific circumstance on Android. > I have provided a project of the stock Cordova Android project which can be > found here: http://www.filedropper.com/windowfstest - with a minor > modification for the issue I am having. > I have uploaded a compiled APK to install to your device here: > http://www.filedropper.com/windowfstest140509-1404 > Steps to replicate are: > 1) Download and install that APK onto your device (I was using the Samsung > Galaxy S4 with Android 4.4.2 running, no root, and stock TouchWiz ROM, I > *hope* this occurs on other Android devices but have not had an opportunity > to verify). > 2) Start the application and observe an alert appears stating 'dr', then > afterwards another alert appears, 'got FS' - if you check the code, you'll > see this is normal from my app.initialize(). > 3) Once those two alerts have appeared, press the Android 'home' button, to > quit to the main Android home screen. > 4) Go into another app or two and just use your phone normally. What we are > trying to achieve here is for the Android memory management system to > 'end'/kill the WindowFSTest app in the backend. > 5) Go into Apps > WindowFSTest (i.e. the app in question) and hopefully it > will have restarted - the app has to have restarted for the bug to occur, and > observe a few things here: > a) Verify the app has restarted, this can be verified by the 'dr' popup > occuring when Cordova loads. > b) Once you are confident the app has been restarted, observe the initial > 'dr' popup, but *not* the 'got FS' popup - this is the bug, the > window.requestFileSystem does not fire the callbacks for some reason - and I > do not know why. > N.b. there are a few things to note here which is why the bug is tricky to > replicate AND I imagine will be even more difficult to debug at a lower level > ;-) > 1) The Android system has to kill the app in the backend once you've pressed > the 'home' button - there's no way of determining when this has happened, > just use the phone like ordinary for half a minute or so - normally it kills > it after a short period. > 2) The way to restart the app is via Apps > WindowFSTest (not via the task > manager). > 3) ***IMPORTANT*** the above two steps seem to occur only when you run it > from a compiled APK, not directly from source/debug APK - so it's not as easy > to debug since you cannot put line breaks in the Java file(s). > Although not perfect, one way to fix this is to use: > android:launchMode="singleTop" > In AndroidManifest.xml - since it ensures the app is 'resumed' instead of > restarted. > I can provide a video upon request illustrating the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8652) Whitelist plugin cannot be found by createmobilespec.js
Dmitry Blotsky created CB-8652:
--
Summary: Whitelist plugin cannot be found by createmobilespec.js
Key: CB-8652
URL: https://issues.apache.org/jira/browse/CB-8652
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Affects Versions: Master
Reporter: Dmitry Blotsky
Running {{createmobilespec.js}} breaks because it can no longer find the
whitelist plugin in `cordova-plugins`, since it's been moved to its own repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3360) Set custom InAppBrowser user-agent
[ https://issues.apache.org/jira/browse/CB-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357461#comment-14357461 ] ASF GitHub Bot commented on CB-3360: Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/131#issuecomment-78356414 Note: will review this for the next release, on the 4.0.x branch. Sorry it's taking so long but we were working on getting the 3.8.0 release out with bug fixes. > Set custom InAppBrowser user-agent > -- > > Key: CB-3360 > URL: https://issues.apache.org/jira/browse/CB-3360 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, BlackBerry, Plugin InAppBrowser, WP8 >Affects Versions: 2.7.0 > Environment: iOS, Android, WP8, BlackBerry >Reporter: Kevin Simpson >Assignee: Joe Bowser >Priority: Minor > Labels: Cordova, InAppBrowser, android > > Currently you can set a custom user-agent for the main Cordova webview by > overriding the init method for the DroidGap class. However, when opening a > page in the InAppBrowser, that webview will still contain the default > user-agent. > There are two solutions that I have thought of to this: > 1. Set the user-agent of the InAppBrowser webview to whatever the user-agent > in the Cordova webview is set to. (This is what I am currently doing, as it > was a one line change, but it requires rebuilding Cordova manually) > 2. Have some sort of configuration option to set the user-agent for the > InAppBrowser. This would allow a different user-agent from the main webview, > but is also a more involved change. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8556) handleOpenURL functionality to be removed to a plugin
[ https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-8556: - Description: It's already pluginized due to CB-7606 In 4.0.0, remove the plugin from core and put it in cordova-plugins. Possibility of release as a core plugin, not sure. This will include functionality to configure the callback function that is called, which is currently a global handleOpenURL function. Remove/edit the note here as well: https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md was: It's already pluginized due to CB-7606 In 4.0.0, remove the plugin from core and put it in cordova-plugins. Possibility of release as a core plugin, not sure. This will include functionality to configure the callback function that is called, which is currently a global handleOpenURL function. > handleOpenURL functionality to be removed to a plugin > - > > Key: CB-8556 > URL: https://issues.apache.org/jira/browse/CB-8556 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > It's already pluginized due to CB-7606 > In 4.0.0, remove the plugin from core and put it in cordova-plugins. > Possibility of release as a core plugin, not sure. > This will include functionality to configure the callback function that is > called, which is currently a global handleOpenURL function. > Remove/edit the note here as well: > https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8463) StatusBarPlugin Issue scrollView not found when using WKWebView
[
https://issues.apache.org/jira/browse/CB-8463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357398#comment-14357398
]
Shazron Abdullah commented on CB-8463:
--
Hmm, this is a quandary. Ideally I don't want plugins to break, but I don't see
why plugins need to override this, they should use pluginInitialize instead:
https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/CordovaLib/Classes/CDVPlugin.m#L38
I realize it's a public API, but it really is more of a "package" API for use
by CordovaLib to instantiate plugins.
Took a look at the battery status plugin, the contents of its initializer
function really should go in pluginInitialize. In fact, that's what our docs
say for plugin dev:
"There is no designated initializer for plugins. Instead, plugins should use
the pluginInitialize method for their startup logic."
http://cordova.apache.org/docs/en/4.0.0/guide_platforms_ios_plugin.md.html#iOS%20Plugins
Changing the use to pluginInitialize will not break the plugins for cordova-ios
3.x as well since pluginInitialize is supported in that series.
When making the API change, I considered that the 4.0 major version bump
allowed us to get rid of some of this type of technical debt, especially since
the intended use was not as an initializer for plugins themselves.
We could put out an Upgrade note here, as well as blog about it:
https://github.com/apache/cordova-ios/tree/master/guides
> StatusBarPlugin Issue scrollView not found when using WKWebView
> ---
>
> Key: CB-8463
> URL: https://issues.apache.org/jira/browse/CB-8463
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin Statusbar
> Environment: iOS 8
>Reporter: Holly Schinsky
>Assignee: Shazron Abdullah
>
> When using the WKWebView Plugin and the StatusBarPlugin together, the
> following error is received from the *CDVStatusBar.m* class:
> {code}
> CDVStatusBar.m:128:18: error:
> property 'scrollView' not found on object of type 'UIView *'
> self.webView.scrollView.scrollsToTop = NO;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8651) Restoring platforms and plugins causes plugin install to be triggered twice
[
https://issues.apache.org/jira/browse/CB-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Connor Pearson updated CB-8651:
---
Description:
Using the basic starter app with the following config.xml:
{code:xml}
http://www.w3.org/ns/widgets";
xmlns:cdv="http://cordova.apache.org/ns/1.0";>
HelloCordova
{code}
Running cordova prepare ios without a platforms or plugins directory produces
this output:
{quote}
Restoring platform ios@3.8.0 referenced on config.xml
Adding ios project...
iOS project created with cordova-ios@3.8.0
Discovered org.apache.cordova.device in config.xml. Installing to the project
Fetching plugin "org.apache.cordova.device" via plugin registry
Installing "org.apache.cordova.device" for ios
Plugin "org.apache.cordova.device" already installed on ios.
{quote}
It looks like Cordova is trying to install the plugin twice.
was:
Using the basic template with the following config.xml:
{code:xml}
http://www.w3.org/ns/widgets";
xmlns:cdv="http://cordova.apache.org/ns/1.0";>
HelloCordova
{code}
Running cordova prepare ios without a platforms or plugins directory produces
this output:
{quote}
Restoring platform ios@3.8.0 referenced on config.xml
Adding ios project...
iOS project created with cordova-ios@3.8.0
Discovered org.apache.cordova.device in config.xml. Installing to the project
Fetching plugin "org.apache.cordova.device" via plugin registry
Installing "org.apache.cordova.device" for ios
Plugin "org.apache.cordova.device" already installed on ios.
{quote}
It looks like Cordova is trying to install the plugin twice.
> Restoring platforms and plugins causes plugin install to be triggered twice
> ---
>
> Key: CB-8651
> URL: https://issues.apache.org/jira/browse/CB-8651
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Reporter: Connor Pearson
>Priority: Minor
>
> Using the basic starter app with the following config.xml:
> {code:xml}
>
> xmlns="http://www.w3.org/ns/widgets";
> xmlns:cdv="http://cordova.apache.org/ns/1.0";>
> HelloCordova
>
>
>
>
>
>
>
> {code}
> Running cordova prepare ios without a platforms or plugins directory produces
> this output:
> {quote}
> Restoring platform ios@3.8.0 referenced on config.xml
> Adding ios project...
> iOS project created with cordova-ios@3.8.0
> Discovered org.apache.cordova.device in config.xml. Installing to the project
> Fetching plugin "org.apache.cordova.device" via plugin registry
> Installing "org.apache.cordova.device" for ios
> Plugin "org.apache.cordova.device" already installed on ios.
> {quote}
> It looks like Cordova is trying to install the plugin twice.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8651) Restoring platforms and plugins causes plugin install to be triggered twice
Connor Pearson created CB-8651:
--
Summary: Restoring platforms and plugins causes plugin install to
be triggered twice
Key: CB-8651
URL: https://issues.apache.org/jira/browse/CB-8651
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Reporter: Connor Pearson
Priority: Minor
Using the basic template with the following config.xml:
{code:xml}
http://www.w3.org/ns/widgets";
xmlns:cdv="http://cordova.apache.org/ns/1.0";>
HelloCordova
{code}
Running cordova prepare ios without a platforms or plugins directory produces
this output:
{quote}
Restoring platform ios@3.8.0 referenced on config.xml
Adding ios project...
iOS project created with cordova-ios@3.8.0
Discovered org.apache.cordova.device in config.xml. Installing to the project
Fetching plugin "org.apache.cordova.device" via plugin registry
Installing "org.apache.cordova.device" for ios
Plugin "org.apache.cordova.device" already installed on ios.
{quote}
It looks like Cordova is trying to install the plugin twice.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8595) Merge platform specific code into one place
[
https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357235#comment-14357235
]
ASF GitHub Bot commented on CB-8595:
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26233744
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
+
+self.getFilesAndFrameworks = getFilesAndFrameworks;
+function getFilesAndFrameworks(platform) {
+var items = [];
+// Please avoid changing the order of the calls below, files will
be
+// installed in this order.
+items = items.concat(self.getSourceFiles(platform));
+items = items.concat(self.getHeaderFiles(platform));
+items = items.concat(self.getResourceFiles(platform));
+items = items.concat(self.getFrameworks(platform));
+items = items.concat(self.getLibFiles(platform));
--- End diff --
I would recommend :
var items = [];
items = items.concat(self.getSourceFiles(platform),
self.getHeaderFiles(platform),
... );
// unnecessarily tricky code is a barrier to some, clarity is king
> Merge platform specific code into one place
> ---
>
> Key: CB-8595
> URL: https://issues.apache.org/jira/browse/CB-8595
> Project: Apache Cordova
> Issue Type: Improvement
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to
> the platform repos where it belongs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-7606) handleOpenURL handler firing more than necessary
[ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346635#comment-14346635 ] Sebastian Kellgren edited comment on CB-7606 at 3/11/15 5:03 PM: - [~shazron], Awsome that you are looking in to this! But, seems like the fix for coldstart does not work for the ios@3.8.0. I have tried to recreate your test case from above and it's not running as expected. The warm start is firing the js handler as expected but not on the cold start. If i use version 3.6.0 everything fires as expected. I have also tried the exact steps as in your test branch and getting the CB-7606 branch with git. I don't know if this is related to a change in the tools or something else. I am very novice when it comes to ObjectiveC so i cant really tell you more in whats going on. My environment looks like this ~/code/CB-7606/CB-7606 master ❯ cordova -v 4.2.0 ❯ xcode -v Version 6.1.1 (6A2008a) The code that i've tried can be found here https://github.com/sekel/CB-7606. Edit: Any update on this? was (Author: sekel): [~shazron], Awsome that you are looking in to this! But, seems like the fix for coldstart does not work for the ios@3.8.0. I have tried to recreate your test case from above and it's not running as expected. The warm start is firing the js handler as expected but not on the cold start. If i use version 3.6.0 everything fires as expected. I have also tried the exact steps as in your test branch and getting the CB-7606 branch with git. I don't know if this is related to a change in the tools or something else. I am very novice when it comes to ObjectiveC so i cant really tell you more in whats going on. My environment looks like this ~/code/CB-7606/CB-7606 master ❯ cordova -v 4.2.0 ❯ xcode -v Version 6.1.1 (6A2008a) The code that i've tried can be found here https://github.com/sekel/CB-7606. > handleOpenURL handler firing more than necessary > > > Key: CB-7606 > URL: https://issues.apache.org/jira/browse/CB-7606 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Paul Kane >Assignee: Shazron Abdullah > Fix For: 3.8.0 > > > I'm not an Obj-C or Cordova programmer so bear with me. > Let's say my app is running. Then I hop over to my mail app and click on a > link (myapp://blahBlahBlah) that should open up my app. This works fine, the > app opens, my own URL handler (in javascript) takes over, etc. > However in Obj-C the view controller is -- incorrectly, I believe -- storing > that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up > later in processOpenURL function, called during webView initialization). > This isn't normally a problem, except when you move to a new page > (window.href = "/new_page"), the webView initialization runs again and picks > up the old (already-acted-upon) openURL variable. (it's then set to nil, so > that it doesn't get acted upon a third time, fourth time, etc...). > I might have some details wrong, but it should be fairly easy to walk through > with a project-wide search for "openurl". Just seems like a slightly wrong > logic-flow, which unfortunately is interfering with my app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8650) Camera crashes on iOS if popoverOptions is set
Wayne Fisher created CB-8650:
Summary: Camera crashes on iOS if popoverOptions is set
Key: CB-8650
URL: https://issues.apache.org/jira/browse/CB-8650
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.8.0
Environment: iOS 8.1.2, iPad 2
Reporter: Wayne Fisher
My app has been using the camera plugin for some time now to both capture
pictures directly from the camera and to retrieve them from the photo library.
I recently updated Cordova to 3.8.0 and the 0.3.5 camera plugin. The app now
crashes when trying to get an image from the photo library on my iPad 2.
The javascript code looks similar to the following:
{code}
// Get a new picture from the library.
var offset;
var options = {
quality: 80,
sourceType: navigator.camera.PictureSourceType.PHOTOLIBRARY
};
// Correctly position the arrow of the iOS dialog.
offset = getElementOffset(this);
options.popoverOptions = new CameraPopoverOptions(offset.x, offset.y,
this.clientWidth, this.clientHeight,
Camera.PopoverArrowDirection.ARROW_ANY);
navigator.camera.getPicture(captureSuccess, captureFailure, options);
{code}
If I comment out the lines where options.popoverOptions gets set, it works fine
(other than the popover being poorly located).
Also going back to the 0.3.4 version of the camera plugin works fine.
The crash is reported as:
{quote}
*** Terminating app due to uncaught exception 'NSUnknownKeyException', reason:
'[ valueForUndefinedKey:]: this class is not key value
coding-compliant for the key x.’
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8649) Media Plugin WP8.1 Media.getDuration returns -1 for audio (mp3) asset
Kim Hansen created CB-8649: -- Summary: Media Plugin WP8.1 Media.getDuration returns -1 for audio (mp3) asset Key: CB-8649 URL: https://issues.apache.org/jira/browse/CB-8649 Project: Apache Cordova Issue Type: Bug Reporter: Kim Hansen Priority: Minor It is understood that WP8.1 is not supported (hence minor priority) but when support is added this is fixable. Media plugin 0.2.13, Cordova 4.2.0, Tools for Apache Cordova The duration can be found at Media.node.duration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8463) StatusBarPlugin Issue scrollView not found when using WKWebView
[
https://issues.apache.org/jira/browse/CB-8463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357029#comment-14357029
]
Ian Clelland edited comment on CB-8463 at 3/11/15 3:26 PM:
---
This patch seems to break (at least) the battery-status plugin -- it uses the
*public* api
{code}
- (instancetype)initWithWebView:(UIView*)theWebView
{code}
which is removed by this patch, and I don't see an easy way to back-fill it. I
don't think there's a way to get at the WebViewEngine from the bare UIView now.
Is there a plan for backwards compatibility? There are probably other
third-party plugins affected as well.
was (Author: iclelland):
This patch seems to break (at least) the battery-status plugin -- it uses the
*public* api
- (instancetype)initWithWebView:(UIView*)theWebView
which is removed by this patch, and I don't see an easy way to back-fill it. I
don't think there's a way to get at the WebViewEngine from the bare UIView now.
Is there a plan for backwards compatibility? There are probably other
third-party plugins affected as well.
> StatusBarPlugin Issue scrollView not found when using WKWebView
> ---
>
> Key: CB-8463
> URL: https://issues.apache.org/jira/browse/CB-8463
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin Statusbar
> Environment: iOS 8
>Reporter: Holly Schinsky
>Assignee: Shazron Abdullah
>
> When using the WKWebView Plugin and the StatusBarPlugin together, the
> following error is received from the *CDVStatusBar.m* class:
> {code}
> CDVStatusBar.m:128:18: error:
> property 'scrollView' not found on object of type 'UIView *'
> self.webView.scrollView.scrollsToTop = NO;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8463) StatusBarPlugin Issue scrollView not found when using WKWebView
[
https://issues.apache.org/jira/browse/CB-8463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357029#comment-14357029
]
Ian Clelland commented on CB-8463:
--
This patch seems to break (at least) the battery-status plugin -- it uses the
*public* api
- (instancetype)initWithWebView:(UIView*)theWebView
which is removed by this patch, and I don't see an easy way to back-fill it. I
don't think there's a way to get at the WebViewEngine from the bare UIView now.
Is there a plan for backwards compatibility? There are probably other
third-party plugins affected as well.
> StatusBarPlugin Issue scrollView not found when using WKWebView
> ---
>
> Key: CB-8463
> URL: https://issues.apache.org/jira/browse/CB-8463
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin Statusbar
> Environment: iOS 8
>Reporter: Holly Schinsky
>Assignee: Shazron Abdullah
>
> When using the WKWebView Plugin and the StatusBarPlugin together, the
> following error is received from the *CDVStatusBar.m* class:
> {code}
> CDVStatusBar.m:128:18: error:
> property 'scrollView' not found on object of type 'UIView *'
> self.webView.scrollView.scrollsToTop = NO;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8595) Merge platform specific code into one place
[
https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356983#comment-14356983
]
ASF GitHub Bot commented on CB-8595:
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26218885
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var platforms = require('./platformsConfig.json');
+
+// Remove this block soon. The parser property is no longer used in
+// cordova-lib but some downstream tools still use it.
+var addModuleProperty = require('../cordova/util').addModuleProperty;
+Object.keys(platforms).forEach(function(key) {
+var obj = platforms[key];
+if (obj.parser_file) {
+addModuleProperty(module, 'parser', obj.parser_file, false, obj);
+}
+});
+
+
+// Avoid loading the same platform projects more than once (identified by
path)
+var cachedProjects = {};
+
+var PARSER_PUBLIC_METHODS = [
+'config_xml',
+'cordovajs_path',
+'update_from_config',
+'update_overrides',
+'update_project',
+'update_www',
+'www_dir',
+];
+
+var HANDLER_PUBLIC_METHODS = [
+'package_name',
+'parseProjectFile',
+'purgeProjectFileCache',
+];
+
+
+// A single class that exposes functionality from platform specific files
from
+// both places cordova/metadata and plugman/platforms. Hopefully, to be
soon
+// replaced by real unified platform specific classes.
+function PlatformProjectAdapter(platform, platformRootDir) {
+var self = this;
+self.root = platformRootDir;
+self.platform = platform;
+var ParserConstructor = require(platforms[platform].parser_file);
+self.parser = new ParserConstructor(platformRootDir);
+self.handler = require(platforms[platform].handler_file);
+
+// Expos all public methods from the parser and handler, properly
bound.
+PARSER_PUBLIC_METHODS.forEach(function(method) {
+if (self.parser[method]) {
+self[method] = self.parser[method].bind(self.parser);
+}
+});
+
+HANDLER_PUBLIC_METHODS.forEach(function(method) {
+if (self.handler[method]) {
+self[method] = self.handler[method].bind(self.handler);
+}
+});
+
+self.getInstaller = function(type) {
+return self.handler[type].install;
+};
+
+self.getUninstaller = function(type) {
+return self.handler[type].uninstall;
+};
+}
+
+// getPlatformProject() should be the only method of instantiating the
+// PlatformProject classes for now.
+function getPlatformProject(platform, platformRootDir) {
+var cached = cachedProjects[platformRootDir];
+if (cached && cached.platform == platform) {
--- End diff --
The tests sometimes reuse the same dir for several platforms. Added the
platform check after spending a couple of hours figuring this out. Not sure if
there is a viable real world case for using the same dir for different
platforms.
> Merge platform specific code into one place
> ---
>
> Key: CB-8595
> URL: https://issues.apache.org/jira/browse/CB-8595
> Project: Apache Cordova
> Issue Type: Improvement
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to
> the platform repos where it belongs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscri
[jira] [Resolved] (CB-7747) Extract whitelist functionality into a plugin
[ https://issues.apache.org/jira/browse/CB-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7747. --- Resolution: Fixed Done! https://github.com/apache/cordova-plugin-whitelist https://github.com/apache/cordova-plugin-legacy-whitelist > Extract whitelist functionality into a plugin > - > > Key: CB-7747 > URL: https://issues.apache.org/jira/browse/CB-7747 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS >Affects Versions: 4.0.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mailing list thread: http://markmail.org/message/6jqt5f3t4iio52td > Also @apache: > https://mail-archives.apache.org/mod_mbox/cordova-dev/201407.mbox/%3CCADVgkyNN3EKT4xiRXJFbwMGFhsrVF3kHQRzd3exvb5nW7_GdfA%40mail.gmail.com%3E > Ideally the network policy is completely removed from Cordova core, and > replaced with a small set of plugin hooks so that different kinds of policies > can be implemented in different plugins. The current whitelist implementation > can be an example plugin provided for backwards-compatibility. > It should also be possible, once this is removed, to control the webview's > network policy with CSP, in most platforms. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8595) Merge platform specific code into one place
[
https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356921#comment-14356921
]
ASF GitHub Bot commented on CB-8595:
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215310
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
+
+self.getFilesAndFrameworks = getFilesAndFrameworks;
+function getFilesAndFrameworks(platform) {
+var items = [];
+// Please avoid changing the order of the calls below, files will
be
+// installed in this order.
+items = items.concat(self.getSourceFiles(platform));
+items = items.concat(self.getHeaderFiles(platform));
+items = items.concat(self.getResourceFiles(platform));
+items = items.concat(self.getFrameworks(platform));
+items = items.concat(self.getLibFiles(platform));
--- End diff --
Good idea, will change.
> Merge platform specific code into one place
> ---
>
> Key: CB-8595
> URL: https://issues.apache.org/jira/browse/CB-8595
> Project: Apache Cordova
> Issue Type: Improvement
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to
> the platform repos where it belongs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8595) Merge platform specific code into one place
[
https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356918#comment-14356918
]
ASF GitHub Bot commented on CB-8595:
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215211
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var platforms = require('./platformsConfig.json');
+
+// Remove this block soon. The parser property is no longer used in
+// cordova-lib but some downstream tools still use it.
+var addModuleProperty = require('../cordova/util').addModuleProperty;
+Object.keys(platforms).forEach(function(key) {
+var obj = platforms[key];
+if (obj.parser_file) {
+addModuleProperty(module, 'parser', obj.parser_file, false, obj);
+}
+});
+
+
+// Avoid loading the same platform projects more than once (identified by
path)
+var cachedProjects = {};
+
+var PARSER_PUBLIC_METHODS = [
+'config_xml',
+'cordovajs_path',
+'update_from_config',
+'update_overrides',
+'update_project',
+'update_www',
+'www_dir',
+];
+
+var HANDLER_PUBLIC_METHODS = [
+'package_name',
+'parseProjectFile',
+'purgeProjectFileCache',
+];
+
+
+// A single class that exposes functionality from platform specific files
from
+// both places cordova/metadata and plugman/platforms. Hopefully, to be
soon
+// replaced by real unified platform specific classes.
+function PlatformProjectAdapter(platform, platformRootDir) {
+var self = this;
+self.root = platformRootDir;
+self.platform = platform;
+var ParserConstructor = require(platforms[platform].parser_file);
+self.parser = new ParserConstructor(platformRootDir);
+self.handler = require(platforms[platform].handler_file);
+
+// Expos all public methods from the parser and handler, properly
bound.
+PARSER_PUBLIC_METHODS.forEach(function(method) {
+if (self.parser[method]) {
+self[method] = self.parser[method].bind(self.parser);
+}
+});
+
+HANDLER_PUBLIC_METHODS.forEach(function(method) {
+if (self.handler[method]) {
--- End diff --
For the handlers the if is still needed because there is actually code that
checks if the handler has a parseProjectFile() function before calling it.
> Merge platform specific code into one place
> ---
>
> Key: CB-8595
> URL: https://issues.apache.org/jira/browse/CB-8595
> Project: Apache Cordova
> Issue Type: Improvement
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to
> the platform repos where it belongs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8595) Merge platform specific code into one place
[
https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356908#comment-14356908
]
ASF GitHub Bot commented on CB-8595:
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214642
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var platforms = require('./platformsConfig.json');
+
+// Remove this block soon. The parser property is no longer used in
+// cordova-lib but some downstream tools still use it.
+var addModuleProperty = require('../cordova/util').addModuleProperty;
+Object.keys(platforms).forEach(function(key) {
+var obj = platforms[key];
+if (obj.parser_file) {
+addModuleProperty(module, 'parser', obj.parser_file, false, obj);
+}
+});
+
+
+// Avoid loading the same platform projects more than once (identified by
path)
+var cachedProjects = {};
+
+var PARSER_PUBLIC_METHODS = [
+'config_xml',
+'cordovajs_path',
+'update_from_config',
+'update_overrides',
+'update_project',
+'update_www',
+'www_dir',
+];
+
+var HANDLER_PUBLIC_METHODS = [
+'package_name',
+'parseProjectFile',
+'purgeProjectFileCache',
+];
+
+
+// A single class that exposes functionality from platform specific files
from
+// both places cordova/metadata and plugman/platforms. Hopefully, to be
soon
+// replaced by real unified platform specific classes.
+function PlatformProjectAdapter(platform, platformRootDir) {
+var self = this;
+self.root = platformRootDir;
+self.platform = platform;
+var ParserConstructor = require(platforms[platform].parser_file);
+self.parser = new ParserConstructor(platformRootDir);
+self.handler = require(platforms[platform].handler_file);
+
+// Expos all public methods from the parser and handler, properly
bound.
+PARSER_PUBLIC_METHODS.forEach(function(method) {
+if (self.parser[method]) {
+self[method] = self.parser[method].bind(self.parser);
+}
+});
+
+HANDLER_PUBLIC_METHODS.forEach(function(method) {
+if (self.handler[method]) {
+self[method] = self.handler[method].bind(self.handler);
+}
+});
+
+self.getInstaller = function(type) {
+return self.handler[type].install;
+};
+
+self.getUninstaller = function(type) {
+return self.handler[type].uninstall;
+};
+}
+
+// getPlatformProject() should be the only method of instantiating the
+// PlatformProject classes for now.
+function getPlatformProject(platform, platformRootDir) {
+var cached = cachedProjects[platformRootDir];
+if (cached && cached.platform == platform) {
--- End diff --
If we have a `cached` PlatformProject already, shouldn't we just assert
that `cached.platform == platform` inside the if? If the platform is wrong,
theres a bug right?
> Merge platform specific code into one place
> ---
>
> Key: CB-8595
> URL: https://issues.apache.org/jira/browse/CB-8595
> Project: Apache Cordova
> Issue Type: Improvement
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to
> the platform repos where it belongs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional
[jira] [Commented] (CB-8595) Merge platform specific code into one place
[
https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356887#comment-14356887
]
ASF GitHub Bot commented on CB-8595:
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26213790
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
+
+self.getFilesAndFrameworks = getFilesAndFrameworks;
+function getFilesAndFrameworks(platform) {
+var items = [];
+// Please avoid changing the order of the calls below, files will
be
+// installed in this order.
+items = items.concat(self.getSourceFiles(platform));
+items = items.concat(self.getHeaderFiles(platform));
+items = items.concat(self.getResourceFiles(platform));
+items = items.concat(self.getFrameworks(platform));
+items = items.concat(self.getLibFiles(platform));
--- End diff --
Tip: `concat` actually accepts any number of arguments and will concat all
in one go.
Can also do: `[].concat.apply([], [ self.getSourceFiles(..),
self.getHeaderFiles(..), ...])`
Which I think looks nicest.
> Merge platform specific code into one place
> ---
>
> Key: CB-8595
> URL: https://issues.apache.org/jira/browse/CB-8595
> Project: Apache Cordova
> Issue Type: Improvement
>Reporter: Mark Koudritsky
>Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to
> the platform repos where it belongs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-5078) App crashes on samsung galaxy s3 with android 4.0.4 when using plugin that opens a new activity (camera,gallery,voice recorder, etc.)
[ https://issues.apache.org/jira/browse/CB-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350562#comment-14350562 ] Matthew Keable edited comment on CB-5078 at 3/11/15 1:05 PM: - I'm able to reliably reproduce this on a Galaxy S3 running Android 4.4.3. This is using Cordova CLI 4.0, Cordova for Android 3.7.1 and the March 2nd version of the Media Capture Plugin. For me the most reliable way to reproduce it is to record a video using the media-capture plugin, then hit the play button to watch the video back. On the S3 when you then save a video it will restart the app. If you don't watch the video back then it behaves itself. I've not been able to reproduce this on any other test device. was (Author: keab42): I'm able to reliably reproduce this on a Galaxy S3 running Android 4.4.3. For me the most reliable way to reproduce it is to record a video using the media-capture plugin, then hit the play button to watch the video back. On the S3 when you then save a video it will restart the app, if you don't want the video back then it behaves itself. I've not been able to reproduce this on any other test device. > App crashes on samsung galaxy s3 with android 4.0.4 when using plugin that > opens a new activity (camera,gallery,voice recorder, etc.) > - > > Key: CB-5078 > URL: https://issues.apache.org/jira/browse/CB-5078 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Camera, Plugin Media Capture >Affects Versions: 3.0.0 > Environment: samsung galaxy s3 with android 4.0.4. the app is based > on phonegap 3.0.0 >Reporter: Shay Stern >Assignee: Joe Bowser > Labels: android, plugin > > when using phonegap API for camera, media capture etc, or any other plugin > which opens a new android activity, the main app restart itself. > it happens also on an hello world app, so it doesn't happen because of high > memory consumption app, or any internal defect. > the defect is reproducible only on Samsung galaxy s3 with android version > 4.0.4. it wasn't reproducible on Samsung galaxy s2 with 4.0.4 or Samsung > galaxy s3 with 4.1.2. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8542) long delay opening camera roll and initializing camera v 0.3.5
[
https://issues.apache.org/jira/browse/CB-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356821#comment-14356821
]
Justin Noel edited comment on CB-8542 at 3/11/15 12:38 PM:
---
Experiencing same problem. Takes 5 to 15 seconds for camera UI to load.
Frequently, it is a black screen with the focus box showing. Sometimes after
10 more seconds, the image will appear.
Somewhat related : https://issues.apache.org/jira/browse/CB-7641
Cordova CLI : 4.3.0
Cordova iOS : 3.8.0
Cordova Camera Plugins : 0.3.5 and 0.3.6 (same problem in each)
was (Author: jnoel):
Experiencing same problem. Takes 5 to 15 seconds for camera UI to load.
Frequently, it is a black screen with the focus box showing. Sometimes after
10 more seconds, the image will appear.
Somewhat related : https://issues.apache.org/jira/browse/CB-8035
Cordova CLI : 4.3.0
Cordova iOS : 3.8.0
Cordova Camera Plugins : 0.3.5 and 0.3.6 (same problem in each)
> long delay opening camera roll and initializing camera v 0.3.5
> --
>
> Key: CB-8542
> URL: https://issues.apache.org/jira/browse/CB-8542
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 3.7.0
> Environment: iOS 7.1.1 iPad Model MD522NF/A
>Reporter: Eltjo Boersma
>
> I am using iOS platform version 3.7.0 and it came recently with an upgrade of
> the camera plugin 0.3.4 -> 0.3.5.
> With this version opening the camera roll takes more than 40 seconds.
> (On this test iPad there is only one camera roll with only 57 pictures.)
> Also using the camera shows a delay of more than 30 seconds to fully
> initialize. It starts out with a black screen but with the controls active.
> Also the focus square appears from time to time. Taking a picture when the
> screen is black yields a proper image and the screen is no longer black when
> doing retake.
> Also on iPhone 6 and iOS 8.1.3 there is a noticeable delay when opening the
> camera roll, but it is less pronounced.
> The delays are no longer present when I revert back to version 0.3.4.
> Here is how I call the api:
> Camera roll
> navigator.camera.getPicture(this.addDocumentDone, this.addDocumentFails, {
> quality: 50,
> sourceType: 0,
> destinationType: Camera.DestinationType.DATA_URL,
> allowEdit: true
> });
> Camera
> navigator.camera.getPicture(this.addDocumentDone, this.addDocumentFails, {
> quality: 50,
> sourceType: Camera.PictureSourceType.CAMERA,
> destinationType: Camera.DestinationType.DATA_URL,
> allowEdit: true,
> saveToPhotoAlbum: true,
> correctOrientation: true
> });
> Thanks for looking into this and best regards,
> Eltjo
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8542) long delay opening camera roll and initializing camera v 0.3.5
[
https://issues.apache.org/jira/browse/CB-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356821#comment-14356821
]
Justin Noel commented on CB-8542:
-
Experiencing same problem. Takes 5 to 15 seconds for camera UI to load.
Frequently, it is a black screen with the focus box showing. Sometimes after
10 more seconds, the image will appear.
Somewhat related : https://issues.apache.org/jira/browse/CB-8035
Cordova CLI : 4.3.0
Cordova iOS : 3.8.0
Cordova Camera Plugins : 0.3.5 and 0.3.6 (same problem in each)
> long delay opening camera roll and initializing camera v 0.3.5
> --
>
> Key: CB-8542
> URL: https://issues.apache.org/jira/browse/CB-8542
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 3.7.0
> Environment: iOS 7.1.1 iPad Model MD522NF/A
>Reporter: Eltjo Boersma
>
> I am using iOS platform version 3.7.0 and it came recently with an upgrade of
> the camera plugin 0.3.4 -> 0.3.5.
> With this version opening the camera roll takes more than 40 seconds.
> (On this test iPad there is only one camera roll with only 57 pictures.)
> Also using the camera shows a delay of more than 30 seconds to fully
> initialize. It starts out with a black screen but with the controls active.
> Also the focus square appears from time to time. Taking a picture when the
> screen is black yields a proper image and the screen is no longer black when
> doing retake.
> Also on iPhone 6 and iOS 8.1.3 there is a noticeable delay when opening the
> camera roll, but it is less pronounced.
> The delays are no longer present when I revert back to version 0.3.4.
> Here is how I call the api:
> Camera roll
> navigator.camera.getPicture(this.addDocumentDone, this.addDocumentFails, {
> quality: 50,
> sourceType: 0,
> destinationType: Camera.DestinationType.DATA_URL,
> allowEdit: true
> });
> Camera
> navigator.camera.getPicture(this.addDocumentDone, this.addDocumentFails, {
> quality: 50,
> sourceType: Camera.PictureSourceType.CAMERA,
> destinationType: Camera.DestinationType.DATA_URL,
> allowEdit: true,
> saveToPhotoAlbum: true,
> correctOrientation: true
> });
> Thanks for looking into this and best regards,
> Eltjo
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8447) 'cordova platform update android@3.7.1' fails
[ https://issues.apache.org/jira/browse/CB-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356785#comment-14356785 ] Imran Ahmed commented on CB-8447: - This bug is fixed in cordova-lib@4.3.0 > 'cordova platform update android@3.7.1' fails > - > > Key: CB-8447 > URL: https://issues.apache.org/jira/browse/CB-8447 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire > > [This issue is resolved in the current master branch] > In cordova-lib@4.2.0, The following sequence of operations fails : > - cordova platform add android@3.5.0 > - cordova platform update android@3.7.1 > The error message is : "Platform "android@3.7.1" is not installed. See > `cordova platform list`." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356680#comment-14356680 ] ASF subversion and git services commented on CB-8634: - Commit 2eaebd89064604e85ebde068b38a4ec080da2e61 in cordova-cli's branch refs/heads/master from [~omefire] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=2eaebd8 ] CB-8634 Adds docs about support for custom branches for `cordova platform add` This closes #210 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356683#comment-14356683 ] ASF GitHub Bot commented on CB-8634: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/210 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356679#comment-14356679 ] ASF GitHub Bot commented on CB-8634: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/180 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8633) Regression: `cordova platform add` does not support tarballs anymore
[ https://issues.apache.org/jira/browse/CB-8633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356674#comment-14356674 ] ASF GitHub Bot commented on CB-8633: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/179 > Regression: `cordova platform add` does not support tarballs anymore > > > Key: CB-8633 > URL: https://issues.apache.org/jira/browse/CB-8633 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire > > Issuing the command `cordova platform add > "https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz"` > used to work. now, it results in the following error : > omefire@my-machine:~/Cordova/test-apps/hello$ cordova platform add > android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz"; > git cloning: > android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz"; > Unable to fetch platform > browser@android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz": > Error: Command failed: Cloning into > '/home/omefire/.cordova/lib/tmp/tmp_cordova_git_23549_1425806531335'... > fatal: unable to access > 'android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz";': > The requested URL returned error: 403 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8633) Regression: `cordova platform add` does not support tarballs anymore
[ https://issues.apache.org/jira/browse/CB-8633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356673#comment-14356673 ] ASF subversion and git services commented on CB-8633: - Commit f830e4651512040ef790e82a3b07495f163ec848 in cordova-lib's branch refs/heads/master from [~omefire] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f830e46 ] CB-8633 BugFix: Support for urls to tarballs was broken > Regression: `cordova platform add` does not support tarballs anymore > > > Key: CB-8633 > URL: https://issues.apache.org/jira/browse/CB-8633 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire > > Issuing the command `cordova platform add > "https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz"` > used to work. now, it results in the following error : > omefire@my-machine:~/Cordova/test-apps/hello$ cordova platform add > android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz"; > git cloning: > android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz"; > Unable to fetch platform > browser@android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz": > Error: Command failed: Cloning into > '/home/omefire/.cordova/lib/tmp/tmp_cordova_git_23549_1425806531335'... > fatal: unable to access > 'android@"https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.7.1;sf=tgz";': > The requested URL returned error: 403 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
