[jira] [Resolved] (CB-9111) Medic gets test results from another build if there were no test results reported on current build.
[
https://issues.apache.org/jira/browse/CB-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Sorokin resolved CB-9111.
---
Resolution: Fixed
> Medic gets test results from another build if there were no test results
> reported on current build.
> ---
>
> Key: CB-9111
> URL: https://issues.apache.org/jira/browse/CB-9111
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
>Reporter: Alexander Sorokin
>
> This happens because it requests test results by following request:
> {code}
> http://cdv-ms-buildbot.cloudapp.net:5984/mobilespec_results/_all_docs?start_key=%22cordova-windows-store8.1-98-cdv-ms-master%22&limit=1
> {code}
> This query returns results from another run simply because there is no
> end_key parameter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7143) OSX platform cannot be installed as described
[ https://issues.apache.org/jira/browse/CB-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578354#comment-14578354 ] ASF GitHub Bot commented on CB-7143: Github user hypery2k commented on the pull request: https://github.com/apache/cordova-osx/pull/12#issuecomment-110231057 is it possible that within the next cordova release OS X is officially supported? > OSX platform cannot be installed as described > - > > Key: CB-7143 > URL: https://issues.apache.org/jira/browse/CB-7143 > Project: Apache Cordova > Issue Type: Bug > Components: OSX >Affects Versions: 3.5.0 > Environment: OSX 10.9.4 >Reporter: Tim Stewart > > Following instructions as per: > https://github.com/apache/cordova-osx > "Add the Cordova OSX Platform the a CLI project" [sic] > does not work. > I checked out cordova from master, completed all the npm linking as described > in the linked instructions and checked cordova version: > 3.5.0-0.2.7-dev > I then tried to follow this instruction: "patch the 2 projects with the > patches provided in the patches directory to enable the osx platform". I > expected to be able to download and git apply these patches in the git root > for each of the two node modules - cordova-cli and cordova-plugman. However, > they are not set up correctly for this, and produced errors: > error: platforms.js: No such file or directory > error: src/platform.js: No such file or directory > Indeed, the path locations in each patch do not seem to be vaild for any > given location within either module. I thus ended up finding all files named > platform.js and platforms.js (there are many, spread throughout the > cordova-lib module within both cordova-cli and cordova-plugman), eyeballing > them to see which files matched the patch changes, and copy/pasting the > changes manually. (8 files in total, as the 4 "patched" files appear under > cordova-lib in each cordova module.) > When running cordova platform add osx, I then got an error about an invaild > location for the ios-parser. I found the incorrect line in the "patched" > cordova/platform.js and changed it as follows: > parser : './metadata/ios_parser', > Following this I was able to add the osx platform and run the app. > Needless to say, this is a frustrating developer experience. I don't know why > the osx platform information code is not included in cordova by default - it > would seem to be fairly well isolated from effects on any other platform - > but if it is going to be "upgradable" in this fashion, then the git patches > should at least work. If they were designed to work (and ever did work) with > a specific version of the cordova modules, or in a different location other > than the git root, then that should be stated, instead of instructing the > hapless developer to clone cordova from master and providing no further clues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9067) Setting plugman registry changes npm registry but not plugman registry
[
https://issues.apache.org/jira/browse/CB-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578342#comment-14578342
]
ASF subversion and git services commented on CB-9067:
-
Commit 00c5262b1763e4e63cd578a1334ea7bfa4110c71 in cordova-lib's branch
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=00c5262 ]
CB-9067 fixed plugman config set registry and adduser
> Setting plugman registry changes npm registry but not plugman registry
> --
>
> Key: CB-9067
> URL: https://issues.apache.org/jira/browse/CB-9067
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, Plugman
>Reporter: Jesse MacFadyen
>Assignee: Steve Gill
>Priority: Blocker
>
> Repro steps show the full impact ...
> {code}
> jessem-osx: jessem$ npm config get registry
> https://registry.npmjs.org/
> jessem-osx: jessem$ plugman config get registry
> http://registry.cordova.io
> jessem-osx: jessem$ plugman config set registry http://plugins.cordova.io
> jessem-osx: jessem$ plugman config get registry
> http://registry.cordova.io
> jessem-osx: jessem$ npm config get registry
> http://plugins.cordova.io/
> {code}
> After attempting to set the plugman registry, npm will be unusable for
> installing packages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-9067) Setting plugman registry changes npm registry but not plugman registry
[
https://issues.apache.org/jira/browse/CB-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Gill resolved CB-9067.
Resolution: Fixed
Fixed by passing in settings object when calling npm load
> Setting plugman registry changes npm registry but not plugman registry
> --
>
> Key: CB-9067
> URL: https://issues.apache.org/jira/browse/CB-9067
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, Plugman
>Reporter: Jesse MacFadyen
>Assignee: Steve Gill
>Priority: Blocker
>
> Repro steps show the full impact ...
> {code}
> jessem-osx: jessem$ npm config get registry
> https://registry.npmjs.org/
> jessem-osx: jessem$ plugman config get registry
> http://registry.cordova.io
> jessem-osx: jessem$ plugman config set registry http://plugins.cordova.io
> jessem-osx: jessem$ plugman config get registry
> http://registry.cordova.io
> jessem-osx: jessem$ npm config get registry
> http://plugins.cordova.io/
> {code}
> After attempting to set the plugman registry, npm will be unusable for
> installing packages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578198#comment-14578198
]
ASF GitHub Bot commented on CB-9119:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31978041
--- Diff: bin/templates/cordova/lib/exec.js ---
@@ -19,16 +19,42 @@
under the License.
*/
-var child_process = require('child_process'),
-Q = require('q');
+var child_process = require('child_process');
+var Q = require('q');
+
+// constants
+var DEFAULT_MAX_BUFFER = 1024000;
// Takes a command and optional current working directory.
// Returns a promise that either resolves with the stdout, or
// rejects with an error message and the stderr.
-module.exports = function(cmd, opt_cwd) {
+//
+// WARNING:
+// opt_cwd is an artifact of an old design, and must
+// be removed in the future; the correct solution is
+// to pass the options object the same way that
+// child_process.exec expects
+//
+// NOTE:
+// exec documented here -
https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback
+module.exports = function(cmd, opt_cwd, options) {
+
var d = Q.defer();
+
+if (options === undefined) {
+options = {};
--- End diff --
Previously, a hard-coded `maxBuffer` was always passed to
`child_process.exec`. Now, it's passed as a default when it's not specified in
a given `options.maxBuffer`. Otherwise, the given value is respected.
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578197#comment-14578197
]
ASF GitHub Bot commented on CB-9119:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31977946
--- Diff: bin/templates/cordova/lib/retry.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node: true */
+
+"use strict";
+
+/*
+ * Retry a promise-returning function attemts_left times, propagating its
+ * results on success or throwing its error on a failed final attempt.
+ *
+ * Takes a number of attempts, a promise-returning function, and all its
+ * arguments (as trailing arguments).
+ */
+module.exports.retryPromise = function (attemts_left, promiseFunction) {
+
+// NOTE:
+// get all trailing arguments, by skipping the first two
(attemts_left and
+// promiseFunction) because they shouldn't get passed to
promiseFunction
+var promiseFunctionArguments = Array.prototype.slice.call(arguments,
2);
+
+return promiseFunction.apply(undefined, promiseFunctionArguments).then(
+
+// on success pass results through
+function onFulfilled(value) {
+return value;
+},
+
+// on rejection either retry, or throw the error
+function onRejected(error) {
+
+attemts_left -= 1;
+
+if (attemts_left < 1) {
+throw error;
+}
+
+console.log("call failed; retrying " + attemts_left + " more
time(s)");
--- End diff --
I'm conflicted on whether this log message should exist. It's there now
because I chose to be more verbose rather than less verbose, but I'm not sure
that it belongs here in general. If this function gets used in other places,
these messages will quickly get out of hand. What's Cordova's way to print
verbose logs only when asked?
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578190#comment-14578190
]
ASF GitHub Bot commented on CB-9119:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31977846
--- Diff: bin/templates/cordova/lib/retry.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node: true */
+
+"use strict";
+
+/*
+ * Retry a promise-returning function attemts_left times, propagating its
+ * results on success or throwing its error on a failed final attempt.
+ *
+ * Takes a number of attempts, a promise-returning function, and all its
+ * arguments (as trailing arguments).
+ */
+module.exports.retryPromise = function (attemts_left, promiseFunction) {
--- End diff --
Good idea. I created a JIRA task for this.
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9139) Add tests for retry.js in cordova-android
Dmitry Blotsky created CB-9139: -- Summary: Add tests for retry.js in cordova-android Key: CB-9139 URL: https://issues.apache.org/jira/browse/CB-9139 Project: Apache Cordova Issue Type: Test Components: Android Reporter: Dmitry Blotsky Assignee: Dmitry Blotsky Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578187#comment-14578187
]
ASF GitHub Bot commented on CB-9119:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31977783
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -298,37 +306,67 @@ module.exports.resolveTarget = function(target) {
* If no started emulators are found, error out.
* Returns a promise.
*/
-module.exports.install = function(target, buildResults) {
-return Q().then(function() {
-if (target && typeof target == 'object') {
-return target;
+module.exports.install = function(givenTarget, buildResults) {
+
+var target;
+
+// resolve the target emulator
+return Q().then(function () {
+if (givenTarget && typeof givenTarget == 'object') {
+return givenTarget;
+} else {
+return module.exports.resolveTarget(givenTarget);
}
-return module.exports.resolveTarget(target);
-}).then(function(resolvedTarget) {
-var apk_path = build.findBestApkForArchitecture(buildResults,
resolvedTarget.arch);
+
+// set the resolved target
+}).then(function (resolvedTarget) {
+target = resolvedTarget;
+
+// install the app
+}).then(function () {
+
+var apk_path= build.findBestApkForArchitecture(buildResults,
target.arch);
+var execOptions = {
+timeout:INSTALL_COMMAND_TIMEOUT, // in milliseconds
+killSignal: EXEC_KILL_SIGNAL
+};
+
console.log('Installing app on emulator...');
console.log('Using apk: ' + apk_path);
-return exec('adb -s ' + resolvedTarget.target + ' install -r -d "'
+ apk_path + '"', os.tmpdir())
-.then(function(output) {
+
+var retriedInstall = retry.retryPromise(
+NUM_INSTALL_RETRIES,
+exec, 'adb -s ' + target.target + ' install -r -d "' +
apk_path + '"', os.tmpdir(), execOptions
+);
+
+return retriedInstall.then(function (output) {
if (output.match(/Failure/)) {
return Q.reject('Failed to install apk to emulator: ' +
output);
+} else {
+console.log('INSTALL SUCCESS');
}
-return Q();
-}, function(err) {
+}, function (err) {
return Q.reject('Failed to install apk to emulator: ' + err);
-}).then(function() {
-//unlock screen
-return exec('adb -s ' + resolvedTarget.target + ' shell input
keyevent 82', os.tmpdir());
-}).then(function() {
-// launch the application
-console.log('Launching application...');
-var launchName = appinfo.getActivityName();
-var cmd = 'adb -s ' + resolvedTarget.target + ' shell am start
-W -a android.intent.action.MAIN -n ' + launchName;
-return exec(cmd, os.tmpdir());
-}).then(function(output) {
-console.log('LAUNCH SUCCESS');
-}, function(err) {
-return Q.reject('Failed to launch app on emulator: ' + err);
});
+
+// unlock screen
+}).then(function () {
+
+console.log('Unlocking screen...');
+return exec('adb -s ' + target.target + ' shell input keyevent
82', os.tmpdir());
+
+// launch the application
--- End diff --
If the console logs get removed (for example, to make the function less
verbose), the comments will remain.
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.o
[jira] [Updated] (CB-9136) Android Splash documentation needs more details
[ https://issues.apache.org/jira/browse/CB-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Jones updated CB-9136: -- Description: Android Splash screen or not working as per documentation. http://cordova.apache.org/docs/en/5.0.0/config_ref_images.md.html#Icons%20and%20Splash%20Screens Documentation implies that the plugin is option, needs more details. Suggest merging information from Read.md: https://github.com/apache/cordova-plugin-splashscreen was: Android Splash screen or not working as per documentation. I tested by inserting following into config.xml I then created matching file/folder structure in the root of my project (next to config.xml). On build no splash screen loads only a black screen then app load as normal. Environment: Cordova 5.0.0, Android http://cordova.apache.org/docs/en/5.0.0/config_ref_images.md.html#Icons%20and%20Splash%20Screens (was: Windows 8.1, Cordova 5.0.0 Command Line, Targeting Android, Tetsing on Android Nexus 5 Android 5.0) Labels: android config.xml cordova splashscreen website (was: android config.xml cordova splashscreen) Issue Type: Improvement (was: Bug) Summary: Android Splash documentation needs more details (was: Android Splash not working or documentation incorrect) > Android Splash documentation needs more details > --- > > Key: CB-9136 > URL: https://issues.apache.org/jira/browse/CB-9136 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, CLI, Website >Affects Versions: 5.0.0 > Environment: Cordova 5.0.0, Android > http://cordova.apache.org/docs/en/5.0.0/config_ref_images.md.html#Icons%20and%20Splash%20Screens >Reporter: Ben Jones > Labels: android, config.xml, cordova, splashscreen, website > > Android Splash screen or not working as per documentation. > http://cordova.apache.org/docs/en/5.0.0/config_ref_images.md.html#Icons%20and%20Splash%20Screens > Documentation implies that the plugin is option, needs more details. > Suggest merging information from Read.md: > https://github.com/apache/cordova-plugin-splashscreen -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[ https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578157#comment-14578157 ] ASF GitHub Bot commented on CB-9119: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/180#issuecomment-110188933 Mostly looks good - some stylistic comments > ADB install in automation sometimes hangs the emulator > -- > > Key: CB-9119 > URL: https://issues.apache.org/jira/browse/CB-9119 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: Master >Reporter: Dmitry Blotsky >Assignee: Dmitry Blotsky >Priority: Critical > Labels: adb, android, hang, hard_to_verify > Original Estimate: 72h > Remaining Estimate: 72h > > Sometimes "adb install ..." hangs indefinitely when running "cordova run" > under medic. Jenkins also sees this. Related links below. > Android bug: http://code.google.com/p/android/issues/detail?id=10255 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578156#comment-14578156
]
ASF GitHub Bot commented on CB-9119:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31976180
--- Diff: bin/templates/cordova/lib/retry.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node: true */
+
+"use strict";
+
+/*
+ * Retry a promise-returning function attemts_left times, propagating its
+ * results on success or throwing its error on a failed final attempt.
+ *
+ * Takes a number of attempts, a promise-returning function, and all its
+ * arguments (as trailing arguments).
+ */
+module.exports.retryPromise = function (attemts_left, promiseFunction) {
+
+// NOTE:
+// get all trailing arguments, by skipping the first two
(attemts_left and
+// promiseFunction) because they shouldn't get passed to
promiseFunction
+var promiseFunctionArguments = Array.prototype.slice.call(arguments,
2);
+
+return promiseFunction.apply(undefined, promiseFunctionArguments).then(
+
+// on success pass results through
+function onFulfilled(value) {
+return value;
+},
+
+// on rejection either retry, or throw the error
+function onRejected(error) {
+
+attemts_left -= 1;
+
+if (attemts_left < 1) {
+throw error;
+}
+
+console.log("call failed; retrying " + attemts_left + " more
time(s)");
--- End diff --
Nit. use full stop instead of semicolon. This is not code but message to
users and start the message with a capital letter.
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578155#comment-14578155
]
ASF GitHub Bot commented on CB-9119:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31976074
--- Diff: bin/templates/cordova/lib/retry.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node: true */
+
+"use strict";
+
+/*
+ * Retry a promise-returning function attemts_left times, propagating its
+ * results on success or throwing its error on a failed final attempt.
+ *
+ * Takes a number of attempts, a promise-returning function, and all its
+ * arguments (as trailing arguments).
+ */
+module.exports.retryPromise = function (attemts_left, promiseFunction) {
--- End diff --
Consider writing unit tests for this one as it is fairly easy and isolated
to write for this function.
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578154#comment-14578154
]
ASF GitHub Bot commented on CB-9119:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31976044
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -298,37 +306,67 @@ module.exports.resolveTarget = function(target) {
* If no started emulators are found, error out.
* Returns a promise.
*/
-module.exports.install = function(target, buildResults) {
-return Q().then(function() {
-if (target && typeof target == 'object') {
-return target;
+module.exports.install = function(givenTarget, buildResults) {
+
+var target;
+
+// resolve the target emulator
+return Q().then(function () {
+if (givenTarget && typeof givenTarget == 'object') {
+return givenTarget;
+} else {
+return module.exports.resolveTarget(givenTarget);
}
-return module.exports.resolveTarget(target);
-}).then(function(resolvedTarget) {
-var apk_path = build.findBestApkForArchitecture(buildResults,
resolvedTarget.arch);
+
+// set the resolved target
+}).then(function (resolvedTarget) {
+target = resolvedTarget;
+
+// install the app
+}).then(function () {
+
+var apk_path= build.findBestApkForArchitecture(buildResults,
target.arch);
+var execOptions = {
+timeout:INSTALL_COMMAND_TIMEOUT, // in milliseconds
+killSignal: EXEC_KILL_SIGNAL
+};
+
console.log('Installing app on emulator...');
console.log('Using apk: ' + apk_path);
-return exec('adb -s ' + resolvedTarget.target + ' install -r -d "'
+ apk_path + '"', os.tmpdir())
-.then(function(output) {
+
+var retriedInstall = retry.retryPromise(
+NUM_INSTALL_RETRIES,
+exec, 'adb -s ' + target.target + ' install -r -d "' +
apk_path + '"', os.tmpdir(), execOptions
+);
+
+return retriedInstall.then(function (output) {
if (output.match(/Failure/)) {
return Q.reject('Failed to install apk to emulator: ' +
output);
+} else {
+console.log('INSTALL SUCCESS');
}
-return Q();
-}, function(err) {
+}, function (err) {
return Q.reject('Failed to install apk to emulator: ' + err);
-}).then(function() {
-//unlock screen
-return exec('adb -s ' + resolvedTarget.target + ' shell input
keyevent 82', os.tmpdir());
-}).then(function() {
-// launch the application
-console.log('Launching application...');
-var launchName = appinfo.getActivityName();
-var cmd = 'adb -s ' + resolvedTarget.target + ' shell am start
-W -a android.intent.action.MAIN -n ' + launchName;
-return exec(cmd, os.tmpdir());
-}).then(function(output) {
-console.log('LAUNCH SUCCESS');
-}, function(err) {
-return Q.reject('Failed to launch app on emulator: ' + err);
});
+
+// unlock screen
+}).then(function () {
+
+console.log('Unlocking screen...');
+return exec('adb -s ' + target.target + ' shell input keyevent
82', os.tmpdir());
+
+// launch the application
--- End diff --
Nit: I liked the placement of comments earlier - though - given we are
emitting console log messages with the same text - these comments are somewhat
redundant.
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For ad
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578152#comment-14578152
]
ASF GitHub Bot commented on CB-9119:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r31975924
--- Diff: bin/templates/cordova/lib/exec.js ---
@@ -19,16 +19,42 @@
under the License.
*/
-var child_process = require('child_process'),
-Q = require('q');
+var child_process = require('child_process');
+var Q = require('q');
+
+// constants
+var DEFAULT_MAX_BUFFER = 1024000;
// Takes a command and optional current working directory.
// Returns a promise that either resolves with the stdout, or
// rejects with an error message and the stderr.
-module.exports = function(cmd, opt_cwd) {
+//
+// WARNING:
+// opt_cwd is an artifact of an old design, and must
+// be removed in the future; the correct solution is
+// to pass the options object the same way that
+// child_process.exec expects
+//
+// NOTE:
+// exec documented here -
https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback
+module.exports = function(cmd, opt_cwd, options) {
+
var d = Q.defer();
+
+if (options === undefined) {
+options = {};
--- End diff --
Is this changing the behavior of providing max buffer when no options are
specified?
> ADB install in automation sometimes hangs the emulator
> --
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Affects Versions: Master
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9000) Medic-check doesn't fail when no record is found
[ https://issues.apache.org/jira/browse/CB-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578144#comment-14578144 ] ASF GitHub Bot commented on CB-9000: Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/55 > Medic-check doesn't fail when no record is found > > > Key: CB-9000 > URL: https://issues.apache.org/jira/browse/CB-9000 > Project: Apache Cordova > Issue Type: Bug > Components: Medic >Affects Versions: Master >Reporter: Dmitry Blotsky >Priority: Minor > Original Estimate: 4h > Remaining Estimate: 4h > > The medic-check.js script returns 0 even when it can't find the build result > it is looking for. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9000) Medic-check doesn't fail when no record is found
[ https://issues.apache.org/jira/browse/CB-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578143#comment-14578143 ] ASF subversion and git services commented on CB-9000: - Commit 917c999ec1957d7706303f328fb419cc85c42540 in cordova-medic's branch refs/heads/master from [~alsorokin] [ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=917c999 ] CB-9000 Failing properly if no test results were found. This closes #55. > Medic-check doesn't fail when no record is found > > > Key: CB-9000 > URL: https://issues.apache.org/jira/browse/CB-9000 > Project: Apache Cordova > Issue Type: Bug > Components: Medic >Affects Versions: Master >Reporter: Dmitry Blotsky >Priority: Minor > Original Estimate: 4h > Remaining Estimate: 4h > > The medic-check.js script returns 0 even when it can't find the build result > it is looking for. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9000) Medic-check doesn't fail when no record is found
[ https://issues.apache.org/jira/browse/CB-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578145#comment-14578145 ] ASF GitHub Bot commented on CB-9000: Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/55#issuecomment-110186774 Sorry for delay. Verified, LGTM. :+1: Rebased and merged. > Medic-check doesn't fail when no record is found > > > Key: CB-9000 > URL: https://issues.apache.org/jira/browse/CB-9000 > Project: Apache Cordova > Issue Type: Bug > Components: Medic >Affects Versions: Master >Reporter: Dmitry Blotsky >Priority: Minor > Original Estimate: 4h > Remaining Estimate: 4h > > The medic-check.js script returns 0 even when it can't find the build result > it is looking for. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
[ https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578117#comment-14578117 ] ASF GitHub Bot commented on CB-9119: GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-android/pull/180 CB-9119 Fixing intermittent 'adb install' hanging issue Adding lib/retry.js for retrying promise-returning functions. Retrying 'adb install' in emulator.js to work around it hanging sometimes. Related Android bug: https://code.google.com/p/android/issues/detail?id=10255 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-android CB-9119 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/180.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #180 commit 912f011bc7edc42b388a59c6fbce3229cd1209bb Author: Dmitry Blotsky Date: 2015-06-09T00:17:12Z CB-9119 Adding lib/retry.js for retrying promise-returning functions. Retrying 'adb install' in emulator.js because it sometimes hangs. > ADB install in automation sometimes hangs the emulator > -- > > Key: CB-9119 > URL: https://issues.apache.org/jira/browse/CB-9119 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: Master >Reporter: Dmitry Blotsky >Assignee: Dmitry Blotsky >Priority: Critical > Labels: adb, android, hang, hard_to_verify > Original Estimate: 72h > Remaining Estimate: 72h > > Sometimes "adb install ..." hangs indefinitely when running "cordova run" > under medic. Jenkins also sees this. Related links below. > Android bug: http://code.google.com/p/android/issues/detail?id=10255 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9138) Installing multiple plugins from multiple registries fails
[ https://issues.apache.org/jira/browse/CB-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578093#comment-14578093 ] Steve Gill commented on CB-9138: Related to CB-9067 > Installing multiple plugins from multiple registries fails > -- > > Key: CB-9138 > URL: https://issues.apache.org/jira/browse/CB-9138 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Plugman >Affects Versions: 5.0.0 >Reporter: Steve Gill >Assignee: Steve Gill > Fix For: 5.2.0 > > > If you use tag in config.xml and reference plugins from both CPR and > npm. When you do a platform add/cordova prepare to install those plugins, the > registry value will be incorrect. > Seems to be a async/promise issue and how we call npm load. The value gets > set to either registry.cordova.io or registry.npmjs.org. It won't alternate > based on where the plugin lives. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9138) Installing multiple plugins from multiple registries fails
Steve Gill created CB-9138: -- Summary: Installing multiple plugins from multiple registries fails Key: CB-9138 URL: https://issues.apache.org/jira/browse/CB-9138 Project: Apache Cordova Issue Type: Bug Components: CordovaLib, Plugman Affects Versions: 5.0.0 Reporter: Steve Gill Assignee: Steve Gill Fix For: 5.2.0 If you use tag in config.xml and reference plugins from both CPR and npm. When you do a platform add/cordova prepare to install those plugins, the registry value will be incorrect. Seems to be a async/promise issue and how we call npm load. The value gets set to either registry.cordova.io or registry.npmjs.org. It won't alternate based on where the plugin lives. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Issue Comment Deleted] (CB-9102) Crash when using a iOS Cordova plugin within a WebSocket event
[
https://issues.apache.org/jira/browse/CB-9102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Iñaki Baz Castillo updated CB-9102:
---
Comment: was deleted
(was: Anybody there?)
> Crash when using a iOS Cordova plugin within a WebSocket event
> --
>
> Key: CB-9102
> URL: https://issues.apache.org/jira/browse/CB-9102
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.8.0
>Reporter: Iñaki Baz Castillo
> Labels: ios, plugin, websocket
>
> I've coded a cordova plugin for iOS. It is exported as a JavaScript object
> with multiple functions in `window.cordova.plugins.iosrtc`.
> If I use any of those exported functions within the callback of a WebSocket
> event (onopen, onmessage, etc), the plugin/app usually crashes:
> {code}
> Process 2326 stopped
> * thread #1: tid = 0x94ce5, 0x2e267474
> WebCore`WebCore::NavigationScheduler::schedule(std::__1::unique_ptr std::__1::default_delete >) + 276, queue =
> 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
> frame #0: 0x2e267474
> WebCore`WebCore::NavigationScheduler::schedule(std::__1::unique_ptr std::__1::default_delete >) + 276
> WebCore`WebCore::NavigationScheduler::schedule:
> -> 0x2e267474 <+276>: ldrr2, [r0]
> 0x2e267476 <+278>: ldrr3, [r2, #0x10]
> 0x2e267478 <+280>: movr2, r10
> 0x2e26747a <+282>: blxr3
> (lldb)
> error: No auto repeat.
> (lldb) list
>30 {
>31 @autoreleasepool {
>32 int retVal = UIApplicationMain(argc, argv, nil,
> @"AppDelegate");
>33 return retVal;
>34 }
>35 }
> (lldb) bt
> * thread #1: tid = 0x94ce5, 0x2e267474
> WebCore`WebCore::NavigationScheduler::schedule(std::__1::unique_ptr std::__1::default_delete >) + 276, queue =
> 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
> * frame #0: 0x2e267474
> WebCore`WebCore::NavigationScheduler::schedule(std::__1::unique_ptr std::__1::default_delete >) + 276
> frame #1: 0x2e26769e
> WebCore`WebCore::NavigationScheduler::scheduleLocationChange(WebCore::SecurityOrigin*,
> WebCore::URL const&, WTF::String const&, WebCore::LockHistory,
> WebCore::LockBackForwardList) + 498
> frame #2: 0x2de00c20 WebCore`WebCore::DOMWindow::setLocation(WTF::String
> const&, WebCore::DOMWindow&, WebCore::DOMWindow&,
> WebCore::SetLocationLocking) + 172
> frame #3: 0x2e22b0e2 WebCore`WebCore::Location::setHref(WTF::String
> const&, WebCore::DOMWindow&, WebCore::DOMWindow&) + 86
> frame #4: 0x2e03c5d6
> WebCore`WebCore::JSDOMWindow::setLocation(JSC::ExecState*, JSC::JSValue) + 142
> frame #5: 0x2daad47e WebCore`WebCore::JSDOMWindow::put(JSC::JSCell,
> JSC::ExecState, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) + 446
> frame #6: 0x231a3436 JavaScriptCore`JSC::JSProxy::put(JSC::JSCell,
> JSC::ExecState, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) + 54
> frame #7: 0x23199fc0 JavaScriptCore`llint_slow_path_put_by_id + 404
> frame #8: 0x233ca3ce JavaScriptCore`llint_entry + 9694
> {code}
> Sometimes it produces a different error:
> {code}
> 2015-06-01 15:29:17.810 cordovaIosrtcDemo[2298:602476] DiskCookieStorage
> changing policy from 2 to 0, cookie file:
> file:///private/var/mobile/Containers/Data/Application/3588C109-5F97-4E5F-83EA-36165871ACC3/Library/Cookies/Cookies.binarycookies
> 2015-06-01 15:29:18.083 cordovaIosrtcDemo[2298:602476] Apache Cordova native
> platform version 3.8.0 is starting.
> 2015-06-01 15:29:18.083 cordovaIosrtcDemo[2298:602476] Multi-tasking ->
> Device: YES, App: YES
> 2015-06-01 15:29:18.088 cordovaIosrtcDemo[2298:602476] Unlimited access to
> network resources
> 2015-06-01 15:29:18.277 cordovaIosrtcDemo[2298:602476] iosrtcPlugin#init()
> 2015-06-01 15:29:18.325 cordovaIosrtcDemo[2298:602476]
> PluginGetUserMedia#init()
> 2015-06-01 15:29:18.326 cordovaIosrtcDemo[2298:602476]
> [CDVTimer][iosrtcplugin] 55.085003ms
> 2015-06-01 15:29:18.326 cordovaIosrtcDemo[2298:602476]
> [CDVTimer][TotalPluginStartup] 55.342019ms
> 2015-06-01 15:29:18.967 cordovaIosrtcDemo[2298:602476] Resetting plugins due
> to page load.
> 2015-06-01 15:29:19.432 cordovaIosrtcDemo[2298:602476] Finished load of:
> file:///private/var/mobile/Containers/Bundle/Application/90A5F156-4893-490C-B608-A7D3715F379D/cordovaIosrtcDemo.app/www/index.html
> Process 2298 stopped
> * thread #8: tid = 0x931b5, 0x21e410e8 CoreFoundation`CFRelease + 1268, name
> = 'WebThread', stop reason = EXC_BREAKPOINT (code=EXC_ARM_BREAKPOINT,
> subcode=0xdefe)
> frame #0: 0x21e410e8 CoreFoundation`CFRelease + 1268
> CoreFoundation`CFRelease:
> -> 0x21e410e8 <+1268>: trap
> 0x21e410ea <+1270>: trap
> CoreFoundation`_CFAllocatorDeallocate
[jira] [Commented] (CB-9000) Medic-check doesn't fail when no record is found
[ https://issues.apache.org/jira/browse/CB-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577845#comment-14577845 ] ASF GitHub Bot commented on CB-9000: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/55#issuecomment-110138958 @dblotsky Can you please review and help merge. > Medic-check doesn't fail when no record is found > > > Key: CB-9000 > URL: https://issues.apache.org/jira/browse/CB-9000 > Project: Apache Cordova > Issue Type: Bug > Components: Medic >Affects Versions: Master >Reporter: Dmitry Blotsky >Priority: Minor > Original Estimate: 4h > Remaining Estimate: 4h > > The medic-check.js script returns 0 even when it can't find the build result > it is looking for. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577719#comment-14577719 ] ASF subversion and git services commented on CB-6503: - Commit 7591ab84b5378df8d2aa790f8bf8adf33677ab7a in cordova-plugin-file-transfer's branch refs/heads/CB-9128cordova-plugin-file-transfer from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=7591ab8 ] CB-6503: Null pointer check for headers in upload (This closes #27) > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577720#comment-14577720 ] ASF subversion and git services commented on CB-6503: - Commit de55dc7f8499d7116e4157d9fc4073c1de0a9d36 in cordova-plugin-file-transfer's branch refs/heads/CB-9128cordova-plugin-file-transfer from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=de55dc7 ] Merge branch 'CB-6503' > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577718#comment-14577718 ] ASF subversion and git services commented on CB-6503: - Commit 04f088b6c906e0b74bf3610005787b90aa548b9e in cordova-plugin-file-transfer's branch refs/heads/CB-9128cordova-plugin-file-transfer from [~mwc_tonesoft] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=04f088b ] CB-6503: Allow payload content-types other than multipart/form-data to be used for upload > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577716#comment-14577716 ] ASF subversion and git services commented on CB-8993: - Commit 559a072ee5dc15f7006263f5f656b9f8040ad599 in cordova-cli's branch refs/heads/CB-9128cordova-cli from [~mpridham] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=559a072 ] CB-8993 Plugin restore ignores search path. This closes #213 > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Assignee: Gorkem ERCAN >Priority: Minor > Fix For: 5.1.2 > > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577703#comment-14577703 ] ASF GitHub Bot commented on CB-6503: Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-110114815 @machenmusik, I definitely see the CLA now -- thanks! And it's merged -- if there are any issues with it, please keep the bug at [CB-6503](https://issues.apache.org/jira/browse/CB-6503) updated. > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9133) CDVFILE NOT WORKING???
[ https://issues.apache.org/jira/browse/CB-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577702#comment-14577702 ] Michael Romanovsky commented on CB-9133: I made a pull request for this here: https://github.com/apache/cordova-plugin-whitelist/pull/6 > CDVFILE NOT WORKING??? > -- > > Key: CB-9133 > URL: https://issues.apache.org/jira/browse/CB-9133 > Project: Apache Cordova > Issue Type: Bug >Reporter: Michael Romanovsky >Priority: Critical > > I used the instructions here: > https://github.com/apache/cordova-plugin-whitelist > I have this in my config.xml file: > > > > I have this in my .HTML file: > > I get these errors: > Refused to load the script 'http://d3aq14vri881or.cloudfront.net/kiip.js' > because it violates the following Content Security Policy directive: > "script-src 'self' 'unsafe-inline' 'unsafe-eval'". > Refused to load the script 'cdvfile://localhost/persistent/free.min.js' > because it violates the following Content Security Policy directive: > "script-src 'self' 'unsafe-inline' 'unsafe-eval'". > HELP?! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN reassigned CB-8993: Assignee: Gorkem ERCAN > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Assignee: Gorkem ERCAN >Priority: Minor > Fix For: 5.1.2 > > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN resolved CB-8993. -- Resolution: Fixed > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Assignee: Gorkem ERCAN >Priority: Minor > Fix For: 5.1.2 > > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN updated CB-8993: - Fix Version/s: 5.1.2 > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Priority: Minor > Fix For: 5.1.2 > > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577693#comment-14577693 ] ASF GitHub Bot commented on CB-8993: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/213 > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Priority: Minor > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577695#comment-14577695 ] ASF GitHub Bot commented on CB-8993: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/224 > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Priority: Minor > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577692#comment-14577692 ] ASF subversion and git services commented on CB-8993: - Commit 559a072ee5dc15f7006263f5f656b9f8040ad599 in cordova-cli's branch refs/heads/master from [~mpridham] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=559a072 ] CB-8993 Plugin restore ignores search path. This closes #213 > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Priority: Minor > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577694#comment-14577694 ] ASF subversion and git services commented on CB-8993: - Commit 2e3be3c6983b15018f08ac57c14e598764d34216 in cordova-lib's branch refs/heads/master from [~mpridham] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=2e3be3c ] CB-8993 Plugin restore ignores search path. This closes #224 > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Priority: Minor > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577683#comment-14577683 ] ASF subversion and git services commented on CB-6503: - Commit 04f088b6c906e0b74bf3610005787b90aa548b9e in cordova-plugin-file-transfer's branch refs/heads/master from [~mwc_tonesoft] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=04f088b ] CB-6503: Allow payload content-types other than multipart/form-data to be used for upload > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577684#comment-14577684 ] ASF subversion and git services commented on CB-6503: - Commit 7591ab84b5378df8d2aa790f8bf8adf33677ab7a in cordova-plugin-file-transfer's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=7591ab8 ] CB-6503: Null pointer check for headers in upload (This closes #27) > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577685#comment-14577685 ] ASF subversion and git services commented on CB-6503: - Commit de55dc7f8499d7116e4157d9fc4073c1de0a9d36 in cordova-plugin-file-transfer's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=de55dc7 ] Merge branch 'CB-6503' > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6503) allow file uploads to be sent directly, rather than only as multipart form data
[ https://issues.apache.org/jira/browse/CB-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577686#comment-14577686 ] ASF GitHub Bot commented on CB-6503: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/27 > allow file uploads to be sent directly, rather than only as multipart form > data > --- > > Key: CB-6503 > URL: https://issues.apache.org/jira/browse/CB-6503 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin File Transfer >Affects Versions: 3.3.0 >Reporter: M C >Priority: Minor > > > > on iOS, Android and Amazon, if upload has a header named Content-Type, > > > multipart form data will NOT be used > > I understand the problem, but wouldn't it be better if we just filtered out > > "Content-Type" for user-defined headers? (disallow setting it) > In this use case, direct upload without the multipart encoding is desirable, > so disallowing the header and forcing multipart upload would have the > opposite effect of what was needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9136) Android Splash not working or documentation incorrect
[ https://issues.apache.org/jira/browse/CB-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Jones updated CB-9136: -- Summary: Android Splash not working or documentation incorrect (was: Android Splash working or Documentation incorrect) > Android Splash not working or documentation incorrect > - > > Key: CB-9136 > URL: https://issues.apache.org/jira/browse/CB-9136 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI, Website >Affects Versions: 5.0.0 > Environment: Windows 8.1, Cordova 5.0.0 Command Line, Targeting > Android, Tetsing on Android Nexus 5 Android 5.0 >Reporter: Ben Jones > Labels: android, config.xml, cordova, splashscreen > > Android Splash screen or not working as per documentation. I tested by > inserting following into config.xml > > density="land-hdpi"/> > density="land-ldpi"/> > density="land-mdpi"/> > density="land-xhdpi"/> > density="port-hdpi"/> > density="port-ldpi"/> > density="port-mdpi"/> > density="port-xhdpi"/> > > > I then created matching file/folder structure in the root of my project (next > to config.xml). > On build no splash screen loads only a black screen then app load as normal. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8516) Support DefaultLanguage selection for WP8
[ https://issues.apache.org/jira/browse/CB-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murat Sutunc closed CB-8516. Resolution: Fixed > Support DefaultLanguage selection for WP8 > - > > Key: CB-8516 > URL: https://issues.apache.org/jira/browse/CB-8516 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 >Reporter: Murat Sutunc >Assignee: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for WP 8.0 using > the W3C widget spec "defaultlocale" attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9121) Add support for build configuration to be specified using the CLI
[ https://issues.apache.org/jira/browse/CB-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577537#comment-14577537 ] ASF subversion and git services commented on CB-9121: - Commit 9f34c4eb8b41c27881fc4a54f05845c77b25f112 in cordova-cli's branch refs/heads/CB-9128cordova-cli from [~nikhilkh] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=9f34c4e ] CB-9121 Add support for build configuration to be specified using the CLI > Add support for build configuration to be specified using the CLI > - > > Key: CB-9121 > URL: https://issues.apache.org/jira/browse/CB-9121 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Affects Versions: 5.2 >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577491#comment-14577491 ] ASF GitHub Bot commented on CB-8993: Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/224#issuecomment-110080565 Thanks. I filled out a Apache CLA back in January and got confirmation from Apache Secretary Craig Russell. I have done a pull request in the past for CB-8328. > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Priority: Minor > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8993) Plugin restore ignores search path
[ https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577438#comment-14577438 ] ASF GitHub Bot commented on CB-8993: Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/224#issuecomment-110066248 @marcuspridham PR looks. Do you have Apache CLA signed? I can not seem to find it if you have. Before I can merge this one, you need to sign Apache’s Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas > Plugin restore ignores search path > -- > > Key: CB-8993 > URL: https://issues.apache.org/jira/browse/CB-8993 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Marcus Pridham >Priority: Minor > > If I run the command: > cordova prepare --searchpath ~/cordova-plugins > I would expect the CLI to try restore plugins in the config.xml from the > provided searchpath. Currently this parameter is ignored. > I can get this to work if I modify the opts variable in cli.js and add: > searchpath : args.searchpath, > https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9137) AppVeyor builds for cordova-lib are failing
[
https://issues.apache.org/jira/browse/CB-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577291#comment-14577291
]
ASF GitHub Bot commented on CB-9137:
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-js/pull/115
> AppVeyor builds for cordova-lib are failing
> ---
>
> Key: CB-9137
> URL: https://issues.apache.org/jira/browse/CB-9137
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, CordovaLib
>Affects Versions: 5.1.2
> Environment: Windows 8.1 machine, cordova-lib, cordova-js from trunk.
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
> Fix For: 5.1.2
>
>
> Our AppVeyor builds are failing for a while
> (https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.735) with
> undescriptive error:
> {noformat}
> npm ERR! weird error 1
> npm ERR! Test failed. See above for more details.
> Command exited with code 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9124) The error messages that occur due to network timeouts are unclear
[ https://issues.apache.org/jira/browse/CB-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576994#comment-14576994 ] ASF GitHub Bot commented on CB-9124: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/240 CB-9124 Makes network-related error messages more descriptive. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9124 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/240.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #240 commit 0021c4e132404c9dcd5ff9b12ff4deb2360fa4d1 Author: Vladimir Kotikov Date: 2015-06-05T14:14:28Z CB-9124 Makes network-related errors' messages more descriptive. > The error messages that occur due to network timeouts are unclear > - > > Key: CB-9124 > URL: https://issues.apache.org/jira/browse/CB-9124 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 5.0.1 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov >Priority: Minor > > Networks timeouts can happen during fetching plugins, platforms, or even the > starter template. When these are not cached, the error messages are not very > descriptive. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9137) AppVeyor builds for cordova-lib are failing
[
https://issues.apache.org/jira/browse/CB-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576974#comment-14576974
]
ASF GitHub Bot commented on CB-9137:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-js/pull/115
CB-9137 Fixes module inclusion failure on Windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-9137
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
commit 143431ba7a0550c81e6c5cdb0684b9d613920135
Author: Vladimir Kotikov
Date: 2015-06-08T09:55:20Z
CB-9137 Fixes module inclusion failure on Windows
> AppVeyor builds for cordova-lib are failing
> ---
>
> Key: CB-9137
> URL: https://issues.apache.org/jira/browse/CB-9137
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, CordovaLib
>Affects Versions: 5.1.2
> Environment: Windows 8.1 machine, cordova-lib, cordova-js from trunk.
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
> Fix For: 5.1.2
>
>
> Our AppVeyor builds are failing for a while
> (https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.735) with
> undescriptive error:
> {noformat}
> npm ERR! weird error 1
> npm ERR! Test failed. See above for more details.
> Command exited with code 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9137) AppVeyor builds for cordova-lib are failing
Vladimir Kotikov created CB-9137:
Summary: AppVeyor builds for cordova-lib are failing
Key: CB-9137
URL: https://issues.apache.org/jira/browse/CB-9137
Project: Apache Cordova
Issue Type: Bug
Components: CordovaJS, CordovaLib
Affects Versions: 5.1.2
Environment: Windows 8.1 machine, cordova-lib, cordova-js from trunk.
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Fix For: 5.1.2
Our AppVeyor builds are failing for a while
(https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.735) with
undescriptive error:
{noformat}
npm ERR! weird error 1
npm ERR! Test failed. See above for more details.
Command exited with code 1
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9136) Android Splash working or Documentation incorrect
Ben Jones created CB-9136: - Summary: Android Splash working or Documentation incorrect Key: CB-9136 URL: https://issues.apache.org/jira/browse/CB-9136 Project: Apache Cordova Issue Type: Bug Components: Android, CLI, Website Affects Versions: 5.0.0 Environment: Windows 8.1, Cordova 5.0.0 Command Line, Targeting Android, Tetsing on Android Nexus 5 Android 5.0 Reporter: Ben Jones Android Splash screen or not working as per documentation. I tested by inserting following into config.xml I then created matching file/folder structure in the root of my project (next to config.xml). On build no splash screen loads only a black screen then app load as normal. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
