[jira] [Commented] (CB-9969) Windows filetransfer upload error deletes original file.
[
https://issues.apache.org/jira/browse/CB-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029579#comment-15029579
]
ASF subversion and git services commented on CB-9969:
-
Commit 6e960b2ffd16ba86ffbe8a94fa3e58526be473fc in
cordova-plugin-file-transfer's branch refs/heads/master from [~daserge]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=6e960b2
]
CB-9969 Filetransfer upload error deletes original file
Reverts iOS changes
> Windows filetransfer upload error deletes original file.
> --
>
> Key: CB-9969
> URL: https://issues.apache.org/jira/browse/CB-9969
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: windows
>Reporter: Wema Wuyts
>Assignee: Sergey Shakhnazarov
> Labels: reproduced, triaged
>
> The upload function on windows has an onerror handler:
> getTransferError.then(function(transferError) {
> storageFile.deleteAsync().then(function() {
> errorCallback(transferError);
> });
> });
> think this should be :
> getTransferError.then(function(transferError) {
> errorCallback(transferError);
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5308) Contact.save() calls failure callback even though contact data is successfully saved on device
[
https://issues.apache.org/jira/browse/CB-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029574#comment-15029574
]
ASF GitHub Bot commented on CB-5308:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023669
--- Diff: tests/tests.js ---
@@ -37,23 +37,34 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 3;
-var removeContact = function() {
-if (gContactObj) {
-gContactObj.remove(function() {}, function() {
-console.log("[CONTACTS ERROR]: removeContact cleanup
method failed to clean up test artifacts.");
-});
-gContactObj = null;
-}
-};
+var removeContact = function(done) {
+if (!done) {
+done = function noop () { };
--- End diff --
I just realized that `removeContact` is now used only in async way (with
`done`) so this is not needed at all. Removing.
> Contact.save() calls failure callback even though contact data is
> successfully saved on device
> --
>
> Key: CB-5308
> URL: https://issues.apache.org/jira/browse/CB-5308
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: Android 4.1.2, 4.4.3 physical device. 4.4.3 device is
> Nexus 7.
> Cordova 3.1.0, 3.6.3
>Reporter: Shingo Toda
>Assignee: Vladimir Kotikov
> Labels: Android, reproduced, triaged
>
> When I run contact mobile-spec, following specs sometimes fail.
> - contacts.spec.6
> - contacts.spec.20
> - contacts.spec.21
> - contacts.spec.24
> In Java side, it looks that {{ContactAccessorSdk5.save()}} returns contact id
> but {{ContactAccessorSdk5.getContactById()}} returns {{null}} instead of
> contact data associated with the id. Actually some of contact data such as
> "Test Delete" are found on my device so the save operation is actually done.
> This save() returns "newId" in the following code.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> //Add contact
> try {
> ContentProviderResult[] cpResults =
> mApp.getActivity().getContentResolver().applyBatch(ContactsContract.AUTHORITY,
> ops);
> if (cpResults.length >= 0) {
> newId = cpResults[0].uri.getLastPathSegment();
> }
> } catch (RemoteException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> } catch (OperationApplicationException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> }
> return newId;
> {code}
> When I debug it, {{cpResults\[0\].uri}} is
> {{content://com.android.contacts/raw_contacts/}} so, this is just my
> assumption, I think {{save()}} returns raw contact id.
> But at {{getContactById()}}, query filter uses {{CONTACT_ID}} column as a
> projection.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.CONTACT_ID + " = ? ",
> new String[] { id },
> ContactsContract.Data.CONTACT_ID + " ASC");
> {code}
> So if contact id and raw contact id is different then fetching contact data
> might fail. Actually in my case, if I fail the specs, they are always
> different.
> I try modifying {{getContactById()}} to process following code if contact
> JSONObject doesn't have id property, then I didn't get failure for those
> specs even if I run them some times.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.RAW_CONTACT_ID + " = ? ",
> new String[] { rawid },
> ContactsContract.Data.RAW_CONTACT_ID + " ASC");
> {code}
> I am just learning how contact data is managed on Android so I might be wrong
> for some use cases, but it works fine for mobile-spec.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5308) Contact.save() calls failure callback even though contact data is successfully saved on device
[
https://issues.apache.org/jira/browse/CB-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029571#comment-15029571
]
ASF GitHub Bot commented on CB-5308:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023545
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1027,7 +1027,7 @@ else if (accounts.length > 1) {
private String modifyContact(String id, JSONObject contact, String
accountType, String accountName) {
// Get the RAW_CONTACT_ID which is needed to insert new values in
an already existing contact.
// But not needed to update existing values.
-int rawId = (Integer.valueOf(getJsonString(contact,
"rawId"))).intValue();
+String rawId = getJsonString(contact, "rawId");
--- End diff --
From my experiments this works both with `int` and `String`. My guess is
that ContentProvider casts types implicitly, when needed.
Also, according to the [same
documentation](http://developer.android.com/intl/ru/reference/android/provider/ContactsContract.Data.html)
`id` is also of type `long`, but is has been used here as `String` always. So
IMO it doesn't matter.
> Contact.save() calls failure callback even though contact data is
> successfully saved on device
> --
>
> Key: CB-5308
> URL: https://issues.apache.org/jira/browse/CB-5308
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: Android 4.1.2, 4.4.3 physical device. 4.4.3 device is
> Nexus 7.
> Cordova 3.1.0, 3.6.3
>Reporter: Shingo Toda
>Assignee: Vladimir Kotikov
> Labels: Android, reproduced, triaged
>
> When I run contact mobile-spec, following specs sometimes fail.
> - contacts.spec.6
> - contacts.spec.20
> - contacts.spec.21
> - contacts.spec.24
> In Java side, it looks that {{ContactAccessorSdk5.save()}} returns contact id
> but {{ContactAccessorSdk5.getContactById()}} returns {{null}} instead of
> contact data associated with the id. Actually some of contact data such as
> "Test Delete" are found on my device so the save operation is actually done.
> This save() returns "newId" in the following code.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> //Add contact
> try {
> ContentProviderResult[] cpResults =
> mApp.getActivity().getContentResolver().applyBatch(ContactsContract.AUTHORITY,
> ops);
> if (cpResults.length >= 0) {
> newId = cpResults[0].uri.getLastPathSegment();
> }
> } catch (RemoteException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> } catch (OperationApplicationException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> }
> return newId;
> {code}
> When I debug it, {{cpResults\[0\].uri}} is
> {{content://com.android.contacts/raw_contacts/}} so, this is just my
> assumption, I think {{save()}} returns raw contact id.
> But at {{getContactById()}}, query filter uses {{CONTACT_ID}} column as a
> projection.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.CONTACT_ID + " = ? ",
> new String[] { id },
> ContactsContract.Data.CONTACT_ID + " ASC");
> {code}
> So if contact id and raw contact id is different then fetching contact data
> might fail. Actually in my case, if I fail the specs, they are always
> different.
> I try modifying {{getContactById()}} to process following code if contact
> JSONObject doesn't have id property, then I didn't get failure for those
> specs even if I run them some times.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.RAW_CONTACT_ID + " = ? ",
> new String[] { rawid },
> ContactsContract.Data.RAW_CONTACT_ID + " ASC");
> {code}
> I am just learning how contact data is managed on Android so I might be wrong
> for some use cases, but it works fine for mobile-spec.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029299#comment-15029299
]
Shazron Abdullah commented on CB-7287:
--
One solution:
Each bridge should clean itself up, or we add a new function to cordova.js to
set and cleanup bridges (ie each bridge has a deInit() function, and
cordova.changeBridge(bridge) would call it, or something).
But for now, to be backwards compatible, we could do:
{code}
if (cordova.exec !== iOSExec) { // where iOSExec is our exec in our scope
console.log("The bridge has changed, do something, pass remnant commands to
new bridge, cleanup, stop any timers etc");
// TODO: For each command in the commandQueue, we have to "unwrap" the
callbackId to get the
// success and failure callbacks, and send to the new cordova.exec.
}
{code}
NOTE: this problem only exists because of that timer to catch commands that may
have been missed because of an iframe change
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029294#comment-15029294
]
Anis Kadri commented on CB-7287:
Understood. I agree that this should be handled in Javascript if possible.
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029291#comment-15029291
]
Shazron Abdullah commented on CB-7287:
--
Another note: it's not just "ignoring" it, if it doesn't "handle" it (thus
handling the bridge like UIWebView), the call will still go on, since the
commandQueue is not empty. The wkwebview-engine bridge should not be handling
the remnants of the other bridge.
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029288#comment-15029288
]
Shazron Abdullah commented on CB-7287:
--
Not hard, but that's not the point like I mentioned, why would wkwebview-engine
need to know the goings-on of another engine? It'll be a quick patch for sure,
but it should be stand-alone
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029286#comment-15029286
]
Anis Kadri commented on CB-7287:
Not sure if this could be handled with our in-house javascript packager either
(possibly using in plugin.xml ?). How hard would it be for
wkwebview-engine to handle/ignore that first call ?
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029284#comment-15029284
]
Shazron Abdullah commented on CB-7287:
--
Idea: after N tries, it tries to push the command back to cordova.exec instead
of calling pokeNative. In this case the command will go to the right
cordova.exec at runtime.
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029277#comment-15029277
]
Shazron Abdullah edited comment on CB-7287 at 11/26/15 10:08 PM:
-
Found the culprit for the infinite "gap://ready" calls when the WKWebView
engine plugin is installed for mobile-spec.
During runtime, checking cordova.exec shows the right clobber, but the old
iOSExec call is called at least once by cordova.js, resulting in this infinite
call.
pokeNative() is called infinitely here:
https://github.com/apache/cordova-ios/blob/e3ae7e3ca0395988a087884f9ba18a683160dbde/cordova-js-src/exec.js#L162
Not sure if this can be handled in JavaScript, it seems that wkwebview-engine
has to handle this to satisfy the old exec at least once. In any case, the old
iOSExec function design is inadequate. It is more desirable to handle this in
JavaScript since the wkwebview-engine ideally does not need to know about how
gap://ready works.
cc [~purplecabbage] who broke out the .js exec functionality
was (Author: shazron):
Found the culprit for the infinite "gap://ready" calls when the WKWebView
engine plugin is installed for mobile-spec.
During runtime, checking cordova.exec shows the right clobber, but the iOSExec
call is called at least once by cordova.js, resulting in this infinite call.
pokeNative() is called infinitely here:
https://github.com/apache/cordova-ios/blob/e3ae7e3ca0395988a087884f9ba18a683160dbde/cordova-js-src/exec.js#L162
Not sure if this can be handled in JavaScript, it seems that wkwebview-engine
has to handle this to satisfy the old exec at least once. In any case, the old
iOSExec function design is inadequate. It is more desirable to handle this in
JavaScript since the wkwebview-engine ideally does not need to know about how
gap://ready works.
cc [~purplecabbage] who broke out the .js exec functionality
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-7287) [WKWebView] Failing tests
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah updated CB-7287:
-
Summary: [WKWebView] Failing tests (was: [UIWebView][iOS 7] Failing tests
(wkwebview branch))
> [WKWebView] Failing tests
> -
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7287) [UIWebView][iOS 7] Failing tests (wkwebview branch)
[
https://issues.apache.org/jira/browse/CB-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029277#comment-15029277
]
Shazron Abdullah commented on CB-7287:
--
Found the culprit for the infinite "gap://ready" calls when the WKWebView
engine plugin is installed for mobile-spec.
During runtime, checking cordova.exec shows the right clobber, but the iOSExec
call is called at least once by cordova.js, resulting in this infinite call.
pokeNative() is called infinitely here:
https://github.com/apache/cordova-ios/blob/e3ae7e3ca0395988a087884f9ba18a683160dbde/cordova-js-src/exec.js#L162
Not sure if this can be handled in JavaScript, it seems that wkwebview-engine
has to handle this to satisfy the old exec at least once. In any case, the old
iOSExec function design is inadequate. It is more desirable to handle this in
JavaScript since the wkwebview-engine ideally does not need to know about how
gap://ready works.
cc [~purplecabbage] who broke out the .js exec functionality
> [UIWebView][iOS 7] Failing tests (wkwebview branch)
> ---
>
> Key: CB-7287
> URL: https://issues.apache.org/jira/browse/CB-7287
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Anis Kadri
> Labels: cordova-ios-4.0.x
>
> This is only for the wkwebview branch, and using these plugins, and 3.5.0
> mobile-spec:
> {code}
> "org.apache.cordova.battery-status": "0.2.10",
> "org.apache.cordova.camera": "0.3.1",
> "org.apache.cordova.console": "0.2.10",
> "org.apache.cordova.contacts": "0.2.12",
> "org.apache.cordova.device": "0.2.11",
> "org.apache.cordova.device-motion": "0.2.9",
> "org.apache.cordova.device-orientation": "0.3.8",
> "org.apache.cordova.dialogs": "0.2.9",
> "org.apache.cordova.file": "1.3.0",
> "org.apache.cordova.file-transfer": "0.4.5",
> "org.apache.cordova.geolocation": "0.3.9",
> "org.apache.cordova.globalization": "0.3.0",
> "org.apache.cordova.inappbrowser": "0.5.1",
> "org.apache.cordova.media": "0.2.12",
> "org.apache.cordova.media-capture": "0.3.2",
> "org.apache.cordova.network-information": "0.2.11",
> "org.apache.cordova.splashscreen": "0.3.2",
> "org.apache.cordova.vibration": "0.3.10"
> {code}
> The 3 failing tests:
> {code}
> FileTransfer upload method filetransfer.spec.18 should be able to upload a
> file.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/ed60ec667664b454d72b193bf8841e5c","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:28.862Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer upload method filetransfer.spec.19 should be able to upload a
> file with http basic auth.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/94aa407aca7bd9c53081f0da5ab33d54","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:29.322Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> FileTransfer Backwards compatibility filetransfer.spec.29 should be able to
> upload a file using local paths.
> Expected
> '{"fields":{"value2":"param","value1":"test"},"files":{"file":{"size":24,"path":"/opt/run/snapshot/.tmp/9bf857a3d64ef9beaf4eae4e22876ecc","name":"upload.txt","type":"text/plain","mtime":"2014-08-12T21:53:31.307Z"}}}
> ' to match /fields:\s*{\s*value1.*/.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10088) filetransfer spec.10 and spec.11 test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-10088. --- Resolution: Fixed > filetransfer spec.10 and spec.11 test is faulty > --- > > Key: CB-10088 > URL: https://issues.apache.org/jira/browse/CB-10088 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Xcode 7.1 > iOS 9.1 iPhone 6s >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: iOS > > Copied from: > https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283 > This is within the context of mobile-spec's autotests. > I added some logs in the native code, and cordova-filetransfer.tests > spec.10's file "downloaded" within 30ms (probably because of caching). When > calling abort, there is no active file transfer so the failure callback is > not called back to JavaScript: > https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380 > Since the failure callback is never called (the abort), and the the > unexpected download success was called, the test fails. > The test is faulty and needs to be reworked to take into account this case, > where the download finished before the file could be aborted (the test delays > the abort call). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10088) filetransfer spec.10 and spec.11 test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029266#comment-15029266 ] ASF subversion and git services commented on CB-10088: -- Commit 3ae73a28792197e38cca797b278617b7b73e in cordova-plugin-file-transfer's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=3ae73a2 ] CB-10088 - filetransfer spec.10 and spec.11 test is faulty > filetransfer spec.10 and spec.11 test is faulty > --- > > Key: CB-10088 > URL: https://issues.apache.org/jira/browse/CB-10088 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Xcode 7.1 > iOS 9.1 iPhone 6s >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: iOS > > Copied from: > https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283 > This is within the context of mobile-spec's autotests. > I added some logs in the native code, and cordova-filetransfer.tests > spec.10's file "downloaded" within 30ms (probably because of caching). When > calling abort, there is no active file transfer so the failure callback is > not called back to JavaScript: > https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380 > Since the failure callback is never called (the abort), and the the > unexpected download success was called, the test fails. > The test is faulty and needs to be reworked to take into account this case, > where the download finished before the file could be aborted (the test delays > the abort call). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10088) filetransfer spec.10 and spec.11 test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-10088: -- Summary: filetransfer spec.10 and spec.11 test is faulty (was: filetransfer spec.10 test is faulty) > filetransfer spec.10 and spec.11 test is faulty > --- > > Key: CB-10088 > URL: https://issues.apache.org/jira/browse/CB-10088 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Xcode 7.1 > iOS 9.1 iPhone 6s >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: iOS > > Copied from: > https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283 > This is within the context of mobile-spec's autotests. > I added some logs in the native code, and cordova-filetransfer.tests > spec.10's file "downloaded" within 30ms (probably because of caching). When > calling abort, there is no active file transfer so the failure callback is > not called back to JavaScript: > https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380 > Since the failure callback is never called (the abort), and the the > unexpected download success was called, the test fails. > The test is faulty and needs to be reworked to take into account this case, > where the download finished before the file could be aborted (the test delays > the abort call). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10088) filetransfer spec.10 and spec.11 test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029262#comment-15029262 ] Shazron Abdullah edited comment on CB-10088 at 11/26/15 9:44 PM: - spec.11 is affected by this as well (when I fixed spec.10, the error because of the cache popped up for spec.11) was (Author: shazron): spec.11 is affected by this as well. > filetransfer spec.10 and spec.11 test is faulty > --- > > Key: CB-10088 > URL: https://issues.apache.org/jira/browse/CB-10088 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Xcode 7.1 > iOS 9.1 iPhone 6s >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: iOS > > Copied from: > https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283 > This is within the context of mobile-spec's autotests. > I added some logs in the native code, and cordova-filetransfer.tests > spec.10's file "downloaded" within 30ms (probably because of caching). When > calling abort, there is no active file transfer so the failure callback is > not called back to JavaScript: > https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380 > Since the failure callback is never called (the abort), and the the > unexpected download success was called, the test fails. > The test is faulty and needs to be reworked to take into account this case, > where the download finished before the file could be aborted (the test delays > the abort call). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10088) filetransfer spec.10 test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029262#comment-15029262 ] Shazron Abdullah commented on CB-10088: --- spec.11 is affected by this as well. > filetransfer spec.10 test is faulty > --- > > Key: CB-10088 > URL: https://issues.apache.org/jira/browse/CB-10088 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Xcode 7.1 > iOS 9.1 iPhone 6s >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: iOS > > Copied from: > https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283 > This is within the context of mobile-spec's autotests. > I added some logs in the native code, and cordova-filetransfer.tests > spec.10's file "downloaded" within 30ms (probably because of caching). When > calling abort, there is no active file transfer so the failure callback is > not called back to JavaScript: > https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380 > Since the failure callback is never called (the abort), and the the > unexpected download success was called, the test fails. > The test is faulty and needs to be reworked to take into account this case, > where the download finished before the file could be aborted (the test delays > the abort call). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10088) filetransfer spec.10 test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029256#comment-15029256 ] Shazron Abdullah commented on CB-10088: --- The fix here is to append a query string to the file to download, to bust the cache. The value should be randomized so the test can pass on multiple runs. > filetransfer spec.10 test is faulty > --- > > Key: CB-10088 > URL: https://issues.apache.org/jira/browse/CB-10088 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Xcode 7.1 > iOS 9.1 iPhone 6s >Reporter: Shazron Abdullah > Labels: iOS > > Copied from: > https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283 > This is within the context of mobile-spec's autotests. > I added some logs in the native code, and cordova-filetransfer.tests > spec.10's file "downloaded" within 30ms (probably because of caching). When > calling abort, there is no active file transfer so the failure callback is > not called back to JavaScript: > https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380 > Since the failure callback is never called (the abort), and the the > unexpected download success was called, the test fails. > The test is faulty and needs to be reworked to take into account this case, > where the download finished before the file could be aborted (the test delays > the abort call). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-10088) filetransfer spec.10 test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah reassigned CB-10088: - Assignee: Shazron Abdullah > filetransfer spec.10 test is faulty > --- > > Key: CB-10088 > URL: https://issues.apache.org/jira/browse/CB-10088 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Xcode 7.1 > iOS 9.1 iPhone 6s >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: iOS > > Copied from: > https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283 > This is within the context of mobile-spec's autotests. > I added some logs in the native code, and cordova-filetransfer.tests > spec.10's file "downloaded" within 30ms (probably because of caching). When > calling abort, there is no active file transfer so the failure callback is > not called back to JavaScript: > https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380 > Since the failure callback is never called (the abort), and the the > unexpected download success was called, the test fails. > The test is faulty and needs to be reworked to take into account this case, > where the download finished before the file could be aborted (the test delays > the abort call). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10082) [UIWebView][iOS 9] Failing tests on mobile-spec
[
https://issues.apache.org/jira/browse/CB-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029255#comment-15029255
]
Shazron Abdullah edited comment on CB-10082 at 11/26/15 9:32 PM:
-
The fix here is for CB-10088 to append a query string with a randomized value
to bust the cache.
I did an experiment where I appended "?q=1" to the end, and it passed the test
(because the download wasn't in the cache). While the app was still running, I
ran the test again, and this time it failed (because it was in the cache, and
loaded almost immediately).
was (Author: shazron):
The fix here is for CB-10088 to append a query string with a randomized value
to bust the cache.
I did an experiment where I appended "?q=1" to the end, and it passed the test
(because the download wasn't in the cache). While the app was still running, I
ran the test again, and this time it failed.
> [UIWebView][iOS 9] Failing tests on mobile-spec
> ---
>
> Key: CB-10082
> URL: https://issues.apache.org/jira/browse/CB-10082
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: Xcode 7.1
> iOS 9.1
> iPhone 6s
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Labels: cordova-ios-4.0.x
>
> As of today:
> 15 failures (I had to disable whitelist tests since in cordova-ios-4.x there
> is no whitelist use, it's all ATS. I will be checking in code to disable it
> in mobile-spec for ios)
> *ALL* failures are cordova-plugin-file-transfer-tests, specs: 4, 5, 6, 10,
> 12, 13, 18, 19, 21, 22, 28-32
> {code}
> cordova-plugin-file-transfer-tests.tests >> FileTransfer methods download
> filetransfer.spec.4 should download a file
> Error: Timeout - Async callback was not invoked within timeout specified by
> jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js
> (line 1764)
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1764:32
> Expected spy httpFail not to have been called.
> stack@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:26
> buildExpectationResult@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:19
> expectationResultFactory@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:572:40
> addExpectationResult@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:321:58
> addExpectationResult@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:516:41
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:32
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/plugins/cordova-plugin-file-transfer-tests/tests.js:245:79
> attemptSync@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1741:28
> run@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1729:20
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1753:19
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1697:11
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/plugins/cordova-plugin-file-transfer-tests/tests.js:124:25
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/plugins/cordova-plugin-file/www/DirectoryEntry.js:112:22
> callbackFromNative@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cordova.js:295:57
> nc2@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cordova.js:988:39
> cordova-plugin-file-transfer-tests.tests >> FileTransfer methods download
> filetransfer.spec.5 should download a file using http basic auth
> Error: Timeout - Async callback was not invoked within timeout specified by
> jasmine.DEFAULT_T
[jira] [Commented] (CB-10082) [UIWebView][iOS 9] Failing tests on mobile-spec
[
https://issues.apache.org/jira/browse/CB-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029255#comment-15029255
]
Shazron Abdullah commented on CB-10082:
---
The fix here is for CB-10088 to append a query string with a randomized value
to bust the cache.
I did an experiment where I appended "?q=1" to the end, and it passed the test
(because the download wasn't in the cache). While the app was still running, I
ran the test again, and this time it failed.
> [UIWebView][iOS 9] Failing tests on mobile-spec
> ---
>
> Key: CB-10082
> URL: https://issues.apache.org/jira/browse/CB-10082
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: Xcode 7.1
> iOS 9.1
> iPhone 6s
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Labels: cordova-ios-4.0.x
>
> As of today:
> 15 failures (I had to disable whitelist tests since in cordova-ios-4.x there
> is no whitelist use, it's all ATS. I will be checking in code to disable it
> in mobile-spec for ios)
> *ALL* failures are cordova-plugin-file-transfer-tests, specs: 4, 5, 6, 10,
> 12, 13, 18, 19, 21, 22, 28-32
> {code}
> cordova-plugin-file-transfer-tests.tests >> FileTransfer methods download
> filetransfer.spec.4 should download a file
> Error: Timeout - Async callback was not invoked within timeout specified by
> jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js
> (line 1764)
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1764:32
> Expected spy httpFail not to have been called.
> stack@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:26
> buildExpectationResult@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:19
> expectationResultFactory@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:572:40
> addExpectationResult@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:321:58
> addExpectationResult@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:516:41
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:32
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/plugins/cordova-plugin-file-transfer-tests/tests.js:245:79
> attemptSync@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1741:28
> run@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1729:20
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1753:19
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1697:11
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/plugins/cordova-plugin-file-transfer-tests/tests.js:124:25
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/plugins/cordova-plugin-file/www/DirectoryEntry.js:112:22
> callbackFromNative@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cordova.js:295:57
> nc2@file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cordova.js:988:39
> cordova-plugin-file-transfer-tests.tests >> FileTransfer methods download
> filetransfer.spec.5 should download a file using http basic auth
> Error: Timeout - Async callback was not invoked within timeout specified by
> jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js
> (line 1764)
> file:///var/mobile/Containers/Bundle/Application/AA21552D-93C0-435E-A790-0B6215AF0537/mobilespec.app/www/cdvtests/jasmine-2.2.0/jasmine.js:1764:32
> Expected spy httpFail not to have been called.
> stack@file:///var/mobile/Containers/Bundle/Application/AA21552D-9
[jira] [Commented] (CB-9969) Windows filetransfer upload error deletes original file.
[
https://issues.apache.org/jira/browse/CB-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029227#comment-15029227
]
ASF subversion and git services commented on CB-9969:
-
Commit c97f544ef8511605b5fd74321cdf548d380b5601 in
cordova-plugin-file-transfer's branch refs/heads/master from [~daserge]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=c97f544
]
CB-9969 Filetransfer upload error deletes original file
Adds corresponding test and fixes for iOS and Windows
Also fixes filetransfer.spec.9, which used an incorrect path in the
root.getFile call.
> Windows filetransfer upload error deletes original file.
> --
>
> Key: CB-9969
> URL: https://issues.apache.org/jira/browse/CB-9969
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: windows
>Reporter: Wema Wuyts
>Assignee: Sergey Shakhnazarov
> Labels: reproduced, triaged
>
> The upload function on windows has an onerror handler:
> getTransferError.then(function(transferError) {
> storageFile.deleteAsync().then(function() {
> errorCallback(transferError);
> });
> });
> think this should be :
> getTransferError.then(function(transferError) {
> errorCallback(transferError);
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9969) Windows filetransfer upload error deletes original file.
[
https://issues.apache.org/jira/browse/CB-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029228#comment-15029228
]
ASF GitHub Bot commented on CB-9969:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/115
> Windows filetransfer upload error deletes original file.
> --
>
> Key: CB-9969
> URL: https://issues.apache.org/jira/browse/CB-9969
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: windows
>Reporter: Wema Wuyts
>Assignee: Sergey Shakhnazarov
> Labels: reproduced, triaged
>
> The upload function on windows has an onerror handler:
> getTransferError.then(function(transferError) {
> storageFile.deleteAsync().then(function() {
> errorCallback(transferError);
> });
> });
> think this should be :
> getTransferError.then(function(transferError) {
> errorCallback(transferError);
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9969) Windows filetransfer upload error deletes original file.
[
https://issues.apache.org/jira/browse/CB-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029210#comment-15029210
]
ASF GitHub Bot commented on CB-9969:
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#issuecomment-159983208
@dblotsky, thanks for reviewing!
Looks like the Android code does not need any changes - I confused
targetFile with source, which was not being deleted.
I will also improve the test now.
> Windows filetransfer upload error deletes original file.
> --
>
> Key: CB-9969
> URL: https://issues.apache.org/jira/browse/CB-9969
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: windows
>Reporter: Wema Wuyts
>Assignee: Sergey Shakhnazarov
> Labels: reproduced, triaged
>
> The upload function on windows has an onerror handler:
> getTransferError.then(function(transferError) {
> storageFile.deleteAsync().then(function() {
> errorCallback(transferError);
> });
> });
> think this should be :
> getTransferError.then(function(transferError) {
> errorCallback(transferError);
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10093) No file path is returned when selecting picture from third party apps
[ https://issues.apache.org/jira/browse/CB-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ying Wei Loke updated CB-10093: --- Description: 1) Camera.getPicture with - source type: PHOTOLIBRARY - destination type: FILE_URI 2) On the photo library, open other apps from menu (e.g. gallery/file manager/One Drive, etc) 3) Select any picture. Actual result: No file path for the picture selected is returned to the camera plugin. Note: Was working previously on plugin version 1.2.0. Logs with logcat: D/Documents(29453): onActivityResult() code=-1 V/WindowManager( 543): rotationForOrientationLw(orient=1, last=0); user=0 D/CordovaInterfaceImpl(15585): Sending activity result to plugin D/CameraLauncher(15585): File locaton is: I/Timeline(15585): Timeline: Activity_idle id: android.os.BinderProxy@16b7c72d time:10419445 W/System.err(15585): java.io.FileNotFoundException: /storage/emulated/0/Android/data/com.likemindnetworks.apps.teamDental/cache: open failed: EISDIR (Is a directory) W/System.err(15585):at libcore.io.IoBridge.open(IoBridge.java:456) W/System.err(15585):at java.io.FileOutputStream.(FileOutputStream.java:87) W/System.err(15585):at java.io.FileOutputStream.(FileOutputStream.java:127) W/System.err(15585):at java.io.FileOutputStream.(FileOutputStream.java:116) W/System.err(15585):at org.apache.cordova.camera.CameraLauncher.ouputModifiedBitmap(CameraLauncher.java:595) W/System.err(15585):at org.apache.cordova.camera.CameraLauncher.processResultFromGallery(CameraLauncher.java:703) W/System.err(15585):at org.apache.cordova.camera.CameraLauncher.access$000(CameraLauncher.java:66) W/System.err(15585):at org.apache.cordova.camera.CameraLauncher$1.run(CameraLauncher.java:800) W/System.err(15585):at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) W/System.err(15585):at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) W/System.err(15585):at java.lang.Thread.run(Thread.java:818) W/System.err(15585): Caused by: android.system.ErrnoException: open failed: EISDIR (Is a directory) W/System.err(15585):at libcore.io.Posix.open(Native Method) W/System.err(15585):at libcore.io.BlockGuardOs.open(BlockGuardOs.java:186) W/System.err(15585):at libcore.io.IoBridge.open(IoBridge.java:442) W/System.err(15585):... 10 more was: 1) Camera.getPicture with - source type: PHOTOLIBRARY - destination type: FILE_URI 2) On the photo library, open other apps from menu (e.g. gallery/file manager/One Drive, etc) 3) Select any picture. Actual result: No file path for the picture selected is returned to the camera plugin. Note: Was working previously on plugin version 1.2.0. > No file path is returned when selecting picture from third party apps > - > > Key: CB-10093 > URL: https://issues.apache.org/jira/browse/CB-10093 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Environment: Android 6.0, Android 5.1.1, Camera plugin 2.0.0, Cordova > 5.4.0 >Reporter: Ying Wei Loke > Labels: camera > > 1) Camera.getPicture with > - source type: PHOTOLIBRARY > - destination type: FILE_URI > 2) On the photo library, open other apps from menu (e.g. gallery/file > manager/One Drive, etc) > 3) Select any picture. > Actual result: > No file path for the picture selected is returned to the camera plugin. > Note: Was working previously on plugin version 1.2.0. > Logs with logcat: > D/Documents(29453): onActivityResult() code=-1 > V/WindowManager( 543): rotationForOrientationLw(orient=1, last=0); user=0 > D/CordovaInterfaceImpl(15585): Sending activity result to plugin > D/CameraLauncher(15585): File locaton is: > I/Timeline(15585): Timeline: Activity_idle id: > android.os.BinderProxy@16b7c72d time:10419445 > W/System.err(15585): java.io.FileNotFoundException: > /storage/emulated/0/Android/data/com.likemindnetworks.apps.teamDental/cache: > open failed: EISDIR (Is a directory) > W/System.err(15585): at libcore.io.IoBridge.open(IoBridge.java:456) > W/System.err(15585): at > java.io.FileOutputStream.(FileOutputStream.java:87) > W/System.err(15585): at > java.io.FileOutputStream.(FileOutputStream.java:127) > W/System.err(15585): at > java.io.FileOutputStream.(FileOutputStream.java:116) > W/System.err(15585): at > org.apache.cordova.camera.CameraLauncher.ouputModifiedBitmap(CameraLauncher.java:595) > W/System.err(15585): at > org.apache.cordova.camera.CameraLauncher.processResultFromGallery(CameraLauncher.java:703) > W/System.err(15585): at > org.apache.cordova.camera.CameraLauncher.access$000(CameraLauncher.java:66) > W/System.err(15585): at > org.apache.cordova.camera.CameraLauncher$1.run(CameraLauncher.java:800) > W/System.err(15585): at > java.u
[jira] [Created] (CB-10093) No file path is returned when selecting picture from third party apps
Ying Wei Loke created CB-10093: -- Summary: No file path is returned when selecting picture from third party apps Key: CB-10093 URL: https://issues.apache.org/jira/browse/CB-10093 Project: Apache Cordova Issue Type: Bug Components: Android Environment: Android 6.0, Android 5.1.1, Camera plugin 2.0.0, Cordova 5.4.0 Reporter: Ying Wei Loke 1) Camera.getPicture with - source type: PHOTOLIBRARY - destination type: FILE_URI 2) On the photo library, open other apps from menu (e.g. gallery/file manager/One Drive, etc) 3) Select any picture. Actual result: No file path for the picture selected is returned to the camera plugin. Note: Was working previously on plugin version 1.2.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9969) Windows filetransfer upload error deletes original file.
[
https://issues.apache.org/jira/browse/CB-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029169#comment-15029169
]
ASF GitHub Bot commented on CB-9969:
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#issuecomment-15997
Yes, I've tested it with test-framework plugin.
> Windows filetransfer upload error deletes original file.
> --
>
> Key: CB-9969
> URL: https://issues.apache.org/jira/browse/CB-9969
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: windows
>Reporter: Wema Wuyts
>Assignee: Sergey Shakhnazarov
> Labels: reproduced, triaged
>
> The upload function on windows has an onerror handler:
> getTransferError.then(function(transferError) {
> storageFile.deleteAsync().then(function() {
> errorCallback(transferError);
> });
> });
> think this should be :
> getTransferError.then(function(transferError) {
> errorCallback(transferError);
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9969) Windows filetransfer upload error deletes original file.
[
https://issues.apache.org/jira/browse/CB-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029167#comment-15029167
]
ASF GitHub Bot commented on CB-9969:
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/115#discussion_r46001338
--- Diff: tests/tests.js ---
@@ -450,7 +450,7 @@ exports.defineAutoTests = function () {
expect(transfer.onprogress).toHaveBeenCalled();
// check that there is no file
-root.getFile(localFilePath, null,
unexpectedCallbacks.fileSystemWin, done);
+root.getFile(fileName, null,
unexpectedCallbacks.fileSystemWin, done);
--- End diff --
Despite the fact that [the
docs](https://github.com/apache/cordova-plugin-file/blob/ab42f3e7c6c2282ac303e32260e8d68fdd2e18e3/www/DirectoryEntry.js#L98)
says it takes a relative or an absolute path (by the way I can't find any File
plugin test for an absolute path), the use of `localFilePath` (which is
`file:///` on Android and `ms-appdata:///` on Windows) causes a fail with
`FileError.ENCODING_ERR = 5` instead of `FileError.NOT_FOUND_ERR = 1`.
Probably the absolute path should be absolute to the fs root like
`/dir/file.txt` and not a native path.
> Windows filetransfer upload error deletes original file.
> --
>
> Key: CB-9969
> URL: https://issues.apache.org/jira/browse/CB-9969
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: windows
>Reporter: Wema Wuyts
>Assignee: Sergey Shakhnazarov
> Labels: reproduced, triaged
>
> The upload function on windows has an onerror handler:
> getTransferError.then(function(transferError) {
> storageFile.deleteAsync().then(function() {
> errorCallback(transferError);
> });
> });
> think this should be :
> getTransferError.then(function(transferError) {
> errorCallback(transferError);
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10092) Can't find variable: StatusBar
Kevin Campion created CB-10092: -- Summary: Can't find variable: StatusBar Key: CB-10092 URL: https://issues.apache.org/jira/browse/CB-10092 Project: Apache Cordova Issue Type: Bug Components: CordovaJS, CordovaLib, iOS Affects Versions: 2.0.0 Reporter: Kevin Campion Priority: Blocker cordova-plugin-statusbar 2.0.0 Cordova 5.4.0 iPhone 6 (iOS 9.1) Ionic 1.7.10 I installed the StatusBar plugin with this command: # cordova plugin add cordova-plugin-statusbar When I build and launch my project under the iOS simulator, this mistake appears: Can't find variable: StatusBar I could see the plugin is loaded under Xcode's logs: [CDVTimer][statusbar] 4.725993ms This problem comes only if I use StatusBar just after the starting, under a controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-9945) Geolocation plugin not working in Android 6.0 emulator
[
https://issues.apache.org/jira/browse/CB-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Bowser closed CB-9945.
--
Resolution: Won't Fix
This is an issue with Genymotion. We don't experience this issue on an actual
device. If you get this on an actual device, please let us know.
> Geolocation plugin not working in Android 6.0 emulator
> --
>
> Key: CB-9945
> URL: https://issues.apache.org/jira/browse/CB-9945
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Geolocation
> Environment: AVD Android 6.0
> Genymotion Android 6.0 PREVIEW
>Reporter: Dave Alden
>
> Calling the Cordova geolocation API in an Android emulator environment causes
> the Android OS to crash and reboot.
> The issue is reproducible with Cordova geolocation plugin from npm release
> version 1.0.1 and latest version on master branch 1.0.2-dev.
> Steps to reproduce:
> Use the Cordova geolocation API to request a location in Android 6.0 emulator
> environment:
> navigator.geolocation.getCurrentPosition(onPosition, onPositionError, {
> maxAge: 0,
> timeout: 1,
> enableHighAccuracy: false
> });
>
> OR clone the bitbucket repo
> https://bitbucket.org/dpa99c/android-m-location-test/src, build and run
> OR install and run the pre-built APK for that project:
> https://bitbucket.org/dpa99c/android-m-location-test/raw/9a836ca3e3185db55fa75b263a4abbb76b4713ea/android-debug.apk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5308) Contact.save() calls failure callback even though contact data is successfully saved on device
[
https://issues.apache.org/jira/browse/CB-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029016#comment-15029016
]
ASF GitHub Bot commented on CB-5308:
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r45991178
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1027,7 +1027,7 @@ else if (accounts.length > 1) {
private String modifyContact(String id, JSONObject contact, String
accountType, String accountName) {
// Get the RAW_CONTACT_ID which is needed to insert new values in
an already existing contact.
// But not needed to update existing values.
-int rawId = (Integer.valueOf(getJsonString(contact,
"rawId"))).intValue();
+String rawId = getJsonString(contact, "rawId");
--- End diff --
Should the type be String or long as stated in [the
docs](http://developer.android.com/intl/ru/reference/android/provider/ContactsContract.Data.html)?
Or does not this matter?
> Contact.save() calls failure callback even though contact data is
> successfully saved on device
> --
>
> Key: CB-5308
> URL: https://issues.apache.org/jira/browse/CB-5308
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: Android 4.1.2, 4.4.3 physical device. 4.4.3 device is
> Nexus 7.
> Cordova 3.1.0, 3.6.3
>Reporter: Shingo Toda
>Assignee: Vladimir Kotikov
> Labels: Android, reproduced, triaged
>
> When I run contact mobile-spec, following specs sometimes fail.
> - contacts.spec.6
> - contacts.spec.20
> - contacts.spec.21
> - contacts.spec.24
> In Java side, it looks that {{ContactAccessorSdk5.save()}} returns contact id
> but {{ContactAccessorSdk5.getContactById()}} returns {{null}} instead of
> contact data associated with the id. Actually some of contact data such as
> "Test Delete" are found on my device so the save operation is actually done.
> This save() returns "newId" in the following code.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> //Add contact
> try {
> ContentProviderResult[] cpResults =
> mApp.getActivity().getContentResolver().applyBatch(ContactsContract.AUTHORITY,
> ops);
> if (cpResults.length >= 0) {
> newId = cpResults[0].uri.getLastPathSegment();
> }
> } catch (RemoteException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> } catch (OperationApplicationException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> }
> return newId;
> {code}
> When I debug it, {{cpResults\[0\].uri}} is
> {{content://com.android.contacts/raw_contacts/}} so, this is just my
> assumption, I think {{save()}} returns raw contact id.
> But at {{getContactById()}}, query filter uses {{CONTACT_ID}} column as a
> projection.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.CONTACT_ID + " = ? ",
> new String[] { id },
> ContactsContract.Data.CONTACT_ID + " ASC");
> {code}
> So if contact id and raw contact id is different then fetching contact data
> might fail. Actually in my case, if I fail the specs, they are always
> different.
> I try modifying {{getContactById()}} to process following code if contact
> JSONObject doesn't have id property, then I didn't get failure for those
> specs even if I run them some times.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.RAW_CONTACT_ID + " = ? ",
> new String[] { rawid },
> ContactsContract.Data.RAW_CONTACT_ID + " ASC");
> {code}
> I am just learning how contact data is managed on Android so I might be wrong
> for some use cases, but it works fine for mobile-spec.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5308) Contact.save() calls failure callback even though contact data is successfully saved on device
[
https://issues.apache.org/jira/browse/CB-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029008#comment-15029008
]
ASF GitHub Bot commented on CB-5308:
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r45990446
--- Diff: tests/tests.js ---
@@ -358,44 +380,68 @@ exports.defineAutoTests = function() {
pending();
}
-expect(gContactObj).toBeDefined();
-
-var bDay = new Date(1975, 5, 4);
+var aDay = new Date(1976, 6, 4);
+var bDay;
var noteText = "an UPDATED note";
-var win = function(obj) {
-expect(obj).toBeDefined();
-expect(obj.id).toBe(gContactObj.id);
-expect(obj.note).toBe(noteText);
-
expect(obj.birthday.toDateString()).toBe(bDay.toDateString());
-expect(obj.emails.length).toBe(1);
-expect(obj.emails[0].value).toBe('h...@there.com');
-removeContact(); // Clean up contact object
-done();
+var obj = {
+"gender": "male",
+"note": "my note",
+"name": {
+"familyName": "Delete",
+"givenName": "Test"
},
-fail = function() {
-removeContact();
-fail(done);
-};
+"emails": [{
+"value": "h...@there.com"
+}, {
+"value": "th...@here.com"
+}],
+"birthday": aDay
+};
+
+var saveFail = fail.bind(null, done);
+
+var saveSuccess = function(obj) {
+// must store returned object in order to have id for
update test below
+gContactObj = obj;
+gContactObj.emails[1].value = "";
+bDay = new Date(1975, 5, 4);
+gContactObj.birthday = bDay;
+gContactObj.note = noteText;
+gContactObj.save(updateSuccess, saveFail);
+};
+
+var updateSuccess = function(obj) {
+expect(obj).toBeDefined();
+expect(obj.id).toBe(gContactObj.id);
+expect(obj.note).toBe(noteText);
+
expect(obj.birthday.toDateString()).toBe(bDay.toDateString());
+expect(obj.emails.length).toBe(1);
+expect(obj.emails[0].value).toBe('h...@there.com');
+done();
+};
+
+navigator.contacts
+.create(obj)
+.save(saveSuccess, saveFail);
-// remove an email
-gContactObj.emails[1].value = "";
-// change birthday
-gContactObj.birthday = bDay;
-// update note
-gContactObj.note = noteText;
-gContactObj.save(win, fail);
}, MEDIUM_TIMEOUT);
});
+
describe('Contact.remove method', function(done) {
-afterEach(removeContact);
+afterEach(function (done) {
+removeContact(done);
+});
it("contacts.spec.22 calling remove on a contact has an id of
null should return ContactError.UNKNOWN_ERROR", function(done) {
-var win = function() {};
+var win = function() {
+expect(false).toBe(true);
--- End diff --
IMO this might be rewritten to use the global `fail` function as in spec.23
and others, i.e. use `fail.bind` as it does the same thing.
> Contact.save() calls failure callback even though contact data is
> successfully saved on device
> --
>
> Key: CB-5308
> URL: https://issues.apache.org/jira/browse/CB-5308
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: Android 4.1.2, 4.4.3 physical device. 4.4.3 device is
> Nexus 7.
> Cordova 3.1.0, 3.6.3
>Reporter: Shingo Toda
>Assignee: Vladimir
[jira] [Commented] (CB-5308) Contact.save() calls failure callback even though contact data is successfully saved on device
[
https://issues.apache.org/jira/browse/CB-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028994#comment-15028994
]
ASF GitHub Bot commented on CB-5308:
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r45989334
--- Diff: tests/tests.js ---
@@ -37,23 +37,34 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 3;
-var removeContact = function() {
-if (gContactObj) {
-gContactObj.remove(function() {}, function() {
-console.log("[CONTACTS ERROR]: removeContact cleanup
method failed to clean up test artifacts.");
-});
-gContactObj = null;
-}
-};
+var removeContact = function(done) {
+if (!done) {
+done = function noop () { };
--- End diff --
A comment on why this is added would be useful.
> Contact.save() calls failure callback even though contact data is
> successfully saved on device
> --
>
> Key: CB-5308
> URL: https://issues.apache.org/jira/browse/CB-5308
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: Android 4.1.2, 4.4.3 physical device. 4.4.3 device is
> Nexus 7.
> Cordova 3.1.0, 3.6.3
>Reporter: Shingo Toda
>Assignee: Vladimir Kotikov
> Labels: Android, reproduced, triaged
>
> When I run contact mobile-spec, following specs sometimes fail.
> - contacts.spec.6
> - contacts.spec.20
> - contacts.spec.21
> - contacts.spec.24
> In Java side, it looks that {{ContactAccessorSdk5.save()}} returns contact id
> but {{ContactAccessorSdk5.getContactById()}} returns {{null}} instead of
> contact data associated with the id. Actually some of contact data such as
> "Test Delete" are found on my device so the save operation is actually done.
> This save() returns "newId" in the following code.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> //Add contact
> try {
> ContentProviderResult[] cpResults =
> mApp.getActivity().getContentResolver().applyBatch(ContactsContract.AUTHORITY,
> ops);
> if (cpResults.length >= 0) {
> newId = cpResults[0].uri.getLastPathSegment();
> }
> } catch (RemoteException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> } catch (OperationApplicationException e) {
> Log.e(LOG_TAG, e.getMessage(), e);
> }
> return newId;
> {code}
> When I debug it, {{cpResults\[0\].uri}} is
> {{content://com.android.contacts/raw_contacts/}} so, this is just my
> assumption, I think {{save()}} returns raw contact id.
> But at {{getContactById()}}, query filter uses {{CONTACT_ID}} column as a
> projection.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.CONTACT_ID + " = ? ",
> new String[] { id },
> ContactsContract.Data.CONTACT_ID + " ASC");
> {code}
> So if contact id and raw contact id is different then fetching contact data
> might fail. Actually in my case, if I fail the specs, they are always
> different.
> I try modifying {{getContactById()}} to process following code if contact
> JSONObject doesn't have id property, then I didn't get failure for those
> specs even if I run them some times.
> {code:title=ContactAccessorSdk5.java|borderStyle=solid}
> Cursor c =
> mApp.getActivity().getContentResolver().query(ContactsContract.Data.CONTENT_URI,
> null,
> ContactsContract.Data.RAW_CONTACT_ID + " = ? ",
> new String[] { rawid },
> ContactsContract.Data.RAW_CONTACT_ID + " ASC");
> {code}
> I am just learning how contact data is managed on Android so I might be wrong
> for some use cases, but it works fine for mobile-spec.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6979) CDVContact : ExtractPhotos creating replica photos
[
https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028990#comment-15028990
]
ASF GitHub Bot commented on CB-6979:
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/89#discussion_r45988996
--- Diff: src/ios/CDVContact.m ---
@@ -1324,6 +1324,7 @@ - (NSObject*)extractPhotos
NSMutableArray* photos = nil;
if (ABPersonHasImageData(self.record)) {
+CFIndex photoId = ABRecordGetRecordID(self.record);
--- End diff --
Will this always return a valid value?
> CDVContact : ExtractPhotos creating replica photos
> ---
>
> Key: CB-6979
> URL: https://issues.apache.org/jira/browse/CB-6979
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: iOS
>Reporter: Geetha
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: iOS, triaged
>
> When we try to get the contacts from the Addressbook , in CDVContact in the
> extractPhotos method , the photos are extracted and stroed in the tmp folder.
> But duplicates of photos have created in tm because everytime the photo URL
> is been a new one thus creating a photo and increasing the memory consumption
> of the app. We ve found that app memory usage piles up when we try to load
> the more no of contacts which leads to low memory warning to the app and
> thus killed by the OS.
> This is the observation we found , Please let us know if we can do some
> alternative.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-4069) Setting empty emails should remove the email from Contact. mobile-spec test case fails
[ https://issues.apache.org/jira/browse/CB-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov closed CB-4069. Resolution: Fixed This is seems to be already fixed in CB-4084. Closing. > Setting empty emails should remove the email from Contact. mobile-spec test > case fails > -- > > Key: CB-4069 > URL: https://issues.apache.org/jira/browse/CB-4069 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 2.7.0 > Environment: Galaxy Nexus emulator >Reporter: Peter >Assignee: Joe Bowser >Priority: Minor > Labels: Android, cannot-reproduce, triaged > > Refer to dev mailing list: http://markmail.org/message/ks5pfvfdz3u2n6wl > The cordova-mobile-spec contact.specs.21 test case expects that setting an > empty email address will remove that email from the contact. > I have debugged into ContactAccessorSdk5.modifyContact and it seems that > Android implementation currently has no such logic to handle this. > So the device API test fails. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4069) Setting empty emails should remove the email from Contact. mobile-spec test case fails
[ https://issues.apache.org/jira/browse/CB-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-4069: - Component/s: (was: mobile-spec) (was: Android) > Setting empty emails should remove the email from Contact. mobile-spec test > case fails > -- > > Key: CB-4069 > URL: https://issues.apache.org/jira/browse/CB-4069 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 2.7.0 > Environment: Galaxy Nexus emulator >Reporter: Peter >Assignee: Joe Bowser >Priority: Minor > Labels: Android, cannot-reproduce, triaged > > Refer to dev mailing list: http://markmail.org/message/ks5pfvfdz3u2n6wl > The cordova-mobile-spec contact.specs.21 test case expects that setting an > empty email address will remove that email from the contact. > I have debugged into ContactAccessorSdk5.modifyContact and it seems that > Android implementation currently has no such logic to handle this. > So the device API test fails. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4069) Setting empty emails should remove the email from Contact. mobile-spec test case fails
[ https://issues.apache.org/jira/browse/CB-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-4069: - Labels: Android cannot-reproduce triaged (was: ) > Setting empty emails should remove the email from Contact. mobile-spec test > case fails > -- > > Key: CB-4069 > URL: https://issues.apache.org/jira/browse/CB-4069 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 2.7.0 > Environment: Galaxy Nexus emulator >Reporter: Peter >Assignee: Joe Bowser >Priority: Minor > Labels: Android, cannot-reproduce, triaged > > Refer to dev mailing list: http://markmail.org/message/ks5pfvfdz3u2n6wl > The cordova-mobile-spec contact.specs.21 test case expects that setting an > empty email address will remove that email from the contact. > I have debugged into ContactAccessorSdk5.modifyContact and it seems that > Android implementation currently has no such logic to handle this. > So the device API test fails. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[
https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028941#comment-15028941
]
ASF GitHub Bot commented on CB-3950:
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/90#discussion_r45985746
--- Diff: src/ios/CDVContact.m ---
@@ -787,7 +789,9 @@ +
(NSString*)convertPropertyLabelToContactType:(NSString*)label
} else if ([label
isEqualToString:(NSString*)kABPersonHomePageLabel]) {
type = kW3ContactUrlProfile;
} else {
-type = kW3ContactOtherLabel;
+// CB-3950 If label is not one of kW3*Label constants, threat
it as custom label.
+// Otherwise fetching contact and then saving it will mailform
this label in address book.
--- End diff --
Typo: mailform -> malform
> Custom labels are removed when a contact is saved on iOS.
> -
>
> Key: CB-3950
> URL: https://issues.apache.org/jira/browse/CB-3950
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: iOS
> Cordova 2.7.0
>Reporter: Olivier Louvignes
>Assignee: Vladimir Kotikov
> Labels: contacts, ios, reproduced, triaged
>
> When I update an existing contact that has some custom labels (like
> "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do
> not touch the "phoneNumbers" array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[ https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028942#comment-15028942 ] ASF GitHub Bot commented on CB-3950: Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/90#issuecomment-159933019 LGTM :+1: > Custom labels are removed when a contact is saved on iOS. > - > > Key: CB-3950 > URL: https://issues.apache.org/jira/browse/CB-3950 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS > Cordova 2.7.0 >Reporter: Olivier Louvignes >Assignee: Vladimir Kotikov > Labels: contacts, ios, reproduced, triaged > > When I update an existing contact that has some custom labels (like > "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do > not touch the "phoneNumbers" array. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[
https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028938#comment-15028938
]
ASF GitHub Bot commented on CB-3950:
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/90#discussion_r45985736
--- Diff: src/ios/CDVContact.m ---
@@ -750,7 +750,9 @@ +
(CFStringRef)convertContactTypeToPropertyLabel:(NSString*)label
} else if ([label caseInsensitiveCompare:kW3ContactUrlProfile] ==
NSOrderedSame) {
type = kABPersonHomePageLabel;
} else {
-type = kABOtherLabel;
+// CB-3950 If label is not one of kW3*Label constants, threat it
as custom label.
+// Otherwise fetching contact and then saving it will mailform
this label in address book.
--- End diff --
Typo: mailform -> malform
> Custom labels are removed when a contact is saved on iOS.
> -
>
> Key: CB-3950
> URL: https://issues.apache.org/jira/browse/CB-3950
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: iOS
> Cordova 2.7.0
>Reporter: Olivier Louvignes
>Assignee: Vladimir Kotikov
> Labels: contacts, ios, reproduced, triaged
>
> When I update an existing contact that has some custom labels (like
> "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do
> not touch the "phoneNumbers" array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[ https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028802#comment-15028802 ] ASF GitHub Bot commented on CB-3950: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/90 CB-3950 Do not replace custom labels with "Other" on contact save https://issues.apache.org/jira/browse/CB-3950 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-3950 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/90.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #90 commit c87152cb64bc9f7dbbba9d0ba5c7e4194a8e2ad9 Author: Vladimir Kotikov Date: 2015-11-26T13:40:28Z CB-3950 Adds support for custom labels > Custom labels are removed when a contact is saved on iOS. > - > > Key: CB-3950 > URL: https://issues.apache.org/jira/browse/CB-3950 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS > Cordova 2.7.0 >Reporter: Olivier Louvignes >Assignee: Vladimir Kotikov > Labels: contacts, ios, reproduced, triaged > > When I update an existing contact that has some custom labels (like > "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do > not touch the "phoneNumbers" array. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[ https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov reassigned CB-3950: Assignee: Vladimir Kotikov > Custom labels are removed when a contact is saved on iOS. > - > > Key: CB-3950 > URL: https://issues.apache.org/jira/browse/CB-3950 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS > Cordova 2.7.0 >Reporter: Olivier Louvignes >Assignee: Vladimir Kotikov > Labels: contacts, ios, reproduced, triaged > > When I update an existing contact that has some custom labels (like > "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do > not touch the "phoneNumbers" array. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8048) Contact.pickContact API should call getContactByRawId to fetch already existing contact
[
https://issues.apache.org/jira/browse/CB-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028705#comment-15028705
]
Vladimir Kotikov commented on CB-8048:
--
IMO this issue is not valid because you are suggesting a fix, based on a code,
that hasn't ever been pulled into master.
{{getContactById}} already uses raw id to get a contact since
[e426029|https://github.com/apache/cordova-plugin-contacts/commit/e42602901cd8b1a6c24b465ac725e4132f5c7a1e]
Also, CB-5308 is partially fixed (it works, when you saving a just created
contact), and the last fix for this is on the way (see
[#87|https://github.com/apache/cordova-plugin-contacts/pull/87])
So i'm going to close this as not actual anymore
> Contact.pickContact API should call getContactByRawId to fetch already
> existing contact
> ---
>
> Key: CB-8048
> URL: https://issues.apache.org/jira/browse/CB-8048
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
>Affects Versions: 3.6.3
> Environment: Mobilespec 3.6.3 , Nexus 7 device, Android 4.4.3 version
> on device
>Reporter: Pavankumar Joshi
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: Android, triaged
>
> This Issue is related to https://issues.apache.org/jira/browse/CB-5308
> I am constantly getting contact.save()(already existing contact) method test
> failure.
> If I apply the patch as mentioned in JIRA
> https://issues.apache.org/jira/browse/CB-5308 pickContacts API fails.
> But without the patch conact.save()(already existing contact) method always
> fails.
> I observed that the query to retrieve the contact which already exists
> RAWCONTACTS_ID is used This is implemented in onActivityResult() in
> ContactManager.java
> Hence i made the change even to pickContact API.
> Earlier Code
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[]
> {RawContacts._ID}, RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst()) { this.callbackContext.error("Error occured while
> retrieving contact raw id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try { JSONObject contact = contactAccessor.getContactById(id);
> this.callbackContext.success(contact); return; } catch (JSONException e) {
> Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED){
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Modified Code : Changed the call " JSONObject contact =
> contactAccessor.getContactByRawId(id);"
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[] {RawContacts._ID}
> , RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst())
> { this.callbackContext.error("Error occured while retrieving contact raw
> id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try
> { //JSONObject contact = contactAccessor.getContactById(id); JSONObject
> contact = contactAccessor.getContactByRawId(id);
> this.callbackContext.success(contact); return; }
> catch (JSONException e)
> { Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED)
> { this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Please let me know if this is correct or are we missing something
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8048) Contact.pickContact API should call getContactByRawId to fetch already existing contact
[
https://issues.apache.org/jira/browse/CB-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov closed CB-8048.
Resolution: Invalid
> Contact.pickContact API should call getContactByRawId to fetch already
> existing contact
> ---
>
> Key: CB-8048
> URL: https://issues.apache.org/jira/browse/CB-8048
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
>Affects Versions: 3.6.3
> Environment: Mobilespec 3.6.3 , Nexus 7 device, Android 4.4.3 version
> on device
>Reporter: Pavankumar Joshi
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: Android, triaged
>
> This Issue is related to https://issues.apache.org/jira/browse/CB-5308
> I am constantly getting contact.save()(already existing contact) method test
> failure.
> If I apply the patch as mentioned in JIRA
> https://issues.apache.org/jira/browse/CB-5308 pickContacts API fails.
> But without the patch conact.save()(already existing contact) method always
> fails.
> I observed that the query to retrieve the contact which already exists
> RAWCONTACTS_ID is used This is implemented in onActivityResult() in
> ContactManager.java
> Hence i made the change even to pickContact API.
> Earlier Code
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[]
> {RawContacts._ID}, RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst()) { this.callbackContext.error("Error occured while
> retrieving contact raw id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try { JSONObject contact = contactAccessor.getContactById(id);
> this.callbackContext.success(contact); return; } catch (JSONException e) {
> Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED){
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Modified Code : Changed the call " JSONObject contact =
> contactAccessor.getContactByRawId(id);"
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[] {RawContacts._ID}
> , RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst())
> { this.callbackContext.error("Error occured while retrieving contact raw
> id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try
> { //JSONObject contact = contactAccessor.getContactById(id); JSONObject
> contact = contactAccessor.getContactByRawId(id);
> this.callbackContext.success(contact); return; }
> catch (JSONException e)
> { Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED)
> { this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Please let me know if this is correct or are we missing something
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8048) Contact.pickContact API should call getContactByRawId to fetch already existing contact
[
https://issues.apache.org/jira/browse/CB-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-8048:
-
Labels: Android triaged (was: Android reproduced triaged)
> Contact.pickContact API should call getContactByRawId to fetch already
> existing contact
> ---
>
> Key: CB-8048
> URL: https://issues.apache.org/jira/browse/CB-8048
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
>Affects Versions: 3.6.3
> Environment: Mobilespec 3.6.3 , Nexus 7 device, Android 4.4.3 version
> on device
>Reporter: Pavankumar Joshi
>Priority: Minor
> Labels: Android, triaged
>
> This Issue is related to https://issues.apache.org/jira/browse/CB-5308
> I am constantly getting contact.save()(already existing contact) method test
> failure.
> If I apply the patch as mentioned in JIRA
> https://issues.apache.org/jira/browse/CB-5308 pickContacts API fails.
> But without the patch conact.save()(already existing contact) method always
> fails.
> I observed that the query to retrieve the contact which already exists
> RAWCONTACTS_ID is used This is implemented in onActivityResult() in
> ContactManager.java
> Hence i made the change even to pickContact API.
> Earlier Code
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[]
> {RawContacts._ID}, RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst()) { this.callbackContext.error("Error occured while
> retrieving contact raw id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try { JSONObject contact = contactAccessor.getContactById(id);
> this.callbackContext.success(contact); return; } catch (JSONException e) {
> Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED){
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Modified Code : Changed the call " JSONObject contact =
> contactAccessor.getContactByRawId(id);"
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[] {RawContacts._ID}
> , RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst())
> { this.callbackContext.error("Error occured while retrieving contact raw
> id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try
> { //JSONObject contact = contactAccessor.getContactById(id); JSONObject
> contact = contactAccessor.getContactByRawId(id);
> this.callbackContext.success(contact); return; }
> catch (JSONException e)
> { Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED)
> { this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Please let me know if this is correct or are we missing something
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8048) Contact.pickContact API should call getContactByRawId to fetch already existing contact
[
https://issues.apache.org/jira/browse/CB-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov reassigned CB-8048:
Assignee: Vladimir Kotikov
> Contact.pickContact API should call getContactByRawId to fetch already
> existing contact
> ---
>
> Key: CB-8048
> URL: https://issues.apache.org/jira/browse/CB-8048
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
>Affects Versions: 3.6.3
> Environment: Mobilespec 3.6.3 , Nexus 7 device, Android 4.4.3 version
> on device
>Reporter: Pavankumar Joshi
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: Android, triaged
>
> This Issue is related to https://issues.apache.org/jira/browse/CB-5308
> I am constantly getting contact.save()(already existing contact) method test
> failure.
> If I apply the patch as mentioned in JIRA
> https://issues.apache.org/jira/browse/CB-5308 pickContacts API fails.
> But without the patch conact.save()(already existing contact) method always
> fails.
> I observed that the query to retrieve the contact which already exists
> RAWCONTACTS_ID is used This is implemented in onActivityResult() in
> ContactManager.java
> Hence i made the change even to pickContact API.
> Earlier Code
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[]
> {RawContacts._ID}, RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst()) { this.callbackContext.error("Error occured while
> retrieving contact raw id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try { JSONObject contact = contactAccessor.getContactById(id);
> this.callbackContext.success(contact); return; } catch (JSONException e) {
> Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED){
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Modified Code : Changed the call " JSONObject contact =
> contactAccessor.getContactByRawId(id);"
> {code}
> public void onActivityResult(int requestCode, int resultCode, final Intent
> intent) {
> if (requestCode == CONTACT_PICKER_RESULT) {
> if (resultCode == Activity.RESULT_OK) {
> String contactId = intent.getData().getLastPathSegment();
> // to populate contact data we require Raw Contact ID
> // so we do look up for contact raw id first
> Cursor c =
> this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
> new String[] {RawContacts._ID}
> , RawContacts.CONTACT_ID + " = " + contactId, null, null);
> if (!c.moveToFirst())
> { this.callbackContext.error("Error occured while retrieving contact raw
> id"); return; }
> String id = c.getString(c.getColumnIndex(RawContacts._ID));
> c.close();
> try
> { //JSONObject contact = contactAccessor.getContactById(id); JSONObject
> contact = contactAccessor.getContactByRawId(id);
> this.callbackContext.success(contact); return; }
> catch (JSONException e)
> { Log.e(LOG_TAG, "JSON fail.", e); }
> } else if (resultCode == Activity.RESULT_CANCELED)
> { this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.NO_RESULT, UNKNOWN_ERROR)); return; }
> this.callbackContext.sendPluginResult(new
> PluginResult(PluginResult.Status.ERROR, UNKNOWN_ERROR));
> }
> }
> {code}
> Please let me know if this is correct or are we missing something
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6979) CDVContact : ExtractPhotos creating replica photos
[ https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028669#comment-15028669 ] ASF GitHub Bot commented on CB-6979: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/89 CB-6979 Don't create duplicates for extracted contacts photos Fix for [CB-6979](https://issues.apache.org/jira/browse/CB-6979) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-6979 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit 9df4809abe1b2d1ad04031e5a02a046757b20947 Author: Vladimir Kotikov Date: 2015-11-26T12:21:57Z CB-6979 Don't create duplicates for extracted contacts photos > CDVContact : ExtractPhotos creating replica photos > --- > > Key: CB-6979 > URL: https://issues.apache.org/jira/browse/CB-6979 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS >Reporter: Geetha >Assignee: Vladimir Kotikov >Priority: Minor > Labels: iOS, triaged > > When we try to get the contacts from the Addressbook , in CDVContact in the > extractPhotos method , the photos are extracted and stroed in the tmp folder. > But duplicates of photos have created in tm because everytime the photo URL > is been a new one thus creating a photo and increasing the memory consumption > of the app. We ve found that app memory usage piles up when we try to load > the more no of contacts which leads to low memory warning to the app and > thus killed by the OS. > This is the observation we found , Please let us know if we can do some > alternative. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-6979) CDVContact : ExtractPhotos creating replica photos
[ https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov reassigned CB-6979: Assignee: Vladimir Kotikov > CDVContact : ExtractPhotos creating replica photos > --- > > Key: CB-6979 > URL: https://issues.apache.org/jira/browse/CB-6979 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS >Reporter: Geetha >Assignee: Vladimir Kotikov >Priority: Minor > Labels: iOS, triaged > > When we try to get the contacts from the Addressbook , in CDVContact in the > extractPhotos method , the photos are extracted and stroed in the tmp folder. > But duplicates of photos have created in tm because everytime the photo URL > is been a new one thus creating a photo and increasing the memory consumption > of the app. We ve found that app memory usage piles up when we try to load > the more no of contacts which leads to low memory warning to the app and > thus killed by the OS. > This is the observation we found , Please let us know if we can do some > alternative. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-6979) CDVContact : ExtractPhotos creating replica photos
[ https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-6979: - Priority: Minor (was: Major) > CDVContact : ExtractPhotos creating replica photos > --- > > Key: CB-6979 > URL: https://issues.apache.org/jira/browse/CB-6979 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS >Reporter: Geetha >Priority: Minor > Labels: iOS, triaged > > When we try to get the contacts from the Addressbook , in CDVContact in the > extractPhotos method , the photos are extracted and stroed in the tmp folder. > But duplicates of photos have created in tm because everytime the photo URL > is been a new one thus creating a photo and increasing the memory consumption > of the app. We ve found that app memory usage piles up when we try to load > the more no of contacts which leads to low memory warning to the app and > thus killed by the OS. > This is the observation we found , Please let us know if we can do some > alternative. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-6979) CDVContact : ExtractPhotos creating replica photos
[ https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-6979: - Labels: iOS triaged (was: ) > CDVContact : ExtractPhotos creating replica photos > --- > > Key: CB-6979 > URL: https://issues.apache.org/jira/browse/CB-6979 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS >Reporter: Geetha >Priority: Minor > Labels: iOS, triaged > > When we try to get the contacts from the Addressbook , in CDVContact in the > extractPhotos method , the photos are extracted and stroed in the tmp folder. > But duplicates of photos have created in tm because everytime the photo URL > is been a new one thus creating a photo and increasing the memory consumption > of the app. We ve found that app memory usage piles up when we try to load > the more no of contacts which leads to low memory warning to the app and > thus killed by the OS. > This is the observation we found , Please let us know if we can do some > alternative. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9348) Unable to get linked contact's phone number, while using pickContact
[ https://issues.apache.org/jira/browse/CB-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028579#comment-15028579 ] ASF GitHub Bot commented on CB-9348: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/88 CB-9348 Fetch phoneNumbers and emails from linked contacts too This fixes [CB-9348](https://issues.apache.org/jira/browse/CB-9348). The idea here is to fetch `phoneNumbers` (and other `MultiValue`'s) from linked contacts as well as from picked (unified) one. These items from linked contacts then marked with `id = -1` and do not saved, when `contact.save` is called for 'unified' contact. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-9348 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit d6c09502c572571ca95a09943202f92a598cd7a4 Author: Vladimir Kotikov Date: 2015-11-26T08:25:40Z CB-9348 Fetch phoneNumbers and emails from linked contacts too > Unable to get linked contact's phone number, while using pickContact > > > Key: CB-9348 > URL: https://issues.apache.org/jira/browse/CB-9348 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 1.1.0 >Reporter: Dipanjan Chakraborty >Assignee: Vladimir Kotikov > Labels: linked-contacts, reproduced, triaged > > using cordova v5.1.1 and contacts plugin v1.1.0 > we are unable to fetch the mobile numbers from the phonebook especially if > there are contacts linked. > example: > the main contact is > Name: John Doe > mobile: 99 > the linked G+ contact is > Name J.Doe > mobile: 88 > When fetching the contact using pickContact , it does not fetch either phone > numbers. however, the name of the secondary (J.Doe) is fetched . > Appreciate any help on this issue. > Thanks in advance. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[ https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-3950: - Affects Version/s: (was: 2.7.0) > Custom labels are removed when a contact is saved on iOS. > - > > Key: CB-3950 > URL: https://issues.apache.org/jira/browse/CB-3950 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS >Reporter: Olivier Louvignes > Labels: contacts, ios, reproduced, triaged > > When I update an existing contact that has some custom labels (like > "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do > not touch the "phoneNumbers" array. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[ https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-3950: - Environment: iOS Cordova 2.7.0 was:iOS > Custom labels are removed when a contact is saved on iOS. > - > > Key: CB-3950 > URL: https://issues.apache.org/jira/browse/CB-3950 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: iOS > Cordova 2.7.0 >Reporter: Olivier Louvignes > Labels: contacts, ios, reproduced, triaged > > When I update an existing contact that has some custom labels (like > "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do > not touch the "phoneNumbers" array. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-3950) Custom labels are removed when a contact is saved on iOS.
[ https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-3950: - Labels: contacts ios reproduced triaged (was: contacts ios) > Custom labels are removed when a contact is saved on iOS. > - > > Key: CB-3950 > URL: https://issues.apache.org/jira/browse/CB-3950 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 2.7.0 > Environment: iOS >Reporter: Olivier Louvignes > Labels: contacts, ios, reproduced, triaged > > When I update an existing contact that has some custom labels (like > "BlackBerry", "iPhone"), theses labels are replaced by "other" even if I do > not touch the "phoneNumbers" array. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-2422) iOS 6 Facebook Linked Contact Problem.
[ https://issues.apache.org/jira/browse/CB-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028562#comment-15028562 ] Vladimir Kotikov commented on CB-2422: -- [~themil], wonder if this still actual? From what i see you are running into a problem, similar to CB-10010 and CB-9629. I'm going to close this. Feel free to reopen if the problem is still there. > iOS 6 Facebook Linked Contact Problem. > -- > > Key: CB-2422 > URL: https://issues.apache.org/jira/browse/CB-2422 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: Present on iOS 6. > I'm using Phonegap 2.2.0. >Reporter: Michael Marchment > Labels: contacts, facebook, ios, ios6 > > I've just written an app that uses the (undocumented) > "navigator.contacts.chooseContact", which when a contact was selected, would > pull their id, displayName & phoneNumbers and arrange them nicely into a > table -- BUT! I started to realise that I wasn't adding every contact. > "console.log(contacts.length + " contact(s) found");" would tell me a contact > was there and that there is a contact being chosen, it just (for whatever > reason) chooses to ignore the phone numbers and spit out an error. If I > remove "for (var j=0; j reference to calling, say, "contactsPhoneNumber = > contacts[i].phoneNumbers[j].value;" and calling "contactsPhoneNumber", the > function will work! (Code is identical to that in the Phonegap documentation) > The issue happens when a contact is automatically linked with Facebook. > Facebook doesn't always syc phone numbers to the contact as some people don't > put them up, but it will syc it with contacts with matching names to friends > in your address book. > For instance, my sister's name is Jessica in my address book but her Facebook > name is Jesska so there are 2 contacts in my address book. Phonegap will only > insert Jessica, not Jesska even though both have the same phone number. > Using native code is not my forte, so I thought I might just bring this up > here and see if people are having troubles with phone numbers when doing the > same thing and perhaps someone who knows native code well could come up with > a solution for the next release of Phonegap... If you follow :) > Thanks all, > Michael. > Update: After writing all of this out and double checking to see if it > worked, iOS put back in all of the facebook info. I just deleted the linked > facebook contact permanently and it worked for that contact again. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-2422) iOS 6 Facebook Linked Contact Problem.
[ https://issues.apache.org/jira/browse/CB-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov closed CB-2422. Resolution: Cannot Reproduce Assignee: Vladimir Kotikov > iOS 6 Facebook Linked Contact Problem. > -- > > Key: CB-2422 > URL: https://issues.apache.org/jira/browse/CB-2422 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: Present on iOS 6. > I'm using Phonegap 2.2.0. >Reporter: Michael Marchment >Assignee: Vladimir Kotikov > Labels: contacts, facebook, ios, ios6 > > I've just written an app that uses the (undocumented) > "navigator.contacts.chooseContact", which when a contact was selected, would > pull their id, displayName & phoneNumbers and arrange them nicely into a > table -- BUT! I started to realise that I wasn't adding every contact. > "console.log(contacts.length + " contact(s) found");" would tell me a contact > was there and that there is a contact being chosen, it just (for whatever > reason) chooses to ignore the phone numbers and spit out an error. If I > remove "for (var j=0; j reference to calling, say, "contactsPhoneNumber = > contacts[i].phoneNumbers[j].value;" and calling "contactsPhoneNumber", the > function will work! (Code is identical to that in the Phonegap documentation) > The issue happens when a contact is automatically linked with Facebook. > Facebook doesn't always syc phone numbers to the contact as some people don't > put them up, but it will syc it with contacts with matching names to friends > in your address book. > For instance, my sister's name is Jessica in my address book but her Facebook > name is Jesska so there are 2 contacts in my address book. Phonegap will only > insert Jessica, not Jesska even though both have the same phone number. > Using native code is not my forte, so I thought I might just bring this up > here and see if people are having troubles with phone numbers when doing the > same thing and perhaps someone who knows native code well could come up with > a solution for the next release of Phonegap... If you follow :) > Thanks all, > Michael. > Update: After writing all of this out and double checking to see if it > worked, iOS put back in all of the facebook info. I just deleted the linked > facebook contact permanently and it worked for that contact again. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10091) Android Application not getting approved
Venkatesh created CB-10091: -- Summary: Android Application not getting approved Key: CB-10091 URL: https://issues.apache.org/jira/browse/CB-10091 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 5.0.1 Environment: Our app continuously getting rejected. I have updated the latest version of cordova and also tried to upload a version using cordova 3.6.1 version but still the app getting rejected continuously. Please help me to sort out this issue. Reporter: Venkatesh Fix For: 5.0.1 This app uses software that contains security vulnerabilities for users. Below is the list of vulnerabilities and the corresponding APK versions that were detected in your recent submission. Please upgrade your app(s) as soon as possible and increment the version number of the upgraded APK. Vulnerability APK Version(s) Apache Cordova The vulnerabilities were fixed in Apache Cordova v.3.5.1. For more information about the vulnerabilities, and for guidance on upgrading Apache Cordova, please seehttps://cordova.apache.org/announcements/2014/08/04/android-351.html. For other technical questions about Apache Cordova, please post to Stack Overflow and use the tags "android-security" and "cordova." 8 To confirm you’ve upgraded correctly, submit the updated version of your app to the Developer Console and check back after five hours to make sure the warning is gone. While these vulnerabilities may not affect every app that uses this software, it’s best to stay up to date on all security patches. Make sure to update any libraries in your app that have known security issues, even if you're not sure the issues are relevant to your app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-9348) Unable to get linked contact's phone number, while using pickContact
[ https://issues.apache.org/jira/browse/CB-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov reassigned CB-9348: Assignee: Vladimir Kotikov > Unable to get linked contact's phone number, while using pickContact > > > Key: CB-9348 > URL: https://issues.apache.org/jira/browse/CB-9348 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 1.1.0 >Reporter: Dipanjan Chakraborty >Assignee: Vladimir Kotikov > Labels: linked-contacts, reproduced, triaged > > using cordova v5.1.1 and contacts plugin v1.1.0 > we are unable to fetch the mobile numbers from the phonebook especially if > there are contacts linked. > example: > the main contact is > Name: John Doe > mobile: 99 > the linked G+ contact is > Name J.Doe > mobile: 88 > When fetching the contact using pickContact , it does not fetch either phone > numbers. however, the name of the secondary (J.Doe) is fetched . > Appreciate any help on this issue. > Thanks in advance. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9348) Unable to get linked contact's phone number, while using pickContact
[ https://issues.apache.org/jira/browse/CB-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028488#comment-15028488 ] Vladimir Kotikov commented on CB-9348: -- [~steven.patrick.elli...@gmail.com], from deep inspection, this is not related to permissions problem. Even if permission is granted to application to access contacts, there is no implementation for getting linked contacs properties for iOS. > Unable to get linked contact's phone number, while using pickContact > > > Key: CB-9348 > URL: https://issues.apache.org/jira/browse/CB-9348 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 1.1.0 >Reporter: Dipanjan Chakraborty > Labels: linked-contacts, reproduced, triaged > > using cordova v5.1.1 and contacts plugin v1.1.0 > we are unable to fetch the mobile numbers from the phonebook especially if > there are contacts linked. > example: > the main contact is > Name: John Doe > mobile: 99 > the linked G+ contact is > Name J.Doe > mobile: 88 > When fetching the contact using pickContact , it does not fetch either phone > numbers. however, the name of the secondary (J.Doe) is fetched . > Appreciate any help on this issue. > Thanks in advance. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10079) Splashscreen plugin does not honor SplashScreenDelay on iOS
[ https://issues.apache.org/jira/browse/CB-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028471#comment-15028471 ] ASF GitHub Bot commented on CB-10079: - GitHub user theju opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/64 Use the SplashScreenDelay on iOS Refs https://issues.apache.org/jira/browse/CB-10079 You can merge this pull request into a Git repository by running: $ git pull https://github.com/theju/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 2ae2c42ab8ed8deb5376a08d0de1df29e65d514b Author: Thejaswi Puthraya Date: 2015-11-26T10:12:25Z Use the SplashScreenDelay on iOS > Splashscreen plugin does not honor SplashScreenDelay on iOS > --- > > Key: CB-10079 > URL: https://issues.apache.org/jira/browse/CB-10079 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Affects Versions: 3.5.0 > Environment: iOS >Reporter: Thejaswi Puthraya > > Supposing I want to have the splashscreen display for larger than the default > of 2.5s, changing the `SplashScreenDelay` (to say 10 seconds) in the > config.xml does not work for iOS. > There is no place where the `SplashScreenDelay` is referenced in [1]. > [1] > https://github.com/apache/cordova-plugin-splashscreen/blob/master/src/ios/CDVSplashScreen.m -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10090) How to load Local URLs with access to Cordova files
ajay created CB-10090: - Summary: How to load Local URLs with access to Cordova files Key: CB-10090 URL: https://issues.apache.org/jira/browse/CB-10090 Project: Apache Cordova Issue Type: New Feature Reporter: ajay I want to create a Ionic view kind of application so I want to know how can I load the local www folder with cordova support in INAPPBrowser plugin -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10078) With iPad Pro the wrong userAgent (iPhone) will be saved
[
https://issues.apache.org/jira/browse/CB-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Hemker updated CB-10078:
--
Description:
Using UIWebView on an iPad Pro (iOS 9.1) gives you a wrong userAgent, because
it says its an iPhone.
You can reproduce this behavior with the iPad Pro device and with the iPad Pro
simulator. In both cases the userAgent is:
{noformat}
mozilla/5.0 (iphone; cpu iphone os 9_1 like mac os x) applewebkit/601.1.46
(khtml, like gecko) mobile/13b137
{noformat}
This seems to be a known bug with iOS 9.1 on the iPad Pro because it is fixed
with iOS 9.2 beta 4 and you are getting the right userAgent.
If you clean install your app, everything works fine on iOS 9.2 beta 4. But if
you update your previously installed app, you are still getting the wrong
userAgent because the CDVUserAgentUtil uses the cached userAgent.
For users it is not possible to clean install the app, because in that case the
whole configuration would get lost. To get the right userAgent every time,
developers must have the option to disable the caching of the userAgent in
their apps.
was:
Using UIWebView on an iPad Pro (iOS 9.1) gives you a wrong userAgent, because
is says its an iPhone.
The iPad Pro Simulator 9.1 (Xcode 7.1.1) gives you this iPhone userAgent:
{noformat}
mozilla/5.0 (iphone; cpu iphone os 9_1 like mac os x) applewebkit/601.1.46
(khtml, like gecko) mobile/13b137
{noformat}
Same happens for the userAgent on iPad Pro.
This seems to be a known bug with iOS 9.1 on the iPad Pro because it is fixed
with iOS 9.2 beta 4.. Then you get the correct iPad UserAgent.
If you install an iOS app that is build with iOS (8.4) on an iPad Pro (iOS
9.1/9.2 beta 4) the iPhone userAgent will be used inside the cordova app.
In this case calling the method originalUserAgent from CDVUserAgentUtil the
userAgent „…iPhone…“ is cached inside the app.
The problem is, that if you install an cordova app update for iOS 9.1, the
CDVUserAgentUtil uses the cached „…iPhone…“ userAgent
instead of the corrected userAgent „…iPad..“ that is fixed with iOS 9.2 beta 4.
How do we get the correct userAgent in case of an app update for the
originalUserAgent?
If you install the same cordova app build with iOS 9.2 on the iPad Pro (iOS 9.2
beta 4) the userAgent iPad is used.
> With iPad Pro the wrong userAgent (iPhone) will be saved
>
>
> Key: CB-10078
> URL: https://issues.apache.org/jira/browse/CB-10078
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: Master, 3.6.3
> Environment: iPad Pro
> iOS 9.1
>Reporter: Christian Hemker
>
> Using UIWebView on an iPad Pro (iOS 9.1) gives you a wrong userAgent, because
> it says its an iPhone.
> You can reproduce this behavior with the iPad Pro device and with the iPad
> Pro simulator. In both cases the userAgent is:
> {noformat}
> mozilla/5.0 (iphone; cpu iphone os 9_1 like mac os x) applewebkit/601.1.46
> (khtml, like gecko) mobile/13b137
> {noformat}
> This seems to be a known bug with iOS 9.1 on the iPad Pro because it is fixed
> with iOS 9.2 beta 4 and you are getting the right userAgent.
> If you clean install your app, everything works fine on iOS 9.2 beta 4. But
> if you update your previously installed app, you are still getting the wrong
> userAgent because the CDVUserAgentUtil uses the cached userAgent.
> For users it is not possible to clean install the app, because in that case
> the whole configuration would get lost. To get the right userAgent every
> time, developers must have the option to disable the caching of the userAgent
> in their apps.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Reopened] (CB-9945) Geolocation plugin not working in Android 6.0 emulator
[
https://issues.apache.org/jira/browse/CB-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Alden reopened CB-9945:
This issue is still occurring with the latest cordova-android (5.1.0-dev) and
cordova-plugin-geolocation (2.0.0).
See this screen capture video illustrating the issue:
http://ge.tt/api/1/files/3NdclVS2/0/blob?download
I've updated the project in the bitbucket repo with these versions. The result
still the same: requesting location causes emulator to reboot with exception:
java.lang.IllegalArgumentException: provider doesn't exist: network
Is this likely to be an Android issue rather than a Cordova issue?
> Geolocation plugin not working in Android 6.0 emulator
> --
>
> Key: CB-9945
> URL: https://issues.apache.org/jira/browse/CB-9945
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Geolocation
> Environment: AVD Android 6.0
> Genymotion Android 6.0 PREVIEW
>Reporter: Dave Alden
>
> Calling the Cordova geolocation API in an Android emulator environment causes
> the Android OS to crash and reboot.
> The issue is reproducible with Cordova geolocation plugin from npm release
> version 1.0.1 and latest version on master branch 1.0.2-dev.
> Steps to reproduce:
> Use the Cordova geolocation API to request a location in Android 6.0 emulator
> environment:
> navigator.geolocation.getCurrentPosition(onPosition, onPositionError, {
> maxAge: 0,
> timeout: 1,
> enableHighAccuracy: false
> });
>
> OR clone the bitbucket repo
> https://bitbucket.org/dpa99c/android-m-location-test/src, build and run
> OR install and run the pre-built APK for that project:
> https://bitbucket.org/dpa99c/android-m-location-test/raw/9a836ca3e3185db55fa75b263a4abbb76b4713ea/android-debug.apk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10078) With iPad Pro the wrong userAgent (iPhone) will be saved
[
https://issues.apache.org/jira/browse/CB-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Hemker updated CB-10078:
--
Description:
Using UIWebView on an iPad Pro (iOS 9.1) gives you a wrong userAgent, because
is says its an iPhone.
The iPad Pro Simulator 9.1 (Xcode 7.1.1) gives you this iPhone userAgent:
{noformat}
mozilla/5.0 (iphone; cpu iphone os 9_1 like mac os x) applewebkit/601.1.46
(khtml, like gecko) mobile/13b137
{noformat}
Same happens for the userAgent on iPad Pro.
This seems to be a known bug with iOS 9.1 on the iPad Pro because it is fixed
with iOS 9.2 beta 4.. Then you get the correct iPad UserAgent.
If you install an iOS app that is build with iOS (8.4) on an iPad Pro (iOS
9.1/9.2 beta 4) the iPhone userAgent will be used inside the cordova app.
In this case calling the method originalUserAgent from CDVUserAgentUtil the
userAgent „…iPhone…“ is cached inside the app.
The problem is, that if you install an cordova app update for iOS 9.1, the
CDVUserAgentUtil uses the cached „…iPhone…“ userAgent
instead of the corrected userAgent „…iPad..“ that is fixed with iOS 9.2 beta 4.
How do we get the correct userAgent in case of an app update for the
originalUserAgent?
If you install the same cordova app build with iOS 9.2 on the iPad Pro (iOS 9.2
beta 4) the userAgent iPad is used.
was:
Using UIWebView on an iPad Pro (iOS 9.1) gives you a wrong userAgent, because
is says its an iPhone.
The iPad Pro Simulator 9.1 gives you this iPhone userAgent:
{noformat}
mozilla/5.0 (iphone; cpu iphone os 9_1 like mac os x) applewebkit/601.1.46
(khtml, like gecko) mobile/13b137
{noformat}
Same happens for the userAgent on iPad Pro device.
This seems is a known bug with iOS 9.1 on the Pro, while this is fixed with iOS
9.2 beta 4. Then you get the correct iPad UserAgent.
If you install an iOS app that is build with iOS (8.4) on an iPad Pro (iOS
9.1/9.2 beta 4) the iPhone userAgent will be used inside the cordova app.
In this case inside the method originalUserAgent from CDVUserAgentUtil the
userAgent „…iPhone…“ is cached inside the app.
The problem is, that if you install an cordova app update for iOS 9.1, the
CDVUserAgentUtil uses the cached „…iPhone…“ userAgent
instead of the corrected userAgent „…iPad..“ that is fixed with iOS 9.2 beta 4.
How is it possible not to use the cached value originalUserAgent because in
this cases thats wrong?
If you install the same cordova app build with iOS 9.2 on the iPad Pro (iOS 9.2
beta 4) the userAgent iPad is used.
> With iPad Pro the wrong userAgent (iPhone) will be saved
>
>
> Key: CB-10078
> URL: https://issues.apache.org/jira/browse/CB-10078
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: Master, 3.6.3
> Environment: iPad Pro
> iOS 9.1
>Reporter: Christian Hemker
>
> Using UIWebView on an iPad Pro (iOS 9.1) gives you a wrong userAgent, because
> is says its an iPhone.
> The iPad Pro Simulator 9.1 (Xcode 7.1.1) gives you this iPhone userAgent:
> {noformat}
> mozilla/5.0 (iphone; cpu iphone os 9_1 like mac os x) applewebkit/601.1.46
> (khtml, like gecko) mobile/13b137
> {noformat}
> Same happens for the userAgent on iPad Pro.
> This seems to be a known bug with iOS 9.1 on the iPad Pro because it is fixed
> with iOS 9.2 beta 4.. Then you get the correct iPad UserAgent.
> If you install an iOS app that is build with iOS (8.4) on an iPad Pro (iOS
> 9.1/9.2 beta 4) the iPhone userAgent will be used inside the cordova app.
> In this case calling the method originalUserAgent from CDVUserAgentUtil the
> userAgent „…iPhone…“ is cached inside the app.
> The problem is, that if you install an cordova app update for iOS 9.1, the
> CDVUserAgentUtil uses the cached „…iPhone…“ userAgent
> instead of the corrected userAgent „…iPad..“ that is fixed with iOS 9.2 beta
> 4.
> How do we get the correct userAgent in case of an app update for the
> originalUserAgent?
> If you install the same cordova app build with iOS 9.2 on the iPad Pro (iOS
> 9.2 beta 4) the userAgent iPad is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
