[jira] [Commented] (CB-10281) Allow CORS
[
https://issues.apache.org/jira/browse/CB-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075771#comment-15075771
]
ASF GitHub Bot commented on CB-10281:
-
Github user pmuellr commented on the pull request:
https://github.com/apache/cordova-weinre/pull/10#issuecomment-168134161
conversation for this PR happening on the issue -
https://issues.apache.org/jira/browse/CB-10281
> Allow CORS
> --
>
> Key: CB-10281
> URL: https://issues.apache.org/jira/browse/CB-10281
> Project: Apache Cordova
> Issue Type: New Feature
> Components: weinre
>Affects Versions: 3.5.0
>Reporter: Miquel
>Assignee: Patrick Mueller
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: Master
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> I've created a pull request to allow CORS:
> https://github.com/apache/cordova-weinre/pull/10:
> {noformat}
> diff --git a/weinre.server/lib/weinre.js b/weinre.server/lib/weinre.js
> index a4ca11c..036df78 100644
> --- a/weinre.server/lib/weinre.js
> +++ b/weinre.server/lib/weinre.js
> @@ -133,6 +133,11 @@ startServer = function() {
>});
>app.use(express.favicon(favIcon));
>app.use(jsonBodyParser());
> + app.use(function(req, res, next) {
> +res.header("Access-Control-Allow-Origin", "*");
> +res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With,
> Content-Type, Accept");
> +next();
> + });
>app.all(/^\/ws\/client(.*)/, function(request, response, next) {
> var uri;
> uri = request.params[0];
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9538) Implementing FadeSplashScreen feature for Android
[ https://issues.apache.org/jira/browse/CB-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075553#comment-15075553 ] ASF GitHub Bot commented on CB-9538: Github user trancee commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/73#issuecomment-168099920 Looks good, thank you for updating and cleaning this up :) > Implementing FadeSplashScreen feature for Android > - > > Key: CB-9538 > URL: https://issues.apache.org/jira/browse/CB-9538 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, Plugin SplashScreen >Reporter: Philipp Grosswiler >Priority: Minor > > Implementing FadeSplashScreen preference by using AlphaAnimation to fade out > the ImageView. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10283) Displays white bar at the bottom of the android app.
Devshi Patel created CB-10283:
-
Summary: Displays white bar at the bottom of the android app.
Key: CB-10283
URL: https://issues.apache.org/jira/browse/CB-10283
Project: Apache Cordova
Issue Type: Bug
Components: Android, CordovaLib
Affects Versions: 5.3.3
Environment: Cordova cli 5.3.9 and Cordova 4.1.1
Android Sumsung s6 (v5.0)
jquery.mobile-1.4.5.min.js
Reporter: Devshi Patel
When the app starts it displays a white bar at the bottom of the screen like a
status bar. This happens frequently but not always.
I have been using Cordova cli 4.2 & Cordova 4.0 without any problems. the app
is on google play store.
I am using jquery mobile framework version 1.4.5
I think the issue is with webview display.
The code for MainActivity.java file
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
super.loadUrl("file:///android_asset/www/index.html");
new SimpleEula(this).show();
}
index.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7786) Support mediaPlaybackRequiresUserAction on Android
[ https://issues.apache.org/jira/browse/CB-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075335#comment-15075335 ] ASF GitHub Bot commented on CB-7786: GitHub user seank-com opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/132 CB-7786 android: add new param - param has same name and default as iOS - setting is conditionally gated the same way as CordovaLib/src/org/apache/cordova/engine/SystemWebViewEngine.java - updated manual video tests - updated docs in README.md - added notes and steps for running plugin tests to CONTRIBUTING.md - I'm not neuortic, atom removed uneeded whitespace automatically You can merge this pull request into a Git repository by running: $ git pull https://github.com/seank-com/cordova-plugin-inappbrowser CB-7786 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit 69e051f1b69ff32f83ff1786073b6402753de5f7 Author: Sean Kelly Date: 2015-12-30T19:02:52Z CB-7786 android: add new param - param has same name and default as iOS - setting is conditionally gated the same way as CordovaLib/src/org/apache/cordova/engine/SystemWebViewEngine.java - updated manual video tests - updated docs in README.md - added notes and steps for running plugin tests to CONTRIBUTING.md - I'm not neuortic, atom removed uneeded whitespace automatically > Support mediaPlaybackRequiresUserAction on Android > -- > > Key: CB-7786 > URL: https://issues.apache.org/jira/browse/CB-7786 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin InAppBrowser >Reporter: Mike Dawson > > The In App Browser in Android after API Version 17 (Android 4.2+ I believe) > by default does not permit playback of audio and video elements unless > triggered by a user event (blocks both autoplay and playing via Javascript). > That's the same behaviour as iOS. I have forked Inappbrowser and written a > patch for the Android version here that respects this feature (same parameter > name as for iOS): > https://github.com/UstadMobile/cordova-plugin-inappbrowser/ > Reading the contributors page I believe I need to send/sign the agreement and > I need to add unit tests to cover this. I'm not familiar with the Cordova > testing framework so might take me a bit of time to do that, or perhaps > someone can add an appropriate test? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10282) Documentation issue - "Supported Platforms" doesn't mention iOS
Michael Stanford created CB-10282: - Summary: Documentation issue - "Supported Platforms" doesn't mention iOS Key: CB-10282 URL: https://issues.apache.org/jira/browse/CB-10282 Project: Apache Cordova Issue Type: Improvement Components: Plugin Whitelist Affects Versions: 3.5.0 Environment: All Reporter: Michael Stanford Priority: Minor The documentation (at https://www.npmjs.com/package/cordova-plugin-whitelist) appears to claim only Android is supported: "Supported Cordova Platforms Android 4.0.0 or above" The warning when you add this plugin to your project also appears to indicate that this plugin is not needed on iOS: "This plugin is only applicable for versions of cordova-android greater than 4.0." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10281) Allow CORS
[
https://issues.apache.org/jira/browse/CB-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075280#comment-15075280
]
Patrick Mueller commented on CB-10281:
--
Thanks for the PR. Coupla things:
* the source is CoffeeScript; the original source location of your modification
is here:
https://github.com/apache/cordova-weinre/blob/master/weinre.server/lib-src/weinre.coffee#L139
* weinre already handles CORS requests for things that CORS requests are
absolutely required for; see:
https://github.com/apache/cordova-weinre/blob/master/weinre.server/lib-src/HttpChannelHandler.coffee#L46
and
https://github.com/apache/cordova-weinre/blob/master/weinre.server/lib-src/HttpChannelHandler.coffee#L141
So, not sure what this patch would do - presumably allow downloading of the
weinre static resources via CORS - the existing code just handles XHR requests
via CORS. Is there some reason you need this?
> Allow CORS
> --
>
> Key: CB-10281
> URL: https://issues.apache.org/jira/browse/CB-10281
> Project: Apache Cordova
> Issue Type: New Feature
> Components: weinre
>Affects Versions: 3.5.0
>Reporter: Miquel
>Assignee: Patrick Mueller
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: Master
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> I've created a pull request to allow CORS:
> https://github.com/apache/cordova-weinre/pull/10:
> {noformat}
> diff --git a/weinre.server/lib/weinre.js b/weinre.server/lib/weinre.js
> index a4ca11c..036df78 100644
> --- a/weinre.server/lib/weinre.js
> +++ b/weinre.server/lib/weinre.js
> @@ -133,6 +133,11 @@ startServer = function() {
>});
>app.use(express.favicon(favIcon));
>app.use(jsonBodyParser());
> + app.use(function(req, res, next) {
> +res.header("Access-Control-Allow-Origin", "*");
> +res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With,
> Content-Type, Accept");
> +next();
> + });
>app.all(/^\/ws\/client(.*)/, function(request, response, next) {
> var uri;
> uri = request.params[0];
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10274) plugman ignores --www parameter
[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075184#comment-15075184
]
ASF GitHub Bot commented on CB-10274:
-
Github user bradleyjames commented on the pull request:
https://github.com/apache/cordova-lib/pull/360#issuecomment-168031644
Noticed that uninstall suffers from the same issue. I'll address that at
some point in the future (if I find the time and need).
> plugman ignores --www parameter
> ---
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add ..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10274) plugman ignores --www parameter
[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075183#comment-15075183
]
ASF GitHub Bot commented on CB-10274:
-
GitHub user bradleyjames opened a pull request:
https://github.com/apache/cordova-lib/pull/360
[CB-10274] Make www directory the default for plugman.
New patch that addresses comments made here:
https://github.com/apache/cordova-lib/pull/359.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bradleyjames/cordova-lib cb-10274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/360.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #360
commit d2ade703bfb48fe5790b8f440b5782b7f758ba47
Author: Brad Reynolds
Date: 2015-12-30T15:26:56Z
[CB-10274] Make www directory the default for plugman.
> plugman ignores --www parameter
> ---
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add ..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9538) Implementing FadeSplashScreen feature for Android
[ https://issues.apache.org/jira/browse/CB-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075132#comment-15075132 ] ASF GitHub Bot commented on CB-9538: Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-168023487 @trancee, I've updated this PR in #73 - please take a look. > Implementing FadeSplashScreen feature for Android > - > > Key: CB-9538 > URL: https://issues.apache.org/jira/browse/CB-9538 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, Plugin SplashScreen >Reporter: Philipp Grosswiler >Priority: Minor > > Implementing FadeSplashScreen preference by using AlphaAnimation to fade out > the ImageView. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9538) Implementing FadeSplashScreen feature for Android
[ https://issues.apache.org/jira/browse/CB-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075077#comment-15075077 ] ASF GitHub Bot commented on CB-9538: GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/73 CB-9538 Implementing FadeSplashScreen feature for Android FadeSplashScreen is supported by using AlphaAnimation to fade out the ImageView. Based on #71 [Jira issue](https://issues.apache.org/jira/browse/CB-9538) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-9538 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 694edf2be8174fdadf5183cdc38fc10af27b7237 Author: Philipp Grosswiler Date: 2015-08-06T09:29:41Z Added support for FadeSplashScreen. commit 8bd92ca017268b8b2b8fa67b93238e899dbd4a57 Author: Philipp Grosswiler Date: 2015-08-07T02:23:11Z Added DecelerateInterpolator for smoother fading experience. commit e724b16ba0a354d12abbec23b705a8bb13f52210 Author: Philipp Grosswiler Date: 2015-08-07T15:31:16Z Fixed reading preference as Float instead of Integer (thanks to spiritax for pointing this out). commit 1bfcd9239dca8c548158726e7acd191f2b185938 Author: daserge Date: 2015-12-30T14:38:33Z CB-9538 Implementing FadeSplashScreen feature for Android Refactoring, adds support of seconds for fade duration for backward compatibility Includes fade duration into overall splashscreen duration to be consistent with iOS > Implementing FadeSplashScreen feature for Android > - > > Key: CB-9538 > URL: https://issues.apache.org/jira/browse/CB-9538 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, Plugin SplashScreen >Reporter: Philipp Grosswiler >Priority: Minor > > Implementing FadeSplashScreen preference by using AlphaAnimation to fade out > the ImageView. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10274) plugman ignores --www parameter
[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075060#comment-15075060
]
ASF GitHub Bot commented on CB-10274:
-
Github user bradleyjames commented on the pull request:
https://github.com/apache/cordova-lib/pull/359#issuecomment-168009298
Seems like that will change the default install location for plugman (when
not called from the cordova CLI) from platform_www to www. Is that what you're
wanting?
> plugman ignores --www parameter
> ---
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add ..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10274) plugman ignores --www parameter
[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075048#comment-15075048
]
ASF GitHub Bot commented on CB-10274:
-
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/359#discussion_r48605174
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform,
project_dir, plugins_dir,
events.emit('verbose', 'Install start for "' + pluginInfo.id + '" on '
+ platform + '.');
options.variables = filtered_variables;
-// Set up platform to install asset files/js modules to
/platform_www dir
-// instead of /www. This is required since on each prepare
platform's www dir is changed
-// and files from 'platform_www' merged into 'www'. Thus we need to
persist these
-// files platform_www directory, so they'll be applied to www on each
prepare.
-options.usePlatformWww = true;
+if (!('www_dir' in options) || options.www_dir === undefined) {
--- End diff --
Oops, missed that...
> plugman ignores --www parameter
> ---
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add ..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10274) plugman ignores --www parameter
[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075047#comment-15075047
]
ASF GitHub Bot commented on CB-10274:
-
Github user bradleyjames commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/359#discussion_r48605088
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform,
project_dir, plugins_dir,
events.emit('verbose', 'Install start for "' + pluginInfo.id + '" on '
+ platform + '.');
options.variables = filtered_variables;
-// Set up platform to install asset files/js modules to
/platform_www dir
-// instead of /www. This is required since on each prepare
platform's www dir is changed
-// and files from 'platform_www' merged into 'www'. Thus we need to
persist these
-// files platform_www directory, so they'll be applied to www on each
prepare.
-options.usePlatformWww = true;
+if (!('www_dir' in options) || options.www_dir === undefined) {
--- End diff --
The conversation from --www -> www_dir happens here:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/plugman.js#L107
> plugman ignores --www parameter
> ---
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add ..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8720) Launch Application in Portrait mode up side down. Status bar is coming in down and never recovers
[ https://issues.apache.org/jira/browse/CB-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075006#comment-15075006 ] ASF GitHub Bot commented on CB-8720: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/44 CB-8720 Fix status bar position when app started upside down on iOS 7 https://issues.apache.org/jira/browse/CB-8720 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-statusbar CB-8720 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit c299a14d6019871ab28b76fc1670d0ff4b720f7b Author: Vladimir Kotikov Date: 2015-12-30T07:16:58Z CB-8720 Fix status bar position when app started upside down on iOS 7 > Launch Application in Portrait mode up side down. Status bar is coming in > down and never recovers > - > > Key: CB-8720 > URL: https://issues.apache.org/jira/browse/CB-8720 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.0.0 > Environment: iOS 7 >Reporter: Puneeth Rai >Assignee: Vladimir Kotikov > Labels: iOS, reproduced, triaged > > I've following in config.xml > > > > Status bar plugin version : 0.1.10 > Cordova iOS version : 3.5.0 > iOS version: 7.1 > iPadmini > Launch cordova app in portrait upside down orientation . Status bar band is > appearing at bottom and a white space is shown at actual status bar. This > only happens when application in launched in portrait upside down orientation > and always reproducible.I believe it can be duplicated in all iOS devices, > but I've only iPad mini devices. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9513) Status bar show/hide have no response in Fullsrceen
[
https://issues.apache.org/jira/browse/CB-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074993#comment-15074993
]
ASF GitHub Bot commented on CB-9513:
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/42#issuecomment-167990042
lgtm!
> Status bar show/hide have no response in Fullsrceen
> ---
>
> Key: CB-9513
> URL: https://issues.apache.org/jira/browse/CB-9513
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Statusbar
> Environment: Test Device: Google nexus5
> Cordova-android 4.1
>Reporter: lijingjing
>Assignee: Vladimir Kotikov
> Labels: Android, reproduced, triaged
>
> Test Steps:
> 1.cordova create statusbar com.example.statusbar statusbar
> 2.cordova platform add android
> 3.config.xml-add:
> {code}
>
>
> {code}
> 4.replace index.html:
> {code}
>
>
> Status Bar Test In Fullscreen
> \n
> Click "Status Bar Show" button to show status bar:
> Status Bar Show
> Click "Status Bar Hide" button to hide status bar:
> Status Bar Hide
> {code}
> 5. cordova plugin add cordova-plugin-statusbar.
> 6. cordova build android.
> 7.Then install statusbar.apk on the test device.
> 8.click "status Bar show/hide" button.
> Expected Outcome:
> Status Bar can show or hide.
> Actual Outcome:
> have no response.
> Issue Analysis:
> this issue only happen on Cordova Android 4.1 and Cordova CLI 5.2.If use
> Cordova CLI 5.1,apk can run successfully.
> error log:
> {code}
> V/StatusBar( 4028): Executing action: show
> D/audio_hw_primary( 184): select_devices: out_snd_device(2: speaker)
> in_snd_device(0: )
> W/InputMethodManagerService( 753): Window already focused, ignoring focus
> gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@432d6328
> attribute=null, token = android.os.BinderProxy@42f61a70
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10118) statusbar plugin crashes during startup
[
https://issues.apache.org/jira/browse/CB-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074991#comment-15074991
]
ASF GitHub Bot commented on CB-10118:
-
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/43#issuecomment-167989868
lgtm!
> statusbar plugin crashes during startup
> ---
>
> Key: CB-10118
> URL: https://issues.apache.org/jira/browse/CB-10118
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Statusbar
>Affects Versions: 5.4.1
>Reporter: Marc Luria
>Assignee: Vladimir Kotikov
>Priority: Trivial
> Labels: Browser, reproduced, triaged
> Fix For: 5.4.0
>
>
> During startup, the plugin fails on the lines:
> define = function (id, factory) {
> if (modules[id]) {
> throw "module " + id + " already defined";
> }
> modules[id] = {
> id: id,
> factory: factory
> };
> };
> with the error Uncaught module cordova-plugin-statusbar.statusbar already
> defined
> I've only tested this so far in the browser plugin, partly because it's
> difficult to set a breakpoint in ios or android.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10277) Error callback should be called w/ PositionError when location access is denied
[
https://issues.apache.org/jira/browse/CB-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074972#comment-15074972
]
ASF GitHub Bot commented on CB-10277:
-
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/62#discussion_r48600533
--- Diff: www/android/geolocation.js ---
@@ -52,7 +62,20 @@ module.exports = {
var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
geo.clearWatch(args[0]);
}
-exec(win, error, "Geolocation", "getPermission", []);
+var fail = function() {
+if (error) {
+error(illegalAccessError);
+}
+};
+exec(win, fail, "Geolocation", "getPermission", []);
}
};
+// mimic PositionError to be compliant with W3C spec
+var illegalAccessError = {
--- End diff --
Currently PositionError is not available on Andoroid as we don't include
that file, but I think we can include it and use it - I'll update PR.
> Error callback should be called w/ PositionError when location access is
> denied
> ---
>
> Key: CB-10277
> URL: https://issues.apache.org/jira/browse/CB-10277
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: Andriod, Triaged
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10278) geolocation watchPosition doesn't return watchID string
[
https://issues.apache.org/jira/browse/CB-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074969#comment-15074969
]
ASF GitHub Bot commented on CB-10278:
-
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48600376
--- Diff: www/android/geolocation.js ---
@@ -38,21 +39,29 @@ module.exports = {
},
watchPosition: function(success, error, args) {
+var pluginWatchId = utils.createUUID();
+
var win = function() {
var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
-geo.watchPosition(success, error, {
+pluginToNativeWatchMap[pluginWatchId] =
geo.watchPosition(success, error, {
enableHighAccuracy: args[1]
});
};
exec(win, error, "Geolocation", "getPermission", []);
+
+return pluginWatchId;
},
-clearWatch: function(success, error, args) {
+clearWatch: function(pluginWatchId) {
var win = function() {
- var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
- geo.clearWatch(args[0]);
+var nativeWatchId = pluginToNativeWatchMap[pluginWatchId];
--- End diff --
I tested this case and incorrect value (which does not exist or undefined)
was ignored w/o any error or exception
> geolocation watchPosition doesn't return watchID string
> ---
>
> Key: CB-10278
> URL: https://issues.apache.org/jira/browse/CB-10278
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Geolocation
> Environment: Android 4.4 on samsung galaxy s5.
> Android 5.0 on samsung galaxy s5.
>Reporter: Nicholas Tsaoucis
> Labels: Android, Triaged
>
> With the new version of the geolocation plugin (-r1.0.1- 2.0.0) when calling
> watchPosition no watchID is returned as a string. only undefined is returned.
> This makes it impossible to call clearWatch as we don't have the watchID to
> use in the clearWatch call.
> I rolled back to version -r1.0.0- r1.0.1 and it works properly.
> ~edit
> The issue is actually with the master branch (version 2.0.0)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10192) Native Android Contacts app crashed after creating new contact in Cordova app
[
https://issues.apache.org/jira/browse/CB-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074968#comment-15074968
]
Vladimir Kotikov commented on CB-10192:
---
There is https://github.com/apache/cordova-plugin-contacts/releases/tag/2.0.0,
but you need to specify version explicitly. Also it requires cordova-android >=
5.0.0, so you will need for something like this:
{noformat}
cordova platform rm android
cordova platform add android@5.0.0
cordova plugin add cordova-plugin-contacts@2.0.0
{noformat}
> Native Android Contacts app crashed after creating new contact in Cordova app
> -
>
> Key: CB-10192
> URL: https://issues.apache.org/jira/browse/CB-10192
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
>Affects Versions: 1.1.0
> Environment: Google Nexus 6 Marshmallow
> Cordova : 5.4.0
> Contacts Plugin: 1.1.0
>Reporter: Sumama Waheed
>Assignee: Vladimir Kotikov
> Labels: Android, contact.save, triaged
>
> I successfully create a new contact with minimal fields like First Name and
> Given Name.
> The contact is created successfully and you can see it in the native Android
> contacts app if you scroll to the correct place.
> However, if you search for the new contact by name, it crashes the Contacts
> app every time until you delete that contact !!.
> Cordova : 5.4.0
> Contacts Plugin: 1.1.0
> This is how I am creating the contact:
> {code:javascript}
> var contact = navigator.contacts.create();
> contact.displayName = firstName + " " + lastName;
> contact.nickname = firstName;
> var name = new ContactName();
> name.givenName = firstName;
> name.familyName = lastName;
> contact.name = name;
> var phoneNumbers = [];
> phoneNumbers.push(new ContactField('work', workPhone, false));
> phoneNumbers.push(new ContactField('mobile', mobilePhone, true)); //
> preferred number
> contact.phoneNumbers = phoneNumbers;
> var organizations = [];
> organizations.push(new ContactOrganization(true, "work", "Company",
> "Company", "Supervisor"));
> contact.organizations = organizations;
> contact.save(onSuccess,onError);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10274) plugman ignores --www parameter
[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074959#comment-15074959
]
ASF GitHub Bot commented on CB-10274:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/359#issuecomment-167983975
IMO, better fix this by moving 'usePlatformWww' option setup to cordova-cli
area of responsibility - somewhere around
[src/cordova/plugin.js#L180](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/plugin.js#L180)
- this way you won't need to specify any options to plugman to get desired
result, but cordova-cli will continue to install plugins' JS files to
`platform_www`
> plugman ignores --www parameter
> ---
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add ..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10274) plugman ignores --www parameter
[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074946#comment-15074946
]
ASF GitHub Bot commented on CB-10274:
-
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/359#discussion_r48599256
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform,
project_dir, plugins_dir,
events.emit('verbose', 'Install start for "' + pluginInfo.id + '" on '
+ platform + '.');
options.variables = filtered_variables;
-// Set up platform to install asset files/js modules to
/platform_www dir
-// instead of /www. This is required since on each prepare
platform's www dir is changed
-// and files from 'platform_www' merged into 'www'. Thus we need to
persist these
-// files platform_www directory, so they'll be applied to www on each
prepare.
-options.usePlatformWww = true;
+if (!('www_dir' in options) || options.www_dir === undefined) {
--- End diff --
There is some inconsistency in how this option should be specified: the
[plugman's
README](https://github.com/apache/cordova-plugman/blob/master/README.md#plugin-management)
states that there is `--www` option for plugman cli, [comments in cordova-lib
code](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L68)
metntion `www_dir` option, but there is no code, reponsible for conversion
`--www` -> `www_dir`
> plugman ignores --www parameter
> ---
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add ..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10278) geolocation watchPosition doesn't return watchID string
[
https://issues.apache.org/jira/browse/CB-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074914#comment-15074914
]
ASF GitHub Bot commented on CB-10278:
-
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48596899
--- Diff: www/android/geolocation.js ---
@@ -38,21 +39,29 @@ module.exports = {
},
watchPosition: function(success, error, args) {
+var pluginWatchId = utils.createUUID();
+
var win = function() {
var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
-geo.watchPosition(success, error, {
+pluginToNativeWatchMap[pluginWatchId] =
geo.watchPosition(success, error, {
enableHighAccuracy: args[1]
});
};
exec(win, error, "Geolocation", "getPermission", []);
+
+return pluginWatchId;
},
-clearWatch: function(success, error, args) {
+clearWatch: function(pluginWatchId) {
var win = function() {
- var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
- geo.clearWatch(args[0]);
+var nativeWatchId = pluginToNativeWatchMap[pluginWatchId];
--- End diff --
What will happen if there is no `pluginWatchId` in
`pluginToNativeWatchMap`? How native `geo.clearWatch` will behave if called
with `undefined?`
> geolocation watchPosition doesn't return watchID string
> ---
>
> Key: CB-10278
> URL: https://issues.apache.org/jira/browse/CB-10278
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Geolocation
> Environment: Android 4.4 on samsung galaxy s5.
> Android 5.0 on samsung galaxy s5.
>Reporter: Nicholas Tsaoucis
> Labels: Android, Triaged
>
> With the new version of the geolocation plugin (-r1.0.1- 2.0.0) when calling
> watchPosition no watchID is returned as a string. only undefined is returned.
> This makes it impossible to call clearWatch as we don't have the watchID to
> use in the clearWatch call.
> I rolled back to version -r1.0.0- r1.0.1 and it works properly.
> ~edit
> The issue is actually with the master branch (version 2.0.0)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7146) Port geolocation tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074907#comment-15074907 ] ASF GitHub Bot commented on CB-7146: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/59#issuecomment-167973201 :+1: > Port geolocation tests to plugin-test-framework > --- > > Key: CB-7146 > URL: https://issues.apache.org/jira/browse/CB-7146 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Plugin TestFramework >Reporter: Staci Cooper >Assignee: Staci Cooper >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android
[
https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074906#comment-15074906
]
ASF GitHub Bot commented on CB-10204:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/60#issuecomment-167973027
LGTM
> Fix getCurrentPosition options on Android
> -
>
> Key: CB-10204
> URL: https://issues.apache.org/jira/browse/CB-10204
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
> Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>Reporter: Timo Salola
>Assignee: Sergey Grebnov
> Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In
> getCurrentPosition it does not verify that options are given resulting
> javascript error when trying to access undefined as an array at
> www/android/geolocation.js lines 33 and 34:
> {code:javascript}
> getCurrentPosition: function(success, error, args) {
> var win = function() {
> var geo =
> cordova.require('cordova/modulemapper').getOriginalSymbol(window,
> 'navigator.geolocation');
> geo.getCurrentPosition(success, error, {
> enableHighAccuracy: args[0],
> maximumAge: args[1]
> });
> };
> exec(win, error, "Geolocation", "getPermission", []);
> }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8443) Android: nothing happens if GPS is turned off
[ https://issues.apache.org/jira/browse/CB-8443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074905#comment-15074905 ] ASF GitHub Bot commented on CB-8443: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/61#issuecomment-167972921 LGTM > Android: nothing happens if GPS is turned off > - > > Key: CB-8443 > URL: https://issues.apache.org/jira/browse/CB-8443 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Geolocation >Affects Versions: 3.5.0 > Environment: moto G android 4.4.4 >Reporter: clement bidon > Labels: android, triaged > > to goe the error: disable "ALL LOCATION SERVICE" on the phone. > call "getCurrentPosition" or "watchPosition" functions without any timout. > The "onError" function should be called with > "PositionError.PERMISSION_DENIED" or with > "PositionError.POSITION_UNAVAILABLE", BUT IT S NOT THE CASE: --> nothing > happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10277) Error callback should be called w/ PositionError when location access is denied
[
https://issues.apache.org/jira/browse/CB-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074899#comment-15074899
]
ASF GitHub Bot commented on CB-10277:
-
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/62#discussion_r48596423
--- Diff: www/android/geolocation.js ---
@@ -52,7 +62,20 @@ module.exports = {
var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
geo.clearWatch(args[0]);
}
-exec(win, error, "Geolocation", "getPermission", []);
+var fail = function() {
+if (error) {
+error(illegalAccessError);
+}
+};
+exec(win, fail, "Geolocation", "getPermission", []);
}
};
+// mimic PositionError to be compliant with W3C spec
+var illegalAccessError = {
--- End diff --
Insead of creating custom object, can we reuse [PositionError
polyfill](https://github.com/apache/cordova-plugin-geolocation/blob/master/www/PositionError.js)
here?
> Error callback should be called w/ PositionError when location access is
> denied
> ---
>
> Key: CB-10277
> URL: https://issues.apache.org/jira/browse/CB-10277
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Geolocation
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
> Labels: Andriod, Triaged
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-2845) CompassError, PositionError constants not attached to prototype as specified in W3C document
[
https://issues.apache.org/jira/browse/CB-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074895#comment-15074895
]
ASF GitHub Bot commented on CB-2845:
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167972137
LGTM
> CompassError, PositionError constants not attached to prototype as specified
> in W3C document
>
>
> Key: CB-2845
> URL: https://issues.apache.org/jira/browse/CB-2845
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Device Orientation, Plugin Geolocation
>Affects Versions: 2.5.0, 2.6.0
> Environment: Any
>Reporter: Thomas K.
>Assignee: Sergey Grebnov
> Labels: audit, triaged
>
> CompassError.js PositionError.js do not define the error constants on the
> prototype of the object. Hence the constants are not passed into the error
> function as specified in the W3C document
> http://dev.w3.org/geo/api/spec-source.html#position_error_interface (see:
> interface PositionError { const unsigned short PERMISSION_DENIED = 1; ...)
> Fix: define in the library PositionError.js and Compass.js constants
> additionally like this:
> PositionError.prototype.PERMISSION_DENIED = 1;
> https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/PositionError.js#L34
> https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/CompassError.js#L31
> W3C compatible code is:
> positionError = function(gpsError)
>{
> switch(gpsError.code)
> {
> case gpsError.PERMISSION_DENIED:
> errorMessage = "Access to GPS denied!";
> break;
> ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10281) Allow CORS
Miquel created CB-10281:
---
Summary: Allow CORS
Key: CB-10281
URL: https://issues.apache.org/jira/browse/CB-10281
Project: Apache Cordova
Issue Type: New Feature
Components: weinre
Affects Versions: 3.5.0
Reporter: Miquel
Assignee: Patrick Mueller
Priority: Minor
Fix For: Master
I've created a pull request to allow CORS:
https://github.com/apache/cordova-weinre/pull/10:
{noformat}
diff --git a/weinre.server/lib/weinre.js b/weinre.server/lib/weinre.js
index a4ca11c..036df78 100644
--- a/weinre.server/lib/weinre.js
+++ b/weinre.server/lib/weinre.js
@@ -133,6 +133,11 @@ startServer = function() {
});
app.use(express.favicon(favIcon));
app.use(jsonBodyParser());
+ app.use(function(req, res, next) {
+res.header("Access-Control-Allow-Origin", "*");
+res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With,
Content-Type, Accept");
+next();
+ });
app.all(/^\/ws\/client(.*)/, function(request, response, next) {
var uri;
uri = request.params[0];
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-9240) Cordova splash screen plugin iPad landscape mode issue
[ https://issues.apache.org/jira/browse/CB-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shakhnazarov resolved CB-9240. - Resolution: Fixed Fixed in 3.0.1-dev > Cordova splash screen plugin iPad landscape mode issue > -- > > Key: CB-9240 > URL: https://issues.apache.org/jira/browse/CB-9240 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen > Environment: iPad iOS 8 >Reporter: Hetal > Labels: ios, landscape, plugin, reproduced, splashscreen, triaged > > I am using the Cordova splash screen plugin > (https://github.com/apache/cordova-plugin-splashscreen) in my hybrid mobile > app targeted for iOS. I have all the splash screen images added to my > project. The reason for using this plugin is to elongate the time for which > the splash screen is shown and I manually hide it later in the app. So my > config.xml has the following declarations: > > > This plugin works fine in the portrait mode on iPhone and iPad. But on the > iPad in landscape mode, the plugin shows the splash image in portrait mode > and consequently my first app view also shows in the portrait mode even > though the device is in landscape mode. > The screenshots are available here: > http://stackoverflow.com/questions/31035650/cordova-splash-screen-plugin-ipad-landscape-mode-issue -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10278) geolocation watchPosition doesn't return watchID string
[ https://issues.apache.org/jira/browse/CB-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074874#comment-15074874 ] ASF GitHub Bot commented on CB-10278: - Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/63#issuecomment-167969937 LGTM > geolocation watchPosition doesn't return watchID string > --- > > Key: CB-10278 > URL: https://issues.apache.org/jira/browse/CB-10278 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Geolocation > Environment: Android 4.4 on samsung galaxy s5. > Android 5.0 on samsung galaxy s5. >Reporter: Nicholas Tsaoucis > Labels: Android, Triaged > > With the new version of the geolocation plugin (-r1.0.1- 2.0.0) when calling > watchPosition no watchID is returned as a string. only undefined is returned. > This makes it impossible to call clearWatch as we don't have the watchID to > use in the clearWatch call. > I rolled back to version -r1.0.0- r1.0.1 and it works properly. > ~edit > The issue is actually with the master branch (version 2.0.0) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9240) Cordova splash screen plugin iPad landscape mode issue
[ https://issues.apache.org/jira/browse/CB-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074868#comment-15074868 ] ASF subversion and git services commented on CB-9240: - Commit 3b2e9e59124e345c61235ca132e8f519d7df8ead in cordova-plugin-splashscreen's branch refs/heads/master from [~daserge] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=3b2e9e5 ] CB-9240 Cordova splash screen plugin iPad landscape mode issue Aligns shouldRotate default value with parent CDVViewController behavior > Cordova splash screen plugin iPad landscape mode issue > -- > > Key: CB-9240 > URL: https://issues.apache.org/jira/browse/CB-9240 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen > Environment: iPad iOS 8 >Reporter: Hetal > Labels: ios, landscape, plugin, reproduced, splashscreen, triaged > > I am using the Cordova splash screen plugin > (https://github.com/apache/cordova-plugin-splashscreen) in my hybrid mobile > app targeted for iOS. I have all the splash screen images added to my > project. The reason for using this plugin is to elongate the time for which > the splash screen is shown and I manually hide it later in the app. So my > config.xml has the following declarations: > > > This plugin works fine in the portrait mode on iPhone and iPad. But on the > iPad in landscape mode, the plugin shows the splash image in portrait mode > and consequently my first app view also shows in the portrait mode even > though the device is in landscape mode. > The screenshots are available here: > http://stackoverflow.com/questions/31035650/cordova-splash-screen-plugin-ipad-landscape-mode-issue -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9240) Cordova splash screen plugin iPad landscape mode issue
[ https://issues.apache.org/jira/browse/CB-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074869#comment-15074869 ] ASF GitHub Bot commented on CB-9240: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/72 > Cordova splash screen plugin iPad landscape mode issue > -- > > Key: CB-9240 > URL: https://issues.apache.org/jira/browse/CB-9240 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen > Environment: iPad iOS 8 >Reporter: Hetal > Labels: ios, landscape, plugin, reproduced, splashscreen, triaged > > I am using the Cordova splash screen plugin > (https://github.com/apache/cordova-plugin-splashscreen) in my hybrid mobile > app targeted for iOS. I have all the splash screen images added to my > project. The reason for using this plugin is to elongate the time for which > the splash screen is shown and I manually hide it later in the app. So my > config.xml has the following declarations: > > > This plugin works fine in the portrait mode on iPhone and iPad. But on the > iPad in landscape mode, the plugin shows the splash image in portrait mode > and consequently my first app view also shows in the portrait mode even > though the device is in landscape mode. > The screenshots are available here: > http://stackoverflow.com/questions/31035650/cordova-splash-screen-plugin-ipad-landscape-mode-issue -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9240) Cordova splash screen plugin iPad landscape mode issue
[ https://issues.apache.org/jira/browse/CB-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074866#comment-15074866 ] ASF subversion and git services commented on CB-9240: - Commit 3b2e9e59124e345c61235ca132e8f519d7df8ead in cordova-plugin-splashscreen's branch refs/heads/CB-9240 from [~daserge] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=3b2e9e5 ] CB-9240 Cordova splash screen plugin iPad landscape mode issue Aligns shouldRotate default value with parent CDVViewController behavior > Cordova splash screen plugin iPad landscape mode issue > -- > > Key: CB-9240 > URL: https://issues.apache.org/jira/browse/CB-9240 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen > Environment: iPad iOS 8 >Reporter: Hetal > Labels: ios, landscape, plugin, reproduced, splashscreen, triaged > > I am using the Cordova splash screen plugin > (https://github.com/apache/cordova-plugin-splashscreen) in my hybrid mobile > app targeted for iOS. I have all the splash screen images added to my > project. The reason for using this plugin is to elongate the time for which > the splash screen is shown and I manually hide it later in the app. So my > config.xml has the following declarations: > > > This plugin works fine in the portrait mode on iPhone and iPad. But on the > iPad in landscape mode, the plugin shows the splash image in portrait mode > and consequently my first app view also shows in the portrait mode even > though the device is in landscape mode. > The screenshots are available here: > http://stackoverflow.com/questions/31035650/cordova-splash-screen-plugin-ipad-landscape-mode-issue -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-5375) iOS7 splash screen resizing
[ https://issues.apache.org/jira/browse/CB-5375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shakhnazarov resolved CB-5375. - Resolution: Cannot Reproduce [~fabryb], feel free to reopen if this is still actual. > iOS7 splash screen resizing > --- > > Key: CB-5375 > URL: https://issues.apache.org/jira/browse/CB-5375 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Affects Versions: 3.1.0 > Environment: iOS 7.0.x > Xcode 5 >Reporter: Fabrizio Bottino > Labels: ios7, splashscreen, xcode5 > > When transition happens between xcode splash screen and plugin splash screen > I can see image "moving" because it got resized. > My app is currently compatible with iOS 5.x, 6.x, 7.0.x so I have both old > splash screen sizes (devices size - status bar) and new splash screen sizes > (full devices size) > I tried to debug the issue and this is what I have found: > - plugin guesses splash screen file name based on default apple naming of > files > - plugin is not reading effective splash screen used in in .plist > - in iOS 7 there are new splash screen sizes which are "outside" standard > apple naming > in this example I will show ipad NON retina landscape: > 1024x748 Default-Landscape~ipad.png > 1024x768 ipad7l.png > Where "ipad7l" is a name I choose, while " Default-Landscape~ipad" is the > name Xcode has given to my splash after pointing it as splash. > When plugin starts it compares actual device resolution with guessed image > resolution and if they're not equal it proceed to resize. > Device size is 1024x768, image size is 1024x748 (because plugin guesses > Default-Landscape~ipad.png as image file name, as in iOS 6 naming) and it > proceed to resize it. > Maybe I am wrong in my splash screen naming. > If I am not I suggest plugin should red .plist file to know which file to use -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8376) StatusBar plugin breaks when platform/ios is recreated
[ https://issues.apache.org/jira/browse/CB-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-8376: - Labels: cannot-reproduce triaged (was: ) > StatusBar plugin breaks when platform/ios is recreated > -- > > Key: CB-8376 > URL: https://issues.apache.org/jira/browse/CB-8376 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: Master > Environment: XCode >Reporter: Daniel Holth > Labels: cannot-reproduce, triaged > > I'm using the statusbar plugin on iOS to keep the status bar from overlaying > the webview. > > I put this preference in plugins/ios.json's munge section and in config.xml. > If I remove the platforms/ directory and then add the ios platform back in, > the statusbar plugin does not load. The status bar is now transparent instead > of my preference. > The only way to get it reconfigured properly seems to be to remove and re-add > the plugin but even this fix does not seem to be completely reliable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8376) StatusBar plugin breaks when platform/ios is recreated
[ https://issues.apache.org/jira/browse/CB-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074837#comment-15074837 ] Vladimir Kotikov commented on CB-8376: -- [~dholth], [~asgeo1], Is this still actual? Tested this with latest cordova-cli@5.3.3, cordova-ios@3.9.2 and ordova-plugin-statusbar@2 and this doesn't repro for me. If the bug still exists, could you please provide information about versions and repro steps? > StatusBar plugin breaks when platform/ios is recreated > -- > > Key: CB-8376 > URL: https://issues.apache.org/jira/browse/CB-8376 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: Master > Environment: XCode >Reporter: Daniel Holth > Labels: cannot-reproduce, triaged > > I'm using the statusbar plugin on iOS to keep the status bar from overlaying > the webview. > > I put this preference in plugins/ios.json's munge section and in config.xml. > If I remove the platforms/ directory and then add the ios platform back in, > the statusbar plugin does not load. The status bar is now transparent instead > of my preference. > The only way to get it reconfigured properly seems to be to remove and re-add > the plugin but even this fix does not seem to be completely reliable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-9913) [iOS] SplashScreen AutoHideSplashScreen can't find file on some iPhone models
[
https://issues.apache.org/jira/browse/CB-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shakhnazarov resolved CB-9913.
-
Resolution: Fixed
Fixed in CB-10263
> [iOS] SplashScreen AutoHideSplashScreen can't find file on some iPhone models
> -
>
> Key: CB-9913
> URL: https://issues.apache.org/jira/browse/CB-9913
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
>Affects Versions: Master
> Environment: {code}
> node -v
> v0.10.40
> npm ls -g --depth 0
> /Users/sk/.nvm/v0.10.40/lib
> ├── cordova@5.3.4-dev -> /Users/sk/cache/cordova/cordova-cli
> ├── cordova-common@0.1.1-dev ->
> /Users/sk/cache/cordova/cordova-lib/cordova-common
> ├── cordova-lib@5.3.4-dev -> /Users/sk/cache/cordova/cordova-lib/cordova-lib
> ├── ios-sim@5.0.1
> ├── npm@2.14.6
> └── plugman@1.0.3-dev -> /Users/sk/cache/cordova/cordova-plugman
> cd ~/cache/cordova/cordova-cli
> git log | head -n 1
> commit b53810ee754bd4a44591388473355efda0aa8653
> cd ../cordova-lib/
> git log | head -n 1
> commit b45bc1c80b239040b91da25e2f12e759fc52c31d
> cd ../cordova-plugman/
> git log | head -n 1
> commit 2a4ff6e21de715ea8f6f6e5e024647ee1b557738
> {code}
>Reporter: Seth W. Klein
>
> {code}
> cordova create cordova-splash-no-auto-bug com.example.SplashBug SplashBug
> cd cordova-splash-no-auto-bug/
> cordova plugin add
> https://github.com/apache/cordova-plugin-splashscreen.git#master
> cordova platform add https://github.com/apache/cordova-ios.git#master
> cordova emulate ios
> # add to config.xml
> #
> cordova emulate ios --target iPhone-6
> # observe that splash screen hides and app becomes visible.
> # expected splash screen to remain hiding app due to AutoHideSplashScreen
> being false.
> cordova emulate ios --target iPhone-5
> # observe expected behavior
> open platforms/ios/SplashBug.xcodeproj
> # run in iPhone-6 in XCode and observe error in console:
> 2015-10-28 00:20:38.029 SplashBug[40245:3789224] WARNING: The splashscreen
> image named LaunchImage-667h was not found
> # observe that XCode sees SplashBug/Resources/Images.xcassets/LaunchImage
> Retina HD 4.7, named Default-667h.png, and sized at 750 x 1334, matching the
> expected size
> find . -name '*667h*'
> ./platforms/ios/build/emulator/SplashBug.app/launchimage-800-6...@2x.png
> ./platforms/ios/SplashBug/Images.xcassets/LaunchImage.launchimage/Default-667h.png
> a similar but more complex situation is visible with iPhone 6s Plus
> launchimage-800-landscape-7...@3x.png
> launchimage-800-portrait-7...@3x.png
> something that might work:
> https://github.com/sethwklein/cordova-plugin-splashscreen/commit/d44868a77fc8bb6e3a9435d84bb3dd97f1f85ae0
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6191) Failed to show splash image when running cordova on 3.5-inch devices or simulators
[
https://issues.apache.org/jira/browse/CB-6191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074824#comment-15074824
]
Sergey Shakhnazarov commented on CB-6191:
-
[This
commit|https://github.com/apache/cordova-plugin-splashscreen/commit/75327c88e4463ef3e3507424e4bb411c4365b9ca]
is a fix for iPhone landscape-only apps splashscreen image rotation.
The following config.xml preference should be used for iPhone (see [Icons and
Splash Screens|http://cordova.apache.org/docs/en/dev/config_ref/images.html]
for more details):
{code}
...
{code}
[~glmnbeyond], could you please test this with the latest version?
{code}
cordova plugin add https://github.com/apache/cordova-plugin-splashscreen
{code}
> Failed to show splash image when running cordova on 3.5-inch devices or
> simulators
> --
>
> Key: CB-6191
> URL: https://issues.apache.org/jira/browse/CB-6191
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
> Environment: splash-screen v0.2.7
> iOS
>Reporter: glmnbeyond
>
> If I run Cordova app on 3.5-inch devices or simulators, the splash image is
> not displayed.
> We can run mobile-spec->Splashscreen test to reproduce this phenomenon.
> I believe this bug is imported by commit
> https://github.com/apache/cordova-plugin-splashscreen/commit/75327c88e4463ef3e3507424e4bb411c4365b9ca
> The reason is that it can't find image which is named "Default-Portrait".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-7791) iPhone 6 showing wrong splash screen
[
https://issues.apache.org/jira/browse/CB-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shakhnazarov resolved CB-7791.
-
Resolution: Fixed
Fixed in CB-10263
> iPhone 6 showing wrong splash screen
>
>
> Key: CB-7791
> URL: https://issues.apache.org/jira/browse/CB-7791
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
>Affects Versions: 3.6.3
> Environment: iOS
>Reporter: Jacob Weber
> Attachments: Test.zip
>
>
> I use asset catalogs to manage my splash screens in Xcode, along with the
> splash screen plugin.
> I added the images for iPhone 6 and 6 Plus. When I run the app on an iPhone
> 6, I briefly see my new image, then I see the 640x960 image. How can I
> prevent this?
> I created the project by doing the following:
> {code}
> cordova create Test com.test.test Test
> cd test
> cordova platform add ios
> cordova plugin add org.apache.cordova.splashscreen
> cordova prepare
> {code}
> then opening the file in Xcode, converting the launch images to an asset
> catalog, adding the Default-667h@2x~iphone.png and Default-736h@3x~iphone.png
> images to the project, then adding them to the asset catalog.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8342) SplashScreen plugin doesn't destroy it's views which seems to block user interaction
[ https://issues.apache.org/jira/browse/CB-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074785#comment-15074785 ] Sergey Shakhnazarov commented on CB-8342: - [~jamaljohnson], can you attach the failing sample code to repro and fix? (I could not find any PinLock plugin available) > SplashScreen plugin doesn't destroy it's views which seems to block user > interaction > > > Key: CB-8342 > URL: https://issues.apache.org/jira/browse/CB-8342 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Jamal Johnson > Labels: ios, splashscreen > > We recently updated the SplashScreen plugin for iPhone 6/6+ support but > uncovered an issue that appears to have been caused by a fix for another > issue. > There was a bug report (https://issues.apache.org/jira/browse/CB-7204) > concerning it sounds like a race condition with the spinner and the splash > screen and the fix was to make sure the animation "completed" by checking a > boolean passed to the animation "completion" function, when hiding the > SplashScreen, before destroying it's views. This boolean, according to the > docs, will be false if another view is animated in before this one was > "completed". > Here is the commit with the fix: d2e62a551c950041cb4c9683624a04d931f4bee3 > (https://github.com/apache/cordova-plugin-splashscreen/commit/d2e62a551c950041cb4c9683624a04d931f4bee3) > We have a case where we have another view (a PinLock plugin) that sometimes > gets animated in before the SplashScreen animation is fully complete. There > doesn't seem to be any issues with this and is transparent to the user. > However, with the addition of checking the "finished" boolean before > destroying the views, the app becomes unusable. If we comment that > conditional out, everything works fine again. > Is there another way to handle fixing the race condition? Or any other > suggestions? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
