[jira] [Commented] (CB-10798) Cannot create folder into cordova.file.externalRootDirectory on Android 6.x Marshmallow
[
https://issues.apache.org/jira/browse/CB-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186677#comment-15186677
]
Vito Macchia commented on CB-10798:
---
[~jasongin] yeah, you're right: 12 is definitely PATH_EXISTS. Anyway I also
think that, whether you go for deprecating this or not, it should be clearly
visible in the docs.
I was trying to make a kind of a shared folder for my app, then I realized that
there are more robust ways (even if they require some more work) of doing this.
Anyway I still think this has something to do with the way the plugin code gets
directory permissions on 6.x because some file managers can still easily create
folders in the sdcard root directory (e.g. File Expert).
We may agree that this is not the most useful feature of this plugin and that
several workarounds can be found, but at least the documentation for Android
6.x has to be updated.
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow
> ---
>
> Key: CB-10798
> URL: https://issues.apache.org/jira/browse/CB-10798
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.1.1
> Environment: Android 6.0.1 (Nexus 9 and other 6.x devices), Cordova
> cli 6.0.0, Android platform 5.1.0
>Reporter: Vito Macchia
>Assignee: Jason Ginchereau
> Labels: android, triaged
>
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow. It always returns encording error (12), while on Android 5.x
> (Lollipop) the same code works fine.
> On Marshmallow devices I can succesfully create folders only into
> cordova.file.externalDataDirectory.
> No matter the value of preference AndroidPersistentFileLocation or
> AndroidExtraFilesystems.
> Code (some ES6, sorry)
> This snippet uses WinJS Promises - should work with native promises as well
> or you can just remove promises and pass succes and fail callbacks. It should
> create MY_Folder/test (both folders, like mkdirp) in the SD Card (regardless
> if emulated or not) root directory. It works fine with 5.x devices, but
> returns always FileError.ENCODING_ERR on Marshmallow.
> {code:title=createDirectory.js|borderStyle=solid}
> function errorCode(e) {
> var msg = '';
> switch (e.code) {
> case FileError.ABORT_ERR:
> msg = 'ABORT_ERR';
> break;
> case FileError.ENCODING_ERR:
> msg = 'ENCODING_ERR';
> break;
> case FileError.NOT_READABLE_ERR:
> msg = 'NOT_READABLE_ERR';
> break;
> case FileError.PATH_EXISTS_ERR:
> msg = 'PATH_EXISTS_ERR';
> break;
> case FileError.QUOTA_EXCEEDED_ERR:
> msg = 'QUOTA_EXCEEDED_ERR';
> break;
> case FileError.NOT_FOUND_ERR:
> msg = 'NOT_FOUND_ERR';
> break;
> case FileError.SECURITY_ERR:
> msg = 'SECURITY_ERR';
> break;
> case FileError.INVALID_MODIFICATION_ERR:
> msg = 'INVALID_MODIFICATION_ERR';
> break;
> case FileError.INVALID_STATE_ERR:
> msg = 'INVALID_STATE_ERR';
> break;
> default:
> msg = 'Unknown Error';
> break;
> };
> console.log('Error: ' + msg, "CODE", e);
> return msg;
> }
> const STATIC_CONTENT_DIR = 'MY_Folder/test';
> function createDirectory(startDirectory = cordova.file.externalRootDirectory)
> {
> return new WinJS.Promise(function(success, fail) {
> window.resolveLocalFileSystemURL(startDirectory, function(directory) {
> console.log("FS ROOT", directory);
> function fileGetDir(path, cb) {
> console.log("*** PATH", path);
> var fnGetOrCreateDir = function(p, de) {
> var entry = p.shift();
> console.log("PATH", path);
> if (entry) {
> de.getDirectory(entry, {
> create: true,
> exclusive: false
> }, function(dirEntry) {
> console.log("CR", dirEntry);
> fnGetOrCreateDir(p, dirEntry);
> }, fileFSError);
> } else
> if (cb) cb(de);
> };
> if (path) {
> var arPath = path.split("/");
> fnGetOrCreateDir(arPath, directory.filesystem.root);
> } else {
> if (cb) cb(directory);
> }
> }
> fileGetDir(STATIC_CONTENT_DIR, onSuccess);
>
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186654#comment-15186654
]
ASF GitHub Bot commented on CB-9858:
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55480177
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/*
+ * A module that npm installs a module from npm or a git url
+ *
+ * @param {String} target the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+if(!shell.which('npm')) {
+return Q.reject(new CordovaError('"npm" command line tool is not
installed: make sure it is accessible on your PATH.'));
+}
+
+if(dest && target) {
+//add target to fetchArgs Array
+fetchArgs.push(target);
+
+//append node_modules to dest if it doesn't come included
+if (path.basename(dest) !== 'node_modules') {
+dest = path.resolve(path.join(dest, 'node_modules'));
+}
+
+//create dest if it doesn't exist
+if(!fs.existsSync(dest)) {
+shell.mkdir('-p', dest);
+}
+
+} else return Q.reject(new CordovaError('Need to supply a target and
destination'));
+
+//set the directory where npm install will be run
+opts.cwd = dest;
--- End diff --
Yup! Pass everything to superspawn that fetch was passed. Add the cwd to
opts though.
> Implement Cordova Fetch Proposal
>
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186653#comment-15186653
]
ASF GitHub Bot commented on CB-9858:
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55480086
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/*
+ * A module that npm installs a module from npm or a git url
+ *
+ * @param {String} target the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+if(!shell.which('npm')) {
--- End diff --
Sounds like a good idea! Do you have any examples of doing this with
Java_home I could use as a basis for this? I pretty much mickimed how our
current fetch code looks for git.
> Implement Cordova Fetch Proposal
>
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186545#comment-15186545 ] ASF GitHub Bot commented on CB-10679: - Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/238#discussion_r55473629 --- Diff: doc/plugin.txt --- @@ -4,20 +4,23 @@ Synopsis Manage project plugins -add [...] Add specified plugins +add [...] Add specified plugins. If adding a plugin from npm, the --- End diff -- Too many ifs. I was hoping we would actually have an order of resolution of how plugin add picks the plugin in the README.md which is the CLI reference doc. I'm not sure if inline CLI help is the best place for something like this. > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186532#comment-15186532
]
ASF GitHub Bot commented on CB-9858:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55473246
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/*
+ * A module that npm installs a module from npm or a git url
+ *
+ * @param {String} target the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+if(!shell.which('npm')) {
+return Q.reject(new CordovaError('"npm" command line tool is not
installed: make sure it is accessible on your PATH.'));
+}
+
+if(dest && target) {
+//add target to fetchArgs Array
+fetchArgs.push(target);
+
+//append node_modules to dest if it doesn't come included
+if (path.basename(dest) !== 'node_modules') {
+dest = path.resolve(path.join(dest, 'node_modules'));
+}
+
+//create dest if it doesn't exist
+if(!fs.existsSync(dest)) {
+shell.mkdir('-p', dest);
+}
+
+} else return Q.reject(new CordovaError('Need to supply a target and
destination'));
+
+//set the directory where npm install will be run
+opts.cwd = dest;
--- End diff --
Are the `opts` for superspawn the same as the `opts` passed to this
function?
> Implement Cordova Fetch Proposal
>
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186520#comment-15186520
]
ASF GitHub Bot commented on CB-9858:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55472886
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/*
+ * A module that npm installs a module from npm or a git url
+ *
+ * @param {String} target the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+if(!shell.which('npm')) {
--- End diff --
Judging from previous experience with our tools not being able to find
ANDROID_HOME/JAVA_HOME - this might become an error message that will affect
new people. We should consider doing a best effort to find the npm installed on
the system if `which` can't find it. There are some well known places on
Windows/Mac where this gets installed.
> Implement Cordova Fetch Proposal
>
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10820) Plugins Release March 9, 2016
[ https://issues.apache.org/jira/browse/CB-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carlos Santana updated CB-10820: Description: Following steps at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md The following patches to be included into this release: cordova-plugin-camera cordova-plugin-statusbar cordova-plugin-globalization cordova-plugin-splashscreen was: Following steps at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md The following patches to be included into this release: > Plugins Release March 9, 2016 > - > > Key: CB-10820 > URL: https://issues.apache.org/jira/browse/CB-10820 > Project: Apache Cordova > Issue Type: Task > Components: Plugin Camera, Plugin Globalization, Plugin > SplashScreen, Plugin Statusbar >Reporter: Carlos Santana >Assignee: Carlos Santana > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > The following patches to be included into this release: > cordova-plugin-camera > cordova-plugin-statusbar > cordova-plugin-globalization > cordova-plugin-splashscreen -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10820) Plugins Release March 9, 2016
Carlos Santana created CB-10820: --- Summary: Plugins Release March 9, 2016 Key: CB-10820 URL: https://issues.apache.org/jira/browse/CB-10820 Project: Apache Cordova Issue Type: Task Components: Plugin Camera, Plugin Globalization, Plugin SplashScreen, Plugin Statusbar Reporter: Carlos Santana Assignee: Carlos Santana Following steps at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md The following patches to be included into this release: -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10806) Anchors on events page don't work
[ https://issues.apache.org/jira/browse/CB-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186364#comment-15186364 ] Dmitry Blotsky commented on CB-10806: - [~jcesarmobile] looks fixed now. Please confirm. > Anchors on events page don't work > - > > Key: CB-10806 > URL: https://issues.apache.org/jira/browse/CB-10806 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: jcesarmobile >Priority: Minor > > On the events page > (http://cordova.apache.org/docs/en/dev/cordova/events/events.html) there is a > table with the available events and the supported platforms. > The events on that table have anchors to the event documentation, but those > anchors don't work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10806) Anchors on events page don't work
[ https://issues.apache.org/jira/browse/CB-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Blotsky resolved CB-10806. - Resolution: Fixed > Anchors on events page don't work > - > > Key: CB-10806 > URL: https://issues.apache.org/jira/browse/CB-10806 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: jcesarmobile >Priority: Minor > > On the events page > (http://cordova.apache.org/docs/en/dev/cordova/events/events.html) there is a > table with the available events and the supported platforms. > The events on that table have anchors to the event documentation, but those > anchors don't work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10819) Snapshotting dev to latest should be automated
Dmitry Blotsky created CB-10819: --- Summary: Snapshotting dev to latest should be automated Key: CB-10819 URL: https://issues.apache.org/jira/browse/CB-10819 Project: Apache Cordova Issue Type: New Feature Components: Docs Reporter: Dmitry Blotsky Assignee: Dmitry Blotsky Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186318#comment-15186318 ] ASF GitHub Bot commented on CB-9858: Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-194065776 Needs https://github.com/apache/cordova-cli/pull/239. Discussion at https://github.com/cordova/cordova-discuss/pull/33 > Implement Cordova Fetch Proposal > > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186317#comment-15186317 ] ASF GitHub Bot commented on CB-9858: GitHub user stevengill opened a pull request: https://github.com/apache/cordova-cli/pull/239 CB-9858 added --fetch option Needs https://github.com/apache/cordova-lib/pull/407 Part of https://github.com/cordova/cordova-discuss/pull/33 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-cli CB-9858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #239 commit ac24fde7dba444aabc143ff04fe9f5d7ed8872e4 Author: Steve Gill Date: 2016-03-04T00:32:37Z CB-9858 added --fetch option > Implement Cordova Fetch Proposal > > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186287#comment-15186287 ] ASF GitHub Bot commented on CB-9858: Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-194059148 I decided to write the tests in node-tap. I am now regretting that decision a bit. Tests randomly timeout and fail. Doesn't happen in actual use. > Implement Cordova Fetch Proposal > > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186284#comment-15186284 ] ASF GitHub Bot commented on CB-9858: GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/407 CB-9858 Cordova Fetch Work This is not ready to merge yet! Opening the PR so it is easy to manage diffs and take feedback You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib CB-9858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/407.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #407 commit 378b876bdc7aa4e80450e3a3e3d45f02891fc50d Author: Steve Gill Date: 2016-02-06T02:13:51Z initial commit for cordova-fetch commit 2206b1e2d8976dd2d0b21adf7ee4042b5eeec462 Author: Steve Gill Date: 2016-02-09T02:24:41Z implemented fetch module and added tests commit 1e3853d0e768dd9a7af63e026643601ac900a5d6 Author: Steve Gill Date: 2016-02-24T02:03:40Z CB-9858: completed first implementation of cordova-fetch module commit de15f74e7872fc249346faf152e63bb061036a5f Author: Steve Gill Date: 2016-03-02T02:11:08Z CB-9858 updated tests commit 9a1373571b082f1a8e6e643306f89c204ea9fcd5 Author: Steve Gill Date: 2016-03-04T01:31:49Z CB-9858 adding platforms can now use cordova-fetch with --fetch flag commit 47ae946562058fb7563685d1fdee61d7b7fcbf9f Author: Steve Gill Date: 2016-03-09T01:10:17Z CB-9859 added trimID to handle cordova platform update usecase commit 1fa38af3c3b6a35cb84d7e01b651b5aafef33e28 Author: Steve Gill Date: 2016-03-09T01:30:22Z CB-9858 cordova platform remove --fetch deletes module from node_modules directory > Implement Cordova Fetch Proposal > > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186248#comment-15186248 ] ASF GitHub Bot commented on CB-10679: - Github user dblotsky commented on the pull request: https://github.com/apache/cordova-cli/pull/238#issuecomment-194053721 LGTM. > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10269) [iOS 8] cordova-plugin-wkwebview-engine breaks Cordova iOS 4.0.0 under iOS 8
[ https://issues.apache.org/jira/browse/CB-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186239#comment-15186239 ] ASF GitHub Bot commented on CB-10269: - Github user jamesandersen closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3 > [iOS 8] cordova-plugin-wkwebview-engine breaks Cordova iOS 4.0.0 under iOS 8 > > > Key: CB-10269 > URL: https://issues.apache.org/jira/browse/CB-10269 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 4.0.0 > Environment: Cordova tools 5.4.1 > Cordova iOS platform 4.0.1 > iOS Simulator 8.4 > cordova-plugin-wkwebview-engine plugin >Reporter: Ivan Karpan >Assignee: Shazron Abdullah >Priority: Critical > Labels: cordova-ios-4.1.0, triaged > Attachments: ios-wkwebview-exec.js > > > When launching on iOS 8.4 simulator the following error breaks JS execution > early on: > ios-wkwebview-exec.js:127 TypeError: undefined is not an object (evaluating > 'window.webkit.messageHandlers') > So inclusion of 'cordova-plugin-wkwebview-engine' plugin breaks support of > iOS versions previous to 9.0. I assume ios-wkwebview-exec.js should have > environment checks before using WKWebView bridge... > Exclusion of the same plugin breaks the project at all. Are there any > fallback mechanics in place? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186230#comment-15186230
]
ASF GitHub Bot commented on CB-7862:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55457515
--- Diff: www/FileReader.js ---
@@ -96,6 +106,78 @@ function initRead(reader, file) {
}
/**
+ * Callback used by the following read* functions to handle incremental or
final success.
+ * Must be bound to the FileReader's this along with all but the last
parameter,
+ * e.g. readSuccessCallback.bind(this, "readAsText", "UTF-8", offset,
totalSize, accumulate)
+ * @param readType The name of the read function to call.
+ * @param encoding Text encoding, or null if this is not a text type read.
+ * @param offset Starting offset of the read.
+ * @param totalSize Total number of bytes or chars to read.
+ * @param accumulate A function that takes the callback result and
accumulates it in this._result.
+ * @param r Callback result returned by the last read exec() call, or null
to begin reading.
+ */
+function readSuccessCallback(readType, encoding, offset, totalSize,
accumulate, r) {
+if (this._readyState === FileReader.DONE) {
+return;
+}
+
+if (typeof r !== "undefined") {
+accumulate(r);
+this._progress = Math.min(this._progress +
FileReader.READ_CHUNK_SIZE, totalSize);
+
+if (typeof this.onprogress === "function") {
+this.onprogress(new ProgressEvent("progress",
{loaded:this._progress, total:totalSize}));
+}
+}
+
+if (typeof r === "undefined" || this._progress < totalSize) {
+var execArgs = [
+this._localURL,
+offset + this._progress,
+offset + this._progress + Math.min(totalSize - this._progress,
FileReader.READ_CHUNK_SIZE)];
+if (encoding) {
--- End diff --
Sure, that works. I just thought it was unclear why you were inserting an
argument in this way
> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied.
> I use http://ngcordova.com/ and here is my code
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186219#comment-15186219
]
ASF GitHub Bot commented on CB-7862:
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55456235
--- Diff: www/FileReader.js ---
@@ -96,6 +106,78 @@ function initRead(reader, file) {
}
/**
+ * Callback used by the following read* functions to handle incremental or
final success.
+ * Must be bound to the FileReader's this along with all but the last
parameter,
+ * e.g. readSuccessCallback.bind(this, "readAsText", "UTF-8", offset,
totalSize, accumulate)
+ * @param readType The name of the read function to call.
+ * @param encoding Text encoding, or null if this is not a text type read.
+ * @param offset Starting offset of the read.
+ * @param totalSize Total number of bytes or chars to read.
+ * @param accumulate A function that takes the callback result and
accumulates it in this._result.
+ * @param r Callback result returned by the last read exec() call, or null
to begin reading.
+ */
+function readSuccessCallback(readType, encoding, offset, totalSize,
accumulate, r) {
+if (this._readyState === FileReader.DONE) {
+return;
+}
+
+if (typeof r !== "undefined") {
+accumulate(r);
+this._progress = Math.min(this._progress +
FileReader.READ_CHUNK_SIZE, totalSize);
+
+if (typeof this.onprogress === "function") {
+this.onprogress(new ProgressEvent("progress",
{loaded:this._progress, total:totalSize}));
+}
+}
+
+if (typeof r === "undefined" || this._progress < totalSize) {
+var execArgs = [
+this._localURL,
+offset + this._progress,
+offset + this._progress + Math.min(totalSize - this._progress,
FileReader.READ_CHUNK_SIZE)];
+if (encoding) {
--- End diff --
See the doc-comment for the encoding param.
> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied.
> I use http://ngcordova.com/ and here is my code
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10818) Support the scroll deceleration speed preference
[ https://issues.apache.org/jira/browse/CB-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186211#comment-15186211 ] ASF GitHub Bot commented on CB-10818: - Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4#issuecomment-194041370 Issue filed: https://issues.apache.org/jira/browse/CB-10818 @dpogue can you prefix the title of this PR with CB-10818? Thanks! > Support the scroll deceleration speed preference > > > Key: CB-10818 > URL: https://issues.apache.org/jira/browse/CB-10818 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > > PR: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4 > Adds a new preference WKWebViewDecelerationSpeed, but will safely fall back > to the UIWebViewDecelerationSpeed for existing projects. > It might be preferable to always use UIWebViewDecelerationSpeed rather than > adding a new preference, although the name would be inconsistent. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10818) Support the scroll deceleration speed preference
[ https://issues.apache.org/jira/browse/CB-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-10818: -- Reporter: Darryl Pogue (was: Shazron Abdullah) > Support the scroll deceleration speed preference > > > Key: CB-10818 > URL: https://issues.apache.org/jira/browse/CB-10818 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin WKWebViewEngine >Reporter: Darryl Pogue > > PR: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4 > Adds a new preference WKWebViewDecelerationSpeed, but will safely fall back > to the UIWebViewDecelerationSpeed for existing projects. > It might be preferable to always use UIWebViewDecelerationSpeed rather than > adding a new preference, although the name would be inconsistent. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10818) Support the scroll deceleration speed preference
Shazron Abdullah created CB-10818: - Summary: Support the scroll deceleration speed preference Key: CB-10818 URL: https://issues.apache.org/jira/browse/CB-10818 Project: Apache Cordova Issue Type: New Feature Components: Plugin WKWebViewEngine Reporter: Shazron Abdullah PR: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4 Adds a new preference WKWebViewDecelerationSpeed, but will safely fall back to the UIWebViewDecelerationSpeed for existing projects. It might be preferable to always use UIWebViewDecelerationSpeed rather than adding a new preference, although the name would be inconsistent. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10269) [iOS 8] cordova-plugin-wkwebview-engine breaks Cordova iOS 4.0.0 under iOS 8
[ https://issues.apache.org/jira/browse/CB-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186206#comment-15186206 ] ASF GitHub Bot commented on CB-10269: - Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-194040883 @jamesandersen can you close this? it came out in the 1.0.2 release of the plugin > [iOS 8] cordova-plugin-wkwebview-engine breaks Cordova iOS 4.0.0 under iOS 8 > > > Key: CB-10269 > URL: https://issues.apache.org/jira/browse/CB-10269 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 4.0.0 > Environment: Cordova tools 5.4.1 > Cordova iOS platform 4.0.1 > iOS Simulator 8.4 > cordova-plugin-wkwebview-engine plugin >Reporter: Ivan Karpan >Assignee: Shazron Abdullah >Priority: Critical > Labels: cordova-ios-4.1.0, triaged > Attachments: ios-wkwebview-exec.js > > > When launching on iOS 8.4 simulator the following error breaks JS execution > early on: > ios-wkwebview-exec.js:127 TypeError: undefined is not an object (evaluating > 'window.webkit.messageHandlers') > So inclusion of 'cordova-plugin-wkwebview-engine' plugin breaks support of > iOS versions previous to 9.0. I assume ios-wkwebview-exec.js should have > environment checks before using WKWebView bridge... > Exclusion of the same plugin breaks the project at all. Are there any > fallback mechanics in place? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10817) The webView should reload when a crash occurs
[ https://issues.apache.org/jira/browse/CB-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186202#comment-15186202 ] ASF GitHub Bot commented on CB-10817: - Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-194039914 Sorry, overlooked this. The normal process is to file a JIRA issue and reference it in the title here (which will mirror comments to the issue). I've done so: https://issues.apache.org/jira/browse/CB-10817 @dlmma can you prefix CB-10817 to the title of this PR? Thanks. > The webView should reload when a crash occurs > - > > Key: CB-10817 > URL: https://issues.apache.org/jira/browse/CB-10817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > > With the iOS9 API, it is now possible to detect when the WKProcess dies. See > the API details for reference: > PR: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5 > https://developer.apple.com/library/ios/releasenotes/General/iOS90APIDiffs/Objective-C/WebKit.html > When it does, the content is blanked out and the URL becomes nil. This > results in a "white screen" that can only be resolved by restarting the app. > See this for more info: https://bugs.webkit.org/show_bug.cgi?id=148685 > I've Implemented the method: - > (void)webViewWebContentProcessDidTerminate:(WKWebView *)webView which will be > called when the process dies and reload the webView. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10817) The webView should reload when a crash occurs
Shazron Abdullah created CB-10817: - Summary: The webView should reload when a crash occurs Key: CB-10817 URL: https://issues.apache.org/jira/browse/CB-10817 Project: Apache Cordova Issue Type: Bug Components: Plugin WKWebViewEngine Reporter: Shazron Abdullah With the iOS9 API, it is now possible to detect when the WKProcess dies. See the API details for reference: PR: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5 https://developer.apple.com/library/ios/releasenotes/General/iOS90APIDiffs/Objective-C/WebKit.html When it does, the content is blanked out and the URL becomes nil. This results in a "white screen" that can only be resolved by restarting the app. See this for more info: https://bugs.webkit.org/show_bug.cgi?id=148685 I've Implemented the method: - (void)webViewWebContentProcessDidTerminate:(WKWebView *)webView which will be called when the process dies and reload the webView. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10816) Upgrade overwrites several customized items in iOS project
[
https://issues.apache.org/jira/browse/CB-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob Weber updated CB-10816:
-
Description:
I have an iOS project using cordova-ios 4.0.1, developed with the
platform-centric workflow. I downloaded [cordova-ios
4.1.0|https://github.com/apache/cordova-ios/releases] and ran
{{cordova-ios-4.1.0/bin/update}} on my project.
In addition to the usual upgrades, it made the following unexpected changes:
* Deleted all images in {{/XcodeProject/Images.xcassets/AppIcon.appiconset}}
and {{/XcodeProject/Images.xcassets/LaunchImage.launchimage}}, and replaced
them with Cordova defaults.
* Deleted all plugin code in {{/XcodeProject/Plugins/}}.
* Replaced {{/XcodeProject/config.xml}} with the default, e.g.
{{HelloCordova}}.
* Replaced {{/XcodeProject//XcodeProject-Info.plist}} with the default.
This hasn't happened in any previous upgrades.
was:
I have an iOS project using cordova-ios 4.0.1, developed with the
platform-centric workflow. I downloaded [cordova-ios
4.1.0|https://github.com/apache/cordova-ios/releases] and ran
{{cordova-ios-4.1.0/bin/update}} on my project.
In addition to the usual upgrades, it made the following unexpected changes:
* Deleted all images in {{/MyProject/Images.xcassets/AppIcon.appiconset}} and
{{/MyProject/Images.xcassets/LaunchImage.launchimage}}, and replaced them with
Cordova defaults.
* Deleted all plugin code in {{/MyProject/Plugins}}.
* Replaced {{/config.xml}} with the default, e.g. {{HelloCordova}}.
* Replaced {{/MyProject-Info.plist}} with the default.
This hasn't happened in any previous upgrades.
> Upgrade overwrites several customized items in iOS project
> --
>
> Key: CB-10816
> URL: https://issues.apache.org/jira/browse/CB-10816
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 4.1.0
> Environment: Mac OS 10.11.3, node 4.3.1
>Reporter: Jacob Weber
>
> I have an iOS project using cordova-ios 4.0.1, developed with the
> platform-centric workflow. I downloaded [cordova-ios
> 4.1.0|https://github.com/apache/cordova-ios/releases] and ran
> {{cordova-ios-4.1.0/bin/update}} on my project.
> In addition to the usual upgrades, it made the following unexpected changes:
> * Deleted all images in {{/XcodeProject/Images.xcassets/AppIcon.appiconset}}
> and {{/XcodeProject/Images.xcassets/LaunchImage.launchimage}}, and replaced
> them with Cordova defaults.
> * Deleted all plugin code in {{/XcodeProject/Plugins/}}.
> * Replaced {{/XcodeProject/config.xml}} with the default, e.g.
> {{HelloCordova}}.
> * Replaced {{/XcodeProject//XcodeProject-Info.plist}} with the default.
> This hasn't happened in any previous upgrades.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[ https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186136#comment-15186136 ] ASF GitHub Bot commented on CB-7862: Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/168#issuecomment-194033408 LGTM. Tested on Marshmallow device and KitKat emulator > FileReader reads large files in a single chunk causing OOM exceptions > - > > Key: CB-7862 > URL: https://issues.apache.org/jira/browse/CB-7862 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 4.0.0 > Environment: Android >Reporter: shenzhuxi >Assignee: Jason Ginchereau >Priority: Critical > > In Android, I tried to copy a 14MB file from html file input with > org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied. > I use http://ngcordova.com/ and here is my code > https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10816) Upgrade overwrites several customized items in iOS project
Jacob Weber created CB-10816:
Summary: Upgrade overwrites several customized items in iOS project
Key: CB-10816
URL: https://issues.apache.org/jira/browse/CB-10816
Project: Apache Cordova
Issue Type: Bug
Components: iOS
Affects Versions: 4.1.0
Environment: Mac OS 10.11.3, node 4.3.1
Reporter: Jacob Weber
I have an iOS project using cordova-ios 4.0.1, developed with the
platform-centric workflow. I downloaded [cordova-ios
4.1.0|https://github.com/apache/cordova-ios/releases] and ran
{{cordova-ios-4.1.0/bin/update}} on my project.
In addition to the usual upgrades, it made the following unexpected changes:
* Deleted all images in {{/MyProject/Images.xcassets/AppIcon.appiconset}} and
{{/MyProject/Images.xcassets/LaunchImage.launchimage}}, and replaced them with
Cordova defaults.
* Deleted all plugin code in {{/MyProject/Plugins}}.
* Replaced {{/config.xml}} with the default, e.g. {{HelloCordova}}.
* Replaced {{/MyProject-Info.plist}} with the default.
This hasn't happened in any previous upgrades.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186114#comment-15186114
]
ASF GitHub Bot commented on CB-7862:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55451426
--- Diff: www/FileReader.js ---
@@ -96,6 +106,78 @@ function initRead(reader, file) {
}
/**
+ * Callback used by the following read* functions to handle incremental or
final success.
+ * Must be bound to the FileReader's this along with all but the last
parameter,
+ * e.g. readSuccessCallback.bind(this, "readAsText", "UTF-8", offset,
totalSize, accumulate)
+ * @param readType The name of the read function to call.
+ * @param encoding Text encoding, or null if this is not a text type read.
+ * @param offset Starting offset of the read.
+ * @param totalSize Total number of bytes or chars to read.
+ * @param accumulate A function that takes the callback result and
accumulates it in this._result.
+ * @param r Callback result returned by the last read exec() call, or null
to begin reading.
+ */
+function readSuccessCallback(readType, encoding, offset, totalSize,
accumulate, r) {
+if (this._readyState === FileReader.DONE) {
+return;
+}
+
+if (typeof r !== "undefined") {
+accumulate(r);
+this._progress = Math.min(this._progress +
FileReader.READ_CHUNK_SIZE, totalSize);
+
+if (typeof this.onprogress === "function") {
+this.onprogress(new ProgressEvent("progress",
{loaded:this._progress, total:totalSize}));
+}
+}
+
+if (typeof r === "undefined" || this._progress < totalSize) {
+var execArgs = [
+this._localURL,
+offset + this._progress,
+offset + this._progress + Math.min(totalSize - this._progress,
FileReader.READ_CHUNK_SIZE)];
+if (encoding) {
--- End diff --
Nitpick: It would be nice to have a comment explaining that you only insert
the encoding when reading as text
> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied.
> I use http://ngcordova.com/ and here is my code
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value
[ https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Ginchereau resolved CB-10577. --- Resolution: Fixed > Android plugin file: resolveLocalFileSystemURL produce incorrect value > -- > > Key: CB-10577 > URL: https://issues.apache.org/jira/browse/CB-10577 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: vldm >Priority: Critical > Labels: android, triaged > Attachments: index.js > > > On android resolveLocalFileSystemURL sets isDirectory and isFile properties > based on argument URL having trailing slash, and not on actual object type. > See attached test program, which currently outputs the following: > cdvfile://localhost/temporary/tst is file > cdvfile://localhost/temporary/tst/ is directory > Correct output shall be: > cdvfile://localhost/temporary/tst is directory > cdvfile://localhost/temporary/tst/ is directory -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10798) Cannot create folder into cordova.file.externalRootDirectory on Android 6.x Marshmallow
[
https://issues.apache.org/jira/browse/CB-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186095#comment-15186095
]
Jason Ginchereau commented on CB-10798:
---
Or perhaps externalRootDirectory should not be deprecated, but this limitation
on Android 6+ should just be documented in the plugin quirks. Having the
externalDataDirectory path available may still be useful to applications which
do not intend to write directly to that root, but rather may intend to read or
write files in one of the media-specific subdirectories.
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow
> ---
>
> Key: CB-10798
> URL: https://issues.apache.org/jira/browse/CB-10798
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.1.1
> Environment: Android 6.0.1 (Nexus 9 and other 6.x devices), Cordova
> cli 6.0.0, Android platform 5.1.0
>Reporter: Vito Macchia
>Assignee: Jason Ginchereau
> Labels: android, triaged
>
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow. It always returns encording error (12), while on Android 5.x
> (Lollipop) the same code works fine.
> On Marshmallow devices I can succesfully create folders only into
> cordova.file.externalDataDirectory.
> No matter the value of preference AndroidPersistentFileLocation or
> AndroidExtraFilesystems.
> Code (some ES6, sorry)
> This snippet uses WinJS Promises - should work with native promises as well
> or you can just remove promises and pass succes and fail callbacks. It should
> create MY_Folder/test (both folders, like mkdirp) in the SD Card (regardless
> if emulated or not) root directory. It works fine with 5.x devices, but
> returns always FileError.ENCODING_ERR on Marshmallow.
> {code:title=createDirectory.js|borderStyle=solid}
> function errorCode(e) {
> var msg = '';
> switch (e.code) {
> case FileError.ABORT_ERR:
> msg = 'ABORT_ERR';
> break;
> case FileError.ENCODING_ERR:
> msg = 'ENCODING_ERR';
> break;
> case FileError.NOT_READABLE_ERR:
> msg = 'NOT_READABLE_ERR';
> break;
> case FileError.PATH_EXISTS_ERR:
> msg = 'PATH_EXISTS_ERR';
> break;
> case FileError.QUOTA_EXCEEDED_ERR:
> msg = 'QUOTA_EXCEEDED_ERR';
> break;
> case FileError.NOT_FOUND_ERR:
> msg = 'NOT_FOUND_ERR';
> break;
> case FileError.SECURITY_ERR:
> msg = 'SECURITY_ERR';
> break;
> case FileError.INVALID_MODIFICATION_ERR:
> msg = 'INVALID_MODIFICATION_ERR';
> break;
> case FileError.INVALID_STATE_ERR:
> msg = 'INVALID_STATE_ERR';
> break;
> default:
> msg = 'Unknown Error';
> break;
> };
> console.log('Error: ' + msg, "CODE", e);
> return msg;
> }
> const STATIC_CONTENT_DIR = 'MY_Folder/test';
> function createDirectory(startDirectory = cordova.file.externalRootDirectory)
> {
> return new WinJS.Promise(function(success, fail) {
> window.resolveLocalFileSystemURL(startDirectory, function(directory) {
> console.log("FS ROOT", directory);
> function fileGetDir(path, cb) {
> console.log("*** PATH", path);
> var fnGetOrCreateDir = function(p, de) {
> var entry = p.shift();
> console.log("PATH", path);
> if (entry) {
> de.getDirectory(entry, {
> create: true,
> exclusive: false
> }, function(dirEntry) {
> console.log("CR", dirEntry);
> fnGetOrCreateDir(p, dirEntry);
> }, fileFSError);
> } else
> if (cb) cb(de);
> };
> if (path) {
> var arPath = path.split("/");
> fnGetOrCreateDir(arPath, directory.filesystem.root);
> } else {
> if (cb) cb(directory);
> }
> }
> fileGetDir(STATIC_CONTENT_DIR, onSuccess);
> }, fileFSError);
> function fileFSError(e) {
> console.log(e.code);
> try {
> console.log("fileFSError: " + JSON.stringify(e) +
> errorCode(e));
> fail(e);
> } catch (err) {
> fail(err);
> }
> }
> function onSuccess(dirEntry) {
>
[jira] [Commented] (CB-10798) Cannot create folder into cordova.file.externalRootDirectory on Android 6.x Marshmallow
[
https://issues.apache.org/jira/browse/CB-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186082#comment-15186082
]
Jason Ginchereau commented on CB-10798:
---
I've verified that this repros on Android 6.x, and not on 5.x. It appears
Android 6.x simply blocks any writes to the external root directory.
[~lamuertepeluda], can you explain why you want to write to this directory? The
[relevant Android
documentation|http://developer.android.com/reference/android/os/Environment.html#getExternalStorageDirectory()]
says "applications should not directly use this top-level directory". Instead
you should write to one of the media-specific subdirectories (Music, Pictures,
etc.) or the application-specific directory
(cordova.file.externalDataDirectory).
Cordova should probably deprecate the externalRootDirectory property and set it
to null on Android 6+. (Apps should not be relying on it anyway since it is
null on iOS and Windows platforms.)
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow
> ---
>
> Key: CB-10798
> URL: https://issues.apache.org/jira/browse/CB-10798
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.1.1
> Environment: Android 6.0.1 (Nexus 9 and other 6.x devices), Cordova
> cli 6.0.0, Android platform 5.1.0
>Reporter: Vito Macchia
>Assignee: Jason Ginchereau
> Labels: android, triaged
>
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow. It always returns encording error (12), while on Android 5.x
> (Lollipop) the same code works fine.
> On Marshmallow devices I can succesfully create folders only into
> cordova.file.externalDataDirectory.
> No matter the value of preference AndroidPersistentFileLocation or
> AndroidExtraFilesystems.
> Code (some ES6, sorry)
> This snippet uses WinJS Promises - should work with native promises as well
> or you can just remove promises and pass succes and fail callbacks. It should
> create MY_Folder/test (both folders, like mkdirp) in the SD Card (regardless
> if emulated or not) root directory. It works fine with 5.x devices, but
> returns always FileError.ENCODING_ERR on Marshmallow.
> {code:title=createDirectory.js|borderStyle=solid}
> function errorCode(e) {
> var msg = '';
> switch (e.code) {
> case FileError.ABORT_ERR:
> msg = 'ABORT_ERR';
> break;
> case FileError.ENCODING_ERR:
> msg = 'ENCODING_ERR';
> break;
> case FileError.NOT_READABLE_ERR:
> msg = 'NOT_READABLE_ERR';
> break;
> case FileError.PATH_EXISTS_ERR:
> msg = 'PATH_EXISTS_ERR';
> break;
> case FileError.QUOTA_EXCEEDED_ERR:
> msg = 'QUOTA_EXCEEDED_ERR';
> break;
> case FileError.NOT_FOUND_ERR:
> msg = 'NOT_FOUND_ERR';
> break;
> case FileError.SECURITY_ERR:
> msg = 'SECURITY_ERR';
> break;
> case FileError.INVALID_MODIFICATION_ERR:
> msg = 'INVALID_MODIFICATION_ERR';
> break;
> case FileError.INVALID_STATE_ERR:
> msg = 'INVALID_STATE_ERR';
> break;
> default:
> msg = 'Unknown Error';
> break;
> };
> console.log('Error: ' + msg, "CODE", e);
> return msg;
> }
> const STATIC_CONTENT_DIR = 'MY_Folder/test';
> function createDirectory(startDirectory = cordova.file.externalRootDirectory)
> {
> return new WinJS.Promise(function(success, fail) {
> window.resolveLocalFileSystemURL(startDirectory, function(directory) {
> console.log("FS ROOT", directory);
> function fileGetDir(path, cb) {
> console.log("*** PATH", path);
> var fnGetOrCreateDir = function(p, de) {
> var entry = p.shift();
> console.log("PATH", path);
> if (entry) {
> de.getDirectory(entry, {
> create: true,
> exclusive: false
> }, function(dirEntry) {
> console.log("CR", dirEntry);
> fnGetOrCreateDir(p, dirEntry);
> }, fileFSError);
> } else
> if (cb) cb(de);
> };
> if (path) {
> var arPath = path.split("/");
> fnGetOrCreateDir(arPath, directory.filesystem.root);
> } else {
> if (cb) cb(directory);
> }
>
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186077#comment-15186077 ] ASF GitHub Bot commented on CB-10679: - Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194025822 Thanks @riknoll!! > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186075#comment-15186075 ] ASF GitHub Bot commented on CB-10679: - Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194025033 Added you both as owners. The tests use cordova-android version 3.1.0, which is checked into cordova-lib: ``` cordova-lib/cordova-lib/spec-cordova/fixtures/platforms/android ``` > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10549) TOC links broken in 6.0.0 on website
[ https://issues.apache.org/jira/browse/CB-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Blotsky closed CB-10549. --- > TOC links broken in 6.0.0 on website > > > Key: CB-10549 > URL: https://issues.apache.org/jira/browse/CB-10549 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll >Priority: Critical > Labels: regression, triaged > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10803) Slugify scheme does not escape '/'
[ https://issues.apache.org/jira/browse/CB-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Blotsky resolved CB-10803. - Resolution: Fixed > Slugify scheme does not escape '/' > -- > > Key: CB-10803 > URL: https://issues.apache.org/jira/browse/CB-10803 > Project: Apache Cordova > Issue Type: Bug > Components: Website >Reporter: Nikhil Khandelwal >Assignee: Dmitry Blotsky >Priority: Minor > > Anchor reference for this heading: > How WinJS accesses native/managed code > in page does not work correctly: > http://cordova.apache.org/docs/en/dev/guide/platforms/win8/plugin.html > My guess it is because of the '/' in the title. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10803) Slugify scheme does not escape '/'
[ https://issues.apache.org/jira/browse/CB-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186065#comment-15186065 ] Dmitry Blotsky commented on CB-10803: - [~nikhilkh]: please review the fix. > Slugify scheme does not escape '/' > -- > > Key: CB-10803 > URL: https://issues.apache.org/jira/browse/CB-10803 > Project: Apache Cordova > Issue Type: Bug > Components: Website >Reporter: Nikhil Khandelwal >Assignee: Dmitry Blotsky >Priority: Minor > > Anchor reference for this heading: > How WinJS accesses native/managed code > in page does not work correctly: > http://cordova.apache.org/docs/en/dev/guide/platforms/win8/plugin.html > My guess it is because of the '/' in the title. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186062#comment-15186062 ] ASF GitHub Bot commented on CB-10679: - Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194021132 LGTM. Question though, what version of android are the tests using? What version gets fetched (1.1.2 it looks like)? Maybe add vlad and me as owners to the module on npm. Always smart to have a few people who can publish if needed. `npm owner add stevegill cordova-lib-test-plugin` `npm owner add kotikov.vladimir cordova-lib-test-plugin` > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186025#comment-15186025
]
ASF GitHub Bot commented on CB-7862:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443925
--- Diff: tests/tests.js ---
@@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () {
expect(true).toFailWithMessage('Platform does not
supported this feature');
done();
}
-runReaderTest('readAsArrayBuffer', true, done, function
(evt, fileData, fileDataAsBinaryString) {
+runReaderTest('readAsArrayBuffer', true, done, null,
function (evt, fileData, fileDataAsBinaryString) {
expect(arrayBufferEqualsString(evt.target.result,
fileDataAsBinaryString.slice(0, -1))).toBe(true);
done();
}, 0, -1);
});
-});
+it("file.spec.94.5 should read large file in multiple chunks,
readAsArrayBuffer", function (done) {
+// Skip test if ArrayBuffers are not supported (e.g.:
Android 2.3).
+if (typeof window.ArrayBuffer == 'undefined') {
+expect(true).toFailWithMessage('Platform does not
supported this feature');
--- End diff --
A, I guess leave it as is and we can correct it all at once later
> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied.
> I use http://ngcordova.com/ and here is my code
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186023#comment-15186023
]
ASF GitHub Bot commented on CB-7862:
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443750
--- Diff: tests/tests.js ---
@@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () {
expect(true).toFailWithMessage('Platform does not
supported this feature');
done();
}
-runReaderTest('readAsArrayBuffer', true, done, function
(evt, fileData, fileDataAsBinaryString) {
+runReaderTest('readAsArrayBuffer', true, done, null,
function (evt, fileData, fileDataAsBinaryString) {
expect(arrayBufferEqualsString(evt.target.result,
fileDataAsBinaryString.slice(0, -1))).toBe(true);
done();
}, 0, -1);
});
-});
+it("file.spec.94.5 should read large file in multiple chunks,
readAsArrayBuffer", function (done) {
+// Skip test if ArrayBuffers are not supported (e.g.:
Android 2.3).
+if (typeof window.ArrayBuffer == 'undefined') {
+expect(true).toFailWithMessage('Platform does not
supported this feature');
--- End diff --
This is copied from a bunch of other tests. Should I update all of those
too?
> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied.
> I use http://ngcordova.com/ and here is my code
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186019#comment-15186019
]
ASF GitHub Bot commented on CB-7862:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443467
--- Diff: tests/tests.js ---
@@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () {
expect(true).toFailWithMessage('Platform does not
supported this feature');
done();
}
-runReaderTest('readAsArrayBuffer', true, done, function
(evt, fileData, fileDataAsBinaryString) {
+runReaderTest('readAsArrayBuffer', true, done, null,
function (evt, fileData, fileDataAsBinaryString) {
expect(arrayBufferEqualsString(evt.target.result,
fileDataAsBinaryString.slice(0, -1))).toBe(true);
done();
}, 0, -1);
});
-});
+it("file.spec.94.5 should read large file in multiple chunks,
readAsArrayBuffer", function (done) {
+// Skip test if ArrayBuffers are not supported (e.g.:
Android 2.3).
+if (typeof window.ArrayBuffer == 'undefined') {
+expect(true).toFailWithMessage('Platform does not
supported this feature');
--- End diff --
supported -> support
> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied.
> I use http://ngcordova.com/ and here is my code
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186020#comment-15186020
]
ASF GitHub Bot commented on CB-7862:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443526
--- Diff: tests/tests.js ---
@@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () {
expect(true).toFailWithMessage('Platform does not
supported this feature');
done();
}
-runReaderTest('readAsArrayBuffer', true, done, function
(evt, fileData, fileDataAsBinaryString) {
+runReaderTest('readAsArrayBuffer', true, done, null,
function (evt, fileData, fileDataAsBinaryString) {
expect(arrayBufferEqualsString(evt.target.result,
fileDataAsBinaryString.slice(0, -1))).toBe(true);
done();
}, 0, -1);
});
-});
+it("file.spec.94.5 should read large file in multiple chunks,
readAsArrayBuffer", function (done) {
+// Skip test if ArrayBuffers are not supported (e.g.:
Android 2.3).
+if (typeof window.ArrayBuffer == 'undefined') {
+expect(true).toFailWithMessage('Platform does not
supported this feature');
--- End diff --
Also, shouldn't this just be pending?
> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied.
> I use http://ngcordova.com/ and here is my code
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value
[ https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186010#comment-15186010 ] ASF subversion and git services commented on CB-10577: -- Commit 3e09b31fd7530e02a2f70ea3d7b8d53cd99941cc in cordova-plugin-file's branch refs/heads/master from [~jasongin] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=3e09b31 ] CB-10577: Android resolveLocalFileSystemURL should detect directory vs file. This closes #167 > Android plugin file: resolveLocalFileSystemURL produce incorrect value > -- > > Key: CB-10577 > URL: https://issues.apache.org/jira/browse/CB-10577 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: vldm >Priority: Critical > Labels: android, triaged > Attachments: index.js > > > On android resolveLocalFileSystemURL sets isDirectory and isFile properties > based on argument URL having trailing slash, and not on actual object type. > See attached test program, which currently outputs the following: > cdvfile://localhost/temporary/tst is file > cdvfile://localhost/temporary/tst/ is directory > Correct output shall be: > cdvfile://localhost/temporary/tst is directory > cdvfile://localhost/temporary/tst/ is directory -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value
[ https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186011#comment-15186011 ] ASF GitHub Bot commented on CB-10577: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/167 > Android plugin file: resolveLocalFileSystemURL produce incorrect value > -- > > Key: CB-10577 > URL: https://issues.apache.org/jira/browse/CB-10577 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: vldm >Priority: Critical > Labels: android, triaged > Attachments: index.js > > > On android resolveLocalFileSystemURL sets isDirectory and isFile properties > based on argument URL having trailing slash, and not on actual object type. > See attached test program, which currently outputs the following: > cdvfile://localhost/temporary/tst is file > cdvfile://localhost/temporary/tst/ is directory > Correct output shall be: > cdvfile://localhost/temporary/tst is directory > cdvfile://localhost/temporary/tst/ is directory -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[ https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186005#comment-15186005 ] ASF GitHub Bot commented on CB-7862: Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/168#issuecomment-194003277 @rakatyal or @riknoll please review > FileReader reads large files in a single chunk causing OOM exceptions > - > > Key: CB-7862 > URL: https://issues.apache.org/jira/browse/CB-7862 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 4.0.0 > Environment: Android >Reporter: shenzhuxi >Assignee: Jason Ginchereau >Priority: Critical > > In Android, I tried to copy a 14MB file from html file input with > org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied. > I use http://ngcordova.com/ and here is my code > https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185992#comment-15185992 ] ASF GitHub Bot commented on CB-10679: - GitHub user riknoll opened a pull request: https://github.com/apache/cordova-cli/pull/238 CB-10679: Adding explanation for plugin version selection to plugin help This was just merged into cordova-lib. I wasn't totally sure where to add this blurb and decided on the current location after discussing with @dblotsky. @nikhilkh please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli CB-10679 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #238 commit 6793a1231ea0dab9c3c18aaf89bfab79ddfc174c Author: riknoll Date: 2016-03-08T22:35:35Z CB-10679: Adding explanation for plugin version selection to plugin help > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10703) cordova-lib fails to install on NPM@3.3.12
[
https://issues.apache.org/jira/browse/CB-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185973#comment-15185973
]
Dmitry Blotsky commented on CB-10703:
-
Edited to add the output.
> cordova-lib fails to install on NPM@3.3.12
> --
>
> Key: CB-10703
> URL: https://issues.apache.org/jira/browse/CB-10703
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Reporter: Dmitry Blotsky
> Labels: triaged, wfc
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Make sure you have Node@~4 and NPM@~2. Then, run:
> {noformat}
> mkdir CB-10703
> cd CB-10703
> export HERE=`pwd`
> export npm_config_prefix=$HERE
> export NPM=$HERE/node_modules/.bin/npm
> npm install npm@3.7.3
> git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
> git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> pushd cordova-js; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link
> cordova-common; $NPM install; popd
> {noformat}
> Output:
> {noformat}
> npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
> npm ERR! Windows_NT 10.0.10586
> npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
> "c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
> npm ERR! node v0.12.9
> npm ERR! npm v3.3.12
> npm ERR! path
> c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
> npm ERR! code ENOENT
> npm ERR! errno -4058
> npm ERR! enoent ENOENT, chmod
> 'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a file.
> npm ERR! enoent
> npm ERR! Please include the following file with any support request:
> npm ERR! c:\CB-10703\cordova-lib\cordova-lib\npm-debug.log
> Signal 112 (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10703) cordova-lib fails to install on NPM@3.3.12
[
https://issues.apache.org/jira/browse/CB-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Blotsky updated CB-10703:
Description:
Make sure you have Node@~4 and NPM@~2. Then, run:
{noformat}
mkdir CB-10703
cd CB-10703
export HERE=`pwd`
export npm_config_prefix=$HERE
export NPM=$HERE/node_modules/.bin/npm
npm install npm@3.3.12
git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
pushd cordova-js; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link cordova-common;
$NPM install; popd
{noformat}
Output:
{noformat}
npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
"c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v0.12.9
npm ERR! npm v3.3.12
npm ERR! path
c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! enoent ENOENT, chmod
'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR! c:\CB-10703\cordova-lib\cordova-lib\npm-debug.log
Signal 112 (core dumped)
{noformat}
was:
Make sure you have Node@~4 and NPM@~2. Then, run:
{noformat}
mkdir CB-10703
cd CB-10703
export HERE=`pwd`
export npm_config_prefix=$HERE
export NPM=$HERE/node_modules/.bin/npm
npm install npm@3.7.3
git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
pushd cordova-js; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link cordova-common;
$NPM install; popd
{noformat}
Output:
{noformat}
npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
"c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v0.12.9
npm ERR! npm v3.3.12
npm ERR! path
c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! enoent ENOENT, chmod
'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR! c:\CB-10703\cordova-lib\cordova-lib\npm-debug.log
Signal 112 (core dumped)
{noformat}
> cordova-lib fails to install on NPM@3.3.12
> --
>
> Key: CB-10703
> URL: https://issues.apache.org/jira/browse/CB-10703
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Reporter: Dmitry Blotsky
> Labels: triaged, wfc
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Make sure you have Node@~4 and NPM@~2. Then, run:
> {noformat}
> mkdir CB-10703
> cd CB-10703
> export HERE=`pwd`
> export npm_config_prefix=$HERE
> export NPM=$HERE/node_modules/.bin/npm
> npm install npm@3.3.12
> git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
> git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> pushd cordova-js; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link
> cordova-common; $NPM install; popd
> {noformat}
> Output:
> {noformat}
> npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
> npm ERR! Windows_NT 10.0.10586
> npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
> "c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
> npm ERR! node v0.12.9
> npm ERR! npm v3.3.12
> npm ERR! path
> c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
> npm ERR! code ENOENT
> npm ERR! errno -4058
> npm ERR! enoent ENOENT, chmod
> 'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a
[jira] [Updated] (CB-10703) cordova-lib fails to install on NPM@3.3.12
[
https://issues.apache.org/jira/browse/CB-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Blotsky updated CB-10703:
Description:
Make sure you have Node@~4 and NPM@~2. Then, run:
{noformat}
mkdir CB-10703
cd CB-10703
export HERE=`pwd`
export npm_config_prefix=$HERE
export NPM=$HERE/node_modules/.bin/npm
npm install npm@3.7.3
git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
pushd cordova-js; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link cordova-common;
$NPM install; popd
{noformat}
Output:
{noformat}
npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
"c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v0.12.9
npm ERR! npm v3.3.12
npm ERR! path
c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! enoent ENOENT, chmod
'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR! c:\CB-10703\cordova-lib\cordova-lib\npm-debug.log
Signal 112 (core dumped)
{noformat}
was:
Make sure you have Node@~4 and NPM@~2. Then, run:
{noformat}
mkdir CB-10703
cd CB-10703
export HERE=`pwd`
export npm_config_prefix=$HERE
export NPM=$HERE/node_modules/.bin/npm
npm install npm@3.7.3
git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
pushd cordova-js; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link cordova-common;
$NPM install; popd
{noformat}
Output:
{noformat}
npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
"c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v0.12.9
npm ERR! npm v3.3.12
npm ERR! path
c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! enoent ENOENT, chmod
'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR! c:\CB-10703\cordova-lib\cordova-lib\npm-debug.log
Signal 112 (core dumped)
~/Developer/repositories/lol/CB-10703
{noformat}
> cordova-lib fails to install on NPM@3.3.12
> --
>
> Key: CB-10703
> URL: https://issues.apache.org/jira/browse/CB-10703
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Reporter: Dmitry Blotsky
> Labels: triaged, wfc
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Make sure you have Node@~4 and NPM@~2. Then, run:
> {noformat}
> mkdir CB-10703
> cd CB-10703
> export HERE=`pwd`
> export npm_config_prefix=$HERE
> export NPM=$HERE/node_modules/.bin/npm
> npm install npm@3.7.3
> git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
> git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> pushd cordova-js; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link
> cordova-common; $NPM install; popd
> {noformat}
> Output:
> {noformat}
> npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
> npm ERR! Windows_NT 10.0.10586
> npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
> "c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
> npm ERR! node v0.12.9
> npm ERR! npm v3.3.12
> npm ERR! path
> c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
> npm ERR! code ENOENT
> npm ERR! errno -4058
> npm ERR! enoent ENOENT, chmod
> 'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is rel
[jira] [Updated] (CB-10703) cordova-lib fails to install on NPM@3.3.12
[
https://issues.apache.org/jira/browse/CB-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Blotsky updated CB-10703:
Description:
Make sure you have Node@~4 and NPM@~2. Then, run:
{noformat}
mkdir CB-10703
cd CB-10703
export HERE=`pwd`
export npm_config_prefix=$HERE
export NPM=$HERE/node_modules/.bin/npm
npm install npm@3.7.3
git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
pushd cordova-js; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link cordova-common;
$NPM install; popd
{noformat}
Output:
{noformat}
npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
"c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v0.12.9
npm ERR! npm v3.3.12
npm ERR! path
c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! enoent ENOENT, chmod
'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR! c:\CB-10703\cordova-lib\cordova-lib\npm-debug.log
Signal 112 (core dumped)
~/Developer/repositories/lol/CB-10703
{noformat}
was:
Make sure you have Node@~4 and NPM@~2. Then, run:
{noformat}
mkdir CB-10703
cd CB-10703
export HERE=`pwd`
export npm_config_prefix=$HERE
export NPM=$HERE/node_modules/.bin/npm
npm install npm@3.7.3
git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
pushd cordova-js; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link cordova-common;
$NPM install; popd
{noformat}
> cordova-lib fails to install on NPM@3.3.12
> --
>
> Key: CB-10703
> URL: https://issues.apache.org/jira/browse/CB-10703
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Reporter: Dmitry Blotsky
> Labels: triaged, wfc
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Make sure you have Node@~4 and NPM@~2. Then, run:
> {noformat}
> mkdir CB-10703
> cd CB-10703
> export HERE=`pwd`
> export npm_config_prefix=$HERE
> export NPM=$HERE/node_modules/.bin/npm
> npm install npm@3.7.3
> git clone https://git-wip-us.apache.org/repos/asf/cordova-js.git
> git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git
> pushd cordova-js; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-common; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-serve; $NPM install; $NPM link; popd
> pushd cordova-lib/cordova-lib; $NPM link cordova-js; $NPM link
> cordova-common; $NPM install; popd
> {noformat}
> Output:
> {noformat}
> npm WARN EPACKAGEJSON cordova-lib@6.0.1-dev No license field.
> npm ERR! Windows_NT 10.0.10586
> npm ERR! argv "c:\\Program Files (x86)\\nodejs\\node.exe"
> "c:\\CB-10703\\node_modules\\npm\\bin\\npm-cli.js" "install"
> npm ERR! node v0.12.9
> npm ERR! npm v3.3.12
> npm ERR! path
> c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js
> npm ERR! code ENOENT
> npm ERR! errno -4058
> npm ERR! enoent ENOENT, chmod
> 'c:\CB-10703\cordova-lib\cordova-lib\node_modules\escodegen\node_modules\esprima\bin\esparse.js'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a file.
> npm ERR! enoent
> npm ERR! Please include the following file with any support request:
> npm ERR! c:\CB-10703\cordova-lib\cordova-lib\npm-debug.log
> Signal 112 (core dumped)
> ~/Developer/repositories/lol/CB-10703
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10737) Downloading docs silently accepts 404s
[ https://issues.apache.org/jira/browse/CB-10737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Blotsky closed CB-10737. --- Resolution: Fixed > Downloading docs silently accepts 404s > -- > > Key: CB-10737 > URL: https://issues.apache.org/jira/browse/CB-10737 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: Dmitry Blotsky >Assignee: Dmitry Blotsky > Labels: quickfix > Original Estimate: 2h > Remaining Estimate: 2h > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10739) Heading IDs in fetched files are not the same as GitHub
[ https://issues.apache.org/jira/browse/CB-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Blotsky closed CB-10739. --- Resolution: Fixed > Heading IDs in fetched files are not the same as GitHub > --- > > Key: CB-10739 > URL: https://issues.apache.org/jira/browse/CB-10739 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: Dmitry Blotsky >Assignee: Dmitry Blotsky >Priority: Minor > Original Estimate: 48h > Remaining Estimate: 48h > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10744) Fragment links in docs don't work in many cases
[
https://issues.apache.org/jira/browse/CB-10744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Blotsky closed CB-10744.
---
Resolution: Fixed
> Fragment links in docs don't work in many cases
> ---
>
> Key: CB-10744
> URL: https://issues.apache.org/jira/browse/CB-10744
> Project: Apache Cordova
> Issue Type: Bug
> Components: Docs
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Minor
>
> Cases that don't work:
> - using {{name="X"}} for fragment anchors
> - using special characters in IDs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions
[ https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185867#comment-15185867 ] ASF GitHub Bot commented on CB-7862: GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/168 CB-7862: FileReader reads large files in chunks with progress I added support in FileReader for reading large files in chunks and reporting progress for each chunk. Previously, the Cordova FileReader would always read files as a single chunk (resulting in OOM exceptions for files > 10 MB or so), and would NEVER invoke the onprogress callback. With this change, it's possible to read files with sizes up to the actual available application memory: I have verified with files over 500 MB. The default chunk size of 256 KB is based on some non-scientific timing tests I did: it yields only minor overhead from multiple exec() calls while still providing frequent-enough progress reports for large files. Much smaller chunk sizes could cause large file reads to take significantly longer due to the numerous exec() calls (and progress callbacks). The FileReader.READ_CHUNK_SIZE value is exposed and may be adjusted by app code, though I don't expect that is something that would need to be changed normally so I didn't add it to the plugin documentation. The added test case however does use that capability so that it can verify chunking and progress behavior without having to generate a very large file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasongin/cordova-plugin-file CB-7862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #168 commit 30f4a8810586dd048e17311f991a9b29315e7fde Author: Jason Ginchereau Date: 2016-03-08T21:11:21Z CB-7862: FileReader reads large files in chunks with progress > FileReader reads large files in a single chunk causing OOM exceptions > - > > Key: CB-7862 > URL: https://issues.apache.org/jira/browse/CB-7862 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 4.0.0 > Environment: Android >Reporter: shenzhuxi >Assignee: Jason Ginchereau >Priority: Critical > > In Android, I tried to copy a 14MB file from html file input with > org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied. > I use http://ngcordova.com/ and here is my code > https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10815) Android emulator sometimes shows as offline in the Windows CI
Richard B Knoll created CB-10815:
Summary: Android emulator sometimes shows as offline in the
Windows CI
Key: CB-10815
URL: https://issues.apache.org/jira/browse/CB-10815
Project: Apache Cordova
Issue Type: Test
Components: Medic
Environment: Windows
Reporter: Richard B Knoll
Priority: Minor
Occasionally, the Android emulator will start up but be "offline" and the build
will fail (running tests and getting logs). This is being marked as minor,
because the OS X Android builder works fine and this only happens roughly once
per day.
Relevant log for run step:
{code}
JAVA_HOME=C:\Program Files (x86)\Java\jdk1.7.0_55
[MEDIC LOG Tue, 08 Mar 2016 19:47:51 GMT] no device found, so switching to
emulator
[MEDIC LOG Tue, 08 Mar 2016 19:47:51 GMT] Attempting to start Android emulator
Error: Failed to deploy to device, no devices found.
{code}
Relevant log for log step:
{code}
[MEDIC LOG Tue, 08 Mar 2016 20:12:52 GMT] running:
[MEDIC LOG Tue, 08 Mar 2016 20:12:52 GMT] adb devices
List of devices attached
emulator-5554 offline
[MEDIC LOG Tue, 08 Mar 2016 20:12:53 GMT] running:
[MEDIC LOG Tue, 08 Mar 2016 20:12:53 GMT] adb logcat -d
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9393) Embedded use case is undocumented for Cordova-Android 4.0.x
[ https://issues.apache.org/jira/browse/CB-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185810#comment-15185810 ] ASF GitHub Bot commented on CB-9393: GitHub user infil00p opened a pull request: https://github.com/apache/cordova-docs/pull/544 CB-9393: Documenting how to embed a SystemWebView Redo of the pull request to update the SystemWebView documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-docs webview_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/544.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #544 commit 8c89253caba86b6ddbfc203332ecf46ec67350d2 Author: Joe Bowser Date: 2016-03-08T21:12:15Z CB-9393: Documenting how to embed a SystemWebView > Embedded use case is undocumented for Cordova-Android 4.0.x > --- > > Key: CB-9393 > URL: https://issues.apache.org/jira/browse/CB-9393 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 4.0.1 >Reporter: Joe Bowser >Assignee: Joe Bowser > Fix For: 5.0.0 > > > We broke the embedded webview use case for Android 4.0.x. and it's currently > difficult to embed a webview without some gradle editing. We should probably > work on getting the Embedded WebView use case to work out of the box for > Gradle, and in the meantime document all the workarounds for getting an > embedded webview in Android Studio to actually work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10814) Remove unneeded permissions
[ https://issues.apache.org/jira/browse/CB-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185755#comment-15185755 ] Tony Homer commented on CB-10814: - Mentioning [~riknoll] in case he wants to take this on. > Remove unneeded permissions > --- > > Key: CB-10814 > URL: https://issues.apache.org/jira/browse/CB-10814 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media Capture >Affects Versions: 1.2.0 >Reporter: Tony Homer > Labels: Android > > It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for > this plugin because it uses intents to record audio/video. > WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on > File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow > permission handling. > This task is to verify that these permissions can be removed and remove them. > -OR- > If it is determined that the permissions are actually needed, a > PermissionHandler class needs to be added for Marshmallow compatibility. > See CB-10670 for [background > discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10814) Remove unneeded permissions
[ https://issues.apache.org/jira/browse/CB-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Homer updated CB-10814: Description: It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for this plugin because it uses intents to record audio/video. WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow permission handling. This task is to verify that these permissions can be removed and remove them. - OR - If it is determined that the permissions are actually needed, a PermissionHandler class needs to be added for Marshmallow compatibility. See CB-10670 for [background discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. was: It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for this plugin because it uses intents to record audio/video. WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow permission handling. This task is to verify that these permissions can be removed and remove them. -OR- If it is determined that the permissions are actually needed, a PermissionHandler class needs to be added for Marshmallow compatibility. See CB-10670 for [background discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. > Remove unneeded permissions > --- > > Key: CB-10814 > URL: https://issues.apache.org/jira/browse/CB-10814 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media Capture >Affects Versions: 1.2.0 >Reporter: Tony Homer > Labels: Android > > It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for > this plugin because it uses intents to record audio/video. > WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on > File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow > permission handling. > This task is to verify that these permissions can be removed and remove them. > - OR - > If it is determined that the permissions are actually needed, a > PermissionHandler class needs to be added for Marshmallow compatibility. > See CB-10670 for [background > discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10814) Remove unneeded permissions
[ https://issues.apache.org/jira/browse/CB-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Homer updated CB-10814: Description: It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for this plugin because it uses intents to record audio/video. WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow permission handling. This task is to verify that these permissions can be removed and remove them. *OR* If it is determined that the permissions are actually needed, a PermissionHandler class needs to be added for Marshmallow compatibility. See CB-10670 for [background discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. was: It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for this plugin because it uses intents to record audio/video. WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow permission handling. This task is to verify that these permissions can be removed and remove them. - OR - If it is determined that the permissions are actually needed, a PermissionHandler class needs to be added for Marshmallow compatibility. See CB-10670 for [background discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. > Remove unneeded permissions > --- > > Key: CB-10814 > URL: https://issues.apache.org/jira/browse/CB-10814 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media Capture >Affects Versions: 1.2.0 >Reporter: Tony Homer > Labels: Android > > It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for > this plugin because it uses intents to record audio/video. > WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on > File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow > permission handling. > This task is to verify that these permissions can be removed and remove them. > *OR* > If it is determined that the permissions are actually needed, a > PermissionHandler class needs to be added for Marshmallow compatibility. > See CB-10670 for [background > discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10814) Remove unneeded permissions
Tony Homer created CB-10814: --- Summary: Remove unneeded permissions Key: CB-10814 URL: https://issues.apache.org/jira/browse/CB-10814 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Capture Affects Versions: 1.2.0 Reporter: Tony Homer It seems that the RECORD_AUDIO and RECORD_VIDEO should not be required for this plugin because it uses intents to record audio/video. WRITE_EXTERNAL_STORAGE should not be needed because this plugin depends on File plugin, which already uses WRITE_EXTERNAL_STORAGE and has Marshmallow permission handling. This task is to verify that these permissions can be removed and remove them. -OR- If it is determined that the permissions are actually needed, a PermissionHandler class needs to be added for Marshmallow compatibility. See CB-10670 for [background discussion|https://issues.apache.org/jira/browse/CB-10670?focusedCommentId=15185679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15185679]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10670) Media Capture on Android 6.0.1 fails
[
https://issues.apache.org/jira/browse/CB-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185741#comment-15185741
]
Tony Homer commented on CB-10670:
-
{quote}
My guess is that we are declaring them, but not actually using them because our
use of intents makes them irrelevant
{quote}
Yeah, that is what i was thinking about RECORD_AUDIO and RECORD_VIDEO - they
probably aren't needed.
Media capture probably does need WRITE_EXTERNAL_STORAGE, but media capture
depends on file and file gets WRITE_EXTERNAL_STORAGE and handles Marshmallow,
so this isn't an issue either.
I guess this ends up being cleanup that should be in a separate JIRA, just
thought I'd get your feedback before I logged it, since I had already written
my comment!
> Media Capture on Android 6.0.1 fails
>
>
> Key: CB-10670
> URL: https://issues.apache.org/jira/browse/CB-10670
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media Capture
>Affects Versions: 5.1.0
>Reporter: Christoph Brosdau
>Assignee: Richard B Knoll
>Priority: Critical
> Labels: Android, triaged
>
> Although this should work, I cannot make it work - on android 6.0, i always
> have the same issue concerning permissions - maybe I overlooked something,
> but I dont know what :)
> Whith the following super simple demo JS and latest Cordova and latest
> version of all plugins, I get:
> navigator.device.capture.captureVideo(function(){},function(e){console.log(e);},{limit:1});
> In the console, I get:
> Permission Denial: starting Intent { act=android.media.action.VIDEO_CAPTURE
> cmp=com.google.android.GoogleCamera/com.android.camera.VideoCamera (has
> extras) } from ProcessRecord{7481fe2 17042:tv.nexx.android.gdtv/u0a183}
> (pid=17042, uid=10183) with revoked permission android.permission.CAMERA
> In Android Studio I get:
> Uncaught exception from plugin
>
> java.lang.SecurityException: Permission Denial: starting Intent {
> act=android.media.action.IMAGE_CAPTURE flg=0x3
> cmp=com.google.android.GoogleCamera/com.android.camera.CaptureActivity
> clip={text/uri-list
> U:file:///storage/emulated/0/Android/data/tv.nexx.android.gdtv/cache/.Pic.jpg}
> (has extras) } from ProcessRecord{7481fe2 17042:tv.nexx.android.gdtv/u0a183}
> (pid=17042, uid=10183) with revoked permission android.permission.CAMERA
> at
> android.os.Parcel.readException(Parcel.java:1620)
> at
> android.os.Parcel.readException(Parcel.java:1573)
> at
> android.app.ActivityManagerProxy.startActivity(ActivityManagerNative.java:2658)
> at
> android.app.Instrumentation.execStartActivity(Instrumentation.java:1507)
> at
> android.app.Activity.startActivityForResult(Activity.java:3930)
> at
> org.apache.cordova.CordovaActivity.startActivityForResult(CordovaActivity.java:332)
> at
> android.app.Activity.startActivityForResult(Activity.java:3890)
> at
> org.apache.cordova.CordovaInterfaceImpl.startActivityForResult(CordovaInterfaceImpl.java:65)
> at
> org.apache.cordova.camera.CameraLauncher.takePicture(CameraLauncher.java:262)
> at
> org.apache.cordova.camera.CameraLauncher.callTakePicture(CameraLauncher.java:236)
> at
> org.apache.cordova.camera.CameraLauncher.execute(CameraLauncher.java:168)
> at
> org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:98)
> at
> org.apache.cordova.PluginManager.exec(PluginManager.java:133)
> at
> org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:59)
> at
> org.apache.cordova.engine.SystemExposedJsApi.exec(SystemExposedJsApi.java:41)
> at
> org.chromium.base.SystemMessageHandler.n
[jira] [Commented] (CB-10670) Media Capture on Android 6.0.1 fails
[
https://issues.apache.org/jira/browse/CB-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185719#comment-15185719
]
Richard B Knoll commented on CB-10670:
--
[~tony--] Something is fishy about those permission declarations. Those are
indeed dangerous permissions, but I don't see us requesting them (or any other
permissions) in the code. My guess is that we are declaring them, but not
actually using them because our use of intents makes them irrelevant. Looks
like they can be removed. We do need to add PermissionHelper for the fix to
this issue (CB-10670), however, because we need to request the CAMERA
permission just like we do for CB-10120. Unfortunately, the PR for CB-10120 is
blocked by an ICLA request so I can't just pull that code over for this issue.
I need to figure out what to do about that PR because a lot of people are
asking for it to be merged.
> Media Capture on Android 6.0.1 fails
>
>
> Key: CB-10670
> URL: https://issues.apache.org/jira/browse/CB-10670
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media Capture
>Affects Versions: 5.1.0
>Reporter: Christoph Brosdau
>Assignee: Richard B Knoll
>Priority: Critical
> Labels: Android, triaged
>
> Although this should work, I cannot make it work - on android 6.0, i always
> have the same issue concerning permissions - maybe I overlooked something,
> but I dont know what :)
> Whith the following super simple demo JS and latest Cordova and latest
> version of all plugins, I get:
> navigator.device.capture.captureVideo(function(){},function(e){console.log(e);},{limit:1});
> In the console, I get:
> Permission Denial: starting Intent { act=android.media.action.VIDEO_CAPTURE
> cmp=com.google.android.GoogleCamera/com.android.camera.VideoCamera (has
> extras) } from ProcessRecord{7481fe2 17042:tv.nexx.android.gdtv/u0a183}
> (pid=17042, uid=10183) with revoked permission android.permission.CAMERA
> In Android Studio I get:
> Uncaught exception from plugin
>
> java.lang.SecurityException: Permission Denial: starting Intent {
> act=android.media.action.IMAGE_CAPTURE flg=0x3
> cmp=com.google.android.GoogleCamera/com.android.camera.CaptureActivity
> clip={text/uri-list
> U:file:///storage/emulated/0/Android/data/tv.nexx.android.gdtv/cache/.Pic.jpg}
> (has extras) } from ProcessRecord{7481fe2 17042:tv.nexx.android.gdtv/u0a183}
> (pid=17042, uid=10183) with revoked permission android.permission.CAMERA
> at
> android.os.Parcel.readException(Parcel.java:1620)
> at
> android.os.Parcel.readException(Parcel.java:1573)
> at
> android.app.ActivityManagerProxy.startActivity(ActivityManagerNative.java:2658)
> at
> android.app.Instrumentation.execStartActivity(Instrumentation.java:1507)
> at
> android.app.Activity.startActivityForResult(Activity.java:3930)
> at
> org.apache.cordova.CordovaActivity.startActivityForResult(CordovaActivity.java:332)
> at
> android.app.Activity.startActivityForResult(Activity.java:3890)
> at
> org.apache.cordova.CordovaInterfaceImpl.startActivityForResult(CordovaInterfaceImpl.java:65)
> at
> org.apache.cordova.camera.CameraLauncher.takePicture(CameraLauncher.java:262)
> at
> org.apache.cordova.camera.CameraLauncher.callTakePicture(CameraLauncher.java:236)
> at
> org.apache.cordova.camera.CameraLauncher.execute(CameraLauncher.java:168)
> at
> org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:98)
> at
> org.apache.cordova.PluginManager.exec(PluginManager.java:133)
> at
> org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:59)
> at
> org.apache.cordova.engine.SystemExposedJsApi.exec(SystemEx
[jira] [Commented] (CB-10688) Cordova Plugin Splashscreen Readme must have examples
[ https://issues.apache.org/jira/browse/CB-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185718#comment-15185718 ] ASF GitHub Bot commented on CB-10688: - Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#issuecomment-193953081 Minor comments - LGTM otherwise > Cordova Plugin Splashscreen Readme must have examples > - > > Key: CB-10688 > URL: https://issues.apache.org/jira/browse/CB-10688 > Project: Apache Cordova > Issue Type: Task >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: Docs-6.x > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10688) Cordova Plugin Splashscreen Readme must have examples
[ https://issues.apache.org/jira/browse/CB-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185712#comment-15185712 ] ASF GitHub Bot commented on CB-10688: - Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r55421079 --- Diff: README.md --- @@ -44,6 +44,53 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord - Windows - Browser +## Example Configuration +In the top-level `config.xml` file (not the one in `platforms`), add configuration elements like those specified here. + +Please notice that the value of the "src" attribute is relative to the project directory and not to the www directory. You can name the source image whatever you like. The internal name in the app is determined by Cordova. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- 'windows8' => 'blackberry' > Cordova Plugin Splashscreen Readme must have examples > - > > Key: CB-10688 > URL: https://issues.apache.org/jira/browse/CB-10688 > Project: Apache Cordova > Issue Type: Task >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: Docs-6.x > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10688) Cordova Plugin Splashscreen Readme must have examples
[ https://issues.apache.org/jira/browse/CB-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185709#comment-15185709 ] ASF GitHub Bot commented on CB-10688: - Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r55420970 --- Diff: README.md --- @@ -44,6 +44,53 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord - Windows - Browser +## Example Configuration +In the top-level `config.xml` file (not the one in `platforms`), add configuration elements like those specified here. + +Please notice that the value of the "src" attribute is relative to the project directory and not to the www directory. You can name the source image whatever you like. The internal name in the app is determined by Cordova. + + --- End diff -- Consider using a '```xml' as below to get syntax highlighting on GitHub: ```xml ``` > Cordova Plugin Splashscreen Readme must have examples > - > > Key: CB-10688 > URL: https://issues.apache.org/jira/browse/CB-10688 > Project: Apache Cordova > Issue Type: Task >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: Docs-6.x > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10688) Cordova Plugin Splashscreen Readme must have examples
[ https://issues.apache.org/jira/browse/CB-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185691#comment-15185691 ] ASF GitHub Bot commented on CB-10688: - Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#issuecomment-193949335 @rakatyal @nikhilkh @dblotsky @daserge Fixed your comments. Please verify this PR > Cordova Plugin Splashscreen Readme must have examples > - > > Key: CB-10688 > URL: https://issues.apache.org/jira/browse/CB-10688 > Project: Apache Cordova > Issue Type: Task >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: Docs-6.x > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10670) Media Capture on Android 6.0.1 fails
[
https://issues.apache.org/jira/browse/CB-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185679#comment-15185679
]
Tony Homer commented on CB-10670:
-
[~riknoll] The latest release of media capture plugin has uses-permission
(RECORD_AUDIO, RECORD_VIDEO, WRITE_EXTERNAL_STORAGE) entries in plugin.xml but
does not include PermissionHelper. When I started writing this comment, I
thought this was related, but now that I've read over CB-10120 and the PR
discussion and reflected a bit, I guess this is not really related.
It seems incorrect for any plugin to have dangerous uses-permission entries in
plugin.xml but not have PermissionsHandler, do you agree? Should I open a new
JIRA for this? I'm not sure if some of the permissions should be removed
(because, similar to Camera plugin, intents are used so the plugin does not
itself require the permissions), but either way it seems like an issue...
> Media Capture on Android 6.0.1 fails
>
>
> Key: CB-10670
> URL: https://issues.apache.org/jira/browse/CB-10670
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media Capture
>Affects Versions: 5.1.0
>Reporter: Christoph Brosdau
>Assignee: Richard B Knoll
>Priority: Critical
> Labels: Android, triaged
>
> Although this should work, I cannot make it work - on android 6.0, i always
> have the same issue concerning permissions - maybe I overlooked something,
> but I dont know what :)
> Whith the following super simple demo JS and latest Cordova and latest
> version of all plugins, I get:
> navigator.device.capture.captureVideo(function(){},function(e){console.log(e);},{limit:1});
> In the console, I get:
> Permission Denial: starting Intent { act=android.media.action.VIDEO_CAPTURE
> cmp=com.google.android.GoogleCamera/com.android.camera.VideoCamera (has
> extras) } from ProcessRecord{7481fe2 17042:tv.nexx.android.gdtv/u0a183}
> (pid=17042, uid=10183) with revoked permission android.permission.CAMERA
> In Android Studio I get:
> Uncaught exception from plugin
>
> java.lang.SecurityException: Permission Denial: starting Intent {
> act=android.media.action.IMAGE_CAPTURE flg=0x3
> cmp=com.google.android.GoogleCamera/com.android.camera.CaptureActivity
> clip={text/uri-list
> U:file:///storage/emulated/0/Android/data/tv.nexx.android.gdtv/cache/.Pic.jpg}
> (has extras) } from ProcessRecord{7481fe2 17042:tv.nexx.android.gdtv/u0a183}
> (pid=17042, uid=10183) with revoked permission android.permission.CAMERA
> at
> android.os.Parcel.readException(Parcel.java:1620)
> at
> android.os.Parcel.readException(Parcel.java:1573)
> at
> android.app.ActivityManagerProxy.startActivity(ActivityManagerNative.java:2658)
> at
> android.app.Instrumentation.execStartActivity(Instrumentation.java:1507)
> at
> android.app.Activity.startActivityForResult(Activity.java:3930)
> at
> org.apache.cordova.CordovaActivity.startActivityForResult(CordovaActivity.java:332)
> at
> android.app.Activity.startActivityForResult(Activity.java:3890)
> at
> org.apache.cordova.CordovaInterfaceImpl.startActivityForResult(CordovaInterfaceImpl.java:65)
> at
> org.apache.cordova.camera.CameraLauncher.takePicture(CameraLauncher.java:262)
> at
> org.apache.cordova.camera.CameraLauncher.callTakePicture(CameraLauncher.java:236)
> at
> org.apache.cordova.camera.CameraLauncher.execute(CameraLauncher.java:168)
> at
> org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:98)
> at
> org.apache.cordova.PluginManager.exec(PluginManager.java:133)
> at
> org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:59)
> at
> org.apache.cordova.engine
[jira] [Assigned] (CB-10798) Cannot create folder into cordova.file.externalRootDirectory on Android 6.x Marshmallow
[
https://issues.apache.org/jira/browse/CB-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Ginchereau reassigned CB-10798:
-
Assignee: Jason Ginchereau
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow
> ---
>
> Key: CB-10798
> URL: https://issues.apache.org/jira/browse/CB-10798
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.1.1
> Environment: Android 6.0.1 (Nexus 9 and other 6.x devices), Cordova
> cli 6.0.0, Android platform 5.1.0
>Reporter: Vito Macchia
>Assignee: Jason Ginchereau
> Labels: android, triaged
>
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow. It always returns encording error (12), while on Android 5.x
> (Lollipop) the same code works fine.
> On Marshmallow devices I can succesfully create folders only into
> cordova.file.externalDataDirectory.
> No matter the value of preference AndroidPersistentFileLocation or
> AndroidExtraFilesystems.
> Code (some ES6, sorry)
> This snippet uses WinJS Promises - should work with native promises as well
> or you can just remove promises and pass succes and fail callbacks. It should
> create MY_Folder/test (both folders, like mkdirp) in the SD Card (regardless
> if emulated or not) root directory. It works fine with 5.x devices, but
> returns always FileError.ENCODING_ERR on Marshmallow.
> {code:title=createDirectory.js|borderStyle=solid}
> function errorCode(e) {
> var msg = '';
> switch (e.code) {
> case FileError.ABORT_ERR:
> msg = 'ABORT_ERR';
> break;
> case FileError.ENCODING_ERR:
> msg = 'ENCODING_ERR';
> break;
> case FileError.NOT_READABLE_ERR:
> msg = 'NOT_READABLE_ERR';
> break;
> case FileError.PATH_EXISTS_ERR:
> msg = 'PATH_EXISTS_ERR';
> break;
> case FileError.QUOTA_EXCEEDED_ERR:
> msg = 'QUOTA_EXCEEDED_ERR';
> break;
> case FileError.NOT_FOUND_ERR:
> msg = 'NOT_FOUND_ERR';
> break;
> case FileError.SECURITY_ERR:
> msg = 'SECURITY_ERR';
> break;
> case FileError.INVALID_MODIFICATION_ERR:
> msg = 'INVALID_MODIFICATION_ERR';
> break;
> case FileError.INVALID_STATE_ERR:
> msg = 'INVALID_STATE_ERR';
> break;
> default:
> msg = 'Unknown Error';
> break;
> };
> console.log('Error: ' + msg, "CODE", e);
> return msg;
> }
> const STATIC_CONTENT_DIR = 'MY_Folder/test';
> function createDirectory(startDirectory = cordova.file.externalRootDirectory)
> {
> return new WinJS.Promise(function(success, fail) {
> window.resolveLocalFileSystemURL(startDirectory, function(directory) {
> console.log("FS ROOT", directory);
> function fileGetDir(path, cb) {
> console.log("*** PATH", path);
> var fnGetOrCreateDir = function(p, de) {
> var entry = p.shift();
> console.log("PATH", path);
> if (entry) {
> de.getDirectory(entry, {
> create: true,
> exclusive: false
> }, function(dirEntry) {
> console.log("CR", dirEntry);
> fnGetOrCreateDir(p, dirEntry);
> }, fileFSError);
> } else
> if (cb) cb(de);
> };
> if (path) {
> var arPath = path.split("/");
> fnGetOrCreateDir(arPath, directory.filesystem.root);
> } else {
> if (cb) cb(directory);
> }
> }
> fileGetDir(STATIC_CONTENT_DIR, onSuccess);
> }, fileFSError);
> function fileFSError(e) {
> console.log(e.code);
> try {
> console.log("fileFSError: " + JSON.stringify(e) +
> errorCode(e));
> fail(e);
> } catch (err) {
> fail(err);
> }
> }
> function onSuccess(dirEntry) {
> console.log(dirEntry.fullPath);
> success(dirEntry.fullPath)
> }
> });
> }
> {code}
> I suspect it has something to do with the way the storage should be handled
> on Marshmallow, see for instance
> http://developer.android.com/guide/topics/data/data-storage.html and
> https://source.android.com/devices/storage/
--
This message was sent by Atlassian
[jira] [Commented] (CB-10798) Cannot create folder into cordova.file.externalRootDirectory on Android 6.x Marshmallow
[
https://issues.apache.org/jira/browse/CB-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185669#comment-15185669
]
Jason Ginchereau commented on CB-10798:
---
Note error code 12 is FileError.PATH_EXISTS_ERR (not ENCODING_ERR). So that
probably indicates that the externalRootDirectory path is incorrect. I'll
investigate further.
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow
> ---
>
> Key: CB-10798
> URL: https://issues.apache.org/jira/browse/CB-10798
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
>Affects Versions: 4.1.1
> Environment: Android 6.0.1 (Nexus 9 and other 6.x devices), Cordova
> cli 6.0.0, Android platform 5.1.0
>Reporter: Vito Macchia
> Labels: android, triaged
>
> Cannot create folder into cordova.file.externalRootDirectory on Android 6.x
> Marshmallow. It always returns encording error (12), while on Android 5.x
> (Lollipop) the same code works fine.
> On Marshmallow devices I can succesfully create folders only into
> cordova.file.externalDataDirectory.
> No matter the value of preference AndroidPersistentFileLocation or
> AndroidExtraFilesystems.
> Code (some ES6, sorry)
> This snippet uses WinJS Promises - should work with native promises as well
> or you can just remove promises and pass succes and fail callbacks. It should
> create MY_Folder/test (both folders, like mkdirp) in the SD Card (regardless
> if emulated or not) root directory. It works fine with 5.x devices, but
> returns always FileError.ENCODING_ERR on Marshmallow.
> {code:title=createDirectory.js|borderStyle=solid}
> function errorCode(e) {
> var msg = '';
> switch (e.code) {
> case FileError.ABORT_ERR:
> msg = 'ABORT_ERR';
> break;
> case FileError.ENCODING_ERR:
> msg = 'ENCODING_ERR';
> break;
> case FileError.NOT_READABLE_ERR:
> msg = 'NOT_READABLE_ERR';
> break;
> case FileError.PATH_EXISTS_ERR:
> msg = 'PATH_EXISTS_ERR';
> break;
> case FileError.QUOTA_EXCEEDED_ERR:
> msg = 'QUOTA_EXCEEDED_ERR';
> break;
> case FileError.NOT_FOUND_ERR:
> msg = 'NOT_FOUND_ERR';
> break;
> case FileError.SECURITY_ERR:
> msg = 'SECURITY_ERR';
> break;
> case FileError.INVALID_MODIFICATION_ERR:
> msg = 'INVALID_MODIFICATION_ERR';
> break;
> case FileError.INVALID_STATE_ERR:
> msg = 'INVALID_STATE_ERR';
> break;
> default:
> msg = 'Unknown Error';
> break;
> };
> console.log('Error: ' + msg, "CODE", e);
> return msg;
> }
> const STATIC_CONTENT_DIR = 'MY_Folder/test';
> function createDirectory(startDirectory = cordova.file.externalRootDirectory)
> {
> return new WinJS.Promise(function(success, fail) {
> window.resolveLocalFileSystemURL(startDirectory, function(directory) {
> console.log("FS ROOT", directory);
> function fileGetDir(path, cb) {
> console.log("*** PATH", path);
> var fnGetOrCreateDir = function(p, de) {
> var entry = p.shift();
> console.log("PATH", path);
> if (entry) {
> de.getDirectory(entry, {
> create: true,
> exclusive: false
> }, function(dirEntry) {
> console.log("CR", dirEntry);
> fnGetOrCreateDir(p, dirEntry);
> }, fileFSError);
> } else
> if (cb) cb(de);
> };
> if (path) {
> var arPath = path.split("/");
> fnGetOrCreateDir(arPath, directory.filesystem.root);
> } else {
> if (cb) cb(directory);
> }
> }
> fileGetDir(STATIC_CONTENT_DIR, onSuccess);
> }, fileFSError);
> function fileFSError(e) {
> console.log(e.code);
> try {
> console.log("fileFSError: " + JSON.stringify(e) +
> errorCode(e));
> fail(e);
> } catch (err) {
> fail(err);
> }
> }
> function onSuccess(dirEntry) {
> console.log(dirEntry.fullPath);
> success(dirEntry.fullPath)
> }
> });
> }
> {code}
> I suspect it has something to do with the way the storage should be handled
> on Marshmallow, see for instance
> http
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185659#comment-15185659 ] ASF GitHub Bot commented on CB-10679: - Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-193942230 @stevengill @vladimir-kotikov please review when you have a moment > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints
[ https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185639#comment-15185639 ] ASF GitHub Bot commented on CB-10679: - GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/406 CB-10679: Improving version choosing logic test coverage This adds a test plugin to improve our end to end tests related to the new plugin version choosing logic implementation. The plugin itself is empty and published to npm under my account: https://www.npmjs.com/package/cordova-lib-test-plugin . I also added a test case for git URLs, because we were missing one. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib test-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/406.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #406 commit 8eed08ef17d06cde56df1d2a42ec2f2f8124843e Author: riknoll Date: 2016-03-08T00:10:22Z CB-10679: Improving version choosing logic test coverage > Update plugin add behavior to allow plugins to list engine constraints > -- > > Key: CB-10679 > URL: https://issues.apache.org/jira/browse/CB-10679 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Let plugins specify their Cordova related dependencies in their package.json > so that the CLI can choose a compatible version for the current project. > Full specification is here: > https://github.com/cordova/cordova-discuss/pull/30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10813) Fix Hooks Guide
[ https://issues.apache.org/jira/browse/CB-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185636#comment-15185636 ] ASF GitHub Bot commented on CB-10813: - GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/543 CB-10813: Fix Hooks Guide Made the following changes: 1. Modified the column width to ensure that the commands are readable 2, Changed the commands for prepare, compile and build hooks. @axemclion @dblotsky @riknoll @rakatyal Can you please review and merge this PR? You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-docs CB-10813 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/543.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #543 commit c4b2ffe54d9e846cea3fe2b4b120318abc91690d Author: Sarangan Rajamanickam Date: 2016-03-08T19:44:45Z CB-10813: Fix Hooks Guide > Fix Hooks Guide > --- > > Key: CB-10813 > URL: https://issues.apache.org/jira/browse/CB-10813 > Project: Apache Cordova > Issue Type: Bug >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9832) requestFileSystem.js & resolveLocalFileSystemURI.js incorrect behavior
[ https://issues.apache.org/jira/browse/CB-9832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-9832: -- Component/s: (was: Browser) > requestFileSystem.js & resolveLocalFileSystemURI.js incorrect behavior > -- > > Key: CB-9832 > URL: https://issues.apache.org/jira/browse/CB-9832 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 2.1.0, 3.0.0 > Environment: cordova-plugin-file >Reporter: Denis Babineau >Assignee: Tim Barham > Labels: Browser > > fixes previously applied to said files fixes parse errors but incorrectly > changes the logic. See commits below (Updated resolveFileSystem.js so it can > be parsed by uglifyJS): > de403d0324d7c5d4e94c3d8a457d543d22871757 > 597e2d4543dd122d653a6572c89394d69ed9b717 > The logic to break out of the script when in Chrome has been wrapped in a > function, however the return now simply returns the function and the script > continues to execute below the call regardless of the conditions wrapped in > the function. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10813) Fix Hooks Guide
Sarangan Rajamanickam created CB-10813: -- Summary: Fix Hooks Guide Key: CB-10813 URL: https://issues.apache.org/jira/browse/CB-10813 Project: Apache Cordova Issue Type: Bug Reporter: Sarangan Rajamanickam Assignee: Sarangan Rajamanickam -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10812) Document defaults.xml in platform upgrade guides
Jacob Weber created CB-10812:
Summary: Document defaults.xml in platform upgrade guides
Key: CB-10812
URL: https://issues.apache.org/jira/browse/CB-10812
Project: Apache Cordova
Issue Type: Improvement
Components: Docs
Reporter: Jacob Weber
In the platform upgrade guides (e.g.
[here|https://cordova.apache.org/docs/en/latest/guide/platforms/android/upgrade.html]
and
[here|https://cordova.apache.org/docs/en/latest/guide/platforms/ios/upgrade.html]),
there should be some mention of the fact that, when you're upgrading projects
that don't use the Cordova CLI, you need to incorporate any changes to the
{{cordova/defaults.xml}} file.
For example, I recently upgraded an iOS project from 3.8.0 to 4.0.1. There were
several changes to defaults.xml, including things like {{}}, but they're not added by the upgrade script. Without
them, the behavior breaks in mysterious ways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10775) All plugins removed after update to 4.1.0 ios
[ https://issues.apache.org/jira/browse/CB-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185490#comment-15185490 ] Shazron Abdullah commented on CB-10775: --- I think this is the approach we should do. Talked to [~stevegill], and this will greatly help with the cordova-fetch work he is doing. I'll start a [DISCUSS] thread on dev@ regarding this > All plugins removed after update to 4.1.0 ios > - > > Key: CB-10775 > URL: https://issues.apache.org/jira/browse/CB-10775 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.1.0 > Environment: OSX 10.10 >Reporter: Matthias Max >Assignee: Shazron Abdullah > Labels: cordova-ios-4.1.1, triaged > Attachments: Bildschirmfoto 2016-03-03 um 23.45.02.png > > > I have updated to Cordova 4.1.0 due to the problems 4.0.1 had. > Now all my plugins are gone in the IONIC app. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10673) overlapped target-dir from two different plugins causes a failure.
[
https://issues.apache.org/jira/browse/CB-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185477#comment-15185477
]
Byoungro So commented on CB-10673:
--
Thank you very much for your valuable input and merging the pull requests,
[~nikhilkh]
> overlapped target-dir from two different plugins causes a
> failure.
>
>
> Key: CB-10673
> URL: https://issues.apache.org/jira/browse/CB-10673
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, iOS, Windows
>Reporter: Byoungro So
>Assignee: Byoungro So
> Labels: cordova-ios-4.1.1, pendingPR, triaged
>
> Cordova-android forces the target-dir of the tag to be unique
> for no reason.
> However, this causes an issue.
> It is always possible that two different plugins could have overlapped
> target-dir path.
> It is impossible for a plugin to know that the target-dir is overlapped with
> other plugins's target dir.
> So, we should relax this requirement.
> For example, cordova-sqlite-storage has the following in its plugin.xml.
> {code}
> target-dir="libs/armeabi"/>
> {code}
> com.intel.security has the following in its plugin.xml.
> {code}
>
> {code}
> When adding two plugins, cordova-android throws an exception.
> {code}
> [t6.0.1] cordova plugin add cordova-sqlite-storage@0.7.14
> Fetching plugin "cordova-sqlite-storage@0.7.14" via npm
> Installing "cordova-sqlite-storage" for android
> Installing "cordova-sqlite-storage" for ios
> [t6.0.1] cordova plugin add https://github.com/01org/AppSecurityApi.git#v1.4.1
> Fetching plugin "https://github.com/01org/AppSecurityApi.git"; via git clone
> Repository "https://github.com/01org/AppSecurityApi.git"; checked out to git
> ref "v1.4.1".
> Installing "com.intel.security" for android
> Failed to install 'com.intel.security':CordovaError: Uh oh!
> "/Users/bso/cordova/test/t6.0.1/platforms/android/libs/armeabi" already
> exists!
> at copyNewFile
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/lib/pluginHandlers.js:212:15)
> at handlers.source-file.install
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/lib/pluginHandlers.js:34:13)
> at Object.ActionStack.process
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at Api.addPlugin
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/Api.js:205:20)
> at handleInstall
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/src/plugman/install.js:598:6)
> at
> /Users/bso/cordova/bso-cordova-lib/cordova-lib/src/plugman/install.js:396:28
> at _fulfilled
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:509:49
> Error: Uh oh!
> "/Users/bso/cordova/test/t6.0.1/platforms/android/libs/armeabi" already
> exists!
> {code}
> I figured the same issue is present in cordova-ios and cordova-windows, too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10673) overlapped target-dir from two different plugins causes a failure.
[
https://issues.apache.org/jira/browse/CB-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Byoungro So closed CB-10673.
> overlapped target-dir from two different plugins causes a
> failure.
>
>
> Key: CB-10673
> URL: https://issues.apache.org/jira/browse/CB-10673
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, iOS, Windows
>Reporter: Byoungro So
>Assignee: Byoungro So
> Labels: cordova-ios-4.1.1, pendingPR, triaged
>
> Cordova-android forces the target-dir of the tag to be unique
> for no reason.
> However, this causes an issue.
> It is always possible that two different plugins could have overlapped
> target-dir path.
> It is impossible for a plugin to know that the target-dir is overlapped with
> other plugins's target dir.
> So, we should relax this requirement.
> For example, cordova-sqlite-storage has the following in its plugin.xml.
> {code}
> target-dir="libs/armeabi"/>
> {code}
> com.intel.security has the following in its plugin.xml.
> {code}
>
> {code}
> When adding two plugins, cordova-android throws an exception.
> {code}
> [t6.0.1] cordova plugin add cordova-sqlite-storage@0.7.14
> Fetching plugin "cordova-sqlite-storage@0.7.14" via npm
> Installing "cordova-sqlite-storage" for android
> Installing "cordova-sqlite-storage" for ios
> [t6.0.1] cordova plugin add https://github.com/01org/AppSecurityApi.git#v1.4.1
> Fetching plugin "https://github.com/01org/AppSecurityApi.git"; via git clone
> Repository "https://github.com/01org/AppSecurityApi.git"; checked out to git
> ref "v1.4.1".
> Installing "com.intel.security" for android
> Failed to install 'com.intel.security':CordovaError: Uh oh!
> "/Users/bso/cordova/test/t6.0.1/platforms/android/libs/armeabi" already
> exists!
> at copyNewFile
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/lib/pluginHandlers.js:212:15)
> at handlers.source-file.install
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/lib/pluginHandlers.js:34:13)
> at Object.ActionStack.process
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at Api.addPlugin
> (/Users/bso/cordova/test/t6.0.1/platforms/android/cordova/Api.js:205:20)
> at handleInstall
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/src/plugman/install.js:598:6)
> at
> /Users/bso/cordova/bso-cordova-lib/cordova-lib/src/plugman/install.js:396:28
> at _fulfilled
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/bso/cordova/bso-cordova-lib/cordova-lib/node_modules/q/q.js:509:49
> Error: Uh oh!
> "/Users/bso/cordova/test/t6.0.1/platforms/android/libs/armeabi" already
> exists!
> {code}
> I figured the same issue is present in cordova-ios and cordova-windows, too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10811) App crashes on iOS unless iOS debugger is open
Nikhil Gopal created CB-10811: - Summary: App crashes on iOS unless iOS debugger is open Key: CB-10811 URL: https://issues.apache.org/jira/browse/CB-10811 Project: Apache Cordova Issue Type: Bug Components: CordovaJS, iOS, Plugin Camera, Plugin File Transfer, Plugin InAppBrowser Affects Versions: 6.0.0 Environment: Mac OSX 10.11 Reporter: Nikhil Gopal This is a rather odd bug and I'm not sure how to debug it. I have an iOS app I'm developing for a university project. The app works, but only if I open up the iOS debugger window when trying to run the app in the iOS emulator. Otherwise, the app crashes with signal 9. Application 'UIKitApplication:edu.washington.explane[0x8ef3]' exited abnormally via signal. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10810) Callbacks on iOS
Sunny Cupertino created CB-10810: Summary: Callbacks on iOS Key: CB-10810 URL: https://issues.apache.org/jira/browse/CB-10810 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Reporter: Sunny Cupertino Both version 2.2.1 (the most recent in github) and 2.2.0 (the one linked from npm) don't callback when playing is finished in iOS. Version 2.2.1 works on android though. I went back to version 2.0.0 and that works well on iOS. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9393) Embedded use case is undocumented for Cordova-Android 4.0.x
[ https://issues.apache.org/jira/browse/CB-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185332#comment-15185332 ] ASF GitHub Bot commented on CB-9393: Github user infil00p closed the pull request at: https://github.com/apache/cordova-docs/pull/498 > Embedded use case is undocumented for Cordova-Android 4.0.x > --- > > Key: CB-9393 > URL: https://issues.apache.org/jira/browse/CB-9393 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 4.0.1 >Reporter: Joe Bowser >Assignee: Joe Bowser > Fix For: 5.0.0 > > > We broke the embedded webview use case for Android 4.0.x. and it's currently > difficult to embed a webview without some gradle editing. We should probably > work on getting the Embedded WebView use case to work out of the box for > Gradle, and in the meantime document all the workarounds for getting an > embedded webview in Android Studio to actually work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9393) Embedded use case is undocumented for Cordova-Android 4.0.x
[ https://issues.apache.org/jira/browse/CB-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185334#comment-15185334 ] ASF GitHub Bot commented on CB-9393: Github user infil00p commented on the pull request: https://github.com/apache/cordova-docs/pull/498#issuecomment-193884897 Redoing this pull request on a whole new branch, because this one-off is not going to work with all the changes @jcesarmobile is suggesting. > Embedded use case is undocumented for Cordova-Android 4.0.x > --- > > Key: CB-9393 > URL: https://issues.apache.org/jira/browse/CB-9393 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 4.0.1 >Reporter: Joe Bowser >Assignee: Joe Bowser > Fix For: 5.0.0 > > > We broke the embedded webview use case for Android 4.0.x. and it's currently > difficult to embed a webview without some gradle editing. We should probably > work on getting the Embedded WebView use case to work out of the box for > Gradle, and in the meantime document all the workarounds for getting an > embedded webview in Android Studio to actually work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
[ https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185315#comment-15185315 ] Jim Trainor commented on CB-10109: -- I believe it is your case number two. I am not loading from a remote host. All my javascript, html, and css, files are static. When I use the WKWebView plugin then Polymer won't load because it tries load a *local* html file using and XMLHttpRequest on a file:// url. The XHR request originates in Google's Polymer web components js library. It is loading Polymer elements at that point. I interpret this as the same behaviour that was reported by Frederik Wessberg insofar as interaction with Polymer is concerned. > Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open > --- > > Key: CB-10109 > URL: https://issues.apache.org/jira/browse/CB-10109 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > Labels: wkwebview-known-issues > > Because of CORS, you can only open requests using http*:// schemes, not file. > Ultimately this might be a new plugin. The plugin needs to: > 1. Run a local webserver > 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1) > The local webserver in (1) will route the requests using the appropriate > handler, and will need to utilize a secret to prevent unauthorized access. > Something like this: > https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
[
https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185239#comment-15185239
]
Carlos Santana edited comment on CB-10109 at 3/8/16 5:04 PM:
-
Which one is your problem?
1. Loading xhr template from a remote host (templates are not included inside
your app www and always remote)
2. Loading xhr template via relative path to file path (templates are inside
your app)
This will help determined which use case we concentrate first to solve.
Would embedding the template in the index.html like
{code}
...
Web Components
http://webcomponents.org/img/logo.svg";>
{code}
would not work?
was (Author: csantana):
Which one is your problem?
1. Loading xhr template from a remote host (templates are not included inside
your app www and always remote)
2. Loading xhr template via relative path to file path (templates are inside
your app)
This will help determined which use case we concentrate first to solve.
> Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
> ---
>
> Key: CB-10109
> URL: https://issues.apache.org/jira/browse/CB-10109
> Project: Apache Cordova
> Issue Type: Wish
> Components: Plugin WKWebViewEngine
>Reporter: Shazron Abdullah
> Labels: wkwebview-known-issues
>
> Because of CORS, you can only open requests using http*:// schemes, not file.
> Ultimately this might be a new plugin. The plugin needs to:
> 1. Run a local webserver
> 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1)
> The local webserver in (1) will route the requests using the appropriate
> handler, and will need to utilize a secret to prevent unauthorized access.
> Something like this:
> https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
[ https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185239#comment-15185239 ] Carlos Santana commented on CB-10109: - Which one is your problem? 1. Loading xhr template from a remote host (templates are not included inside your app www and always remote) 2. Loading xhr template via relative path to file path (templates are inside your app) This will help determined which use case we concentrate first to solve. > Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open > --- > > Key: CB-10109 > URL: https://issues.apache.org/jira/browse/CB-10109 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > Labels: wkwebview-known-issues > > Because of CORS, you can only open requests using http*:// schemes, not file. > Ultimately this might be a new plugin. The plugin needs to: > 1. Run a local webserver > 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1) > The local webserver in (1) will route the requests using the appropriate > handler, and will need to utilize a secret to prevent unauthorized access. > Something like this: > https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10723) iOS9.2 no audio
[ https://issues.apache.org/jira/browse/CB-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185163#comment-15185163 ] ASF GitHub Bot commented on CB-10723: - Github user FlossyWeb commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-193845735 Hi there, Thanks @gaelenh this definitely fixes the issue, please merge guys ! > iOS9.2 no audio > --- > > Key: CB-10723 > URL: https://issues.apache.org/jira/browse/CB-10723 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.2.0 > Environment: IonicFramework | ngCordova | cordova-plugin-media >Reporter: Johnny Dong >Assignee: Omar Mefire > Labels: easyfix, iOS, pendingPR, triaged > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Found an issue with the latest cordova.plugin.media whilst i was putting > together a IonicFramework app for iOS 9.2.1 (iPhone 6s) to play an M4A file. > The iOS logs would show: > - Found resource '[path].m4a' in the web folder. > Playing audio sample '[path].m4a' > - Playing stream with AVPlayer & custom rate > but no sound (both simulator + device) > Debugging in Xcode, ./cordova-plugin-media/src/ios/CDVSound.m,ln 352 + 355 > appears to be the culprit. > Instead of using "avPlayer" which doesn't appear to have a handle to the > sound resource, switching to "audioFile.player" appears to resolve the sound > issue. > *** ./cordova-plugin-media/src/ios/CDVSound.m,ln 352 > from: > [avPlayer setRate:customRate]; > to: > [audioFile.player setRate:customRate]; > *** ./cordova-plugin-media/src/ios/CDVSound.m,ln 355 > from: > [avPlayer play]; > to: > [audioFile.player play]; > NOTE: I've yet to create a PR as I have not signed the Apache ICLA, however > i've committed a code in my personal fork and happy for somebody to have a > look at it and submit on my behalf: > https://github.com/spudmashmedia/cordova-plugin-media/commit/946ffcf569cbaa22241e8ec00f11b4a52a0c6809 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10809) Medi plugin npm points to buggy version
Sunny Cupertino created CB-10809: Summary: Medi plugin npm points to buggy version Key: CB-10809 URL: https://issues.apache.org/jira/browse/CB-10809 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Reporter: Sunny Cupertino NPM points to version 2.2.0 of the plugin which is an old version where callbacks don't work. Version 2.2.1 in github works fine. Please update your npm link. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9161) Support iPad multitasking in iOS 9
[ https://issues.apache.org/jira/browse/CB-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185166#comment-15185166 ] Gaven Henry commented on CB-9161: - http://en.gg/enable-ipad-split-screen-feature-in-an-ionic-or-cordova-app/ Found this reference while doing some research about this. Might be helpful. It would be great to find a simple way to get this support in place. > Support iPad multitasking in iOS 9 > -- > > Key: CB-9161 > URL: https://issues.apache.org/jira/browse/CB-9161 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.0.0 > Environment: iOS 9 >Reporter: Shazron Abdullah > Labels: cordova-ios-5.0.x > Attachments: screenshot-1.png > > > This is to support SlideOver and SplitView. Note that SplitView is only > supported on iPad Air 2. > The three rules are: > 1. Build your apps with the iOS 9 SDK > 2. Support all orientations > 3. Use Launch Storyboards > We have 1 and 2 covered, but not 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10808) cordova template should have api to specify directory name with template content
[
https://issues.apache.org/jira/browse/CB-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carlos Santana updated CB-10808:
Description:
When creating an app using a template from npm like:
cordova create myapp --template my-cool-cdv-template
App is created with content of root of the npm pacakge.
By doing this all files are copied from the template.
In some cases some files are not desire to end up in the new app, files that
are related to testing, packaging, source control, etc..
Some files are:
package.json
And some time you want the new app to have a package.json provided by the
template but not the template's pacakge.json
We should implement same way we do cordova-app-hello-world npm package
main module exports an object with a property dirname
Example:
Content of package.tgz from npm
package.json
lib/
.gitignore
template_content/
template_content/package.json
template_content/www
template_content/config.xml
index.js
Content of package.json
{
"name": "my-cool-cdv-template",
"main": "./index.js"
}
Content of index.js:
path=require('path');
exports = {
"dirname": path.join(__dirname,'template_content');
}
proposed changes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L308
{code}
function copyTemplateFiles(templateDir, projectDir) {
var templateFiles; // Current file
var templatePkg;
var templateDir;
templatePkg = require(projectDir);
if(templatePkg && templatePkg.dirname){
templateDir = templatePkg.dirname;
} else {
templateDir = projectDir;
}
templateFiles = fs.readdirSync(templateDir);
//...
}
Also this calls would need to be adjusted to location aware
copyOrLink(paths.www, path.join(dir, 'www'), true);
copyOrLink(paths.merges, path.join(dir, 'merges'), true);
copyOrLink(paths.hooks, path.join(dir, 'hooks'),paths.hooksLinkable);
{code}
was:
When creating an app using a template from npm like:
cordova create myapp --template my-cool-cdv-template
App is created with content of root of the npm pacakge.
By doing this all files are copied from the template.
In some cases some files are not desire to end up in the new app, files that
are related to testing, packaging, source control, etc..
Some files are:
package.json
And some time you want the new app to have a package.json provided by the
template but not the template's pacakge.json
We should implement same way we do cordova-app-hello-world npm package
main module exports an object with a property dirname
Example:
Content of package.tgz from npm
package.json
lib/
.gitignore
template_content/
template_content/package.json
template_content/www
template_content/config.xml
index.js
Content of package.json
{
"name": "my-cool-cdv-template",
"main": "./index.js"
}
Content of index.js:
path=require('path');
exports = {
"dirname": path.join(__dirname,'template_content');
}
proposed changes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L308
{code}
function copyTemplateFiles(templateDir, projectDir) {
var templateFiles; // Current file
var templatePkg;
var templateDir;
templatePkg = require(projectDir);
if(templatePkg && templatePkg.dirname){
templateDir = templatePkg.dirname;
} else {
templateDir = projectDir;
}
templateFiles = fs.readdirSync(templateDir);
//...
}
{code}
> cordova template should have api to specify directory name with template
> content
>
>
> Key: CB-10808
> URL: https://issues.apache.org/jira/browse/CB-10808
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Reporter: Carlos Santana
>Assignee: Carlos Santana
>
> When creating an app using a template from npm like:
> cordova create myapp --template my-cool-cdv-template
> App is created with content of root of the npm pacakge.
> By doing this all files are copied from the template.
> In some cases some files are not desire to end up in the new app, files that
> are related to testing, packaging, source control, etc..
> Some files are:
> package.json
> And some time you want the new app to have a package.json provided by the
> template but not the template's pacakge.json
> We should implement same way we do cordova-app-hello-world npm package
> main module exports an object with a property dirname
> Example:
> Content of package.tgz from npm
> package.json
> lib/
> .gitignore
> template_content/
> template_content/package.json
> template_content/www
> template_content/config.xml
> index.js
> Content of package.json
> {
> "name": "my-cool-cdv-template",
> "main": "./inde
[jira] [Updated] (CB-10808) cordova template should have api to specify directory name with template content
[
https://issues.apache.org/jira/browse/CB-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carlos Santana updated CB-10808:
Description:
When creating an app using a template from npm like:
cordova create myapp --template my-cool-cdv-template
App is created with content of root of the npm pacakge.
By doing this all files are copied from the template.
In some cases some files are not desire to end up in the new app, files that
are related to testing, packaging, source control, etc..
Some files are:
package.json
And some time you want the new app to have a package.json provided by the
template but not the template's pacakge.json
We should implement same way we do cordova-app-hello-world npm package
main module exports an object with a property dirname
Example:
Content of package.tgz from npm
package.json
lib/
.gitignore
template_content/
template_content/package.json
template_content/www
template_content/config.xml
index.js
Content of package.json
{
"name": "my-cool-cdv-template",
"main": "./index.js"
}
Content of index.js:
path=require('path');
exports = {
"dirname": path.join(__dirname,'template_content');
}
proposed changes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L308
{code}
function copyTemplateFiles(templateDir, projectDir) {
var templateFiles; // Current file
var templatePkg;
var templateDir;
templatePkg = require(projectDir);
if(templatePkg && templatePkg.dirname){
templateDir = templatePkg.dirname;
} else {
templateDir = projectDir;
}
templateFiles = fs.readdirSync(templateDir);
//...
}
{code}
was:
When creating an app using a template from npm like:
cordova create myapp --template my-cool-cdv-template
App is created with content of root of the npm pacakge.
By doing this all files are copied from the template.
In some cases some files are not desire to end up in the new app, files that
are related to testing, packaging, source control, etc..
Some files are:
package.json
And some time you want the new app to have a package.json provided by the
template but not the template's pacakge.json
We should implement same way we do cordova-app-hello-world npm package
main module exports an object with a property dirname
Example:
Content of package.tgz from npm
package.json
lib/
.gitignore
template_content/
template_content/package.json
template_content/www
template_content/config.xml
index.js
Content of package.json
{
"name": "my-cool-cdv-template",
"main": "./index.js"
}
Content of template.js:
path=require('path');
exports = {
"dirname": path.join(__dirname,'template_content');
}
proposed changes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L308
{code}
function copyTemplateFiles(templateDir, projectDir) {
var templateFiles; // Current file
var templatePkg;
var templateDir;
templatePkg = require(projectDir);
if(templatePkg && templatePkg.dirname){
templateDir = templatePkg.dirname;
} else {
templateDir = projectDir;
}
templateFiles = fs.readdirSync(templateDir);
//...
}
{code}
> cordova template should have api to specify directory name with template
> content
>
>
> Key: CB-10808
> URL: https://issues.apache.org/jira/browse/CB-10808
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Reporter: Carlos Santana
>Assignee: Carlos Santana
>
> When creating an app using a template from npm like:
> cordova create myapp --template my-cool-cdv-template
> App is created with content of root of the npm pacakge.
> By doing this all files are copied from the template.
> In some cases some files are not desire to end up in the new app, files that
> are related to testing, packaging, source control, etc..
> Some files are:
> package.json
> And some time you want the new app to have a package.json provided by the
> template but not the template's pacakge.json
> We should implement same way we do cordova-app-hello-world npm package
> main module exports an object with a property dirname
> Example:
> Content of package.tgz from npm
> package.json
> lib/
> .gitignore
> template_content/
> template_content/package.json
> template_content/www
> template_content/config.xml
> index.js
> Content of package.json
> {
> "name": "my-cool-cdv-template",
> "main": "./index.js"
> }
> Content of index.js:
> path=require('path');
> exports = {
>"dirname": path.join(__dirname,'template_content');
> }
> proposed changes:
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js
[jira] [Updated] (CB-10808) cordova template should have api to specify directory name with template content
[
https://issues.apache.org/jira/browse/CB-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carlos Santana updated CB-10808:
Description:
When creating an app using a template from npm like:
cordova create myapp --template my-cool-cdv-template
App is created with content of root of the npm pacakge.
By doing this all files are copied from the template.
In some cases some files are not desire to end up in the new app, files that
are related to testing, packaging, source control, etc..
Some files are:
package.json
And some time you want the new app to have a package.json provided by the
template but not the template's pacakge.json
We should implement same way we do cordova-app-hello-world npm package
main module exports an object with a property dirname
Example:
Content of package.tgz from npm
package.json
lib/
.gitignore
template_content/
template_content/package.json
template_content/www
template_content/config.xml
index.js
Content of package.json
{
"name": "my-cool-cdv-template",
"main": "./index.js"
}
Content of template.js:
path=require('path');
exports = {
"dirname": path.join(__dirname,'template_content');
}
proposed changes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L308
{code}
function copyTemplateFiles(templateDir, projectDir) {
var templateFiles; // Current file
var templatePkg;
var templateDir;
templatePkg = require(projectDir);
if(templatePkg && templatePkg.dirname){
templateDir = templatePkg.dirname;
} else {
templateDir = projectDir;
}
templateFiles = fs.readdirSync(templateDir);
//...
}
{code}
was:
When creating an app using a template from npm like:
cordova create myapp --template my-cool-cdv-template
App is created with content of root of the npm pacakge.
By doing this all files are copied from the template.
In some cases some files are not desire to end up in the new app, files that
are related to testing, packaging, source control
Some files are:
package.json
And some time you want the new app to have a package.json provided by the
template but not the template's pacakge.json
We should implement same way we do cordova-app-hello-world npm package
main module exports an object with a property dirname
Example:
Content of package.tgz from npm
package.json
lib/
.gitignore
template_content/
template_content/package.json
template_content/www
template_content/config.xml
index.js
Content of package.json
{
"name": "my-cool-cdv-template",
"main": "./index.js"
}
Content of template.js:
path=require('path');
exports = {
"dirname": path.join(__dirname,'template_content');
}
proposed changes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L308
{code}
function copyTemplateFiles(templateDir, projectDir) {
var templateFiles; // Current file
var templatePkg;
var templateDir;
templatePkg = require(projectDir);
if(templatePkg && templatePkg.dirname){
templateDir = templatePkg.dirname;
} else {
templateDir = projectDir;
}
templateFiles = fs.readdirSync(templateDir);
//...
}
{code}
> cordova template should have api to specify directory name with template
> content
>
>
> Key: CB-10808
> URL: https://issues.apache.org/jira/browse/CB-10808
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
>Reporter: Carlos Santana
>Assignee: Carlos Santana
>
> When creating an app using a template from npm like:
> cordova create myapp --template my-cool-cdv-template
> App is created with content of root of the npm pacakge.
> By doing this all files are copied from the template.
> In some cases some files are not desire to end up in the new app, files that
> are related to testing, packaging, source control, etc..
> Some files are:
> package.json
> And some time you want the new app to have a package.json provided by the
> template but not the template's pacakge.json
> We should implement same way we do cordova-app-hello-world npm package
> main module exports an object with a property dirname
> Example:
> Content of package.tgz from npm
> package.json
> lib/
> .gitignore
> template_content/
> template_content/package.json
> template_content/www
> template_content/config.xml
> index.js
> Content of package.json
> {
> "name": "my-cool-cdv-template",
> "main": "./index.js"
> }
> Content of template.js:
> path=require('path');
> exports = {
>"dirname": path.join(__dirname,'template_content');
> }
> proposed changes:
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#
[jira] [Created] (CB-10808) cordova template should have api to specify directory name with template content
Carlos Santana created CB-10808:
---
Summary: cordova template should have api to specify directory
name with template content
Key: CB-10808
URL: https://issues.apache.org/jira/browse/CB-10808
Project: Apache Cordova
Issue Type: Improvement
Components: CLI
Reporter: Carlos Santana
Assignee: Carlos Santana
When creating an app using a template from npm like:
cordova create myapp --template my-cool-cdv-template
App is created with content of root of the npm pacakge.
By doing this all files are copied from the template.
In some cases some files are not desire to end up in the new app, files that
are related to testing, packaging, source control
Some files are:
package.json
And some time you want the new app to have a package.json provided by the
template but not the template's pacakge.json
We should implement same way we do cordova-app-hello-world npm package
main module exports an object with a property dirname
Example:
Content of package.tgz from npm
package.json
lib/
.gitignore
template_content/
template_content/package.json
template_content/www
template_content/config.xml
index.js
Content of package.json
{
"name": "my-cool-cdv-template",
"main": "./index.js"
}
Content of template.js:
path=require('path');
exports = {
"dirname": path.join(__dirname,'template_content');
}
proposed changes:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L308
{code}
function copyTemplateFiles(templateDir, projectDir) {
var templateFiles; // Current file
var templatePkg;
var templateDir;
templatePkg = require(projectDir);
if(templatePkg && templatePkg.dirname){
templateDir = templatePkg.dirname;
} else {
templateDir = projectDir;
}
templateFiles = fs.readdirSync(templateDir);
//...
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
[ https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184983#comment-15184983 ] Jim Trainor edited comment on CB-10109 at 3/8/16 2:44 PM: -- As reported by another commenter: a Polymer app won't load because it performs an XHR request to file:. A resolution to this issue would help. I tested wkwebview-engine-localhost and my polymer app does load using that plugin (which is a combination of this plugin plus a local web server). Note that wkwebview-engine-localhost introduce new problems with CORS requests. I haven't figured out if there is anyway to set a CORS header on the cordova-labs-local-webserver that wkwebview-engine-localhost uses. If there is a way to set a CORS header it is not obvious or well documented. was (Author: jptrainor): A reported by another commenter: a Polymer app won't load because it performs an XHR request to file:. A resolution to this issue would help. I tested wkwebview-engine-localhost and my polymer app does load using that plugin (which is a combination of this plugin plus a local web server). Note that wkwebview-engine-localhost introduce new problems with CORS requests. I haven't figured out if there is anyway to set a CORS header on the cordova-labs-local-webserver that wkwebview-engine-localhost uses. If there is a way to set a CORS header it is not obvious or well documented. > Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open > --- > > Key: CB-10109 > URL: https://issues.apache.org/jira/browse/CB-10109 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > Labels: wkwebview-known-issues > > Because of CORS, you can only open requests using http*:// schemes, not file. > Ultimately this might be a new plugin. The plugin needs to: > 1. Run a local webserver > 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1) > The local webserver in (1) will route the requests using the appropriate > handler, and will need to utilize a secret to prevent unauthorized access. > Something like this: > https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9528) create new core plugin to control screen orientation
[ https://issues.apache.org/jira/browse/CB-9528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184985#comment-15184985 ] Tony Homer commented on CB-9528: Thanks for continuing to promote this one. It is still on my to-do list, but other project work has taken more time than I had hoped (currently struggling with a release that has been delayed for 2 weeks). > create new core plugin to control screen orientation > > > Key: CB-9528 > URL: https://issues.apache.org/jira/browse/CB-9528 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Tony Homer >Assignee: Tony Homer > > Create a new core Cordova plugin that enables the user to dynamically control > the orientation of their app. > Tentatively base interface on [the screen-orientation spec| > http://www.w3.org/TR/screen-orientation/]. > There is a precedent for this behavior being supported as part of Cordova. > Previously iOS supported a non-standard approach to controlling the > orientation dynamically (see last entry in [this section of the 5.1.1 > docs|http://cordova.apache.org/docs/en/5.1.1/config_ref_index.md.html#The%20config.xml%20File_multi_platform_preferences]). > Recent platform changes made the iOS-specific approach untenable, but it's > removal prompted a discussion about enabling this as a cross-platform feature > via a new core plugin. > See related discussion in CB-8047. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
[ https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184983#comment-15184983 ] Jim Trainor commented on CB-10109: -- A reported by another commenter: a Polymer app won't load because it performs an XHR request to file:. A resolution to this issue would help. I tested wkwebview-engine-localhost and my polymer app does load using that plugin (which is a combination of this plugin plus a local web server). Note that wkwebview-engine-localhost introduce new problems with CORS requests. I haven't figured out if there is anyway to set a CORS header on the cordova-labs-local-webserver that wkwebview-engine-localhost uses. If there is a way to set a CORS header it is not obvious or well documented. > Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open > --- > > Key: CB-10109 > URL: https://issues.apache.org/jira/browse/CB-10109 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > Labels: wkwebview-known-issues > > Because of CORS, you can only open requests using http*:// schemes, not file. > Ultimately this might be a new plugin. The plugin needs to: > 1. Run a local webserver > 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1) > The local webserver in (1) will route the requests using the appropriate > handler, and will need to utilize a secret to prevent unauthorized access. > Something like this: > https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10807) Add a Travis badge for cordova-cli
[ https://issues.apache.org/jira/browse/CB-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shakhnazarov closed CB-10807. Resolution: Fixed > Add a Travis badge for cordova-cli > -- > > Key: CB-10807 > URL: https://issues.apache.org/jira/browse/CB-10807 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10807) Add a Travis badge for cordova-cli
[ https://issues.apache.org/jira/browse/CB-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shakhnazarov updated CB-10807: - Summary: Add a Travis badge for cordova-cli (was: Add Travis badge for cordova-cli) > Add a Travis badge for cordova-cli > -- > > Key: CB-10807 > URL: https://issues.apache.org/jira/browse/CB-10807 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10807) Add Travis badge for cordova-cli
Sergey Shakhnazarov created CB-10807: Summary: Add Travis badge for cordova-cli Key: CB-10807 URL: https://issues.apache.org/jira/browse/CB-10807 Project: Apache Cordova Issue Type: Improvement Components: CLI Reporter: Sergey Shakhnazarov Assignee: Sergey Shakhnazarov Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10748) Use cordova-common.CordovaLogger in CLI
[ https://issues.apache.org/jira/browse/CB-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184624#comment-15184624 ] ASF GitHub Bot commented on CB-10748: - Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-193655233 @nikhilkh > Are there still some test failures? No, tests should be green now. > Could you also add the travis badge for cordova-cli? Sure, will do. > Use cordova-common.CordovaLogger in CLI > --- > > Key: CB-10748 > URL: https://issues.apache.org/jira/browse/CB-10748 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > > We need to replace custom logging in CLI and platforms with now default > implementation from CB-10176. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10806) Anchors on events page don't work
jcesarmobile created CB-10806: - Summary: Anchors on events page don't work Key: CB-10806 URL: https://issues.apache.org/jira/browse/CB-10806 Project: Apache Cordova Issue Type: Bug Components: Docs Reporter: jcesarmobile Priority: Minor On the events page (http://cordova.apache.org/docs/en/dev/cordova/events/events.html) there is a table with the available events and the supported platforms. The events on that table have anchors to the event documentation, but those anchors don't work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
