[jira] [Commented] (CB-10773) Incorrect path separator in FRAMEWORK_SEARCH_PATHS with custom framework from plugin.xml

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190588#comment-15190588
 ] 

ASF subversion and git services commented on CB-10773:
--

Commit d1199065289c37bbaee91dceca84f78ff73b064e in cordova-ios's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=d119906 ]

CB-10773 Update path delimiters in tests


> Incorrect path separator in FRAMEWORK_SEARCH_PATHS with custom framework from 
> plugin.xml
> 
>
> Key: CB-10773
> URL: https://issues.apache.org/jira/browse/CB-10773
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
> Environment: iOS
>Reporter: Edna Morales
>Assignee: Vladimir Kotikov
>  Labels: cordova-ios-4.1.1
>
> When an iOS project is created and a plugin with custom frameworks is added 
> on Windows, the path separator in FRAMEWORK_SEARCH_PATHS of the pbxproj file 
> is incorrect. It has the Windows path separator. This causes build issues 
> when the project is moved to OSX and built in Xcode.
> This is ultimately coming from the xcode npm package. I have opened up an 
> issue with that module with a suggested solution: 
> https://github.com/alunny/node-xcode/issues/80
> Once it is fixed there, we will need to refresh our version of the xcode npm 
> package in our node_modules for cordova-ios



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10780) Return waveform data while recording

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190579#comment-15190579
 ] 

jcesarmobile commented on CB-10780:
---

I think this is related https://issues.apache.org/jira/browse/CB-9487  (Support 
getting amplitude for recording)

> Return waveform data while recording
> 
>
> Key: CB-10780
> URL: https://issues.apache.org/jira/browse/CB-10780
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media
>Reporter: Simon MacDonald
>  Labels: Android, iOS
>
> While we are recording audio we should be able to return the volume of the 
> current sample so that the UI can use it to draw a waveform. This is very 
> useful for users to be able to tell if their voice is being recorded properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10769) Plugin handlers tests for iOS should be kept in platform's repo

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190575#comment-15190575
 ] 

ASF subversion and git services commented on CB-10769:
--

Commit 000a61e602f3bddd641316a8fda985d87ad10b62 in cordova-ios's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=000a61e ]

CB-10769 Update specs according to actual implementation

This closes #200


> Plugin handlers tests for iOS should be kept in platform's repo
> ---
>
> Key: CB-10769
> URL: https://issues.apache.org/jira/browse/CB-10769
> Project: Apache Cordova
>  Issue Type: Task
>  Components: iOS
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: cordova-ios-4.1.1
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10769) Plugin handlers tests for iOS should be kept in platform's repo

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190573#comment-15190573
 ] 

ASF subversion and git services commented on CB-10769:
--

Commit c0db5e4ecfb4e2afa31fdb277620cc4ebcf7d7f3 in cordova-ios's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=c0db5e4 ]

CB-10769 Copy raw pluginHandler tests from cordova-lib

Update tests structure and npm tasks
Copying related fixtures from cordova-lib


> Plugin handlers tests for iOS should be kept in platform's repo
> ---
>
> Key: CB-10769
> URL: https://issues.apache.org/jira/browse/CB-10769
> Project: Apache Cordova
>  Issue Type: Task
>  Components: iOS
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: cordova-ios-4.1.1
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10769) Plugin handlers tests for iOS should be kept in platform's repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190572#comment-15190572
 ] 

ASF GitHub Bot commented on CB-10769:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/200


> Plugin handlers tests for iOS should be kept in platform's repo
> ---
>
> Key: CB-10769
> URL: https://issues.apache.org/jira/browse/CB-10769
> Project: Apache Cordova
>  Issue Type: Task
>  Components: iOS
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: cordova-ios-4.1.1
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10838) Switch to CordovaLogger from 'common' in Windows

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190555#comment-15190555
 ] 

ASF subversion and git services commented on CB-10838:
--

Commit cb7df923a0b1a2f413d46770511c2b0df6807181 in cordova-windows's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=cb7df92 ]

CB-10838 Use logger from cordova-common


> Switch to CordovaLogger from 'common' in Windows
> 
>
> Key: CB-10838
> URL: https://issues.apache.org/jira/browse/CB-10838
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10838) Switch to CordovaLogger from 'common' in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190558#comment-15190558
 ] 

ASF GitHub Bot commented on CB-10838:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/158


> Switch to CordovaLogger from 'common' in Windows
> 
>
> Key: CB-10838
> URL: https://issues.apache.org/jira/browse/CB-10838
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10769) Plugin handlers tests for iOS should be kept in platform's repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190554#comment-15190554
 ] 

ASF GitHub Bot commented on CB-10769:
-

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-ios/pull/200#issuecomment-195226834
  
@dblotsky, updated/


> Plugin handlers tests for iOS should be kept in platform's repo
> ---
>
> Key: CB-10769
> URL: https://issues.apache.org/jira/browse/CB-10769
> Project: Apache Cordova
>  Issue Type: Task
>  Components: iOS
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: cordova-ios-4.1.1
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10600) 'cordova run android --release' does not use signed and zip-aligned version of APK

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190518#comment-15190518
 ] 

ASF GitHub Bot commented on CB-10600:
-

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/273#issuecomment-195215718
  
@daserge Can you please review?


> 'cordova run android --release' does not use signed and zip-aligned version 
> of APK
> --
>
> Key: CB-10600
> URL: https://issues.apache.org/jira/browse/CB-10600
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Tested on Windows 8.1 with Cordova CLI 6.0.0 (and Ionic 
> CLI 1.7.14)
>Reporter: Eric Gopak
>Assignee: Joe Bowser
>Priority: Minor
>  Labels: triaged
>
> Running command `cordova run android --release` builds the app successfully, 
> both unsigned and signed/zip-aligned versions. However, it then tries to use 
> the unsigned version of the APK. Here are the last lines of the output:
> .
> BUILD SUCCESSFUL
> Total time: 31.35 secs
> Built the following apk(s):
> 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> C:/X/platforms/android/build/outputs/apk/android-armv7-release.apk
> Using apk: 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> ERROR running one or more of the platforms: Failed to install apk to device: 
> pkg: /data/local/tmp/android-armv7-release-unsigned.apk
> Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES]
> You may not have the required environment or OS to run this project
> It has worked before I updated Cordova with 'npm install -g cordova'.
> I specify signing properties in a file 'release-signing.properties', which I 
> copy to platforms/android/ folder. During the run/build I get prompted for 
> the password, just as it has always been.
> I believe it is just a problem of choosing the wrong APK from the list of 
> built APKs (Cordova probably chooses the one that comes earlier 
> lexicographically)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10829) Broken docs CLI reference links in platform guides

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190428#comment-15190428
 ] 

ASF GitHub Bot commented on CB-10829:
-

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/554#issuecomment-195164298
  
@riknoll please review when you have a moment.


> Broken docs CLI reference links in platform guides
> --
>
> Key: CB-10829
> URL: https://issues.apache.org/jira/browse/CB-10829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Dmitry Blotsky
>
> Looks like it is in blackberry10, Android and iOS. They appear like so
> {noformat}
> [Cordova CLI Reference]:(../../../cordova-cli/index.html)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10829) Broken docs CLI reference links in platform guides

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190427#comment-15190427
 ] 

ASF GitHub Bot commented on CB-10829:
-

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/554

CB-10829 Fixing reference links.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10829

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #554


commit c2a221c05a3dd60e6a4f78315b8e6e68cff64275
Author: Dmitry Blotsky 
Date:   2016-03-11T03:37:19Z

CB-10829 Fixing reference links.




> Broken docs CLI reference links in platform guides
> --
>
> Key: CB-10829
> URL: https://issues.apache.org/jira/browse/CB-10829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Dmitry Blotsky
>
> Looks like it is in blackberry10, Android and iOS. They appear like so
> {noformat}
> [Cordova CLI Reference]:(../../../cordova-cli/index.html)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-8842) Device motion test failures on Android and iOS

[Dmitry Blotsky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Blotsky closed CB-8842.
--

> Device motion test failures on Android and iOS
> --
>
> Key: CB-8842
> URL: https://issues.apache.org/jira/browse/CB-8842
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, Plugin Device Motion
>Affects Versions: Master
> Environment: OSX, Windows
>Reporter: Dmitry Blotsky
>  Labels: android, found-by-ci, ios, plugin, plugin-device-motion, 
> test-fail
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Test results here: 
> [http://ci.apache.org/builders/cordova-android-osx/builds/275/steps/running-tests/logs/stdio],
>  and here: 
> [http://ci.apache.org/builders/cordova-ios/builds/399/steps/running-tests/logs/stdio].
> {noformat}
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) getCurrentAcceleration accelerometer.spec.3 success 
> callback should be called with an Acceleration object
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) getCurrentAcceleration accelerometer.spec.4 success 
> callback Acceleration object should have (reasonable) values for x, y and z 
> expressed in m/s^2
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) getCurrentAcceleration accelerometer.spec.5 success 
> callback Acceleration object should return a recent timestamp
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) watchAcceleration accelerometer.spec.7 success 
> callback should be called with an Acceleration object
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) watchAcceleration accelerometer.spec.8 success 
> callback Acceleration object should have (reasonable) values for x, y and z 
> expressed in m/s^2
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success 
> callback Acceleration object should return a recent timestamp
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) watchAcceleration accelerometer.spec.12 success 
> callback should be preserved and called several times
> cordova-plugin-device-motion-tests.tests >> Accelerometer 
> (navigator.accelerometer) clearWatch accelerometer.spec.11 should clear an 
> existing watch
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-8853) Android builds fail when emulator is already running

[Dmitry Blotsky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Blotsky closed CB-8853.
--

> Android builds fail when emulator is already running
> 
>
> Key: CB-8853
> URL: https://issues.apache.org/jira/browse/CB-8853
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, Medic
>Affects Versions: Master
> Environment: OSX, Windows
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>  Labels: android, emulator, found-by-ci, medic
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Running an Android build when the emulator is already running fails in 
> different ways on different platforms (e.g. hang, error, etc.). However, 
> running the build when the emulator is not running succeeds, but raises an 
> error regarding shutdown.
> Examples of hangs:
> http://ci.apache.org/builders/cordova-android-osx/builds/310/steps/running-tests/logs/stdio
> http://ci.apache.org/builders/cordova-android-win/builds/1085/steps/running-tests/logs/stdio
> Example of failure to shut down:
> http://ci.apache.org/builders/cordova-android-win/builds/1086/steps/running-tests/logs/stdio



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-9278) Restoring multiple platforms fails

[Dmitry Blotsky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Blotsky closed CB-9278.
--

> Restoring multiple platforms fails
> --
>
> Key: CB-9278
> URL: https://issues.apache.org/jira/browse/CB-9278
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
> Environment: OS X
>Reporter: Dmitry Blotsky
>Assignee: Omar Mefire
>  Labels: cordova-lib, platform, restore, save
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Steps to reproduce:
> 1. Create a blank app: {{cordova create test com.app.test test}}
> 2. Add and save a platform: {{cordova platform add --save ios}}
> 3. Add and save another platform: {{cordova platform add --save android}}
> 4. Remove the platforms: {{cordova platform remove android ios}}
> 5. Try to restore platforms automatically: {{cordova prepare}}
> Expected: both platforms installed and prepared
> Actual:
> {noformat}
> Error: Trying to initialize npm when settings have not been restored from a 
> previous initialization.
> {noformat}
> Running {{cordova prepare}} again fixes the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10844) Site-wide search doesn't work

[Robert Posener (JIRA)]

Robert Posener created CB-10844:
---

 Summary: Site-wide search doesn't work
 Key: CB-10844
 URL: https://issues.apache.org/jira/browse/CB-10844
 Project: Apache Cordova
  Issue Type: Bug
  Components: Docs
Affects Versions: 6.0.0
Reporter: Robert Posener
Priority: Minor


No matter what you enter as search criteria (eg, "preference", "bluetooth", 
"fred" and "rubbish" you always get 11,800 results and none of them are 
"matches".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190353#comment-15190353
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55781014
  
--- Diff: appium-tests/helpers/wdHelper.js ---
@@ -0,0 +1,68 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+var wd = global.WD || require('wd');
+var driver;
+
+module.exports.getDriver = function (platform, callback) {
+var serverConfig = {
+host: 'localhost',
+port: 4723
--- End diff --

Please factor these out into constants.


> Implement Appium tests for Contacts plugin
> --
>
> Key: CB-10399
> URL: https://issues.apache.org/jira/browse/CB-10399
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Medic, Plugin Contacts
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190349#comment-15190349
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780934
  
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+function prepare(item) {
+if (typeof item === 'object') {
+return JSON.stringify(item);
+}
+if (typeof item === 'string') {
+return '"' + item + '"';
+}
+return undefined;
+}
+
+module.exports.getContactName = function (firstName, lastName) {
+return {
+formatted: firstName == lastName === undefined ? null : firstName 
+ ' ' + lastName,
+familyName: lastName,
+givenName: firstName,
+middleName: ''
+};
+};
+
+module.exports.getAddContactCode = function (displayName, contactName, 
phoneNumber) {
+var preparedDisplayName = prepare(displayName);
+console.log('preparedDisplayName is ' + preparedDisplayName);
+var preparedContactName = prepare(contactName);
+var preparedPhoneNumber = prepare(phoneNumber);
+
+var result =
+'try {\n' +
+'var results = document.getElementById("info");\n' +
+'var contact = navigator.contacts.create({ "displayName": ' + 
preparedDisplayName + ', "name": ' + preparedContactName + ', "note": 
"DeleteMe" });\n' +
+
+'var phoneNumbers = [1];\n' +
+'phoneNumbers[0] = new ContactField("work", ' + 
preparedPhoneNumber + ', true);\n' +
+'contact.phoneNumbers = phoneNumbers;\n' +
+
+'contact.save(function() {\n' +
+'results.innerHTML = "' + (displayName || 'Nameless 
contact') + ' saved.";\n' +
+'}, function(e) {\n' +
+'if (e.code === ContactError.NOT_SUPPORTED_ERROR) {\n' +
+'results.innerHTML = "Saving contacts not 
supported.";\n' +
+'} else {\n' +
+'results.innerHTML = "Contact save failed: error " + 
e.code;\n' +
+'}\n' +
+'});\n' +
+'} catch (e) {\n' +
+'var results = document.getElementById("info");\n' +
+'results.innerHTML = "ERROR: " + e.code;\n' +
+'}\n';
+
+return result;
+};
+
+module.exports.getGetContactsCode = function (filter) {
+var preparedFilter = prepare(filter);
+
+var result =
+'var results = document.getElementById("info");\n' +
+'var obj = new ContactFindOptions();\n' +
+'if (' + preparedFilter + ') {\n' +
+'obj.filter = ' + preparedFilter + ';\n' +
+'}\n' +
+'obj.multiple = true;\n' +
+'navigator.contacts.find(["displayName", "name", "phoneNumbers", 
"emails", "urls", "note"], function(contacts) {\n' +
+'var s = "";\n' +
+'if (contacts.length === 0) {\n' +
+'s = "No contacts found";\n' +
+'} else {\n' +
+'s = "Number of contacts: " + contacts.length + 
"NamePhoneEmail";\n' +
+'for (var i = 0; i < contacts.length; i++) {\n' +
+'var contact = contacts[i];\n' +
+'var contactNameTag = contact.name ? "" + 
contact.name.formatted + "" : "(No Name)";\n' +
+'s = s + contactNameTag;\n' +
+'if (contact.phoneNumbers && 
contact.phoneNumbers.length > 0) {\n' +
+'s = s + contact.phoneNumbers[0].value;\n' +
+'}\n' +
+'s = s + "";\n' +
+   

[jira] [Commented] (CB-10460) getRealPathFromURI_API11to18() return null

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190342#comment-15190342
 ] 

Richard B Knoll commented on CB-10460:
--

Stack Trace:
{noformat}
java.lang.RuntimeException: Can't create handler inside thread that has not 
called Looper.prepare()
   at android.os.Handler.(Handler.java:197)
   at android.os.Handler.(Handler.java:111)
   at android.content.Loader$ForceLoadContentObserver.(Loader.java:72)
   at android.content.CursorLoader.(CursorLoader.java:137)
   at 
org.apache.cordova.camera.FileHelper.getRealPathFromURI_API11to18(FileHelper.java:154)
   at org.apache.cordova.camera.FileHelper.getRealPath(FileHelper.java:60)
   at 
org.apache.cordova.camera.CameraLauncher.processResultFromGallery(CameraLauncher.java:620)
   at 
org.apache.cordova.camera.CameraLauncher.access$000(CameraLauncher.java:66)
   at org.apache.cordova.camera.CameraLauncher$1.run(CameraLauncher.java:778)
   at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
   at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
   at java.lang.Thread.run(Thread.java:841)
{noformat}

Camera options:
{code}
{
mediaType: Camera.MediaType.PICTURE,
destinationType: Camera.DestinationType.FILE_URI,
sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
correctOrientation: true
}
{code}

> getRealPathFromURI_API11to18() return null
> --
>
> Key: CB-10460
> URL: https://issues.apache.org/jira/browse/CB-10460
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.0.0, 2.1.0
> Environment: Android 4.0.3
>Reporter: Satoshi Watanabe
>  Labels: android, reproduced, triaged
>
> getRealPathFromURI_API11to18() return null.
> CursorLoader in getRealPathFromURI_API11to18() throw following exception:
>  java.lang.RuntimeException: Can't create handler inside thread that has not 
> called Looper.prepare()
> so this method return null.
> I think call Looper.prepare() before creating CursorLoader.
> I am in need.
> I will request fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190348#comment-15190348
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780861
  
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+function prepare(item) {
--- End diff --

Please give this function a more descriptive name.


> Implement Appium tests for Contacts plugin
> --
>
> Key: CB-10399
> URL: https://issues.apache.org/jira/browse/CB-10399
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Medic, Plugin Contacts
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190345#comment-15190345
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780842
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190339#comment-15190339
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780731
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190338#comment-15190338
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780673
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190337#comment-15190337
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780654
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190331#comment-15190331
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780482
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190328#comment-15190328
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780424
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
--- End diff --

Are we using a version of Jasmine that has a `fail()` function?


> Implement Appium tests for Contacts plugin
> --
>
> Key: CB-10399
> URL: https://issues.apache.org/jira/browse/CB-10399
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Medic, Plugin Contacts
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190326#comment-15190326
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780286
  
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -0,0 +1,352 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform ios 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+var unorm = global.unorm || require("unorm");
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW_1';
+
+describe('contacts tests iOS', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = 

[jira] [Commented] (CB-10399) Implement Appium tests for Contacts plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190327#comment-15190327
 ] 

ASF GitHub Bot commented on CB-10399:
-

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780306
  
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -0,0 +1,352 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform ios 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+var unorm = global.unorm || require("unorm");
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW_1';
+
+describe('contacts tests iOS', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = 

[jira] [Commented] (CB-10460) getRealPathFromURI_API11to18() return null

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190318#comment-15190318
 ] 

Richard B Knoll commented on CB-10460:
--

I have reproduced this on Jellybean. [~sassy.watan...@gmail.com] can you open a 
PR since you have a fix? See 
http://cordova.apache.org/contribute/contribute_guidelines.html

> getRealPathFromURI_API11to18() return null
> --
>
> Key: CB-10460
> URL: https://issues.apache.org/jira/browse/CB-10460
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.0.0, 2.1.0
> Environment: Android 4.0.3
>Reporter: Satoshi Watanabe
>  Labels: android, reproduced, triaged
>
> getRealPathFromURI_API11to18() return null.
> CursorLoader in getRealPathFromURI_API11to18() throw following exception:
>  java.lang.RuntimeException: Can't create handler inside thread that has not 
> called Looper.prepare()
> so this method return null.
> I think call Looper.prepare() before creating CursorLoader.
> I am in need.
> I will request fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10460) getRealPathFromURI_API11to18() return null

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll updated CB-10460:
-
Labels: android reproduced triaged  (was: android triaged)

> getRealPathFromURI_API11to18() return null
> --
>
> Key: CB-10460
> URL: https://issues.apache.org/jira/browse/CB-10460
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.0.0, 2.1.0
> Environment: Android 4.0.3
>Reporter: Satoshi Watanabe
>  Labels: android, reproduced, triaged
>
> getRealPathFromURI_API11to18() return null.
> CursorLoader in getRealPathFromURI_API11to18() throw following exception:
>  java.lang.RuntimeException: Can't create handler inside thread that has not 
> called Looper.prepare()
> so this method return null.
> I think call Looper.prepare() before creating CursorLoader.
> I am in need.
> I will request fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10460) getRealPathFromURI_API11to18() return null

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll updated CB-10460:
-
Labels: android triaged  (was: android triaged wfc)

> getRealPathFromURI_API11to18() return null
> --
>
> Key: CB-10460
> URL: https://issues.apache.org/jira/browse/CB-10460
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.0.0, 2.1.0
> Environment: Android 4.0.3
>Reporter: Satoshi Watanabe
>  Labels: android, reproduced, triaged
>
> getRealPathFromURI_API11to18() return null.
> CursorLoader in getRealPathFromURI_API11to18() throw following exception:
>  java.lang.RuntimeException: Can't create handler inside thread that has not 
> called Looper.prepare()
> so this method return null.
> I think call Looper.prepare() before creating CursorLoader.
> I am in need.
> I will request fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10819) Snapshotting dev to latest should be automated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190296#comment-15190296
 ] 

ASF GitHub Bot commented on CB-10819:
-

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/553#issuecomment-195134620
  
@riknoll @rakatyal please review when you have a moment.


> Snapshotting dev to latest should be automated
> --
>
> Key: CB-10819
> URL: https://issues.apache.org/jira/browse/CB-10819
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Docs
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Minor
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10819) Snapshotting dev to latest should be automated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190291#comment-15190291
 ] 

ASF GitHub Bot commented on CB-10819:
-

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/553

CB-10819 Adding snapshotting and improving build system

- Added 'snap' command to Makefile and gulpfile. 
- Fixed 'newversion' command.
- Made fetched files live under /reference/. 
- Refactored and removed incrementversion.js in favour of simple FS 
commands.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10819

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #553


commit dc75ae90c2ed53410668c28f081d74ef7c270f61
Author: Dmitry Blotsky 
Date:   2016-03-08T02:21:40Z

CB-10819 Added 'snap' command to Makefile and gulpfile. Fixed 'newversion' 
command. Made fetched files live under /reference/. Refactored and removed 
incrementversion.js in favour of simple FS commands.




> Snapshotting dev to latest should be automated
> --
>
> Key: CB-10819
> URL: https://issues.apache.org/jira/browse/CB-10819
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Docs
>Reporter: Dmitry Blotsky
>Assignee: Dmitry Blotsky
>Priority: Minor
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10270) camera.getPicture() returns an empty string

[Cameron Gregory (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190287#comment-15190287
 ] 

Cameron Gregory commented on CB-10270:
--

quick test and that worked for me (nexus 7 android 5.1.1, galaxy core 2 / 
4.4.2, 6+ ios 9 <- JIC)
thanks!
Cameron

> camera.getPicture() returns an empty string
> ---
>
> Key: CB-10270
> URL: https://issues.apache.org/jira/browse/CB-10270
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.1.0
> Environment: Android 4.4.2 (api 19)
>Reporter: Alexander Sorokin
>Priority: Critical
>  Labels: android, mustfix, reproduced, triaged
> Attachments: mobilespec-camera.7z
>
>
> Code sample to reproduce:
> {code}
> navigator.camera.getPicture(onSuccess, onFail, { 
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
> correctOrientation: true
> });
> {code}
> {{onSuccess}} is called with an empty string as an argument.
> if {{correctOrientation}} is {{false}}, everything works as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10843) Typo in CVE announcement blog post for Android

[Shazron Abdullah (JIRA)]

Shazron Abdullah created CB-10843:
-

 Summary: Typo in CVE announcement blog post for Android
 Key: CB-10843
 URL: https://issues.apache.org/jira/browse/CB-10843
 Project: Apache Cordova
  Issue Type: Bug
  Components: Docs
Reporter: Shazron Abdullah


http://cordova.apache.org/announcements/2015/11/20/security.html

"annoucements" should be "announcements



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10841) Cordova crashes when the window is resized on Android

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-10841:

Description: 
Long-Press the Square Box so it enters window-resize mode and resize a window.

Expected: Shouldn't crash
What happens: Crashes miserably

It's likely that the WebView wasn't tested and this preview all Cordova apps 
crap the bed.  This applies to the System Webview.  I can't get Crosswalk to 
work with Android N at all, so I'm not really testing it.

  was:
Long-Press the Square Box so it enters window-resize mode and resize a window.

Expected: Shouldn't crash
What happens: Crashes miserably

It's likely that the WebView wasn't tested and this preview all Cordova apps 
crap the bed.  I can't get Crosswalk to work with Android N at all, so I'm not 
really testing it.


> Cordova crashes when the window is resized on Android
> -
>
> Key: CB-10841
> URL: https://issues.apache.org/jira/browse/CB-10841
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Android N
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: AndroidN, DevRelease
>
> Long-Press the Square Box so it enters window-resize mode and resize a window.
> Expected: Shouldn't crash
> What happens: Crashes miserably
> It's likely that the WebView wasn't tested and this preview all Cordova apps 
> crap the bed.  This applies to the System Webview.  I can't get Crosswalk to 
> work with Android N at all, so I'm not really testing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10841) Cordova crashes when the window is resized on Android N

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-10841:

Description: 
Long-Press the Square Box so it enters window-resize mode and resize a window.

Expected: Shouldn't crash
What happens: Crashes miserably

It's likely that the WebView wasn't tested and this preview all Cordova apps 
crap the bed.  This applies to the System Webview.  I can't get Crosswalk to 
work with Android N at all, so I'm not really testing it.

(You can't resize your window in prior versions of Android)

  was:
Long-Press the Square Box so it enters window-resize mode and resize a window.

Expected: Shouldn't crash
What happens: Crashes miserably

It's likely that the WebView wasn't tested and this preview all Cordova apps 
crap the bed.  This applies to the System Webview.  I can't get Crosswalk to 
work with Android N at all, so I'm not really testing it.


> Cordova crashes when the window is resized on Android N
> ---
>
> Key: CB-10841
> URL: https://issues.apache.org/jira/browse/CB-10841
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Android N
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: AndroidN, DevRelease
>
> Long-Press the Square Box so it enters window-resize mode and resize a window.
> Expected: Shouldn't crash
> What happens: Crashes miserably
> It's likely that the WebView wasn't tested and this preview all Cordova apps 
> crap the bed.  This applies to the System Webview.  I can't get Crosswalk to 
> work with Android N at all, so I'm not really testing it.
> (You can't resize your window in prior versions of Android)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10841) Cordova crashes when the window is resized on Android N

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-10841:

Summary: Cordova crashes when the window is resized on Android N  (was: 
Cordova crashes when the window is resized on Android)

> Cordova crashes when the window is resized on Android N
> ---
>
> Key: CB-10841
> URL: https://issues.apache.org/jira/browse/CB-10841
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Android N
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: AndroidN, DevRelease
>
> Long-Press the Square Box so it enters window-resize mode and resize a window.
> Expected: Shouldn't crash
> What happens: Crashes miserably
> It's likely that the WebView wasn't tested and this preview all Cordova apps 
> crap the bed.  This applies to the System Webview.  I can't get Crosswalk to 
> work with Android N at all, so I'm not really testing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10841) Cordova crashes when the window is resized on Android

[fujunwei (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190235#comment-15190235
 ] 

fujunwei commented on CB-10841:
---

@Wanming, could you please help verify it?

Thanks,
Junwei.
-Original Message-
From: Joe Bowser (JIRA) [mailto:j...@apache.org] 
Sent: Friday, March 11, 2016 6:31 AM
To: issues@cordova.apache.org
Subject: [jira] [Created] (CB-10841) Cordova crashes when the window is resized 
on Android

Joe Bowser created CB-10841:
---

 Summary: Cordova crashes when the window is resized on Android
 Key: CB-10841
 URL: https://issues.apache.org/jira/browse/CB-10841
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
 Environment: Android N
Reporter: Joe Bowser
Assignee: Joe Bowser


Long-Press the Square Box so it enters window-resize mode and resize a window.

Expected: Shouldn't crash
What happens: Crashes miserably

It's likely that the WebView wasn't tested and this preview all Cordova apps 
crap the bed.  I can't get Crosswalk to work with Android N at all, so I'm not 
really testing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



> Cordova crashes when the window is resized on Android
> -
>
> Key: CB-10841
> URL: https://issues.apache.org/jira/browse/CB-10841
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Android N
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: AndroidN, DevRelease
>
> Long-Press the Square Box so it enters window-resize mode and resize a window.
> Expected: Shouldn't crash
> What happens: Crashes miserably
> It's likely that the WebView wasn't tested and this preview all Cordova apps 
> crap the bed.  I can't get Crosswalk to work with Android N at all, so I'm 
> not really testing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190176#comment-15190176
 ] 

ASF GitHub Bot commented on CB-10679:
-

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/241#discussion_r55768334
  
--- Diff: doc/readme.md ---
@@ -337,6 +337,18 @@ There are a number of ways to specify a plugin:
 | commit-ish  | Commit/tag/branch reference. If none is specified, 
'master' is used
 | subdir  | Sub-directory to find plugin.xml for the specified plugin.
 
+### Algorithm for choosing which plugin version to fetch from npm
+
+When adding a plugin to a project from npm, the CLI will choose which 
version
+of the plugin to fetch based on the following criteria (listed in order of
+precedence):
+
+1. The plugin version specified in the command (e.g. `cordova plugin add 
plugin@version`)
+2. The plugin version saved in config.xml (i.e. if the plugin was 
previously added with `--save`)
+3. The latest plugin version that the current project can support (only 
applies to plugins that list their [Cordova dependencies] in their 
`package.json`)
--- End diff --

"As for version 6.1, ..."


> Update plugin add behavior to allow plugins to list engine constraints
> --
>
> Key: CB-10679
> URL: https://issues.apache.org/jira/browse/CB-10679
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Let plugins specify their Cordova related dependencies in their package.json 
> so that the CLI can choose a compatible version for the current project.
> Full specification is here:
> https://github.com/cordova/cordova-discuss/pull/30



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190171#comment-15190171
 ] 

ASF GitHub Bot commented on CB-10679:
-

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/241#discussion_r55767811
  
--- Diff: doc/readme.md ---
@@ -337,6 +337,18 @@ There are a number of ways to specify a plugin:
 | commit-ish  | Commit/tag/branch reference. If none is specified, 
'master' is used
 | subdir  | Sub-directory to find plugin.xml for the specified plugin.
 
+### Algorithm for choosing which plugin version to fetch from npm
+
+When adding a plugin to a project from npm, the CLI will choose which 
version
+of the plugin to fetch based on the following criteria (listed in order of
+precedence):
+
+1. The plugin version specified in the command (e.g. `cordova plugin add 
plugin@version`)
--- End diff --

Consider changing `version` to `plugin-spec`


> Update plugin add behavior to allow plugins to list engine constraints
> --
>
> Key: CB-10679
> URL: https://issues.apache.org/jira/browse/CB-10679
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Let plugins specify their Cordova related dependencies in their package.json 
> so that the CLI can choose a compatible version for the current project.
> Full specification is here:
> https://github.com/cordova/cordova-discuss/pull/30



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190161#comment-15190161
 ] 

ASF GitHub Bot commented on CB-10679:
-

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/241#discussion_r55766818
  
--- Diff: doc/readme.md ---
@@ -337,6 +337,18 @@ There are a number of ways to specify a plugin:
 | commit-ish  | Commit/tag/branch reference. If none is specified, 
'master' is used
 | subdir  | Sub-directory to find plugin.xml for the specified plugin.
 
+### Algorithm for choosing which plugin version to fetch from npm
+
+When adding a plugin to a project from npm, the CLI will choose which 
version
+of the plugin to fetch based on the following criteria (listed in order of
+precedence):
+
+1. The plugin version specified in the command (e.g. `cordova plugin add 
plugin@version`)
+2. The plugin version saved in config.xml (i.e. if the plugin was 
previously added with `--save`)
+3. The latest plugin version that the current project can support (only 
applies to plugins that list their [Cordova dependencies] in their 
`package.json`)
+4. The plugin version pinned by your installed CLI version (only applies 
to [Apache-developed plugins])
--- End diff --

This will likely need an update in a couple of days - when you remove 
plugin pinning.


> Update plugin add behavior to allow plugins to list engine constraints
> --
>
> Key: CB-10679
> URL: https://issues.apache.org/jira/browse/CB-10679
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Let plugins specify their Cordova related dependencies in their package.json 
> so that the CLI can choose a compatible version for the current project.
> Full specification is here:
> https://github.com/cordova/cordova-discuss/pull/30



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10842) Update MSBuild 15 support

[Jason Ginchereau (JIRA)]

Jason Ginchereau created CB-10842:
-

 Summary: Update MSBuild 15 support
 Key: CB-10842
 URL: https://issues.apache.org/jira/browse/CB-10842
 Project: Apache Cordova
  Issue Type: Bug
  Components: Windows
Reporter: Jason Ginchereau
Assignee: Jason Ginchereau


If you have both MSBuild 14 and 15 installed (VS 2015 and a preview of the next 
VS version), and you try use VS 2015 to build a Cordova project that targets 
Windows/Phone 8.1, it will fail because MSBuild 15 is unable to build those 
target types.

Support for MSBuild 15 was added to Cordova a couple months ago, as CB-10292. 
At the time, MSBuild 15 supported all the same targets as MSBuild 14. But since 
then it has dropped support for building Windows/Phone 8.1 targets. So instead 
of picking the latest available MSBuild version, Cordova needs to prefer 
MSBuild 14 when targeting Windows/Phone 8.1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10270) camera.getPicture() returns an empty string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190111#comment-15190111
 ] 

ASF GitHub Bot commented on CB-10270:
-

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195084460
  
@jcesarmobile I don't even know if this is an issue in Jelly Bean. Do you 
have a device to test with?


> camera.getPicture() returns an empty string
> ---
>
> Key: CB-10270
> URL: https://issues.apache.org/jira/browse/CB-10270
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.1.0
> Environment: Android 4.4.2 (api 19)
>Reporter: Alexander Sorokin
>Priority: Critical
>  Labels: android, mustfix, reproduced, triaged
> Attachments: mobilespec-camera.7z
>
>
> Code sample to reproduce:
> {code}
> navigator.camera.getPicture(onSuccess, onFail, { 
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
> correctOrientation: true
> });
> {code}
> {{onSuccess}} is called with an empty string as an argument.
> if {{correctOrientation}} is {{false}}, everything works as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10769) Plugin handlers tests for iOS should be kept in platform's repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190098#comment-15190098
 ] 

ASF GitHub Bot commented on CB-10769:
-

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/200#discussion_r55762230
  
--- Diff: .jshintignore ---
@@ -1,2 +1,3 @@
 bin/node_modules/*
 bin/templates/project/*
+tests/spec/unit/fixtures/*
--- End diff --

Please add a newline at the end of the file.


> Plugin handlers tests for iOS should be kept in platform's repo
> ---
>
> Key: CB-10769
> URL: https://issues.apache.org/jira/browse/CB-10769
> Project: Apache Cordova
>  Issue Type: Task
>  Components: iOS
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: cordova-ios-4.1.1
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10769) Plugin handlers tests for iOS should be kept in platform's repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190097#comment-15190097
 ] 

ASF GitHub Bot commented on CB-10769:
-

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/200#discussion_r55762207
  
--- Diff: .gitignore ---
@@ -7,3 +7,4 @@ tmp
 xcuserdata
 console.log
 node_modules/
+npm-debug.log
--- End diff --

Please add a newline at the end of the file.


> Plugin handlers tests for iOS should be kept in platform's repo
> ---
>
> Key: CB-10769
> URL: https://issues.apache.org/jira/browse/CB-10769
> Project: Apache Cordova
>  Issue Type: Task
>  Components: iOS
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: cordova-ios-4.1.1
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10270) camera.getPicture() returns an empty string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190094#comment-15190094
 ] 

ASF GitHub Bot commented on CB-10270:
-

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195082019
  
#175 only fixes it on API 19 and greater, maybe it should be moved outside. 


> camera.getPicture() returns an empty string
> ---
>
> Key: CB-10270
> URL: https://issues.apache.org/jira/browse/CB-10270
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.1.0
> Environment: Android 4.4.2 (api 19)
>Reporter: Alexander Sorokin
>Priority: Critical
>  Labels: android, mustfix, reproduced, triaged
> Attachments: mobilespec-camera.7z
>
>
> Code sample to reproduce:
> {code}
> navigator.camera.getPicture(onSuccess, onFail, { 
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
> correctOrientation: true
> });
> {code}
> {{onSuccess}} is called with an empty string as an argument.
> if {{correctOrientation}} is {{false}}, everything works as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10841) Cordova crashes when the window is resized on Android

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-10841:

Labels: AndroidN DevRelease  (was: )

> Cordova crashes when the window is resized on Android
> -
>
> Key: CB-10841
> URL: https://issues.apache.org/jira/browse/CB-10841
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Android N
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: AndroidN, DevRelease
>
> Long-Press the Square Box so it enters window-resize mode and resize a window.
> Expected: Shouldn't crash
> What happens: Crashes miserably
> It's likely that the WebView wasn't tested and this preview all Cordova apps 
> crap the bed.  I can't get Crosswalk to work with Android N at all, so I'm 
> not really testing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10841) Cordova crashes when the window is resized on Android

[Joe Bowser (JIRA)]

Joe Bowser created CB-10841:
---

 Summary: Cordova crashes when the window is resized on Android
 Key: CB-10841
 URL: https://issues.apache.org/jira/browse/CB-10841
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
 Environment: Android N
Reporter: Joe Bowser
Assignee: Joe Bowser


Long-Press the Square Box so it enters window-resize mode and resize a window.

Expected: Shouldn't crash
What happens: Crashes miserably

It's likely that the WebView wasn't tested and this preview all Cordova apps 
crap the bed.  I can't get Crosswalk to work with Android N at all, so I'm not 
really testing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9960) Images from Google Photos cause FileNotFoundException

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll updated CB-9960:

Assignee: (was: Richard B Knoll)

> Images from Google Photos cause FileNotFoundException
> -
>
> Key: CB-9960
> URL: https://issues.apache.org/jira/browse/CB-9960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Android 6.0, cordova-android 5.0.0 (dev), 
> cordova-plugin-camera 1.2.1 (dev)
>Reporter: Richard B Knoll
>Priority: Critical
>  Labels: android, mustfix, triaged
>
> When selecting images from the PHOTOLIBRARY source using the Google Photos 
> application a FileNotFoundException is thrown if any flags that cause image 
> edits are turned on (width/height, allowEdit, correctOrientation, etc.). The 
> issue is that our method for dereferencing content URIs in FileHelper fails 
> for the content URI returned by Google Photos and returns an empty path (that 
> {{ouputModifiedBitmap()}} tries to grab a filename from)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9960) Images from Google Photos cause FileNotFoundException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190082#comment-15190082
 ] 

ASF GitHub Bot commented on CB-9960:


Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-195077454
  
Seems to have been fixed by #175, so I'm closing this


> Images from Google Photos cause FileNotFoundException
> -
>
> Key: CB-9960
> URL: https://issues.apache.org/jira/browse/CB-9960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Android 6.0, cordova-android 5.0.0 (dev), 
> cordova-plugin-camera 1.2.1 (dev)
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>Priority: Critical
>  Labels: android, mustfix, triaged
>
> When selecting images from the PHOTOLIBRARY source using the Google Photos 
> application a FileNotFoundException is thrown if any flags that cause image 
> edits are turned on (width/height, allowEdit, correctOrientation, etc.). The 
> issue is that our method for dereferencing content URIs in FileHelper fails 
> for the content URI returned by Google Photos and returns an empty path (that 
> {{ouputModifiedBitmap()}} tries to grab a filename from)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10270) camera.getPicture() returns an empty string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190079#comment-15190079
 ] 

ASF GitHub Bot commented on CB-10270:
-

Github user riknoll closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/160


> camera.getPicture() returns an empty string
> ---
>
> Key: CB-10270
> URL: https://issues.apache.org/jira/browse/CB-10270
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.1.0
> Environment: Android 4.4.2 (api 19)
>Reporter: Alexander Sorokin
>Priority: Critical
>  Labels: android, mustfix, reproduced, triaged
> Attachments: mobilespec-camera.7z
>
>
> Code sample to reproduce:
> {code}
> navigator.camera.getPicture(onSuccess, onFail, { 
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
> correctOrientation: true
> });
> {code}
> {{onSuccess}} is called with an empty string as an argument.
> if {{correctOrientation}} is {{false}}, everything works as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-9960) Images from Google Photos cause FileNotFoundException

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll resolved CB-9960.
-
Resolution: Fixed

> Images from Google Photos cause FileNotFoundException
> -
>
> Key: CB-9960
> URL: https://issues.apache.org/jira/browse/CB-9960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Android 6.0, cordova-android 5.0.0 (dev), 
> cordova-plugin-camera 1.2.1 (dev)
>Reporter: Richard B Knoll
>Priority: Critical
>  Labels: android, mustfix, triaged
>
> When selecting images from the PHOTOLIBRARY source using the Google Photos 
> application a FileNotFoundException is thrown if any flags that cause image 
> edits are turned on (width/height, allowEdit, correctOrientation, etc.). The 
> issue is that our method for dereferencing content URIs in FileHelper fails 
> for the content URI returned by Google Photos and returns an empty path (that 
> {{ouputModifiedBitmap()}} tries to grab a filename from)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9960) Images from Google Photos cause FileNotFoundException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190083#comment-15190083
 ] 

ASF GitHub Bot commented on CB-9960:


Github user riknoll closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/135


> Images from Google Photos cause FileNotFoundException
> -
>
> Key: CB-9960
> URL: https://issues.apache.org/jira/browse/CB-9960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Android 6.0, cordova-android 5.0.0 (dev), 
> cordova-plugin-camera 1.2.1 (dev)
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>Priority: Critical
>  Labels: android, mustfix, triaged
>
> When selecting images from the PHOTOLIBRARY source using the Google Photos 
> application a FileNotFoundException is thrown if any flags that cause image 
> edits are turned on (width/height, allowEdit, correctOrientation, etc.). The 
> issue is that our method for dereferencing content URIs in FileHelper fails 
> for the content URI returned by Google Photos and returns an empty path (that 
> {{ouputModifiedBitmap()}} tries to grab a filename from)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10270) camera.getPicture() returns an empty string

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190078#comment-15190078
 ] 

ASF GitHub Bot commented on CB-10270:
-

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195077141
  
Seems to have been fixed by #175, so I'm closing this


> camera.getPicture() returns an empty string
> ---
>
> Key: CB-10270
> URL: https://issues.apache.org/jira/browse/CB-10270
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.1.0
> Environment: Android 4.4.2 (api 19)
>Reporter: Alexander Sorokin
>Priority: Critical
>  Labels: android, mustfix, reproduced, triaged
> Attachments: mobilespec-camera.7z
>
>
> Code sample to reproduce:
> {code}
> navigator.camera.getPicture(onSuccess, onFail, { 
> destinationType: Camera.DestinationType.FILE_URI,
> sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
> correctOrientation: true
> });
> {code}
> {{onSuccess}} is called with an empty string as an argument.
> if {{correctOrientation}} is {{false}}, everything works as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10760) config.xml reference does not document plugin element

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190043#comment-15190043
 ] 

ASF GitHub Bot commented on CB-10760:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/536#issuecomment-195072875
  
:+1: 


> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-10760) config.xml reference does not document plugin element

[Omar Mefire (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Mefire resolved CB-10760.
--
Resolution: Fixed

> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10760) config.xml reference does not document plugin element

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190040#comment-15190040
 ] 

ASF GitHub Bot commented on CB-10760:
-

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/536#issuecomment-195072354
  
@riknoll :+1: 
handled.


> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10760) config.xml reference does not document plugin element

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190036#comment-15190036
 ] 

ASF subversion and git services commented on CB-10760:
--

Commit 05a8bc4c7f320c230c2465bd6089a3d1755df24d in cordova-docs's branch 
refs/heads/master from [~omefire]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=05a8bc4 ]

CB-10760: 'version' to 'spect'


> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10836) "Edit" links on docs pages should be more helpful

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189986#comment-15189986
 ] 

ASF GitHub Bot commented on CB-10836:
-

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/551#issuecomment-195061572
  
@nikhilkh @rakatyal @stevengill please review when you have a moment.


> "Edit" links on docs pages should be more helpful
> -
>
> Key: CB-10836
> URL: https://issues.apache.org/jira/browse/CB-10836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Dmitry Blotsky
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Namely, there should be links to:
> - correct place for editing source
> - correct place for translating



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189982#comment-15189982
 ] 

ASF GitHub Bot commented on CB-10679:
-

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-cli/pull/241#issuecomment-195060242
  
LGTM.


> Update plugin add behavior to allow plugins to list engine constraints
> --
>
> Key: CB-10679
> URL: https://issues.apache.org/jira/browse/CB-10679
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Let plugins specify their Cordova related dependencies in their package.json 
> so that the CLI can choose a compatible version for the current project.
> Full specification is here:
> https://github.com/cordova/cordova-discuss/pull/30



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10760) config.xml reference does not document plugin element

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189978#comment-15189978
 ] 

ASF GitHub Bot commented on CB-10760:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/536#issuecomment-195059738
  
I know this was merged, but there was another part to the JIRA. The example 
config.xml at the bottom of the file uses the plugin tag incorrectly (`version` 
should be `spec`)


> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10760) config.xml reference does not document plugin element

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189971#comment-15189971
 ] 

ASF GitHub Bot commented on CB-10760:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/536


> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10760) config.xml reference does not document plugin element

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189970#comment-15189970
 ] 

ASF subversion and git services commented on CB-10760:
--

Commit 47955eb1146de0f5c4ddb33a7156de7e669e6e56 in cordova-docs's branch 
refs/heads/master from [~omefire]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=47955eb ]

CB-10760: Documenting the 'plugin' element


> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10760) config.xml reference does not document plugin element

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189968#comment-15189968
 ] 

ASF subversion and git services commented on CB-10760:
--

Commit 47955eb1146de0f5c4ddb33a7156de7e669e6e56 in cordova-docs's branch 
refs/heads/CB-10760 from [~omefire]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=47955eb ]

CB-10760: Documenting the 'plugin' element


> config.xml reference does not document plugin element
> -
>
> Key: CB-10760
> URL: https://issues.apache.org/jira/browse/CB-10760
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Omar Mefire
>  Labels: Docs-6.x, triaged
>
> The example config.xml on the bottom of the page actually uses this tag, but 
> I also believe the example is incorrect. The {{version}} attribute should be 
> {{spec}}. See 
> http://cordova.apache.org/docs/en/dev/config_ref/index.html#sample-config-xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions

[Jason Ginchereau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Ginchereau resolved CB-7862.
--
Resolution: Fixed

> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with 
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied. 
> I use http://ngcordova.com/ and here is my code 
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189781#comment-15189781
 ] 

ASF subversion and git services commented on CB-10577:
--

Commit 2132bbf2d8bd1d45f500270b64f348f8ba001b75 in cordova-plugin-file's branch 
refs/heads/master from [~jasongin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=2132bbf ]

CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for file


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189782#comment-15189782
 ] 

ASF subversion and git services commented on CB-10577:
--

Commit f863542a7f8fc70e922c358eb132265b181b51e1 in cordova-plugin-file's branch 
refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=f863542 ]

Merge branch 'CB-10577a' of https://github.com/jasongin/cordova-plugin-file


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189783#comment-15189783
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/169


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189759#comment-15189759
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/169#issuecomment-195004006
  
LGTM. Tested on windows phone 8.1 emulator and Windows 10


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10734) NullPointerException for Fade animation in SplashScreen plugin on android

[Harsha Kiran (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsha Kiran updated CB-10734:
--
Description: 
I couldn't replicate the issue on my device, but we see a lot of crash reports 
in our crashlytics log with below message. So looking at code its crashing on 
splashImageView.setAnimation(fadeOut);

So checking if splashImageView is null at line:214 might fix this issue.
```if (fadeSplashScreenDuration > 0)```

```Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual 
method 'void 
android.widget.ImageView.setAnimation(android.view.animation.Animation)' on a 
null object reference
   at 
org.apache.cordova.splashscreen.SplashScreen$3.run(SplashScreen.java:219)
   at android.app.Activity.runOnUiThread(Activity.java:5766)
   at 
org.apache.cordova.splashscreen.SplashScreen.removeSplashScreen(SplashScreen.java:210)
   at 
org.apache.cordova.splashscreen.SplashScreen.onMessage(SplashScreen.java:180)
   at org.apache.cordova.PluginManager.postMessage(PluginManager.java:313)
   at 
org.apache.cordova.CordovaWebViewImpl.postMessage(CordovaWebViewImpl.java:377)
   at 
org.apache.cordova.splashscreen.SplashScreen$1.run(SplashScreen.java:156)
   at android.os.Handler.handleCallback(Handler.java:739)
   at android.os.Handler.dispatchMessage(Handler.java:95)
   at android.os.Looper.loop(Looper.java:145)
   at android.app.ActivityThread.main(ActivityThread.java:6897)
   at java.lang.reflect.Method.invoke(Method.java)
   at java.lang.reflect.Method.invoke(Method.java:372)
   at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)``` 

Full details here -> http://crashes.to/s/6b0613ce153

  was:
I couldn't replicate the issue on my device, but we see a lot of crash reports 
in our crashlytics log with below message. So looking at code its crashing on 
splashImageView.setAnimation(fadeOut);

So checking if splashImageView is null at line:214 might fix this issue.
```if (fadeSplashScreenDuration > 0)```

```Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual 
method 'void 
android.widget.ImageView.setAnimation(android.view.animation.Animation)' on a 
null object reference
   at 
org.apache.cordova.splashscreen.SplashScreen$3.run(SplashScreen.java:219)
   at android.app.Activity.runOnUiThread(Activity.java:5766)
   at 
org.apache.cordova.splashscreen.SplashScreen.removeSplashScreen(SplashScreen.java:210)
   at 
org.apache.cordova.splashscreen.SplashScreen.onMessage(SplashScreen.java:180)
   at org.apache.cordova.PluginManager.postMessage(PluginManager.java:313)
   at 
org.apache.cordova.CordovaWebViewImpl.postMessage(CordovaWebViewImpl.java:377)
   at 
org.apache.cordova.splashscreen.SplashScreen$1.run(SplashScreen.java:156)
   at android.os.Handler.handleCallback(Handler.java:739)
   at android.os.Handler.dispatchMessage(Handler.java:95)
   at android.os.Looper.loop(Looper.java:145)
   at android.app.ActivityThread.main(ActivityThread.java:6897)
   at java.lang.reflect.Method.invoke(Method.java)
   at java.lang.reflect.Method.invoke(Method.java:372)
   at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)``` 




> NullPointerException for Fade animation in SplashScreen plugin on android
> -
>
> Key: CB-10734
> URL: https://issues.apache.org/jira/browse/CB-10734
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Affects Versions: 3.2.0
>Reporter: Harsha Kiran
>  Labels: android, splashscreen
>
> I couldn't replicate the issue on my device, but we see a lot of crash 
> reports in our crashlytics log with below message. So looking at code its 
> crashing on splashImageView.setAnimation(fadeOut);
> So checking if splashImageView is null at line:214 might fix this issue.
> ```if (fadeSplashScreenDuration > 0)```
> ```Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual 
> method 'void 
> android.widget.ImageView.setAnimation(android.view.animation.Animation)' on a 
> null object reference
>at 
> org.apache.cordova.splashscreen.SplashScreen$3.run(SplashScreen.java:219)
>at android.app.Activity.runOnUiThread(Activity.java:5766)
>at 
> org.apache.cordova.splashscreen.SplashScreen.removeSplashScreen(SplashScreen.java:210)
>at 
> org.apache.cordova.splashscreen.SplashScreen.onMessage(SplashScreen.java:180)
>at org.apache.cordova.PluginManager.postMessage(PluginManager.java:313)
>at 
> 

[jira] [Commented] (CB-10734) NullPointerException for Fade animation in SplashScreen plugin on android

[Harsha Kiran (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189737#comment-15189737
 ] 

Harsha Kiran commented on CB-10734:
---

Just wanted to add an update on this. After creating this issue I made this 
change in splashscreen.java:214

if (fadeSplashScreenDuration > 0 && splashImageView != null) and pushed an apk 
but that results in different crash

```Fatal Exception: java.lang.IllegalArgumentException: 
View=com.android.internal.policy.impl.PhoneWindow$DecorView{2014d9d7 V.E. 
R..D 0,0-1440,2560} not attached to window manager
   at 
android.view.WindowManagerGlobal.findViewLocked(WindowManagerGlobal.java:412)
   at 
android.view.WindowManagerGlobal.removeView(WindowManagerGlobal.java:338)
   at 
android.view.WindowManagerImpl.removeViewImmediate(WindowManagerImpl.java:118)
   at android.app.Dialog.dismissDialog(Dialog.java:509)
   at android.app.Dialog.dismiss(Dialog.java:492)
   at 
org.apache.cordova.splashscreen.SplashScreen$3.run(SplashScreen.java:243)
   at android.app.Activity.runOnUiThread(Activity.java:5716)
   at 
org.apache.cordova.splashscreen.SplashScreen.removeSplashScreen(SplashScreen.java:210)
   at 
org.apache.cordova.splashscreen.SplashScreen.onMessage(SplashScreen.java:180)
   at org.apache.cordova.PluginManager.postMessage(PluginManager.java:313)
   at 
org.apache.cordova.CordovaWebViewImpl.postMessage(CordovaWebViewImpl.java:377)
   at 
org.apache.cordova.splashscreen.SplashScreen$1.run(SplashScreen.java:156)
   at android.os.Handler.handleCallback(Handler.java:739)
   at android.os.Handler.dispatchMessage(Handler.java:95)
   at android.os.Looper.loop(Looper.java:145)
   at android.app.ActivityThread.main(ActivityThread.java:6837)
   at java.lang.reflect.Method.invoke(Method.java)
   at java.lang.reflect.Method.invoke(Method.java:372)
   at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)```

Full details here -> http://crashes.to/s/a4083ed1025

Also not sure if this might be related to 
https://issues.apache.org/jira/browse/CB-10692

> NullPointerException for Fade animation in SplashScreen plugin on android
> -
>
> Key: CB-10734
> URL: https://issues.apache.org/jira/browse/CB-10734
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Affects Versions: 3.2.0
>Reporter: Harsha Kiran
>  Labels: android, splashscreen
>
> I couldn't replicate the issue on my device, but we see a lot of crash 
> reports in our crashlytics log with below message. So looking at code its 
> crashing on splashImageView.setAnimation(fadeOut);
> So checking if splashImageView is null at line:214 might fix this issue.
> ```if (fadeSplashScreenDuration > 0)```
> ```Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual 
> method 'void 
> android.widget.ImageView.setAnimation(android.view.animation.Animation)' on a 
> null object reference
>at 
> org.apache.cordova.splashscreen.SplashScreen$3.run(SplashScreen.java:219)
>at android.app.Activity.runOnUiThread(Activity.java:5766)
>at 
> org.apache.cordova.splashscreen.SplashScreen.removeSplashScreen(SplashScreen.java:210)
>at 
> org.apache.cordova.splashscreen.SplashScreen.onMessage(SplashScreen.java:180)
>at org.apache.cordova.PluginManager.postMessage(PluginManager.java:313)
>at 
> org.apache.cordova.CordovaWebViewImpl.postMessage(CordovaWebViewImpl.java:377)
>at 
> org.apache.cordova.splashscreen.SplashScreen$1.run(SplashScreen.java:156)
>at android.os.Handler.handleCallback(Handler.java:739)
>at android.os.Handler.dispatchMessage(Handler.java:95)
>at android.os.Looper.loop(Looper.java:145)
>at android.app.ActivityThread.main(ActivityThread.java:6897)
>at java.lang.reflect.Method.invoke(Method.java)
>at java.lang.reflect.Method.invoke(Method.java:372)
>at 
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
>at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)``` 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189728#comment-15189728
 ] 

ASF GitHub Bot commented on CB-7862:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/168


> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with 
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied. 
> I use http://ngcordova.com/ and here is my code 
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7862) FileReader reads large files in a single chunk causing OOM exceptions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189726#comment-15189726
 ] 

ASF subversion and git services commented on CB-7862:
-

Commit 3eae249cca98de6793ed8af314a89952a912c464 in cordova-plugin-file's branch 
refs/heads/master from [~jasongin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=3eae249 ]

CB-7862: FileReader reads large files in chunks with progress. This closes #168


> FileReader reads large files in a single chunk causing OOM exceptions
> -
>
> Key: CB-7862
> URL: https://issues.apache.org/jira/browse/CB-7862
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.0.0
> Environment: Android
>Reporter: shenzhuxi
>Assignee: Jason Ginchereau
>Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with 
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied. 
> I use http://ngcordova.com/ and here is my code 
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189694#comment-15189694
 ] 

ASF GitHub Bot commented on CB-10679:
-

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-cli/pull/241

CB-10679: Documenting how the CLI chooses plugin versions

Now in the README! Note that this relies on the documentation in 
https://github.com/apache/cordova-docs/pull/521 being merged.

@nikhilkh @dblotsky please take a look.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli CB-10679redo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #241


commit 1a8be501d31aeba99d56fd3280c39693941a99fb
Author: Richard Knoll 
Date:   2016-03-10T18:32:14Z

CB-10679: Documenting how the CLI chooses plugin versions




> Update plugin add behavior to allow plugins to list engine constraints
> --
>
> Key: CB-10679
> URL: https://issues.apache.org/jira/browse/CB-10679
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Let plugins specify their Cordova related dependencies in their package.json 
> so that the CLI can choose a compatible version for the current project.
> Full specification is here:
> https://github.com/cordova/cordova-discuss/pull/30



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10698) loadstart on ios is not being sent in wkwebview

[Marc Luria (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189681#comment-15189681
 ] 

Marc Luria commented on CB-10698:
-

does the fact that has been assigned, mean that there is a good chance it will 
be in next version?  Is it a fix to wkwebview or a fix to cordova-ios?



> loadstart on ios is not being sent in wkwebview
> ---
>
> Key: CB-10698
> URL: https://issues.apache.org/jira/browse/CB-10698
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>Affects Versions: 6.0.0
> Environment: ios
>Reporter: Marc Luria
>Assignee: Shazron Abdullah
>  Labels: ios, triaged
>
> In my app, I depend on the loadstart event during twitter login.  This works 
> fine without wkwebview, but once I add this component, it stops working.  
> I see an loadstart on the initial load, but after that, they stop coming.  
> I tried this with console.log and with breakpoints in the debugger, but I was 
> concerned that the loadstart was being missed, so I sent the messages to my 
> server and logged them there.  It still didn't work.
> The web pages load, during the twitter logon process, including a final page 
> on my site, but no loadstart  (or loadstop or loaderror).  When I hit the 
> done button, I get a loadstart for the last page that was visiting, but this 
> is not really acceptable.
> In the worst case, is there a workaround for this?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10734) NullPointerException for Fade animation in SplashScreen plugin on android

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189673#comment-15189673
 ] 

Nikhil Khandelwal commented on CB-10734:


[~daserge] Can you please review?

> NullPointerException for Fade animation in SplashScreen plugin on android
> -
>
> Key: CB-10734
> URL: https://issues.apache.org/jira/browse/CB-10734
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Affects Versions: 3.2.0
>Reporter: Harsha Kiran
>  Labels: android, splashscreen
>
> I couldn't replicate the issue on my device, but we see a lot of crash 
> reports in our crashlytics log with below message. So looking at code its 
> crashing on splashImageView.setAnimation(fadeOut);
> So checking if splashImageView is null at line:214 might fix this issue.
> ```if (fadeSplashScreenDuration > 0)```
> ```Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual 
> method 'void 
> android.widget.ImageView.setAnimation(android.view.animation.Animation)' on a 
> null object reference
>at 
> org.apache.cordova.splashscreen.SplashScreen$3.run(SplashScreen.java:219)
>at android.app.Activity.runOnUiThread(Activity.java:5766)
>at 
> org.apache.cordova.splashscreen.SplashScreen.removeSplashScreen(SplashScreen.java:210)
>at 
> org.apache.cordova.splashscreen.SplashScreen.onMessage(SplashScreen.java:180)
>at org.apache.cordova.PluginManager.postMessage(PluginManager.java:313)
>at 
> org.apache.cordova.CordovaWebViewImpl.postMessage(CordovaWebViewImpl.java:377)
>at 
> org.apache.cordova.splashscreen.SplashScreen$1.run(SplashScreen.java:156)
>at android.os.Handler.handleCallback(Handler.java:739)
>at android.os.Handler.dispatchMessage(Handler.java:95)
>at android.os.Looper.loop(Looper.java:145)
>at android.app.ActivityThread.main(ActivityThread.java:6897)
>at java.lang.reflect.Method.invoke(Method.java)
>at java.lang.reflect.Method.invoke(Method.java:372)
>at 
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
>at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)``` 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10600) 'cordova run android --release' does not use signed and zip-aligned version of APK

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189650#comment-15189650
 ] 

ASF GitHub Bot commented on CB-10600:
-

GitHub user dpolivy opened a pull request:

https://github.com/apache/cordova-android/pull/273

[CB-10600] 'cordova run --release' uses wrong apk

When doing `cordova run android --release`, the CLI attempts to use the
android-release-unsigned.apk, which naturally fails to install on the
device because it is unsigned. The release build does also generate the
properly signed android-release.apk, and that should be used instead.

The apk-finding logic for "debug" excludes unsigned builds, so the
"release" logic should follow a similar pattern.

Fixes https://issues.apache.org/jira/browse/CB-10600

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpolivy/cordova-android CB10600

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #273


commit c788355ab1cb6234441166bbc92ca7b5c6c4c52b
Author: Dan Polivy 
Date:   2016-03-10T18:05:52Z

[CB-10600] 'cordova run --release' uses wrong apk

When doing `cordova run android --release`, the CLI attempts to use the
android-release-unsigned.apk, which naturally fails to install on the
device because it is unsigned. The release build does also generate the
properly signed android-release.apk, and that should be used instead.

The apk-finding logic for "debug" excludes unsigned builds, so the
"release" logic should follow a similar pattern.

Fixes https://issues.apache.org/jira/browse/CB-10600




> 'cordova run android --release' does not use signed and zip-aligned version 
> of APK
> --
>
> Key: CB-10600
> URL: https://issues.apache.org/jira/browse/CB-10600
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Tested on Windows 8.1 with Cordova CLI 6.0.0 (and Ionic 
> CLI 1.7.14)
>Reporter: Eric Gopak
>Assignee: Joe Bowser
>Priority: Minor
>  Labels: triaged
>
> Running command `cordova run android --release` builds the app successfully, 
> both unsigned and signed/zip-aligned versions. However, it then tries to use 
> the unsigned version of the APK. Here are the last lines of the output:
> .
> BUILD SUCCESSFUL
> Total time: 31.35 secs
> Built the following apk(s):
> 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> C:/X/platforms/android/build/outputs/apk/android-armv7-release.apk
> Using apk: 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> ERROR running one or more of the platforms: Failed to install apk to device: 
> pkg: /data/local/tmp/android-armv7-release-unsigned.apk
> Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES]
> You may not have the required environment or OS to run this project
> It has worked before I updated Cordova with 'npm install -g cordova'.
> I specify signing properties in a file 'release-signing.properties', which I 
> copy to platforms/android/ folder. During the run/build I get prompted for 
> the password, just as it has always been.
> I believe it is just a problem of choosing the wrong APK from the list of 
> built APKs (Cordova probably chooses the one that comes earlier 
> lexicographically)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10600) 'cordova run android --release' does not use signed and zip-aligned version of APK

[Dan Polivy (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189634#comment-15189634
 ] 

Dan Polivy commented on CB-10600:
-

[~nikhilkh] Sure, I can take a stab at it. My only concern is that I don't 
really know this code, so I don't know if this omission is intentional or if it 
will have other effects down the road. Are there specific tests I should run to 
verify? It would also be good to have someone with more familiarity of this 
component chime in.

> 'cordova run android --release' does not use signed and zip-aligned version 
> of APK
> --
>
> Key: CB-10600
> URL: https://issues.apache.org/jira/browse/CB-10600
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Tested on Windows 8.1 with Cordova CLI 6.0.0 (and Ionic 
> CLI 1.7.14)
>Reporter: Eric Gopak
>Assignee: Joe Bowser
>Priority: Minor
>  Labels: triaged
>
> Running command `cordova run android --release` builds the app successfully, 
> both unsigned and signed/zip-aligned versions. However, it then tries to use 
> the unsigned version of the APK. Here are the last lines of the output:
> .
> BUILD SUCCESSFUL
> Total time: 31.35 secs
> Built the following apk(s):
> 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> C:/X/platforms/android/build/outputs/apk/android-armv7-release.apk
> Using apk: 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> ERROR running one or more of the platforms: Failed to install apk to device: 
> pkg: /data/local/tmp/android-armv7-release-unsigned.apk
> Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES]
> You may not have the required environment or OS to run this project
> It has worked before I updated Cordova with 'npm install -g cordova'.
> I specify signing properties in a file 'release-signing.properties', which I 
> copy to platforms/android/ folder. During the run/build I get prompted for 
> the password, just as it has always been.
> I believe it is just a problem of choosing the wrong APK from the list of 
> built APKs (Cordova probably chooses the one that comes earlier 
> lexicographically)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10600) 'cordova run android --release' does not use signed and zip-aligned version of APK

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189630#comment-15189630
 ] 

Nikhil Khandelwal commented on CB-10600:


[~dpolivy] Good find! Would be great if you can submit a PR. This looks like a 
good one to get fixed.

> 'cordova run android --release' does not use signed and zip-aligned version 
> of APK
> --
>
> Key: CB-10600
> URL: https://issues.apache.org/jira/browse/CB-10600
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Tested on Windows 8.1 with Cordova CLI 6.0.0 (and Ionic 
> CLI 1.7.14)
>Reporter: Eric Gopak
>Assignee: Joe Bowser
>Priority: Minor
>  Labels: triaged
>
> Running command `cordova run android --release` builds the app successfully, 
> both unsigned and signed/zip-aligned versions. However, it then tries to use 
> the unsigned version of the APK. Here are the last lines of the output:
> .
> BUILD SUCCESSFUL
> Total time: 31.35 secs
> Built the following apk(s):
> 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> C:/X/platforms/android/build/outputs/apk/android-armv7-release.apk
> Using apk: 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> ERROR running one or more of the platforms: Failed to install apk to device: 
> pkg: /data/local/tmp/android-armv7-release-unsigned.apk
> Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES]
> You may not have the required environment or OS to run this project
> It has worked before I updated Cordova with 'npm install -g cordova'.
> I specify signing properties in a file 'release-signing.properties', which I 
> copy to platforms/android/ folder. During the run/build I get prompted for 
> the password, just as it has always been.
> I believe it is just a problem of choosing the wrong APK from the list of 
> built APKs (Cordova probably chooses the one that comes earlier 
> lexicographically)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10600) 'cordova run android --release' does not use signed and zip-aligned version of APK

[Dan Polivy (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189625#comment-15189625
 ] 

Dan Polivy commented on CB-10600:
-

[~bowserj] I can reproduce this consistently now. Using Cordova 6.0.0. It seems 
to come down to this line of code:

https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GenericBuilder.js#L112

Why is the release case different from debug in NOT excluding {{-unsigned}} 
from the target apk name? When I locally modify this to exclude {{-unsigned}}, 
then it picks up the correct apk and runs just fine.

I am discussing this on slack if you want to chat more about it.

> 'cordova run android --release' does not use signed and zip-aligned version 
> of APK
> --
>
> Key: CB-10600
> URL: https://issues.apache.org/jira/browse/CB-10600
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: Tested on Windows 8.1 with Cordova CLI 6.0.0 (and Ionic 
> CLI 1.7.14)
>Reporter: Eric Gopak
>Assignee: Joe Bowser
>Priority: Minor
>  Labels: triaged
>
> Running command `cordova run android --release` builds the app successfully, 
> both unsigned and signed/zip-aligned versions. However, it then tries to use 
> the unsigned version of the APK. Here are the last lines of the output:
> .
> BUILD SUCCESSFUL
> Total time: 31.35 secs
> Built the following apk(s):
> 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> C:/X/platforms/android/build/outputs/apk/android-armv7-release.apk
> Using apk: 
> C:/X/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> ERROR running one or more of the platforms: Failed to install apk to device: 
> pkg: /data/local/tmp/android-armv7-release-unsigned.apk
> Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES]
> You may not have the required environment or OS to run this project
> It has worked before I updated Cordova with 'npm install -g cordova'.
> I specify signing properties in a file 'release-signing.properties', which I 
> copy to platforms/android/ folder. During the run/build I get prompted for 
> the password, just as it has always been.
> I believe it is just a problem of choosing the wrong APK from the list of 
> built APKs (Cordova probably chooses the one that comes earlier 
> lexicographically)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10838) Switch to CordovaLogger from 'common' in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189606#comment-15189606
 ] 

ASF GitHub Bot commented on CB-10838:
-

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/158#issuecomment-194969878
  
LGTM


> Switch to CordovaLogger from 'common' in Windows
> 
>
> Key: CB-10838
> URL: https://issues.apache.org/jira/browse/CB-10838
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10562) hide() not working in latest splashscreen plug in 3.1.0 in iOS

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-10562:
---
Labels: regression  (was: )

> hide() not working in latest splashscreen plug in 3.1.0 in iOS
> --
>
> Key: CB-10562
> URL: https://issues.apache.org/jira/browse/CB-10562
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Affects Versions: 3.1.0
> Environment: OSX Yosemite, iOS 9, iPhone 6, XCode 7.2.1, Cordova 
> 4.0.1, IONIC app, latest Cordova & IONIC CLIs
>Reporter: Matthias Max
>Assignee: Sergey Shakhnazarov
>Priority: Critical
>  Labels: regression
>
> In version 3.0.0 the command navigator.splashscreen.hide(); works fine.
> With the new version 3.1.0 it simply doesn't close the splashscreen. The 
> splashscreen keeps on being displayed for the time set in the config.xml.
> config.xml:
>   
>   
>   
>   
>   
>   
>   
> JS:
> $ionicPlatform.ready(function() {
> // Hide splash screen
> if (navigator.splashscreen) {
>  navigator.splashscreen.hide();
> }
> });



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10562) hide() not working in latest splashscreen plug in 3.1.0 in iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189586#comment-15189586
 ] 

ASF GitHub Bot commented on CB-10562:
-

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/91#issuecomment-194966042
  
Can we add test cases for this area? Looks like we regressed behavior here.


> hide() not working in latest splashscreen plug in 3.1.0 in iOS
> --
>
> Key: CB-10562
> URL: https://issues.apache.org/jira/browse/CB-10562
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Affects Versions: 3.1.0
> Environment: OSX Yosemite, iOS 9, iPhone 6, XCode 7.2.1, Cordova 
> 4.0.1, IONIC app, latest Cordova & IONIC CLIs
>Reporter: Matthias Max
>Assignee: Sergey Shakhnazarov
>Priority: Critical
>
> In version 3.0.0 the command navigator.splashscreen.hide(); works fine.
> With the new version 3.1.0 it simply doesn't close the splashscreen. The 
> splashscreen keeps on being displayed for the time set in the config.xml.
> config.xml:
>   
>   
>   
>   
>   
>   
>   
> JS:
> $ionicPlatform.ready(function() {
> // Hide splash screen
> if (navigator.splashscreen) {
>  navigator.splashscreen.hide();
> }
> });



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9696) Add possibility to use non-immersive fullscreen in all Android versions

[Julien Roubieu (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189569#comment-15189569
 ] 

Julien Roubieu commented on CB-9696:


I'm surprised there isn't more interest to merge this.
Are you aware of another workaround for your 2d issue (navigation bar hidden 
when keyboard opens)?

> Add possibility to use non-immersive fullscreen in all Android versions
> ---
>
> Key: CB-9696
> URL: https://issues.apache.org/jira/browse/CB-9696
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Affects Versions: Master
>Reporter: Timo Tiuraniemi
>Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Issue CB-8902 added a fullscreen immersive mode for Android version >=4.4 
> Kitkat.
> As I commented on the issue, unfortunately this change broke my >=KitKat app. 
> Immersive mode is significantly different from the old behavior:
> 1. Fullscreen in 4.1.1 is triggered later during boot than in 4.0.0, which 
> cause my layout to slightly break as CSS is evaluated before fullscreen is 
> ready. 
> 2. When activating the keyboard, to navigation bar comes back. It didn't in 
> 4.0.0. When I close the keyboard, the navigation bar doesn't get hidden but 
> fullscreen is lost.
> I propose that we introduce a new setting "fullscreen-immersive" to turn 
> immersive off, but keep fullscreen on like this:
> 
> 
> The new setting would default to true, making this change non-breaking for 
> everyone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10840) Use cordova-common.CordovaLogger in cordova-ios

[Sergey Shakhnazarov (JIRA)]

Sergey Shakhnazarov created CB-10840:


 Summary: Use cordova-common.CordovaLogger in cordova-ios
 Key: CB-10840
 URL: https://issues.apache.org/jira/browse/CB-10840
 Project: Apache Cordova
  Issue Type: Sub-task
  Components: iOS
Reporter: Sergey Shakhnazarov
Assignee: Sergey Shakhnazarov






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10837) platform specific orientation preference is not supported

[Connor Pearson (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189413#comment-15189413
 ] 

Connor Pearson commented on CB-10837:
-

This looks similar to https://issues.apache.org/jira/browse/CB-9975

> platform specific orientation preference is not supported
> -
>
> Key: CB-10837
> URL: https://issues.apache.org/jira/browse/CB-10837
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.4.1
>Reporter: dcz.switcher
>  Labels: build
>
> Hi,
> I want to set Manifest.xml activity with android:screenOrientation="nosensor"
> http://developer.android.com/guide/topics/manifest/activity-element.html#screen
> In cordova doc : 
> Additionally, you can specify any platform-specific orientation value if you 
> place the  element within a  element:
> So, I do it in config.xml
> 
> 
> 
> but on build : 
> Unsupported global orientation: nosensor. Defaulting to value: default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10825) Permission not being requested for photolibrary source

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189398#comment-15189398
 ] 

ASF GitHub Bot commented on CB-10825:
-

Github user csantanapr commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/550#discussion_r55691390
  
--- Diff: www/_posts/2016-03-12-plugin-release.md ---
@@ -0,0 +1,74 @@
+---
+layout: post
+author:
+name: Carlos Santana
+url: https://twitter.com/csantanapr
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-camera@2.1.1
+* cordova-plugin-statusbar@2.1.2
+* cordova-plugin-globalization@1.0.3
+* cordova-plugin-splashscreen@3.2.1
+
+
+
+You can update any plugin by removing it, and then re-adding it.
+
+ E.g. To update your media plugin:
+
+cordova plugin rm cordova-plugin-camera --save
+cordova plugin add cordova-plugin-camera@2.1.1 --save
+
+Changes include:
+
+
+cordova-plugin-camera@2.1.1
+* [CB-10825](https://issues.apache.org/jira/browse/CB-10825) android: 
Always request READ permission for gallery source
--- End diff --

yep, should be be **Android** and entry should be clear, "it should request 
permissions to get a picture"


> Permission not being requested for photolibrary source
> --
>
> Key: CB-10825
> URL: https://issues.apache.org/jira/browse/CB-10825
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Reporter: Richard B Knoll
>Priority: Critical
>  Labels: android, regression, reproduced, triaged
>
> We get a SecurityException for certain cameraOptions in Marshmallow because 
> we do not request the READ_EXTERNAL_STORAGE permission. Here is a repro set:
> {code}
> {
> saveToPhotoAlbum: false,
> targetHeight: -1,
> targetWidth: -1,
> allowEdit: false,
> correctOrientation: false,
> destinationType: Camera.DestinationType.FILE_URI,
> mediaType: Camera.MediaType.PICTURE,
> encodingType: 1,
> sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM
> }
> {code}
> Stack trace:
> {code}
> DatabaseUtils: Writing exception to parcel
> DatabaseUtils: java.lang.SecurityException: Permission Denial: reading 
> com.android.providers.media.MediaProvider uri 
> content://media/external/images/media requires 
> android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
> DatabaseUtils: at 
> android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:605)
> DatabaseUtils: at 
> android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:480)
> DatabaseUtils: at 
> android.content.ContentProvider$Transport.query(ContentProvider.java:211)
> DatabaseUtils: at 
> android.content.ContentProviderNative.onTransact(ContentProviderNative.java:112)
> DatabaseUtils: at android.os.Binder.execTransact(Binder.java:453)
> AndroidRuntime: FATAL EXCEPTION: pool-1-thread-2
> AndroidRuntime: Process: io.cordova.hellocordova
> AndroidRuntime: java.lang.SecurityException: Permission Denial: reading 
> com.android.providers.media.MediaProvider uri 
> content://media/external/images/media requires 
> android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
> AndroidRuntime:at android.os.Parcel.readException(Parcel.java:1620)
> AndroidRuntime:at 
> android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:183)
> AndroidRuntime:at 
> android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:135)
> AndroidRuntime:at 
> android.content.ContentProviderProxy.query(ContentProviderNative.java:421)
> AndroidRuntime:at 
> android.content.ContentResolver.query(ContentResolver.java:491)
> AndroidRuntime:at 
> android.content.ContentResolver.query(ContentResolver.java:434)
> AndroidRuntime:at 
> org.apache.cordova.camera.FileHelper.getDataColumn(FileHelper.java:292)
> AndroidRuntime:at 
> org.apache.cordova.camera.FileHelper.getRealPathFromURI_API19(FileHelper.java:128)
> AndroidRuntime:at 
> org.apache.cordova.camera.FileHelper.getRealPath(FileHelper.java:64)
> AndroidRuntime:at 
> org.apache.cordova.camera.CameraLauncher.processResultFromGallery(CameraLauncher.java:623)
> AndroidRuntime:at 
> org.apache.cordova.camera.CameraLauncher.access$000(CameraLauncher.java:66)
> AndroidRuntime:at 
> org.apache.cordova.camera.CameraLauncher$1.run(CameraLauncher.java:781)
> AndroidRuntime:at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
> AndroidRuntime:at 
> 

[jira] [Commented] (CB-10791) Add adjustLoggerLevel to cordova-common.CordovaLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189363#comment-15189363
 ] 

ASF GitHub Bot commented on CB-10791:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/405


> Add adjustLoggerLevel to cordova-common.CordovaLogger
> -
>
> Key: CB-10791
> URL: https://issues.apache.org/jira/browse/CB-10791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10679) Update plugin add behavior to allow plugins to list engine constraints

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189364#comment-15189364
 ] 

ASF GitHub Bot commented on CB-10679:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/406


> Update plugin add behavior to allow plugins to list engine constraints
> --
>
> Key: CB-10679
> URL: https://issues.apache.org/jira/browse/CB-10679
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Let plugins specify their Cordova related dependencies in their package.json 
> so that the CLI can choose a compatible version for the current project.
> Full specification is here:
> https://github.com/cordova/cordova-discuss/pull/30



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10791) Add adjustLoggerLevel to cordova-common.CordovaLogger

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189362#comment-15189362
 ] 

ASF subversion and git services commented on CB-10791:
--

Commit 0386ac2cd76671001ce3d566148522cfd8de614a in cordova-lib's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=0386ac2 ]

CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger

Adds corresponding tests


> Add adjustLoggerLevel to cordova-common.CordovaLogger
> -
>
> Key: CB-10791
> URL: https://issues.apache.org/jira/browse/CB-10791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10562) hide() not working in latest splashscreen plug in 3.1.0 in iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189349#comment-15189349
 ] 

ASF GitHub Bot commented on CB-10562:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/91

CB-10562 hide() not working in latest splashscreen plug in 3.1.0 in iOS

[Jira issue](https://issues.apache.org/jira/browse/CB-10562)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen 
CB-10562

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit ee5be0413e2e2300cb0e8ed58ad13898cd18d968
Author: daserge 
Date:   2016-03-10T12:38:32Z

CB-10562 hide() not working in latest splashscreen plug in 3.1.0 in iOS




> hide() not working in latest splashscreen plug in 3.1.0 in iOS
> --
>
> Key: CB-10562
> URL: https://issues.apache.org/jira/browse/CB-10562
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Affects Versions: 3.1.0
> Environment: OSX Yosemite, iOS 9, iPhone 6, XCode 7.2.1, Cordova 
> 4.0.1, IONIC app, latest Cordova & IONIC CLIs
>Reporter: Matthias Max
>Assignee: Sergey Shakhnazarov
>Priority: Critical
>
> In version 3.0.0 the command navigator.splashscreen.hide(); works fine.
> With the new version 3.1.0 it simply doesn't close the splashscreen. The 
> splashscreen keeps on being displayed for the time set in the config.xml.
> config.xml:
>   
>   
>   
>   
>   
>   
>   
> JS:
> $ionicPlatform.ready(function() {
> // Hide splash screen
> if (navigator.splashscreen) {
>  navigator.splashscreen.hide();
> }
> });



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10835) icon proportion on cordova android 5.1

[Yann (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yann updated CB-10835:
--
Affects Version/s: (was: 3.3.0)
   (was: 3.2.0)
   (was: 3.1.0)
   (was: 2.6.0)
   (was: 3.0.0)
   1.2.1
   0.6.1
   1.1.0
   1.2.0
   1.3.0

> icon proportion on cordova android 5.1
> --
>
> Key: CB-10835
> URL: https://issues.apache.org/jira/browse/CB-10835
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 1.1.0, 1.2.0, 1.3.0, 0.6.1, 1.2.1
> Environment: android
>Reporter: Yann
>
> On cordova android 5.1 the toolbar from the in app browser is display with 
> messy button. 
> Button images have not good proportion. 
> On cordova android 4.1.1 no problem. 
> Screenshot : http://imgur.com/7xhW4oH



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10749) Use cordova-common.CordovaLogger in cordova-android

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-10749:
--
Issue Type: Sub-task  (was: Improvement)
Parent: CB-10839

> Use cordova-common.CordovaLogger in cordova-android
> ---
>
> Key: CB-10749
> URL: https://issues.apache.org/jira/browse/CB-10749
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> We need to replace custom logging in CLI and platforms with now default 
> implementation from CB-10176. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10837) platform specific orientation preference is not supported

[dcz.switcher (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189308#comment-15189308
 ] 

dcz.switcher commented on CB-10837:
---

note : I try orientation and Orientation

> platform specific orientation preference is not supported
> -
>
> Key: CB-10837
> URL: https://issues.apache.org/jira/browse/CB-10837
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.4.1
>Reporter: dcz.switcher
>  Labels: build
>
> Hi,
> I want to set Manifest.xml activity with android:screenOrientation="nosensor"
> http://developer.android.com/guide/topics/manifest/activity-element.html#screen
> In cordova doc : 
> Additionally, you can specify any platform-specific orientation value if you 
> place the  element within a  element:
> So, I do it in config.xml
> 
> 
> 
> but on build : 
> Unsupported global orientation: nosensor. Defaulting to value: default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10838) Switch to CordovaLogger from 'common' in Windows

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-10838:
--
Issue Type: Sub-task  (was: Task)
Parent: CB-10839

> Switch to CordovaLogger from 'common' in Windows
> 
>
> Key: CB-10838
> URL: https://issues.apache.org/jira/browse/CB-10838
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10839) Switch to shared CordovaLogger in platforms that use 'cordova-common'

[Vladimir Kotikov (JIRA)]

Vladimir Kotikov created CB-10839:
-

 Summary: Switch to shared CordovaLogger in platforms that use 
'cordova-common'
 Key: CB-10839
 URL: https://issues.apache.org/jira/browse/CB-10839
 Project: Apache Cordova
  Issue Type: Task
  Components: Android, iOS, Windows
Reporter: Vladimir Kotikov






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10838) Switch to CordovaLogger from 'common' in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189296#comment-15189296
 ] 

ASF GitHub Bot commented on CB-10838:
-

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/158

CB-10838 Use logger from cordova-common

This implements https://issues.apache.org/jira/browse/CB-10838

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10838

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #158


commit 166ec9ad34760b50699da3bd2ae3af277fefe5a2
Author: Vladimir Kotikov 
Date:   2016-03-10T12:37:11Z

CB-10838 Upgrade cordova-common to 1.1.0

commit f8958213983bc1b80b85e2c5de85e4238d7b172c
Author: Vladimir Kotikov 
Date:   2016-03-10T13:10:08Z

CB-10838 Use logger from cordova-common




> Switch to CordovaLogger from 'common' in Windows
> 
>
> Key: CB-10838
> URL: https://issues.apache.org/jira/browse/CB-10838
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Windows
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10838) Switch to CordovaLogger from 'common' in Windows

[Vladimir Kotikov (JIRA)]

Vladimir Kotikov created CB-10838:
-

 Summary: Switch to CordovaLogger from 'common' in Windows
 Key: CB-10838
 URL: https://issues.apache.org/jira/browse/CB-10838
 Project: Apache Cordova
  Issue Type: Task
  Components: Windows
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10837) platform specific orientation preference is not supported

[dcz.switcher (JIRA)]

dcz.switcher created CB-10837:
-

 Summary: platform specific orientation preference is not supported
 Key: CB-10837
 URL: https://issues.apache.org/jira/browse/CB-10837
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: 5.4.1
Reporter: dcz.switcher


Hi,

I want to set Manifest.xml activity with android:screenOrientation="nosensor"

http://developer.android.com/guide/topics/manifest/activity-element.html#screen

In cordova doc : 
Additionally, you can specify any platform-specific orientation value if you 
place the  element within a  element:

So, I do it in config.xml





but on build : 
Unsupported global orientation: nosensor. Defaulting to value: default





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8657) app icon config declaration not working for fire os

[JIRA]

[ 
https://issues.apache.org/jira/browse/CB-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189242#comment-15189242
 ] 

Benny Görlitz commented on CB-8657:
---

any updates?


> app icon config declaration not working for fire os
> ---
>
> Key: CB-8657
> URL: https://issues.apache.org/jira/browse/CB-8657
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Amazon FireOS (deprecated)
>Affects Versions: 3.5.0
> Environment: i used newest cordova 4.3
>Reporter: Benny Görlitz
>Assignee: Archana Naik
>Priority: Minor
>
> it seems that the icon declaration is not working properly.
> it does not matter what i configure for plarform amazon-fireos:
> {code}
> 
> 
> 
> {code}
> only the android platform setting take affect, so i'm forced to configure 
> android like this:
> {code}
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}
> thats because fireos has big coverflow app icons that are very blurry with 
> default android settings.
> please use android icon settings only in case of fallback when no 
> amazon-fireos setting is existent.
> cheers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org