[jira] [Commented] (CB-9490) LG G4 camera application saves photos when using destinationType DATA_URL

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387060#comment-15387060
 ] 

ASF GitHub Bot commented on CB-9490:


Github user cojomojo closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/115


> LG G4 camera application saves photos when using destinationType DATA_URL
> -
>
> Key: CB-9490
> URL: https://issues.apache.org/jira/browse/CB-9490
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: LG G4, Android 5.1
>Reporter: Cody Balos
>Assignee: Cody Balos
>Priority: Minor
>  Labels: Android, triaged
>  Time Spent: 6h
>  Remaining Estimate: 0h
>
> So far this issue only happens on an LG G4 using the stock camera application:
> Using the camera plugin, with destinationType set to DATA_URL,
> the expected functionality is for the base64 string to be returned to the 
> javascript interface, and not saved to the file system without explicitly 
> saving it separately. Using the LG G4 stock camera application, all photos 
> are saved even when using destinationType DATA_URL if the retake option is 
> used. 
> The issue does not occur when using the Google Camera application or Camera 
> 360 (both on the Play Store). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11374) Support applicationId for android on config.xml

2016-07-20 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CB-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386892#comment-15386892
 ] 

Frederico Costa Galvão commented on CB-11374:
-

Also need to make it so that *device.js* uses the applicationId from config.xml 
when launching the application on *run*, instead of using 
*pkgName=manifest.getPackageId();*.

> Support applicationId for android on config.xml
> ---
>
> Key: CB-11374
> URL: https://issues.apache.org/jira/browse/CB-11374
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Android, CLI
>Affects Versions: 6.2.0
>Reporter: Frederico Costa Galvão
>Priority: Minor
>
> After discovering these hidden/undocumented options \[1\], while trying to 
> set up my cordova project to be whitelabel-friendly, I realized that a 
> *android-applicationId* setting should be made available on config.xml now 
> that android decoupled *applicationId* from *packageName*.
> An initial PR related to this topic was 
> https://github.com/apache/cordova-android/pull/247, but the "more robust" 
> thing was left for later. This second step should be fairly easy to set up, I 
> guess.
> \[1\] https://issues.apache.org/jira/browse/CB-11373



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-11607) breakout cordova-create from cordova-lib

2016-07-20 Thread Steve Gill (JIRA)
Steve Gill created CB-11607:
---

 Summary: breakout cordova-create from cordova-lib
 Key: CB-11607
 URL: https://issues.apache.org/jira/browse/CB-11607
 Project: Apache Cordova
  Issue Type: Improvement
Reporter: Steve Gill
Assignee: Caryn Tran


As the title suggests, lets breakout cordova-create from cordova-lib and 
publish it as its own module. It can live in the cordova-lib git repo. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386758#comment-15386758
 ] 

ASF GitHub Bot commented on CB-9825:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/461


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386757#comment-15386757
 ] 

ASF subversion and git services commented on CB-9825:
-

Commit 29382ca2bf67e17337845feb4360980df99fe3d2 in cordova-lib's branch 
refs/heads/master from [~juliascript]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=29382ca ]

CB-9825 framework tag spec parsing

 This closes #461


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-11606) Cordova.js not including the WinJS Base.js file correctly

2016-07-20 Thread linda zhong (JIRA)
linda zhong created CB-11606:


 Summary: Cordova.js not including the WinJS Base.js file correctly
 Key: CB-11606
 URL: https://issues.apache.org/jira/browse/CB-11606
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaJS, Windows
Reporter: linda zhong
Priority: Minor


If I remote debug to x64 the app side loads through the debugger. I can click 
around, do everything, no problem.
BUT once I disconnect the debug process, and then start the app on the surface, 
it flashes open, then closes... the error from that closing seems to be related 
to Windows not being defined( i assume from the base) and then creating DB 
connections off of that.

I thought maybe it was a change in the debugging setup, so I went through the 
whole process of side loading it, and the same thing happens. 
I traced it down to Cordova not including the Base.js file correctly, there 
seem to be pathing issues, but only when i run it on the surface, without the 
debugger... so I'm confused.
Of course, since i side loaded it onto the x64 surface, I thought, I could 
sideload the app onto the Surface RT, which i did, and guess what, it works 
fine there. 
So why would the same app, side loaded on RT work, but not on x64.
Is there something different in the Base file its trying to use, maybe it 
exists for one but not the other?

If I run the index.html in chrome, i can see more errors, so debugging with 
that I see a few more things.

Here is the code in the cordova.js file thats messing up the include (line 1449 
in the cordova js i have)

if (!window.WinJS) {
    var scriptElem = document.createElement("script");

    if (navigator.appVersion.indexOf('MSAppHost/3.0') !== -1) {
    // Windows 10 UWP
    scriptElem.src = '/www/WinJS/js/base.js';
    } else if (navigator.appVersion.indexOf("Windows Phone 8.1;") !== 
-1) {
    // windows phone 8.1 + Mobile IE 11
    scriptElem.src = "//Microsoft.Phone.WinJS.2.1/js/base.js";
    } else if (navigator.appVersion.indexOf("MSAppHost/2.0;") !== -1) {
    // windows 8.1 + IE 11
    scriptElem.src = "//Microsoft.WinJS.2.0/js/base.js";
    } else {
    // windows 8.0 + IE 10
    scriptElem.src = "//Microsoft.WinJS.1.0/js/base.js";
    }
    scriptElem.addEventListener("load", onWinJSReady);
    document.head.appendChild(scriptElem);
    }

The x64 is firing this include - the else
  scriptElem.src = "//Microsoft.WinJS.1.0/js/base.js";

When I inspect it loading locally on my machine, its using


If i hard code a script tag to the WinJS/js/base.js that error goes away from 
the console, but then i am still seeing the error for Windows. is not defined.

Now, with the base.js fixed, its not showing errors in the windows events log, 
but its still crashing on start up.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-5137) docs should describe how to build Cordova from Apache dist

2016-07-20 Thread Jesse MacFadyen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse MacFadyen resolved CB-5137.
-
Resolution: Not A Problem

I believe this is no longer valid.  The 'new' apache way is to get the projects 
from our npm releases, or in some cases, github mirrors.
People who are tech savvy enough to want to build from apache git distro/repos 
would very likely also be able to figure that out. So the number of people 
potentially affected here is near zero, I think.

Please feel free to re-open if you disagree, otherwise, [~cmarcelk] has one 
less in progress task.

> docs should describe how to build Cordova from Apache dist
> --
>
> Key: CB-5137
> URL: https://issues.apache.org/jira/browse/CB-5137
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Marcel Kinard
>Assignee: Marcel Kinard
>Priority: Minor
>
> The docs seem to assume that Cordova was already downloaded either via npm or 
> from a PhoneGap distribution or similar. Though the Apache Way is to 
> distribute source code, it isn't clear to the average consumer in the docs 
> how to get Cordova up and running from either the source zips on 
> dist.apache.org or from the repos at git-wip-us.apache.org. This 
> documentation should be added, perhaps as a section such as "How to Obtain 
> Cordova" and/or "How to Build Cordova from Source".
> There may be additional docs needed that describe how to bootstrap the docs 
> (build the html from the md) if for some reason the user can't get them 
> online at cordova.apache.org/docs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-6208) Docs do not mention Git requirement for plugin adding

2016-07-20 Thread Jesse MacFadyen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse MacFadyen resolved CB-6208.
-
Resolution: Fixed

Done

> Docs do not mention Git requirement for plugin adding
> -
>
> Key: CB-6208
> URL: https://issues.apache.org/jira/browse/CB-6208
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Raymond Camden
>Priority: Minor
>
> Twice now I've run into people who have an issue adding a plugin because they 
> don't have Git installed. While the error is pretty clear, it is in the 
> middle of a bunch of other output and the docs should note that this is a 
> dependancy. To be fair, it isn't necessarily something you need to run a CLI, 
> but as soon as you add a plugin (which is pretty much *always* required now), 
> you run into it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-9919) Docs gen uses Windows line endings on Windows

2016-07-20 Thread Jesse MacFadyen (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386541#comment-15386541
 ] 

Jesse MacFadyen commented on CB-9919:
-

Is this still relevant?  If not please close.

> Docs gen uses Windows line endings on Windows
> -
>
> Key: CB-9919
> URL: https://issues.apache.org/jira/browse/CB-9919
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Windows 10
>Reporter: Richard B Knoll
>Priority: Minor
>
> The new precommit hook that generates the docs in the camera repo uses the 
> line endings of the environment you're developing in. This means that 
> whenever I commit in in Windows, it tries to commit a huge diff in the README 
> because it changes all of the line endings



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-5402) InAppBrowser doc needs some improvement

2016-07-20 Thread Jesse MacFadyen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse MacFadyen resolved CB-5402.
-
Resolution: Fixed

> InAppBrowser doc needs some improvement
> ---
>
> Key: CB-5402
> URL: https://issues.apache.org/jira/browse/CB-5402
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Affects Versions: 3.2.0
>Reporter: Marcel Kinard
>Priority: Minor
>
> The nice description of the behaviors on 
> https://wiki.apache.org/cordova/InAppBrowser (especially with regard to the 
> different target parms) isn't really present in 
> http://cordova.apache.org/docs/en/edge/cordova_inappbrowser_inappbrowser.md.html
>  . Just migrating that information over would be a big help. And there are 
> some minor wording inconsistencies, i.e. "details" vs. "injectDetails".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-5402) InAppBrowser doc needs some improvement

2016-07-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386531#comment-15386531
 ] 

ASF subversion and git services commented on CB-5402:
-

Commit fc7452c445c60996bdd0b1d8da21c7e57892aa63 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=fc7452c
 ]

CB-5402 Merge doc improvements


> InAppBrowser doc needs some improvement
> ---
>
> Key: CB-5402
> URL: https://issues.apache.org/jira/browse/CB-5402
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Affects Versions: 3.2.0
>Reporter: Marcel Kinard
>Priority: Minor
>
> The nice description of the behaviors on 
> https://wiki.apache.org/cordova/InAppBrowser (especially with regard to the 
> different target parms) isn't really present in 
> http://cordova.apache.org/docs/en/edge/cordova_inappbrowser_inappbrowser.md.html
>  . Just migrating that information over would be a big help. And there are 
> some minor wording inconsistencies, i.e. "details" vs. "injectDetails".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-5402) InAppBrowser doc needs some improvement

2016-07-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386532#comment-15386532
 ] 

ASF subversion and git services commented on CB-5402:
-

Commit 2a3a0cecab0fd02e71c5a4ce867c627ec5c17b8a in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=2a3a0ce
 ]

CB-5402 added extra content from wiki page


> InAppBrowser doc needs some improvement
> ---
>
> Key: CB-5402
> URL: https://issues.apache.org/jira/browse/CB-5402
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Affects Versions: 3.2.0
>Reporter: Marcel Kinard
>Priority: Minor
>
> The nice description of the behaviors on 
> https://wiki.apache.org/cordova/InAppBrowser (especially with regard to the 
> different target parms) isn't really present in 
> http://cordova.apache.org/docs/en/edge/cordova_inappbrowser_inappbrowser.md.html
>  . Just migrating that information over would be a big help. And there are 
> some minor wording inconsistencies, i.e. "details" vs. "injectDetails".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386513#comment-15386513
 ] 

ASF GitHub Bot commented on CB-11241:
-

Github user toddm commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
:shipit:


> File encoding test fails with UTF-8 file encoding error on windows store 
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
>  Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file 
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the 
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save 
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not 
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-677) Docs/Getting Started Guides

2016-07-20 Thread Jesse MacFadyen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse MacFadyen resolved CB-677.

Resolution: Fixed

Ima call dis done. Great work everyone.

> Docs/Getting Started Guides
> ---
>
> Key: CB-677
> URL: https://issues.apache.org/jira/browse/CB-677
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Affects Versions: Master
>Reporter: Andrew Trice
>Assignee: Michael Brooks
>Priority: Minor
> Fix For: Master
>
>
> I have gotten a lot of feedback from Adobe customers and developers at 
> conferences on this... In general, the getting started guides are great at 
> getting people's environments configured, but many end up wondering "what do 
> I do next".  It would be great to have docs/guidance on "next steps", 
> including strategies to make your apps feel more like "apps" and less like 
> "the web", performance optimizations, and possibly case studies on how 
> showcase apps were created.  This JIRA issue is intended for tracking 
> purposes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386136#comment-15386136
 ] 

ASF GitHub Bot commented on CB-11241:
-

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
+1 :shipit: 


> File encoding test fails with UTF-8 file encoding error on windows store 
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
>  Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file 
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the 
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save 
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not 
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386130#comment-15386130
 ] 

ASF GitHub Bot commented on CB-11241:
-

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/187#discussion_r71557328
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -512,8 +515,6 @@ function addBOMSignature(directory) {
 });
--- End diff --

+1


> File encoding test fails with UTF-8 file encoding error on windows store 
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
>  Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file 
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the 
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save 
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not 
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11382) Camera will not open

2016-07-20 Thread IagoSRL (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385730#comment-15385730
 ] 

IagoSRL commented on CB-11382:
--

Hi again!
Found a good solution (not workaround): I was working with cordova-android 
4.1.1 (default at Phonegag 5.2.0, using Phonegap Build service), after updating 
to cordova-android version 5.1.1 (currently the latest avaiilable at Phonegap 
Build), the plugin worked again using a targetSdkVersion of 23 (or default).
Now when trying to use getPicture, Android shows the permissions dialog and 
after tap Allow everything goes as expected.

Additionally, I updated my targetSdkVersion to 23 (or left default one) to get 
the APK accepted at Google Play store.

Note: I found a problem that prevented me from clicking 'Allow' button, is a 
problem from other App ("File Manager" on my case), as commented at 
https://code.google.com/p/android/issues/detail?id=212934

Reviewing plugin README, it says "This requires cordova 5.0+", since I was 
using Phonegap/Cordova 5.2.0 I expected I was in the correct version. Maybe it 
can specify it clearer that the required is "cordova-android 5.0+"? And add 
some note about Android 6 permissions, and this issue can be closed.

> Camera will not open
> 
>
> Key: CB-11382
> URL: https://issues.apache.org/jira/browse/CB-11382
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Reporter: Ivan
>
> I'm using Cordova Camera Plugin 
> (https://www.npmjs.com/package/cordova-plugin-camera) and starting with this 
> line
> navigator.camera.getPicture(onSuccessPhoto, onFailPhoto, { quality: 50, 
> destinationType: Camera.DestinationType.FILE_URI });
> On android 6.0.1. camera will not open and I got error 
> "permission denial: ... requires android.permission.read_external_storage or 
> granturipermission()"
> On lower android version it works fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385724#comment-15385724
 ] 

ASF GitHub Bot commented on CB-11241:
-

Github user sgrebnov commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
LGTM :+1: 


> File encoding test fails with UTF-8 file encoding error on windows store 
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
>  Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file 
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the 
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save 
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not 
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11382) Camera will not open

2016-07-20 Thread IagoSRL (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385674#comment-15385674
 ] 

IagoSRL commented on CB-11382:
--

A workaround that may help some people: set the targetSdkVersion of your 
project to 22 or lower (that's immediately before Android 6 / API 23). That 
way, the new permissions management will not be used and the camera plugin will 
work.
Do it with next preference at the config.xml:


Take care: doing that, the app or included plugins cannot use any new feature 
from a higher Android API level.
Note: Even with that, the app can run at Android 6 devices and newer.
Google Play note: if you have already uploaded and published an APK with a 
target SDK of 23 (the default used at latest cordova-android), you cannot use 
this solution since the store will prevent you from downgrading the target SDK 
version of your app. This happens on any channel: alpha, beta and production.

I have this last problem, I cannot go back and my production App is just broken 
because of this bug, since I updated cordova-android without notice this could 
happen.

> Camera will not open
> 
>
> Key: CB-11382
> URL: https://issues.apache.org/jira/browse/CB-11382
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Reporter: Ivan
>
> I'm using Cordova Camera Plugin 
> (https://www.npmjs.com/package/cordova-plugin-camera) and starting with this 
> line
> navigator.camera.getPicture(onSuccessPhoto, onFailPhoto, { quality: 50, 
> destinationType: Camera.DestinationType.FILE_URI });
> On android 6.0.1. camera will not open and I got error 
> "permission denial: ... requires android.permission.read_external_storage or 
> granturipermission()"
> On lower android version it works fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission

2016-07-20 Thread Roberto De Simone (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385659#comment-15385659
 ] 

Roberto De Simone commented on CB-11241:


[~vladimir.kotikov] thanks for the info!

> File encoding test fails with UTF-8 file encoding error on windows store 
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
>  Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file 
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the 
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save 
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not 
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-10478) getCurrentPosition should trigger system dialog for enabling location services

2016-07-20 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385645#comment-15385645
 ] 

Dave Alden commented on CB-10478:
-

cordova-plugin-request-location-accuracy@2.0.0 
(https://github.com/dpa99c/cordova-plugin-request-location-accuracy) enables a 
direct location request to be made which triggers the native iOS dialog to 
directly open the Privacy page in the Settings app where the switch for 
Location Services is located.

> getCurrentPosition should trigger system dialog for enabling location services
> --
>
> Key: CB-10478
> URL: https://issues.apache.org/jira/browse/CB-10478
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: Plugin Geolocation
> Environment: iOS, Android
>Reporter: Zarko Hristovski
>  Labels: features, iOS, triaged
>
> The use case is when an app/user needs to access geoposition while 
> device's location services are disabled. Let's say for the first time / 
> attempt.
> While I've been able to find a way to send the user directly to the 
> system setting on Android (via cordova-diagnostic-plugin's 
> switchToLocationSettings),
> it seems to be no obvious way to achieve the same on iOS with the 
> plugin(s) at present.
> I'll point you to two existing threads that explain in more detail so 
> that I don't repeat myself here:
> - 
> https://forum.ionicframework.com/t/ios-plugin-for-sending-user-to-settings-privacy-location-services
> - https://github.com/dpa99c/cordova-diagnostic-plugin/issues/31
> I thus suggest extending getCurrentPosition with an option for a better UX in 
> case the device's location services are disabled. On iOS it should trigger 
> the system dialog where the user is given a choice between "Settings" and 
> "Cancel". "Settings" gives the user the possibility to go straight into 
> Settings->Privacy->Location Services.
> I would suggest covering the same for Android, even thought this issue is 
> concerned mainly with the UX on iOS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11321) Plugin install error: Cannot call method 'indexOf' of undefined - splashScreen plugin

2016-07-20 Thread Atif Gulzar (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385636#comment-15385636
 ] 

Atif Gulzar commented on CB-11321:
--

cordova --version
6.2.0

cordova platform
Installed platforms:
  ios 4.1.1
Available platforms: 
  amazon-fireos ~3.6.3 (deprecated)
  android ~5.1.1
  blackberry10 ~3.8.0
  browser ~4.1.0
  firefoxos ~3.6.3
  osx ~4.0.1
  webos ~3.7.0

cordova plugins
com.phonegap.plugins.PushPlugin 3.2.0 "PushPlugin"
cordova-plugin-appversion 1.0.0 "App Version"
cordova-plugin-device 1.1.2 "Device"
cordova-plugin-dialogs 1.2.1 "Notification"
cordova-plugin-globalization 1.0.3 "Globalization"
cordova-plugin-google-analytics 0.8.1 "Google Universal Analytics Plugin"
cordova-plugin-inappbrowser 1.4.1-dev "InAppBrowser"
cordova-plugin-safariviewcontroller 1.4.3 "SafariViewController"
cordova-plugin-splashscreen 4.0.0 "Splashscreen"
cordova-plugin-whitelist 1.2.2 "Whitelist"

> Plugin install error: Cannot call method 'indexOf' of undefined - 
> splashScreen plugin
> -
>
> Key: CB-11321
> URL: https://issues.apache.org/jira/browse/CB-11321
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Affects Versions: 3.5.0
> Environment: IOS
>Reporter: Atif Gulzar
>Assignee: Sergey Shakhnazarov
>  Labels: github-import, no-repro, triaged, wfc
>
> AtifMacPro:cordova wison$ cordova plugin add 
> https://github.com/apache/cordova-plugin-splashscreen.git
> Fetching plugin "https://github.com/apache/cordova-plugin-splashscreen.git"; 
> via git clone
> Installing "cordova-plugin-splashscreen" for ios
> TypeError: Cannot call method 'indexOf' of undefined
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:232:55
> at Array.forEach (native)
> at getEngines 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:211:13)
> at runInstall 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:281:22)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:81:16
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:749:13)
> at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:810:14
> at flush (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:108:17)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission

2016-07-20 Thread Vladimir Kotikov (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385628#comment-15385628
 ] 

Vladimir Kotikov commented on CB-11241:
---

[~rdesimone], the PR also should fix you problem about not adding BOM to 
{{.htm}} files

> File encoding test fails with UTF-8 file encoding error on windows store 
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
>  Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file 
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the 
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save 
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not 
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385617#comment-15385617
 ] 

ASF GitHub Bot commented on CB-11241:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
/cc @sgrebnov, @purplecabbage. Could you please take a look?


> File encoding test fails with UTF-8 file encoding error on windows store 
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
>  Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file 
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the 
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save 
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not 
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11605) platform update should be non-destructive

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385499#comment-15385499
 ] 

ASF GitHub Bot commented on CB-11605:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/465
  
## [Current coverage][cc-pull] is **61.73%**
> Merging [#465][cc-pull] into [master][cc-base-branch] will decrease 
coverage by **18.88%**

```diff
@@ master   #465   diff @@
==
  Files68 67  -1   
  Lines  5394   5405 +11   
  Methods 855856  +1   
  Messages  0  0   
  Branches   1040   1042  +2   
==
- Hits   4349   3337   -1012   
- Misses 1045   2068   +1023   
  Partials  0  0   
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[f05874a...82de549][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-lib/compare/f05874a5420ea5fcf5b96290cb1a7fe18fe3e6d6...82de54982af0e087a16da68a813baab01882d57c?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/465?src=pr


> platform update should be non-destructive
> -
>
> Key: CB-11605
> URL: https://issues.apache.org/jira/browse/CB-11605
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>
> More details here:
> https://github.com/cordova/cordova-discuss/issues/50
> and here:
> http://markmail.org/message/nrabt2f4kcbp6vkh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11605) platform update should be non-destructive

2016-07-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385488#comment-15385488
 ] 

ASF GitHub Bot commented on CB-11605:
-

GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-lib/pull/465

CB-11605 Non-destructive platform update

backup platformId@oldVersion before updating

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-lib CB-11605

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #465


commit fdda80fe572e2766d5aeeb674de0c7334553d2cc
Author: Jesse MacFadyen 
Date:   2016-07-20T07:27:30Z

backup platformId@oldVersion before updating




> platform update should be non-destructive
> -
>
> Key: CB-11605
> URL: https://issues.apache.org/jira/browse/CB-11605
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>
> More details here:
> https://github.com/cordova/cordova-discuss/issues/50
> and here:
> http://markmail.org/message/nrabt2f4kcbp6vkh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-11605) platform update should be non-destructive

2016-07-20 Thread Jesse MacFadyen (JIRA)
Jesse MacFadyen created CB-11605:


 Summary: platform update should be non-destructive
 Key: CB-11605
 URL: https://issues.apache.org/jira/browse/CB-11605
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Reporter: Jesse MacFadyen
Assignee: Jesse MacFadyen




More details here:
https://github.com/cordova/cordova-discuss/issues/50

and here:
http://markmail.org/message/nrabt2f4kcbp6vkh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org