[jira] [Commented] (CB-11705) [iOS-Cordova] Add configuration to override default WebViewEngine
[ https://issues.apache.org/jira/browse/CB-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429124#comment-15429124 ] ASF GitHub Bot commented on CB-11705: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/241 > [iOS-Cordova] Add configuration to override default WebViewEngine > - > > Key: CB-11705 > URL: https://issues.apache.org/jira/browse/CB-11705 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Affects Versions: Master >Reporter: Håkon Nilsen > Labels: easyfix > Original Estimate: 2h > Remaining Estimate: 2h > > The introduction of WKWebView from iOS9 separed the WebView-interface to > enable WKWebView and UIWebView. UIWebView is the default for all of Cordova > unless WKWebView is specified, and always default for iOS 8. > I think it is appropritate to be able to change the default UIWebView to > whatever you'd want (i.e. WKWebView for iOS8 as well, or a different > UIWebView plugin). > I will supply a pull request. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11705) [iOS-Cordova] Add configuration to override default WebViewEngine
[ https://issues.apache.org/jira/browse/CB-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429123#comment-15429123 ] ASF GitHub Bot commented on CB-11705: - Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/241 Tested locally (passes - Travis CI had a hiccup with the simulator, above) and did a code review, looks good to me. Can you create a new docs PR for the new setting? It should be in the same location as `CordovaWebViewEngine`: http://cordova.apache.org/docs/en/latest/config_ref/index.html The file location is: https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/index.md (just click on the Edit button at that GH location to create a PR) > [iOS-Cordova] Add configuration to override default WebViewEngine > - > > Key: CB-11705 > URL: https://issues.apache.org/jira/browse/CB-11705 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS >Affects Versions: Master >Reporter: Håkon Nilsen > Labels: easyfix > Original Estimate: 2h > Remaining Estimate: 2h > > The introduction of WKWebView from iOS9 separed the WebView-interface to > enable WKWebView and UIWebView. UIWebView is the default for all of Cordova > unless WKWebView is specified, and always default for iOS 8. > I think it is appropritate to be able to change the default UIWebView to > whatever you'd want (i.e. WKWebView for iOS8 as well, or a different > UIWebView plugin). > I will supply a pull request. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
[ https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429115#comment-15429115 ] Tony Homer commented on CB-10109: - I am out of the office with limited access to email through August 31. > Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open > --- > > Key: CB-10109 > URL: https://issues.apache.org/jira/browse/CB-10109 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > Labels: wkwebview-known-issues > > Because of CORS, you can only open requests using http*:// schemes, not file. > Ultimately this might be a new plugin. The plugin needs to: > 1. Run a local webserver > 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1) > The local webserver in (1) will route the requests using the appropriate > handler, and will need to utilize a secret to prevent unauthorized access. > Something like this: > https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
[ https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429112#comment-15429112 ] ASF GitHub Bot commented on CB-10109: - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Hi, Some issues I've encountered, pre-testing: 1. Can you prefix the issue with CB-10109 so it can be automatically tracked by the apache bots to https://issues.apache.org/jira/browse/CB-10109 2. All traces of "Ionic" have to be removed, in the docs or the code -- you'll have to rework the docs so that they are Cordova centric. All the contributors to this project (indeed any Apache project) are treated as if they are independent of any company and their contributions should reflect as such. Attribution is through the "Author" of the commit. 3. jshint errors that need to be resolved: ``` src/ios/xhr.js: line 55, col 8, Creating global 'for' variable. Should be 'for (var property ...'. src/ios/xhr.js: line 58, col 8, Creating global 'for' variable. Should be 'for (var property ...'. src/ios/xhr.js: line 55, col 8, 'property' is not defined. src/ios/xhr.js: line 56, col 20, 'property' is not defined. src/ios/xhr.js: line 58, col 8, 'property' is not defined. src/ios/xhr.js: line 59, col 9, 'property' is not defined. src/ios/xhr.js: line 59, col 64, 'property' is not defined. src/ios/xhr.js: line 60, col 16, 'property' is not defined. src/ios/xhr.js: line 60, col 40, 'property' is not defined. ``` 4. The contributor, in this case, @manucorporat, **must** file an [iCLA](https://www.apache.org/licenses/icla.txt) since this is a non-trivial contribution. This is required. I did not find one that was filed already. 5. The contributor's employer, in this case @driftyco, should file a [CCLA](https://www.apache.org/licenses/cla-corporate.txt). Note that this is **not** required, but see this [FAQ item](http://www.apache.org/legal/resolved.html#are-contributors-required-to-sign-a-ccla) on why its a good idea (particularly for the committer). I'll proceed with reviewing the actual functionality of the code next week, unless there are any blockers to issues 2, 4 and 5 that I have raised. > Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open > --- > > Key: CB-10109 > URL: https://issues.apache.org/jira/browse/CB-10109 > Project: Apache Cordova > Issue Type: Wish > Components: Plugin WKWebViewEngine >Reporter: Shazron Abdullah > Labels: wkwebview-known-issues > > Because of CORS, you can only open requests using http*:// schemes, not file. > Ultimately this might be a new plugin. The plugin needs to: > 1. Run a local webserver > 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1) > The local webserver in (1) will route the requests using the appropriate > handler, and will need to utilize a secret to prevent unauthorized access. > Something like this: > https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11728) allowsAirPlayForMediaPlayback in WKWebViewConfiguration is not sticky
Shazron Abdullah created CB-11728: - Summary: allowsAirPlayForMediaPlayback in WKWebViewConfiguration is not sticky Key: CB-11728 URL: https://issues.apache.org/jira/browse/CB-11728 Project: Apache Cordova Issue Type: Bug Components: Plugin WKWebViewEngine Reporter: Shazron Abdullah Assignee: Shazron Abdullah Looks like an Apple bug. See test: https://github.com/apache/cordova-plugin-wkwebview-engine/blob/42c847b2680a80e52ffd3617119ddd6634751453/tests/ios/CDVWKWebViewEngineTest/CDVWKWebViewEngineLibTests/CDVWKWebViewEngineTest.m#L189-L198 We still need to file a bug with Apple. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11727) travis ci setup is still using 0.10.32 node
[ https://issues.apache.org/jira/browse/CB-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11727. --- Resolution: Fixed > travis ci setup is still using 0.10.32 node > --- > > Key: CB-11727 > URL: https://issues.apache.org/jira/browse/CB-11727 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Because language is android in .travis.yml, node will default to 0.10.32 > Our travis.yml: > https://github.com/apache/cordova-android/blob/master/.travis.yml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11726) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11726. --- Resolution: Fixed > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11726 > URL: https://issues.apache.org/jira/browse/CB-11726 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11726) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428977#comment-15428977 ] ASF subversion and git services commented on CB-11726: -- Commit 0299467831c72a9be14e3ce1be1eb8b8c205fb09 in cordova-android's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=0299467 ] CB-11726 - Update appveyor node versions to 4 and 6, so they will always use the latest versions This closes #324 > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11726 > URL: https://issues.apache.org/jira/browse/CB-11726 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11727) travis ci setup is still using 0.10.32 node
[ https://issues.apache.org/jira/browse/CB-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428979#comment-15428979 ] ASF subversion and git services commented on CB-11727: -- Commit 8fbb6d7c62ec02194247910dc85dabc3293e60bb in cordova-android's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=8fbb6d7 ] CB-11727 - travis ci setup is still using 0.10.32 node This closes #325 > travis ci setup is still using 0.10.32 node > --- > > Key: CB-11727 > URL: https://issues.apache.org/jira/browse/CB-11727 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Because language is android in .travis.yml, node will default to 0.10.32 > Our travis.yml: > https://github.com/apache/cordova-android/blob/master/.travis.yml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11726) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428978#comment-15428978 ] ASF GitHub Bot commented on CB-11726: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/324 > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11726 > URL: https://issues.apache.org/jira/browse/CB-11726 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11727) travis ci setup is still using 0.10.32 node
[ https://issues.apache.org/jira/browse/CB-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428980#comment-15428980 ] ASF GitHub Bot commented on CB-11727: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/325 > travis ci setup is still using 0.10.32 node > --- > > Key: CB-11727 > URL: https://issues.apache.org/jira/browse/CB-11727 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Because language is android in .travis.yml, node will default to 0.10.32 > Our travis.yml: > https://github.com/apache/cordova-android/blob/master/.travis.yml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8401) Android permissions don't merge nicely when maxSdkVersion is set
[ https://issues.apache.org/jira/browse/CB-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428375#comment-15428375 ] Dustin Jones edited comment on CB-8401 at 8/19/16 5:28 PM: --- Also running into this issue. Is there any work being done on this? This issue probably originates here (and not related to plugman): https://github.com/apache/cordova-lib/blob/master/cordova-common/src/ConfigChanges/ConfigChanges.js was (Author: djones_pcty): Also running into this issue. Is there any work being done on this? > Android permissions don't merge nicely when maxSdkVersion is set > > > Key: CB-8401 > URL: https://issues.apache.org/jira/browse/CB-8401 > Project: Apache Cordova > Issue Type: Bug > Components: Plugman > Environment: Android >Reporter: Eddy Verbruggen > > If two plugins request the same permission they are nicely merged into one > line in AndroidManifest.xml. > However, if one of those two has 'android:maxSdkVersion="18"', both lines > show up in the resulting AndroidManifest.xml which is not allowed, so the > Android build fails. > As an example you can create a Cordova CLI project with the core File plugin > and SocialSharing (the latter has the maxSdkVersion set): > cordova create duplicatepermissiontest > cd duplicatepermissiontest > cordova platform add android > cordova plugin add org.apache.cordova.file > cordova plugin add nl.x-services.plugins.socialsharing > cordova prepare > The AndroidManifest.xml now has the duplicate permission. > I think what you'd want is the broader permission to 'win' this fight, so I'd > expect the manifest to contain only ' android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>'. > Note that I added the maxSdkVersion restriction because according to Google > SDK 19+ no longer requires the permission in my case and the permission tends > to scare off people using apps with this plugin installed. > I hope you will consider creating something clever to merge these duplicate > permissions. > This issue was first reported here: > https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/295 > Best, > Eddy -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8401) Android permissions don't merge nicely when maxSdkVersion is set
[ https://issues.apache.org/jira/browse/CB-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428375#comment-15428375 ] Dustin Jones commented on CB-8401: -- Also running into this issue. Is there any work being done on this? > Android permissions don't merge nicely when maxSdkVersion is set > > > Key: CB-8401 > URL: https://issues.apache.org/jira/browse/CB-8401 > Project: Apache Cordova > Issue Type: Bug > Components: Plugman > Environment: Android >Reporter: Eddy Verbruggen > > If two plugins request the same permission they are nicely merged into one > line in AndroidManifest.xml. > However, if one of those two has 'android:maxSdkVersion="18"', both lines > show up in the resulting AndroidManifest.xml which is not allowed, so the > Android build fails. > As an example you can create a Cordova CLI project with the core File plugin > and SocialSharing (the latter has the maxSdkVersion set): > cordova create duplicatepermissiontest > cd duplicatepermissiontest > cordova platform add android > cordova plugin add org.apache.cordova.file > cordova plugin add nl.x-services.plugins.socialsharing > cordova prepare > The AndroidManifest.xml now has the duplicate permission. > I think what you'd want is the broader permission to 'win' this fight, so I'd > expect the manifest to contain only ' android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>'. > Note that I added the maxSdkVersion restriction because according to Google > SDK 19+ no longer requires the permission in my case and the permission tends > to scare off people using apps with this plugin installed. > I hope you will consider creating something clever to merge these duplicate > permissions. > This issue was first reported here: > https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/295 > Best, > Eddy -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10973) inAppBrowser for Windows Platform: wrong height of webview with location=yes
[ https://issues.apache.org/jira/browse/CB-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428315#comment-15428315 ] ASF GitHub Bot commented on CB-10973: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/180 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/180/commits/a77b289f0132e71f635cf692d816c47d42efe972) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62//PLATFORM=android/artifact/) | > inAppBrowser for Windows Platform: wrong height of webview with location=yes > > > Key: CB-10973 > URL: https://issues.apache.org/jira/browse/CB-10973 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 6.0.0 > Environment: Windows Phone 10, cordova-windows@4.3.1, > cordova-plugin-inappbrowser@1.2.1 >Reporter: Roberto De Simone >Assignee: Sergey Shakhnazarov > Labels: Windows, triaged > Attachments: inAppBrowser-wrong-height.png > > > When setting location=yes, the height of the webview is by some pixels too > small. Please see attached screenshot with the green remarks. > ref = cordova.InAppBrowser.open(h, '_blank', 'location=yes fullscreen=yes'); -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10973) inAppBrowser for Windows Platform: wrong height of webview with location=yes
[ https://issues.apache.org/jira/browse/CB-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428284#comment-15428284 ] ASF GitHub Bot commented on CB-10973: - GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/180 CB-10973 inAppBrowser for Windows Platform: wrong height of webview w… …ith location=yes ### Platforms affected Windows ### What does this PR do? Removes a transparent gap between x-ms-webview and bottom appbar. ### What testing has been done on this change? Windows 8.1/10, Windows Phone 8.1/10, normal and fullscreen modes, portrait and landscape orientations. ### Checklist - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. [Jira issue](https://issues.apache.org/jira/browse/CB-10973) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/180.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #180 commit a77b289f0132e71f635cf692d816c47d42efe972 Author: daserge Date: 2016-08-19T14:43:48Z CB-10973 inAppBrowser for Windows Platform: wrong height of webview with location=yes > inAppBrowser for Windows Platform: wrong height of webview with location=yes > > > Key: CB-10973 > URL: https://issues.apache.org/jira/browse/CB-10973 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 6.0.0 > Environment: Windows Phone 10, cordova-windows@4.3.1, > cordova-plugin-inappbrowser@1.2.1 >Reporter: Roberto De Simone >Assignee: Sergey Shakhnazarov > Labels: Windows, triaged > Attachments: inAppBrowser-wrong-height.png > > > When setting location=yes, the height of the webview is by some pixels too > small. Please see attached screenshot with the green remarks. > ref = cordova.InAppBrowser.open(h, '_blank', 'location=yes fullscreen=yes'); -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-10973) inAppBrowser for Windows Platform: wrong height of webview with location=yes
[ https://issues.apache.org/jira/browse/CB-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shakhnazarov reassigned CB-10973: Assignee: Sergey Shakhnazarov (was: Sergey Grebnov) > inAppBrowser for Windows Platform: wrong height of webview with location=yes > > > Key: CB-10973 > URL: https://issues.apache.org/jira/browse/CB-10973 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 6.0.0 > Environment: Windows Phone 10, cordova-windows@4.3.1, > cordova-plugin-inappbrowser@1.2.1 >Reporter: Roberto De Simone >Assignee: Sergey Shakhnazarov > Labels: Windows, triaged > Attachments: inAppBrowser-wrong-height.png > > > When setting location=yes, the height of the webview is by some pixels too > small. Please see attached screenshot with the green remarks. > ref = cordova.InAppBrowser.open(h, '_blank', 'location=yes fullscreen=yes'); -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10998) File-Transfer doesn't start after ~5-10 cancelled downloads
[ https://issues.apache.org/jira/browse/CB-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-10998: -- Labels: cannot-reproduce triaged wfc (was: triaged) > File-Transfer doesn't start after ~5-10 cancelled downloads > --- > > Key: CB-10998 > URL: https://issues.apache.org/jira/browse/CB-10998 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer >Affects Versions: 1.5.0 > Environment: iOS 9 >Reporter: Noam Gal > Labels: cannot-reproduce, triaged, wfc > > I created a sample project, minimally modifying the HelloCordova project with > a Download file button. > The File Transfer plugin is trying to download a single file through https > (from my public dropbox folder. Any other file will do, as long as it is > behind https). > I added NSLog calls in the didReceiveResponse and in the > willSendRequestForAuthenticationChallange callbacks. > If I cancel the download after the didReceiveResponse starts (but before it > is finished), and then try to download again and again, at ~ the 10th attempt > the download just never starts (I used fiddler, and at that stage no request > is coming out). > When I tried it in a different host, it was consistently after the 6th > download attempt/cancel. > My sample project is located at > https://github.com/ATGardner/cordova-FileTransfer-test > just run "cordova prepare" (and maybe add the NSLog calls in the > CDVFileTransfer.m file) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10998) File-Transfer doesn't start after ~5-10 cancelled downloads
[
https://issues.apache.org/jira/browse/CB-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428239#comment-15428239
]
Vladimir Kotikov commented on CB-10998:
---
Hi, [~ATGardner]. I've tried to reproduce the problem w/ your code but it works
for me. Please clarify a bit some questions:
1. ??If I cancel the download after the didReceiveResponse starts (but before
it is finished)?? - how have you achieved that? Are you just setting a
breakpoint there and then cancel download from UI?
2. What happens when you calling {{download}} after 10th attempt? Does it
trigger any callbacks?
3. Does it trigger error callback when you cancelling last successful download?
4. Is the file available on device after you cancelled download?
Also it'd be great if you could check you simulator/device logs to see if
something is logged there.
> File-Transfer doesn't start after ~5-10 cancelled downloads
> ---
>
> Key: CB-10998
> URL: https://issues.apache.org/jira/browse/CB-10998
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.5.0
> Environment: iOS 9
>Reporter: Noam Gal
> Labels: triaged
>
> I created a sample project, minimally modifying the HelloCordova project with
> a Download file button.
> The File Transfer plugin is trying to download a single file through https
> (from my public dropbox folder. Any other file will do, as long as it is
> behind https).
> I added NSLog calls in the didReceiveResponse and in the
> willSendRequestForAuthenticationChallange callbacks.
> If I cancel the download after the didReceiveResponse starts (but before it
> is finished), and then try to download again and again, at ~ the 10th attempt
> the download just never starts (I used fiddler, and at that stage no request
> is coming out).
> When I tried it in a different host, it was consistently after the 6th
> download attempt/cancel.
> My sample project is located at
> https://github.com/ATGardner/cordova-FileTransfer-test
> just run "cordova prepare" (and maybe add the NSLog calls in the
> CDVFileTransfer.m file)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10998) File-Transfer doesn't start after ~5-10 cancelled downloads
[
https://issues.apache.org/jira/browse/CB-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428239#comment-15428239
]
Vladimir Kotikov edited comment on CB-10998 at 8/19/16 2:11 PM:
Hi, [~ATGardner]. I've tried to reproduce the problem w/ your code but it works
for me. Please clarify a bit some questions:
1. ??If I cancel the download after the didReceiveResponse starts (but before
it is finished)?? - how have you achieved that? Are you just setting a
breakpoint there and then cancelling download from UI?
2. What happens when you calling {{download}} after 10th attempt? Does it
trigger any callbacks?
3. Does it trigger error callback when you cancelling last successful download?
4. Is the file available on device after you cancelled download?
Also it'd be great if you could check you simulator/device logs to see if
something is logged there.
was (Author: vladimir.kotikov):
Hi, [~ATGardner]. I've tried to reproduce the problem w/ your code but it works
for me. Please clarify a bit some questions:
1. ??If I cancel the download after the didReceiveResponse starts (but before
it is finished)?? - how have you achieved that? Are you just setting a
breakpoint there and then cancel download from UI?
2. What happens when you calling {{download}} after 10th attempt? Does it
trigger any callbacks?
3. Does it trigger error callback when you cancelling last successful download?
4. Is the file available on device after you cancelled download?
Also it'd be great if you could check you simulator/device logs to see if
something is logged there.
> File-Transfer doesn't start after ~5-10 cancelled downloads
> ---
>
> Key: CB-10998
> URL: https://issues.apache.org/jira/browse/CB-10998
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.5.0
> Environment: iOS 9
>Reporter: Noam Gal
> Labels: triaged
>
> I created a sample project, minimally modifying the HelloCordova project with
> a Download file button.
> The File Transfer plugin is trying to download a single file through https
> (from my public dropbox folder. Any other file will do, as long as it is
> behind https).
> I added NSLog calls in the didReceiveResponse and in the
> willSendRequestForAuthenticationChallange callbacks.
> If I cancel the download after the didReceiveResponse starts (but before it
> is finished), and then try to download again and again, at ~ the 10th attempt
> the download just never starts (I used fiddler, and at that stage no request
> is coming out).
> When I tried it in a different host, it was consistently after the 6th
> download attempt/cancel.
> My sample project is located at
> https://github.com/ATGardner/cordova-FileTransfer-test
> just run "cordova prepare" (and maybe add the NSLog calls in the
> CDVFileTransfer.m file)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11692) Unable to load .png image from gallery
[
https://issues.apache.org/jira/browse/CB-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427991#comment-15427991
]
Mohammed Sadiq M C commented on CB-11692:
-
[~vladimir.kotikov] Please find below code snippet used in my application. As I
mentioned earlier, JPG images are getting attached but not PNG. Also I tried
there is no reason for error received in _image.onerror_.
{code}
$('#btnGallery').click(function () {
getPhoto(navigator.camera.PictureSourceType.SAVEDPHOTOALBUM);
});
function getPhoto(source) {
navigator.camera.getPicture(function (imageURI) {
addLoader();
onPhotoURISuccess(imageURI);
}, CameraFail, {
quality: 35,
destinationType: navigator.camera.DestinationType.FILE_URI,
saveToPhotoAlbum: false,
sourceType: source,
allowEdit: false,
targetWidth: 600,
targetHeight: 800
});
}
function onPhotoURISuccess(imageURI) {
// converts the image to a 2d canvas
canvasimage(imageURI);
}
function canvasimage(src) {
var canvas = document.createElement("canvas");
var ctx = canvas.getContext("2d");
var imgdata = new Image;
imgdata.onload = function () {
canvas.width = this.width;
canvas.height = this.height;
ctx.drawImage(this, 0, 0);
dataURL = canvas.toDataURL('image/jpeg');
var blob = dataURItoBlob(dataURL);
gotfilesystem(blob);
}
imgdata.onerror = function () {
alert('error');
}
imgdata.src = src;
}
function dataURItoBlob(dataURI) {
// convert base64/URLEncoded data component to raw binary data held in a
string
var byteString;
if (dataURI.split(',')[0].indexOf('base64') >= 0)
byteString = atob(dataURI.split(',')[1]);
else
byteString = unescape(dataURI.split(',')[1]);
// separate out the mime component
var mimeString = dataURI.split(',')[0].split(':')[1].split(';')[0];
// write the bytes of the string to a typed array
var ia = new Uint8Array(byteString.length);
for (var i = 0; i < byteString.length; i++) {
ia[i] = byteString.charCodeAt(i);
}
return new Blob([ia], { type: mimeString });
}
.
{code}
> Unable to load .png image from gallery
> --
>
> Key: CB-11692
> URL: https://issues.apache.org/jira/browse/CB-11692
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 1.2.0
> Environment: Cordova Version: 5.0.0
> Installed Platform: wp8
> Plugins:
> cordova-plugin-camera 1.2.0 "Camera"
> cordova-plugin-file 3.0.0 "File"
> cordova-plugin-file-transfer 1.4.0 "File Transfer"
> cordova-plugin-whitelist 1.2.0 "Whitelist"
> cordova.plugins.diagnostic 1.1.0 "Diagnostic"
>Reporter: Mohammed Sadiq M C
> Labels: wfc, wp8
>
> I am blocked with image selection from gallery. I cant able to load the .png
> image selected from gallery to the UI. Appreciating for the fix .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427932#comment-15427932
]
Vladimir Kotikov edited comment on CB-9936 at 8/19/16 10:00 AM:
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3 and
simulator w/ iOS 9.3 (cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png|width=800!
was (Author: vladimir.kotikov):
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png|width=800!
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.4.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: cannot-reproduce, triaged
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-9936:
-
Affects Version/s: (was: 1.3.0)
1.4.0
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.4.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: cannot-reproduce, triaged
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-9936:
-
Labels: cannot-reproduce triaged (was: connection event filetransfer
progress)
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.4.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: cannot-reproduce, triaged
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427932#comment-15427932
]
Vladimir Kotikov edited comment on CB-9936 at 8/19/16 9:58 AM:
---
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png|width=400!
was (Author: vladimir.kotikov):
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png|thumbnail!
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.3.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: connection, event, filetransfer, progress
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427932#comment-15427932
]
Vladimir Kotikov edited comment on CB-9936 at 8/19/16 9:59 AM:
---
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png|width=800!
was (Author: vladimir.kotikov):
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png|width=400!
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.3.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: connection, event, filetransfer, progress
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427932#comment-15427932
]
Vladimir Kotikov edited comment on CB-9936 at 8/19/16 9:58 AM:
---
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png|thumbnail!
was (Author: vladimir.kotikov):
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png!
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.3.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: connection, event, filetransfer, progress
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427932#comment-15427932
]
Vladimir Kotikov commented on CB-9936:
--
I wasn't able to reproduce w/ 1.3.0 version on iPhone 4s w/ iOS 8.3
(cordova-ios 4.2.0). Here is the repro code I used:
{noformat}
window.requestFileSystem(window.TEMPORARY,0, function(fs) {
var fileTransfer = new FileTransfer();
var uri = encodeURI("http://ovh.net/files/10Mio.dat";);
fs.root.getFile("test.dat", {create: true}, function(fileEntry) {
fileTransfer.onprogress = function(progressEvent) {
console.log("download percent");
console.log(progressEvent.loaded/progressEvent.total*100);
};
fileTransfer.download(uri, fileEntry.nativeURL,
function(entry) {
console.log("download complete: " + entry.toURL());
},
function(error) {
console.log(error);
}
);
});
});
{noformat}
and here is the output:
!screenshot.png!
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.3.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: connection, event, filetransfer, progress
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-9936:
-
Attachment: screenshot.png
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
>Affects Versions: 1.3.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: connection, event, filetransfer, progress
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11614) On iOS the Objectiv-C method 'shouldAutorotateToInterfaceOrientation' is never called during/after a device orientation
[
https://issues.apache.org/jira/browse/CB-11614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427878#comment-15427878
]
Ronny Schleicher commented on CB-11614:
---
Hello Cordova Team.
The Issue was created to four weeks.
Lack any information that I can provide?
> On iOS the Objectiv-C method 'shouldAutorotateToInterfaceOrientation' is
> never called during/after a device orientation
> ---
>
> Key: CB-11614
> URL: https://issues.apache.org/jira/browse/CB-11614
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 4.2.0
> Environment: * iMAC with OS X El Capitan Version 10.11.5
> * X-Code Version 7.3 (7D175)
> * iPhone 4S with iOS 9.3.3
> * Latest Version of Cordova 4.2.0
>Reporter: Ronny Schleicher
>Priority: Critical
>
> h3. Steps to reproduce
> h4. 1. Create a new fresh cordova app on your iMAC
> {code}
> cordova create PhoneGap_ios de.test.test Test
> cd PhoneGap_ios
> cordova platform add ios --save
> cordova plugin add cordova-plugin-device-motion
> cordova plugin add cordova-plugin-device-orientation
> cordova plugin add cordova-plugin-network-information
> cordova plugin add cordova-plugin-device
> cordova plugin add cordova-plugin-splashscreen
> cordova plugin add cordova-plugin-console
> cordova plugin add cordova-plugin-statusbar
> cordova plugin ls
> {code}
> h4. 2. Open the x-code project an enable in the project all orientations
> Targets -> Test -> General -> Deployment Info -> Device Orientation -> check
> all orientations
> h4. 3. Set a breakpoint in follow method
> {code:title=MainViewController.m|borderStyle=solid}
> -
> (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation
> {
> // Return YES for supported orientations
> return [super
> shouldAutorotateToInterfaceOrientation:interfaceOrientation];
> }
> {code}
> h4. 5. Now connect your iPhone and run the Test App
> With a change in orientation of the device, the method is never called.
> Is this correct? I believe this is an error.
> The method should be invoked in any change of orientation.
> h3. Notes and a Workaround
> In an earlier version of Cordova (3.9.2???) the *shouldAutorotate* method was
> used at this point. This old method I have installed in my app as workaround
> again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11708) Android version name still 1.0
[ https://issues.apache.org/jira/browse/CB-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427765#comment-15427765 ] asapsystems commented on CB-11708: -- sure, http://phonegap.com/ns/1.0"; xmlns:cdv="http://cordova.apache.org/ns/1.0"; xmlns:vs="http://schemas.microsoft.com/appx/2014/htmlapps"; id="com.xxx.x" versionCode = "445" version="4.4.5" xmlns="http://www.w3.org/ns/widgets"; defaultlocale="en-US"> x http://*/*"; /> https://*/*"; /> mailto:*"; /> http://api.phonegap.com/1.0/device"; /> https://github.com/apache/cordova-plugin-whitelist.git"; /> > Android version name still 1.0 > -- > > Key: CB-11708 > URL: https://issues.apache.org/jira/browse/CB-11708 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 6.1.0 >Reporter: asapsystems > > Android version name still show "1.0" when i release to the google play > store , > even if i change it in the config -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11727) travis ci setup is still using 0.10.32 node
[ https://issues.apache.org/jira/browse/CB-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427762#comment-15427762 ] ASF GitHub Bot commented on CB-11727: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/325 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/325?src=pr) is 33.78% (diff: 100%) > Merging [#325](https://codecov.io/gh/apache/cordova-android/pull/325?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage ```diff @@ master #325 diff @@ == Files11 11 Lines 965965 Methods 197197 Messages 0 0 Branches157157 == Hits326326 Misses 639639 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [2efe240...375d7e1](https://codecov.io/gh/apache/cordova-android/compare/2efe2406175a9913022dd0113947984856d6d58a...375d7e1900eca20ee756de73ad5811ef5f627686?src=pr) > travis ci setup is still using 0.10.32 node > --- > > Key: CB-11727 > URL: https://issues.apache.org/jira/browse/CB-11727 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Because language is android in .travis.yml, node will default to 0.10.32 > Our travis.yml: > https://github.com/apache/cordova-android/blob/master/.travis.yml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11727) travis ci setup is still using 0.10.32 node
[ https://issues.apache.org/jira/browse/CB-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427745#comment-15427745 ] ASF GitHub Bot commented on CB-11727: - GitHub user shazron opened a pull request: https://github.com/apache/cordova-android/pull/325 CB-11727 - travis ci setup is still using 0.10.32 node You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-android CB-11727 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/325.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #325 commit df018e1667ea7976ef53c614578af308f285e5c2 Author: Shazron Abdullah Date: 2016-08-19T07:18:11Z CB-11727 - travis ci setup is still using 0.10.32 node > travis ci setup is still using 0.10.32 node > --- > > Key: CB-11727 > URL: https://issues.apache.org/jira/browse/CB-11727 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Because language is android in .travis.yml, node will default to 0.10.32 > Our travis.yml: > https://github.com/apache/cordova-android/blob/master/.travis.yml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11727) travis ci setup is still using 0.10.32 node
Shazron Abdullah created CB-11727: - Summary: travis ci setup is still using 0.10.32 node Key: CB-11727 URL: https://issues.apache.org/jira/browse/CB-11727 Project: Apache Cordova Issue Type: Bug Components: iOS Reporter: Shazron Abdullah Assignee: Shazron Abdullah Config: https://travis-ci.org/apache/cordova-ios/jobs/151965364/config Our travis.yml: https://github.com/apache/cordova-ios/blob/master/.travis.yml It's defaulting to 0.10.x probably because it can't read the config or something. Not sure. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11727) travis ci setup is still using 0.10.32 node
[ https://issues.apache.org/jira/browse/CB-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11727: -- Component/s: (was: iOS) Android > travis ci setup is still using 0.10.32 node > --- > > Key: CB-11727 > URL: https://issues.apache.org/jira/browse/CB-11727 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Because language is android in .travis.yml, node will default to 0.10.32 > Our travis.yml: > https://github.com/apache/cordova-android/blob/master/.travis.yml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11727) travis ci setup is still using 0.10.32 node
[ https://issues.apache.org/jira/browse/CB-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11727: -- Description: Because language is android in .travis.yml, node will default to 0.10.32 Our travis.yml: https://github.com/apache/cordova-android/blob/master/.travis.yml was: Config: https://travis-ci.org/apache/cordova-ios/jobs/151965364/config Our travis.yml: https://github.com/apache/cordova-ios/blob/master/.travis.yml It's defaulting to 0.10.x probably because it can't read the config or something. Not sure. > travis ci setup is still using 0.10.32 node > --- > > Key: CB-11727 > URL: https://issues.apache.org/jira/browse/CB-11727 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Because language is android in .travis.yml, node will default to 0.10.32 > Our travis.yml: > https://github.com/apache/cordova-android/blob/master/.travis.yml -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11726) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427734#comment-15427734 ] ASF GitHub Bot commented on CB-11726: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/324 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/324?src=pr) is 33.78% (diff: 100%) > Merging [#324](https://codecov.io/gh/apache/cordova-android/pull/324?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage ```diff @@ master #324 diff @@ == Files11 11 Lines 965965 Methods 197197 Messages 0 0 Branches157157 == Hits326326 Misses 639639 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [2efe240...dab3a37](https://codecov.io/gh/apache/cordova-android/compare/2efe2406175a9913022dd0113947984856d6d58a...dab3a3773771e4076c3785112024b0c803062dc6?src=pr) > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11726 > URL: https://issues.apache.org/jira/browse/CB-11726 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11726) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427720#comment-15427720 ] ASF GitHub Bot commented on CB-11726: - GitHub user shazron opened a pull request: https://github.com/apache/cordova-android/pull/324 CB-11726 - Update appveyor node versions to 4 and 6, so they will always use the latest versions You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-android CB-11726 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/324.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #324 commit dab3a3773771e4076c3785112024b0c803062dc6 Author: Shazron Abdullah Date: 2016-08-19T07:06:05Z CB-11726 - Update appveyor node versions to 4 and 6, so they will always use the latest versions > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11726 > URL: https://issues.apache.org/jira/browse/CB-11726 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7497) Crash on open app from fresh
[ https://issues.apache.org/jira/browse/CB-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427715#comment-15427715 ] ASF GitHub Bot commented on CB-7497: Github user gabn88 commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/106 For me, the catch is called. But also the splashscreen is blinking, which it was not before. ST: 15 times the following messages (and 15 blinks): 2016-08-19 09:00:05.341 MyApp[6590:3826998] Finished load of: file:///var/containers/Bundle/Application/87EF668F-793D-4E20-97C3-B0EC4ED5222D/MyApp.app/www/index.html#/tab/overview 2016-08-19 09:00:05.497 EquineM[6590:3826998] frame observer was not attached 2016-08-19 09:00:05.497 EquineM[6590:3826998] bounds observer was not attached 2016-08-19 09:00:05.502 EquineM[6590:3826998] Resetting plugins due to page load. > Crash on open app from fresh > > > Key: CB-7497 > URL: https://issues.apache.org/jira/browse/CB-7497 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen > Environment: ios7 iphone 4s >Reporter: Miquel >Assignee: jcesarmobile >Priority: Critical > Original Estimate: 2m > Remaining Estimate: 2m > > Everytime the app is fresh opened (not in the debugger) > : *** Terminating app due to uncaught exception 'NSRangeException', > reason: 'Cannot remove an observer for the key > path "frame" from because it is not registered as an > observer.' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11725) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-11725. --- Resolution: Fixed > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11725 > URL: https://issues.apache.org/jira/browse/CB-11725 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11726) Update appveyor node versions to 4 and 6, so they will always use the latest versions
Shazron Abdullah created CB-11726: - Summary: Update appveyor node versions to 4 and 6, so they will always use the latest versions Key: CB-11726 URL: https://issues.apache.org/jira/browse/CB-11726 Project: Apache Cordova Issue Type: Bug Components: iOS Reporter: Shazron Abdullah Assignee: Shazron Abdullah Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11726) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11726: -- Component/s: (was: iOS) Android > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11726 > URL: https://issues.apache.org/jira/browse/CB-11726 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11721) Android InAppBrowser Previous, Next page history buttons do not change with the state of the content
[ https://issues.apache.org/jira/browse/CB-11721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-11721: -- Labels: android triaged (was: android) > Android InAppBrowser Previous, Next page history buttons do not change with > the state of the content > > > Key: CB-11721 > URL: https://issues.apache.org/jira/browse/CB-11721 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: Master > Environment: Android OS 6.0.1, Cordova CLI 6.3.1, cordova-android > 5.2.1, cordova-plugin-inappbrowser 1.4.0 >Reporter: Arjun Thounaojam > Labels: android, triaged > Attachments: InAppBrowserAndroidCurrentHistoryButtons.png, > InAppBrowserAndroidImprovedHistoryButtons.png > > > Steps to reproduce: > 1) Create a simple Cordova Android app with the InAppBrowser plugin pointing > to a website. E.g. https://news.google.com > 2) Navigate back and forth between different pages > 3) Observe the history buttons on the toolbar > Expected behavior: > The Previous / Next arrow buttons should become highlighted or faded based on > where in the page history the content is. > This behavior is standard on most browsers. The iOS InAppBrowser implements > it too. > Observed behavior: > The Previous / Next buttons remain highlighted regardless of if it's possible > to navigate back or forward in the content. > This was never implemented for Android so wasn't sure if Issue Type should be > a Bug or Improvement. Left it at default. > I have a potential implementation. Will fork repo and trigger a pull request > soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11725) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427706#comment-15427706 ] ASF GitHub Bot commented on CB-11725: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/243 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/243?src=pr) is 53.50% (diff: 100%) > Merging [#243](https://codecov.io/gh/apache/cordova-ios/pull/243?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage ```diff @@ master #243 diff @@ == Files12 12 Lines 1028 1028 Methods 145145 Messages 0 0 Branches169169 == Hits550550 Misses 478478 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [a06f419...d52a687](https://codecov.io/gh/apache/cordova-ios/compare/a06f41918c16cb266cb3106a826c7efd8cc8667e...d52a6876c4761f0d27743f62d423a6ad30d3d75a?src=pr) > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11725 > URL: https://issues.apache.org/jira/browse/CB-11725 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11725) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427709#comment-15427709 ] ASF GitHub Bot commented on CB-11725: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/243 > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11725 > URL: https://issues.apache.org/jira/browse/CB-11725 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11725) Update appveyor node versions to 4 and 6, so they will always use the latest versions
[ https://issues.apache.org/jira/browse/CB-11725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427708#comment-15427708 ] ASF subversion and git services commented on CB-11725: -- Commit d52a6876c4761f0d27743f62d423a6ad30d3d75a in cordova-ios's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=d52a687 ] CB-11725 - Update appveyor node versions to 4 and 6, so they will always use the latest versions > Update appveyor node versions to 4 and 6, so they will always use the latest > versions > - > > Key: CB-11725 > URL: https://issues.apache.org/jira/browse/CB-11725 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now they use 4.2 and 6.0 specifically -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
