[jira] [Commented] (CB-5195) Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating
[ https://issues.apache.org/jira/browse/CB-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441992#comment-15441992 ] ASF GitHub Bot commented on CB-5195: Github user swbradshaw commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @stevengill - I think this is good to go. My first PR/rebase, hopefully didn't messed it up! -Rebased from master -Verified rotation is working correctly after merge conflict resolved -Tested fed987 / CB-11447 to make sure it works w/merge conflict resolved -A side-effect of getting rotation/scaling working, is this PR allows the user to choose picture from any Document Provider now (including Google Drive), provided the appropriate calling options are set (scale || rotate || base64 output). > Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating > > > Key: CB-5195 > URL: https://issues.apache.org/jira/browse/CB-5195 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Camera >Affects Versions: 2.6.0 > Environment: Galaxy S4 >Reporter: Andre Asselin > Labels: Android, reproduced, triaged > > Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture > from the library. If you specify both the correctOrientation and > targetWidth/Height options (which currently you must do if you want > correctOrientation to work because of bug CB-5194), the code scales the image > first before rotating it, so the final dimensions are incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5195) Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating
[ https://issues.apache.org/jira/browse/CB-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442031#comment-15442031 ] ASF GitHub Bot commented on CB-5195: Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/197/commits/0ed6406864ff5a166fbc7fe226193e40c8528eec) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/74//PLATFORM=android/artifact/) | > Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating > > > Key: CB-5195 > URL: https://issues.apache.org/jira/browse/CB-5195 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Camera >Affects Versions: 2.6.0 > Environment: Galaxy S4 >Reporter: Andre Asselin > Labels: Android, reproduced, triaged > > Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture > from the library. If you specify both the correctOrientation and > targetWidth/Height options (which currently you must do if you want > correctOrientation to work because of bug CB-5194), the code scales the image > first before rotating it, so the final dimensions are incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9762) App icon and Launch image for iPad Pro
[ https://issues.apache.org/jira/browse/CB-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442273#comment-15442273 ] Kerri Shotts commented on CB-9762: -- I've got a branch that supports the launch storyboard here: https://github.com/kerrishotts/cordova-ios/tree/CB-9762 It follows nearly the same logic as set forth in my second PoC, but also supports the iPad and iPhone idioms as [~jonathanli] suggested. The logic wasn't any more difficult; just an additional loop. A few additional notes: * If there are no matching splash images, the project is configured so that no launch storyboard is used. This allows for fallback to the existing launch images. (Note: if the user has already configured their own storyboard, this won't reset it.) * If there are matching splash images, the project is configured to use our launch storyboard unless a storyboard is already configured. * No default images are provided; they would get overwritten on the first prepare (regardless of any splashes in config.xml) > App icon and Launch image for iPad Pro > -- > > Key: CB-9762 > URL: https://issues.apache.org/jira/browse/CB-9762 > Project: Apache Cordova > Issue Type: Task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS >Affects Versions: 4.0.0 >Reporter: Manuel Martiarena >Assignee: Kerri Shotts > Labels: cordova-ios-4.1.1 > Attachments: Default-Landscape@2x~ipad-pro.png, > Default-Portrait@2x~ipad-pro.png > > > Provide app icon image and launch image for iPad Pro > iPad Pro (@2x) App icon required 167x167 > iPad Pro (@2x) Launch image required 2048 x 2732 (portrait) > 2732 x 2048 (landscape) > https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9762) App icon and Launch image for iPad Pro
[ https://issues.apache.org/jira/browse/CB-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442280#comment-15442280 ] Kerri Shotts commented on CB-9762: -- Jonathan -- thanks for your suggestion. Using a single image was in fact my original intent, but I've found since that it tends to be a little limiting (especially with regard to viewports that are very narrow). With the addition of ipad/iphone idiom support, the dev has a lot more control over what the launch image looks like. Going from universal idioms to adding ipad/iphone only needed an additional loop, but converting a plugin PoC to the core platform did require some reworking of the logic. See my other comment regarding a test branch; see what you think. I'd appreciate your input! > App icon and Launch image for iPad Pro > -- > > Key: CB-9762 > URL: https://issues.apache.org/jira/browse/CB-9762 > Project: Apache Cordova > Issue Type: Task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS >Affects Versions: 4.0.0 >Reporter: Manuel Martiarena >Assignee: Kerri Shotts > Labels: cordova-ios-4.1.1 > Attachments: Default-Landscape@2x~ipad-pro.png, > Default-Portrait@2x~ipad-pro.png > > > Provide app icon image and launch image for iPad Pro > iPad Pro (@2x) App icon required 167x167 > iPad Pro (@2x) Launch image required 2048 x 2732 (portrait) > 2732 x 2048 (landscape) > https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-9762) App icon and Launch image for iPad Pro
[ https://issues.apache.org/jira/browse/CB-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442280#comment-15442280 ] Kerri Shotts edited comment on CB-9762 at 8/27/16 9:54 PM: --- Jonathan -- thanks for your suggestion. Using a single image was in fact my original intent, but I've found since that it tends to be a little limiting (especially with regard to viewports that are very narrow). With the addition of ipad/iphone idiom support, the dev has a lot more control over what the launch image looks like. Going from universal idioms to adding ipad/iphone only needed an additional loop, but converting a plugin PoC to the core platform did require some reworking of the logic. See my other comment regarding a test branch; see what you think. I'd appreciate your input! Added: Note that you should still be able to use a single image approach using the branch should you desire. iOS will pick the most appropriate image automatically based upon the device's and viewport's characteristics. was (Author: kerrishotts): Jonathan -- thanks for your suggestion. Using a single image was in fact my original intent, but I've found since that it tends to be a little limiting (especially with regard to viewports that are very narrow). With the addition of ipad/iphone idiom support, the dev has a lot more control over what the launch image looks like. Going from universal idioms to adding ipad/iphone only needed an additional loop, but converting a plugin PoC to the core platform did require some reworking of the logic. See my other comment regarding a test branch; see what you think. I'd appreciate your input! > App icon and Launch image for iPad Pro > -- > > Key: CB-9762 > URL: https://issues.apache.org/jira/browse/CB-9762 > Project: Apache Cordova > Issue Type: Task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS >Affects Versions: 4.0.0 >Reporter: Manuel Martiarena >Assignee: Kerri Shotts > Labels: cordova-ios-4.1.1 > Attachments: Default-Landscape@2x~ipad-pro.png, > Default-Portrait@2x~ipad-pro.png > > > Provide app icon image and launch image for iPad Pro > iPad Pro (@2x) App icon required 167x167 > iPad Pro (@2x) Launch image required 2048 x 2732 (portrait) > 2732 x 2048 (landscape) > https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
