[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445005#comment-15445005 ] Håkon Nilsen commented on CB-7179: -- I has now been a year and a half since this was closed, and I must ask that this needs to be reopened. When using WKWebView engine in Cordova, the InAppBrowser, based on UIWebView, cannot share the session. This means that the InAppBrowser cannot be used for anything that requires a session, as the InAppBrowser is practically an "incognito" window. Right now I am forced to continue using UIWebView as my only browser, because the InAppBrowser is UIWebView. What I suggest is making an additional plugin for an InAppBrowser that uses UIWebView if the main webview is based on UIWebView, and uses WKWebView if the main webview is based on WKWebView. That way you can share the session in the InAppBrowser regardless of which engine you use. Cordova with UIWebView using InAppBrowser with UIWebView --> works Cordova with WKWebView using InAppBrowser with UIWebView --> doesn't work > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin InAppBrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5195) Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating
[ https://issues.apache.org/jira/browse/CB-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444817#comment-15444817 ] ASF GitHub Bot commented on CB-5195: Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/197/commits/e77ffa6bc704a9b18d41ffeea18bbaf91d02e34c) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/75//PLATFORM=android/artifact/) | > Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating > > > Key: CB-5195 > URL: https://issues.apache.org/jira/browse/CB-5195 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Camera >Affects Versions: 2.6.0 > Environment: Galaxy S4 >Reporter: Andre Asselin > Labels: Android, reproduced, triaged > > Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture > from the library. If you specify both the correctOrientation and > targetWidth/Height options (which currently you must do if you want > correctOrientation to work because of bug CB-5194), the code scales the image > first before rotating it, so the final dimensions are incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5195) Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating
[ https://issues.apache.org/jira/browse/CB-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444758#comment-15444758 ] ASF GitHub Bot commented on CB-5195: Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @swbradshaw don't worry about it! We all make mistakes like that. Really appreciate the PR! I'll test and merge it in tomorrow. Thanks! > Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating > > > Key: CB-5195 > URL: https://issues.apache.org/jira/browse/CB-5195 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Camera >Affects Versions: 2.6.0 > Environment: Galaxy S4 >Reporter: Andre Asselin > Labels: Android, reproduced, triaged > > Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture > from the library. If you specify both the correctOrientation and > targetWidth/Height options (which currently you must do if you want > correctOrientation to work because of bug CB-5194), the code scales the image > first before rotating it, so the final dimensions are incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5195) Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating
[ https://issues.apache.org/jira/browse/CB-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444753#comment-15444753 ] ASF GitHub Bot commented on CB-5195: Github user swbradshaw commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @stevengill Man, I'm such an amateur. Removed. > Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating > > > Key: CB-5195 > URL: https://issues.apache.org/jira/browse/CB-5195 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Camera >Affects Versions: 2.6.0 > Environment: Galaxy S4 >Reporter: Andre Asselin > Labels: Android, reproduced, triaged > > Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture > from the library. If you specify both the correctOrientation and > targetWidth/Height options (which currently you must do if you want > correctOrientation to work because of bug CB-5194), the code scales the image > first before rotating it, so the final dimensions are incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5195) Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating
[ https://issues.apache.org/jira/browse/CB-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444746#comment-15444746 ] ASF GitHub Bot commented on CB-5195: Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @swbradshaw looks you included a new file named `CameraLauncherMaster.java` in your commit by mistake > Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating > > > Key: CB-5195 > URL: https://issues.apache.org/jira/browse/CB-5195 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Camera >Affects Versions: 2.6.0 > Environment: Galaxy S4 >Reporter: Andre Asselin > Labels: Android, reproduced, triaged > > Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture > from the library. If you specify both the correctOrientation and > targetWidth/Height options (which currently you must do if you want > correctOrientation to work because of bug CB-5194), the code scales the image > first before rotating it, so the final dimensions are incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9762) App icon and Launch image for iPad Pro
[ https://issues.apache.org/jira/browse/CB-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444642#comment-15444642 ] Jonathan Li commented on CB-9762: - Hi That makes sense. I assume when launch storyboard is used, there is no need to ask developers to provide copies of the same image with different resolution (1x, 2x, 3x), as only the highest resolution of the same image is needed. The launch storyboard can scale the image properly based on device's resolutions when starting the app. Thanks Jonathan > App icon and Launch image for iPad Pro > -- > > Key: CB-9762 > URL: https://issues.apache.org/jira/browse/CB-9762 > Project: Apache Cordova > Issue Type: Task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS >Affects Versions: 4.0.0 >Reporter: Manuel Martiarena >Assignee: Kerri Shotts > Labels: cordova-ios-4.1.1 > Attachments: Default-Landscape@2x~ipad-pro.png, > Default-Portrait@2x~ipad-pro.png > > > Provide app icon image and launch image for iPad Pro > iPad Pro (@2x) App icon required 167x167 > iPad Pro (@2x) Launch image required 2048 x 2732 (portrait) > 2732 x 2048 (landscape) > https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9027) FileTransfer#download fails with FileTransferError.CONNECTION_ERR after 60 sec. on iOS
[ https://issues.apache.org/jira/browse/CB-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444364#comment-15444364 ] Ryan Williams commented on CB-9027: --- iOS timeout appears to be 60 seconds. (iOS prior to 5 or 6 was 240 seconds) Android appears to use 60 seconds. Windows appears to use 120 seconds. I'm also encountering this timeout when uploading using HTTPS over AT&T LTE as they appear to have some sort of TCP buffering or Proxy server in place. I'm planning to submit a PR to expose the timeout as an option. > FileTransfer#download fails with FileTransferError.CONNECTION_ERR after 60 > sec. on iOS > -- > > Key: CB-9027 > URL: https://issues.apache.org/jira/browse/CB-9027 > Project: Apache Cordova > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin File Transfer >Affects Versions: 3.4.0 > Environment: iPhone 4s, iOS 8.3 > iPhone 5s, iOS 8.3 > Cordova 3.4.1 > FileTransfer 0.4.2 >Reporter: Alexander Kilinskiy > > (x) when I try to download large file on iOS I receive > FileTransferError.CONNECTION_ERR in 60 seconds (file generation tooks ~ 70-90 > sec). > Standard code used: > {code:javascript}var fileTransfer = new window.FileTransfer(), > fileUrl = "", // some valid url (big file ~ 100Mb) > filePath = ""; // some valid location > fileTransfer.download(fileUrl, > filePath, > function(entry) { > // process file > }, > function(error) { > // process error > });{code} > Could i set custom timeout instead of 60 sec? > P.S. android devices wait till file is generated (70-90 sec) > Thanks in advance. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11248) InAppBrowser no focus on input text fields
[ https://issues.apache.org/jira/browse/CB-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444236#comment-15444236 ] Chris Zagar commented on CB-11248: -- I was having a problem quite like the one described. The first time I opened an InAppBrowser, the text fields would always work. But if I closed and then reopened, eventually (1 to several times later) the text input fields would not show a caret and I could not type anything, even though the keyboard appeared, suggestions would work and I could copy and paste. It was driving my quite mad. I finally noticed that if I had the location bar enabled and touched it, then touched a text edit, I would get the caret. This led me to try many different things with changes in establishing focus. Right or wrong, the combination I found that finally gave me consistent behavior was to change onPageFinished to add calls to clear and request focus like this: {code} public void onPageFinished(WebView view, String url) { super.onPageFinished(view, url); view.clearFocus(); view.requestFocus(); {code} Once I made this change, touching the text fields always produced a caret. > InAppBrowser no focus on input text fields > -- > > Key: CB-11248 > URL: https://issues.apache.org/jira/browse/CB-11248 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin InAppBrowser >Affects Versions: 1.4.0 > Environment: Cordova CLI, Android, Android Studio >Reporter: Mo Pages >Priority: Minor > Labels: android, no-repro, triaged > > When opening a webpage with a form in the Cordova default webview or system > webview focus on an input text box works as normal - a cursor is displayed > (and if there's any js list its displayed). However when using the > InAppBrowser the focus cursor does not display at all when you click in a > text box...the keyboard comes up but no focus cursor. > I've tried injecting js to focus on the text box but this doesn't do > anything..Also it makes no difference what value the option > keyboardDisplayRequiresUserAction is given...Is there a fix for this? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10288) statusbar plugin interaction with iOS multitasking
[ https://issues.apache.org/jira/browse/CB-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444211#comment-15444211 ] ASF GitHub Bot commented on CB-10288: - Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, Thanks for the PR, but the id you used isn't right. This doesn't add the multitask support, it fixes the resize problems when using multitask. There is another issue for that CB-10288. Can you change the id? > statusbar plugin interaction with iOS multitasking > -- > > Key: CB-10288 > URL: https://issues.apache.org/jira/browse/CB-10288 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Statusbar > Environment: cordova ios 4.0.0 >Reporter: Nick Redding >Assignee: jcesarmobile > Labels: ios, triaged > > In pluginInitialize the statement > [[NSNotificationCenter defaultCenter] addObserver:self > selector:@selector(statusBarDidChangeFrame:) name: > UIApplicationDidChangeStatusBarFrameNotification object:nil]; > causes incorrect rendering behavior when using iOS multitasking split window. > When pulling the cordova app onto the screen from the right, the window > resizing is not handled correctly (much larger widths thsn actual are > reported and reflected in the rendering). > Commenting out this statement eliminates the problem, but it is not clear > what the potentially unwanted effects of this would be. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11782) Dangerous incompatibilities with browser platform
[ https://issues.apache.org/jira/browse/CB-11782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Christopher Henry updated CB-11782: - Description: The browser platform, reflecting the limitations of {{window.confirm()}} and {{window.prompt()}}, doesn't allow customization of the button labels. That's fine. However, it blithely triggers the callback with hardcoded button values of {{1}} for OK and {{2}} for Cancel. That's dangerous, because the developer may have assigned different labels for those buttons. For example, if the developer reverses the order of the Cancel and OK buttons (and therefore interprets the button index differently in the callback), the browser platform version will end up calling the OK callback when the user presses Cancel, which could lead to data loss and other serious problems. One solution would be to document the limitations of the browser platform, and then fail fast (i.e. refuse to show the dialog) if the caller tries to pass custom button labels. was: The browser platform, reflecting the limitations of {{window.confirm()}} and {{window.prompt()}}, doesn't allow customization of the button labels. That's fine. However, it blithely triggers the callback with hardcoded button values of {{1}} for OK and {{2}} for Cancel. That's dangerous, because the developer may have assigned different labels for those buttons. For example, if the developer reverses the order of the Cancel and OK buttons (and therefore interprets the button index differently in the callback), the browser platform version will end up calling the OK callback when the user presses Cancel, which could lead to data loss and other serious problems. One solution would be to document the limitations of the browser platform, and and then fail fast (i.e. refuse to show the dialog) if the caller tries to pass custom button labels. > Dangerous incompatibilities with browser platform > - > > Key: CB-11782 > URL: https://issues.apache.org/jira/browse/CB-11782 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Dialogs >Reporter: Kevin Christopher Henry > > The browser platform, reflecting the limitations of {{window.confirm()}} and > {{window.prompt()}}, doesn't allow customization of the button labels. That's > fine. > However, it blithely triggers the callback with hardcoded button values of > {{1}} for OK and {{2}} for Cancel. That's dangerous, because the developer > may have assigned different labels for those buttons. > For example, if the developer reverses the order of the Cancel and OK buttons > (and therefore interprets the button index differently in the callback), the > browser platform version will end up calling the OK callback when the user > presses Cancel, which could lead to data loss and other serious problems. > One solution would be to document the limitations of the browser platform, > and then fail fast (i.e. refuse to show the dialog) if the caller tries to > pass custom button labels. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11782) Dangerous incompatibilities with browser platform
Kevin Christopher Henry created CB-11782: Summary: Dangerous incompatibilities with browser platform Key: CB-11782 URL: https://issues.apache.org/jira/browse/CB-11782 Project: Apache Cordova Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: Plugin Dialogs Reporter: Kevin Christopher Henry The browser platform, reflecting the limitations of {{window.confirm()}} and {{window.prompt()}}, doesn't allow customization of the button labels. That's fine. However, it blithely triggers the callback with hardcoded button values of {{1}} for OK and {{2}} for Cancel. That's dangerous, because the developer may have assigned different labels for those buttons. For example, if the developer reverses the order of the Cancel and OK buttons (and therefore interprets the button index differently in the callback), the browser platform version will end up calling the OK callback when the user presses Cancel, which could lead to data loss and other serious problems. One solution would be to document the limitations of the browser platform, and and then fail fast (i.e. refuse to show the dialog) if the caller tries to pass custom button labels. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9161) Support iPad multitasking in iOS 9
[ https://issues.apache.org/jira/browse/CB-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444059#comment-15444059 ] Jonathan Li commented on CB-9161: - Testing on this issue shows the ipad pro webview multitask resizing issue is caused by statusbar plugin. The ios statusbar plugin currently uses the device screen bounds as the application's UI bounds, which will set the webview frame to the device screen bound by mistake when ipad pro is in splitview or slideview state. After replacing the device screen bounds with the UIWindow bound, then the resizing works in ipad pro splitview and slideview as expected. A pull request has been submitted for reference at https://github.com/apache/cordova-plugin-statusbar/pull/62 (only tested in the cordova project I am working on) There maybe similar code in other plugins that still uses device screen bound as the application bounds, and they will also need to be updated to make ipad pro multitask slideview and splitview work. Actually, I wonder it is better to avoid explicitly setting the UIWebView's frame at all, and instead just defining the related constraints when creating the webview, and then let the ios auto layout to handle the webview resizing after statusbar or navigationbar state is changed by application's code. > Support iPad multitasking in iOS 9 > -- > > Key: CB-9161 > URL: https://issues.apache.org/jira/browse/CB-9161 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS >Affects Versions: 4.0.0 > Environment: iOS 9 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Labels: cordova-ios-5.0.x > Attachments: screenshot-1.png > > > This is to support SlideOver and SplitView. Note that SplitView is only > supported on iPad Air 2. > The three rules are: > 1. Build your apps with the iOS 9 SDK > 2. Support all orientations > 3. Use Launch Storyboards > We have 1 and 2 covered, but not 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
[ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444036#comment-15444036 ] ASF GitHub Bot commented on CB-3232: GitHub user jonathanli2 opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/62 CB:-9161 Support iPad multitasking in iOS 9. (statusbar plugin side fix) ### Platforms affected ios ### What does this PR do? With the ipad pro multitask slideview and splitview function, ios application cannot assume it can always use the full screen as its UI, instead the ios may only allow part of the screen to be used for the application's view. So when checking the bounds of UI view, it should get it from UIWindow's bounds instead of the device screen's bound ### What testing has been done on this change? Manual testing on ios devices ### Checklist - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jonathanli2/cordova-plugin-statusbar master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 8070c69e91c2e317baf3b970350f3c950ffcbfa3 Author: Jonathan Li Date: 2016-08-28T20:01:54Z CB:-9161 Support iPad multitasking in iOS 9. (statusbar plugin side fix) > "cordova platform add blackberry" fails on 2.7.1-rc.1 > - > > Key: CB-3232 > URL: https://issues.apache.org/jira/browse/CB-3232 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: BlackBerry, CLI >Affects Versions: 2.7.0 >Reporter: Michael Brooks >Assignee: Michael Brooks > Fix For: 2.7.0 > > > The following error is thrown when running {{$ cordova platform add > blackberry}}: > {code} > [Error: An error occured during creation of blackberry sub-project. Creating > BlackBerry project... > Updating config.xml ... > sed: > /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml: > No such file or directory > Cleaning up ... > Remember to update the project.properties file inside your application > directory! > ] > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth
[ https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444031#comment-15444031 ] ASF GitHub Bot commented on CB-11136: - Github user dotNetkow commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 hi @shazron - any way your team could consider this? OAuth is a major reason folks use InAppBrowser, and for years now it's been feasible and "supported" in a sense with UIWebView. One alternative is to use the "toolbar=yes" option, which shows a "done" link that will close the browser. Developer's would have to have a self hosted page that tells the user to tap the link, like "Successfully connected! Please tap Done to continue". Not the best usability but possible: `inAppBrowserRef = window.open("www.google.com", '_blank', 'toolbar=yes');` However, I once had Apple reject my app with this option in place - they didn't like that it obviously loading "something" outside of my app. So that's probably out :( Thanks for considering. The performance gains from WKWebView are immense, so I'd hate to miss out on using it! > InAppBrowser fails to close with WKWebView OAuth > - > > Key: CB-11136 > URL: https://issues.apache.org/jira/browse/CB-11136 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin InAppBrowser, Plugin WKWebViewEngine >Affects Versions: 4.1.0 > Environment: iOS 8+ with WKWebView >Reporter: Geordie Jay >Assignee: Shazron Abdullah > Original Estimate: 3h > Remaining Estimate: 3h > > Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for > OAuth (e.g. Facebook or Google login) fails to close as it should. > The reason is that the entire WKWebView thread seems to pause when another > view controller is presented. This can be confirmed by inspecting the > WKWebView session in Safari, running `window.open('http://something.com')` > and then trying to enter another command into that Safari console. > I made a hacky but working version of this that animated in the > InAppBrowser's view manually, rather than 'presenting' the ViewController in > the traditional iOS style. In that instance the WKWebView thread continues as > normal and receives the confirmation to close the other InAppBrowser when the > OAuth process is complete. > Maybe there is a better way around this, but at the moment this is a big > usability fail for all WKWebView users. > What do you all think, is the 'not-actually-presenting' way of presenting the > InAppBrowser acceptable? Would be happy to make a pull request along these > lines if it is. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11781) camera, device-orientation and media-capture plugins supposedly crash an app on winstore 8.1
Alexander Sorokin created CB-11781: -- Summary: camera, device-orientation and media-capture plugins supposedly crash an app on winstore 8.1 Key: CB-11781 URL: https://issues.apache.org/jira/browse/CB-11781 Project: Apache Cordova Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: Plugin Camera, Plugin Device Orientation, Plugin Media Capture Reporter: Alexander Sorokin Assignee: Alexander Sorokin http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/124/ http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/124/PLATFORM=windows-8.1-store,PLUGIN=cordova-plugin-camera/console {noformat} [EnvInject] - Inject global passwords. [EnvInject] - Mask passwords passed as build parameters. Started by upstream project "cordova-periodic-build" build number 124 originally caused by: Started by timer [EnvInject] - Loading node environment variables. Building remotely on windows-slave (windows-8.1-phone windows-10-store android-4.4 android-5.1 windows-8.1-store) in workspace E:\jenkins\workspace\cordova-periodic-build > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url > https://github.com/apache/cordova-plugin-console.git # timeout=10 Fetching upstream changes from https://github.com/apache/cordova-plugin-console.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress > https://github.com/apache/cordova-plugin-console.git > +refs/heads/*:refs/remotes/origin/* Checking out Revision 336554cd3d049706392f66678ebf139a2cbd42f9 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 336554cd3d049706392f66678ebf139a2cbd42f9 > git rev-list 336554cd3d049706392f66678ebf139a2cbd42f9 # timeout=10 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url > https://github.com/apache/cordova-plugin-device.git # timeout=10 Fetching upstream changes from https://github.com/apache/cordova-plugin-device.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress > https://github.com/apache/cordova-plugin-device.git > +refs/heads/*:refs/remotes/origin/* Checking out Revision 5298c1f524877602e65e7f71b522b7c95e7a6c8e (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 5298c1f524877602e65e7f71b522b7c95e7a6c8e > git rev-list 5298c1f524877602e65e7f71b522b7c95e7a6c8e # timeout=10 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url > https://github.com/apache/cordova-plugin-media-capture.git # timeout=10 Fetching upstream changes from https://github.com/apache/cordova-plugin-media-capture.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress > https://github.com/apache/cordova-plugin-media-capture.git > +refs/heads/*:refs/remotes/origin/* Checking out Revision f108e236df1644dfd9d076d861d4f9578653325c (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f f108e236df1644dfd9d076d861d4f9578653325c > git rev-list f108e236df1644dfd9d076d861d4f9578653325c # timeout=10 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url > https://github.com/apache/cordova-plugin-camera.git # timeout=10 Fetching upstream changes from https://github.com/apache/cordova-plugin-camera.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress > https://github.com/apache/cordova-plugin-camera.git > +refs/heads/*:refs/remotes/origin/* Checking out Revision c98607c613602a0ae2d0f1004af27732227244ee (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f c98607c613602a0ae2d0f1004af27732227244ee > git rev-list 1beeafb6e8b2296d7748d545128686bf8296bbb7 # timeout=10 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url > https://github.com/apache/cordova-plugin-network-information.git # timeout=10 Fetching upstream changes from https://github.com/apache/cordova-plugin-network-information.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress > https://github.com/apache/cordova-plugin-network-information.git > +refs/heads/*:refs/remotes/origin/* Checking out Revision 379b35debb79d0515eebcdb2ac5702a32aebdf02 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 379b35debb79d0515eebcdb2ac5702a32aebdf02 > git rev-list 379b35debb79d0515eebcdb2ac5702a32aebdf02 # timeout=10 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git reposito
[jira] [Commented] (CB-11673) camera.ui.spec.12.28 base64 image did not load
[ https://issues.apache.org/jira/browse/CB-11673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444019#comment-15444019 ] Alexander Sorokin commented on CB-11673: Happened again http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build/124/PLATFORM=ios,PLUGIN=cordova-plugin-camera/console > camera.ui.spec.12.28 base64 image did not load > -- > > Key: CB-11673 > URL: https://issues.apache.org/jira/browse/CB-11673 > Project: Apache Cordova > Issue Type: Test > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Camera >Reporter: Sergey Shakhnazarov > Labels: flaky, found-by-ci, ios, triaged > > {noformat} > ✗ camera.ui.spec.12.28 Combining options. sourceType: PHOTOLIBRARY, > destinationType: FILE_URI, encodingType: JPEG, allowEdit: false, > correctOrientation: false > - Failed: ERROR: The image did not load: > data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAASABIAAD/4QBMRXhpZgAATU0AKggAAgESAAMBAAEAAIdpAAQBJgAAAqACAAQBAAAQwKADAAQBAAALIAA > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11779) Cordova plugin media is not working on Samsung Galaxy S5
[ https://issues.apache.org/jira/browse/CB-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayyaz Zafar closed CB-11779. Resolution: Not A Bug > Cordova plugin media is not working on Samsung Galaxy S5 > - > > Key: CB-11779 > URL: https://issues.apache.org/jira/browse/CB-11779 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Media Capture >Affects Versions: 3.5.0 > Environment: I am using Samsung Galaxy S5 with android version 6.0.1 >Reporter: Ayyaz Zafar >Priority: Critical > Labels: cordova-plugin-media-capture > > When I record and press ok it returns me to the app but it throws following > error with no output response: > Uncaught (in promise) Attempt to invoke virtual method 'boolean > android.graphics.Bitmap.compress(android.graphics.Bitmap$CompressFormat, int, > java.io.OutputStream)' on a null object reference > I even tried on basic hello world apps provided by cordova but issue is still > same. > It works fine on other devices but not on Samsung galaxy S5 ( android 6.0.1). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11757) media.stop() should call error callback when called in MEDIA_STARTING state
[ https://issues.apache.org/jira/browse/CB-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443581#comment-15443581 ] ASF GitHub Bot commented on CB-11757: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/113 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/113/commits/13bcd820d6baa4877b5821e1ed384f70d73794d9) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/artifact/) | > media.stop() should call error callback when called in MEDIA_STARTING state > --- > > Key: CB-11757 > URL: https://issues.apache.org/jira/browse/CB-11757 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS, Plugin Media >Affects Versions: Master >Reporter: Alexander Sorokin >Assignee: Alexander Sorokin > Labels: triaged > > On iOS, when calling media.stop() when media is in state MEDIA_STARTING (for > example, the player is caching media file), we don't get any callback. And > then, when the caching is completed, the media actually starts playing. > The proposed fix is that when media.stop() is called in an invalid state, the > plugin should send an error callback with the code MEDIA_ERR_NONE_ACTIVE > Another approach would be to stop the playback as soon as the player finishes > caching. One possible advantage of this over the proposed fix would be that > MEDIA_ERR_NONE_ACTIVE is not in w3c spec: > https://dev.w3.org/html5/spec-author-view/video.html#error-codes -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11779) Cordova plugin media is not working on Samsung Galaxy S5
[ https://issues.apache.org/jira/browse/CB-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayyaz Zafar updated CB-11779: - Labels: cordova-plugin-media-capture (was: ) > Cordova plugin media is not working on Samsung Galaxy S5 > - > > Key: CB-11779 > URL: https://issues.apache.org/jira/browse/CB-11779 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Media Capture >Affects Versions: 3.5.0 > Environment: I am using Samsung Galaxy S5 with android version 6.0.1 >Reporter: Ayyaz Zafar >Priority: Critical > Labels: cordova-plugin-media-capture > > When I record and press ok it returns me to the app but it throws following > error with no output response: > Uncaught (in promise) Attempt to invoke virtual method 'boolean > android.graphics.Bitmap.compress(android.graphics.Bitmap$CompressFormat, int, > java.io.OutputStream)' on a null object reference > I even tried on basic hello world apps provided by cordova but issue is still > same. > It works fine on other devices but not on Samsung galaxy S5 ( android 6.0.1). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11779) Cordova plugin media is not working on Samsung Galaxy S5
[ https://issues.apache.org/jira/browse/CB-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayyaz Zafar updated CB-11779: - Component/s: Plugin Media Capture > Cordova plugin media is not working on Samsung Galaxy S5 > - > > Key: CB-11779 > URL: https://issues.apache.org/jira/browse/CB-11779 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Media Capture >Affects Versions: 3.5.0 > Environment: I am using Samsung Galaxy S5 with android version 6.0.1 >Reporter: Ayyaz Zafar >Priority: Critical > Labels: cordova-plugin-media-capture > > When I record and press ok it returns me to the app but it throws following > error with no output response: > Uncaught (in promise) Attempt to invoke virtual method 'boolean > android.graphics.Bitmap.compress(android.graphics.Bitmap$CompressFormat, int, > java.io.OutputStream)' on a null object reference > I even tried on basic hello world apps provided by cordova but issue is still > same. > It works fine on other devices but not on Samsung galaxy S5 ( android 6.0.1). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11779) Cordova plugin media is not working on Samsung Galaxy S5
Ayyaz Zafar created CB-11779: Summary: Cordova plugin media is not working on Samsung Galaxy S5 Key: CB-11779 URL: https://issues.apache.org/jira/browse/CB-11779 Project: Apache Cordova Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Affects Versions: 3.5.0 Environment: I am using Samsung Galaxy S5 with android version 6.0.1 Reporter: Ayyaz Zafar Priority: Critical When I record and press ok it returns me to the app but it throws following error with no output response: Uncaught (in promise) Attempt to invoke virtual method 'boolean android.graphics.Bitmap.compress(android.graphics.Bitmap$CompressFormat, int, java.io.OutputStream)' on a null object reference I even tried on basic hello world apps provided by cordova but issue is still same. It works fine on other devices but not on Samsung galaxy S5 ( android 6.0.1). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11778) ios nightly is missing packages in node_modules that are in the repo
[ https://issues.apache.org/jira/browse/CB-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443124#comment-15443124 ] Shazron Abdullah commented on CB-11778: --- The only sane choice is to use the `npm pack` or `npm publish` version that comes with node 6.x > ios nightly is missing packages in node_modules that are in the repo > > > Key: CB-11778 > URL: https://issues.apache.org/jira/browse/CB-11778 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Coho > Environment: iOS, node 0.10.25 in CI >Reporter: Shazron Abdullah > > Try to do a platform add: > {code} > cordova platform add ios@4.3.0-nightly.2016.8.25.582e3577 > {code} > Error: > {code} > Warning: using prerelease version 6.4.0-nightly.2016.8.25.4935f1a5 > (cordova-lib@6.4.0-nightly.2016.8.25.3b38b538) > Warning: using prerelease platform ios@4.3.0-nightly.2016.8.25.582e3577. > Use 'cordova platform add ios@latest' to add the latest published version > instead. > Adding ios project... > Running command: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create > /Users/shaz/Desktop/s/platforms/ios s s --cli > module.js:457 > throw err; > ^ > Error: Cannot find module 'elementtree' > at Function.Module._resolveFilename (module.js:455:15) > at Function.Module._load (module.js:403:25) > at Module.require (module.js:483:17) > at require (internal/module.js:20:19) > at Object. > (/Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:22:10) > at Module._compile (module.js:556:32) > at Object.Module._extensions..js (module.js:565:10) > at Module.load (module.js:473:32) > at tryModuleLoad (module.js:432:12) > at Function.Module._load (module.js:424:3) > Error: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create: > Command failed with exit code 1 > {code} > If I go into: > {code} > ~/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules > {code} > the package "elementtree" is missing (a lot of others are as well). The > package elementtree does exist in the repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11778) ios nightly is missing packages in node_modules that are in the repo
[ https://issues.apache.org/jira/browse/CB-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443121#comment-15443121 ] Shazron Abdullah commented on CB-11778: --- You will need all the items in the flattened node_modules directory to be listed in the bundledDependencies tag. This is quite tedious since a lot of these modules are subdependencies, really. This can create a sync problem > ios nightly is missing packages in node_modules that are in the repo > > > Key: CB-11778 > URL: https://issues.apache.org/jira/browse/CB-11778 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Coho > Environment: iOS, node 0.10.25 in CI >Reporter: Shazron Abdullah > > Try to do a platform add: > {code} > cordova platform add ios@4.3.0-nightly.2016.8.25.582e3577 > {code} > Error: > {code} > Warning: using prerelease version 6.4.0-nightly.2016.8.25.4935f1a5 > (cordova-lib@6.4.0-nightly.2016.8.25.3b38b538) > Warning: using prerelease platform ios@4.3.0-nightly.2016.8.25.582e3577. > Use 'cordova platform add ios@latest' to add the latest published version > instead. > Adding ios project... > Running command: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create > /Users/shaz/Desktop/s/platforms/ios s s --cli > module.js:457 > throw err; > ^ > Error: Cannot find module 'elementtree' > at Function.Module._resolveFilename (module.js:455:15) > at Function.Module._load (module.js:403:25) > at Module.require (module.js:483:17) > at require (internal/module.js:20:19) > at Object. > (/Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:22:10) > at Module._compile (module.js:556:32) > at Object.Module._extensions..js (module.js:565:10) > at Module.load (module.js:473:32) > at tryModuleLoad (module.js:432:12) > at Function.Module._load (module.js:424:3) > Error: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create: > Command failed with exit code 1 > {code} > If I go into: > {code} > ~/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules > {code} > the package "elementtree" is missing (a lot of others are as well). The > package elementtree does exist in the repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Issue Comment Deleted] (CB-11477) Add a note about nightly builds to Cordova website
[ https://issues.apache.org/jira/browse/CB-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11477: -- Comment: was deleted (was: Actually: this is probably a problem in someone using a require to load a module in the flattened node_modules structure, which really should be in the bundledDependencies key in package.json instead.) > Add a note about nightly builds to Cordova website > -- > > Key: CB-11477 > URL: https://issues.apache.org/jira/browse/CB-11477 > Project: Apache Cordova > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Website >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: docs, nightly > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11477) Add a note about nightly builds to Cordova website
[ https://issues.apache.org/jira/browse/CB-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443109#comment-15443109 ] Shazron Abdullah commented on CB-11477: --- Actually: this is probably a problem in someone using a require to load a module in the flattened node_modules structure, which really should be in the bundledDependencies key in package.json instead. > Add a note about nightly builds to Cordova website > -- > > Key: CB-11477 > URL: https://issues.apache.org/jira/browse/CB-11477 > Project: Apache Cordova > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Website >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: docs, nightly > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11778) ios nightly is missing packages in node_modules that are in the repo
[ https://issues.apache.org/jira/browse/CB-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443105#comment-15443105 ] Shazron Abdullah commented on CB-11778: --- I think I know what's going on -- what we have in node_modules (bundledDependencies) is actually correct, it is the npm@3 behaviour where it flattens dependencies. In this case, ConfigParser is relying on the `elementtree' package which was flattened in node_modules. Since it is needed, it really should be a bundledDependencies item in package.json. > ios nightly is missing packages in node_modules that are in the repo > > > Key: CB-11778 > URL: https://issues.apache.org/jira/browse/CB-11778 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Coho > Environment: iOS, node 0.10.25 in CI >Reporter: Shazron Abdullah > > Try to do a platform add: > {code} > cordova platform add ios@4.3.0-nightly.2016.8.25.582e3577 > {code} > Error: > {code} > Warning: using prerelease version 6.4.0-nightly.2016.8.25.4935f1a5 > (cordova-lib@6.4.0-nightly.2016.8.25.3b38b538) > Warning: using prerelease platform ios@4.3.0-nightly.2016.8.25.582e3577. > Use 'cordova platform add ios@latest' to add the latest published version > instead. > Adding ios project... > Running command: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create > /Users/shaz/Desktop/s/platforms/ios s s --cli > module.js:457 > throw err; > ^ > Error: Cannot find module 'elementtree' > at Function.Module._resolveFilename (module.js:455:15) > at Function.Module._load (module.js:403:25) > at Module.require (module.js:483:17) > at require (internal/module.js:20:19) > at Object. > (/Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:22:10) > at Module._compile (module.js:556:32) > at Object.Module._extensions..js (module.js:565:10) > at Module.load (module.js:473:32) > at tryModuleLoad (module.js:432:12) > at Function.Module._load (module.js:424:3) > Error: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create: > Command failed with exit code 1 > {code} > If I go into: > {code} > ~/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules > {code} > the package "elementtree" is missing (a lot of others are as well). The > package elementtree does exist in the repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11778) ios nightly is missing packages in node_modules that are in the repo
[ https://issues.apache.org/jira/browse/CB-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11778: -- Environment: iOS, node 0.10.25 in CI Component/s: (was: iOS) Coho > ios nightly is missing packages in node_modules that are in the repo > > > Key: CB-11778 > URL: https://issues.apache.org/jira/browse/CB-11778 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Coho > Environment: iOS, node 0.10.25 in CI >Reporter: Shazron Abdullah > > Try to do a platform add: > {code} > cordova platform add ios@4.3.0-nightly.2016.8.25.582e3577 > {code} > Error: > {code} > Warning: using prerelease version 6.4.0-nightly.2016.8.25.4935f1a5 > (cordova-lib@6.4.0-nightly.2016.8.25.3b38b538) > Warning: using prerelease platform ios@4.3.0-nightly.2016.8.25.582e3577. > Use 'cordova platform add ios@latest' to add the latest published version > instead. > Adding ios project... > Running command: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create > /Users/shaz/Desktop/s/platforms/ios s s --cli > module.js:457 > throw err; > ^ > Error: Cannot find module 'elementtree' > at Function.Module._resolveFilename (module.js:455:15) > at Function.Module._load (module.js:403:25) > at Module.require (module.js:483:17) > at require (internal/module.js:20:19) > at Object. > (/Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:22:10) > at Module._compile (module.js:556:32) > at Object.Module._extensions..js (module.js:565:10) > at Module.load (module.js:473:32) > at tryModuleLoad (module.js:432:12) > at Function.Module._load (module.js:424:3) > Error: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create: > Command failed with exit code 1 > {code} > If I go into: > {code} > ~/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules > {code} > the package "elementtree" is missing (a lot of others are as well). The > package elementtree does exist in the repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11477) Add a note about nightly builds to Cordova website
[ https://issues.apache.org/jira/browse/CB-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443083#comment-15443083 ] Shazron Abdullah commented on CB-11477: --- node 0.10, 0.12, 4.x does not pack the bundled dependencies correctly. Using 6.x fixes this problem -- see my findings in CB-11778. > Add a note about nightly builds to Cordova website > -- > > Key: CB-11477 > URL: https://issues.apache.org/jira/browse/CB-11477 > Project: Apache Cordova > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Website >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: docs, nightly > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11778) ios nightly is missing packages in node_modules that are in the repo
[ https://issues.apache.org/jira/browse/CB-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443081#comment-15443081 ] Shazron Abdullah commented on CB-11778: --- The nightly build CI uses node 0.10.25, where `npm pack` displays this behaviour. Using nvm, I tried 0.10.46 (latest 0.10 release) and 0.12.15 (latest 0.12 release) and 4.5.0 (latest 4.x release), the npm bundled with those node versions exhibited this issue. The fix is by using node 6.4.0 (the latest 6.x release), where using `npm pack` it used the proper behaviour. The CI build should use `nvm` and change to a 6.x version before using `npm pack`, or just use the latest 6.x node. > ios nightly is missing packages in node_modules that are in the repo > > > Key: CB-11778 > URL: https://issues.apache.org/jira/browse/CB-11778 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: iOS >Reporter: Shazron Abdullah > > Try to do a platform add: > {code} > cordova platform add ios@4.3.0-nightly.2016.8.25.582e3577 > {code} > Error: > {code} > Warning: using prerelease version 6.4.0-nightly.2016.8.25.4935f1a5 > (cordova-lib@6.4.0-nightly.2016.8.25.3b38b538) > Warning: using prerelease platform ios@4.3.0-nightly.2016.8.25.582e3577. > Use 'cordova platform add ios@latest' to add the latest published version > instead. > Adding ios project... > Running command: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create > /Users/shaz/Desktop/s/platforms/ios s s --cli > module.js:457 > throw err; > ^ > Error: Cannot find module 'elementtree' > at Function.Module._resolveFilename (module.js:455:15) > at Function.Module._load (module.js:403:25) > at Module.require (module.js:483:17) > at require (internal/module.js:20:19) > at Object. > (/Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:22:10) > at Module._compile (module.js:556:32) > at Object.Module._extensions..js (module.js:565:10) > at Module.load (module.js:473:32) > at tryModuleLoad (module.js:432:12) > at Function.Module._load (module.js:424:3) > Error: > /Users/shaz/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/bin/create: > Command failed with exit code 1 > {code} > If I go into: > {code} > ~/.cordova/lib/npm_cache/cordova-ios/4.3.0-nightly.2016.8.25.582e3577/package/node_modules > {code} > the package "elementtree" is missing (a lot of others are as well). The > package elementtree does exist in the repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org