[jira] [Commented] (CB-12169) We should check to see if a clean is necessary before doing a clean and adding plugins.
[ https://issues.apache.org/jira/browse/CB-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684989#comment-15684989 ] ASF GitHub Bot commented on CB-12169: - GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/349 CB-12169: Check for build directory before running a clean ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android CB-12169 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #349 commit 5017e2302b90f8555bb105dc5a90b0483b384280 Author: Joe BowserDate: 2016-11-21T22:41:14Z CB-12169: Check for build directory before running a clean > We should check to see if a clean is necessary before doing a clean and > adding plugins. > --- > > Key: CB-12169 > URL: https://issues.apache.org/jira/browse/CB-12169 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Joe Bowser > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12163) plugin.xml 'resource-file' does not copy file to target for Windows
[ https://issues.apache.org/jira/browse/CB-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684982#comment-15684982 ] Karen Tran commented on CB-12163: - I think there will need to be some sort of compromise to this issue. This little snippet was found in PluginHandler.js and it contradicts with what I am proposing. I wouldn't be able to simply check that a target path exists. {code} // do not copy, but reference the file in the plugin folder. This allows to // have multiple source files map to the same target and select the appropriate // one based on the current build settings, e.g. architecture. // also, we don't check for existence. This allows to insert build variables // into the source file name, e.g. // {code} One way or another, the solution would end up having a Windows quirk and should be properly documented, which it isn't now. A couple things we need to decide on: 1. What should be the default behavior of tag? Should it simply be copy resources as it was originally intended to, or should it be doing what it is now, which is making a reference to the resource files. 2. Should tag handle both functionalities, or should one be separated out into another tag? > plugin.xml 'resource-file' does not copy file to target for Windows > --- > > Key: CB-12163 > URL: https://issues.apache.org/jira/browse/CB-12163 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: Master > Environment: Windows 8/Windows10 >Reporter: Karen Tran > Labels: Windows > > From plugin.xml: > {noformat} target="myprops.properties"/>{noformat} > does not copy the file from src to target anymore. It used > to, but was changed. This creates a couple of issues since I expect it to be > in the application, but it technically isn't. This means that I cannot update > the file that doesn't exist and very much limits the functionality of > (Also the documentation is wrong for Windows since it doesn't > copy any files). Visual Studio also only shows the file from the src path. > This doesn't make much sense since that file wouldn't be in the application. > The expected behavior should be if the target is specified, > should copy the file to the target location. In turn, Visual Studio should > show the target file instead of the src file because the target is part of > the application whereas the src file is not. > This used to be expected behavior, but was changed as a result of CB-10326. > The intention of that issue is limited to use cases of only having the src > attribute, ignoring the possibility that we would want to update files in the > target instead (which imo makes more sense). Resource files are not all .dll > files, so it's not very user friendly to limit the tag to > handling just those kinds of files. > Proposed changes in JsprojManager.js and PluginHandler.js: > If target attribute is specified, copy the file to the target and point the > Include attribute to the path of the target. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12169) We should check to see if a clean is necessary before doing a clean and adding plugins.
[ https://issues.apache.org/jira/browse/CB-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-12169: Component/s: Android > We should check to see if a clean is necessary before doing a clean and > adding plugins. > --- > > Key: CB-12169 > URL: https://issues.apache.org/jira/browse/CB-12169 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Joe Bowser > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12169) We should check to see if a clean is necessary before doing a clean and adding plugins.
Joe Bowser created CB-12169: --- Summary: We should check to see if a clean is necessary before doing a clean and adding plugins. Key: CB-12169 URL: https://issues.apache.org/jira/browse/CB-12169 Project: Apache Cordova Issue Type: Bug Reporter: Joe Bowser -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12019) cordova-plugin-file : Performance issue between version 3.0.0 and 4.3.0
[ https://issues.apache.org/jira/browse/CB-12019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-12019: Labels: Android performance (was: performance) Component/s: (was: Android) > cordova-plugin-file : Performance issue between version 3.0.0 and 4.3.0 > --- > > Key: CB-12019 > URL: https://issues.apache.org/jira/browse/CB-12019 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.5.0 > Environment: Tests done with Visual Studio 2015, cordova cli 6.3 > Materiel : Samsung A5 2016, Android 6.0.1 >Reporter: Sebastien Chauffray >Priority: Minor > Labels: Android, performance > > Performance tests to compare cordova-plugin-file 3.0.0 to 4.3.0 > I've done 3 tests : > Test 1 : Create 1 000 files (about 4 000 characters each) in synchronous > mode. I wait the end of a file to create the next > Test 2 : Create 500 files (about 4 000 characters each) in asynchronous mode. > Don't wait to create all the file > Test 3 : Create a file by 400 appends of 4 000 caractères and read this file > (about 1.60 Mo) > I mesure each test and see very bad performance for version 4.3.0 of the > plugin... > You can see the result in the array : > Version 3.0.0 > Cycle 1Cycle 2 > Test 121s 975ms 22s 78ms > Test 24s 118ms 3s 761ms > Test 310s 317ms > Version 4.3.0 > Cycle 1Cycle 2 > Test 150s 341ms 51s 10ms > Test 28s 172ms 9s 230ms > Test 316s 484ms > if needed, i can discuss about the test detail -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12155) Create automated tests for launch storyboard feature
[ https://issues.apache.org/jira/browse/CB-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684669#comment-15684669 ] ASF GitHub Bot commented on CB-12155: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/280 > Create automated tests for launch storyboard feature > > > Key: CB-12155 > URL: https://issues.apache.org/jira/browse/CB-12155 > Project: Apache Cordova > Issue Type: Test > Components: iOS >Affects Versions: 4.3.1 >Reporter: Kerri Shotts >Assignee: Kerri Shotts > Labels: cordova-ios, cordova-ios-4.3.x > > This issue is to track development of automated testing for the launch > storyboard feature introduced with CB-9762. Right now all testing is manual, > but most of the functionality could be verified with automated tests leaving > only a few manual tests remaining. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12155) Create automated tests for launch storyboard feature
[ https://issues.apache.org/jira/browse/CB-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684668#comment-15684668 ] ASF subversion and git services commented on CB-12155: -- Commit 4b86462452ffe69b33a54561e0d12583057592a8 in cordova-ios's branch refs/heads/master from [~kerrishotts] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=4b86462 ] CB-12155: Create tests for launch storyboards This closes #280 > Create automated tests for launch storyboard feature > > > Key: CB-12155 > URL: https://issues.apache.org/jira/browse/CB-12155 > Project: Apache Cordova > Issue Type: Test > Components: iOS >Affects Versions: 4.3.1 >Reporter: Kerri Shotts >Assignee: Kerri Shotts > Labels: cordova-ios, cordova-ios-4.3.x > > This issue is to track development of automated testing for the launch > storyboard feature introduced with CB-9762. Right now all testing is manual, > but most of the functionality could be verified with automated tests leaving > only a few manual tests remaining. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12146) cordova-plugin-media - Adds support for "playAudioWhenScreenIsLocked" already used in iOS
[ https://issues.apache.org/jira/browse/CB-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684634#comment-15684634 ] ASF GitHub Bot commented on CB-12146: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/121/commits/f140897fcc29996579991f49f580cdb0a7f3f853) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/86//PLATFORM=android/artifact/) | > cordova-plugin-media - Adds support for "playAudioWhenScreenIsLocked" already > used in iOS > - > > Key: CB-12146 > URL: https://issues.apache.org/jira/browse/CB-12146 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Media >Affects Versions: Master > Environment: Apache Cordova media plugin on Android >Reporter: Romedius Weiss >Priority: Minor > Labels: newbie, patch > Fix For: Master > > Original Estimate: 0h > Remaining Estimate: 0h > > This patch adds the support of the playAudioWhenScreenIsLocked flag on > Android, listed as quirk for iOS. > https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/#ios-quirks > A previous version of the fix was published here: > https://github.com/apache/cordova-plugin-media/pull/54 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12117) Cordova-ios iphone 5 splashscreen stoped working between cordova-ios 4.1.1 - 4.2.0 (cordova default splashscreen is loaded)
[ https://issues.apache.org/jira/browse/CB-12117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684197#comment-15684197 ] David Azevedo commented on CB-12117: Hi Sergrey, Sorry for the delay to respond. I made tests and found a clear way to reproduce. Ios simulator is not needed to reproduce the issue. The issue is with the image: Default-568h@2x~iphone.png and only cordova-ios@4.2.0 and above. What happens is that in our config.xml que put our app customized splashscreen like bellow Cordova-ios iphone 5 splashscreen stoped working between cordova-ios 4.1.1 - > 4.2.0 (cordova default splashscreen is loaded) > --- > > Key: CB-12117 > URL: https://issues.apache.org/jira/browse/CB-12117 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Affects Versions: 6.0.0 > Environment: Cordova >= 6.0.0 >Reporter: David Azevedo > Labels: ios, no-repro, triaged, wfc > > Sorry if i created the issue on the wrong tracker, could not find a cordova > ios tracker > I was using cordova ios 4.2.0 and had this problem, when i downgrade to 4.1.0 > the problem was gone. I didnt had time to test if 4.1.1 also solves the > problem. Please fix as soon as possible so we can catch up the latests > cordova ios versions -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12168) NSLog behavior changed in iOS10
Mathias Latournerie created CB-12168: Summary: NSLog behavior changed in iOS10 Key: CB-12168 URL: https://issues.apache.org/jira/browse/CB-12168 Project: Apache Cordova Issue Type: Bug Components: Plugin Console Reporter: Mathias Latournerie Hello, Since iOS10, NSLog changed in two ways : - It now truncates its output to 1024 characters - It isn't logged anymore for deployed apps iOS10 introduced a new logger : os_log This plugin should reflect on this change and use os_log when available. Currently, you can't read console.log on iOS10 if you do not run your project directly from xcode in debug mode. See this link for more informations : http://stackoverflow.com/a/40451002 Regards. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12085) FileReader#readAsArrayBuffer reads whole file
[ https://issues.apache.org/jira/browse/CB-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683432#comment-15683432 ] Nikita Matrosov commented on CB-12085: -- FileReader in fact reads file in chunked mode (256Kb by default (https://github.com/apache/cordova-plugin-file/blob/815c2b1bfe578ee9a9b0f998a906087aca379cd1/www/FileReader.js#L52)), not the whole file at once. However, it also does some transcoding data -> Base64 -> Uint8Array -> data, which sounds excessive but in fact is a feature of platform and JS-to-native bridge implementation. Some experiments show that changing this to avoid intermediate base64 encoding/decoding and pass JSON array through bridge in fact slows read operations down even more (~1.5 times), so i think window.atob is not the worst thing here. As a workaround, to reduce amount of data to pass through bridge I think you can read only the data range that you really need. You can either use 'File.slice' function (See https://developer.mozilla.org/en-US/docs/Web/API/Blob/slice) and then create and use a FileReader for sliced file (for 1 Kb of data it takes 20-40 ms to read, instead 2000-3000 for the whole 3Mb file), or just specify 'start' and 'end' properties of the file instance (which is basically the same and gives the same result). > FileReader#readAsArrayBuffer reads whole file > - > > Key: CB-12085 > URL: https://issues.apache.org/jira/browse/CB-12085 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 4.3.0 > Environment: Android >Reporter: Damian Senn >Assignee: Nikita Matrosov >Priority: Critical > Labels: performance > > Reading a File with > ```js > let fr = new FileReader > fr.onload = () => done(fs.result) > fr.readAsArrayBuffer(blob) > ``` > Is very slow, I'm assuming this is because it reads the whole file, then > transfers this via base64 to the JS world, where it is converted to an > ArrayBuffer. My use-case involves reading some media metadata in JS-World, > this usually involves reading several bytes (maybe around 100b to 1kb) of 2mb > to 50mb files. > I noticed this by profiling via Chrome-DevTools where the most time is being > spent in the `atob` function in `cordova/base64.toArrayBuffer`. > So parsing some hundreds of bytes on a 3mb file may take around 3 to 4 > seconds on my Samsung Galaxy S4 and around 1 second on my Samsung Galaxy S6. > (This is without trying to read the actual metadata from the file). > My guess is that this also has a very negative impact on memory usage and > garbage collection. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12085) FileReader#readAsArrayBuffer reads whole file
[ https://issues.apache.org/jira/browse/CB-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-12085: -- Assignee: Nikita Matrosov > FileReader#readAsArrayBuffer reads whole file > - > > Key: CB-12085 > URL: https://issues.apache.org/jira/browse/CB-12085 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 4.3.0 > Environment: Android >Reporter: Damian Senn >Assignee: Nikita Matrosov >Priority: Critical > Labels: performance > > Reading a File with > ```js > let fr = new FileReader > fr.onload = () => done(fs.result) > fr.readAsArrayBuffer(blob) > ``` > Is very slow, I'm assuming this is because it reads the whole file, then > transfers this via base64 to the JS world, where it is converted to an > ArrayBuffer. My use-case involves reading some media metadata in JS-World, > this usually involves reading several bytes (maybe around 100b to 1kb) of 2mb > to 50mb files. > I noticed this by profiling via Chrome-DevTools where the most time is being > spent in the `atob` function in `cordova/base64.toArrayBuffer`. > So parsing some hundreds of bytes on a 3mb file may take around 3 to 4 > seconds on my Samsung Galaxy S4 and around 1 second on my Samsung Galaxy S6. > (This is without trying to read the actual metadata from the file). > My guess is that this also has a very negative impact on memory usage and > garbage collection. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12019) cordova-plugin-file : Performance issue between version 3.0.0 and 4.3.0
[ https://issues.apache.org/jira/browse/CB-12019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682962#comment-15682962 ] Sebastien Chauffray commented on CB-12019: -- Hi Have you been able to watch this performance issue ? Thanks a lot Sebastien > cordova-plugin-file : Performance issue between version 3.0.0 and 4.3.0 > --- > > Key: CB-12019 > URL: https://issues.apache.org/jira/browse/CB-12019 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin File >Affects Versions: 3.5.0 > Environment: Tests done with Visual Studio 2015, cordova cli 6.3 > Materiel : Samsung A5 2016, Android 6.0.1 >Reporter: Sebastien Chauffray >Priority: Minor > Labels: performance > > Performance tests to compare cordova-plugin-file 3.0.0 to 4.3.0 > I've done 3 tests : > Test 1 : Create 1 000 files (about 4 000 characters each) in synchronous > mode. I wait the end of a file to create the next > Test 2 : Create 500 files (about 4 000 characters each) in asynchronous mode. > Don't wait to create all the file > Test 3 : Create a file by 400 appends of 4 000 caractères and read this file > (about 1.60 Mo) > I mesure each test and see very bad performance for version 4.3.0 of the > plugin... > You can see the result in the array : > Version 3.0.0 > Cycle 1Cycle 2 > Test 121s 975ms 22s 78ms > Test 24s 118ms 3s 761ms > Test 310s 317ms > Version 4.3.0 > Cycle 1Cycle 2 > Test 150s 341ms 51s 10ms > Test 28s 172ms 9s 230ms > Test 316s 484ms > if needed, i can discuss about the test detail -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org