[jira] [Resolved] (CB-12729) Test Framework - KEEP
[ https://issues.apache.org/jira/browse/CB-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12729. Resolution: Feedback Received > Test Framework - KEEP > -- > > Key: CB-12729 > URL: https://issues.apache.org/jira/browse/CB-12729 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-test-framework >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12725) Battery Status - KEEP
[ https://issues.apache.org/jira/browse/CB-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12725. Resolution: Feedback Received Closing this. Opened CB-13046 to track changes to the battery status plugin work. > Battery Status - KEEP > - > > Key: CB-12725 > URL: https://issues.apache.org/jira/browse/CB-12725 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-battery-status >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13046) Update battery status plugin to latest spec / drop android impl
Filip Maj created CB-13046: -- Summary: Update battery status plugin to latest spec / drop android impl Key: CB-13046 URL: https://issues.apache.org/jira/browse/CB-13046 Project: Apache Cordova Issue Type: Task Components: cordova-plugin-battery-status Reporter: Filip Maj See CB-12725 for details. Need to look at incorporating https://github.com/phonegap/phonegap-plugin-battery-status. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13046) Update battery status plugin to latest spec / drop android impl
[ https://issues.apache.org/jira/browse/CB-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj updated CB-13046: --- Labels: plugins-next (was: ) > Update battery status plugin to latest spec / drop android impl > --- > > Key: CB-13046 > URL: https://issues.apache.org/jira/browse/CB-13046 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-battery-status >Reporter: Filip Maj > Labels: plugins-next > > See CB-12725 for details. > Need to look at incorporating > https://github.com/phonegap/phonegap-plugin-battery-status. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12724) Vibration - KEEP
[ https://issues.apache.org/jira/browse/CB-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12724. Resolution: Feedback Received I've filed CB-13045 to track the work of testing support for the vibration API on Android, and seeing if we can drop the Android implementation. Closing this. > Vibration - KEEP > > > Key: CB-12724 > URL: https://issues.apache.org/jira/browse/CB-12724 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-vibration >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13045) Drop android implementation of cordova-plugin-vibration
[ https://issues.apache.org/jira/browse/CB-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj updated CB-13045: --- Labels: plugins-next (was: ) > Drop android implementation of cordova-plugin-vibration > --- > > Key: CB-13045 > URL: https://issues.apache.org/jira/browse/CB-13045 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-vibration >Reporter: Filip Maj > Labels: plugins-next > > Android webviews should support this API natively now. WE should test which > Android versions support this and if its feasible. If it is, the minimum > Android version it supports should also give us a good hint as to which > minimum cordova-android versions the new version of this plugin could support. > This will require a major version bump for the plugin. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13045) Drop android implementation of cordova-plugin-vibration
Filip Maj created CB-13045: -- Summary: Drop android implementation of cordova-plugin-vibration Key: CB-13045 URL: https://issues.apache.org/jira/browse/CB-13045 Project: Apache Cordova Issue Type: Task Components: cordova-plugin-vibration Reporter: Filip Maj Android webviews should support this API natively now. WE should test which Android versions support this and if its feasible. If it is, the minimum Android version it supports should also give us a good hint as to which minimum cordova-android versions the new version of this plugin could support. This will require a major version bump for the plugin. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13043) Cordova generated app broken if the plugin is a dynamic framework that depends on Cordova
[ https://issues.apache.org/jira/browse/CB-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095545#comment-16095545 ] Shazron Abdullah commented on CB-13043: --- Let's move over to only Cordova.framework use. Off the top of my head I can't recall anything that is impacted, save maybe an Embedded WebView case (instructions might need updating): https://cordova.apache.org/docs/en/latest/guide/platforms/ios/webview.html In any case, we signal major changes like this with a major version bump, which is coming up (cordova-ios@5.0.0: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=86) > Cordova generated app broken if the plugin is a dynamic framework that > depends on Cordova > - > > Key: CB-13043 > URL: https://issues.apache.org/jira/browse/CB-13043 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create, cordova-ios >Affects Versions: 4.4.0 > Environment: iOS 10 >Reporter: Bharath Hariharan >Assignee: Shazron Abdullah > > I have a plugin that's directly dependent on Cordova since it contains a > subclass of CDVViewController and it references other native Cordova classes. > I'm trying to package this framework as a dynamic framework and bundle it in > my plugin. The problem with this is that it has to be linked to > Cordova.framework but the generated app from Cordova CLI links to > libCordova.a which causes symbol conflicts. The basic problem is that a > dynamic framework has a defined boundary and is self-sufficient, which > prevents it from getting symbols from the external libCordova.a. It also > can't weak-link to a static lib. The fix here would be to do 1 of the > following: > 1) In the generated app, make Cordova's dynamic framework target a dependency > instead of the static target like it is currently. Also, link to > Cordova.framework instead of libCordova.a. > 2) Allow a parameter to be set in the plugin, called "dynamic" or something > to that effect that allows a plugin to specify that it needs Cordova as a > dynamic framework dependency. Setting this parameter would basically make > Cordova do (1). > Since Apple has moved away from static libs and is recommending dynamic > frameworks, I would recommend approach (1). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12710) Camera - KEEP
[ https://issues.apache.org/jira/browse/CB-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095542#comment-16095542 ] jcesarmobile commented on CB-12710: --- I think we should move all the AndroidManifest.xml and info.plist permission writing out of plugins once we have the config-file properly working on the config.xml. It caused problems in the past with duplicate permissions in Android and now it's causing with text missing on iOS > Camera - KEEP > - > > Key: CB-12710 > URL: https://issues.apache.org/jira/browse/CB-12710 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-camera >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12720) Network Information - KEEP
[ https://issues.apache.org/jira/browse/CB-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12720. Resolution: Feedback Received > Network Information - KEEP > -- > > Key: CB-12720 > URL: https://issues.apache.org/jira/browse/CB-12720 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-network-information >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13043) Cordova generated app broken if the plugin is a dynamic framework that depends on Cordova
[ https://issues.apache.org/jira/browse/CB-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095539#comment-16095539 ] Kevin Hawkins commented on CB-13043: I guess the overarching question is: can we think of a reason _not_ to simply move to a {{Cordova.framework}} dependency in the CLI-based apps? It would arguably be a more straightforward exercise to simply cut over from the static library dependency. But I'm sure I'm not thinking of all of the other impacts that may have for consumers, plugins, testing paradigms, etc. > Cordova generated app broken if the plugin is a dynamic framework that > depends on Cordova > - > > Key: CB-13043 > URL: https://issues.apache.org/jira/browse/CB-13043 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create, cordova-ios >Affects Versions: 4.4.0 > Environment: iOS 10 >Reporter: Bharath Hariharan >Assignee: Shazron Abdullah > > I have a plugin that's directly dependent on Cordova since it contains a > subclass of CDVViewController and it references other native Cordova classes. > I'm trying to package this framework as a dynamic framework and bundle it in > my plugin. The problem with this is that it has to be linked to > Cordova.framework but the generated app from Cordova CLI links to > libCordova.a which causes symbol conflicts. The basic problem is that a > dynamic framework has a defined boundary and is self-sufficient, which > prevents it from getting symbols from the external libCordova.a. It also > can't weak-link to a static lib. The fix here would be to do 1 of the > following: > 1) In the generated app, make Cordova's dynamic framework target a dependency > instead of the static target like it is currently. Also, link to > Cordova.framework instead of libCordova.a. > 2) Allow a parameter to be set in the plugin, called "dynamic" or something > to that effect that allows a plugin to specify that it needs Cordova as a > dynamic framework dependency. Setting this parameter would basically make > Cordova do (1). > Since Apple has moved away from static libs and is recommending dynamic > frameworks, I would recommend approach (1). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12718) WKWebViewEngine - KEEP
[ https://issues.apache.org/jira/browse/CB-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12718. Resolution: Feedback Received > WKWebViewEngine - KEEP > -- > > Key: CB-12718 > URL: https://issues.apache.org/jira/browse/CB-12718 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-wkwebview-engine >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12716) Device - KEEP
[ https://issues.apache.org/jira/browse/CB-12716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12716. Resolution: Feedback Received > Device - KEEP > - > > Key: CB-12716 > URL: https://issues.apache.org/jira/browse/CB-12716 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12715) File - KEEP
[ https://issues.apache.org/jira/browse/CB-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12715. Resolution: Feedback Received Opened a new issue to track updating at CB-13044. > File - KEEP > --- > > Key: CB-12715 > URL: https://issues.apache.org/jira/browse/CB-12715 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13044) Update cordova-plugin-file to latest version of File API
Filip Maj created CB-13044: -- Summary: Update cordova-plugin-file to latest version of File API Key: CB-13044 URL: https://issues.apache.org/jira/browse/CB-13044 Project: Apache Cordova Issue Type: Task Components: cordova-plugin-file Reporter: Filip Maj Part of the roadmap for the core plugins is to update them to make them spec-relevant once more. See CB-12715. TODO: Determine what needs to be updated. Check out http://w3c.github.io/FileAPI -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12712) Geolocation - KEEP
[ https://issues.apache.org/jira/browse/CB-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12712. Resolution: Later > Geolocation - KEEP > -- > > Key: CB-12712 > URL: https://issues.apache.org/jira/browse/CB-12712 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-geolocation >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12710) Camera - KEEP
[ https://issues.apache.org/jira/browse/CB-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095527#comment-16095527 ] Filip Maj commented on CB-12710: [~macdonst] based on [the claims in this pull request to the camera plugin, using {{getUserMedia}} in Android API 24+ requires the use of the CAMERA permission|https://github.com/apache/cordova-plugin-camera/pull/282]. > Camera - KEEP > - > > Key: CB-12710 > URL: https://issues.apache.org/jira/browse/CB-12710 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-camera >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13043) Cordova generated app broken if the plugin is a dynamic framework that depends on Cordova
Bharath Hariharan created CB-13043: -- Summary: Cordova generated app broken if the plugin is a dynamic framework that depends on Cordova Key: CB-13043 URL: https://issues.apache.org/jira/browse/CB-13043 Project: Apache Cordova Issue Type: Bug Components: cordova-create, cordova-ios Affects Versions: 4.4.0 Environment: iOS 10 Reporter: Bharath Hariharan Assignee: Shazron Abdullah I have a plugin that's directly dependent on Cordova since it contains a subclass of CDVViewController and it references other native Cordova classes. I'm trying to package this framework as a dynamic framework and bundle it in my plugin. The problem with this is that it has to be linked to Cordova.framework but the generated app from Cordova CLI links to libCordova.a which causes symbol conflicts. The basic problem is that a dynamic framework has a defined boundary and is self-sufficient, which prevents it from getting symbols from the external libCordova.a. It also can't weak-link to a static lib. The fix here would be to do 1 of the following: 1) In the generated app, make Cordova's dynamic framework target a dependency instead of the static target like it is currently. Also, link to Cordova.framework instead of libCordova.a. 2) Allow a parameter to be set in the plugin, called "dynamic" or something to that effect that allows a plugin to specify that it needs Cordova as a dynamic framework dependency. Setting this parameter would basically make Cordova do (1). Since Apple has moved away from static libs and is recommending dynamic frameworks, I would recommend approach (1). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12709) InAppBrowser - KEEP
[ https://issues.apache.org/jira/browse/CB-12709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-12709. Resolution: Later Closing the issue. > InAppBrowser - KEEP > --- > > Key: CB-12709 > URL: https://issues.apache.org/jira/browse/CB-12709 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser >Reporter: Shazron Abdullah > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-9661) Plugins should be notified after deviceready event has been fired
[ https://issues.apache.org/jira/browse/CB-9661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095503#comment-16095503 ] Filip Maj edited comment on CB-9661 at 7/20/17 10:51 PM: - For the record I agree with you, it should be possible to extend the standard cordova plugin interface to include an event like this. In [Android, for example, we already provide event hooks for {{onStop}}, {{onResume}}, {{onNewIntent}}, etc.|https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaPlugin.java] I don't see the harm in adding deviceready to that list, I think it is clearer than my cludgy workaround abusing {{exec}}. was (Author: filmaj): For the record I agree with you, it should be possible to extend the standard cordova plugin interface to include an event like this. In [Android, for example, we already provide event hooks for {{onStop}}, {{onResume}}, {{onNewIntent}}, etc.|https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaPlugin.java] > Plugins should be notified after deviceready event has been fired > - > > Key: CB-9661 > URL: https://issues.apache.org/jira/browse/CB-9661 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Affects Versions: 5.1.1 >Reporter: Sebastien Lorber > > I use the Intercom plugin. > It is a plugin that shows a little button at the bottom (that we'll call > "widget") that permits to show a native chat panel when the user wants to > give a feedback for our app. > On startup I run something akin to: > {code} > function deviceReady() { > hideSplashScreen(); > if ( isUserConnected() ) { > intercom.registerIdentifiedUser(userIntercomData); > startApp(); > } > else { > intercom.reset(); > showLoginForm(); > } > } > {code} > The widget is only shawn after calling intercom.registerIdentifiedUser(); > The widget disappear when we call intercom.reset(); > The intercom plugin memoizes the fact that an user is registered over time. > This means that if I kill the app with a registered user, and restart it, > Intercom will by default restore that regitered user on next startup. > Unfortunatly, this means that the widget will be shawn at the very beginning > of the app initialization, even before the webview is initialized. In my > case, it means that the Intercom button will be shawn for a little amount of > time above the splash screen, which is a bit weird. > This would make sense for the Intercom team to not show the widget until the > webview is initialized, particularly waiting for deviceready event to fire. > After discussing with the Intercom team, it seems they can't implement this > because there's no possible way to wait for the deviceready event to fire > from the native plugin code. > So I think it could be nice to be able, from the native plugin code, to wait > for the deviceready event to be handled, so that native code can be started > afterwards. > The original plugin issue: > https://github.com/intercom/intercom-cordova/issues/18 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9661) Plugins should be notified after deviceready event has been fired
[ https://issues.apache.org/jira/browse/CB-9661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095503#comment-16095503 ] Filip Maj commented on CB-9661: --- For the record I agree with you, it should be possible to extend the standard cordova plugin interface to include an event like this. In [Android, for example, we already provide event hooks for {{onStop}}, {{onResume}}, {{onNewIntent}}, etc.|https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaPlugin.java] > Plugins should be notified after deviceready event has been fired > - > > Key: CB-9661 > URL: https://issues.apache.org/jira/browse/CB-9661 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Affects Versions: 5.1.1 >Reporter: Sebastien Lorber > > I use the Intercom plugin. > It is a plugin that shows a little button at the bottom (that we'll call > "widget") that permits to show a native chat panel when the user wants to > give a feedback for our app. > On startup I run something akin to: > {code} > function deviceReady() { > hideSplashScreen(); > if ( isUserConnected() ) { > intercom.registerIdentifiedUser(userIntercomData); > startApp(); > } > else { > intercom.reset(); > showLoginForm(); > } > } > {code} > The widget is only shawn after calling intercom.registerIdentifiedUser(); > The widget disappear when we call intercom.reset(); > The intercom plugin memoizes the fact that an user is registered over time. > This means that if I kill the app with a registered user, and restart it, > Intercom will by default restore that regitered user on next startup. > Unfortunatly, this means that the widget will be shawn at the very beginning > of the app initialization, even before the webview is initialized. In my > case, it means that the Intercom button will be shawn for a little amount of > time above the splash screen, which is a bit weird. > This would make sense for the Intercom team to not show the widget until the > webview is initialized, particularly waiting for deviceready event to fire. > After discussing with the Intercom team, it seems they can't implement this > because there's no possible way to wait for the deviceready event to fire > from the native plugin code. > So I think it could be nice to be able, from the native plugin code, to wait > for the deviceready event to be handled, so that native code can be started > afterwards. > The original plugin issue: > https://github.com/intercom/intercom-cordova/issues/18 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10872) Add documentation for the Browser platform
[ https://issues.apache.org/jira/browse/CB-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj updated CB-10872: --- Labels: browser-next (was: backlog browser-next) > Add documentation for the Browser platform > -- > > Key: CB-10872 > URL: https://issues.apache.org/jira/browse/CB-10872 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-browser > Environment: Browser Platform >Reporter: Robert Posener >Priority: Critical > Labels: browser-next > > TOC under Platforms is missing Browser > Config.xml is missing Browser > Customize Icons is missing Browser > [~filmaj] notes: cordova-browser README.md once-over. Do the PWA notes apply? > feels like this section could use more ellaboration. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10872) Add documentation for the Browser platform
[ https://issues.apache.org/jira/browse/CB-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj updated CB-10872: --- Description: TOC under Platforms is missing Browser Config.xml is missing Browser Customize Icons is missing Browser [~filmaj] notes: cordova-browser README.md once-over. Do the PWA notes apply? feels like this section could use more ellaboration. was: TOC under Platforms is missing Browser Config.xml is missing Browser Customize Icons is missing Browser > Add documentation for the Browser platform > -- > > Key: CB-10872 > URL: https://issues.apache.org/jira/browse/CB-10872 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-browser > Environment: Browser Platform >Reporter: Robert Posener >Priority: Critical > Labels: browser-next > > TOC under Platforms is missing Browser > Config.xml is missing Browser > Customize Icons is missing Browser > [~filmaj] notes: cordova-browser README.md once-over. Do the PWA notes apply? > feels like this section could use more ellaboration. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13042) Run Apache RAT / add license headers
Filip Maj created CB-13042: -- Summary: Run Apache RAT / add license headers Key: CB-13042 URL: https://issues.apache.org/jira/browse/CB-13042 Project: Apache Cordova Issue Type: Task Components: cordova-browser Reporter: Filip Maj Assignee: Jesse MacFadyen bin/template/cordova/Api.js is missing it. run RAT to see if we're good. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095166#comment-16095166 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/580 CB-12895 : Replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12895-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #580 commit 4cb49cf58523d0ef8039cba6b2d3d6a7ebc260a9 Author: Audrey SoDate: 2017-07-19T16:51:05Z CB-12895 : set up eslint commit 25c80f56f2697f6f359669eb8e150b208e2cd9f2 Author: Audrey So Date: 2017-07-19T16:54:49Z CB-12895 : ran eslint --fix on cordova-lib commit 55a3eccf913ac0cee11633718a11748a43e8cb88 Author: Audrey So Date: 2017-07-20T16:41:06Z CB-12895 : updated integration tests with eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12677) `cordova requirements android` fails when Android Studio is in "Program Files" instead of "Program Files (x86)"
[ https://issues.apache.org/jira/browse/CB-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095157#comment-16095157 ] ASF GitHub Bot commented on CB-12677: - Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/396 Did you see the fix @purplecabbage did to pull this info from the Windows registry for Windows users? We're probably going to go with that solution for Windows because of the whole PATH issue. Mac OS and Linux users are able to install Gradle without a problem. There are already other issues with using or requiring Android Studio as a dependency, such as the fact that some people don't ever use the IDE > `cordova requirements android` fails when Android Studio is in "Program > Files" instead of "Program Files (x86)" > --- > > Key: CB-12677 > URL: https://issues.apache.org/jira/browse/CB-12677 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.2.1 > Environment: Windows 7, 64-bit > Android Studio 2.3.1 > cordova 6.5.0 > cordova-android 6.2.1 >Reporter: jakub-g > Labels: android-next > > See http://stackoverflow.com/a/43523141/245966 > basically on my machine in `cordova/lib/check_reqs.js`: > {code} > process.env['ProgramFiles'] === 'C:\\Program Files (x86)' > {code} > whereas I have android studio in `C:\Program Files` and I think I might not > be the only one with the same problem. > In fact on my machine I have the following folders somehow: > {code} > C:\Program Files\Android\Android Studio > C:\Program Files (x86)\Android\android-sdk > {code} > (The second folder is some leftovers from old installation, not used anymore; > I keep things in `D:\java\android\sdk` since quite a while) > What would be a good fix in your opinion, other than checking both folders? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095146#comment-16095146 ] ASF GitHub Bot commented on CB-12361: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/579 CB-12361 : added tests for save.js ### Platforms affected ### What does this PR do? ### What testing has been done on this change? added tests for save.js ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-11 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/579.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #579 > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10123) -webkit-scrollbar css does not work in WKWebViewEngine
[ https://issues.apache.org/jira/browse/CB-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094811#comment-16094811 ] Joshua Bronson edited comment on CB-10123 at 7/20/17 3:21 PM: -- Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the ::-webkit-scrollbar \{ display: none; \} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as making them consistent with their Android counterpart builds, which don't get scrollbars by default either. And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? I searched for such a plugin and couldn't find something that seemed like the solution to this issue. Thanks! was (Author: jab_): Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the ::-webkit-scrollbar \{ display: none; \} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as making them consistent with their Android counterpart builds, which don't get scrollbars by default either. And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! > -webkit-scrollbar css does not work in WKWebViewEngine > -- > > Key: CB-10123 > URL: https://issues.apache.org/jira/browse/CB-10123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-wkwebview-engine > Environment: Using iOS 9, with IOS-Cordova 4.0 (beta) and official > cordova WKWebView engine. >Reporter: Cole Turner > Labels: wkwebview-known-issues > > To hide the appearance of scrollbars in Safari, Webkit, and UIWebView, we use > the following CSS: > ::-webkit-scrollbar {display:none;} > The WKWebView engine does not honor this property. The only way to control > the appearance of a scrollbar is invoking it via a plugin as so: > self.wkWebView.scrollView.showsVerticalScrollIndicator = NO; > self.wkWebView.scrollView.showsHorizontalScrollIndicator = NO; > It would be nice to abstract this as a plugin preference since the WKWebView > engine is now a separate plugin: (via Shazron) > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10123) -webkit-scrollbar css does not work in WKWebViewEngine
[ https://issues.apache.org/jira/browse/CB-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094811#comment-16094811 ] Joshua Bronson edited comment on CB-10123 at 7/20/17 3:20 PM: -- Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the ::-webkit-scrollbar \{ display: none; \} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as making them consistent with their Android counterpart builds, which don't get scrollbars by default either. And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! was (Author: jab_): Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the ::-webkit-scrollbar \{ display: none; \} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! > -webkit-scrollbar css does not work in WKWebViewEngine > -- > > Key: CB-10123 > URL: https://issues.apache.org/jira/browse/CB-10123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-wkwebview-engine > Environment: Using iOS 9, with IOS-Cordova 4.0 (beta) and official > cordova WKWebView engine. >Reporter: Cole Turner > Labels: wkwebview-known-issues > > To hide the appearance of scrollbars in Safari, Webkit, and UIWebView, we use > the following CSS: > ::-webkit-scrollbar {display:none;} > The WKWebView engine does not honor this property. The only way to control > the appearance of a scrollbar is invoking it via a plugin as so: > self.wkWebView.scrollView.showsVerticalScrollIndicator = NO; > self.wkWebView.scrollView.showsHorizontalScrollIndicator = NO; > It would be nice to abstract this as a plugin preference since the WKWebView > engine is now a separate plugin: (via Shazron) > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10123) -webkit-scrollbar css does not work in WKWebViewEngine
[ https://issues.apache.org/jira/browse/CB-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094811#comment-16094811 ] Joshua Bronson edited comment on CB-10123 at 7/20/17 3:19 PM: -- Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the ::-webkit-scrollbar \{ display: none; \} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! was (Author: jab_): Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the {code}::-webkit-scrollbar { display: none; }{code} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! > -webkit-scrollbar css does not work in WKWebViewEngine > -- > > Key: CB-10123 > URL: https://issues.apache.org/jira/browse/CB-10123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-wkwebview-engine > Environment: Using iOS 9, with IOS-Cordova 4.0 (beta) and official > cordova WKWebView engine. >Reporter: Cole Turner > Labels: wkwebview-known-issues > > To hide the appearance of scrollbars in Safari, Webkit, and UIWebView, we use > the following CSS: > ::-webkit-scrollbar {display:none;} > The WKWebView engine does not honor this property. The only way to control > the appearance of a scrollbar is invoking it via a plugin as so: > self.wkWebView.scrollView.showsVerticalScrollIndicator = NO; > self.wkWebView.scrollView.showsHorizontalScrollIndicator = NO; > It would be nice to abstract this as a plugin preference since the WKWebView > engine is now a separate plugin: (via Shazron) > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10123) -webkit-scrollbar css does not work in WKWebViewEngine
[ https://issues.apache.org/jira/browse/CB-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094811#comment-16094811 ] Joshua Bronson edited comment on CB-10123 at 7/20/17 3:18 PM: -- Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the {code}::-webkit-scrollbar { display: none; }{code} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! was (Author: jab_): Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the {noformat}::-webkit-scrollbar { display: none; }{noformat} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! > -webkit-scrollbar css does not work in WKWebViewEngine > -- > > Key: CB-10123 > URL: https://issues.apache.org/jira/browse/CB-10123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-wkwebview-engine > Environment: Using iOS 9, with IOS-Cordova 4.0 (beta) and official > cordova WKWebView engine. >Reporter: Cole Turner > Labels: wkwebview-known-issues > > To hide the appearance of scrollbars in Safari, Webkit, and UIWebView, we use > the following CSS: > ::-webkit-scrollbar {display:none;} > The WKWebView engine does not honor this property. The only way to control > the appearance of a scrollbar is invoking it via a plugin as so: > self.wkWebView.scrollView.showsVerticalScrollIndicator = NO; > self.wkWebView.scrollView.showsHorizontalScrollIndicator = NO; > It would be nice to abstract this as a plugin preference since the WKWebView > engine is now a separate plugin: (via Shazron) > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-10123) -webkit-scrollbar css does not work in WKWebViewEngine
[ https://issues.apache.org/jira/browse/CB-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094811#comment-16094811 ] Joshua Bronson edited comment on CB-10123 at 7/20/17 3:17 PM: -- Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the {noformat}::-webkit-scrollbar { display: none; }{noformat} CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! was (Author: jab_): Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the ::-webkit-scrollbar { display: none; } CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! > -webkit-scrollbar css does not work in WKWebViewEngine > -- > > Key: CB-10123 > URL: https://issues.apache.org/jira/browse/CB-10123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-wkwebview-engine > Environment: Using iOS 9, with IOS-Cordova 4.0 (beta) and official > cordova WKWebView engine. >Reporter: Cole Turner > Labels: wkwebview-known-issues > > To hide the appearance of scrollbars in Safari, Webkit, and UIWebView, we use > the following CSS: > ::-webkit-scrollbar {display:none;} > The WKWebView engine does not honor this property. The only way to control > the appearance of a scrollbar is invoking it via a plugin as so: > self.wkWebView.scrollView.showsVerticalScrollIndicator = NO; > self.wkWebView.scrollView.showsHorizontalScrollIndicator = NO; > It would be nice to abstract this as a plugin preference since the WKWebView > engine is now a separate plugin: (via Shazron) > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10123) -webkit-scrollbar css does not work in WKWebViewEngine
[ https://issues.apache.org/jira/browse/CB-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094811#comment-16094811 ] Joshua Bronson commented on CB-10123: - Just found this issue after some significant searching for why scrollbars are appearing in our Cordova (6.5.0) app on iOS (10.3.2) but not Android. (And adding the ::-webkit-scrollbar { display: none; } CSS makes no difference.) Unfortunately Googling around for this yielded lots of other dead-end results before it led here, but it looks like I've finally found the culprit and this issue is the reason, is that right? I do see that this issue hasn't been updated in ~10 months, so first figured I'd just make sure the ticket status/priority/etc. haven't drifted out-of-date. If not, is there some reason that Cordova isn't just setting the wkWebView.scrollView.shows(Vertical|Horizontal)ScrollIndicator properties to NO by default for all Cordova iOS apps? This would make Cordova iOS apps look consistent with other native iOS apps, as well as them consistent with their Android counterparts (which don't get scrollbars by default). And as long as an additional plugin is required to get this to be consistent, is anyone aware of (an up-to-date version of) such a plugin that could be linked to from this issue? Thanks! > -webkit-scrollbar css does not work in WKWebViewEngine > -- > > Key: CB-10123 > URL: https://issues.apache.org/jira/browse/CB-10123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-wkwebview-engine > Environment: Using iOS 9, with IOS-Cordova 4.0 (beta) and official > cordova WKWebView engine. >Reporter: Cole Turner > Labels: wkwebview-known-issues > > To hide the appearance of scrollbars in Safari, Webkit, and UIWebView, we use > the following CSS: > ::-webkit-scrollbar {display:none;} > The WKWebView engine does not honor this property. The only way to control > the appearance of a scrollbar is invoking it via a plugin as so: > self.wkWebView.scrollView.showsVerticalScrollIndicator = NO; > self.wkWebView.scrollView.showsHorizontalScrollIndicator = NO; > It would be nice to abstract this as a plugin preference since the WKWebView > engine is now a separate plugin: (via Shazron) > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6938) iOS File plugin: copyTo for file returns error when destination file exists
[ https://issues.apache.org/jira/browse/CB-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094659#comment-16094659 ] ASF GitHub Bot commented on CB-6938: GitHub user VinceOPS opened a pull request: https://github.com/apache/cordova-plugin-file/pull/211 CB-6938: (fix) on iOS, copyTo should overwrite any existing file https://issues.apache.org/jira/browse/CB-6938 ### Platforms affected iOS, all versions. ### What does this PR do? It fixes CB-6938. Instead of returning an error 12 (PATH_EXISTS_ERR), it tries to remove the existing file, then to copy the "new" one. ### What testing has been done on this change? Simulator: iPhone 5 and iPhone 6 @ iOS 9, 10. Real device: iPhone 5 @ iOS 10. No unit test provided nor written. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/VinceOPS/cordova-plugin-file CB-6938cordova-plugin-file Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #211 commit 064c7f33e8d9b5dcee4f520e80a385336c9fcbc5 Author: VinceOPSDate: 2017-07-20T13:00:42Z iOS: (fix) copyTo should overwrite any existing file > iOS File plugin: copyTo for file returns error when destination file exists > --- > > Key: CB-6938 > URL: https://issues.apache.org/jira/browse/CB-6938 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Affects Versions: 3.5.0 > Environment: ios >Reporter: vldm >Assignee: Ian Clelland > Labels: iOS > > According to w3c spec: > A copy of a file on top of an existing file must attempt to delete and > replace that file. > iOS version of plugin in file CDVLocalFilesystem.m contains this code for the > case: > {code} > } else if (bNewExists) { > // the full destination should NOT already exist if a copy > errCode = PATH_EXISTS_ERR; > {code} > Suggested patch: > {code} > diff --git a/src/ios/CDVLocalFilesystem.m b/src/ios/CDVLocalFilesystem.m > index d1576ad..f5aa508 100644 > --- a/src/ios/CDVLocalFilesystem.m > +++ b/src/ios/CDVLocalFilesystem.m > @@ -535,11 +535,11 @@ > if (bSrcIsDir && ![self canCopyMoveSrc:srcFullPath > ToDestination:newFileSystemPath]) { > // can't copy dir into self > errCode = INVALID_MODIFICATION_ERR; > -} else if (bNewExists) { > -// the full destination should NOT already exist if a > copy > -errCode = PATH_EXISTS_ERR; > } else { > -bSuccess = [fileMgr copyItemAtPath:srcFullPath > toPath:newFileSystemPath error:]; > + bSuccess = YES; > +if (bNewExists) > +bSuccess = [fileMgr > removeItemAtPath:newFileSystemPath error:]; > +if (bSuccess) > +bSuccess = [fileMgr copyItemAtPath:srcFullPath > toPath:newFileSystemPath error:]; > } > } else { // move > // iOS requires that destination must not exist before > calling moveTo > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13040) Stream stops playing randomly when app is on background
[ https://issues.apache.org/jira/browse/CB-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Skuder updated CB-13040: -- Affects Version/s: 3.0.0 cordova@7.0.0 > Stream stops playing randomly when app is on background > --- > > Key: CB-13040 > URL: https://issues.apache.org/jira/browse/CB-13040 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 3.0.0, cordova@7.0.0 > Environment: Android >Reporter: Jarek Skuder > > I made an radio streaming app and when app is on background, stream randomly > stops (can be after 15min, can be 7min etc.). > Tested on Samsung S5 mini Android 6.0.1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13031) config.xml: android-packageName case-sensitivity
[ https://issues.apache.org/jira/browse/CB-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094449#comment-16094449 ] Ronald Klip commented on CB-13031: -- [~Nikita Matrosov] Ah, OK. That works: I can add the platform, the activity file gets created in the directory under src, and I can build and run the app. I noticed that the directory name platforms/android/src/com/example/testapp is the lowercase version, i.e. it doesn't fully match the package name in the manifest. Unsure whether that is relevant; things seem to work fine. > config.xml: android-packageName case-sensitivity > > > Key: CB-13031 > URL: https://issues.apache.org/jira/browse/CB-13031 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 7.0.1 >Reporter: Ronald Klip >Assignee: Nikita Matrosov >Priority: Minor > Labels: osx, windows > > In config.xml, setting {{android-packageName}} to a value that only differs > from {{id}} in capitalization causes an error with {{platform add android}} . > *Example:* > {{cordova create testapp com.example.testapp testapp}} > {{cd testapp}} > (edit config.xml, add android-packageName="com.example.Testapp" to ) > {{cordova platform add android}} > *Output:* > Using cordova-fetch for cordova-android@~6.2.2 > Adding android project... > Creating Cordova project for the Android platform: > Path: platforms/android > Package: com.example.testapp > Name: testapp > Activity: MainActivity > Android target: android-25 > Subproject Path: CordovaLib > Android project created with cordova-android@6.2.3 > Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the > project > Installing "cordova-plugin-whitelist" for android >This plugin is only applicable for versions of cordova-android > greater than 4.0. If you have a previous platform version, you do *not* need > this plugin since the whitelist will be built in. > > Adding cordova-plugin-whitelist to package.json > Saved plugin info for "cordova-plugin-whitelist" to config.xml > ls: no such file or directory: > /Users/ronald987/dev/apps/testapp/platforms/android/src/com/example/Testapp/*.java > {color:red}Error: No Java files found that extend CordovaActivity.{color} > > The directory and the .java indeed don't exist. In platforms/android/src > there's only an org directory. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12677) `cordova requirements android` fails when Android Studio is in "Program Files" instead of "Program Files (x86)"
[ https://issues.apache.org/jira/browse/CB-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094429#comment-16094429 ] ASF GitHub Bot commented on CB-12677: - Github user russaa commented on the issue: https://github.com/apache/cordova-android/pull/396 I have to say, I like the current solution better (using `gradle` from Android Studio): 1. you are not required to install something, that you may already have installed 2. if you are building/debugging the Cordova app with Android Studio, you can be sure that builds are same (as you are using the same version of `gradle`) 3. users who prefer to install `gradle` separately still have this option If you want to get rid of the automatic-detection (because it may become cumbersome to maintain) I would still like to have the option of using Android Studio's `gradle` by pointing to its place via the env variable. Its code should be fairly easy to maintain, since the user is responsible to specify the correct path, i.e. the detection routine only needs to look into the env variable and does not need to be adjusted to changing path structures etc. itself. Although the mechanism then should maybe be changed, so that the env variable needs to point the `gradle` directory directly, instead of the Android Studio directory (which it does now), e.g. change the env variable to something like `GRADLE_HOME` and the path would need to point, e.g. to the `gradle` sub-directory of the Android Studio directory. As an additional reason: I assume the _"install `gradle` separately/as requirement"_ option also means, that you must have `gradle` in your PATH env variable. On Windows, this is a concern for me, as the PATH variable has a maximum length -- which I, for instance, are always about to exceed. So I try to not have paths there, if I can avoid it. > `cordova requirements android` fails when Android Studio is in "Program > Files" instead of "Program Files (x86)" > --- > > Key: CB-12677 > URL: https://issues.apache.org/jira/browse/CB-12677 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.2.1 > Environment: Windows 7, 64-bit > Android Studio 2.3.1 > cordova 6.5.0 > cordova-android 6.2.1 >Reporter: jakub-g > Labels: android-next > > See http://stackoverflow.com/a/43523141/245966 > basically on my machine in `cordova/lib/check_reqs.js`: > {code} > process.env['ProgramFiles'] === 'C:\\Program Files (x86)' > {code} > whereas I have android studio in `C:\Program Files` and I think I might not > be the only one with the same problem. > In fact on my machine I have the following folders somehow: > {code} > C:\Program Files\Android\Android Studio > C:\Program Files (x86)\Android\android-sdk > {code} > (The second folder is some leftovers from old installation, not used anymore; > I keep things in `D:\java\android\sdk` since quite a while) > What would be a good fix in your opinion, other than checking both folders? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13036) Use other cordova plugins with inAppBrowser
[ https://issues.apache.org/jira/browse/CB-13036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13036. - Resolution: Not A Problem This is by design, InAppBrowser was created to load external and potentially insecure websites, so access to cordova apis is forbidden. > Use other cordova plugins with inAppBrowser > --- > > Key: CB-13036 > URL: https://issues.apache.org/jira/browse/CB-13036 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Ivan Rozhkov > > I'm not sure if it is a bug or by design. > I want to use some plugin with inappbrowser. > I've read the docs and it is said > https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-inappbrowser/ > : > > ... The InAppBrowser window behaves like a standard web browser, and can't > > access Cordova APIs. ... > Does it mean that I won't be able to use most of cordova plugins? > I can't find a way to use cordova in app browser with other plugins > For example, plugin https://github.com/markmarijnissen/cordova-plugin-share > should be used like this: > > window.plugins.socialsharing.share('Message only') > But looks like I don't have access to window.plugins at all inside > InAppBrowser. > Is there a way to overcome it? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13040) Stream stops playing randomly when app is on background
[ https://issues.apache.org/jira/browse/CB-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13040: -- Component/s: cordova-plugin-media > Stream stops playing randomly when app is on background > --- > > Key: CB-13040 > URL: https://issues.apache.org/jira/browse/CB-13040 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media > Environment: Android >Reporter: Jarek Skuder > > I made an radio streaming app and when app is on background, stream randomly > stops (can be after 15min, can be 7min etc.). > Tested on Samsung S5 mini Android 6.0.1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13041) Stream stops playing randomly when app is on background
[ https://issues.apache.org/jira/browse/CB-13041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13041. - Resolution: Duplicate Closing as duplicate of CB-13040 > Stream stops playing randomly when app is on background > > > Key: CB-13041 > URL: https://issues.apache.org/jira/browse/CB-13041 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 3.0.0, cordova@7.0.0 > Environment: Android >Reporter: Jarek Skuder > > I made an app that plays radio stream and when the app goes to background, > audio randomly stops the stream (after 15min or after 7min or etc). > Tested on Samsung S5 mini Android 6.0.1 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13041) Stream stops playing randomly when app is on background
[ https://issues.apache.org/jira/browse/CB-13041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Skuder updated CB-13041: -- Affects Version/s: cordova@7.0.0 > Stream stops playing randomly when app is on background > > > Key: CB-13041 > URL: https://issues.apache.org/jira/browse/CB-13041 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 3.0.0, cordova@7.0.0 > Environment: Android >Reporter: Jarek Skuder > > I made an app that plays radio stream and when the app goes to background, > audio randomly stops the stream (after 15min or after 7min or etc). > Tested on Samsung S5 mini Android 6.0.1 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13041) Stream stops playing randomly when app is on background
Jarek Skuder created CB-13041: - Summary: Stream stops playing randomly when app is on background Key: CB-13041 URL: https://issues.apache.org/jira/browse/CB-13041 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-media Affects Versions: 3.0.0 Environment: Android Reporter: Jarek Skuder I made an app that plays radio stream and when the app goes to background, audio randomly stops the stream (after 15min or after 7min or etc). Tested on Samsung S5 mini Android 6.0.1 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13040) Stream stops playing randomly when app is on background
Jarek Skuder created CB-13040: - Summary: Stream stops playing randomly when app is on background Key: CB-13040 URL: https://issues.apache.org/jira/browse/CB-13040 Project: Apache Cordova Issue Type: Bug Environment: Android Reporter: Jarek Skuder I made an radio streaming app and when app is on background, stream randomly stops (can be after 15min, can be 7min etc.). Tested on Samsung S5 mini Android 6.0.1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12877) (Android) Audio stops playing randomly on background
[ https://issues.apache.org/jira/browse/CB-12877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094323#comment-16094323 ] Jarek Skuder commented on CB-12877: --- Same for me, but i have KeepRunning value false and it still stops. Tested on Samsung S5 mini Android 6.0.1 > (Android) Audio stops playing randomly on background > > > Key: CB-12877 > URL: https://issues.apache.org/jira/browse/CB-12877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 6.5.0 > Environment: android 6.0, tested on Motorola Moto X 2d gen > http://www.gsmarena.com/motorola_moto_x_(2nd_gen)-6649.php >Reporter: Guilherme Dellagustin >Priority: Minor > > When audio is playing on background, it does not prevent the application from > eventually being closed by the OS. > When this happens, I do not get any pop up like "unfortunally ... stoped > responding". > I have some native apps that play audio on the background, where I never > observed this behavior. > I have in the config file, and > the following plugins > > > > > > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org