[jira] [Closed] (CB-12918) Inconsistent behavior between "cordova prepare" and "cordova plugin add" when installing plugin from local folder

2017-09-13 Thread Max Mednik (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Mednik closed CB-12918.
---
Resolution: Cannot Reproduce

Sorry, can't reproduce any longer.

> Inconsistent behavior between "cordova prepare" and "cordova plugin add" when 
> installing plugin from local folder
> -
>
> Key: CB-12918
> URL: https://issues.apache.org/jira/browse/CB-12918
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 6.5.0, 7.0.1
>Reporter: Max Mednik
>  Labels: cordova-8.0.0
>
> Running "cordova prepare" and "cordova plugin add" handle plugin installation 
> from a local folder differently and either one or another breaks depending on 
> which one used first. 
> For example, I have a plugin defined as following:
> {code}
> {
> ...
> "dependencies": {
> ...
> "cordova-plugin-x": "file:custom_plugins/cordova-plugin-x"
> },
> 
> "cordova": {
> "platforms": [
> "android",
> "ios"
> ],
> "plugins": {
> ...
> "cordova-plugin-x": {}
> }
> }
> }
> {code}
> This config is created when I run "cordova plugin add 
> ./custom_plugins/cordova-plugin-x" and everything works as expected. But, if 
> you delete the plugin from the plugins folder and try to run "cordova 
> prepare" afterwards it will fail with the following message:
> {code}
> Failed to restore plugin "cordova-plugin-x" from config.xml. You might need 
> to try adding it again. Error: Failed to fetch plugin 
> cordova-plugin-x@file:custom_plugins/cordova-plugin-x via registry.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13255) Android Camera photo Crop bug

2017-09-13 Thread Tamas Kovacs (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164345#comment-16164345
 ] 

Tamas Kovacs commented on CB-13255:
---

It happens when the allowEdit is active in the parameters

> Android Camera photo  Crop bug
> --
>
> Key: CB-13255
> URL: https://issues.apache.org/jira/browse/CB-13255
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: Yash Rad
>Priority: Blocker
> Attachments: Screen Shot 2017-09-08 at 15.34.18.png
>
>
> I'm experiencing this on Android devices after taking a photo:
> Preview of the photo is shown correctly,[^attachment-name.zip]
> When you are asked to pick a program for cropping "only once", the image is 
> lost.
> Only after choosing "always" for the default cropping app , from the next 
> time you take the photos it works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins

2017-09-13 Thread Jacques de Villiers (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164369#comment-16164369
 ] 

Jacques de Villiers commented on CB-12242:
--

I asked a question about this on StackOverflow:
https://stackoverflow.com/questions/41125428/how-can-i-get-cordova-to-use-yarn-js-instead-of-npm-for-adding-plugins

And it seems quite a number of people are interested in this, so any feedback 
on this from the Cordova team would be great.

> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>
> Currently it can take quite long to add certain plugins to my project (using 
> cordova plugin add), especially if I need to re-add the plugins. My 
> suggestion is to update the cordova cli to start using yarn js instead of npm 
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and 
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be 
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally 
> sure how to proceed on this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12242) Use yarn js instead of npm when adding plugins

2017-09-13 Thread Jacques de Villiers (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques de Villiers updated CB-12242:
-
Issue Type: Improvement  (was: Wish)

> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>
> Currently it can take quite long to add certain plugins to my project (using 
> cordova plugin add), especially if I need to re-add the plugins. My 
> suggestion is to update the cordova cli to start using yarn js instead of npm 
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and 
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be 
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally 
> sure how to proceed on this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12918) Inconsistent behavior between "cordova prepare" and "cordova plugin add" when installing plugin from local folder

2017-09-13 Thread Max Mednik (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Mednik updated CB-12918:

Affects Version/s: (was: 6.5.0)

> Inconsistent behavior between "cordova prepare" and "cordova plugin add" when 
> installing plugin from local folder
> -
>
> Key: CB-12918
> URL: https://issues.apache.org/jira/browse/CB-12918
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Max Mednik
>  Labels: cordova-8.0.0
>
> Running "cordova prepare" and "cordova plugin add" handle plugin installation 
> from a local folder differently and either one or another breaks depending on 
> which one used first. 
> For example, I have a plugin defined as following:
> {code}
> {
> ...
> "dependencies": {
> ...
> "cordova-plugin-x": "file:custom_plugins/cordova-plugin-x"
> },
> 
> "cordova": {
> "platforms": [
> "android",
> "ios"
> ],
> "plugins": {
> ...
> "cordova-plugin-x": {}
> }
> }
> }
> {code}
> This config is created when I run "cordova plugin add 
> ./custom_plugins/cordova-plugin-x" and everything works as expected. But, if 
> you delete the plugin from the plugins folder and try to run "cordova 
> prepare" afterwards it will fail with the following message:
> {code}
> Failed to restore plugin "cordova-plugin-x" from config.xml. You might need 
> to try adding it again. Error: Failed to fetch plugin 
> cordova-plugin-x@file:custom_plugins/cordova-plugin-x via registry.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Reopened] (CB-12918) Inconsistent behavior between "cordova prepare" and "cordova plugin add" when installing plugin from local folder

2017-09-13 Thread Max Mednik (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Mednik reopened CB-12918:
-

Hmm, works with Cordova 6.5.0 but not with 7.0.1

> Inconsistent behavior between "cordova prepare" and "cordova plugin add" when 
> installing plugin from local folder
> -
>
> Key: CB-12918
> URL: https://issues.apache.org/jira/browse/CB-12918
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Max Mednik
>  Labels: cordova-8.0.0
>
> Running "cordova prepare" and "cordova plugin add" handle plugin installation 
> from a local folder differently and either one or another breaks depending on 
> which one used first. 
> For example, I have a plugin defined as following:
> {code}
> {
> ...
> "dependencies": {
> ...
> "cordova-plugin-x": "file:custom_plugins/cordova-plugin-x"
> },
> 
> "cordova": {
> "platforms": [
> "android",
> "ios"
> ],
> "plugins": {
> ...
> "cordova-plugin-x": {}
> }
> }
> }
> {code}
> This config is created when I run "cordova plugin add 
> ./custom_plugins/cordova-plugin-x" and everything works as expected. But, if 
> you delete the plugin from the plugins folder and try to run "cordova 
> prepare" afterwards it will fail with the following message:
> {code}
> Failed to restore plugin "cordova-plugin-x" from config.xml. You might need 
> to try adding it again. Error: Failed to fetch plugin 
> cordova-plugin-x@file:custom_plugins/cordova-plugin-x via registry.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12918) Inconsistent behavior between "cordova prepare" and "cordova plugin add" when installing plugin from local folder

2017-09-13 Thread Max Mednik (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Mednik updated CB-12918:

Description: 
Running "cordova prepare" and "cordova plugin add" handle plugin installation 
from a local folder differently and either one or another breaks depending on 
which one used first. 
For example, I have a plugin defined as following in the config.xml:
{code}

  ...  
  
  ...

{code}

This config is created when I run "cordova plugin add 
./custom_plugins/cordova-plugin-xxx" and everything works as expected. But, if 
you delete the plugin from the plugins folder and try to run "cordova prepare" 
afterwards it will fail with the following message:
{code}
Failed to restore plugin "cordova-plugin-x" from config.xml. You might need to 
try adding it again. Error: Failed to fetch plugin 
cordova-plugin-x@file:custom_plugins/cordova-plugin-x via registry.
{code}

  was:
Running "cordova prepare" and "cordova plugin add" handle plugin installation 
from a local folder differently and either one or another breaks depending on 
which one used first. 
For example, I have a plugin defined as following:
{code}
{
...
"dependencies": {
...
"cordova-plugin-x": "file:custom_plugins/cordova-plugin-x"
},

"cordova": {
"platforms": [
"android",
"ios"
],
"plugins": {
...
"cordova-plugin-x": {}
}
}
}
{code}

This config is created when I run "cordova plugin add 
./custom_plugins/cordova-plugin-x" and everything works as expected. But, if 
you delete the plugin from the plugins folder and try to run "cordova prepare" 
afterwards it will fail with the following message:
{code}
Failed to restore plugin "cordova-plugin-x" from config.xml. You might need to 
try adding it again. Error: Failed to fetch plugin 
cordova-plugin-x@file:custom_plugins/cordova-plugin-x via registry.
{code}


> Inconsistent behavior between "cordova prepare" and "cordova plugin add" when 
> installing plugin from local folder
> -
>
> Key: CB-12918
> URL: https://issues.apache.org/jira/browse/CB-12918
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Max Mednik
>  Labels: cordova-8.0.0
>
> Running "cordova prepare" and "cordova plugin add" handle plugin installation 
> from a local folder differently and either one or another breaks depending on 
> which one used first. 
> For example, I have a plugin defined as following in the config.xml:
> {code}
> 
>   ...  
>/>
>   ...
> 
> {code}
> This config is created when I run "cordova plugin add 
> ./custom_plugins/cordova-plugin-xxx" and everything works as expected. But, 
> if you delete the plugin from the plugins folder and try to run "cordova 
> prepare" afterwards it will fail with the following message:
> {code}
> Failed to restore plugin "cordova-plugin-x" from config.xml. You might need 
> to try adding it again. Error: Failed to fetch plugin 
> cordova-plugin-x@file:custom_plugins/cordova-plugin-x via registry.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12918) Inconsistent behavior between "cordova prepare" and "cordova plugin add" when installing plugin from local folder

2017-09-13 Thread Max Mednik (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Mednik updated CB-12918:

Description: 
Running "cordova prepare" and "cordova plugin add" handle plugin installation 
from a local folder differently and either one or another breaks depending on 
which one used first. 
For example, I have a plugin defined as following in the config.xml:
{code}

  ...  
  
  ...

{code}

This config is created when I run "cordova plugin add 
./custom_plugins/cordova-plugin-ios-no-export-compliance" and everything works 
as expected. But, if you delete the plugin from the plugins folder and try to 
run "cordova prepare" afterwards it will fail with the following message:
{code}
Discovered plugin "cordova-plugin-ios-no-export-compliance" in config.xml. 
Adding it to the project
Failed to restore plugin "cordova-plugin-ios-no-export-compliance" from 
config.xml. You might need to try adding it again. Error: Failed to fetch 
plugin 
cordova-plugin-ios-no-export-compliance@file:custom_plugins/cordova-plugin-ios-no-export-compliance
 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Error: npm: Command failed with exit code 254 Error output:
npm ERR! addLocal Could not install [project 
path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
npm ERR! path [project 
path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall open
npm ERR! enoent ENOENT: no such file or directory, open '[project 
path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
{code}

Also, after running "cordova prepare" the plugin entry in the config.xml was 
changed to: 
{code}

{code}

  was:
Running "cordova prepare" and "cordova plugin add" handle plugin installation 
from a local folder differently and either one or another breaks depending on 
which one used first. 
For example, I have a plugin defined as following in the config.xml:
{code}

  ...  
  
  ...

{code}

This config is created when I run "cordova plugin add 
./custom_plugins/cordova-plugin-xxx" and everything works as expected. But, if 
you delete the plugin from the plugins folder and try to run "cordova prepare" 
afterwards it will fail with the following message:
{code}
Failed to restore plugin "cordova-plugin-x" from config.xml. You might need to 
try adding it again. Error: Failed to fetch plugin 
cordova-plugin-x@file:custom_plugins/cordova-plugin-x via registry.
{code}


> Inconsistent behavior between "cordova prepare" and "cordova plugin add" when 
> installing plugin from local folder
> -
>
> Key: CB-12918
> URL: https://issues.apache.org/jira/browse/CB-12918
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Max Mednik
>  Labels: cordova-8.0.0
>
> Running "cordova prepare" and "cordova plugin add" handle plugin installation 
> from a local folder differently and either one or another breaks depending on 
> which one used first. 
> For example, I have a plugin defined as following in the config.xml:
> {code}
> 
>   ...  
>spec="./custom_plugins/cordova-plugin-ios-no-export-compliance" />
>   ...
> 
> {code}
> This config is created when I run "cordova plugin add 
> ./custom_plugins/cordova-plugin-ios-no-export-compliance" and everything 
> works as expected. But, if you delete the plugin from the plugins folder and 
> try to run "cordova prepare" afterwards it will fail with the following 
> message:
> {code}
> Discovered plugin "cordova-plugin-ios-no-export-compliance" in config.xml. 
> Adding it to the project
> Failed to restore plugin "cordova-plugin-ios-no-export-compliance" from 
> config.xml. You might need to try adding it again. Error: Failed to fetch 
> plugin 
> cordova-plugin-ios-no-export-compliance@file:custom_plugins/cordova-plugin-ios-no-export-compliance
>  via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm ERR! addLocal Could not install [project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
> npm ERR! path [project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
> npm ERR! code ENOENT
> npm ERR! errno -2
> npm ERR! syscall open
> npm ERR! enoent ENOENT: no such file or directory, open '[project 
> path]/node_modules/custom_plugins/co

[jira] [Updated] (CB-12918) Inconsistent behavior between "cordova prepare" and "cordova plugin add" when installing plugin from local folder

2017-09-13 Thread Max Mednik (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Mednik updated CB-12918:

Attachment: custom_plugins.zip

Adding plugin for reference

> Inconsistent behavior between "cordova prepare" and "cordova plugin add" when 
> installing plugin from local folder
> -
>
> Key: CB-12918
> URL: https://issues.apache.org/jira/browse/CB-12918
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Max Mednik
>  Labels: cordova-8.0.0
> Attachments: custom_plugins.zip
>
>
> Running "cordova prepare" and "cordova plugin add" handle plugin installation 
> from a local folder differently and either one or another breaks depending on 
> which one used first. 
> For example, I have a plugin defined as following in the config.xml:
> {code}
> 
>   ...  
>spec="./custom_plugins/cordova-plugin-ios-no-export-compliance" />
>   ...
> 
> {code}
> This config is created when I run "cordova plugin add 
> ./custom_plugins/cordova-plugin-ios-no-export-compliance" and everything 
> works as expected. But, if you delete the plugin from the plugins folder and 
> try to run "cordova prepare" afterwards it will fail with the following 
> message:
> {code}
> Discovered plugin "cordova-plugin-ios-no-export-compliance" in config.xml. 
> Adding it to the project
> Failed to restore plugin "cordova-plugin-ios-no-export-compliance" from 
> config.xml. You might need to try adding it again. Error: Failed to fetch 
> plugin 
> cordova-plugin-ios-no-export-compliance@file:custom_plugins/cordova-plugin-ios-no-export-compliance
>  via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm ERR! addLocal Could not install [project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
> npm ERR! path [project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
> npm ERR! code ENOENT
> npm ERR! errno -2
> npm ERR! syscall open
> npm ERR! enoent ENOENT: no such file or directory, open '[project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a file.
> npm ERR! enoent
> {code}
> Also, after running "cordova prepare" the plugin entry in the config.xml was 
> changed to: 
> {code}
>  spec="file:custom_plugins/cordova-plugin-ios-no-export-compliance" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13170) final changes and release of post-integration cordova-plugin-console

2017-09-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164457#comment-16164457
 ] 

ASF GitHub Bot commented on CB-13170:
-

Github user janpio commented on the issue:

https://github.com/apache/cordova-plugin-console/pull/25
  
Nice. 

Does this mean that the 2.0.0 of the console plugin can be installed on 
`cordova-ios` 4.5.0 without causing the build problems?


> final changes and release of post-integration cordova-plugin-console
> 
>
> Key: CB-13170
> URL: https://issues.apache.org/jira/browse/CB-13170
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-console (DEPRECATED)
>Reporter: Filip Maj
>Assignee: Shazron Abdullah
>  Labels: plugins-next
>
> 1. add an {{}} constraint to {{plugin.xml}}, and to 
> {{cordovaDependencies}} in {{package.json}}, capping cordova-ios and 
> cordova-windows support
> 2. bump version
> 3. Update README.md to reflect maintenance status. Direct users to file 
> bugs/prs to the platforms that integrate the plugin
> 4. do a final release
> 5. {{npm deprecate}} the plugin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13271) put a patch in the cordova-android project to solve the fragmentation and performance problems in the cordova application on android platform

2017-09-13 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164460#comment-16164460
 ] 

Jan Piotrowski (Sujan) commented on CB-13271:
-

Is there any English language information about this "x5 kernel" available 
anywhere? 
I could only find Chinese pages that Google translate can't really handle :/

> put a patch in the cordova-android project to solve the fragmentation and 
> performance problems in the cordova application on android platform
> -
>
> Key: CB-13271
> URL: https://issues.apache.org/jira/browse/CB-13271
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova@7.0.0
>Reporter: liuzheng
>Assignee: Joe Bowser
>  Labels: patch
>
>   We want to put a patch in the cordova-android project to solve the 
> fragmentation and performance problems in the cordova application on android 
> platform , hoping to be supported by the Cordoba project team.
> Recently, many cordova application developers feedback to Tencent's 
> X5 kernel team (Tencent browsing service) , hope cordova-android can support 
> the use of x5 kernel to solve the fragmentation of the android system and 
> performance problems.
> X5 kernel is developed based on the blink core, which is aimed at 
> solving android fragmentation and performance issues. It is well compatible 
> with android version of the system and give users a more smooth browsing 
> experience. The current number of applications using x5 core exceed 20,000, 
> the number of active users has more than 700 million.
>   
> 
>   
>  Looking forward to your reply!
>   
> Email: aczheng...@tencent.com



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Issue Comment Deleted] (CB-12918) Inconsistent behavior between "cordova prepare" and "cordova plugin add" when installing plugin from local folder

2017-09-13 Thread Max Mednik (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Mednik updated CB-12918:

Comment: was deleted

(was: Sorry, can't reproduce any longer.)

> Inconsistent behavior between "cordova prepare" and "cordova plugin add" when 
> installing plugin from local folder
> -
>
> Key: CB-12918
> URL: https://issues.apache.org/jira/browse/CB-12918
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Max Mednik
>  Labels: cordova-8.0.0
> Attachments: custom_plugins.zip
>
>
> Running "cordova prepare" and "cordova plugin add" handle plugin installation 
> from a local folder differently and either one or another breaks depending on 
> which one used first. 
> For example, I have a plugin defined as following in the config.xml:
> {code}
> 
>   ...  
>spec="./custom_plugins/cordova-plugin-ios-no-export-compliance" />
>   ...
> 
> {code}
> This config is created when I run "cordova plugin add 
> ./custom_plugins/cordova-plugin-ios-no-export-compliance" and everything 
> works as expected. But, if you delete the plugin from the plugins folder and 
> try to run "cordova prepare" afterwards it will fail with the following 
> message:
> {code}
> Discovered plugin "cordova-plugin-ios-no-export-compliance" in config.xml. 
> Adding it to the project
> Failed to restore plugin "cordova-plugin-ios-no-export-compliance" from 
> config.xml. You might need to try adding it again. Error: Failed to fetch 
> plugin 
> cordova-plugin-ios-no-export-compliance@file:custom_plugins/cordova-plugin-ios-no-export-compliance
>  via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm ERR! addLocal Could not install [project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
> npm ERR! path [project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance
> npm ERR! code ENOENT
> npm ERR! errno -2
> npm ERR! syscall open
> npm ERR! enoent ENOENT: no such file or directory, open '[project 
> path]/node_modules/custom_plugins/cordova-plugin-ios-no-export-compliance'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a file.
> npm ERR! enoent
> {code}
> Also, after running "cordova prepare" the plugin entry in the config.xml was 
> changed to: 
> {code}
>  spec="file:custom_plugins/cordova-plugin-ios-no-export-compliance" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13272) Doesn't load config.xml if app is loaded from a subdirectory

2017-09-13 Thread Brad Gies (JIRA)
Brad Gies created CB-13272:
--

 Summary: Doesn't load config.xml if app is loaded from a 
subdirectory
 Key: CB-13272
 URL: https://issues.apache.org/jira/browse/CB-13272
 Project: Apache Cordova
  Issue Type: Bug
  Components: AllPlugins
Affects Versions: cordova@7.0.0
 Environment: Ionic CLI: 3.10.1
Cordova CLI: 7.0.1
Node: 7.2.1
Cordova Platforms: android 6.1.2 browser 4.1.0

Reporter: Brad Gies
Priority: Minor


After uploading an app to a subdirectory of the website public root IE... 
mydomain.com/store/config.xml the app attempts to load the config.xml from the 
public root IE. mydomain.com/config.xml.

Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
cordova build browser --prod --release" 

In my uploaded app, the offending line was this one (line 875 in my file, 
function readConfig)

try {
xhr.open("get", "/config.xml", true);
xhr.send();
} catch(e) {
fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
JSON.stringify(e));
}

I could list the URL to view the error here, but that app will change often, 
and it's easy to reproduce. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13272) Doesn't load config.xml if app is loaded from a subdirectory

2017-09-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13272:

Component/s: (was: AllPlugins)
 cordova-browser

> Doesn't load config.xml if app is loaded from a subdirectory
> 
>
> Key: CB-13272
> URL: https://issues.apache.org/jira/browse/CB-13272
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser
>Affects Versions: cordova@7.0.0
> Environment: Ionic CLI: 3.10.1
> Cordova CLI: 7.0.1
> Node: 7.2.1
> Cordova Platforms: android 6.1.2 browser 4.1.0
>Reporter: Brad Gies
>Priority: Minor
>
> After uploading an app to a subdirectory of the website public root IE... 
> mydomain.com/store/config.xml the app attempts to load the config.xml from 
> the public root IE. mydomain.com/config.xml.
> Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
> cordova build browser --prod --release" 
> In my uploaded app, the offending line was this one (line 875 in my file, 
> function readConfig)
> try {
> xhr.open("get", "/config.xml", true);
> xhr.send();
> } catch(e) {
> fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
> JSON.stringify(e));
> }
> I could list the URL to view the error here, but that app will change often, 
> and it's easy to reproduce. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Assigned] (CB-13272) Doesn't load config.xml if app is loaded from a subdirectory

2017-09-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) reassigned CB-13272:
---

Assignee: Jan Piotrowski (Sujan)

> Doesn't load config.xml if app is loaded from a subdirectory
> 
>
> Key: CB-13272
> URL: https://issues.apache.org/jira/browse/CB-13272
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser
>Affects Versions: cordova@7.0.0
> Environment: Ionic CLI: 3.10.1
> Cordova CLI: 7.0.1
> Node: 7.2.1
> Cordova Platforms: android 6.1.2 browser 4.1.0
>Reporter: Brad Gies
>Assignee: Jan Piotrowski (Sujan)
>Priority: Minor
>
> After uploading an app to a subdirectory of the website public root IE... 
> mydomain.com/store/config.xml the app attempts to load the config.xml from 
> the public root IE. mydomain.com/config.xml.
> Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
> cordova build browser --prod --release" 
> In my uploaded app, the offending line was this one (line 875 in my file, 
> function readConfig)
> try {
> xhr.open("get", "/config.xml", true);
> xhr.send();
> } catch(e) {
> fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
> JSON.stringify(e));
> }
> I could list the URL to view the error here, but that app will change often, 
> and it's easy to reproduce. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13272) Doesn't load config.xml if app is loaded from a subdirectory

2017-09-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13272:

Description: 
After uploading an app to a subdirectory of a domain i.e. mydomain.com/store/ 
the app attempts to load the config.xml from the public root i.e. 
mydomain.com/config.xml instead of mydomain.com/store/config.xml

Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
cordova build browser --prod --release" 

In my uploaded app, the offending line was this one (line 875 in my file, 
function readConfig)

{code}
try {
xhr.open("get", "/config.xml", true);
xhr.send();
} catch(e) {
fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
JSON.stringify(e));
}
{code}

Same function on Github:
https://github.com/apache/cordova-browser/blob/f5df89f99302263fb149c6cec3f5168c0e3c4192/cordova-lib/cordova.js#L894
https://github.com/apache/cordova-browser/blob/dfa40a685780da5aff9965bd54aafec177113abc/cordova-js-src/confighelper.js#L69

I could list the URL to view the error here, but that app will change often, 
and it's easy to reproduce. 

  was:
After uploading an app to a subdirectory of the website public root IE... 
mydomain.com/store/config.xml the app attempts to load the config.xml from the 
public root IE. mydomain.com/config.xml.

Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
cordova build browser --prod --release" 

In my uploaded app, the offending line was this one (line 875 in my file, 
function readConfig)

try {
xhr.open("get", "/config.xml", true);
xhr.send();
} catch(e) {
fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
JSON.stringify(e));
}

I could list the URL to view the error here, but that app will change often, 
and it's easy to reproduce. 


> Doesn't load config.xml if app is loaded from a subdirectory
> 
>
> Key: CB-13272
> URL: https://issues.apache.org/jira/browse/CB-13272
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser
>Affects Versions: cordova@7.0.0
> Environment: Ionic CLI: 3.10.1
> Cordova CLI: 7.0.1
> Node: 7.2.1
> Cordova Platforms: android 6.1.2 browser 4.1.0
>Reporter: Brad Gies
>Assignee: Jan Piotrowski (Sujan)
>Priority: Minor
>
> After uploading an app to a subdirectory of a domain i.e. mydomain.com/store/ 
> the app attempts to load the config.xml from the public root i.e. 
> mydomain.com/config.xml instead of mydomain.com/store/config.xml
> Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
> cordova build browser --prod --release" 
> In my uploaded app, the offending line was this one (line 875 in my file, 
> function readConfig)
> {code}
> try {
> xhr.open("get", "/config.xml", true);
> xhr.send();
> } catch(e) {
> fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
> JSON.stringify(e));
> }
> {code}
> Same function on Github:
> https://github.com/apache/cordova-browser/blob/f5df89f99302263fb149c6cec3f5168c0e3c4192/cordova-lib/cordova.js#L894
> https://github.com/apache/cordova-browser/blob/dfa40a685780da5aff9965bd54aafec177113abc/cordova-js-src/confighelper.js#L69
> I could list the URL to view the error here, but that app will change often, 
> and it's easy to reproduce. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13272) Doesn't load config.xml if app is loaded from a subdirectory

2017-09-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13272:

Description: 
After uploading an app to a subdirectory of a domain i.e. mydomain.com/store/ 
the app attempts to load the config.xml from the public root i.e. 
mydomain.com/config.xml instead of mydomain.com/store/config.xml

Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
cordova build browser --prod --release" 

In my uploaded app, the offending line was here: 
(line 875 in my file, function readConfig)

{code}
try {
xhr.open("get", "/config.xml", true);
xhr.send();
} catch(e) {
fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
JSON.stringify(e));
}
{code}

Same function on Github:
https://github.com/apache/cordova-browser/blob/f5df89f99302263fb149c6cec3f5168c0e3c4192/cordova-lib/cordova.js#L894
https://github.com/apache/cordova-browser/blob/dfa40a685780da5aff9965bd54aafec177113abc/cordova-js-src/confighelper.js#L69

I could list the URL to view the error here, but that app will change often, 
and it's easy to reproduce. 

  was:
After uploading an app to a subdirectory of a domain i.e. mydomain.com/store/ 
the app attempts to load the config.xml from the public root i.e. 
mydomain.com/config.xml instead of mydomain.com/store/config.xml

Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
cordova build browser --prod --release" 

In my uploaded app, the offending line was this one (line 875 in my file, 
function readConfig)

{code}
try {
xhr.open("get", "/config.xml", true);
xhr.send();
} catch(e) {
fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
JSON.stringify(e));
}
{code}

Same function on Github:
https://github.com/apache/cordova-browser/blob/f5df89f99302263fb149c6cec3f5168c0e3c4192/cordova-lib/cordova.js#L894
https://github.com/apache/cordova-browser/blob/dfa40a685780da5aff9965bd54aafec177113abc/cordova-js-src/confighelper.js#L69

I could list the URL to view the error here, but that app will change often, 
and it's easy to reproduce. 


> Doesn't load config.xml if app is loaded from a subdirectory
> 
>
> Key: CB-13272
> URL: https://issues.apache.org/jira/browse/CB-13272
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser
>Affects Versions: cordova@7.0.0
> Environment: Ionic CLI: 3.10.1
> Cordova CLI: 7.0.1
> Node: 7.2.1
> Cordova Platforms: android 6.1.2 browser 4.1.0
>Reporter: Brad Gies
>Assignee: Jan Piotrowski (Sujan)
>Priority: Minor
>
> After uploading an app to a subdirectory of a domain i.e. mydomain.com/store/ 
> the app attempts to load the config.xml from the public root i.e. 
> mydomain.com/config.xml instead of mydomain.com/store/config.xml
> Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
> cordova build browser --prod --release" 
> In my uploaded app, the offending line was here: 
> (line 875 in my file, function readConfig)
> {code}
> try {
> xhr.open("get", "/config.xml", true);
> xhr.send();
> } catch(e) {
> fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
> JSON.stringify(e));
> }
> {code}
> Same function on Github:
> https://github.com/apache/cordova-browser/blob/f5df89f99302263fb149c6cec3f5168c0e3c4192/cordova-lib/cordova.js#L894
> https://github.com/apache/cordova-browser/blob/dfa40a685780da5aff9965bd54aafec177113abc/cordova-js-src/confighelper.js#L69
> I could list the URL to view the error here, but that app will change often, 
> and it's easy to reproduce. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13272) Doesn't load config.xml if app is loaded from a subdirectory

2017-09-13 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) updated CB-13272:

Environment: 
Cordova CLI: 7.0.1
Node: 7.2.1
Cordova Platforms: android 6.1.2 browser 4.1.0
Ionic CLI: 3.10.1

  was:
Ionic CLI: 3.10.1
Cordova CLI: 7.0.1
Node: 7.2.1
Cordova Platforms: android 6.1.2 browser 4.1.0



> Doesn't load config.xml if app is loaded from a subdirectory
> 
>
> Key: CB-13272
> URL: https://issues.apache.org/jira/browse/CB-13272
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser
>Affects Versions: cordova@7.0.0
> Environment: Cordova CLI: 7.0.1
> Node: 7.2.1
> Cordova Platforms: android 6.1.2 browser 4.1.0
> Ionic CLI: 3.10.1
>Reporter: Brad Gies
>Assignee: Jan Piotrowski (Sujan)
>Priority: Minor
>
> After uploading an app to a subdirectory of a domain i.e. mydomain.com/store/ 
> the app attempts to load the config.xml from the public root i.e. 
> mydomain.com/config.xml instead of mydomain.com/store/config.xml
> Note this is an Ionic 3/Angular 4 app, and built using the command "ionic 
> cordova build browser --prod --release" 
> In my uploaded app, the offending line was here: 
> (line 875 in my file, function readConfig)
> {code}
> try {
> xhr.open("get", "/config.xml", true);
> xhr.send();
> } catch(e) {
> fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' + 
> JSON.stringify(e));
> }
> {code}
> Same function on Github:
> https://github.com/apache/cordova-browser/blob/f5df89f99302263fb149c6cec3f5168c0e3c4192/cordova-lib/cordova.js#L894
> https://github.com/apache/cordova-browser/blob/dfa40a685780da5aff9965bd54aafec177113abc/cordova-js-src/confighelper.js#L69
> I could list the URL to view the error here, but that app will change often, 
> and it's easy to reproduce. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12367) Modernize styling of iOS InAppBrowser view

2017-09-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164755#comment-16164755
 ] 

ASF GitHub Bot commented on CB-12367:
-

Github user artyom-dorokhov commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/210
  
i'd love to have it merged. current version of inappbrowser with its 
styling looks like from 90's


> Modernize styling of iOS InAppBrowser view
> --
>
> Key: CB-12367
> URL: https://issues.apache.org/jira/browse/CB-12367
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 1.6.1
>Reporter: Reid Beels
>
> I've been working on a branch that brings several visual and configuration 
> improvements to the iOS InAppBrowser view, along with a little refactoring of 
> the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method 
> into several smaller helper methods to handle the creation of individual 
> subviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of 
> background color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to 
> {{UIBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} or 
> {{black}}
> * sets the status bar style and background color to match the 
> {{toolbarstyle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (◄►) with drawn arrows that match 
> those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like 
> {{F8A027}}. If not provided, or set to {{default}}, controls will be rendered 
> in the default iOS blue, or in white when {{toolbarstyle=black}} is set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12367) Modernize styling of iOS InAppBrowser view

2017-09-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164848#comment-16164848
 ] 

ASF GitHub Bot commented on CB-12367:
-

Github user timbru31 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/210
  
@artyom-dorokhov you might want to check out 
https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller


> Modernize styling of iOS InAppBrowser view
> --
>
> Key: CB-12367
> URL: https://issues.apache.org/jira/browse/CB-12367
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 1.6.1
>Reporter: Reid Beels
>
> I've been working on a branch that brings several visual and configuration 
> improvements to the iOS InAppBrowser view, along with a little refactoring of 
> the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method 
> into several smaller helper methods to handle the creation of individual 
> subviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of 
> background color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to 
> {{UIBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} or 
> {{black}}
> * sets the status bar style and background color to match the 
> {{toolbarstyle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (◄►) with drawn arrows that match 
> those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like 
> {{F8A027}}. If not provided, or set to {{default}}, controls will be rendered 
> in the default iOS blue, or in white when {{toolbarstyle=black}} is set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12367) Modernize styling of iOS InAppBrowser view

2017-09-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164868#comment-16164868
 ] 

ASF GitHub Bot commented on CB-12367:
-

Github user artyom-dorokhov commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/210
  
@timbru31 thanks for the tip, but inappbrowser can inject js/css on a 
third-party page and it's the main point of using it.


> Modernize styling of iOS InAppBrowser view
> --
>
> Key: CB-12367
> URL: https://issues.apache.org/jira/browse/CB-12367
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 1.6.1
>Reporter: Reid Beels
>
> I've been working on a branch that brings several visual and configuration 
> improvements to the iOS InAppBrowser view, along with a little refactoring of 
> the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method 
> into several smaller helper methods to handle the creation of individual 
> subviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of 
> background color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to 
> {{UIBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} or 
> {{black}}
> * sets the status bar style and background color to match the 
> {{toolbarstyle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (◄►) with drawn arrows that match 
> those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like 
> {{F8A027}}. If not provided, or set to {{default}}, controls will be rendered 
> in the default iOS blue, or in white when {{toolbarstyle=black}} is set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)
Dave Alden created CB-13273:
---

 Summary: Webview is sized incorrectly on iPhone X (Simulator)
 Key: CB-13273
 URL: https://issues.apache.org/jira/browse/CB-13273
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-ios
Affects Versions: cordova-ios 4.5.0
 Environment: Xcode 9.0 (9A235)
Simulator 10.0 (SimulatorApp-829.6) - iPhone X
Reporter: Dave Alden
Assignee: Shazron Abdullah


New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving white bars above and below the 
Webview frame.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
frame is sized correctly.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Description: 
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving white bars above and below the 
Webview frame.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
frame is sized correctly.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

Attached Cordova project illustrates the issue.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


  was:
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving white bars above and below the 
Webview frame.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
frame is sized correctly.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Attachment: webview-test.zip

Cordova project which illustrates the issue

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Issue Comment Deleted] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Comment: was deleted

(was: Cordova project which illustrates the issue)

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files

2017-09-13 Thread Audrey So (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So updated CB-13274:
---
Affects Version/s: (was: @7)
   cordova7

> Update cordova README.md docs with eslint changes and cleanup/remove old 
> jshint files
> -
>
> Key: CB-13274
> URL: https://issues.apache.org/jira/browse/CB-13274
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-lib
>Affects Versions: cordova7
>Reporter: Audrey So
>Assignee: Audrey So
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files

2017-09-13 Thread Audrey So (JIRA)
Audrey So created CB-13274:
--

 Summary: Update cordova README.md docs with eslint changes and 
cleanup/remove old jshint files
 Key: CB-13274
 URL: https://issues.apache.org/jira/browse/CB-13274
 Project: Apache Cordova
  Issue Type: Task
  Components: cordova-lib
Affects Versions: @7
Reporter: Audrey So
Assignee: Audrey So
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files

2017-09-13 Thread Audrey So (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So updated CB-13274:
---
Description: 
Docs needs to be updated with latest eslint changes
Old jshint & jshint ignore files can be removed

> Update cordova README.md docs with eslint changes and cleanup/remove old 
> jshint files
> -
>
> Key: CB-13274
> URL: https://issues.apache.org/jira/browse/CB-13274
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-lib
>Affects Versions: cordova7
>Reporter: Audrey So
>Assignee: Audrey So
>Priority: Minor
>
> Docs needs to be updated with latest eslint changes
> Old jshint & jshint ignore files can be removed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files

2017-09-13 Thread Audrey So (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So updated CB-13274:
---
Description: 
Docs needs to be updated with latest eslint changes
Old jshint & jshint ignore files can be removed & any references to jshint

  was:
Docs needs to be updated with latest eslint changes
Old jshint & jshint ignore files can be removed


> Update cordova README.md docs with eslint changes and cleanup/remove old 
> jshint files
> -
>
> Key: CB-13274
> URL: https://issues.apache.org/jira/browse/CB-13274
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-lib
>Affects Versions: cordova7
>Reporter: Audrey So
>Assignee: Audrey So
>Priority: Minor
>
> Docs needs to be updated with latest eslint changes
> Old jshint & jshint ignore files can be removed & any references to jshint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13254) node 4 with cordova-cli causes platform add issues

2017-09-13 Thread Steve Gill (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill updated CB-13254:

Labels: tools-next  (was: )

> node 4 with cordova-cli causes platform add issues
> --
>
> Key: CB-13254
> URL: https://issues.apache.org/jira/browse/CB-13254
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Reporter: Shazron Abdullah
>  Labels: tools-next
>
> From [~jcesarmobile] in dev@:
> {code}
> I'm trying to do cordova platform add
> https://github.com/apache/cordova-ios#4.5.0 and getting this error
> Using CLI 7.0.1:
> cordova platform add https://github.com/apache/cordova-ios#4.5.0
> Using cordova-fetch for https://github.com/apache/cordova-ios#4.5.0
> Adding ios project...
>  Using this version of Cordova with older version of cordova-ios is
> deprecated. Upgrade to cordova-ios@4.0.0 or newer.
> Error: Your ios platform does not have Api.js
> Using nightly CLI:
> cordova platform add https://github.com/apache/cordova-ios#4.5.0
> Warning: using prerelease version 7.0.2-nightly.2017.9.7.596da5df
> (cordova-lib@7.0.2-nightly.2017.9.7.6f5be6a7)
> Using cordova-fetch for https://github.com/apache/cordova-ios#4.5.0
> Adding ios project...
> Unable to load PlatformApi from platform. Error: Cannot find module 'unorm'
> Error: Uncaught, unspecified "error" event. (The platform "ios" does not
> appear to be a valid cordova platform. It is missing API.js. ios not
> supported.)
> node -v
> v4.4.7
> npm -v
> 2.15.8
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org