[jira] [Commented] (CB-13236) SVG image via object tag will not be shown on iOS
[ https://issues.apache.org/jira/browse/CB-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167440#comment-16167440 ] Bernhard Eckl commented on CB-13236: I just did that, no console errors. But I can see in the inspector that the svg is not correctly loaded into the html, when I unfold the object tag I can see . The same html page opened via Safari and the svg is working fine. > SVG image via object tag will not be shown on iOS > - > > Key: CB-13236 > URL: https://issues.apache.org/jira/browse/CB-13236 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0 >Reporter: Bernhard Eckl >Assignee: Shazron Abdullah > Labels: backlog > > I have svg images via object tag in a cordova app loaded via https request > (object and not just img tag because I want to use webfonts in the svg). On > iOS the svg is not shown, on Android it works fine. The same via Safari or > via Inappbrowser works fine. Only when using it in a Cordova app it won’t > show the svg. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Smirnov updated CB-13273:
Attachment: fig1.png
fig2.png
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Smirnov updated CB-13273:
Attachment: fig1.png
fig2.png
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig1.png, fig2.png, fig2.png, Simulator Screen
> Shot - iPhone X - 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167523#comment-16167523
]
Sergey Smirnov commented on CB-13273:
-
Got it to work:
1. First of all add new image(s) for iPhone X into Images.xcassets /
LaunchImage, here is the snippet for Content.json of portrait one:
{noformat}
{
"orientation" : "portrait",
"idiom" : "iphone",
"extent" : "full-screen",
"minimum-system-version" : "11.0",
"filename" : "DUNNO_HOW_TO_NAME_IT.png",
"subtype" : "2436h",
"scale" : "3x"
},
{noformat}
Image size should be 1125x2436 (375x812 at 3x)
2. Add new Safe area feature to the CDVLaunchScreen.storyboard. Apple tells
that it is safe, as on previous iOS versions it will fall back to defaults.
2.1 Check "Use Safe Area Laout Guide" at Interface Builder Document;
2.2 Edit constraints: LaunchStoryboard's bottom, leading and trailing to Safe
Area ones, top should be set to Superview.top (by default) or to Safe Area.top.
After that you will something close to Fig1 - use of almost all area, but with
status bar safe area.
!fig1.png|thumbnail!
If you want to move forward and use the whole screen area:
3. Add viewport-fit=cover to your viewport meta tag.
4. Use cordova-plugin-statusbar with a little bit of patching - it has a
hardcoded statubar height. The new one for X is 44. So you can use something
close to the following at resizeWebView method:
{noformat}
CGFloat defaultStatusbarHeight = 20;
if (IsAtLeastiOSVersion(@"11.0") && height == 44) {
defaultStatusbarHeight = 44;
}
if (!self.statusBarOverlaysWebView) { ...
{noformat}
and replace all "20"-s with "defaultStatusbarHeight".
Also it seems that "statusbar overlay webview" case now requires the increment
of height for webview:
{noformat}
if (IsAtLeastiOSVersion(@"11.0") && height == 44) {
frame.size.height += defaultStatusbarHeight;
}
{noformat}
After that you will something close to Fig2.
!fig2.png|thumbnail!
PS: cordova-plugin-splashscreen requires some patching too - atm it references
to wrong image. Make some patches to support X, but the plugin cannot find an
image. Please, point me to the right image referencing...
PPS: tested for WKWebView (cordova-plugin-wkwebview-engine) only.
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig1.png, fig2.png, fig2.png, Simulator Screen
> Shot - iPhone X - 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Smirnov updated CB-13273:
Attachment: (was: fig2.png)
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig1.png, fig2.png, Simulator Screen Shot -
> iPhone X - 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Smirnov updated CB-13273:
Attachment: fig2.png
fig1.png
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig1.png, fig2.png, Simulator Screen Shot -
> iPhone X - 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Smirnov updated CB-13273:
Attachment: (was: fig2.png)
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig1.png, fig2.png, Simulator Screen Shot -
> iPhone X - 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Smirnov updated CB-13273:
Attachment: (was: fig1.png)
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig1.png, fig2.png, Simulator Screen Shot -
> iPhone X - 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Smirnov updated CB-13273:
Attachment: (was: fig1.png)
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167526#comment-16167526
]
Dave Alden commented on CB-13273:
-
Thanks Darryl, I've tried this out with a LaunchStoryboard using
cordova-plugin-splashscreen with the following in config.xml and, in
combination with viewport-fit and safe-area-inset-*, it resolves the issue.
{code:xml}
{code}
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Alden updated CB-13273:
Attachment: Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167526#comment-16167526
]
Dave Alden edited comment on CB-13273 at 9/15/17 8:28 AM:
--
Thanks Darryl, I've tried this out with a LaunchStoryboard using
cordova-plugin-splashscreen with the following in config.xml and, in
combination with viewport-fit and safe-area-inset-*, it resolves the issue.
{code:xml}
{code}
[^Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png]
was (Author: dpa99c):
Thanks Darryl, I've tried this out with a LaunchStoryboard using
cordova-plugin-splashscreen with the following in config.xml and, in
combination with viewport-fit and safe-area-inset-*, it resolves the issue.
{code:xml}
{code}
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167526#comment-16167526
]
Dave Alden edited comment on CB-13273 at 9/15/17 8:29 AM:
--
Thanks Darryl, I've tried this out with a LaunchStoryboard using
cordova-plugin-splashscreen with the following in config.xml and, in
combination with viewport-fit and safe-area-inset-*, it resolves the issue.
{code:xml}
{code}
[^Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png]
was (Author: dpa99c):
Thanks Darryl, I've tried this out with a LaunchStoryboard using
cordova-plugin-splashscreen with the following in config.xml and, in
combination with viewport-fit and safe-area-inset-*, it resolves the issue.
{code:xml}
{code}
[^Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png]
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167523#comment-16167523
]
Sergey Smirnov edited comment on CB-13273 at 9/15/17 8:29 AM:
--
Got it to work:
1. First of all add new image(s) for iPhone X into Images.xcassets /
LaunchImage, here is the snippet for Content.json of portrait one:
{noformat}
{
"orientation" : "portrait",
"idiom" : "iphone",
"extent" : "full-screen",
"minimum-system-version" : "11.0",
"filename" : "DUNNO_HOW_TO_NAME_IT.png",
"subtype" : "2436h",
"scale" : "3x"
},
{noformat}
Image size should be 1125x2436 (375x812 at 3x)
2. Add new Safe area feature to the CDVLaunchScreen.storyboard. Apple tells
that it is safe, as on previous iOS versions it will fall back to defaults.
2.1 Check "Use Safe Area Laout Guide" at Interface Builder Document;
2.2 Edit constraints: LaunchStoryboard's bottom, leading and trailing to Safe
Area ones, top should be set to Superview.top (by default) or to Safe Area.top.
After that you will something close to Fig1 - use of almost all area, but with
status bar safe area.
!fig1.png|thumbnail!
If you want to move forward and use the whole screen area:
3. Add viewport-fit=cover to your viewport meta tag.
4. Use cordova-plugin-statusbar with a little bit of patching - it has a
hardcoded statubar height. The new one for X is 44. So you can use something
close to the following at resizeWebView method:
{noformat}
CGFloat defaultStatusbarHeight = 20;
if (IsAtLeastiOSVersion(@"11.0") && height == 44) {
defaultStatusbarHeight = 44;
}
if (!self.statusBarOverlaysWebView) { ...
{noformat}
and replace all "20"-s with "defaultStatusbarHeight".
Also it seems that "statusbar overlay webview" case now requires the increment
of height for webview:
{noformat}
if (IsAtLeastiOSVersion(@"11.0") && height == 44) {
frame.size.height += defaultStatusbarHeight;
}
{noformat}
After that you will something close to Fig2 - the whole screen is used.
!fig2.png|thumbnail!
PS: cordova-plugin-splashscreen requires some patching too - atm it references
to wrong image. Make some patches to support X, but the plugin cannot find an
image. Please, point me to the right image referencing...
PPS: tested for WKWebView (cordova-plugin-wkwebview-engine) only.
was (Author: smirnoff):
Got it to work:
1. First of all add new image(s) for iPhone X into Images.xcassets /
LaunchImage, here is the snippet for Content.json of portrait one:
{noformat}
{
"orientation" : "portrait",
"idiom" : "iphone",
"extent" : "full-screen",
"minimum-system-version" : "11.0",
"filename" : "DUNNO_HOW_TO_NAME_IT.png",
"subtype" : "2436h",
"scale" : "3x"
},
{noformat}
Image size should be 1125x2436 (375x812 at 3x)
2. Add new Safe area feature to the CDVLaunchScreen.storyboard. Apple tells
that it is safe, as on previous iOS versions it will fall back to defaults.
2.1 Check "Use Safe Area Laout Guide" at Interface Builder Document;
2.2 Edit constraints: LaunchStoryboard's bottom, leading and trailing to Safe
Area ones, top should be set to Superview.top (by default) or to Safe Area.top.
After that you will something close to Fig1 - use of almost all area, but with
status bar safe area.
!fig1.png|thumbnail!
If you want to move forward and use the whole screen area:
3. Add viewport-fit=cover to your viewport meta tag.
4. Use cordova-plugin-statusbar with a little bit of patching - it has a
hardcoded statubar height. The new one for X is 44. So you can use something
close to the following at resizeWebView method:
{noformat}
CGFloat defaultStatusbarHeight = 20;
if (IsAtLeastiOSVersion(@"11.0") && height == 44) {
defaultStatusbarHeight = 44;
}
if (!self.statusBarOverlaysWebView) { ...
{noformat}
and replace all "20"-s with "defaultStatusbarHeight".
Also it seems that "statusbar overlay webview" case now requires the increment
of height for webview:
{noformat}
if (IsAtLeastiOSVersion(@"11.0") && height == 44) {
frame.size.height += defaultStatusbarHeight;
}
{noformat}
After that you will something close to Fig2.
!fig2.png|thumbnail!
PS: cordova-plugin-splashscreen requires some patching too - atm it references
to wrong image. Make some patches to support X, but the plugin cannot find an
image. Please, point me to the right image referencing...
PPS: tested for WKWebView (cordova-plugin-wkwebview-engine) only.
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Co
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Alden updated CB-13273:
Attachment: (was: webview-test.zip)
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Alden updated CB-13273:
Attachment: webview-test.zip
Updated project with LaunchStoryboard config and images attached
[^webview-test.zip]
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Alden resolved CB-13273.
-
Resolution: Not A Bug
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167554#comment-16167554
]
Dave Alden commented on CB-13273:
-
If you land up here looking for a solution, see my stackoverflow answer:
https://stackoverflow.com/a/46232813/777265
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13283) Fetching of download counts fails on plugins.cordova.io
[
https://issues.apache.org/jira/browse/CB-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) reassigned CB-13283:
---
Assignee: Tommy-Carlos Williams
> Fetching of download counts fails on plugins.cordova.io
> ---
>
> Key: CB-13283
> URL: https://issues.apache.org/jira/browse/CB-13283
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
> Environment: All
>Reporter: Tommy-Carlos Williams
>Assignee: Tommy-Carlos Williams
>
> The batched fetching of download counts for returned plugins fails for any
> requests that contain scoped packages thus blocking the "sort by downloads"
> from ever appearing and spewing GET errors into the console.
> This is due to npmjs not supporting scoped packages in bulk lookups:
> {code:javascript}
> {"error":"scoped packages are not currently supported in bulk lookups"}
> {code}
> I propose we filter out scoped packages from the bulk lookups. At least then
> we will get download counts for the packages that are supported in bulk
> lookups.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13284) Slack js on cordova-docs fails to load due to insecure response
[
https://issues.apache.org/jira/browse/CB-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167662#comment-16167662
]
Jan Piotrowski (Sujan) commented on CB-13284:
-
slackin.js is used to display a badge for Slack:
!https://cldup.com/IaiPnDEAA6.gif!
Source: https://github.com/rauchg/slackin#realtime-demo
There is also a static version that doesn't require loading JS:
!https://cldup.com/jWUT4QFLnq.png!
https://github.com/rauchg/slackin#svg-demo
The https error of course would still exist when switching.
What is the actual `herokuapp.com` hostname of that page?
> Slack js on cordova-docs fails to load due to insecure response
> ---
>
> Key: CB-13284
> URL: https://issues.apache.org/jira/browse/CB-13284
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
> Environment: All
>Reporter: Tommy-Carlos Williams
>
> The file slackin.js is served from https://slack.cordova.io with an incorrect
> TLS certificate (*herokuapp.com)
> {code:none}
> Failed to load resource: net::ERR_INSECURE_RESPONSE
> {code}
> We cannot just serve it from http as cordova.apache.org is served from https
> and would then have the issue of being mixed.
> Is this slackin.js important? If it is, perhaps its script tag in the docs
> site could use the actual underlying herokuapp.com name instead of
> slack.cordova.io, then the TLS certificate would match.
> However, if it's not that important, it could simply be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13284) Slack js on cordova-docs fails to load due to insecure response
[
https://issues.apache.org/jira/browse/CB-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167662#comment-16167662
]
Jan Piotrowski (Sujan) edited comment on CB-13284 at 9/15/17 10:11 AM:
---
slackin.js is used to display a badge for Slack:
!https://cldup.com/IaiPnDEAA6.gif!
Source: https://github.com/rauchg/slackin#realtime-demo
The https error of course would still exist when switching.
What is the actual `herokuapp.com` hostname of that page?
There is also a static version that doesn't require loading JS:
!https://cldup.com/jWUT4QFLnq.png!
https://github.com/rauchg/slackin#svg-demo
was (Author: sujan12):
slackin.js is used to display a badge for Slack:
!https://cldup.com/IaiPnDEAA6.gif!
Source: https://github.com/rauchg/slackin#realtime-demo
There is also a static version that doesn't require loading JS:
!https://cldup.com/jWUT4QFLnq.png!
https://github.com/rauchg/slackin#svg-demo
The https error of course would still exist when switching.
What is the actual `herokuapp.com` hostname of that page?
> Slack js on cordova-docs fails to load due to insecure response
> ---
>
> Key: CB-13284
> URL: https://issues.apache.org/jira/browse/CB-13284
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
> Environment: All
>Reporter: Tommy-Carlos Williams
>
> The file slackin.js is served from https://slack.cordova.io with an incorrect
> TLS certificate (*herokuapp.com)
> {code:none}
> Failed to load resource: net::ERR_INSECURE_RESPONSE
> {code}
> We cannot just serve it from http as cordova.apache.org is served from https
> and would then have the issue of being mixed.
> Is this slackin.js important? If it is, perhaps its script tag in the docs
> site could use the actual underlying herokuapp.com name instead of
> slack.cordova.io, then the TLS certificate would match.
> However, if it's not that important, it could simply be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13284) Slack js on cordova-docs fails to load due to insecure response
[
https://issues.apache.org/jira/browse/CB-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167671#comment-16167671
]
Jan Piotrowski (Sujan) commented on CB-13284:
-
Ah, saw your message in Slack now:
https://slack-cordova-io.herokuapp.com/slackin.js
I think switching over to this is reasonable.
> Slack js on cordova-docs fails to load due to insecure response
> ---
>
> Key: CB-13284
> URL: https://issues.apache.org/jira/browse/CB-13284
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
> Environment: All
>Reporter: Tommy-Carlos Williams
>
> The file slackin.js is served from https://slack.cordova.io with an incorrect
> TLS certificate (*herokuapp.com)
> {code:none}
> Failed to load resource: net::ERR_INSECURE_RESPONSE
> {code}
> We cannot just serve it from http as cordova.apache.org is served from https
> and would then have the issue of being mixed.
> Is this slackin.js important? If it is, perhaps its script tag in the docs
> site could use the actual underlying herokuapp.com name instead of
> slack.cordova.io, then the TLS certificate would match.
> However, if it's not that important, it could simply be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165881#comment-16165881
]
Prashant Malik edited comment on CB-12035 at 9/15/17 10:59 AM:
---
Hi Everyone,
We are facing the same issue with our clients and i found that *network.js*
code in function it's invoking the wrong event i.e _OFFLINE_ even though device
is connected to the Wi-Fi. JS code is as follows:
{code:java}
netwrok.js: #59
channel.onCordovaReady.subscribe(function() {
me.getInfo(function(info) {*//info value is coming as none even-though
device is connected to wi-fi*
me.type = info;
if (info === "none") {
// set a timer if still offline at the end of timer send the
offline event
timerId = setTimeout(function(){
cordova.fireDocumentEvent("offline");
timerId = null;
}, timeout);
} else {
// If there is a current offline event pending clear it
if (timerId !== null) {
clearTimeout(timerId);
timerId = null;
}
cordova.fireDocumentEvent("online");
}
// should only fire this once
if (channel.onCordovaConnectionReady.state !== 2) {
channel.onCordovaConnectionReady.fire();
}
}
{code}
We use cordova version 7.0.0 and platform is Android 7. Devices on which we
tested is Samsung Galaxy S7 and Note5.
Any update on the solution or if anyone found the work around? Please suggest!!
Thanks & Regards
Prashant Malik
was (Author: prashant.malik77):
Hi Everyone,
We are facing the same issue with our clients and i found that *network.js*
code in function it's invoking the wrong event i.e _OFFLINE_ even though device
is connected to the Wi-Fi. JS code is as follows:
{code:java}
netwrok.js: #59
channel.onCordovaReady.subscribe(function() {
me.getInfo(function(info) {*//info value is coming as none even-though
device is connected to wi-fi*
me.type = info;
if (info === "none") {
// set a timer if still offline at the end of timer send the
offline event
timerId = setTimeout(function(){
cordova.fireDocumentEvent("offline");
timerId = null;
}, timeout);
} else {
// If there is a current offline event pending clear it
if (timerId !== null) {
clearTimeout(timerId);
timerId = null;
}
cordova.fireDocumentEvent("online");
}
// should only fire this once
if (channel.onCordovaConnectionReady.state !== 2) {
channel.onCordovaConnectionReady.fire();
}
}
{code}
Any update on the solution or if anyone found the work around? Please suggest!!
Thanks & Regards
Prashant Malik
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
> Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/";.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or dev
[jira] [Created] (CB-13286) plugin-geolocation fails , after 2 min, in Huawei P9/10
Ivan Penchev created CB-13286:
-
Summary: plugin-geolocation fails , after 2 min, in Huawei P9/10
Key: CB-13286
URL: https://issues.apache.org/jira/browse/CB-13286
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-geolocation
Affects Versions: cordova@7.0.0
Environment: cordova -v 7.0.1
Installed platforms:
android 6.1.0
com.phonegap.plugins.nativesettingsopener 1.2 "Native settings"
cordova-plugin-background-mode 0.6.6-dev "BackgroundMode"
cordova-plugin-bluetooth-serial 0.4.6 "Bluetooth Serial"
cordova-plugin-compat 1.1.0 "Compat"
cordova-plugin-console 1.0.5 "Console"
cordova-plugin-datepicker 0.9.3 "DatePicker"
cordova-plugin-device 1.1.4 "Device"
cordova-plugin-dialogs 1.3.0 "Notification"
cordova-plugin-file 4.3.1 "File"
cordova-plugin-geolocation 2.4.1 "Geolocation"
cordova-plugin-googlemaps 1.4.0 "phonegap-googlemaps-plugin"
cordova-plugin-mauron85-background-geolocation 2.2.4 "CDVBackgroundGeolocation"
cordova-plugin-media 2.4.1 "Media"
cordova-plugin-network-information 1.3.0 "Network Information"
cordova-plugin-splashscreen 4.0.1 "Splashscreen"
cordova-plugin-vibration 2.1.2 "Vibration"
cordova-plugin-whitelist 1.3.0 "Whitelist"
cordova-plugin-x-toast 2.5.2 "Toast"
cordova.plugins.diagnostic 3.2.1 "Diagnostic"
de.appplant.cordova.plugin.local-notification 0.8.2dev "LocalNotification"
phonegap-plugin-push 1.10.5 "PushPlugin"
Reporter: Ivan Penchev
Logic of the program:
if CurrentLocation is close to POI
Important to notice is this bug happens on only Some phones (Mostly Huawei
P9/10), as same code runs perfectly on my S6.
Logic implemntation:
{code:JavaScriptl}
function onAppReady()
{
build_dom();
gps_watch();
if IOS .
If Android
}
function gps_watch()
{
var options = {
enableHighAccuracy: true,
timeout: 3
}
gps_watch_handle = navigator.geolocation.watchPosition(
location_received,
function(obj)
{
some code here... basically it says to restart the
gps_watch()
},
,
options
);
}
function location_received(position)
{
if IOS do this
If Android do this...
basic logic is we create an data source with which we can compare.
pos = new Array(position.coords.latitude, position.coords.longitude,
position.coords.accuracy, position.coords.speed, position.coords.heading);
}
{code}
So far I tried to debug something in the console:
this is what I have:
within gps_watch method
within location_received method
>>> Latitude: 57.023577388
within location_received method
>>> Latitude: 57.023596579
this above repeate for about 2 minutes (which is how it should behave).
Then it stops:
within location_received method
>>> Latitude: 57.023733988
within location_received method
No errors no nothing. I tried manually to start the gps_watch method (just
added a button with that method attached as onClick) this happens:
within gps_watch method
within error function in gps_watch method
within gps_watch method
within error function in gps_watch method
and this repeate.
As you can see I am a novice developer, I would appreciate any guides into how
to solve/further debug this issue.
Thank you,
Ivan
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13286) plugin-geolocation fails , after 2 min, in Huawei P9/10
[
https://issues.apache.org/jira/browse/CB-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Penchev updated CB-13286:
--
Description:
Logic of the program:
if CurrentLocation is close to POI
Important to notice is this bug happens on only Some phones (Mostly Huawei
P9/10), as same code runs perfectly on my S6.
Logic implemntation:
{code:JavaScript}
function onAppReady()
{
build_dom();
gps_watch();
if IOS .
If Android
}
function gps_watch()
{
var options = {
enableHighAccuracy: true,
timeout: 3
}
gps_watch_handle = navigator.geolocation.watchPosition(
location_received,
function(obj)
{
some code here... basically it says to restart the
gps_watch()
},
,
options
);
}
function location_received(position)
{
if IOS do this
If Android do this...
basic logic is we create an data source with which we can compare.
pos = new Array(position.coords.latitude, position.coords.longitude,
position.coords.accuracy, position.coords.speed, position.coords.heading);
}
{code}
So far I tried to debug something in the console:
this is what I have:
within gps_watch method
within location_received method
>>> Latitude: 57.023577388
within location_received method
>>> Latitude: 57.023596579
this above repeate for about 2 minutes (which is how it should behave).
Then it stops:
within location_received method
>>> Latitude: 57.023733988
within location_received method
No errors no nothing. I tried manually to start the gps_watch method (just
added a button with that method attached as onClick) this happens:
within gps_watch method
within error function in gps_watch method
within gps_watch method
within error function in gps_watch method
and this repeate.
As you can see I am a novice developer, I would appreciate any guides into how
to solve/further debug this issue.
Thank you,
Ivan
was:
Logic of the program:
if CurrentLocation is close to POI
Important to notice is this bug happens on only Some phones (Mostly Huawei
P9/10), as same code runs perfectly on my S6.
Logic implemntation:
{code:JavaScriptl}
function onAppReady()
{
build_dom();
gps_watch();
if IOS .
If Android
}
function gps_watch()
{
var options = {
enableHighAccuracy: true,
timeout: 3
}
gps_watch_handle = navigator.geolocation.watchPosition(
location_received,
function(obj)
{
some code here... basically it says to restart the
gps_watch()
},
,
options
);
}
function location_received(position)
{
if IOS do this
If Android do this...
basic logic is we create an data source with which we can compare.
pos = new Array(position.coords.latitude, position.coords.longitude,
position.coords.accuracy, position.coords.speed, position.coords.heading);
}
{code}
So far I tried to debug something in the console:
this is what I have:
within gps_watch method
within location_received method
>>> Latitude: 57.023577388
within location_received method
>>> Latitude: 57.023596579
this above repeate for about 2 minutes (which is how it should behave).
Then it stops:
within location_received method
>>> Latitude: 57.023733988
within location_received method
No errors no nothing. I tried manually to start the gps_watch method (just
added a button with that method attached as onClick) this happens:
within gps_watch method
within error function in gps_watch method
within gps_watch method
within error function in gps_watch method
and this repeate.
As you can see I am a novice developer, I would appreciate any guides into how
to solve/further debug this issue.
Thank you,
Ivan
> plugin-geolocation fails , after 2 min, in Huawei P9/10
> ---
>
> Key: CB-13286
> URL: https://issues.apache.org/jira/browse/CB-13286
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-geolocation
>Affects Versions: cordova@7.0.0
> Environment: cordova -v 7.0.1
> Installed platforms:
> android 6.1.0
> com.phonegap.plugins.nativesettingsopener 1.2 "Native settings"
> cordova-plugin-background-mode 0.6.6-dev "BackgroundMode"
> cordova-plugin-bluetooth-serial 0.4.6 "Bluetooth Serial"
> cordova-plugin-compat 1.1.0 "Compat"
> cordova-plugin-console 1.0.5 "Console"
> cordova-plugin-datepicker 0.9.3 "DatePicker"
> cordova-plugin-device 1.1.4 "Device"
> cordova-plugin-dialogs 1.3.0 "Notification"
> cordova-plugin-file 4.3.1 "File"
> cordova-plugin-geolocation 2.4.1 "Geolocation"
> cordova-plugin-googlemaps 1.4.0 "phonegap-googlemaps-plugin"
> cordova-plugin-mauron85-background-geolocation 2.2.4
> "CDVBack
[jira] [Updated] (CB-13286) plugin-geolocation fails , after 2 min, in Huawei P9/10
[
https://issues.apache.org/jira/browse/CB-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Penchev updated CB-13286:
--
Description:
Logic of the program:
if CurrentLocation is close to POI
Important to notice is this bug happens on only Some phones (Mostly Huawei
P9/10), as same code runs perfectly on my S6.
Logic implemntation:
{code:JavaScript}
function onAppReady()
{
build_dom();
gps_watch();
if IOS .
If Android
}
function gps_watch()
{
var options = {
enableHighAccuracy: true,
timeout: 3
}
gps_watch_handle = navigator.geolocation.watchPosition(
location_received,
function(obj)
{
some code here... basically it says to restart the
gps_watch()
},
,
options
);
}
function location_received(position)
{
if IOS do this
If Android do this...
basic logic is we create an data source with which we can compare.
pos = new Array(position.coords.latitude, position.coords.longitude,
position.coords.accuracy, position.coords.speed, position.coords.heading);
}
{code}
So far I tried to debug something in the console:
this is what I have:
within gps_watch method
within location_received method
>>> Latitude: 57.023577388
within location_received method
>>> Latitude: 57.023596579
this above repeate for about 2 minutes (which is how it should behave).
Then it stops:
within location_received method
>>> Latitude: 57.023733988
within location_received method
No errors no nothing. I tried manually to start the gps_watch method (just
added a button with that method attached as onClick) this happens:
within gps_watch method
within error function in gps_watch method
within gps_watch method
within error function in gps_watch method
and this repeate.
EDIT: in the error function object, which I receive after I manually click on
the gps_watch method with the button I greated lies this:
body:::gps error: Timeout expired
code:::gps errorcode: 3
As you can see I am a novice developer, I would appreciate any guides into how
to solve/further debug this issue.
Thank you,
Ivan
was:
Logic of the program:
if CurrentLocation is close to POI
Important to notice is this bug happens on only Some phones (Mostly Huawei
P9/10), as same code runs perfectly on my S6.
Logic implemntation:
{code:JavaScript}
function onAppReady()
{
build_dom();
gps_watch();
if IOS .
If Android
}
function gps_watch()
{
var options = {
enableHighAccuracy: true,
timeout: 3
}
gps_watch_handle = navigator.geolocation.watchPosition(
location_received,
function(obj)
{
some code here... basically it says to restart the
gps_watch()
},
,
options
);
}
function location_received(position)
{
if IOS do this
If Android do this...
basic logic is we create an data source with which we can compare.
pos = new Array(position.coords.latitude, position.coords.longitude,
position.coords.accuracy, position.coords.speed, position.coords.heading);
}
{code}
So far I tried to debug something in the console:
this is what I have:
within gps_watch method
within location_received method
>>> Latitude: 57.023577388
within location_received method
>>> Latitude: 57.023596579
this above repeate for about 2 minutes (which is how it should behave).
Then it stops:
within location_received method
>>> Latitude: 57.023733988
within location_received method
No errors no nothing. I tried manually to start the gps_watch method (just
added a button with that method attached as onClick) this happens:
within gps_watch method
within error function in gps_watch method
within gps_watch method
within error function in gps_watch method
and this repeate.
As you can see I am a novice developer, I would appreciate any guides into how
to solve/further debug this issue.
Thank you,
Ivan
> plugin-geolocation fails , after 2 min, in Huawei P9/10
> ---
>
> Key: CB-13286
> URL: https://issues.apache.org/jira/browse/CB-13286
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-geolocation
>Affects Versions: cordova@7.0.0
> Environment: cordova -v 7.0.1
> Installed platforms:
> android 6.1.0
> com.phonegap.plugins.nativesettingsopener 1.2 "Native settings"
> cordova-plugin-background-mode 0.6.6-dev "BackgroundMode"
> cordova-plugin-bluetooth-serial 0.4.6 "Bluetooth Serial"
> cordova-plugin-compat 1.1.0 "Compat"
> cordova-plugin-console 1.0.5 "Console"
> cordova-plugin-datepicker 0.9.3 "DatePicker"
> cordova-plugin-device 1.1.4 "Device"
> cordova-plugin-dialogs 1.3.0 "Notification"
> cordova-plugin-fi
[jira] [Commented] (CB-9936) iOS File Transfer not receiving Progress Event
[
https://issues.apache.org/jira/browse/CB-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167945#comment-16167945
]
Evan Wieland commented on CB-9936:
--
I can confirm that this work-around does the trick.
> iOS File Transfer not receiving Progress Event
> --
>
> Key: CB-9936
> URL: https://issues.apache.org/jira/browse/CB-9936
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file-transfer
>Affects Versions: 1.4.0
> Environment: iOS
>Reporter: Tony Leung
>Priority: Minor
> Labels: cannot-reproduce, triaged
> Attachments: screenshot.png
>
>
> In CDVFileTransfer.m, download() method between line 447 to 462
> {noformat}
> delegate.connection = [[NSURLConnection alloc] initWithRequest:req
> delegate:delegate startImmediately:NO];
> if (self.queue == nil) {
> self.queue = [[NSOperationQueue alloc] init];
> }
> [delegate.connection setDelegateQueue:self.queue];
> @synchronized (activeTransfers) {
> activeTransfers[delegate.objectId] = delegate;
> }
> // Downloads can take time
> // sending this to a new thread calling the download_async method
> dispatch_async(
>dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,
> (unsigned long)NULL),
>^(void) { [delegate.connection start];}
>);
> {noformat}
> If I replaced it with the older version of the code, then it works.
> {noformat}
> delegate.connection = [NSURLConnection connectionWithRequest:req
> delegate:delegate];
> if (activeTransfers == nil) {
> activeTransfers = [[NSMutableDictionary alloc] init];
> }
> [activeTransfers setObject:delegate forKey:delegate.objectId];
> {noformat}
> In summary, if we don't use GCD to start the NSURLConnection, it works.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167968#comment-16167968
]
Mike Hartington commented on CB-13273:
--
I think a better approach instead would be to take advantage of the new
safe-area-insets. I have this fork ready to PR that does just that for iOS 11,
and falls back to the older hard-coded method for ios 10 and below.
https://github.com/mhartington/cordova-plugin-statusbar/commit/f4dbcc2d61c01c2766afdc5e40d1c47226a04f5d
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167972#comment-16167972
]
ASF GitHub Bot commented on CB-13273:
-
GitHub user mhartington opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/85
CB-13273: fix statusbar spacing with new iphoneX
### Platforms affected
iOS
### What does this PR do?
Adds additional check for iOS11/iPhone X and the new statusbar size
### What testing has been done on this change?
Manual testing on devices and simulators.
Note: I messed on the commit message format, tagged the wrong jira issue.
But there is an issue for this.
https://issues.apache.org/jira/browse/CB-13273
### Checklist
- [ x] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mhartington/cordova-plugin-statusbar
CB-12886cordova-plugin-statusbar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
commit f4dbcc2d61c01c2766afdc5e40d1c47226a04f5d
Author: mhartington
Date: 2017-09-15T13:50:42Z
CB-12886: fix statusbar spacing with new iphoneX
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167977#comment-16167977
]
Dave Alden commented on CB-13273:
-
I've used safe-area-insets, but just applied with CSS (no forking required):
{code:html}
body{
padding-top: constant(safe-area-inset-top);
}
{code}
FYI I also needed to do so for footer toolbar buttons in my app to avoid them
being overlapped by the virtual Home button on iPhone X (couldn't apply this to
as footer is absolutely positioned):
{code:html}
.toolbar-footer{
margin-bottom: constant(safe-area-inset-bottom);
}
{code}
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167981#comment-16167981
]
Mike Hartington commented on CB-13273:
--
Yep, that works well if you are +not+ using the statusbar plugin. For those who
are, the PR I sent will be needed.
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168003#comment-16168003
]
Dave Alden commented on CB-13273:
-
Thanks Mike, good to know: I'm not using it so hadn't hit that problem. Will
update my SO post with your PR.
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13287) Select dropdown opens twice on IOS11
[ https://issues.apache.org/jira/browse/CB-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manoj Shrestha updated CB-13287: Attachment: select-dropdown-issue.mov > Select dropdown opens twice on IOS11 > > > Key: CB-13287 > URL: https://issues.apache.org/jira/browse/CB-13287 > Project: Apache Cordova > Issue Type: Bug > Environment: * IOS11 > * Any version of cordova (tried on 6.5.0 and 7.0.1) >Reporter: Manoj Shrestha > Attachments: select-dropdown-issue.mov > > > The HTML Select dropdown seems have an issue with latest IOS v11. After we > select a value from the drop down, the option list pops up once again. > Please refer to the attached video to see this behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13287) Select dropdown opens twice on IOS11
Manoj Shrestha created CB-13287: --- Summary: Select dropdown opens twice on IOS11 Key: CB-13287 URL: https://issues.apache.org/jira/browse/CB-13287 Project: Apache Cordova Issue Type: Bug Environment: * IOS11 * Any version of cordova (tried on 6.5.0 and 7.0.1) Reporter: Manoj Shrestha The HTML Select dropdown seems have an issue with latest IOS v11. After we select a value from the drop down, the option list pops up once again. Please refer to the attached video to see this behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13287) Select dropdown opens twice on IOS11
[ https://issues.apache.org/jira/browse/CB-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manoj Shrestha updated CB-13287: Environment: * Xcode 9 * IOS11 * Any version of cordova (tried on 6.5.0 and 7.0.1) was: * IOS11 * Any version of cordova (tried on 6.5.0 and 7.0.1) > Select dropdown opens twice on IOS11 > > > Key: CB-13287 > URL: https://issues.apache.org/jira/browse/CB-13287 > Project: Apache Cordova > Issue Type: Bug > Environment: * Xcode 9 > * IOS11 > * Any version of cordova (tried on 6.5.0 and 7.0.1) >Reporter: Manoj Shrestha > Attachments: select-dropdown-issue.mov > > > The HTML Select dropdown seems have an issue with latest IOS v11. After we > select a value from the drop down, the option list pops up once again. > Please refer to the attached video to see this behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13287) Select dropdown opens twice on IOS11
[ https://issues.apache.org/jira/browse/CB-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manoj Shrestha updated CB-13287: Environment: * Xcode 9 * IOS11 * Any version of Cordova (tried on 6.5.0 and 7.0.1) was: * Xcode 9 * IOS11 * Any version of cordova (tried on 6.5.0 and 7.0.1) > Select dropdown opens twice on IOS11 > > > Key: CB-13287 > URL: https://issues.apache.org/jira/browse/CB-13287 > Project: Apache Cordova > Issue Type: Bug > Environment: * Xcode 9 > * IOS11 > * Any version of Cordova (tried on 6.5.0 and 7.0.1) >Reporter: Manoj Shrestha > Attachments: select-dropdown-issue.mov > > > The HTML Select dropdown seems have an issue with latest IOS v11. After we > select a value from the drop down, the option list pops up once again. > Please refer to the attached video to see this behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168139#comment-16168139 ] ASF GitHub Bot commented on CB-12361: - Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/592 > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168138#comment-16168138 ] ASF GitHub Bot commented on CB-12361: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/593 CB-12361 : added plugin unit tests for plugin list ### Platforms affected ### What does this PR do? Added plugin unit tests for plugin list ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12361-list_spec Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/593.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #593 commit e956fe7c8d0cbd8c7663bed4e66d5b1f78411e68 Author: Audrey So Date: 2017-09-15T16:32:55Z CB-12361 : added plugin tests for plugin list > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13271) put a patch in the cordova-android project to solve the fragmentation and performance problems in the cordova application on android platform
[ https://issues.apache.org/jira/browse/CB-13271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-13271. - Resolution: Won't Fix You are welcome to write a third-party plugin, that said I don't believe it would be a good idea for us to endorse any new third party plugins at this point in time. > put a patch in the cordova-android project to solve the fragmentation and > performance problems in the cordova application on android platform > - > > Key: CB-13271 > URL: https://issues.apache.org/jira/browse/CB-13271 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: cordova@7.0.0 >Reporter: liuzheng >Assignee: Joe Bowser > Labels: patch > > We want to put a patch in the cordova-android project to solve the > fragmentation and performance problems in the cordova application on android > platform , hoping to be supported by the Cordoba project team. > Recently, many cordova application developers feedback to Tencent's > X5 kernel team (Tencent browsing service) , hope cordova-android can support > the use of x5 kernel to solve the fragmentation of the android system and > performance problems. > X5 kernel is developed based on the blink core, which is aimed at > solving android fragmentation and performance issues. It is well compatible > with android version of the system and give users a more smooth browsing > experience. The current number of applications using x5 core exceed 20,000, > the number of active users has more than 700 million. > > > > Looking forward to your reply! > > Email: aczheng...@tencent.com -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13288) Plugin "search" command, not working
Audrey So created CB-13288: -- Summary: Plugin "search" command, not working Key: CB-13288 URL: https://issues.apache.org/jira/browse/CB-13288 Project: Apache Cordova Issue Type: Bug Components: cordova-lib Affects Versions: cordova7 Reporter: Audrey So Assignee: Audrey So Priority: Minor cordova plugin search [ ] ... not working properly. Error --> "Error: module.exports.search is not a function" For example: Running cordova plugin search bar code Should bring you to http://cordova.apache.org/plugins/?q=bar%20code -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6936) app crashes if webview is destroyed while dialog box open
[
https://issues.apache.org/jira/browse/CB-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168466#comment-16168466
]
ASF subversion and git services commented on CB-6936:
-
Commit dddb2837ddfa4a13e9f2f748bdc432bcdd78847e in cordova-android's branch
refs/heads/master from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=dddb283 ]
CB-6936: Merge pull request #304 from uareurapid/master
CB-6936: fix crash when calling methods on a destroyed webview
> app crashes if webview is destroyed while dialog box open
> -
>
> Key: CB-6936
> URL: https://issues.apache.org/jira/browse/CB-6936
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 3.4.0
> Environment: Android 4.x on physical device
> Or any Android environment
>Reporter: Shingo Toda
>Assignee: Joe Bowser
>Priority: Minor
>
> We have an Android application which implements an embedded WebView
> "container" in which it executes customer Cordova apps.
> Under certain conditions our container needs to terminate the customer app,
> and during this termination it calls {{CordovaWebView.destroy()}} to disable
> CordovaWebView.
> But application may entirely crash during this termination in some scenarios.
> For example:
> # call {{navigator.notification.alert}}, {{confirm}} or {{prompt}} and leave
> popup dialog open
> # this termination is done for some reason while dialog box is till open
> # all views on CordovaWebView are released but dialog box still remains
> # attempt to close dialog by pressing button in the dialog
> # application crashes with Unknown exception.
> {code}
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176): 81508: Unknown exception
> occurred.
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176): java.lang.NullPointerException
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> android.webkit.WebView.setNetworkAvailable(WebView.java:2639)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue$OnlineEventsBridgeMode$1.run(NativeToJsMessageQueue.java:305)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> android.app.Activity.runOnUiThread(Activity.java:4175)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue$OnlineEventsBridgeMode.onNativeToJsMessageAvailable(NativeToJsMessageQueue.java:313)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue.enqueueMessage(NativeToJsMessageQueue.java:253)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue.addPluginResult(NativeToJsMessageQueue.java:246)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.CordovaWebView.sendPluginResult(CordovaWebView.java:572)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.CallbackContext.sendPluginResult(CallbackContext.java:64)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.dialogs.Notification$1$1.onClick(Notification.java:150)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
> {code}
> h2. Problem
> Obviously CordovaWebView is already not available but dialog still exists. If
> a user press button in dialog, {{onClick()}} gets called and consequently
> {{CordovaWebView.setNetworkAvailable()}} gets called to send message from
> queue to JavaScript even though WebView is already destroyed. As a result,
> entire application crashes.
> h3. Workaround
> We made a method to check if WebView is destroyed or not.
> {code}
> private boolean isWebViewDestroyed() {
> final String url = webView.getUrl();
> if (url == null ||
> url.equals("about:blank")) {
> return true;
> } else {
> return false;
> }
> }
> {code}
> And check this before {{callbackContext.sendPluginResult()}} is called.
> {code}
> public synchronized void alert(final String message, final String title,
> final String buttonLabel, final CallbackContext callbackContext) {
> final CordovaInterface cordova = this.cordova;
> Runnable runnable = new Runnable() {
> public void run() {
> AlertDialog.Builder dlg = new
> AlertDialog.Builder(cordova.getActivity());
> dlg.setMessage(message);
> dlg.setTitle(title);
> dlg.setCancelable(true);
> dlg.setPositiveButton(buttonLabel,
> new AlertDialog.OnClickListener() {
> public void onC
[jira] [Commented] (CB-6936) app crashes if webview is destroyed while dialog box open
[
https://issues.apache.org/jira/browse/CB-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168468#comment-16168468
]
ASF subversion and git services commented on CB-6936:
-
Commit dddb2837ddfa4a13e9f2f748bdc432bcdd78847e in cordova-android's branch
refs/heads/master from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=dddb283 ]
CB-6936: Merge pull request #304 from uareurapid/master
CB-6936: fix crash when calling methods on a destroyed webview
> app crashes if webview is destroyed while dialog box open
> -
>
> Key: CB-6936
> URL: https://issues.apache.org/jira/browse/CB-6936
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 3.4.0
> Environment: Android 4.x on physical device
> Or any Android environment
>Reporter: Shingo Toda
>Assignee: Joe Bowser
>Priority: Minor
>
> We have an Android application which implements an embedded WebView
> "container" in which it executes customer Cordova apps.
> Under certain conditions our container needs to terminate the customer app,
> and during this termination it calls {{CordovaWebView.destroy()}} to disable
> CordovaWebView.
> But application may entirely crash during this termination in some scenarios.
> For example:
> # call {{navigator.notification.alert}}, {{confirm}} or {{prompt}} and leave
> popup dialog open
> # this termination is done for some reason while dialog box is till open
> # all views on CordovaWebView are released but dialog box still remains
> # attempt to close dialog by pressing button in the dialog
> # application crashes with Unknown exception.
> {code}
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176): 81508: Unknown exception
> occurred.
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176): java.lang.NullPointerException
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> android.webkit.WebView.setNetworkAvailable(WebView.java:2639)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue$OnlineEventsBridgeMode$1.run(NativeToJsMessageQueue.java:305)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> android.app.Activity.runOnUiThread(Activity.java:4175)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue$OnlineEventsBridgeMode.onNativeToJsMessageAvailable(NativeToJsMessageQueue.java:313)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue.enqueueMessage(NativeToJsMessageQueue.java:253)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.NativeToJsMessageQueue.addPluginResult(NativeToJsMessageQueue.java:246)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.CordovaWebView.sendPluginResult(CordovaWebView.java:572)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.CallbackContext.sendPluginResult(CallbackContext.java:64)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> org.apache.cordova.dialogs.Notification$1$1.onClick(Notification.java:150)
> 06-13 21:45:19.765: E/FSP_INTS-MAPS_AG(11176):at
> com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
> {code}
> h2. Problem
> Obviously CordovaWebView is already not available but dialog still exists. If
> a user press button in dialog, {{onClick()}} gets called and consequently
> {{CordovaWebView.setNetworkAvailable()}} gets called to send message from
> queue to JavaScript even though WebView is already destroyed. As a result,
> entire application crashes.
> h3. Workaround
> We made a method to check if WebView is destroyed or not.
> {code}
> private boolean isWebViewDestroyed() {
> final String url = webView.getUrl();
> if (url == null ||
> url.equals("about:blank")) {
> return true;
> } else {
> return false;
> }
> }
> {code}
> And check this before {{callbackContext.sendPluginResult()}} is called.
> {code}
> public synchronized void alert(final String message, final String title,
> final String buttonLabel, final CallbackContext callbackContext) {
> final CordovaInterface cordova = this.cordova;
> Runnable runnable = new Runnable() {
> public void run() {
> AlertDialog.Builder dlg = new
> AlertDialog.Builder(cordova.getActivity());
> dlg.setMessage(message);
> dlg.setTitle(title);
> dlg.setCancelable(true);
> dlg.setPositiveButton(buttonLabel,
> new AlertDialog.OnClickListener() {
> public void onC
[jira] [Updated] (CB-13288) Plugin "search" command, not working
[ https://issues.apache.org/jira/browse/CB-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13288: --- Description: cordova plugin search [ ] ... not working properly. Error --> "Error: module.exports.search is not a function" For example: Running cordova plugin search Should bring you to http://cordova.apache.org/plugins/ was: cordova plugin search [ ] ... not working properly. Error --> "Error: module.exports.search is not a function" For example: Running cordova plugin search bar code Should bring you to http://cordova.apache.org/plugins/?q=bar%20code > Plugin "search" command, not working > > > Key: CB-13288 > URL: https://issues.apache.org/jira/browse/CB-13288 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > cordova plugin search [ ] ... not working properly. > Error --> "Error: module.exports.search is not a function" > For example: > Running cordova plugin search > Should bring you to http://cordova.apache.org/plugins/ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13288) Plugin "search" command, not working
[ https://issues.apache.org/jira/browse/CB-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168481#comment-16168481 ] ASF GitHub Bot commented on CB-13288: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/594 CB-13288 : updated index.js and test to fix cordova plugin search ### Platforms affected ### What does this PR do? Updated index.js and test to fix cordova plugin search ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13288 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #594 commit e50c9b60e45cdc033d68bce62a2af894da0e1b61 Author: Audrey So Date: 2017-09-15T20:34:44Z CB-13288 : updated index.js and test to fix cordova plugin search > Plugin "search" command, not working > > > Key: CB-13288 > URL: https://issues.apache.org/jira/browse/CB-13288 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > cordova plugin search [ ] ... not working properly. > Error --> "Error: module.exports.search is not a function" > For example: > Running cordova plugin search > Should bring you to http://cordova.apache.org/plugins/ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13241) Potential issue with geolocation when device is set to GPS only
[
https://issues.apache.org/jira/browse/CB-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168625#comment-16168625
]
Filip Maj commented on CB-13241:
OK, so I tried to reproduce this but could not on an Galaxy S7 Edge (model
SM-G9350) running Android 7.0.
I created a cordova project using cordova-cli@7, added cordova-android@6.2.3
and cordova-plugin-geolocation@2.4.3 to it, and used a slightly modified
standard cordova project (the app's [app.js replacement is available in a gist
if you want to take a
look|https://gist.github.com/filmaj/89a30995504952dabd686d5fd79e96e5]) to test
out two calls to {{getCurrentPosition}} using the options provided by
[~frontendphil].
On the S7 I mentioned above, after installing, the app would immediately ask me
for permission to use Geo. I accepted. I would then get two "geo success"
calls. I'm testing this in an open area where GPS tracking should not be an
issue.
> Potential issue with geolocation when device is set to GPS only
> ---
>
> Key: CB-13241
> URL: https://issues.apache.org/jira/browse/CB-13241
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-plugin-geolocation
> Environment: Reproducible by me on: Samsung Galaxy S5 when phone
> location settings are set to GPS only.
> Error reporting has logged the issue on (based on most first):
> Samsung Galaxy S7 (international and European version)
> Samsung Galaxy S6 (SM-G920F)
> Samsung Galaxy A5 2017 (SM-A520F)
> Samsung Galaxy S8 (SM-G950F)
> [etc]
> The top 15 devices are Samsung with the exception of the Sony Xperia XA
> (F3111).
> There are other devices on the list but they happen a handful of times so
> could be false positives or users have poor reception for example.
> Of note: Google Pixel and Pixel XL does not appear in the list of devices. I
> am also unable to reproduce the issue on Nexus 5X.
>Reporter: Phil Lennon
>Assignee: Filip Maj
>
> Pinging [~filmaj] who asked to be assigned this.
> My app uses the Geolocation getCurrentPosition() function on both IOS and
> Android. I have had an estimated 1.6k Android users unable to get a location
> with a timeout error code 3. There are no problems on IOS.
> I first try to get location with the following settings:
> this.geolocationOptionsFirst = {
> enableHighAccuracy: true,
> maximumAge: 30,
> timeout: 1
> }
> if that fails I then try again with the following settings:
> this.geolocationOptionsSecond = {
> enableHighAccuracy: false,
> maximumAge: 30,
> timeout: 6000
> }
> The app is failing with a timeout after 16 seconds in total. My testing has
> made me believe it's something to do with setting phone location settings to
> GPS only. Please see environment for affected devices.
> Happy to provide more information if needed. I am available on the
> cordova-android Slack channel as frontendphil.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168648#comment-16168648 ] Sean Hill commented on CB-12886: So can someone explain what the final solution is if I'd like to use WKWebView? > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13170) final changes and release of post-integration cordova-plugin-console
[
https://issues.apache.org/jira/browse/CB-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168691#comment-16168691
]
ASF GitHub Bot commented on CB-13170:
-
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/25
thanks @alsorokin !
> final changes and release of post-integration cordova-plugin-console
>
>
> Key: CB-13170
> URL: https://issues.apache.org/jira/browse/CB-13170
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-console (DEPRECATED)
>Reporter: Filip Maj
>Assignee: Shazron Abdullah
> Labels: plugins-next
>
> 1. add an {{}} constraint to {{plugin.xml}}, and to
> {{cordovaDependencies}} in {{package.json}}, capping cordova-ios and
> cordova-windows support
> 2. bump version
> 3. Update README.md to reflect maintenance status. Direct users to file
> bugs/prs to the platforms that integrate the plugin
> 4. do a final release
> 5. {{npm deprecate}} the plugin
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13170) final changes and release of post-integration cordova-plugin-console
[
https://issues.apache.org/jira/browse/CB-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168695#comment-16168695
]
ASF GitHub Bot commented on CB-13170:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-console/pull/25
> final changes and release of post-integration cordova-plugin-console
>
>
> Key: CB-13170
> URL: https://issues.apache.org/jira/browse/CB-13170
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-console (DEPRECATED)
>Reporter: Filip Maj
>Assignee: Shazron Abdullah
> Labels: plugins-next
>
> 1. add an {{}} constraint to {{plugin.xml}}, and to
> {{cordovaDependencies}} in {{package.json}}, capping cordova-ios and
> cordova-windows support
> 2. bump version
> 3. Update README.md to reflect maintenance status. Direct users to file
> bugs/prs to the platforms that integrate the plugin
> 4. do a final release
> 5. {{npm deprecate}} the plugin
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13170) final changes and release of post-integration cordova-plugin-console
[
https://issues.apache.org/jira/browse/CB-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168698#comment-16168698
]
Shazron Abdullah commented on CB-13170:
---
PR integrated. Only Steps 4 and 5 remain for this task.
> final changes and release of post-integration cordova-plugin-console
>
>
> Key: CB-13170
> URL: https://issues.apache.org/jira/browse/CB-13170
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-console (DEPRECATED)
>Reporter: Filip Maj
>Assignee: Shazron Abdullah
> Labels: plugins-next
>
> 1. add an {{}} constraint to {{plugin.xml}}, and to
> {{cordovaDependencies}} in {{package.json}}, capping cordova-ios and
> cordova-windows support
> 2. bump version
> 3. Update README.md to reflect maintenance status. Direct users to file
> bugs/prs to the platforms that integrate the plugin
> 4. do a final release
> 5. {{npm deprecate}} the plugin
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13170) final changes and release of post-integration cordova-plugin-console
[
https://issues.apache.org/jira/browse/CB-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168694#comment-16168694
]
ASF subversion and git services commented on CB-13170:
--
Commit 0681d8a63788126b29c4cc25e4b99e39dd0d4362 in cordova-plugin-console's
branch refs/heads/master from [~shazron]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-console.git;h=0681d8a ]
CB-13170 - final changes and release of post-integration cordova-plugin-console
This closes #25
> final changes and release of post-integration cordova-plugin-console
>
>
> Key: CB-13170
> URL: https://issues.apache.org/jira/browse/CB-13170
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-console (DEPRECATED)
>Reporter: Filip Maj
>Assignee: Shazron Abdullah
> Labels: plugins-next
>
> 1. add an {{}} constraint to {{plugin.xml}}, and to
> {{cordovaDependencies}} in {{package.json}}, capping cordova-ios and
> cordova-windows support
> 2. bump version
> 3. Update README.md to reflect maintenance status. Direct users to file
> bugs/prs to the platforms that integrate the plugin
> 4. do a final release
> 5. {{npm deprecate}} the plugin
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12074) Cookies are ignored on first application execution
[ https://issues.apache.org/jira/browse/CB-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168706#comment-16168706 ] Grant Patterson commented on CB-12074: -- [~todd.miller] my experience as well. Can someone explain how AJAX/XHR requests are handled by the native code? Perhaps there's another way to intercept these and save the cookies returned by the server? FYI for me, the app doesn't need to be "closed" per se; simply backgrounding and foregrounding it makes things work. > Cookies are ignored on first application execution > -- > > Key: CB-12074 > URL: https://issues.apache.org/jira/browse/CB-12074 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-wkwebview-engine > Environment: Cordova 5.4.0, iOS 9.3.5 >Reporter: Maxim >Assignee: Shazron Abdullah > Labels: wkwebview-known-issues > > Our application authenticates to the server. The server sets a 'JSESSIONID' > cookie. The cookie is used by the server for session management. > The issue is WKWebView does not send this cookie back to the server on > subsequent requests. However, this only happens on first execution of the > application, after its installation. Once the application closed and > re-opened, the cookies are properly sent and authentication completes > successfully. > The problematic behavior is consistent, and was observed on several devices. > On the other hand, there are no such issues with UIWebView. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13289) Gradle/Android Plugin DSL change breaks including CordovaLib
Joe Bowser created CB-13289: --- Summary: Gradle/Android Plugin DSL change breaks including CordovaLib Key: CB-13289 URL: https://issues.apache.org/jira/browse/CB-13289 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: 6.2.1 Reporter: Joe Bowser Assignee: Joe Bowser Priority: Blocker Fix For: 7.0.0 Android Studio 3.0.0 uses a new DSL, and this breaks the dependency list. This directly affects Cordova plugins that work as a Library Module, as well as adding and removing the Android platform. Basically, once Android Studio 3.0 updates, Cordova projects will not work properly with the new version of Android Studio once they're updated. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168825#comment-16168825 ] Sean Molyneaux commented on CB-12886: - Hello, I have a modified the status bar plugin to deal with iOS 11 white space and also to support iPhone X fullscreen correctly when StatusBarOverlaysWebView = true. Where can I post the revised code as a suggestion. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
