[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195453#comment-16195453 ] Jan Piotrowski (Sujan) commented on CB-13409: - Nice! Is there a PR for that? > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Original Estimate: 8h > Remaining Estimate: 8h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > -Have a custom text for a close button instead of the Default X: > closebuttoncaption: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > -Change the close button color: > closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, > and it will change the > close button color from default, regardless of being a text or default X. > Only has effect if user has location set to `yes`." > -Hide the navigation buttons that go backwards and forwards: > hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > -Change navigation buttons color: > navigationbuttoncolor: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > -Change color of toolbar: > toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > closebuttoncolor(same as above) > hidenavigationbuttons(same as above) > toolbarcolor(same as above) > -Make toolbar non-translucent: > toolbartranslucent: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13412) Document platform specific CLI options
[ https://issues.apache.org/jira/browse/CB-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195433#comment-16195433 ] Filip Maj commented on CB-13412: Some prior documentation on where shreds of this exist: - https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#setting-gradle-properties - https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#using-flags - https://cordova.apache.org/docs/en/latest/guide/platforms/ios/index.html#xcode-build-flags - https://cordova.apache.org/docs/en/latest/guide/platforms/ios/index.html#using-flags - https://cordova.apache.org/docs/en/latest/guide/platforms/win8/#the---appx-parameter Some places in code to look for more: - https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/build.js#L34-L49 - and ios / windows build scripts would be another good place to look for any ones that we missed. > Document platform specific CLI options > -- > > Key: CB-13412 > URL: https://issues.apache.org/jira/browse/CB-13412 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-docs, cordova-ios >Reporter: Jan Piotrowski (Sujan) >Assignee: Joe Bowser > > Seems `cordova build android -- --versionCode=1` is a thing and works: > https://stackoverflow.com/a/40274188/252627 > https://cordova.apache.org/docs/en/7.x/reference/cordova-cli/index.html#cordova-build-command > has: > {quote} > To provide platform specific options, you must include them > after -- separator. Review platform guide docs for more details. > {quote} > But in the "platform guide docs" I can't find anything. > [~filmaj] suggested: `--` forwards arguments to the underlying build scripts > that are present in each platform. > So these should probably investigated, inventoried and documented. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195427#comment-16195427 ] ASF GitHub Bot commented on CB-13054: - Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/746#discussion_r143312794 --- Diff: www/_posts/2017-10-02-from-filetransfer-to-xhr2.md --- @@ -0,0 +1,175 @@ +--- +layout: post +author: +name: Fil Maj +url: https://twitter.com/filmaj +title: "Transition off of cordova-plugin-file-transfer" +categories: blog +tags: plugins +--- + +Early on in Cordova's existence, the [file-transfer plugin](https://github.com/apache/cordova-plugin-file-transfer) +was created to solve the [problem of downloading binary files](https://issues.apache.org/jira/browse/CB-22). +At the time, there weren't great options for solving this using standards-compliant +web APIs. The web took a twisty path to get to a solution (see +[Firefox's `sendAsBinary`](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/sendAsBinary) +and the now-defunct [FileSystem API](https://dev.w3.org/2009/dap/file-system/file-dir-sys.html)'s +[BlobBuilder](https://developer.mozilla.org/en-US/docs/Web/API/BlobBuilder), +among others), but today you can use our good friend [XMLHttpRequest](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest)'s +newest features, combined with some newer JavaScript types and objects, +[to solve this problem](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data). +This is an exciting moment for Cordova as the dream for this project was always +to eventually reduce the surface area of APIs the project maintains, and instead +see regular web APIs be able to handle these use cases. + +As a result, +[Cordova is sunsetting the file-transfer plugin](https://issues.apache.org/jira/browse/CB-13052). +What does "sunsetting" mean? In summary: + +* No more work will be done on the file-transfer plugin by the Cordova development + community. +* You can continue to use the file-transfer plugin if you wish - it should work + fine as-is for the foreseeable future. +* We highly suggest Cordova users transition to using the + [standards-compliant way of sending and receiving binary data](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data). + +All of us at Apache Cordova don't want to leave y'all hanging, though, so we +thought it'd be a good idea to show you how to use these newer XHR features to do +what file-transfer lets you do, but in a way that will work in any modern web +browser to boot! + +## Requirements + +Based on how deeply you interact with the underlying device filesystem, and on +which platforms, you may still need to rely on the +[Cordova File plugin](https://github.com/apache/cordova-plugin-file). If you +still have references to `requestFileSystem` or `root.fs` in your application's +JavaScript, you will definitely need the File plugin because these are not +standards-compliant APIs. Take note and care! + +## Platform Support + +Binary types in JavaScript, as well as the extended XHR features, are available +on the following Cordova-supported platforms without requiring any additional +plugins: + +* Android 4.4 or newer. +* iOS 10 or newer. +* Windows UWP (8.1, 10 or newer all work). +* Windows Phone 8 or newer. + +As always, check [caniuse.com](https://caniuse.com) for detailed support for the +required bits, like [`Blob`](http://caniuse.com/#feat=blobbuilder), +[Typed Arrays](http://caniuse.com/#feat=typedarrays), and +[extended XHR features](http://caniuse.com/#feat=xhr2). + +## TL;DR + +Don't care about "standards" and all that mumbo jumbo? Just looking to copy-paste --- End diff -- "Standards are great and all, but what do you actually have to copy-paste to replace the previous FileTransfer examples? We got you covered: Here's ..." > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CB-13412) Document platform specific CLI options
[ https://issues.apache.org/jira/browse/CB-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195425#comment-16195425 ] Jan Piotrowski (Sujan) commented on CB-13412: - To get them all: Google for `cordova "-- --"` and change that it searched exactly for that (Tools -> Verbatim) > Document platform specific CLI options > -- > > Key: CB-13412 > URL: https://issues.apache.org/jira/browse/CB-13412 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-docs, cordova-ios >Reporter: Jan Piotrowski (Sujan) >Assignee: Joe Bowser > > Seems `cordova build android -- --versionCode=1` is a thing and works: > https://stackoverflow.com/a/40274188/252627 > https://cordova.apache.org/docs/en/7.x/reference/cordova-cli/index.html#cordova-build-command > has: > {quote} > To provide platform specific options, you must include them > after -- separator. Review platform guide docs for more details. > {quote} > But in the "platform guide docs" I can't find anything. > [~filmaj] suggested: `--` forwards arguments to the underlying build scripts > that are present in each platform. > So these should probably investigated, inventoried and documented. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13412) Document platform specific CLI options
Jan Piotrowski (Sujan) created CB-13412: --- Summary: Document platform specific CLI options Key: CB-13412 URL: https://issues.apache.org/jira/browse/CB-13412 Project: Apache Cordova Issue Type: Improvement Components: cordova-android, cordova-docs, cordova-ios Reporter: Jan Piotrowski (Sujan) Assignee: Joe Bowser Seems `cordova build android -- --versionCode=1` is a thing and works: https://stackoverflow.com/a/40274188/252627 https://cordova.apache.org/docs/en/7.x/reference/cordova-cli/index.html#cordova-build-command has: {quote} To provide platform specific options, you must include them after -- separator. Review platform guide docs for more details. {quote} But in the "platform guide docs" I can't find anything. [~filmaj] suggested: `--` forwards arguments to the underlying build scripts that are present in each platform. So these should probably investigated, inventoried and documented. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11563) Apple Watch icons not added to Images.xcassets/AppIcon
[ https://issues.apache.org/jira/browse/CB-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195413#comment-16195413 ] Suraj Pindoria commented on CB-11563: - Fixed with https://issues.apache.org/jira/browse/CB-12896 > Apple Watch icons not added to Images.xcassets/AppIcon > -- > > Key: CB-11563 > URL: https://issues.apache.org/jira/browse/CB-11563 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 4.1.1, 4.2.0 > Environment: % cordova --version > 6.2.0 > % cordova platform ls > Installed platforms: > ios 4.1.1 >Reporter: Ricardo Panaggio > Labels: backlog, icons, ios, triaged > > Even if I add to my config file icons with the respective sizes, Apple Watch > icons aren't added as other icons do. > `config.xml` excerpt: > {code} > [...] > > /> > > > [...] > {code} > And the resulting Images.xcassets > AppIcon: > http://i.imgur.com/aGFs53N.png -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11563) Apple Watch icons not added to Images.xcassets/AppIcon
[ https://issues.apache.org/jira/browse/CB-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Pindoria closed CB-11563. --- Resolution: Fixed Fix Version/s: (was: cordova-ios@5.0.0) > Apple Watch icons not added to Images.xcassets/AppIcon > -- > > Key: CB-11563 > URL: https://issues.apache.org/jira/browse/CB-11563 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 4.1.1, 4.2.0 > Environment: % cordova --version > 6.2.0 > % cordova platform ls > Installed platforms: > ios 4.1.1 >Reporter: Ricardo Panaggio > Labels: backlog, icons, ios, triaged > > Even if I add to my config file icons with the respective sizes, Apple Watch > icons aren't added as other icons do. > `config.xml` excerpt: > {code} > [...] > > /> > > > [...] > {code} > And the resulting Images.xcassets > AppIcon: > http://i.imgur.com/aGFs53N.png -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195410#comment-16195410 ] ASF GitHub Bot commented on CB-13054: - Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/746#discussion_r143310881 --- Diff: www/_posts/2017-10-02-from-filetransfer-to-xhr2.md --- @@ -0,0 +1,175 @@ +--- +layout: post +author: +name: Fil Maj +url: https://twitter.com/filmaj +title: "Transition off of cordova-plugin-file-transfer" +categories: blog +tags: plugins +--- + +Early on in Cordova's existence, the [file-transfer plugin](https://github.com/apache/cordova-plugin-file-transfer) +was created to solve the [problem of downloading binary files](https://issues.apache.org/jira/browse/CB-22). +At the time, there weren't great options for solving this using standards-compliant +web APIs. The web took a twisty path to get to a solution (see +[Firefox's `sendAsBinary`](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/sendAsBinary) +and the now-defunct [FileSystem API](https://dev.w3.org/2009/dap/file-system/file-dir-sys.html)'s +[BlobBuilder](https://developer.mozilla.org/en-US/docs/Web/API/BlobBuilder), +among others), but today you can use our good friend [XMLHttpRequest](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest)'s +newest features, combined with some newer JavaScript types and objects, +[to solve this problem](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data). +This is an exciting moment for Cordova as the dream for this project was always +to eventually reduce the surface area of APIs the project maintains, and instead +see regular web APIs be able to handle these use cases. + +As a result, +[Cordova is sunsetting the file-transfer plugin](https://issues.apache.org/jira/browse/CB-13052). +What does "sunsetting" mean? In summary: + +* No more work will be done on the file-transfer plugin by the Cordova development + community. +* You can continue to use the file-transfer plugin if you wish - it should work + fine as-is for the foreseeable future. +* We highly suggest Cordova users transition to using the + [standards-compliant way of sending and receiving binary data](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data). + +All of us at Apache Cordova don't want to leave y'all hanging, though, so we +thought it'd be a good idea to show you how to use these newer XHR features to do +what file-transfer lets you do, but in a way that will work in any modern web +browser to boot! + +## Requirements + +Based on how deeply you interact with the underlying device filesystem, and on +which platforms, you may still need to rely on the +[Cordova File plugin](https://github.com/apache/cordova-plugin-file). If you +still have references to `requestFileSystem` or `root.fs` in your application's +JavaScript, you will definitely need the File plugin because these are not +standards-compliant APIs. Take note and care! + +## Platform Support + +Binary types in JavaScript, as well as the extended XHR features, are available +on the following Cordova-supported platforms without requiring any additional +plugins: + +* Android 4.4 or newer. +* iOS 10 or newer. +* Windows UWP (8.1, 10 or newer all work). +* Windows Phone 8 or newer. + +As always, check [caniuse.com](https://caniuse.com) for detailed support for the +required bits, like [`Blob`](http://caniuse.com/#feat=blobbuilder), +[Typed Arrays](http://caniuse.com/#feat=typedarrays), and +[extended XHR features](http://caniuse.com/#feat=xhr2). + +## TL;DR + +Don't care about "standards" and all that mumbo jumbo? Just looking to copy-paste --- End diff -- Sort of.. suggestions on how to reword? > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail:
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195399#comment-16195399 ] ASF GitHub Bot commented on CB-13054: - Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/746 I like it. > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195397#comment-16195397 ] ASF GitHub Bot commented on CB-13054: - Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/746#discussion_r143309683 --- Diff: www/_posts/2017-10-02-from-filetransfer-to-xhr2.md --- @@ -0,0 +1,175 @@ +--- +layout: post +author: +name: Fil Maj +url: https://twitter.com/filmaj +title: "Transition off of cordova-plugin-file-transfer" +categories: blog +tags: plugins +--- + +Early on in Cordova's existence, the [file-transfer plugin](https://github.com/apache/cordova-plugin-file-transfer) +was created to solve the [problem of downloading binary files](https://issues.apache.org/jira/browse/CB-22). +At the time, there weren't great options for solving this using standards-compliant +web APIs. The web took a twisty path to get to a solution (see +[Firefox's `sendAsBinary`](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/sendAsBinary) +and the now-defunct [FileSystem API](https://dev.w3.org/2009/dap/file-system/file-dir-sys.html)'s +[BlobBuilder](https://developer.mozilla.org/en-US/docs/Web/API/BlobBuilder), +among others), but today you can use our good friend [XMLHttpRequest](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest)'s +newest features, combined with some newer JavaScript types and objects, +[to solve this problem](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data). +This is an exciting moment for Cordova as the dream for this project was always +to eventually reduce the surface area of APIs the project maintains, and instead +see regular web APIs be able to handle these use cases. + +As a result, +[Cordova is sunsetting the file-transfer plugin](https://issues.apache.org/jira/browse/CB-13052). +What does "sunsetting" mean? In summary: + +* No more work will be done on the file-transfer plugin by the Cordova development + community. +* You can continue to use the file-transfer plugin if you wish - it should work + fine as-is for the foreseeable future. +* We highly suggest Cordova users transition to using the + [standards-compliant way of sending and receiving binary data](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data). + +All of us at Apache Cordova don't want to leave y'all hanging, though, so we +thought it'd be a good idea to show you how to use these newer XHR features to do +what file-transfer lets you do, but in a way that will work in any modern web +browser to boot! + +## Requirements + +Based on how deeply you interact with the underlying device filesystem, and on +which platforms, you may still need to rely on the +[Cordova File plugin](https://github.com/apache/cordova-plugin-file). If you +still have references to `requestFileSystem` or `root.fs` in your application's +JavaScript, you will definitely need the File plugin because these are not +standards-compliant APIs. Take note and care! + +## Platform Support + +Binary types in JavaScript, as well as the extended XHR features, are available +on the following Cordova-supported platforms without requiring any additional +plugins: + +* Android 4.4 or newer. +* iOS 10 or newer. +* Windows UWP (8.1, 10 or newer all work). +* Windows Phone 8 or newer. + +As always, check [caniuse.com](https://caniuse.com) for detailed support for the +required bits, like [`Blob`](http://caniuse.com/#feat=blobbuilder), +[Typed Arrays](http://caniuse.com/#feat=typedarrays), and +[extended XHR features](http://caniuse.com/#feat=xhr2). + +## TL;DR + +Don't care about "standards" and all that mumbo jumbo? Just looking to copy-paste --- End diff -- Sounds a bit snarky. Intended? > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195347#comment-16195347 ] ASF subversion and git services commented on CB-13380: -- Commit fc692355c949cac6d8adbce74d892fc7c86d2507 in cordova-cli's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=fc69235 ] CB-13380 Incremented package version to -dev > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195357#comment-16195357 ] ASF subversion and git services commented on CB-13145: -- Commit 3af9a17c92578194284698a358d7a5e84cfa0e30 in cordova-common's branch refs/heads/CB-13145 from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=3af9a17 ] Merge branch 'CB-13145' of https://github.com/stevengill/cordova-common into CB-13145-steve > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195354#comment-16195354 ] ASF subversion and git services commented on CB-13380: -- Commit e76dd52f67f46f93d51ff7fa41df74482019a9e3 in cordova-common's branch refs/heads/2.1.x from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=e76dd52 ] CB-13380 Updated version and RELEASENOTES.md for release 2.1.1 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195356#comment-16195356 ] ASF subversion and git services commented on CB-13145: -- Commit 3af9a17c92578194284698a358d7a5e84cfa0e30 in cordova-common's branch refs/heads/CB-13145 from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=3af9a17 ] Merge branch 'CB-13145' of https://github.com/stevengill/cordova-common into CB-13145-steve > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195366#comment-16195366 ] ASF subversion and git services commented on CB-13380: -- Commit 522ed6593ebec5562f36859ba5812f46b576affe in cordova-fetch's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-fetch.git;h=522ed65 ] CB-13380 Updated version and RELEASENOTES.md for release 1.2.0 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195363#comment-16195363 ] ASF subversion and git services commented on CB-13380: -- Commit e76dd52f67f46f93d51ff7fa41df74482019a9e3 in cordova-common's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=e76dd52 ] CB-13380 Updated version and RELEASENOTES.md for release 2.1.1 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195343#comment-16195343 ] ASF subversion and git services commented on CB-13380: -- Commit 128d95269fa5b73e5608a140f67073ecd66cef28 in cordova-plugman's branch refs/heads/1.5.x from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=128d952 ] CB-13380 Updated version and RELEASENOTES.md for release 1.5.1 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12747) Tools Release May 1, 2017
[ https://issues.apache.org/jira/browse/CB-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195341#comment-16195341 ] ASF subversion and git services commented on CB-12747: -- Commit ae26220abd0a9b9de3c70664e0f60c0bc72f12d1 in cordova-plugman's branch refs/heads/1.5.x from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=ae26220 ] CB-12747 Incremented package version to -dev > Tools Release May 1, 2017 > - > > Key: CB-12747 > URL: https://issues.apache.org/jira/browse/CB-12747 > Project: Apache Cordova > Issue Type: Task > Components: cordova-app-hello-world, cordova-cli, cordova-common, > cordova-create, cordova-fetch, cordova-js, cordova-lib, cordova-plugman, > cordova-serve >Reporter: Steve Gill >Assignee: Steve Gill > > Big tools release time! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195355#comment-16195355 ] ASF subversion and git services commented on CB-13145: -- Commit 8f8887e20241f2d54da9dd7a8a8cef784768a705 in cordova-common's branch refs/heads/CB-13145 from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=8f8887e ] CB-13145: added variable replacing to framework tag > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195360#comment-16195360 ] ASF subversion and git services commented on CB-13145: -- Commit a4216009e7bc7c18bccaff1bf8091d7c72b72aea in cordova-common's branch refs/heads/CB-13145 from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=a421600 ] Merge branch 'CB-13145' of https://github.com/stevengill/cordova-common into CB-13145-steve > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195365#comment-16195365 ] ASF subversion and git services commented on CB-13380: -- Commit 522ed6593ebec5562f36859ba5812f46b576affe in cordova-fetch's branch refs/heads/1.2.x from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-fetch.git;h=522ed65 ] CB-13380 Updated version and RELEASENOTES.md for release 1.2.0 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195353#comment-16195353 ] ASF subversion and git services commented on CB-13145: -- Commit 623039ff6ecb6b522dd5d6da10560cbedded8310 in cordova-common's branch refs/heads/2.1.x from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=623039f ] CB-13145 : added getFrameworks to unit tests > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195345#comment-16195345 ] ASF subversion and git services commented on CB-13380: -- Commit ab419506e4dbf0c3de1d7c75c124645863a19219 in cordova-plugman's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=ab41950 ] CB-13380 Incremented package version to -dev > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195364#comment-16195364 ] ASF subversion and git services commented on CB-13380: -- Commit 7f4e5d75b05042d40cca02adac54de72a5913d7e in cordova-common's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=7f4e5d7 ] CB-13380 Incremented package version to -dev > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195371#comment-16195371 ] ASF subversion and git services commented on CB-13380: -- Commit ba195a85438c810eac41905adc4930428ba90a24 in cordova-node-xcode's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-node-xcode.git;h=ba195a8 ] CB-13380 Incremented package version to -dev > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195348#comment-16195348 ] ASF subversion and git services commented on CB-13380: -- Commit f03c7971c257ecdf781ee2d2154b0820d5b6beee in cordova-js's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=f03c797 ] CB-13380 Updated version and RELEASENOTES.md for release 4.2.2 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195359#comment-16195359 ] ASF subversion and git services commented on CB-13145: -- Commit 7f38f6b266e683f56eb7ca980fe9fdff405b5f35 in cordova-common's branch refs/heads/CB-13145 from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=7f38f6b ] CB-13145: added variable replacing to framework tag > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195368#comment-16195368 ] ASF subversion and git services commented on CB-13380: -- Commit 53dda04aae950ab733bac3faedb25ae9d94ed3da in cordova-node-xcode's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-node-xcode.git;h=53dda04 ] CB-13380 Updated version and RELEASENOTES.md for release 1.0.0 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195370#comment-16195370 ] ASF subversion and git services commented on CB-13380: -- Commit 9345e5ed03e2118b3f5baccd96c570446406d2a2 in cordova-node-xcode's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-node-xcode.git;h=9345e5e ] CB-13380 added missing license headers > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195361#comment-16195361 ] ASF subversion and git services commented on CB-13145: -- Commit a4216009e7bc7c18bccaff1bf8091d7c72b72aea in cordova-common's branch refs/heads/CB-13145 from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=a421600 ] Merge branch 'CB-13145' of https://github.com/stevengill/cordova-common into CB-13145-steve > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195367#comment-16195367 ] ASF subversion and git services commented on CB-13380: -- Commit 4c27340a8ff75ea321c5729b276d8a15752f6117 in cordova-fetch's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-fetch.git;h=4c27340 ] CB-13380 Incremented package version to -dev > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195362#comment-16195362 ] ASF subversion and git services commented on CB-13145: -- Commit 1fe84e338c0687c6e8f2809fbc83bc60dd89a1a3 in cordova-common's branch refs/heads/CB-13145 from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=1fe84e3 ] CB-13145 : added getFrameworks to unit test > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11968) add support to config.xml
[ https://issues.apache.org/jira/browse/CB-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195358#comment-16195358 ] ASF subversion and git services commented on CB-11968: -- Commit af5c6dcddda0f96062b4d327ee75009dc1214428 in cordova-common's branch refs/heads/CB-13145 from [~Nikita Matrosov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=af5c6dc ] CB-11968: Added support for in config.xml This closes #2 > add support to config.xml > --- > > Key: CB-11968 > URL: https://issues.apache.org/jira/browse/CB-11968 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Reporter: Steve Gill >Assignee: Nikita Matrosov > Labels: tools-next > > Need a way for users to add new settings to config files from config.xml. > Lets add support to config.xml. Right now, only > works in plugin.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195342#comment-16195342 ] ASF subversion and git services commented on CB-12895: -- Commit 20c2f03ba55663dd3aebecb8558b8f2c36e1651f in cordova-plugman's branch refs/heads/1.5.x from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=20c2f03 ] CB-12895 : setup eslint and remove jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13145) Create playservices version preference in config.xml
[ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195352#comment-16195352 ] ASF subversion and git services commented on CB-13145: -- Commit c38a22093ca60373571b62525d54655a25c26dcf in cordova-common's branch refs/heads/2.1.x from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=c38a220 ] CB-13145: added variable replacing to framework tag > Create playservices version preference in config.xml > > > Key: CB-13145 > URL: https://issues.apache.org/jira/browse/CB-13145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@7.2.0 > > > We are seeing an issue in the community of two plugins using different > versions of google play services. This causes gradle to error out. We are > running into this with the phonegap-push-plugin. > Potential solution: > We could create an Android only preference called PlayServicesVersion in > config.xml which would control the version of Play Services used for the > entire project. > In config.xml: > {code} > > {code} > Then if the push plugin wanted to include the FCM libraries in it's > plugin.xml it would do: > > and the cordova-plugin-google-analytics wanted to include Play Services in > it's plugin.xml it would do: > {code} > src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" /> > {code} > they would both use the same version of Play Services. This gets around the > problem of plugins using + in the framework tag and having two plugins pin > different versions of Play Services. > The + wildcard fails to compile with the following error: > {code} > > Failed to apply plugin [id 'com.google.gms.google-services'] >> For input string: "+" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195349#comment-16195349 ] ASF subversion and git services commented on CB-13380: -- Commit ff66178b108b93be36a1aafe341af17381a727a3 in cordova-js's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=ff66178 ] CB-13380 Incremented package version to -dev > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195346#comment-16195346 ] ASF subversion and git services commented on CB-13380: -- Commit cc5cb8a6e81c55d11425f3d6ce6a5e62e06e36a3 in cordova-cli's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=cc5cb8a ] CB-13380 Updated version and RELEASENOTES.md for release 7.1.0 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13231) Cordova-Common@2.1.0 Release August 30, 2017
[ https://issues.apache.org/jira/browse/CB-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195351#comment-16195351 ] ASF subversion and git services commented on CB-13231: -- Commit 3d4602af9c69727fe6cefdb5dbec74fa56ad2b51 in cordova-common's branch refs/heads/2.1.x from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=3d4602a ] CB-13231 Incremented package version to -dev > Cordova-Common@2.1.0 Release August 30, 2017 > > > Key: CB-13231 > URL: https://issues.apache.org/jira/browse/CB-13231 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 2.1.0 >Reporter: Audrey So >Assignee: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195344#comment-16195344 ] ASF subversion and git services commented on CB-13380: -- Commit 128d95269fa5b73e5608a140f67073ecd66cef28 in cordova-plugman's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=128d952 ] CB-13380 Updated version and RELEASENOTES.md for release 1.5.1 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195338#comment-16195338 ] ASF subversion and git services commented on CB-13380: -- Commit c0689eccab5aca689a662cc715eabc39d5a710e3 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c0689ec ] CB-13380 Updated version and RELEASENOTES.md for release 7.1.0 > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195339#comment-16195339 ] ASF subversion and git services commented on CB-13380: -- Commit 1a8c8abb77e8679eee399b8713b72ba3e08d9bf5 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=1a8c8ab ] CB-13380: updated integration tests to work with new pinned platforms > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13380) Tools Release Oct 2, 2017
[ https://issues.apache.org/jira/browse/CB-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195340#comment-16195340 ] ASF subversion and git services commented on CB-13380: -- Commit f96e0adf784e50802762403a582971bb14fb5d28 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f96e0ad ] CB-13380 Incremented package version to -dev > Tools Release Oct 2, 2017 > - > > Key: CB-13380 > URL: https://issues.apache.org/jira/browse/CB-13380 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md; -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13411) The launch screen storyboard (splash screen) has a white safe area on the bottom ONLY on iPhone X, iOS 11
[ https://issues.apache.org/jira/browse/CB-13411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Lazzarotto updated CB-13411: --- Summary: The launch screen storyboard (splash screen) has a white safe area on the bottom ONLY on iPhone X, iOS 11 (was: The launcher storyboard (splash screen) has a white safe area on the bottom ONLY on iPhone X, iOS 11) > The launch screen storyboard (splash screen) has a white safe area on the > bottom ONLY on iPhone X, iOS 11 > - > > Key: CB-13411 > URL: https://issues.apache.org/jira/browse/CB-13411 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: {{cordova-ios}} 4.5.0 or 4.5.1 and > {{cordova-plugin-splashscreen}} >Reporter: Andrea Lazzarotto >Assignee: Suraj Pindoria >Priority: Minor > Labels: easyfix > Original Estimate: 5m > Remaining Estimate: 5m > > The splash screen used by {{cordova-plugin-splashscreen}} uses the > {{CDVLaunchScreen.storyboard}} file from {{cordova-ios}}. On the iPhone X > emulator with iOS11, this shows a white "safe area inset" *only on the bottom > margin* (not on the top). > The splash screen should be immersive both on top and on the bottom, > therefore the storyboard should be fixed. I use this simple replacement in a > hook to patch {{cordova-ios}} after {{cordova prepare}}: > {code} > NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')" > sed -i '' 's_secondItem="xb3-aO-Qok" > secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' > "$NAME" > {code} > Basically one constraint on the storyboard needs to be updated. It should be > trivial to fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13411) The launcher storyboard (splash screen) has a white safe area on the bottom ONLY on iPhone X, iOS 11
Andrea Lazzarotto created CB-13411: -- Summary: The launcher storyboard (splash screen) has a white safe area on the bottom ONLY on iPhone X, iOS 11 Key: CB-13411 URL: https://issues.apache.org/jira/browse/CB-13411 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Affects Versions: cordova-ios 4.5.0 Environment: {{cordova-ios}} 4.5.0 or 4.5.1 and {{cordova-plugin-splashscreen}} Reporter: Andrea Lazzarotto Assignee: Suraj Pindoria Priority: Minor The splash screen used by {{cordova-plugin-splashscreen}} uses the {{CDVLaunchScreen.storyboard}} file from {{cordova-ios}}. On the iPhone X emulator with iOS11, this shows a white "safe area inset" *only on the bottom margin* (not on the top). The splash screen should be immersive both on top and on the bottom, therefore the storyboard should be fixed. I use this simple replacement in a hook to patch {{cordova-ios}} after {{cordova prepare}}: {code} NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')" sed -i '' 's_secondItem="xb3-aO-Qok" secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' "$NAME" {code} Basically one constraint on the storyboard needs to be updated. It should be trivial to fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13399) White status bar in iOs 11
[ https://issues.apache.org/jira/browse/CB-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195148#comment-16195148 ] Kevin Ryan commented on CB-13399: - currently it seems like this isn't going well on any side, hoping that you guys are able to solve around the issue with UIWebView. this has been fixed in WKWebView https://github.com/ionic-team/ionic/issues/12958#issuecomment-333874645 > White status bar in iOs 11 > -- > > Key: CB-13399 > URL: https://issues.apache.org/jira/browse/CB-13399 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-statusbar >Affects Versions: cordova-ios@4.3.1 > Environment: Application made with Phonegap + framework 7 > Phonegap Build versions: > cli-6.5.0 > ios-4.3.1 >Reporter: Artur Shagimardanov > > Using > Problem with status bar. It' always white and I can't change its' color or > overlay in iOs 11 with params: > > > !https://image.prntscr.com/image/wJPH_-WURZ_yf1g5DinSQg.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195137#comment-16195137 ] ASF GitHub Bot commented on CB-13054: - Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/746 I made a bunch of changes to it @macdonst @janpio. Also explicitly called out support for Windows and eliminated any links to my xhr test app as per feedback from @purplecabbage. > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[ https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194985#comment-16194985 ] Suraj Pindoria commented on CB-13382: - Submitted PR for this: https://github.com/apache/cordova-ios/pull/342 > Cordova iOS - Method to correctly destroy CDVViewControllers webView object > --- > > Key: CB-13382 > URL: https://issues.apache.org/jira/browse/CB-13382 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Nick Deakin >Assignee: Suraj Pindoria >Priority: Minor > > We have an app where we are using multi CDVViewController instances where a > user can switch between hybrid apps within the native app. > The issue that as been lingering for a couple of years is that even though a > CDVViewController instance can be set to nil, the webview contained within > still remains in memory. This can be observed when using the safari debugger. > This is particularly troublesome when the webview is 'closed', then the > content files in the webview are updated, and finally the webview is > recreated, showing the old content. Performing a cmd-r in safari debugger > refreshes the view and shows the updated content. > We can also do this a [UIWebView reload], but it is not possible if the app > changes it's URL to a none physical path, e.g. > file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then > we get a page load error. > I've been able to get the webview completely removed by doing the following: > add the following method to CDVViewController: > {code:java} > -(void)destroyWebView { > self.webViewEngine = nil; > } > {code} > then in my view controllers destroy method: > {code:java} > [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil]; > [self.pluginObjects removeAllObjects]; > [self.webView removeFromSuperview]; > [self destroyWebView]; > {code} > Setting webViewEngine to nil is an unavoidable step to completely destroying > the webview, but it is readonly. > Therefore, i would really appreciate this destroyWebView method, or a similar > cleanup method being added. > Android has a method to clean up which is CordovaWebViewImpl.handleDestroy(). > This destroys all the plugins, sets the URL to 'about:blank' and then > executes engine.destroy() > Many thanks! > Nick -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12626) Splashscreen crashing on Samsung devices, not rendering on others
[ https://issues.apache.org/jira/browse/CB-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-12626. - Resolution: Fixed > Splashscreen crashing on Samsung devices, not rendering on others > - > > Key: CB-12626 > URL: https://issues.apache.org/jira/browse/CB-12626 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-splashscreen > Environment: Crashing devices: > - Samsung Galaxy 7 Edge, Android 7.0 > - Samsung Galaxy Note 4, Android 6.0.1 > "Not showing" devices: > - Lenovo/Zuk Z1, Android 5.1.1 > - Official Android Emulator with Nexus S simulated hardware, API 25 >Reporter: Andrea Lazzarotto >Assignee: Joe Bowser > Labels: android, android-next > > We tested the plugin on a few Samsung devices and found out that the current > version of the splash screen plug-in is completely crashing the app, with an > error given by {{AndroidRuntime}} (including the PID of the app) and a > warning given by {{ActivityManager}} in the log: > {{Force finishing activity packagename/.MainActivity}} > Moreover, we noticed that the splash screen is not showing correctly on some > devices. The Samsung crash was initially solved by commenting out this line: > {{preferences.set("SplashDrawableId", drawableId);}} > Basically, this means that storing the {{drawableId}} in the preferences is > not reliable. This didn't solve the display issue on other devices, which > required refactoring the code that reads the resource ID. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12626) Splashscreen crashing on Samsung devices, not rendering on others
[ https://issues.apache.org/jira/browse/CB-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194831#comment-16194831 ] ASF GitHub Bot commented on CB-12626: - Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 OK, it's in. Thanks for contributing. > Splashscreen crashing on Samsung devices, not rendering on others > - > > Key: CB-12626 > URL: https://issues.apache.org/jira/browse/CB-12626 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-splashscreen > Environment: Crashing devices: > - Samsung Galaxy 7 Edge, Android 7.0 > - Samsung Galaxy Note 4, Android 6.0.1 > "Not showing" devices: > - Lenovo/Zuk Z1, Android 5.1.1 > - Official Android Emulator with Nexus S simulated hardware, API 25 >Reporter: Andrea Lazzarotto >Assignee: Joe Bowser > Labels: android, android-next > > We tested the plugin on a few Samsung devices and found out that the current > version of the splash screen plug-in is completely crashing the app, with an > error given by {{AndroidRuntime}} (including the PID of the app) and a > warning given by {{ActivityManager}} in the log: > {{Force finishing activity packagename/.MainActivity}} > Moreover, we noticed that the splash screen is not showing correctly on some > devices. The Samsung crash was initially solved by commenting out this line: > {{preferences.set("SplashDrawableId", drawableId);}} > Basically, this means that storing the {{drawableId}} in the preferences is > not reliable. This didn't solve the display issue on other devices, which > required refactoring the code that reads the resource ID. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13410) Improve CLI help text
[ https://issues.apache.org/jira/browse/CB-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194816#comment-16194816 ] Jan Piotrowski (Sujan) commented on CB-13410: - It would be awesome to have a documentation page that writes down all the individual steps and shows in a visual way what command combines which elements. For the `build` example: {code} prepare \ } build compile / {code} > Improve CLI help text > - > > Key: CB-13410 > URL: https://issues.apache.org/jira/browse/CB-13410 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Filip Maj > Labels: tools-next > > - the [prepare help > text|https://github.com/apache/cordova-cli/blob/master/doc/prepare.txt] does > not mention that config.xml properties are interpolated from the xml file and > into proper native project structure / locations / format. should it link to > config.xml documentation on docs.cordova.io? > - the [run help > text|https://github.com/apache/cordova-cli/blob/master/doc/run.txt] mentions, > vaguely, what happens when you execute the command, but it could be clearer, > and it is burried all the way down under the 'technical details' section. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13410) Improve CLI help text
Filip Maj created CB-13410: -- Summary: Improve CLI help text Key: CB-13410 URL: https://issues.apache.org/jira/browse/CB-13410 Project: Apache Cordova Issue Type: Improvement Components: cordova-cli Reporter: Filip Maj - the [prepare help text|https://github.com/apache/cordova-cli/blob/master/doc/prepare.txt] does not mention that config.xml properties are interpolated from the xml file and into proper native project structure / locations / format. should it link to config.xml documentation on docs.cordova.io? - the [run help text|https://github.com/apache/cordova-cli/blob/master/doc/run.txt] mentions, vaguely, what happens when you execute the command, but it could be clearer, and it is burried all the way down under the 'technical details' section. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steinar Ágúst Steinarsson updated CB-13409: --- Description: I added a couple of customizations to inappbrowser's toolbar: *Android*: -Have a custom text for a close button instead of the Default X: closebuttoncaption: "set to a string to use as the close buttons caption instead of a X. Note that you need to localize this value yourself." -Change the close button color: closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the close button color from default, regardless of being a text or default X. Only has effect if user has location set to `yes`." -Hide the navigation buttons that go backwards and forwards: hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the location toolbar, only has effect if user has location set to `yes`. The default value is `no`." -Change navigation buttons color: navigationbuttoncolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the color of both navigation buttons from default. Only has effect if user has location set to `yes` and not hidenavigationbuttons set to `yes`." -Change color of toolbar: toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the color the toolbar from default. Only has effect if user has location set to `yes`." *iOS:* closebuttoncolor(same as above) hidenavigationbuttons(same as above) toolbarcolor(same as above) -Make toolbar non-translucent: toolbartranslucent: "set to `yes` or `no` to make the toolbar translucent(semi-transparent) (defaults to `yes`). Only applicable if toolbar is not disabled." was: I added a couple of customizations to inappbrowser's toolbar: *Android*: -Have a custom text for a close button instead of the Default X: closebuttoncaption: "set to a string to use as the close buttons caption instead of a X. Note that you need to localize this value yourself." -Change the close button color: closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the close button color from default, regardless of being a text or default X. Only has effect if user has location set to `yes`." -Hide the navigation buttons that go backwards and forwards: hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the location toolbar, only has effect if user has location set to `yes`. The default value is `no`." -Change navigation buttons color: navigationbuttoncolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the color of both navigation buttons from default. Only has effect if user has location set to `yes` and not hidenavigationbuttons set to `yes`." -Change color of toolbar: toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the color the toolbar from default. Only has effect if user has location set to `yes`." *iOS:* closebuttoncolor(same as above) hidetoolbarnavigationbuttons(same as above) toolbarcolor(same as above) -Make toolbar non-translucent: toolbartranslucent: "set to `yes` or `no` to make the toolbar translucent(semi-transparent) (defaults to `yes`). Only applicable if toolbar is not disabled." > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Original Estimate: 8h > Remaining Estimate: 8h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > -Have a custom text for a close button instead of the Default X: > closebuttoncaption: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > -Change the close button color: > closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, > and it will change the > close button color from default, regardless of being a text or default X. > Only has effect if user has location set to `yes`." > -Hide the navigation buttons that go backwards and forwards: > hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > -Change navigation buttons color: > navigationbuttoncolor: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect
[jira] [Created] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
Steinar Ágúst Steinarsson created CB-13409: -- Summary: Allow more additional options, for customizing toolbar in cordova/inappbrowser Key: CB-13409 URL: https://issues.apache.org/jira/browse/CB-13409 Project: Apache Cordova Issue Type: Improvement Components: cordova-plugin-inappbrowser Environment: iOS, Android Reporter: Steinar Ágúst Steinarsson Priority: Minor I added a couple of customizations to inappbrowser's toolbar: *Android*: -Have a custom text for a close button instead of the Default X: closebuttoncaption: "set to a string to use as the close buttons caption instead of a X. Note that you need to localize this value yourself." -Change the close button color: closebuttoncolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the close button color from default, regardless of being a text or default X. Only has effect if user has location set to `yes`." -Hide the navigation buttons that go backwards and forwards: hidenavigationbuttons: "set to `yes` to hide the navigation buttons on the location toolbar, only has effect if user has location set to `yes`. The default value is `no`." -Change navigation buttons color: navigationbuttoncolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the color of both navigation buttons from default. Only has effect if user has location set to `yes` and not hidenavigationbuttons set to `yes`." -Change color of toolbar: toolbarcolor: "set to a valid hex color string, for example: `#00ff00`, and it will change the color the toolbar from default. Only has effect if user has location set to `yes`." *iOS:* closebuttoncolor(same as above) hidetoolbarnavigationbuttons(same as above) toolbarcolor(same as above) -Make toolbar non-translucent: toolbartranslucent: "set to `yes` or `no` to make the toolbar translucent(semi-transparent) (defaults to `yes`). Only applicable if toolbar is not disabled." -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194729#comment-16194729 ] ASF GitHub Bot commented on CB-13396: - Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/135 Actually, the code of this plugin need not be changed. However, the `cordova-ios` template needs a fix. I am using `cordova-ios@4.5.1` and I've added this to my `hooks/after_prepare/` directory: ``` NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')" sed -i '' 's_secondItem="xb3-aO-Qok" secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' "$NAME" ``` Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If this is fixed, nothing else needs to be changed. > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194719#comment-16194719 ] ASF GitHub Bot commented on CB-13054: - Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/746 Thanks guys ;) Thing is if you do more than your PoC app that covers the standard usecase (like e.g. putting it as a library on Github, installable via npm, which people can use as a drop in replacement, fork and contribute their own more complicated use cases) you have to maintain that one, accept PRs etc - which kind of misses the point of sunsetting the plugin ;) But having the TLDR more accessible like you suggested in https://github.com/apache/cordova-docs/pull/746#issuecomment-334767623 sure would go a long way. Many people use this plugin via the Ionic Native wrapper in Ionic/Angular, [no idea yet what will happen there](https://github.com/ionic-team/ionic-native/issues/2026) (as it is also community maintained). > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194694#comment-16194694 ] ASF GitHub Bot commented on CB-13054: - Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/746 @janpio that makes sense. Us as cordova committers probably have way more context around what sunsetting means because we've been talking about it for months! I will take a stab at rewriting that part. Also curious to hear your thoughts about the code examples. Are links to my PoC app good enough, or do we want something more fleshed out? I don't want to half-ass this :) > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194690#comment-16194690 ] ASF GitHub Bot commented on CB-13054: - Github user macdonst commented on the issue: https://github.com/apache/cordova-docs/pull/746 @janpio I think your English is great and I kinda want _"we stop future development as it works just fine right now, for the future a better standard alternative is here that can replace all this stuff (and is maintained by the browser directly!). so you don't need this any more, but feel free to keep using it."_ on a t-shirt > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194686#comment-16194686 ] Ahmad Tawakol commented on CB-12886: Yes, with the viewport-fit tag > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194687#comment-16194687 ] ASF GitHub Bot commented on CB-13054: - Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/746 To be honest to me in practice "sunsetting" or "deprecating" never is really clear - even if I theoretically know what it means. My thoughts when reading: Does it mean I have to change my stuff now? That it's broken? That something doesn't or won't work? What does "no more maintance" (or something similar) really mean? Now I know it just means "we stop future development as it works just fine right now, for the future a better standard alternative is here that can replace all this stuff (and is maintained by the browser directly!). so you don't need this any more, but feel free to keep using it.". > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194683#comment-16194683 ] Artur Shagimardanov commented on CB-12886: -- [~twkl] I need to try those plugins + "viewport-fit=cover"? Because I already try "cordova-plugin-disable-ios11-statusbar" but without "viewport-fit=cover" and it's doesn't solve the problem. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194678#comment-16194678 ] Ahmad Tawakol commented on CB-12886: Try one of these plugins (both should do the same thing): https://github.com/jcesarmobile/cordova-plugin-disable-ios11-statusbar https://www.npmjs.com/package/cordova-plugin-ios11-inset-statusbar > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13390) Clarify documentation on plugin.xml -> framework -> gradleReference
[ https://issues.apache.org/jira/browse/CB-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13390. - Resolution: Fixed > Clarify documentation on plugin.xml -> framework -> gradleReference > --- > > Key: CB-13390 > URL: https://issues.apache.org/jira/browse/CB-13390 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Minor > > Wording is not 100% clear at the moment. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194663#comment-16194663 ] ASF GitHub Bot commented on CB-13054: - Github user macdonst commented on the issue: https://github.com/apache/cordova-docs/pull/746 @janpio yup, I feel like that is a good summary. > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194643#comment-16194643 ] Artur Shagimardanov commented on CB-12886: -- [~twkl] thank you, I add this parametr, so now line looks like In phonegap test app it's ok. If make a build and test on iphone 7 with ios 11, problem still exists =\ > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194638#comment-16194638 ] ASF GitHub Bot commented on CB-13054: - Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/746 @macdonst sounds good, once this gets the thumbs up I'll change the date to make it the day-of. @janpio yeah, the helpers.js file bits are supposed to be drop-in replacements, but only for the most common uses of the file-transfer plugin. The plugin supports many options - this would be a long post if we wanted to cover everything. That said, I'm open to adding or changing the post to address your concern. I could potentially change the "TL;DR" section to instead just be drop-in replacements for the main `upload` and `download` methods, and write XHR-based equivalents for [the main examples for these methods that exit in our docs](https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-file-transfer/index.html#example). Should we call out the fact that there will be no more work done on the file transfer plugin? I thought that was implied when I mentioned we were sunsetting it. > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194617#comment-16194617 ] Ahmad Tawakol commented on CB-12886: Add {noformat}viewport-fit=cover{noformat} to your meta tag in the index.html file. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194612#comment-16194612 ] ASF GitHub Bot commented on CB-13054: - Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/746 Ok, so let's see if I got it right: - There will be no more dev work on the plugin as there is now a standard alternative. - There is no pressure on switching to the standard as this all works just fine right now. - Only in the future with new releases of iOS or Android it might break. - Switching from this to the standard is a bit of work _right now_, but could be simplified a lot if someone did a wrapper for it that uses the same API as the plugin. All correct? > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194582#comment-16194582 ] ASF GitHub Bot commented on CB-13054: - Github user macdonst commented on the issue: https://github.com/apache/cordova-docs/pull/746 @janpio where the plugins are not quite spec complaint we will be updating the plugins to match current standards. In the case of the FileTransfer plugin which was created out of necessity and doesn't follow any spec we are not providing backward compatibility. Even though we won't be doing anything with the plugin in the future it will still continue to work for folks. If one of the community members wants to take on a wrapper lib that would be something I'd support. > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194556#comment-16194556 ] ASF GitHub Bot commented on CB-13054: - Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/746 I (unfairly) expected it to be a post with "replace `upload` with this code, replace `download` with this code", maybe even an API identical implementation of the new stuff. Is your [`helpers.js` file](https://github.com/filmaj/xhr2test/blob/master/www/js/helpers.js) something like this? > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13332) iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription
[ https://issues.apache.org/jira/browse/CB-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194510#comment-16194510 ] ASF GitHub Bot commented on CB-13332: - Github user mino922 commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/289 To use this, you must add to your config.xml `` > iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription > -- > > Key: CB-13332 > URL: https://issues.apache.org/jira/browse/CB-13332 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: iOS 11 >Reporter: Sam Mino >Priority: Blocker > > I am using this plugin to take a picture, but in iOS11 I receive the > following error: > * > _This app has crashed because it attempted to access privacy-sensitive data > without a usage description. The app's Info.plist must contain an > NSPhotoLibraryAddUsageDescription key with a string value explaining to the > user how the app uses this data._* > _Note: I have descriptions for CAMERA_USAGE_DESCRIPTION and > PHOTOLIBRARY_USAGE_DESCRIPTION. I was able to take a picture in iOS 10._ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13054) Write blog post on how to transition from file-transfer to XHR2
[ https://issues.apache.org/jira/browse/CB-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194499#comment-16194499 ] ASF GitHub Bot commented on CB-13054: - Github user macdonst commented on the issue: https://github.com/apache/cordova-docs/pull/746 @filmaj looks good to me other than the file name. Does `2017-10-02` mean it will show up in the past on the blog? Maybe update that to the day you publish? > Write blog post on how to transition from file-transfer to XHR2 > --- > > Key: CB-13054 > URL: https://issues.apache.org/jira/browse/CB-13054 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-file-transfer >Reporter: Filip Maj >Assignee: Filip Maj > Labels: plugins-next > > Based on XHR2 research (see linked-to JIRA issue), write up a blog post! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194495#comment-16194495 ] Artur Shagimardanov commented on CB-12886: -- Hello! Maybe anyone know how to fix this problem? Application made with Phonegap + framework 7 Phonegap Build versions: cli-6.5.0 ios-4.3.1 Using Problem with status bar. It' always white and I can't change its' color or overlay in iOs 11 with params: !https://image.prntscr.com/image/wJPH_-WURZ_yf1g5DinSQg.png! Thank you. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13408) Improve navigation entry for InAppBrowser
Jan Piotrowski (Sujan) created CB-13408: --- Summary: Improve navigation entry for InAppBrowser Key: CB-13408 URL: https://issues.apache.org/jira/browse/CB-13408 Project: Apache Cordova Issue Type: Bug Components: cordova-docs Reporter: Jan Piotrowski (Sujan) Priority: Trivial https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-inappbrowser/, navigation entry is "Inappbrowser" instead of expected "InAppBrowser" -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org